--- Log opened Sat Jul 06 00:00:40 2013
20130706 00:01:53-!- R2D2C3PO [57a1731a@gateway/web/freenode/ip.87.161.115.26] has quit [Quit: Page closed]
20130706 00:13:47-!- siriusbtx [~siriusbtx@94-226-44-183.access.telenet.be] has left #wesnoth-dev []
20130706 00:15:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20130706 00:20:18-!- mjs-de [~mjs-de@g224179063.adsl.alicedsl.de] has quit [Remote host closed the connection]
20130706 00:46:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20130706 00:58:57-!- Upthorn [~ogmar@adsl-108-82-44-238.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 264 seconds]
20130706 01:01:17-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: ttyl]
20130706 01:08:43-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20130706 01:16:01-!- Blueblaze [~Blueblaze@ip68-3-135-148.ph.ph.cox.net] has quit [Quit: Blueblaze]
20130706 02:15:41-!- irker674 [~irker@ai0867.net] has joined #wesnoth-dev
20130706 02:15:41< irker674> wesnoth: Ignacio R. Morelle wesnoth-old:master 0835b357929b / src/ (unit_display.cpp unit_display.hpp): display: Allow forcing viewport scrolling when moving units http://git.io/RjikNA
20130706 02:15:44< irker674> wesnoth: Ignacio R. Morelle wesnoth-old:master 62a2789cb28a / changelog src/game_events.cpp: Add [move_unit_fake] force_scroll attribute, defaults to 'yes' http://git.io/3UrwZA
20130706 02:15:47< irker674> wesnoth: Ignacio R. Morelle wesnoth-old:master f6cc3acbaf85 / changelog data/lua/wml-tags.lua: Add [move_unit] force_scroll attribute http://git.io/xxqeew
20130706 02:19:04-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection]
20130706 02:22:40-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130706 02:29:22-!- mattsc [~mattsc@d154-20-34-165.bchsia.telus.net] has joined #wesnoth-dev
20130706 02:32:30-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev
20130706 02:34:41-!- Blueblaze [~Blueblaze@ip68-3-135-148.ph.ph.cox.net] has joined #wesnoth-dev
20130706 02:42:39-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20130706 02:51:39-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20130706 02:51:39-!- Upth is now known as Upthorn
20130706 03:09:41-!- iwontbecreative [~thibault@89-180-77-154.net.novis.pt] has joined #wesnoth-dev
20130706 03:09:47< iwontbecreative> Hi
20130706 03:09:59< iwontbecreative> Is there someone that can update the website ?
20130706 03:10:51< iwontbecreative> There's an XSS (non-persistent) in gettext.wesnoth.com
20130706 03:10:55< iwontbecreative> http://www.wesnoth.org/gettext/?package=%3Ci%3E%3Ch1%3EXSS%3Ca%20href='http://www.meansite.com'%3EHEY%20CLICK%20HERE%20%3C/a%3E&order=trans&version=branch
20130706 03:11:49< iwontbecreative> Don't worry that link is harmless, but since it filters neither '<>' nor ' " " ' an attacker could do a lot of things.
20130706 03:25:21-!- iwontbecreative [~thibault@89-180-77-154.net.novis.pt] has quit [Ping timeout: 264 seconds]
20130706 03:27:05-!- iwontbecreative [~thibault@89-180-77-154.net.novis.pt] has joined #wesnoth-dev
20130706 03:27:13-!- iwontbecreative [~thibault@89-180-77-154.net.novis.pt] has left #wesnoth-dev []
20130706 03:27:18-!- iwontbecreative [~thibault@89-180-77-154.net.novis.pt] has joined #wesnoth-dev
20130706 03:30:42< shadowm> iwontbecreative: Could you elaborate in a private bug report in bugs.wesnoth.org?
20130706 03:31:05< shadowm> If you have a patch that would be even better.
20130706 03:31:19< iwontbecreative> Shadowm : I can do a quick patch but it will be hard to test it
20130706 03:31:31< iwontbecreative> Don't have anything to run php on my laptop
20130706 03:31:42< shadowm> Well, I don't know how gettext.w.o and the one person I know who does ( AI0867 ) is unavailable.
20130706 03:31:51< iwontbecreative> It's a one-liner patch
20130706 03:31:52< shadowm> *gettext.w.o works
20130706 03:36:30< shadowm> For an extended period of time, may I add, hence the bug report suggestion.
20130706 03:37:06< iwontbecreative> I don't get what you mean :/
20130706 03:37:14< iwontbecreative> Sure it works, but there's a security issue
20130706 03:37:39< shadowm> I understand that but I don't know the target codebase at all so I can't fix it.
20130706 03:37:47< iwontbecreative> Ah
20130706 03:37:54< iwontbecreative> I can fix it I believe
20130706 03:37:59< iwontbecreative> But can't test it
20130706 03:38:06< iwontbecreative> Atm
20130706 03:38:21< shadowm> And what would the one-liner be?
20130706 03:39:30< iwontbecreative> -       $package = $_GET['package'];
20130706 03:39:30< iwontbecreative> +       $package = htmlspecialchars($_GET['package'], ENT_QUOTES, 'UTF-8');
20130706 03:40:08< shadowm> Could you provide me with a real patch?
20130706 03:41:52< iwontbecreative> http://pastebin.com/zMpdZ1bW
20130706 03:42:41< shadowm> The thing is that there's actually four lines like $package = $_GET['package']; in the directory.
20130706 03:42:58< iwontbecreative> Hmmm
20130706 03:43:13< iwontbecreative> So they probably need to be all changed
20130706 03:43:25< iwontbecreative> I didn't want to do a commit before I could test it
20130706 03:43:37< shadowm> I'll change the live copy.
20130706 03:44:45< shadowm> Which is a bit hard to do through a slow SSH link.
20130706 03:46:44< iwontbecreative> Would be nice
20130706 03:48:00< shadowm> Okay, applied.
20130706 03:48:21< iwontbecreative> shadowm : I think the whole tool might need some security fixes 
20130706 03:48:27< iwontbecreative> http://www.wesnoth.org/gettext/?version=bob%22%3E%3Ch1%3EHI&package=alloff
20130706 03:48:38< iwontbecreative> I believe no paramater is checked
20130706 03:49:30< iwontbecreative> But the change did indeed fix the first XSS
20130706 03:49:49< shadowm> Well, it should be just matter of writing a wrapper for $_GET queries that returns a cleaned-up string.
20130706 03:50:01< iwontbecreative> So at least we know how to fix the issues in spite of my low understanding of php
20130706 03:50:22< iwontbecreative> shadowm : Probably, never coded in php
20130706 03:50:40< shadowm> Okay, I kind of assumed you knew what you were doing. :p
20130706 03:50:53< iwontbecreative> Well, I checked the references on the web
20130706 03:50:59< iwontbecreative> The documentation
20130706 03:51:20< shadowm> (Don't worry, I do know some PHP, so I would have been able to tell if you were tricking me into doing something ridiculous.)
20130706 03:51:21< iwontbecreative> I know what the change I told you does, not how to write a wrapper :p
20130706 03:52:01< iwontbecreative> shadowm : Yeah I guessed you wouldn't apply a change if you didn't understand it before ^^
20130706 03:52:16< iwontbecreative> Or didn't have the confirmation from someone more trustworthy :p
20130706 03:52:35< shadowm> I'm faced with the unexpected challenge of dealing with a Subversion repository that I _believe_ is locked.
20130706 03:53:18< shadowm> So not sure whether I'll be able to commit it or I'll have to just apply the patch manually.
20130706 03:55:01< iwontbecreative> shadowm : My understanding of subversion is just about as good as my understanding of php so I can't really help you.
20130706 03:59:57< irker674> wesnoth: shadowmaster * r56598 /website/gettext.wesnoth.org/ (index.lang.php index.php functions.php index.extra.php): 
20130706 03:59:58< irker674> wesnoth: gettext.wesnoth.org: Clean-up GET parameters for possible XSS exploits
20130706 04:00:26< shadowm> And the commit went through.
20130706 04:00:29< iwontbecreative> Good job !
20130706 04:01:07< shadowm> iwontbecreative: Thanks for the fix idea.
20130706 04:01:16-!- Octalot [~noct@host86-128-72-64.range86-128.btcentralplus.com] has quit []
20130706 04:01:46< iwontbecreative> shadowm : No problem :)
20130706 04:03:45-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 264 seconds]
20130706 04:07:43< irker674> wesnoth: Thibault Févry wesnoth-old:master 39e300ac728d / data/tools/README: Indicate the right wiki page in terrain2wiki.py doc and fix typos. http://git.io/t3piig
20130706 04:09:07-!- Ivanovic_ [~ivanovic@x2f437fb.dyn.telefonica.de] has joined #wesnoth-dev
20130706 04:12:14-!- Ivanovic_ [~ivanovic@x2f437fb.dyn.telefonica.de] has quit [Changing host]
20130706 04:12:14-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20130706 04:12:16< irker674> wesnoth: Thibault Févry wesnoth-old:master c289f6608bfb / data/tools/ (imgcheck trackplacer): Fix typos in comments http://git.io/PJpBHg
20130706 04:12:17-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 248 seconds]
20130706 04:13:10-!- Ivanovic_ is now known as Ivanovic
20130706 04:13:14< mattsc> In case anybody is interested, I figured out my path finding custom cost function problem.  Turns out that the lines dealing with negative remaining movement (712-713) here: https://github.com/wesnoth/wesnoth-old/blob/master/src/pathfind/pathfind.cpp#L712
20130706 04:14:01< mattsc> ... are generally important, not just in special cases.  I thought they didn't apply in my situation, but that just shows that I don't know well enough how the A* search works.
20130706 05:28:42-!- Gambit [~quassel@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20130706 05:32:54< iwontbecreative> Off for tonight, good night
20130706 05:33:00-!- iwontbecreative [~thibault@89-180-77-154.net.novis.pt] has quit [Quit: leaving]
20130706 05:41:07-!- Blueblaze [~Blueblaze@ip68-3-135-148.ph.ph.cox.net] has quit [Quit: Blueblaze]
20130706 05:46:48-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130706 06:09:42< irker674> wesnoth: mattsc wesnoth-old:master b103ded11831 / data/ai/micro_ais/ais/micro_ais_wml_tags.lua: [micro_ai] tag setup: fix eval/exec function name assignment when ca_id= key is  http://git.io/CXff7Q
20130706 06:27:09-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 264 seconds]
20130706 06:28:21-!- ancestral [~ancestral@75-161-180-197.mpls.qwest.net] has joined #wesnoth-dev
20130706 06:31:41-!- SigurdFD [SigurdFD@24.154.98.89] has joined #wesnoth-dev
20130706 06:37:55-!- ancestral [~ancestral@75-161-180-197.mpls.qwest.net] has quit [Quit: Smell ya later!]
20130706 06:41:40-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 276 seconds]
20130706 07:03:20-!- mattsc [~mattsc@d154-20-34-165.bchsia.telus.net] has quit [Quit: ttyl]
20130706 07:08:53-!- Guest14645 [~quassel@f050094237.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20130706 07:11:05-!- Crendgrim [~quassel@g224213094.adsl.alicedsl.de] has joined #wesnoth-dev
20130706 07:12:55-!- SigurdFD [SigurdFD@24.154.98.89] has quit []
20130706 07:29:51-!- skyfaller [~skyfaller@c-75-67-154-18.hsd1.ma.comcast.net] has joined #wesnoth-dev
20130706 07:29:52-!- skyfaller [~skyfaller@c-75-67-154-18.hsd1.ma.comcast.net] has quit [Changing host]
20130706 07:29:52-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20130706 07:44:41-!- Jetrel_new [~richard_k@c-75-73-182-0.hsd1.mn.comcast.net] has quit [Quit: Jetrel_new]
20130706 07:46:01-!- Jetrel_new [~richard_k@c-75-73-182-0.hsd1.mn.comcast.net] has joined #wesnoth-dev
20130706 08:00:22-!- Gallaecio [~quassel@183.Red-88-29-254.staticIP.rima-tde.net] has joined #wesnoth-dev
20130706 08:00:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: system reboot in progress]
20130706 08:04:34-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20130706 08:12:01-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 276 seconds]
20130706 08:12:59-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20130706 08:32:01-!- Gallaecio_ [~quassel@234.Red-2-141-168.dynamicIP.rima-tde.net] has joined #wesnoth-dev
20130706 08:34:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 08:35:25-!- Gallaecio [~quassel@183.Red-88-29-254.staticIP.rima-tde.net] has quit [Ping timeout: 276 seconds]
20130706 08:41:10-!- stikonas_ [~gentoo@ctv-213-164-96-160.vinita.lt] has joined #wesnoth-dev
20130706 08:41:11-!- stikonas_ [~gentoo@ctv-213-164-96-160.vinita.lt] has quit [Changing host]
20130706 08:41:11-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 08:45:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds]
20130706 08:45:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20130706 08:46:29-!- stikonas_ [~gentoo@ctv-213-164-96-160.vinita.lt] has joined #wesnoth-dev
20130706 08:46:29-!- stikonas_ [~gentoo@ctv-213-164-96-160.vinita.lt] has quit [Changing host]
20130706 08:46:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 08:51:43-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130706 09:35:27-!- mjs-de [~mjs-de@d189088.adsl.hansenet.de] has joined #wesnoth-dev
20130706 09:46:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20130706 09:47:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 09:59:40-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20130706 09:59:56-!- stikonas_ [~gentoo@ctv-213-164-96-160.vinita.lt] has joined #wesnoth-dev
20130706 09:59:56-!- stikonas_ [~gentoo@ctv-213-164-96-160.vinita.lt] has quit [Changing host]
20130706 09:59:56-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 10:00:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20130706 10:05:02-!- stikonas__ [~gentoo@ctv-213-164-96-160.vinita.lt] has joined #wesnoth-dev
20130706 10:05:03-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20130706 10:12:16-!- Gallaecio_ [~quassel@234.Red-2-141-168.dynamicIP.rima-tde.net] has quit [Ping timeout: 276 seconds]
20130706 10:13:12-!- Gallaecio [~quassel@7.Red-95-125-203.staticIP.rima-tde.net] has joined #wesnoth-dev
20130706 10:25:07-!- timotei__ is now known as timotei_
20130706 10:29:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 10:31:33-!- stikonas__ [~gentoo@ctv-213-164-96-160.vinita.lt] has quit [Ping timeout: 248 seconds]
20130706 10:32:05-!- EdB [~edb@abo-200-11-69.bdx.modulonet.fr] has joined #wesnoth-dev
20130706 10:32:12-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev
20130706 10:35:09-!- Gallaecio [~quassel@7.Red-95-125-203.staticIP.rima-tde.net] has quit [Read error: Connection reset by peer]
20130706 10:36:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds]
20130706 10:38:10-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20130706 10:38:10-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20130706 10:38:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 10:45:09-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 264 seconds]
20130706 10:46:36-!- EdB [~edb@abo-200-11-69.bdx.modulonet.fr] has quit [Quit: Konversation terminated!]
20130706 11:00:05-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130706 11:05:19-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130706 11:50:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20130706 11:53:30-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20130706 11:53:30-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20130706 11:53:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 11:54:45-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 264 seconds]
20130706 12:02:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20130706 12:07:36-!- irker674 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20130706 12:37:39-!- Gallaecio [~quassel@118.Red-88-29-175.dynamicIP.rima-tde.net] has joined #wesnoth-dev
20130706 12:41:50< fabi_> thunderstruck: hello
20130706 12:45:16-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20130706 12:45:22-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20130706 12:46:03-!- Gallaecio [~quassel@118.Red-88-29-175.dynamicIP.rima-tde.net] has quit [Quit: No Ping reply in 180 seconds.]
20130706 12:46:37-!- Gallaecio [~quassel@118.Red-88-29-175.dynamicIP.rima-tde.net] has joined #wesnoth-dev
20130706 12:51:34< thunderstruck> fabi_: Hi.
20130706 12:52:03< fabi_> thunderstruck: and luck with the gu1 drawing problems?
20130706 12:53:01< thunderstruck> fabi_: Nope. I haven't got any further than the last time we spoke about it.
20130706 12:55:07< fabi_> thunderstruck: Consider to call it a underlying gui engine problem, fill a proper bug report and go ahead.
20130706 12:55:30< fabi_> thunderstruck: It might take you weeks to get into gui1 internals.
20130706 12:56:43< thunderstruck> fabi_: yeah, I was thinking that it is a problem with an engine itself. Probably something with the active gui elements. Because both tooltip and that menu were the last active items in that window before loading.
20130706 12:56:45-!- Gallaecio [~quassel@118.Red-88-29-175.dynamicIP.rima-tde.net] has quit [Ping timeout: 256 seconds]
20130706 12:57:06< thunderstruck> fabi_: well, except the difficulty dialog.
20130706 12:57:17< thunderstruck> fabi_: but it is not a part of a window.
20130706 12:57:32< fabi_> The difficulty dialog is a gui2 one.
20130706 12:58:17< fabi_> Mixing both engines is some kind of a problem.
20130706 12:59:13< thunderstruck> What about loadscreen? Is that based on gui 1 or 2?
20130706 12:59:35< fabi_> The loadscreen is a hardcoded thing.
20130706 13:00:02< fabi_> It just uses sdl directly to draw on a surface. Neither gui1 nor gui2 iirc.
20130706 13:00:12< thunderstruck> ok
20130706 13:00:25< thunderstruck> There is also another small gui issue I have.
20130706 13:01:04< fabi_> Well, that is a political issue.
20130706 13:01:23< thunderstruck> The thing is that if "Load game" is selected from mp::create screen.
20130706 13:01:58< fabi_> We need to fix our current situation with the gui systems for 5 years now.
20130706 13:02:02< thunderstruck> mp::create will get destroyed, but the screen won't get redrawed and load game dialog will be displayted on top.
20130706 13:02:18< fabi_> Enough time to take action and assign a gsoc student on it for example.
20130706 13:02:21< thunderstruck> But, the map disappears.
20130706 13:02:50< fabi_> Don't get tempted in fixing gui stuff, your task is to improve MP Campaigns.
20130706 13:02:51< thunderstruck> fabi_: yes, to use 2 guis at the same time is not a good thing.
20130706 13:03:30< thunderstruck> fabi_: anyway, are you aware of disappearing minimap when load game is selected from mp::create?
20130706 13:04:14< fabi_> thunderstruck: In which version to luck at?
20130706 13:04:20< fabi_> s/luck/look
20130706 13:04:22< thunderstruck> 1.10+
20130706 13:08:09< fabi_> thunderstruck: You want to display the map from the active menu item in the load game dialog?
20130706 13:09:02< thunderstruck> fabi_: no. Just select "Load game.." from mp::create screen. You should see that the minimap of top left disappeared.
20130706 13:09:12< thunderstruck> on top left*
20130706 13:09:16< fabi_> Yes, I see.
20130706 13:09:25< thunderstruck> fabi_: that is a small glitch.
20130706 13:09:29< fabi_> Indeed.
20130706 13:09:56< fabi_> Not your problem, don't waste any time on it. (Except maybe filling a bug report).
20130706 13:10:00< thunderstruck> fabi_: However, I've moved "Load game.." from menu to a separate button and now there is always a minimap or a campaign's portrait.
20130706 13:10:13< fabi_> cool
20130706 13:10:27< thunderstruck> fabi_: yes, but the glitch looks more odd now.
20130706 13:10:29< fabi_> The "Load Game" option was always too hidden.
20130706 13:11:08< thunderstruck> Currently, if you select "Load game", the minimap will be black and if it disappears it is just a slight difference.
20130706 13:11:39< thunderstruck> But in my case, there is always a colourful map or image and if it just disappears that is quite odd.
20130706 13:13:51< thunderstruck> So I will do a couple of bug reports then.
20130706 13:13:58< fabi_> Yeah, please.
20130706 13:14:18< thunderstruck> fabi_: And as for the discussion we had about game type selection, I think I will go for combo.
20130706 13:15:08< thunderstruck> It lets to display all the options and takes little space.
20130706 13:15:43-!- Samual [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 256 seconds]
20130706 13:15:46< thunderstruck> After that, if Crab agrees, I should be able to push my work to master.
20130706 13:16:42< fabi_> thunderstruck: Is there a combo box in gui1?
20130706 13:16:57< thunderstruck> fabi_: Yes, I've just added one for mp::configure.
20130706 13:18:27< fabi_> thunderstruck: Cool, but you shouldn't do so. It is a shame to let you fix our gui systems and having a heavy main task. 
20130706 13:19:44< thunderstruck> fabi_: I think you misunderstood. I've used a gui::combo for mp::configure.
20130706 13:20:05< thunderstruck> fabi_: I didn't implement it.
20130706 13:20:08< fabi_> okay
20130706 13:20:41< fabi_> My idea about the different types of MP games is to have tabs.
20130706 13:21:27< fabi_> The only dialog that is similar to the tab concept is the preview_pane used by the preferences dialog.
20130706 13:22:27< fabi_> But it can't be used here, the layout is not fitting the needs.
20130706 13:22:40< thunderstruck> fabi_: I remember this idea. However, we're quite short on space in mp::create.
20130706 13:22:58< thunderstruck> fabi_: and from what I've seen preview_pane takes a lot of it.
20130706 13:23:14< fabi_> You have a empty bar at the top of the screen.
20130706 13:23:58< fabi_> You could just place buttons in there.
20130706 13:24:35< fabi_> And keep the active one pressed.
20130706 13:25:35< fabi_> thunderstruck: Can I see your latest screenshot, again?
20130706 13:25:42< fabi_> please
20130706 13:26:15< thunderstruck> fabi_: http://forums.wesnoth.org/viewtopic.php?f=15&t=39077
20130706 13:26:38-!- lipkab [~the_new_l@apn-94-44-252-240.vodafone.hu] has joined #wesnoth-dev
20130706 13:28:30< fabi_> thunderstruck: Yes, I would use the top bar for switching between different types and thus slightly different gui layouts.
20130706 13:29:19< fabi_> thunderstruck: The "Create Game" title would switch between "Create Campaign", "Create Scenario", "Create from Map", maybe more later.
20130706 13:30:32< thunderstruck> fabi_: hmm.. That might be an option. I think that I would still like to go with combo for now. With the current state of mp::create it would be easy to change things like that since engine and gui is separted.
20130706 13:31:33< thunderstruck> fabi_: The discussions what looks the best or is easier to use slows me down :)
20130706 13:32:08< thunderstruck> fabi_: That's why I decided to just leave a question in the forums.
20130706 13:36:50< fabi_> thunderstruck: Well, I would just take a decision now, Combo box is fine if it suits you. I can not say anything about the look and feel, at least not before I have seen a screenshot or a mockup. My suggestion aims more for making the different types more prominent.
20130706 13:38:03< fabi_> thunderstruck: But I guess we pretty much agree that you shouldn't get lost in gui problems.
20130706 13:38:32< thunderstruck> fabi_: that's true.
20130706 13:38:58< thunderstruck> fabi_: Talking about different type more prominent, don't you think that random maps could be displayed along user maps?
20130706 13:39:09< thunderstruck> different types being more*
20130706 13:40:00< fabi_> user maps are the ones in the editor folder of .local/share/wesnoth/ ?
20130706 13:40:41< thunderstruck> fabi_: yes.
20130706 13:40:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130706 13:41:04< thunderstruck> fabi_: I was thinking about having a combo box option "Maps" for editor maps and random maps.
20130706 13:41:06< fabi_> Yes, the random maps should go there.
20130706 13:41:15-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20130706 13:41:15-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20130706 13:41:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 13:41:47< fabi_> They can have their own option if you like. 
20130706 13:43:21< thunderstruck> I'm thinking about having 4 options and in this order: Scenarios, Campaigns, Maps, SP Campaigns.
20130706 13:44:03< thunderstruck> Although it might be slightly confusing what is the difference between a scenario and a map?
20130706 13:44:31< thunderstruck> "SP Campaigns" might also be a bit confusing.
20130706 13:44:32< fabi_> Well, a scenario is some wml code
20130706 13:44:41< fabi_> While a map is just the map data.
20130706 13:45:07< fabi_> The differentiation between the two gets more important with the editor saving extra wml.
20130706 13:45:11< thunderstruck> fabi_: Yes, but technically random maps have scenario wml.
20130706 13:45:39< fabi_> The pure map does so as well, it is loaded with the default setup.
20130706 13:46:20< fabi_> Again, I think it is okay to give generated maps their own tag.
20130706 13:46:28< fabi_> s/tag/option.
20130706 13:46:44< fabi_> We will have more map generators in the future.
20130706 13:47:33< vultraz> fabi_: are there plans to move pyrophorus's map gen from the forums into mainline?
20130706 13:47:50< vultraz> IMO it's much superior to the current one
20130706 13:47:55< fabi_> vultraz: Yes, that is exactly what I am speaking about.
20130706 13:48:21< thunderstruck> fabi_: Ok. What about "SP Campaigns" options? People might think what the hell SP campaigns are doing in MP.
20130706 13:48:53< thunderstruck> s/options/option
20130706 13:49:34< thunderstruck> fabi_: maybe just call them "Other Campaigns" and show a warning text somewhere that they are unadjusted for MP?
20130706 13:50:01-!- lipkab [~the_new_l@apn-94-44-252-240.vodafone.hu] has quit [Ping timeout: 276 seconds]
20130706 13:50:07< fabi_> Well, my suggestion is to not show them unless wesnoth is started with --debug.
20130706 13:50:56< fabi_> If you include them in the combo box, then call them SP Campaigns, because this is what they are. Naming them different is just increasing confusion.
20130706 13:51:38< thunderstruck> fabi_: I don't really think that they should be in mp::create window by default.
20130706 13:51:51< thunderstruck> fabi_: as I said last time, I was thinking about an option in advanced.
20130706 13:51:58< thunderstruck> But --debug is also fine.
20130706 13:52:18< thunderstruck> in advanced preferences*
20130706 13:52:56< fabi_> Well, it might result in having some SP campaigns being played online.
20130706 13:53:16< fabi_> If you play them online you can not save load that easily and others can watch you play and give hints.
20130706 13:53:38< fabi_> Or learn from you.
20130706 13:54:10< fabi_> Thus the option might be useful for everyone, not just testers or developers.
20130706 13:55:34< vultraz> I support the idea of playing SP campaigns online
20130706 13:56:09< vultraz> It's actually a thing I've been hoping for since 2011 and zaroth's project
20130706 13:56:11< fabi_> thunderstruck: Thus my advice is to just get the dialog done, including the 4 options you mentioned + maybe one for generators. We can see later if it needs to get guarded by a preferences item or a commandline option.
20130706 13:57:08< thunderstruck> fabi_: I agree.
20130706 13:57:34< fabi_> vultraz: May I ask why you like the idea?
20130706 13:59:28< vultraz> fabi_: well, for one, you could be playing an SP campaign, and have someone come and observe, and give tips. Or you could use it for a youtube letsplay series, with one person observing while one plays. Or similar 
20130706 14:00:32< thunderstruck> also there are more configurations when campaign is played in mp
20130706 14:00:48< thunderstruck> of course, some of them are broken for campaigns
20130706 14:01:21< fabi_> vultraz: Maybe it is already possible to apply the mp modifcation addons on them.
20130706 14:01:26< thunderstruck> and some of them might get locked by default for campaign because of the current changes I'm doing
20130706 14:01:34< vultraz> Or you could be playing a campaign you're making on the sever, and ask suggestions from the observers
20130706 14:13:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130706 14:17:40-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20130706 14:17:40-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20130706 14:17:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 14:22:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130706 14:22:51-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20130706 14:22:51-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20130706 14:22:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 14:25:05-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has joined #wesnoth-dev
20130706 14:28:18-!- Gambit [~quassel@wesnoth/developer/grickit] has joined #wesnoth-dev
20130706 14:41:58-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has quit [Quit: DCW]
20130706 14:52:25-!- dailin [~dailin@115.193.171.251] has joined #wesnoth-dev
20130706 15:22:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20130706 15:22:58-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20130706 15:22:58-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20130706 15:22:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 15:45:15< fabi_> thunderstruck: When do you want to merge your branch into master?
20130706 16:07:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130706 16:11:03-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20130706 16:11:03-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20130706 16:11:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 16:39:19-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20130706 16:48:09-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20130706 16:50:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: No route to host]
20130706 16:50:36-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20130706 16:50:36-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20130706 16:50:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130706 17:03:31-!- kex [~kex@89.205.70.185] has joined #wesnoth-dev
20130706 17:20:34-!- dailin [~dailin@115.193.171.251] has quit [Quit: Leaving]
20130706 17:26:46-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130706 17:55:23-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 256 seconds]
20130706 18:09:40-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has joined #wesnoth-dev
20130706 18:10:27-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection]
20130706 18:12:23-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Ping timeout: 256 seconds]
20130706 18:21:28-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has joined #wesnoth-dev
20130706 18:40:09-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection]
20130706 18:40:11-!- mattsc [~mattsc@d154-20-34-165.bchsia.telus.net] has joined #wesnoth-dev
20130706 19:08:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20130706 19:24:47-!- skyfaller [~skyfaller@c-75-67-154-18.hsd1.ma.comcast.net] has joined #wesnoth-dev
20130706 19:24:47-!- skyfaller [~skyfaller@c-75-67-154-18.hsd1.ma.comcast.net] has quit [Changing host]
20130706 19:24:47-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20130706 19:30:05-!- skyfaller_ [~skyfaller@c-75-67-154-18.hsd1.ma.comcast.net] has joined #wesnoth-dev
20130706 19:30:28-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20130706 19:33:09-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Ping timeout: 264 seconds]
20130706 19:47:42-!- skyfaller [~skyfaller@c-75-67-154-18.hsd1.ma.comcast.net] has joined #wesnoth-dev
20130706 19:47:42-!- skyfaller [~skyfaller@c-75-67-154-18.hsd1.ma.comcast.net] has quit [Changing host]
20130706 19:47:42-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20130706 19:48:59-!- irker215 [~irker@ai0867.net] has joined #wesnoth-dev
20130706 19:48:59< irker215> wesnoth: mattsc wesnoth-old:master 8d55cc572f37 / data/ai/micro_ais/ais/ (mai_goto_engine.lua micro_ais_wml_tags.lua): Goto MAI: add avoid_enemies= parameter http://git.io/kBF8Dg
20130706 19:49:01< irker215> wesnoth: mattsc wesnoth-old:master 8d8014e3758d / data/ai/micro_ais/ (maps/goto.map scenarios/goto.cfg): Goto MAI test scenario: add ghost side that uses avoid_enemies= key http://git.io/4sty7g
20130706 19:49:17-!- skyfaller_ [~skyfaller@c-75-67-154-18.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds]
20130706 19:58:27< thunderstruck> fabi_: I'm not exactly sure. I still need to do a couple things and hear back from Crab.
20130706 19:58:47< thunderstruck> fabi_: But it should happen in the beginning of the next week if everything's ok.
20130706 19:59:04< fabi_> thunderstruck: Okay, I want to adjust LoW as soon as possible to provide a test case.
20130706 19:59:14-!- Blueblaze [~Blueblaze@ip68-3-135-148.ph.ph.cox.net] has joined #wesnoth-dev
20130706 19:59:35< thunderstruck> fabi_: Ok. I was playing with LoW a bit with myself.
20130706 19:59:52< thunderstruck> fabi_: a bit myself*
20130706 20:00:37< thunderstruck> fabi_: What exactly you were planning to do with it?
20130706 20:17:26< fabi_> thunderstruck: Well, write a working [campaign] with type=hybrid, adjust the current chapter handling to you new system. Remove the difficulty hack I used before.
20130706 20:18:39< fabi_> thunderstruck: Maybe there are more changes needed to get it running.
20130706 20:19:02< vultraz> thunderstruck: what happens with WML compatibility in all this? Will all code now become "mp-safe"?
20130706 20:22:18< fabi_> thunderstruck: Also, I need to assign the sides in scenario 3,7 and 14 properly to the players. This is not possible now, (iirc) but depends on one of your new features, I hope you thought about it.
20130706 20:24:08< thunderstruck> fabi_: Ok. I haven't made any changes to scenarios itself, so sides should still work the way they work now in mp.
20130706 20:24:20< thunderstruck> fabi_: And I thought that it is my responsibility to port LoW.
20130706 20:24:29< fabi_> thunderstruck: Okay, no problem. One step after the other.
20130706 20:25:28< fabi_> thunderstruck: Well, if you really want to do it, I'm fine. Still I think your project is enough work, remembering that a similar project already failed.
20130706 20:25:56< thunderstruck> fabi_: Yeah, I'm currently considering about making the game to go to mp::connect after every non-last multiplayer scenario.
20130706 20:26:18< thunderstruck> fabi_: This would help me to implement proper players management support and set up a correct game config for every scnenario.
20130706 20:26:28< thunderstruck> I.e. eras, mods and maybe some other things.
20130706 20:26:39< fabi_> thunderstruck: I would go to the screen at every scenario that has allow_new_game=yes.
20130706 20:27:06< thunderstruck> vultraz: I try to not break any WML compatibility and so far I haven't broken anything.
20130706 20:27:46< thunderstruck> vultraz: well, all code is already mp-safe. But some things just don't work well.
20130706 20:28:46< fabi_> thunderstruck: On the other hand, going back to connect after every non last scenario is a good setting for the testing/development phase.
20130706 20:29:18< thunderstruck> fabi_: it is also a good thing for campaigns which would allow custom options.
20130706 20:31:41< thunderstruck> fabi_: and what about the campaigns which have different number of players?
20130706 20:32:33< fabi_> thunderstruck: Different number of players between the chapters, like LoW?
20130706 20:33:03< thunderstruck> fabi_: hmmm.. what about leaving players?
20130706 20:33:56< thunderstruck> fabi_: it would be nice to be able to easily get a new player if needed. i.e. if someone left.
20130706 20:34:16< fabi_> If a player leaves, the player who is in control of the game can replace him by either a observer or by one of the players.
20130706 20:34:46< fabi_> You can add a command to reenter the connect screen for him.
20130706 20:35:34< fabi_> Thus the players can decide how to handle the situation and go back to the connect screen if no in-game solution can be found.
20130706 20:36:19< thunderstruck> fabi_: Ok. Thanks for the discussion. I got to go now.
20130706 20:36:30< thunderstruck> Bye.
20130706 20:36:32< fabi_> thunderstruck: You are welcome. Bye
20130706 20:36:39-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving]
20130706 20:47:46-!- iwontbecreative [~thibault@89-180-77-154.net.novis.pt] has joined #wesnoth-dev
20130706 21:29:55-!- vultraz_laptop [~chatzilla@124.109.10.167] has quit [Read error: Connection reset by peer]
20130706 21:31:32-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20130706 21:31:33-!- Yukiria [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20130706 21:32:01-!- Yukiria is now known as vultraz
20130706 21:35:32-!- vultraz [~chatzilla@124.109.10.167] has quit [Read error: Connection reset by peer]
20130706 21:35:38-!- Yukiria [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20130706 21:35:57-!- Yukiria is now known as vultraz
20130706 21:36:30-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130706 21:54:16< irker215> wesnoth: mattsc wesnoth-old:master 2c890d5932fc / data/ai/micro_ais/ais/micro_ais_wml_tags.lua: Goto MAI: make [filter] an optional parameter http://git.io/IX7DqQ
20130706 21:54:18< irker215> wesnoth: mattsc wesnoth-old:master bb267636029c / data/ai/micro_ais/scenarios/goto.cfg: Goto MAI test scenario: don't use [filter] if all side units are to be controlle http://git.io/Pt4N7w
20130706 21:58:01-!- vultraz [~chatzilla@124.109.10.167] has quit [Read error: Connection reset by peer]
20130706 22:00:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 276 seconds]
20130706 22:02:41< irker215> wesnoth: mattsc wesnoth-old:master 35848693e5bf / data/ai/micro_ais/scenarios/goto.cfg: Goto Micro AI scenario: use change action rather than delete+add ... https://github.com/wesnoth/wesnoth-old/commit/35848693e5bfcb4e1c7def65f3a278c0b039f8c0
20130706 22:02:46< irker215> wesnoth: mattsc wesnoth-old:master e30f68f2f1d6 / data/ai/micro_ais/scenarios/goto.cfg: Goto MAI scenario: minor change to a message http://git.io/2t3nRQ
20130706 22:11:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20130706 22:17:20-!- lipkab [~the_new_l@apn-5-206-145-10.vodafone.hu] has joined #wesnoth-dev
20130706 22:36:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130706 23:58:42-!- kex [~kex@89.205.70.185] has quit [Remote host closed the connection]
--- Log closed Sun Jul 07 00:00:06 2013