--- Log opened Sun Aug 18 00:00:14 2013 20130818 00:07:45-!- gfgtdf [~chatzilla@f054144095.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 22.0/20130618035212]] 20130818 00:24:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20130818 00:37:37< shadowm> Does anyone have an opinion on this absolutely preposterous amount of .gitignore files? 20130818 00:37:42< shadowm> 18:34:45 shadowm@nanacore:~/src/wesnoth$ find . -name .gitignore | wc -l 20130818 00:37:45< shadowm> 18:34:45 170 20130818 00:39:08< un214> shouldn't there be 1? 20130818 00:40:53-!- EdB [~edb@85.69.144.96] has quit [Quit: Konversation terminated!] 20130818 00:41:49-!- groggy [43eeb2e1@gateway/web/freenode/ip.67.238.178.225] has joined #wesnoth-dev 20130818 00:46:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20130818 00:46:59< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master cf8adf901452 / Doxyfile: Bump Doxyfile version number https://github.com/wesnoth/wesnoth-old/commit/cf8adf901452e72586e498bc4021a3e5d53d49f2 20130818 00:47:33< iwontbecreative> shadowm: Might be easier to have all in just one file indeed 20130818 00:48:04< Gallaecio> I did not even knew you could have more than one… 20130818 00:48:36< shadowm> Yeah, I realized after I found some .pyc files being ignored without being in .gitignore or .git/info/exclude. 20130818 00:51:04< shadowm> Ivanovic: http://wiki.wesnoth.org/index.php?title=ReleasingWesnoth&diff=51767&oldid=51166 20130818 00:51:08-!- nagafono [~kvirc@178.19.251.44] has joined #wesnoth-dev 20130818 00:51:09< shadowm> For future releases. 20130818 00:51:28-!- nagafono [~kvirc@178.19.251.44] has left #wesnoth-dev [] 20130818 00:52:06< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:1.10 fefa476b8571 / Doxyfile: Bump Doxyfile version number https://github.com/wesnoth/wesnoth-old/commit/fefa476b857139b5dfdc5f67a20d5bcf65a91d84 20130818 00:53:11< iwontbecreative> Hmmm anyone knows what's the issue with stats.wesnoth.org ? 20130818 00:53:48-!- nurupo|away is now known as nurupo 20130818 00:55:05-!- groggy [43eeb2e1@gateway/web/freenode/ip.67.238.178.225] has quit [Ping timeout: 250 seconds] 20130818 01:04:11< AI0867> shadowm: you already noted a while back that it was the result of the conversion and that they don't do quite the same thing as the svn:ignore properties we had 20130818 01:04:11-!- groggy [43eeb2e1@gateway/web/freenode/ip.67.238.178.225] has joined #wesnoth-dev 20130818 01:05:15-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 276 seconds] 20130818 01:12:03< Gallaecio> shadowm: about the version bumps, if CMake is used both to build the game and the documentation, have you considered using CMake to define the version in a centralized way instead of updating the version in more than one place? 20130818 01:14:44< irker062> wesnoth: Adrián Chaves Fernández (Gallaecio) wesnoth-old:1.10 bb762f4015d1 / data/core/images/maps/l10n/gl/wesnoth--overlay.png: [Galician Translation] Added an image that had been left behind because of .giti https://github.com/wesnoth/wesnoth-old/commit/bb762f4015d1f0a03d30218a728b817872d70224 20130818 01:14:47< irker062> wesnoth: Alexander van Gessel wesnoth-old:1.10 20335188f441 / data/core/images/maps/l10n/gl/wesnoth--overlay.png: Merge pull request #67 from Gallaecio/1.10-gl https://github.com/wesnoth/wesnoth-old/commit/20335188f4411579c1b62839debbaf8fd766b0e1 20130818 01:20:06< shadowm> AI0867: I did? 20130818 01:21:26< shadowm> Gallaecio: I don't use cmake, but I have the cronjob used to build devdocs.w.o in my console here and it doesn't use cmake. 20130818 01:21:41< shadowm> It just changes to the target dir and runs doxygen without any arguments on it. 20130818 01:21:59< shadowm> Incidentally, "Generated by doxygen 1.7.1 on Mon May 20 2013 20:54:56 for The Battle for Wesnoth". :\ 20130818 01:22:14< Gallaecio> OK, nevermind then. 20130818 01:22:25< shadowm> I've got to wonder if anyone actually uses devdocs.w.o. 20130818 01:23:56-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has quit [Quit: Leaving] 20130818 01:29:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20130818 01:32:23< jamit> shadowm: I use it sometimes. 20130818 01:32:45< irker062> wesnoth: Groggy Dice wesnoth-old:master 45fa75c08267 / data/tools/wmllint: change introduction's reference to checking out wmllint from 1.4 branch, to wmll http://git.io/ZrMDmQ 20130818 01:33:18< irker062> wesnoth: Groggy Dice wesnoth-old:master 46e9d8dc1dbe / data/tools/wmllint: wmllint: bugfix missing "stringfreeze" long argument in getopt, and correct help https://github.com/wesnoth/wesnoth-old/commit/46e9d8dc1dbe9bf2f63f53904f991de7fec19f4c 20130818 01:33:20< irker062> wesnoth: Groggy Dice wesnoth-old:master db560619e8fa / data/tools/wmllint: wmllint: add switch -K --known for suppresing consistency_check() http://git.io/JsjCcg 20130818 01:33:22< irker062> wesnoth: Groggy Dice wesnoth-old:master 93af90d2db67 / data/tools/wmllint: additions to wmllint help http://git.io/K77PTw 20130818 01:33:25< irker062> wesnoth: Groggy Dice wesnoth-old:master 8b3aba7ccb0f / data/tools/wmllint: wmllint: extend scenario check to include first scenario http://git.io/CdlVGA 20130818 01:34:36-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection] 20130818 01:35:38< shadowm> groggy: Would you consider yourself to be the new de facto maintainer of wmllint now? :) 20130818 01:36:11< groggy> i dunno. there's some real-life projects i really need to get cracking on 20130818 01:36:29< groggy> this wesnoth stuff has in fact been a dangerous distraction 20130818 01:36:57< groggy> of course, esr himself did "appoint" me wmllint maintainer 20130818 01:38:09< shadowm> I must've missed that. 20130818 01:40:06< shadowm> I was going to point you to a FR that Elvish_Hunter was supposedly going to file about the unit_type.zoc semantics change, but it turns out the FR doesn't actually exist yet. :\ 20130818 01:40:31< groggy> http://forums.wesnoth.org/viewtopic.php?f=10&t=38317&p=548119#p548119 20130818 01:41:00< AI0867> shadowm: I remember someone complaining about it. I thought it was you 20130818 01:41:02< shadowm> Ah, that. Heh. 20130818 01:41:37< shadowm> AI0867: Potentially? I promust have forgotten ay have forgotten. 20130818 01:42:25< shadowm> It doesn't matter much in any case. Nothing will happen unless we decide whether we prefer the current rather opaque approach or folding it all into a single file. 20130818 01:43:49< shadowm> I for one would rather see it all in a single file like this: http://pastebin.com/sv249Bn6 20130818 01:43:49< groggy> there's also limits to my pthon knowledge - i havent set up a class yet 20130818 01:43:59< AI0867> well, the reconversion might fix the ignore files 20130818 01:44:23< AI0867> and the centralized/distributed thing might be done then too 20130818 01:44:37< groggy> havent figured out the stuff in wmliterator and wmltools either 20130818 01:44:48< shadowm> AI0867: Yeah, you know what my opinion on rewriting history is... 20130818 01:45:10-!- trademark_ [~trademark@mne69-1-82-67-17-201.fbx.proxad.net] has quit [Read error: Operation timed out] 20130818 01:49:34< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 6e69dd15fbca / .gitignore: Restrict some .gitignore patterns to the root of the working tree http://git.io/f5GJDQ 20130818 01:49:36-!- iwontbecreative [~thibault@89.180.80.228] has quit [Quit: leaving] 20130818 01:51:41< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:1.10 473d95378245 / .gitignore: Update .gitignore to match the copy from master http://git.io/4MuvbA 20130818 01:51:44< shadowm> Gallaecio, stikonas: That _should_ help in the future unless I missed something. 20130818 01:53:30< Gallaecio> Great 20130818 01:54:17< shadowm> Okay why is ./website/stats.wesnoth.org/.gitignore anything but a gitignore file. 20130818 01:54:30< shadowm> !file website/stats.wesnoth.org/.gitignore 20130818 01:54:30< shikadibot> shadowm: Web interface URL to file website/stats.wesnoth.org/.gitignore: https://github.com/wesnoth/wesnoth-old/blob/master/website/stats.wesnoth.org/.gitignore 20130818 01:55:00-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20130818 01:55:48< shadowm> wesbot: log 35965 20130818 01:55:49< wesbot> cornmander * r35965 : port to turbogears 2 -> much better debugging features and better URL generation control 20130818 01:55:52< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=35965 20130818 01:58:26< shadowm> Yeah, someone did a svn propset or propedit wrong. 20130818 01:59:17< groggy> shadowm: i believe EH considers his commit sufficient: https://github.com/wesnoth/wesnoth-old/commit/3eb9299bd20b3f9295e211cefb932fe9e95bb741 20130818 01:59:43< groggy> it does leave a blank line 20130818 01:59:48< shadowm> *unit_type.ellipse in what I said above, sorry. 20130818 02:00:09< groggy> oh a variable. sorry 20130818 02:00:33< shadowm> No, not a variable, I just use that notation to refer to any part of a WML tree for convenience. 20130818 02:00:53< shadowm> groggy: Okay, now I see why wmllint never warned me about instances of that in my campaign. 20130818 02:00:58< shadowm> ellipse="misc/ellipse-nozoc" 20130818 02:01:24< shadowm> That substitution only occurs on unquoted instances of the attribute/value pair. :\ 20130818 02:03:47< shadowm> So yeah, no, adding that plain text substitution pair to the tuple isn't enough. 20130818 02:04:05< shadowm> I don't think that kind of syntax changes belong there, in general. 20130818 02:05:16-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 256 seconds] 20130818 02:06:48< groggy> well, if EH doesnt get to it in a couple of days, i may look at it 20130818 02:06:50-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20130818 02:06:50-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20130818 02:06:50-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20130818 02:07:02< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master f62c9d647d32 / website/stats.wesnoth.org/.gitignore: Remove a .gitignore file that is not a .gitignore file http://git.io/CqLoDg 20130818 02:07:17< shadowm> I probably should PM him since he hasn't answered my log messages for a while. 20130818 02:07:27< groggy> with 1.11.6 out, the pressure is off... at least for me 20130818 02:07:49-!- ancestral [~ancestral@97-127-74-247.mpls.qwest.net] has joined #wesnoth-dev 20130818 02:09:47< groggy> my own plans include adding an -m --missing= switch for the no side= change 20130818 02:10:44< groggy> 'warn' (default) will warn the author that no side= will now be applied to all sides 20130818 02:11:10< groggy> 'new' will tell lint to ignore no side= key 20130818 02:12:49< groggy> then i'll try to set up an option to prompt the user if he wants side= inserted 20130818 02:13:15< shadowm> I think we can all agree that there are multiple things wrong with this: http://pastebin.com/mG0y0r2U 20130818 02:13:41 * shadowm ponders possible methods to trace down the sources of each pattern. 20130818 02:14:26< shadowm> Without the sort -u step the result is 632 lines long, too. 20130818 02:17:25-!- groggy [43eeb2e1@gateway/web/freenode/ip.67.238.178.225] has quit [Quit: Page closed] 20130818 02:18:26-!- SpoOkyMagician [~chatzilla@74-128-177-187.dhcp.insightbb.com] has quit [Quit: well, I guess I am not accomplishing much today... Later... -Coin Mode-] 20130818 02:18:58-!- ancestral [~ancestral@97-127-74-247.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20130818 02:19:21-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 264 seconds] 20130818 02:20:23-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20130818 02:20:23-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20130818 02:20:23-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20130818 02:43:42-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 264 seconds] 20130818 02:51:33< shadowm> So I used this: http://pastebin.com/aK5Mxy13 20130818 02:51:46< shadowm> And got this: https://dl.dropboxusercontent.com/u/21371130/wesnoth-gitignore-sources 20130818 02:53:02< shadowm> A sorted version: https://dl.dropboxusercontent.com/u/21371130/wesnoth-gitignore-sources-sorted 20130818 02:53:32< shadowm> There is plenty of room for... uh... optimization... there. 20130818 02:55:28< shadowm> The first pattern is just 0x0A (LF), which is ignored by Git, but still. 20130818 02:57:16< shadowm> It's a trailing blank line. 20130818 02:58:00< shadowm> I guess a good first step for cleanup would be identifying the .gitignore files that are identical to each other. 20130818 03:26:56-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 268 seconds] 20130818 03:29:23-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20130818 03:54:54-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 276 seconds] 20130818 03:55:43-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20130818 03:59:07-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has joined #wesnoth-dev 20130818 04:08:56-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection] 20130818 04:20:45-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130818 04:22:42-!- Ivanovic_ [~ivanovic@x2f3c02e.dyn.telefonica.de] has joined #wesnoth-dev 20130818 04:25:42-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 264 seconds] 20130818 04:25:59-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Operation timed out] 20130818 04:26:29-!- knotwork [~markm@142.68.128.216] has joined #wesnoth-dev 20130818 04:26:29-!- knotwork [~markm@142.68.128.216] has quit [Changing host] 20130818 04:26:29-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20130818 04:27:09-!- Ivanovic_ [~ivanovic@x2f3c02e.dyn.telefonica.de] has quit [Ping timeout: 264 seconds] 20130818 04:39:10-!- Ivanovic [~ivanovic@x2f3c02e.dyn.telefonica.de] has joined #wesnoth-dev 20130818 04:39:10-!- Ivanovic [~ivanovic@x2f3c02e.dyn.telefonica.de] has quit [Changing host] 20130818 04:39:10-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20130818 04:41:11-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has joined #wesnoth-dev 20130818 04:46:31-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20130818 04:46:31-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20130818 04:46:31-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20130818 04:59:58< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 21191cd52084 / doc/doxygen/footer.html: Doxygen: update footer links http://git.io/g-Cjhg 20130818 05:13:09-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection] 20130818 05:22:53< shadowm> AI0867: Weren't we going to discard libana? 20130818 05:24:14< shadowm> Also, I just ran doxygen on the source tree on my desktop (nanacore). 20130818 05:24:15< shadowm> 23:18:28 nanacore does in 6:54 minutes what wesnoth.org does in 1 hour 57 minutes. 20130818 05:40:57< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 42bdb96e1c15 / src/map.hpp: Doxygen comment fixes http://git.io/YAqRmQ 20130818 05:41:00< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 1678bce91e38 / src/floating_point_emulation.hpp: Doxygen comment fixes http://git.io/A6Nwgw 20130818 05:41:03< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 2a0034a6bb93 / src/unit_types.cpp: Doxygen comment fixes https://github.com/wesnoth/wesnoth-old/commit/2a0034a6bb932fedd12c2440e81b7382cc539d7c 20130818 05:41:06< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master d8afccde1c37 / src/unit.cpp: Doxygen comment fixes http://git.io/U80lpg 20130818 05:41:09< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 9e13bf380c1a / src/actions/undo.cpp: Doxygen comment fixes http://git.io/dp5KsQ 20130818 05:41:12< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 153224fc0566 / src/editor/action/mouse/mouse_action.cpp: Doxygen comment fixes https://github.com/wesnoth/wesnoth-old/commit/153224fc0566208a6b1260f401783c0db616ece3 20130818 05:41:15< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master a8ff10955886 / src/editor/toolkit/editor_toolkit.cpp: Doxygen comment fixes http://git.io/sQdOZw 20130818 05:41:18< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master f22673603935 / src/gui/widgets/control.hpp: Doxygen comment fixes http://git.io/_4I-vA 20130818 05:52:57-!- Gambit is now known as Gambit|banningpu 20130818 05:53:04-!- Gambit|banningpu is now known as Gambit 20130818 05:53:35< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 444b7eafe0e6 / src/text.hpp: Doxygen comment fixes http://git.io/tnMTrg 20130818 05:55:27-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 05:55:53-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 06:00:50< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 7da2afa04c85 / src/attack_prediction.cpp: Doxygen comment fixes http://git.io/DlwBSg 20130818 06:00:53< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master f04278de6194 / src/marked-up_text.hpp: Doxygen comment fixes https://github.com/wesnoth/wesnoth-old/commit/f04278de619455f12b5a7ab66caa575f5c19860f 20130818 06:20:45-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20130818 06:23:54< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master c76944c80558 / src/hotkeys.hpp: Doxygen comment fixes http://git.io/H77qMg 20130818 06:33:58-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 06:34:24-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 06:34:30-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130818 06:44:17-!- _Coffee [~david@ppp121-45-78-176.lns20.adl6.internode.on.net] has joined #wesnoth-dev 20130818 06:57:10-!- ancestral [~ancestral@97-127-74-247.mpls.qwest.net] has joined #wesnoth-dev 20130818 06:58:51-!- ancestral [~ancestral@97-127-74-247.mpls.qwest.net] has quit [Client Quit] 20130818 06:59:02< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:1.10 266f7180aa49 / players_changelog: Fix players_changelog formatting https://github.com/wesnoth/wesnoth-old/commit/266f7180aa4952046dc9348c03272109b07abfb4 20130818 06:59:09< irker062> wesnoth: Ignacio R. Morelle wesnoth-old:master 2e93f56778ae / players_changelog: Fix players_changelog formatting http://git.io/JOXNEA 20130818 07:05:04< shadowm> _Coffee: Does ~ have a special meaning in the new animation syntax that could conflict with image path functions? 20130818 07:05:29-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20130818 07:09:28< _8680_> shadowm: From what I remember, “foo[1~3].png” expands to “foo1.png,foo2.png,foo3.png”. 20130818 07:09:44< shadowm> Yes, but is that only parsed within the brackets? 20130818 07:10:14< _Coffee> shadowm: ~ is like before for offsets in files 20130818 07:10:23< _Coffee> before the syntax changes 20130818 07:10:38< _8680_> shadowm: I don’t remember. I believe it wasn’t in my test implementation, but I don’t know about the implementation that went into the game. Shall I check? 20130818 07:11:14< shadowm> What I really want to know is why {DEFENSE_ANIM "units/elves-wood/lady.png~CS(-255,-255,-255)" "units/elves-wood/lady.png~CS(-255,-255,-255)" {SOUND_LIST:ELF_FEMALE_HIT} } results in lady.png appearing untinted during the defense animation. 20130818 07:11:14< _Coffee> _8680_: that's right 20130818 07:11:24< _Coffee> I put all the syntax changes into the wiki page 20130818 07:11:51< shadowm> (This is a really dumbed down test case I just concocted and the issue that led me to investigate this is actually more practical and involves ~PAL() instead.) 20130818 07:12:06< _Coffee> I can check 20130818 07:12:36< shadowm> _Coffee: In that case, here is the test WML: http://pastebin.com/aPqbE4Cm 20130818 07:12:49< shadowm> The trigger is the defense animation when the unit is attacked, of course. 20130818 07:14:12< shadowm> In Wesnoth 1.10 the black silhouette resulting from ~CS(-255,-255,-255) is merely tinted red when hit, not reverted to the unmodified base image. 20130818 07:15:09< shadowm> What I see is that the macro is substituted with an animation that has a frame with image="units/elves-wood/lady.png~CS(-255,-255,-255)":1,"units/elves-wood/lady.png~CS(-255,-255,-255)":250,"units/elves-wood/lady.png~CS(-255,-255,-255)":1 20130818 07:15:37< _Coffee> yeah, that is what it should be 20130818 07:15:49< shadowm> Is that supposed to cause problems? 20130818 07:15:50< _Coffee> and only if there are square brackets should it care about the ~ inside 20130818 07:16:30< shadowm> Right. 20130818 07:17:28< shadowm> I wonder if the quotes could be causing problems? Although I'd expect "image not found" messages in stderr in that case, and there are none such. 20130818 07:18:15< shadowm> Since the macro arguments include parentheses, the quotes are really necessary to prevent the preprocessor from claiming that there are unmatched parentheses and failing. 20130818 07:18:43< shadowm> But this results in the unusual substitution above, which I'm unsure the animations engine is equipped to handle. 20130818 07:18:47< _Coffee> trying expanded macro 20130818 07:20:01< _Coffee> nope 20130818 07:20:07< _Coffee> still shows undarkened 20130818 07:20:23-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20130818 07:20:50< shadowm> So something is somehow dropping the image path functions when parsing that. 20130818 07:21:48< shadowm> Well, when the unit is hit, anyway. It seems to work fine when the attack misses. 20130818 07:21:51< _Coffee> even when expanding to multiple frames it glitches 20130818 07:23:03< _Coffee> and also when dropping the timing 20130818 07:23:58< shadowm> So this appears to have last worked correctly on 1.11.1. Hm. 20130818 07:24:14< _Coffee> yeah, it is a bug I may have introduced 20130818 07:24:15< shadowm> I guess I could run a bisect. 20130818 07:33:58-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 07:34:21-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 07:34:55< _Coffee> shadowm: the problem I believe is in progressive_image function in unit_frame.cpp 20130818 07:35:07< _Coffee> it gets the correct image name into this 20130818 07:35:23 * shadowm is bisecting. 20130818 07:39:30< shadowm> I missed the opportunity to speed this up using -O0 instead of -O3. :\ 20130818 07:40:17< _Coffee> shadowm: I think I see the problem 20130818 07:41:04< _Coffee> image::locator elsewhere (other than in progressive_image) has 2 arguments and splits them into image and mod 20130818 07:41:59< _Coffee> I think you'll find the problem occurred in the commit that introduced the progressive_image function 20130818 07:45:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20130818 07:46:12< _Coffee> shadowm: testing with image_mod function instead 20130818 07:47:50< shadowm> Hit a commit that won't build. Oops. 20130818 07:49:33< shadowm> Almost done, I think. 20130818 07:50:26< shadowm> _Coffee: http://pastebin.com/rKbJ4620 20130818 07:50:29-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 248 seconds] 20130818 07:51:09< _Coffee> shadowm: I thought so :P 20130818 07:51:09< shadowm> It's not a particularly nice commit to look at. The diffstat is full of WML noise. 20130818 07:51:29< _Coffee> that is when the progressive_image function was added 20130818 08:11:55< _Coffee> shadowm: fixed (here anyway) 20130818 08:13:30< _Coffee> can commit to git once I resync with main code on my computer 20130818 08:15:57< shadowm> Okay, cool. 20130818 08:42:02-!- trademark_ [~trademark@mne69-1-82-67-17-201.fbx.proxad.net] has joined #wesnoth-dev 20130818 09:01:47-!- nurupo is now known as nurupo|away 20130818 09:22:11-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20130818 09:22:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130818 09:43:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20130818 09:57:30< vultraz> wesbot: !seen mattsc 20130818 09:57:30< wesbot> vultraz: The person with the nick mattsc last spoke 11d 20h ago. 11d 20h ago was here and on the channel #wesnoth-umc-dev with the message: Quit: Traveling for most of August, won't be around much. 20130818 09:57:39< vultraz> wesbot: !seen alarantalara 20130818 09:57:40< wesbot> vultraz: The person with the nick Alarantalara last spoke 53d 5h ago. 44d 8h ago was here and on the channel #wesnoth-umc-dev with the message: Quit: Leaving. 20130818 10:05:58-!- EdB [~edb@85.69.144.96] has joined #wesnoth-dev 20130818 10:44:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20130818 10:51:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130818 10:51:59-!- nurupo|away [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 260 seconds] 20130818 10:52:45-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has joined #wesnoth-dev 20130818 10:53:38-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20130818 10:53:43-!- mjs-de [~mjs-de@p3EE20C3D.dip0.t-ipconnect.de] has joined #wesnoth-dev 20130818 10:55:09-!- nurupo|away [~nurupo.ga@biribiri.org] has joined #wesnoth-dev 20130818 10:55:09-!- nurupo|away is now known as nurupo 20130818 10:55:30-!- nurupo [~nurupo.ga@biribiri.org] has quit [Changing host] 20130818 10:55:31-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20130818 11:00:12-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 256 seconds] 20130818 11:00:21-!- nurupo|away [~nurupo.ga@biribiri.org] has joined #wesnoth-dev 20130818 11:04:59-!- nurupo|away is now known as nurupo 20130818 11:05:09-!- nurupo [~nurupo.ga@biribiri.org] has quit [Changing host] 20130818 11:05:09-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20130818 11:17:07-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 11:17:34-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 11:25:10-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 11:25:36-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 11:33:12-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 11:33:41-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 12:18:44-!- mjs-de [~mjs-de@p3EE20C3D.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20130818 12:22:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20130818 12:22:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130818 12:36:47-!- irker062 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130818 12:38:24-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 260 seconds] 20130818 12:41:39-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20130818 12:41:39-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer] 20130818 12:42:54-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20130818 12:48:53-!- stikonas__ [~gentoo@5.20.200.50] has joined #wesnoth-dev 20130818 12:52:14-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20130818 13:04:57-!- stikonas__ is now known as stikonas 20130818 13:13:42-!- Vandal [Ganrao@cpe-65-189-245-210.woh.res.rr.com] has joined #wesnoth-dev 20130818 13:29:55-!- irker761 [~irker@ai0867.net] has joined #wesnoth-dev 20130818 13:29:55< irker761> wesnoth: Adrián Chaves Fernández (Gallaecio) wesnoth-old:master 79424012911c / po/ (9 files in 9 dirs): Updated the Galician translation http://git.io/5RYyxA 20130818 13:29:55< irker761> wesnoth: Alexander van Gessel wesnoth-old:master b955bb69aff5 / po/ (9 files in 9 dirs): Merge pull request #69 from Gallaecio/gl http://git.io/pF7-SA 20130818 13:30:52-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 13:31:23-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 13:40:26< _Coffee> hmm 20130818 13:40:52< _Coffee> I made a change earlier and ran "git commit -a -m ..." and itdoesn't appear to have gone through 20130818 13:43:04-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 13:43:29-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 13:48:09< _Coffee> do I need to use git push? 20130818 13:49:51< AI0867> shadowm: probably, nobody's made a decision on that yet though 20130818 13:52:10-!- asbfki [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 13:52:38-!- {V} [~V@139-79-ftth.on.nl] has quit [Disconnected by services] 20130818 13:52:48-!- asbfki is now known as {V} 20130818 13:57:21< _Coffee> is there a page that lists wesnoth/git-hub specific commands on the wiki? 20130818 13:58:00< _Coffee> seems like that might be a good idea if other people are like me and require googling to get stuff done with it 20130818 13:58:07< _Coffee> I'd be happy to contribute 20130818 13:58:36< _Coffee> I notice that there are heaps of "forks" in strange places when looking at the repository listings, so I can't be alone 20130818 13:59:07-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 13:59:34-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 14:01:09< irker761> wesnoth: David Mikos wesnoth-old:master 51a85d3d098b / src/unit_animation.cpp: Fix image modifications on hit and death animation WML not showing. Original bug http://git.io/TcjoyQ 20130818 14:01:11< irker761> wesnoth: David Mikos wesnoth-old:master 04d3bf3dd5a0 / po/ (9 files in 9 dirs): Merge branch 'master' of github.com:wesnoth/wesnoth-old http://git.io/BBo1JQ 20130818 14:07:08-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 14:07:27< shadowm> _Coffee: What do you mean forks in strange places? 20130818 14:07:33-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 14:07:57< _Coffee> shadowm: well, when creating a branch the way github recommends I had to "fork" the repository 20130818 14:08:04< shadowm> AI0867: Okay, and who would have to make a decision anyway? 20130818 14:08:17< _Coffee> and in doing so I noticed that other people have done this only maybe half the time 20130818 14:08:21< shadowm> _Coffee: Mainline developers don't need to fork. 20130818 14:08:38< _Coffee> there looks to be no simple process to follow for merging github "forks" 20130818 14:08:48< shadowm> There actually is. 20130818 14:09:28< _Coffee> still might help if there was a wiki IMO for those that want to fork and post online for comments from other developers 20130818 14:09:43< shadowm> https://help.github.com/articles/using-pull-requests 20130818 14:09:52< _Coffee> it is not obvious the changing of the repository url and such (to me anyways) 20130818 14:09:57< shadowm> But mainline developers do not need to fork or create pull requests. 20130818 14:10:43< _Coffee> how do you then show to other developers what you are doing? 20130818 14:11:03-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20130818 14:11:48< shadowm> You may create a fork on GitHub and work with that, or publish your own downstream repository through some private channel if your resources allow. 20130818 14:12:10< _Coffee> ok 20130818 14:12:26< _Coffee> but for maybe one-time contributers or future devs? 20130818 14:12:35< _Coffee> would it be useful to have a wiki page for that? 20130818 14:12:48< shadowm> Nothing of this is trivial and I personally think keeping things decidedly non-trivial help keep the amount of garbage/useless contributions relatively low/nil. 20130818 14:13:19< shadowm> As for one-time contributors or future developers the process is the usual, you may either fork and create pull requests or use patches.wesnoth.org. 20130818 14:14:07< shadowm> One-time contributors generally won't want to clone the > 1.6 GiB repo, anyway. 20130818 14:14:19< _Coffee> you're probably right 20130818 14:15:13< shadowm> So yeah, did you know that we are supposed to require Git-conforming commit messages? 20130818 14:15:48< shadowm> Maximum of 71 chars for the short introductory subject line, optionally blank line follows and then the full description of the commit, etc. 20130818 14:16:08< shadowm> I don't really care, but it does make it easier to look at things in git log --format=oneline. 20130818 14:16:40< _Coffee> shadowm: I've used git in the past with those kind of rules and it makes sense 20130818 14:16:42< shadowm> It also avoids GitHub or git format-patch mangling the first line. 20130818 14:17:13< _Coffee> just wondering if (for forgetful people ike me) you have them written down somewhere to make it easy 20130818 14:18:05-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer] 20130818 14:18:21< shadowm> I vaguely remember someone writing down the commit messages thing _somewhere_, but my memory's hazy atm. 20130818 14:18:44< shadowm> Ah yes, this: http://wiki.wesnoth.org/GoodCommitCommentingPractice 20130818 14:19:47< _Coffee> bookmarked, thanks 20130818 14:20:16< shadowm> Feel free to not follow point 3 onwards 20130818 14:20:45< shadowm> Also, you did not just have this conversation with me. 20130818 14:21:28< shadowm> Now, I heard something about a bug being fixed? 20130818 14:21:38< _Coffee> yeah, it is fixed here 20130818 14:21:45< _Coffee> the "dark elf" should work fine now 20130818 14:21:55< shadowm> It saddens me that I don't understand the diff at all. 20130818 14:22:45< _Coffee> assuming I did the right thing with git, there should be a simple change to the unit_animation file 20130818 14:22:49< AI0867> shadowm: anyone who feels comfortable throwing out something google paid 5 kUSD for? 20130818 14:22:53-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20130818 14:22:56< shadowm> I need coffee. 20130818 14:23:03< shadowm> Ah right, I can't drink coffee. 20130818 14:23:10-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 14:23:19< shadowm> I was going to complain about the bug not being fixed and then I realized I did not actually rebuild Wesnoth after pulling. 20130818 14:23:26< _Coffee> in changing to the progressive_image (or comma separated list) the filename was used instead of the whole string with the image mod applied also 20130818 14:23:34-!- {V} [~V@88.159.79.139] has joined #wesnoth-dev 20130818 14:23:35< _Coffee> this is fixed in the above commit 20130818 14:24:22< shadowm> I didn't know there was any code using image locators directly. 20130818 14:24:27< shadowm> s/any// 20130818 14:24:44< _Coffee> well, it just specified a string before, and that is why it worked 20130818 14:25:11< _Coffee> here it uses an array of image_locators, which had to be used insteado of string for existing code integration purposes 20130818 14:25:42< shadowm> Fix confirmed, thanks a bunch. :) 20130818 14:25:43< _Coffee> in the end a small patch, and you should see it working now 20130818 14:25:54-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev 20130818 14:25:54-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host] 20130818 14:25:54-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20130818 14:26:09< mordante> servus 20130818 14:26:48< shadowm> AI0867: I thought someone proposed at some point excising it from our source tree and publishing it separately for whoever might be interested. 20130818 14:27:20< shadowm> In practice the code is unused, which is nearly the same thing sans the excising. 20130818 14:28:04< shadowm> loonycyborg even worked on Boost.asio integration (sadly only for the add-ons client atm) after we decided ana was fundamentally broken. 20130818 14:28:59< shadowm> Although I'm not sure who and when made any attempt to contact the author about the issues, if ever; but I do believe the student went Internet-MIA after the period was over. 20130818 14:30:28< mordante> stikonas, has your patch been already applied? 20130818 14:30:36< mordante> already been* 20130818 14:31:55< AI0867> shadowm: I think the author already intended to do that? It may already be on google code 20130818 14:31:57< shadowm> _Coffee: Could we have a changelog entry, though? The changelog needs more love.... 20130818 14:32:06< shadowm> (Alternatively, the changelog needs to be put out of its misery.) 20130818 14:32:17< stikonas> mordante: not yet, I'll do another map and resubmit a large commit. I now know why you were not able to fetch 20130818 14:32:23< stikonas> it was a bug in git-daemon :( 20130818 14:32:32< stikonas> I was running it as a non-root user 20130818 14:32:48< shadowm> AI0867: Shurg. 20130818 14:32:49< stikonas> but it was still trying and failing to access /root/.config/git 20130818 14:33:09< mordante> stikonas, ok, and indeed fetching now works 20130818 14:33:28< AI0867> I can't find it though 20130818 14:33:56-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 256 seconds] 20130818 14:34:00< shadowm> Hey I just realized something. 20130818 14:34:09< shadowm> I use an IMAP client with a built-in search functionality. 20130818 14:34:29< shadowm> Ta-da: https://mail.gna.org/public/wesnoth-dev/2011-10/msg00027.html 20130818 14:34:41< stikonas> mordante: I've removed that commit from my repository, actually it should be empty now 20130818 14:34:58< stikonas> so don't pull from there yet :) 20130818 14:35:06< mordante> stikonas, it is, but I no longer get error messages when fetching 20130818 14:35:07< shadowm> AI0867: SO yeah, it is in Google Code. 20130818 14:35:47< stikonas> I had seen some strange message with 1.4 branch, so I decided to reclone the repository from github,,, 20130818 14:35:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20130818 14:36:28< Ivanovic> i got a problem with the pandora build of 1.11.6 20130818 14:36:31< shadowm> "Once feature freeze phase before 1.10 passes I plan to continue working on new network subsystem and I'd prefer to use asio directly." Said loonycyborg before being eaten by a rabid Windows-based system. 20130818 14:37:02< Ivanovic> it does not start, the cache creation is done, but at the point 'loading start menu' i get a crash with the following log output: 20130818 14:37:04< mordante> Ivanovic, can you pastebin the error message 20130818 14:37:04< Ivanovic> *** glibc detected *** ./bin/wesnoth: double free or corruption (!prev): 0x01a69d50 *** 20130818 14:37:37< mordante> let's see whether I can revive my pandora build 20130818 14:38:06< Ivanovic> building itself worked lovely, just running it does not after it has all the cache creation and such done 20130818 14:38:07< loonycyborg> I'm setting up a cross-compile environment on baldras atm :P 20130818 14:38:48-!- {V} [~V@88.159.79.139] has quit [Read error: Connection reset by peer] 20130818 14:39:13-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 14:40:10< Ivanovic> loonycyborg: what i am using for the pandora is the following installer script: http://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-misc.git;a=blob;f=sdk_installer/openpandora_toolchain.sh;h=ec984b886e99bd3eede1cfda71d2edb595b6fd81;hb=HEAD 20130818 14:40:24< mordante> :q 20130818 14:40:34< mordante> wrong window 20130818 14:41:18< loonycyborg> mordante: ^^ :P 20130818 14:41:39< mordante> loonycyborg, but you're going to debug it? 20130818 14:41:57< loonycyborg> I don't know anything about pandora 20130818 14:42:15< loonycyborg> I was talking about cross-compile environment for minw32 20130818 14:43:14< loonycyborg> Just now realized that pandora involves cross-compiling too 20130818 14:43:24< loonycyborg> I was responding to shadowm 20130818 14:43:59< mordante> ah ok 20130818 14:47:49< shadowm> libintl is gettext, right? 20130818 14:48:02< loonycyborg> YEs 20130818 14:49:09< loonycyborg> Anyway, I remember people were talking about static initialization fiasco here recently 20130818 14:49:23< loonycyborg> Maybe this is what causes pandora failures? 20130818 14:50:38< mordante> well my compiler is running, but will take some time haven't compiled for the pandora in ages 20130818 14:58:40< irker761> wesnoth: David Mikos wesnoth-old:master 911f0073942f / changelog: Changelog entry for 51a85d3d098b699a9ec0553ce6160701c4c8fcbb http://git.io/OWlVDQ 20130818 15:00:56-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20130818 15:02:14-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 15:02:39-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 15:19:51-!- stikonas_ [~gentoo@2002:514:c832:0:216:cfff:febb:f05] has joined #wesnoth-dev 20130818 15:19:51-!- stikonas_ [~gentoo@2002:514:c832:0:216:cfff:febb:f05] has quit [Changing host] 20130818 15:19:51-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130818 15:19:57-!- stikonas [~gentoo@5.20.200.50] has quit [Ping timeout: 264 seconds] 20130818 15:37:12-!- _Coffee [~david@ppp121-45-78-176.lns20.adl6.internode.on.net] has quit [Quit: Konversation terminated!] 20130818 15:53:02-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20130818 15:58:05-!- stikonas__ [~gentoo@5.20.200.50] has joined #wesnoth-dev 20130818 15:58:27-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: No route to host] 20130818 16:06:07-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130818 16:07:44< mordante> fabi, did you commit the yamg code? 20130818 16:10:39-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130818 16:15:16-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20130818 16:29:32-!- {V} [~V@139-79-ftth.on.nl] has quit [Ping timeout: 256 seconds] 20130818 16:30:09-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 16:35:59< mordante> Ivanovic, I can reproduce a crash, but there's no love between me and the debugger, it ignores my breakpoints :-( 20130818 16:37:46-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 16:38:12-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 16:40:36-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 276 seconds] 20130818 16:45:01< Ivanovic> :( 20130818 16:47:43-!- nurupo|away [~nurupo.ga@biribiri.org] has joined #wesnoth-dev 20130818 16:48:50-!- nurupo|away is now known as nurupo 20130818 16:48:50-!- nurupo [~nurupo.ga@biribiri.org] has quit [Changing host] 20130818 16:48:50-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20130818 16:49:36< mordante> well trying other ways to drive gdb into submission ;-) 20130818 16:53:14-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 16:53:46-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 16:57:15-!- stikonas__ is now known as stikonas 20130818 17:01:28-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 17:01:54-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 17:06:33-!- nurupo is now known as nurupo|away 20130818 17:07:07< _8680_> Is ~/src/wesnoth-old a reasonable default place to assume that people on Unix descendant systems with wesnoth-old clones will put their clones? 20130818 17:07:23-!- nurupo|away is now known as nurupo 20130818 17:07:35< mordante> _8680_, why? 20130818 17:08:50< shadowm> git clone foobar.git without an additional final argument will clone the repository into ./foobar, yes. 20130818 17:09:26< _8680_> mordante: For a script I have that uses wesnoth_addon_manager, which it currently defaults to looking for in ~/src/wesnoth-old/data/tools if no other location is given. 20130818 17:09:28-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 17:09:55-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 17:10:00< shadowm> Why don't you look for wam in PATH instead? 20130818 17:10:21< shadowm> Just... assume wam is in PATH, die otherwise. 20130818 17:10:35< mordante> _8680_, it's a horrible default, like any default location for this kind of thing 20130818 17:10:39< _8680_> I didn’t think most people would put Wesnoth tools in PATH. Is that a common practice? 20130818 17:11:12< shadowm> I think it's a reasonable possibility. Alternatively allow your mysterious script to take a path to wam? 20130818 17:11:42< shadowm> Or make it reasonably easy to alter the script to point it to wam. 20130818 17:12:04< _8680_> mordante: I wrote the script for me specifically, and that’s where I have it; this is the last thing that makes it still more for me specifically. 20130818 17:12:51< _8680_> shadowm: I think I will add an easily-changed variable with the default path at the start of the script. 20130818 17:13:38< shadowm> Dropping that kind of innocuous stuff in PATH generally makes things easier for me: http://pastebin.com/a9m6HE5s 20130818 17:14:02< _8680_> shadowm: The “mysterious script” is just a wrapper around wesnoth_addon_manager that performs some additional checks. I don’t know if I’ll actually release it, but I did want to make it more general. 20130818 17:14:21< shadowm> What kind of checks? 20130818 17:15:04 * _8680_ checks. 20130818 17:15:19< shadowm> (The logical conclusion to my approach might be a bit messy, though: http://pastebin.com/sdHU5Uzc ) 20130818 17:15:42< _8680_> Currently only that the version number has been bumped, since I forgot to do that a few times. 20130818 17:15:50< mordante> _8680_, using defaults that make no sense or for sense one developer specifically are a bad idea. 20130818 17:16:15< _8680_> mordante: Which is why I’m asking this. 20130818 17:16:54< mordante> so better have the user to specify the location and use a small script or alias for your local case 20130818 17:17:24< mordante> eg alias foo='bar ~/src/wesnoth-old/data/tools' 20130818 17:17:29< shadowm> Wait, how do you know whether the version number has been bumped? 20130818 17:17:29-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 17:17:53-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 17:17:57< shadowm> Oh right, you probably look into wam -l or something, never mind. 20130818 17:18:10< _8680_> shadowm: Yes. 20130818 17:18:13< shadowm> Yes, I will continue to call it wam. 20130818 17:18:28< shadowm> I don't like long application names. 20130818 17:19:10< shadowm> Especially not names that include underscores, since that's an extra keypress for me compared to hyphens. 20130818 17:20:54< _8680_> The main reason why I wrote the script was because I didn’t want to bother remembering what wesnoth_addon_manager’s parameters do, or looking them up every time I used it. 20130818 17:21:04< fabi> mordante: yes I did. 20130818 17:21:27< _8680_> (Not that, in general, I have a problem with learning how to use software properly.) 20130818 17:21:33< fabi> mordante: But it was modified later on by a pull request. 20130818 17:22:16< fabi> mordante: And lipk helped to make it cleaner. 20130818 17:22:18< shadowm> People have been misusing the Doxygen @ref command, I see. 20130818 17:22:26< shadowm> /home/shadowm/src/wesnoth/src/buffered_istream.hpp:25: warning: unable to resolve reference to `std::istream' for \ref command 20130818 17:22:29< shadowm> Et cetera. 20130818 17:22:34< mordante> fabi, did you write it or somebody else 20130818 17:22:42< fabi> mordante: pyrophorus 20130818 17:23:08< mordante> fabi, why not clean it before committing, the code is more C as C++ 20130818 17:23:10< shadowm> Okay, no, it's actually just src/buffered_istream.hpp that's included all over the place, plus some .cpp file. 20130818 17:24:20< fabi> mordante: I did clean it, and lipk did so as well. But I agree that it is still very low level. Especially that he always uses pointers and new. 20130818 17:24:30< shadowm> Oh, that's mordante's file. 20130818 17:24:52< shadowm> Oh well, that didn't stop me from fixing a comment in a GUI2 code file earlier. 20130818 17:25:08< fabi> shadowm: It was you mentioning that you could also make use of a proper ~ROTATE() image path function? 20130818 17:25:29< mordante> fabi, so why was it then committed if the code is not clean? 20130818 17:25:31-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 17:25:43< shadowm> fabi: I only said that regarding 90° transforms. 20130818 17:25:56-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 17:26:06< shadowm> Anything else will inevitably look like crap with pixel art regardless of the interpolation method used. 20130818 17:27:25< fabi> shadowm: Oh, okay. This is already implemented. I just lifted some simplified implementation of the "rotsprite" algorithm which is designed to rotate pixel art properly. The results are fine. 20130818 17:29:23< shadowm> Nah. 20130818 17:29:33< fabi> nah? 20130818 17:29:42 * shadowm nods. 20130818 17:30:21< fabi> The results of rotsprite are still looking like crap in your eyes? 20130818 17:31:06< shadowm> I don't know, I haven't seen them, and as with most things pixel-art, the results vary a lot from case to case. 20130818 17:31:52< shadowm> I personally don't need non-90° transforms at this time in Wesnoth. And I'll probably never need them either. 20130818 17:31:57< fabi> http://info.sonicretro.org/RotSprite 20130818 17:32:25< shadowm> Yeah, that's not really 'fine' in my view. 20130818 17:33:18< shadowm> It's very close, but every imperfection tends to count with pixel art. 20130818 17:33:32-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 17:33:44< shadowm> That is, assuming your quality standards are high enough. 20130818 17:33:56-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 17:34:00-!- mjs-de [~mjs-de@g224189083.adsl.alicedsl.de] has joined #wesnoth-dev 20130818 17:34:14< shadowm> Some people are just content with seeing colorful blobs on the screen. 20130818 17:35:58< fabi> I have these top down sprites I use in my total conversion. They original program is using rotation to produce all 6 directions since ages. But their result is far worse than what the rotsprite does. 20130818 17:36:31< shadowm> Yeah, you see, I actually draw things. 20130818 17:36:59< shadowm> I would not even _try_ to have a program produce pixel art transforms for me. 20130818 17:37:55< fabi> Well, maybe I should mention that rotsprite does not destroy team coloring. 20130818 17:37:59< shadowm> Anyway, you don't need to convince me. I have zero use for any such thing in Wesnoth atm, and I won't be creating any more original content running on the Wesnoth engine. 20130818 17:38:20< fabi> I do not want to convince you. 20130818 17:38:46< mordante> fabi, so why was it then committed if the code is not clean? 20130818 17:39:22< fabi> mordante: I have tested it and got no bugs. 20130818 17:40:07< fabi> mordante: Do we have a convention that calls pointer with new "unclean"? 20130818 17:40:13< mordante> fabi, that was not my question 20130818 17:40:35< fabi> mordante: Well, I have problem to understand your definition of "clean". 20130818 17:40:58< mordante> fabi, before you already said the code was not clean 20130818 17:41:09< fabi> I said that it is very low level. 20130818 17:41:26< mordante> "fabi> mordante: And lipk helped to make it cleaner." 20130818 17:41:32< fabi> You mentioned the word "clean". 20130818 17:41:34-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 17:42:01-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 17:42:09-!- gfgtdf [~chatzilla@f054144095.adsl.alicedsl.de] has joined #wesnoth-dev 20130818 17:42:37< fabi> mordante: It was unclean first, because it used variables not named to our conventions. I fixed that. Lipk replaced some more variable initialization that was done in the block with the c++ method of doing so. 20130818 17:42:39< mordante> fabi, we don't have a convention against pointers, but we do have coding standard 4.4 20130818 17:42:49< mordante> Write exception-safe code 20130818 17:42:59< mordante> this code is _not_ exception-safe 20130818 17:44:24< fabi> Yes, I thought so at first as well. 20130818 17:44:37-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 248 seconds] 20130818 17:45:05< fabi> I mean, I thought there might be problems with the memory management. 20130818 17:45:26< fabi> You assume that an exception might leave undeleted data structures? 20130818 17:45:50-!- nurupo|away [~nurupo.ga@biribiri.org] has joined #wesnoth-dev 20130818 17:46:11-!- nurupo|away is now known as nurupo 20130818 17:46:14-!- nurupo [~nurupo.ga@biribiri.org] has quit [Changing host] 20130818 17:46:14-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20130818 17:47:01< irker761> wesnoth: Ignacio R. Morelle wesnoth-old:master 0ee75fb0a9ba / src/buffered_istream.hpp: Doxygen comment fixes http://git.io/euhheQ 20130818 17:47:04< irker761> wesnoth: Ignacio R. Morelle wesnoth-old:master a16edac8c7fe / src/serialization/preprocessor.cpp: Doxygen comment fixes http://git.io/BbAvvA 20130818 17:50:30< mordante> fabi, for example, but there are also other memory related issue by using raw pointers 20130818 17:53:08< fabi> mordante: Would you clean up a little patch of the code for me? I could see how it is done and do the rest. I am not sure how to get rid of pointers produced by new or malloc properly. If I understand my compiler lesions well enough, new uses the heap while other variables are part of the function frame. 20130818 17:54:01< fabi> Structures on the heap life forever if not manually freed, right? 20130818 17:54:44< shadowm> fabi: Mind if I /query you? 20130818 17:55:13< fabi> shadowm: No, you do not need to ask, just go ahead. 20130818 17:59:19< mordante> fabi, why use a pointer to an array instead of std::vector 20130818 17:59:49< mordante> fabi, the code also ignores the rule of three 20130818 17:59:55< mordante> afk for a short while 20130818 18:03:15< shadowm> I'm done with the Doxygen format fixes for the foreseeable future. The rest ( http://pastebin.com/UDEa6ZdH ) is either Doxygen not understanding C++ (probably about 96% of the warnings) or people documenting things inconsistently. 20130818 18:04:44< shadowm> (There's at least one case of Doxygen not recognizing operator* as a valid method name.) 20130818 18:05:43-!- balrog [~balrog@discferret/developer/balrog] has quit [Read error: Operation timed out] 20130818 18:06:14< shadowm> (And regardless, I am sure my audience of 1 person will be pleased with just devdocs.wesnoth.org not being stuck in the past anymore, which was completely unrelated to any of this, caused by an obsolete path in a service script.) 20130818 18:06:42< shadowm> (i.e. everything else is just icing on the cake.) 20130818 18:13:16-!- asbfki [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 18:13:44-!- {V} [~V@139-79-ftth.on.nl] has quit [Disconnected by services] 20130818 18:26:00-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20130818 18:31:17-!- asbfki [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 18:31:44-!- asbfki [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 18:52:14-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 256 seconds] 20130818 18:56:37-!- EdB [~edb@85.69.144.96] has quit [Ping timeout: 248 seconds] 20130818 19:00:32< stikonas> mordante: can you try fetching that commit from me now? 20130818 19:01:13-!- Samual_ [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev 20130818 19:02:18-!- Samual [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 264 seconds] 20130818 19:03:49< irker761> wesnoth: loonycyborg wesnoth-old:master 634b0039f80e / SConstruct src/SConscript: Fixed scons configure checks for ming32 cross-compile http://git.io/feDkww 20130818 19:03:51< irker761> wesnoth: loonycyborg wesnoth-old:master e097cdc5c575 / src/windows_tray_notification.hpp: Fixed #includes of windows headers for cross-compile http://git.io/TbHHDg 20130818 19:05:19-!- Kostic [~marko@net85-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev 20130818 19:05:23-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20130818 19:08:40-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 256 seconds] 20130818 19:11:05-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20130818 19:40:52< irker761> wesnoth: Andrius Štikonas wesnoth-old:master 892463c52fb7 / / (6 files in 4 dirs): [Lithuanian Translation] Updated map localization of DiD and TSG. http://git.io/yw_KDA 20130818 19:41:10< mordante> stikonas, it worked properly now ^ 20130818 19:45:56-!- asbfki is now known as {V} 20130818 19:50:01-!- Kostic [~marko@net85-1-245-109.mbb.telenor.rs] has quit [Quit: Ex-Chat] 20130818 19:53:40-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 19:54:32< mordante> I'm off bye 20130818 19:54:32-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 19:55:14-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20130818 19:55:20-!- flix [~flix@91-66-31-1-dynip.superkabel.de] has joined #wesnoth-dev 20130818 19:55:44-!- balrog [~balrog@discferret/developer/balrog] has quit [Read error: Connection reset by peer] 20130818 19:57:05-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20130818 20:01:57-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer] 20130818 20:02:23-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 20:27:27< irker761> wesnoth: JaMiT wesnoth-old:master eca68863c352 / src/ (4 files in 2 dirs): Refactor game_events::manager::running(). http://git.io/GCoGeQ 20130818 20:27:29< irker761> wesnoth: JaMiT wesnoth-old:master 9abafef232fb / src/game_events/handlers.cpp: Simplify some code with utilss::join(). http://git.io/4pR7mQ 20130818 20:42:45-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 264 seconds] 20130818 20:50:15-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20130818 21:09:50-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving] 20130818 21:41:53-!- Kostic [~marko@net85-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev 20130818 22:09:16-!- Kostic [~marko@net85-1-245-109.mbb.telenor.rs] has quit [Ping timeout: 268 seconds] 20130818 22:11:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130818 22:11:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130818 22:28:53-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 240 seconds] 20130818 22:30:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130818 22:38:06-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 276 seconds] 20130818 22:38:59-!- asbfki [~V@139-79-ftth.on.nl] has joined #wesnoth-dev 20130818 22:39:23-!- {V} [~V@139-79-ftth.on.nl] has quit [Disconnected by services] 20130818 22:46:33-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20130818 22:53:12-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has joined #wesnoth-dev 20130818 23:01:06-!- trademark_ [~trademark@mne69-1-82-67-17-201.fbx.proxad.net] has quit [Ping timeout: 264 seconds] 20130818 23:07:30-!- exciton_ [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130818 23:07:38-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection] 20130818 23:11:23-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 240 seconds] 20130818 23:19:25-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has joined #wesnoth-dev 20130818 23:29:14-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection] 20130818 23:32:13-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has joined #wesnoth-dev 20130818 23:32:58-!- gfgtdf_ [~chatzilla@f054148062.adsl.alicedsl.de] has joined #wesnoth-dev 20130818 23:33:40-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection] 20130818 23:36:31-!- gfgtdf [~chatzilla@f054144095.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds] 20130818 23:36:39-!- gfgtdf_ is now known as gfgtdf 20130818 23:36:53-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has joined #wesnoth-dev 20130818 23:47:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20130818 23:48:06-!- esr [~esr@wesnoth/developer/esr] has quit [Read error: Operation timed out] 20130818 23:57:40-!- un214 [~un214@2602:306:ce4c:2949:224:8cff:fed2:ef57] has quit [Remote host closed the connection] --- Log closed Mon Aug 19 00:00:45 2013