--- Log opened Sat Sep 14 00:00:10 2013 --- Day changed Sat Sep 14 2013 20130914 00:00:10< nurupo> shadowm: works fine with unicode that wesnoth uses 20130914 00:00:40< nurupo> it displayed cyrillic correctly 20130914 00:02:53-!- irker487 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130914 00:03:55< shadowm> Yeah, I noticed that line. 20130914 00:04:16< shadowm> What I didn't notice is the specifics of how it goes. 20130914 00:04:18< shadowm> lstrcpy(nid->szInfoTitle, string_to_wstring(title).data()); 20130914 00:04:24< nurupo> i guess you can just `utils::string_to_wstring(title).data();`, don't remember why i made the windows_tray_notification::string_to_wstring 20130914 00:04:29< shadowm> Does the result of string_to_wstring() live through the lstrcpy() call? 20130914 00:04:48< nurupo> mabe because it ddn't work, but you could try :) 20130914 00:05:35< nurupo> shadowm: what do you mean? 20130914 00:05:44< shadowm> string_to_wstring() returns a temporary. 20130914 00:05:51< nurupo> string_to_wstring returns std::wstring 20130914 00:05:59< nurupo> and then you memcpy it 20130914 00:06:06< nurupo> into the struct 20130914 00:06:15< shadowm> That's not what I see in that line. 20130914 00:06:43< nurupo> doesn't lstrcpy copy wide char string into destination from the source? 20130914 00:06:46< shadowm> First string_to_wstring() returns a temporary, then you call the data() method on that temporary (which does not return a temporary, it returns a pointer to an internal field of that temporary instead). 20130914 00:07:00< nurupo> oh 20130914 00:07:08< nurupo> undestood 20130914 00:07:08< shadowm> So my question is whether the temporary still exists around the point the lstrcpy() call (as opposed to the evaluation of its arguments) takes place. 20130914 00:07:15< shadowm> That's the kind of thing about C++ that always gets me. 20130914 00:08:40< nurupo> i have no idea, i would guess that it exists until the whole statement, everything before ';', is executed 20130914 00:08:49< nurupo> but i don't know 20130914 00:08:57< shadowm> Anyway, the difference between both versions of string_to_wstring() is that the public one in utils returns a std::vector, whereas yours returns a std::wstring, which IIRC is a std::basic_string. 20130914 00:09:05-!- justinzane_ [~justinzan@216.7.117.181] has joined #wesnoth-dev 20130914 00:09:16< nurupo> correct 20130914 00:09:31< shadowm> Yeah, it is a std::basic_string here. 20130914 00:09:34-!- justinzane [~justinzan@tiny.justinzane.com] has quit [Ping timeout: 246 seconds] 20130914 00:11:38< nurupo> shadowm: continue. why are you bringing this up? that std::wstring is typedef of std::basic_string 20130914 00:12:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 00:12:12< shadowm> 19:04:22 i guess you can just `utils::string_to_wstring(title).data();`, don't remember why i made the windows_tray_notification::string_to_wstring 20130914 00:12:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:13:15< shadowm> I was just explaining why you had to make a separate version fo the function. std::vector does not have a data() method, that's a std::basic_string thing. 20130914 00:13:47< nurupo> doesn't std::vector.data() return wchar_t*? 20130914 00:14:26< nurupo> the one std::wstring::data() does 20130914 00:14:46< shadowm> Oh right, there is a data() method for vectors that returns the address of the front item. 20130914 00:15:16 * nurupo tries to remember why he converted the std::vector into std::wstring is all what he needed was wchar_t* 20130914 00:15:50< nurupo> that's why i said that probably i didn't work when i tested, for some reason 20130914 00:16:43-!- trademark [~trademark@37.161.90.59] has quit [Ping timeout: 260 seconds] 20130914 00:16:50< nurupo> not that i can test right now, i would have to set up the whole wesnoth build enviroment, which is not very wise thing to do, considering i have exams on monday and tuesday 20130914 00:18:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 00:18:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:18:27< shadowm> I am testing the internationalization fix here. 20130914 00:19:14< nurupo> on windows? 20130914 00:19:32< shadowm> Yeah. 20130914 00:19:39< nurupo> oh, then great :) 20130914 00:20:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 00:21:56< shadowm> Yeah, it works, but both OS X and Windows notifications suffer from a couple of additional internationalization issues. 20130914 00:23:17-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:24:01< nurupo> also, i remember making senders send their timestamps together with messages, so that receiver would use sender's timestamp. there were several problems with that, like one if sender has wrong timezone in OS set, which would cause problems. 02:00pm in UTC-9 and 02:00pm in UTC+9 display same system time, but have different timestamps 20130914 00:24:43< nurupo> the receiver could get messages from the past or future :) 20130914 00:25:08< nurupo> i wonder if that change still in the game or was removed 20130914 00:26:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 00:27:08< nurupo> oh, found it https://github.com/wesnoth/wesnoth-old/commit/7afab08eb799ac536d24f3b65021b14ba042fde4 20130914 00:28:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:28:52-!- flix [~flix@109.45.0.155] has quit [Remote host closed the connection] 20130914 00:29:04< shadowm> Now that I think of it yeah, that temporary lives through the lstrcpy() call, otherwise a lot of our gettext calls would be much more awkward. 20130914 00:33:19-!- exciton_ [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:33:53-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 240 seconds] 20130914 00:35:01-!- exciton_ [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 00:35:53< nurupo> shadowm: A temporary bound to a reference parameter in a function call (5.2.2) persists until the completion of the full expression containing the call. http://www.lcdf.org/c%2B%2B/clause12.html 20130914 00:36:40< nurupo> so everything is fine 20130914 00:38:17-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:39:37-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130914 00:40:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 00:41:06-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev 20130914 00:43:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:44:48-!- irker141 [~irker@ai0867.net] has joined #wesnoth-dev 20130914 00:44:48< irker141> wesnoth: Ignacio R. Morelle wesnoth-old:master 70cd18228242 / changelog src/game_display.cpp src/windows_tray_notification.cpp: Improve i18n of system tray notifications on Windows http://git.io/vjixpw 20130914 00:44:49< irker141> wesnoth: Ignacio R. Morelle wesnoth-old:master ac0e0b74a3b3 / changelog src/game_display.cpp: Improve i18n of app notifications on OS X http://git.io/s9H1jw 20130914 00:45:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20130914 00:45:33-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130914 00:45:59-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130914 00:46:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 00:46:31< shadowm> People on OS X should test that commit because I can't. 20130914 00:47:46< shadowm> Incidentally, can anyone besides Alarantalara here do that? Because I'd like to get a personal branch tested too. 20130914 00:48:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:48:57-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has joined #wesnoth-dev 20130914 00:48:59-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has quit [Changing host] 20130914 00:48:59-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130914 00:53:19-!- exciton_ [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 00:53:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20130914 00:53:53-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 240 seconds] 20130914 00:58:01-!- jetrel_laptop [~jetrel_la@64.215.234.33] has quit [Quit: jetrel_laptop] 20130914 01:01:52-!- SpoOkyMagician [~chatzilla@74-136-58-34.dhcp.insightbb.com] has joined #wesnoth-dev 20130914 01:03:04-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130914 01:03:53-!- exciton_ [chuck-the-@89.208.169.104] has quit [Ping timeout: 240 seconds] 20130914 01:04:30-!- mattsc [~mattsc@142.179.109.14] has joined #wesnoth-dev 20130914 01:05:32-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 01:10:08-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has joined #wesnoth-dev 20130914 01:10:08-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has quit [Changing host] 20130914 01:10:08-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130914 01:10:15-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai] 20130914 01:24:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20130914 01:33:16-!- mattsc [~mattsc@142.179.109.14] has quit [Quit: Ciao] 20130914 01:43:46-!- justinzane_ is now known as absent_justinzan 20130914 01:52:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20130914 01:53:09-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130914 01:53:12-!- absent_justinzan is now known as justinzane_ 20130914 01:59:11-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20130914 02:01:56-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has joined #wesnoth-dev 20130914 02:01:56-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has quit [Changing host] 20130914 02:01:56-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130914 02:06:28-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20130914 02:18:07-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130914 02:18:52-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has joined #wesnoth-dev 20130914 02:18:59-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has quit [Changing host] 20130914 02:19:00-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130914 02:21:11-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 260 seconds] 20130914 02:47:20-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130914 02:48:32-!- justinzane_ is now known as absent_justinzan 20130914 02:57:39-!- absent_justinzan is now known as justinzane_ 20130914 03:10:57-!- Molt [~elektron@47.23.35.74] has joined #wesnoth-dev 20130914 03:11:02< Molt> hey everyone! 20130914 03:11:10< fabi> hi Molt 20130914 03:11:39< _Coffee> hello 20130914 03:12:38< Molt> so I was in here the other day asking to contribute to development and got pointed in the right direction 20130914 03:12:53< Molt> i set up my development environment 20130914 03:13:02< Molt> and have a project in mind 20130914 03:13:38-!- justinzane_ is now known as absent_justinzan 20130914 03:14:12< Molt> i'm wondering where control of the hover-hex.png is 20130914 03:15:34< fabi> Molt: The image itself is defined in game_config.cfg. Most of the backend code is in display.cpp and mouse_event.cpp. 20130914 03:16:19< _Coffee> well it looks also like it is in game_display.cpp, line 289 and such hard coded 20130914 03:17:02< fabi> Molt: What do you want to do to it? :-) 20130914 03:17:30< Molt> ahh... mouse_even.cpp sounds like the right place for this, but I'll poke around in display.cpp as well 20130914 03:18:06< Molt> wanted to add a focus-hex.png that displays which character is currently in focus 20130914 03:18:21-!- absent_justinzan is now known as justinzane_ 20130914 03:18:37< Molt> or, rather what unit is in focus 20130914 03:18:59< _Coffee> not really my area but it does look like you could add that from game_display.cpp with drawing_buffer_add 20130914 03:19:11< fabi> You mean the selected unit 20130914 03:19:21< fabi> ? 20130914 03:19:27< Molt> yep 20130914 03:19:36< Molt> this insiped me: https://gna.org/bugs/?20962#cc 20130914 03:20:58< _Coffee> you can press 'n' to go to the next unit with move points left 20130914 03:21:23< _Coffee> I think this is what most players do 20130914 03:22:05< fabi> It is already marked by highlighting. Thus you could just add your additional hex frame in display::highlight_hex(). 20130914 03:22:20< Molt> yeah... i do that too, but you don't have a visual cue telling you what unit is actually in focus... they just end up in the middle of the screen 20130914 03:22:32< fabi> Or better display::select_hex() 20130914 03:22:43< Molt> fabi - exactly what I was thinking 20130914 03:22:55< fabi> You have a visual clue. 20130914 03:22:57< fabi> already 20130914 03:23:03< Molt> i already made a new png 20130914 03:23:06< Molt> :) 20130914 03:23:07< fabi> It really is highlighted. 20130914 03:24:05< fabi> And the ellipsis is also modified. 20130914 03:24:20< fabi> But I guess you want a stronger visual clue. 20130914 03:24:25< Molt> mtell me about it 20130914 03:24:38< Molt> oops... posted that in the wrong window 20130914 03:25:04< Molt> ok, back 20130914 03:25:56< Molt> naw... not sure you understand. So, there is the gold hex that shows you where your cursor is. that follows your cursor 20130914 03:26:35< Molt> what i want to do is leave that, but add another hex (this one slightly blue) over the unit in focus when you press 'n' 20130914 03:26:44< _Coffee> are you compiling from latest git source? 20130914 03:27:09< Molt> yeah 20130914 03:27:30< _Coffee> well, it looks like when your unit is not active to move then nothing is really selected 20130914 03:27:54< fabi> Molt: Yes, I got that. But what I said still stands. The selected unit and the hex field is highlighted, also the ellipsis under the unit is modified to give a visual clue. 20130914 03:28:28< _Coffee> do you mean when you click on a unit to move it? 20130914 03:29:08< fabi> _Coffee: Is your question for me? 20130914 03:29:20< _Coffee> well, either I suppose 20130914 03:29:37< _Coffee> normally when nothing is slected it doesn't matter which unit was last selected it seem to me 20130914 03:29:47< _Coffee> as you can't click to move it without selecting again 20130914 03:33:07-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev 20130914 03:33:34< fabi> jamit: Hurray :-) 20130914 03:33:43< fabi> jamit: Do you have some minutes? 20130914 03:33:58< jamit> Sure 20130914 03:34:25< fabi> jamit: Your work on [set_menu_item] introduced an evil segfault... 20130914 03:35:21< jamit> Bug 21127? http://gna.org/bugs/index.php?21127 20130914 03:36:04< fabi> jamit: Oh yes. I wasn't aware that it is already reported. 20130914 03:36:50< jamit> Can you check the pseudo-fix I posted there? I haven't reproduced the crash on my end yet. 20130914 03:37:10< fabi> jamit: Yes. I will do so immediately. 20130914 03:38:01< jamit> Thanks. The theory makes sense to me, so if someone can confirm it, I'll spend time fixing instead of trying to reproduce the bug. ;) 20130914 03:39:36< fabi> jamit: I can't find a file called handlers.cpp 20130914 03:39:58< jamit> fabi: In the game_events subdirectory? 20130914 03:39:59< fabi> ah, in game_eventsw 20130914 03:40:34< jamit> I should have mentioned that in the bug report. My bad. 20130914 03:41:05< fabi> Okay, compile is on the way. 20130914 03:42:14< fabi> jamit: bumbadabum has a test case in his addon. You could use it as a test case and to reproduce it. 20130914 03:42:55< fabi> jamit: Okay, the segfault is gone. 20130914 03:43:00< jamit> My theory is that a pointer to stack data is being accessed after the stack has unwound, which would account for an exact cause being tough to pin down through experimentation.. 20130914 03:43:40< jamit> fabi: Cool. I'm thinking the real culprit is actually in variable.hpp. 20130914 03:44:20< jamit> Give me a few hours to eat and see if that change is safe to make, memory-wise. 20130914 03:44:31< jamit> Probably in that order... :) 20130914 03:45:55-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130914 03:48:20< fabi> jamit: Sure, there is no need to hurry. The pseudo fix definitely does fix it for me now, the issue is no heisenbug, it was pretty constant. 20130914 03:48:55-!- justinzane_ is now known as absent_justinzan 20130914 03:50:15< fabi> absent_justinzan: Would you please configure your client to just mark you as being away, please? Just to avoid the extra traffic on the channel. 20130914 03:51:37-!- absent_justinzan is now known as justinzane_ 20130914 04:03:21-!- mjs-de [~mjs-de@d119094.adsl.hansenet.de] has quit [Remote host closed the connection] 20130914 04:05:19-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130914 04:13:09-!- justinzane_ is now known as absent_justinzan 20130914 04:14:28-!- absent_justinzan is now known as justinzane_ 20130914 04:16:42-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev 20130914 04:32:49< fabi> hi mattsc 20130914 04:33:05-!- justinzane_ is now known as absent_justinzan 20130914 04:52:09-!- Ivanovic_ [~ivanovic@x2f3e5da.dyn.telefonica.de] has joined #wesnoth-dev 20130914 04:53:03< mattsc> hi fabi 20130914 04:54:42-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 264 seconds] 20130914 04:54:44-!- absent_justinzan is now known as justinzane_ 20130914 04:56:03-!- Ivanovic_ is now known as Ivanovic 20130914 05:13:12-!- ancestral [~ancestral@65-128-232-98.mpls.qwest.net] has joined #wesnoth-dev 20130914 05:16:04-!- mattsc [~mattsc@154.20.32.246] has quit [Quit: Ciao] 20130914 05:21:32-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 256 seconds] 20130914 05:23:50-!- SpoOkyMagician [~chatzilla@74-136-58-34.dhcp.insightbb.com] has quit [Quit: later] 20130914 05:24:12< ancestral> shadowm: I hate building Wesnoth. Otherwise, I would help you. 20130914 05:24:42< ancestral> (Which, I realize, of itself, isn’t helpful : |) 20130914 05:26:21< ancestral> To whomever it may concern: Wesnoth runs on OS X 10.9 without issue for me (compared to 10.8) 20130914 05:26:52-!- ancestral [~ancestral@65-128-232-98.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.] 20130914 05:34:26-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20130914 05:40:52-!- justinzane_ is now known as absent_justinzan 20130914 05:41:26-!- absent_justinzan is now known as justinzane_ 20130914 05:54:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20130914 06:05:26-!- Molt [~elektron@47.23.35.74] has quit [] 20130914 06:14:21-!- nurupo is now known as nurupo|away 20130914 06:14:59-!- nurupo|away is now known as nurupo 20130914 06:46:20-!- ejls [~Epsilon01@mszy.fr] has quit [Ping timeout: 268 seconds] 20130914 06:46:20-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer] 20130914 06:46:28-!- nurupo is now known as nurupo|away 20130914 06:46:42-!- ejls [~Epsilon01@mszy.fr] has joined #wesnoth-dev 20130914 06:46:43-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130914 07:31:24-!- ivanovic_seattle [41796908@gateway/web/freenode/ip.65.121.105.8] has joined #wesnoth-dev 20130914 07:31:40-!- irker141 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130914 07:42:49-!- ivanovic_seattle [41796908@gateway/web/freenode/ip.65.121.105.8] has quit [Ping timeout: 250 seconds] 20130914 08:29:29-!- trademark [~trademark@37.161.36.168] has joined #wesnoth-dev 20130914 08:48:21< shadowm> justinzane_: Did you email me? 20130914 08:54:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds] 20130914 08:55:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20130914 09:00:35-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130914 09:00:40< justinzane_> yup 20130914 09:01:18< justinzane_> fabi: sorry 20130914 09:02:47< shadowm> justinzane_: Did you get your question answered in the meantime? 20130914 09:05:39< justinzane_> shadowm: no, what is the process, exactly, for submitting patches / pull requests? 20130914 09:06:42< justinzane_> shadowm: I got your email from github, where it says that contributers must be members of the Wesnoth group. Don't know what them means on github. 20130914 09:08:09< shadowm> We currently have two methods for accepting patches. The legacy one (which I think people aren't really watching much anymore) is submitting patches to http://patches.wesnoth.org/ following the instructions in http://wiki.wesnoth.org/PatchSubmissionGuidelines . The newer one is forking on GitHub, pushing commits to your fork (preferably in a branch, as that makes it easier for you to update your own pull requests and track our ... 20130914 09:08:15< shadowm> ... public branches without any complications), and then submitting pull requests to our own repository as needed. 20130914 09:08:47< shadowm> In both cases you are expected to follow our http://wiki.wesnoth.org/CodingStandards for C++ code. 20130914 09:09:43< shadowm> Promising contributors who have gotten multiple patches/pull requests merged in mainline may be offered commit access to our repository. 20130914 09:10:46< shadowm> justinzane_: Not sure how you got my email, though. :) I've never been very involved with the process of managing new contributions from coders, except when their patches are targeting areas I've worked with in the past. 20130914 09:14:24< justinzane_> shadowm: its listed right on github... 20130914 09:16:32< justinzane_> Ok, I'll just start pushing to my fork under a new branch. 20130914 09:17:43< shadowm> As for how to use pull requests, GitHub has some documentation on the matter here: https://help.github.com/articles/using-pull-requests 20130914 09:18:05< shadowm> That is, in case you're in doubt as to how to make one. 20130914 09:20:18< justinzane_> shadowm: No, that I get. Just wanted to make sure that that was your (plural) intended workflow. I've been yelled at for submittint pull reqs for other projects that want patches e-mailed to a list, or some other process. 20130914 09:20:40< shadowm> AI0867, Ivanovic: I'm going to update our repository description from "Pre-reconversion repository. Matches the one on sourceforge." (I wrote that when I was trying to prove a point about GitHub) to "Free, turn-based strategy game with a high fantasy theme, featuring both single-player, and online/hotseat multiplayer combat." 20130914 09:21:22< shadowm> It's amazing nobody had pointed out that yet. 20130914 09:22:57< justinzane_> I'm on the US WEst Coast, and I get the impression that some? many? of you are European. What times (UTC) are the best for finding folks here that are knowledgeable about the c++ codebase? 20130914 09:22:58< shadowm> justinzane_: Ah, I understand. We certainly don't use our mailing list for patches these days, if it's any reassurance, and I've seen a lot of pull requests merged in mainline since we moved to GitHUb. 20130914 09:23:17< justinzane_> shadowm: perfect! and thanks. 20130914 09:24:12< shadowm> Most of our developers live in Western and Central Europe, but many of us also look at the IRC logs for this channel (cf topic) and answer questions made in our absence. 20130914 09:25:32< shadowm> So that'd be UTC+00 through UTC+03. No idea about specific IRCing schedules though, that varies a lot. 20130914 09:30:31< justinzane_> thanks. 20130914 09:33:00< justinzane_> silly question, but has anyone ever built wesnoth with llvm/clang? 20130914 09:34:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20130914 09:36:45< thunderstruck> justinzane_: I know that mordante did. 20130914 09:38:00< thunderstruck> He explained how to do a few days ago here, in IRC, if you're using cmake. 20130914 09:38:05< thunderstruck> how to do it* 20130914 09:40:13< justinzane_> rhanks 20130914 09:40:22< justinzane_> uh, thanks 20130914 09:41:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20130914 09:44:56-!- Kostic [~marko@85.202.113.79] has joined #wesnoth-dev 20130914 09:45:43< shadowm> " CMake Error: your C compiler: "/usr/bin/ccache clang" was not found. Please set CMAKE_C_COMPILER to a valid compiler path or name. 20130914 09:45:50< shadowm> cmake hates me. 20130914 09:48:05< shadowm> If there's some way of including ccache in the command line other than providing it as the compiler and sticking clang in CMAKE_*_FLAGS and hoping for the best, I'd love to hear of it. 20130914 09:50:26< shadowm> I see this recipe doesn't allow me to stick -march=native in CMAKE_CXX_FLAGS either. Ah, this must be why I've been using scons for so long. 20130914 09:52:11< thunderstruck> shadowm: If you'll figure out how to use clang with scons, please tell me. 20130914 09:54:14-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20130914 09:54:14-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host] 20130914 09:54:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130914 10:01:11-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20130914 10:06:30-!- mjs-de [~mjs-de@d119094.adsl.hansenet.de] has joined #wesnoth-dev 20130914 10:09:42< shadowm> It is probably worth noting that Wesnoth won't build in strict mode using clang 3.2 at the moment: http://pastebin.com/Rg39reQn 20130914 10:10:32< shadowm> (i.e. disable ENABLE_STRICT_COMPILATION) 20130914 10:11:06-!- Kostic [~marko@85.202.113.79] has quit [Quit: Ex-Chat] 20130914 10:11:25-!- Kostic [~marko@85.202.113.206] has joined #wesnoth-dev 20130914 10:14:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130914 10:20:56-!- bumbadadabum_ [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20130914 10:20:58-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer] 20130914 10:21:15-!- bumbadadabum_ is now known as bumbadadabum 20130914 10:27:53-!- trademark [~trademark@37.161.36.168] has quit [Read error: Connection reset by peer] 20130914 10:45:01-!- trademark [~trademark@37.160.125.183] has joined #wesnoth-dev 20130914 10:45:23-!- mjs-de [~mjs-de@d119094.adsl.hansenet.de] has quit [Ping timeout: 262 seconds] 20130914 10:45:44-!- mjs-de [~mjs-de@g224178096.adsl.alicedsl.de] has joined #wesnoth-dev 20130914 10:46:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20130914 10:52:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20130914 11:05:26-!- trademark [~trademark@37.160.125.183] has quit [Ping timeout: 256 seconds] 20130914 11:17:38-!- trademark [~trademark@37.161.147.165] has joined #wesnoth-dev 20130914 11:27:05-!- molgrum [~molgrum@c83-249-40-178.bredband.comhem.se] has joined #wesnoth-dev 20130914 11:40:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130914 11:47:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20130914 12:00:33-!- esr [~esr@wesnoth/developer/esr] has quit [Read error: Connection reset by peer] 20130914 12:04:32-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: Lost terminal] 20130914 12:05:09-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20130914 12:05:09-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20130914 12:05:09-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20130914 12:13:09< trademark> thunderstruck, I don't know if you found, but I use the command: scons cxxtool=clang++ 20130914 12:16:13< thunderstruck> trademark: Thanks, you saved me a bit of time, 'cause I haven't tried to find it yet. 20130914 12:25:49-!- mjs-de [~mjs-de@g224178096.adsl.alicedsl.de] has quit [Remote host closed the connection] 20130914 12:27:33-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20130914 12:30:10-!- _8680_ [~8680@2002:4404:712c:0:745f:fa15:2fec:6b63] has quit [Ping timeout: 246 seconds] 20130914 12:30:11-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 260 seconds] 20130914 12:32:00-!- Guest50270 [~8680@2002:4404:712c:0:a001:d5a:5d6e:ef17] has joined #wesnoth-dev 20130914 12:40:14-!- Guest50270 [~8680@2002:4404:712c:0:a001:d5a:5d6e:ef17] has quit [Ping timeout: 240 seconds] 20130914 12:41:17-!- _8680__ [~8680@2002:4404:712c:0:ec0b:5759:3833:201c] has joined #wesnoth-dev 20130914 12:46:45-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has joined #wesnoth-dev 20130914 12:50:21-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has quit [Read error: Connection reset by peer] 20130914 12:54:21-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving] 20130914 12:54:55-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130914 12:56:52-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has joined #wesnoth-dev 20130914 12:57:33-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Client Quit] 20130914 12:57:53-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130914 12:57:55-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20130914 12:59:48-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has quit [Read error: Connection reset by peer] 20130914 13:06:50< Soliton> thunderstruck: looks like notify_next_scenario was deprecated as sent from the host, not in general. 20130914 13:07:56< Soliton> thunderstruck: your commit looks good, though i don't know what "unnotified" means. 20130914 13:08:38-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20130914 13:08:52< thunderstruck> Soliton: Well, non-host players need to be notified when next scenario data is available so that "End Turn/End Scenario" button can be enable. 20130914 13:09:07< Soliton> exactly. 20130914 13:09:16< thunderstruck> If that is not happening, they are able to press the button and bad things happen. 20130914 13:09:28< Soliton> that part is not deprecated. 20130914 13:10:35< thunderstruck> Alright. So, it was just broken, I assume. 20130914 13:12:20< Soliton> what was broken? it seems to me you changed things so start_game() is not called when advancing and thus no notification was sent anymore. 20130914 13:16:44< thunderstruck> Soliton: When did I change that? 20130914 13:17:31< thunderstruck> The broken thing was that "notify_next_scenario" was never sent and so the button was not enabled (neither was disabled, but that was other problem) 20130914 13:18:13< thunderstruck> Soliton: Wait. 20130914 13:18:40< thunderstruck> Soliton: I remember now, 20130914 13:18:55< thunderstruck> those things must have broken than I changed server's protocol for a first time. 20130914 13:19:01-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has joined #wesnoth-dev 20130914 13:19:11< thunderstruck> But I didn't notice that, because another bug was hiding it. 20130914 13:20:35-!- Gallaecio [~quassel@84.120.219.21.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 20130914 13:20:54-!- EdB [~edb@abo-152-221-68.trs.modulonet.fr] has joined #wesnoth-dev 20130914 13:33:38< thunderstruck> Soliton: I'm thinking that a similar guard as "notify_next_scenario" could be added to avoid causing OOS when players advance to the next scenario and end turn before all other players had advanced. 20130914 13:52:55-!- Ardonik [~ardonik@adsl-75-28-98-226.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev 20130914 13:58:27< Soliton> why does that cause OOS? 20130914 13:59:14-!- rei4dan [~reinis@87.110.9.112] has quit [Quit: WeeChat 0.4.1] 20130914 14:08:20-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has quit [Read error: Connection reset by peer] 20130914 14:08:31-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has joined #wesnoth-dev 20130914 14:09:27 * Soliton is gone for the day. 20130914 14:09:38-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 0.4.0] 20130914 14:10:12-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20130914 14:12:38-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has quit [Ping timeout: 240 seconds] 20130914 14:22:24-!- Gallaecio [~quassel@84.120.219.21.dyn.user.ono.com] has joined #wesnoth-dev 20130914 14:31:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130914 14:44:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Operation timed out] 20130914 14:46:05-!- Kostic [~marko@85.202.113.206] has quit [Quit: Ex-Chat] 20130914 15:07:37-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has joined #wesnoth-dev 20130914 15:07:54-!- EdB [~edb@abo-152-221-68.trs.modulonet.fr] has quit [Quit: Konversation terminated!] 20130914 15:11:20-!- stikonas [~gentoo@host-89-241-167-135.as13285.net] has joined #wesnoth-dev 20130914 15:11:20-!- stikonas [~gentoo@host-89-241-167-135.as13285.net] has quit [Changing host] 20130914 15:11:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130914 15:18:22-!- _Coffee [~david@ppp121-45-78-176.lns20.adl6.internode.on.net] has quit [Quit: Konversation terminated!] 20130914 15:28:25-!- ivanovic-seatle [41796908@gateway/web/freenode/ip.65.121.105.8] has joined #wesnoth-dev 20130914 15:28:42-!- flix [~flix@ip-109-45-0-155.web.vodafone.de] has quit [Read error: Connection reset by peer] 20130914 15:29:19< fabi> justinzane_: No problem, its no big deal. 20130914 15:29:31< fabi> s/its/it's 20130914 15:51:26-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20130914 16:19:10-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130914 16:21:42-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev 20130914 16:21:42-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host] 20130914 16:21:42-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20130914 16:21:58< mordante> servus 20130914 16:24:39< mordante> justinzane_, found out how to use clang with cmake? 20130914 16:25:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 261 seconds] 20130914 16:45:19-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 246 seconds] 20130914 16:46:48< ivanovic-seatle> hi mordante 20130914 16:47:17< mordante> hi ivanovic-seatle 20130914 16:47:29< mordante> ivanovic-seatle, on a business trip? 20130914 16:58:44-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130914 17:04:56< ivanovic-seatle> mordante: yeah 20130914 17:05:05< ivanovic-seatle> will visit Dave tomorrow 20130914 17:06:40< mordante> ivanovic-seatle, nice, have fun 20130914 17:06:46< ivanovic-seatle> so if anything wesnoth relate is up which required my attention: better send me a mail, i won't log into my bouncer until back in germany next saturday 20130914 17:07:28< mordante> no problem, I don't expect anything urgent 20130914 17:07:36< ivanovic-seatle> Crab_, mordante: please keep in mind that GSoC is almost over, communicate this to your students 20130914 17:07:48< ivanovic-seatle> and be ready to fill out all those lovely end evaluations, too 20130914 17:08:40< mordante> ivanovic-seatle, I will, haven't forgotten about it ;-) 20130914 17:08:59< ivanovic-seatle> :) 20130914 17:19:01-!- irker229 [~irker@ai0867.net] has joined #wesnoth-dev 20130914 17:19:01< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 9a6f3d628dec / src/umcd/database/ (database_query.cpp database_query.hpp database_server_type.hpp): Put the database-specific query into a dedicated class and add define/header to http://git.io/EH2H8Q 20130914 17:19:01< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 6fda586fa1d3 / src/ (4 files in 3 dirs): Retreive the ID of the inserted add-on. http://git.io/XREy-w 20130914 17:29:06< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 80f9bf95f370 / data/umcd/license_header.txt: Add the license_header file to put in the top of the generated files. http://git.io/0jiQ4w 20130914 17:32:47-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20130914 17:36:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 17:36:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 17:50:48-!- travis-ci [~travis-ci@ec2-107-22-147-69.compute-1.amazonaws.com] has joined #wesnoth-dev 20130914 17:50:48< travis-ci> [travis-ci] wesnoth/wesnoth-old#556 (asio_umcd - 6fda586 : Pierre T): The build is still failing. 20130914 17:50:48< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11360066 20130914 17:50:48-!- travis-ci [~travis-ci@ec2-107-22-147-69.compute-1.amazonaws.com] has left #wesnoth-dev [] 20130914 17:53:03< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd fe77f6604cbe / src/umcd/boost/asio/asio.hpp: Add a workaround for old Boost version that have not the async_connect function. http://git.io/eBh3rg 20130914 17:58:06-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 264 seconds] 20130914 17:59:17-!- travis-ci [~travis-ci@ec2-67-202-33-142.compute-1.amazonaws.com] has joined #wesnoth-dev 20130914 17:59:17< travis-ci> [travis-ci] wesnoth/wesnoth-old#557 (asio_umcd - 80f9bf9 : Pierre T): The build is still failing. 20130914 17:59:17< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11360278 20130914 17:59:17-!- travis-ci [~travis-ci@ec2-67-202-33-142.compute-1.amazonaws.com] has left #wesnoth-dev [] 20130914 18:03:23-!- ivanovic-seatle [41796908@gateway/web/freenode/ip.65.121.105.8] has quit [Ping timeout: 250 seconds] 20130914 18:07:27-!- qal [~sabban@reverse-62.fdn.fr] has quit [Ping timeout: 276 seconds] 20130914 18:07:55-!- lobby [~wesnoth@wesnoth/bot/lobby] has quit [Ping timeout: 246 seconds] 20130914 18:08:05-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20130914 18:08:05-!- Topic for #wesnoth-dev: current repo: https://github.com/wesnoth/wesnoth-old (Please read the dev-ml for the latest status!) | 0 bugs, 0 feature requests, 0 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20130914 18:08:05-!- Topic set by Ivanovic [~ivanovic@wesnoth/developer/ivanovic] [Sat Aug 24 14:34:05 2013] 20130914 18:08:05[Users #wesnoth-dev] 20130914 18:08:05[ _8680__ ] [ DHost ] [ Gambit ] [ justinzane_] [ Rhonda ] [ tomreyn ] 20130914 18:08:05[ AI0867 ] [ ejls ] [ happygrue_] [ knotwork ] [ Samual ] [ trademark] 20130914 18:08:05[ apoi ] [ elias ] [ Ingmar ] [ lobby ] [ shadowm ] [ Upth ] 20130914 18:08:05[ Ardonik ] [ EliDupree] [ irker229 ] [ loonycyborg] [ shikadibot ] [ Upthorn ] 20130914 18:08:05[ balrog ] [ enchilado] [ Ivanovic ] [ Mara_Jade ] [ Smar ] [ vultraz ] 20130914 18:08:05[ boucman ] [ esr ] [ iwaim__ ] [ melinath ] [ Soliton ] [ wesbot ] 20130914 18:08:05[ bumbadadabum ] [ exciton ] [ jamit ] [ molgrum ] [ thunderstruck] [ yann ] 20130914 18:08:05[ cjhopman_ ] [ fabi ] [ janebot ] [ mordante ] [ timotei__ ] [ zookeeper] 20130914 18:08:05[ crimson_penguin] [ Gallaecio] [ Jetrel_new] [ nurupo|away] [ ToBeFree ] [ {V} ] 20130914 18:08:05-!- Irssi: #wesnoth-dev: Total of 54 nicks [0 ops, 0 halfops, 0 voices, 54 normal] 20130914 18:08:11-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009 20130914 18:08:47-!- qal [~sabban@reverse-62.fdn.fr] has joined #wesnoth-dev 20130914 18:09:13-!- Irssi: Join to #wesnoth-dev was synced in 76 secs 20130914 18:18:22-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20130914 18:19:16-!- travis-ci [~travis-ci@ec2-107-22-147-69.compute-1.amazonaws.com] has joined #wesnoth-dev 20130914 18:19:17< travis-ci> [travis-ci] wesnoth/wesnoth-old#558 (asio_umcd - fe77f66 : Pierre T): The build is still failing. 20130914 18:19:17< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11360722 20130914 18:19:17-!- travis-ci [~travis-ci@ec2-107-22-147-69.compute-1.amazonaws.com] has left #wesnoth-dev [] 20130914 18:21:42< anonymissimus> shadowm: so, how did you test those i18n commits ? 20130914 18:27:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20130914 18:29:38-!- nurupo|away is now known as nurupo 20130914 18:35:18-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20130914 18:35:39< shadowm> anonymissimus: I did not test the OS X one. I stated so in the channel. 20130914 18:36:16< shadowm> For the Windows commit I just started a local game of AI vs AI and let it run in the background. 20130914 18:38:01< anonymissimus> I'm interested in the build systems; you said that MSVC crashes at the start 20130914 18:38:01< shadowm> I'm using Code::Blocks on Windows 7. 20130914 18:38:01< anonymissimus> and you didn't build with MnGw, did you ? 20130914 18:38:01< anonymissimus> ah ok 20130914 18:38:29< anonymissimus> perhaps vultraz can test OS X 20130914 18:39:00< shadowm> Yeah, he said "busy" and "sometime" last time I asked. 20130914 18:39:36< vultraz> yes 20130914 18:39:39< vultraz> busy playing dota 20130914 18:39:50< shadowm> See? Busy. (...) 20130914 18:40:04< anonymissimus> or mattsc 20130914 18:40:18< vultraz> but O 20130914 18:40:26< vultraz> I'll see what I can do tomorrow 20130914 18:44:06< anonymissimus> vultraz: as a user of one of the lesser used build systems, you should feel a special responsibility to help the project in such cases :P 20130914 18:44:25< bumbadadabum> It works with scons :p 20130914 18:44:59< vultraz> as I said, I'll see what I can do tomorrow :P 20130914 18:49:58< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 1322b8575523 / src/umcd/boost/asio/asio.hpp: Change the connect_handler interface, pass the first endpoint. http://git.io/6xiyWA 20130914 18:50:00< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 1443507af78d / .travis.yml: Disable compilation under Travis, the support of scons is cancelled or, at least http://git.io/PfSu3g 20130914 18:52:38< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 2c376f2f9cb1 / src/umcd/boost/asio/asio.hpp: Change the namespace boost::asiop to boost::asio. And uncomment define. http://git.io/7o5hAg 20130914 18:59:46-!- Ard0nik [~ardonik@adsl-75-28-107-126.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev 20130914 19:01:13-!- knotwork_ [~markm@142.68.212.59] has joined #wesnoth-dev 20130914 19:01:13-!- knotwork_ [~markm@142.68.212.59] has quit [Changing host] 20130914 19:01:13-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20130914 19:02:16< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 36a6891a258f / src/umcd/boost/asio/asio.hpp: Uncomment define. http://git.io/8qzseg 20130914 19:02:18< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 3200323cb1de / src/tools/code_generator/sql2cpp/ (6 files in 2 dirs): Add support of the datetime keyword. http://git.io/s1JPPA 20130914 19:02:20< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd 47674194549f / data/umcd/database/create_database.sql: Minor modifications of the schema. http://git.io/1cAJSw 20130914 19:02:22< irker229> wesnoth: Pierre T wesnoth-old:asio_umcd a9d830f7bf06 / src/umcd/client/client.hpp: Use our custom asio header and add comments on the async_connect workaround. http://git.io/GFqpWA 20130914 19:02:38-!- Ardonik [~ardonik@adsl-75-28-98-226.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 256 seconds] 20130914 19:04:31-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 260 seconds] 20130914 19:08:13-!- knotwork__ [~markm@142.68.141.101] has joined #wesnoth-dev 20130914 19:08:13-!- knotwork__ [~markm@142.68.141.101] has quit [Changing host] 20130914 19:08:13-!- knotwork__ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20130914 19:09:46< irker229> wesnoth: Mark de Wever wesnoth-old:asio_umcd 8db4b67250ba / src/umcd/protocol/core/header_data_stream.cpp: Add a missing include. http://git.io/yWS9Tg 20130914 19:11:02-!- knotwork_ [~markm@unaffiliated/knotwork] has quit [Ping timeout: 264 seconds] 20130914 19:12:40< irker229> wesnoth: JaMiT wesnoth-old:master 1124f0c8d0a7 / src/gamestatus.cpp: Use references in case a compiler does not perform copy elision. http://git.io/Pis2og 20130914 19:12:42< irker229> wesnoth: JaMiT wesnoth-old:master 04c0a8f01193 / src/ (gamestatus.cpp variable.cpp variable.hpp): Force vconfig members of wml_menu_item to manage their own memory. http://git.io/rEi0uw 20130914 19:12:44< irker229> wesnoth: JaMiT wesnoth-old:master b79a908d065f / src/ (variable.cpp variable.hpp): No reason to qualify a non-ref return value as "const". http://git.io/3gacrA 20130914 19:13:29< irker229> wesnoth: JaMiT wesnoth-old:master f3b5bfc4019d / src/game_events/action_wml.cpp: Use references in case a compiler does not perform copy elision. http://git.io/tjsRig 20130914 19:13:29< irker229> wesnoth: JaMiT wesnoth-old:master 6f34cdee83b7 / src/game_events/action_wml.cpp: Take advantage of vector::front() returning a reference. http://git.io/SACfqw 20130914 19:14:39-!- trademark [~trademark@37.161.147.165] has quit [Read error: Connection reset by peer] 20130914 19:15:53-!- travis-ci [~travis-ci@ec2-107-20-119-51.compute-1.amazonaws.com] has joined #wesnoth-dev 20130914 19:15:58< travis-ci> [travis-ci] wesnoth/wesnoth-old#559 (asio_umcd - 1443507 : Pierre T): The build was fixed. 20130914 19:15:59< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11361895 20130914 19:15:59-!- travis-ci [~travis-ci@ec2-107-20-119-51.compute-1.amazonaws.com] has left #wesnoth-dev [] 20130914 19:15:59-!- Turuk [~Turuk@cpe-65-29-217-233.cinci.res.rr.com] has joined #wesnoth-dev 20130914 19:18:26-!- travis-ci [~travis-ci@ec2-107-22-147-69.compute-1.amazonaws.com] has joined #wesnoth-dev 20130914 19:18:26< travis-ci> [travis-ci] wesnoth/wesnoth-old#560 (asio_umcd - 2c376f2 : Pierre T): The build was fixed. 20130914 19:18:26< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11361930 20130914 19:18:26-!- travis-ci [~travis-ci@ec2-107-22-147-69.compute-1.amazonaws.com] has left #wesnoth-dev [] 20130914 19:34:26-!- travis-ci [~travis-ci@67.202.33.142] has joined #wesnoth-dev 20130914 19:34:26< travis-ci> [travis-ci] wesnoth/wesnoth-old#561 (asio_umcd - a9d830f : Pierre T): The build was fixed. 20130914 19:34:26< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11362219 20130914 19:34:26-!- travis-ci [~travis-ci@67.202.33.142] has left #wesnoth-dev [] 20130914 19:34:27-!- BatmanGambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20130914 19:35:02-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 264 seconds] 20130914 19:41:41-!- travis-ci [~travis-ci@ec2-107-22-147-69.compute-1.amazonaws.com] has joined #wesnoth-dev 20130914 19:41:41< travis-ci> [travis-ci] wesnoth/wesnoth-old#562 (asio_umcd - 8db4b67 : Mark de Wever): The build was fixed. 20130914 19:41:41< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11362452 20130914 19:41:41-!- travis-ci [~travis-ci@ec2-107-22-147-69.compute-1.amazonaws.com] has left #wesnoth-dev [] 20130914 19:52:46< anonymissimus> shadowm: I dunno; the ballon I get over the tray icon still says English "chat message"... 20130914 19:53:08< anonymissimus> but I don't care anyway 20130914 19:53:38< shadowm> Yeah, because it's not in the translation catalogues yet. 20130914 19:53:43< anonymissimus> perhaps the string is no where translated, yes 20130914 19:54:06< shadowm> "Turn changed" was, though, and it was already translated in Spanish, because it's referenced from a call to the notifications code in playmp_controller.cpp or so. 20130914 19:54:56< shadowm> *to Spanish 20130914 19:58:09-!- trademark [~trademark@37.160.41.17] has joined #wesnoth-dev 20130914 20:02:01-!- BatmanGambit is now known as Gambit 20130914 20:10:31< anonymissimus> jamit: now I finally understand some more what this mysterious is_volatile parameter means! :) 20130914 20:11:14< trademark> loonycyborg, hello, it seems you are the scons master around, I'd have a request to make the umcd build with scons 20130914 20:12:00< anonymissimus> jamit: so hte problem was that the config the show_if_/filter_location_ came from did no longer exist in memory at the point wml_menu_item::to_config was called ? 20130914 20:12:30< loonycyborg> trademark: hmm, isn't it already fixed according to travis? :P 20130914 20:14:10< anonymissimus> jamit: and yes, I hope you've fixed all the places where you better had put references now 20130914 20:16:40< trademark> loonycyborg, I just removed the umcd target 20130914 20:17:17< loonycyborg> trademark: kinda busy now, will look into it later, by checking out that branch 20130914 20:17:53< trademark> loonycyborg, no problem it doesn't urge. But I'll need to tell you what you need to do, because it's not obvious, unless you watch in the cmake file. 20130914 20:18:28-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 246 seconds] 20130914 20:18:29< anonymissimus> and why is the word "volatile" if it means "maintain your own memory" ? it should rather be called "stable" or "independent" or the like 20130914 20:21:37< thunderstruck> Can someone assign me to this bug https://gna.org/bugs/?21135 ? 20130914 20:22:27< thunderstruck> Or give me rights to do it myself? 20130914 20:25:37< anonymissimus> thunderstruck: you need to make a gna account, send a request to get membership, and be granted membership by a project admin 20130914 20:25:47< anonymissimus> such as Ivanovic 20130914 20:32:04< jamit> anonymissimus: I figured I might as well document what I learned about is_volatile. :) And right, the config no longer existed at that point. 20130914 20:32:07< thunderstruck> Ivanovic, ivanovic-seatle: in case you won't be notified, I sent a request on gna! for a membership. 20130914 20:32:18< anonymissimus> jamit: alright, fixed here 20130914 20:33:34< jamit> anonymissimus: I don't know if I added all the references possible. Those were just ones I had encountered while seeing if I should change the default for is_volatile. (It was too big a task, so I stopped midway through.) 20130914 20:34:09< anonymissimus> jamit: yes, I think think there could be some more documentation such as "setting is_volatile to true causes this vconfig to keep around a copy of the config it was constructed from, so that it is independent from the memory of the config it came from in case that config is destructed" 20130914 20:34:36< anonymissimus> that's basically what I was looking for when I wanted to understand that parameter and found absolutely nothing 20130914 20:35:06< jamit> anonymissimus: I'll take another look at documentation later. I'm about to run out for a bit. 20130914 20:35:11< anonymissimus> I hope that was roughly correct 20130914 20:35:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20130914 20:35:33< anonymissimus> and the translation of the word confused me additionally 20130914 20:36:53-!- Turuk [~Turuk@cpe-65-29-217-233.cinci.res.rr.com] has quit [Quit: Turuk] 20130914 20:36:53< anonymissimus> jamit: alright, good job! 20130914 20:40:44-!- stikonas [~gentoo@host-89-241-167-135.as13285.net] has joined #wesnoth-dev 20130914 20:40:44-!- stikonas [~gentoo@host-89-241-167-135.as13285.net] has quit [Changing host] 20130914 20:40:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130914 20:45:42-!- lobby [~wesnoth@wesnoth/bot/lobby] has quit [Ping timeout: 264 seconds] 20130914 20:46:16-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20130914 20:46:17-!- Topic for #wesnoth-dev: current repo: https://github.com/wesnoth/wesnoth-old (Please read the dev-ml for the latest status!) | 0 bugs, 0 feature requests, 0 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20130914 20:46:17-!- Topic set by Ivanovic [~ivanovic@wesnoth/developer/ivanovic] [Sat Aug 24 14:34:05 2013] 20130914 20:46:17[Users #wesnoth-dev] 20130914 20:46:17[ _8680__ ] [ ejls ] [ Ingmar ] [ loonycyborg] [ shadowm_desktop] [ un214 ] 20130914 20:46:17[ AI0867 ] [ elias ] [ irker229 ] [ Mara_Jade ] [ shikadibot ] [ Upth ] 20130914 20:46:17[ anonymissimus ] [ EliDupree ] [ Ivanovic ] [ melinath ] [ Smar ] [ Upthorn ] 20130914 20:46:17[ apoi ] [ enchilado ] [ iwaim__ ] [ molgrum ] [ Soliton ] [ vultraz ] 20130914 20:46:17[ Ard0nik ] [ esr ] [ jamit ] [ mordante ] [ stikonas ] [ wesbot ] 20130914 20:46:17[ balrog ] [ exciton ] [ janebot ] [ nurupo ] [ thunderstruck ] [ yann ] 20130914 20:46:17[ boucman ] [ fabi ] [ Jetrel_new ] [ qal ] [ timotei__ ] [ zookeeper] 20130914 20:46:17[ cjhopman_ ] [ Gallaecio ] [ justinzane_] [ Rhonda ] [ ToBeFree ] [ {V} ] 20130914 20:46:17[ crimson_penguin] [ Gambit ] [ knotwork__ ] [ Samual ] [ tomreyn ] 20130914 20:46:17[ DHost ] [ happygrue_] [ lobby ] [ shadowm ] [ trademark ] 20130914 20:46:17-!- Irssi: #wesnoth-dev: Total of 58 nicks [0 ops, 0 halfops, 0 voices, 58 normal] 20130914 20:46:27-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009 20130914 20:47:33-!- Irssi: Join to #wesnoth-dev was synced in 87 secs 20130914 20:54:31-!- un214 [~un214@2602:304:37b8:d939:224:8cff:fed2:ef57] has quit [Remote host closed the connection] 20130914 21:07:20-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving] 20130914 21:11:48-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 11.0/20120312181643]] 20130914 21:14:16< justinzane_> mordante: I'm using scons right now just 'cause 1-I love Python and 2-it integrates with Eclipse CDT. I'll see about converting the cmake recipe if I can motivate myself. :) 20130914 21:16:37< justinzane_> I'm trying to do a `scons build=profile` and it always dies with `g++: error: -pg and -fomit-frame-pointer are incompatible \n scons: *** [build/profile/lua_jailbreak_exception.o] Error 1' 20130914 21:18:58< loonycyborg> interesting 20130914 21:19:11< mordante> justinzane_, then don't use the combination of -pg and -fomit-frame-pointers 20130914 21:19:21< justinzane_> I've grepped for fomit-frame-pointer to no avail 20130914 21:19:24< loonycyborg> I think the default script doesn't add -fomit-frame-pointer 20130914 21:19:35< loonycyborg> Maybe it's from pkg-config or something? 20130914 21:19:49< justinzane_> I'm now looking for '\-O[23]' 20130914 21:19:50< loonycyborg> Or .scons-option-cache 20130914 21:20:30< justinzane_> loonycyborg: hmmm... will look 20130914 21:20:30< loonycyborg> It passes -O2 for profile builds I think 20130914 21:22:06< mordante> but I assume -O2 doesn't drop the frame pointers, else it would be impossible to create profiles from optimised code 20130914 21:22:17< mordante> and profiling -O0 is rather silly 20130914 21:24:42-!- trademark [~trademark@37.160.41.17] has quit [Ping timeout: 264 seconds] 20130914 21:28:37< justinzane_> "-fomit-frame-pointer ... Enabled at levels -O, -O2, -O3, -Os." http://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html 20130914 21:28:56< justinzane_> I'm trying to profile -Og 20130914 21:29:49< mordante> justinzane_, maybe then manually add -fno-omit-frame-pointer (would be nice if -pg did that :-/) 20130914 21:29:59< loonycyborg> You can pass a differen -O with extra_flags_profile 20130914 21:30:12< justinzane_> loonycyborg: mordante: It did pass -O2, which I always thought to be acceptable as mordante mentioned. So, I'm just eliminating that as the cause of the error. 20130914 21:30:27< loonycyborg> But do you see -fno-omit-frame-pointer in the command line? 20130914 21:30:35< justinzane_> that's what I did. 20130914 21:30:37< justinzane_> loonycyborg: no 20130914 21:30:53< justinzane_> that is what confusticates and bebothers me 20130914 21:31:03< loonycyborg> -fomit-frame-pointer that is 20130914 21:32:16< justinzane_> where the fuck does g++/ld think it is getting -fomit-frame-pointer from for "lua_jailbreak_exception"? 20130914 21:32:49< justinzane_> i've cleaned `scons -c all` and reconfigured `scons --config=force` 20130914 21:33:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20130914 21:34:07-!- molgrum [~molgrum@c83-249-40-178.bredband.comhem.se] has quit [Quit: Lämnar] 20130914 21:36:22< loonycyborg> justinzane_: Can you show full command line for that particular file? 20130914 21:36:50-!- trademark [~trademark@37.160.41.17] has joined #wesnoth-dev 20130914 21:38:06< justinzane_> loonycyborg: I removed the .scons-option-cache and am rebuilding. I'll gist it if it dies again. thanks 20130914 21:53:16-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev 20130914 21:54:44-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130914 21:57:20< mattsc> shadowm: It compiled on OS X (10.8.4) and Wesnoth started without problems (did that maybe 15 hours ago), but I seem to be to stupid to get notifications to work. 20130914 21:57:34< mattsc> If have "disable notifications" set to 'no' in the preferences. Is there anything else I need to do? 20130914 21:59:30< mattsc> maybe that ^ is a question for vultraz ? Do I need to do something on the system side as well? 20130914 22:00:34< mordante> I'm off bye 20130914 22:01:49-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20130914 22:02:53< justinzane_> shadowm: `BoolVariable('notifications', 'Enable support for desktop notifications', True),` 20130914 22:03:17< justinzane_> shadowm: I'm sure you rememberred to build with them enabled... 20130914 22:05:30-!- trademark [~trademark@37.160.41.17] has quit [Ping timeout: 264 seconds] 20130914 22:06:16< justinzane_> loonycyborg: I've got this little chunk "-fPIC -pipe -fstack-protector --param=ssp-buffer-size=4 -fno-strict-aliasing -fomit-frame-pointer " in the command for "build/profile/lua_jailbreak_exception.o" which is not from anywhere in the /wesnoth-old/ tree. 20130914 22:07:54< loonycyborg> hmm, is that a .c or .cpp file? 20130914 22:08:43< justinzane_> .cpp 20130914 22:10:19< justinzane_> looking at the previous build commands, I only see options that are in the base SConstruct file. Let's see if there is sn Scon* file in src/lua/ 20130914 22:13:49< shadowm> mattsc: I don't know if notifications on OS X work differently, but yes, "Disable notifications" should be set to 'no'. 20130914 22:14:15< shadowm> ("Differently" as in maybe the platform expects something else or the user must authorize the application. *shurg*) 20130914 22:19:31 * justinzane_ **confused** 20130914 22:20:36< justinzane_> Where could that "-fPIC -pipe -fstack-protector --param=ssp-buffer-size=4 -fno-strict-aliasing -fomit-frame-pointer" set of options come from? 20130914 22:26:23< shadowm> Have you checked build/config.log? 20130914 22:27:10< shadowm> That could give a hint as to which configuration step introduces each set of flags. 20130914 22:28:39< mattsc> shadowm: I've been looking through the system preferences. OS X as of 10.8 has a "Notification Center" and lists the applications in the system preferences that will produce notifications. Wesnoth is not listed in there, but I have no clue whether that needs to be (or can be ) changed on the Wesnoth or on the System side. 20130914 22:28:49< mattsc> I see no options for adding applications. 20130914 22:42:08-!- lobby [~wesnoth@wesnoth/bot/lobby] has quit [Ping timeout: 260 seconds] 20130914 22:42:34-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20130914 22:42:34-!- Topic for #wesnoth-dev: current repo: https://github.com/wesnoth/wesnoth-old (Please read the dev-ml for the latest status!) | 0 bugs, 0 feature requests, 0 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20130914 22:42:34-!- Topic set by Ivanovic [~ivanovic@wesnoth/developer/ivanovic] [Sat Aug 24 14:34:05 2013] 20130914 22:42:34[Users #wesnoth-dev] 20130914 22:42:34[ _8680__ ] [ ejls ] [ happygrue_ ] [ knotwork__ ] [ Rhonda ] [ tomreyn ] 20130914 22:42:34[ AI0867 ] [ elias ] [ Ingmar ] [ lipkab ] [ Samual ] [ Upth ] 20130914 22:42:34[ apoi ] [ EliDupree] [ irker229 ] [ lobby ] [ shadowm ] [ Upthorn ] 20130914 22:42:34[ Ard0nik ] [ enchilado] [ Ivanovic ] [ loonycyborg] [ shadowm_desktop] [ vultraz ] 20130914 22:42:34[ balrog ] [ esr ] [ iwaim__ ] [ Mara_Jade ] [ shikadibot ] [ wesbot ] 20130914 22:42:34[ boucman ] [ exciton ] [ jamit ] [ mattsc ] [ Smar ] [ yann ] 20130914 22:42:34[ cjhopman_ ] [ fabi ] [ janebot ] [ melinath ] [ Soliton ] [ zookeeper] 20130914 22:42:34[ crimson_penguin] [ Gallaecio] [ Jetrel_new ] [ nurupo ] [ timotei__ ] [ {V} ] 20130914 22:42:34[ DHost ] [ Gambit ] [ justinzane_] [ qal ] [ ToBeFree ] 20130914 22:42:34-!- Irssi: #wesnoth-dev: Total of 53 nicks [0 ops, 0 halfops, 0 voices, 53 normal] 20130914 22:42:51-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009 20130914 22:43:18-!- stikonas [~gentoo@host-89-241-167-135.as13285.net] has joined #wesnoth-dev 20130914 22:43:18-!- stikonas [~gentoo@host-89-241-167-135.as13285.net] has quit [Changing host] 20130914 22:43:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130914 22:44:28-!- Irssi: Join to #wesnoth-dev was synced in 125 secs 20130914 22:49:37< shadowm> I assume that this 'Growl' thing that's referenced in the code isn't part of OS X itself then. 20130914 22:50:11< shadowm> The notifications code is guarded behind an #ifdef HAVE_GROWL. 20130914 22:50:46< mattsc> Just reading up on this (sorry, I just upgraded to 10.8 and haven't had time to figure out how things work). 20130914 22:51:30< mattsc> Apparently it used to be Growl, but is now it's own thing. But there's a way of getting Growl notifications to work too, by getting some free add-on or application or whatever ... 20130914 22:51:36< shadowm> I'd also have to assume Alarantalara's builds don't use it either/it doesn't always work. 20130914 22:52:36< shadowm> That'd render the testing mostly irrelevant, since I'd not expect a lot of people to build Wesnoth on OS X. 20130914 22:53:49< shadowm> Eh, anyway, it probably doesn't matter a lot. gettext's return value is const char*, the original literals are equivalent to const char* const, so it'll certainly compile. 20130914 23:00:03-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20130914 23:00:17-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130914 23:00:44< mattsc> shadowm: well, I downloaded this application that supposedly forwards growl notifications to the new Notification Center, but that doesn't seem to work either. Unfortunately, I am out of time for now. I'll ask Alarantalara about it if nobody else has any ideas. 20130914 23:07:22< justinzane_> shadowm: grep shows nothing about "frame" in config/build.log 20130914 23:09:13-!- trademark [~trademark@37.161.216.187] has joined #wesnoth-dev 20130914 23:13:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20130914 23:17:20< justinzane_> Can I just add "-fno-omit-frame-pointer" to my "profile" extra options and be done with it? Let's see... 20130914 23:19:50-!- trewe [~trewe@87.196.89.85] has joined #wesnoth-dev 20130914 23:19:57< shadowm> User options generally get appended to platform and recipe-defined defaults, so that should work. 20130914 23:21:18< shadowm> e.g. I have -O3 in extra_flags_release and it's passed after the recipe default of -O2. 20130914 23:23:53-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Quit: Nettalk6 - www.ntalk.de] 20130914 23:39:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20130914 23:42:17< jamit> It looks like Sapient is the one who designed vconfig's memory management. I wonder if he's lurking? 20130914 23:42:23< jamit> wesbot: see Sapient 20130914 23:42:33< jamit> wesbot: seen Sapient 20130914 23:42:33< wesbot> jamit: Sorry, I don't know of Sapient. 20130914 23:42:44< jamit> wesbot: seen sapient 20130914 23:42:44< wesbot> jamit: Sorry, I don't know of sapient. 20130914 23:42:54< jamit> Not in a while, I guess. 20130914 23:43:39< jamit> I was looking into things, and it looks like some of that nice memory-management code is going to waste in practice. 20130914 23:44:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20130914 23:44:47< jamit> If anyone wants to try it out themselves to get more data, the diagnostic code I inserted was: http://pastebin.com/K32sDUff 20130914 23:46:12< jamit> It spits out some messages to stderr. The "cached" and "stored" numbers measure how often the memory management was useful. The "constructed" number measures how often new memory had to be allocated. 20130914 23:46:41< jamit> Starting the test scenario, I saw cached: 0; stored: 1; constructed: 30 20130914 23:47:07< jamit> Running through the tutorial, I saw cached: 0; stored: 0; constructed: 5 20130914 23:47:40< jamit> Starting up UtBS-S1, I got the same numbers as the tutorial. 20130914 23:48:20< jamit> So it looks like that management is going to waste. I think it would be better off not trying to be so clever so we can drop the overhead. 20130914 23:57:47-!- trademark [~trademark@37.161.216.187] has quit [Ping timeout: 264 seconds] 20130914 23:58:26-!- lobby [~wesnoth@wesnoth/bot/lobby] has quit [Ping timeout: 264 seconds] --- Log closed Sun Sep 15 00:00:07 2013