--- Log opened Mon Sep 16 00:00:55 2013
20130916 00:11:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20130916 00:11:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20130916 00:25:33-!- Kostic [~marko@net24-1-245-109.mbb.telenor.rs] has quit [Quit: Ex-Chat]
20130916 00:37:28-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 256 seconds]
20130916 00:39:43-!- nurupo|away is now known as nurupo
20130916 00:45:07-!- stikonas_ [~gentoo@host-78-148-90-171.as13285.net] has joined #wesnoth-dev
20130916 00:45:07-!- stikonas_ [~gentoo@host-78-148-90-171.as13285.net] has quit [Changing host]
20130916 00:45:07-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 00:55:18-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20130916 01:14:56-!- mjs-de [~mjs-de@p3EE21EE1.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20130916 01:57:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20130916 02:04:37-!- nurupo is now known as nurupo|away
20130916 02:55:33-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20130916 03:28:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20130916 03:47:36-!- jamit [~jamit@wesnoth/developer/jamit] has left #wesnoth-dev []
20130916 04:18:56-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 256 seconds]
20130916 04:30:55< fabi> shadowm: Hello, would you review 3 short methods which I want to commit to the image path functions?
20130916 04:31:19< shadowm> Yes.
20130916 04:33:40< fabi> shadowm: http://pastebin.com/sDpHPAAA
20130916 04:34:22< shadowm> Oh my god it has maths.
20130916 04:35:30< fabi> :-) Doesn't every image path function?
20130916 04:35:34< shadowm> fabi: At first glance I see multiple instances in which you are casting integral or pointer types using C-style casts. See http://wiki.wesnoth.org/CodingStandards#Do_not_use_C-style_casts .
20130916 04:36:04< fabi> Ah yes. That should not be hard to fix.
20130916 04:36:13< shadowm> No, image path functions themselves are merely light interfaces to lower level functions.
20130916 04:36:35< shadowm> What you pated aren't image path functions, they are the lower level functions behind the implementation themselves.
20130916 04:37:43< shadowm> Hm.
20130916 04:38:24< shadowm> fabi: Do you know what the optimize parameter in most of those functions does?
20130916 04:39:08< fabi> Nope, that is one of my concerns. I also want to ask if I handle the surface wrappers properly.
20130916 04:39:36< shadowm> It compresses the pixel data using RLE.
20130916 04:39:52< shadowm> This is generally considered wasteful for temporary surfaces that won't enter the image cache, like the one generated in line 5.
20130916 04:41:20< fabi> Ah. I see.
20130916 04:43:13< shadowm> I can't really review code involving bitwise operations properly. There's a missing line break in line 86.
20130916 04:46:15< shadowm> I generally lack enough experience with very low-level SDL code to review the pixel manipulation code.
20130916 04:47:07< shadowm> I'm not really sure why you decided to make put_pixel and get_pixel separate functions, is that part of a larger refactoring attempt?
20130916 04:48:00< fabi> shadowm: No. I tried hard ( a whole day ) to integrate them into the main method properly. But failed.
20130916 04:49:48-!- Ivanovic_ [~ivanovic@x2f3b190.dyn.telefonica.de] has joined #wesnoth-dev
20130916 04:49:48< shadowm> Some (not all) existing code requiring access to color values seems to use SDL_MapRGBA() and SDL_GetRGBA().
20130916 04:50:41< shadowm> Anyway I would suspect mordante understands this (rather sensitive) area better since he's done fixes and optimizations on it before.
20130916 04:51:23< fabi> Okay, I will ask him and try with map and get rgba. Thanks, you helped me already a lot.
20130916 04:51:28-!- nurupo|away is now known as nurupo
20130916 04:51:39< shadowm> Okay, no problem.
20130916 04:53:02-!- Ivanovic [~ivanovic@x2f510c9.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20130916 04:53:10< fabi> shadowm: The create_optimized_surface in line 56 makes sense?
20130916 04:53:42-!- Ivanovic_ is now known as Ivanovic
20130916 04:57:00< shadowm> Since I assume that's the surface that will be used by the image path function interface, yes, I think so.
20130916 04:58:27-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20130916 05:03:08< fabi> shadowm: Thanks
20130916 05:05:17-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20130916 05:09:43< nurupo> shadowm: is wesnoth uses c++11 now?
20130916 05:10:54< fabi> nurupo: no
20130916 05:12:07< nurupo> wasn't mordante adding "override" into sources few month ago?
20130916 05:12:20< shadowm> I've seen some C++11 bits guarded behind preprocessor conditionals, but all code is still required to work in C++ 98 mode.
20130916 05:13:04-!- ancestral [~ancestral@c-24-118-224-240.hsd1.mn.comcast.net] has joined #wesnoth-dev
20130916 05:13:17< shadowm> And I don't know how much testing has been done with the alternative C++11 code. Probably not a lot
20130916 05:13:44< nurupo> https://github.com/wesnoth/wesnoth-old/search?q=override
20130916 05:14:12< nurupo> would code with "override" compile in c++98 mode?
20130916 05:14:28< nurupo> it's c++11 thing
20130916 05:14:35< shadowm> Yes. OVERRIDE is subject to one of the aforementioned preprocessor conditionals and it's a macro.
20130916 05:15:26< shadowm> IIRC it evaluates to 'override' when C++11 is enabled, and to nothing otherwise (thus the compiler doesn't get to complain in C++ 98 mode).
20130916 05:15:37< nurupo> oh, i see
20130916 05:15:43< nurupo> global.hpp
20130916 05:15:50< nurupo> #define OVERRIDE
20130916 05:16:53< nurupo> anyway, i just wanted to say that if you are using c++11, then in "Do not use 0 when you mean NULL" sectin of the Coding Standards wiki page posted above, "NULL" should be replaced with "nullptr"
20130916 05:17:15< nurupo> but nevermind then, since it uses c++98
20130916 05:18:03-!- ancestral [~ancestral@c-24-118-224-240.hsd1.mn.comcast.net] has quit [Quit: i go nstuf kthxbai]
20130916 05:18:55< shadowm> I personally don't know much about the changes, recommendations, and new features in C++11, and I've been trying to find some motivation (i.e. software to write in C++) for a while. :\
20130916 05:23:11< nurupo> if you have a little personal project, you can choose whatever tools you want, which is what i do
20130916 05:26:14-!- irker835 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20130916 05:33:08< nurupo> clang and gcc almost done implementing c++11 features, although gcc says that c++11 is experimental and some features were implemented based on early proposals. gcc is only lacking garbage collection http://gcc.gnu.org/projects/cxx0x.html, clang lacks garbage collection and two other things http://gcc.gnu.org/projects/cxx0x.html
20130916 05:34:34-!- nurupo is now known as nurupo|away
20130916 05:44:26< shadowm> You pasted the link for gcc's implementation status twice.
20130916 05:45:05< shadowm> The latter would be: http://clang.llvm.org/cxx_status.html
20130916 06:00:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20130916 06:00:39-!- Octalot [~noct@host86-128-228-187.range86-128.btcentralplus.com] has quit []
20130916 06:21:42-!- ancestral [~ancestral@65-128-232-98.mpls.qwest.net] has joined #wesnoth-dev
20130916 06:21:48-!- ancestral [~ancestral@65-128-232-98.mpls.qwest.net] has quit [Client Quit]
20130916 06:25:55< justinzane_> missed most of the log, but i've been building and running in std=cxx0x for a while now
20130916 06:26:32< justinzane_> saw one issue a couple days back, but otherwise it has been fine
20130916 06:26:45-!- ancestral [~ancestral@65-128-232-98.mpls.qwest.net] has joined #wesnoth-dev
20130916 06:40:21-!- justinzane_ [~justinzan@216.7.117.181] has quit []
20130916 06:42:31-!- justinzane [~justinzan@tiny.justinzane.com] has joined #wesnoth-dev
20130916 06:48:24-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit []
20130916 06:58:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20130916 07:02:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20130916 07:07:25-!- justinzane [~justinzan@tiny.justinzane.com] has quit [Remote host closed the connection]
20130916 07:07:50-!- justinzane [~justinzan@tiny.justinzane.com] has joined #wesnoth-dev
20130916 07:12:08< zookeeper> putpixel IPF? yay. now add-on scenarios can do away with downloadable images.
20130916 07:17:31< shadowm> I don't think that's intended to be exposed as an image path function.
20130916 07:19:38< zookeeper> aww.
20130916 07:19:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20130916 07:19:49< shadowm> I also calculated once that the closest equivalent would have an abominable impact on the image cache but I don't remember the specifics.
20130916 07:23:52< shadowm> A Base64 substitution image path function would probably be more optimal in any case.
20130916 07:55:11-!- ancestral [~ancestral@65-128-232-98.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20130916 08:26:08-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130916 08:39:10-!- stikonas [~gentoo@host-78-148-90-171.as13285.net] has joined #wesnoth-dev
20130916 08:39:10-!- stikonas [~gentoo@host-78-148-90-171.as13285.net] has quit [Changing host]
20130916 08:39:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 08:44:07-!- _Coffee [~david@ppp121-45-78-176.lns20.adl6.internode.on.net] has quit [Ping timeout: 260 seconds]
20130916 08:50:39-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 260 seconds]
20130916 08:56:28-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130916 09:01:11-!- _Coffee [~david@ppp118-210-37-17.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20130916 09:03:33-!- justinzane [~justinzan@tiny.justinzane.com] has quit [Ping timeout: 248 seconds]
20130916 09:05:58-!- irker440 [~irker@ai0867.net] has joined #wesnoth-dev
20130916 09:05:58< irker440> wesnoth: Ignacio R. Morelle wesnoth-old:master d93be3ff5b27 / changelog players_changelog src/gui/dialogs/addon/description.cpp: gui2/taddon_description: Ensure color consistency with Add-ons Manager http://git.io/iiCedg
20130916 09:20:03-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20130916 09:22:20-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev
20130916 09:23:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20130916 09:32:12< irker440> wesnoth: Ignacio R. Morelle wesnoth-old:master 9268f310429d / src/intro.cpp: Drop alternate no-op implementation of the_end() http://git.io/vf2dGQ
20130916 09:32:15< irker440> wesnoth: Ignacio R. Morelle wesnoth-old:master 474651de46fb / src/ (6 files in 2 dirs): Remove --new-storyscreens command line switch http://git.io/3keWbQ
20130916 09:32:18< irker440> wesnoth: Ignacio R. Morelle wesnoth-old:master ede9848bd837 / / (6 files in 6 dirs): Remove stub.hpp and the orphaned function using it http://git.io/UPYqyg
20130916 09:35:45< irker440> wesnoth: Ignacio R. Morelle wesnoth-old:master 0ed08a121744 / src/intro.cpp: Remove orphaned references to the log facilities in intro.cpp http://git.io/jvw1Cw
20130916 09:40:57-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev
20130916 09:43:27-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has joined #wesnoth-dev
20130916 09:45:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20130916 10:06:42< Soliton> _Coffee: pong... maybe just say what you want to say? ;-)
20130916 10:11:11< _Coffee> Soliton: hi
20130916 10:11:17< _Coffee> wanted to ask about multiplayer
20130916 10:11:55< _Coffee> from speaking a little with shadowm I have an idea (and some time to do it potentially)
20130916 10:12:31< _Coffee> I am looking for an "easy" way to parallelize the multiplayer server list connections
20130916 10:13:00< _Coffee> what I am thinking is that you could connect to both server.wesnoth.org and server2.wesnoth.org at the same time
20130916 10:13:13< _Coffee> and the multiplayer lobby would show both server connections
20130916 10:13:39< _Coffee> once a game is hosted it would only be dealing with that server from that point
20130916 10:14:13< _Coffee> so if a server becomes unavailable you would quit the game (or be forcibly quit after a peroid of inactivity) and then host on the other server
20130916 10:14:34< _Coffee> I think this might be possible with little code
20130916 10:14:40< _Coffee> but I could be mistaken
20130916 10:15:47< Soliton> first issue comming to mind would be that player names are not unique anymore.
20130916 10:16:28< _Coffee> what do you mean?
20130916 10:16:48< Soliton> well, how could they still be?
20130916 10:16:59< _Coffee> you would connect to both servers with the same username/password
20130916 10:17:15< _Coffee> but I don't actually know how that works technically I have to admit
20130916 10:17:47< Soliton> in a perfect world where there would be no netsplits that's all nice and clean. but we don't live in that world.
20130916 10:17:50< _Coffee> basically I was thinking have 2 threads when connecting that try to connect to each server with the username/password
20130916 10:18:17< _Coffee> and continue when both come back successful or one times out
20130916 10:19:10< _Coffee> I think I have seen what you are talking about before
20130916 10:19:41< _Coffee> where you get disconnected and you try to rejoin and "nickname already used" or "such and such is already logged in"
20130916 10:20:08< _Coffee> but this is a bug isn't it?
20130916 10:20:20< Soliton> no.
20130916 10:20:53< Soliton> in one form or another you will have to deal with two connections to each server with the same nick but not actually the same client.
20130916 10:21:46< Soliton> and unless you want to make the server aware of each other the client really has no chance to completely deal with that.
20130916 10:21:56< _Coffee> so it would be like it is now, where a message could say "such and such is already logged in"?
20130916 10:22:31< Soliton> sure.
20130916 10:22:32< _Coffee> why would you need to though?
20130916 10:22:48< _Coffee> after the game is hosted it stays on that server and code works as is now
20130916 10:22:52< _Coffee> no fancy stuff
20130916 10:22:54< Soliton> ok, how do you present the nick list?
20130916 10:23:09< _Coffee> a combination of the 2 lists
20130916 10:23:28< _Coffee> and make it so that one server is preferred
20130916 10:23:34< _Coffee> for all hosting games
20130916 10:23:50< _Coffee> only using the alternate server when the first one is unavailable, and so on
20130916 10:24:21< _Coffee> don't allow someone to join if there is a "split error" on one of the servers
20130916 10:24:38< _Coffee> waiting for the connection to idle and disconnect instead and use a different handle in the meantime
20130916 10:25:02< Soliton> so how do you combine the list knowing that a username on one server does not neccessarily equal the same client on a different server?
20130916 10:25:44< _Coffee> oh, I see
20130916 10:26:23-!- mjs-de [~mjs-de@g224177225.adsl.alicedsl.de] has joined #wesnoth-dev
20130916 10:26:24< _Coffee> then the second server would need to make sure that the first and so on is the same client on initial connection
20130916 10:26:37< Soliton> maybe an easy first step would be just multiple connections to different servers and a tabbed interface to show that.
20130916 10:27:12< Soliton> i.e. every server completely separate like now just visible from one client.
20130916 10:27:53< _Coffee> interesting
20130916 10:28:13< _Coffee> so you could go to the network lobby and it might appear as local host one does now
20130916 10:28:23< _Coffee> with tabs for the server1 and server2
20130916 10:28:26-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:28:26< Soliton> and since i believe the new lobby already has a tabbed interface it'd make sense to ressurrect it first and see what still needs fixing there.
20130916 10:29:00< _Coffee> I haven't used the new lobby I have to say
20130916 10:29:00-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:29:01-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:29:13< _Coffee> the jumping around of new games made it unusable for me at the time
20130916 10:29:17-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:29:18-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:29:24< _Coffee> but Ill have another look
20130916 10:29:50-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:29:50-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:29:58< Soliton> well, as a developer maybe you're able to fix it! :-P
20130916 10:30:22-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:30:22-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:30:28< _Coffee> yeah, I'll have some time in a couple of weeks spare to do some programming
20130916 10:30:53-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:30:56-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:31:28-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:31:30-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:31:59-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:31:59-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:32:33-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20130916 10:32:34-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20130916 10:32:34-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:37:18-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 264 seconds]
20130916 10:37:54-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20130916 10:39:07-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has joined #wesnoth-dev
20130916 10:39:07-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has quit [Changing host]
20130916 10:39:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 10:40:19-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20130916 10:42:06-!- markus_ [~mjs-de@g224185016.adsl.alicedsl.de] has joined #wesnoth-dev
20130916 10:45:26-!- mjs-de [~mjs-de@g224177225.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20130916 10:48:51-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:49:31-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:49:31-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:49:51-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:49:53-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:50:16-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:50:18-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:50:48-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:50:50-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:51:25-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:51:26-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:51:51-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:51:52-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:52:24-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:52:25-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:52:54-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:52:56-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:53:28-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:53:30-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:54:01-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20130916 10:54:01-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20130916 10:54:01-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:54:02-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:54:35-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:54:37-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20130916 10:55:03-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20130916 10:55:06-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20130916 10:55:06-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20130916 10:59:48-!- Kostic [~marko@net209-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev
20130916 10:59:56-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20130916 11:01:04-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20130916 11:52:15-!- Kostic [~marko@net209-1-245-109.mbb.telenor.rs] has quit [Quit: Ex-Chat]
20130916 11:55:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130916 11:57:48-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving]
20130916 12:22:39-!- markus_ is now known as mjs
20130916 12:23:00-!- mjs is now known as mjs-de
20130916 12:53:55-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20130916 13:04:46-!- Kostic [~marko@85.202.113.76] has joined #wesnoth-dev
20130916 13:07:07-!- Kostic [~marko@85.202.113.76] has quit [Client Quit]
20130916 13:07:34-!- Kostic [~marko@85.202.113.46] has joined #wesnoth-dev
20130916 13:08:53-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20130916 13:09:41-!- Kostic [~marko@85.202.113.46] has quit [Remote host closed the connection]
20130916 13:12:18-!- Kostic [~marko@85.202.113.151] has joined #wesnoth-dev
20130916 13:15:28-!- Ard0nik [~ardonik@adsl-75-28-107-126.dsl.irvnca.sbcglobal.net] has quit [Quit: No such file]
20130916 13:17:22-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20130916 13:26:35-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has joined #wesnoth-dev
20130916 13:29:49-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has joined #wesnoth-dev
20130916 13:29:49-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has quit [Changing host]
20130916 13:29:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 13:55:10-!- stikonas_ [~gentoo@vpn2-145.vpn.net.ed.ac.uk] has joined #wesnoth-dev
20130916 13:55:10-!- stikonas_ [~gentoo@vpn2-145.vpn.net.ed.ac.uk] has quit [Changing host]
20130916 13:55:10-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 13:55:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20130916 13:58:08-!- EdB [~edb@AToulouse-159-1-39-218.w92-134.abo.wanadoo.fr] has joined #wesnoth-dev
20130916 14:01:16< fabi> shadowm: I think putpixel and getpixel are fine. I learned that they are the recommended way to handle single pixels in the sdl docu: http://sdl.beuc.net/sdl.wiki/Pixel_Access. The only differnce is that I modified them slightly to make use of our surface wrappers.
20130916 14:03:48-!- ancestral [~ancestral@65-128-232-98.mpls.qwest.net] has joined #wesnoth-dev
20130916 14:17:25-!- justinzane [~justinzan@tiny.justinzane.com] has joined #wesnoth-dev
20130916 14:27:12-!- ancestral [~ancestral@65-128-232-98.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20130916 14:27:46-!- Kostic [~marko@85.202.113.151] has quit [Remote host closed the connection]
20130916 14:36:40-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20130916 14:42:16-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has quit [Quit: DCW]
20130916 14:43:57-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer]
20130916 14:44:30-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev
20130916 14:55:12-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130916 15:17:05-!- irker440 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20130916 15:21:20-!- EdB_ [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has joined #wesnoth-dev
20130916 15:23:50-!- EdB [~edb@AToulouse-159-1-39-218.w92-134.abo.wanadoo.fr] has quit [Ping timeout: 240 seconds]
20130916 15:24:15-!- DHost [~Pcy@sd.yost.fr] has quit [Quit: leaving]
20130916 15:24:52-!- DHost [~Pcy@sd.yost.fr] has joined #wesnoth-dev
20130916 15:29:54-!- EdB_ is now known as EdB
20130916 15:35:38-!- Kostic [~marko@85.202.113.55] has joined #wesnoth-dev
20130916 15:45:54-!- flix [~flix@91-66-60-135-dynip.superkabel.de] has joined #wesnoth-dev
20130916 15:45:55-!- Vandal [Ganrao@cpe-65-189-245-210.woh.res.rr.com] has joined #wesnoth-dev
20130916 16:06:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 16:06:15-!- mattsc [~mattsc@207.230.251.234] has joined #wesnoth-dev
20130916 16:06:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 16:10:51-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has quit [Quit: Konversation terminated!]
20130916 16:11:18-!- exciton_ [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 16:13:54-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 240 seconds]
20130916 16:14:01-!- exciton_ [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 16:16:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 16:18:48-!- H-Hour_ [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has joined #wesnoth-dev
20130916 16:20:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 16:21:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 16:21:55-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has quit [Ping timeout: 260 seconds]
20130916 16:25:18-!- Kostic [~marko@85.202.113.55] has quit [Ping timeout: 264 seconds]
20130916 16:30:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 16:30:21-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 16:32:58-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20130916 16:33:33-!- Kostic [~marko@85.202.113.200] has joined #wesnoth-dev
20130916 16:34:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 16:34:18-!- mattsc [~mattsc@207.230.251.234] has quit [Quit: Computer's asleep]
20130916 16:35:22-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 16:36:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 16:40:22-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 16:40:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20130916 16:44:20-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130916 16:50:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 16:50:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 16:51:29-!- jetrel_laptop [~jetrel_la@184-100-95-129.mpls.qwest.net] has joined #wesnoth-dev
20130916 16:55:40-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev
20130916 17:00:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 17:00:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 17:05:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 17:05:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 17:08:23-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has joined #wesnoth-dev
20130916 17:08:23-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has quit [Changing host]
20130916 17:08:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 17:08:49-!- DCW1 [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has joined #wesnoth-dev
20130916 17:15:29-!- cjhopman_ [cjhopman@nat/google/x-eewgacegnqtshyaq] has quit [Ping timeout: 240 seconds]
20130916 17:17:18-!- cjhopman__ [cjhopman@nat/google/x-kdlcfztdgacuufpp] has joined #wesnoth-dev
20130916 17:18:54-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 240 seconds]
20130916 17:21:28-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 17:23:44-!- Shelim [~shelim@195.225.71.101] has joined #wesnoth-dev
20130916 17:24:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 17:26:28-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 17:40:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20130916 17:40:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 17:41:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 17:41:17-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 17:42:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 17:46:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 17:47:23-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20130916 17:52:50-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130916 17:54:38-!- trademark [~trademark@37.161.191.174] has joined #wesnoth-dev
20130916 18:00:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20130916 18:04:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130916 18:05:13-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has joined #wesnoth-dev
20130916 18:05:14-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has quit [Changing host]
20130916 18:05:14-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20130916 18:10:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130916 18:15:53-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20130916 18:19:35-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds]
20130916 18:24:21-!- Shelim [~shelim@195.225.71.101] has quit [Quit: Nettalk6 - www.ntalk.de]
20130916 18:30:05-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has joined #wesnoth-dev
20130916 18:33:58-!- stikonas [~gentoo@host-78-148-90-171.as13285.net] has joined #wesnoth-dev
20130916 18:33:59-!- stikonas [~gentoo@host-78-148-90-171.as13285.net] has quit [Changing host]
20130916 18:33:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 18:45:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130916 18:50:54-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has quit [Quit: Leaving]
20130916 18:59:31 * fabi wonders if "int dst_w = static_cast<int>(ceil(abs(max_x) - min_x)) / zoom;" and "dst_w = ceil(abs(max_x) - min_x) / zoom;" are equivalent.
20130916 19:00:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20130916 19:02:28< fabi> zoom is an integer.
20130916 19:02:45< fabi> max_
20130916 19:03:03< fabi> max_* and min_* are floats.
20130916 19:15:17< Soliton> presumably ceil() returns an int then it's equivalent.
20130916 19:17:02< Soliton> well, looks like it's not returning an int.
20130916 19:17:35< Soliton> i'd leave the explicit cast then.
20130916 19:17:54-!- mjs-de [~mjs-de@g224185016.adsl.alicedsl.de] has quit [Remote host closed the connection]
20130916 19:18:28-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev
20130916 19:19:15< Soliton> btw, it's curious how abs() is called on max_x but not min_x. not that i have any idea what's being calculated.
20130916 19:20:38< fabi> Soliton: http://pastebin.com/Z9jgkkLr
20130916 19:23:25< fabi> Soliton: It is a simplified "Rotsprite" algorithm. https://en.wikipedia.org/wiki/Image_scaling#RotSprite
20130916 19:23:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20130916 19:25:56< Soliton> surely above what's pasted there is documentation detailing that, right? :-)
20130916 19:27:07< fabi> Soliton: Sorry, I don't understand. Do you want a link to a more specific documentation?
20130916 19:28:14< fabi> Soliton: Oh, okay. You suggest to add a detailed documentation into our sourcecode, right?
20130916 19:28:26< Soliton> i'm saying no one will have any clue what this code should accomplish be just reading it.
20130916 19:28:47< Soliton> and if you have no idea what should be accomplished it's very hard to find any bugs.
20130916 19:29:14< fabi> Yes, I fear that is true for everything in sdl_utils.cpp.
20130916 19:30:12< Soliton> doesn't mean you have to add to it.
20130916 19:30:48< fabi> Indeed, proper documentation is what kept me from pushing it in our repo so far.
20130916 19:35:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20130916 19:36:32< Soliton> btw, might be easier and nicer to share code for review in just pushing it to a branch or your own fork instead of pasting bits to that aweful pastebin.com. ;-)
20130916 19:37:41< fabi> I agree. This also makes it a lot easier for a reviewer to actually compile and try the code.
20130916 19:38:06< fabi> But my skills with git and github are still quite limited. I need to take the time and learn how to use it properly.
20130916 19:47:04< Soliton> should be as simple as making a fork on github if you haven't already. clone it, copy your changes over (maybe with git format-patch and git am) and push.
20130916 19:48:14< fabi> Yeah, I will do so.
20130916 19:49:29< fabi> I have made some changes to the unit_map class, that is definitely something which shouldn't be commited carelessly.
20130916 20:18:09-!- DCW1 [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has quit [Remote host closed the connection]
20130916 20:40:19< fabi> A "Do whatever you want but don't blame me for damage" is enough for lifting a piece of code into Wesnoth?
20130916 20:40:33-!- trademark [~trademark@37.161.191.174] has quit [Ping timeout: 245 seconds]
20130916 20:49:04-!- Kostic [~marko@85.202.113.200] has quit [Ping timeout: 264 seconds]
20130916 20:49:48-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20130916 20:52:56-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar]
20130916 21:22:29-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection]
20130916 21:24:28< justinzane> Could comeone explain the purpose of src/unit_id, please. Why not just use UUIDs from an existing library? Or value+timestamp hashes?
20130916 21:30:49-!- stikonas [~gentoo@81.5.148.65] has joined #wesnoth-dev
20130916 21:30:50-!- stikonas [~gentoo@81.5.148.65] has quit [Changing host]
20130916 21:30:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 21:55:58 * justinzane having trouble with fingers automatically typing __var... for private variables. too much python?
20130916 22:04:08-!- Kostic [~marko@net71-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev
20130916 22:10:41-!- stikonas_ [~gentoo@host-78-148-90-171.as13285.net] has joined #wesnoth-dev
20130916 22:10:42-!- stikonas_ [~gentoo@host-78-148-90-171.as13285.net] has quit [Changing host]
20130916 22:10:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130916 22:14:03-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: Ciao]
20130916 22:14:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20130916 22:24:27-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20130916 22:41:06< fabi> justinzane: hi
20130916 22:42:13< justinzane> hey there. 
20130916 22:42:15-!- Kostic [~marko@net71-1-245-109.mbb.telenor.rs] has quit [Ping timeout: 260 seconds]
20130916 22:43:10< justinzane> fabi: what IDE do you use? there are a lot of github plugins for the "popular" ides.
20130916 22:44:42< justinzane> I've found that the github integration for eclipse makes commits much easier, but that lots of other things are easier on the console -- one console for `man git-somecommand` and another to actually use git in my repo.
20130916 22:45:55< justinzane> I've also just made tarball backups or btrfs snapshots of my repo before I do things just in case I fsck things up.
20130916 22:47:36< justinzane> On shadowm's advice i'm setting up my own fork-branch for some of my experimental changes.
20130916 22:55:51-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has joined #wesnoth-dev
20130916 23:02:40-!- Kostic [~marko@net71-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev
20130916 23:07:33< fabi> justinzane: I am using Eclipse as well.
20130916 23:08:03< fabi> justinzane: But most git stuff I do on the command line. But sometimes I also use the git Eclipse integration.
20130916 23:08:48< fabi> justinzane: Sounds like we use it pretty much the same.
20130916 23:13:00< justinzane> not ontopic, but when I switched from Windows fulltime back ~2005, I was always looking for a GUI to do everything. Now, its gotten to the point that my first instinct is to <F12> to pop down a console. I'm at the point that I often struggle to remember how to help people use the GUI interfaces.
20130916 23:25:23< Soliton> you're on the right path. :-)
20130916 23:27:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20130916 23:28:08-!- shadowm_desktop [~ignacio@186.10.6.120] has joined #wesnoth-dev
20130916 23:28:19-!- shadowm_desktop is now known as Guest91210
20130916 23:28:34-!- Guest91210 [~ignacio@186.10.6.120] has quit [Client Quit]
20130916 23:28:49-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20130916 23:32:17-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Bye]
20130916 23:32:25-!- Kostic [~marko@net71-1-245-109.mbb.telenor.rs] has quit [Quit: Kostic]
20130916 23:36:33< justinzane> not yet ready for vim, though :)
20130916 23:43:01-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving]
20130916 23:46:40< fabi> shadowm: Do you know which scaling algorithm is used by Wesnoth? I wonder if http://research.microsoft.com/en-us/um/people/kopf/pixelart/paper/pixel.pdf would be an improvement in our case. If I understand right it preserves the colors, thus it won't break TC.
20130916 23:48:59< shadowm> fabi: mordante should know. That kind of stuff goes over my head.
20130916 23:49:26< shadowm> Also, except where sloppy UMC coders specify otherwise, scaling is done after RC.
20130916 23:49:55< fabi> Hmmm, yes. That makes sense.
20130916 23:51:28-!- shadowm_desktop2 is now known as shadowm_desktop
20130916 23:51:51-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20130916 23:55:34-!- nurupo|away is now known as nurupo
--- Log closed Tue Sep 17 00:00:21 2013