--- Log opened Wed Sep 18 00:00:32 2013 20130918 00:12:33-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20130918 00:27:20-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20130918 00:44:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130918 00:48:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds] 20130918 00:49:21-!- stikonas__ [~gentoo@81.5.148.65] has joined #wesnoth-dev 20130918 00:49:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20130918 00:55:51-!- stikonas__ [~gentoo@81.5.148.65] has quit [Ping timeout: 260 seconds] 20130918 01:12:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20130918 01:15:39-!- ancestral [~ancestral@mobile-198-228-233-081.mycingular.net] has joined #wesnoth-dev 20130918 01:28:29-!- nurupo|away is now known as nurupo 20130918 01:29:39-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 264 seconds] 20130918 01:30:14-!- ancestral [~ancestral@mobile-198-228-233-081.mycingular.net] has quit [Quit: Smell ya later!] 20130918 01:41:27-!- ancestral [~ancestral@mobile-198-228-233-081.mycingular.net] has joined #wesnoth-dev 20130918 01:45:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20130918 02:00:33-!- Samual [diotecktec@xonotic/core-team/Samual] has left #wesnoth-dev [] 20130918 02:04:42-!- cjhopman__ [cjhopman@nat/google/x-kdlcfztdgacuufpp] has quit [Remote host closed the connection] 20130918 02:05:09-!- cjhopman__ [cjhopman@nat/google/x-shvnubvjefhtevkn] has joined #wesnoth-dev 20130918 02:12:38-!- ancestral_ [~ancestral@174-20-209-41.mpls.qwest.net] has joined #wesnoth-dev 20130918 02:12:39-!- ancestral [~ancestral@mobile-198-228-233-081.mycingular.net] has quit [Quit: Smell ya later!] 20130918 02:12:40-!- ancestral_ is now known as ancestral 20130918 02:40:09-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has quit [Quit: Leaving] 20130918 02:46:26-!- irker293 [~irker@ai0867.net] has joined #wesnoth-dev 20130918 02:46:27< irker293> wesnoth: fendrin wesnoth-old:master 80ca05e44814 / src/ (image_modifications.cpp image_modifications.hpp sdl_utils.cpp sdl_utils.hpp): Simplified Rotsprite algorithm. http://git.io/s-r76A 20130918 02:46:27< irker293> wesnoth: fendrin wesnoth-old:master 85f84dd3839a / src/ (image_modifications.cpp image_modifications.hpp sdl_utils.cpp sdl_utils.hpp): Documentation and cleanups to the RotSprite methods. http://git.io/KJhJcw 20130918 02:46:56-!- fabi__ is now known as fabi 20130918 02:59:34-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has joined #wesnoth-dev 20130918 03:24:16-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20130918 03:28:18-!- Octalot [~noct@host86-160-137-127.range86-160.btcentralplus.com] has quit [] 20130918 04:06:00< irker293> wesnoth: fendrin wesnoth-old:master 3c8342048360 / src/unit.cpp: Filtering for variation_type=. http://git.io/TQGBDg 20130918 04:08:06-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 248 seconds] 20130918 04:38:33-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20130918 04:40:28< irker293> wesnoth: fendrin wesnoth-old:master dbad16589111 / src/ (unit.cpp unit_types.cpp unit_types.hpp): Support for variation= in [unit_type]. http://git.io/VEN0Yg 20130918 04:47:20-!- Ivanovic_ [~ivanovic@x2f4dc0a.dyn.telefonica.de] has joined #wesnoth-dev 20130918 04:50:33-!- Ivanovic [~ivanovic@x2f40cdf.dyn.telefonica.de] has quit [Ping timeout: 245 seconds] 20130918 04:51:15-!- Ivanovic_ is now known as Ivanovic 20130918 05:08:25< shadowm> fendrin: What's the purpose and rationale of the last two commits? 20130918 05:10:08-!- molgrum_ [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev 20130918 05:12:21< shadowm> They seem to be changing or adding WML things, but this is neither specified in the commit descriptions (which are missing altogether) nor in changelog entries (also missing). 20130918 05:13:02-!- jetrel_laptop_ [~jetrel_la@184-100-95-129.mpls.qwest.net] has joined #wesnoth-dev 20130918 05:14:15-!- yann_ [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20130918 05:14:32-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Disconnected by services] 20130918 05:14:34-!- Netsplit *.net <-> *.split quits: jetrel_laptop, molgrum 20130918 05:14:34-!- jetrel_laptop_ is now known as jetrel_laptop 20130918 06:00:43< fabi> shadowm: They are very simple. Filtering for variation_type= allows for filtering the variation type. The rationale is that the wml coder might want to filter not only the unit type but also for the variation_type of the unit. 20130918 06:02:35< fabi> There is nothing more behind it. 20130918 06:03:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20130918 06:05:30< fabi> [unit_type] variation= allows for specifying the variation to use. It serves the same purpose like [unit] variation= 20130918 06:10:09< shadowm> fabi: Why variation_type instead of variation for the filter? 20130918 06:10:19< shadowm> The [unit] attribute is variation. 20130918 06:10:33< shadowm> Also, why does [unit_type] need to be able to specify a variation? 20130918 06:10:52< fabi> Because you filter with type for the id. 20130918 06:11:50< fabi> Thus I thought filtering with variation_type makes sense. 20130918 06:12:07< shadowm> type=Unit Type variation=variation_name 20130918 06:12:36< shadowm> That's what I'd use if I needed to filter both on the unit type and variation. 20130918 06:14:05< fabi> The next step will be to have variation_name a translateable string and an additional variation_id. 20130918 06:15:05< shadowm> How does this relate to the variation_type filter? 20130918 06:16:06< fabi> The thought I wrote about above. 20130918 06:16:13< fabi> type filters for id 20130918 06:16:27< fabi> variation_type filters for variation_id 20130918 06:16:42< fabi> That is easy to memorize. 20130918 06:17:21< shadowm> So why not just variation=? 20130918 06:17:54< fabi> That is fine as well. If you prefer just variation I am happy to change it. 20130918 06:17:56< shadowm> (Noting that currently, [filter_wml] variation= would be equivalent.) 20130918 06:18:04< fabi> no 20130918 06:18:53< fabi> variation= (or currently still variation_type) can be a list. 20130918 06:19:33< shadowm> [filter_wml] variation=var1 [or] variation=var2 [/or] [or] variation=var3 [/or] [...] 20130918 06:19:52< shadowm> I thought that was obvious. 20130918 06:20:06< fabi> Well, yes. 20130918 06:20:49< shadowm> And according to the diff I'm reading, the last commit allows unit_type to specify a 'default' variation. Is that right? 20130918 06:20:57< fabi> yes 20130918 06:21:03< shadowm> Why is this necessary? 20130918 06:21:41< fabi> It is not. 20130918 06:21:44< shadowm> That is, for all this time the default variation for a unit type with variations is to not use a variation. This seems perfectly natural and reasonable to me. 20130918 06:24:09< fabi> Yes, If you do not use variation= in [unit_type] the base unit is still the default. 20130918 06:25:02< shadowm> So why would someone want to use variation= in [unit_type] as opposed to just making that variation the base unit itself? 20130918 06:26:22< fabi> Well, my use case are different variations for height levels. 20130918 06:26:53< fabi> I have deep_submerged, submerged, ground_level, low_level_flight, medium_level_flight, high_level_flight and orbit. 20130918 06:28:08< fabi> I could make one of them the base unit. Maybe ground_level. 20130918 06:28:18-!- ivanovic-vancouv [60352936@gateway/web/freenode/ip.96.53.41.54] has joined #wesnoth-dev 20130918 06:28:24< fabi> But what about units that can never be at ground level? 20130918 06:28:51< fabi> Thus I decided that I never have non variation units in the game. 20130918 06:34:10< fabi> It makes my wml coding a lot easier this way. 20130918 06:35:25-!- noy [~Noy@50.98.14.44] has joined #wesnoth-dev 20130918 06:35:27-!- noy [~Noy@50.98.14.44] has quit [Changing host] 20130918 06:35:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20130918 06:35:46< fabi> I also want to implement for filtering if a unit has a certain variation. 20130918 06:35:57< shadowm> OK, in any case, please do update the changelog. :( 20130918 06:36:03< fabi> Sure. 20130918 06:36:24< irker293> wesnoth: Ignacio R. Morelle wesnoth-old:master 1e3e56b699f1 / RELEASE_NOTES: Updated RELEASE_NOTES for add-ons management improvements http://git.io/Tr2CoA 20130918 06:36:26< shadowm> And wiki. 20130918 06:36:38< fabi> Yes. 20130918 06:37:01< fabi> I also want to implement filtering if a unit has a certain variation type. 20130918 06:37:21< shadowm> I thought that's exactly what you just did? 20130918 06:37:23< fabi> Something like has_variation=ground_level 20130918 06:37:33< shadowm> Oh, that. 20130918 06:37:44< shadowm> Yeah, makes sense. 20130918 06:38:12< shadowm> wesbot: seen lipkab 20130918 06:38:13< wesbot> shadowm: The person with the nick lipkab last spoke 9h 8m ago. 8h 44m ago was here and on the channel #wesnoth with the message: Quit: Távozom 20130918 06:38:46< shadowm> lipkab: How would you prefer me to provide feedback on the MP game setup UI changes? Some forum thread, or just IRC? 20130918 06:40:34< shadowm> mattsc, other AI people: Please don't forget RELEASE_NOTES for any changes you feel are important for players/content authors to read about in the announcement for the next release, whenever that'll take place. 20130918 06:41:24< shadowm> lipkab: Actually, the same thing applies to you, seeing as how the MP setup UI changes take up four lines in the changelog. 20130918 06:42:29< shadowm> Not sure who's behind the MP [campaign] changes and I'm too lazy to check at the moment. I'm just preemptively making sure we don't get another insultingly bland announcement like 1.11.6's. Later. 20130918 06:58:06-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20130918 07:01:51-!- tomreyn_ [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20130918 07:05:39-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 264 seconds] 20130918 07:07:40-!- tomreyn_ is now known as tomreyn 20130918 07:14:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20130918 07:39:09-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20130918 07:59:16-!- tomreyn_ [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20130918 08:02:00-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Disconnected by services] 20130918 08:02:05-!- tomreyn_ is now known as tomreyn 20130918 08:06:40-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 245 seconds] 20130918 08:12:09-!- ivanovic-vancouv [60352936@gateway/web/freenode/ip.96.53.41.54] has quit [Quit: Page closed] 20130918 08:27:49-!- nurupo is now known as nurupo|away 20130918 08:32:06-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20130918 08:48:44-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20130918 08:53:02-!- stikonas [~gentoo@host-78-148-90-171.as13285.net] has joined #wesnoth-dev 20130918 08:53:02-!- stikonas [~gentoo@host-78-148-90-171.as13285.net] has quit [Changing host] 20130918 08:53:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130918 08:58:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds] 20130918 09:03:33-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has joined #wesnoth-dev 20130918 09:11:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20130918 09:42:24-!- Netsplit *.net <-> *.split quits: iwaim__ 20130918 09:42:47-!- Netsplit over, joins: iwaim__ 20130918 09:45:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds] 20130918 09:52:19-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20130918 09:52:20-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host] 20130918 09:52:20-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130918 10:11:47-!- Octalot [~noct@host86-140-22-59.range86-140.btcentralplus.com] has joined #wesnoth-dev 20130918 10:12:51-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has joined #wesnoth-dev 20130918 10:15:41-!- groggy [43eeb2e1@gateway/web/freenode/ip.67.238.178.225] has joined #wesnoth-dev 20130918 10:21:51-!- Upthorn [~ogmar@69.62.144.56] has joined #wesnoth-dev 20130918 10:27:57< groggy> espreon: your brit po commit on 1.10; didnt ivanovic fix the utbs "if if" typo? 20130918 10:28:47-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has quit [Quit: Leaving] 20130918 10:29:48-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has joined #wesnoth-dev 20130918 10:33:50< groggy> thunderstruck: do you intend for new_game_title to be translatable or not? 20130918 10:34:04-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has quit [Client Quit] 20130918 10:35:08< groggy> thunderstruck: you underscored the value, but when wmllint stripped the underscore, you committed the result 20130918 10:36:04< groggy> if you intend for it to be translatable, it will have to be added to wmllint's list of translatables to keep it from stripping the underscore 20130918 10:37:37-!- Kostic [~marko@net191-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev 20130918 10:41:48-!- markus_ [~mjs-de@d117237.adsl.hansenet.de] has joined #wesnoth-dev 20130918 10:41:48-!- mjs-de [~mjs-de@g224185030.adsl.alicedsl.de] has quit [Read error: Connection reset by peer] 20130918 10:45:33-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has quit [Quit: Konversation terminated!] 20130918 10:54:10-!- Kostic [~marko@net191-1-245-109.mbb.telenor.rs] has quit [Read error: Connection timed out] 20130918 11:03:28-!- markus_ is now known as mjs-de 20130918 11:05:32-!- groggy [43eeb2e1@gateway/web/freenode/ip.67.238.178.225] has quit [Quit: Page closed] 20130918 11:20:07-!- Ardonik [~ardonik@adsl-75-28-104-8.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev 20130918 11:24:10-!- Octalot [~noct@host86-140-22-59.range86-140.btcentralplus.com] has quit [] 20130918 11:26:59-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has joined #wesnoth-dev 20130918 11:29:03-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has joined #wesnoth-dev 20130918 11:29:03-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has quit [Changing host] 20130918 11:29:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130918 11:46:51-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has quit [Quit: DCW] 20130918 12:43:07-!- irker293 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130918 13:02:33-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20130918 13:29:18-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20130918 13:35:30-!- Ardonik [~ardonik@adsl-75-28-104-8.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 264 seconds] 20130918 13:35:31-!- Ard0nik [~ardonik@adsl-75-28-101-193.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev 20130918 13:44:20-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has joined #wesnoth-dev 20130918 13:49:34-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20130918 14:01:02-!- Kostic [~marko@85.202.113.171] has joined #wesnoth-dev 20130918 14:08:02-!- trademark [~trademark@37.161.130.238] has joined #wesnoth-dev 20130918 14:26:38-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20130918 14:35:07-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20130918 14:37:11-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20130918 14:43:02-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130918 14:54:01-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20130918 14:57:05-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 245 seconds] 20130918 14:57:57-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has joined #wesnoth-dev 20130918 15:20:02-!- ivanovic-vancouv [60352936@gateway/web/freenode/ip.96.53.41.54] has joined #wesnoth-dev 20130918 15:26:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20130918 15:28:51-!- Kostic [~marko@85.202.113.171] has quit [Quit: Kostic] 20130918 15:29:12-!- Kostic [~marko@85.202.113.171] has joined #wesnoth-dev 20130918 15:35:31-!- trademark [~trademark@37.161.130.238] has quit [Ping timeout: 260 seconds] 20130918 15:40:43-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20130918 15:45:58-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 245 seconds] 20130918 15:47:37-!- trademark [~trademark@37.161.182.68] has joined #wesnoth-dev 20130918 15:51:22-!- irker916 [~irker@ai0867.net] has joined #wesnoth-dev 20130918 15:51:22< irker916> wesnoth: Pierre T wesnoth-old:asio_umcd f5387b25b8f3 / src/tools/code_generator/sql2cpp/ (5 files in 2 dirs): Add the constraint unique on several columns and remove the constraint on a sing http://git.io/geYtEg 20130918 15:51:22< irker916> wesnoth: Pierre T wesnoth-old:asio_umcd b7563a26764e / src/umcd/otl/otl.hpp: Add support for the operator <<(otl_stream, boost::posix_time::ptime). http://git.io/9j5R_A 20130918 15:51:23< irker916> wesnoth: Pierre T wesnoth-old:asio_umcd 1adc30823810 / data/umcd/database/create_database.sql: Change the database to be compatible with the parser and add a unique constraint http://git.io/M-9UhA 20130918 15:51:24< irker916> wesnoth: Pierre T wesnoth-old:asio_umcd 53e6f96af416 / src/umcd/actions/ (request_umc_upload_action.cpp request_umc_upload_action.hpp): Update the upload request to add data inside the addon_version table. http://git.io/pXvfrg 20130918 15:51:25< irker916> wesnoth: Pierre T wesnoth-old:asio_umcd f43be99c5690 / src/umcd/ (10 files in 3 dirs): Add timeout on asynchronous transfer and correction of some design issue in the http://git.io/iUF3xA 20130918 15:51:27< irker916> wesnoth: Pierre T wesnoth-old:asio_umcd 207ba396473b / src/umcd/protocol/core/header_data_stream.cpp: Merge branch 'asio_umcd' of https://github.com/wesnoth/wesnoth-old into asio_umc http://git.io/5TE8Mw 20130918 15:51:28< irker916> wesnoth: Pierre T wesnoth-old:asio_umcd 9b24aca74cc8 / src/umcd/ (protocol/core/header_mutable_buffer.cpp server/transfer_events.hpp): Add reference in event slot. http://git.io/Tfkdjw 20130918 15:55:09-!- trademark [~trademark@37.161.182.68] has quit [Ping timeout: 276 seconds] 20130918 15:57:11-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has quit [Quit: Konversation terminated!] 20130918 16:08:01-!- trademark [~trademark@37.160.96.239] has joined #wesnoth-dev 20130918 16:09:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer] 20130918 16:10:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20130918 16:38:23-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130918 16:49:34-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 256 seconds] 20130918 16:50:48-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130918 16:51:46-!- ivanovic-vancouv [60352936@gateway/web/freenode/ip.96.53.41.54] has quit [Quit: Page closed] 20130918 16:52:03-!- Ivanovic [~ivanovic@x2f4dc0a.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20130918 16:56:06-!- Ivanovic [~ivanovic@x2f4ea2d.dyn.telefonica.de] has joined #wesnoth-dev 20130918 17:00:52-!- stikonas_ [~gentoo@vpn2-242.vpn.net.ed.ac.uk] has joined #wesnoth-dev 20130918 17:00:52-!- stikonas_ [~gentoo@vpn2-242.vpn.net.ed.ac.uk] has quit [Changing host] 20130918 17:00:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130918 17:01:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20130918 17:06:04-!- trademark [~trademark@37.160.96.239] has quit [Ping timeout: 248 seconds] 20130918 17:15:43-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130918 17:19:24-!- trademark [~trademark@37.160.140.75] has joined #wesnoth-dev 20130918 17:21:20-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Quit: Nettalk6 - www.ntalk.de] 20130918 17:25:00-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20130918 17:27:39-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20130918 17:36:23-!- trademark [~trademark@37.160.140.75] has quit [Ping timeout: 260 seconds] 20130918 17:48:47-!- trademark [~trademark@37.161.117.202] has joined #wesnoth-dev 20130918 18:28:44-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds] 20130918 18:49:41-!- ivanovic-vancouv [cf664603@gateway/web/freenode/ip.207.102.70.3] has joined #wesnoth-dev 20130918 18:51:22-!- ivanovic-vancouv [cf664603@gateway/web/freenode/ip.207.102.70.3] has quit [Client Quit] 20130918 18:53:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20130918 18:57:07-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds] 20130918 18:58:00-!- irker916 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130918 19:04:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130918 19:06:00-!- R2D2C3PO [57a14195@gateway/web/freenode/ip.87.161.65.149] has joined #wesnoth-dev 20130918 19:07:21-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20130918 19:07:34< anonymissimus> fabi: ping 20130918 19:09:06-!- stikonas [~gentoo@host-78-144-197-209.as13285.net] has joined #wesnoth-dev 20130918 19:09:06-!- stikonas [~gentoo@host-78-144-197-209.as13285.net] has quit [Changing host] 20130918 19:09:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130918 19:09:08< anonymissimus> fabi: where do you have "M_PI" defined in your build setup ? 20130918 19:11:48< Soliton> math.h 20130918 19:12:11< Soliton> looks like for msvc you get to define them yourself. 20130918 19:13:56< anonymissimus> yeah; fabi : I recall you defining PI locally at another spot; so the right thing to do is putting it as a global constant somewhere into our project 20130918 19:14:01< Soliton> we should probably add it to some global header. 20130918 19:14:07 * Soliton nods. 20130918 19:14:38< anonymissimus> I recall searching and was surprised that it isn't already somwhere 20130918 19:21:19< Soliton> maybe this would be convenient for us: http://www.boost.org/doc/libs/1_54_0/libs/math/doc/html/constants.html 20130918 19:23:40< fabi> anonymissimus: hi 20130918 19:26:35< anonymissimus> Soliton: if it doesn't add a dependency (I guess not if it's just a header with constants) 20130918 19:26:53< Soliton> yeah, that is my guess as well. 20130918 19:29:36-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130918 19:33:03< fabi> anonymissimus, Soliton: I am fine with both solutions. Just tell me how you want to get the issue fixed and I will do it. 20130918 19:35:27< Soliton> evaluate the use of that boost lib and/or define the needed math constants in a (maybe new) header of ours. 20130918 19:35:40< Soliton> and make sure that is used consistently. 20130918 19:53:29< fabi> okay 20130918 20:11:59< anonymissimus> fabi: I don't commit my local fix for PI then; if you're going to use the boost lib I guess it will work for me without the need to do anything about it 20130918 20:12:14< fabi> anonymissimus: Yepp 20130918 20:12:40< fabi> anonymissimus: I am already on it. 20130918 20:15:33-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has joined #wesnoth-dev 20130918 20:16:31-!- irker432 [~irker@ai0867.net] has joined #wesnoth-dev 20130918 20:16:31< irker432> wesnoth: anonymissimus wesnoth-old:master 93e28f42f36c / src/image_modifications.cpp: fix warnings about unreachable code http://git.io/7z1t3Q 20130918 20:16:31< irker432> wesnoth: anonymissimus wesnoth-old:master c0a24dc4b7c1 / src/sdl_utils.cpp: fix warning about unreachable code http://git.io/Z4Na3w 20130918 20:23:22< fabi> The boost constants are cool. You can use them like that pi. 20130918 20:31:33-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has quit [Quit: DCW] 20130918 20:32:35< anonymissimus> yes, boost::math::constants::pi() works 20130918 20:33:21-!- Kostic [~marko@85.202.113.171] has quit [Ping timeout: 276 seconds] 20130918 20:33:34< fabi> I wonder if it makes sense to define a lot of constants like pi_float, pi_double, pi_whatever. The coder might better use the boost lib directly. 20130918 20:40:48< anonymissimus> fabi: you added a header defining pi which refers to the boost pi ? 20130918 20:41:35< fabi> Well, that is the plan. I still search for an already existing header where it might fit in. 20130918 20:54:18< Soliton> i'd just use the boost constants directly, maybe adding a using directive if the namespace is too much. 20130918 20:59:36< fabi> Yes. 20130918 21:00:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20130918 21:11:39-!- nurupo|away is now known as nurupo 20130918 21:18:30-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130918 21:38:52-!- yann_ is now known as yann 20130918 21:39:34-!- R2D2C3PO [57a14195@gateway/web/freenode/ip.87.161.65.149] has quit [Quit: Page closed] 20130918 21:39:57-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130918 21:44:29-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Quit: Távozom] 20130918 21:59:30-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving] 20130918 22:03:53-!- Kostic [~marko@net200-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev 20130918 22:44:27-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has quit [Quit: Leaving] 20130918 22:45:12-!- ivanovic-richmon [a98ff473@gateway/web/freenode/ip.169.143.244.115] has joined #wesnoth-dev 20130918 22:49:23-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20130918 22:49:33-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has joined #wesnoth-dev 20130918 22:55:01-!- Velvet-Sky [~SkyNet@99-111-224-165.lightspeed.rcsntx.sbcglobal.net] has quit [Quit: Leaving] 20130918 23:03:44-!- qwebirc943432 [cf664603@gateway/web/freenode/ip.207.102.70.3] has joined #wesnoth-dev 20130918 23:04:23-!- ivanovic-richmon [a98ff473@gateway/web/freenode/ip.169.143.244.115] has quit [Ping timeout: 250 seconds] 20130918 23:04:53-!- qwebirc943432 is now known as Ivanovic-richmon 20130918 23:04:54-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 240 seconds] 20130918 23:07:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20130918 23:07:43-!- trademark [~trademark@37.161.117.202] has quit [Ping timeout: 260 seconds] 20130918 23:16:30-!- irker432 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130918 23:18:30-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has quit [Read error: Connection reset by peer] 20130918 23:26:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20130918 23:31:10-!- Kostic [~marko@net200-1-245-109.mbb.telenor.rs] has quit [Ping timeout: 268 seconds] 20130918 23:31:32-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 11.0/20120312181643]] 20130918 23:43:27-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Thu Sep 19 00:00:34 2013