--- Log opened Sun Sep 22 00:00:08 2013 20130922 00:12:30-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20130922 00:16:18-!- flix1 [~flix@37-5-10-145-dynip.superkabel.de] has quit [Ping timeout: 264 seconds] 20130922 00:27:30-!- flix [~flix@37-5-10-145-dynip.superkabel.de] has joined #wesnoth-dev 20130922 00:27:54-!- flix [~flix@37-5-10-145-dynip.superkabel.de] has left #wesnoth-dev [] 20130922 00:27:54< jamit> shadowm: Sure. Low expectations are easy to meet. :P 20130922 00:28:30< jamit> shadowm: That change replaces a homebrew system with boost::shared_ptr, so probably no spontaneous combustion. 20130922 00:44:24-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds] 20130922 00:44:41-!- Ivanovic [~ivanovic@x2f4c4cf.dyn.telefonica.de] has joined #wesnoth-dev 20130922 00:45:22-!- Ivanovic [~ivanovic@x2f4c4cf.dyn.telefonica.de] has quit [Changing host] 20130922 00:45:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20130922 00:45:23-!- molgrum_ [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev 20130922 00:46:25-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Read error: Connection reset by peer] 20130922 00:47:35-!- stikonas [~gentoo@cpc3-sgyl27-2-0-cust146.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130922 00:47:35-!- stikonas [~gentoo@cpc3-sgyl27-2-0-cust146.sgyl.cable.virginmedia.com] has quit [Changing host] 20130922 00:47:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130922 00:51:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Operation timed out] 20130922 00:51:46-!- stikonas [~gentoo@anon-36-36.vpn.ipredator.se] has joined #wesnoth-dev 20130922 00:51:46-!- stikonas [~gentoo@anon-36-36.vpn.ipredator.se] has quit [Changing host] 20130922 00:51:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130922 00:51:56-!- stikonas__ [~gentoo@cpc3-sgyl27-2-0-cust146.sgyl.cable.virginmedia.com] has quit [Ping timeout: 260 seconds] 20130922 00:59:27-!- lipkab [~the_new_l@apn-89-223-213-222.vodafone.hu] has quit [Quit: Nettalk6 - www.ntalk.de] 20130922 01:01:26-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 248 seconds] 20130922 01:03:47-!- mattsc [~mattsc@154.20.32.246] has quit [Read error: Connection reset by peer] 20130922 01:07:48-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev 20130922 01:23:03-!- nurupo|away is now known as nurupo 20130922 01:32:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20130922 01:43:20-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130922 01:43:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds] 20130922 01:44:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit] 20130922 01:49:34-!- Crendgrim [~crend@77-23-29-102-dynip.superkabel.de] has quit [Quit: Konversation terminated!] 20130922 01:56:03-!- Ivanovic [~ivanovic@x2f4fabe.dyn.telefonica.de] has joined #wesnoth-dev 20130922 01:56:43-!- Ivanovic [~ivanovic@x2f4fabe.dyn.telefonica.de] has quit [Changing host] 20130922 01:56:45-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20130922 02:15:02-!- nurupo is now known as nurupo|away 20130922 02:16:54-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 264 seconds] 20130922 02:20:26-!- irker975 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130922 02:27:18-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130922 03:08:44-!- love1cat [~Adium@c-76-119-168-240.hsd1.ma.comcast.net] has joined #wesnoth-dev 20130922 03:10:01-!- irker101 [~irker@ai0867.net] has joined #wesnoth-dev 20130922 03:10:01< irker101> wesnoth: Ignacio R. Morelle wesnoth-old:master a93a37244830 / / (5 files in 2 dirs): addon/client: Move connection step to a separate member method http://git.io/Mwn1hQ 20130922 03:15:49-!- mjs-de [~mjs-de@g224190040.adsl.alicedsl.de] has quit [Quit: On the road again] 20130922 03:20:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds] 20130922 03:27:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130922 03:57:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds] 20130922 04:05:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130922 04:22:28-!- Ivanovic_ [~ivanovic@x2f4ede6.dyn.telefonica.de] has joined #wesnoth-dev 20130922 04:23:34-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer] 20130922 04:23:55-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130922 04:25:43-!- Ivanovic_ [~ivanovic@x2f4ede6.dyn.telefonica.de] has quit [Changing host] 20130922 04:25:44-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20130922 04:26:04-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 260 seconds] 20130922 04:27:14-!- Ivanovic_ is now known as Ivanovic 20130922 04:31:40-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has joined #wesnoth-dev 20130922 05:37:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds] 20130922 05:38:17-!- love1cat [~Adium@c-76-119-168-240.hsd1.ma.comcast.net] has left #wesnoth-dev [] 20130922 05:43:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130922 05:43:28-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer] 20130922 05:55:05-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood] 20130922 05:55:30-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20130922 05:57:03-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130922 06:02:17-!- mattsc [~mattsc@154.20.32.246] has quit [Quit: Ciao] 20130922 06:07:02-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 248 seconds] 20130922 06:13:16-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20130922 06:15:31-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20130922 06:39:17-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has joined #wesnoth-dev 20130922 07:14:11-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20130922 07:55:48-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130922 07:58:02-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130922 07:58:34< shadowm> Am I doing fork/exec/wait right? http://pastebin.com/E3dLVHFc (This is intended to land in mainline, by the way.) 20130922 07:59:30< shadowm> (Also, no, I don't want to use system(). It eats kittens.) 20130922 08:26:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130922 08:28:42-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130922 08:52:22-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 248 seconds] 20130922 09:03:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20130922 09:14:30-!- trademark [~trademark@37.160.93.15] has joined #wesnoth-dev 20130922 09:16:50< AI0867> shadowm: looks okay 20130922 09:26:24-!- irker101 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130922 09:38:35-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130922 09:41:35< fabi> shadowm: I like to ask how team colors work. I guess you know a little bit about them, being the author of the team color tool. 20130922 09:45:34< shadowm> You would like to ask how team colors work. Okay, what's the question(s)? 20130922 09:45:34< fabi> shadowm: The color_palette tag seems not to be covered in the wml reference wiki. Is that right, or is it just not listened? 20130922 09:45:45< fabi> I have learned that just putting every color which needs to be translated in the list is not enough. 20130922 09:46:16< fabi> The order of the sequence seems to play an important role. 20130922 09:46:26< fabi> But how shall I sort them? 20130922 09:47:54< shadowm> "Listened"? 20130922 09:48:02< shadowm> I think you mean "listed". 20130922 09:48:17< fabi> Indeed 20130922 09:49:06< shadowm> Yeah, [color_palette] and [color_range] aren't in the wiki at all, apparently. 20130922 09:50:05< shadowm> fabi: I know the sequence order matters when you are using the ~PAL() image path function (or its implementation detail), but I don't know if it does for ~RC() (or its implementation detail, shared by ~TC()). 20130922 09:51:33< fabi> I do not use any image path functions. 20130922 09:51:34< shadowm> In the ~PAL() case, it matters in that for a source palette with colors A1,A2,...,An and a target palette with colors B1,B2,...,Bn, Ax will be replaced with Bx for any given value of x from 1 to n. 20130922 09:52:15< shadowm> fabi: "Or its implementation detail". i.e. ~RC()'s implementation detail is used for implicit team coloring. 20130922 09:52:32< fabi> Ah yes. 20130922 09:52:53< fabi> Okay, then the order matters for ~RC() as well. 20130922 09:53:40< shadowm> It sounds from the implementation of recolor_range() (src/color_range.cpp) that the first color at least is magic in some way. 20130922 09:53:50< fabi> Indeed. 20130922 09:54:03< fabi> Changing the first one has a huge impact. 20130922 09:54:12-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has joined #wesnoth-dev 20130922 09:54:35< shadowm> Looking at the mainline magenta palette on RCX, it seems to be sorted from the darkest shade (starting from the second color) to the lightest one at the end. 20130922 09:55:38< shadowm> Given that color_ranges work with average, minimum, and maximum shades, yeah, there must be some deeper significance to that order. :p (Maths.) 20130922 09:55:43-!- zookeeper [~lmsnie@87-100-225-7.bb.dnainternet.fi] has joined #wesnoth-dev 20130922 09:55:48-!- zookeeper [~lmsnie@87-100-225-7.bb.dnainternet.fi] has quit [Changing host] 20130922 09:55:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20130922 09:56:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130922 09:56:43< shadowm> ellipse_red is backwards, though. The second shade is the lightest and the last one the darkest. 20130922 09:56:49< shadowm> Same goes for flag_green. 20130922 09:57:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20130922 09:57:27< fabi> Hmmm, how do you know about "light" and "dark"? 20130922 09:57:45< shadowm> Visually? 20130922 09:57:55< fabi> From the hex numbers. 20130922 09:58:03< shadowm> Numerically, #ffffff is the lightest color (white) and #000000 the darkest one (black), so... 20130922 09:58:36< fabi> Okay, so just sorting them by their value seems a good idea. 20130922 09:58:37< shadowm> If you need something more specific I suppose you could look up a color's V/L value when converted to HSV/HSL. 20130922 09:59:09< shadowm> Or more generally, calculate its V/L value. 20130922 09:59:55-!- irker124 [~irker@ai0867.net] has joined #wesnoth-dev 20130922 09:59:55< irker124> wesnoth: Pierre T wesnoth-old:asio_umcd 985331dc1250 / src/umcd/ (12 files in 6 dirs): Add missing Doxygen documentation in some classes. http://git.io/GGAWzg 20130922 10:02:09-!- H-Hour_ [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has joined #wesnoth-dev 20130922 10:02:43< fabi> shadowm: Damn, I have that many values to handle I guess it will take ages to get this done right. 20130922 10:03:21< shadowm> What are you trying to do? 20130922 10:03:56< fabi> Well, I have a set of unit images. They are team colored. But the team color is not our magenta range. 20130922 10:04:30< fabi> http://www.battle-planet.de/pbp/dev/cromoner_forschung_land.php 20130922 10:05:05-!- H-Hour_ [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has quit [Client Quit] 20130922 10:08:28< shadowm> It's the red colors? 20130922 10:08:52< fabi> Yes 20130922 10:12:56< shadowm> The palette seems dead simple then. Just shades of red with all other channels set to zero. 20130922 10:12:56< shadowm> Like our own ellipse_red. 20130922 10:12:56< shadowm> Okay, well, there's a few non pure red colors. 20130922 10:12:56< shadowm> Still, that shouldn't be too hard to sort. 20130922 10:19:16-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has joined #wesnoth-dev 20130922 10:23:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20130922 10:24:45-!- Gallaecio [~quassel@84.120.112.34.dyn.user.ono.com] has joined #wesnoth-dev 20130922 10:32:26< fabi> shadowm: Yeah, I have figured out a much better result than I had previously. Thank you :-) 20130922 10:46:32-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has quit [Remote host closed the connection] 20130922 11:07:08-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: Lost terminal] 20130922 11:09:36-!- mjs-de [~mjs-de@g224184026.adsl.alicedsl.de] has joined #wesnoth-dev 20130922 11:09:59-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Remote host closed the connection] 20130922 11:11:34-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20130922 11:24:24-!- trademark [~trademark@37.160.93.15] has quit [Ping timeout: 268 seconds] 20130922 11:37:52-!- trademark [~trademark@37.161.119.193] has joined #wesnoth-dev 20130922 11:45:30-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has joined #wesnoth-dev 20130922 11:52:06-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has quit [Ping timeout: 252 seconds] 20130922 12:47:12-!- lipkab [~the_new_l@apn-94-44-223-190.vodafone.hu] has joined #wesnoth-dev 20130922 12:49:13-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has quit [Quit: Leaving] 20130922 12:56:03-!- molgrum_ [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar] 20130922 13:12:08-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has joined #wesnoth-dev 20130922 13:44:19-!- lipkab [~the_new_l@apn-94-44-223-190.vodafone.hu] has quit [Quit: Nettalk6 - www.ntalk.de] 20130922 13:46:38-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20130922 13:47:51-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20130922 13:55:28-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20130922 13:56:01-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has joined #wesnoth-dev 20130922 14:05:40-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has quit [Remote host closed the connection] 20130922 14:06:25-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has joined #wesnoth-dev 20130922 14:10:28-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20130922 14:11:01-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving] 20130922 14:14:34-!- EdB [~edb@AToulouse-159-1-57-200.w92-134.abo.wanadoo.fr] has quit [Quit: Konversation terminated!] 20130922 14:22:51-!- Crendgrim [~crend@77-23-29-102-dynip.superkabel.de] has joined #wesnoth-dev 20130922 14:30:06-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130922 14:33:32-!- irker124 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20130922 14:54:53-!- Ard0n1k [~ardonik@adsl-75-28-104-156.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev 20130922 14:55:18-!- Ard0nik [~ardonik@adsl-75-28-99-210.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 264 seconds] 20130922 14:55:58-!- Ard0n1k is now known as Ardonik 20130922 14:59:40-!- Vandal is now known as Ganrao 20130922 14:59:48-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130922 15:15:24-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds] 20130922 15:15:51-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20130922 15:16:00-!- stikonas_ [~gentoo@cpc3-sgyl27-2-0-cust146.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130922 15:16:00-!- stikonas_ [~gentoo@cpc3-sgyl27-2-0-cust146.sgyl.cable.virginmedia.com] has quit [Changing host] 20130922 15:16:00-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130922 15:19:13-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20130922 15:47:04-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20130922 15:47:20< mordante> servus 20130922 16:05:52< Ivanovic> hi mordante 20130922 16:05:59< mordante> hi Ivanovic 20130922 16:09:18-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds] 20130922 16:12:55-!- nurupo|away is now known as nurupo 20130922 16:25:35-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev 20130922 16:25:54-!- trademark [~trademark@37.161.119.193] has quit [Ping timeout: 264 seconds] 20130922 16:27:46-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20130922 16:37:33-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20130922 16:38:54-!- trademark [~trademark@37.161.119.193] has joined #wesnoth-dev 20130922 16:45:30< fabi> hi mordante 20130922 16:45:44< fabi> hi Ivanovic 20130922 16:45:58< mordante> hi fabi 20130922 16:54:41< fabi> zookeeper: Hello, I have done some work on the artillery unit and I am facing unexpected problems. The event solution suits me best but I can't see how I can make it work without disabling undo. Using a weapon special isn't working at all because I can't filter for moves=. I thought it would be doable by using conditional WML but it seems the weapon specials do not feature that. 20130922 16:55:22< zookeeper> you can filter for moves with [filter_wml] 20130922 16:55:49< fabi> And compare it with max_moves? 20130922 16:55:56< zookeeper> yes 20130922 16:56:02< fabi> Oh. 20130922 16:56:22< zookeeper> [filter_wml] moves="$($this_unit.max_moves)" or something like that 20130922 16:56:41< fabi> cool 20130922 17:18:36< trademark> mordante, hi 20130922 17:30:41-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130922 17:31:52< thunderstruck> fabi: Hello. There are same problems with other campaigns with wmllint as with LoW. 20130922 17:32:32< fabi> hi thunderstruck 20130922 17:32:35< thunderstruck> fabi: And I don't really have an idea where to look for a problem. 20130922 17:39:22< fabi> esr: Hello, do you want to help with some wmllint issues? 20130922 17:41:20-!- jamit [~jamit@wesnoth/developer/jamit] has quit [Quit: Leaving.] 20130922 17:42:42-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20130922 17:42:56< fabi> zookeeper: [filter_self] [not] [filter_wml] moves=$this_unit.max_moves works :-) 20130922 17:43:04< zookeeper> it does 20130922 17:43:10< zookeeper> i've used that a few times myself 20130922 17:43:12< fabi> yeah 20130922 17:43:23< fabi> like a charm 20130922 17:43:34-!- trademark [~trademark@37.161.119.193] has quit [Ping timeout: 248 seconds] 20130922 17:44:23-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 256 seconds] 20130922 17:44:27< fabi> thunderstruck: I think anonymisimus fixed some wmllint related bugs recently. He might be able to solve this problem as well. 20130922 17:48:14-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130922 18:15:01-!- trademark [~trademark@37.160.96.114] has joined #wesnoth-dev 20130922 18:16:20-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 260 seconds] 20130922 18:16:49-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev 20130922 18:21:43-!- Espreon [~espreon@wesnoth/developer/espreon] has quit [Ping timeout: 260 seconds] 20130922 18:22:06-!- Espreon [~espreon@ai0867.net] has joined #wesnoth-dev 20130922 18:22:28-!- Espreon is now known as Guest46564 20130922 18:38:56-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130922 18:39:56-!- lipkab2 [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130922 18:41:42< shadowm> nurupo: The vector returned by utils::string_to_wstring() is not NULL-terminated, that's why it wasn't working for you. 20130922 18:41:46< shadowm> It's also why I just wasted several hours investigating a heisenbug. 20130922 18:41:56< shadowm> (In my own code.) 20130922 18:42:01< nurupo> shadowm: i see 20130922 18:43:30-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 252 seconds] 20130922 18:43:32-!- lipkab3 [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130922 18:44:01< shadowm> I'm not sure the data retrieved by std::wstring::data() is NULL-terminated either, but the result of the c_str() method is. 20130922 18:44:36-!- lipkab2 [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 252 seconds] 20130922 18:45:26< shadowm> Yeah, no, it's not guaranteed data()'s result is. 20130922 18:45:44< shadowm> So I'll change that in windows_tray_notification.cpp later as well. 20130922 18:47:20-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has joined #wesnoth-dev 20130922 18:47:20-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has quit [Changing host] 20130922 18:47:20-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130922 18:56:40< nurupo> shadowm: yes, change data() to c_str(). also, i find it kind of weird that `wide_string string_to_wstring(const std::string &src)` doesn't return std::wstring 20130922 18:57:01< nurupo> what is the benefit of having vector of wide chars? 20130922 18:57:25< shadowm> I have no idea what the logic behind that design was. 20130922 18:58:35< shadowm> I just noticed that there's still some code working around VC++ 6.0 missing features, perhaps that might be related. 20130922 18:59:52< nurupo> heh, i already gave up on VC++ in favor of gcc (MinGW) on Windows :) 20130922 19:04:41-!- DCW1 [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has joined #wesnoth-dev 20130922 19:05:39-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20130922 19:11:28-!- lipkab3 [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 265 seconds] 20130922 19:14:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20130922 19:18:42-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev 20130922 19:26:34-!- gfgtdf [~chatzilla@f054152136.adsl.alicedsl.de] has joined #wesnoth-dev 20130922 19:29:22-!- irker620 [~irker@ai0867.net] has joined #wesnoth-dev 20130922 19:29:22< irker620> wesnoth: JaMiT wesnoth-old:master 0774ca49f41f / src/ (gamestatus.cpp gamestatus.hpp play_controller.cpp): Using a typedef to make some code easier to read. http://git.io/xyznXQ 20130922 19:29:24< irker620> wesnoth: JaMiT wesnoth-old:master 501581ea740a / src/ (gamestatus.hpp iterator.hpp): Turn wmi_container into a container. http://git.io/Culw9A 20130922 19:29:26< irker620> wesnoth: JaMiT wesnoth-old:master dcae119497c4 / src/ (game_events/handlers.cpp gamestatus.cpp play_controller.cpp): Make use of wmi_container's new features. http://git.io/v-8khA 20130922 19:29:28< irker620> wesnoth: JaMiT wesnoth-old:master 72f6b5ead639 / src/ (game_events/action_wml.cpp gamestatus.cpp gamestatus.hpp): Add find() and erase() to wmi_container. http://git.io/9r_P3w 20130922 19:29:30< irker620> wesnoth: JaMiT wesnoth-old:master 7aeacc554c0d / src/gamestatus.hpp: Remove wmi_container::get_menu_items(). http://git.io/kIjGyA 20130922 19:29:32< irker620> wesnoth: JaMiT wesnoth-old:master 22796e208a01 / src/ (4 files in 2 dirs): Have wmi_container::get_item() return an item instead of a pointer. http://git.io/aFonAg 20130922 19:29:34< irker620> wesnoth: JaMiT wesnoth-old:master 2401cdba8f3e / src/ (play_controller.cpp play_controller.hpp): const-qualify elements of play_controller::wml_commands_. http://git.io/eTmddQ 20130922 19:29:36< irker620> wesnoth: JaMiT wesnoth-old:master b9821441a992 / src/game_events/action_wml.cpp: No need to search through a container twice. http://git.io/93gw9Q 20130922 19:36:34< irker620> wesnoth: Ignacio R. Morelle wesnoth-old:master a1d818ecaa89 / src/ (windows_tray_notification.cpp windows_tray_notification.hpp): Fix instances of 'handle' typoed as 'hanlde' http://git.io/qVzs-Q 20130922 19:36:37< irker620> wesnoth: Ignacio R. Morelle wesnoth-old:master 1ad6d1cc967e / changelog players_changelog src/windows_tray_notification.cpp: Use std::wstring::c_str() to get null-terminated strings, not data() http://git.io/2TJNvA 20130922 19:43:53< fabi> shadowm, zookeeper: The [+any_tag] syntax. What do you think about a [~any_tag] syntax, which does not add to the former tag of the same name but replaces it? 20130922 19:44:47< zookeeper> fine by me 20130922 19:45:06< shadowm> I can't think of any possible uses atm. 20130922 19:45:30< zookeeper> (for what it's worth, neither can i) 20130922 19:46:06< shadowm> mattsc: Around? 20130922 19:47:04< fabi> My use case is a weapon macro with some specials. The derived weapon is used like: {THE_WEAPON_MACRO}[+attack] [+specials] [the_first_special] 20130922 19:47:29< mattsc> shadowm: yes 20130922 19:47:30< fabi> Say I want to replace the "first_special" with another one, I can't currently do so. 20130922 19:47:55< shadowm> mattsc: I updated my external branch, you might want to pull and test again. :p 20130922 19:48:21< mattsc> shadowm: okay 20130922 19:49:13< fabi> Nor can I remove the special. The new [any_tag] __remove=yes syntax does the trick whenever a config is merged. But in this case it is a wml parser thing like shadowm explained me. 20130922 19:50:49< shadowm> 14:47:28 Say I want to replace the "first_special" with another one, I can't currently do so. 20130922 19:51:03< shadowm> I'd rethink THE_WEAPON_MACRO in that case. 20130922 19:51:54< shadowm> Just saying that that's the normal think to do. 20130922 19:51:54< shadowm> thing 20130922 19:54:20-!- travis-ci [~travis-ci@ec2-54-243-23-104.compute-1.amazonaws.com] has joined #wesnoth-dev 20130922 19:54:20< travis-ci> [travis-ci] wesnoth/wesnoth-old#587 (master - b982144 : JaMiT): The build was broken. 20130922 19:54:20< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11660454 20130922 19:54:20-!- travis-ci [~travis-ci@ec2-54-243-23-104.compute-1.amazonaws.com] has left #wesnoth-dev [] 20130922 19:55:22< fabi> shadowm: https://github.com/fendrin/CombatShore/blob/master/data/core/units/_weapon.cfg That are all my weapon macros. How would you redesign them? 20130922 19:55:48< nurupo> >The build was broken. 20130922 19:56:44< shadowm> fabi: Is that a trick question? 20130922 19:57:16< shadowm> Like yeah, you are throwing non-trivial code I didn't write at me which depends on additional macros I've never seen. 20130922 19:57:33< shadowm> Not sure what you expect me to do given such a situation. 20130922 19:58:10< fabi> https://github.com/fendrin/CombatShore/blob/master/data/core/macros/weapon-specials.cfg Contains the only (iirc) used macros in _weapons.cfg 20130922 19:58:44< shadowm> I said "I didn't write". 20130922 19:59:07< shadowm> The most obvious thing would be making the [specials] contents one of the weapon macro parameters. 20130922 19:59:11< fabi> Neither did I. It is a converted file. 20130922 19:59:33< shadowm> Uh, yeah, I don't normally hear of machine-generated WML. 20130922 20:00:02< shadowm> But you presumably wrote the conversion script. 20130922 20:01:53-!- lipkab3 [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20130922 20:02:25-!- travis-ci [~travis-ci@ec2-54-211-149-66.compute-1.amazonaws.com] has joined #wesnoth-dev 20130922 20:02:25< travis-ci> [travis-ci] wesnoth/wesnoth-old#588 (master - 1ad6d1c : Ignacio R. Morelle): The build was broken. 20130922 20:02:25< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/11660586 20130922 20:02:25-!- travis-ci [~travis-ci@ec2-54-211-149-66.compute-1.amazonaws.com] has left #wesnoth-dev [] 20130922 20:02:49< fabi> Is it okay to modify the attack dialog to not show weapons which can't do any damage? 20130922 20:05:13-!- DCW1 [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has quit [Quit: DCW1] 20130922 20:06:59< jamit> fabi: Why? 20130922 20:07:36< fabi> Because attacking with a weapon that can't do any damage is not an action that does make any sense for the attacker. 20130922 20:08:08< jamit> Poison? Slow? Drain? 20130922 20:08:27< jamit> And my question was really aimed at what prompted that question. 20130922 20:08:42< jamit> Why does the attacker have a weapon that cannot do damage? 20130922 20:09:31< fabi> Don't the named weapon specials rely on inflicting at least one single point of damage? 20130922 20:10:36< jamit> I don't think so. Well, the percentage-based drain does, but wasn't a fixed-amount drain added? 20130922 20:11:59< fabi> If you want to code a weapon which relies on certain preconditions to be useful (say a spell of a dark sorcerer which can only be used at night) the only way known to me is either setting it's number= or damage= values to zero. 20130922 20:13:00< fabi> My use case is several height levels a unit can be on. 20130922 20:13:19< fabi> Some weapons can not be used from or against all height levels. 20130922 20:14:21< fabi> For example, a submerged submarine can not be attacked with a machine gun. 20130922 20:14:53-!- thunderstruck [~thunderst@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: Leaving] 20130922 20:15:31-!- Guest46564 is now known as Espreon 20130922 20:15:35-!- Espreon [~espreon@ai0867.net] has quit [Changing host] 20130922 20:15:35-!- Espreon [~espreon@wesnoth/developer/espreon] has joined #wesnoth-dev 20130922 20:16:45< fabi> jamit: If the dialog does not show the weapons which can not inflict damage but those which have number=0 it should be safe. 20130922 20:22:31< jamit> fabi: What if the attacker wants the unit to die? I seem to recall an item that basically exploded when its bearer died. Or maybe the defender has an attack that is self-damaging, and the attacker wants to trigger it? 20130922 20:22:57< mattsc> shadowm: it compiles and all the "file manager" buttons open Finder 20130922 20:23:23< shadowm> OK, I think I'm basically ready for merging it upstream now. 20130922 20:23:33< mattsc> The "copy link" thinks also work, just that spaces come across with the '\ '. I assume there's not much you can do about that though? 20130922 20:23:46< mattsc> s/thinks/things 20130922 20:24:06< mattsc> grrr! and: s/with/without 20130922 20:24:28< shadowm> Hm, you mean that spaces are there with the backslash escape? 20130922 20:24:48< mattsc> No without (sorry, typo)/ So when you copy it into a terminal window, you have to insert the \ manually 20130922 20:25:32< mattsc> You could argue that you want it to be that way for copying into dialogs etc. 20130922 20:26:16< shadowm> This goes along the same line as the dialog in Windows using forward slashes instead of back slashes. I had written a patch to amend that, but I then decided to not use it since part of the dialog's mission is to be useful for debugging, so the exact path format used by Wesnoth to communicate with the OS would be the most optimal for that end. 20130922 20:26:52< shadowm> Also, paths with whitespace can also be wrapped in single quotes (no shell expansion) or double quotes (for shell expansion of e.g. $VARIABLES) in the shell. 20130922 20:27:06< shadowm> That's usually much faster than escaping every single space by hand. ;) 20130922 20:27:33< mattsc> yes. In fact, I just tried that with the pasted link for the saves dir. It works. 20130922 20:28:23< mattsc> And duh! (one of those "in retrospect that's so obvious" things) 20130922 20:28:36< shadowm> OK, thanks for your help. That's all for now. 20130922 20:28:36< mattsc> shadowm: so as far as I can tell, everything works as it should. 20130922 20:28:49< mattsc> Great. 20130922 20:30:27< fabi> jamit: Hmmm, yes. So there might be attacks with number=0 serving some special purposes. I guess that is even more esoteric than my use cases. 20130922 20:32:46< jamit> fabi: More esoteric? I thought there was an explode-upon-death item in a campaign, but maybe it wasn't mainline. I believe a self-damaging attack is in the test scenario. I don't recall ever seeing machine guns or submarines in a BfW game though... 20130922 20:33:45< jamit> I guess it depends on if you are looking at how often the situation comes up, or how often it comes up assuming certain units exist. 20130922 20:34:04< shadowm> THoT has an item that causes the unit to kill everyone adjacent to it when it dies. 20130922 20:34:23< fabi> jamit: I speak about self-damaging attacks that would be triggered by attacks with number=0 or having number=0 themselves. 20130922 20:35:16< jamit> shadowm: Thanks. That was probably what I was thinking of. Just could not remember where I saw it. 20130922 20:35:26< fabi> I think this combination is more esoteric. 20130922 20:37:10< jamit> Attacker with 0 attacks, defender with 5 attacks each of which damages the defender by 3 when they hit: Wouldn't that potentially damage the defender by 15, even though the attacker has 0 attacks? 20130922 20:37:46< fabi> I think so. 20130922 20:40:56-!- trewe [~trewe@87.196.13.44] has joined #wesnoth-dev 20130922 20:42:03< fabi> If one wants to code an attack that does not do any damage but is still shown in the attack dialog (and thus being usable), she can use number!=0 but damage=0. 20130922 20:42:22< jamit> So the only esoteric part about triggering that is the attacker having 0 attacks, which is the assumption that started the discussion. 20130922 20:42:47< jamit> strong and dexterous say damage=0 is not a solution. 20130922 20:43:04< fabi> Indeed. 20130922 20:44:12< jamit> You are trying to simulate a way to disable an attack without actually disabling an attack. That approach made sense when it was asked in the WML workshop, where source code is off the table. 20130922 20:46:16< fabi> Well, I try to do as much as possible by using the power of WML, introducing more power to WML or changing the engine in other ways is always hard because of much discussion. 20130922 20:46:24< zookeeper> oh look, there's a related FR from 2007: https://gna.org/bugs/?8813 :p 20130922 20:46:57< zookeeper> although i suppose these days i'd rather see a [filter_condition] 20130922 20:47:16< jamit> That FR must have been written by someone with foresight. :) 20130922 20:48:23< fabi> zookeeper: Cool, that FR is exactly what I want to implement. 20130922 20:49:28< fabi> zookeeper: I have discussed it with gfgtdf or bumbadadabum (I think it was gfgtdf) already here in the channel. 20130922 20:50:18< fabi> zookeeper: Do you think it should be a direct subtag of [attack]? Or is it better implemented as a new weapon special? 20130922 20:50:36< zookeeper> a special would work too 20130922 20:53:24< fabi> The weapon special has the advantage that you can give it a proper description. Informing the user about how the filter works is hard to archive fully automated. 20130922 20:53:58< zookeeper> uh... you can tell the user whatever you want by using [dummy] specials 20130922 20:54:27< zookeeper> err. 20130922 20:54:47< zookeeper> i wonder if that worked for specials or not. i guess it probably does. 20130922 21:01:00< fabi> zookeeper: Well, I can implement it either as a direct subtag of attack or as a weapon special. You are the wml syntax guru. I will follow your advice. 20130922 21:01:49< zookeeper> weapon special, then. it has the advantage that you can give it to a unit with [effect]. 20130922 21:01:54-!- lipkab3 [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Quit: Nettalk6 - www.ntalk.de] 20130922 21:02:04< fabi> zookeeper: So will it be. 20130922 21:02:22< zookeeper> [disable_attack] or something 20130922 21:03:22< fabi> Maybe a nice addition would be to not just drop the disabled attack from the attack dialog but gray it out. 20130922 21:04:04 * zookeeper shrugs 20130922 21:04:21< zookeeper> that's not how other forms of attack-is-unavailable things work, though 20130922 21:04:29< zookeeper> (such as if you have attack_weight=0) 20130922 21:06:52< fabi> Good point. 20130922 21:07:22 * fabi is away, celebrating that the FDP fuckers are no longer present in the German parliament. 20130922 21:17:08< Gambit> It always confuses me how "liberal" parties in europe are super conservative 20130922 21:17:35< Gambit> But then again so does celsius and the metric system. 20130922 21:17:43< Gambit> Hey-o. Self deprecating american jokes. 20130922 21:23:38-!- _trewe [~trewe@87-196-56-96.net.novis.pt] has joined #wesnoth-dev 20130922 21:23:47< bumbadadabum> Gambit: Are you sure you wanted to post this here? 20130922 21:24:12< Gambit> No. I was replying to fabi. 20130922 21:24:27< bumbadadabum> ok 20130922 21:24:33< bumbadadabum> well, because it's not true 20130922 21:25:00-!- trewe [~trewe@87.196.13.44] has quit [Ping timeout: 245 seconds] 20130922 21:25:15< Gambit> I looked up the FDP. They're called "liberal", but they're right wing as shit. 20130922 21:25:21< bumbadadabum> well 20130922 21:25:28< bumbadadabum> in Europe, the liberals are the right wing 20130922 21:25:35< bumbadadabum> (in my country, at least) 20130922 21:25:52< Gambit> Yes, and I said that always confuses me. 20130922 21:25:58< bumbadadabum> It's rather the americans being extremely right wing 20130922 21:26:15< zookeeper> umm. right/left isn't anywhere near the same thing as liberal/conservative. 20130922 21:26:26-!- _trewe [~trewe@87-196-56-96.net.novis.pt] has quit [Max SendQ exceeded] 20130922 21:28:32-!- trewe [~trewe@87-196-56-96.net.novis.pt] has joined #wesnoth-dev 20130922 21:32:44-!- trewe [~trewe@87-196-56-96.net.novis.pt] has quit [Ping timeout: 248 seconds] 20130922 21:51:29< AI0867> Gambit: the problem with your two-party system is that it flattens everything to a linear scale 20130922 21:52:19-!- Octalot [~noct@host86-159-75-116.range86-159.btcentralplus.com] has joined #wesnoth-dev 20130922 21:52:19< AI0867> http://upload.wikimedia.org/wikipedia/commons/3/36/European-political-spectrum.png 20130922 21:52:34< AI0867> that's hardly all-encompassing, but it's closer to reality 20130922 21:53:04< AI0867> if you plot the dutch political parties on there, it becomes clear that left/right is a terrible simplification 20130922 21:53:56< AI0867> over here, the "conservatives" are mostly christian parties, with the big one being fairly centric regarding the left/right thing 20130922 21:55:25< AI0867> the liberals are right-wing as opposed to socialists 20130922 21:55:35< AI0867> US right-wing sounds more like socialism-for-corporations 20130922 21:55:45< AI0867> on the economic bits that is 20130922 21:56:07< Gambit> I thought the celsius and metric system joke would have made it clearer that I was kidding around. v_v 20130922 21:56:40< Gambit> I get all this AI0867, but thank you. 20130922 21:57:41-!- trewe [~trewe@87-196-53-100.net.novis.pt] has joined #wesnoth-dev 20130922 21:57:55< mordante> I'm off night 20130922 21:58:38-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20130922 21:59:34-!- trademark [~trademark@37.160.96.114] has quit [Ping timeout: 268 seconds] 20130922 22:04:54< AI0867> Gambit: =P 20130922 23:02:29-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 248 seconds] 20130922 23:06:58-!- gfgtdf [~chatzilla@f054152136.adsl.alicedsl.de] has quit [Read error: Connection reset by peer] 20130922 23:07:32-!- gfgtdf [~chatzilla@f054150024.adsl.alicedsl.de] has joined #wesnoth-dev 20130922 23:19:47-!- H-Hour [~H-Hour@cpc7-sgyl35-2-0-cust428.18-2.cable.virginmedia.com] has quit [Quit: Leaving] 20130922 23:23:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20130922 23:35:44< irker620> wesnoth: JaMiT wesnoth-old:master 50f97f053454 / src/ (gamestatus.cpp iterator.hpp): Fixing compilation issues. http://git.io/7i9Rug 20130922 23:40:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20130922 23:40:30-!- stikonas_ [~gentoo@cpc3-sgyl27-2-0-cust146.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20130922 23:40:30-!- stikonas_ [~gentoo@cpc3-sgyl27-2-0-cust146.sgyl.cable.virginmedia.com] has quit [Changing host] 20130922 23:40:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20130922 23:46:33-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20130922 23:47:33-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has joined #wesnoth-dev 20130922 23:47:33-!- skyfaller [~skyfaller@ool-2f11697b.dyn.optonline.net] has quit [Changing host] 20130922 23:47:33-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20130922 23:52:24-!- un214 [~un214@2602:304:37b8:c189:224:8cff:fed2:ef57] has joined #wesnoth-dev --- Log closed Mon Sep 23 00:00:08 2013