--- Log opened Sun Oct 06 00:00:38 2013
20131006 00:01:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131006 00:27:12-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: system reboot in progress]
20131006 00:29:01-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131006 00:29:41-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131006 00:32:10-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131006 00:34:09-!- shadowm_desktop is now known as Guest56417
20131006 00:34:09-!- Guest56417 [ignacio@wesnoth/developer/shadowmaster] has quit [Killed (leguin.freenode.net (Nickname regained by services))]
20131006 00:34:09-!- shadowm_desktop2 is now known as shadowm_desktop
20131006 00:44:51-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20131006 00:48:41-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has left #wesnoth-dev []
20131006 00:50:25-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 246 seconds]
20131006 00:54:51-!- love1cat [~Adium@c-76-119-168-240.hsd1.ma.comcast.net] has joined #wesnoth-dev
20131006 00:56:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20131006 00:58:07-!- trewe [~trewe@87-196-12-207.net.novis.pt] has quit [Ping timeout: 246 seconds]
20131006 01:03:55-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131006 01:24:14-!- gfgtdf [~chatzilla@f054133007.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 22.0/20130618035212]]
20131006 01:40:27-!- Crendgrim [~crend@77-23-29-102-dynip.superkabel.de] has quit [Quit: Konversation terminated!]
20131006 01:49:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 01:49:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 01:50:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 01:54:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 01:56:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 01:59:17-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 02:00:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 02:04:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 02:04:25-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 240 seconds]
20131006 02:05:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 02:08:28< irker523> wesnoth: mattsc wesnoth-old:master 771619939f34 / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: move Etheliel's profile to the right http://git.io/eFJ-9g
20131006 02:09:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 02:12:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 02:14:17-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 02:15:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 02:19:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 02:19:49< irker523> wesnoth: mattsc wesnoth-old:master 81277b89af8a / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: move Jetto's profile to the right http://git.io/lUvsBg
20131006 02:24:44< irker523> wesnoth: mattsc wesnoth-old:master 8944783b4a96 / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: objectives don't change mid scenario, don't redisplay http://git.io/98cfew
20131006 02:26:49< irker523> wesnoth: Alexander van Gessel wesnoth-old:master a922551302aa / data/tools/wesnoth/wescamp.py: Don't compare a boolean to None http://git.io/9ACHAg
20131006 02:26:51< irker523> wesnoth: Alexander van Gessel wesnoth-old:master e10ef1d98d14 / / (621 files in 78 dirs): Merge branch 'master' of github.com:wesnoth/wesnoth-old http://git.io/doykYw
20131006 02:40:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 02:40:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 02:41:08-!- justinzane [~justinzan@tiny.justinzane.com] has joined #wesnoth-dev
20131006 02:45:50< irker523> wesnoth: mattsc wesnoth-old:master 549b706801c8 / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: make allied orcs stay on castle, hills and villages http://git.io/VXgrRQ
20131006 03:40:38< irker523> wesnoth: mattsc wesnoth-old:master 23cd3f8ca7c0 / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: restrict range of allied AI even more http://git.io/B5-9jQ
20131006 03:40:40< irker523> wesnoth: mattsc wesnoth-old:master 37157ca98d26 / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: remove [leader_goal] for allied AI http://git.io/GCuJ1A
20131006 03:41:23< irker523> wesnoth: mattsc wesnoth-old:master 7eb825c1f7de / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: remove the AI controller http://git.io/hlSI3w
20131006 03:45:50< irker523> wesnoth: mattsc wesnoth-old:master da8478c6d3e2 / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: remove unused variable http://git.io/QUVT0A
20131006 03:49:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 03:49:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 03:50:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131006 03:50:03< irker523> wesnoth: mattsc wesnoth-old:master c4f48eae9bac / data/campaigns/Son_Of_The_Black_Eye/scenarios/04_The_Siege_of_Barag_Gor.cfg: SotBE S4: event filter should come before event actions http://git.io/FChEkw
20131006 03:50:50-!- Ardonik [~ardonik@adsl-75-28-98-15.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20131006 03:53:49< shadowm> zookeeper: Any particular reason this hasn't been committed? http://forums.wesnoth.org/viewtopic.php?p=556000#p556000
20131006 03:54:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131006 04:14:44-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20131006 04:18:28-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 264 seconds]
20131006 04:18:44-!- Ivanovic_ is now known as Ivanovic
20131006 04:19:41-!- Ard0nik [~ardonik@adsl-75-28-98-138.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20131006 04:21:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 245 seconds]
20131006 04:23:07-!- Ardonik [~ardonik@adsl-75-28-98-15.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 256 seconds]
20131006 04:25:30-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20131006 04:29:51-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Ping timeout: 248 seconds]
20131006 04:30:20-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20131006 04:30:34-!- Ard0nik is now known as Ardonik
20131006 04:41:01-!- wesbot changed the topic of #wesnoth-dev to: current repo: https://github.com/wesnoth/wesnoth-old (Please read the dev-ml for the latest status!) | 197 bugs, 339 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20131006 05:03:35-!- Ardonik [~ardonik@adsl-75-28-98-138.dsl.irvnca.sbcglobal.net] has quit [Read error: Connection reset by peer]
20131006 05:04:38-!- Ardonik [~ardonik@adsl-75-28-128-233.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20131006 06:04:43-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20131006 06:19:06-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has joined #wesnoth-dev
20131006 06:23:05-!- Ard0nik [~ardonik@adsl-75-28-104-189.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20131006 06:25:48-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Remote host closed the connection]
20131006 06:26:05-!- Ardonik [~ardonik@adsl-75-28-128-233.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 256 seconds]
20131006 06:26:07-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20131006 06:33:58-!- mattsc [~mattsc@154.20.32.246] has quit [Quit: Ciao]
20131006 06:34:49-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 246 seconds]
20131006 06:40:24-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20131006 06:46:35-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has joined #wesnoth-dev
20131006 06:59:03-!- Jetrel_new [~richard_k@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Quit: Jetrel_new]
20131006 07:02:20-!- Jetrel_new [~richard_k@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20131006 07:13:21-!- tomreyn_ [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20131006 07:17:21-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 252 seconds]
20131006 07:17:30-!- tomreyn_ is now known as tomreyn
20131006 07:42:46-!- Ardonik [~ardonik@adsl-75-28-100-222.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20131006 07:45:08-!- Ard0nik [~ardonik@adsl-75-28-104-189.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20131006 07:47:38-!- love1cat [~Adium@c-76-119-168-240.hsd1.ma.comcast.net] has quit [Quit: Leaving.]
20131006 08:03:25-!- ancestral [~ancestral@174-20-209-41.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20131006 08:12:54-!- noy [~Noy@154.20.62.142] has joined #wesnoth-dev
20131006 08:13:03-!- noy [~Noy@154.20.62.142] has quit [Changing host]
20131006 08:13:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131006 08:29:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131006 08:56:11-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131006 09:17:54-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131006 09:32:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131006 09:55:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20131006 10:00:47< zookeeper> shadowm. no particular reason
20131006 10:14:57-!- baldraslobby [~wesnoth@baldras.wesnoth.org] has joined #wesnoth-dev
20131006 10:16:14-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has joined #wesnoth-dev
20131006 10:19:38-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 10:24:04-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 246 seconds]
20131006 10:38:29-!- irker523 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20131006 10:43:15-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 10:45:46-!- mjs-de [~mjs-de@g224183145.adsl.alicedsl.de] has quit [Ping timeout: 246 seconds]
20131006 10:51:12-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131006 10:56:17-!- thunderstruck [~zaibotren@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has joined #wesnoth-dev
20131006 10:56:33-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131006 10:59:34-!- mjs-de [~mjs-de@d120131.adsl.hansenet.de] has joined #wesnoth-dev
20131006 11:00:18-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20131006 11:10:44-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Remote host closed the connection]
20131006 11:12:36-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Read error: Connection reset by peer]
20131006 11:13:14-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 11:19:46-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 245 seconds]
20131006 11:26:43-!- baldraslobby [~wesnoth@baldras.wesnoth.org] has quit [Quit: leaving]
20131006 11:48:56-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 245 seconds]
20131006 12:03:39-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 12:11:27-!- Crendgrim [~crend@77-23-29-102-dynip.superkabel.de] has joined #wesnoth-dev
20131006 12:43:07-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 260 seconds]
20131006 12:46:57-!- fabi__ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20131006 12:49:18-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20131006 12:50:01-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds]
20131006 13:04:55-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 13:12:33-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20131006 13:24:11-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20131006 13:30:08-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Read error: Operation timed out]
20131006 13:34:00-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20131006 13:42:02-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Read error: Connection reset by peer]
20131006 13:43:17-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 13:45:09< thunderstruck> trademark_: Hi. I was looking at your GSoC project page and I noticed that you didn't use a correct naming for your code samples.
20131006 13:45:21< thunderstruck> trademark_: I suggest that you follow this http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2013/codeguidelines
20131006 14:31:09-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 256 seconds]
20131006 14:42:54-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 14:49:29-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 240 seconds]
20131006 14:53:35-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20131006 14:54:29-!- Ivanovic [~ivanovic@x2f4d63a.dyn.telefonica.de] has joined #wesnoth-dev
20131006 14:54:44-!- Ivanovic [~ivanovic@x2f4d63a.dyn.telefonica.de] has quit [Changing host]
20131006 14:54:44-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20131006 15:03:09-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 15:05:31< trademark_> thunderstruck, ok, I modified it, thanks.
20131006 15:09:48-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 252 seconds]
20131006 15:12:36-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 15:16:48-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 240 seconds]
20131006 15:40:36-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 252 seconds]
20131006 15:49:39-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20131006 16:05:37< thunderstruck> trademark_: Ok. I just didn't want you to not get your t-shirt :)
20131006 16:08:55-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev
20131006 16:13:33-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Quit: Though to our health we drank a thousand times, it's time to ramble on.]
20131006 16:16:30-!- horon [~horon@nttkyo176024.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20131006 16:22:41-!- nurupo|away is now known as nurupo
20131006 16:30:32-!- Kostic [~marko@net152-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev
20131006 16:33:42-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20131006 16:33:42-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20131006 16:33:42-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20131006 16:33:58< mordante> servus
20131006 16:38:12< mordante> anonymissimus, gfgtdf, kind of forgot about that gzip patch, will try to dig it up again
20131006 16:44:36< mordante> loonycyborg, I haven't replied since I haven't found time to look at the email in detail yet
20131006 16:52:59-!- flix [~flix@37-5-10-145-dynip.superkabel.de] has joined #wesnoth-dev
20131006 17:02:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131006 17:09:12-!- gfgtdf [~chatzilla@f054128129.adsl.alicedsl.de] has joined #wesnoth-dev
20131006 17:10:22< gfgtdf> mordante: i have added a commit. i'd like to read it know weather it works for you, https://github.com/wesnoth/wesnoth-old/commit/b8dda3d520e953390b1a22e1634a957197d13f63
20131006 17:11:03< gfgtdf> since you are the one who worked on this.
20131006 17:14:50< mordante> gfgtdf, will dig my patch up and compare it with your patch
20131006 17:18:10< mordante> gfgtdf, regarding the #ifdef does the issue not occur with older versions of MSVC (also would be nice to write which MSVC version 1500 maps to)
20131006 17:21:03< gfgtdf> mordante: well i wanted to make the #if as ristricitve as possible becausei still dont know why this bug doesnt appears on other compilers. I f knwe this i'd problable not written an #if at all. is use VS2010 (1600) Anonymissimus use VS2008  thats 1500.
20131006 17:21:32< mordante> gfgtdf, this is my patch http://paste.debian.net/51820/
20131006 17:22:34< mordante> gfgtdf, if we're not sure which version of MSVC is affected, wouldn't it be better to use if for all versions of MSVC?
20131006 17:23:23< mordante> I'm not sure whether anonymissimus tested my patch
20131006 17:24:59< gfgtdf> mordante: ok seems like my throws an and gzip_error in case of failure and your path just returns. the reason i decided to thorw gzip error is that save_index_class::data  expects an gzip_error t be thown to determine westhat a file was aculay gzip_compressed, and the line "parser(cfg, filter,validator)(); " could also throw this error.
20131006 17:25:21< gfgtdf> s/westhat/weathr
20131006 17:26:42< gfgtdf> mordante: ye maybe.
20131006 17:27:08< gfgtdf> mordante: the best solution would be finding out wether it causes problem on other compiler cnd then remove the #if
20131006 17:28:39< mordante> gfgtdf, the problem doesn't happen on Linux
20131006 17:29:36< mordante> my patch was to act as-if the two byte .gz file is an empty file
20131006 17:30:07< mordante> (or was it entirely empty?)
20131006 17:30:22< gfgtdf> mordante: no 2 bytes size
20131006 17:31:09< gfgtdf> could you test what happens if you the save_index file is non compessed in gcc/clang ?
20131006 17:31:42< mordante> not at the moment, working on some patches, will take about 15 minutes
20131006 17:33:05< gfgtdf> mordante: my guess is, that the gcc version just return in case of currupt gip_files and therefore the catch for gzip_error in save_index_class::data is never reached.
20131006 17:33:44< gfgtdf> mordante: in that case  removing the #if would also fix that.
20131006 17:36:30< gfgtdf> mordante: and also fix the case that teh cahce files cuppupt but in the later part. but not in the header
20131006 17:36:43< gfgtdf> s/teh cahce/the cache
20131006 17:38:18-!- irker800 [~irker@ai0867.net] has joined #wesnoth-dev
20131006 17:38:18< irker800> wesnoth: Mark de Wever wesnoth-old:master 05ad49a955be / CMakeLists.txt changelog: Adds -Wno-deprecated-register compiler flag. http://git.io/kudz5Q
20131006 17:38:18< irker800> wesnoth: Mark de Wever wesnoth-old:master 6886871b8fc4 / src/tstring.cpp: Remove an unused const variable. http://git.io/mPN0hg
20131006 17:38:19< irker800> wesnoth: Mark de Wever wesnoth-old:master 9f79860a6933 / src/soundsource.cpp: Remove unused const variables. http://git.io/MAGWLw
20131006 17:38:20< irker800> wesnoth: Mark de Wever wesnoth-old:master c8407cf3565b / src/multiplayer_configure.cpp: Remove an unused const variable. http://git.io/dLbv4w
20131006 17:38:21< irker800> wesnoth: Mark de Wever wesnoth-old:master 12a7a5a1e0fe / src/lua/lapi.c: Remove unused const variables. http://git.io/3dnmgg
20131006 17:38:22< irker800> wesnoth: Mark de Wever wesnoth-old:master 962d9848011a / src/hotkeys.cpp: Remove an unused const variable. http://git.io/lxK0Vg
20131006 17:38:24< irker800> wesnoth: Mark de Wever wesnoth-old:master 2ce21395642e / src/help.cpp: Remove an unused const variable. http://git.io/zetpLA
20131006 17:38:26< irker800> wesnoth: Mark de Wever wesnoth-old:master 494787185957 / src/gui/widgets/window.cpp: Remove an unused const variable. http://git.io/jP3QSA
20131006 17:38:28< irker800> wesnoth: Mark de Wever wesnoth-old:master 9d07d1f6b85c / src/game_preferences.cpp: Remove an unused const variable. http://git.io/hZb36Q
20131006 17:38:30< irker800> wesnoth: Mark de Wever wesnoth-old:master 381ef1adbacb / src/game_events/action_wml.cpp: Remove unused const variables. http://git.io/sZzA8w
20131006 17:38:32< irker800> wesnoth: Mark de Wever wesnoth-old:master 15cc6a4fab84 / src/game_display.cpp: Remove an unused const variable. http://git.io/r3Lp8Q
20131006 17:38:34< irker800> wesnoth: Mark de Wever wesnoth-old:master bbe8bc862a62 / src/editor/palette/tristate_button.cpp: Remove unused const variables. http://git.io/xNM1Ow
20131006 17:38:37< irker800> wesnoth: Mark de Wever wesnoth-old:master 2303ae9911be / src/ai/default/contexts.cpp: Remove an unused const variable. http://git.io/cMustw
20131006 17:40:35< mordante> well gcc returns an EOF upon peeking
20131006 17:41:53< mordante> also note the initial remark in read_compressed
20131006 17:42:31< mordante> we had the issue before and added a specific test for it, and then we returned
20131006 17:42:55< mordante> so I bolted this extra test on it since a one character file is invalid
20131006 17:43:15< mordante> no idea where the '\0' in the stream is generated
20131006 17:45:26< gfgtdf> ok in that case i i'll make another pull request removing the #if and the "i dont knowhow other cmpilers hand it" comments
20131006 17:45:41< gfgtdf> in teh commenta of my commit somewhere said where there were created
20131006 17:45:52< gfgtdf> s/teh commenta/the comments
20131006 17:46:05< gfgtdf> there/they
20131006 17:46:06< mordante> is it a pull request or a commit?
20131006 17:46:26< gfgtdf> a pull request inside a commit 
20131006 17:46:31< gfgtdf> no the other way
20131006 17:46:47< gfgtdf> but the other commits in it dont have anything to do with that bug
20131006 17:46:52< mordante> that makes more sense ;-)
20131006 17:47:26< mordante> could you test whether my patch works, if so I prefer my patch since it mimics existing behaviour for empty files
20131006 17:47:33< gfgtdf> "// also note that this doesn't fix the source of the currupted gz files wich is, that filtering_stream cannot create empty compressend gz files properly, see https://svn.boost.org/trac/boost/ticket/5237"
20131006 17:47:50< mordante> (I still think there is a bug in boost io stuff)
20131006 17:48:29< gfgtdf> wel i prefer my patch because it also fixed the bahavior if teh files are curruped in anotehr way the 2-bytes ones
20131006 17:49:47< gfgtdf> also also because some functions like save_index_class::data() rely on gzip_error beeing thown
20131006 17:50:39< gfgtdf> but we could add a sprcialy case for theose 2-byte files
20131006 17:50:42< gfgtdf> special*
20131006 17:50:46< gfgtdf> those*
20131006 17:51:11< mordante> well I see my fix as a work-around for a boost bug
20131006 17:51:13< mordante> brb
20131006 17:56:46< gfgtdf> mordante: if you want a workaround for the boost bug i suggest just adding a newline to the compressed files to make sure they are not empty and the curroted files doesnt even occur for example in the destructor of the config_writer class (in serialization/binary_or_text.cpp)
20131006 17:57:05-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131006 17:58:01-!- Ardonik [~ardonik@adsl-75-28-100-222.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 246 seconds]
20131006 18:00:43< mordante> I think for this issue my patch is the best, if the gz stream is corrupt at other places an exception would be the better solution
20131006 18:01:15< mordante> this feels as work-around for a boost bug only on one platform
20131006 18:01:38< mordante> and I prefer Wesnoth to behave the same on empty files on Windows and Linux
20131006 18:03:30< gfgtdf> i said teh #if sould be removed
20131006 18:03:47< gfgtdf> and this isnt a work around for  a boost bug
20131006 18:04:10< gfgtdf> its for non-gz files in general
20131006 18:04:26< gfgtdf> like in save_index_class::data wich has nohing to do with teh boost bug
20131006 18:04:45< gfgtdf> if you want to fix teh boost bug its better to not even create cuppruped gz files
20131006 18:05:55< mordante> imo it is for a boost bug since we test for EOF on an empty file and it doesn't return EOF on Windows, it does on Linux
20131006 18:06:16-!- Kostic [~marko@net152-1-245-109.mbb.telenor.rs] has quit [Ping timeout: 245 seconds]
20131006 18:06:38< gfgtdf> no i said it  alredy trice fixing that wasnt teh only intention of thet patch
20131006 18:08:13< gfgtdf> save_index_class::data  uses read_gz to read a file and tries to read it as uncompressed if it found out thta this isnt a zip file with id determined by weather a gzip_error is thrown
20131006 18:08:31< gfgtdf> those methods RELY on gzip_error beeing thown
20131006 18:08:57< mordante> <mordante> I think for this issue my patch is the best, if the gz stream is corrupt at other places an exception would be the better solution
20131006 18:09:20< gfgtdf> the current gcc doenst do that and the current VS crashes
20131006 18:09:58< mordante> so for _this_ part of the issue, the boost bug is the best for the rest if the issue thus corrupted files your approach seems better
20131006 18:10:29< mordante> afk, getting something to eat
20131006 18:10:45-!- Ardonik [~ardonik@adsl-75-28-128-33.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20131006 18:11:25-!- Kostic [~marko@net152-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev
20131006 18:16:01< gfgtdf> well i still think for te boost issue it is the best to not create those corrupted files at all
20131006 18:30:05< irker800> wesnoth: flix wesnoth-old:master 961c97f62294 / / (4 files in 2 dirs): Add command line parameter "--repeat <arg>" http://git.io/79X2NQ
20131006 18:34:08< irker800> wesnoth: flix wesnoth-old:master 4c9372d76b85 / src/loadscreen.cpp: Avoid "logo is too big" error if --nogui is used. http://git.io/SZPQOA
20131006 18:42:18< flix> mordante: Hi! I added a new command-line option (--repeat, see ^). Do you know where I can update the manpage? And are there other things to update?
20131006 18:43:57< timotei_> flix: doc/man/wesnoth.6 would be one
20131006 18:44:31< timotei_> I once updated the wiki as well but that was Preprocessor-related stuff, so IDK for sure.
20131006 18:47:31< flix> timotei_: thanks
20131006 18:59:27-!- Kostic [~marko@net152-1-245-109.mbb.telenor.rs] has quit [Read error: Operation timed out]
20131006 19:05:34< gfgtdf> mordante: was the line "if(filter.peek() == EOF)" also just for that boost issue 
20131006 19:05:37< gfgtdf> ?
20131006 19:09:36-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Ping timeout: 252 seconds]
20131006 19:11:34-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20131006 19:12:17-!- thunderstruck [~zaibotren@cpc5-sgyl29-2-0-cust174.sgyl.cable.virginmedia.com] has quit [Quit: leaving]
20131006 19:13:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131006 19:17:36-!- Turuk [~Turuk@cpe-65-29-217-233.cinci.res.rr.com] has joined #wesnoth-dev
20131006 19:24:48< Soliton> flix: repeat sounds awfully generic. maybe you can come up with a slightly more specific parameter name?
20131006 19:27:31< flix> Soliton: suggestions? Maybe "--multiplayer-repeat"?
20131006 19:30:23< Soliton> since it seems to only work with --multiplayer that sounds good.
20131006 19:35:11-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131006 19:42:57-!- love1cat [~Adium@c-76-119-168-240.hsd1.ma.comcast.net] has joined #wesnoth-dev
20131006 20:02:10< flix> Soliton: okay, I'll change it
20131006 20:20:33-!- Kostic [~marko@net152-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev
20131006 20:34:17-!- Kostic [~marko@net152-1-245-109.mbb.telenor.rs] has quit [Quit: Kostic]
20131006 21:03:53< gfgtdf> i want to add a newline at the end of compressed config files to prevent a boost bug happens on empty comressed gzip files, does anyone think thats a bad idea ? 
20131006 21:06:01< irker800> wesnoth: Turuk wesnoth-old:master 4531783ec005 / data/campaigns/Son_Of_The_Black_Eye/scenarios/01_End_of_Peace.cfg: SotBE S1: wmlindent ran to properly format http://git.io/OIdIUA
20131006 21:11:12< lipkab> gfgtdf: "lipkab: are you still using windows  and try "familiarizing with Microsoft software" ?" <- More or less, yeah.
20131006 21:11:27< lipkab> I'm dual-booting Linux and Windows.
20131006 21:12:09-!- Turuk [~Turuk@cpe-65-29-217-233.cinci.res.rr.com] has quit [Quit: Turuk]
20131006 21:14:30< gfgtdf> lipkab: ah ye i was lookng for someone who uses windows to talk about my msvc patch then. But i think i already know what i wanted to know.
20131006 21:14:51< lipkab> Okay.
20131006 21:42:33-!- trewe [~trewe@87-196-42-216.net.novis.pt] has joined #wesnoth-dev
20131006 22:09:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131006 22:19:54< mordante> gfgtdf, yes that also confused MSVC and that worked until with a newer version of boost the issue returned
20131006 22:20:47-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Remote host closed the connection]
20131006 22:20:52< gfgtdf> mordante: what do you think about preventing the boost issue by adding a newline character to the end of all gz compressed files?
20131006 22:21:54< mordante> gfgtdf, do you know how the 0 byte files are created?
20131006 22:22:24< gfgtdf> yes form calling config_cache with empy cfg objects
20131006 22:22:31< AI0867> technically, this machine dual-boots debian and windows 7
20131006 22:22:32< gfgtdf> s(calling/using
20131006 22:22:39< AI0867> in practice, my uptime is 124 days
20131006 22:22:48< gfgtdf> AI0867: ?
20131006 22:22:59< mordante> gfgtdf, maybe the code should check for an emtpy config and not create a file
20131006 22:23:17< AI0867> (I now see that what I am replying to happened an hour ago)
20131006 22:24:55< mordante> adding a newline could be done, but it feels like a hack papering over a bug in boost, my fix is also papering over the bug, but at least shows where the problem is
20131006 22:25:52< gfgtdf> i tihnk the bug is that those files are created
20131006 22:26:27< gfgtdf> not creating a fild could be more cimplicarted but maybe its possible
20131006 22:26:28-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 246 seconds]
20131006 22:26:30< gfgtdf> file*
20131006 22:27:44< mordante> where is the call for creating the file made and can't it just instead of calling the function first test whether the config object is empty?
20131006 22:27:52< gfgtdf> sorry i meant config_writer not config_cache 
20131006 22:28:27< gfgtdf> in serialiation/binary_or_text.cpp
20131006 22:29:32< gfgtdf> checking weather a config is empty would be up to the functions the use config_writer, it would be better if we could do it at teh central place where they are written
20131006 22:30:03< mordante> I disagree the writer shouldn't decide that policy, if you want to write an empty file it should be possible
20131006 22:30:12< mordante> the caller should make sure it makes sense to write the file
20131006 22:30:28< gfgtdf> but boost gz cannot write empty files
20131006 22:30:54< gfgtdf> so letting someone decide weather to do that doesnt make sense
20131006 22:31:07< mordante> it could in the past and it can write empty bz files
20131006 22:31:31< mordante> so I still consider it a bug in boost (and it seems Linux is not affected)
20131006 22:31:43< mordante> but alas it seems boost iostream is somewhat unmaintained
20131006 22:31:46< gfgtdf> linux is affecs as well as windows
20131006 22:32:09< mordante> I couldn't reproduce the problem on Linux
20131006 22:32:14< gfgtdf> the corruot files are also created on my downloaded veersion of wesnoth 
20131006 22:32:33< gfgtdf> did you check you chache filder in te file explorer ?
20131006 22:32:36< gfgtdf> folder*
20131006 22:32:39< gfgtdf> the*
20131006 22:33:32< mordante> I don't have a file explorer ;-)
20131006 22:33:57< gfgtdf> then in a shell, 
20131006 22:34:09< mordante> no empty file there
20131006 22:34:29< gfgtdf> no gz files with size < 10 bytes ?
20131006 22:34:52< mordante> na and gzip is happy with all files
20131006 22:34:56< mordante> no*
20131006 22:36:22< gfgtdf> hm do you ghave addons installed ?
20131006 22:36:25< gfgtdf> have*
20131006 22:36:29< gfgtdf> wesnoth addons
20131006 22:36:33< mordante> yes
20131006 22:40:18< gfgtdf> in the sources in teh internet there is nothing that made me think that this is a windows specific problem, plus is also happens with teh version that i downloadded from teh wenoth side wich isnt compiled with visual studio i think
20131006 22:41:59< mordante> no but it is still a Windows program
20131006 22:42:20< mordante> I needed anonymissimus to reproduce the problem
20131006 22:43:19< mordante> I'm off night
20131006 22:44:03< gfgtdf> ok
20131006 22:44:07-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20131006 22:46:48-!- Ard0nik [~ardonik@adsl-75-28-105-125.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20131006 22:50:30-!- Ardonik [~ardonik@adsl-75-28-128-33.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 264 seconds]
20131006 22:55:43-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131006 23:22:44-!- gfgtdf_ [~chatzilla@f054136031.adsl.alicedsl.de] has joined #wesnoth-dev
20131006 23:24:28-!- gfgtdf [~chatzilla@f054128129.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20131006 23:24:40-!- gfgtdf_ is now known as gfgtdf
20131006 23:29:44-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131006 23:35:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20131006 23:38:28-!- trewe [~trewe@87-196-42-216.net.novis.pt] has quit [Quit: Verlassend]
20131006 23:50:46< irker800> wesnoth: mattsc wesnoth-old:master 45d76a325b03 / data/campaigns/Son_Of_The_Black_Eye/scenarios/06_Black_Flag.cfg: SotBE S6: remove GRUNT_DEFENDER, ARCHER_DEFENDER macros http://git.io/ZLhSmA
20131006 23:59:21< irker800> wesnoth: mattsc wesnoth-old:master bb3709ffbeb3 / data/campaigns/Son_Of_The_Black_Eye/scenarios/06_Black_Flag.cfg: SotBE S6: remove HUMAN_PILLAGER macro http://git.io/YCI1fg
--- Log closed Mon Oct 07 00:00:42 2013