--- Log opened Mon Nov 18 00:00:05 2013
20131118 00:01:31-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 272 seconds]
20131118 00:03:55-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds]
20131118 00:05:26-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 00:08:59< irker189> wesnoth: Bär Halberkamp wesnoth-old:master 8e46916d7a51 / data/core/ (12 files in 2 dirs): Added some animations for the Horseman and updated animationwml http://git.io/82m1Pg
20131118 00:09:02< irker189> wesnoth: Bär Halberkamp wesnoth-old:master b7d3ae107836 / changelog players_changelog: Updated changelog and players_changelog http://git.io/xV5rtg
20131118 00:09:05< irker189> wesnoth: Bär Halberkamp wesnoth-old:master 4ab33959c130 / data/core/images/units/human-loyalists/horseman/ (86 files): Ran wesnoth-optipng http://git.io/SJCxLA
20131118 00:10:06-!- flix [~flix@37-5-10-145-dynip.superkabel.de] has left #wesnoth-dev []
20131118 00:18:13-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg]
20131118 00:49:06< irker189> wesnoth: JaMiT wesnoth-old:master c101fb721b44 / src/ (config.cpp config.hpp): Adapt config::child_or_empty to return a reference instead of a copy. http://git.io/cd3UMA
20131118 00:57:24-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has quit [Quit: Konversation terminated!]
20131118 01:13:40-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 264 seconds]
20131118 01:33:31< mattsc> Hi fabi 
20131118 01:33:59< mattsc> fabi: this commit by you: https://github.com/wesnoth/wesnoth-old/commit/28029ae78c12ac4ac13f4c22ccb892d25bd43dee#diff-54411f8c204f7ceac25ecc0882ee5623L476
20131118 01:34:21< mattsc> appears to be causing this bug: https://gna.org/bugs/?21277
20131118 01:36:00< mattsc> What is happening is that in l.480 you set attacker_stats_ .  When the program then gets to l.336: https://github.com/wesnoth/wesnoth-old/blob/master/src/actions/attack.cpp#L336
20131118 01:36:49< mattsc> attacker_stats_ is set, but defender_stats_ is not, which subsequently crashes Wesnoth here: https://github.com/wesnoth/wesnoth-old/blob/master/src/actions/attack.cpp#L404
20131118 01:37:23< mattsc> (credit to finding most of this goes to flix, btw, I just did some follow-up work.
20131118 01:37:37< mattsc> *credit for
20131118 01:38:58< mattsc> fabi: I can see a couple different ways of fixing this, but am not sure which one's best, so I'll leave that to you if you don't mind.  Also, I assume there's no WML work-around for this happening for doofus to put into his campaign, so that it can work with 1.11.7?
20131118 01:52:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20131118 01:59:11< fabi> mi mattsc
20131118 02:02:41< mattsc> fabi:  hi.  Just letting you know what I think I found.  If that's not the reason, just tell me to go away.  :)
20131118 02:03:30< fabi> mattsc: No problem. Matt, do you about the circumstances? What is special with the "Ares" character?
20131118 02:03:37< mattsc> However, when I reverted the change to lines 480-482 (just those lines, not the entire commit), the crash dudn't happen.
20131118 02:04:16< mattsc> No, I have not been able to find out about that yet.  Ares is the God of War (thus, the name), who has >800 HP.
20131118 02:04:19-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds]
20131118 02:04:48< mattsc> If I replace him by a weaker unit, the crash does not happen.  If I replace him by other gods (very strong units), it sometimes happens and sometimes not.  So no, I don't know.
20131118 02:05:17-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 02:05:43< fabi> mattsc: Well, I tested the stuff with the CombatShore units. Most tanks have around 500-900 HP there. The Headquarter is even more heavy with 12000 hitpoints.
20131118 02:06:18< mattsc> fabi: yeah, I don't think that HP alone explain it.
20131118 02:10:19-!- exciton_ [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 02:10:23-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds]
20131118 02:12:27< fabi> mattsc: Did the Author of the Addon use the "disable" weapon special?
20131118 02:14:43-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 245 seconds]
20131118 02:17:58< mattsc> fabi: I have no idea.  (just one added piece of information though, that save crashes in 1.11.7, but not in 1.11.6 or 1.11.5, so it is caused by a recent commit)
20131118 02:18:17< mattsc> ... although the root cause might be something else, of course.
20131118 02:43:31-!- kex [~kex@78.157.10.254] has quit []
20131118 02:44:02-!- wesbot changed the topic of #wesnoth-dev to: 196 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20131118 03:07:10-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20131118 03:19:38-!- Alarantalara [~Adium@192.0.128.11] has joined #wesnoth-dev
20131118 03:25:42-!- Ivanovic_ [~ivanovic@x2f516ae.dyn.telefonica.de] has joined #wesnoth-dev
20131118 03:28:43-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 260 seconds]
20131118 03:29:35-!- Ivanovic_ is now known as Ivanovic
20131118 03:55:00-!- exciton_ [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131118 03:55:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 04:00:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131118 04:06:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 04:14:51-!- Chusslove [~Chusslove@unaffiliated/chusslove] has quit [Ping timeout: 272 seconds]
20131118 04:17:14-!- Octalot [~noct@host86-128-228-133.range86-128.btcentralplus.com] has quit [Read error: Connection reset by peer]
20131118 04:18:00-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131118 04:18:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 04:21:55-!- jamit [~jamit@wesnoth/developer/jamit] has quit [Quit: Leaving.]
20131118 04:24:11< mattsc> Hey _8680_: do you know if there's a Lua command that translates something like 'side=2-4,7' into a list of sides (or side numbers) ?
20131118 04:25:57< mattsc> As background, I want to change the [micro_ai] tag so that it can take a list of sides for the side= key, and I am wondering whether I need to create the a table with the side numbers myself, or whether there's a more lazy method.
20131118 04:37:05-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has joined #wesnoth-dev
20131118 04:40:45-!- Chusslove [~Chusslove@unaffiliated/chusslove] has joined #wesnoth-dev
20131118 04:58:10< _8680_> mattsc: As far as I know, Wesnoth does not provide a Lua function to do that specifically. You could however use a StandardSideFilter (with helper.get_sides), which would understand `side=2-4,7` (and more).
20131118 05:03:59-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds]
20131118 05:05:28-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 05:16:54-!- Gallaecio [~quassel@84.120.112.245.dyn.user.ono.com] has joined #wesnoth-dev
20131118 05:37:47< mattsc> _8680_: thanks, that matches my understanding of things.
20131118 05:37:48-!- Alarantalara [~Adium@192.0.128.11] has quit [Quit: Leaving.]
20131118 05:47:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20131118 05:59:55-!- mattsc [~mattsc@154.20.32.246] has quit [Quit: Computer's napping]
20131118 06:13:13-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20131118 06:37:25-!- tomreyn_ [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20131118 06:41:12-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 246 seconds]
20131118 06:41:17-!- tomreyn_ is now known as tomreyn
20131118 06:42:28-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20131118 06:47:22-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20131118 06:55:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20131118 07:45:38-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131118 07:50:09-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131118 07:56:42-!- Gallaecio [~quassel@84.120.112.245.dyn.user.ono.com] has quit [Remote host closed the connection]
20131118 08:18:08-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has joined #wesnoth-dev
20131118 08:21:35-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20131118 08:44:02-!- wesbot changed the topic of #wesnoth-dev to: 197 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20131118 09:00:13-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131118 09:05:27-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 09:09:28-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20131118 09:23:25-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20131118 09:30:57< Rhonda> Ivanovic: handle it in what way?
20131118 09:34:07-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20131118 09:45:24-!- mjs-de [~mjs-de@g228228213.adsl.alicedsl.de] has joined #wesnoth-dev
20131118 09:49:53-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 272 seconds]
20131118 10:13:22-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20131118 10:13:22-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host]
20131118 10:13:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 10:58:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20131118 11:06:02-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has joined #wesnoth-dev
20131118 11:39:20-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has quit [Ping timeout: 265 seconds]
20131118 11:41:40-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20131118 11:48:48-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has joined #wesnoth-dev
20131118 11:51:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 11:59:05-!- stikonas_ [~gentoo@maths-pgs-002.maths.ed.ac.uk] has joined #wesnoth-dev
20131118 11:59:05-!- stikonas_ [~gentoo@maths-pgs-002.maths.ed.ac.uk] has quit [Changing host]
20131118 11:59:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 11:59:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20131118 12:08:20-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 245 seconds]
20131118 12:24:17< AI0867> 05:24 < mattsc> Hey _8680_: do you know if there's a Lua command that translates something like 'side=2-4,7' into a list of sides (or side numbers) ? <-- wesnoth.get_sides takes a side filter and returns a list of sides
20131118 12:25:45< AI0867> but it looks like you already got an answer
20131118 12:26:14-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20131118 12:30:30-!- irker189 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20131118 13:02:51-!- Elvish_Hunter [6d347d96@gateway/web/freenode/ip.109.52.125.150] has joined #wesnoth-dev
20131118 13:03:27< Elvish_Hunter> Hi all
20131118 13:07:34< vultraz> hello
20131118 13:13:33-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20131118 13:14:09-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131118 13:18:53-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 272 seconds]
20131118 13:40:20-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has joined #wesnoth-dev
20131118 14:05:16-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20131118 14:09:26-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20131118 14:11:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20131118 14:14:07< Elvish_Hunter> For anyone that's interested: [elseif] support in WML: http://forums.wesnoth.org/viewtopic.php?f=58&t=32237&p=562784#p562784
20131118 14:16:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20131118 14:20:39-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20131118 14:20:58-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20131118 14:25:27-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has quit [Quit: Konversation terminated!]
20131118 14:33:28-!- Elvish_Hunter [6d347d96@gateway/web/freenode/ip.109.52.125.150] has quit [Quit: Ciao!]
20131118 14:36:36-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131118 14:41:35-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 272 seconds]
20131118 14:44:31-!- Kostic [~marko@85.202.113.171] has joined #wesnoth-dev
20131118 15:05:32-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131118 15:09:28-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20131118 15:14:59-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20131118 15:16:27-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131118 15:37:35-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev
20131118 15:51:03-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Quit: Nettalk6 - www.ntalk.de]
20131118 15:53:47-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131118 15:57:26< mattsc> AI0867: thanks
20131118 15:59:32< fabi> mattsc: I have thought about the bug you mentioned yesterday.
20131118 16:00:50< fabi> I wonder if it can be fixed by not assigning the object to the member variable but just using a local one.
20131118 16:03:47< mattsc> fabi: hi.  I really don't know how all this works very well, I just poked around a little to see what recent change (seems to have) caused the crash.  That's when I pinged you, since you know what's going on much better than I.  :)
20131118 16:04:22< mattsc> So I guess I won't be very helpful with discussing possible fixes, unfortunately...
20131118 16:04:49< fabi> Well, the whole attacker/defender/combatant code isn't that light weight. I would lie if I claimed to have understand it properly in every detail.
20131118 16:06:34< mattsc> fabi: btw, the member variable you're talking about is attacker_stats_ ?
20131118 16:06:41< fabi> yes
20131118 16:07:48< mattsc> I do think that only using that locally at that part of the code would likely avoid the crash, yes.  I have no idea if that fixes the root problem or whether it has other side effects.
20131118 16:08:40< mattsc> Another option would be to put an if statement in the other part of the code that checks for both attacker and defender stats.  But again, that could have some side effects that we (flix and I) are not aware of.
20131118 16:10:08< mattsc> And in any case, I have no idea why this crash only happens for Ares and not other units.  How do you use the disable weapon special in WML?  (haven't really been following this)
20131118 16:10:43< mattsc> Well, it happens for Ares and *some* other units, but not most of them.
20131118 16:12:39< mattsc> fabi: ah, found it (where [disable] is explained).  I did a grep through that campaign's code and the [disable] tag does not appear in it.
20131118 16:16:33< fabi> mattsc: Yeah, [disable] is just another new weapon special.
20131118 16:17:36-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar]
20131118 16:17:44-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Remote host closed the connection]
20131118 16:17:59< fabi> mattsc: The feature itself is new but the use-case is old. UMC coders used other weapon specials to reduce the damage or the number of strikes a weapon does to zero instead.
20131118 16:18:12-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131118 16:19:33< mattsc> fabi: yes, I don't think that the disable special itself causes this.  It's just a side effect of that bit of code you put in and I am pretty sure that that variable should be local.
20131118 16:20:21< mattsc> what I don't understand at the moment is why this does not cause crashes much more frequently (and what UMC authors can do for the time being to work around it)
20131118 16:21:53< fabi> I guess UMC authors will sadly have to live with the bug for the time of 1.11.7. Maybe a slightly reduced Ares with a normal amount of hitpoints can be used to test if the bug is really large hitpoints depended.
20131118 16:22:22< mattsc> fabi: actually, one thing I just noticed is that it is probably not caused by Ares.
20131118 16:22:51< mattsc> That code block is only entered when the unit has only one weapon, while Ares has 2.
20131118 16:23:08< fabi> What I don't know is how to proceed. I can change the code to use a local variable but what you wrote makes a lot of sense: The change might have revealed another bug that deserves to be fixed but might live on for longer if I just fix the [disable] coding.
20131118 16:23:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20131118 16:24:02< mattsc> fabi: let me poke around a little more, I want to figure out what is actually going on.
20131118 16:24:31-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev
20131118 16:24:33< fabi> Sure, just call me if you need some help.
20131118 16:24:42< mattsc> Will do.
20131118 16:24:49-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131118 16:29:08-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20131118 16:39:21< mattsc> fabi: one step farther, the reason why it happens for Ares is that attack_weight is set to 0 for the second attack.  So there's a way around it for that unit at least.  I still don't understand why it does not always happen for units with only one attack in the first place then.
20131118 16:41:13-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131118 16:42:31< mattsc> So, yes, if I use debug mode to replace that Ares by one that does not have the attack_weight s
20131118 16:42:40< mattsc> Oh, I do know, I think.  Cool ...
20131118 16:43:58< mattsc> ... or not ...
20131118 16:47:43< mattsc> Ah, yes, I do.  :P
20131118 16:49:43< mattsc> fabi: okay, problem solved.  I know both how to fix the code and how to set up a work-around for doofus.
20131118 16:49:52< fabi> Cool
20131118 16:50:02< fabi> Please tell me about the problem.
20131118 16:50:17< mattsc> check out this: https://github.com/wesnoth/wesnoth-old/blob/master/src/actions/attack.cpp#L323
20131118 16:50:34-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar]
20131118 16:50:45< mattsc> choose_attacker_weapon() is not called if the unit only has one weapon in the first place
20131118 16:51:26-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev
20131118 16:51:29< mattsc> That means that the condition at l.480 is only true for units that have more than one weapon, but with all but one "disabled" (attack_weight=0)
20131118 16:51:49< mattsc> That just isn't the case very often, since attack_weight is not used a lot
20131118 16:52:25< mattsc> So, the work-around for doofus is to set attack_weight=0.00001 or something (I'll reply to the forum thread and tell him)
20131118 16:52:33-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Client Quit]
20131118 16:52:38< fabi> Indeed, I have not a single test case used with attack weight set to zero.
20131118 16:52:58< mattsc> The fix for the C++ code then is what you suggested, use a local variable in your code.
20131118 16:53:17-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev
20131118 16:53:37< fabi> Are you sure attack_weight=0.00001 is doing well as a work around?
20131118 16:53:41< mattsc> Or, alternatively, calculate both attacker_stats_ and defender_stats_
20131118 16:53:50< mattsc> Yes, I tried it.
20131118 16:54:07< fabi> Well, maybe it preserves the game from crashing.
20131118 16:54:27< fabi> Still the weight=0 has a special semantic meaning which is quite different from every other value. 
20131118 16:55:14< fabi> Weight=0 means the ai shall not use the weapon at all. Any other value is going into a comparison and might lead to the usage of the weapon by the ai.
20131118 16:55:30< fabi> Or did I understand it wrongly?
20131118 16:55:32< mattsc> fabi: well, yes, that's true.  I guess the other option for him would be to remove that attack from the unit in the first place.
20131118 16:56:05-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds]
20131118 16:56:11< mattsc> No, that's not the same either ...
20131118 16:56:50< mattsc> Because then the unit also won't defend itself with that weapon - but there's a work-around for that also, although it gets pretty messy at that time ...
20131118 16:57:28< mattsc> Well, I'll tell him, and he can see whether it is important that it is exactly 0, and then choose whatever complexity of a work-around he wants.
20131118 16:58:30< mattsc> The most complex version would be to remove the attack at the beginning of the AI turn, and re-instate it at the end of it.  That way, the unit would never attack with that weapon, but would defend itself with it.
20131118 16:59:18< mattsc> fabi: so will you fix the C++ code (and mark the bug as fixed), and I will reply to the forum thread?
20131118 16:59:34< mattsc> You can also do it all, I wouldn't complain.  ;)
20131118 17:02:10< fabi> Yes. Let me see if I can setup a proper test case for the bug. Just fixing it without any testing afterwards seems quite unprofessional.
20131118 17:02:40< fabi> I guess that I have learned enough about the issue to also answer the forum thread properly then.
20131118 17:03:01< mattsc> fabi: if you fix it, I can test it (or you can do it yourself with the save from the bug report)
20131118 17:03:04< fabi> But I can't promise to do so soon.
20131118 17:03:34< mattsc> fabi: well, let me reply to the forum thread then, since I have tested the work-around already.
20131118 17:04:23< fabi> My current work is dedicated to a new UI for the game that is more in the style of the editor. I do not want to get distracted from that, I want to make sure that the thing enters Wesnoth before the feature freeze.
20131118 17:04:53< mattsc> fabi: sure, no problem.  Since there is an easy work-around, it's not urgent.
20131118 17:05:25< fabi> Yeah, fine. Most likely when exactly the c++ issue is solved will make much difference to the UMC author as long as it gets into the next dev release.
20131118 17:05:42< mattsc> agreed
20131118 17:05:45< fabi> s/will make/won't make
20131118 17:06:20< fabi> mattsc: Please assign the bug report to me, I might forget about it otherwise.
20131118 17:07:57< mattsc> fabi: done.  I also increased its severity to important.
20131118 17:08:17< fabi> Thank you very much :-)
20131118 17:08:43-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Read error: Connection reset by peer]
20131118 17:09:17-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20131118 17:09:54-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev
20131118 17:10:03< mattsc> No worries.  For some reason I actually think these kinds of things are fun.  :)
20131118 17:10:49< fabi> The appearance of interesting bugs is fun?
20131118 17:11:30< mattsc> Ha!  No, the "detective work" involved in trying to solve them.
20131118 17:12:05< fabi> Well, I have 2 bugs on my list which drive me mad, maybe you want to have a quick glance?
20131118 17:16:00-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20131118 17:17:13< mattsc> fabi: depends what area of Wesnoth they are about (there are some things I just don't know anything at all about).  But you can always tell me.
20131118 17:22:38< fabi> mattsc: Hmmm, I thought that there is a bug report already assigned to me but I can't find it. The problem is with the tooltips of the terrain palette in the editor. They include pango markup for making the warning about non core terrains red. But this only works occasionally. A "Heisenbug".
20131118 17:23:35< fabi> Half of the time you see the red warning, half of the time you see the pango markup in the tooltip.
20131118 17:23:49-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 240 seconds]
20131118 17:25:14-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has joined #wesnoth-dev
20131118 17:31:18-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev
20131118 17:32:04< mattsc> fabi: okay, I'll have a look sometime, to see whether I can even get started on it.  No promises that it will be soon though.
20131118 17:32:59< fabi> :-)
20131118 17:36:07< bumbadadabum> mattsc: Oh damn that crashes my era as well
20131118 17:36:13< bumbadadabum> the attack_weight thing
20131118 17:37:35< mattsc> bumbadadabum: :(  At least you have a work-around for it now.
20131118 17:37:42< bumbadadabum> yeah
20131118 17:37:50< bumbadadabum> But I'll need to upload a fix
20131118 17:38:38< fabi> bumbadadabum: Sorry I missed testing with the weight=0 option. But it is incredibly hard to cover all the test space when WML is involved. 
20131118 17:38:55< bumbadadabum> It's good you found it, though
20131118 17:39:17< fabi> Well, all credit goes to mattsc. I only caused the bug :-)
20131118 17:39:49< mattsc> Well, actually flix found where the crash is caused, I just figured out why.  :)
20131118 17:43:44-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131118 17:45:26< fabi> Espreon: Hello, I guess you are the only one currently left who is interested in Wesnoth's prose. The auto-generated terrain descriptions need some change to the current prose and maybe there are good reasons to write more descriptions for some or all of our terrains.  
20131118 17:46:27< lipkab> Prose? Nah. Only the spelling, I fear.
20131118 17:46:43< fabi> lipkab: Who can I ask for help with prose?
20131118 17:47:17< fabi> esr: Do you want to help me with some prose again?
20131118 17:48:05< lipkab> I think the best prose comes from Writer's Forums nowadays.
20131118 17:48:48-!- kex [~kex@89.205.75.19] has quit []
20131118 17:53:09-!- Chusslove [~Chusslove@unaffiliated/chusslove] has quit []
20131118 17:53:36< fabi> lipkab: Yeah, I had no luck with my latest attempt to get help with the map editor's help section.
20131118 17:59:10< lipkab> fabi: Me neither with era descriptions :D Still, I don't recall any prose changes in the past ~2 years that didn't come from there.
20131118 18:00:11< fabi> Maybe calling for editor help sections is more successful when the editor is part of a stable release.
20131118 18:00:40< fabi> The terrain sections are causing me more worries.
20131118 18:04:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 18:06:10-!- mjs-de [~mjs-de@g228228213.adsl.alicedsl.de] has quit [Remote host closed the connection]
20131118 18:15:11-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has joined #wesnoth-dev
20131118 18:16:21-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131118 18:32:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131118 18:32:29-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131118 18:44:47-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has quit [Ping timeout: 272 seconds]
20131118 18:46:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20131118 18:47:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 18:47:39-!- DCW1 [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has joined #wesnoth-dev
20131118 18:48:17-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Quit: Távozom]
20131118 18:52:25-!- DCW1 [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20131118 18:58:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20131118 18:58:46-!- stikonas_ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20131118 18:58:46-!- stikonas_ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host]
20131118 18:58:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 19:03:38-!- knotwork [~markm@142.68.143.36] has joined #wesnoth-dev
20131118 19:03:38-!- knotwork [~markm@142.68.143.36] has quit [Changing host]
20131118 19:03:38-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20131118 19:05:30-!- mjs-de [~mjs-de@wh.uni-dortmund.de] has joined #wesnoth-dev
20131118 19:10:53-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has quit [Quit: No Ping reply in 180 seconds.]
20131118 19:15:33-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev
20131118 19:16:35-!- Chusslove [~Chusslove@unaffiliated/chusslove] has joined #wesnoth-dev
20131118 19:23:02-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20131118 19:23:50-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has quit [Read error: Operation timed out]
20131118 19:25:24-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev
20131118 19:31:55-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20131118 19:32:58-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has quit [Quit: No Ping reply in 180 seconds.]
20131118 19:36:47-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has left #wesnoth-dev ["Konversation terminated!"]
20131118 19:39:14-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev
20131118 19:40:27-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20131118 19:45:48-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has quit [Quit: No Ping reply in 180 seconds.]
20131118 19:47:05-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev
20131118 19:51:10-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has quit [Client Quit]
20131118 19:51:51-!- Kostic [~marko@85.202.113.171] has quit [Quit: Kostic]
20131118 19:52:26-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev
20131118 19:54:41-!- stikonas__ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20131118 19:54:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20131118 19:56:30-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has quit [Client Quit]
20131118 19:57:42-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev
20131118 19:59:12< mattsc> fabi: concerning your Heisenbug, it's actually an inverse Heisenbug, and a 2nd order one at that.  :P
20131118 19:59:27< fabi> mattsc: huh?
20131118 19:59:44< mattsc> It doesn't go away when you observe the system, but only appears in that case, and only on the second observation.  :D
20131118 20:00:49< mattsc> When you move the mouse over a terrain for the first time (from outside the terrain icon panel) it works, then when you move the cursor over it the second time (without leaving the panel), it does not.
20131118 20:01:27< mattsc> I have no idea if that helps you track down the problem, but that's how you can reproduce the problem.
20131118 20:01:53-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has quit [Read error: Operation timed out]
20131118 20:03:00< fabi> mattsc: Yeah, reproduction has never been a problem. :-)
20131118 20:04:09< mattsc> fabi: okay - is there anything that is different in the gui between hovering over a terrain for the first and second time?
20131118 20:05:32< fabi> No, not that I am aware off. All the buttons and their tooltips are created whenever you change the terrain group. 
20131118 20:06:44< mattsc> fabi: okay.  I'll probably look into it some more later this week.  I don't have time right now, I just wanted to make sure that I understand what you are talking about.
20131118 20:07:02< fabi> mattsc: Cool, thank you :-)
20131118 20:07:07-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev
20131118 20:08:05-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20131118 20:08:36< mattsc> fabi: and you were right, there is a bug about it assigned to you:  https://gna.org/bugs/?21281
20131118 20:09:09< mattsc> fabi: also, I assume you are aware of this one, even though it is not assigned to you: https://gna.org/bugs/?21282
20131118 20:12:44-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Read error: Connection reset by peer]
20131118 20:22:34< fabi> mattsc: Sadly the 21281 is another one. The report is about the game while the other one is an editor one.
20131118 20:23:03< mattsc> fabi: ah, okay
20131118 20:25:32-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar]
20131118 20:25:53-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev
20131118 20:26:54-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Client Quit]
20131118 20:30:50-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev
20131118 20:37:46-!- mjs-de [~mjs-de@wh.uni-dortmund.de] has quit [Read error: Operation timed out]
20131118 20:40:24-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20131118 20:44:02-!- wesbot changed the topic of #wesnoth-dev to: 196 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20131118 20:52:08-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20131118 21:06:17< fabi> Ivanovic: I want to talk with you about the 800x480 resolution since you are the only user among the developers who plays at this mode.
20131118 21:15:17< AI0867> fabi: I do too, windowed
20131118 21:15:34< fabi> AI0867: Really? Why?
20131118 21:15:46< AI0867> to test it =P
20131118 21:15:53< fabi> Okay :-)
20131118 21:16:00< fabi> Then I do it as well :-)
20131118 21:16:05< AI0867> also, it's less than a quarter of the screen, so I can do other stuff at the same time
20131118 21:16:50< fabi> The main point I like to discuss is: Is it okay to remove the tod image at that low resolution?
20131118 21:18:46-!- irker909 [~irker@ai0867.net] has joined #wesnoth-dev
20131118 21:18:46< irker909> wesnoth: 8573 wesnoth-old:master c1c661ed1f2b / data/lan_server.cfg: Fix two textual errors in data/lan_server.cfg. http://git.io/zlJRYQ
20131118 21:18:48< irker909> wesnoth: Bär Halberkamp wesnoth-old:master f85922d5d821 / data/lan_server.cfg: Merge pull request #83 from 8573/fix/text/lan-server-motd-spelling-and-capitaliz http://git.io/8NdUSw
20131118 21:18:52< AI0867> you need some kind of indication
20131118 21:19:23< fabi> AI0867: http://imagebin.org/277560 That is my first attempt on a UI theme for the 1.12 version which is in sync with the editor one again.
20131118 21:19:48< fabi> Yes, the time of day still needs to get shown somewhere.
20131118 21:23:15< fabi> http://imagebin.org/277780 The 1024x600 version.
20131118 21:25:08< fabi> http://imagebin.org/277781 800x600
20131118 21:28:04< fabi> http://imagebin.org/277782 800x480 (still incomplete)
20131118 21:28:32< fabi> Another idea is to get rid of the endturn button
20131118 21:34:02< irker909> wesnoth: 8573 wesnoth-old:master ef73e1d08c1c / data/ (3 files in 3 dirs): Fix straight apostrophes in player-visible text. http://git.io/ju2YIA
20131118 21:34:04< irker909> wesnoth: Bär Halberkamp wesnoth-old:master 623d752952d3 / data/ (3 files in 3 dirs): Merge branch 'fix/text/typographic-apostrophes/1' of https://github.com/8573/wes http://git.io/9AcR7g
20131118 21:34:07< irker909> wesnoth: Bär Halberkamp wesnoth-old:master c9a28f977b1c / data/lan_server.cfg: Fixed the conflicts http://git.io/j0bsXQ
20131118 21:38:40< fabi> hi thunderstruck
20131118 21:38:45-!- stikonas__ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Quit: Konversation terminated!]
20131118 21:39:59< fabi> Also, the game map decoration used in the editor, do we want it in the game as well? If yes, at all resolutions?
20131118 21:40:47< fabi> thunderstruck: I remember we talked about the wmllint errors in LoW once. Any news on the issue?
20131118 21:42:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 21:44:09< AI0867> looks like GCI has started already
20131118 21:44:33< AI0867> I'm getting status spam from the "copyleft games" project
20131118 21:45:39< thunderstruck> fabi: Hi. No, I haven't looked at that issue.
20131118 21:45:59< thunderstruck> I don't really now that stuff and I didn't have much time latetly.
20131118 21:46:02< thunderstruck> lately*
20131118 21:46:24< fabi> thunderstruck: Okay, I will take care about them.
20131118 21:46:30< thunderstruck> Anyway, I thought that issue is not in LoW, but in wmllint. Is that right?
20131118 21:46:54< thunderstruck> s/really now/really know/
20131118 21:47:07< fabi> Yes, the LoW code is most likely fine.
20131118 21:49:03< thunderstruck> fabi: Talking about LoW, do you have any plans to fix the last chapters for MP?
20131118 21:49:25< fabi> Well yes. I want to do them.
20131118 21:49:36< thunderstruck> I think I would be able to help with that, but I would need some guidance for story related things.
20131118 21:50:07< fabi> Still the competitive nature of that campaign part needs some thinking about the design. 
20131118 21:55:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20131118 22:00:13-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131118 22:00:28-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 22:03:38< thunderstruck> fabi: How did you use to test LoW for multiplayer?
20131118 22:04:09< fabi> thunderstruck: Sorry, I don't get that last sentence.
20131118 22:04:30< fabi> thunderstruck: Ah wait.
20131118 22:05:13< fabi> thunderstruck: I tested it in local multiplayer mode. And from time to time on the mp server by connecting with several wesnoth clients.
20131118 22:05:29< fabi> Is that what you want to know?
20131118 22:07:10< thunderstruck> And what did you do if you changed one of the last scenarios?
20131118 22:07:11-!- justinzane [~justinzan@tiny.justinzane.com] has quit []
20131118 22:07:16< thunderstruck> Did you manually set some carryover/
20131118 22:07:49< thunderstruck> 'Cause you would not just test it everything again, right? :)
20131118 22:08:48-!- justinzane [~justinzan@tiny.justinzane.com] has joined #wesnoth-dev
20131118 22:10:00< fabi> thunderstruck: You can make units in debug mode.
20131118 22:10:41< thunderstruck> But that would not work well in multiplayer. At least not on the server.
20131118 22:10:49< thunderstruck> I think I had OOS the last time I tried that.
20131118 22:11:39< mattsc> fabi: hi, I lied.  I did find out what causes pango markup not to work.
20131118 22:12:19< fabi> mattsc: What is it?
20131118 22:12:20< mattsc> This commit by mordante/shadowm adds a use_markup flag to add_tooltip(): https://github.com/wesnoth/wesnoth-old/commit/49eb8c10b1102e7131b7dbb277741dd0232182db
20131118 22:12:48< mattsc> But if you look at the file a l.146: https://github.com/wesnoth/wesnoth-old/blob/master/src/tooltips.cpp#L146
20131118 22:13:11< fabi> I see.
20131118 22:13:17< mattsc> you can see that this got added to lines 142 and 151, but apparently forgotten in l.146
20131118 22:13:42< mattsc> So I think all it takes is adding , use_markup to l.146
20131118 22:14:14< mattsc> Well, I tried, and it works, and I think that's all it takes.  But I'll let shadowm comment, maybe there's a deeper reason for this.
20131118 22:14:23-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds]
20131118 22:15:40-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131118 22:19:17< fabi> thunderstruck: LoW loads persistent variables.
20131118 22:19:29< fabi> thunderstruck: With units in them.
20131118 22:32:54< thunderstruck> fabi: Okay. I need to go now. Bye.
20131118 22:33:01-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20131118 22:38:49-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131118 22:57:07-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 272 seconds]
20131118 22:58:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20131118 22:58:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20131118 23:02:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 23:11:03-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Read error: Operation timed out]
20131118 23:11:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20131118 23:13:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131118 23:20:30-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg]
20131118 23:27:46< Espreon> fabi: Yeah, I'm not really interested in fixing up prose. Besides, I'm on Wesbreak.
20131118 23:27:57< Espreon> fabi: Sorry
20131118 23:28:05-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar]
20131118 23:28:10< fabi> Espreon: No problem. Have a nice Holiday :-)
20131118 23:28:17< Espreon> Thanks.
20131118 23:29:59-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev
20131118 23:35:22-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131118 23:37:37< shadowm> mattsc: I don't know what comment is required from me.
20131118 23:38:14< shadowm> That seems to be an obvious explanation for pango markup not working on tooltips, so...
20131118 23:38:33< mattsc> shadowm: whether l.146 in tooltips.cpp intentionally only has 3 arguments or whether that's an oversight
20131118 23:38:35< shadowm> fabi: Why did you mark https://gna.org/bugs/?20882 as fixed and closed it? Did you read my last comment?
20131118 23:38:56< shadowm> I still see those tooltips randomly alternating between using pango markup or not.
20131118 23:39:22< fabi> Yes.
20131118 23:39:48< mattsc> shadowm: and second, whether you want to fix it or if I should do it?
20131118 23:40:10< shadowm> fabi: Then the bug isn't Fixed yet and it's certainly not closeable.
20131118 23:40:26< shadowm> mattsc: Good question, I'm not really sure what's going on there and I haven't looked at the code in years.
20131118 23:40:32-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131118 23:40:45< shadowm> It's probably an oversight.
20131118 23:41:23< fabi> The old issue (not implemented tooltips) is closed.
20131118 23:41:59< mattsc> shadowm: from what I have seen, I'd assume so too.
20131118 23:42:02< fabi> The current issue is a problem at a different code location and not specific to the tooltip of the bug report.
20131118 23:42:29< fabi> I think it is better to not handle both issues in the same bug report.
20131118 23:42:44< shadowm> In fact that might as well be what mattsc pointed out since it apparently has something to do with overlapping tooltips (?).
20131118 23:43:02< fabi> shadowm: Yes, mattsc is speaking about the fix for that exact problem.
20131118 23:43:39< shadowm> mattsc: Feel free to test and commit. :)
20131118 23:44:34< mattsc> shadowm: okay.  I have tested that it fixes that bug, but will do some more tests and then commit.
20131118 23:44:36< fabi> shadowm: Please have a look at the screenshots I uploaded and linked to above.
20131118 23:46:24< shadowm> I don't see anything above in my 42 lines tall terminal.
20131118 23:46:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131118 23:46:41< shadowm> So, I guess it's from earlier. I'll try to remember to take a look later.
20131118 23:47:03< fabi> <fabi> AI0867: http://imagebin.org/277560 That is my first attempt on a UI theme for the 1.12 version which is in sync with the editor one again.
20131118 23:47:04< fabi> [22:20] <fabi> Yes, the time of day still needs to get shown somewhere.
20131118 23:47:06< fabi> [22:23] <fabi> http://imagebin.org/277780 The 1024x600 version.
20131118 23:47:07< fabi> [22:25] <fabi> http://imagebin.org/277781 800x600
20131118 23:47:09< fabi> [22:28] <fabi> http://imagebin.org/277782 800x480 (still incomplete)
20131118 23:48:06< shadowm> AI0867: Re http://forums.wesnoth.org/viewtopic.php?p=562810#p562810 how can the server know that option is enabled? Wouldn't the client be the one trying to ping the server?
20131118 23:48:17-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: Computer's napping]
20131118 23:51:15< shadowm> fabi: Are you aware that all editor terrain icons are broken atm btw?
20131118 23:51:28< fabi> yes
20131118 23:51:38< fabi> There is a bug report assigned to me.
20131118 23:51:50< fabi> Don't worry, the bug did not make it into 1.11.7.
20131118 23:52:11< fabi> I will commit the fix in the next hour.
20131118 23:54:44< AI0867> shadowm: no, the client sends 'selective_ping' to the server
20131118 23:54:54< AI0867> if that's true, the server refrains from pinging the client
20131118 23:58:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
--- Log closed Tue Nov 19 00:00:10 2013