--- Log opened Thu Nov 21 00:00:58 2013 20131121 00:04:47-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds] 20131121 00:05:29-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20131121 00:14:04-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer] 20131121 00:14:41-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20131121 00:29:16-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20131121 00:57:51-!- iceiceice [~chris@cpe-24-193-85-148.nyc.res.rr.com] has joined #wesnoth-dev 20131121 01:10:29-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 248 seconds] 20131121 01:14:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20131121 01:15:05-!- stikonas__ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Quit: Konversation terminated!] 20131121 01:19:20-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20131121 01:31:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Read error: Operation timed out] 20131121 01:31:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20131121 01:51:08-!- {V} [~V@88-73-ftth.on.nl] has quit [Ping timeout: 246 seconds] 20131121 01:51:36-!- {V} [~V@88-73-ftth.on.nl] has joined #wesnoth-dev 20131121 02:12:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20131121 02:23:19-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has joined #wesnoth-dev 20131121 02:24:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20131121 02:43:42-!- gfgtdf [~chatzilla@e177127199.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 24.0/20130910160258]] 20131121 02:44:03-!- wesbot changed the topic of #wesnoth-dev to: 200 bugs, 345 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20131121 02:57:49-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20131121 02:59:00-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 246 seconds] 20131121 03:05:15-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Remote host closed the connection] 20131121 03:21:20-!- Ivanovic_ [~ivanovic@x2f3d7cf.dyn.telefonica.de] has joined #wesnoth-dev 20131121 03:23:59-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 260 seconds] 20131121 03:24:02-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer] 20131121 03:25:14-!- Ivanovic_ is now known as Ivanovic 20131121 03:35:20-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev 20131121 03:35:53-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20131121 03:36:57< jamit> mattsc: Going by memory, I think Ayne shifted what got saved as the start of a replay, and that led to events being duplicated. But I don't remember, and that code takes time to sift through. 20131121 03:38:13< jamit> mattsc: What I did was compensate for that, in part because I did not want to hunt down why the replay was starting from a state after the start events. 20131121 03:38:27< mattsc> jamit: it's not actually the events that get duplicated. It's the state after the events that gets saved, and then some things get duplicated if the events are also run. 20131121 03:38:45< mattsc> jamit: yes, that was my interpretation of what you did. 20131121 03:39:07< mattsc> jamit: do you agree though that the events should be run? 20131121 03:39:10< jamit> Meh, point of view. The events are duplicated in the sense that they happened once before saving the start-of-replay and once after loading the replay. :P 20131121 03:39:21< mattsc> yes :) 20131121 03:40:04< jamit> Yes, I think it would be better to start the replay before the start events. Possibly also the prestart. 20131121 03:40:48< mattsc> jamit, okay. I have figured out how to do that. I have not had time to check yet whether that causes other side effects. 20131121 03:40:56< jamit> I thought it was odd that replays lacked a scenario's opening dialog, but I apparently didn't report it.... :( 20131121 03:41:49< jamit> Worst-case side effect: loading a replay causes your computer to explode. I think you can manage less destruction than that. :) 20131121 03:42:29< mattsc> most likely :) 20131121 03:43:02< jamit> Anyway, I just stopped in after browsing the log. I'm off, probably until the weekend. 20131121 03:43:05< jamit> Good luck. 20131121 03:43:11-!- jamit [~jamit@wesnoth/developer/jamit] has quit [Quit: Leaving.] 20131121 03:43:18< mattsc> thanks 20131121 04:03:38-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has joined #wesnoth-dev 20131121 04:25:39-!- Chusslove [~Chusslove@unaffiliated/chusslove] has quit [Read error: Operation timed out] 20131121 04:30:50-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds] 20131121 04:49:00< mattsc> Ha, funny. In most cases one would not get duplication of the prestart/start events even the way it is right now because they usually don't have 'first_time_only=no' set. 20131121 04:49:43< mattsc> But of course it is quite possible that that flag is set for one reason or another in a scenario even for a prestart or start event. 20131121 04:55:49-!- Chusslove [~Chusslove@unaffiliated/chusslove] has joined #wesnoth-dev 20131121 05:00:14-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20131121 05:05:29-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20131121 05:13:27< mattsc> ... and found yet another bug in replays in 1.11 ... 20131121 05:15:06< mattsc> When you get to the end of the replay and keep clicking play next turn, it doesn't stop there but happily moves through the turns. Again, this is already so in 1.11.5 and it is different from how it worked in 1.10. 20131121 05:26:58< mattsc> And another: game saved from a replay, then played some more results in replay with OOS errors. But that one was already like this in 1.10. 20131121 05:32:13-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20131121 05:42:54-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has joined #wesnoth-dev 20131121 05:52:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20131121 05:55:01< zookeeper> mattsc, yeah, actually i noticed that next turn bug yesterday as well 20131121 05:57:32< mattsc> zookeeper: good morning. I'll look into that one later sometime. I do have the prestart/start event thing fixed in my local repository (and that does fix the crash you encountered also). I just want to do some more tests tomorrow before I commit it. 20131121 05:59:08< zookeeper> i can't think of anything that might have gotten missed WRT the start/prestart events bug. unless it has something to do with multiplayer for example 20131121 06:00:50< mattsc> yeah, I have tested that it works in MP scenarios as well. I do want to do some tests with MP campaigns, but I don't really expect any trouble. 20131121 06:38:51< fabi__> Ivanovic: http://imagebin.org/278162 A special theme for the Pandora (or better for 800x480 devices which have a high dpi value) 20131121 06:39:01-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 246 seconds] 20131121 06:39:11-!- Ivanovic [~ivanovic@x2f3d7cf.dyn.telefonica.de] has quit [Changing host] 20131121 06:39:11-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20131121 06:39:29< fabi__> Ivanovic: ^ 20131121 06:40:21< Ivanovic> moin 20131121 06:40:29< Ivanovic> fabi__: how to end turn? 20131121 06:40:37-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20131121 06:41:36< fabi__> Ivanovic: I left the end turn button out. I thought it is okay to use the menu button or the context menu. But we can talk about that. 20131121 06:43:50< fabi__> Ivanovic: I tried to address all the issue you mentioned: Make the button big enough to be easy touchable. The map is big enough to be usable again. Only show the important stuff but that big enough to work on the small display. 20131121 06:49:09< Ivanovic> fabi__: maybe have a smaller icon somewhere for the "real" menu but some end turn button instead? 20131121 06:49:23< Ivanovic> the problem is that end turn is required very often, the menu less often so 20131121 06:51:02< fabi__> Yeah, I can try that. It is already a bit crowded and not easy to find some extra space. 20131121 06:51:12< fabi__> Ivanovic: Do you like the overall concept? 20131121 06:51:19< Ivanovic> yes, I do 20131121 06:51:40< Ivanovic> to get an idea of the size of the pandora: take the screenshot you got and view it in an image viewer 20131121 06:52:08-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20131121 06:52:09< Ivanovic> take a ruler and reduce the image so far that the diagonal of it is about 9.4cm on your display 20131121 06:52:18< Ivanovic> this way you at least have a rough idea how it will feel 20131121 06:52:45< fabi__> Uh 20131121 06:52:51< fabi__> That is still readable. 20131121 06:52:57< fabi__> Better than I thought. 20131121 06:56:15< fabi__> Ivanovic: Were you ever able to read any of the unit description stuff with the old theme? 20131121 07:05:20< Ivanovic> with good eyes: yes 20131121 07:05:29< Ivanovic> but it was freaking tiny 20131121 07:06:43< fabi__> Ivanovic: I don't have fitting buttons for the menu and end turn lying around. But LordBob will surely help there. I am going to commit the theme soon, you can play with it then. 20131121 07:07:24< Ivanovic> fabi__: before being able to do so i need to first find out the reason for the segfault in versions post the release of 1.11.4 20131121 07:07:46< Ivanovic> fabi__: and i most likely won't find the time before december 12th (that is when my vacation starts) 20131121 07:09:24< fabi__> Ivanovic: Okay, so the 800x480 version of the default theme will still aim at low resolution with low dpi and the small devices with high dpi get their own theme. 20131121 07:10:20< Ivanovic> for devices with "extremely high dpi" (well above the 160dpi level e.g. fullhd on 5") we peobably need yet a different theme where the units are increased in size 20131121 07:11:13< fabi__> Indeed. But that is not much a question of the theme. It is more an issue of setting a different default zoom level. 20131121 07:11:27< fabi__> Ivanovic: Do you package the pandora version yourself? 20131121 07:11:33< Ivanovic> yes 20131121 07:11:44< Ivanovic> and now i got to head off to work 20131121 07:11:50< Ivanovic> CU in some 12h 20131121 07:11:52< fabi__> Ivanovic: bye 20131121 07:26:51-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has joined #wesnoth-dev 20131121 07:34:14< vultraz> fabi__: were you able to get your editor selection fix in with 1.11.7? 20131121 07:51:01-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 248 seconds] 20131121 07:55:12-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20131121 07:56:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20131121 08:12:17-!- mjs-de [~mjs-de@f049194009.adsl.alicedsl.de] has joined #wesnoth-dev 20131121 08:56:35-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has joined #wesnoth-dev 20131121 09:09:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20131121 09:09:26-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20131121 09:25:34-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20131121 09:45:09-!- irker924 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20131121 09:47:35-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection] 20131121 09:48:11-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20131121 09:52:45-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 272 seconds] 20131121 10:11:39-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20131121 10:16:41-!- Octalot [~noct@87.114.171.23] has joined #wesnoth-dev 20131121 10:42:16-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20131121 10:54:08-!- Coffee_irc [~david@ppp118-210-35-86.lns20.adl2.internode.on.net] has joined #wesnoth-dev 20131121 11:07:55-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds] 20131121 11:13:08-!- LordNasty [~NaSTy@93-43-104-160.ip91.fastwebnet.it] has quit [Read error: Connection reset by peer] 20131121 11:15:43-!- LordNasty [~NaSTy@93-43-104-160.ip91.fastwebnet.it] has joined #wesnoth-dev 20131121 11:48:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20131121 11:54:02-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20131121 12:26:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20131121 12:36:01-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20131121 12:41:12-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20131121 12:41:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20131121 12:44:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20131121 12:44:45-!- stikonas_ [~gentoo@maths-pgs-002.maths.ed.ac.uk] has joined #wesnoth-dev 20131121 12:44:45-!- stikonas_ [~gentoo@maths-pgs-002.maths.ed.ac.uk] has quit [Changing host] 20131121 12:44:45-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20131121 12:44:57-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Client Quit] 20131121 13:00:00-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20131121 13:06:15-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20131121 13:17:50-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20131121 13:18:10-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20131121 13:29:06-!- Kostic [~marko@85.202.113.151] has joined #wesnoth-dev 20131121 13:34:03-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 272 seconds] 20131121 13:36:11-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20131121 13:44:58-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20131121 13:52:12-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has joined #wesnoth-dev 20131121 13:52:12-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has quit [Changing host] 20131121 13:52:12-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20131121 13:54:29-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20131121 13:54:43-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20131121 13:57:33-!- TooLmaN [~TooLmaN@mx1.thomsonplastics.com] has joined #wesnoth-dev 20131121 14:05:47-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20131121 14:41:24-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20131121 14:58:40-!- mattsc [~mattsc@154.20.32.246] has quit [Quit: Computer's napping] 20131121 15:03:53-!- iceiceice [~chris@cpe-24-193-85-148.nyc.res.rr.com] has quit [Ping timeout: 245 seconds] 20131121 15:18:35-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20131121 15:19:12-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20131121 15:22:03-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has joined #wesnoth-dev 20131121 15:23:32-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20131121 15:42:59-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20131121 15:54:18-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds] 20131121 15:55:16-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar] 20131121 15:57:58-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20131121 15:59:57-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev 20131121 16:00:20< bumbadadabum> zookeeper: I was thinking about expanding the selection of schedules and their usage in mainline. Do you think that would be a good idea? For example, we have the summer and winter schedules (which aren't used a lot) and there are some other things floating in the aether (like rain) that could be used to add flavor to a scenario 20131121 16:02:02< zookeeper> i don't see the point in increasing the selection just for its own sake. if there's a scenario which should have a different schedule, then that can be added. 20131121 16:03:40< bumbadadabum> zookeeper: The summer and winter schedules were also added for no reason as of now 20131121 16:03:45< bumbadadabum> They're not used anywhere 20131121 16:04:07< zookeeper> well, i'd have advised against that too. 20131121 16:04:46< bumbadadabum> same is the case for MIDNIGHT and MIDDAY 20131121 16:05:03< bumbadadabum> I think those could be added to some scenarios to add flavor 20131121 16:05:43< bumbadadabum> although that would affect balance 20131121 16:07:16-!- R2D2C3PO [57a141b7@gateway/web/freenode/ip.87.161.65.183] has joined #wesnoth-dev 20131121 16:23:51-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20131121 16:30:09-!- mjs-de [~mjs-de@f049194009.adsl.alicedsl.de] has quit [Read error: Operation timed out] 20131121 16:33:43-!- mjs-de [~mjs-de@g228140077.adsl.alicedsl.de] has joined #wesnoth-dev 20131121 16:53:50-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20131121 16:54:15-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20131121 17:03:07-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20131121 17:06:23-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds] 20131121 17:08:56-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20131121 17:10:13< mattsc> bumbadadabum: MIDDAY and MIDNIGHT are being used in a couple mainline scenarios 20131121 17:10:24< bumbadadabum> grep didn't return anything 20131121 17:10:43< mattsc> it does for me 20131121 17:10:50< bumbadadabum> well 20131121 17:11:02< mattsc> MIDDAY is in UtBS; MIDNIGHT in SotBE and DiD 20131121 17:11:06< bumbadadabum> it returned UtBS, which uses a midday in their schedule 20131121 17:11:17< bumbadadabum> and the midnight hour from the 24h schedule 20131121 17:12:01< mattsc> oh, okay; I thought that's what you were talking about. Disregard awhat I am saying then. :) 20131121 17:25:41-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20131121 17:28:03-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar] 20131121 17:30:11-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has joined #wesnoth-dev 20131121 17:31:28< mattsc> hi fabi__ 20131121 17:32:10-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has joined #wesnoth-dev 20131121 17:32:13< mattsc> I am trying to figure out why the replay buttons don't stay disabled after all replay actions are done. Doesn't button()_>enable(false) disable a button? 20131121 17:32:26< mattsc> Does it get reset automatically when the side changes or something? 20131121 17:40:31-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 246 seconds] 20131121 17:41:17-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20131121 17:46:00-!- Chusslove [~Chusslove@unaffiliated/chusslove] has quit [] 20131121 17:46:13-!- lipkab [~the_new_l@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 272 seconds] 20131121 18:00:13-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20131121 18:00:27-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20131121 18:02:13< mattsc> Oh, wow, it's in hotkeys.cpp (function set_button_state) that resets them to active. I need to stop this right now though. I'll get back to it later... 20131121 18:03:55-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20131121 18:03:55-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Client Quit] 20131121 18:05:21< mattsc> fabi__: so what's going on here, if I understand it correctly, is that that function checks whether it _can_ execute the replay button action, and since the answer is yes, it re-enables the button. 20131121 18:05:44< mattsc> Well, sure, it _can_ do that. But how about if I do not _want_ to. How do I force that? 20131121 18:06:28-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has quit [Quit: DCW] 20131121 18:14:54< fabi__> hi mattsc 20131121 18:15:09< mattsc> hi fabi__ 20131121 18:16:10< mattsc> fabi__: does my question make sense? 20131121 18:16:28< fabi__> yes 20131121 18:16:40< fabi__> let me fetch some tea and smoke a cigarette. 20131121 18:17:10< mattsc> fabi__: sure. I'll be afk in about 10 minutes for half and hour to an hour, back after that. 20131121 18:17:23< fabi__> okay 20131121 18:17:31< mattsc> fabi__: possibly related, the tooltips for the replay buttons also don't seem to work. 20131121 18:18:58< Ivanovic> hi folks 20131121 18:21:05< fabi__> hi Ivanovic 20131121 18:25:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20131121 18:26:50< fabi__> mattsc: There is no way right now to disable the automatic handling of button states. 20131121 18:27:47< mattsc> fabi__: is there a way to have the action function return an "I'm not available" ? 20131121 18:27:56< fabi__> mattsc: The logic to determine the state of the button should be moved to the can_execute function. 20131121 18:41:01-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev 20131121 18:43:48< Ivanovic> fabi__: if you need to compare the screen elements take this 1.10 pandora screenshot and make sure to use it scaled down so that the diagonal is just 9.7cm on your normal screen: http://repo.openpandora.org/files/pnd/wesnoth-1.11/screenshots/wesnoth-1.10-2.png 20131121 18:44:13< Ivanovic> so yes, if this image is shown on a "normal" screen the minimap is somewhat usable but already borderline 20131121 18:44:30< Ivanovic> and the map of the first scenario of two brothers is not too huge 20131121 18:46:47< fabi__> Ivanovic: On my monitor I can't read anything anymore with the old theme when zoomed to ~10cm. 20131121 18:47:13< fabi__> Ivanovic: The text is reduced to blur. 20131121 18:47:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20131121 18:47:29< fabi__> Except the name of the human. 20131121 18:48:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20131121 18:50:11-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has joined #wesnoth-dev 20131121 18:53:41< fabi__> vultraz: No, I have not worked on the selection tool recently. 20131121 18:53:57< bumbadadabum> fabi__: I noticed something in the editor 20131121 18:54:21< bumbadadabum> if I want to change the color adjust in the ToD tool the dialog disappears 20131121 18:55:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20131121 18:57:23< Ivanovic> fabi__: that is due to image scaling 20131121 18:57:35< Ivanovic> if you have the stuff in the respective dpi on the screen it is readable 20131121 18:58:10< fabi__> bumbadadabum: Yeah, that is vultraz's bug. He is the master of the tod dialog. 20131121 18:58:20-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds] 20131121 18:58:37< fabi__> Ivanovic: Yes, I thought so. 20131121 19:00:16-!- fabi__ [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20131121 19:00:29< vultraz> bumbadadabum: I'm dealing with it 20131121 19:01:36< bumbadadabum> k 20131121 19:01:40< bumbadadabum> do it quickly 20131121 19:01:48< bumbadadabum> I want to mess with the ToD lighting 20131121 19:03:31-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has joined #wesnoth-dev 20131121 19:04:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20131121 19:13:09-!- Kostic [~marko@85.202.113.151] has quit [Ping timeout: 248 seconds] 20131121 19:13:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20131121 19:17:30-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds] 20131121 19:31:37-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 272 seconds] 20131121 19:35:48-!- gfgtdf [~chatzilla@e177127199.adsl.alicedsl.de] has joined #wesnoth-dev 20131121 19:38:06-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has quit [Quit: Lämnar] 20131121 19:39:55-!- molgrum [~molgrum@h-94-220.a230.priv.bahnhof.se] has joined #wesnoth-dev 20131121 19:48:36-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has joined #wesnoth-dev 20131121 19:49:16-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has left #wesnoth-dev [] 20131121 20:02:57-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20131121 20:04:23-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20131121 20:09:00< fabi> mattsc: Are you around again? 20131121 20:09:31< mattsc> fabi: hi, yes. And thanks, I understand what I need to do now. 20131121 20:10:37< fabi> mattsc: Yeah, the whole point of my changes to the hotkeys system was to let the can_execute be in control of both the menu entries and the state of buttons which rely on hotkey actions. 20131121 20:11:33< mattsc> fabi: yeah, that works really well, I just didn't know that part of the code yet. 20131121 20:12:04< mattsc> I'm in the process of doing the last tests of the prestart/start event issue, and then I'll take care of the buttons. 20131121 20:15:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20131121 20:20:14-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev 20131121 20:20:14-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host] 20131121 20:20:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20131121 20:35:20< mattsc> hi irker ... ? 20131121 20:35:43< fabi> mattsc: AI0867 is his master. 20131121 20:35:59< mattsc> fabi: :) thanks 20131121 20:37:53< mattsc> zookeeper: I just made two commits which result in three fixes: [pre]start events are included in replays again; the crash you encountered by ending the scenario during the start event is fixed with that too; play/stop buttons become inactive after the replay is over. 20131121 20:38:39< mattsc> Also, the order of the stored units is now the same ingame and in the replay, although I doubt that that will fix the OOS error in Clash of Armies. 20131121 20:41:53-!- Jetrel_ [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev 20131121 20:45:43-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 272 seconds] 20131121 20:50:59-!- R2D2C3PO [57a141b7@gateway/web/freenode/ip.87.161.65.183] has quit [Ping timeout: 250 seconds] 20131121 20:51:48-!- irker354 [~irker@ai0867.net] has joined #wesnoth-dev 20131121 20:51:48< irker354> wesnoth: mattsc wesnoth-old:master 2cb96755e43c / src/ (playsingle_controller.cpp replay_controller.cpp): Replays: add prestart and start events back into replays http://git.io/9CbfQg 20131121 20:51:48< irker354> wesnoth: mattsc wesnoth-old:master 2309ee15e0ca / src/replay_controller.cpp: Replays: disable the play/stop buttons after end of replay http://git.io/e-KMfg 20131121 20:52:30< mattsc> thank you, irker354. :) 20131121 20:55:29< AI0867> mattsc: if it needs to reconnect to IRC, it may take a minute 20131121 20:55:41-!- Coffee_irc [~david@ppp118-210-35-86.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!] 20131121 20:55:43< AI0867> but did it take 20 in this case? 20131121 20:57:05< AI0867> huh, the webhook received stuff at [21/Nov/2013 21:34:30] 20131121 20:57:23< AI0867> but irker didn't actually transmit until Thu Nov 21 21:51:40 2013 20131121 21:02:18< mattsc> AI0867: I know that it might take up to a minute or so. I didn't know that it might take this long. 20131121 21:02:32< mattsc> I thought that when it's this long, it's down somehow and you restart it. 20131121 21:04:50< AI0867> nope, it did this all by itself 20131121 21:04:54< AI0867> not sure why it took so long 20131121 21:05:57< mattsc> okay - I'll wait longer next time then. :) 20131121 21:10:23-!- TooLmaN [~TooLmaN@mx1.thomsonplastics.com] has quit [Quit: Off to save the world!] 20131121 21:13:04-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 245 seconds] 20131121 21:13:10-!- Gallaecio [~quassel@84.120.115.29.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 20131121 21:18:45-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has joined #wesnoth-dev 20131121 21:23:26-!- Kostic [~marko@net242-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev 20131121 21:34:06-!- Kostic [~marko@net242-1-245-109.mbb.telenor.rs] has quit [Ping timeout: 246 seconds] 20131121 21:35:01-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 248 seconds] 20131121 21:36:41-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20131121 21:36:57-!- Kostic [~marko@net242-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev 20131121 22:02:01-!- Chusslove [~Chusslove@unaffiliated/chusslove] has joined #wesnoth-dev 20131121 22:04:03-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds] 20131121 22:05:28-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev 20131121 22:06:11< mattsc> zookeeper: btw, I figured out what's going on in Clash of Armies. It's not that the stored units get shuffled around, it's that they get stored (enter the transport) in an undeterministic order. So it's this [store_unit] tag that's done in a different order: 20131121 22:06:22< mattsc> https://github.com/wesnoth/wesnoth-old/blob/master/data/campaigns/Son_Of_The_Black_Eye/scenarios/11_Clash_of_Armies.cfg#L375 20131121 22:06:51< zookeeper> uh huh. 20131121 22:07:21< mattsc> The wiki claims this: "The units will be stored in order of their internal underlying_id attribute, which is usually in creation order", but it's not true 20131121 22:07:46< mattsc> While the underlying IDs are not the same, the differences between them for the 3 units are the same. 20131121 22:08:31< mattsc> There's a number of different ways to fix that. Just curious which one you would use. 20131121 22:09:11-!- gfgtdf_ [~chatzilla@f054139250.adsl.alicedsl.de] has joined #wesnoth-dev 20131121 22:09:42< zookeeper> well, i'd think that the logical thing is to make sure that ids and underlying_ids remain constant 20131121 22:09:55-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has joined #wesnoth-dev 20131121 22:10:03< mattsc> but that won't change this problem 20131121 22:10:40< zookeeper> if that doesn't cause the undeterministic store order, what does? 20131121 22:10:52< mattsc> the underlying_ids for the 3 units are 421-423-413 ingame and 447-449-439 in the replay, in that order (in my case) 20131121 22:11:09< mattsc> yet, they enter the transport in order 1-2-3 in one case and 1-3-2 in the other 20131121 22:11:12-!- Kostic [~marko@net242-1-245-109.mbb.telenor.rs] has quit [Ping timeout: 246 seconds] 20131121 22:11:48-!- Kostic [~marko@net242-1-245-109.mbb.telenor.rs] has joined #wesnoth-dev 20131121 22:11:51-!- gfgtdf [~chatzilla@e177127199.adsl.alicedsl.de] has quit [Ping timeout: 272 seconds] 20131121 22:11:57< mattsc> I don't know what causes the different order in the code, so far this is just an observation of what is happening 20131121 22:12:06< zookeeper> oh, right 20131121 22:12:06-!- gfgtdf_ is now known as gfgtdf 20131121 22:12:36< mattsc> actually, give me a second, I'll try something 20131121 22:13:48< zookeeper> well, for one thing i really do think that making underlying_id deterministic between ingame/replay makes sense in any case. having it be undeterministic sounds like a big can of worms. 20131121 22:14:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20131121 22:15:06< mattsc> zookeeper: I can't disagree with that 20131121 22:19:25< mattsc> zookeeper: I changed the ids and underlying ids to be exactly the same in the replay as in the normal save, and the order is still different. 20131121 22:19:32< mattsc> So what the wiki says is definitely wrong. 20131121 22:19:38< mattsc> Let me change the names too 20131121 22:21:03< zookeeper> have you checked the actual code behind [store_unit]? 20131121 22:23:34< mattsc> no I have not yet done that 20131121 22:23:55< zookeeper> sounds like that's where you need to dive :P 20131121 22:23:56< mattsc> in any case, changing the names doesn't change anything either 20131121 22:24:31< mattsc> Well, or you could heed the warning on the wiki: "but you normally should not depend on the order" 20131121 22:24:45< mattsc> and write the WML so that it does not depend on the stored unit order :) 20131121 22:24:55< mattsc> you = one = we, in this case 20131121 22:25:58< zookeeper> well, i don't think that would be a reasonable interpretation of that warning 20131121 22:26:02< mattsc> With which I don't mean to disagree that the code should do the same in the two cases 20131121 22:26:28< mattsc> why not? How should I interpret it? 20131121 22:29:18< zookeeper> well, i interpret it as "there are no guarantees about the order". i think it goes without saying that even then, the order should be deterministic between ingame and replay. 20131121 22:30:12< mattsc> Hmm, I definitely agree that it should be ... 20131121 22:30:19< zookeeper> i mean you can't really ask WML authors to deal with stuff producing different results ingame and in replays 20131121 22:30:31< mattsc> Why is [store_unit] written in Lua ? Wasn't this tag around long before Lua ? 20131121 22:30:45< zookeeper> it was, dunno why it's in lua 20131121 22:30:53< zookeeper> anyway, i really gotta go to bed 20131121 22:31:22-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20131121 22:31:50< mattsc> okay, good night. Anyways, that makes the fix trivial. It's a one-liner. 20131121 22:32:02< zookeeper> i just really think that replays are replays and thus it's a given that they should... replay what happened in the game. 20131121 22:32:06< mattsc> Do I reinstate the "ordered by underlying_id" thing as the wiki says? 20131121 22:32:32< mattsc> As I said, I don't at all disagree with that. 20131121 22:32:36< zookeeper> i don't really care what the order is, or which order would be best 20131121 22:32:49< zookeeper> one-liner fix? well, that's... cool 20131121 22:32:52 * zookeeper will read logs tomorrow 20131121 22:33:06< mattsc> good night 20131121 22:35:20-!- mjs-de [~mjs-de@g228140077.adsl.alicedsl.de] has quit [Remote host closed the connection] 20131121 22:36:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20131121 22:37:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20131121 22:37:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20131121 22:37:46-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20131121 22:41:25-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20131121 22:42:25-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20131121 22:42:55-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev 20131121 22:42:55-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host] 20131121 22:42:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20131121 22:45:33-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 252 seconds] 20131121 23:04:25-!- Chusslove [~Chusslove@unaffiliated/chusslove] has quit [Ping timeout: 272 seconds] 20131121 23:06:20-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20131121 23:06:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20131121 23:07:40-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20131121 23:11:57-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 252 seconds] 20131121 23:12:55-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds] 20131121 23:14:51-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer] 20131121 23:15:15-!- exciton [~exciton@89.208.169.104] has joined #wesnoth-dev 20131121 23:19:27-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg] 20131121 23:35:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20131121 23:41:52< mattsc> zookeeper: http://forums.wesnoth.org/viewtopic.php?f=58&t=39648 20131121 23:43:56-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: Computer's napping] 20131121 23:45:24-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20131121 23:49:22-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20131121 23:52:33-!- Kostic [~marko@net242-1-245-109.mbb.telenor.rs] has quit [Ping timeout: 272 seconds] 20131121 23:57:10-!- ancestral [~ancestral@71-215-216-1.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20131121 23:57:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev --- Log closed Fri Nov 22 00:00:03 2013