--- Log opened Wed Dec 04 00:00:38 2013
20131204 00:34:37-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20131204 00:35:05-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20131204 00:36:28-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131204 00:53:48-!- mjs-de [~mjs-de@g228135220.adsl.alicedsl.de] has quit [Remote host closed the connection]
20131204 01:17:40-!- gfgtdf [~chatzilla@f054172177.adsl.alicedsl.de] has joined #wesnoth-dev
20131204 01:20:17-!- kex [~kex@212.158.180.74] has joined #wesnoth-dev
20131204 01:21:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20131204 01:26:43-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20131204 02:13:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131204 02:17:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20131204 02:17:16-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20131204 02:34:55-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds]
20131204 02:35:31-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131204 02:44:02-!- wesbot changed the topic of #wesnoth-dev to: 202 bugs, 345 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20131204 03:04:47-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds]
20131204 03:05:29-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131204 03:08:50-!- Octalot_ [~noct@245.176.90.146.dyn.plus.net] has quit []
20131204 03:09:45-!- kex [~kex@212.158.180.74] has quit [Remote host closed the connection]
20131204 03:10:35-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has joined #wesnoth-dev
20131204 03:11:59-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20131204 03:21:36-!- Ivanovic_ [~ivanovic@x2f49a35.dyn.telefonica.de] has joined #wesnoth-dev
20131204 03:24:13-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 272 seconds]
20131204 03:24:56-!- Ivanovic_ is now known as Ivanovic
20131204 03:27:54-!- gfgtdf [~chatzilla@f054172177.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 24.0/20130910160258]]
20131204 03:30:31-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has quit [Quit: Turuk]
20131204 03:34:23-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 252 seconds]
20131204 04:04:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131204 04:14:27-!- un214 [~un214@2602:303:fcd0:a019:224:8cff:fed2:ef57] has joined #wesnoth-dev
20131204 04:17:05-!- knotwork [~markm@unaffiliated/knotwork] has quit [Read error: Connection reset by peer]
20131204 04:18:02-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20131204 04:18:41-!- un214 [~un214@2602:303:fcd0:a019:224:8cff:fed2:ef57] has quit [Remote host closed the connection]
20131204 04:20:20-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20131204 05:02:16-!- Chusslove [~Chusslove@unaffiliated/chusslove] has quit [Ping timeout: 245 seconds]
20131204 05:14:45-!- Samual_ [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20131204 05:16:31-!- crimson_pingvin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20131204 05:20:07-!- Samual [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 245 seconds]
20131204 05:20:08-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 245 seconds]
20131204 05:20:08-!- crimson_pingvin is now known as crimson_penguin
20131204 05:28:54-!- Chusslove [~Chusslove@brsg-d9baf47c.pool.mediaWays.net] has joined #wesnoth-dev
20131204 05:28:54-!- Chusslove [~Chusslove@brsg-d9baf47c.pool.mediaWays.net] has quit [Changing host]
20131204 05:28:54-!- Chusslove [~Chusslove@unaffiliated/chusslove] has joined #wesnoth-dev
20131204 05:43:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20131204 06:04:29-!- mattsc [~mattsc@154.20.32.246] has quit [Quit: Ciao]
20131204 06:06:14-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20131204 06:06:14-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20131204 06:41:58-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20131204 06:44:55-!- Ivanovic [~ivanovic@x2f49a35.dyn.telefonica.de] has quit [Changing host]
20131204 06:44:55-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20131204 07:46:52-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131204 08:07:18-!- Octalot [~noct@245.176.90.146.dyn.plus.net] has joined #wesnoth-dev
20131204 08:17:08-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has joined #wesnoth-dev
20131204 08:32:32-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131204 08:33:39< Soliton> fabi: the only obvious part of that commit was that you refactored hotkey stuff for some reason. i hope you can see that that is not enough to understand/verify the commit in any meaningful way.
20131204 08:35:04< fabi> Soliton: There is no other reasoning behind the commit than: File too large! Can't find what I need in it. Split stuff into more files to get overview back.
20131204 08:37:01< Soliton> so you randomly chose function groups and moved them into randomly named new source files?
20131204 08:37:32< fabi> I put a class in its own file.
20131204 08:37:45< fabi> And a struct with related functions into another file.
20131204 08:37:49-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131204 08:38:06< fabi> A third class got a third file.
20131204 08:39:34< Soliton> looks like you could have made the commit obvious with just a couple of lines of explanation then.
20131204 08:39:45< fabi> Yes
20131204 08:40:23< fabi> Beside the 2 very small interface cleanups it was quite the basic case of a refactoring job.
20131204 08:41:58-!- Samual_ [diotecktec@xonotic/core-team/Samual] has quit [Read error: Connection reset by peer]
20131204 08:42:33-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20131204 09:05:20-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20131204 09:05:49-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 241 seconds]
20131204 09:08:44-!- iwaim_ [~iwaim@gateway.alib.jp] has quit [Remote host closed the connection]
20131204 09:09:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131204 09:10:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131204 09:10:35-!- iwaim_ [~iwaim@gateway.alib.jp] has joined #wesnoth-dev
20131204 09:11:30-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has quit [Ping timeout: 246 seconds]
20131204 09:11:40-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has joined #wesnoth-dev
20131204 09:12:21-!- Netsplit *.net <-> *.split quits: Crendgrim
20131204 09:16:05-!- EdB_ [~edb@ip-153.net-89-2-218.rev.numericable.fr] has joined #wesnoth-dev
20131204 09:16:20-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20131204 09:16:45-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has quit [Ping timeout: 246 seconds]
20131204 09:27:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131204 09:40:40< Soliton> maybe we should make it clear in some developer guidelines that wesnoth is not a write-only project. actual code and commits will be read much more often than written which means if people make a bit of an effort to explain their reasoning (even if it seems trivial to them at the time) it saves all the people reading their code lots of time and guess work. which in turn means better quality since they can spot errors much better if they
20131204 09:40:46< Soliton> know what's going on and why.
20131204 09:41:09< Soliton> at least i think that's something people forget occasionally.
20131204 09:42:03-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20131204 09:42:03-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host]
20131204 09:42:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131204 09:45:31-!- mjs-de [~mjs-de@f049013167.adsl.alicedsl.de] has joined #wesnoth-dev
20131204 10:04:02< fabi> Soliton:  http://xkcd.com/1296/
20131204 10:43:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20131204 10:47:50-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131204 10:48:42-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20131204 11:11:11< trademark_> wesbot, !seen mordante
20131204 11:11:11< wesbot> trademark_: The person with the nick mordante last spoke 58d 14h ago.  58d 14h ago was here and on the channel #wesnoth-de with the message: Quit: Leaving
20131204 11:17:00-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20131204 11:24:00-!- Fortescue [~Vigilant@cpe-65-189-245-210.woh.res.rr.com] has quit []
20131204 11:29:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131204 11:29:51-!- Fortescue [~Vigilant@cpe-65-189-245-210.woh.res.rr.com] has joined #wesnoth-dev
20131204 11:41:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20131204 12:00:16-!- Crendgrim_ is now known as Crendgrim
20131204 12:03:47-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 260 seconds]
20131204 12:05:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131204 12:06:44-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20131204 12:07:37-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20131204 12:08:11-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131204 12:08:14-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has joined #wesnoth-dev
20131204 12:08:14-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has quit [Changing host]
20131204 12:08:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131204 12:08:54-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131204 12:09:16-!- EdB_ is now known as EdB
20131204 12:12:28-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Quit: I'm jerking forever, leaves.]
20131204 12:12:29-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20131204 12:17:17-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20131204 12:20:22-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131204 12:20:25-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has joined #wesnoth-dev
20131204 12:27:51-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20131204 12:29:14-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20131204 12:34:29-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has quit [Quit: Turuk]
20131204 12:38:42-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20131204 12:39:52-!- fabi [~fabi@88-134-21-163-dynip.superkabel.de] has joined #wesnoth-dev
20131204 12:39:52-!- fabi [~fabi@88-134-21-163-dynip.superkabel.de] has quit [Changing host]
20131204 12:39:52-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20131204 12:45:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20131204 12:56:38-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20131204 12:57:19-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20131204 13:00:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131204 13:00:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131204 13:02:15-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20131204 13:03:27-!- fabi [~fabi@88-134-21-163-dynip.superkabel.de] has joined #wesnoth-dev
20131204 13:03:27-!- fabi [~fabi@88-134-21-163-dynip.superkabel.de] has quit [Changing host]
20131204 13:03:27-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20131204 13:04:34-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has joined #wesnoth-dev
20131204 13:04:34-!- stikonas [~gentoo@cpat001.wlan.net.ed.ac.uk] has quit [Changing host]
20131204 13:04:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131204 13:26:08-!- irker719 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20131204 13:38:50-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20131204 13:42:41-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 252 seconds]
20131204 13:51:39-!- TooLmaN [~TooLmaN@mx1.thomsonplastics.com] has joined #wesnoth-dev
20131204 13:59:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
20131204 14:14:24-!- mattsc [~mattsc@207.230.251.234] has joined #wesnoth-dev
20131204 14:16:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20131204 14:16:14-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20131204 15:04:00-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has joined #wesnoth-dev
20131204 15:06:12-!- Kostic [~marko@85.202.113.46] has joined #wesnoth-dev
20131204 15:07:30-!- mattsc [~mattsc@207.230.251.234] has quit [Quit: Computer's napping]
20131204 15:09:07-!- Kostic [~marko@85.202.113.46] has quit [Remote host closed the connection]
20131204 15:14:50-!- Kostic [~marko@85.202.113.22] has joined #wesnoth-dev
20131204 15:15:02-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131204 15:26:48-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev
20131204 15:33:20-!- irker926 [~irker@109.237.218.218] has joined #wesnoth-dev
20131204 15:33:20< irker926> wesnoth: mattsc wesnoth-old:master cfee347a38d5 / src/ai/actions.cpp: Remove blank lines http://git.io/WkuztQ
20131204 15:33:22< irker926> wesnoth: mattsc wesnoth-old:master 3aa9cdc99cad / src/ (10 files in 4 dirs): Lua AI: add new replay-safe action ai.synced_command() http://git.io/MXArLA
20131204 15:33:24< irker926> wesnoth: mattsc wesnoth-old:master 4aef27a1dd39 / data/campaigns/Son_Of_The_Black_Eye/ (ai/ca_transport.lua ai/ca_transport_S6.lua scenarios/06_Black_Flag.cfg): SotBE S6: rename transport AI candidate action file http://git.io/4TfQnQ
20131204 15:33:26< irker926> wesnoth: mattsc wesnoth-old:master 3cce3ae09362 / data/campaigns/Son_Of_The_Black_Eye/ (ai/ca_transport_S6.lua ai/unload.lua scenarios/06_Black_Flag.cfg): SotBE S6: move unloading code into the AI http://git.io/r_kQKA
20131204 15:36:18-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20131204 15:36:51-!- kex [~kex@212.158.180.32] has joined #wesnoth-dev
20131204 15:37:33-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20131204 15:41:47-!- kex [~kex@212.158.180.32] has quit [Ping timeout: 272 seconds]
20131204 16:00:12-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20131204 16:05:09< irker926> wesnoth: Bär Halberkamp wesnoth-old:master 4c7f24c319a8 / src/unit.cpp: Allowed the generated description for traits to be turned off http://git.io/BuNiGQ
20131204 16:05:12< irker926> wesnoth: Bär Halberkamp wesnoth-old:master a2b1d69755d7 / changelog: updated changelog http://git.io/Zbr0dA
20131204 16:21:51-!- Fortescue [~Vigilant@cpe-65-189-245-210.woh.res.rr.com] has quit []
20131204 16:22:18-!- Fortescue [~Vigilant@cpe-65-189-245-210.woh.res.rr.com] has joined #wesnoth-dev
20131204 16:33:59-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131204 16:48:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131204 16:48:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20131204 16:52:24< irker926> wesnoth: mattsc wesnoth-old:master 28b05397b657 / data/campaigns/Son_Of_The_Black_Eye/ai/ca_transport_S6.lua: SotBE S6: fix typo in variable names http://git.io/j4lwrA
20131204 17:10:40-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has quit [Remote host closed the connection]
20131204 17:11:32-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has joined #wesnoth-dev
20131204 17:14:07-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has quit [Quit: Turuk]
20131204 17:23:17-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 246 seconds]
20131204 17:23:42-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20131204 17:41:47-!- soifb [~V@88-73-ftth.on.nl] has joined #wesnoth-dev
20131204 17:42:25-!- {V} [~V@88-73-ftth.on.nl] has quit [Disconnected by services]
20131204 17:42:33-!- soifb is now known as {V}
20131204 17:42:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131204 17:44:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131204 17:49:06-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131204 18:00:18-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has joined #wesnoth-dev
20131204 18:01:42-!- prkc [~negusnyul@catv-188-142-168-46.catv.broadband.hu] has left #wesnoth-dev []
20131204 18:08:29-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has joined #wesnoth-dev
20131204 18:20:41-!- Kexoth [~kex@89.205.75.19] has quit [Remote host closed the connection]
20131204 18:21:02-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131204 18:21:04-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20131204 18:23:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131204 18:27:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131204 18:45:22-!- Chusslove [~Chusslove@unaffiliated/chusslove] has quit []
20131204 18:50:27-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20131204 19:16:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131204 19:30:32< irker926> wesnoth: Bär Halberkamp wesnoth-old:master ffe06509c969 / data/tools/wmllint: Fixed wmllint with my latest commits http://git.io/kZn5IQ
20131204 19:32:06< shadowm> fabi_: Do you have a patch to teach wmllint about the help_topic_text attribute (?) in your queue already?
20131204 19:43:53< shadowm> fabi_: The reason I'm asking: http://pastebin.com/aGG4DG2n  The solution is in fact a trivial addition to wmllint's translatables tuple: http://pastebin.com/zHxZ5MWY  No idea if you want me to commit it or you'd prefer to do so yourself.
20131204 19:44:12< fabi_> shadowm: Please commit it :-)
20131204 19:44:46< shadowm> And naturally I can't find help_topic_text in the full log of the master branch.
20131204 19:45:34< shadowm> It seesm to have been introduced in a28cfc3fd96264c411453307d536b48435e5bdeb according to the diffs.
20131204 19:45:38< shadowm> seems
20131204 19:46:07< shadowm> This is why more informative commit messages would be highly appreciated.
20131204 19:47:58< shadowm> fabi_: Is there any specific reason why the attribute name is that instead of the more common 'description'?
20131204 19:49:20< fabi_> shadowm: Description is old and may not contain help pango markup.
20131204 19:49:35< fabi_> I mean help markup.
20131204 19:49:41< shadowm> Actually, it may.
20131204 19:50:03< fabi_> Description may include pango markup.
20131204 19:50:07< fabi_> But not help markup.
20131204 19:50:09< shadowm> Wesnoth generally doesn't care about what a string attribute contains until it's time to pass it to some rendering pipeline or something.
20131204 19:50:30< shadowm> For example, it is valid to include help markup in [unit_type] description and it will display as expected in the help system.
20131204 19:50:40< shadowm> It just won't do for the sidebar tooltips.
20131204 19:53:08< fabi_> Well, description is already in use for the sidebar tooltips and there the help markup is invalid.
20131204 19:53:20< fabi_> Thus I chosed another name for the attribute.
20131204 19:54:15< shadowm> It's also used for the help system as I said above.
20131204 19:55:35< shadowm> Nobody has seen a need to have different strings for the help system and Pango contexts yet I guess, but I personally think we could use a function to strip help markup from unit descriptions when rendering sidebar tooltips (which use Pango).
20131204 19:56:34< shadowm> Then again, there usually isn't much use for help markup in unit descriptions. I used to have a unit with some of that because it has an ability that's too complicated for the Special Notes part of the description.
20131204 19:57:23< shadowm> But since that caused problems after Pango was deployed on the sidebar tooltips on 1.9.x or so, I ended up dropping the help markup from Special Notes.
20131204 20:02:08< irker926> wesnoth: Ignacio R. Morelle wesnoth-old:master b0373525b37f / data/tools/wmllint: wmllint: Recognize help_topic_text as a translatable attribute http://git.io/7btPfg
20131204 20:03:24< shadowm> fabi_: ^
20131204 20:03:41< fabi_> shadowm: Maybe the help system can learn pango?
20131204 20:03:45< shadowm> Did you test the last batch of fixes to the editor ToD configuration dialog, by the way?
20131204 20:04:20< fabi_> shadowm: At the moment I am still concerned that the test target is not linking.
20131204 20:04:53< fabi_> broken test system is a bad situation.
20131204 20:04:54< shadowm> I am not too concerned about it since the problem seemed unsolvable when I first hit it (although it was on the main target rather than the test suite).
20131204 20:05:42< shadowm> I mean, is there anyone here who makes sure to run and inspect the test target's output regularly? I build it every time I build the rest, but that's as far as it goes.
20131204 20:06:33< fabi_> Well, a proper test system is a good thing to have. I hate myself for not taking more care about it.
20131204 20:07:05< fabi_> I wonder if we can have some unit tests.
20131204 20:08:13< fabi_> Still, it makes me nervous that I don't get why the linking of the test target fails.
20131204 20:11:14< fabi_> shadowm: Ah yes, the tod schedule creator dialog looks much better now, thank you. I wonder if it isn't the better soluiton to just update only after the slider drag ended. 
20131204 20:11:30< shadowm> No idea if GUI2 allows doing that somehow.
20131204 20:12:56< fabi_> It is done in other parts of the program by using the left_mouse_up event.
20131204 20:13:10< fabi_> And poll the state of the slider at that moment.
20131204 20:21:28< shadowm> That seems like a lot of (low level) work for such a simple thing.
20131204 20:34:34-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20131204 20:35:12< shadowm> OK, I *think* I figured out the test target linking issue.
20131204 20:37:00< shadowm> The current link order for the object collections for the test target is: libwesnoth_extras.a liblua.a libwesnoth_core.a libwesnoth_sdl.a libwesnoth.a libwesnoth_extras.a liblua.a libtest_utils.a
20131204 20:37:11< shadowm> For the main (wesnoth) target it is: libwesnoth_extras.a lua/liblua.a libwesnoth_core.a libwesnoth_sdl.a libwesnoth.a
20131204 20:37:33< shadowm> *lua/liblua.a in the first line above.
20131204 20:38:00< shadowm> The test target links correctly if the order for it is changed to libtest_utils.a libwesnoth_extras.a lua/liblua.a libwesnoth_core.a libwesnoth_sdl.a libwesnoth.a.
20131204 20:38:14< shadowm> loonycyborg, fabi_: ^ (no, I have no idea what's going on)
20131204 20:38:25-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has joined #wesnoth-dev
20131204 20:39:23-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has joined #wesnoth-dev
20131204 20:39:58< shadowm> fabi_: Also, the build with cmake is broken.
20131204 20:39:59-!- Kostic [~marko@85.202.113.22] has quit [Quit: Kostic]
20131204 20:40:27< shadowm> > CMake Error at src/CMakeLists.txt:933 (add_library): Cannot find source file: hotkey_preferences_display.cpp
20131204 20:41:12< shadowm> Weird that no-one has complained about it yet.
20131204 20:47:02-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection timed out]
20131204 21:00:14-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20131204 21:05:34-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20131204 21:10:27-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has joined #wesnoth-dev
20131204 21:11:23-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20131204 21:13:39< Ivanovic> fabi_: building with cmake on git-master is broken
20131204 21:14:15< Ivanovic> http://pastebin.com/zn264sxD
20131204 21:14:49< shadowm> Yes, that's exactly what I just said.
20131204 21:15:56< Ivanovic> ah, okay
20131204 21:18:46< irker926> wesnoth: Bär Halberkamp wesnoth-old:master 22dd990a45b7 / data/core/macros/animation-utils.cfg: Fixed the FIRE_BURST_SMALL macro only showing the last frame http://git.io/DjyPgw
20131204 21:18:54< Ivanovic> okay, for cmake it is a plain typo / missing change
20131204 21:22:14-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20131204 21:23:12< irker926> wesnoth: Bär Halberkamp wesnoth-old:master 5fd6eb5bbe18 / data/core/macros/animation-utils.cfg: Revert "Fixed the FIRE_BURST_SMALL macro only showing the last frame" http://git.io/BUBkxA
20131204 21:23:27< Ivanovic> with the fixed file reference it built nicely and installed using cmake
20131204 21:23:43< bumbadadabum> The fix worked, but there seems to be a bug in the engine...
20131204 21:23:45< irker926> wesnoth: Nils Kneuper wesnoth-old:master 82a190be5f25 / src/CMakeLists.txt: fixed compilation be referencing the correct file http://git.io/roG8kw
20131204 21:23:51< bumbadadabum> wesbot: seen Coffee_irc
20131204 21:23:51< wesbot> bumbadadabum: The person with the nick Coffee_irc 3d 9h ago they left with the message: Quit: Konversation terminated!
20131204 21:24:06-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has joined #wesnoth-dev
20131204 21:24:13< bumbadadabum> Coffee, when you get online again, can you look into this?
20131204 21:24:25< bumbadadabum> (if you read logs)
20131204 21:28:01-!- stikonas_ [~gentoo@46.246.45.211] has joined #wesnoth-dev
20131204 21:28:01-!- stikonas_ [~gentoo@46.246.45.211] has quit [Changing host]
20131204 21:28:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131204 21:28:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 272 seconds]
20131204 21:29:33< shadowm> The test suite links with cmake, so only the scons recipe needs a fix.
20131204 21:31:27-!- gfgtdf [~chatzilla@f054172177.adsl.alicedsl.de] has joined #wesnoth-dev
20131204 21:31:42-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20131204 21:36:33< gfgtdf> mattsc: are you online ?
20131204 21:38:12< mattsc> gfgtdf: yes, to some extent
20131204 21:39:42< LordBob_> fabi_ : my workshop is over, so I'm back again with some time for our projects. I'll be online in the evenings if you need to catch me.
20131204 21:40:08< Ivanovic> LordBob_: do you plan to come to brussels for fosdem?
20131204 21:40:26< Ivanovic> that would be at the beginning of february (first saturday+sunday in february)
20131204 21:40:55< LordBob_> Hmm, that could be a good idea.
20131204 21:41:17< LordBob_> Gotta see if there's an easy/not too expensive way to travel there from Bordeaux
20131204 21:47:20-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20131204 21:51:55-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Read error: Connection reset by peer]
20131204 21:52:02< gfgtdf> mattsc: about bug 21290, have you tested what happends if you recruit a traitless unit like wose and then undo the recruit?
20131204 21:52:43-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20131204 21:53:59-!- TooLmaN [~TooLmaN@mx1.thomsonplastics.com] has quit [Quit: Off to save the world!]
20131204 21:56:16< mattsc> gfgtdf: no, I have not.  What's the problem?
20131204 21:58:43< gfgtdf> mattsc: i haven't tested (thats why i asked), but i thought after your patch recuiting a unit changes the random  even if you unit has no traits, and it could therefore cause oos if you undo it.
20131204 21:59:48< mattsc> gfgtdf: ah, good point...  That wouldn't be good.
20131204 22:04:18< LordBob_> Ivanovic: turns out there's a direct airline and tickets aren't too expensive. I need to discuss this with my lady  and see if we can make the best out of it, but there's a chance you'll be seeing me.
20131204 22:05:35< elias> my flight is kinda expensive, but that's mostly since I go from a really tiny local one
20131204 22:05:51< elias> and no direct flights for me unfortunately :/
20131204 22:06:10< LordBob_> where do you fly from, out of curiosity ?
20131204 22:06:24-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 246 seconds]
20131204 22:09:32< elias> Salzburg
20131204 22:10:39-!- EdB [~edb@ip-153.net-89-2-218.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20131204 22:10:46< mattsc> gfgtdf: indeed it causes OOS errors, but one that I did not expect.  In the replay, both the "undone" Wose and the unit hired afterward (also a Wose in my case) are there.
20131204 22:12:23< gfgtdf> mattsc: oh :s,  seems strange to me, the question is wether that was also before your commit.
20131204 22:13:05< gfgtdf> mattsc: i itnhk 1.11.7 was before your commit ?
20131204 22:13:08< gfgtdf> think*
20131204 22:13:11< mattsc> gfgtdf: it was not the case for 1.11.7.  I didn't have time to change which commit caused this, but mine has a high chance of being the culprit.
20131204 22:13:11-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 260 seconds]
20131204 22:13:22< mattsc> s/change/check
20131204 22:14:03< mattsc> Recommendations on how to deal with this?  Is it acceptable to disallow undoing recruiting for units without traits also?  My guess is no?
20131204 22:15:10< gfgtdf> mattsc: hm i personaly have never undone a recruit, but idk.
20131204 22:15:44< gfgtdf> mattsc: in any case it is better than a guaranteed oos
20131204 22:16:07< gfgtdf> mattsc: to fix this problem we need to understand this problem
20131204 22:17:00-!- Chusslove [~Chusslove@brsg-4dbbb032.pool.mediaWays.net] has joined #wesnoth-dev
20131204 22:17:00-!- Chusslove [~Chusslove@brsg-4dbbb032.pool.mediaWays.net] has quit [Changing host]
20131204 22:17:00-!- Chusslove [~Chusslove@unaffiliated/chusslove] has joined #wesnoth-dev
20131204 22:18:26< mattsc> gfgtdf: not necessarily.  We can _prevent_ the problem by not allowing undo.  If that is not an acceptable option, then we need to look into fixing it.  From what I have seen in the code, both should be possible.
20131204 22:19:40< gfgtdf> mattsc: just tested: i got that problem also on 1.11.7
20131204 22:19:42< mattsc> Either way, I don't have time to deal with it right now.  I'd like to hear people's opinions on which course of actions should be taken, then I'll look into doing that.
20131204 22:19:48< mattsc> gfgtdf: you did?
20131204 22:19:52< gfgtdf> yes
20131204 22:20:06< mattsc> So maybe it's not my fault?  :P
20131204 22:20:27< mattsc> Well, I assume we'd still get an OOS error due to my commit, but a different one.
20131204 22:20:47< gfgtdf> exactly like you descibed: 1)recruiting a wose 2)undo 3) recruitng annother wose.
20131204 22:20:49< gfgtdf> yes
20131204 22:23:49< mattsc> gfgtdf: I have to do something else for while.  I'll stay logged in though and might have time for brief comments.  But even if not, I'll read up on things later if you find something else.  Thanks for pointing this out!
20131204 22:31:24< mattsc> gfgtdf: okay, I did one more quick test and I do not get the problem in 1.11.7 - in a Freelands local MP game.  (and now I'm off for real)
20131204 22:32:18< gfgtdf> mattsc: hm i used a sp game, i
20131204 22:32:26< gfgtdf> 'll test the mp variant too
20131204 22:36:25< gfgtdf> i tested and got the error on 1.11.7 too played a 2p map rebels vs rebels, the same sequence
20131204 22:37:00< gfgtdf> gfgtdf: you did start 2 wesnoth clients no ?
20131204 22:38:15< gfgtdf> mattsc: you did start 2 wesnoth clients no ?
20131204 22:38:58< mattsc> gfgtdf: no, I did a local game on one client, saved the replay, then watched it again.
20131204 22:41:23< gfgtdf> mattsc: still, i get the error in that situation too. 2p freelands rebels vs rebels.
20131204 22:42:22< mattsc> gfgtdf: could you just describe again what "the error" is, so that I'm sure we're talking about the same thing?
20131204 22:43:22< gfgtdf> mattsc: both woses appear in the replay although i have undone one of them in the real game.
20131204 22:44:04< mattsc> gfgtdf: okay, that's what I was talking about as well.  Strange, I do not see that in 1.11.7.
20131204 22:46:09< gfgtdf> mattsc: hm i noticed i get an error message even if i 1)start the game 2) recruit a mage 3) save the game 4)watch the replay
20131204 22:46:20-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131204 22:47:01< gfgtdf> mattsc: the 1.11.7 versions for all operating sytems are based on the same commit right ?
20131204 22:47:12< mattsc> They should be.
20131204 22:48:27< shadowm> LordBob_: Hi.
20131204 22:49:10< shadowm> gfgtdf: Binary packages may include additional patches if deemed necessary by the respective packagers (usually only for severe bugs that weren't found before releasing).
20131204 22:49:25-!- gfgtdf_ [~chatzilla@f054166194.adsl.alicedsl.de] has joined #wesnoth-dev
20131204 22:49:29< LordBob_> Hi Shadowm
20131204 22:51:00< shadowm> LordBob_: I saw that you replaced the in-game status bar village icon some time ago. It just so happens that ever since I've been around, the wesnoth.org site icon has matched the in-game village icon. Did you have any intentions to replace that too?
20131204 22:51:13-!- gfgtdf [~chatzilla@f054172177.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20131204 22:51:20-!- gfgtdf_ is now known as gfgtdf
20131204 22:52:25< LordBob_> Shadowm:  I wouldn't mind it, as our homepage icon isn't getting any younger
20131204 22:53:24< shadowm> I also noticed that the new in-game icon has transparent pixels within the colored region and I wasn't sure if this was intentional or not.
20131204 22:53:37< LordBob_> Plus, it would be a fitting side bonus for when we release the graphically-revamped UI
20131204 22:53:49< shadowm> In-game it's not terribly relevant because the background (with the default theme, anyway) is always dark, but that's not the case with web browsers.
20131204 22:54:16< LordBob_> Let me check the file
20131204 22:56:36< shadowm> Also, are there versions larger than 16x16? It's not necessary per se, but IIRC some browsers may want to use larger icons than the standard 16x16.
20131204 22:59:32< LordBob_> So yeah, there are some transparent pixels that I included thinking that the icon would be used only on the dark background of the status boxes
20131204 22:59:43< LordBob_> But fixing that is easy enough
20131204 23:00:33< LordBob_> As for larger icons, working on 16x16 is quite frustrating and I've been itching to make a nicer version, so it shouldn't be a problem :)
20131204 23:07:31-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has quit [Quit: Turuk]
20131204 23:09:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131204 23:16:01-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20131204 23:20:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20131204 23:24:44< gfgtdf> mattsc: i could even reproduce that bug on 11.2 
20131204 23:25:46< gfgtdf> mattsc: i created a new userdata folder so it cannot be caused by addons 
20131204 23:26:12< shadowm> There is no 11.2 version.
20131204 23:27:08< gfgtdf> 1.11.2, i think mattsc knows what i meant.
20131204 23:29:48< mattsc> gfgtdf: I've tried a couple more times and I cannot reproduce it even on 1.11.7.  I don't know what's going on.
20131204 23:29:55-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has quit [Quit: night]
20131204 23:32:59< shadowm> It's a terrible infectious habit nevertheless and I intend to stop it before it spreads further.
20131204 23:33:16-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: Computer's napping]
20131204 23:41:47< justinzane_> fabi_: Done any more looking at SDL2?
20131204 23:43:01< irker926> wesnoth: Ignacio R. Morelle wesnoth-old:master 0fbd864748ff / src/SConscript: scons: Fix test suite linking step after the hotkey refactoring changes http://git.io/jU9B_w
20131204 23:43:11< shadowm> fabi_: ^
20131204 23:43:33< gfgtdf> mattsc: i never noticed this bug before, and now i cannot even open a single file without getting an error, i really think people would have noticed a bug with this impact, so i think only i have this error.
20131204 23:43:40< shadowm> You may want to follow the link and read the full commit message.
20131204 23:43:42< justinzane_> fabi_: I've gotten a pretty solid grasp of the uses of CIEL*a*b* transforms, and that has led me to wonder about the future use of SDL_Surface vs SDL_Texture
20131204 23:45:56< justinzane_> Currently base "sprites" are re-processed again and again, blurring, compsiting, etc. I'm wondering if there should be a "sprite cache" that allows reuse of Surfaces/Textures instead of going through the whole pipeline for each use?
20131204 23:46:15< shadowm> That is the case already.
20131204 23:48:11< justinzane_> shadowm: Re my comment?
20131204 23:49:03< shadowm> Yes.
20131204 23:50:23< justinzane_> Unless lots has changed in the past month or so, there is still a **lot** of repeated calles to "blur" and other similar functions with the same data.
20131204 23:50:39-!- mjs-de [~mjs-de@f049013167.adsl.alicedsl.de] has quit [Remote host closed the connection]
20131204 23:51:21< shadowm> Those presumably could be converted to use image::get_image() with image path functions as long as they aren't going to pollute the cache with lots of unnecessary rarely used entries.
20131204 23:51:23< justinzane_> I'm thinking about a once-and-only-once cache, and whether it is even rational.
20131204 23:52:21< shadowm> Because image::get_image() and image path functions are what's exposed to WML coders for most things dealing with images, and get_image() transparently accesses the image cache.
20131204 23:52:51< gfgtdf> mattsc: ok i think i found a was to reproduce the other oos: 1)play 2p freelands with rebels against the ai, 2)load the first turn autosave 3)recruit a bowman 4) save the game 5) watch the replay from (4).
20131204 23:54:52< justinzane_> shadowm: Don't know if this is something you have looked at, but what about the transition to using SDL2/SDL_Texture as the primary image vehicle instead of SDL2/SDL_Surface?
20131204 23:55:53< justinzane_> My impression is that SDL2 is geared to shifting as much as possible from the CPU/System RAM to GPU/Video RAM (where such exists).
20131204 23:56:05< shadowm> justinzane_: I have no clue about SDL 2 or SDL in general, unfortunately.
20131204 23:57:48-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev
20131204 23:58:04< gfgtdf> mattsc: and for the bug you pointed out: it seems liek you have to start wenoth  in debug mode for that,
20131204 23:59:24< justinzane_> That's Ok. Just trying to understand the direction that the SDL2 project is moving in so that I have some idea of what will be well supported in the future.
--- Log closed Thu Dec 05 00:00:11 2013