--- Log opened Sat Dec 21 00:00:50 2013
20131221 00:02:11< anonymissimus> yes, affects 1.10
20131221 00:07:34-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 00:07:51-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 00:12:24< anonymissimus> shadowm: you were asking some gui testing question, but actually, I don't understand it
20131221 00:16:35< anonymissimus> shadowm: "20131216 23:51:12< shadowm> I want to know if the HttT description is rendered with one or two linebreaks between the description and the parenthetical difficulty/length line for you.
20131221 00:16:37< anonymissimus> 20131216 23:51:18< shadowm> On Windows."
20131221 00:16:55< anonymissimus> the gui in the campaigns dialog ?
20131221 00:18:28< shadowm> anonymissimus: Uh, yes, there is a way to rebuild a single project.
20131221 00:18:43< anonymissimus> shadowm: okay, it looks like a single line break, that is, no empty line between description and difficulty/lenght
20131221 00:18:56< shadowm> Right click on wesnothd, select build. Of course that's going to build a lot of files shared between both projects... because they are explicitly listed in both projects.
20131221 00:19:04< anonymissimus> win xp, MinGw binary
20131221 00:19:18< shadowm> anonymissimus: Okay, yeah, that's what iI wanted to know.
20131221 00:19:37< shadowm> It's a bug and I have no idea how it even exists.
20131221 00:19:57< anonymissimus> ah so there should be an empty line ?
20131221 00:20:05< shadowm> Unless this is also related to Cairo's deficiencies with ClearType.
20131221 00:20:45< anonymissimus> the _main contains an empty line, so, yes
20131221 00:21:02< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/httt-desc-linux.png
20131221 00:21:08< zookeeper> fabi_, let me know if you need any other labels in there: http://imagebin.org/283196 i'll still position/rotate/bend them right, just checking if there's anything missing.
20131221 00:25:23< shadowm> Coffee_irc: The first post in that ML thread proposed December 21st for the release.
20131221 00:26:11< Coffee_irc> shadowm: yeah, but here in Australia it is a bit earlier than in Europe from which I assume the timing is?
20131221 00:26:17 * shadowm finds the whole situation in that thread hilarious.
20131221 00:26:55< Coffee_irc> if it is released late Saturday it would suit me as I would have today to get this (admittedly minor) thing in
20131221 00:27:18< anonymissimus> fabi_: here is a diff working around your end iterator derefs: http://pastebin.com/NuV2dLm8
20131221 00:27:24< shadowm> Coffee_irc: Ivanovic lives in Germany, so yeah.
20131221 00:27:57< anonymissimus> (I don't know whether it's an error if the find doesn't succeed)
20131221 00:28:30< shadowm> Coffee_irc: UTC+01
20131221 00:28:41-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 246 seconds]
20131221 00:29:30< anonymissimus> so, wesnoth launches into test scenario again
20131221 00:29:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131221 00:30:20< anonymissimus> bit of annoying I need to do these checks at least once a month or so or the situation gets constantly worse
20131221 00:31:07< fabi_> lipkab: I don't know yet. Properly not.
20131221 00:31:26< anonymissimus> (there are a few other MSVC users aren't there)
20131221 00:32:11< irker935> wesnoth: Boldizsár Lipka wesnoth-old:master 94ba796055d0 / src/ (3 files): Enable filtering by number of players. http://git.io/PYWPxQ
20131221 00:32:13< irker935> wesnoth: Boldizsár Lipka wesnoth-old:master 4676c005f1a5 / src/multiplayer_create_engine.cpp: Initialize level metadata when adding the levels. http://git.io/m7LDiA
20131221 00:32:15< irker935> wesnoth: Boldizsár Lipka wesnoth-old:master f59e0aaf7895 / src/ (multiplayer_configure.cpp multiplayer_create.cpp): Relabel buttons that switch between mp screens. http://git.io/53uCeg
20131221 00:32:31 * lipkab is ready for the freeze!
20131221 00:33:00< anonymissimus> fabi_: I hope you deal with it right now ?
20131221 00:33:10< lipkab> Oh well.
20131221 00:33:20< lipkab> I forgot the changelog again.
20131221 00:34:03< lipkab> Why do we need a changelog anyway?
20131221 00:34:30< Coffee_irc> lipkab: so others know what is changed :P
20131221 00:35:02< Coffee_irc> I assume it would be good for Ivanovic to see how much is being changed for each version too
20131221 00:35:31< Coffee_irc> it seems to be slowing down (to me anyway)
20131221 00:35:46< anonymissimus> shadowm: so, you want me to backport that fix to 1.10 ?
20131221 00:37:03< shadowm> Why we need a changelog: 1) Because you people often write subpar commit messages; 2) And UMC authors can't use Git anyway; 3) Plus release notes don't go into a lot of detail about that kind of thing; 4) And neither does the wiki.
20131221 00:37:08-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20131221 00:38:06-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131221 00:38:10< Coffee_irc> shadowm: my commit messages are always super-sub-par thank you very much
20131221 00:39:51< shadowm> anonymissimus: If you want...
20131221 00:40:08< shadowm> I tried applying it myself but patch failed.
20131221 00:40:36-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131221 00:40:44< zookeeper> there can be a gazillion commits related to what's essentially just one change. shifting through hundreds of commit messages in an attempt to get an idea of what sort of things have changed would be immensely awkward.
20131221 00:40:56< shadowm> It really depends on whether we can consider 1.10 to have reached EOL already or not. The problem with this kind of project is that that kind of thing is never officially decided upon.
20131221 00:41:07< AI0867> the changelog is essentially a summary
20131221 00:42:39-!- LordBob_ [~LordBob_@che33-7-78-232-36-126.fbx.proxad.net] has quit [Quit: LordBob_]
20131221 00:44:11-!- LordBob_ [~LordBob_@che33-7-78-232-36-126.fbx.proxad.net] has joined #wesnoth-dev
20131221 00:44:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20131221 00:46:07< anonymissimus> shadowm: well, I'm using self-build 1.10 to play, I'll do it
20131221 00:46:16< irker935> wesnoth: Boldizsár Lipka wesnoth-old:master 04bdca51b7fa / changelog: Update the changelog. http://git.io/2uWHhw
20131221 00:47:28< shadowm> So I want to use the config_writer::compressor enum type elsewhere, but I don't want to include serialization/binary_or_text.hpp for that purpose. Ideas?
20131221 00:48:08-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev
20131221 00:48:55< shadowm> Here's the simplest idea: relocate config_writer::compressor to a separate file and amend any references to it accordingly.
20131221 00:49:13< lipkab> A different guy at a different project told me that changelogs were in fact absolutely useless to them and the mania of writing them rooted in the GPL.
20131221 00:49:21< shadowm> Okay actually I don't know why I'm even asking here.
20131221 00:49:29< lipkab> But yeah, different project.
20131221 00:49:31< shadowm> The type is used in about two lines.
20131221 00:50:04< shadowm> lipkab: Different audience, too?
20131221 00:50:17< shadowm> lipkab: Also, did you see my email to the ML thread about the add-ons section in the help?
20131221 00:51:14< anonymissimus> fabi_: could you please be so kind to say whether I bothered you enough to make you fix it, or do I need to assign a bug report ?
20131221 00:52:00< anonymissimus> I'm always bit worried you overlook IRC bug reports
20131221 00:52:30-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 00:52:41< lipkab> shadowm: Oh right, I did.
20131221 00:52:46-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 00:53:46< lipkab> shadowm: Can you please point me to where these help texts are located?
20131221 00:54:00< shadowm> lipkab: data/core/help.cfg
20131221 00:54:07< lipkab> Thanks.
20131221 01:06:15-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 01:06:29-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 01:09:15< mattsc> Personally, as a UMC author, I find the Wesnoth changelog extremely useful.
20131221 01:09:34< irker935> wesnoth: Boldizsár Lipka wesnoth-old:master ec7516f366f9 / data/core/help.cfg: Some text about mp mods in the help. http://git.io/6DFk9g
20131221 01:09:36 * shadowm glares at AI0867.
20131221 01:09:50< lipkab> shadowm: ^^
20131221 01:11:06< lipkab> Now that was way enough of Wesnoth coding for today.
20131221 01:11:17< lipkab> Bye everyone!
20131221 01:11:21-!- lipkab [~the_new_l@apn-94-44-230-43.vodafone.hu] has quit [Quit: Távozom]
20131221 01:11:21-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 01:11:36-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 01:12:40< shadowm> If I see just another ? ".bz2" : ".gz" sequence I'm going to explode.
20131221 01:19:38< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/wesnoth-1.11.8-save-game-format-selection.png
20131221 01:23:35< AI0867> ooh, features
20131221 01:24:12< Coffee_irc> bz2gzbz2gzbz2gzbz2gz
20131221 01:24:28 * Coffee_irc apologizes for a cat that must have walked on my keyboard
20131221 01:25:30< shadowm> Likely story.
20131221 01:25:38< Coffee_irc> :)
20131221 01:26:47< mattsc> Fortunately, I am far enough away that I won't be able to hear the bang.  :P
20131221 01:28:04-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 01:29:45< shadowm> Well, he forgot the ?: operator and dots and quotes.
20131221 01:30:31< bumbadadabum> Is there a mention of the mainline campaign updates in the release notes btw?
20131221 01:30:45-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 01:31:00-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 01:31:04< shadowm> What mainline campaign updates?
20131221 01:31:13< bumbadadabum> bugfixes and things
20131221 01:31:28< bumbadadabum> I think LoW, SotBE, EI and HTTT
20131221 01:31:35< bumbadadabum> and the new wose shaman in DM
20131221 01:31:40< bumbadadabum> I think enough to mention it
20131221 01:32:02< shadowm> I see you people have only added one entry to the release notes.
20131221 01:32:24< mattsc> bumbadadabum: https://github.com/wesnoth/wesnoth-old/blob/master/RELEASE_NOTES
20131221 01:32:31< bumbadadabum> I see
20131221 01:32:35-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 250 seconds]
20131221 01:33:00< shadowm> Just noting, I am the one whose work is being made harder by this.
20131221 01:33:46< shadowm> I'm giving you all 24 hours after the tagging to sort that out or there will be bans otherwise.
20131221 01:33:55< shadowm> That is assuming there'll be any tagging.
20131221 01:34:02< bumbadadabum> I'll do it tomorrow morning
20131221 01:34:17< shadowm> fabi: This also applies to you.
20131221 01:34:37< bumbadadabum> do you think I should group the minor changes under one section?
20131221 01:34:53< shadowm> Think of it this way: you are selling this product to your audience.
20131221 01:34:55< bumbadadabum> I don't have any experience writing release notes though
20131221 01:35:01< bumbadadabum> or selling anything
20131221 01:35:17< shadowm> You need to convince users that downloading 400 MiB or so is going to be worth it.
20131221 01:36:18< shadowm> Even better, pretend you are convincing me (since as you all know I can't download big crap freely).
20131221 01:36:34< bumbadadabum> but you're doing it anyway
20131221 01:37:20< Coffee_irc> shadowm: release notes for 1.11.8 -> miscellaneous: Wesnoth now comes with a free nonalcoholic beer?
20131221 01:37:22< shadowm> This should prove more inspirational than a less tangible marketing scenario.
20131221 01:37:37< shadowm> bumbadadabum: 'm doing what?
20131221 01:37:55< bumbadadabum> shadowm: downloading
20131221 01:37:58< shadowm> (Incidentally, something appears to be updating itself in the background and it's killing my ssh link.)
20131221 01:38:28< mattsc> bumbadadabum: Put anything significant into the changelog.  Put anything a player will notice into players_changelog.  Put anything that makes it worth downloading 400 MiB (for the player, not the UMC creator) into the Release Notes.  That's (roughly) what I go by.
20131221 01:38:38< bumbadadabum> ok
20131221 01:39:10< mattsc> Coffee_irc: free kitten with each download.
20131221 01:39:15< shadowm> No, the last one is also for UMC creators at a larger scale.
20131221 01:39:48< bumbadadabum> "There have been a ton of bugfixes and updates to many mainline campaigns, including improved sprites and new features"
20131221 01:39:51< mattsc> shadowm: yes, but I expect UMC authors to read the changelog and decide based on that
20131221 01:39:53< bumbadadabum> something like this?
20131221 01:40:07< shadowm> For example, if Wesnoth suddenly gained support for lolcode? Release notes.
20131221 01:40:20< shadowm> New [make_coffee] WML tag? Changelog only.
20131221 01:40:40< mattsc> shadowm: sure, agreed
20131221 01:41:24< mattsc> bumbadadabum: "a ton of" doesn't sound "professional" enough for a serious advertisement.  Also, being slightly more specific would be good.
20131221 01:42:04< bumbadadabum> Eh, I'll work on it tomorrow
20131221 01:42:11< bumbadadabum> it's almost 3 AM and I need to sleep
20131221 01:42:35< mattsc> Sounds good, I'm off for dinner and beer anyway for a while.  Bonne nuit.
20131221 01:42:47< bumbadadabum> have fun
20131221 01:43:18< shadowm> 24 hours after tagging, tops.
20131221 01:48:47-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20131221 01:52:07-!- Alarantalara [~Adium@192-0-128-11.cpe.teksavvy.com] has joined #wesnoth-dev
20131221 01:53:55< shadowm> Hi Alarantalara .
20131221 01:54:15-!- LordBob_ [~LordBob_@che33-7-78-232-36-126.fbx.proxad.net] has quit [Quit: LordBob_]
20131221 01:54:28< Alarantalara> Hello
20131221 01:54:46< shadowm> Alarantalara: mattsc told me that you were aware of the issues with color cursors on OS X and knew the cause.
20131221 01:55:15< Alarantalara> I'm definitely aware of the issue, though I have no clear idea as to the cause
20131221 01:55:25< Alarantalara> or if I did, it was long enough ago that I have forgatten
20131221 01:55:30< Alarantalara> *forgotten
20131221 01:55:49< shadowm> From what he recalled it seemed to have something to do with SDL.
20131221 01:56:27< shadowm> I looked at the code and saw nothing that should be particularly CPU intensive as to cause additional lag aside from a few blits there and there.
20131221 01:56:43-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 01:56:50< shadowm> Unless there's an issue with the calls to get the current mouse position and stuff.
20131221 01:56:59-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 01:58:46< Alarantalara> There are several issues. There is an offset cursor problem that is unrelated to color cursors that is related to SDL 1.2 not having support for Apple's implementation of high pixel density displays
20131221 01:59:16< Alarantalara> but the slow cursors have existed since at least 1.6
20131221 01:59:36< Alarantalara> with respect to color
20131221 01:59:58< shadowm> Yeah, they aren't particularly fast on Linux either, but not so slow as to lag the whole thing down.
20131221 02:00:23< shadowm> In any case, I hid and disabled the feature on OS X for the next release.
20131221 02:00:48< Alarantalara> It could well be related to bit order in colours
20131221 02:01:12< Alarantalara> Apple does not use the same order as the SDL neutral surface
20131221 02:01:37< Alarantalara> So you don't get to blit directly on OS X
20131221 02:02:02-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 264 seconds]
20131221 02:04:17< shadowm> So that can't possibly be fixed in Wesnoth, right?
20131221 02:04:20< Alarantalara> I ended up patching SDL at one point to reduce the number of times the colours were reordered so that the map would scroll
20131221 02:05:25< Alarantalara> It might need to be fixed partly in Wesnoth and partly in SDL
20131221 02:05:49< Alarantalara> I haven't looked at it closely enough to know where the exact fix would be
20131221 02:07:11< shadowm> So, besides missing fullscreen support and the color cursors issue we're sweeping under the rug, what other issues are there that are OS X-specific?
20131221 02:08:19< Alarantalara> Map rendering is extremely CPU intensive (for the reason I mentioned above), though it doesn't tend to slow things down
20131221 02:09:19< Alarantalara> Sometimes there are colour issues because of the different colour order, but I do't think any of those exist at the moment
20131221 02:10:33< Alarantalara> Changing languages doesn't work the second time. You have to restart Wesnoth to do it
20131221 02:10:52< Alarantalara> and pnago seems to have some rendering problems
20131221 02:11:12< Alarantalara> though they manifest only as error messages in the console and don't affect the game display
20131221 02:11:29< Alarantalara> I think that's it
20131221 02:11:50< shadowm> Cairo/Pango is a mess on Windows too.
20131221 02:12:17< shadowm> And the rendering is actually awful (with ClearType) and double line breaks are rendered as single line breaks for some reason.
20131221 02:15:57< mattsc> shadowm: do you get a double line break if you put a space in the empty line?
20131221 02:16:32< mattsc> Because that's the only way how I seem to be able to get a double line break on my system.
20131221 02:18:17< shadowm> mattsc: I don't know, I don't have the Windows VM running right now.
20131221 02:18:20< mattsc> But then, I have my editor set to eliminate trailing spaces, so it's kind of pointless ...
20131221 02:18:35< shadowm> I'll check after I'm done with this commit.
20131221 02:37:21< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master f1b4d2dc45c1 / src/game_preferences_display.cpp: preferences: Add description and name_short attributes to combo options http://git.io/5Bw6XA
20131221 02:37:24< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 553c56b2bd97 / / (15 files in 4 dirs): preferences: Merge compress_saves and bzip2_savegame_compression options http://git.io/0vZhnw
20131221 02:46:13-!- TooLmaN [~TooLmaN@c-174-56-210-230.hsd1.ga.comcast.net] has joined #wesnoth-dev
20131221 02:49:49-!- travis-ci [~travis-ci@ec2-184-72-213-192.compute-1.amazonaws.com] has joined #wesnoth-dev
20131221 02:49:50< travis-ci> [travis-ci] wesnoth/wesnoth-old#1205 (master - 553c56b : Ignacio R. Morelle): The build was broken.
20131221 02:49:50< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/15801896
20131221 02:49:50-!- travis-ci [~travis-ci@ec2-184-72-213-192.compute-1.amazonaws.com] has left #wesnoth-dev []
20131221 02:51:11< shadowm> Uh.
20131221 02:51:27< shadowm> Okay, that's embarassing.
20131221 02:52:06< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 0ca924d7345d / src/serialization/compression.hpp: Add missing serialization/compression.hpp from 553c56b2bd971535117530af6b3cc3644 http://git.io/l16tZQ
20131221 02:57:08-!- rjaguar3 [~rjaguar3@c-67-175-80-212.hsd1.il.comcast.net] has joined #wesnoth-dev
20131221 02:58:17< rjaguar3> So, I think bug 21214 should be fixed by reverting e45df51a.  I'm not sure whether any of that commit can be reintroduced without recreating the bug.
20131221 03:01:44< shadowm> rjaguar3: You should probably ask thunderstruck then.
20131221 03:04:12< rjaguar3> Where do I contact em?  The author of e45df51a was Andrius Silinskas
20131221 03:04:40< shadowm> rjaguar3: That's thunderstruck.
20131221 03:05:45< shadowm> You can find him on IRC depending on the time. I don't know whether he reads the logs.
20131221 03:07:13< shadowm> I've assigned the bug to him in any case.
20131221 03:08:21< shadowm> fabi_: Are you aware of https://gna.org/bugs/index.php?21357 ?
20131221 03:11:31-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev
20131221 03:16:05-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 03:20:38-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20131221 03:20:53-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 03:21:09-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 03:21:33< rjaguar3> Thanks, shadowm.
20131221 03:27:05-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has joined #wesnoth-dev
20131221 03:28:24-!- travis-ci [~travis-ci@ec2-184-72-213-192.compute-1.amazonaws.com] has joined #wesnoth-dev
20131221 03:28:24< travis-ci> [travis-ci] wesnoth/wesnoth-old#1206 (master - 0ca924d : Ignacio R. Morelle): The build was fixed.
20131221 03:28:24< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/15802214
20131221 03:28:24-!- travis-ci [~travis-ci@ec2-184-72-213-192.compute-1.amazonaws.com] has left #wesnoth-dev []
20131221 03:42:32-!- Coffee_irc [~david@ppp118-210-99-69.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20131221 03:42:33-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has quit [Quit: Turuk]
20131221 03:58:46-!- Ivanovic_ [~ivanovic@x2f518c5.dyn.telefonica.de] has joined #wesnoth-dev
20131221 03:58:46-!- Ivanovic_ [~ivanovic@x2f518c5.dyn.telefonica.de] has quit [Changing host]
20131221 03:58:46-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20131221 04:02:32-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 246 seconds]
20131221 04:02:46-!- Ivanovic_ is now known as Ivanovic
20131221 04:09:31-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 04:09:48-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 04:12:53< irker935> wesnoth: anonymissimus wesnoth-old:1.10 81be35a69724 / src/unit_map.hpp: backport fix 6142f5a687f9977ef5f4f33baa394f92dac4c1e6from 1.11 to 1.10 http://git.io/6Z3oxQ
20131221 04:12:55< irker935> wesnoth: Anonymissimus wesnoth-old:1.10 3db2ead9038f / src/ (multiplayer_connect.cpp unit_types.cpp): explicitly convert some config::attribute_value to std::string http://git.io/D1onLA
20131221 04:14:37-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 04:14:51-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 04:14:51-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 11.0/20120312181643]]
20131221 04:15:57-!- TooLmaN [~TooLmaN@c-174-56-210-230.hsd1.ga.comcast.net] has quit [Quit: Off to save the world!]
20131221 04:18:40-!- Alarantalara [~Adium@192-0-128-11.cpe.teksavvy.com] has quit [Quit: Leaving.]
20131221 04:25:17-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20131221 04:28:18-!- Coffee_irc [~david@ppp118-210-99-69.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20131221 04:32:50< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 673b3b08e038 / projectfiles/CodeBlocks/wesnothd.cbp: Revert "remove unused util.*pp from wesnothd cb project" http://git.io/-kTcEg
20131221 04:32:53< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 23bdf9e1d6ba / projectfiles/CodeBlocks/ (wesnoth.cbp wesnothd.cbp): CodeBlocks project update http://git.io/lsgUcA
20131221 04:38:16-!- travis-ci [~travis-ci@ec2-184-72-213-192.compute-1.amazonaws.com] has joined #wesnoth-dev
20131221 04:38:16< travis-ci> [travis-ci] wesnoth/wesnoth-old#1207 (1.10 - 3db2ead : Anonymissimus): The build is still failing.
20131221 04:38:16< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/15803881
20131221 04:38:16-!- travis-ci [~travis-ci@ec2-184-72-213-192.compute-1.amazonaws.com] has left #wesnoth-dev []
20131221 04:39:51-!- iceiceice [~chris@cpe-24-193-85-148.nyc.res.rr.com] has joined #wesnoth-dev
20131221 04:48:20-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 04:48:34-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 04:59:10< irker935> wesnoth: Chris Beck wesnoth-old:master 4dab15daa25e / src/scripting/lua.cpp: New lua metatable "wesnoth.mp_settings". http://git.io/gyf2Pg
20131221 04:59:12< irker935> wesnoth: Chris Beck wesnoth-old:master 0ece1e6b9093 / src/scripting/lua.cpp: enable wesnoth.mp_settings.active_mods and side_users http://git.io/vMUTnQ
20131221 04:59:14< irker935> wesnoth: Chris Beck wesnoth-old:master 93a1de1ac47c / src/scripting/lua.cpp: delete explicit attribute references, write a cfg instead http://git.io/wKyjtg
20131221 04:59:16< irker935> wesnoth: Chris Beck wesnoth-old:master 3e17446b5d15 / src/scripting/lua.cpp: moved mp_settings to be a (conditional) child of game_config, http://git.io/6XfcWw
20131221 04:59:18< irker935> wesnoth: Coffee-- wesnoth-old:master 31e9c4ec0e86 / src/scripting/lua.cpp: Merge pull request #87 from cbeck88/new_lua_hooks http://git.io/4GNVVQ
20131221 05:00:46< Coffee_irc> iceiceice: pull request for read-only era variable access in lua merged
20131221 05:01:14< iceiceice> Coffee_irc: cool, thank you :)
20131221 05:04:12-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 05:08:49-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 250 seconds]
20131221 05:16:31-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 05:16:45-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 05:22:36< fabi_> shadowm, anonymissimusimaus: Yeah, it is Friday/Saturday evening, that means, getting stoned and dance :-)
20131221 05:22:39< irker935> wesnoth: David Mikos wesnoth-old:master 13f8f2d86a7d / changelog: changelog entry for Involution/iceiceice's new mp_settings LUA read-only table. http://git.io/2fOf7A
20131221 05:25:33< shadowm> fabi_: Huh?
20131221 05:25:55< fabi_> :-)
20131221 05:26:41< fabi_> Just want to admit that I can#T FIX bugs righti now .-=)
20131221 05:27:00< fabi_> !%44 
20131221 05:27:24< shadowm> That's disgusting.
20131221 05:27:48< fabi_> rof
20131221 05:27:49< fabi_> l
20131221 05:28:04< Coffee_irc> so that's why the minimaps look the way they do :D
20131221 05:28:15< fabi_> lol
20131221 05:33:20-!- travis-ci [~travis-ci@ec2-54-224-79-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20131221 05:33:21< travis-ci> [travis-ci] wesnoth/wesnoth-old#1209 (master - 31e9c4e : Coffee--): The build has errored.
20131221 05:33:21< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth-old/builds/15805005
20131221 05:33:21-!- travis-ci [~travis-ci@ec2-54-224-79-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20131221 05:33:32< fabi_> ^ lol
20131221 05:33:34< fabi_> hihi
20131221 05:34:57< fabi_> Let me commit some unfinished stuff as well.
20131221 05:35:29< Coffee_irc> compiles for me
20131221 05:35:47< Coffee_irc> looks like it failed earlier up from the merged pull request
20131221 05:36:01< fabi_> damn
20131221 05:36:04< fabi_> No matter
20131221 05:36:25< fabi_> I still feel like commiting
20131221 05:36:46< Coffee_irc> committing what changes?
20131221 05:39:40-!- rjaguar3 [~rjaguar3@c-67-175-80-212.hsd1.il.comcast.net] has quit [Quit: Leaving]
20131221 05:39:47< irker935> wesnoth: fendrin wesnoth-old:master 9a44642689aa / src/ (9 files in 2 dirs): Save villages and items. http://git.io/ZIibXQ
20131221 05:40:00< fabi_> Those ^
20131221 05:56:36-!- mattsc [~mattsc@154.20.32.246] has quit [Quit: Ciao]
20131221 06:08:02< shadowm> fabi_: Why did you unlock that thread?
20131221 06:08:53-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 246 seconds]
20131221 06:11:27< fabi_> Because there is no reason to lock it.
20131221 06:11:44< shadowm> Then discuss it with Gambit instead of arguing about it in public.
20131221 06:11:54< fabi_> I don't argue.
20131221 06:12:11< fabi_> There is no reason for discussion.
20131221 06:12:41-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 06:12:58-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 06:15:40< shadowm> fabi_: Stop unlocking it. Discuss it with Gambit via PM if you must.
20131221 06:15:54< fabi_> no
20131221 06:16:11< fabi_> There is no reason to lock the thread.
20131221 06:16:11< shadowm> Sorry?
20131221 06:16:30< fabi_> Keep locking it and I will keep unlocking it.
20131221 06:16:40< shadowm> That's easily solved.
20131221 06:17:47< fabi_> :-)
20131221 06:18:32< fabi_> You need to ban "fendrin" as well-
20131221 06:18:34< fabi_> .
20131221 06:19:14< shadowm> No, I don't, because there is only one account you own that has moderator privileges, and I expect you to behave anyway.
20131221 06:19:56< fabi_> You lock my 2004 account?
20131221 06:20:04< fabi_> :-)
20131221 06:22:22< fabi_> I guess the forum won't miss me much-
20131221 06:22:34< shadowm> Only one day.
20131221 06:22:41< shadowm> That should be enough for you to sober up.
20131221 06:23:24< fabi_> One day only? 
20131221 06:23:35< fabi_> rofl
20131221 06:23:46-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 06:24:00-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 06:25:36< fabi_> Well, let's take that opportunity to take a Wesbreak.
20131221 06:25:52< fabi_> It feels like the right time, just now.
20131221 06:26:09-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20131221 06:34:30-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 06:34:46-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 06:39:13-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 06:39:47-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 06:50:20-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 245 seconds]
20131221 06:52:21-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 06:54:54-!- kex [~kex@89.205.75.19] has quit [Read error: Operation timed out]
20131221 07:03:02-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20131221 07:18:45-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20131221 07:38:38-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 264 seconds]
20131221 07:49:01-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 07:49:17-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 08:09:00< AI0867> Coffee_irc: the reason it wasn't merged yet is that while the final diff was tiny, the intermediate commits weren't
20131221 08:09:17< AI0867> I would have liked to see those squashed down into the actual diff
20131221 08:10:25< Coffee_irc> AI0867: all looks good to me
20131221 08:10:57< Coffee_irc> he's just creating a LUA accessible table with information for a game such as era and timer, etc.
20131221 08:11:20< Coffee_irc> nothing fancy going on
20131221 08:12:33< Coffee_irc> but I see what you are saying as he created and deleted a bit of code in the process
20131221 08:15:50-!- Kostic [~marko@85.202.113.113] has joined #wesnoth-dev
20131221 08:23:55-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20131221 08:24:31-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Client Quit]
20131221 08:36:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131221 08:40:34-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 08:44:02-!- wesbot changed the topic of #wesnoth-dev to: 202 bugs, 343 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20131221 08:44:49-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20131221 09:07:03-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20131221 09:07:03-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20131221 09:07:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131221 09:07:32-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has joined #wesnoth-dev
20131221 09:10:09-!- zookeeper [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20131221 09:10:16-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20131221 09:10:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20131221 09:18:52-!- lipkab [~the_new_l@apn-185-10-127-10.vodafone.hu] has joined #wesnoth-dev
20131221 09:20:37-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 248 seconds]
20131221 09:21:38-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131221 09:21:51-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131221 09:39:56-!- mjs-de [~mjs-de@g228199110.adsl.alicedsl.de] has joined #wesnoth-dev
20131221 09:43:51-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20131221 09:54:22-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has joined #wesnoth-dev
20131221 10:12:08< zookeeper> should string freeze apply as strictly to addition of new to-be-localized images (namely maps)? it's not like they appear in a po file or anything.
20131221 10:13:18< thunderstruck> lipkab: https://github.com/wesnoth/wesnoth-old/commit/4676c005f1a528d46bbcbb83c630a2e580f98601
20131221 10:13:46< thunderstruck> Perhaps you should remove previos calls to set_metadata() then?
20131221 10:28:40-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 10:30:04-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20131221 10:31:25< lipkab> thunderstruck: That breaks random map previews.
20131221 10:31:44< thunderstruck> lipkab: Good point.
20131221 10:32:36-!- kex [~kex@89.205.75.19] has quit [Read error: Operation timed out]
20131221 10:35:47< thunderstruck> lipkab: By the way, I noticed that when using "Activate" button to enable mod, you might get that popup asking for user interaction. And if you press "cancel", mod gets still enabled.
20131221 10:36:31< thunderstruck> That's rather trivial, but I think it's unintuitive.
20131221 10:38:05< lipkab> thunderstruck: Yeah, I know of that. The dependency manager doesn't seem to work well with the new gui.
20131221 10:38:28< lipkab> But I was short of time, so decided to put features first :)
20131221 10:38:35< lipkab> *on
20131221 10:38:35< thunderstruck> I see.
20131221 10:38:49< lipkab> This is something I can fix during the freeze.
20131221 10:39:10< Coffee_irc> is the freeze only for new strings or features as well?
20131221 10:39:22< thunderstruck> Both, I think.
20131221 10:39:50< lipkab> That's why it's called *feature* freeze in the first place ;)
20131221 10:44:05< irker935> wesnoth: Andrius Silinskas wesnoth-old:master 09c73abdff0f / changelog players_changelog: Updated changelogs. http://git.io/EjI_qg
20131221 10:45:55< thunderstruck> lipkab: Sorry for bugging you so much, but I also noticed that "allow_era" and similar keys do not exists.
20131221 10:46:01< thunderstruck> But they are here http://wiki.wesnoth.org/ScenarioWML
20131221 10:46:12< thunderstruck> Well, at least I can't find them using grep.
20131221 10:46:39< lipkab> Hmm. They ought to be in mp_depcheck.
20131221 10:47:28< lipkab> Yeah, grep won't find it because the appropriate strings are generated with concatenation.
20131221 10:48:19< thunderstruck> Ok. Makes sense.
20131221 10:48:24< lipkab> See mp_depcheck.cpp:241, for example.
20131221 10:58:59-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131221 11:03:28< irker935> wesnoth: ln-zookeeper wesnoth-old:master c4dca8e3099f / data/core/units.cfg: Typo fixes in drake race description. http://git.io/mjgLGA
20131221 11:03:30< irker935> wesnoth: ln-zookeeper wesnoth-old:master df175d747f16 / / (34 files in 8 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth-old http://git.io/WYUxEg
20131221 11:04:06< zookeeper> wait wtf
20131221 11:04:21< zookeeper> where did all that garbage come from
20131221 11:05:10< zookeeper> it didn't do one of those stupid merge commits when i pushed stuff yesterday, so why does it do it now
20131221 11:05:43-!- stikonas_ [~gentoo@46.246.43.191] has joined #wesnoth-dev
20131221 11:05:43-!- stikonas_ [~gentoo@46.246.43.191] has quit [Changing host]
20131221 11:05:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131221 11:06:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20131221 11:06:25< bumbadadabum> zookeeper: There were other commits before yours and you worked on an old HEAD?
20131221 11:06:48 * zookeeper shrugs
20131221 11:06:58< zookeeper> why don't we move to a VCS which isn't so broken?
20131221 11:07:33< irker935> wesnoth: ln-zookeeper wesnoth-old:master 994960c6aaad / data/campaigns/The_Rise_Of_Wesnoth/scenarios/15_A_New_Land.cfg: Flipped Haldric's ship horizontally. http://git.io/prZF8w
20131221 11:08:18-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 11:08:31-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 11:09:05< zookeeper> well, anyway, i have no idea whether there's a problem or not with that commit so i'm not gonna do anything about it by default.
20131221 11:10:05< irker935> wesnoth: Boldizsár Lipka wesnoth-old:master 63a7446925bc / src/ (mp_options.cpp mp_options.hpp multiplayer_configure.cpp): Hide custom option widgets in configure::hide_children. http://git.io/8fjgkQ
20131221 11:10:07< irker935> wesnoth: Boldizsár Lipka wesnoth-old:master a1e6eb821a58 / src/multiplayer_configure.cpp: Fix custom options layout. http://git.io/yjzQDg
20131221 11:10:44< lipkab> zookeeper: Hey look, I can do it without stupid merge commits!
20131221 11:11:50< zookeeper> :o
20131221 11:12:02< zookeeper> you're a wizard
20131221 11:13:02-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 11:13:04< lipkab> Well, it's only lesser black magic - you should update your local repo with "git pull --rebase", that's all.
20131221 11:13:34-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 11:15:43< lipkab> bumbadadabum: EoC lacks a description.
20131221 11:19:37< zookeeper> i just don't get why everyone and their mom always quote command line stuff :|
20131221 11:19:59< zookeeper> but no, you don't need to explain it any further anyway
20131221 11:24:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20131221 11:27:26< bumbadadabum> lipkab: Oh right, I might add one thanks
20131221 11:35:13-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20131221 11:43:20-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20131221 11:43:26-!- stikonas_ [~gentoo@5.20.200.50] has joined #wesnoth-dev
20131221 11:43:26-!- stikonas_ [~gentoo@5.20.200.50] has quit [Changing host]
20131221 11:43:26-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20131221 11:45:35-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds]
20131221 11:47:52-!- stikonas__ [~gentoo@46.246.43.22] has joined #wesnoth-dev
20131221 11:47:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20131221 11:49:10< Coffee_irc> well, I've finished the changes I made to middle click scrolling on my local repository
20131221 11:49:24< Coffee_irc> pity fabi seemed to have too much to drink tonight :P
20131221 11:51:45< Coffee_irc> if I want to get the changes in, should I commit, or do I wait for fabi to check them over?
20131221 11:55:43< thunderstruck> Coffee_irc: I would commit them now if freeze is today. You can always fix it later.
20131221 11:57:02-!- Kostic [~marko@85.202.113.113] has quit [Ping timeout: 240 seconds]
20131221 11:57:29-!- Kostic [~marko@85.202.113.22] has joined #wesnoth-dev
20131221 11:59:21< irker935> wesnoth: David Mikos wesnoth-old:master 36b6b60beb50 / / (6 files in 2 dirs): Make middle click scrolling based on movement distance not screen centre. http://git.io/HUnJCw
20131221 12:01:05< Coffee_irc> hopefully middle click scrolling is more intuitive and useful now
20131221 12:01:29-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Ping timeout: 240 seconds]
20131221 12:02:19-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 12:02:34-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 12:07:24-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 12:07:38-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 12:15:24-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has quit [Quit: LordBob_]
20131221 12:16:49-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 12:18:44-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 12:18:58-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 12:21:30-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20131221 12:27:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131221 12:29:37-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
20131221 12:29:58-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131221 12:30:04-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20131221 12:30:54-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 12:31:10-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 12:31:51-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 12:36:10-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 12:43:47-!- stikonas__ [~gentoo@46.246.43.22] has quit [Ping timeout: 260 seconds]
20131221 12:47:19-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 12:47:33-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 12:48:24-!- stikonas__ [~gentoo@2002:514:c832:0:216:cfff:febb:f05] has joined #wesnoth-dev
20131221 12:49:00-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 12:51:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20131221 12:52:02-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20131221 12:52:02-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20131221 12:52:02-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20131221 13:03:47-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 13:13:48-!- Bengt82 [~Bengt82@s83-179-55-156.cust.tele2.se] has joined #wesnoth-dev
20131221 13:14:27-!- Bengt82 [~Bengt82@s83-179-55-156.cust.tele2.se] has quit [Client Quit]
20131221 13:24:35-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 245 seconds]
20131221 13:26:27-!- gfgtdf [~chatzilla@e177127226.adsl.alicedsl.de] has joined #wesnoth-dev
20131221 13:26:36< gfgtdf> mattsc: have you fixed the undo recuit oos ?
20131221 13:29:58< gfgtdf> wesbot: seen mattsc
20131221 13:29:58< wesbot> gfgtdf: The person with the nick mattsc last spoke 11h 11m ago.  7h 33m ago was here and on the channels #wesnoth, #wesnoth-de and #wesnoth-umc-dev with the message: Quit: Ciao
20131221 13:39:30-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 13:39:47-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 13:45:16< Coffee_irc> one last change from me to allow mouse wheel scrolling of sliders
20131221 13:45:20-!- {V} [~V@88-73-ftth.on.nl] has quit [Read error: Connection reset by peer]
20131221 13:46:00< bumbadadabum> I actually was going to do some revamping of EI, but I only got to S2
20131221 13:46:01-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 13:46:05-!- {V} [~V@88-73-ftth.on.nl] has joined #wesnoth-dev
20131221 13:46:07< bumbadadabum> is that a problem for 1.11.8?
20131221 13:46:09-!- Turuk [~Turuk@74-139-73-227.dhcp.insightbb.com] has joined #wesnoth-dev
20131221 13:46:16-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 13:46:19< bumbadadabum> that the code might be a bit inconsistent
20131221 13:47:23< shadowm> Coffee_irc: Does the middle button map grabbing respect the scroll speed option in Preferences? It seems awfully fast compared to wheel and arrow key scrolling here.
20131221 13:47:29< irker935> wesnoth: David Mikos wesnoth-old:master cd8c83532b0d / / (7 files in 3 dirs): Make it so that sliders can be mouse wheel scrolled. http://git.io/jCy1XA
20131221 13:48:00< Coffee_irc> shadowm: yeah, it is based on distance of the mouse from the start of the middle click as well as the preferences setting for scroll speed
20131221 13:48:07< shadowm> Coffee_irc: That commit only affects GUI1 sliders, but I assume you knew that already.
20131221 13:48:37< shadowm> Coffee_irc: Still, it's awfully fast compared to regular scrolling (i.e. not very usable for me).
20131221 13:48:39< Coffee_irc> shadowm: how are you so quick? :P
20131221 13:49:14< shadowm> I am not... quick...?
20131221 13:49:32< shadowm> I have the window maximized on a 1920x1080 screen, by the way.
20131221 13:49:36< Coffee_irc> I just committed the changes to the slider about 2 seconds before you comment :P
20131221 13:50:00< shadowm> 10:47:28 <irker935>
20131221 13:50:01< shadowm> 10:48:06 <shadowm>
20131221 13:50:04< Coffee_irc> shadowm: could it be that your machine is faster and is running more ticks per second?
20131221 13:50:14< shadowm> I'm not very good at maths, but I believe that's 38 seconds.
20131221 13:50:27< bumbadadabum> Coffee_irc: Don't you know shadowm is a time traveler?
20131221 13:50:28< Coffee_irc> for the middle click scrolling?
20131221 13:50:52< shadowm> Coffee_irc: Wesnoth caps max FPS at 50 by default and I haven't changed that.
20131221 13:51:17< Coffee_irc> hmm, maybe I am more used to very subtle mouse movements
20131221 13:52:02< Coffee_irc> I could make it nonlinear the speedup as you get further from the initial mouse click
20131221 13:52:17< Coffee_irc> so that small changes don't affect it as much if that would help?
20131221 13:52:45< shadowm> Potentially. I'm willing to test patches.
20131221 13:52:54< AI0867> 12:09 < zookeeper> well, anyway, i have no idea whether there's a problem or not with that commit so i'm not gonna do anything about it by default. <-- it's not, and thank you for not doing anything. Someone once panicked and started reverting things
20131221 13:55:19< Coffee_irc> in case you guys are wondering about the middle click scrolling, it was on fabi's list before I had a go at it, so it would have been implemented at some point
20131221 14:00:01-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 14:00:23-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 14:01:44< Coffee_irc> shadowm: http://pastebin.com/wZhRzmwP
20131221 14:02:24< Coffee_irc> ^ I gave a go at using a more gradual square root algorithm for the speed
20131221 14:02:34< shadowm> It seems using :fps renders Wesnoth immune to CTRL+C. O o
20131221 14:02:58< Coffee_irc> don't look at me, nothing to do with my patch :P
20131221 14:03:12< shadowm> ... Obviously.
20131221 14:03:54< Coffee_irc> yeah, another thing is that when in full screen connecting to the addons or downloading a big addon you can't switch from fullscreen with control-f or alt-tab...
20131221 14:04:13< shadowm> No, that's completely normal.
20131221 14:04:30< shadowm> What isn't normal is that Wesnoth can at times ignore CTRL+C without explicitly blocking SIGINT.
20131221 14:04:58-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 14:06:31< shadowm> Okay, it feels better...
20131221 14:07:19< Coffee_irc> not what nintendo would put out, but I think a huge imrovement over what was there before, wouldn't you say?
20131221 14:07:56< shadowm> Still much faster than the regular scrolling, but I'm not completely sure until what point that can be considered a feature.
20131221 14:09:20< bumbadadabum> shadowm: Repeating my original question, is having an incomplete improvement run in EI a problem to have in 1.12?
20131221 14:09:39-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 260 seconds]
20131221 14:10:03< shadowm> It does seem impossible at times to scroll the map as I want after hitting a map edge (not really sure how to explain, it's probably very dependent on my current window configuration).
20131221 14:10:19< bumbadadabum> The changes aren't major, but S1 and S2 have some things that aren't in the rest of the campaign
20131221 14:10:39< shadowm> That's both before and after the pastebin patch.
20131221 14:10:57< shadowm> bumbadadabum: What kind of improvements are we talking about?
20131221 14:11:06< bumbadadabum> macrofied code
20131221 14:11:11< bumbadadabum> did some side hiding
20131221 14:11:17< bumbadadabum> facings
20131221 14:11:20< shadowm> Does this touch any global macros (data/core) or translatable strings?
20131221 14:11:34< bumbadadabum> no
20131221 14:11:41< shadowm> Units from data/core?
20131221 14:11:47< bumbadadabum> no
20131221 14:11:50< shadowm> Then it shouldn't be a problem.
20131221 14:12:35< bumbadadabum> but can I still do the things after the feature freeze?
20131221 14:12:35< bumbadadabum> Because I have time now, and kinda want to do it :p
20131221 14:12:39< shadowm> Also, 1.12 won't be released right now... Assuming we do enter the feature freeze, you still have a few versions (at least two betas and one RC) before 1.12.
20131221 14:12:56< shadowm> That's at least 2 months time.
20131221 14:13:17< bumbadadabum> yeah, but I thought the feature freeze meant no more anything except bugfixes
20131221 14:13:22< shadowm> Plenty of time to finish whatever you are doing there that doesn't break the feature freeze and is properly tested so it won't introduce any bugs.
20131221 14:13:30< bumbadadabum> ok
20131221 14:13:36< bumbadadabum> so can I make map improvements?
20131221 14:14:29< shadowm> I guess that's okay as long as you don't replace the whole campaign with L*** or some crap.
20131221 14:14:47< bumbadadabum> L***?
20131221 14:15:01< shadowm> It was the first UMC campaign I could think of.
20131221 14:15:07< bumbadadabum> oh
20131221 14:15:07< bumbadadabum> I see
20131221 14:15:12< bumbadadabum> I thought it was a terrain type
20131221 14:15:13< bumbadadabum> lol
20131221 14:15:35< bumbadadabum> I was thinking about adding variety in villages
20131221 14:15:36< shadowm> No, asterisks are not allowed* in terrain strings because they are used as wildcards.
20131221 14:15:37< bumbadadabum> and grass
20131221 14:15:39< bumbadadabum> and forests
20131221 14:15:50< shadowm> e.g. in terrain=X*,*^X* and so on.
20131221 14:15:54< bumbadadabum> I know
20131221 14:16:03< bumbadadabum> and therefore I thought you meant "any terrain with L"
20131221 14:18:33< shadowm> Okay... Wesnoth became immune to CTRL+C in any context now.
20131221 14:19:17< shadowm> ... Also SIGHUP apparently.
20131221 14:19:24< shadowm> Not good.
20131221 14:20:01-!- exciton [chuck-the-@89.109.202.5] has quit [Read error: Connection reset by peer]
20131221 14:20:16-!- exciton [chuck-the-@89.109.202.5] has joined #wesnoth-dev
20131221 14:20:55< shadowm> I'd guess somebody changed a system event handling loop recently.
20131221 14:23:18< shadowm> OK, now that I think of it, this must not be a bug in Wesnoth, because I'm sure it worked until a couple of days ago and now even 1.11.7 is ignoring...
20131221 14:23:23< shadowm> SIGTERM, SIGHUP, SIGINT.
20131221 14:25:23-!- exciton_ [chuck-the-@89.109.205.92] has joined #wesnoth-dev
20131221 14:25:49< shadowm> Oooooh, what the hell, it only ignores signals when sound (in-game) is disabled.
20131221 14:25:59< shadowm> That doesn't make any sense.
20131221 14:26:59-!- exciton [chuck-the-@89.109.202.5] has quit [Ping timeout: 260 seconds]
20131221 14:27:01< AI0867> sounds like SDL
20131221 14:27:06-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20131221 14:27:13< AI0867> I've had some weird issues with a joystick-testing program
20131221 14:27:19< bumbadadabum> uhh
20131221 14:27:37< shadowm> Can anyone else on Linux reproduce this? Go to Preferences -> Sound, quit the game, start the game again (from the terminal), press CTRL+C on the terminal or send SIGINT or SIGTERM to Wesnoth manually, does Wesnoth quit or ignore the signal?
20131221 14:27:40< bumbadadabum> the File: menu for the editor doesn't seem to use only display names
20131221 14:27:47< AI0867> in some cases it suddenly stops passing on the SQL_QUIT event
20131221 14:28:02< shadowm> Er, *Go to Preferences -> Sound, unmark all checkboxes, quit the game [...]
20131221 14:28:06< AI0867> okay
20131221 14:28:15< shadowm> Alternatively, start with --nosound.
20131221 14:28:19< bumbadadabum> unless fabi really wants it to appear as "editor-scenario-edit"
20131221 14:28:39< shadowm> bumbadadabum: It looks fine for me?
20131221 14:28:49< AI0867> shadowm: worksforme
20131221 14:29:03< shadowm> AI0867: Does that mean it quits, or ignores the signal?
20131221 14:29:07< AI0867> it quits
20131221 14:29:19< bumbadadabum> I guess I'll recompile then
20131221 14:29:20< shadowm> Perhaps it's my SDL version then.
20131221 14:29:24< bumbadadabum> something might have gone wron
20131221 14:29:26< bumbadadabum> *wrong
20131221 14:29:28< AI0867> shadowm: it's a build of a few days old though
20131221 14:29:35 * AI0867 pulls
20131221 14:29:42< shadowm> AI0867: Even 1.11.7 should do, really.
20131221 14:29:50< AI0867> well, it's certainly newer than that
20131221 14:29:55< lipkab> shadowm: Quits here too.
20131221 14:30:03< shadowm> But I'm using libsdl1.2debian 1.2.15-8 from Debian jessie.
20131221 14:31:29-!- exciton_ [chuck-the-@89.109.205.92] has quit [Read error: Connection reset by peer]
20131221 14:31:43-!- exciton [chuck-the-@89.109.205.92] has joined #wesnoth-dev
20131221 14:31:46< lipkab> shadowm: Same here...
20131221 14:32:25< shadowm> Odd.
20131221 14:33:24< AI0867> 1.2.15-5 here
20131221 14:34:45-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20131221 14:35:23< thunderstruck> Is there any reason why git repo hasn't already been renamed to "wesnoth"?
20131221 14:36:49< AI0867> name issues
20131221 14:36:49< shadowm> Yeah.
20131221 14:36:56< AI0867> what if we do get a new conversion?
20131221 14:37:28< shadowm> Yeah well, that's the crux of the issue. Somebody is supposed to be working on a reconversion because of some alleged issues with the current repository.
20131221 14:38:27< shadowm> (I don't remember what the issues are, and I really don't want to know anyway.)
20131221 14:38:36< thunderstruck> So we'll be stuck with this odd name for a while, I guess.
20131221 14:38:59< thunderstruck> s/for a while/for a long while/
20131221 14:39:10< Coffee_irc> shadowm: one more test would be appreciated http://pastebin.com/index/wZhRzmwP
20131221 14:39:53< Coffee_irc> I tried to get the snap edge thing working with horizontal and vertical movements, as well as tweaked the scroll to match as best I could the edge scroll
20131221 14:40:28< shadowm> Hang on, I found an ancient bug I now know how to fix and I absolutely must fix it right now so brb.
20131221 14:41:40< thunderstruck> AI0867: And what bad would happen if we renamed this repo to "wesnoth" and get a new conversion?
20131221 14:42:21-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 14:44:13-!- Kostic [~marko@85.202.113.22] has quit [Quit: Kostic]
20131221 14:44:14-!- exciton [chuck-the-@89.109.205.92] has quit [Read error: Connection reset by peer]
20131221 14:44:28-!- exciton [chuck-the-@89.109.205.92] has joined #wesnoth-dev
20131221 14:44:50< shadowm> thunderstruck: Everyone will end up with invalid downstream repositories tracking orphaned commits and branches.
20131221 14:46:34< lipkab> Eek. Is it known that movement anims are horribly broken?
20131221 14:46:57< Coffee_irc> lipkab: what do you mean?
20131221 14:47:34 * shadowm plays with accel 1.75, doesn't see any movement anims for very long.
20131221 14:48:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20131221 14:48:47< lipkab> Coffee_irc: Movement is lagging, and the unit randomly jumps back a few hexes in the route sometimes for a few frames.
20131221 14:49:19-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20131221 14:49:22-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev
20131221 14:49:33< Coffee_irc> lipkab: hmm, does it happen with speed set to 0.25x for you?
20131221 14:49:51< Coffee_irc> because it is all good here
20131221 14:50:26< Coffee_irc> and good at 1x
20131221 14:51:03< lipkab> Coffee_irc: The jumback doesn't, but the movement isn't smooth on 0.25x either.
20131221 14:51:06< gfgtdf> mattsc: have you fixed the undo recuit oos ?
20131221 14:51:10< lipkab> *jumpback
20131221 14:51:19-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20131221 14:51:59< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 41b666fbfec5 / changelog src/widgets/file_menu.cpp: gui1: Escape filenames in the file_menu menu that may contain WML formatting http://git.io/jalI2Q
20131221 14:52:26-!- stikonas__ is now known as stikonas
20131221 14:52:31< mattsc> gfgtdf: no.  I've been concentrating on things that would change strings etc.  Also, I thought you were going to look into it.  Maybe I misremember, there was a lot going on at the time.
20131221 14:52:57< lipkab> Okay, it seems that this is the intelligent fog slowdown again...
20131221 14:53:33< lipkab> I'll try to make a release build and see if the problem exists there.
20131221 14:54:00< shadowm> Coffee_irc: You linked me to the same patch...
20131221 14:54:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20131221 14:54:35< gfgtdf> mattsc: so i'll disable undo unit recruitement for 1.11.8 (can be reabled later) since it results in oos im most cases?
20131221 14:54:59< Coffee_irc> shadowm: sorry http://pastebin.com/YBGVBeYG
20131221 14:56:18< mattsc> gfgtdf: sure
20131221 14:56:25< shadowm> Coffee_irc: Uh, this is to be applied on top of the other patch?
20131221 14:56:34< Coffee_irc> shadowm: instead of it
20131221 14:56:50< shadowm> Well, patch is rejecting it.
20131221 14:57:09< Coffee_irc> I'll do it again
20131221 14:57:57< Coffee_irc> shadowm: http://pastebin.com/6U4DwycF
20131221 14:58:23< Coffee_irc> that should work on HEAD
20131221 14:58:48< shadowm> Yeah, it does.
20131221 15:00:02-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20131221 15:01:52< shadowm> Coffee_irc: Okay, I finally know what's bothering me about it, but it's probably not worth "fixing".
20131221 15:02:18< Coffee_irc> so...
20131221 15:02:23< shadowm> In the GIMP, when I use the middle button to scroll the image, the view only scrolls for as long as I'm moving the pointer.
20131221 15:02:24< Coffee_irc> what is it?
20131221 15:02:40< Coffee_irc> yeah, this is more like scrolling firefox
20131221 15:02:52< shadowm> Uh, Firefox doesn't do middle button scrolling.
20131221 15:03:03< shadowm> I think.
20131221 15:03:07< Coffee_irc> shadowm: give it a try :)
20131221 15:03:19< shadowm> Unless it's the autoscrolling option I don't know what it does that I have disabled.
20131221 15:03:32< shadowm> Ooooooo that's it.
20131221 15:04:20< shadowm> Finally, my web page scrolling problems have come to an end!
20131221 15:04:29< Coffee_irc> :D
20131221 15:04:55< shadowm> Erm, I was scrolling on the test scenario and I got a SIGSEGV.
20131221 15:05:56< lipkab> And didn'T
20131221 15:05:59< Coffee_irc> yeah, I just got that too with the test scenario...
20131221 15:06:04< lipkab> ...Wesnoth ignore it?
20131221 15:06:07< shadowm> Of course I can't reproduce it now that I am running it on gdb.
20131221 15:06:22< lipkab> Heisenbug!!!
20131221 15:06:32< Coffee_irc> wesnoth: src/persist_context.cpp:146: virtual bool persist_file_context::clear_var(const string&, bool): Assertion `active != __null' failed.
20131221 15:06:54< shadowm> Coffee_irc: No, not the prestart bug if that's what you mean.
20131221 15:07:24-!- exciton [chuck-the-@89.109.205.92] has quit [Read error: Connection reset by peer]
20131221 15:07:29-!- lipkab [~the_new_l@apn-185-10-127-10.vodafone.hu] has quit [Quit: Távozom]
20131221 15:07:38-!- exciton [chuck-the-@89.109.205.92] has joined #wesnoth-dev
20131221 15:07:57< Coffee_irc> oh, I think I know what could have happened
20131221 15:08:13< Coffee_irc> one of the variables I've used may not have been set
20131221 15:08:21< Coffee_irc> I should do a check for that
20131221 15:08:58< Coffee_irc> the mouse events for pressed and holding down are in separate areas and could fire in a different order
20131221 15:09:31< AI0867> Coffee_irc: that particular bit is a known bug in persistence
20131221 15:09:42< shadowm> lipkab: While an application _could_ block SIGSEGV if it wanted, odds are that execution would quickly go off the rails, so odds are that SDL isn't equipped to handle that or any other error signals (SIGBUS, SIGILL, SIGFPE).
20131221 15:09:46< AI0867> that is, the assert was placed there to prevent segfaults
20131221 15:10:37< Coffee_irc> shadowm: is the feel of the middle click scroll good do you think?
20131221 15:11:57< shadowm> Coffee_irc: Well, ideally the theme UI sidebar shouldn't interfere with the scrolling, but otherwise it's good now.
20131221 15:12:15< shadowm> I suppose there's not much that can be done about the sidebar in any case.
20131221 15:12:33< Coffee_irc> ok, I'll push and try to fix any possible variable not set bug
20131221 15:12:37< Coffee_irc> thanks for testing
20131221 15:13:48< irker935> wesnoth: David Mikos wesnoth-old:master 120f2011f3b5 / src/controller_base.cpp: Add snap horizontal/vertical to middle click scrolling and tweak speed. http://git.io/yvC7mA
20131221 15:14:59< shadowm> Yeah well, if you suspect a variable may not be initialized correctly you really should confirm and fix that first. :p
20131221 15:17:20< shadowm> mattsc: What was the final verdict with regards to the AI recruitment gold saving aspect being enabled by default?
20131221 15:18:58< mattsc> shadowm: there's been no verdict.  I've gotten no response at all to my ML post.  I assume the folks who IMO should make the decision aren't around at the moment, and nobody else has spoken up.
20131221 15:19:26< shadowm> Boo.
20131221 15:19:44< gfgtdf> mattsc: another issue: your github account is strange, as a result if i want to see your commits https://github.com/wesnoth/wesnoth-old/commits?author=mattsc  i only see your commits until sptember.
20131221 15:20:54< mattsc> gfgtdf: uh, strange.  No idea what might be causing this.
20131221 15:21:52< mattsc> shadowm: I don't really want to make a decision over flix's head, although I assume that he wouldn't be opposed to not having gold saving as default (he was open to that option when he first introduced it)
20131221 15:23:24< gfgtdf> mattsc: maybe your local software is not properly connected to your github account (i had a similar issue when i had a different email in my local software and in my github account).
20131221 15:23:48< mattsc> gfgtdf: can you use CL git?  'git log --author=mattsc' works for me and shows everything
20131221 15:24:28< mattsc> gfgtdf: umm ...  I use the OS X github app, I'll have a look into that
20131221 15:24:30< irker935> wesnoth: David Mikos wesnoth-old:master d04f6af930b1 / src/ (controller_base.cpp mouse_handler_base.cpp mouse_handler_base.hpp): add check to see that middle click scrolling variables are fully intialized http://git.io/gKsaGQ
20131221 15:25:00< shadowm> mattsc: You only really need to check whether the email you use for committing is registered in https://github.com/settings/emails .
20131221 15:25:49< mattsc> shadowm: yeah, just found that and that might be the problem
20131221 15:29:15< mattsc> gfgtdf: I just added the email address I use for committing (I think), but the list still doesn't show anything past September ...
20131221 15:30:38< shadowm> Did you confirm the address?
20131221 15:30:44< mattsc> yes
20131221 15:30:55< gfgtdf> mattsc: it's strange: this: https://github.com/wesnoth/wesnoth-old/commits?author=mattsc&page=1 works but https://github.com/wesnoth/wesnoth-old/commits?author=mattsc not
20131221 15:30:58-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has joined #wesnoth-dev
20131221 15:31:20< shadowm> Then there's probably a delay in processing past commits.
20131221 15:31:37< mattsc> shadowm: okay
20131221 15:32:10< shadowm> Or server-side caching, it seems.
20131221 15:37:36< irker935> wesnoth: JaMiT wesnoth-old:master df6aedc69540 / src/game_events/menu_item.cpp: More precise hotkey updates for WML menu items. http://git.io/5fH7Mw
20131221 15:37:38-!- exciton [chuck-the-@89.109.205.92] has quit [Read error: Connection reset by peer]
20131221 15:37:44< Coffee_irc> good night all
20131221 15:37:56-!- exciton [chuck-the-@89.109.205.92] has joined #wesnoth-dev
20131221 15:37:57< bumbadadabum> gn Coffee_irc 
20131221 15:38:25-!- Coffee_irc [~david@ppp118-210-99-69.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20131221 15:43:38-!- exciton [chuck-the-@89.109.205.92] has quit [Remote host closed the connection]
20131221 15:45:52-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 15:51:55-!- exciton [chuck-the-@77.51.136.118] has quit [Ping timeout: 260 seconds]
20131221 15:52:42-!- Adamant14 [57a17fc8@gateway/web/freenode/ip.87.161.127.200] has joined #wesnoth-dev
20131221 15:56:25-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20131221 15:57:12< irker935> wesnoth: JaMiT wesnoth-old:master 00784d7de5bf / src/ (game_events/wmi_container.hpp iterator.hpp utils/iterator.hpp): Move iterator.hpp to the utils subdirectory. http://git.io/gr7o6Q
20131221 15:57:25-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 15:59:52-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20131221 16:01:56-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 16:08:59-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 16:14:05< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 717e11c2690a / data/core/help.cfg: help: Prose revision of the Add-ons section http://git.io/DVDkiA
20131221 16:14:23< bumbadadabum> wesbot: seen zookeeper
20131221 16:14:23< wesbot> bumbadadabum: The person with the nick zookeeper last spoke 4h 54m ago.  4h 49m ago was here and on the channels #wesnoth and #wesnoth-umc-dev with the message: Ping timeout: 245 seconds
20131221 16:16:08< bumbadadabum> that was fast
20131221 16:16:08< wesbot> bumbadadabum: Sometimes we are fast
20131221 16:16:58< bumbadadabum> it was sarcasm, wesbot
20131221 16:20:05-!- Alarantalara [~Adium@192-0-128-11.cpe.teksavvy.com] has joined #wesnoth-dev
20131221 16:21:05-!- Alarantalara1 [~Adium@192-0-128-11.cpe.teksavvy.com] has joined #wesnoth-dev
20131221 16:21:05-!- Alarantalara [~Adium@192-0-128-11.cpe.teksavvy.com] has quit [Read error: Connection reset by peer]
20131221 16:21:10< shadowm> thunderstruck: Didn't you and lipkab work on improving MP campaigns support for this release again? RELEASE_NOTES needs more love.
20131221 16:22:40< shadowm> It does seem like most of our work in this opportunity was on the plumbing, in general.
20131221 16:23:32< shadowm> I'm not sure the unit overlays on the Recall menu thing deserves a release notes entry, for example.
20131221 16:25:00-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 16:25:11< shadowm> Oh right, fabi did stuff in the editor and didn't add changelog entries.
20131221 16:26:15< shadowm> And that's been the case for several releases.
20131221 16:26:35< shadowm> Great.
20131221 16:30:16-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 16:31:53-!- rjaguar3 [~rjaguar3@c-67-175-80-212.hsd1.il.comcast.net] has joined #wesnoth-dev
20131221 16:32:40-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 240 seconds]
20131221 16:33:03-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20131221 16:36:00-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 16:36:15-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 16:44:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20131221 16:45:37< zookeeper> Ivanovic, how much time?
20131221 16:48:22-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 16:48:39-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 16:49:35< shadowm> Hm.
20131221 16:49:43< zookeeper> bumbadadabum, yes?
20131221 16:49:47< shadowm> I middle-clicked on the map to scroll in the editor and it crashed instantly.
20131221 16:50:00-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 16:50:30< shadowm> I'm going to revert coffee's commits before the release if I can't find a solution.
20131221 16:51:10< shadowm> http://pastebin.com/aiv0Q5Aa  leaving this here for me while I make a debug build.
20131221 16:53:39-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 16:55:00-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 16:58:39-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 16:59:02-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Read error: Operation timed out]
20131221 17:00:18-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 17:03:03-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20131221 17:03:40-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 17:05:31-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 17:07:43-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20131221 17:08:39-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 17:08:40< shadowm> Okay, it seems like handle_scroll() should be able to know what controller is invoking it because it's actually a method of controller_base.
20131221 17:08:56< shadowm> So using resources::controller is... uh. Silly?
20131221 17:09:18< shadowm> I guess I don't need to change editor_controller to register itself after all.
20131221 17:13:32< bumbadadabum> I have the same problem
20131221 17:14:56-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has quit [Quit: LordBob_]
20131221 17:15:54< shadowm> Obviously, it's an obvious NULL pointer dereference.
20131221 17:16:06< bumbadadabum> It's impossible to use the editor for me
20131221 17:16:13< shadowm> Nothing good ever comes from dereferencing memory at 0x0000000000000000.
20131221 17:19:05< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master e6c2e9ad1828 / src/controller_base.cpp: Fix NULL pointer dereference when middle-click-scrolling in the editor http://git.io/-aB17Q
20131221 17:19:29-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20131221 17:19:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20131221 17:20:01-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 17:20:16-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 17:20:31< shadowm> Bad coffee.
20131221 17:20:37< shadowm> Bad.
20131221 17:27:55< shadowm> Oh for the love of god.
20131221 17:28:07< shadowm> Now the scrollwheel causes a SIGSEGV.
20131221 17:29:16-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 17:29:30-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 17:29:46< shadowm> Eh.
20131221 17:29:55< shadowm> Uh.
20131221 17:30:10-!- fabi_ [~fabi@88-134-21-163-dynip.superkabel.de] has joined #wesnoth-dev
20131221 17:30:19-!- fabi_ [~fabi@88-134-21-163-dynip.superkabel.de] has quit [Changing host]
20131221 17:30:19-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20131221 17:30:21< shadowm> At first glance it seems like a bad interaction between cd8c83532b0d33a3a2e24d9af04dac0455a84625 and the editor minimap zoom slider.
20131221 17:30:36-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Ping timeout: 272 seconds]
20131221 17:30:48< shadowm> No never mind, it just the commit itself.
20131221 17:31:06< shadowm> So how about we make it an official rule to not commit any C++ code that involves pointers within the last 24 hours prior to a release.
20131221 17:31:40< zookeeper> you can have C++ code which doesn't involve pointers? :p
20131221 17:31:49< zookeeper> (serious reply not necessary)
20131221 17:32:11< bumbadadabum> hey I've committed C++ without pointers
20131221 17:32:13< bumbadadabum> (4 lines)
20131221 17:32:31< shadowm> Strictly speaking, no, it's not possible.
20131221 17:33:23< shadowm> And you can't have Visual C# code that doesn't involve pointers either, for that matter. Sooner or later, you will be running on the CPU and passing pointers to virtual memory in registers and instruction operands.
20131221 17:33:27-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 252 seconds]
20131221 17:34:20 * zookeeper slaps shadowm
20131221 17:34:39< shadowm> It was too tempting.
20131221 17:36:48< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 25266cd2f6d6 / src/mouse_handler_base.cpp: Fix NULL pointer dereference when scroll-wheeling in the editor http://git.io/2Ea5bA
20131221 17:36:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131221 17:38:16< bumbadadabum> shadowm: thanks for fixing it!
20131221 17:38:22-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has joined #wesnoth-dev
20131221 17:38:29< shadowm> OK now can I please, please go back to my map.
20131221 17:38:49< bumbadadabum> shadowm: What map?
20131221 17:39:02< bumbadadabum> IftU ones?
20131221 17:42:19< shadowm> double speed = 0.04 * sqrt(scroll_speed);
20131221 17:42:33 * shadowm tries setting scroll_speed to -1.
20131221 17:43:31< shadowm> Well, it doesn't crash at least.
20131221 17:44:18< loonycyborg> zookeeper: Yes, you can have C++ code that doesn't have pointers :P
20131221 17:44:36< shadowm> OK, I think I got all the bugs.
20131221 17:44:39< loonycyborg> Depending on what task you want to accomplish using which third party libraries
20131221 17:45:41< shadowm> #include <iostreams> \n int main(int, char*[]) { std::cout << 1 << '\n'; return 0; }
20131221 17:45:48< shadowm> No pointers used.
20131221 17:46:37< shadowm> *iostream
20131221 17:47:05< shadowm> I didn't use "Hello world!" because that'd be a pointer to a constant string.
20131221 17:51:20< loonycyborg> yeah, but would hello world string ever cause NULL pointer issue if you only ever pass it to printf?
20131221 17:54:10< loonycyborg> The point is to not to use manual memory management and pointer arithmetic when you can avoid it
20131221 17:58:49-!- lipkab [~the_new_l@apn-185-10-127-10.vodafone.hu] has joined #wesnoth-dev
20131221 17:59:34< shadowm> I was being pedantic in order to justify rejecting all C++ code.
20131221 18:00:01< shadowm> A great idea, if you'd ask me. People rushing code at the last minute _always_ results in unforeseen bugs.
20131221 18:01:44< shadowm> (Also, I am not being serious about any of this. But that's pretty obvious.)
20131221 18:14:40-!- Alarantalara [~Adium@192-0-128-11.cpe.teksavvy.com] has joined #wesnoth-dev
20131221 18:15:50-!- Alarantalara1 [~Adium@192-0-128-11.cpe.teksavvy.com] has quit [Ping timeout: 264 seconds]
20131221 18:16:57-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has joined #wesnoth-dev
20131221 18:16:57-!- LordBob_ [~LordBob_@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has quit [Client Quit]
20131221 18:34:41< zookeeper> fabi_, LoW map done: https://dl.dropboxusercontent.com/u/63964618/wesnoth/maps/low.png
20131221 18:51:19 * zookeeper isn't sure what to do with the EI bigmap
20131221 18:52:23< zookeeper> the map is ready so i could commit that, but i won't get the journey markers done. if i put the map in, then i should also remove the old one, and then there'd be no journey markers at all.
20131221 18:56:02-!- Upthorn [~ogmar@c-71-193-56-99.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
20131221 18:59:40< iceiceice> hey i have a question about this bug:
20131221 18:59:42< iceiceice> https://gna.org/bugs/index.php?21257
20131221 19:00:02< iceiceice> is it really still in "need info" status, and no one is working on it?
20131221 19:00:21< iceiceice> imo it is serious enough that it might be considered a blocker
20131221 19:00:35< iceiceice> the lagging unit movements look really bad and obviously buggy
20131221 19:07:47< jamit> iceiceice: Yes, it is still "need info", as no one has yet been able to describe the bug sufficiently for me to understand it. Somehow, the people reporting the bug assume I will be able to reproduce it, despite me repeatedly stating that it does not occur on my computer.
20131221 19:08:48< iceiceice> ok, i dont have to do anything in particular to make the bug appear with every movement though
20131221 19:09:09< jamit> That's fine. It doesn't help me though.
20131221 19:09:18< iceiceice> are there any other users who don't have it appear?
20131221 19:09:42< iceiceice> is there someway it coudl be a cross-platform issue?
20131221 19:11:09< jamit> Original submission is Mac OS, comment #2 reports Windows, comment #7 Linux.
20131221 19:11:17< iceiceice> i think there were also forum posts about it though
20131221 19:12:09< jamit> All these people submitting reports that something is wrong, yet none have been able to describe what exactly is wrong.
20131221 19:12:09-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20131221 19:12:31< jamit> What forum posts?
20131221 19:12:42< iceiceice> i'm searching now, maybe those were not directly related
20131221 19:13:03< jamit> If someone knows there are forum posts related to the bug report, WHY IS THERE NO LINK IN THE BUG REPORT?!?!?
20131221 19:13:12< jamit> Am I supposed to be psychic?
20131221 19:13:19< iceiceice> it might be my mistake
20131221 19:13:41< iceiceice> if i can find any posts that seem related i will make a post on gna
20131221 19:13:57< iceiceice> so i can tell you what the issue appears to be, althoguh i am not familiar with the animation code
20131221 19:14:03< iceiceice> it looks like, whenver a unit attack moves,
20131221 19:14:12< iceiceice> if it moves throuh some hex on the way to where it attacks from,
20131221 19:14:21< iceiceice> the base frame remains drawn there
20131221 19:14:26< iceiceice> until the attack animations are complete
20131221 19:14:38< iceiceice> also just pure move animations may be affected
20131221 19:14:51< iceiceice> the problem is in the hexes that the unit passes through on the way to its destination
20131221 19:15:24< jamit> How is the animation, if you ignore the extra base image? 
20131221 19:15:55-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 19:15:56< jamit> Are you using accelerated speed?
20131221 19:16:09-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 19:16:20< iceiceice> when i first reproted it seemed to happen on any speed
20131221 19:16:32< iceiceice> i am looking at it right now based ont he current master 
20131221 19:16:34< jamit> Please expand on when pure move animations "may be" affected.
20131221 19:16:51< iceiceice> it might be all of them, its just hard to see
20131221 19:17:02< iceiceice> it seems that whenever the command is done, the extra base frames dissppear
20131221 19:17:11< iceiceice> it looks like when e.g. an elvish scout moves it has all these trails
20131221 19:17:27< iceiceice> this is starting to become guesses though
20131221 19:17:32< iceiceice> with the attacks it is very obvious
20131221 19:18:56< jamit> So if the extra base frames disappear when the command is done, what is the screen shot attached to the bug report showing?
20131221 19:20:46< iceiceice> i'm not sure
20131221 19:20:50< iceiceice> i didnt make that
20131221 19:20:55< iceiceice> i'm going to record a video so you can see what is happening
20131221 19:23:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131221 19:25:34-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20131221 19:38:14-!- iceiceice [~chris@cpe-24-193-85-148.nyc.res.rr.com] has quit [Ping timeout: 240 seconds]
20131221 19:41:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131221 19:51:35-!- iceiceice [~chris@cpe-24-193-85-148.nyc.res.rr.com] has joined #wesnoth-dev
20131221 19:52:15< iceiceice> jamit: here's a link to a video recording which shows the lagging, let me know if you can't access this... vid is 10mb
20131221 19:52:17< iceiceice> https://drive.google.com/file/d/0B54Q-3UjP5fibkFnSUlDS3gxeU0/edit?usp=sharing
20131221 19:54:07< iceiceice> its hard to describe exactly when it occurs... it seems that for some units it happens and some it doesn't,
20131221 19:54:19< iceiceice> sometimes the base frames lag in some hexes but not others the unit passed through,
20131221 19:54:22< iceiceice> sometimes in all of them,
20131221 19:54:29< iceiceice> it seems to happen every turn though
20131221 19:54:39< iceiceice> and it doesn't seem to depend on accelerated speed settings
20131221 19:56:17< shadowm> Personally, I've seen animations (attack animations, though) randomly lag mid-sequence, resulting in missed frames and distorted sounds, but this might be a separate issue.
20131221 19:58:09< iceiceice> do you see things like that?
20131221 19:58:17< iceiceice> *what was in my video?
20131221 19:58:23< zookeeper> ok, i pulled and now i rebased, and it says working copy is not clear and whether i want to stash change? do i?
20131221 19:58:34< shadowm> Oh no, I'm not checking out your video because my connection sucks.
20131221 19:58:46< iceiceice> ok
20131221 19:58:51< shadowm> zookeeper: If you have local changes you want to preserve, stash them.
20131221 19:58:59< shadowm> Local uncommitted changes.
20131221 19:59:25< shadowm> Later you can apply the stashed changes on top of the new state.
20131221 19:59:52< zookeeper> stash pop?
20131221 20:00:30< zookeeper> yes
20131221 20:00:48-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 20:01:04-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 20:02:17< irker935> wesnoth: ln-zookeeper wesnoth-old:master 8a55cc355f1f / data/campaigns/The_Rise_Of_Wesnoth/images/story/ (10 files): Removed obsolete TRoW bigmap images. http://git.io/8xjDsg
20131221 20:02:21-!- iceiceice [~chris@cpe-24-193-85-148.nyc.res.rr.com] has quit [Quit: Leaving]
20131221 20:05:34< zookeeper> i wonder if github for windows would make any of this pointless meta-work go away
20131221 20:09:42< zookeeper> svn: do stuff, update, commit. git: do stuff, pull, rebase, stash, pop, commit, push. or maybe do stuff, commit, pull, rebase, push? i dunno. maybe both + a dozen other ways.
20131221 20:10:52< vultraz> Use a GUI. It eliminates all that
20131221 20:10:55< shadowm> Different paradigm, different workflow.
20131221 20:11:03< zookeeper> vultraz, i use a GUI
20131221 20:11:03< bumbadadabum> bah
20131221 20:11:05< bumbadadabum> GUIs
20131221 20:11:10< bumbadadabum> disgusting
20131221 20:13:08< zookeeper> shadowm, if you don't mind a bit of trolling, is the paradigm to make things as complicated as possible? -.-
20131221 20:13:28< shadowm> It is to not give a shit about non-coders.
20131221 20:13:47< shadowm> That usually encompasses the full spectrum of user unfriendliness.
20131221 20:13:51< zookeeper> hey, i'm a coder. not exactly world class, but still :>
20131221 20:15:14< zookeeper> make things more complicated for every usecase just so when you stumble across that relatively rare usecase, you can solve it in an elegant obscure way and feel good about using a tool which supports that, rather than just spending 5 minutes of grunt work
20131221 20:15:18-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20131221 20:16:01< anonymissimus> shadowm: hi, so does this mean there's no technical reason to refrain from downloading addons vie the web interface ?
20131221 20:17:54< jamit> wesbot: seen iceiceice
20131221 20:17:54< wesbot> jamit: The person with the nick iceiceice last spoke 19m 8s ago.  15m 33s ago they left with the message: Quit: Leaving
20131221 20:17:58< shadowm> I think that is exactly what I said.
20131221 20:18:37< jamit> iceiceice: Before I go jumping to conclusions, have you seen the animation problem during your turns, or is it just during AI turns?
20131221 20:20:02< shadowm> anonymissimus: The only reasons for avoiding the web interface could be that it's more cumbersome for the average Joe that doesn't know how to tar xvf the file.
20131221 20:20:39< shadowm> And that it may be out of date by a certain amount of time.
20131221 20:22:27< anonymissimus> shadowm: I suppose you've looked into the 7z file posted in that thread, as you're supposedly the one who knows that code ?
20131221 20:22:32< shadowm> 1 hour for stable and development, 2 hours for oldstable, 6 hours for trunk.
20131221 20:23:03< shadowm> anonymissimus: Supposedly? According to whom?
20131221 20:23:25< anonymissimus> well but for this guy the web interface is the easiest way
20131221 20:23:44< anonymissimus> supposedly according to me, as you've looked into the thread ?!
20131221 20:24:19< anonymissimus> anyway, then please take a look at the stderr.txt file posted there to see whether you can do something about it
20131221 20:24:25< shadowm> I hadn't read the log contained therein because I expected it to be completely useless. As it turns out, it is completely useless.
20131221 20:25:34-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20131221 20:26:06< shadowm> All I get from it is that the GUI2 gui2::taddon_connect dialog's self-destruction sequence was the last thing taking place before a Boost exception managed to unwind the stack back to main.
20131221 20:26:14-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 20:29:22< shadowm> wesbot: bug 19687
20131221 20:29:23< wesbot> Bug #19687  Assigned to: Sergey Popov <loonycyborg>  Status: Fixed  Priority: 5 - Normal
20131221 20:29:26< wesbot> Summary: Game crash when trying to download addon at disconnection
20131221 20:29:28< wesbot> Original submission: If I connect to addon server, and then I'll be disconnect
20131221 20:29:31< wesbot> ed, but try to download an addon, the game doesn't show any errors - it just cra
20131221 20:29:34< wesbot> URL: http://gna.org/bugs/?19687
20131221 20:29:37< wesbot> Attached file (1st): http://gna.org/bugs/download.php?file_id=15661
20131221 20:30:23-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has quit [Ping timeout: 240 seconds]
20131221 20:30:55-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 260 seconds]
20131221 20:31:20< shadowm> Well, technically it was destroyed most likely as a consequence of the stack unwinding taking place.
20131221 20:31:53< shadowm> That object is bound to a function's scope, so it continues to live after the dialog is shown.
20131221 20:32:54< shadowm> Also, while I understand the add-ons management code for obvious reasons, I don't know much about the underlying network code; that'd be loonycyborg's thing.
20131221 20:33:07-!- lipkab [~the_new_l@apn-185-10-127-10.vodafone.hu] has quit [Ping timeout: 250 seconds]
20131221 20:33:57< shadowm> I was kind of implicitly guaranteed when I took over that the exception catches added with the Boost.asio code introduction would be sufficient for all purposes forever. ;)
20131221 20:34:32< shadowm> And as it turns out, they aren't, and I still haven't figured out how to reproduce, not even with a 1.10 build on Windows 7.
20131221 20:35:51< shadowm> For all I know it could be a difference between the Boost version bundled with the CodeBlocks libs zip/the Boost version I use on Linux, and the version actually used to compile the official Win32 build.
20131221 20:36:29-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20131221 20:40:33-!- Octalot [~noct@87.112.98.13] has quit []
20131221 20:43:39< anonymissimus> shadowm: the boost version libs and so one should be the exact same used to compile the official win release, as I got them from loony
20131221 20:44:02-!- wesbot changed the topic of #wesnoth-dev to: 203 bugs, 343 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20131221 20:44:48-!- lipkab [~the_new_l@apn-5-206-173-211.vodafone.hu] has joined #wesnoth-dev
20131221 20:47:38-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20131221 20:48:17-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 20:48:34-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 20:50:06< anonymissimus> fabi_: I like you, but you're developer ethics scare me
20131221 20:50:51< anonymissimus> fabi_: IMHO you should be more careful about dereferencing into nirvana, those are the things that are really hard to find and fix
20131221 20:53:06< irker935> wesnoth: gfgtdf wesnoth-old:master 65fded5de34d / src/actions/create.cpp: disable undoing unit creation. http://git.io/Gs_-Yg
20131221 20:54:06-!- happygrue [~quassel@wesnoth/developer/wintermute] has joined #wesnoth-dev
20131221 21:18:39< anonymissimus> shadowm: now, why did you revert that commit removing util.cpp ? The usual rules about adding files to project files are, that .hpps are only added, if their .cpp is required as well (during the linking step)
20131221 21:19:00< anonymissimus> otherwise I could go adding boost headers and what not
20131221 21:21:22< anonymissimus> or more important, if that file is important for the project, if it needs to be edited to satisfy requirements of the project (which could be the case here), or if it's a sole header without cpp
20131221 21:24:14-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 21:24:28-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 21:34:44-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 21:39:51-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 272 seconds]
20131221 21:52:46< jamit> gfgtdf: You removed the ability to undo the recruitment of, e.g. walking corpses, and your commit message states that this goes against a player's point of view. Yet this was not significant enough to mention in both changelogs?
20131221 21:59:33< gfgtdf> jamit: uhm when is 1.11.8 released? I did not exclude that me or somone else would find a better solution.
20131221 22:00:27< jamit> ? Run-on sentences can be hard to parse.
20131221 22:02:07< jamit> Or am I missing what something is being excluded from? "that me or someone else would find a better solution" is a subordinate clause? If so, exclude from what?
20131221 22:02:46-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 22:03:02-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 22:03:05< jamit> "exclude" = "discount the possibility"?
20131221 22:03:28< gfgtdf> jamit: i guess i translated wrong:  s/I did not exclude/I thought it is possible
20131221 22:03:44< jamit> Ah.. OK.
20131221 22:05:03< jamit> Still, if you think someone else would find a better solution, why commit? If you are committing, why not update the changelogs also? (If someone finds a better solution, they can revert/update changelogs as well as reverting/updating code.)
20131221 22:07:59< jamit> It's sort of like you want to get a change in because it is likely no better solution will be found, yet at the same time you don't want to document the change because it is likely a better solution will be found.
20131221 22:10:25-!- gfgtdf_ [~chatzilla@f054053190.adsl.alicedsl.de] has joined #wesnoth-dev
20131221 22:10:39< jamit> As far as I know, both code and changelog modifications should use the same criteria for whether or not a change is warranted. If it's worth modifying the code, then it is worth modifying the changelog.
20131221 22:11:08< happygrue> Ivanovic: I just posted to dev-talk regarding khalifate and what would need to happen.
20131221 22:12:35-!- gfgtdf [~chatzilla@e177127226.adsl.alicedsl.de] has quit [Ping timeout: 252 seconds]
20131221 22:12:50-!- gfgtdf_ is now known as gfgtdf
20131221 22:19:14< irker935> wesnoth: gfgtdf wesnoth-old:master 316710e55ab4 / changelog: Update changelog http://git.io/Dgvaew
20131221 22:21:13< jamit> gfgtdf: And players_changelog? This is pretty solidly in the realm of things a player could notice.
20131221 22:21:14< gfgtdf> jamit: i put it into ui but im not 100% wether ui is better than "Miscellaneous and bug fixes"
20131221 22:21:26< gfgtdf> i didnt forget plers changelog players_changelog
20131221 22:21:39< gfgtdf> i didn't forget players_changelog
20131221 22:23:28< irker935> wesnoth: gfgtdf wesnoth-old:master e274833ffa69 / players_changelog: Update players_changelog http://git.io/hokVQw
20131221 22:24:15< jamit> gfgtdf: Probably more of a miscellaneous, as it is a change to game mechanics, not how players interact with the game.
20131221 22:29:37-!- iceiceice [~chris@cpe-24-193-85-148.nyc.res.rr.com] has joined #wesnoth-dev
20131221 22:30:25-!- Coffee_irc [~david@ppp118-210-97-101.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20131221 22:35:59-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20131221 22:36:59-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 22:37:02-!- happygrue_ [~quassel@c-66-30-155-184.hsd1.ma.comcast.net] has joined #wesnoth-dev
20131221 22:37:02-!- happygrue_ [~quassel@c-66-30-155-184.hsd1.ma.comcast.net] has quit [Changing host]
20131221 22:37:02-!- happygrue_ [~quassel@wesnoth/developer/wintermute] has joined #wesnoth-dev
20131221 22:37:05-!- happygrue [~quassel@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20131221 22:37:13-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 22:40:59< anonymissimus> happygrue_: last time I looked there hadn't been any balancing commits to our khifate addon since at least one year
20131221 22:43:27< AI0867> anonymissimus: you must not have looked in the last few days then ;)
20131221 22:44:30-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 22:44:45-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 22:46:28< shadowm> anonymissimus: What rules are you talking about?
20131221 22:48:07< happygrue_> they were ready a year ago too ;)
20131221 22:49:17< happygrue_> I tweaked stuff a few days ago based on the results of the testing tournament we had some months ago
20131221 22:49:29-!- happygrue_ is now known as happygrue
20131221 22:51:05< anonymissimus> happygrue: I ss
20131221 22:51:08< anonymissimus> *see
20131221 22:52:17< anonymissimus> happygrue: well, I just would like to make sure it's a one-time-only step; if they are added to mainline, they should never be removed again, as UMC depends on EK and will depend on EK in mainline
20131221 22:52:21-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 22:52:36-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 22:52:47< happygrue> I very much agree, I would be pretty crushed if they were removed again.
20131221 22:53:16< anonymissimus> shadowm: well, common sense rules, which may not be intuitive to make script users ...
20131221 22:53:45< shadowm> anonymissimus: What I get from this is that there's as much justification for those files to be in the project as there is for those files to not be in the project.
20131221 22:54:14< shadowm> Also that you don't seem to understand how header files work.
20131221 22:55:14< shadowm> Header files are not passed to tools individually, only #included by source files, so whether they are part of the project or not doesn't actually change the result.
20131221 22:55:41< anonymissimus> shadowm: I know that
20131221 22:56:07< anonymissimus> such as the boost headers, which are only #included and no where added
20131221 22:56:25< anonymissimus> (well, we need to tell the IDE where they are)
20131221 22:56:43< shadowm> You could say that util.o is unnecessary for wesnothd atm (#if 0ing the whole thing only yields errors on objects linked into wesnoth here with scons on Linux), but proving that is by definition a hassle since we are talking of template specializations here.
20131221 22:57:07-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20131221 22:57:27< shadowm> So whether it is there or not doesn't actually matter. It's not like util.o alone will enlarge wesnothd.exe by 800% or something.
20131221 22:58:41< lipkab> gfgtdf: Your last commit resulted in an unused variable at actions/create.cpp:943.
20131221 23:01:06< gfgtdf> lipkab: ok i'll fix that
20131221 23:01:16< lipkab> Thanks.
20131221 23:03:49< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 0ab3c93c5156 / data/core/help.cfg: help: Revision of the prose revision of the Add-ons section http://git.io/_W_g5w
20131221 23:04:24< irker935> wesnoth: gfgtdf wesnoth-old:master 113ab5599b27 / src/actions/create.cpp: commented out an unused variable http://git.io/pyBz0A
20131221 23:04:53-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 23:05:07-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 23:05:17< Coffee_irc> shadowm: thanks for bugfixing my scrolling code for me :P
20131221 23:05:27 * shadowm eats Coffee_irc.
20131221 23:06:00-!- ancestral [~ancestral@71-215-198-123.mpls.qwest.net] has joined #wesnoth-dev
20131221 23:06:06-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 23:06:44< lipkab> shadowm: You *drink* coffee, silly.
20131221 23:07:01< Coffee_irc> :)
20131221 23:07:20< shadowm> What if you make coffee-flavored ice cream?
20131221 23:08:08< lipkab> Then it's not coffee anymore but coffee-flavored ice cream, obviously.
20131221 23:08:31< Coffee_irc> I second that
20131221 23:09:20< shadowm> :(
20131221 23:09:38< Coffee_irc> fabi_: yesterday I pushed changes to the middle click scrolling and scrolling of sliders
20131221 23:10:07-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 23:11:05< Coffee_irc> I assume he's recovered from the dancing girls and such of yesterday :D
20131221 23:15:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20131221 23:21:22< shadowm> Oh right. I still had stuff to fix.
20131221 23:21:49< Coffee_irc> what's the current score with the release of 1.11.8?
20131221 23:23:06< Coffee_irc> we waiting of fabi_'s gui changes and khalifate?
20131221 23:23:14< anonymissimus> shadowm: oh, it was Coffee_irc 's code, no fabi_ 's ? how did you detect the null pointer derefs, out of curiosity ?
20131221 23:23:18< shadowm> I don't know, Ivanovic hasn't been around.
20131221 23:23:36< shadowm> anonymissimus: By looking at the code.
20131221 23:24:23< shadowm> No, I only did that for the second, really. For the first I just 'p resources::controller' after breaking into the debugger, since that seemed like the most obvious potential culprit.
20131221 23:25:46< Ivanovic> Coffee_irc: yes, i want to wait for khalifate if this can be done *soon*
20131221 23:25:49< shadowm> As for how I stumbled upon the issues in the first place, by trying to examine one of my maps in the editor for evaluating a possible SLF optimization.
20131221 23:25:51< Ivanovic> and now i am off to bed, n8
20131221 23:26:05< Coffee_irc> Ivanovic: good night
20131221 23:26:35< Coffee_irc> thanks for clafifying that
20131221 23:27:01< Coffee_irc> *clarifying
20131221 23:29:05< shadowm> In general, if you suddenly pull an unchecked pointer out of nowhere and it's being dereferenced in some way (*, ->) or passed to other code, you _have_ to consider the possibility that the pointer may be NULL unless the place where you got it from explicitly guarantees that it may never be NULL.
20131221 23:30:32-!- gfgtdf [~chatzilla@f054053190.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20131221 23:31:14-!- gfgtdf [~chatzilla@f054053190.adsl.alicedsl.de] has joined #wesnoth-dev
20131221 23:32:40< shadowm> Method calls over a NULL object pointer tend to be the trickiest because the method call will not fail instantly (the pointer to 'this' is passed first in the stack to the called method and that's all that'll ever be done with it by the call itself) unless the method refers to some data field like this->field_, which would result in dereferencing memory at 0x0 + (offset of field_).
20131221 23:33:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20131221 23:34:19< Coffee_irc> shadowm: interesting
20131221 23:34:44< shadowm> So depending on the circumstances, the pointer may be passed around enough times to result in a crash much deeper than the original call site.
20131221 23:35:53-!- iceiceice [~chris@cpe-24-193-85-148.nyc.res.rr.com] has quit [Remote host closed the connection]
20131221 23:35:53-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Read error: Connection reset by peer]
20131221 23:37:12< shadowm> happygrue: It sounds like you essentially have the green light for Khalifate unless there's some developer who feels strongly against their inclusion.
20131221 23:37:55< happygrue> \o/
20131221 23:38:33< happygrue> AI0867 has mentioned interest in helping merge stuff
20131221 23:39:02< irker935> wesnoth: Boldizsár Lipka wesnoth-old:master 871aadca1ade / src/ (6 files in 2 dirs): Remove an unused dialog. http://git.io/-9McDQ
20131221 23:39:42< Coffee_irc> I used to not like them, but mainline mp could do with something fresh to make it interesting
20131221 23:39:48< Coffee_irc> IMO
20131221 23:39:58< happygrue> I think for it to be done *soon* someone besides me will have to take the lead with getting the files into working order in mainline
20131221 23:40:04-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20131221 23:40:08< happygrue> but it should be easier than last time, as they are already in umc-dev
20131221 23:40:14< irker935> wesnoth: Bär Halberkamp wesnoth-old:master 85c84b0124a7 / data/campaigns/Eastern_Invasion/maps/ (01_The_Outpost.map 02_The_Escape_Tunnel.map 03_An_Unexpected_Appearance.map): Improved maps for EI scenario 1-3 http://git.io/44X8vA
20131221 23:40:22< happygrue> Coffee_irc: I think that is going to be a common reaction
20131221 23:40:53< happygrue> they are odd, they are different, the first few games are wild, but the mp people who have played them mostly come away thinking they are fun and would like to see them developed
20131221 23:41:01< bumbadadabum> zookeeper: Am I doing this right?
20131221 23:41:17< happygrue> and surely there is a lot that can be improved
20131221 23:41:31< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 1c4129a2101b / data/gui/default/window/mp_depcheck_confirm_change.cfg: gui2/tmp_depcheck_confirm_change: Replace title label with a generic one http://git.io/8rJz5g
20131221 23:41:39< shadowm> lipkab: Oh yeah, I forgot to ask you whether this works. ^
20131221 23:42:39< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master a371eee3ea90 / data/gui/default/window/mp_depcheck_select_new.cfg: gui2/tmp_depcheck_select_new: Convert title label to Title Case http://git.io/sWu-jw
20131221 23:43:20-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 245 seconds]
20131221 23:44:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20131221 23:45:12-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20131221 23:45:16< happygrue> wesbot: bug 21214
20131221 23:45:16< wesbot> Bug #21214  Assigned to: Andrius Silinskas <thunderstruck>  Status: None  Priority: 4
20131221 23:45:19< wesbot> Summary: MP Statistics wrongly lumps together all sides' recruits, kills, and losses
20131221 23:45:22< wesbot> Original submission: See the attached screenshots.  Notice also the damage sta
20131221 23:45:25< wesbot> tistics appear to be bugged.  The replay is also attached.  Note that I played K
20131221 23:45:28< wesbot> URL: http://gna.org/bugs/?21214
20131221 23:45:30< wesbot> Attached file (1st): http://gna.org/bugs/download.php?file_id=19225
20131221 23:46:16< happygrue> so if khalifate are going to be included then I think we can expect to see more people coming to test them out on the development server, and ^ becomes a blocker IMO
20131221 23:47:44< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 232eb14e4fa8 / src/hotkey/hotkey_command.cpp: Convert editor-toggle-renameable action label to use Title Case http://git.io/sGEvdQ
20131221 23:47:47< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master e44605e1be14 / src/hotkey/hotkey_command.cpp: Replace editor-toggle-canrecruit label to be normal English http://git.io/Hry9wg
20131221 23:48:04-!- exciton [chuck-the-@77.51.136.118] has quit [Read error: Connection reset by peer]
20131221 23:48:18-!- exciton [chuck-the-@77.51.136.118] has joined #wesnoth-dev
20131221 23:48:39-!- lipkab [~the_new_l@apn-5-206-173-211.vodafone.hu] has quit [Read error: Connection timed out]
20131221 23:49:08-!- lipkab [~the_new_l@apn-5-206-173-211.vodafone.hu] has joined #wesnoth-dev
20131221 23:50:59< irker935> wesnoth: David Mikos wesnoth-old:master 9780a8a53faa / data/multiplayer/scenarios/2p_Aethermaw.cfg: Fix missing background dragonguard image in mp map Aethermaw http://git.io/V9k1Xg
20131221 23:51:34< zookeeper> the 1.11.7 executable makes some kind of UI noises when scrolling with the arrow keys. i hope trunk doesn't.
20131221 23:51:46< Coffee_irc> zookeeper: no
20131221 23:51:59< Coffee_irc> scrolling with keys is turned off in the code
20131221 23:52:10< zookeeper> ...
20131221 23:52:12< zookeeper> what
20131221 23:52:13< Coffee_irc> not by me
20131221 23:52:23< Coffee_irc> for sliders I mean
20131221 23:52:24< bumbadadabum> what
20131221 23:52:27< bumbadadabum> oh
20131221 23:52:39< Coffee_irc> because of the new map zoom slider
20131221 23:53:01< Coffee_irc> you are not talking about that though I assume :P
20131221 23:53:08< zookeeper> no, i'm talking about scrolling
20131221 23:53:10< zookeeper> you know, the map
20131221 23:53:16< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master 5029dedd063e / src/hotkey/hotkey_command.cpp: Convert editor-selection-generate/randomize action labels to Title Case http://git.io/onDV7A
20131221 23:53:35< zookeeper> bumbadadabum, looks ok to me
20131221 23:53:37< Coffee_irc> zookeeper: that may have been the cause of the sound though
20131221 23:53:47< bumbadadabum> zookeeper: ok good
20131221 23:58:20< irker935> wesnoth: Ignacio R. Morelle wesnoth-old:master c24165a3e809 / src/hotkey/hotkey_command.cpp: Change the editor-tool-soundsource action label to not include a compound word http://git.io/LRpaLA
--- Log closed Sun Dec 22 00:00:19 2013