--- Log opened Thu Feb 20 00:00:25 2014 20140220 00:02:42< EliDupree> I suppose that could also be, like, a misaimed pointer or something in the code called by scroll_to_tile? That would explain the inconsistency and the fact that it sometimes it errors later, even though it's usually right then 20140220 00:03:01< EliDupree> I'm looking in display.cpp right now but I don't know the code well enough 20140220 00:03:56< EliDupree> The view is locked at the time, if that matters. I'm going to go test in 1.10.7 and see if it's any different 20140220 00:04:15-!- mattsc [~mattsc@154.20.32.246] has joined #wesnoth-dev 20140220 00:04:43-!- mjs-de [~mjs-de@f048201247.adsl.alicedsl.de] has quit [Remote host closed the connection] 20140220 00:08:09-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 00:10:05-!- aquileia [52d41a3a@gateway/web/freenode/ip.82.212.26.58] has quit [Quit: Page closed] 20140220 00:12:37-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 246 seconds] 20140220 00:14:09< EliDupree> Yup, same issue is present in 1.10.7 20140220 00:17:09-!- aquileia [52d41a3a@gateway/web/freenode/ip.82.212.26.58] has joined #wesnoth-dev 20140220 00:23:11< EliDupree> Oooh... nope, not a Wesnoth bug, although it was certainly bizarre. 20140220 00:24:27< EliDupree> Looks like I was accidentally using random generation in a lua_function= in a filter. Normally, I have a protection against calling random in desynced places... I set a global variable that says whether it's synchronized or not. 20140220 00:24:30< shadowm> Got to the Elvish Treasury with 1054 gold. 20140220 00:25:13< EliDupree> But since the lua_function was called DURING the other lua, the global context was the same and it falsely believed it was synchronized! 20140220 00:25:33< EliDupree> And scroll_to_tile was just the most likely place for that to happen 20140220 00:26:08< shadowm> Ooo finally I can recruit scouts. It was about time. 20140220 00:26:24< EliDupree> Trouble is, I don't see a way to work around that... 20140220 00:52:49< aquileia> is this really necessary? http://pastebin.com/uYFRUh5a 20140220 00:53:16-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev 20140220 00:58:26< shadowm> Gods, I hate saurians. 20140220 00:58:27< aquileia> does hits=hit include =kill ? 20140220 00:58:39< EliDupree> No, but hits=yes does 20140220 01:00:28< aquileia> Thanks! Then the second block could simply be deleted in the mentioned example 20140220 01:03:31-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has quit [Ping timeout: 245 seconds] 20140220 01:03:31< aquileia> Cleaning up mainline WML is desireable, isn't it? 20140220 01:03:52< shadowm> Probably best to ask Coffee_irc . IIRC there's something about how frames default to whatever was specified in another branch. 20140220 01:06:16< aquileia> Coffee_irc: Looking at the defense animation of the dark assassin, it seems the [else] block can be deleted: http://pastebin.com/uYFRUh5a 20140220 01:06:32< aquileia> shadowm, EliDupree: Thanks 20140220 01:08:25< aquileia> Coffee_irc: Or is there a fallback like stated in shadowm's comment? 20140220 01:12:16< aquileia> The implementation of DEFENSE_ANIM does suggest there is no need of the [else] tag here, but... 20140220 01:13:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140220 01:13:21-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: ancestral] 20140220 01:15:52< shadowm> Huh? 20140220 01:16:06< shadowm> Hm, 20140220 01:17:01-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140220 01:19:22-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev 20140220 01:20:29-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 01:25:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 272 seconds] 20140220 01:27:11-!- wesbot changed the topic of #wesnoth-dev to: 1.11.10 (start of string+feature freeze) planned for February 22nd | 223 bugs, 350 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140220 01:56:16-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 01:58:03-!- irker333 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20140220 02:00:36-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds] 20140220 02:03:17-!- aquileia [52d41a3a@gateway/web/freenode/ip.82.212.26.58] has quit [Quit: Page closed] 20140220 02:05:24< iceiceice> lipk: i think this fixes the issue with eras / modifications not being persistent in mp campaigns https://github.com/cbeck88/wesnoth-old/compare/carryover_mods_and_eras 20140220 02:05:39< iceiceice> i am still testing it, if you have time you might also try and let me know, or tell me if you see any problems 20140220 02:05:53< iceiceice> i might also refactor before actually committing 20140220 02:06:29< shadowm> lipkab: ^ 20140220 02:06:42< iceiceice> shadowm: thanks :) 20140220 02:07:33< mattsc> shadowm: is https://gna.org/bugs/?18921 only due to creating and killing units in debug mode or is there some other cause for it as well? 20140220 02:07:43< mattsc> Because if that's all, I think I have a fix for it. 20140220 02:08:01< shadowm> !commit c1374ba032a06510e741f0944547dfeb655edadd 20140220 02:08:01< shikadibot> shadowm: Revision c1374ba032a0 (ln-zookeeper) on Wed Feb 19 22:56:39 2014: 20140220 02:08:05< shikadibot> shadowm: Clarified 'Evacuation' now taking place at Lake Vrug. 20140220 02:08:07< shikadibot> shadowm: Web interface URL: https://github.com/wesnoth/wesnoth-old/commit/c1374ba032a0 20140220 02:08:23< shadowm> zookeeper: wtf 20140220 02:09:01< shadowm> That commit reverts some of my commits. 20140220 02:13:04-!- irker376 [~irker@ai0867.net] has joined #wesnoth-dev 20140220 02:13:04< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master b7848663bd41 / / (11 files in 3 dirs): Revert most of c1374ba032a06510e741f0944547dfeb655edadd http://git.io/Y-nLiQ 20140220 02:13:41< mattsc> shadowm: essentially, I'd say if another kill/create/recruit animation is currently in process, don't all the debug kill/create. 20140220 02:13:42-!- stikonas__ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Quit: Konversation terminated!] 20140220 02:14:29< mattsc> ... of the same unit, I mean. You can kill another unit before the die animation of the current one is done. 20140220 02:15:08< shadowm> mattsc: Because of animating units while an animation is being played. 20140220 02:15:09< mattsc> ... and the same for creating one. 20140220 02:15:36< mattsc> shadowm: right, but those debug events are the only ones I am aware of that actually cause that. 20140220 02:15:47< shadowm> I stumbled upon the same bug some time ago while testing a new unit animation with :debug :lua wesnoth.wml_actions.animate_unit [...] 20140220 02:16:57< shadowm> Because the game lets me use all commands even while an animation is playing. Triggering [animate_unit] on a unit that's already playing an animation (something which is only possible with :debug :lua) caused the assertion check AI0867 inserted somewhere to fail. 20140220 02:16:59< mattsc> Hmm, that one would not be taken care of by my fix, I think ... 20140220 02:18:50< mattsc> Yeah, I know, but AI0867's fix doesn't really make me happy. ;) Well, there might be another way. I'll do some more testing. 20140220 02:19:21< shadowm> It's decidedly not a fix, just a debugging aid. 20140220 02:19:46< shadowm> It's certainly better than causing a heisenbug situation. 20140220 02:20:17< mattsc> Yes, no argument there, on both of those 20140220 02:20:45< vultraz> Breaking Bad reference? 20140220 02:21:04< mattsc> I have an actual fix for the two debug menu options (doesn't even add lines; just makes two lines a little longer) 20140220 02:21:24< shadowm> vultraz: Uh? 20140220 02:21:40< vultraz> nevermind.. 20140220 02:22:26< mattsc> I'll look into a more general fix that would cover the :lua case as well later tonight 20140220 02:23:01-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 248 seconds] 20140220 03:00:05-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg] 20140220 03:07:44-!- Ivanovic_ [~ivanovic@x2f49a99.dyn.telefonica.de] has joined #wesnoth-dev 20140220 03:08:59-!- Velensk [~Velensk@cpe-75-187-86-211.woh.res.rr.com] has quit [Ping timeout: 252 seconds] 20140220 03:09:11-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has joined #wesnoth-dev 20140220 03:09:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Operation timed out] 20140220 03:09:38-!- Ivanovic_ is now known as Ivanovic 20140220 03:10:45-!- Ivanovic [~ivanovic@x2f49a99.dyn.telefonica.de] has quit [Changing host] 20140220 03:10:45-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140220 03:19:21-!- Grickit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140220 03:19:53-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 246 seconds] 20140220 03:30:13-!- aquileia [52d41a13@gateway/web/freenode/ip.82.212.26.19] has joined #wesnoth-dev 20140220 03:30:20-!- exciton_ [chuck-the-@77.51.150.225] has joined #wesnoth-dev 20140220 03:31:15-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20140220 03:31:59-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds] 20140220 03:33:51-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 260 seconds] 20140220 03:34:26-!- aquileia [52d41a13@gateway/web/freenode/ip.82.212.26.19] has quit [Client Quit] 20140220 03:39:25< mattsc> shadowm: ugh - it's worse than that, actually. 20140220 03:40:11< mattsc> If you create a unit and then kill it without animation (there's no added animation and no re-entry in that case), you get the segfault as well. 20140220 03:41:13< mattsc> It's because the animation gets removed with the unit, but then the animation engine tries to continue playing it (I think) 20140220 03:41:44< shadowm> What animation are we talking about here? (Also, what does "without animation" actually entail?) 20140220 03:41:52-!- exciton_ [chuck-the-@77.51.150.225] has quit [Read error: Connection reset by peer] 20140220 03:42:07-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140220 03:43:53< mattsc> I took the animation away from the shift-k kill option, but I presume that [kill]animate=no (called via :lua) will do it too. 20140220 03:44:26-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 03:44:45< mattsc> And to clarify (sorry): if you do a non-animated kill while the create (recruit) animation is playing, you get a segfault 20140220 03:45:33< mattsc> What I'd need is a unit->get_animation()->valid(), but that doesn't exist... 20140220 03:45:53< shadowm> tl;dr the animations engine makes too many assumptions, burn it with fire and build a new one from scratch. :p 20140220 03:46:20< mattsc> Hah - EasyCoding project for a GSOC application? ;) 20140220 03:46:51< shadowm> It might well be a good idea for next year's GSoC depending on how well the SDL 2 port goes. 20140220 03:46:56< mattsc> Stupid question: there's no way in C++ to check whether a pointer has been dereferenced, is there? 20140220 03:47:05< shadowm> Imagine all the neat stuff we could do once we get accelerated rendering. 20140220 03:47:27< mattsc> I can't even imagine, because I barely know what those words mean :P 20140220 03:47:29< shadowm> mattsc: No, unless you make a smart pointer class and override unary operator *. 20140220 03:48:59-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20140220 03:49:19< iceiceice> mattsc: maybe you can use a fancy pointer? 20140220 03:49:22< shadowm> For that matter, Boost provides a shared pointer class that is designed so the underlying object is destroyed only once it has ceased to be referenced by everyone. 20140220 03:49:53< iceiceice> yeah i mean i guess thats what we are all supposed to be using now? 20140220 03:49:54< mattsc> iceiceice: _I_ cannot (I'm barely semi-literate in C++), but maybe you can?? 20140220 03:50:09< shadowm> Etc.: 20140220 03:50:13< shadowm> http://www.boost.org/doc/libs/1_55_0/libs/smart_ptr/smart_ptr.htm 20140220 03:50:16< iceiceice> idk to be honest i learned C++ in like 2002, 20140220 03:50:50< iceiceice> when i start to read like BOOST::shared_ptr ... nested too many times, it feels very foreign 20140220 03:50:58< iceiceice> i'm not sure if its actually what you need either/ 20140220 03:51:09< mattsc> iceiceice, or whoever: I can point you to the exact place where the crash happens (and tell you what the symptoms are and what one would need to know to fix it), but I have no idea how to code that. 20140220 03:51:11< iceiceice> how about this maybe we trade problems 20140220 03:51:26< iceiceice> i'll try to figure out whats going on with your pointer thing, 20140220 03:51:41< iceiceice> you figure out how to integrate a dummy ai which simply loops into the playcontroller system :p 20140220 03:51:58< mattsc> can I do that in Lua? :P 20140220 03:52:02 * shadowm is busy with Python. 20140220 03:52:21< iceiceice> i hope you can! 20140220 03:52:30< iceiceice> i actually have only a tenuous grasp on that part 20140220 03:52:35< iceiceice> uhm 20140220 03:52:37< iceiceice> i would like to fix this: 20140220 03:52:38< iceiceice> https://gna.org/bugs/index.php?21405 20140220 03:53:53< mattsc> iceiceice: Can we chat tomorrow? Real life is growing over my head here atm ... 20140220 03:54:02< iceiceice> hehe ok 20140220 03:54:12< mattsc> I'll just show you where the crash happens, if you want to have a look already 20140220 03:54:22< iceiceice> alright sure 20140220 03:54:40< mattsc> iceiceice: https://github.com/wesnoth/wesnoth-old/blob/30c3a9c287a0e3420c918181a6de6b79e01c2b2f/src/unit_animation.cpp#L1428 20140220 03:55:07< mattsc> anim->my_unit->get_animation() works, but anim->my_unit->get_animation()->animation_finished_potential() causes a segfault 20140220 03:55:19< iceiceice> that's wierd 20140220 03:55:21< iceiceice> what does &= mean? 20140220 03:55:26< iceiceice> oh just mask? 20140220 03:55:27< iceiceice> assign? 20140220 03:55:32< iceiceice> ok that was a silly question i guess 20140220 03:55:50< mattsc> Easiest way to test: open any game and hit shift-k twice quickly on the same unit. 20140220 03:56:09< shadowm> foo &= bar is foo = foo & bar IIRC. 20140220 03:56:14< iceiceice> i see 20140220 03:56:23< shadowm> I have to admit all the bitwise stuff goes over my head. 20140220 03:56:30< mattsc> You need to press it the second time before the animation from the first one is done playing (so setting accelartion to 0.25 is helpful) 20140220 03:56:54< mattsc> baeh, typing too fast, too many typos (I really need to go) 20140220 03:57:11< mattsc> Oh, and you need to remove the two asserts first, of course, otherwise you never get ther. 20140220 03:57:14< mattsc> e 20140220 03:57:33< mattsc> Anyways, I'll stay online but will be away from the computer for a while. TTYL. 20140220 03:58:49< iceiceice> ok so i know very little about the animation code base 20140220 03:58:52< iceiceice> or wesnoth animations in general 20140220 04:02:09< mattsc> Well, neither do I, but from what I have seen: the first animation gets started and goes into that loop I pointed to. 20140220 04:03:14< mattsc> During that time, the second animation (for the same unit) gets started and plays through, after which the unit gets killed (l. 1044 in menu_events.cpp), which removes the animation. 20140220 04:03:42< mattsc> Then the first animation tries to pick up again and crashes, because the animation pointer was dereferenced (or whatever the right words are here). 20140220 04:04:10< mattsc> So, if we somehow could check whether anim->my_unit->get_animation() is still valid, we'd be all set. 20140220 04:04:20< mattsc> And now I'm off for real ;) 20140220 04:04:49< mattsc> Sorry, line 1144 in menu_events.cpp 20140220 04:28:56-!- Grickit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20140220 04:48:40-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has quit [Quit: Leaving] 20140220 05:00:43-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140220 05:03:48< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master a15f89e8732a / data/tools/wmllint: wmllint: Fix incorrect ToD schedule image substitution http://git.io/FsLPgA 20140220 05:03:51< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master d16ec0cf9efe / data/tools/wmllint: wmllint: Add check for deprecated [theme] name= usage http://git.io/KYb81w 20140220 05:03:54< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master e2bc4a9de72b / data/tools/wmllint: wmllint: Add check for user-visible [theme]s without a name or description http://git.io/KYDhFw 20140220 05:06:01< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 16677d019e89 / data/tools/wmllint: wmllint: Add check for [theme]s without an id http://git.io/yOjLdg 20140220 05:17:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 272 seconds] 20140220 05:17:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20140220 05:32:33-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 05:37:16-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds] 20140220 06:20:06-!- SigurdFD [~SigurdFD@24.154.98.89] has joined #wesnoth-dev 20140220 06:29:12-!- SigurdFD [~SigurdFD@24.154.98.89] has quit [] 20140220 06:48:01< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 93e6930593f5 / data/tools/wmllint: wmllint: Spellcheck [terrain_type] editor_name= and help_topic_text= http://git.io/xVaiLw 20140220 06:48:04< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master cfef162e4001 / data/core/terrain.cfg: Add wmllint spelling exception for 'unwalkable' http://git.io/gaR_pg 20140220 06:48:07< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 561b9146432c / data/core/terrain.cfg: Fix typo: 'facilites' -> 'facilities' http://git.io/YtO41Q 20140220 06:48:10< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master e1d159ad31d9 / data/core/terrain.cfg: 'rarified' -> 'rarefied' http://git.io/NpbX1A 20140220 06:48:13< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master a5a357eaa382 / data/campaigns/Eastern_Invasion/scenarios/08_Training_the_Ogres.cfg: EI S8: Disable spellchecking for a single line http://git.io/ZyCT7Q 20140220 06:50:20-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 06:54:30< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 9932b289d784 / data/campaigns/Heir_To_The_Throne/utils/httt_utils.cfg: HttT: Prevent wmllint from complaining about UK spelling in a WML comment http://git.io/PVdFTA 20140220 06:54:33< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master e0e486aa0bfd / data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg: THoT S12: Move a couple of macros down to appease wmllint's [message] id check http://git.io/-GLqLg 20140220 07:20:46-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 07:22:44-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20140220 07:25:11-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds] 20140220 07:27:11-!- wesbot changed the topic of #wesnoth-dev to: 1.11.10 (start of string+feature freeze) planned for February 22nd | 223 bugs, 349 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140220 07:28:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140220 07:29:08< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master e1852e685487 / data/tools/wmllint: wmllint: Implement [terrain_type] aliasof conversion for changes in 1.11.[89] http://git.io/AZSJWQ 20140220 07:29:17< shadowm> fabi: ^ 20140220 07:29:54< shadowm> fabi: It'd be nice if you could double-check the aliaschanges tuple from that commit. 20140220 07:30:21< shadowm> (Okay, let's be honest, how many of you thought I had completely forgotten about the aliasof situation?) 20140220 07:34:20< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master dd4dc91a9e1a / data/tools/wmllint: wmllint: Add a small comment block http://git.io/Zs7J4g 20140220 07:41:01< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 184af275ebac / data/tools/wmllint: wmllint: Ignore Mercurial .hg directories http://git.io/naqOpQ 20140220 07:44:25< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 8e7242927df3 / data/tools/wmllint: wmllint: Extend [terrain_type] aliasof conversion to mvt_alias http://git.io/LY37yw 20140220 07:47:13< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 181c64d70d1a / data/tools/wmllint: wmllint: Extend [terrain_type] aliasof conversion to def_alias http://git.io/EU9hHg 20140220 07:47:59-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140220 07:55:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20140220 08:00:24< zookeeper> shadowm, uh... 20140220 08:00:56< zookeeper> weird. i reverted those commits locally, but i have no idea how they could have possibly ended up as part of the EI commit. 20140220 08:01:16< shadowm> Why did you revert them locally and how? 20140220 08:01:50< zookeeper> because they stopped the editor working with an older binary, and i just went to the log, selected those commits and chose "revert changes from these revisions" or whatever 20140220 08:02:25< shadowm> And then you chose to commit all changed files later? 20140220 08:02:45< zookeeper> after that i saw the revertions as local changes to said files, so i figured it didn't make a commit out of it so it's still safe to push afterwards 20140220 08:03:15< zookeeper> not that i know of; i have a bunch of other local changes too, so when i open the commit dialog i deselect everything and then select only the files i want to commit 20140220 08:03:22< zookeeper> so i don't know how those could have ended up being part of it 20140220 08:04:04< zookeeper> same with the accidental arne commit, really. i dunno how the image file could have gotten selected either. 20140220 08:04:34< shadowm> Accidental arne commit? :p 20140220 08:04:55 * zookeeper silently releases arne from the asylum 20140220 08:05:06< shadowm> Ah, in 5ef69805070f734a9f8a18fed159451f3aaff7c0 . 20140220 08:06:14< zookeeper> yes 20140220 08:07:11< shadowm> If you are in urgent need of a new binary I can my codeblocks -O3 build. 20140220 08:07:20< shadowm> upload 20140220 08:07:29< zookeeper> nah, it works fine for now 20140220 08:12:53< zookeeper> i can only theorize that tortoisegit silently makes commits out of some operations like renaming or reverting (the way i did them anyway) even though it also leaves them in as uncommitted local changes... that wouldn't make any sense but we're in git-land so... uh, i dunno. 20140220 08:13:37< shadowm> I can't deny or confirm that suspicion on account of my utter lack of experience with third-party Git front-ends. 20140220 08:13:48< zookeeper> i find it hard to believe i've suddenly caught a case of not being able to select what i intend in the commit dialog. 20140220 08:13:52< shadowm> git revert would create a commit with the reversed patch without -n, anyway. 20140220 08:15:13< shadowm> I just hope no other commits have been silently reverted as of late, because that'd be a bad thing. 20140220 08:15:59< shadowm> I for one am too busy to go and scan `git log --stat` for suspicious stuff right now. 20140220 08:16:53< zookeeper> well i scanned my own commits, doesn't look like there's any other screwups 20140220 08:16:58< shadowm> I only found out that happened because I saw an unusual diffstat after my previous pull. 20140220 08:17:27< shadowm> Morale of the story: always look at the diffstat after a pull. 20140220 08:17:28< zookeeper> good that you did :> 20140220 08:17:59< shadowm> Also before a push. 20140220 08:18:59< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 0c459c0689f7 / projectfiles/CodeBlocks/wesnoth.cbp: CodeBlocks project update http://git.io/c3mrFg 20140220 08:19:04< zookeeper> well... 20140220 08:24:22< shadowm> Huh, where in UtBS scenario 8 is the ally recalled? 20140220 08:24:40< shadowm> Ohhh nvm. 20140220 08:33:46< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master d756074658e4 / data/campaigns/Under_the_Burning_Suns/utils/terrain.cfg: UtBS: Fix indirect terrain aliasing: Mm -> Mt http://git.io/J0fWCQ 20140220 08:33:49< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 063c35251d27 / data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg: UtBS S8: Add wmllint: recognize directives for units created in later event http://git.io/dL00AQ 20140220 08:33:52< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 7f60c43424ea / data/campaigns/Under_the_Burning_Suns/scenarios/ (5 files): UtBS: Add wmllint: recognize directives for dwarf/troll allies in S8 onwards http://git.io/0pcx2g 20140220 08:33:55< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 47f0a08cc5b0 / data/campaigns/Under_the_Burning_Suns/scenarios/11_Battle_for_Zocthanol_Isle.cfg: UtBS S11: Fix a broken [message] speaker= attempt caught by wmllint http://git.io/5dX0og 20140220 08:37:59< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master 58d11d7f0752 / data/campaigns/Legend_of_Wesmere/scenarios/chapter1/03_Kalian_under_Attack.cfg: LoW S3: Kill a unit that was stored and never used again, caught by wmllint http://git.io/_0KXeA 20140220 08:38:22-!- blarumyrran [~Bbbb123@wesnoth/artist/blarumyrran] has joined #wesnoth-dev 20140220 08:39:37< shadowm> Urudin is not supposed to die? What. 20140220 08:40:28< shadowm> I killed him in turn 9. 20140220 08:48:50< irker376> wesnoth: Ignacio R. Morelle wesnoth-old:master ab35f3028789 / data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg: HttT S17: Add a wmllint: noconvert directive amidst Lua code http://git.io/lbR1IQ 20140220 08:49:12< shadowm> And now, mainline runs wmllint clean again! Woo-hoo! 20140220 08:49:49< shadowm> (Given a definition of 'mainline' that excludes LoW, anyway: ) 20140220 09:09:00-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 09:13:23-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 246 seconds] 20140220 09:33:02-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20140220 09:41:16-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Crab_] 20140220 09:50:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 264 seconds] 20140220 09:52:28-!- mjs-de [~mjs-de@f049139146.adsl.alicedsl.de] has joined #wesnoth-dev 20140220 10:03:26-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20140220 10:08:09-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20140220 10:12:08-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 10:14:49< Soliton> iceiceice: i think it's fine to continue to use pull requests if you like. i'd assume people will tell you if it really annoys them. (which i find unlikely) 20140220 10:15:22-!- cib0 [~cib@p5DC75F9F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140220 10:18:01-!- cib0 [~cib@p5DC75F9F.dip0.t-ipconnect.de] has quit [Client Quit] 20140220 11:19:43-!- aquileia [5fd017e3@gateway/web/freenode/ip.95.208.23.227] has joined #wesnoth-dev 20140220 11:33:10< aquileia> zookeeper: Last week my attempt to clone the repo timed out after about 4 hours at 10%, and now it completed in 20 minutes... so I just went ahead and made https://github.com/wesnoth/wesnoth-old/pull/99 20140220 11:33:32< aquileia> hope it is to your liking 20140220 11:36:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140220 11:39:09< aquileia> As nobody answered yesterday, I tried for 2 hours but didn't get wesnoth-optipng running... so a run would be necessary after the pull request 20140220 11:40:59< vultraz> if anyone's interested, I rewrote http://wiki.wesnoth.org/BuildingMaps . I also moved the section on map format to http://wiki.wesnoth.org/TerrainCodesWML since it seemed for relevant there 20140220 11:41:13< vultraz> s/format/encoding 20140220 11:41:37< aquileia> I still would like to know: How can I run it on Windows? The cmd shell is incompatible it seems, and I had even more problems installing MSYS 20140220 11:42:06< zookeeper> aquileia, i use http://pnggauntlet.com/ myself 20140220 11:42:59< zookeeper> and i've been very happy with it. seems very slow on big images, but it does seem to compress really really well. 20140220 11:43:09< aquileia> Shall I apply it and update the pull request? 20140220 11:43:25< zookeeper> i wouldn't mind 20140220 11:47:01-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140220 11:52:59< fabi> vultraz: BuildingMaps will confuse map editor users. 20140220 11:53:37-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140220 11:54:01-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer] 20140220 11:54:15-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140220 11:55:09< fabi> vultraz: Do you plan to rewrite BuildingScenarios as well? 20140220 12:06:28-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20140220 12:22:23-!- irker376 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20140220 12:24:04-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20140220 12:29:03< zookeeper> mattsc, i'm trying to get my rewrite of EI's "captured" scenario in before the freeze, and i'm wondering what the easiest way to do the following is these days: 20140220 12:30:14< zookeeper> player side 1, enemy AI side 2, player-allied side 3 (no AI needed); side 2 must ignore everyone and basically do nothing at all, until an event happens, after which it should attack side 1 normally, but continue ignoring side 3 20140220 12:30:47< zookeeper> wait, nevermind all that, that's not really accurate 20140220 12:32:00< zookeeper> let's try again: 20140220 12:33:20< zookeeper> player side 1, enemy AI side 2; side 2 units must ignore player units they do not see or which match filter X. 20140220 12:33:51< zookeeper> it's a wonder how you can simplify things with such a small amount of thinking :p 20140220 12:34:53< zookeeper> (and "units they do not see" simply meaning that the AI side would have fog) 20140220 12:35:53< aquileia> zookeeper: There is a portrait by LordBob for this occasion waiting at wesnoth-resources -- I assume filter X means they are disguised 20140220 12:36:14< zookeeper> yes, this is what it's intended for 20140220 12:37:02< zookeeper> been sitting unused for a few years waiting for me to finish the rewrite :p 20140220 12:43:18< aquileia> zookeeper: As soon as Travis has finished (no idea why it recompiles if no source has changed) the pull request is ready to go 20140220 12:43:35< aquileia> By the way: Comparing optipng (not the wesnoth extension) and pnggauntlet: 8,59 kB to 8,43 kB 20140220 12:54:49< aquileia> zookeeper: In the meantime, feel free to merge https://github.com/aquileia/wesnoth-resources/pull/1 20140220 12:59:40< zookeeper> shouldn't those two commits be squashed (i believe that's the git term) first? it doesn't make sense to have the uncompressed ones go in as well. 20140220 13:02:36-!- stikonas_ [~gentoo@cpat003.wlan.net.ed.ac.uk] has joined #wesnoth-dev 20140220 13:02:36-!- stikonas_ [~gentoo@cpat003.wlan.net.ed.ac.uk] has quit [Changing host] 20140220 13:02:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140220 13:02:41< aquileia> No idea how to do that... 20140220 13:02:57-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140220 13:03:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds] 20140220 13:03:19< zookeeper> ok, well, it's not like it's important or anything 20140220 13:04:19< zookeeper> let's see what happens 20140220 13:05:31< zookeeper> i dunno why it told me it was safe to delete a khalifate++ branch after merging, but if it says it's safe then i guess it was safe. 20140220 13:05:39< aquileia> Yes 20140220 13:06:03< aquileia> It was only there to contain the commit 20140220 13:06:44< aquileia> Now its usefullness has expired 20140220 13:06:46< zookeeper> i suppose irker doesn't report pushes to the resources branch 20140220 13:07:08< zookeeper> not that i get any mail either 20140220 13:07:28< zookeeper> oh well, i'll go afk for a time, maybe it'll sort itself out in the meantime -> 20140220 13:07:37< aquileia> Well, this wasn't resources but wesnoth-resources 20140220 13:07:53< aquileia> not part of the official project 20140220 13:23:04< aquileia> I tried to squash the two commits, but it seems only to affect my local clone 20140220 13:25:54< aquileia> So unfortunately I wont get rid of the unnecessary entry to the commit history 20140220 13:37:22< aquileia> shadowm, Coffee_irc : I commented out the [else] block I mentioned tonight (http://pastebin.com/uYFRUh5a) and the behaviour is the same - there is an impact sound on kill, but no groan 20140220 13:37:47< aquileia> So I think it'd be safe to erase 20140220 13:38:33-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 13:40:32< aquileia> The file is data\campaigns\Under_the_Burning_Suns\units\orcs\Dark_Assassin1.cfg 20140220 13:43:06-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds] 20140220 13:50:41-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 245 seconds] 20140220 13:54:16< aquileia> Oh... while searching for other issues (to justify a pull request) I found most of UtBS units still use the old syntax. They won't be replaced before 1.12 it seems... should I convert them? 20140220 13:55:49< aquileia> And IIRC sometime in the future "begin" will become deprecated, so these have to be treated one way or another. 20140220 13:56:03< AI0867> zookeeper: if you want a recent build: http://baldras.wesnoth.org:8080/job/Wesnoth/compiler=mingw32,label=Debian6-64/ws/ (there should be a downloadable wesnoth.exe there) 20140220 13:58:09< zookeeper> AI0867, right, thanks 20140220 13:59:16< zookeeper> aquileia, can you add changelog entries for the shadow mages? "Updated sprites for Shadow Mage line." for instance, under campaigns -> liberty 20140220 13:59:38< zookeeper> i was about to press the big green button when i noticed those are missing 20140220 13:59:44-!- Netsplit *.net <-> *.split quits: enchilado 20140220 13:59:44< aquileia> blarumyrran: Your mages are currently here: https://github.com/wesnoth/wesnoth-old/pull/99 20140220 13:59:50-!- aquileia [5fd017e3@gateway/web/freenode/ip.95.208.23.227] has quit [Quit: Page closed] 20140220 14:00:11-!- aquileia [5fd017e3@gateway/web/freenode/ip.95.208.23.227] has joined #wesnoth-dev 20140220 14:01:10< aquileia> zookeeper: My browser crashed before I coul read your messages, I just checked the log 20140220 14:01:59-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 260 seconds] 20140220 14:02:20-!- Netsplit over, joins: enchilado 20140220 14:03:13< aquileia> No problem 20140220 14:07:12-!- justinzane_ [~justinzan@tiny.justinzane.com] has joined #wesnoth-dev 20140220 14:08:57-!- apoi_ [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev 20140220 14:10:47-!- justinzane [~justinzan@tiny.justinzane.com] has quit [Write error: Connection reset by peer] 20140220 14:11:01-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has quit [Write error: Connection reset by peer] 20140220 14:11:01-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Write error: Connection reset by peer] 20140220 14:12:02-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140220 14:12:33-!- mattsc [~mattsc@154.20.32.246] has quit [Quit: Computer's napping] 20140220 14:14:34-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20140220 14:17:44-!- _8680_ [~8680@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 245 seconds] 20140220 14:18:22< aquileia> Again squash didn't work, but the PR now includes a changelog entry. 20140220 14:19:31-!- Guest96472 [~8680@2002:4404:712c:0:fda5:4961:1277:f12a] has joined #wesnoth-dev 20140220 14:20:19< aquileia> zookeeper, blarumyrran : As I sent this while crashing, here again: https://github.com/wesnoth/wesnoth-old/pull/99 20140220 14:20:24-!- irker960 [~irker@ai0867.net] has joined #wesnoth-dev 20140220 14:20:24< irker960> wesnoth: aquileia wesnoth-old:master 3d781813bdee / data/campaigns/Liberty/ (26 files in 3 dirs): graphics update for the shadow mage line http://git.io/G6bgkQ 20140220 14:20:24< irker960> wesnoth: aquileia wesnoth-old:master 602930ac42cd / data/campaigns/Liberty/images/ (21 files in 2 dirs): png optimisation http://git.io/K28-9A 20140220 14:20:24< irker960> wesnoth: aquileia wesnoth-old:master 7970dc369a90 / changelog: graphics update for the shadow mage line http://git.io/invWfw 20140220 14:20:25< irker960> wesnoth: Lari Nieminen wesnoth-old:master 68c2bd895398 / / (27 files in 4 dirs): Merge pull request #99 from aquileia/master http://git.io/TQM3vg 20140220 14:20:49< aquileia> Thanks! 20140220 14:20:51< zookeeper> the changelog entry was misindented, but i'll fix that when i update it myself then :p 20140220 14:22:19-!- mattsc [~mattsc@207.230.251.234] has joined #wesnoth-dev 20140220 14:24:39-!- Guest96472 [~8680@2002:4404:712c:0:fda5:4961:1277:f12a] has quit [Ping timeout: 245 seconds] 20140220 14:26:31< aquileia> zookeeper: Next time, I'll try to think of squash and changlog update in time. Thanks again! 20140220 14:27:07-!- mattsc [~mattsc@207.230.251.234] has quit [Read error: Connection reset by peer] 20140220 14:27:14-!- ujdf [~V@72-69-ftth.on.nl] has joined #wesnoth-dev 20140220 14:27:30-!- mattsc [~mattsc@207.230.251.234] has joined #wesnoth-dev 20140220 14:27:58-!- {V} [~V@72-69-ftth.on.nl] has quit [Disconnected by services] 20140220 14:28:05-!- ujdf is now known as {V} 20140220 14:30:31-!- Ivanovic_ [~ivanovic@x2f49a99.dyn.telefonica.de] has joined #wesnoth-dev 20140220 14:31:22< mattsc> zookeeper: I don't think that exact functionality exists, but maybe we can approximate it. Let me see if I understand what you want. 20140220 14:31:32< mattsc> By "ignoring player units", I assume you mean that they should not move toward them while out of attack range? So what should the AI units be doing instead? 20140220 14:31:41-!- nurupo_ [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20140220 14:33:04-!- _8680__ [~8680@2002:4404:712c:0:20e1:190:1169:3cef] has joined #wesnoth-dev 20140220 14:33:25< zookeeper> mattsc, i think ai_special=guardian is all that's needed in this case, after my round of simplification :p 20140220 14:33:26< mattsc> AI units never go for non-leader enemy units anyway, the only default goals are enemy leaders and villages. You might be able to make use of that by setting canrecruit=no for the player's leader during the AI turn. 20140220 14:33:58-!- cib0 [~cib@132.231.178.96] has joined #wesnoth-dev 20140220 14:34:27< mattsc> zookeeper: sure that would be one way - unless you want the AI also to go for units they have discovered but that are out of attack range for a given unit. 20140220 14:34:42-!- thunders1ruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20140220 14:35:04< zookeeper> doesn't seem worth the trouble in this case, actually 20140220 14:35:24< mattsc> Okay, no complaints from my side. 20140220 14:35:47< zookeeper> the enemies will in almost all cases move faster than the player anyway, given the terrain, so you can't really get rid of them by running away 20140220 14:36:02< mattsc> You could do that quite easily with the Goto MAI, if you change your mind. 20140220 14:36:27< mattsc> okay 20140220 14:36:43< zookeeper> right, i'll have to see how this actually ends up working 20140220 14:38:10-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Ping timeout: 245 seconds] 20140220 14:38:13-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 245 seconds] 20140220 14:38:14-!- nurupo_ is now known as nurupo 20140220 14:38:17-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.] 20140220 14:38:24-!- _8680__ [~8680@2002:4404:712c:0:20e1:190:1169:3cef] has quit [Ping timeout: 252 seconds] 20140220 14:38:25-!- Ivanovic_ is now known as Ivanovic 20140220 14:46:11< vultraz> fabi: yes, I plan to update BuildingScenarios as well 20140220 14:47:29-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 14:47:36< vultraz> fabi: what do you mean by "it will confuse map editor users"? 20140220 14:47:45-!- _8680__ [~8680@2002:4404:712c:0:1df7:2d97:9ef2:9ccc] has joined #wesnoth-dev 20140220 14:52:28< AI0867> zookeeper: you have an account there, so you can trigger a new build yourself if you need it 20140220 14:52:42-!- _8680__ [~8680@2002:4404:712c:0:1df7:2d97:9ef2:9ccc] has quit [Ping timeout: 252 seconds] 20140220 14:53:31-!- _8680__ [~8680@2002:4404:712c:0:1df7:2d97:9ef2:9ccc] has joined #wesnoth-dev 20140220 14:53:37< mattsc> Hi vultraz: I forgot what the outcome of that was, are you going to re-add the tooltips to the replay buttons? 20140220 14:54:19< zookeeper> AI0867, it's so extremely confusing site that i think i'll pass trying to mess with it 20140220 14:54:26-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140220 14:54:45< zookeeper> i can barely find the download link by clicking on random links for a while 20140220 14:55:21< vultraz> mattsc: I do not have easy access to a repo clone at this time 20140220 14:56:28< mattsc> vultraz: ah, I think I knew this. 20140220 14:56:42< mattsc> fabi: is it on your list? ^ 20140220 14:57:26< vultraz> I *think* it's simple, though 20140220 14:57:29 * vultraz checks 20140220 14:57:56< aquileia> Espreon, zookeeper : With 7 maintainers listed for UtBS, I thought I'd ask just you two... will the unit animation frames be overhauled soonish or is a separate syntax update before 1.12 necessary? Most units still use the "begin" parameter which will be deprecated sometime in the future 20140220 14:58:24-!- _8680__ [~8680@2002:4404:712c:0:1df7:2d97:9ef2:9ccc] has quit [Ping timeout: 245 seconds] 20140220 14:58:29< zookeeper> aquileia, no one's planning up updating those anytime soon, i'm pretty sure 20140220 14:58:42< aquileia> So should I update them? 20140220 14:58:54< aquileia> Not the content, just the code 20140220 14:59:01< zookeeper> as long as it's not deprecated in 1.12, i see no reason to update those just yet 20140220 14:59:07< zookeeper> if you want to, then sure, there's no harm in it 20140220 14:59:50< vultraz> yeah, UtBS is kinda...a can of worms 20140220 15:00:12< aquileia> Out of interest, when is it going to be deprecated? 20140220 15:00:39 * zookeeper doesn't know 20140220 15:00:45 * vultraz has no idea 20140220 15:01:12< aquileia> Coffee_irc: ^ 20140220 15:04:15< Soliton> aquileia: if you want change commit history you need to force push, which is a bad idea for public history though usually ok for a pull request (especially if a reviewer asks for it). 20140220 15:05:40-!- Yukiria [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20140220 15:05:55-!- stikonas [~gentoo@maths-pgs-002.maths.ed.ac.uk] has joined #wesnoth-dev 20140220 15:05:55-!- stikonas [~gentoo@maths-pgs-002.maths.ed.ac.uk] has quit [Changing host] 20140220 15:05:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140220 15:05:55-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 260 seconds] 20140220 15:05:59-!- Yukiria is now known as vultraz 20140220 15:08:46-!- _8680_ [~8680@2002:4404:712c:0:5fd:3b78:aa98:4f1d] has joined #wesnoth-dev 20140220 15:08:48-!- _8680_ is now known as Guest32859 20140220 15:09:10-!- mattsc [~mattsc@207.230.251.234] has quit [Quit: Computer's napping] 20140220 15:10:50-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host] 20140220 15:10:50-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20140220 15:19:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140220 15:19:59< aquileia> It seems it is already deprecated... 20140220 15:20:52< zookeeper> so does UtBS produce user-visible deprecation messages? 20140220 15:21:18< aquileia> No 20140220 15:21:26-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20140220 15:21:58< aquileia> Soliton: Thanks, this helps a lot - I thought I'd have to stop syncing to be able to squash 20140220 15:24:02< vultraz> Ivanovic: you asked me to take a look at the abilities. It seems a bunch of them are not listed in the manual 20140220 15:24:08< aquileia> zookeeper: r.wesnoth.org/p546850 and the wiki state it is deprecated 20140220 15:25:00< aquileia> But no consequencces ingame 20140220 15:26:44-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 15:27:02-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20140220 15:28:40-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Quit: brb] 20140220 15:31:31-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds] 20140220 15:37:43< zookeeper> mattsc, ok, so, correction: guardian alone won't do because they still need to ignore one particular unit. is there any simple [ai] addition i can do to accomplish that? 20140220 15:38:40< mattsc> zookeeper: ignore for attacks or for moving toward while out of attack range? 20140220 15:38:57< zookeeper> ignore in every way imaginable :P 20140220 15:39:16-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20140220 15:39:16< aquileia> perhaps attack weight = 0 ? 20140220 15:40:09< mattsc> zookeeper: well, I can imagine lots of things. :P Let me rephrase. Are they not supposed to seek out that unit, or even ignore it when they accidentally stumble upon it? 20140220 15:40:37< mattsc> s/ignore/avoid 20140220 15:41:25< mattsc> aquileia: that will just disable an attack of a unit, it has nothing to do with what enemies get attacked. 20140220 15:42:04< zookeeper> they should behave as guardians do; not do anything unless an enemy is in range... or if said enemy matches filter X. 20140220 15:43:27< mattsc> If it matches the filter, they are also not supposed to attack? 20140220 15:43:29< aquileia> I don't really understand... isn't it used to give attacks on leaders additional weight? Perhaps I mess up the names... 20140220 15:43:52< zookeeper> mattsc, attacking would count as doing something, so yes 20140220 15:44:15< mattsc> zookeeper: well, everything else is accomplished by the guardian already, isn't it? 20140220 15:44:19< zookeeper> yes 20140220 15:44:25< mattsc> zookeeper: http://wiki.wesnoth.org/AiWML#Filtering_Combat_with_the_.27attacks.27_Aspect 20140220 15:44:42< zookeeper> as it happens i was just looking at that ;) 20140220 15:45:15< zookeeper> looks like it's exactly what i needed 20140220 15:45:47< mattsc> aquileia: maybe you mean leader_value? But that that's just for moving toward the leader, not attacking. 20140220 15:49:55< zookeeper> mattsc, seems to work perfectly now 20140220 15:50:13< mattsc> great 20140220 15:51:07< zookeeper> i wonder why my stderr is flooded with stuff like this: 20140220 15:51:08< zookeeper> 20140220 17:48:09 error engine: Formula in WML string cannot be evaluated due to Could not parse expression 20140220 15:51:08< zookeeper> --> "1 2 " 20140220 15:53:21< fabi> mattsc: Tooltips for the replay buttons? 20140220 15:53:43< aquileia> mattsc: I read it up, it was the [target] tag which is now deprecated. 20140220 15:54:42< aquileia> thanks for the clarification 20140220 15:58:37< fabi> vultraz: The wiki gives hints about scenarios. And the map editor has a scenario mode. But the wiki does not talk about that mode. 20140220 16:02:37< vultraz> fabi: I will add more detail about that soon 20140220 16:10:15< vultraz> Would make things easier if I could upload images to go with the article 20140220 16:11:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 16:11:50< mattsc> fabi: yes, exactly. Why aren't there any in trunk? There are in 1.10. 20140220 16:12:32< mattsc> aquileia: [target] has been replaced by [goal] now, so it still exists. But again, it has nothing to do with attacks. 20140220 16:15:38< fabi> mattsc: Propably because tooltips can be taken from the theme or from the hotkey action definition since a while now. 20140220 16:20:49-!- blarumyrran [~Bbbb123@wesnoth/artist/blarumyrran] has quit [Quit: Leaving] 20140220 16:21:23< mattsc> fabi: okay (I think I understand that). Could we add them back in? 20140220 16:26:03-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [] 20140220 16:32:39< aquileia> SingleUnitWML has no clues when the gender parameter is needed... is "gender=male,female" useful? The elves have it, the desert elves not. 20140220 16:42:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140220 16:46:59< zookeeper> aquileia, i dunno, should be easy to check. 20140220 16:49:28< aquileia> It isn't needed (else UtBS would error) but its use in core must have a reason I thought... perhaps legacy, perhaps coding standards 20140220 16:51:16< fabi> mattsc: Yes, sure. It is on my TODO now. 20140220 16:51:59< mattsc> fabi: great, thanks 20140220 16:52:50< fabi> vultraz: It would make more sense to write an ingame help section instead. There you can put images in. 20140220 16:53:00< vultraz> On the editor? 20140220 16:53:07< vultraz> Ok 20140220 16:53:24< vultraz> But I won't be able to do it before the string freeze 20140220 16:54:39-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 16:55:10-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev 20140220 16:55:12< mattsc> iceiceice: I am around now to discuss your ideas on FR #21405. Btw, you cannot droid a side _during_ its turn, it won't take effect until the next time it's the side's turn. 20140220 16:55:33< mattsc> Well, that's true for the :droid debug command at least, I don't know if you could do it from C++. 20140220 16:55:40< iceiceice> i see 20140220 16:55:58< iceiceice> one sec let me find my link again 20140220 16:56:22< iceiceice> so basically i want to have some better options to go here: 20140220 16:56:22< iceiceice> https://github.com/wesnoth/wesnoth-old/blob/master/src/playturn.cpp#L283 20140220 16:57:28-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has joined #wesnoth-dev 20140220 16:57:32< iceiceice> so what i'm imagining is we could have a "put side in idle mode" option 20140220 16:57:35< Dugi> Hello. 20140220 16:57:49< iceiceice> which would droid it but instaed of "human_ai" it goes to "loop_ai" or something 20140220 16:57:57< fabi> hi Dugi 20140220 16:58:05< vultraz> hey Dugi 20140220 16:58:28< iceiceice> unfortunately i haven't figured out either step amongst, making the play controller code recognize "loop_ai" or actually figuring out how to write and register loop_ai 20140220 16:58:31< Dugi> I forgot to ask how can I test the interaction between the client and the campaign server. 20140220 16:58:33< mattsc> So the AI just sits there in an infinite loop, essentially, thinking and not doing anything? 20140220 16:58:36< iceiceice> yeah 20140220 16:59:04< iceiceice> maybe it sends a chat message "this ai will not do anything or end turn, to proceed you must change controller" 20140220 16:59:18< vultraz> iceiceice: but why 20140220 16:59:33< vultraz> I mean, I fail to see the application 20140220 16:59:51< iceiceice> its for this: 20140220 16:59:52< iceiceice> https://gna.org/bugs/?21405 20140220 17:00:15< fabi> Dugi: Start a local one? 20140220 17:00:26< mattsc> iceiceice: it would be easy to write a candidate action whose evaluation is something like this: 20140220 17:00:31< iceiceice> so basically if players are playing an mp game, we dont give them good ways to deal with one player dc'ing 20140220 17:00:53< mattsc> while (some_flag_is_set) do wait(100ms) end (or something) 20140220 17:01:06< iceiceice> yeah that sounds perfect 20140220 17:01:19< Dugi> fabi: How do I do that? I haven't found the executable yet, only wesnoth and wesnothd, nothing else is compiled. 20140220 17:01:20< mattsc> I don't know if the menu is accessible during that time, but I can check that if you give me a few minutes. 20140220 17:01:33< Dugi> fabi: Silly me, it should be somewhere in the makefile. 20140220 17:01:44< iceiceice> so it seems to be the case that you can undroid a side during its turn 20140220 17:01:54< iceiceice> i'm pretty sure i've done this, and ST also says as much 20140220 17:02:13< iceiceice> vultraz: so i guess the solution now is, if someone leaves a ladder game or a conquest game, the host will give control to an obs 20140220 17:02:19< mattsc> iceiceice: with the :droid command? 20140220 17:02:25< fabi> Dugi: scons -j campaignd 20140220 17:02:25< iceiceice> mattsc: yes 20140220 17:02:33< mattsc> okay, that's news to me ... 20140220 17:02:55< Dugi> fabi: I prefer cmake, but I guess that it will be analogous. 20140220 17:03:00< fabi> Yeah 20140220 17:03:17< iceiceice> vultraz: because if he gives to an obs, he wont see what that side sees, and also he can trust the obs not to move anything until that guy gets back 20140220 17:03:32< iceiceice> the loop bot would basically fill the roll of a trusted obs when there is no obs 20140220 17:03:50< vultraz> So like, nothing would happen 20140220 17:03:54< iceiceice> yeah 20140220 17:04:07< iceiceice> i'm not sure but i think that might be the easiest way to create an "idle" mode right now 20140220 17:04:24< iceiceice> there is an "idle_ai" but unfortunately it ends its turn haha 20140220 17:05:06< Dugi> fabi: It cannot find the target campaignd... seems I am doing something wrong. 20140220 17:05:15-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 252 seconds] 20140220 17:05:26< fabi> Dugi: Maybe without the "d"? 20140220 17:05:27< mattsc> iceiceice: I just tried to do that in a local MP game and I could not droid the AI side during the turn 20140220 17:05:35< mattsc> undroid. whatever. 20140220 17:05:59< fabi> Dugi: scons campaignd is doing fine 20140220 17:06:05< mattsc> iceiceice: the idle_ai just does nothing and passes on 20140220 17:06:24< Dugi> fabi: I'll try scons, hope I'll remember how have I installed it. 20140220 17:07:23< fabi> Dugi: What setup do you use? (IDE?, OS, compiler, etc) 20140220 17:07:53< Dugi> fabi: Using gnu-gcc, Linux, QtCreator as IDE. 20140220 17:08:18< Dugi> fabi: Also when on Windows, but I am usually doing stuff on Linux. 20140220 17:08:40< iceiceice> hmm i'm going to try again then 20140220 17:09:05< Dugi> fabi: It seems that I got scons running. 20140220 17:09:33< mattsc> iceiceice: I don't exactly like the idea of having a looping CA evaluation. It seems ... ugly (even if the undroiding during the turn can be done). But I'll do a couple tests to satisfy my curiosity anyway. 20140220 17:10:04< iceiceice> yeah its pretty hacky... 20140220 17:10:07< mattsc> iceiceice: it just feels like there must be a better solution. I suggest we ask Crab_. He's been coming around once a day recently and knows this code way better than I. 20140220 17:10:15< iceiceice> ok 20140220 17:10:28< mattsc> But anyways, I'll just do a quick test of something. 20140220 17:10:58< iceiceice> it might be that if i read the play controller code more i'll realize there's an easier way 20140220 17:11:03< iceiceice> not really sure right now 20140220 17:11:15< vultraz> to me it seems weird to force an infinite loop just to prevent an end of turn 20140220 17:12:01< vultraz> isn't there a switch to flip to tell it to just evaluate nothing 20140220 17:12:45< mattsc> vultraz: sure, but when it is done evaluating it ends the turn - which would be immediately in this case 20140220 17:12:52< Dugi> fabi: Okay, got campaignd compiled, but how do I run it and make it connect to my client? It complains about unavailable ports (obviously). Should I try to open the necessary port and write 127.0.0.1 as the address of the server? 20140220 17:12:52< mattsc> That's what the idle_ai does. 20140220 17:13:18< vultraz> well that doesn't help 20140220 17:13:40< mattsc> So ideally would be something like adding a flag that requires manual ending of a turn even when the controller is an AI. 20140220 17:13:53< fabi> Dugi: I guess starting it with root privileges will solve the port problem. 20140220 17:13:54< mattsc> controller=manual_ai :P 20140220 17:14:31< vultraz> controller=oxymoron 20140220 17:14:33< vultraz> :P 20140220 17:16:45< Dugi> fabi: I didn't know that I have to write the number of the port there as argument. What should I write there? 20140220 17:16:57< iceiceice> mattsc: I just tried in a droid game, I couldn't get it to undroid before ending, but I feel like it might not have had enough units... not sure 20140220 17:17:25< mattsc> iceiceice: I am pretty sure I have tried many times and it has never worked 20140220 17:17:28< iceiceice> it might be that it makes more sense to figure out where the controller is detected and just write a "do nothing" mode 20140220 17:17:50< mattsc> iceiceice: I would agree with that 20140220 17:19:02< vultraz> would be nice to make it do something funny while it sits :P 20140220 17:19:12< vultraz> I recall we have a wesnoth fortunes thing... 20140220 17:19:13< fabi> Dugi: there is a server.cfg file. Just take a port one you like 16999. 20140220 17:20:06< iceiceice> haha whats wesntoh fortunes? 20140220 17:20:15-!- Ivanovic [~ivanovic@x2f49a99.dyn.telefonica.de] has quit [Changing host] 20140220 17:20:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140220 17:20:25< mattsc> Mal Keshar could perform a rain dance for the audience. 20140220 17:20:41< vultraz> ahahahahaha 20140220 17:21:09< Dugi> fabi: My local network will not allow me using ports, I can allow ports 22, 80 and 443, can I use (any of) them? 20140220 17:21:25< fabi> yes 20140220 17:21:26< fabi> 22 20140220 17:21:28< fabi> is ssh 20140220 17:21:36< Dugi> fabi: Okay, thanks. 20140220 17:22:07< vultraz> iceiceice: no idea, I just see there's a little thing that seems to exist in misc/fortunes. never looked at it, so no idea what it does 20140220 17:22:31< fabi> Dugi: Your local network does not need to allow you to use any ports. We connect to localhost, it is not leaving the machine. 20140220 17:23:04< Dugi> fabi: But campaignd still says that 'Aborted with network error: Could not bind to port'. 20140220 17:23:18< vultraz> To compile 'wesnoth' into an useable fortunes database, run 20140220 17:23:20< vultraz> strfile on it; wesnoth.dat will be generated. Now you can 20140220 17:23:21< vultraz> run 'fortune wesnoth' to have your random Wesnothian fortune. 20140220 17:23:52< fabi> Dugi: What port do you use? 20140220 17:24:00< Dugi> fabi: 22 20140220 17:24:19< fabi> Maybe you have a local ssh deamon running? 20140220 17:25:11< Dugi> fabi: I have one running, I'll try to kill it. 20140220 17:25:21< fabi> No 20140220 17:25:28< fabi> Just use a different port number. 20140220 17:26:02< Dugi> fabi: I tried different numbers, the result was the same. 20140220 17:26:16< fabi> Do you use root privileges? 20140220 17:26:43< Dugi> fabi: Yes, I am running it as sudo. Maybe I haven't enabled something in the OS' settings. 20140220 17:26:59< vultraz> iceiceice: so I looked in the file. apparently it contains some very funny wesnoth irc logs from times gone by 20140220 17:27:11< mattsc> iceiceice: as I thought, the loop-evaluation solution would not work anyway. The UI is unresponsive while an evaluation is going on. 20140220 17:27:47-!- irker960 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20140220 17:28:27< fabi> Dugi: For me 16999 works. 20140220 17:28:41< Dugi> fabi: What do you use as arguments? 20140220 17:29:02< fabi> Dugi: No arguments. Just wrote 16999 in the server.cfg file. 20140220 17:29:17< Dugi> fabi: I'll try that. 20140220 17:29:36< fabi> I can connect and publish my single selfmade addon. 20140220 17:29:54< fabi> It is empty. 20140220 17:30:17< iceiceice> yeah i guess that this might be the case when i proposed this, but ST seemed to think it would work... thanks for catching this 20140220 17:30:44< Dugi> fabi: It seems I got it running. Maybe the server port I was to use wasn't related to the terminal argument. 20140220 17:31:05-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has joined #wesnoth-dev 20140220 17:31:05-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has quit [Changing host] 20140220 17:31:05-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140220 17:31:07< Dugi> fabi: Works also without root privilegies. 20140220 17:32:33< Dugi> fabi: Got it working. Thanks. 20140220 17:33:34< iceiceice> vultraz: these fortunes are pretty silly 20140220 17:33:39< fabi> Dugi: Yes, the distribution vendors can adjust which ports a user is able to open. Usually ports < ~ 16000 are reserved for the root user or special users. 20140220 17:34:29< vultraz> iceiceice: seems everyone had more of s sense of humor back then. Can't think of any recent events that would qualify for this file 20140220 17:35:26< fabi> vultraz: Which file? 20140220 17:35:45< Dugi> fabi: Thanks for clarification. Obviously the dormitory internet service doesn't want me to run a web server. I have managed to upload my campaign to my own imaginary server. The server.cfg file is pretty interesting, and explains a lot of stuff I found quite hard to decipher in the source code. Thank you for your assistance. 20140220 17:35:48< vultraz> misc/fortunes/wesnoth 20140220 17:36:47< fabi> Dugi: You are welcome :-) 20140220 17:36:56< vultraz> Seems last entry was 2011, huh 20140220 17:37:00< vultraz> I was around then! :O 20140220 17:44:27< fabi> Dugi: Do you want to join #wesnoth-umc-dev ? I would like to ask you some stuff about RPG campaigns. 20140220 17:46:45< Ivanovic> vultraz: which abilities are missing? 20140220 17:46:50< Ivanovic> can you create a patch adding them in? 20140220 17:47:49< vultraz> I have no repo clone until my replacement HDD arrives next week 20140220 17:50:08< fabi> vultraz: Indeed, everyone had more sense of humor back then. 20140220 17:50:48< vultraz> fabi: it seems all the humor went to #frogatto :P 20140220 17:52:03< fabi> I hope so. At least it should not have died out. 20140220 17:52:50< Ivanovic> vultraz: can't you use the github web editor to work on manual.txt? 20140220 17:54:00< mattsc> iceiceice: oh ... 20140220 17:54:45< mattsc> iceiceice: We could, of course, simply have the AI sit there displaying a message (even offering a choise to the host) and waiting until that is dismissed... 20140220 17:55:12< iceiceice> i guess thats right 20140220 17:55:15< iceiceice> so, 20140220 17:55:18< mattsc> But I guess that would mean that the host cannot do anything else during that time 20140220 17:55:26< iceiceice> i think i need to figure out what needs to be done in play_controller 20140220 17:55:33< iceiceice> or whatever controller related area of code it is 20140220 17:55:48< iceiceice> because i think whatever blocker mode we make, it should also be committed to / reloaded from save friles 20140220 17:55:51< iceiceice> *files 20140220 17:55:58< mattsc> iceiceice: yeah, I think that's the better way of going about. 20140220 17:56:05< iceiceice> so let me do a little more digging... 20140220 17:56:16< iceiceice> i didnt make any progress on your animation bug from last night btw 20140220 17:56:44< iceiceice> but also i feel like its not a "new feature" so its lower priority for that reason? :p 20140220 17:57:01< mattsc> iceiceice: no worries - while segfaults/asserts are reasonably serious, it is clear what causes this one and it's easy enough to avoid it. 20140220 17:57:58< vultraz> Ivanovic: ah, forgot that was a thing 20140220 17:58:52< mattsc> ... and I could easily add a couple lines of code that would prevent this from happening for the double-kill, double-creation or creation-kill-combo. But it would be better to fix the actual root problem, rather than to work around it. 20140220 17:59:02< mattsc> iceiceice: ^ 20140220 18:05:40< mattsc> ... so that cases like shadowm's :lua debug command are covered too and don't all need to be dealt with individually. 20140220 18:18:29< happygrue> I just switched from an old forum theme to prosilver, and now I can't tell if I've subscibed to a topic by any icon that I can see, am I missing something? 20140220 18:34:50-!- thunders1ruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving] 20140220 18:36:14-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20140220 18:38:29-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20140220 18:43:29< mattsc> Aieee ... I guess it would be preferable if the Micro AIs were replay safe, wouldn't it? 20140220 18:48:04-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev 20140220 18:48:14< Soliton> indubitably. 20140220 18:49:32< mattsc> I recently noticed a couple problems, but starting to look into it, there are quite a few more than I thought. (I'm surprised that nobody has complained about that yet.) 20140220 18:50:33-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 260 seconds] 20140220 18:50:34< mattsc> One of the counter-intuitive things (at first; it makes perfect sense once you think about it) is that the AIs need to use the non-replay-safe RNG or we're in trouble. 20140220 18:51:00< mattsc> I know that now, of course, but some of these AIs go back to when I barely knew how some of this works ... 20140220 18:52:07< Soliton> fabi: privileged ports range from 0 to 1023. 20140220 18:52:42< fabi> Soliton: Linux? 20140220 18:52:48< Soliton> the internet. 20140220 18:58:46< zookeeper> there's a little unit movement regression (dunno when it last worked): when moving a unit and discovering another unit through fog/shroud, you lose your unit selection and must select the unit again to be able to continue moving it. 20140220 18:58:57< zookeeper> before, the unit remained selected and you could simply click again to move it 20140220 19:01:19-!- cib0 [~cib@132.231.178.96] has quit [Ping timeout: 272 seconds] 20140220 19:01:30< zookeeper> also, there's something wrong with ellipses. i have a player leader and hero units moved to an AI side, which seems to break something about their ellipses: 20140220 19:01:30< zookeeper> 20140220 20:59:46 error display: could not open image 'misc/ellipse-hero-leader-top.png' 20140220 19:01:30< zookeeper> 20140220 20:59:46 error display: could not open image 'misc/ellipse-hero-leader-bottom.png' 20140220 19:01:34-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev 20140220 19:01:34-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host] 20140220 19:01:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140220 19:02:27-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has joined #wesnoth-dev 20140220 19:14:08-!- Guest32859 is now known as _8680_ 20140220 19:18:40< mattsc> zookeeper: do you change their leader/hero status in the move? 20140220 19:21:37-!- SigurdFD [~SigurdFD@24.154.98.89] has joined #wesnoth-dev 20140220 19:22:20< mattsc> The way the ellipse system works was changed. I fixed those issues that I was aware of a while ago. See, e.g.,: https://github.com/wesnoth/wesnoth-old/commit/c68c0881d57016ce9b1871e4df94f702c9880199 20140220 19:31:49-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20140220 19:32:54-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140220 19:33:22-!- irker581 [~irker@ai0867.net] has joined #wesnoth-dev 20140220 19:33:22< irker581> wesnoth: mattsc wesnoth-old:master e78462c39505 / data/ai/ (11 files in 2 dirs): Remove function ai_helper.random() http://git.io/Vo2Q7Q 20140220 19:34:03-!- fabi [~fabi@88-134-21-163-dynip.superkabel.de] has joined #wesnoth-dev 20140220 19:34:04-!- fabi [~fabi@88-134-21-163-dynip.superkabel.de] has quit [Changing host] 20140220 19:34:04-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20140220 19:34:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 19:34:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20140220 19:35:07-!- SigurdFD [~SigurdFD@24.154.98.89] has quit [] 20140220 19:36:42< irker581> wesnoth: Chris Beck wesnoth-old:master c0985f0980d2 / src/scripting/lua.cpp: eras_list initial commit http://git.io/njuuqA 20140220 19:36:44< irker581> wesnoth: Chris Beck wesnoth-old:master 690de2e97ab7 / src/scripting/lua.cpp: add eras_list and wesnoth.get_era http://git.io/WrPnIw 20140220 19:36:46< irker581> wesnoth: Chris Beck wesnoth-old:master 238dd0343ea0 / changelog: update changelog http://git.io/NL1Q2g 20140220 19:36:48< irker581> wesnoth: cbeck88 wesnoth-old:master b511dd95dc90 / changelog src/scripting/lua.cpp: Merge pull request #100 from cbeck88/eras http://git.io/k6-CrQ 20140220 19:44:09< zookeeper> mattsc, "The new ellipse system automatically appends -leader to the ellipse 20140220 19:44:09< zookeeper> file name 20140220 19:44:15< zookeeper> " 20140220 19:44:30< zookeeper> does that apply to all units ever, or something that somehow only affects core units? 20140220 19:44:56 * zookeeper grumbles something about a prime example of why linebreaks are bad 20140220 19:45:20< mattsc> zookeeper: I don't know (I was not involved in changing this), but I think it applies to all units. 20140220 19:45:56< zookeeper> okay... 20140220 19:46:27< zookeeper> i think it definitely should not do it if such files cannot be found 20140220 19:47:07< zookeeper> otherwise everyone everywhere will always have to duplicate their ellipses to provide the -leader variants just in case 20140220 19:49:12-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140220 19:50:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 19:51:07< mattsc> zookeeper: if I interpret my 'git log' output correctly, it was LordBob_ and AI0867 who changed this, so you should ask them. 20140220 19:52:14< mattsc> Maybe fabi was also involved; hard to say from the CL output and I am too lazy to look into the full commit messages. 20140220 19:53:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer] 20140220 19:58:36-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev 20140220 20:10:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 20:10:19-!- cib0 [~cib@p5DC75F9F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140220 20:14:42-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20140220 20:17:39< mattsc> Hi Crab_. iceiceice has some questions for you (unless he has solved them already). 20140220 20:18:43< iceiceice> i'm not sure if i'm actually prepared to ask questions here, i'm sort of preoccupied with something else atm 20140220 20:19:16< iceiceice> but basically i was hoping you might comment on this: https://gna.org/bugs/?21405 20140220 20:19:52< iceiceice> we're trying to figure out how to make an "idle" controller that a host could put a side into without getting vision of that side, as a first step to address this 20140220 20:20:12< iceiceice> at first we thought maybe an ai that loops and doesn't end its turn might be a good idea, but now we are perhaps pivoting away from that 20140220 20:23:39-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer] 20140220 20:23:50-!- cib0 [~cib@p5DC75F9F.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds] 20140220 20:26:33-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!] 20140220 20:28:53-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140220 20:32:12-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev 20140220 20:33:46-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Crab_] 20140220 20:36:29-!- cib0 [~cib@p5DD23020.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140220 20:40:46-!- Dugi_ [93fbd156@gateway/web/freenode/ip.147.251.209.86] has joined #wesnoth-dev 20140220 20:43:33-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has quit [Ping timeout: 245 seconds] 20140220 20:45:08-!- Velensk [~Velensk@cpe-75-187-86-211.woh.res.rr.com] has joined #wesnoth-dev 20140220 20:47:39< mattsc> Hmm - also, there's replay safety; and then there's save/load safety. Unfortunately, ensuring one does not necessarily guarantee the other ... 20140220 20:47:56< mattsc> (still talking about the MAIs) 20140220 20:48:21-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 20:52:59-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds] 20140220 20:53:25-!- Dugi_ [93fbd156@gateway/web/freenode/ip.147.251.209.86] has quit [Quit: Page closed] 20140220 20:53:48< iceiceice> mattsc: sounds like we are looking at similar code right now -- i have made it so that eras and mods are preserved as you proceed in an mp campaign, but they are stripped when you save / load... 20140220 20:53:55-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has joined #wesnoth-dev 20140220 20:54:37< mattsc> iceiceice: not really, I think - the MAIs are entirely Lua code. 20140220 20:54:57< iceiceice> oh i see you are worried about *safety* 20140220 20:55:10< mattsc> yes - safety and repeatability 20140220 20:56:43< mattsc> So you cannot do anything inside the AI code that changes the RNG, and you cannot do any gamestate changes or changes to variables etc. that get relied on in a later turn; except for a few synchronized events. 20140220 20:57:59< mattsc> Unfortunately, I didn't understand some of these things very well when I started all this and some of that mess is still left over from back then. I figure I better clean it up for 1.12. :P 20140220 21:01:56< iceiceice> brb 20140220 21:01:57-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has quit [Quit: Leaving] 20140220 21:03:50-!- exciton_ [chuck-the-@95.73.36.33] has joined #wesnoth-dev 20140220 21:05:22-!- Netsplit *.net <-> *.split quits: shadowm, Crendgrim, bumbadadabum, cjhopman_, tomreyn 20140220 21:05:29-!- Netsplit *.net <-> *.split quits: loonycyborg, shikadibot 20140220 21:06:01-!- Netsplit over, joins: loonycyborg 20140220 21:06:18-!- Netsplit over, joins: shadowm, tomreyn, cjhopman_ 20140220 21:06:18-!- tomreyn_ [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20140220 21:06:33-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20140220 21:06:36-!- tomreyn_ is now known as tomreyn 20140220 21:07:07-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 260 seconds] 20140220 21:08:02-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140220 21:08:03-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev 20140220 21:08:03-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20140220 21:14:21-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20140220 21:22:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140220 21:23:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 21:31:52-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!] 20140220 21:32:46-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140220 21:40:06-!- Netsplit *.net <-> *.split quits: Crendgrim, shikadibot 20140220 21:40:35-!- Netsplit *.net <-> *.split quits: shadowm 20140220 21:40:40-!- Netsplit *.net <-> *.split quits: cjhopman_ 20140220 21:53:33-!- noy_ [~Noy@184.69.143.198] has joined #wesnoth-dev 20140220 21:53:33-!- noy_ [~Noy@184.69.143.198] has quit [Changing host] 20140220 21:53:33-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140220 21:54:26-!- cib_ [~cib@p5DD23020.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140220 21:56:25-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20140220 21:59:49-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20140220 22:00:24-!- Netsplit *.net <-> *.split quits: cib0, MaraJade, Fortescue, noy, ejls, _8680_ 20140220 22:00:24-!- noy_ is now known as noy 20140220 22:00:48< thunderstruck> iceiceice: Hello. 20140220 22:01:03< thunderstruck> iceiceice: Do you still have any questions for for me? 20140220 22:01:40< iceiceice> hi, yes just different ones from before :) 20140220 22:02:17-!- Fortescue [sid1929@gateway/web/irccloud.com/x-jqxenivcrbepwwhx] has joined #wesnoth-dev 20140220 22:02:28< iceiceice> so right now i am trying to make it so that [era] and [modification] tags are preserved as you proceed in an mp campaign 20140220 22:03:01< iceiceice> i pushed a commit a while ago so that [endlevel] WML tags can contain "carryover WML" that is appended / merged with the next scenario 20140220 22:03:18< iceiceice> so lipk suggested i might try to make "persistent carryover WML" that applies to all subsequence scenarios 20140220 22:03:25< iceiceice> and put eras and mods there 20140220 22:03:43< iceiceice> so that seems to work but it doesn't work when you save and then reload and i'm not completely sure why 20140220 22:05:00< shadowm_desktop> fabi: Around? 20140220 22:05:00< iceiceice> in fact where i am right now is that i've found that there is a function "loadgame::copy_era" but it doesn't seem to fix this 20140220 22:05:23< thunderstruck> Wait a bit. What exactly are you trying to achieve here? 20140220 22:05:48< iceiceice> i would like that [era] and [modification] tags are preserved as you go throguh the mp campaign, 20140220 22:05:54< iceiceice> specifically so that [event] tags in them recur 20140220 22:05:57< iceiceice> in every scenario 20140220 22:06:02< thunderstruck> Hmmm 20140220 22:06:14< thunderstruck> I thought that eras and mods work fine in mp campaigns 20140220 22:06:33< iceiceice> ok well, a few days ago lipk claimed it didnt work 20140220 22:06:35-!- _8680_ [~8680@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140220 22:06:35-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20140220 22:06:35-!- cjhopman__ [cjhopman@nat/google/x-uvzpbmjgehwdwgbp] has joined #wesnoth-dev 20140220 22:06:35-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev 20140220 22:06:35-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20140220 22:06:35< iceiceice> i found in testing that 20140220 22:07:00< iceiceice> * i have found in testing that eras are not preserved when you save / load 20140220 22:07:08-!- _8680_ is now known as Guest34016 20140220 22:07:19< thunderstruck> Ahhh.. so it works fine until you reload? 20140220 22:07:37< iceiceice> yes 20140220 22:07:46< thunderstruck> Yeah, that might be true. 20140220 22:08:17< thunderstruck> Perhaps you can use mp::connect_engine to take care of this. 20140220 22:08:17< iceiceice> actually, i'm not sure if it works in the subsequent campaign on master right now 20140220 22:08:22< iceiceice> i'm pretty sure that modfications didn't 20140220 22:08:26< iceiceice> hmm 20140220 22:08:28< thunderstruck> But I can't really say for sure without looking into some details 20140220 22:08:53< thunderstruck> And apparently I wouldn't be able to find time for that today. 20140220 22:09:39< iceiceice> ok, i thought this would be quite easy given what i had already done but it has taken much longer than i thought 20140220 22:10:03< thunderstruck> As a starting point, it would be good to figure out what works and what doesn't. And why it doesn't work exactly. 20140220 22:10:10< iceiceice> yeah... 20140220 22:10:40< iceiceice> i have been doing a lot of testing with debugging output 20140220 22:10:50< iceiceice> but mainly associated to, what configs have what values at various times in playcampaign.cpp 20140220 22:10:56< iceiceice> and i dont have a great handle on the save game / load game code 20140220 22:11:03< iceiceice> so thats where i'm poking right now 20140220 22:11:18< iceiceice> i'm hopeful that i'll actually have a full fix in an hour or so, i've been working on this quite a while... 20140220 22:11:34< iceiceice> i think that the loadgame copy_era function isn't actually working right now 20140220 22:11:42< iceiceice> and there is no matching copy_mod function, so i ahve created that as well 20140220 22:12:51< thunderstruck> I have limited knowledge of that area and I never heard about these functions. 20140220 22:14:28< iceiceice> ok 20140220 22:14:30< thunderstruck> Anyway, I think the idea with mods and eras was that mp::connect_engine applies them for each scenario in mp campaign. 20140220 22:14:40< iceiceice> ohh 20140220 22:14:45< thunderstruck> And eras and mods are maintained with mp::game_settings 20140220 22:15:01< iceiceice> so is there any code elsewhere that will copy events from them? 20140220 22:15:24< thunderstruck> But again, I didn't activitely worked on Wesnoth for a while and I don't remember it all 20140220 22:15:42< iceiceice> yeah i see 20140220 22:15:43< thunderstruck> I don't think that I did anything with events. 20140220 22:16:50< iceiceice> hmm well i will keep playing with it, thanks 20140220 22:17:18< thunderstruck> https://github.com/wesnoth/wesnoth-old/blob/master/src/mp_game_utils.cpp 20140220 22:17:31< thunderstruck> I think eras and mods are applied here, IIRC. 20140220 22:18:23< thunderstruck> https://github.com/wesnoth/wesnoth-old/blob/master/src/multiplayer_connect_engine.cpp#L87 20140220 22:18:40< thunderstruck> And it happens for each scenario in MP campaign. 20140220 22:21:37< thunderstruck> iceiceice: Do you have any more questions? I'm thinking of going AFK soon. 20140220 22:22:15< iceiceice> i'm going to look at what you posted, i dont think i have anymore questions though , thanks 20140220 22:23:03< thunderstruck> Ok, if you'll have any you can leave message here. Just mention my name. Bye. 20140220 22:23:20< iceiceice> bye 20140220 22:23:29-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving] 20140220 22:27:08-!- Netsplit *.net <-> *.split quits: shadowm 20140220 22:33:14-!- Netsplit *.net <-> *.split quits: cjhopman__, Guest34016, Crendgrim 20140220 22:33:20-!- Netsplit *.net <-> *.split quits: shikadibot 20140220 22:35:03< aquileia> Any wmllint expert around? For units created via [base_unit] the usage isn't directly in the cfg. I found both units with and without #wmllint: usage of ... is ... 20140220 22:35:12< aquileia> shadowm wrote earlier today mainline except LoW is wmllint clean, so it seems the magic comment is no longer necessary? 20140220 22:36:34-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140220 22:36:40-!- Netsplit over, joins: Crendgrim, Guest34016, shadowm, shikadibot, cjhopman__ 20140220 22:38:06< aquileia> shadowm: ^ 20140220 22:41:33-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 260 seconds] 20140220 22:46:13-!- Netsplit *.net <-> *.split quits: cjhopman__, Crendgrim, shikadibot, Guest34016 20140220 22:46:14-!- Smar [smar@nano.smar.fi] has quit [Ping timeout: 276 seconds] 20140220 22:47:08-!- Netsplit over, joins: Crendgrim, Guest34016, shikadibot, cjhopman__ 20140220 22:49:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140220 22:51:56-!- Smar [smar@nano.smar.fi] has joined #wesnoth-dev 20140220 22:51:56-!- Smar [smar@nano.smar.fi] has quit [Changing host] 20140220 22:51:56-!- Smar [smar@freenet/translator/finnish/Smar] has joined #wesnoth-dev 20140220 22:56:54-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: Ciao] 20140220 22:59:48< fabi> bumbadadabum: Hello, are you firm with [terrain_graphics]? 20140220 22:59:58< bumbadadabum> Not at all 20140220 23:00:00< bumbadadabum> sorry 20140220 23:00:02-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has left #wesnoth-dev ["Ik ga weg"] 20140220 23:00:11-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20140220 23:01:36-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20140220 23:02:35< aquileia> Whom to ask about wmllint here on IRC? Or should I write a PM to GroggyDice? 20140220 23:09:34-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Read error: Operation timed out] 20140220 23:19:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20140220 23:20:55-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev 20140220 23:26:15< iceiceice> thunderstruck: you are right, the carryover is working normally right now, and that function you mentioned is getting called besides at the very first scenario of campaign (which is what i had thought) 20140220 23:26:28< iceiceice> i think there is something wrong in the savegame section though 20140220 23:26:42< iceiceice> because it is definitely the case that eras are getting stripped out on reload 20140220 23:27:10-!- Velensk [~Velensk@cpe-75-187-86-211.woh.res.rr.com] has quit [Quit: Leaving] 20140220 23:28:36< shadowm> fabi: Hi. 20140220 23:29:31< shadowm> Are you ignoring me again? I promise this time I seek feedback, not intend to give feedback. 20140220 23:31:00-!- cib_ is now known as cib 20140220 23:31:02< shadowm> aquileia: What kind of thing about wmllint? I've been doing some stuff with it as of late. 20140220 23:31:03-!- cib is now known as cib0 20140220 23:31:38< shadowm> Oh, you said something on the other side of the netsplit. 20140220 23:31:56< aquileia> Should I explain again? 20140220 23:32:07< shadowm_desktop> I can read it from here. 20140220 23:33:26< shadowm> Adding that kind of comments is usually part of making mainline wmllint-clean, since wmllint isn't able to do things like expand WML macros. 20140220 23:34:09< shadowm> The Desert Archer one seems redundant, though. 20140220 23:34:53-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20140220 23:35:09< aquileia> I rather meant that it was omitted for the Dark Assassin 20140220 23:35:49< aquileia> You said wmllint did not complain? 20140220 23:35:59< shadowm> It's only relevant for unit types appearing in recruit lists IIRC. 20140220 23:36:12< aquileia> Ah, that makes sense. 20140220 23:36:27< shadowm> And that guy and his three variations don't. 20140220 23:37:26< shadowm> Yep, only recruitment pattern checks, all right. 20140220 23:38:01< aquileia> Should I delete the comment for the ethereal ghosts line? It does no harm, but is unnecessary then 20140220 23:38:51< shadowm> I was going to do it myself. The reason it's actually unnecessary there is because wmllint gained the ability to resolve [base_unit]s at some point. 20140220 23:40:02< aquileia> Can I clean UtBS of it, then? I'm working on it anyhow. 20140220 23:40:36< shadowm> Hm, okay. 20140220 23:41:14< aquileia> So just to be sure: Any appearance can be deleted? 20140220 23:42:18< irker581> wesnoth: Charles Dang wesnoth-old:master 72d6f96694fb / doc/manual/manual.txt: Added entries about Unpoison and Feeding abilities http://git.io/lM2SCA 20140220 23:42:43< shadowm> Yes, unless the unit in question has the usage= defined in a way wmllint can't see -- that is, anything besides having it in the [unit_type] or in a [unit_type] from which it is derived. 20140220 23:43:12< shadowm> If in doubt, you can run wmllint yourself after a change by changing into data/tools and running `make lint`. 20140220 23:43:25< vultraz> Ivanovic: ^ 20140220 23:44:13< aquileia> Well, after my problems with wesnoth-optipng I'm not too sure 20140220 23:44:46< aquileia> Windows isn't a good platform for this 20140220 23:45:21-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20140220 23:45:51-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev 20140220 23:47:13< aquileia> Oh, it's python, no shell needed! 20140220 23:49:18< aquileia> Thanks, shadowm! 20140220 23:58:48-!- exciton_ [chuck-the-@95.73.36.33] has quit [Read error: Connection reset by peer] 20140220 23:59:02-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140220 23:59:54< iceiceice> ok, i have deduced that eras and mods are in fact correctly being carried over from scenario to scenario, even through save/load in an mp campaign, --- Log closed Fri Feb 21 00:00:04 2014