--- Log opened Wed Mar 12 00:00:02 2014 --- Day changed Wed Mar 12 2014 20140312 00:00:02-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer] 20140312 00:00:16-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140312 00:06:47-!- sachith500 [~kvirc@112.134.25.222] has quit [Read error: Connection reset by peer] 20140312 00:07:03-!- sachith500 [~kvirc@112.134.25.222] has joined #wesnoth-dev 20140312 00:10:31< gfgtdf> s there a way to do text search in http://gna.org/bugs/?group=wesnoth ? 20140312 00:10:54< shadowm> Hover over the Bugs menu, choose Search. 20140312 00:11:50-!- sachith500|2 [~kvirc@112.134.25.222] has joined #wesnoth-dev 20140312 00:12:38-!- sachith500 [~kvirc@112.134.25.222] has quit [Ping timeout: 252 seconds] 20140312 00:14:57< gfgtdf> shadowm: ty i always clicked "Durchsuchen (the first entry)" not "suchen (last entry)", which have the same meaning in germen. 20140312 00:15:32< shadowm> I wasn't aware gna.org had translations. 20140312 00:17:16< gfgtdf> hm it shows in german by default to me. 20140312 00:17:48< gfgtdf> but not every string in teh menu is tranlated 20140312 00:17:52< gfgtdf> the 20140312 00:20:00-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving] 20140312 00:38:06-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer] 20140312 00:38:20-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140312 00:42:13-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140312 00:42:24-!- stikonas_ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev 20140312 00:42:24-!- stikonas_ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host] 20140312 00:42:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140312 00:42:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20140312 00:47:32-!- lyssdod [~lyssdod@95.158.53.148] has joined #wesnoth-dev 20140312 00:48:07< lyssdod> Hi all, I would like to apply for GSoC this year and to work on SDL transition 20140312 00:49:10< happygrue> Hello lyssdod. 20140312 00:49:26< lyssdod> I worked with SDL before and do work now; although last year I did not qualify their (SDL) requirements in GSoC, I've gathered lots of experience with their modern code 20140312 00:51:01< lyssdod> I also working on a private project from time to time, and this project uses SDL2 for Android and iOS builds, so these aspects are handled by me as well 20140312 00:51:06< lyssdod> *I`m 20140312 00:53:28< lyssdod> Wiki page says that transition will be huge and can't happen by the efforts of just one GSoC, so firstly I`m going to analyze SDL code usage in current state and form a roadmap of SDL->SDL2 transition 20140312 00:53:55< lyssdod> I mean SDL code usage in Wesnoth's engine 20140312 00:54:42-!- Yukiria [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20140312 00:58:16-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds] 20140312 00:58:20-!- knotwork [~markm@142.68.215.102] has quit [Ping timeout: 240 seconds] 20140312 00:58:20-!- spoffy [~spoffy@152.78.175.8] has quit [Ping timeout: 240 seconds] 20140312 00:58:25-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ypmfefzbqobavfjs] has quit [Ping timeout: 240 seconds] 20140312 00:58:26-!- Yukiria is now known as vultraz 20140312 00:58:27-!- Coffee_irc [~david@ppp118-210-31-67.lns20.adl2.internode.on.net] has quit [Ping timeout: 240 seconds] 20140312 00:58:49-!- cjhopman [cjhopman@nat/google/x-ianoaeficrwjtxjn] has quit [Ping timeout: 240 seconds] 20140312 01:00:18-!- knotwork [~markm@142.68.215.102] has joined #wesnoth-dev 20140312 01:00:18-!- knotwork [~markm@142.68.215.102] has quit [Changing host] 20140312 01:00:18-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20140312 01:02:23-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20140312 01:04:06-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds] 20140312 01:04:07-!- {V} [~V@72-69-ftth.on.nl] has quit [Ping timeout: 240 seconds] 20140312 01:04:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140312 01:05:03-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev 20140312 01:07:38-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-gxpeurcpsgpnvcck] has joined #wesnoth-dev 20140312 01:09:03-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-gxpeurcpsgpnvcck] has quit [Changing host] 20140312 01:09:03-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20140312 01:09:03-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host] 20140312 01:09:03-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-gxpeurcpsgpnvcck] has joined #wesnoth-dev 20140312 01:12:56-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev 20140312 01:19:24-!- werlley [~werlley@179.124.130.66] has joined #wesnoth-dev 20140312 01:19:47< iceiceice> hi i have a quick question about add-on dependencies 20140312 01:20:17< iceiceice> i remember reading somewhere, perhaps in the wescamp page? that we aren't supposed to assume when we make add-ons that the user has all campaigns installed 20140312 01:20:29< iceiceice> (i think in wescamp it was about using translations from mainline campaigns) 20140312 01:20:45< iceiceice> is it possible for an add-on to declare a mainline campaign as a dependency? 20140312 01:21:38< iceiceice> i say this because i've also noticed that many umc add-ons (PYRA, SXRPG) reuse content from the campaigns by putting many of those directories as bin_path 20140312 01:21:53< iceiceice> and i guess in 1.12 they should also declare dependencies 20140312 01:21:56< iceiceice> is that actually possible? 20140312 01:23:50< shadowm> No mainline campaigns are guaranteed to be present. 20140312 01:24:10-!- neXyon_ [~neXyon@85-127-52-188.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20140312 01:25:28< iceiceice> yes thats what i understood 20140312 01:26:02< iceiceice> and theres no way for the umc to declare a mainline campaign as a dependency? 20140312 01:26:20-!- neXyon [~neXyon@85-127-126-95.dynamic.xdsl-line.inode.at] has quit [Ping timeout: 252 seconds] 20140312 01:26:33< iceiceice> if so then that's perhaps an oversight 20140312 01:26:42< shadowm> There is no officially-sanctioned way to do that. What I would do as an alternative is the following: 20140312 01:26:59< shadowm> 1) Include a prominent notice in the add-on's description. 20140312 01:27:13< shadowm> 2) Use an #ifhave/#error sequence in the add-on itself. 20140312 01:27:24< shadowm> *#ifnhave 20140312 01:27:57< shadowm> e.g. #ifnhave data/campaigns/Heir_to_the_Throne \n #error You must have HttT installed to be able to play this add-on \n #endif 20140312 01:28:22-!- spoffy [~spoffy@152.78.175.8] has quit [Remote host closed the connection] 20140312 01:29:17< iceiceice> that makes sense 20140312 01:29:23< iceiceice> it might be worthwhile to make a forum post explaining this 20140312 01:30:13< shadowm> I don't know why you suggest a forum post considering that the real WML documentation is in the wiki, but feel free to do so. 20140312 01:32:51< iceiceice> hmm maybe i will just pm the authors if i notice people doing it wrong in 1.12 20140312 01:41:19-!- neXyon_ [~neXyon@85-127-52-188.dynamic.xdsl-line.inode.at] has quit [Quit: bye] 20140312 01:41:46< happygrue> If you think it's worth it you could post a reminder in the forums linking to the correct part of the wiki 20140312 01:59:27-!- sachith500|2 [~kvirc@112.134.25.222] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 20140312 02:00:20-!- exciton_ [chuck-the-@77.51.171.36] has joined #wesnoth-dev 20140312 02:04:08-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds] 20140312 02:06:26-!- exciton_ [chuck-the-@77.51.171.36] has quit [Read error: Connection reset by peer] 20140312 02:06:41-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140312 02:06:48-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has joined #wesnoth-dev 20140312 02:31:33< Aishiko_laptop> anyone that gets git in the house? 20140312 02:31:59-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has quit [Quit: linii] 20140312 02:33:06-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has joined #wesnoth-dev 20140312 02:34:06< Aishiko_laptop> git is saying that updates(commits) rejected because my branch is behind but I have done a git pull and git pull --rebase and both are now saying I'm upto date 20140312 02:35:08< shadowm> Aishiko_laptop: What branch are you trying to push and where? 20140312 02:35:24< Aishiko_laptop> personal fork at github 20140312 02:35:38< shadowm> Could we have the actual command line you are trying and the output? 20140312 02:36:05< Aishiko_laptop> yeah hang on a moment 20140312 02:36:42< iceiceice> also, more useful than just "command X doesn't work", you can tell us what "git status" says 20140312 02:37:36< Aishiko_laptop> http://pastebin.com/Gp3jFG6B 20140312 02:38:20< Aishiko_laptop> iceiceice, "On Branch Master; Ahead by 3 commits" 20140312 02:38:24< shadowm> Aishiko_laptop: Is it literally "username/wesnoth"? 20140312 02:38:44< shadowm> Also, didn't I say before that you should use separate topic branches for pull requests rather than reusing a single branch? 20140312 02:38:47< Aishiko_laptop> shadowm, no Aishiko is in both 20140312 02:39:27< iceiceice> Aishiko: did you reset your branch? 20140312 02:39:32< Aishiko_laptop> you did but that was after I'd made the changes 20140312 02:39:35< shadowm> What I'm seeing here is that master in https://github.com/aishiko/wesnoth already differs from our master (again, that's not what I recommended to do). 20140312 02:39:49< Aishiko_laptop> shadowm, it shouldn't 20140312 02:39:56-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Remote host closed the connection] 20140312 02:39:57< shadowm> Well, it does. :p 20140312 02:40:00-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has quit [Quit: linii] 20140312 02:40:05< Aishiko_laptop> well great 20140312 02:40:22< shadowm> If you want to overwrite that master with yours, try `git push --force fork master`. 20140312 02:40:47< shadowm> But again, really you should use topic branches instead, since we may ask you to rewrite or reorganize commits for each PR. 20140312 02:41:29< shadowm> So you could right now take your current master, branch it away (`git checkout -b feature/unit-recall-costs`, for example), and push that branch. 20140312 02:41:54< iceiceice> y thats smart 20140312 02:42:23< shadowm> And later you could reset your master to match ours and drop the version of your commits there with `git checkout master; git reset --hard origin/master`. 20140312 02:42:34< Aishiko_laptop> I had one called unitRecallCosts and I tried to push there but couldn't 20140312 02:43:23< shadowm> And what was Git's response? If you didn't specify where to push and how, it may have complained about not knowing for sure what you intended to do. 20140312 02:43:45< shadowm> For example, to push a new branch to our fork you would use `git push fork mybranchnamehere`. 20140312 02:43:51< shadowm> Er, *your 20140312 02:44:36< Aishiko_laptop> shadowm, yes I was doing it that way (copying the commands like that and changing the pertinent parts like names) 20140312 02:45:16-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has joined #wesnoth-dev 20140312 02:46:00< Aishiko_laptop> so after creating feature/unit-recall-costs I then just do a git push fork feature/unit-recall-costs... Am I following along correctly? 20140312 02:46:10< shadowm> Yes. 20140312 02:56:11< Aishiko_laptop> shadowm, well I wasn't able to do it at the commandline but once I added a feature/unit-recall-costs branch to the github it worked fine 20140312 02:56:51< iceiceice> aishiko: what went wrong when you tried to push to the fork? 20140312 02:57:31< Aishiko_laptop> said it didn't exist so I added the branch 20140312 02:57:56< iceiceice> so that means i guess you typed the name wrong 20140312 02:58:01-!- dragonofair0 [~dragonofa@2601:7:8800:359:a98b:646b:e9a:6d86] has joined #wesnoth-dev 20140312 02:58:09< iceiceice> its ok to push branches to github that github doesnt know about yet 20140312 02:58:12< iceiceice> so that couldnt have been the prolbem 20140312 02:58:38-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 240 seconds] 20140312 02:58:41< iceiceice> you can use "git branch" to get a list of branches 20140312 02:58:48< iceiceice> and "git status" to see what branch you are on 20140312 02:59:08< iceiceice> idk im trying to think what else it could mean 20140312 03:01:09< Aishiko_laptop> iceiceice, all I know is it worked (finally) if it means that I have to create a branch before pushing anything that's fine I'll do that, just so long as it works 20140312 03:01:36< Aishiko_laptop> I just hope the descriptions are okay this time 20140312 03:02:13< Aishiko_laptop> ie in the proper format (or close enough that it'll slide and I'll be told what needs to be improved on for the next time) 20140312 03:02:56-!- dragonofair0 [~dragonofa@2601:7:8800:359:a98b:646b:e9a:6d86] has quit [Quit: dragonofair0] 20140312 03:03:51< iceiceice> ok sure, but if you are getting strange errors when you are pushing you will want to get to the bottom of it... pushing is pretty fundamental to development obviously 20140312 03:04:04< iceiceice> it might mean that your remotes aren't configured right or something? 20140312 03:04:23< iceiceice> its a bit of a strange error unless it was simply a typo 20140312 03:05:17-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving] 20140312 03:05:26-!- Ivanovic_ [~ivanovic@x2f40472.dyn.telefonica.de] has joined #wesnoth-dev 20140312 03:05:53-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20140312 03:06:15< Aishiko_laptop> iceiceice, if it happens again or more often I think I might get annoyed enough to find out why but until then, I don't want to devel too deep into something else new and screw up my time management more then I already have =P 20140312 03:08:33-!- Ivanovic_ [~ivanovic@x2f40472.dyn.telefonica.de] has quit [Changing host] 20140312 03:08:33-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140312 03:08:39-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds] 20140312 03:09:34-!- Ivanovic_ is now known as Ivanovic 20140312 03:13:39-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20140312 03:17:38< shadowm> Aishiko_laptop: Do you have a specific person in mind to review the PR? 20140312 03:18:07< shadowm> i.e. were you working with someone in particular in the design stage? 20140312 03:19:23< Aishiko_laptop> you and zookeeper spring to mind as the ones that gave the most input in the how to do it phase after that it was random help from the channel usually by you or Soliton 20140312 03:19:29< Aishiko_laptop> shadowm, ^^ 20140312 03:19:45< Aishiko_laptop> I have to say I learned alot fighting with it 20140312 03:20:48< shadowm> int recall_dialog(display& disp, std::vector< const unit* >& units, int side, const std::string& title_suffix, const int team_recall_cost) 20140312 03:21:25< shadowm> Okay, so... 20140312 03:21:31< shadowm> Why is team_recall_cost const? 20140312 03:22:25< Aishiko_laptop> it is really, it needs to not change even by accident in the dialog for comparison purposes 20140312 03:22:47< shadowm> I'm not saying that this is unacceptable practice, but it's very rare to see a function's POD parameter be declared const. 20140312 03:23:47< shadowm> Since this is C++, if team_recall_cost weren't const, you could modify it in recall_dialog() and the caller wouldn't know. 20140312 03:23:57< shadowm> This is because it's passed by copy, not reference. 20140312 03:24:42< Aishiko_laptop> your right, I should have that by ref, not by value 20140312 03:24:57< shadowm> Not really. 20140312 03:25:25< shadowm> I mean, unless you intended recall_dialog() to alter the original value and propagate the alterations done to the caller. 20140312 03:26:29< shadowm> Passing POD types like that by const reference is usually not necessary, and this is because their internal representation usually takes as much space (or even less) than the internal representation of a reference. 20140312 03:26:35< Aishiko_laptop> no, it shouldn't change at all, it should be set at the loading of the mission and not change during that time (from what I understand of it) 20140312 03:27:51< Aishiko_laptop> I guess I was falling back on the old classroom teaching "if its not going to or supposed to change make it a const" 20140312 03:29:06< shadowm> That is also a thing that we use extensively throughout Wesnoth, except for the aforementioned cases. 20140312 03:29:37< shadowm> As I said, it's not a problem, but it's rare to see this in function declarations for non-references. 20140312 03:29:53< shadowm> Opening braces should be preceded by a single space for readability (e.g. "if (true) {" , not "if (true){" ) 20140312 03:30:11< Aishiko_laptop> ohh I thought I had caught all those 20140312 03:30:24< shadowm> Also, assignment operators should be surrounded by spaces. 20140312 03:30:31< shadowm> e.g. https://github.com/Aishiko/wesnoth/commit/68f5464f556bf46109e1557c09d95093dd2293f1#diff-d66b3ca7e9a2f61c2ae838490dd2137cR120 20140312 03:30:32< Aishiko_laptop> let me guess I missed one 20140312 03:31:20< shadowm> https://github.com/Aishiko/wesnoth/commit/68f5464f556bf46109e1557c09d95093dd2293f1#diff-c13e8bd6a835ac26a08a5d2cbc5afee9R731 <- trailing whitespace (git diff will highlight these in red depending on the pager and terminal configuration). 20140312 03:31:40< Aishiko_laptop> sorry, I though I had caught all the convention violations (of the type I know of) 20140312 03:32:04< shadowm> And if you are going to have a closing brace on the same line as an else, it should be followed by a space too for readability. 20140312 03:32:46< Aishiko_laptop> do you mean opening brace? 20140312 03:33:16< shadowm> No, closing brace: https://github.com/Aishiko/wesnoth/commit/68f5464f556bf46109e1557c09d95093dd2293f1#diff-aa2699b29ec1e4e51dd411b0954d308fR551 20140312 03:33:25< gfgtdf> what is the normal way to put wml code in a bug report (having it in a yellow background)? 20140312 03:33:32< shadowm> }else if(cost == team_recall_cost){ -> } else if(cost == team_recall_cost) { 20140312 03:34:27< Aishiko_laptop> ohh I thought I had those } on one line and the else statement on the following 20140312 03:35:23< shadowm> It's hard to say whether to prefer } else { or } \n else { considering that both styles appear a lot in the source. 20140312 03:36:00< shadowm> Because we are too lazy to come up with formatting style guidelines beyond preferring block bodies for control blocks or something. 20140312 03:36:32< shadowm> Mysterious commented-out addition: https://github.com/Aishiko/wesnoth/commit/689bfccd2f9d5a702623bc33048f2b4dca9a1e43#diff-799f3b81330128fd7736e518a2826320R230 20140312 03:36:45< Aishiko_laptop> I personally like having the {} on their own lines it makes it easier for me to see where a block begins and ends 20140312 03:37:49< shadowm> I think these are all the (my) style concerns at first glance. 20140312 03:38:09< shadowm> I'm going to try out the changes in a while. 20140312 03:38:16< Aishiko_laptop> shadowm, do you mean I think belongs elsewhere? 20140312 03:38:23< Aishiko_laptop> that comment? 20140312 03:38:52< shadowm> Aishiko_laptop: No, I mean that adding a commented-out piece of code without a visible explanation is usually a warning sign and not a nice thing to do. :) 20140312 03:39:15< shadowm> For example, it may mean that the coder forgot to uncomment it. 20140312 03:39:54< Aishiko_laptop> actually in this case I think it means I forgot to delete it 20140312 03:40:12< shadowm> Also, you should add a note to the changelog (try to stick to the existing format for changelog entries please, everyone gets this wrong all the time somehow), and add yourself to Miscellaneous Contributors in data/core/about.cfg respecting the existing alphabetical order for "Real Name (nicks)". 20140312 03:40:33-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has quit [Read error: Connection reset by peer] 20140312 03:40:40< shadowm> You should probably add the changelog entry in a separate commit so changelog conflicts can be easily resolved (yes, this tends to happen all the time). 20140312 03:42:25-!- sachith500_ [c0f80841@gateway/web/freenode/ip.192.248.8.65] has joined #wesnoth-dev 20140312 03:42:46-!- linii [~SEXY@pa-67-234-250-183.dhcp.embarqhsd.net] has joined #wesnoth-dev 20140312 03:43:29< Aishiko_laptop> right patch 4 fix style errors, patch 5 change log, and put "real name nicks" format 20140312 03:44:15< shadowm> It was more like 4 style, 5 credits, and 6 changelog 20140312 03:45:14< Aishiko_laptop> ohh I forgot the change log and then confused it with the credits 20140312 03:46:17< shadowm> The alternative is to rewrite the branch and apply the style fixes to each commit in order, but that requires more Git magic. 20140312 03:47:04< shadowm> Although everyone here should be required to learn about that magic (`git rebase -i`), it's not the case, alas. 20140312 03:47:08-!- linii [~SEXY@pa-67-234-250-183.dhcp.embarqhsd.net] has quit [Ping timeout: 252 seconds] 20140312 03:47:45< Aishiko_laptop> something to learn, which I will likely have to if I get accepted 20140312 03:52:19< shadowm> So, for example, you could as an experiment copy your branch onto another branch (say, `git branch feature/unit-recall-costs backup/feature-unit-recall-costs`), and then try running `git rebase -i`. 20140312 03:53:08-!- gfgtdf [~chatzilla@f054134035.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 27.0.1/20140212131424]] 20140312 03:53:16< shadowm> git rebase -i will present you with a new text document in the default editor (same as with git commit), with various comments explaining what the text is about. The lines at the top are the commits in the branch and the actions to take after saving the file. 20140312 03:53:40< Aishiko_laptop> ok, and the }else I know where that came from I copied another section of code that did something similar modified it and didn't touch the structure as it had already passed and thought "well if its this way it has to be for a reason" 20140312 03:54:12< Aishiko_laptop> okay I'll add that to my experiment list 20140312 03:54:13< shadowm> Changing 'pick' with 'edit' in those lines will cause the rebase process to stop after each one of those commits to give you a chance to 'amend' them. 20140312 03:55:49< shadowm> When in that state, running `git show -p` will show the commit's diff so you can have an idea of what you want to change in the commit. `git commit --amend` can then be used after you've done the amendments, and then `git rebase --continue` to proceed onto the next commit to edit until there are no more commits left, at which point you will return to the branch with the amended commits. 20140312 03:56:15-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20140312 03:56:38< shadowm> Aishiko_laptop: So, will you do that, or opt for a simple fourth commit for the formatting amendments? 20140312 03:58:10-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has joined #wesnoth-dev 20140312 03:59:12< Aishiko_laptop> shadowm, which would you think would be better? I'll follow your advice on this front 20140312 03:59:32< Aishiko_laptop> shadowm, were the descriptions better this time? 20140312 03:59:58-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 240 seconds] 20140312 04:00:02< shadowm> It depends on how confident you feel trying something new that may utterly destroy your commits if you fail to follow the instructions given by Git. ;) 20140312 04:01:09< Aishiko_laptop> hmmm in that case I'll do the second set of patches... THEN try it that way if I screw something up at least I've got something out there 20140312 04:01:41< Guest68086> git-rebase is certainly something that’s good to learn, though it is also something that’s good to be careful with. 20140312 04:02:22< Aishiko_laptop> shadowm, I did a rebase.... I stashed my commits before I did whatever that is 20140312 04:03:19-!- Guest68086 is now known as _8680_ 20140312 04:03:27< shadowm> Aishiko_laptop: Hm, 'did'? I don't think you used -i or instructed Git to amend the commits replacing 'pick' with 'edit' in the list of commits, unless you are that fast. 20140312 04:04:03-!- justinzane_ [~justinzan@tiny.justinzane.com] has quit [] 20140312 04:04:03< Aishiko_laptop> ohh no with out the -i before I went.... *small voice" "help" 20140312 04:04:38< shadowm> Without -i rebase will probably do nothing. 20140312 04:04:56< Aishiko_laptop> shadowm, what did you think of my logic of making it all work? 20140312 04:05:18< _8680_> I’d say your commit messages have improved. 20140312 04:05:21< Aishiko_laptop> shadowm, it suggested I do that, in the man page which I looked at before going "help" 20140312 04:05:35< Aishiko_laptop> <--- more then an ugly face 20140312 04:05:41< _8680_> However, “Implementing menu […]” should be “Implement menu”, etc. 20140312 04:05:52< sachith500_> oh? rebase tutorials? ;) 20140312 04:05:59< shadowm> Aishiko_laptop: Right, I gave you specific instructions so you wouldn't have to look at the documentation (yet). 20140312 04:06:27 * sachith500_ squashes commits like so many bugs. 20140312 04:06:38< Aishiko_laptop> shadowm, I always read the man pages before I go and look for human help, 9 times out of 10 that works 20140312 04:10:42< Aishiko_laptop> _8680_, thank you, I'm trying to follow the conventions, which when it comes to writing stuff (non code) tends to be very very bad. You saw like version 3 or 4 of the messages if not 5 or 6 20140312 04:11:58-!- vorobeez [~quassel@85.142.148.12] has joined #wesnoth-dev 20140312 04:12:28< vorobeez> good morning! :) 20140312 04:12:35< shadowm> Hi. 20140312 04:13:27< Aishiko_laptop> morning vorobeez 20140312 04:17:25-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev 20140312 04:48:08-!- sachith500_ [c0f80841@gateway/web/freenode/ip.192.248.8.65] has quit [Ping timeout: 245 seconds] 20140312 05:02:33-!- sachith500_ [c0f80841@gateway/web/freenode/ip.192.248.8.65] has joined #wesnoth-dev 20140312 05:14:36-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer] 20140312 05:14:51-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140312 05:16:57-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20140312 05:17:59< shadowm> Aishiko_laptop: Any progress? 20140312 05:20:01-!- vorobeez [~quassel@85.142.148.12] has quit [Remote host closed the connection] 20140312 05:40:38< EliDupree> Hmm... how does $this_unit behave with nested SUFs? 20140312 05:45:45-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140312 05:49:15< Aishiko_laptop> shadowm, I think so 20140312 05:50:09< Aishiko_laptop> shadowm, are you liking the changes? 20140312 05:51:43< shadowm> Aishiko_laptop: Uh, I took a look at them earlier as I said, I didn't find any problems with them other than what I pointed out. I will test them soon, but I presume you already tested them too? 20140312 05:51:53< shadowm> A thing I forgot to mention, though: 20140312 05:51:58< shadowm> s.recalls[u.type_id()]--; 20140312 05:52:42< shadowm> THis is a stand-alone statement, so nothing depends on the order of the increment/decrement. I believe it's generally preferred in this case to use the prefix increment/decrement operator instead. 20140312 05:54:34< shadowm> I heard somewhere that this is ultimately because prefix increment/decrement can be resolved to a single instruction on the x86 ISA, no idea how true that is but it makes sense. 20140312 05:55:28< shadowm> But that's a tiny thing that doesn't really matter, just worth keeping in mind in the future. 20140312 05:55:42< Aishiko_laptop> shadowm, I did a number of tests making sure costs were read right but I didn't do an scenario testing 20140312 05:56:19< Aishiko_laptop> shadowm, again that is a line of code that I copied as it did what I needed and I didn't change a thing 20140312 06:06:27< Aishiko_laptop> I've tested changing it in the cfg file, and then recalling up to 3 random units of various costs and checking that undoing each one in order gave the right amount back, made sure the whiteboard was performing properly and displaying the right cost for each unit, basically if it directly affected user interaction I tried to think of it and make it just work 20140312 06:08:25-!- blarumyrran [~Bbbb123@wesnoth/artist/blarumyrran] has joined #wesnoth-dev 20140312 06:11:53-!- sachith500_ [c0f80841@gateway/web/freenode/ip.192.248.8.65] has quit [Ping timeout: 245 seconds] 20140312 06:17:32< shadowm> Aishiko_laptop: Sorry was, busy, I'll get to it. 20140312 06:17:34< shadowm> *, was 20140312 06:19:35< shadowm> Why is the fourth commit's summary in Title Case? :p 20140312 06:22:13< shadowm> Aishiko_laptop: Hm, recall_cost is cumulative? 20140312 06:22:50< shadowm> No wait, that's not it, hm... 20140312 06:23:39< shadowm> I set side 1's recall_cost to 40, the Elvish Fighter's recall_cost to 14, and in this scenario I push three units into side 1's recall list: a Fighter with a recall_cost of 2, a Druid with a recall_cost of 1, and a Fighter with no custom recall_cost. 20140312 06:24:04< shadowm> All three are displayed as costing 65 gold in the recall menu, and I get 65 gold deduced when recalling any of them. 20140312 06:24:53< shadowm> 65 = 40 + 14 + 1, so not sure what's going on. 20140312 06:25:12< Aishiko_laptop> what? I didn't have that happen to me 20140312 06:25:37< Aishiko_laptop> can you send me that file? 20140312 06:26:24< shadowm> Er, no, I probably chose the worst campaign to test with those changes. 20140312 06:26:30< Aishiko_laptop> ohhh 20140312 06:26:31< shadowm> Let me try HttT S1 instead... 20140312 06:27:11< Aishiko_laptop> alright 20140312 06:27:55< shadowm> Eh. 20140312 06:28:01< shadowm> Now they all display as costing 0 gold. :\ 20140312 06:28:18-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has quit [Quit: linii] 20140312 06:28:55< shadowm> Aishiko_laptop: http://pastebin.com/bXpdcQru 20140312 06:31:58< Aishiko_laptop> on it, I figured someone would be able to break it, I just wasn't counting on it being so soon! 20140312 06:38:02< Aishiko_laptop> I'm surprised the fighter didn't come up with the right cost 20140312 06:40:02< Aishiko_laptop> shadowm, your right, that's really odd 20140312 06:47:49-!- sachith500_ [c0f80841@gateway/web/freenode/ip.192.248.8.65] has joined #wesnoth-dev 20140312 06:49:33< Aishiko_laptop> well I feel slightly frustrated, I though I had it all ready 20140312 06:50:35 * shadowm is all too familiarized with the feeling. 20140312 06:51:47< sachith500_> we could have had it aalllllllllllllll 20140312 06:51:53 * sachith500_ is rolling in the deep 20140312 06:52:06< Aishiko_laptop> I think I might have missed something in the lua that deals specifically with scenario loading 20140312 06:53:35< shadowm> Hm, no, I don't think that is the case, mainly because it doesn't make sense. 20140312 06:54:15< shadowm> [side] and [unit] are handled exclusively in the C++ side of things, and [unit_type]s are registered before the Lua engine is even available. 20140312 06:56:26< Aishiko_laptop> shadowm, I think I found it I screwed up the loading somehow. It worked fine in 1.11 when inserted into the unit type's config file (I had a tendancy to stick it right under the level) 20140312 06:56:58< Aishiko_laptop> I'm trying a different loading idea and I hope it will bare better results 20140312 06:58:22< shadowm> It looks to me like there are values from nowhere being added. 20140312 06:58:57< Aishiko_laptop> shadowm, I'm as surprised as you! I mean I had it working! 20140312 07:00:11< Aishiko_laptop> it I didn't I wouldn't have even suggested adding it! 20140312 07:12:51< Aishiko_laptop> shadowm, well It looks like I'm going to deal with this for a bit longer then I thought! 20140312 07:14:53< EliDupree> Is it useful to report a gui2 assertion failure, or is that code going to see a more thorough review? 20140312 07:15:02-!- Guest20355 [~shikadi@ai0867.net] has quit [Changing host] 20140312 07:15:02-!- Guest20355 [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20140312 07:15:05-!- Guest20355 is now known as shikadibot 20140312 07:15:44< shadowm> EliDupree: The worst-case scenario is that your bug gets marked as Invalid or Won't Fix. 20140312 07:15:56< EliDupree> Or Duplicate 20140312 07:16:05< shadowm> The best-case scenario is that you provided mordante with information he didn't know. 20140312 07:17:25< shadowm> Duplicate bugs are occasionally helpful too, since sometimes the original report contains less information or isn't general enough. 20140312 07:17:35< Aishiko_laptop> EliDupree, I agree that more info is better then less... though checking to see if some else had that issue and linking to it or adding your info to it would be the best way to go assuming that there is already a report about it 20140312 07:17:49< EliDupree> alright 20140312 07:18:05< shadowm> (That said, checking for existing bug reports and add to them rather than filing duplicates is preferred.) 20140312 07:18:09< shadowm> *adding 20140312 07:19:42< shadowm> Hm, I hope SLF find_in works for events... 20140312 07:20:22< shadowm> OTOH performance concerns... blargh. 20140312 07:27:11-!- wesbot changed the topic of #wesnoth-dev to: 1.12 branch created | string+feature freeze active on 1.12 | 222 bugs, 352 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140312 07:30:05-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20140312 07:30:12-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Client Quit] 20140312 07:31:17-!- justinzane [~justinzan@tiny.justinzane.com] has joined #wesnoth-dev 20140312 07:42:14-!- Gallaecio [~quassel@84.120.218.65.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 20140312 07:46:41-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140312 07:50:26-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140312 07:52:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20140312 08:05:36-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20140312 08:24:42-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20140312 08:35:49-!- eldruz [~eldruz@lav35-1-82-236-137-179.fbx.proxad.net] has joined #wesnoth-dev 20140312 08:36:03-!- sachith500_ [c0f80841@gateway/web/freenode/ip.192.248.8.65] has quit [Ping timeout: 245 seconds] 20140312 08:45:16-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev 20140312 08:46:19-!- mjs-de [~mjs-de@f048226174.adsl.alicedsl.de] has joined #wesnoth-dev 20140312 08:55:10-!- Octalot [~noct@31.185.149.167] has joined #wesnoth-dev 20140312 09:01:34< zookeeper> urgh. why have i never thought of suggesting a wmllint/etc GUI as a GSoC task? 20140312 09:02:05< shadowm> I was thinking the other day about making a wmllint GUI but then I decided there's nothing to GUIfy in it. 20140312 09:04:42< zookeeper> except everything :p 20140312 09:04:45-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Quit: Vannak idők, mikor menni kell] 20140312 09:05:26< shadowm> Not really. 20140312 09:06:15< shadowm> First there's the issue that wmllint is internally inconsistent in regards to how file locations get reported, since so many different people have had their hands on it. 20140312 09:07:54< shadowm> Second, what would you do besides pointing people to the files mentioned in the output or maybe showing some context that they could already obtain by checking in their text editor? (Which is something that they'll end up doing most of the time, anyway.) 20140312 09:08:00-!- Coffee_irc [~david@ppp118-210-31-67.lns20.adl2.internode.on.net] has joined #wesnoth-dev 20140312 09:09:00< shadowm> To me, it seems like the most demanding task with wmllint is installing python, which is to my knowledge non-trivial only on Windows. 20140312 09:09:31< vultraz> shadowm: it's very trivial even on windows 20140312 09:09:59< shadowm> wmlindent is so trivial in comparison to wmllint it's ridiculous. 20140312 09:10:24< shadowm> wmlscope is a shitwreck in 1.11.x. 20140312 09:12:09< zookeeper> what would it do? well, all the things GUI apps usually do. i don't know if i care to write a spec for what all it should be capable of. 20140312 09:14:46< shadowm> Shrug. Applications (GUI or otherwise) usually do a vast range of things related to the task they are intended to accomplish. I could write a simple script that shows a message box with an OK button and call it a wmllint GUI. 20140312 09:40:07-!- sachith500_ [c0f80841@gateway/web/freenode/ip.192.248.8.65] has joined #wesnoth-dev 20140312 09:40:58-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20140312 09:42:54-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev 20140312 09:53:13-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection] 20140312 09:53:48-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140312 09:56:57-!- mehul [671b082b@gateway/web/freenode/ip.103.27.8.43] has joined #wesnoth-dev 20140312 09:57:54-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 245 seconds] 20140312 09:58:36-!- mehul [671b082b@gateway/web/freenode/ip.103.27.8.43] has quit [Client Quit] 20140312 10:00:50-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 246 seconds] 20140312 10:09:33-!- stikonas [~gentoo@cpat003.wlan.net.ed.ac.uk] has joined #wesnoth-dev 20140312 10:09:34-!- stikonas [~gentoo@cpat003.wlan.net.ed.ac.uk] has quit [Changing host] 20140312 10:09:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140312 10:17:18-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 10:18:16< fabi_> zookeeper: the eclipse umc plugin is a wml frontend. 20140312 10:18:29< fabi_> s/wml/wmllint 20140312 10:30:44-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20140312 10:31:13-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140312 10:56:43-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140312 10:58:18-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20140312 11:05:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140312 11:11:08-!- EdB [~edb@37.163.147.39] has joined #wesnoth-dev 20140312 11:11:32-!- eldruz [~eldruz@lav35-1-82-236-137-179.fbx.proxad.net] has quit [Ping timeout: 252 seconds] 20140312 11:19:21-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 264 seconds] 20140312 11:19:36-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginmedia.com] has joined #wesnoth-dev 20140312 11:33:26-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginmedia.com] has quit [Quit: DCW] 20140312 11:36:19-!- sachith500_ [c0f80841@gateway/web/freenode/ip.192.248.8.65] has quit [Quit: Page closed] 20140312 11:38:28-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev 20140312 11:47:44-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20140312 12:01:18 * vultraz pings lipkab 20140312 12:01:42< lipkab> What does vultraz want from lipkab? 20140312 12:02:34< vultraz> I seem to recall there was some issue with using var op random in mp. Is that still the case? 20140312 12:04:28-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140312 12:04:33< lipkab> vultraz: "random" is still MP-unsafe IIRC but that's why also have "rand". 20140312 12:05:45< vultraz> ah, right. 20140312 12:05:50-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 12:06:05< vultraz> ok, I don't think that warrants a dedicated note 20140312 12:07:14< shadowm> !log 4ed02e010d7ca3a6571c308c4f5405830d3bfd23 20140312 12:07:14< shikadibot> shadowm: Revision 4ed02e010d7c (Alexander van Gessel) on Sat Mar 27 02:20:30 2010: 20140312 12:07:18< shikadibot> shadowm: Make [set_variable] random use rand code. 20140312 12:07:20< shikadibot> shadowm: Web interface URL: https://github.com/wesnoth/wesnoth/commit/4ed02e010d7c 20140312 12:07:37< vultraz> Just have a feeling I forgot to list something here http://wiki.wesnoth.org/MultiplayerContent 20140312 12:07:53< shadowm> !log da8833808872fa78fe56f924aea7166db06a8eba 20140312 12:07:54< shikadibot> shadowm: Revision da8833808872 (Mark de Wever) on Sat Apr 9 15:59:59 2011: 20140312 12:07:57< shikadibot> shadowm: Remove some deprecated backwards compability code. 20140312 12:08:00< shikadibot> shadowm: Web interface URL: https://github.com/wesnoth/wesnoth/commit/da8833808872 20140312 12:08:11< shadowm> You don't have "random" anymore. 20140312 12:08:37< vultraz> (that page is a renamed MultiplayerCampaigns page with a small section on single scenarios, which is where I think I'm missing something...) 20140312 12:11:00< lipkab> I wonder how could I remember somehing that was deleted from the code before I started playing Wesnoth. 20140312 12:11:08< lipkab> *something 20140312 12:11:38< vultraz> ...huh 20140312 12:12:22< lipkab> Maybe I'm a reincarnation of a dead Wesnoth dev. 20140312 12:12:22< vultraz> lipkab: just to be sure, is any of this still relevant either? http://wiki.wesnoth.org/BuildingMultiplayerExamples#Random it's still linked from InternalActionsWML which leads me to think it might be 20140312 12:13:26< vultraz> Even though BME is marked as obsolete >_> 20140312 12:15:26< lipkab> vultraz: I think that's still a valid concern, but I can't tell for sure. 20140312 12:16:57< vultraz> Alright. I'll copy that section before deleting the page, then 20140312 12:17:29< shadowm> I'm going to disable the wiki in 12 minutes. 20140312 12:17:54 * vultraz hurries 20140312 12:21:41< vultraz> alright 20140312 12:22:07< vultraz> I'll do further editing later 20140312 12:27:06-!- TC01 [~quassel@128.220.109.252] has joined #wesnoth-dev 20140312 12:37:28-!- iSwapnil [~swapnil@122.163.236.211] has joined #wesnoth-dev 20140312 12:39:29< shadowm> The wiki is back. 20140312 12:43:38< vultraz> heh. was this the predecessor of Wesnoth's FOSDEM attendance? http://wiki.wesnoth.org/Wesconf 20140312 12:44:52< elias> when was the first fosdem? 20140312 12:45:00< elias> (with wesnoth people attending) 20140312 12:45:35< elias> might have been 2007, and they went there instead of dortmund 20140312 12:46:42< vultraz> Seems 2008 20140312 12:46:55< vultraz> That's the earliest mention on the wiki 20140312 12:47:06< elias> i see 20140312 12:47:28< elias> (and it sounds like that dortmund meeting never came to be, from that wiki page) 20140312 12:50:12-!- Rh0nda is now known as Rhonda 20140312 12:50:17-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Changing host] 20140312 12:50:17-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev 20140312 12:50:47< vultraz> Well, since Fosdem is in February, it's possible they just abandoned their 2007 plans and went to fosdem in early 2008 20140312 13:05:30-!- sachith500 [~kvirc@112.135.174.212] has joined #wesnoth-dev 20140312 13:10:16< sachith500> hey how is the "Student proposals not submitted to google" updated? 20140312 13:18:37-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has joined #wesnoth-dev 20140312 13:18:37-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has quit [Changing host] 20140312 13:18:37-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140312 13:19:21< sachith500> hey happygrue :D 20140312 13:19:28< sachith500> I added a timeline yesterday 20140312 13:19:38< sachith500> any thoughts, is it detailed enough? 20140312 13:19:54< sachith500> http://wiki.wesnoth.org/GSoC_sachith500_Proposal 20140312 13:21:23< happygrue> hello sachith500 20140312 13:21:25< happygrue> I'll take a look 20140312 13:21:29< sachith500> ok thank you 20140312 13:22:08< sachith500> I'll fill out more details over time, got a lot of due submissions these days :( 20140312 13:22:33< Aishiko_laptop> shadowm I found the issue!!! in the creating and deleting branches a single line of code got removed, and that was causing part of the issue! add it back in and things start working again. 20140312 13:24:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140312 13:25:18< happygrue> sachith500: it looks good to me. I'm sure that a certain amount of working ahead/falling behind will happen but it seems a reasonable outline at first glance. 20140312 13:25:21< happygrue> one thing: 20140312 13:25:35< sachith500> yeah? 20140312 13:25:49< sachith500> I added timing for the presentation bit 20140312 13:26:08< sachith500> if the project scope is too much that part might get pushed back 20140312 13:26:26< happygrue> I see some documentation lines in there, but one thing it would be good to do near the end is to build in some time to update any relevent wiki stuff and annouce the new features. maybe that's what you have in mind there but it's not clear to me 20140312 13:26:39< sachith500> yeah 20140312 13:26:42< happygrue> basically, it's only useful if people know all of what they can do with it 20140312 13:26:43< sachith500> documentation = everything 20140312 13:26:45< sachith500> relevant 20140312 13:26:47< happygrue> great 20140312 13:26:55< sachith500> I intend to do it along the way too 20140312 13:26:57< happygrue> I like it! 20140312 13:27:01< sachith500> but every time something major happens 20140312 13:27:11< sachith500> would go back and update everything :) 20140312 13:27:25< Aishiko_laptop> happygrue, last year a multi year admin/mentor suggested leaving the last 2 weeks as a pad to do all the little things that seem to get pushed to the end or forgotten 20140312 13:27:47< sachith500> in my case the presentation bit is essentially padding 20140312 13:27:57< sachith500> if the scoping is wrong 20140312 13:28:02< sachith500> I'll probably do it out of gsoc 20140312 13:28:10-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev 20140312 13:28:14-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Client Quit] 20140312 13:28:22< sachith500> our uni gives credit for gsoc projects :D 20140312 13:28:45< sachith500> If there's no presentation, they'd probably cut some marks :P 20140312 13:28:57< happygrue> ;) 20140312 13:29:04< sachith500> :D 20140312 13:29:38< sachith500> happygrue 20140312 13:29:38< sachith500> there's no ban on submitting patches etc after march 21 right? 20140312 13:29:40< happygrue> We'll we'd be happy just to get the collection stuff done and everything on top of that is bonus. But I'd love to see some basic data display stuff of course :D 20140312 13:29:41< sachith500> because I'm a little swamped atm 20140312 13:29:47< sachith500> yeah 20140312 13:29:48< sachith500> same 20140312 13:30:05< sachith500> would hate to work so hard, and not make it usable 20140312 13:30:08< sachith500> at least on a basic level 20140312 13:30:13< sachith500> to everyone :D 20140312 13:31:40< happygrue> I don't think there is a ban on patches sachith500, but I'm not sure 20140312 13:31:55< happygrue> I think that's just the application deadline stuff 20140312 13:32:45< Soliton> what patches? 20140312 13:32:47< Aishiko_laptop> happygrue, I was told it was just the application deadline in channel but, I've not seen that on a webpage or anything "official" looking 20140312 13:34:05< Ivanovic> Soliton: patches against our code which we then consider as part of the students application 20140312 13:34:14< Ivanovic> sachith500: just look at the official timeline 20140312 13:34:23< Soliton> that's my guess but who knows. 20140312 13:34:25< Ivanovic> at some point in time we need to decide which student to accept 20140312 13:34:39< Ivanovic> looking at the timeline my guess is that we might decide this around the 7th 20140312 13:40:22-!- bagzie [~bag@85-76-51-87-nat.elisa-mobile.fi] has joined #wesnoth-dev 20140312 13:41:42< shadowm> Aishiko_laptop: Good, now where's the code? 20140312 13:43:27-!- EdB [~edb@37.163.147.39] has quit [Quit: Konversation terminated!] 20140312 13:44:24< sachith500> hmm 20140312 13:44:51< Aishiko_laptop> shadowm, its only 1/2 done (IE reading from the unit cfg but not the scenario, btw thank you for that file) 20140312 13:46:03-!- lyssdod [~lyssdod@95.158.53.148] has quit [Quit: Leaving] 20140312 13:47:05< Aishiko_laptop> shadowm, however, http://pastebin.com/f8jz4EPA gets it reading from the cfgs 20140312 13:47:33< shadowm> UH, this means that the unit_type recall_cost was being ignored before? 20140312 13:48:12< shadowm> (That's not a valid diff, btw, only a single hunk I just automatically guessed belongs in src/unit_type.cpp.) 20140312 13:50:00< shadowm> I'm still not sure how that would result in those ridiculous numbers. 20140312 13:52:29-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer] 20140312 13:52:45-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140312 13:53:55-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer] 20140312 13:54:22< Aishiko_laptop> shadowm, sorry I chopped some off by accident, and your right in unit_types, and I think in a way it does, since that mem never got initialized it just grabbed whatever was there before which could be anything 20140312 13:54:38< shadowm> Eek. 20140312 13:54:56< Aishiko_laptop> but a read-only runtime error thankfully! 20140312 13:55:07< shadowm> Yeah, always initialize all fields in the constructor's initializer list. 20140312 13:55:29 * shadowm should try to keep that kind of thing in mind when reviewing patches. 20140312 13:57:48-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140312 13:58:32-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer] 20140312 13:58:56< Aishiko_laptop> shadowm, I thought I had as I had it working, but somehow that line got deleted, likely when I was cleaning up the code for review by accident 20140312 14:02:49-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140312 14:07:13< Aishiko_laptop> I'm still hunting down why its not loading WML recall_ costs 20140312 14:15:06< lipkab> Aishiko_laptop: Don't forget to add a changelog entry! 20140312 14:15:24 * lipkab loves reminding people to add changelog entries. 20140312 14:16:07< sachith500> haha were you the one who reminded me for my PR too lipkab? :D 20140312 14:17:24< lipkab> No, actually that was a self-ironic joke, because I never write anything into the changelog :P 20140312 14:17:33< Aishiko_laptop> lipkab, its on the way but until I track down these last 2 errors its premature I think =) 20140312 14:21:40< Ivanovic> okay, just sent a mail to the dev-ml regarding work that prospective mentors got to do over the next days 20140312 14:21:56< Ivanovic> happygrue: no idea if you consider to mentor, if you do so, please follow the steps 20140312 14:22:10< Ivanovic> everyone who already volunteered to mentor got the mail directly, too 20140312 14:22:49-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140312 14:23:30-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 14:25:06< sachith500> so Ivanovic 20140312 14:25:20< sachith500> when would be the patch submission deadline be? 20140312 14:25:22< sachith500> 21st march? 20140312 14:25:29< sachith500> I already did 2 small bug fixes 20140312 14:25:40< sachith500> have been working on the proposals since, is that all right? 20140312 14:27:53-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 246 seconds] 20140312 14:28:20< sachith500> Aishiko_laptop: you mess around with arduino? 20140312 14:28:22< sachith500> cool ;D 20140312 14:28:39< Ivanovic> sachith500: as i said above, there is no fixed deadline 20140312 14:28:42< happygrue> sachith500: there isn't a patch deadline. You could keep working on stuff up to the time candidates are selected 20140312 14:28:48< sachith500> oh all right 20140312 14:28:53< sachith500> I got a bit confused, sorry 20140312 14:28:53< Ivanovic> sachith500: just look at the mail i sent to the dev-ml 20140312 14:28:59< sachith500> will do 20140312 14:29:01< sachith500> :D 20140312 14:29:01< Ivanovic> it explains the basic process we as mentors got 20140312 14:30:05< sachith500> cool 20140312 14:30:12< happygrue> Ivanovic: I have no strong opinion either way about "offical" mentoring. I had assumed some assesment of student's code was a requirement which I wouldn't be able to do very well. I would only be evaluating finished product really, is that a problem? 20140312 14:30:29< happygrue> I'll also be traveling about 3 weeks over the summer 20140312 14:30:47< sachith500> well you aren't expected to spoon feed the students right :P 20140312 14:31:18< happygrue> :D 20140312 14:31:22< sachith500> I assume the students mostly have some small design questions after the first week or two? 20140312 14:31:57< lipkab> Er, rolling the mouse wheel away from yourself should scroll the map down, right? 20140312 14:32:02< happygrue> That would depend on how smoothly everything goes I guess ;) 20140312 14:32:08< sachith500> true :P 20140312 14:32:24< sachith500> hence why this time is very important for the proposal brainstorming 20140312 14:32:48< sachith500> although doing that too much can be nasty as well hehe 20140312 14:32:57< lipkab> ...no. 20140312 14:33:04-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has joined #wesnoth-dev 20140312 14:33:13< Soliton> lipkab: depends how you hold your mouse? :-) 20140312 14:33:18< happygrue> hehe 20140312 14:33:19< sachith500> hahaha 20140312 14:33:40< sachith500> you need to be rigorous 20140312 14:33:49< sachith500> when you ask questions on IRC 20140312 14:33:53 * sachith500 makes a mental note. 20140312 14:33:59< happygrue> I would say rolling down to move map up would be "inverted" 20140312 14:34:39< aquileia> lipkab: Thanks for testing again, and good catch! The "gridrow" was a remnant of the unusual indentation in lobby_main 20140312 14:34:56< lipkab> aquileia: Yeah, I guessed so :) 20140312 14:35:23< aquileia> As to the grep command... 20140312 14:35:24< aquileia> grep "\[[a-z,_,-]*\]" *.cfg --no-filename | tr -d '\t' | sort | uniq -o 20140312 14:35:30< aquileia> is this ok? 20140312 14:35:32< lipkab> No. 20140312 14:35:41< lipkab> grep "\[[a-z,_,-]*\]" *.cfg --no-filename -o | tr -d '\t' | sort | uniq -o 20140312 14:35:48< lipkab> I mean, 20140312 14:35:50< aquileia> ah, ok 20140312 14:35:56< lipkab> grep "\[[a-z,_,-]*\]" *.cfg --no-filename -o | tr -d '\t' | sort | uniq 20140312 14:36:04< lipkab> ^This. 20140312 14:36:10< Soliton> unlikely. 20140312 14:36:26< Soliton> [a-z,_,-] doesn't make a lot of sense. 20140312 14:36:33< lipkab> Ah? 20140312 14:36:39< Soliton> maybe [a-z_-] was meant. 20140312 14:36:59< Soliton> or better [[:lower:]] 20140312 14:37:23< sachith500> ooh regex fun 20140312 14:37:24< Soliton> since depending on locale [a-z] does not mean lower case letters. 20140312 14:37:24< lipkab> Oh, okay. I'm not really good with regexes. 20140312 14:37:25< zookeeper> rawwwr [*,_,*] 20140312 14:37:31< lipkab> Or regices? 20140312 14:37:35< sachith500> haha 20140312 14:37:46< lipkab> I don't even know how to put it into plural :( 20140312 14:37:54< sachith500> well regular expressions 20140312 14:37:56< Soliton> regular expressions. :-P 20140312 14:37:56< sachith500> so regexs 20140312 14:37:58< sachith500> ;) 20140312 14:38:09< sachith500> regice is a pokemon 20140312 14:38:32< Soliton> does it eat regex for breakfast? 20140312 14:38:38< sachith500> and dinner 20140312 14:40:15< Soliton> also note that sort has -u. 20140312 14:40:30< Soliton> where is that grep command run? 20140312 14:41:11< aquileia> In a comment how to reproduce a tag list 20140312 14:41:35< Soliton> ok, where is that grep command supposed to be run? 20140312 14:42:15< lipkab> data/gui/w[[:lower]] 20140312 14:43:22< Soliton> data/gui/default/w*? 20140312 14:43:55< lipkab> Yeah. 20140312 14:44:23-!- bagzie [~bag@85-76-51-87-nat.elisa-mobile.fi] has quit [] 20140312 14:44:52< aquileia> ... and src/gui/widgets IIRC to get the last four entries 20140312 14:45:35-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 14:46:33< Soliton> are you sure? there are no cfg files there. 20140312 14:47:06< Soliton> i would suggest: grep "\[[[:lower:]_-]\+\]" data/gui/default/w*/*.cfg --no-filename -o | sort -u 20140312 14:47:18< aquileia> sorry, I meant a similar grep I did offering 4 additional entries 20140312 14:48:02< aquileia> no tr ? 20140312 14:48:15< Soliton> useless with grep -o. 20140312 14:48:50< Aishiko_laptop> sachith500, a little my Computer Engineering degree capstone group project was to use 2 arduinos to build a working intersection, I built the code that programmed the 2 boards to talk to each other and control the lights and detect "traffic" why? 20140312 14:49:12< Ivanovic> happygrue: depends on the project i would say 20140312 14:49:14< Soliton> i'd decide whether to use -ho or --no-filename --only-matching, btw. and not mix things. 20140312 14:49:25< Ivanovic> if you are the main driver / customer of the project it would make sense if you take the mentoring role 20140312 14:49:27< Aishiko_laptop> got a string issue? use a regex... then you have 2 issues to troubleshoot =P 20140312 14:49:30< aquileia> ok, changed it 20140312 14:49:44< sachith500> oh cool we have arduino practicals these days 20140312 14:50:01< sachith500> we had something along those lines yesterday 20140312 14:50:16< sachith500> basically get the time in master arduino and send it to slave 20140312 14:50:32< sachith500> we were supposed to do it using ints I think :P 20140312 14:50:43< sachith500> found it to be easier using a char buffer 20140312 14:51:09< Aishiko_laptop> ohhh neat 20140312 14:52:05-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Quit: Vannak idők, mikor menni kell] 20140312 14:52:16< sachith500> I'm stealing your questionnaire, because i'm too lazy to locate the original ;D 20140312 14:52:27< sachith500> just hope i don't mistakenly leave anything of yours 20140312 14:52:37-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has quit [Quit: Page closed] 20140312 14:52:37< shadowm> The link to the original is in the SummerOfCodeIdeas page. 20140312 14:53:39< shadowm> Wait no, it's in the proposal template. 20140312 14:53:53< shadowm> Anyway: http://wiki.wesnoth.org/SoC_Information_for_Google#Does_your_organization_have_an_application_template_you_would_like_to_see_students_use.3F 20140312 14:58:29-!- sachith500|2 [~kvirc@112.135.231.162] has joined #wesnoth-dev 20140312 15:01:26-!- sachith500 [~kvirc@112.135.174.212] has quit [Ping timeout: 252 seconds] 20140312 15:05:44< shadowm> "Macro argument does not expect any argument" -- huh? 20140312 15:07:02< shadowm> Oh right, because... I mean... duh. 20140312 15:08:03-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has joined #wesnoth-dev 20140312 15:09:28< aquileia> std::min(base+increment, std::max(base, max_sum)) 20140312 15:10:00< aquileia> Visual Studio says it knows of neither std::min nor std::max ... 20140312 15:10:56< aquileia> Is there a quick fix? I have to go for about an hour and I'd like to use that time on my Laptop to compile 20140312 15:11:21< aquileia> And if you didn't guess already: First time compiling Wesnoth 20140312 15:11:39< aquileia> molgrum: 20140312 15:11:43< aquileia> ah... sorry 20140312 15:11:54-!- irker970 [~irker@ai0867.net] has joined #wesnoth-dev 20140312 15:11:54< irker970> wesnoth: Ignacio R. Morelle wesnoth:master 9fc587d56d20 / src/serialization/preprocessor.cpp: preprocessor: Capitalize first word of two error messages http://git.io/CGs_EQ 20140312 15:11:55< irker970> wesnoth: Ignacio R. Morelle wesnoth:master 21a1937a5f1f / src/serialization/preprocessor.cpp: preprocessor: 'any argument' -> 'any arguments' http://git.io/xtnZTQ 20140312 15:11:56< happygrue> Ivanovic: I see. I'll create an account and take a look at the information/requirements from Google regarding menoring and consider that then. Busy now for a bit. 20140312 15:12:23< Ivanovic> sure 20140312 15:13:38< happygrue> I imagine Soliton and I both helping regardless of who is "lead" and it doesn't matter to me - maybe to him? 20140312 15:13:48< irker970> wesnoth: Ignacio R. Morelle wesnoth:1.12 6b745a51ba94 / src/serialization/preprocessor.cpp: preprocessor: Capitalize first word of two error messages http://git.io/CLmnRw 20140312 15:13:51< happygrue> and I will be less available part of the summer, but that shouldn't be a big problem. 20140312 15:13:51< irker970> wesnoth: Ignacio R. Morelle wesnoth:1.12 65cca621c933 / src/serialization/preprocessor.cpp: preprocessor: 'any argument' -> 'any arguments' https://github.com/wesnoth/wesnoth/commit/65cca621c9337377d3ee90a212b2f9fc7b854626 20140312 15:13:59< Ivanovic> if you want to get a free google branded hoodie: sign up 20140312 15:14:00< Ivanovic> ;) 20140312 15:14:10< Ivanovic> and not being around for 3 weeks is no blocker 20140312 15:15:03< happygrue> free stuff? Well that changes the calculus for sure! ;) 20140312 15:15:20< Ivanovic> :) 20140312 15:18:13-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20140312 15:23:08< aquileia> I'll try including algorithm in utils.cpp and see what happens... 20140312 15:23:14< aquileia> afk 20140312 15:23:25-!- _flatline_ [~flatline@2607:f470:22:8:beae:c5ff:fe5a:903f] has joined #wesnoth-dev 20140312 15:25:10< Soliton> happygrue: i don't mind either way. though if i could blame everything on you if things go wrong that wouldn't be bad... 20140312 15:27:03< Ivanovic> happygrue, Soliton: if you were both in both would get a hoodie and you could each blame the other 20140312 15:27:13< Ivanovic> ;) 20140312 15:27:55< Soliton> the perfect plan. \o/ 20140312 15:29:16< AI0867> I'll blame all of you then 20140312 15:29:27< AI0867> especially Ivanovic, for coming up with the plan 20140312 15:29:46< Ivanovic> AI0867: whatever happens you blame me anyway 20140312 15:29:50< Ivanovic> so there is no change... 20140312 15:29:51< Ivanovic> ;) 20140312 15:30:04< shadowm> Yay, I'm hitting Wesnoth's sound code limits again. I hate it when this happens. 20140312 15:30:05< AI0867> when's the next release? 20140312 15:30:07< Ivanovic> damn, i hate my head and throat right now 20140312 15:30:21< Ivanovic> AI0867: might be this weekend 20140312 15:30:45-!- vorobeez [~quassel@85.142.148.12] has joined #wesnoth-dev 20140312 15:31:05-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20140312 15:32:07< AI0867> hmm, it's asking me for a t-shirt size. Are you sure it's a hoodie? 20140312 15:32:26< Ivanovic> it will be a hoodie this year 20140312 15:32:36< Ivanovic> that is the special for 10 years 20140312 15:35:40< sachith500|2> hahah 20140312 15:36:09< happygrue> If allocating blame is part of the mentoring job then I'm SURE I can do it well. I'm in! :D 20140312 15:36:35< sachith500|2> as long as you don't start blaming the poor students :P 20140312 15:36:46< happygrue> we would never do that 20140312 15:36:48< Ivanovic> sachith500|2: that is where the blame ends anyway 20140312 15:36:50< Ivanovic> ;) 20140312 15:36:55< happygrue> ...before you've applied and can't leave... 20140312 15:36:57< happygrue> :P 20140312 15:37:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140312 15:37:29< sachith500|2> :P 20140312 15:37:32< sachith500|2> hahaha 20140312 15:38:04< sachith500|2> wow that questionnaire was long 20140312 15:50:42< AI0867> Ivanovic: poke on IRC 20140312 15:51:31< sachith500|2> hey AI0867, glad you liked my commit message :P 20140312 15:51:43< sachith500|2> way back last month 20140312 15:52:16 * AI0867 looks 20140312 15:52:49< sachith500|2> ;D 20140312 15:52:54< sachith500|2> if you forgot nvm 20140312 15:52:58< sachith500|2> that's probably better 20140312 15:52:59< sachith500|2> :P 20140312 15:54:47< Ivanovic> sachith500|2: we wanted to show that we can be very beaurocratic, too 20140312 15:55:05< Ivanovic> sachith500|2: in fact most of this questionaire is not directly the stuff on which we "grade" the proposals 20140312 15:55:23< Ivanovic> but it helps us to better understand you and do a reality check with the proposal 20140312 15:57:17< happygrue> Our bureaucracy is expanding to meet the needs of our expanding bureaucracy! 20140312 15:57:42 * happygrue leaves before someone can blame him for this. 20140312 15:58:06< sachith500|2> hahaaha 20140312 15:58:33< sachith500|2> the IRC is way more fun when most of you guys are on 20140312 15:58:57 * Ivanovic is only on because of being sick... 20140312 15:59:03< Ivanovic> otherwise i would be sitting at work right now 20140312 15:59:13< sachith500|2> oh right 20140312 15:59:18< sachith500|2> hope you get better soon :) 20140312 15:59:23< Ivanovic> so do I 20140312 15:59:36< Ivanovic> but it is already getting better... 20140312 15:59:37< sachith500|2> shouldn't you be resting, tho? 20140312 15:59:40< sachith500|2> :P 20140312 15:59:43< sachith500|2> ah cool 20140312 15:59:49< Ivanovic> i am mainly supposed to rest my voice 20140312 16:00:03< Ivanovic> is it very counter productive that i was just in a conference call? 20140312 16:00:16< sachith500|2> haha 20140312 16:00:17< AI0867> yes 20140312 16:00:32< AI0867> Ivanovic: that poke was about melange and the connection thing 20140312 16:00:45< Ivanovic> AI0867: okay 20140312 16:00:56< Ivanovic> what is your accountname? 20140312 16:01:01< sachith500|2> when I first saw AI0867 on IRC I thought he was a bot :P 20140312 16:01:09< AI0867> I am ;) 20140312 16:01:15< sachith500|2> ;D 20140312 16:01:17< Ivanovic> ah, there you are 20140312 16:01:24< Ivanovic> you are in as mentor 20140312 16:01:32< AI0867> =) 20140312 16:01:34< Ivanovic> should now see wesnoth somewhere in your dashboard 20140312 16:03:27-!- yefllowers [3b4e3991@gateway/web/freenode/ip.59.78.57.145] has joined #wesnoth-dev 20140312 16:08:39< Ivanovic> okay, AI0867, mordante, trademark and thunderstruck are now in there as mentor 20140312 16:08:46< Ivanovic> noy is there as admin besides me 20140312 16:08:49< Ivanovic> so the list is growing 20140312 16:09:18< noy> Ivanovic: I'm going to be a bit AFK for the next few weeks… I'm moving to the farm 20140312 16:09:29< noy> I'll be on during the days, but not the evenings 20140312 16:09:41< Ivanovic> ah, cool 20140312 16:09:49< Ivanovic> are you building a house there? 20140312 16:10:03< Ivanovic> IIRC there was not a usable house when we were there last autumn, right? 20140312 16:11:53-!- yefllowers [3b4e3991@gateway/web/freenode/ip.59.78.57.145] has quit [Ping timeout: 245 seconds] 20140312 16:14:58-!- yefllower [3b4e3991@gateway/web/freenode/ip.59.78.57.145] has joined #wesnoth-dev 20140312 16:30:03< aquileia> while I have lots of issues with my new widget, the warnings about std::[min,max] are gone when including in utils.cpp 20140312 16:30:05< noy> no, there was a second house there that was being rented out Ivanovic 20140312 16:30:16< Ivanovic> noy: ah, okay 20140312 16:30:22< noy> its only a decade old and much nicer 20140312 16:30:49< Ivanovic> and then you will be living far outside of towns 20140312 16:30:50< aquileia> is it only me or should it be officially included there? 20140312 16:30:54< Ivanovic> with "not much" in walking distance 20140312 16:31:59< Ivanovic> but i think that is a very european concept, having things like stores, restraurants and pubs in walking distance 20140312 16:34:26-!- blarumyrran [~Bbbb123@wesnoth/artist/blarumyrran] has quit [Quit: Leaving] 20140312 16:35:21-!- Octalot [~noct@31.185.149.167] has quit [] 20140312 16:42:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140312 16:43:29-!- sachith500|2 [~kvirc@112.135.231.162] has quit [Read error: Connection reset by peer] 20140312 16:49:13< aquileia> ah... most of the errors in my widget were caused because I set a default parameter in the declaration instead of the definition! Only 24 left... all because I access my own private variables / functions... I don't get it... 20140312 16:55:01< noy> Ivanovic: you saw the apartment area I used to live in… I was very much in that lifestyle. and I lived in London and other cities like that. 20140312 16:55:13< noy> I got a truck for that. 20140312 16:55:19< noy> for living in the area 20140312 16:55:36< noy> its a 5 minute drive from the farm 20140312 16:56:44< Ivanovic> noy: the appartement felt like there are some houses around 20140312 16:56:57< Ivanovic> and in europe with such a collection of houses come restaurants and shops 20140312 16:56:58< Ivanovic> ;) 20140312 16:58:10< Soliton> aquileia: are you using min() and max() in your new widget? then you should include there and not some other file. 20140312 16:58:41< aquileia> Soliton: No, they are used in utils.cpp without this include 20140312 16:58:56< Soliton> then add the include there, yes. 20140312 16:59:03< aquileia> Thanks 20140312 16:59:17< Soliton> preferably in a seperate patch. ;-) 20140312 16:59:32< aquileia> But... why didn't anybody notice? Are other IDEs smarter? 20140312 16:59:43< Soliton> well, why does it even compile now? 20140312 17:00:01< aquileia> I'll reorganize my commits anyhow, so that's no problem 20140312 17:00:30< Soliton> on other platforms presumably some other header includes algorithm but if that is not the case on windows... 20140312 17:01:36< Soliton> oh somehow they're just warnings? i guess no one bothered to fix them so far then. 20140312 17:01:53< aquileia> And I think I'll update the compile on Windows page... the files seem to work on VC12, no need to use an old version like specified 20140312 17:02:16< aquileia> No, they were listed as errors 20140312 17:03:20< Soliton> well, then no idea how it compiled before. 20140312 17:03:30< aquileia> ok 20140312 17:03:55< aquileia> May I ask a stupid question? 20140312 17:04:00< Soliton> i mean you should know... since you compiled it before? 20140312 17:04:13< aquileia> I didn't, that's my first time 20140312 17:04:25< Soliton> ah, i see. 20140312 17:06:32 * Soliton is off. 20140312 17:09:20< Ivanovic> aquileia: the number of stupid questions is extremely limited 20140312 17:09:37< Ivanovic> aquileia: i guess you will have a real problem finding a *stupid* question... 20140312 17:09:38< Ivanovic> ;) 20140312 17:11:19< aquileia> Ivanovic: I have a function (curretly in my cpp-file) accessing lots of private variables, but also a hefty boost function. 20140312 17:12:07< aquileia> What should I do? Write several inline access functions for the variables? Move it to the hpp? 20140312 17:12:17< aquileia> *currently 20140312 17:16:04-!- _flatline_ [~flatline@2607:f470:22:8:beae:c5ff:fe5a:903f] has quit [Quit: Leaving] 20140312 17:16:24< Ivanovic> someone asked some days ago about the shipping address for students 20140312 17:16:33< Ivanovic> [18:15:11] carols: Is it possible to change my shipping address later on? 20140312 17:16:35< Ivanovic> [18:15:16] ankush92_: sure 20140312 17:16:36< Ivanovic> [18:15:25] whenever you like and as many times as you like 20140312 17:16:38< Ivanovic> [18:15:38] well, until the program's over. you can't change it after that. 20140312 17:16:43< Ivanovic> that is what carols from google just said in #gsoc 20140312 17:26:39-!- Gallaecio [~quassel@84.120.219.74.dyn.user.ono.com] has joined #wesnoth-dev 20140312 17:28:33-!- bagzie [~bag@85-76-46-48-nat.elisa-mobile.fi] has joined #wesnoth-dev 20140312 17:32:11-!- neXyon [~neXyon@85-127-52-188.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20140312 17:32:36-!- neXyon [~neXyon@85-127-52-188.dynamic.xdsl-line.inode.at] has quit [Client Quit] 20140312 17:34:50-!- losted_ [5daf0269@gateway/web/freenode/ip.93.175.2.105] has joined #wesnoth-dev 20140312 17:37:04-!- Gallaecio [~quassel@84.120.219.74.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 20140312 17:37:34-!- Gallaecio [~quassel@84.120.219.74.dyn.user.ono.com] has joined #wesnoth-dev 20140312 18:03:12-!- Bodhi-Baum [~Bodhi@dslb-084-063-047-012.pools.arcor-ip.net] has joined #wesnoth-dev 20140312 18:03:28-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev 20140312 18:04:01-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has joined #wesnoth-dev 20140312 18:07:55-!- neXyon [~neXyon@85-127-52-188.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20140312 18:19:52-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has quit [Quit: linii] 20140312 18:21:49-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev 20140312 18:21:49-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host] 20140312 18:21:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140312 18:22:04-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has joined #wesnoth-dev 20140312 18:28:58-!- yefllower [3b4e3991@gateway/web/freenode/ip.59.78.57.145] has quit [Ping timeout: 245 seconds] 20140312 18:29:57-!- gfgtdf [~chatzilla@f054134035.adsl.alicedsl.de] has joined #wesnoth-dev 20140312 18:34:59< Aishiko_laptop> aquileia, I hate it when I do things like that...... at least you didn't do a pull request on something that was broken because a line of code got forgotten and it was doing runtime errors (read-only but still) 20140312 18:36:07< aquileia> Aishiko_laptop, well... that's because I can't even compile Wesnoth right now :p 20140312 18:36:21< aquileia> I'm so close, but... 20140312 18:38:04< aquileia> In fact I could need a little help (visibility of inherited variables) if you could spare the time 20140312 18:38:26-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving] 20140312 18:42:12< Aishiko_laptop> aquileia, I can try if nothing else! 20140312 18:42:41-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.] 20140312 18:43:00< Aishiko_laptop> right now I'm getting logic errors so compiles but not doing what I it should so I have a few couts floating around so I can follow what's happening 20140312 18:43:01< aquileia> ttext_ <-- ttext_box <-- num_box 20140312 18:43:17< irker970> wesnoth: fendrin wesnoth:master 25483d40244d / data/campaigns/Legend_of_Wesmere/ (images/units/monsters/great-ogre.png units/Great_Ogre.cfg): Great Ogre unit for use in LoW. http://git.io/oi_7HA 20140312 18:43:19< irker970> wesnoth: fendrin wesnoth:master 8e12b18891d6 / data/core/editor/help.cfg: First topic of an editor help section. http://git.io/gVwsCw 20140312 18:43:36< aquileia> Aishiko_laptop: that sounds unpleasant... 20140312 18:43:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140312 18:44:12< Aishiko_laptop> even more when I thought I was done and I find that when others compile its not grabbing from the scenario files =( 20140312 18:45:06< aquileia> Do I understand correctly that I can access protected functions of ttext_ and ttext_box and overwrite private ones? 20140312 18:45:57< Aishiko_laptop> aquileia, only if you have a set or get defined in the class 20140312 18:46:47< aquileia> oh, I have to say that I'm in num_box 20140312 18:47:17-!- daelious [~daelious@74.202.60.2] has joined #wesnoth-dev 20140312 19:01:01< Aishiko_laptop> or be accessing those public funtions of ttext_ and ttext_box 20140312 19:09:16-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:10:19-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:12:14-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:12:37-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:13:53-!- vorobeez [~quassel@85.142.148.12] has quit [Ping timeout: 252 seconds] 20140312 19:14:05< aquileia> Aishiko_laptop: Ok, then I'll have to move some functions in those files... I definitely won't reimplement them for fun. Thanks! 20140312 19:16:02-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:16:04< Aishiko_laptop> aquileia, why can't you just access them from where they are? 20140312 19:16:25-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:16:27-!- neXyon_ [~neXyon@85-127-233-44.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20140312 19:16:46< aquileia> In two cases, I have to overload a function in which I want to use the old implementation 20140312 19:17:36< aquileia> In the other two, I'd like to use a private function that does only half of the public one 20140312 19:18:59-!- neXyon [~neXyon@85-127-52-188.dynamic.xdsl-line.inode.at] has quit [Ping timeout: 240 seconds] 20140312 19:20:18-!- daelious [~daelious@74.202.60.2] has quit [Remote host closed the connection] 20140312 19:20:37-!- Kexoth [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:20:43-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:20:53< Aishiko_laptop> then it makes sense to replicate 20140312 19:21:08< Aishiko_laptop> as for me I think I am figuring out what is going on with my patch 20140312 19:21:20-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:21:36-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:24:53-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:24:55-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:26:27< iceiceice> aquileia: i cant really advise as I don't know the context but maybe you want to use polymorphism somehow? 20140312 19:27:11-!- wesbot changed the topic of #wesnoth-dev to: 1.12 branch created | string+feature freeze active on 1.12 | 223 bugs, 352 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140312 19:27:29< iceiceice> e.g. mark the methods virtual and cast your class down to the parent type when you want the old version? 20140312 19:28:21< aquileia> iceiceice: The problem is that in ttext_, I can't make them virtual... no idea why (something about not being in a class) 20140312 19:28:31-!- Kexoth [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:29:01< aquileia> I really don't understand how to solve this 20140312 19:29:10< iceiceice> is ttext_ a struct or something? 20140312 19:29:23-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:29:23< aquileia> yes, I think so 20140312 19:29:38< aquileia> but classes derive from it... 20140312 19:29:41< iceiceice> you could probably just make it a class if that is causing problems, there is very little difference i guess 20140312 19:30:15< iceiceice> iirc a struct is just a class in which everything is public by default 20140312 19:30:35< aquileia> Hmm... that seems a really intrusive change, but I'll try 20140312 19:30:37< aquileia> thanks 20140312 19:30:43< iceiceice> i guess i didnt realize structs couldn't have virtual elements? 20140312 19:30:49< iceiceice> i want to confirm that... 20140312 19:31:51< aquileia> even weirder... class ttext_ : public tcontrol 20140312 19:32:44< aquileia> the header handles it as a class, the cpp as a struct... 20140312 19:32:57< iceiceice> ok forget the thing i side about struct, i was leading you astray 20140312 19:33:25-!- Bodhi-Baum [~Bodhi@dslb-084-063-047-012.pools.arcor-ip.net] has quit [Quit: Verlassend] 20140312 19:33:48-!- Bodhi-Baum [~Bodhi@dslb-084-063-047-012.pools.arcor-ip.net] has joined #wesnoth-dev 20140312 19:33:51< aquileia> I think for now I will resign and copy-paste the code... 20140312 19:33:58-!- Bodhi-Baum [~Bodhi@dslb-084-063-047-012.pools.arcor-ip.net] has quit [Remote host closed the connection] 20140312 19:34:08-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:34:37-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:34:46< aquileia> I can improve that later on, for now I just want to get Wesnoth compiled for the first time 20140312 19:35:48-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev 20140312 19:35:49-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140312 19:36:17-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 19:38:26< Aishiko_laptop> compling good! 20140312 19:42:25< aquileia> Aishiko_laptop: Gratulations 20140312 19:42:44< aquileia> I'm 2 errors away from that 20140312 19:43:18< Aishiko_laptop> no no I meant for you or in general really 20140312 19:43:30-!- uicus [~chatzilla@088156086225.wroclaw.vectranet.pl] has joined #wesnoth-dev 20140312 19:47:44< Aishiko_laptop> aquileia, one of the first things I did was compile wesnoth so I could see the current state of things 20140312 19:49:06< Aishiko_laptop> OK first I went after an easy coding fix only to find it had been implemented and no one updated the silly page....../ 20140312 19:55:45< shadowm> Does anyone know if there's a way to trick Wesnoth into applying ~RC() and ~PAL() after the rest? 20140312 19:59:55-!- linii [~SEXY@c-71-207-117-65.hsd1.pa.comcast.net] has quit [Ping timeout: 264 seconds] 20140312 20:02:20-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20140312 20:02:34-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: Vannak idők, mikor menni kell] 20140312 20:02:39-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev 20140312 20:07:22-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving] 20140312 20:08:58-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Crab_] 20140312 20:10:41< zookeeper> shadowm, if you can't do it with BLIT, then i don't think so 20140312 20:14:33-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 264 seconds] 20140312 20:15:07-!- uicus [~chatzilla@088156086225.wroclaw.vectranet.pl] has left #wesnoth-dev [] 20140312 20:20:20-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140312 20:31:43-!- iSwapnil [~swapnil@122.163.236.211] has quit [Ping timeout: 264 seconds] 20140312 20:36:34< aquileia> I tried what I could think of... but the error remains: http://pastebin.com/KN165idU 20140312 20:38:37< aquileia> Either my system is haunted or I'm missing something 20140312 20:38:55-!- spoffy [~spoffy@152.78.175.8] has quit [Remote host closed the connection] 20140312 20:39:56-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev 20140312 20:41:12< Aishiko_laptop> aquileia, I know what you mean, wondering if your ever going hit on what's eluding you 20140312 20:41:34< aquileia> Yes, exactly that... 20140312 20:41:52< aquileia> I cannot imagine what the problem may be 20140312 20:42:55-!- uicus [~chatzilla@088156086225.wroclaw.vectranet.pl] has joined #wesnoth-dev 20140312 20:43:10-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140312 20:44:11< Aishiko_laptop> aquileia, I see the problem! C:\users ....... you should be using linux! 20140312 20:45:03< Aishiko_laptop> but really the only issue is that gui2 doesn't know what your doing, add a little something to GUI2 so it goes, "Ohhh I know what you are!" 20140312 20:45:30< Aishiko_laptop> or it might be that your missing the header to talk to gui2? 20140312 20:45:32< aquileia> But at the same time it is listed as a child... 20140312 20:46:06< Aishiko_laptop> but thats not shown in the paste you just gave? 20140312 20:46:20< aquileia> I'll double-check the headers again - let's hope I just overlooked sth. 20140312 20:46:34< aquileia> I can paste all 4 files if you want 20140312 20:47:09< Aishiko_laptop> aquileia, I'll look if you do and tell you what pops out at me, can't promise I'll find the issue but I can try 20140312 20:51:24< aquileia> http://pastebin.com/iTTqbCLh http://pastebin.com/GU3Hawf4 http://pastebin.com/9QEu8qE8 http://pastebin.com/e4C0FDkV 20140312 20:51:41-!- uicus [~chatzilla@088156086225.wroclaw.vectranet.pl] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 27.0.1/20140212131424]] 20140312 20:56:12< gfgtdf> GUI_AUXILIARY_WINDOW_BUILDER_PASSWORD_BOX_HPP_INCLUDED ?? 20140312 20:56:56< aquileia> Ohhhh.... 20140312 20:57:46< Aishiko_laptop> I saw that too but wasn't sure what to make of it 20140312 20:58:20< aquileia> I was sure I renamed it when copying from the password_box... 20140312 20:59:06< aquileia> I think it continues to compile... hooray! 20140312 20:59:19< aquileia> gfgtdf: THANKS 20140312 20:59:43< Aishiko_laptop> aquileia, see even if I don't get the answer right away someone else might 20140312 20:59:48< aquileia> Aishiko_laptop: Thanks as well 20140312 21:01:00< aquileia> One wasted hour searching... I'm soo relieved 20140312 21:02:33-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving] 20140312 21:04:07< aquileia> It will take its time, but I think I soon will have my code compiled for the first time. Thanks again. 20140312 21:06:43-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140312 21:11:13< Aishiko_laptop> your welcome, I finally got individual units to be able to set a unique recall cost but not yet for types and yet I had that working before! 20140312 21:21:32< aquileia> Aishiko_laptop: Nice! 20140312 21:22:15< aquileia> Aishiko_laptop, gfgtdf : It worked, the code is clean... only a linker error remains 20140312 21:22:16< aquileia> LINK : fatal error LNK1104: cannot open file 'Debug\liblua.lib' 20140312 21:22:30< aquileia> So I'll have to look into that 20140312 21:23:04< aquileia> But I'm confident now that my code compiled 20140312 21:23:36< gfgtdf> you used the vs2008 projectfiles or cmake? 20140312 21:26:31< aquileia> Visual Studio 20140312 21:26:57< aquileia> I think I know what I did wrongly 20140312 21:28:02< aquileia> I'm pretty sure I compiled the Wesnoth project alone, without liblua. So I'll compile that and retry 20140312 21:33:39< aquileia> gfgtdf: By the way, which system do you use? 20140312 21:34:31-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer] 20140312 21:35:01< gfgtdf> visual studio 2010 20140312 21:35:18-!- Nostromus [~Thunderbi@f054013089.adsl.alicedsl.de] has joined #wesnoth-dev 20140312 21:35:53-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140312 21:35:54< gfgtdf> but i accidently deleted my local wesnoth repo some days ago so i have to clone it again. 20140312 21:37:06-!- eldruz [~eldruz@lav35-1-82-236-137-179.fbx.proxad.net] has joined #wesnoth-dev 20140312 21:37:17< aquileia> I downloaded the 2013 version yesterday night and had severe problems because the Path variables were wrong, but by downloading SDK 8.1 I could repair it 20140312 21:37:21< Aishiko_laptop> I'm looking for someone that knows about scenario writing 20140312 21:37:42< aquileia> gfgtdf: That's unfortunate 20140312 21:39:34< gfgtdf> aishiko: about wml or about english language or storyline? 20140312 21:39:42-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginmedia.com] has joined #wesnoth-dev 20140312 21:42:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20140312 21:43:22-!- irker970 [~irker@ai0867.net] has quit [Quit: transmission timeout] 20140312 21:43:38-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds] 20140312 21:45:17-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev 20140312 21:46:03-!- trewe [~trewe@185.141.54.77.rev.vodafone.pt] has joined #wesnoth-dev 20140312 21:46:56< Aishiko_laptop> gfgtdf, about adding custom units but I realized that I had some examples already 20140312 21:47:26< Aishiko_laptop> sorry about that =) 20140312 21:48:22-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140312 21:48:58-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 21:50:20-!- exciton_ [chuck-the-@95.73.34.102] has joined #wesnoth-dev 20140312 21:50:50< Aishiko_laptop> I had it getting a tag out of the unit config files just fine and I changed something and then got it getting it out of the scenarios but, inbetween the ones in the unit configs got ignored.... 20140312 21:51:15< spoffy> Recommend reading http://wiki.wesnoth.org/SoC_Information_for_Google for anyone planning on Summer of Code. It's quite interesting. 20140312 21:51:38-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds] 20140312 21:52:09-!- exciton_ [chuck-the-@95.73.34.102] has quit [Read error: Connection reset by peer] 20140312 21:53:55-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds] 20140312 21:55:20-!- exciton [chuck-the-@95.73.34.102] has joined #wesnoth-dev 20140312 21:56:03-!- exciton [chuck-the-@95.73.34.102] has quit [Read error: Connection reset by peer] 20140312 21:56:25-!- sjnsingh [8164d281@gateway/web/freenode/ip.129.100.210.129] has joined #wesnoth-dev 20140312 22:00:20-!- exciton [chuck-the-@95.73.34.102] has joined #wesnoth-dev 20140312 22:02:02-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!] 20140312 22:04:48-!- sjnsingh [8164d281@gateway/web/freenode/ip.129.100.210.129] has quit [Ping timeout: 245 seconds] 20140312 22:07:37-!- exciton [chuck-the-@95.73.34.102] has quit [Read error: Connection reset by peer] 20140312 22:07:51-!- exciton [chuck-the-@95.73.34.102] has joined #wesnoth-dev 20140312 22:13:29-!- gfgtdf_ [~chatzilla@e176184178.adsl.alicedsl.de] has joined #wesnoth-dev 20140312 22:15:13-!- gfgtdf [~chatzilla@f054134035.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds] 20140312 22:15:23-!- gfgtdf_ is now known as gfgtdf 20140312 22:17:43< Aishiko_laptop> thank you spoffy 20140312 22:17:48-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginmedia.com] has quit [Remote host closed the connection] 20140312 22:26:30< Aishiko_laptop> Okay I think I've figured out what is going on, when it first gets the units it grabs from the unit_type config, then when it reads in the scenario its overwriting that value and if that value doesn't exist its getting a default value (in this case zero or -1) 20140312 22:27:38< Aishiko_laptop> so I think I need to do an evaluation/test on that before it gets assigned to the unit 20140312 22:27:54-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 245 seconds] 20140312 22:30:00-!- neXyon_ is now known as neXyon 20140312 22:34:35-!- exciton [chuck-the-@95.73.34.102] has quit [Read error: Connection reset by peer] 20140312 22:34:49-!- exciton [chuck-the-@95.73.34.102] has joined #wesnoth-dev 20140312 22:36:12-!- mjs-de [~mjs-de@f048226174.adsl.alicedsl.de] has quit [Remote host closed the connection] 20140312 22:36:33< Aishiko_laptop> I'm open to suggestions if that couldn't possibly be the cause 20140312 22:40:36< spoffy> No problem Aishiko_laptop :) 20140312 22:44:34< spoffy> Oh, can anyone give me Summer of Code group on the forums please? My username there is the same as my IRC. 20140312 22:49:45-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140312 22:50:25-!- exciton [chuck-the-@95.73.34.102] has quit [Read error: Connection reset by peer] 20140312 22:50:39-!- exciton [chuck-the-@95.73.34.102] has joined #wesnoth-dev 20140312 22:54:38< aquileia> gfgtdf: Just so that you know, I'm now at error LNK1104: cannot open file 'libboost_zlib-vc120-mt-gd-1_55.lib' 20140312 22:55:25< gfgtdf> i assube you build boost yourself ? 20140312 22:55:28< gfgtdf> asume* 20140312 22:55:31< gfgtdf> assume* 20140312 22:55:33< aquileia> yes 20140312 22:55:55< gfgtdf> but you didnt add zlib to it ? 20140312 22:55:56< spoffy> The summer of code questionnaire is quite fun to fill in. Also, have you checked linker paths aquileia (Apologies if you already have, dropping in on this mid-way) :P 20140312 22:56:20< aquileia> how would I do that? 20140312 22:56:35< aquileia> Command line parameter? 20140312 22:57:20< Aishiko_laptop> spoffy, it is? I'd rather it had less on me and more on the skills I think I can bring to the table 20140312 22:57:27< gfgtdf> i dont remember. It was quiet some time ago i did this and i had some problem with it too. 20140312 22:57:40< gfgtdf> you also need to add bzip2 to your bood lib 20140312 22:57:47< gfgtdf> boost 20140312 23:00:36-!- eldruz [~eldruz@lav35-1-82-236-137-179.fbx.proxad.net] has quit [Quit: leaving] 20140312 23:00:58< aquileia> ah, I found it I think 20140312 23:04:59-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds] 20140312 23:05:13-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has quit [Ping timeout: 245 seconds] 20140312 23:07:23< spoffy> Aishiko_laptop I quite like it. An opportunity to rant ;) But I suppose Open Source is as much about attitude as skills. I think skills is better demonstrated by actual code, as well as your project design. 20140312 23:08:11< Aishiko_laptop> I spend most of my time avoiding attention 20140312 23:13:28< spoffy> I suppose that's personal preference :) I'm sure you can get away with putting only a little in and focusing on the actual design :) 20140312 23:15:41-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 246 seconds] 20140312 23:16:14< Aishiko_laptop> spoffy, like adding the name I'm not sure where to put it in the credits without a "real" name 20140312 23:17:26< Aishiko_laptop> my personal feeling would be to put at the end of the list 20140312 23:22:08< spoffy> Hrrrm. I agree. Credits are tricky though :P 20140312 23:24:46< timotei_> To all GSoC students out there: I've fixed most of your wiki pages to include the proper category (Which, by default, is YouIdeas). 20140312 23:26:05< spoffy> timotei_: If we're applying for an existing idea suggestion, what Categories do we need? I've got it marked as SoC 2014 and SoC14 Student Page at the moment. 20140312 23:32:23< Nostromus> aquileia: i had the same issue mit min and max, but only in vs12 codeblocks and eclipse works fine under windows 20140312 23:33:11< Nostromus> i solved it too, with including two days ago 20140312 23:37:22-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20140312 23:37:38-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140312 23:41:13-!- sachith500 [~kvirc@112.135.231.162] has joined #wesnoth-dev 20140312 23:41:32< gfgtdf> what do you think is better for visual studio 2010: using the VC9 projectfiles or generating own projectfiles with cmake ? 20140312 23:41:56-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 246 seconds] 20140312 23:48:18-!- neXyon [~neXyon@85-127-233-44.dynamic.xdsl-line.inode.at] has quit [Quit: bye] 20140312 23:48:39< Nostromus> i only tried vs13, with the right libs vc9 projectfiles should work fine 20140312 23:50:24< Nostromus> cmake makes much more targets 20140312 23:50:54< gfgtdf> are there advantages of havong less targets ? 20140312 23:50:59< gfgtdf> having* 20140312 23:53:35< Nostromus> in my opinion it is personal taste no advantages or disadvantages, there are only 3 targets all other are just cosmetic 20140312 23:53:56< Nostromus> i should mention that i just begin to work on wesnoth, so no guarantee 20140312 23:56:39< gfgtdf> i used the VC9 files so far but now i accidently deleted my local wenoth and i think about using cmake now, because i thought it would make things simpler if the targets were smaller. do the linux devs here use cmake to build wesnoth ? 20140312 23:56:42< Nostromus> i tried both with vs13 but still get linking error, with vc9 and with cmakes generated projectfile, i got problems with libintl 20140312 23:57:34< Nostromus> i do it under linux with cmake, and it works fine, much more easier as under windows 20140312 23:57:46< gfgtdf> what linkerror you get exactly? 20140312 23:58:32< Nostromus> i don't have the error just now but something like __impl__libintl ..... missing ref 20140312 23:59:20< Nostromus> i switched to codeblocks under windows 20140312 23:59:32< Nostromus> with cmake --- Log closed Thu Mar 13 00:00:15 2014