--- Log opened Sat Mar 15 00:00:09 2014
--- Day changed Sat Mar 15 2014
20140315 00:00:09-!- trewe [~trewe@26.84.108.93.rev.vodafone.pt] has joined #wesnoth-dev
20140315 00:02:09-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140315 00:02:28-!- 21WAADK4W [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20140315 00:02:28-!- shikadibot [~shikadi@ai0867.net] has joined #wesnoth-dev
20140315 00:03:28-!- iwaim_______ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20140315 00:03:35-!- shikadibot is now known as Guest62231
20140315 00:05:27-!- bagzie [~bag@85-76-87-76-nat.elisa-mobile.fi] has joined #wesnoth-dev
20140315 00:07:32-!- boucman [~rosen@2a02-8428-034f-f800-92e6-baff-fe93-a07d.rev.sfr.net] has joined #wesnoth-dev
20140315 00:07:32-!- neXyon [~neXyon@85-127-248-168.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140315 00:08:59-!- Rh0nda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20140315 00:10:30-!- {V} [~V@72-69-ftth.on.nl] has quit [Ping timeout: 246 seconds]
20140315 00:10:30-!- matth1askrgr [matthiaskr@gateway/shell/panicbnc/x-jvuynwpcudvxnyer] has quit [Ping timeout: 246 seconds]
20140315 00:10:31-!- boucman1 [~rosen@2a02-8428-034f-f800-92e6-baff-fe93-a07d.rev.sfr.net] has quit [Ping timeout: 246 seconds]
20140315 00:10:32-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Ping timeout: 246 seconds]
20140315 00:10:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20140315 00:10:34-!- iwaim______ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 246 seconds]
20140315 00:10:36-!- bagz1e [~bag@85-76-66-95-nat.elisa-mobile.fi] has quit [Ping timeout: 246 seconds]
20140315 00:10:38-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-klcrabffiaxlvjpk] has joined #wesnoth-dev
20140315 00:10:52-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140315 00:11:00-!- pyromancer2 [~pyromance@pool-173-63-201-238.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20140315 00:12:50-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-klcrabffiaxlvjpk] has quit [Changing host]
20140315 00:12:50-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20140315 00:12:50-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20140315 00:12:50-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-klcrabffiaxlvjpk] has joined #wesnoth-dev
20140315 00:13:13-!- Rh0nda [~rhonda@anguilla.debian.or.at] has quit [Ping timeout: 240 seconds]
20140315 00:13:19-!- trewe [~trewe@26.84.108.93.rev.vodafone.pt] has quit [Quit: quit]
20140315 00:13:52-!- pyromancer3 [~pyromance@pool-173-63-201-238.nwrknj.fios.verizon.net] has quit [Ping timeout: 265 seconds]
20140315 00:13:58-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20140315 00:14:32-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140315 00:15:37-!- boucman [~rosen@2a02-8428-034f-f800-92e6-baff-fe93-a07d.rev.sfr.net] has quit [Ping timeout: 240 seconds]
20140315 00:15:39-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140315 00:16:20-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140315 00:19:50-!- sachith500 [~kvirc@112.134.158.209] has joined #wesnoth-dev
20140315 00:22:07-!- neXyon_ [~neXyon@85-127-248-168.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140315 00:22:15-!- sachith500|2 [~kvirc@112.134.158.209] has joined #wesnoth-dev
20140315 00:24:08-!- sachith500|2 [~kvirc@112.134.158.209] has quit [Read error: Connection reset by peer]
20140315 00:24:13< aquileia> It's great to have merged all relevant changes to get num_box working in two logical commits, just to have Travis request three fixes of formal problems
20140315 00:24:43-!- sachith500|2 [~kvirc@112.134.158.209] has joined #wesnoth-dev
20140315 00:25:15< aquileia> If I only could get clang to run in MSVS... but unfortunately it clashes with the compiler flags the project sets
20140315 00:25:29-!- neXyon_ [~neXyon@85-127-248-168.dynamic.xdsl-line.inode.at] has quit [Client Quit]
20140315 00:25:43-!- sachith500 [~kvirc@112.134.158.209] has quit [Ping timeout: 264 seconds]
20140315 00:25:51-!- sachith500|2 [~kvirc@112.134.158.209] has quit [Read error: Connection reset by peer]
20140315 00:26:01< aquileia> Which means I have to do each fix in a separate commit before Travis finds the next issue
20140315 00:26:16-!- Netsplit *.net <-> *.split quits: neXyon
20140315 00:29:34-!- sachith500|2 [~kvirc@112.134.158.209] has joined #wesnoth-dev
20140315 00:30:04-!- sachith500|2 [~kvirc@112.134.158.209] has quit [Read error: Connection reset by peer]
20140315 00:33:17-!- sachith500 [~kvirc@112.134.158.209] has joined #wesnoth-dev
20140315 00:41:14-!- sachith500|2 [~kvirc@112.134.158.209] has joined #wesnoth-dev
20140315 00:44:57-!- sachith500 [~kvirc@112.134.158.209] has quit [Ping timeout: 372 seconds]
20140315 00:50:33-!- justinzane [~justinzan@24.49.207.112] has joined #wesnoth-dev
20140315 00:53:00-!- Jozrael [~Jozrael@209.133.52.235] has joined #wesnoth-dev
20140315 00:57:50-!- justinzane [~justinzan@24.49.207.112] has quit []
20140315 01:03:55-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140315 01:06:52< gfgtdf> shadowm: can you or whoever does such things please add my gna account gfgtdf2 to wesnoth?
20140315 01:07:34< Coffee_irc> gfgtdf2?
20140315 01:07:41< Coffee_irc> I assume gfgtdf was taken already :P
20140315 01:08:07< gfgtdf> my original account was gfgtdf but for forgot its password 1/2 year ago.
20140315 01:08:38< gfgtdf> this time i wrote it down :)
20140315 01:09:14< Aishiko_laptop> gfgtdf, what no password recover option?
20140315 01:10:08< gfgtdf> Aishiko_laptop:  i forgot my email too, i thought i need my email for password recovers
20140315 01:10:27< Aishiko_laptop> aquileia, you could use a different IDE like codeblocks
20140315 01:10:58< Aishiko_laptop> gfgtdf, ohh and can't recover that password either I take it, or was it, deleted for inactivity?
20140315 01:11:34< gfgtdf> Aishiko_laptop: i think i just inserted a dummy email.
20140315 01:11:35< aquileia> Aishiko_laptop: Of course I could, but clang includes without any problem into MSVS - it's just the compiler flags
20140315 01:12:17< gfgtdf> Aishiko_laptop: I thought like "i can still change my email afterwards"
20140315 01:12:32< aquileia> I'd prefer to get it running
20140315 01:14:24< Aishiko_laptop> I hear that!
20140315 01:14:39< Aishiko_laptop> sorry to hear that gfgtdf 
20140315 01:15:13< gfgtdf> Aishiko_laptop: it's no problem just the name with the 2 isn't that pretty
20140315 01:15:55-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140315 01:19:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 255 seconds]
20140315 01:20:32-!- bagzie [~bag@85-76-87-76-nat.elisa-mobile.fi] has quit []
20140315 01:31:01< Aishiko_laptop> sorry man
20140315 01:36:00-!- pyromancer3 [~pyromance@pool-173-63-201-238.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20140315 01:45:25-!- Netsplit *.net <-> *.split quits: Rhonda, pyromancer2, boucman
20140315 01:51:05-!- lcNaruto [~yaaic@177.159.220.107] has quit [Quit: Yaaic - Yet another Android IRC client - http://www.yaaic.org]
20140315 01:52:22-!- boucman [~rosen@2a02-8428-034f-f800-92e6-baff-fe93-a07d.rev.sfr.net] has joined #wesnoth-dev
20140315 01:52:56-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev
20140315 01:55:26-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140315 01:56:29< shadowm> gfgtdf: Such a waste of a chance to get a proper username.
20140315 01:56:51-!- boucman [~rosen@2a02-8428-034f-f800-92e6-baff-fe93-a07d.rev.sfr.net] has quit [Remote host closed the connection]
20140315 01:57:14< shadowm> Added.
20140315 02:06:16-!- Netsplit over, joins: Rhonda
20140315 02:06:57< Aishiko_laptop> shadowm, would you happen to know if I am added to the gna for wesnoth?
20140315 02:07:56-!- Jozrael2 [~Jozrael@209.133.52.230] has joined #wesnoth-dev
20140315 02:08:05< shadowm> Aishiko_laptop: No, you aren't, because you don't have commit access yet.
20140315 02:09:07< Aishiko_laptop> ahh okay
20140315 02:09:38-!- Jozrael [~Jozrael@209.133.52.235] has quit [Ping timeout: 240 seconds]
20140315 02:12:44-!- Jozrael2 [~Jozrael@209.133.52.230] has quit [Ping timeout: 264 seconds]
20140315 02:13:32-!- Jozrael [Jozrael@76.91.181.112] has joined #wesnoth-dev
20140315 02:20:34< Aishiko_laptop> I should work a bit harder then 
20140315 02:23:17-!- justinzane [~justinzan@tiny.justinzane.com] has joined #wesnoth-dev
20140315 02:29:23< shadowm> Yeah, you need to get two or more non-trivial pull requests accepted and merged into mainline.
20140315 02:30:25< gfgtdf> does anyone know wether there is currently an easy way do determine wether we are in a synced context (https://gna.org/bugs/?21697)? i
20140315 02:31:13< gfgtdf> i'd like to implement one but if there already exists one then i'd just do that
20140315 02:31:21< gfgtdf> s/do/use
20140315 02:46:51< shadowm> Can anyone tell me what is this "timer" the sound code keeps referencing and for which it allocates a single sound channel and that is somehow related to the turn bell?
20140315 02:47:17< shadowm> Does the turn countdown in MP make sounds or something?
20140315 02:48:09< happygrue> shadowm: it does when you're almost out of time
20140315 02:48:17< happygrue> there is a tick tock as your clock winds down
20140315 02:48:26-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has quit [Quit: Page closed]
20140315 02:48:45< shadowm> Ohhhh.
20140315 02:48:53< shadowm> That's the sound file I found the other day.
20140315 02:49:05< happygrue> at least, I think that's how it's supposed to work.  I don't play with timers that much, but IIRC that's what happens.
20140315 02:49:35< happygrue> and with that I'm off to bed to sleep well, knowing I could help.  ;)
20140315 02:49:40< happygrue> o/
20140315 02:49:41< shadowm> Okay, so this is the channel layout atm (this is really a note to self):
20140315 02:50:07< shadowm> 0 - Bell (turn bell)
20140315 02:50:11< shadowm> 1 - Timer
20140315 02:50:53< shadowm> [2..10] - Sound sources (source_channels = 8)
20140315 02:52:01< shadowm> Wait, no, that's [2..10)
20140315 02:52:12< shadowm> [10..16) - Sound effects
20140315 02:52:38< shadowm> Wait, no.
20140315 02:52:40< shadowm> Crap.
20140315 02:53:27< shadowm> [2..10) - Sound sources (source_channels = n_of_channels - 8 = 16 - 8 = 8)
20140315 02:53:39< shadowm> 10 - UI sounds
20140315 02:53:49< shadowm> [11..16) - Sound effects
20140315 02:55:12< shadowm> So: 1/16 for bell, 1/16 for timer alarm, 8/16 = 1/2 for sound sources, 1/16 for UI, 5/16 for SFX.
20140315 02:55:31< shadowm> I find it hilarious that somehow sound sources are more privileged in this regard that regular sound effects.
20140315 02:55:38-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140315 02:55:59< shadowm> Considering they have remained neglected in all other regards for ages.
20140315 02:56:18 * shadowm tries to decide on a new layout.
20140315 02:59:19-!- sachith500 [~kvirc@112.134.7.217] has joined #wesnoth-dev
20140315 03:02:32-!- sachith500|2 [~kvirc@112.134.158.209] has quit [Ping timeout: 264 seconds]
20140315 03:03:02< shadowm> When all channels is busy, we skip sounds. From what I gather with SDL_mixer playing on a busy channel just replaces the sound. Somehow that behavior seems preferable for regular sound effects rather than the check we have.
20140315 03:03:11-!- 21WAADK4W [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Quit: Konversation terminated!]
20140315 03:03:45< shadowm> 20140315 00:03:37 info audio: All channels dedicated to sound group(4) are busy, skipping.
20140315 03:04:07< shadowm> So I could either change the behavior for sound effect channels, or increase the channel limit, or both.
20140315 03:04:48< shadowm> The SDL_Mixer documentation includes a sample call to Mix_AllocateChannels(16) and it seems everyone and their dog has decided to just stick to that without a particular reason.
20140315 03:05:08< shadowm> At least searching for "SDL_mixer channel limit" doesn't give me anything useful.
20140315 03:05:54< shadowm> What I don't know is how a different (higher) number of channels would play with unusual platforms or devices. Here I only have Linux+ALSA to test.
20140315 03:07:53< shadowm> The default allocation is 2 channels.
20140315 03:11:11< EliDupree> 1.13.0-dev. An era uses [get_global_variable], then a player saves the game; in the save is a [replay] tag with a [command]. The player loads the save on the server, a second player joins, and the second player saves the game. The [replay] [command] [global_variable] has different contents in the second save. Is there an expected way this could happen? Or should I report it assuming it is a Wesnoth bug?
20140315 03:14:38< gfgtdf> results that are once in a replay can normaly never be changed, ofc there can be differente results when calling  [get_global_variable] in different times.
20140315 03:15:04< EliDupree> yeah, it's not different times.
20140315 03:15:10< EliDupree> The replay is changed
20140315 03:15:27< gfgtdf> i think it is a bug then.
20140315 03:15:42< EliDupree> Looks like I've got multiple bugs related to saving and loading in multiplayer
20140315 03:15:45< EliDupree> gotta investigate
20140315 03:16:59< gfgtdf> ye mp reloads are currently heavily bugged, see for example: https://gna.org/bugs/?19258
20140315 03:17:56-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 03:17:58< shadowm> http://pastebin.com/pQqQ2td4 - This doesn't seem to cause any problems.
20140315 03:19:06< shadowm> Keeping 8 for sound sources as it is now, and increasing available SFX channels from 5 to 18.
20140315 03:19:48< shadowm> Wait, I mean 9 for sound sources.
20140315 03:20:02< shadowm> Oh right, I put a 3 instead of 2 there.
20140315 03:20:13< shadowm> No, I want a 4. Duh.
20140315 03:20:50< shadowm> 21 SFX channels, 8 source channels.
20140315 03:21:09< shadowm> Er, 7 source channels.
20140315 03:21:49< gfgtdf> gn8
20140315 03:21:52-!- gfgtdf [~chatzilla@f054143201.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 27.0.1/20140212131424]]
20140315 03:22:41< shadowm> const size_t source_channel_last = source_channel_start + source_channels - 1;
20140315 03:22:56-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140315 03:22:59< shadowm> Riiiight, so the source_channels constant should really be called source_channels_plus_one.
20140315 03:36:33< shadowm> Uh.
20140315 03:36:44< shadowm>     const size_t n_reserved_channels = UI_sound_channel + 1; // sources, bell, timer and UI
20140315 03:37:16< shadowm> We are reserving an extra channel that's part of the sound effects block.
20140315 03:37:51-!- dragonofair0 [~dragonofa@2601:7:8800:359:24dc:98a1:ecac:6613] has quit [Quit: dragonofair0]
20140315 03:39:44-!- pyromancer3 [~pyromance@pool-173-63-201-238.nwrknj.fios.verizon.net] has quit [Ping timeout: 264 seconds]
20140315 03:40:32< shadowm> Which doesn't really matter because it turns out there's no point in reserving channels because we never call the playback functions with automatic channel selection.
20140315 03:43:16< shadowm> Ahhh, never mind, I'm just embarassing myself here because I can't do maths, again.
20140315 03:43:30< shadowm> The reserved channel count is good (but still useless).
20140315 03:44:18< shadowm> Unless there's code out there skipping our management interface and invoking SDL_mixer directly... no, there isn't.
20140315 03:45:52-!- irker780 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20140315 03:58:45-!- Ivanovic_ [~ivanovic@x2f4bb74.dyn.telefonica.de] has joined #wesnoth-dev
20140315 04:00:04-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140315 04:00:18-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140315 04:00:22< Jozrael> Out of curiosity, how would a new user joining today learn about planning mode? To my understanding there's nothing about it in the tutorials, no help file, no thread on the forums. I could be blind, I only did a quick Google search. My guess is it was put in a release announcement at one time.
20140315 04:00:36-!- sachith500 [~kvirc@112.134.7.217] has quit [Read error: Connection reset by peer]
20140315 04:00:51-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140315 04:01:12< EliDupree> Jozrael: Simple... at some point they'll accidentally press p
20140315 04:01:13< EliDupree> -_-
20140315 04:01:18-!- Ivanovic_ [~ivanovic@x2f4bb74.dyn.telefonica.de] has quit [Changing host]
20140315 04:01:18-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140315 04:01:38< EliDupree> It's also in the right-click menu.
20140315 04:01:40< vultraz> xD
20140315 04:02:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20140315 04:02:17< iceiceice> yeah i mean actually its pretty self explanatory
20140315 04:02:22< iceiceice> except when it gives buggy behavior
20140315 04:02:52-!- Ivanovic_ is now known as Ivanovic
20140315 04:03:22< shadowm> Jozrael: As I said last night, it's not explained anywhere.
20140315 04:06:26-!- sachith500 [~kvirc@112.134.7.217] has joined #wesnoth-dev
20140315 04:13:24< Jozrael> Ah sorry shadowm, I didn't see your reply ><
20140315 04:35:05< shadowm> Aishiko_laptop: So you'll stick to recall_cost rather than unit_recall_cost I read?
20140315 04:37:10-!- irker409 [~irker@ai0867.net] has joined #wesnoth-dev
20140315 04:37:10< irker409> wesnoth: Ignacio R. Morelle wesnoth:master faaad1991b4e / src/sound.cpp: sound: Include SDL_Mixer channel layout in debug output http://git.io/csFfKQ
20140315 04:37:11< irker409> wesnoth: Ignacio R. Morelle wesnoth:master 0763670a3f50 / changelog src/sound.cpp: sound: Increase the mixer channel allocation from 16 to 32 http://git.io/Mpfg1w
20140315 04:37:12< irker409> wesnoth: Ignacio R. Morelle wesnoth:1.12 674a6bcfa9a6 / src/sound.cpp: sound: Include SDL_Mixer channel layout in debug output http://git.io/WHpWDA
20140315 04:37:14< irker409> wesnoth: Ignacio R. Morelle wesnoth:1.12 de7686d32ef8 / changelog src/sound.cpp: sound: Increase the mixer channel allocation from 16 to 32 http://git.io/sIJh9w
20140315 04:41:00-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Read error: Operation timed out]
20140315 04:42:42-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140315 04:44:39< Aishiko_laptop> shadowm, yes we're going to stick with recall_cost, the only real issue I've been unable to resolv is that you can't set a type's recall_cost to 0, however you can likely use a WML to change any particular unit to 0 if you so desire, like like you could take all loyal units like in that snippet you sent me and change their cost to 0 and it'll work fine, that was the compromise I had to come up with to get recall_cost=0 to w
20140315 04:44:40< Aishiko_laptop> ork at all.
20140315 04:45:10< Aishiko_laptop> the reason being if there is no recall cost set it defaults to 0
20140315 04:45:46< shadowm> Aishiko_laptop: I thought you had made it default to -1?
20140315 04:46:18< Aishiko_laptop> we could get around this if we put recall_cost=-1 into all the config files, but getting everyone that has a custom unit in a scenario to do so would be difficult
20140315 04:46:19< shadowm> If you are obtaining the attribute from a config object, you can use cfg["foobar"].to_int(-1) to that effect.
20140315 04:47:11< Aishiko_laptop> I was having issues, I'll put that back in and check to make sure it still works
20140315 04:47:18< shadowm> (See the declaration of config::attribute_value::to_int().)
20140315 04:48:42-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20140315 04:48:52< Aishiko_laptop> ahh I see why it was not liking the -1 I had recall_cost(-1); not recall_cost(cfg["recall_cost"].to_int(-1));
20140315 04:50:26< shadowm> Just poke me when you have the pull request reading for re-review testing, I assigned it to me the other day.
20140315 04:50:28< Aishiko_laptop> similar statements elsewhere, 
20140315 04:50:55< Aishiko_laptop> shadowm, I'll do that and I was hoping to get zookeeper to take a look at it too
20140315 04:51:23< shadowm> He doesn't do C++, so unless you are going to include an example WML snippet in the test scenario or something... ;)
20140315 04:52:48< Aishiko_laptop> I was, and basically say "here's the WML code snipet I was using to test, can you play around with it and see how breakable/ the set up is?"
20140315 04:53:14< Aishiko_laptop> breakable/abuse-able
20140315 04:58:47< Aishiko_laptop> I basically would like to pass off my patches to someone that will try to break them like a user would that didn't know what sort of input is required
20140315 04:59:43< Aishiko_laptop> obviously less needed for the spritesheets as everything would not get direct user input but I still think a few would find a way to break it =)
20140315 05:06:13-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 05:06:31-!- iwaim_______ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 264 seconds]
20140315 05:10:56-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140315 05:28:09< iceiceice> hmm i found some strange behavior in our scons script
20140315 05:28:27< iceiceice> i upgraded my linux distro last night, and i remember noticing that it replaced my version of gcc
20140315 05:29:04< iceiceice> when i tried to build wesnoth for the first time just now, i failed the check "gcc version >= 3.3 required"
20140315 05:29:13< iceiceice> repeatedly, even with scons --config=force
20140315 05:29:56< iceiceice> even though my machine says "gcc -v"\\"...gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-7ubuntu3) "
20140315 05:30:31< iceiceice> i found however that my scons cxxtool variable is still clang++
20140315 05:30:52< iceiceice> if i did scons cxxtool=gcc, then the check passes and now i can compile...
20140315 05:31:10< iceiceice> i guess im hoping that i can go back to clang after and it will cache the check pass
20140315 05:32:26< Aishiko_laptop> shadowm, its now working with unit_types set to recall_cost=0  so now I just need to clean it up and send it in
20140315 05:32:30-!- Goracore [~Miranda@p5B008368.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140315 05:33:39< shadowm> iceiceice: I'm not sure if it's related, but our scons recipe currently performs some tests exclusively with gcc, regardless of what cxxtool says.
20140315 05:34:05< iceiceice> okay... 
20140315 05:34:14< shadowm> Feel free to bug loonycyborg about it.
20140315 05:34:20< Coffee_irc> seen happygrue
20140315 05:34:24< iceiceice> my theory right now is that when you set clang++ it performs the version check using clang rather than gcc
20140315 05:34:51< iceiceice> but i can't really say for sure
20140315 05:35:00< iceiceice> loonycyborg: ^^
20140315 05:35:21< shadowm> The last tests it performs here using gcc instead of <cxxtool> is the Xlib test, apparently.
20140315 05:36:48< shadowm> After that, the results for the dbus and fribidi tests are cached and the command line required for each isn't included in config.log, and then the Boost.test test runs with <cxxtool>.
20140315 05:38:06< shadowm> iceiceice: Are you  using ccache?
20140315 05:38:33< iceiceice> i was using config=force as suggested to force it not to cache things
20140315 05:38:44< shadowm> No, ccache is an external tool.
20140315 05:38:57< iceiceice> i'm not using it then as far as i'm aware
20140315 05:39:26< iceiceice> The program 'ccache' is currently not installed. You can install it by typing:
20140315 05:39:27< iceiceice> sudo apt-get install ccache
20140315 05:39:27< shadowm> I was asking because I thought that due to the way the compiler test is designed it may yield unusual results with ccache and differing versions of gcc for each pass.
20140315 05:40:18< iceiceice> so this is the code for our c++ check:
20140315 05:40:23< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/scons/cplusplus.py
20140315 05:40:49< iceiceice> i'm not really familiar with scons scripting but,
20140315 05:41:00< iceiceice> its not clear what in this line : https://github.com/wesnoth/wesnoth/blob/master/scons/cplusplus.py#L31
20140315 05:41:15< iceiceice> is telling it to build the test program with gcc as opposed to clang
20140315 05:42:22< iceiceice> otoh i don't know what the clang preprocessor gives as values to "__GNUC__ * 10000 \\
20140315 05:42:23< iceiceice>                            + __GNUC_MINOR__ * 100 \\
20140315 05:42:23< iceiceice>                            + __GNUC_PATCHLEVEL__"
20140315 05:45:43< iceiceice> possibly relevant: http://stackoverflow.com/questions/1617877/how-to-detect-llvm-and-its-version-through-define-directives
20140315 05:46:34< shadowm> 40201
20140315 05:47:19< shadowm> http://pastebin.com/3MC8QVDx
20140315 05:52:50< iceiceice> hmm the plot thickens :)
20140315 05:59:56< iceiceice> hmm i still can't use clang even after letting gcc fully build
20140315 06:01:37< shadowm> Wait, did you use scons config=force or scons --config=force?
20140315 06:02:09< iceiceice> whichever one was suggested, i dont remember now
20140315 06:02:14< iceiceice> i think i tried both and one gave an error
20140315 06:02:21< shadowm> It must be --config=force, config=force simply does nothing.
20140315 06:02:33< iceiceice> shadowm: i find that when i compile your program with clang, i get the following: 
20140315 06:02:59< shadowm> Also, what does build/config.log say?
20140315 06:03:18< iceiceice> http://pastebin.com/nhinEiS8
20140315 06:04:19< iceiceice> so maybe its my problem and not the script...
20140315 06:04:36< shadowm> Sounds like there's a rather serious problem with your libc installation.
20140315 06:05:47< shadowm> Well, no, your clang installation. That file is compiler-provided.
20140315 06:06:46< iceiceice> yeah maybe i will purge clang and reinstall or someting
20140315 06:09:08-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20140315 06:14:33< shadowm> fabi__: You haven't documented the SLF area= attribute yet (I just confirmed it exists and works).
20140315 06:15:11< shadowm> Which is awesome, one file-local macro less to write. \o/
20140315 06:18:13< shadowm> fabi__: I just added it to the SLF page: http://wiki.wesnoth.org/StandardLocationFilter
20140315 06:19:44-!- Fortescue_ [sid1929@gateway/web/irccloud.com/x-qixrjhmwlxcqbeed] has quit [Ping timeout: 245 seconds]
20140315 06:20:53-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has joined #wesnoth-dev
20140315 06:26:57< iceiceice> found a workaround here that fixed it for me, if anyone experiences the same issue: https://bugs.launchpad.net/ubuntu/+source/llvm-defaults/+bug/1198123
20140315 06:41:30-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 265 seconds]
20140315 06:43:39< vultraz> wasn't area= supposed to have to do with an [area] tag, or was that never implemented?
20140315 06:44:53-!- sachith500 [~kvirc@112.134.7.217] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140315 06:54:21-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 06:56:35-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 252 seconds]
20140315 06:58:56-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140315 07:00:04-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140315 07:00:18-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140315 07:08:25-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140315 07:13:35-!- vorobeez [~quassel@85.142.148.12] has joined #wesnoth-dev
20140315 07:27:11-!- wesbot changed the topic of #wesnoth-dev to: 1.12 branch created | string+feature freeze active on 1.12 | 226 bugs, 353 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140315 07:30:17-!- sachith500 [~kvirc@112.134.7.217] has joined #wesnoth-dev
20140315 07:37:17-!- irker409 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20140315 07:40:20-!- sachith500 [~kvirc@112.134.7.217] has quit [Ping timeout: 264 seconds]
20140315 08:07:18-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140315 08:12:14-!- vorobeez [~quassel@85.142.148.12] has quit [Remote host closed the connection]
20140315 08:15:04-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140315 08:16:07-!- neXyon [~neXyon@85-127-121-191.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140315 08:20:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140315 08:30:25-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20140315 08:31:28-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140315 08:32:28-!- sachith500 [~kvirc@61.245.163.10] has joined #wesnoth-dev
20140315 08:33:56-!- fabi__ [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 252 seconds]
20140315 08:42:36-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 08:47:08-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140315 08:52:23-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140315 08:53:14-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140315 09:05:09-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 09:09:17-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Remote host closed the connection]
20140315 09:11:40-!- zijing07 [de42aff5@gateway/web/freenode/ip.222.66.175.245] has joined #wesnoth-dev
20140315 09:12:58-!- zijing07 [de42aff5@gateway/web/freenode/ip.222.66.175.245] has quit [Client Quit]
20140315 09:41:44-!- bagzie [~bag@85-76-46-159-nat.elisa-mobile.fi] has joined #wesnoth-dev
20140315 09:42:23-!- mjs-de [~mjs-de@f049066088.adsl.alicedsl.de] has joined #wesnoth-dev
20140315 09:44:34-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140315 09:49:35< Ivanovic> hey folks
20140315 09:49:44< Ivanovic> what do you think of having another 1.12 beta release?
20140315 09:50:36-!- neXyon [~neXyon@85-127-121-191.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20140315 10:06:53-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140315 10:14:02-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 252 seconds]
20140315 10:24:08-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 264 seconds]
20140315 10:24:33-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 10:24:57-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140315 10:28:34-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20140315 10:28:34-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host]
20140315 10:28:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140315 10:30:56-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 10:35:29-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140315 10:40:18-!- exciton_ [chuck-the-@95.73.190.85] has joined #wesnoth-dev
20140315 10:40:44-!- exciton_ [chuck-the-@95.73.190.85] has quit [Read error: Connection reset by peer]
20140315 10:43:38-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds]
20140315 10:44:30-!- Fortescue_ [sid1929@gateway/web/irccloud.com/x-aycvtbhsfnxqqboi] has joined #wesnoth-dev
20140315 10:45:15-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140315 10:55:07-!- Goracore [~Miranda@p5B008368.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140315 10:56:23-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 252 seconds]
20140315 11:15:45-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140315 11:29:15< loonycyborg> shadowm: The reason of not using clang for some checks is simple: cxxtool=clang++ affects only C++ and those tests are done with C
20140315 11:38:24-!- Gallaecio [~quassel@84.120.219.74.dyn.user.ono.com] has quit [Remote host closed the connection]
20140315 11:39:11-!- Gallaecio [~quassel@84.120.219.74.dyn.user.ono.com] has joined #wesnoth-dev
20140315 11:42:25-!- Octalot [~noct@31.185.149.167] has quit []
20140315 11:46:02-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20140315 11:55:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140315 11:55:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20140315 12:15:00-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140315 12:16:20-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 264 seconds]
20140315 12:18:03-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140315 12:19:03-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 12:19:54-!- Coffee_irc [~david@ppp118-210-31-67.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20140315 12:23:42-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140315 12:24:27-!- Goracore [~Miranda@p5B008368.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140315 12:24:53-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140315 12:28:14-!- vorobeez [~quassel@85.142.148.12] has joined #wesnoth-dev
20140315 12:39:15-!- eldruz [~eldruz@lav35-1-82-236-137-179.fbx.proxad.net] has joined #wesnoth-dev
20140315 12:53:20< Goracore> What happens to skeletons after their master dies? Will they just fall apart? Will they continue the last task that was given to them?
20140315 12:55:27-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140315 13:00:16-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140315 13:06:34< Aishiko> they continue to attack if the scenario keeps going, unless killed off in a WML event
20140315 13:15:49-!- sachith500|2 [~kvirc@112.134.21.130] has joined #wesnoth-dev
20140315 13:19:56-!- sachith500 [~kvirc@61.245.163.10] has quit [Ping timeout: 252 seconds]
20140315 13:20:19-!- sachith500|2 [~kvirc@112.134.21.130] has quit [Ping timeout: 264 seconds]
20140315 13:21:31-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 13:23:44-!- Goracore [~Miranda@p5B008368.dip0.t-ipconnect.de] has quit [Quit: Goracore]
20140315 13:28:00-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 13:32:49-!- vorobeez [~quassel@85.142.148.12] has quit [Remote host closed the connection]
20140315 13:42:01-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140315 13:43:06-!- vorobeez [~quassel@85.142.148.12] has joined #wesnoth-dev
20140315 13:46:41-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 13:51:37-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140315 13:51:51-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140315 13:54:34-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140315 13:55:15-!- lipkab_ [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 13:56:29-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140315 13:57:50-!- irker730 [~irker@ai0867.net] has joined #wesnoth-dev
20140315 13:57:50< irker730> wesnoth: fendrin wesnoth:master dc9a2c89e4cf / src/widgets/ (button.cpp button.hpp): Adds the option to use a suffix to the image paths. http://git.io/_j6m1A
20140315 13:57:52< irker730> wesnoth: fendrin wesnoth:master 1e5d58af6a51 / / (14 files in 5 dirs): Made the orb and minimap colors configurable by the preferences. http://git.io/2XNJ3g
20140315 14:00:29-!- lipkab_ [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140315 14:12:50-!- vorobeez [~quassel@85.142.148.12] has quit [Remote host closed the connection]
20140315 14:12:52-!- vorobeez_ [~firsov@85.142.148.12] has joined #wesnoth-dev
20140315 14:13:00-!- vorobeez_ [~firsov@85.142.148.12] has quit [Client Quit]
20140315 14:13:21-!- vorobeez [~firsov@85.142.148.12] has joined #wesnoth-dev
20140315 14:16:21-!- vorobeez_ [~quassel@85.142.148.12] has joined #wesnoth-dev
20140315 14:16:49-!- vorobeez [~firsov@85.142.148.12] has quit [Client Quit]
20140315 14:17:06-!- vorobeez [~firsov@85.142.148.12] has joined #wesnoth-dev
20140315 14:18:48< irker730> wesnoth: fendrin wesnoth:master c565f92af248 / data/campaigns/Legend_of_Wesmere/ (4 files in 3 dirs): LoW 07: Made the map bigger, adjusted starting positions and more. http://git.io/NjbidQ
20140315 14:18:55-!- vorobeez_ [~quassel@85.142.148.12] has quit [Remote host closed the connection]
20140315 14:22:06-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has joined #wesnoth-dev
20140315 14:23:26< aquileia> "a minimap without a size, this way it can be sized in it's container."
20140315 14:24:06< aquileia> How can I define a container size in GUI2? Is there a widget for that?
20140315 14:25:43< aquileia> perhaps 'panel' ?
20140315 14:32:07-!- stikonas_ is now known as stikonas
20140315 14:33:22< vultraz> You can't set specific sizes for cells, I don't think, no
20140315 14:37:18< aquileia> how will the size be defined then?
20140315 14:38:01< aquileia> I'll have to read that up I guess...
20140315 14:40:34-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140315 14:40:48< mordante> servus
20140315 14:42:39-!- saurabh060792 [cb6ef619@gateway/web/freenode/ip.203.110.246.25] has joined #wesnoth-dev
20140315 14:43:42< vultraz> aquileia: dynamically 
20140315 14:43:57< aquileia> mordante: Hi
20140315 14:44:07< mordante> aquileia, still have questions regarding the 'inheritance for structs in src\gui\auxiliary\window_builder'?
20140315 14:44:09< mordante> hi aquileia 
20140315 14:44:55< aquileia> it resolved itself, the pull request is ready for review
20140315 14:45:14< mordante> ok good to hear
20140315 14:45:22-!- saurabh060792 [cb6ef619@gateway/web/freenode/ip.203.110.246.25] has left #wesnoth-dev []
20140315 14:45:23< mordante> will catch up with the log first
20140315 14:45:43< aquileia> https://github.com/wesnoth/wesnoth/pull/117
20140315 14:46:44< mordante> aquileia, the omission of the password box on the wiki is not intentional, probably the author didn't add the proper comments in the source code
20140315 14:47:12< aquileia> then I'll have to add those comments I guess...
20140315 14:47:16< mordante> so the numbox should also be listed in the wiki, but these pages are generated automatically
20140315 14:50:07< mordante> the matrix code is still experimental, did several experiments in that area since I'm not happy with the listboxes
20140315 14:50:14< mordante> so need to find a better way
20140315 14:53:16-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 15:00:01-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140315 15:00:16-!- exciton [chuck-the-@77.51.121.119] has joined #wesnoth-dev
20140315 15:01:48< mordante> aquileia, seems the pull request has several unrelated patches
20140315 15:02:12< aquileia> yes?
20140315 15:02:32< aquileia> They are separate commits
20140315 15:03:24< mordante> will it be annoying of you when some of them are cherry-picked
20140315 15:03:26< mordante> ?
20140315 15:03:43< aquileia> no, that's fine
20140315 15:04:14< aquileia> and the last three are only to get it compile in strict mode
20140315 15:05:06< aquileia> but if you wait a little, I'd add the wiki documentation
20140315 15:05:29< mordante> would it be possible to combine the compilation fixes with the main patch?
20140315 15:05:52< aquileia> I'd prefer that myself
20140315 15:06:04< mordante> me too
20140315 15:06:16< mordante> keeps the development history cleaner
20140315 15:06:58-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140315 15:06:59< aquileia> I'll have to push -f, but that's ok I guess
20140315 15:08:23< lipkab> Hi mordante.
20140315 15:08:29< mordante> hi lipkab 
20140315 15:09:27< lipkab> mordante: Could you look at my "technical details" here? http://wiki.wesnoth.org/SoC2014_lipkab_SDL2
20140315 15:10:01-!- exciton [chuck-the-@77.51.121.119] has quit [Read error: Connection reset by peer]
20140315 15:10:11< lipkab> I have a little trouble elaborating on display and game_display.
20140315 15:10:14< mordante> lipkab, later today looking at a patch at the moment
20140315 15:10:15-!- exciton [chuck-the-@77.51.121.119] has joined #wesnoth-dev
20140315 15:10:18< lipkab> Okay.
20140315 15:13:05< mordante> aquileia, is there a reason for the return on line 75?
20140315 15:13:10< aquileia> mordante, do you mind if most of my pull request is reverted for some minutes to merge those commits? I could use squash, but...
20140315 15:13:19< aquileia> let me see...
20140315 15:13:49< mordante> no problem I just looking at the code a github at the moment
20140315 15:14:51< aquileia> there was, but it's unnecessary now
20140315 15:15:23< aquileia> So you couldn't reload the page for a short time
20140315 15:16:02< mordante> ok, I just wondered, because I see several not required returns
20140315 15:16:43< mordante> also for debugging it might be nice to add a few log messages
20140315 15:17:01< aquileia> It's due to a structural revamp where I put more code into validate
20140315 15:17:41< aquileia> I'm not really a fan of log messages, so... what do you need?
20140315 15:18:28-!- eldruz [~eldruz@lav35-1-82-236-137-179.fbx.proxad.net] has quit [Read error: Operation timed out]
20140315 15:18:40< mordante> nothing specific, but I just noticed none around, and I love them
20140315 15:19:53< mordante> The C++ term is not overwrite, but override ( src/gui/widgets/num_box.hpp:81 )
20140315 15:19:54< aquileia> if there is no specific need I'd leave them out for now
20140315 15:20:01< aquileia> you can add them of course
20140315 15:20:14< mordante> ?
20140315 15:20:40< mordante> ah nevermind
20140315 15:21:33< mordante> and an overriden function must not be virtual, they are virtual the language guarantees that, so no real need for that comment
20140315 15:22:16< aquileia> That's not mine...
20140315 15:22:42< aquileia> It was in password box
20140315 15:22:57< mordante> I see, but it's also useless there ;-)
20140315 15:23:23< mordante> what's the type of cursor_shift integer or boolean?
20140315 15:23:46< aquileia> integer
20140315 15:24:45< aquileia> I have to pass the length 'len' of a paste to be inserted once
20140315 15:24:57< mordante> I thought so, but »!cursor_shift« can be confusing
20140315 15:25:07< mordante> also I'd like to see Doxygen comment in the headers
20140315 15:25:46< aquileia> I haven't tried Doxygen yet, so that would take some time
20140315 15:26:18< mordante> well the basics are quite simple, if you look at a documented function in the code I think all becomes clear
20140315 15:26:38-!- exciton [chuck-the-@77.51.121.119] has quit [Read error: Connection reset by peer]
20140315 15:26:53-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140315 15:28:05< aquileia> mordante, what is the auxiliary/widget_definition directory for?
20140315 15:29:00< aquileia> password_box had no file there, so I thought it's unnecessary
20140315 15:29:22< aquileia> *not necessary
20140315 15:30:01-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140315 15:31:52-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140315 15:33:43< mordante> aquileia, why do you need direct access to text_ in the num_box and thus make it protected?
20140315 15:34:30< aquileia> because I have to call text_.insert_text
20140315 15:35:53< aquileia> You said you prefer not to revert unnecessarily, so I have to use the inner implementation
20140315 15:41:36< aquileia> mordante, should deleting the comment in password_box be a separate commit?
20140315 15:43:32< mordante> yes please make the deleting comment in the password box separate
20140315 15:44:21< mordante> why do you need to call text_.insert_text, will ttext_::insert_text not suffice?
20140315 15:45:48< aquileia> I don't think that exists...
20140315 15:46:23< aquileia> ttext has that function, but it's not part of ttext_
20140315 15:48:10< mordante> ah I see
20140315 15:49:22< mordante> but by exposing text_ like this your code can modify text_ behind the back of the implementation and break the encapsulation
20140315 15:49:53< mordante> which it does since your paste doesn't fire the NOTIFY_MODIFIED event
20140315 15:50:21< mordante> I've to think about a better solution, but this change won't work
20140315 15:50:37< mordante> (I also expect redraw glitches)
20140315 15:51:16< aquileia> I later call a function that redraws anyhow
20140315 15:51:46< aquileia> and I think it should also fire the notification
20140315 15:52:27< mordante> which is code duplication and all caused because the encapsulation is broken
20140315 15:52:54< mordante> so if I change something in the base class this class will probably break
20140315 15:53:27-!- bagzie [~bag@85-76-46-159-nat.elisa-mobile.fi] has quit []
20140315 15:54:07< aquileia> code duplication is unavoidable here, I think text_box does it as well...
20140315 15:55:21< aquileia> delete_selection will fire those two, and the insert will repeat it later on
20140315 15:55:30-!- Rajdip [Rajdip@103.2.132.89] has joined #wesnoth-dev
20140315 15:55:57-!- pyromancer2 [~pyromance@pool-173-63-201-238.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20140315 15:56:11< aquileia> mordante: By the way, I pushed the proposed changes, the PR is updated
20140315 15:57:20< mordante> thanks
20140315 15:58:16< aquileia> About the encapsulation issue - well, I'd have to add itt 
20140315 15:58:22< mordante> I want to think about this issue before proceeding
20140315 15:59:03< aquileia> but it can't really break something
20140315 15:59:34< mordante> it does, it breaks the designed encapsulation and thus the entire design
20140315 16:00:19< mordante> that doesn't mean your num_box is impossible, just that we need to find a better solution for your problem
20140315 16:00:48< mordante> and I think I have an idea
20140315 16:00:50< aquileia> So... I'll have to move it to a set function in ttext_
20140315 16:00:54< aquileia> right?
20140315 16:01:49< mordante> no
20140315 16:02:54< aquileia> Do I have to guess or will you tell me?
20140315 16:05:45-!- exciton_ [chuck-the-@77.51.121.119] has joined #wesnoth-dev
20140315 16:05:55< mordante> I'll tell but want to give it some thought
20140315 16:05:58< aquileia> text_.insert_unicode I can circumvent easily, but text_.insert_text would need a completely inefficient workaround
20140315 16:08:21-!- exciton_ [chuck-the-@77.51.121.119] has quit [Read error: Connection reset by peer]
20140315 16:09:08-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds]
20140315 16:10:43-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140315 16:19:36< mordante> aquileia, I'm more thinking about something like http://paste.debian.net/87849/
20140315 16:19:57< mordante> allowing the caller to validate the result and accept or reject it
20140315 16:20:23< mordante> (also noticed some minor bugs in the ttext class that I need to fix)
20140315 16:21:20< aquileia> that would however necessite to change every call of that function - breaking things once at least
20140315 16:22:03< mordante> why breaking things?
20140315 16:22:36< aquileia> ah, I overlooked the default parameter
20140315 16:23:10< mordante> yeah added it to make it clearer (even it is not allowed at that place ;-))
20140315 16:24:47< mordante> maybe still can't hurt to also add an insert_text function that does the work of lines 14 and 15 and let paste_selection use that
20140315 16:24:49-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140315 16:25:42< mordante> what do you think of this solution? (I can probably write that code this evening)
20140315 16:25:51< irker730> wesnoth: fendrin wesnoth:master e0186e9f6924 / src/map.cpp: No longer write the map_data header anymore. http://git.io/TOdcWw
20140315 16:27:10< irker730> wesnoth: fendrin wesnoth:master 16f08c46d277 / data/campaigns/Legend_of_Wesmere/maps/Kalian.map: Removed obsolete map header. http://git.io/3eABQg
20140315 16:27:53< aquileia> there is one problem... the mechanics of validate include a) refusing the change  and  b) changing the text
20140315 16:28:22< aquileia> I mean changing it to e.g. maximum_value
20140315 16:29:29< aquileia> Only in one case the validator is negative, but in both we need to react
20140315 16:30:53< aquileia> and a question aside... shouldn't it default to NULL instead of boost::function<bool()>()   ?
20140315 16:31:12< aquileia> or is it the same?
20140315 16:31:43< aquileia> ah, it has to be executed once
20140315 16:31:46< mordante> I don't think NULL is a valid argument, the default results in no validation
20140315 16:32:11< mordante> if it were a function pointer it would be a NULL
20140315 16:32:11< aquileia> yes
20140315 16:32:18< aquileia> ok
20140315 16:33:37-!- spoffy [~spoffy@host81-159-195-99.range81-159.btcentralplus.com] has joined #wesnoth-dev
20140315 16:33:38< aquileia> I would need both a transform() and a validator()... I think it's easier just to add insert_text
20140315 16:33:57< mordante> the advantage of boost function is that you can send extra parameters
20140315 16:34:23< aquileia> Meaning I can break in...
20140315 16:35:13< aquileia> Because I'll change variables processed internally
20140315 16:36:10< mordante> I still think this way is better than the current solution, but let me hack something using your code
20140315 16:36:52< aquileia> my validator would trim, convert and (if out of bonds) reset 'text'
20140315 16:37:22< mordante> please wait until I wrote something, it makes discussing easier ;-)
20140315 16:37:25< aquileia> and if it throws an error during that, it would return false
20140315 16:38:14< aquileia> I could try it myself if you want
20140315 16:43:53-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 16:45:18< aquileia> Oh, I just found an error in my code... good that I caught it
20140315 16:46:49< mordante> I think something like this would then work http://paste.debian.net/87855/
20140315 16:46:50< aquileia> I shift the cursor by the same amount... no matter whether I replaced the text by minimum_value
20140315 16:48:03< aquileia> that means cursor shift shouln't be const
20140315 16:50:00< aquileia> mordante: You finish by ttext_::insert_text()... why then bother with the paste_selection in the first place?
20140315 16:51:17< aquileia> You completely override paste_selection and don't reference the original
20140315 16:53:06< mordante> since your paste selection modifies the pasted text before inserting it
20140315 16:53:30-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Remote host closed the connection]
20140315 16:53:46< mordante> but I also want to modify insert_unicode to also  have a validation function
20140315 16:53:52< aquileia> I really think presenting insert_text would be enough...
20140315 16:54:34< aquileia> oh, yes, insert_unicode would be nice as well
20140315 16:55:23< mordante> your restore code doesn't restore the cursor position
20140315 16:55:33< mordante> so you also need to do that on your side
20140315 16:56:02< aquileia> it doesn't need because the catch occurs before it is changed
20140315 16:56:13< aquileia> * need to
20140315 16:57:01< aquileia> validate(..., len) is only executed if lexical_cast works
20140315 16:57:02< mordante> really?
20140315 16:57:19< mordante> I'm looking at tnum_box::insert_char
20140315 16:58:20< mordante> what happens if I have 12_34_|56 (where 34 is selected and the cursor behind it) and now press 'a'
20140315 16:59:01< mordante> diner's ready will be back afterwards
20140315 16:59:22< aquileia> I can use that time to write a short explanation
20140315 16:59:31< mordante> ok
20140315 16:59:42< aquileia> enjoy your meal
20140315 17:02:26-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 17:05:38-!- AI0867_ is now known as AI0867
20140315 17:06:34< AI0867> aquileia: I don't know if anyone's asked this yet, but you use a uint16 for a unicode character. What happens with characters that aren't in the BMP?
20140315 17:06:38-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140315 17:06:52-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 17:07:25-!- vorobeez [~firsov@85.142.148.12] has quit [Quit: leaving]
20140315 17:07:44< aquileia> I can't really answer that - but if that's an issue, it's also an issue with any text box
20140315 17:09:33< aquileia> AI0867: It would even affect handle_key_default from ttext_ ...
20140315 17:10:30< aquileia> So basically any keyboard input for any text in Wesnoth
20140315 17:11:27-!- Goracore [~Miranda@p5B008368.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140315 17:12:15< AI0867> mordante: ^ is all GUI2 text input in UTF-16 or UCS-2?
20140315 17:13:05< aquileia> He just left, so he won't respond before finishing dinner
20140315 17:13:24< AI0867> okay
20140315 17:14:32< AI0867> FYI, UCS-2 is the original 16-bit format still named 'unicode' in various programs. It does not support anything more than the Basic Multilingual Plane
20140315 17:14:40< AI0867> UTF-16 is UCS-2 with surrogate pairs
20140315 17:14:56< AI0867> so multiple UTF-16 symbols may be only one character
20140315 17:16:01< AI0867> there's also UTF-32 (32 bits should be enough for everyone!) and UTF-8 (let's start with ASCII and make everything else out of surrogate pairs)
20140315 17:16:10< aquileia> Then I assume it's UCS-2...
20140315 17:16:44< aquileia> but I don't know
20140315 17:17:18< aquileia> I like UTF-8 in principle
20140315 17:17:45< AI0867> there's also references to wide_string, which is a basic_string<wchar_t>. The problem with wchar_t is that is that it does not have a specific size. "Type whose range of values can represent distinct codes for all members of the largest extended character set specified among the supported locales."
20140315 17:19:44< AI0867> "extended character set" sounds like ISO-8859-15, shift-JIS, KOI8-R and the like
20140315 17:19:46< aquileia> Sorry, but you'll have to wait for an answer by mordante... the innards of GUI2 are unknown to me
20140315 17:19:48-!- lipkab_ [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 17:19:53< AI0867> rather than a unicode-based system
20140315 17:19:59-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140315 17:25:12< aquileia> mordante: I see what you mean... my code assumes that the selection is backwards and the cursor will therefore be at the start of selection
20140315 17:27:08< aquileia> both directions should be supported, so I'll need another  temporary variable
20140315 17:36:05< aquileia> but the selection will have a length of 0 after that (the text will no longer be selected)... do I have to precisely recreate the initial conditions? I think it's not that important
20140315 17:37:48< aquileia> after delete_selection we're at 12|34m after insert_unicode at 12|a34 and we'll end with 12|3456
20140315 17:38:07-!- lipkab_ [~lipkab@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140315 17:40:22-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 17:42:07< mordante> AI0867, IIRC SDL uses unicode and the same for GUI1 so I just did the same
20140315 17:43:06< mordante> aquileia, exactly my problem with the current code regarding selections
20140315 17:43:30< mordante> therefore I think having the parent widget controlling that part would be cleaner
20140315 17:45:13-!- spoffy [~spoffy@host81-159-195-99.range81-159.btcentralplus.com] has quit [Ping timeout: 240 seconds]
20140315 17:45:29-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140315 17:46:26< aquileia> but I think it's no problem if  the user looses his selection length - he'll see he made an error
20140315 17:47:04< aquileia> It's no bug, it's a feature ;)
20140315 17:47:27< aquileia> else he'd wonder if his keyboard disconnected
20140315 17:47:33< mordante> IMO it's a bug
20140315 17:47:44-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 17:49:44< mordante> lipkab, FYI I'm already looking at some generic SDL texture code
20140315 17:50:00< aquileia> then I'll just use set_selection_length()
20140315 17:51:28< mordante> lipkab, does YCM work really good, I use clang complete but it feels somewhat buggy
20140315 17:53:02< aquileia> afk...
20140315 17:58:47< mordante> see you later
20140315 17:59:05< aquileia> I'm back
20140315 18:01:03< aquileia> While I was away, I realized that I wasn't aware of [g/s]et_selection_length() when writing my code...
20140315 18:01:51< aquileia> With that, I can copy the full state of the text_box are just emulate the change!
20140315 18:02:01< aquileia> s/are/and
20140315 18:02:33< mordante> yes but I think it would be better to do that in the parent class
20140315 18:03:00< mordante> that class knows about its internals and the odds are better that when somebody adds more state it will be properly updated
20140315 18:03:35< mordante> (in fact probably the state should be a struct internally just to make sure it is done properly)
20140315 18:03:40-!- sachith500|2 [~kvirc@112.134.21.130] has joined #wesnoth-dev
20140315 18:05:14< aquileia> so... should I implement get_state() in ttext_ which returns a struct? Of course, if you want to do that - less work for me...
20140315 18:05:45< mordante> well we need another name for it, state_ is already used ;-)
20140315 18:06:05< aquileia> I know... I hoped you wouldn't notice :p
20140315 18:06:32< mordante> small chance even if I didn't the compiler would
20140315 18:06:36< aquileia> content
20140315 18:06:38< aquileia> ?
20140315 18:07:18-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140315 18:08:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20140315 18:08:40-!- stikonas_ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20140315 18:08:40-!- stikonas_ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host]
20140315 18:08:40-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140315 18:09:32< mordante> I'll think about it, first going to fix some bugs in the code for 1.12 then will look at these parts in master
20140315 18:09:53-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 18:10:46< aquileia> can I assume there'll be a struct containing the text, cursor and selection_length?
20140315 18:11:13< aquileia> than I could adjust num_box
20140315 18:11:54< aquileia> Like I said, I could add it myself if you want me to
20140315 18:12:10< mordante> I'm not sure it should be exposed… since it would allow users to do nasty things
20140315 18:12:22< mordante> I think I will go with the save/restore idea
20140315 18:12:33< mordante> so you can take a snapshot and restore that
20140315 18:13:04< mordante> without needing to know (nor care) what it exactly does
20140315 18:13:05< aquileia> yes... that's why I wrote get_state() earlier
20140315 18:13:07-!- Fortescue_ [sid1929@gateway/web/irccloud.com/x-aycvtbhsfnxqqboi] has quit [Ping timeout: 264 seconds]
20140315 18:13:48< aquileia> you could get a copy for personal use, but not access the original
20140315 18:14:13< mordante> except that it won't return anything but saves it in the current 'state' in the widget
20140315 18:14:14< aquileia> then all my checks would apply to the copy
20140315 18:15:54< aquileia> Well, you didn't reply to my proposal of 'content'
20140315 18:16:15-!- Fortescue_ [sid1929@gateway/web/irccloud.com/x-pbdzagbmenurzicd] has joined #wesnoth-dev
20140315 18:16:46< aquileia> so I repeated 'state'
20140315 18:17:23< mordante> I was more objecting against the »get« part
20140315 18:17:26< aquileia> ah, I misunderstood
20140315 18:18:50< mordante> anyway I'll start to code something and post the WIP-patches once the basics are done
20140315 18:18:51< aquileia> I disagree... having void save() would double the necessary  storage pemanently, and you can't use that data to check
20140315 18:19:54< aquileia> having it return a struct would make to easy to do all checks and then just  use the original functions
20140315 18:20:17< aquileia> like insert_char
20140315 18:20:19< mordante> true it's overhead
20140315 18:20:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 255 seconds]
20140315 18:21:14< mordante> using the original functions will fail since you can't process delete_selection on the duplicate
20140315 18:21:19< aquileia> and you can get that data anyhow, you just haave to use all get functions together
20140315 18:22:24< aquileia> a) make delete_selection to apply to the struct
20140315 18:22:25-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140315 18:23:00< aquileia> or b) don't bother and just use a normal std::string function on the copy
20140315 18:23:56< aquileia> I wanted to say that you wouldn't need to change paste_selection, insert_char, ... because the chack can be applied well before
20140315 18:24:04< aquileia> *check
20140315 18:27:02< aquileia> now that I think about it, IMHO it's the obvious thing to do: add a struct with get (& perhaps set) and everyone's happy
20140315 18:27:24< mordante> I want to give it some more thoughts, will have a closer look at the code
20140315 18:28:06< aquileia> ok
20140315 18:28:22-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140315 18:31:58-!- sachith500|2 [~kvirc@112.134.21.130] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140315 18:32:44< aquileia> if the struct became an integral part though, one could shorten
20140315 18:32:48< lipkab> mordante: "lipkab, FYI I'm already looking at some generic SDL texture code" <- Does that mean that you're in the process of obsoleting my roadmap? D:
20140315 18:32:51< aquileia>  text_() , selection_start_(0), selection_length_(0)
20140315 18:33:13< aquileia>  to content("",0,0)
20140315 18:34:12< aquileia> but it's not necessary to fully convert
20140315 18:34:34< aquileia> content could just be used for import/export
20140315 18:35:08< lipkab> mordante: YCM has some minor glitches (namely the code checker sometimes doesn't update until you move the cursor, although the developer blames that on Vim), but it works perfectly otherwise.
20140315 18:36:12< lipkab> I have never tried it on bigger programs, though.
20140315 18:37:40-!- bagzie [~bag@85-76-32-7-nat.elisa-mobile.fi] has joined #wesnoth-dev
20140315 18:43:54< AI0867> Ivanovic: I'm fine with a release this weekend
20140315 18:49:54< mordante> aquileia, what about something like this http://paste.debian.net/87870/
20140315 18:50:57-!- neXyon [~neXyon@85-127-121-191.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140315 18:50:57-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140315 18:51:03< mordante> lipkab, clangcomplete when using libclang is very fast, but changes the current working directory causing havic
20140315 18:51:04< aquileia> I thought you didn't want to undo unnecessary changes?
20140315 18:51:06< mordante> havoc*
20140315 18:52:00< mordante> aquileia, well since you weren't too happy with the validate
20140315 18:52:03< aquileia> if we have tcontent copy = get_content(), I could do the checks before
20140315 18:52:31< mordante> doing delete_selection is tricky it's a virtual function
20140315 18:52:59< mordante> so a subclass of yours might want to change the idea of delete_selection()
20140315 18:53:41< aquileia> I don't follow...
20140315 18:54:20< mordante> lipkab, not destroying it per se, but as said before it will probably need some massaging closer to the GSoC deadline
20140315 18:54:27< aquileia> Let me just write a short code snippet
20140315 18:54:27< mordante> application*
20140315 18:55:08< Ivanovic> things are currently not building for me: http://pastebin.com/JHskBnes
20140315 18:55:12< Ivanovic> that is in master
20140315 18:55:42< mordante> lipkab, but there are some issues I still have with textures
20140315 18:55:45< lipkab> mordante: Hm, I ditched clang_complete because it was horribly slow. It had like 2 second lags when autocompleting even with 1000-2000 lines of code.
20140315 18:56:15< mordante> Ivanovic, I'll fix it
20140315 18:56:31< mordante> lipkab, yes by default it uses clang, using libclang is fast
20140315 18:56:36< Ivanovic> okay
20140315 18:56:56< mordante> no idea why there is an u_int :-/
20140315 18:57:20< mordante> and somebody needs to be slapped for using C-style casts
20140315 18:57:32< lipkab> Ah-ha. I didn't know that. Well, YCM is fast by default :)
20140315 18:57:55-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20140315 18:58:09< mordante> maybe it uses libclang by default, guess I've something to look at :-)
20140315 19:01:09< lipkab> mordante: Anyways, I wanted to ask a question. You mentioned that the rendering engine will need fundamental changes; however, I spent a few a hours examining the code and still couldn't figure what exactly needs to be changed (fundamentally).
20140315 19:01:23< anonymissimus> wesbot: bug #19018
20140315 19:01:24< wesbot> Bug #19018  Assigned to: Anonymissimus <anonymissimus>  Status: Ready For Test  Priority: 5 - Normal
20140315 19:01:27< wesbot> Summary: [replace_map] produced no warnings replacing the game map with an empty map, leaving some units off-map
20140315 19:01:30< wesbot> Original submission: I came across this bug while developing a part of my camp
20140315 19:01:33< wesbot> aign.svn: https://wesnoth-umc-dev.svn.sourceforge.net/svnroot/wesnoth-umc-de
20140315 19:01:36< wesbot> URL: http://gna.org/bugs/?19018
20140315 19:01:58< lipkab> You mentioned the unrendering thing, but I can't find any example of that in display or game_display.
20140315 19:02:50< mordante> lipkab, unrendering is more in the GUI code
20140315 19:04:13< mordante> lipkab, display::draw contains a lot of invalidated tests and updates, when redrawing everything that is no longer required
20140315 19:04:38< aquileia> mordante: it's possible to select in reverse direction, right?
20140315 19:05:32< aquileia> selection_length will just be negative then if I understand correctly...
20140315 19:05:44< mordante> aquileia, yes look at the comment for selection_length_
20140315 19:06:35< aquileia> ah, thanks
20140315 19:06:56< aquileia> I'll have the code snippet ready soon
20140315 19:07:07< mordante> anonymissimus, btw I wouldn't be surprised if wesnoth won't compile for you there's a weird u_int, which is about to be removed :-)
20140315 19:08:06< lipkab> mordante: Partial redrawing of the screen is still possible with textures and tracking invalidated areas would still save us quite a few RenderCopy calls, so... what am I missing here?
20140315 19:08:20< irker730> wesnoth: Mark de Wever wesnoth:master 835977c43706 / src/game_preferences_display.cpp: Remove an old-style-cast. http://git.io/FBWrBA
20140315 19:10:06< lipkab> Validation tests now cost more than redrawing the whole screen?
20140315 19:11:00< mordante> I thought that with the textures it needed to redraw the entire frame, but haven't tested yet
20140315 19:11:48< irker730> wesnoth: Mark de Wever wesnoth:master 093f19ff9ec7 / src/game_preferences_display.cpp: Remove the usage of the non-standard u_int. http://git.io/wzUTEw
20140315 19:11:58< mordante> Ivanovic, fixed
20140315 19:12:27-!- gfgtdf [~chatzilla@f054143201.adsl.alicedsl.de] has joined #wesnoth-dev
20140315 19:15:19< anonymissimus> mordante: trunk ? it did
20140315 19:15:48< anonymissimus> but there's some uint type which is used every now and then by linux coders but is not a standard type yes
20140315 19:16:16< anonymissimus> thunderstruck: ping
20140315 19:16:27< mordante> I've seen uintxx_t before but this u_int never
20140315 19:17:11< AI0867> mordante: I haven't looked very deeply yet, but it looks like SDL uses UCS-2, which is a problem for proper unicode input
20140315 19:20:07< thunderstruck> anonymissimus: pong
20140315 19:23:50< mordante> AI0867, SDL 1.2 or 2.0?
20140315 19:27:11-!- wesbot changed the topic of #wesnoth-dev to: 1.12 branch created | string+feature freeze active on 1.12 | 228 bugs, 353 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140315 19:28:24< aquileia> mordante: http://pastebin.com/660bhJVq
20140315 19:31:39< mordante> as said since delete_selection is a virtual function it won't work. You assume an implementation, which might not be true
20140315 19:32:22< aquileia> but... this time there is no delete_selection
20140315 19:33:12< mordante> no there is a delete_selection emulation
20140315 19:33:49< aquileia> it's only a possibility to have a new delete_selection applying to all content structs
20140315 19:34:20< aquileia> then this could be used both for the original and copies
20140315 19:34:56< mordante> the problem is delete_selection is a virtual call for ttext_ class so you can't make any assumption what it really does
20140315 19:36:58-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140315 19:37:09< aquileia> I think I'm explaining it badly...
20140315 19:37:30-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 19:38:11< aquileia> What I propose would be to have ttext_::delete_... call content.delete_...
20140315 19:38:48< AI0867> mordante: still looking
20140315 19:39:25< aquileia> content would be completely encapsuled, but copies had the same delete method available
20140315 19:39:29< AI0867> mordante: but in thandler::key_down, for SDL1.2, you use event.keysym.unicode, while for SDL2, event.keysym.sym is cast
20140315 19:39:45< AI0867> er, scancode
20140315 19:40:29< AI0867> which is a physical keyboard location, and definitely not unicode
20140315 19:42:31-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140315 19:42:36< AI0867> I /suspect/ that SDL1.2's unicode handling was broken, and they removed this feature from the keyboard events in SDL2 so it could be done in a different layer
20140315 19:43:00< AI0867> a keyboard event isn't the right place, a textinput event is
20140315 19:43:44< irker730> wesnoth: Mark de Wever wesnoth:1.12 15121d706349 / src/gui/widgets/text.cpp: Fix a possible refresh issue in the text boxes. http://git.io/UBa1Yw
20140315 19:43:46< irker730> wesnoth: Mark de Wever wesnoth:1.12 f87c4ed6bf24 / src/gui/widgets/text.cpp: Avoid spurious notification in the text box. http://git.io/YNj6NA
20140315 19:43:48< irker730> wesnoth: Mark de Wever wesnoth:1.12 7e5dae165002 / changelog src/gui/widgets/text.cpp: Merge branch 'ttext_fixes' into 1.12 http://git.io/CfgBkw
20140315 19:44:05< AI0867> and textinput provides a utf-8 C-string
20140315 19:44:54< AI0867> or just a char for every utf-8 byte, but that works out the same
20140315 19:45:07< mordante> yes for SDL 2 we need to move to the text input events, so at the moment keyboard handling in SDL 2 is completely broken
20140315 19:45:30< AI0867> okay, so the move to SDL2 will fix this automatically
20140315 19:45:38< AI0867> for some values of automatic
20140315 19:45:50< mordante> yes that's the goal
20140315 19:46:00< AI0867> SDL2, java, windows
20140315 19:46:06< aquileia> but then... all of GUI2 kay_handle events are going to change?
20140315 19:46:10< AI0867> they all have the same issue
20140315 19:46:14< AI0867> aquileia: probably, yes
20140315 19:46:21< AI0867> er, SDL1
20140315 19:46:34< mordante> but I never looked closely at what SDL 1.2 did, but looked at the existing Wesnoth code
20140315 19:46:52< mordante> aquileia, yes
20140315 19:47:00< AI0867> they all jumped on 'unicode' when some idiot thought 16k codepoints would be enough for everyone
20140315 19:47:28< mordante> some people have a limited view of everyone ;-)
20140315 19:48:06< aquileia> and a limited view of comfort... UTF8 is an improvement in that direction as well
20140315 19:48:07< AI0867> and as utf-16 works just like ucs-2 if you don't leave the BMP, many of the programs written in those days have not been changed
20140315 19:48:32< AI0867> and people *still* write broken utf-16 handling for that reason
20140315 19:48:55< AI0867> there are valid reasons to use utf-16, but it's used mainly for historical reasons
20140315 19:49:06< anonymissimus> thunderstruck: I think it has already answered itself
20140315 19:49:13< AI0867> you should typically use utf-8 or utf-32
20140315 19:49:49< mordante> depends, if you were writing software for Japanese systems and had to be careful about memory usage UTF-16 could be a solution
20140315 19:50:00< AI0867> yes, there are valid reasons
20140315 19:50:05-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140315 19:50:07< AI0867> but that's rarely why people pick it
20140315 19:50:17< mordante> true
20140315 19:51:38< anonymissimus> thunderstruck: I wanted to ask about the how-to-reproduce for https://gna.org/bugs/index.php?21158 you could have been more specific
20140315 19:51:52< AI0867> why do we still use wide_string btw? we now have ucs4_string, which is actually guaranteed to be 4 bytes wide
20140315 19:52:10< AI0867> wchar_t is 32 bits on unix, but not required to be that wide on other systems
20140315 19:52:14< aquileia> So for some time several GUI widgets wil need ifdef'd compability code?
20140315 19:52:16< anonymissimus> but an mp scenario with empty map data seems to way to go
20140315 19:54:34< mordante> aquileia, probably yes
20140315 19:54:39< irker730> wesnoth: anonymissimus wesnoth:master a52b3846f2c3 / src/about.cpp: really fix warning about not initialized variable http://git.io/-E7wZg
20140315 19:54:41< irker730> wesnoth: anonymissimus wesnoth:master e45894c17b19 / projectfiles/VC9/wesnoth.vcproj: vc project update http://git.io/5hplCQ
20140315 19:54:43< aquileia> nice...
20140315 19:55:38< aquileia> anonymissimus: I think you just introduced a merge conflict for my patch of wesnoth.vcproj...
20140315 19:55:52< irker730> wesnoth: Boldizsár Lipka wesnoth:1.12 89fe64e137cf / src/about.cpp: Don't use uninitialized data member for variable initialization. http://git.io/WvErhw
20140315 19:55:54< irker730> wesnoth: anonymissimus wesnoth:1.12 2f1bd85419d7 / src/about.cpp: really fix warning about not initialized variable http://git.io/m7wUZg
20140315 19:56:59< Aishiko> is there anyreason I shoue be getting a permission denied  when trying to use wesnoth/utils/autorevision?
20140315 19:57:11< mordante> AI0867, probably since nobody modified the code?
20140315 19:57:49< aquileia> anonymissimus: Ah, sorry, merging should work as you only inserted that...
20140315 19:58:14< Aishiko> I can't stay so I'll grep the log for when I return
20140315 19:58:54< anonymissimus> aquileia: oh, so you are an MSVC coder ?
20140315 19:59:14< aquileia> since this week, yes
20140315 19:59:31< aquileia> *last tuesday
20140315 19:59:31< anonymissimus> well, there is an option to "just skip this patch" IIRC
20140315 19:59:55< anonymissimus> when rebasing and the conflict occurs
20140315 20:00:08< aquileia> I thought yo changed an existing configuration, hence my comment
20140315 20:00:21< aquileia> I had deleted the NDEBUG flag
20140315 20:00:43< aquileia> https://github.com/aquileia/wesnoth-old/commit/bb6bfdcb7deab7f8170f3a49a2c3b48f6791e3ba
20140315 20:02:50-!- Aishiko_laptop [~unknown@cpe-065-191-176-226.nc.res.rr.com] has quit [Ping timeout: 255 seconds]
20140315 20:09:31< aquileia> mordante: would this resolve the delete_selection issue http://pastebin.com/FEK0L1hm  ?
20140315 20:09:41-!- Goracore [~Miranda@p5B008368.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140315 20:10:16< aquileia> oh, I forgot to fire the notification
20140315 20:10:20< anonymissimus> aquileia: why remove that ?
20140315 20:10:28< anonymissimus> NDEBUG is important
20140315 20:10:44< aquileia> it is disfunct
20140315 20:11:38< aquileia> if you change to Release configuration where it is set, it will throw an error like 'NDEBUG no longer supported#
20140315 20:12:01< anonymissimus> where does it throw that ? a never MSVC version ?
20140315 20:12:19< anonymissimus> or are u using cmake +msvc ?
20140315 20:12:20< aquileia> it's in wesnoth master
20140315 20:12:24< mordante> anonymissimus, when NDEBUG is defined asserts are disabled
20140315 20:12:53-!- ancestral [~ancestral@mobile-198-228-232-074.mycingular.net] has joined #wesnoth-dev
20140315 20:12:54< mordante> since Wesnoth uses asserts as input validation they shouldn't be disabled
20140315 20:13:19< mordante> so recently I added an #error if the macro was defined
20140315 20:14:11< aquileia> and as a reaction Ivanovic pruned most compiler configurations of it... except MSVS
20140315 20:14:35< aquileia> (or at least cmake)
20140315 20:14:36< mordante> aquileia, no it won't since subclasses override delete_selection
20140315 20:15:14< aquileia> Sorry, but could you explain the issue?
20140315 20:17:06< anonymissimus> hm I vaguely recall NDEBUG was important but not where or why
20140315 20:17:06< aquileia> I really on't understand what problem could be caused by that implementation
20140315 20:17:25< anonymissimus> ofc we want asserts in release
20140315 20:19:09-!- eldruz [~eldruz@lav35-1-82-236-137-179.fbx.proxad.net] has joined #wesnoth-dev
20140315 20:19:28< mordante> aquileia, since that implementation overrides delete_selection the original delete_selection is no longer called
20140315 20:19:57< mordante> so adding an implementation for it in ttext_ will have no effect at all
20140315 20:20:13< mordante> every subclass overrides it since it was pure virtual before
20140315 20:20:52< aquileia> mordante, but you can directly call the original
20140315 20:21:44< aquileia> I mean the original content.delete_selection
20140315 20:21:44< mordante> yes but the original and the current implementation might not do the same so after your validation the real code does something else
20140315 20:22:25< mordante> so you validated with code path x and then execute code path y as the real thing
20140315 20:23:14< aquileia> but set_content wouldn't call delete_selection!
20140315 20:25:34< aquileia> At any time, there are all delete_selection implementations available: content.d... & ttext_box::d... & tnum_box::d...
20140315 20:26:55< aquileia> and ttext_::d..
20140315 20:27:59< aquileia> only if set_content was virtual that might be an issue
20140315 20:28:58 * aquileia wonders if he got the point  or is just overlooking the issue...
20140315 20:30:32< mordante> paste_selection calls delete_selection which will break if somebody subclasses your widget and makes a slight modification to delete_selection
20140315 20:31:03< mordante> for example to filter out deleting the leading + sign since that user always want the value to a have a sign
20140315 20:31:45< aquileia> paste_selection calls copy.delete_selection, not tnum_box::delete_selection
20140315 20:31:47< mordante> so _-12_|34 paste 5 -> +|34 -> +5|34
20140315 20:32:06< anonymissimus> Ivanovic: why was the 1.12 branch created so early btw ?
20140315 20:33:11< mordante> then why have ttext_::delete_selection? (I'm getting more and more confused and getting the feeling the code gets ugly)
20140315 20:33:20-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140315 20:33:34-!- spoffy [~spoffy@host81-159-195-99.range81-159.btcentralplus.com] has joined #wesnoth-dev
20140315 20:33:55< aquileia> ttext_::delete_selection is there in case ttext_box overrides it, 
20140315 20:34:06< aquileia> I didn't look yet
20140315 20:34:24< aquileia> oh, and for tpassword_box as well
20140315 20:35:07< aquileia> tpassword_box::delete_selection calls ttext_::delete_selection
20140315 20:35:47< aquileia> therefore it is needed if we don't want to change every single subclass
20140315 20:36:39-!- Rajdip [Rajdip@103.2.132.89] has quit [Quit: Leaving]
20140315 20:36:46< mordante> yes they _must_ override it else the compiler _will_ complain
20140315 20:37:36< mordante> now you completely confused me
20140315 20:37:39-!- ancestral [~ancestral@mobile-198-228-232-074.mycingular.net] has quit [Quit: Smell ya later!]
20140315 20:38:56< aquileia> mordante: Do you want me to complete the rewrite and then show you the result?
20140315 20:39:51< mordante> can you explain why we need line 18 -- 21 in your latest paste starting at step 1?
20140315 20:40:03-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20140315 20:41:35< mordante> also possible but please pastebin it before adding to GitHub
20140315 20:41:55< aquileia> subclasses of ttext_ might want to have an implementation of delete_selection()
20140315 20:42:39< aquileia> it's currently in ttext_ so it should stay there for these subclasses to  implement
20140315 20:43:54< aquileia> ah, it's empty in ttext_ ?
20140315 20:44:41< mordante> it does not exist in ttext_ it's a pure virtual
20140315 20:44:56< aquileia> I thought that - because text.cpp uses it - it would already exist
20140315 20:45:08< mordante> it only has an entry in the vtable
20140315 20:45:37< mordante> (at least in the common implementations)
20140315 20:45:38< aquileia> text.cpp line 132
20140315 20:46:15< mordante> there is no problem to use it in text.cpp ttext_ is an abstract class
20140315 20:47:12< aquileia> ahh... that explains why I had several issues understanding where functions are implemented!
20140315 20:48:20< mordante> I would really recommend to read this site http://www.cs.nctu.edu.tw/cis/chinese/doc/research/c++/C++FAQ-English/
20140315 20:48:44< mordante> and especially http://www.cs.nctu.edu.tw/cis/chinese/doc/research/c++/C++FAQ-English/abcs.html could be interesting
20140315 20:48:55< aquileia> Thanks
20140315 20:49:41< aquileia> It's a non-trivial step from basic C to C++
20140315 20:49:54< mordante> the site contains a lot of information especially regarding several gotcha's of C++
20140315 20:50:43< mordante> it hasn't been updated for C++11, which, in this case, is an advantage
20140315 20:52:14< aquileia> that means... in text.hpp I should only define an abstract struct implemented in derived classes?
20140315 20:53:01< aquileia> Or is the struct implementation allowed there?
20140315 20:53:34< mordante> abstract only refers to the member functions, not the member variables
20140315 20:53:55< aquileia> Ok
20140315 20:54:29< mordante> I'm off now, bye
20140315 20:54:40< aquileia> What about delete_selection in struct content?
20140315 20:54:56< aquileia> bye, and thank you
20140315 20:55:08< mordante> you're welcome
20140315 20:55:31< mordante> not sure whether it needs to be virtual, but can't find a reason to do so now
20140315 20:55:38< Ivanovic> anonymissimus: so that the gsoc feature development can happen
20140315 20:55:53-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140315 21:00:26-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20140315 21:04:13< aquileia> and now it dawns upon me how nice it is that ttext is abstract...
20140315 21:05:09< aquileia> I can rewrite it to use a struct without any  problems arising in subclasses! C++ is nice...
20140315 21:06:03-!- EdB [~edb@37.162.126.26] has joined #wesnoth-dev
20140315 21:06:31-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has left #wesnoth-dev []
20140315 21:08:01< anonymissimus> Ivanovic: but it lifts pressure off of devs to fix bugs instead of coding features doesn't it ?
20140315 21:08:12< Ivanovic> yes, it does
20140315 21:08:34< anonymissimus> I always though that's what a feature freeze is about, mostly
20140315 21:11:25-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 21:15:37-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140315 21:29:09-!- EdB [~edb@37.162.126.26] has quit [Quit: Konversation terminated!]
20140315 21:43:59-!- eldruz [~eldruz@lav35-1-82-236-137-179.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20140315 21:50:34-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 11.0/20120312181643]]
20140315 21:55:20-!- Coffee_irc [~david@ppp118-210-31-67.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140315 21:56:43-!- Gallaecio [~quassel@84.120.219.74.dyn.user.ono.com] has quit [Remote host closed the connection]
20140315 21:57:36-!- Gallaecio [~quassel@84.120.219.74.dyn.user.ono.com] has joined #wesnoth-dev
20140315 21:57:53-!- Gallaecio_ [~quassel@84.120.219.74.dyn.user.ono.com] has joined #wesnoth-dev
20140315 22:09:45-!- gfgtdf_ [~chatzilla@f054063237.adsl.alicedsl.de] has joined #wesnoth-dev
20140315 22:11:38-!- gfgtdf [~chatzilla@f054143201.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140315 22:11:40-!- gfgtdf_ is now known as gfgtdf
20140315 22:23:21-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20140315 22:31:29-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140315 22:37:19< shadowm> loonycyborg: Why C instead of C++? We don't have any C code ourselves anymore.
20140315 22:37:48< loonycyborg> We use some purely C functions
20140315 22:37:56< loonycyborg> and test programs for them are in C
20140315 22:38:00< shadowm> No, client-side code.
20140315 22:38:20< shadowm> If the tests were done with the C++ compiler you may have a chance to catch issues with it earlier.
20140315 22:38:21-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20140315 22:38:57-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140315 22:40:45-!- Gallaecio [~quassel@84.120.219.74.dyn.user.ono.com] has quit [Remote host closed the connection]
20140315 22:40:52-!- Gallaecio_ is now known as Gallaecio
20140315 22:42:46< loonycyborg> Hmm, I could make checks for poll.h and the like with C++ compiler..
20140315 22:42:53< loonycyborg> But that'd be extremely weird
20140315 22:43:22< loonycyborg> I think I need to make a better way of enabling clang
20140315 22:55:57-!- irker730 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20140315 22:58:55-!- neXyon [~neXyon@85-127-121-191.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20140315 23:00:59< AI0867> loonycyborg: probably, yes
20140315 23:02:23-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 252 seconds]
20140315 23:06:26-!- jchb [~jb@174-125-81-141.dyn.centurytel.net] has joined #wesnoth-dev
20140315 23:11:19-!- spoffy [~spoffy@host81-159-195-99.range81-159.btcentralplus.com] has quit [Ping timeout: 264 seconds]
20140315 23:13:11-!- spoffy [~spoffy@host81-159-195-99.range81-159.btcentralplus.com] has joined #wesnoth-dev
20140315 23:37:58-!- Appleman1234 [~Appleman1@rrcs-97-79-164-178.sw.biz.rr.com] has joined #wesnoth-dev
20140315 23:38:19-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140315 23:49:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20140315 23:52:50-!- Immac [be353e6b@gateway/web/freenode/ip.190.53.62.107] has joined #wesnoth-dev
--- Log closed Sun Mar 16 00:00:58 2014