--- Log opened Thu Mar 20 00:00:10 2014
--- Day changed Thu Mar 20 2014
20140320 00:00:10< gfgtdf> with lua_function=
20140320 00:00:17< iceiceice> what is being randomized
20140320 00:00:28< gfgtdf> isk ask EliDupree.
20140320 00:00:31< gfgtdf> idk*
20140320 00:00:34< EliDupree> iceiceice have you read through https://gna.org/bugs/?21697 ?
20140320 00:01:02-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140320 00:01:16-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 00:02:15< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/pull/121 <-- this is my patch, it worked well but it still doesnt catches the case. " the mousover can also take place while teh unit attacks"
20140320 00:03:44< EliDupree> Note, synchronize_choice has zero security against a sophisticated cheater
20140320 00:04:27< EliDupree> I think I could hack it without even changing the wesnoth code.
20140320 00:04:27< iceiceice> no i haven't read all of this stuff
20140320 00:04:30-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140320 00:04:39< gfgtdf> where do you want to use synchronize_choice ? :o
20140320 00:05:03< iceiceice> wait so now we will have 3 rngs?
20140320 00:05:13< iceiceice> what is the random_new files
20140320 00:05:14< EliDupree> gfgtdf: I use it for all kinds of things
20140320 00:05:40< EliDupree> gfgtdf: btw how is math.random seeded?
20140320 00:06:01< gfgtdf> iceiceice:  the random_new shall replayce teh rnadom and rng files.
20140320 00:06:08< iceiceice> i see
20140320 00:06:25< gfgtdf> we have random_new::generator and dependen on what content we are in, it is eigher synced or not.
20140320 00:06:30< gfgtdf> context*
20140320 00:08:44< iceiceice> hmm so i see in replay_controller.cpp we will now fire preload events in replays?
20140320 00:09:36< iceiceice> i remember some discussion on bugs.w.o
20140320 00:09:48< gfgtdf> iceiceice: we alwasy fires preload events in replays
20140320 00:10:00< gfgtdf> once before prestart
20140320 00:10:05< gfgtdf> fired*
20140320 00:10:21< iceiceice> according to github diff at line 291 in replay_controller.cpp
20140320 00:10:32< iceiceice> we added "fire_preload();"
20140320 00:10:44< iceiceice> where i guess it wasn't previously
20140320 00:10:52< gfgtdf> iceiceice	: before the function fire_prestart did also fire preload
20140320 00:10:54-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 265 seconds]
20140320 00:11:09< iceiceice> hmm i see
20140320 00:11:29< gfgtdf> see changes in play_controller.cpp
20140320 00:12:27< gfgtdf> iceiceice: i didn't want to sync preload because it can be fires mutiple times durign a game but only oce durign replay.
20140320 00:12:33< gfgtdf> thats why i plit them
20140320 00:12:36< gfgtdf> split*
20140320 00:12:55< iceiceice> y i'm not sure i guess there is this thread on bugs.w.o about it
20140320 00:12:59< iceiceice> i haven't really followed it
20140320 00:13:05< iceiceice> its up to you
20140320 00:13:08< gfgtdf> iceiceice: in forum ?
20140320 00:13:20< iceiceice> no SlowThinker was reporting some issue here
20140320 00:13:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140320 00:13:33< gfgtdf> on gna bugs ?
20140320 00:13:37< iceiceice> https://gna.org/bugs/?21776
20140320 00:14:20< gfgtdf> hm its mee who mad the 'annonymous' comments, i decided to not change preload in this patch
20140320 00:14:51< gfgtdf> iceiceice: it jut want my main intention.
20140320 00:14:56< gfgtdf> wasn't
20140320 00:14:57-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140320 00:15:14< iceiceice> ok :)
20140320 00:17:43-!- incredible [cebe81ee@gateway/web/freenode/ip.206.190.129.238] has quit [Ping timeout: 245 seconds]
20140320 00:18:12< iceiceice> wait so what are the new intended features for synchronized choice / randomness?
20140320 00:18:26< iceiceice> we have some wesnoth.get_synced query function,
20140320 00:18:42< gfgtdf> iceiceice	: what new features do you mean ?
20140320 00:19:01< iceiceice> https://github.com/gfgtdf/wesnoth-old/commit/9aa98030049bfd4b485ab276efa664baf38586cd
20140320 00:19:04< EliDupree> Like being able to use set_variable rand= in unsynced context?
20140320 00:19:14< EliDupree> and the unit creation random things
20140320 00:19:35< gfgtdf> iceiceice: for example we can now use wesnoth.get_synced query  in attack event which didnt work before
20140320 00:20:00< iceiceice> are there new code features?
20140320 00:20:08< iceiceice> or does it just make the old ones work better
20140320 00:20:31< iceiceice> is it changing wml / lua syntax?
20140320 00:20:47-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140320 00:20:49-!- spoffy [~spoffy@152.78.175.8] has quit [Quit: Leaving]
20140320 00:21:21< gfgtdf> iceiceice: no expect for wesnoth.is_synced(), which indicates wether we are curently in a unsynced event like "select"
20140320 00:21:21< EliDupree> I don't know of any change to that other than wesnoth.is_synced()
20140320 00:21:30< iceiceice> i see
20140320 00:21:41< iceiceice> sounds like a good thing :)
20140320 00:22:29< iceiceice> but it should be not only easy for newbies to use haphazardly, also easy to explain what is going on to experts
20140320 00:22:36< gfgtdf> iceiceice: and we can now use synced_user_choice in start7prestart events
20140320 00:23:02< iceiceice> that's a C++ feature or a wml / lua feature
20140320 00:23:04< iceiceice> ?
20140320 00:23:44< gfgtdf> iceiceice: wesnoth.synchronize_choice is the lua feature, get_user_choice is the underlaying c++ function
20140320 00:23:55< iceiceice> right
20140320 00:24:06< gfgtdf> that is also used by , [message][option]s and [get_global_variable]
20140320 00:24:29< gfgtdf> iceiceice: we coudl also easily implement to allo executing wesnoth.synchronize_choice  on a different side than teh current side
20140320 00:24:47< iceiceice> so will games still have a "random_seed" key or is that gone now?
20140320 00:24:55< iceiceice> out of curiosity
20140320 00:25:11-!- neXyon [~neXyon@85.127.255.41] has quit [Quit: bye]
20140320 00:26:07< gfgtdf> iceiceice: hmm they still have cause im not really sure wether i can correctly handle "turn end" events. plus i plan t implement a "determinsitc SP mode" where you get teh same results when you reload a game, that woudl also use the random_seed
20140320 00:26:26< gfgtdf> iceiceice: like when you start an sp campign you can choose deternistic sp mode
20140320 00:26:31< iceiceice> ok
20140320 00:27:37< gfgtdf> for people who want to keep themself from saveloding :)
20140320 00:28:18-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev
20140320 00:29:08< gfgtdf> EliDupree: have you fund any other bugs not related to unit abilites ?
20140320 00:29:15-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140320 00:29:32< EliDupree> gfgtdf: I have not
20140320 00:29:53-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 00:33:22-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 00:34:35-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 265 seconds]
20140320 00:34:39< EliDupree> Hmm, after messing around for a few turns I got "terminate called after throwing an instance of 'end_turn_exception'"
20140320 00:35:22< EliDupree> I've got it open in gdb right now
20140320 00:35:48< EliDupree> backtrace http://pastebin.com/xbDxaAWK
20140320 00:36:00< EliDupree> gfgtdf
20140320 00:36:20-!- sachith500 [~kvirc@112.134.141.45] has joined #wesnoth-dev
20140320 00:36:51< EliDupree> with era http://pastebin.com/TVD7B4hL on Silverhead Crossing
20140320 00:36:53< iceiceice> gfgtdf: maybe you can try to cherry pick some of these commits out of your pull request? it seems like some of them fix separate bugs / are unrelated
20140320 00:37:34< gfgtdf> iceiceice: which do you mean ?
20140320 00:37:58< gfgtdf> EliDupree: how did you get that error ?
20140320 00:38:01-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140320 00:38:04< iceiceice> does this bug apply to current master or only your branch?
20140320 00:38:04< iceiceice> https://github.com/gfgtdf/wesnoth-old/commit/a5bce48025ccd745452cadfd35901eedf0b492da
20140320 00:38:29< EliDupree> gfgtdf: I did a lot of things. It came in the turn refresh event at the beginning of turn 2 for the host.
20140320 00:38:49< EliDupree> So, it might be as simple as "end two turns"
20140320 00:39:37< gfgtdf> iceiceice: hmm i havent tested that bug also happens without my patch
20140320 00:39:49< EliDupree> Ooh... it's frozen with side 3's flag showing
20140320 00:40:21< iceiceice> ok nm
20140320 00:41:58< RiftWalker> question: is there any reason why config assignment operator shouldn't be copy-and-swap? the current implementation doesn't look strongly exception safe.
20140320 00:42:14< EliDupree> gfgtdf: yup it's that simple. Run that era on that map, end turn twice.
20140320 00:44:41< gfgtdf> EliDupree: maybe you clicked "End turn " too fast ?
20140320 00:45:06< EliDupree> What, are you reproducing it by clicking end turn very fast? because I didn't
20140320 00:45:50< gfgtdf> no it was just my first thought that you clicked "end_turn" while the game waits for rome relote data.
20140320 00:46:03< EliDupree> that's definitely not it
20140320 00:46:10< gfgtdf> there are currently some bugs that buttons arent greyed out when they should be
20140320 00:49:20< iceiceice> Riftwalker: i think you are right, i dont know why it isn't copy and swap
20140320 00:50:09< gfgtdf> EliDupree: i get a error un side 2 ather it clicked end turn.
20140320 00:50:13< gfgtdf> an
20140320 00:51:18< EliDupree> Yeah, that's the same as what I'm getting
20140320 00:51:35< EliDupree> I don't know if it was really the host the first time, I might have misremembered
20140320 00:55:57-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: ancestral]
20140320 00:56:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140320 00:57:17-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev
20140320 01:06:27< gfgtdf> AI0867: online ?
20140320 01:12:01< gfgtdf> wesbot: seen AI0867 
20140320 01:12:01< wesbot> gfgtdf: Queried user last spoke 3h 5m ago.  AI0867 is currently here and on the channels #wesnoth-de and #wesnoth-umc-dev.
20140320 01:15:13< iceiceice> question about modifications: i'm noticing that in save files / replays from games i create in 1.13, the options from modifications that are inactive are still present in [multiplayer]->[options]
20140320 01:15:36< iceiceice> is there a reason why those should be there/
20140320 01:15:56< iceiceice> ideally if a modification is inactive the savefiles and replays we get should be the same as if it wasn't installed
20140320 01:16:08< gfgtdf> iceiceice: i noticed that same but didnt thought about it, but i agree with you
20140320 01:18:27< gfgtdf> wesbot: seen AI0867
20140320 01:18:27< wesbot> gfgtdf: Queried user last spoke 3h 12m ago.  AI0867 is currently here and on the channels #wesnoth-de and #wesnoth-umc-dev.
20140320 01:19:15< gfgtdf> AI0867 or anyone else: how exactly does this work: 0f3ef4dd759c0cd82acd0ef76e216c2264319cd4especialy when/how is handle_generic_event
20140320 01:20:30-!- Aishiko_laptop [~unknown@2606:a000:bcc1:2b00:226:5eff:fe65:125c] has quit [Ping timeout: 265 seconds]
20140320 01:22:40< AI0867> gfgtdf: kinda
20140320 01:23:06< gfgtdf> hm what is teh function that cakks 0f3ef4dd759c0cd82acd0ef76e216c2264319cd4? one of the ai_ events ?
20140320 01:23:53< AI0867> you really need a better keyboard =P
20140320 01:24:20< AI0867> what is your question about [end_turn]?
20140320 01:25:05< AI0867> iceiceice: I doubt it, it's probably just an oversight
20140320 01:25:40< gfgtdf> in taht patch you add code in playsinple_controller::handle_generic_event, and i wanted to ask when that is called.
20140320 01:25:53< gfgtdf> ti thwow the end_turn_execeotion
20140320 01:25:57< gfgtdf> s/ti/to
20140320 01:27:03< iceiceice>  RiftWalker: if you want to make a pull request to fixup the config copy constructor, anyone who has pushed changes to config.cpp might be a good person to review / commit, if you check with them
20140320 01:27:38< iceiceice> https://github.com/wesnoth/wesnoth/commits/master/src/config.cpp
20140320 01:28:57< AI0867> gfgtdf: event::generic_event objects invoke that on their listeners
20140320 01:29:35< AI0867> s/listeners/observers/
20140320 01:30:56< gfgtdf> AI0867: i know but i wanted to know wich call to "notify_observers()" that is suppsed to cause "throw end_turn_expection" after the wml event that contain the [end_turn] is  done.
20140320 01:32:05< RiftWalker> iceiceice: Thanks. I'll do that. I'm also looking at simplifying the cleanup, and possibly the copying, by converting the composite structure to use smart pointers of some kind.
20140320 01:35:06< AI0867> gfgtdf: I don't know which one does it, I'd have to look that up
20140320 01:35:10< AI0867> or ask a debugger
20140320 01:35:37< gfgtdf> AI0867: hm ok
20140320 01:38:38-!- daniwa [415ee84d@gateway/web/cgi-irc/kiwiirc.com/ip.65.94.232.77] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
20140320 01:38:54-!- bagzie [~bag@85-76-83-95-nat.elisa-mobile.fi] has quit []
20140320 01:41:51-!- stikonas__ [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Quit: Konversation terminated!]
20140320 01:45:31-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 264 seconds]
20140320 01:46:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140320 01:49:34-!- mjs-de [~mjs-de@f048001216.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140320 01:51:52-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20140320 01:54:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140320 02:05:58< gfgtdf> EliDupree:   i pushed a commit that might fix the issue
20140320 02:10:48< gfgtdf> EliDupree: ^
20140320 02:10:59< EliDupree> saw it
20140320 02:11:09< EliDupree> multitasking also
20140320 02:12:51< EliDupree> Wow, I just found a way to segfault GDB
20140320 02:12:57< EliDupree> Totally unrelated to this issue
20140320 02:13:18< iceiceice> O_o
20140320 02:13:20< EliDupree> Start it, forward-delete, then tab
20140320 02:13:51< iceiceice> what does forward-delete mean
20140320 02:13:51< gfgtdf> how do i make that smiley ?
20140320 02:14:29< iceiceice> EliDupree: i can't reproduce
20140320 02:14:35< EliDupree> huh
20140320 02:14:45< iceiceice> gfgtdf: what do you mean
20140320 02:15:02< iceiceice> what command lines did you start with?
20140320 02:15:32< gfgtdf> chatzilla converts  O_o to a siley
20140320 02:15:54< gfgtdf> smiley
20140320 02:16:04< iceiceice> ohh
20140320 02:16:26< EliDupree> gfgtdf: this issue looks fixed! :)
20140320 02:16:30< iceiceice> 8) 8) 8)
20140320 02:17:34< EliDupree> iceiceice: Uh, different keys, one normally deletes the character before the cursor and one normally deletes the character after the cursor
20140320 02:17:44< EliDupree> often they're labeled "backspace" and "delete" respectively
20140320 02:17:58< EliDupree> "forwarad-delete" refers to the latter
20140320 02:18:03< iceiceice> ok i coudlnt reproduce using either keys, with "gdb" or "gdb wesnoth"
20140320 02:18:24< EliDupree> ok might be a version difference or terminal difference or something
20140320 02:18:34< EliDupree> I could use a different terminal emulator
20140320 02:19:25< EliDupree> reproduced it in a different one
20140320 02:19:40< EliDupree> with both gdb and gdb ./wesnoth
20140320 02:19:49< iceiceice> chris@chris-KLR650 ~/wesnoth-src/clone/wesnoth-old $ gdb -v
20140320 02:19:49< iceiceice> GNU gdb (GDB) 7.6.1-ubuntu
20140320 02:20:20< EliDupree> GNU gdb (GDB) 7.6.2 (Debian 7.6.2-1)
20140320 02:20:40< iceiceice> thats kind of weird, you would think mine would have the bug also
20140320 02:20:49< EliDupree> well it's a different version
20140320 02:20:55< EliDupree> bug introduced in 7.6.2?
20140320 02:21:36-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 02:22:44< iceiceice> i guess its possible
20140320 02:25:59-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140320 02:29:13-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 246 seconds]
20140320 02:39:51-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140320 02:46:00< iceiceice> shadowm: question about bug #21267
20140320 02:46:09< iceiceice> do we know if it affects all previous wesnoth versions?
20140320 02:53:27< gfgtdf> iceiceice: i didnt kow there are private bugs 
20140320 02:53:37< gfgtdf> iceiceice: are there a lot private bugs ?
20140320 02:53:50< iceiceice> i have no idea, i didnt realize there were private bugs
20140320 02:54:39< gfgtdf> bug #21267 the one yoou just mentioned
20140320 02:55:00< iceiceice> i think its just because its rated higher than "blocker" it isn't displayed unless you are logged in?? not sure
20140320 02:58:07< gfgtdf> 	EliDupree	: online ?
20140320 02:58:15< EliDupree> yeah
20140320 02:58:52< gfgtdf> EliDupree: have you found any other bugs? otherwise i'd try to sync end_turn
20140320 02:59:19< EliDupree> Other than the ability filter, I don't think so
20140320 02:59:24< EliDupree> syncing end turn will be good
20140320 03:04:41< shadowm> gfgtdf, iceiceice: Yes, private bugs exist.
20140320 03:05:08< shadowm> The bug filing form has a field to control that.
20140320 03:05:26< shadowm> iceiceice: Why would it matter whether it affects < 1.6?
20140320 03:05:53< iceiceice> because it might point us to what the problem code is
20140320 03:06:04< iceiceice> if the whole simple_wml framework is bugged that would be one thing
20140320 03:06:22< iceiceice> if theres just some minor pointer mistake with games / players it would be something different
20140320 03:07:23< shadowm> Soliton might know whether it affected 1.4 and earlier. Nowadays we only run the versions mentioned in the report, so I don't know.
20140320 03:12:36-!- Ivanovic_ [~ivanovic@x2f47074.dyn.telefonica.de] has joined #wesnoth-dev
20140320 03:15:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 246 seconds]
20140320 03:15:51-!- Ivanovic_ [~ivanovic@x2f47074.dyn.telefonica.de] has quit [Changing host]
20140320 03:15:51-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140320 03:16:43< gfgtdf> is there a reason against boost lexiacal_cast ?
20140320 03:16:44-!- Ivanovic_ is now known as Ivanovic
20140320 03:35:35< gfgtdf> EliDupree: ready to pull
20140320 03:35:49< EliDupree> gfgtdf: side turn end sync? :)
20140320 03:36:10< gfgtdf> side turn end, turn end and similar
20140320 03:40:16< iceiceice> Soliton: i think there is a contradiction between the server code in this block: https://github.com/wesnoth/wesnoth/blob/master/src/server/game.cpp#L478
20140320 03:40:23< iceiceice> and the line that i commented out which was making everything "human"
20140320 03:40:42< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/server/game.cpp#L199
20140320 03:42:54< gfgtdf> current_side() can be 4 in a 3 player scenario  ?  o_O
20140320 03:43:28< iceiceice> is there a hidden side or smth?
20140320 03:44:04< gfgtdf> no: but its during teh execution of "end turn" in a replay
20140320 03:44:45< iceiceice> sounds suspicious
20140320 03:44:53< gfgtdf> iceiceice	: during teh actual game it was not 4
20140320 03:45:37< gfgtdf> iceiceice: it's 2p Silverhead crossing 
20140320 03:46:13< EliDupree> gfgtdf: yup, seems to be working :)
20140320 03:46:45< gfgtdf> EliDupree: can you save it and try to replay localy ?
20140320 03:46:52< EliDupree> ok
20140320 03:47:49< EliDupree> Same behavior in replay :)
20140320 03:50:12< gfgtdf> worked in replay ?
20140320 03:50:31< gfgtdf> wesnoth: seen anonimus
20140320 03:51:11< gfgtdf> EliDupree:
20140320 03:51:14< gfgtdf> ^
20140320 03:55:19< gfgtdf> EliDupree: same behaviour = no errors ?
20140320 03:56:22< EliDupree> yes
20140320 03:57:11< gfgtdf> i got a meas side == 4 assertoion error when i try
20140320 03:57:13< gfgtdf> mean
20140320 03:57:19< EliDupree> odd
20140320 03:59:27< gfgtdf> EliDupree: i thin i found this issue; this code calls obviously finish_turn with an invalid side: https://github.com/wesnoth/wesnoth/blob/master/src/replay_controller.cpp#L436
20140320 04:01:03< gfgtdf> its  like if (side_is_too_high) then fire_end_turn() end :/
20140320 04:03:32-!- incredible [~incredibl@14.139.122.114] has joined #wesnoth-dev
20140320 04:09:52-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 04:13:30< iceiceice> Anonymissimus: if you are thinking to use controller types of sides in the game to determine if a side is AI or not, because of changes that i made, you should perhaps think twice because it wont work in replays from the replay server, unless we make more changes
20140320 04:14:30-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140320 04:15:04< gfgtdf> iceiceice: couldnt Anonymissimus simply put his code into "wesnoth.synchronize_choice " ?
20140320 04:15:40< gfgtdf> iceiceice: but controller.empty() still works in replays ?
20140320 04:17:05< gfgtdf> EliDupree: do you think we can merge that patch to 1.13 master?
20140320 04:17:23< EliDupree> hmm?
20140320 04:17:40< gfgtdf> idk wether i should wait more :s
20140320 04:18:00< EliDupree> Oh,  you mean do I think all this stuff is stable/ non-buggy enough?
20140320 04:18:07< RiftWalker> fedrin_: Would you mind reviewing my pull request?
20140320 04:18:30< gfgtdf> yes
20140320 04:18:32< iceiceice> fendrin_: ^
20140320 04:18:43< RiftWalker> ah thanks
20140320 04:18:47< iceiceice> gfgtdf: i guess you are right about that
20140320 04:19:22< EliDupree> well... this isn't going to be so nice, but: You messed with the sync stuff. That probably produces a bajillion bugs that will just keep showing up in weird places. You also probably fixed a whole bunch of bugs that show up in weird places
20140320 04:19:36< EliDupree> I've only tracked all the bugs that I could easily track based on what I know right now.
20140320 04:20:04< iceiceice> EliDupree: the question is what is the chance that there is now a severe enough bug that it woudl be a blocker
20140320 04:20:18< EliDupree> I can't estimate that
20140320 04:21:48< iceiceice> gfgtdf: i'm not really sure if controller.empty() worked in server replays, but i it did before it still does i think
20140320 04:21:59-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20140320 04:22:10< EliDupree> and, I'm not available this evening to do a bunch of thorough testing beyond what I've done so far
20140320 04:23:02< gfgtdf> iceiceice: do you know who has access to the wesnothd server?
20140320 04:23:31< iceiceice> you mean the main server?
20140320 04:23:37< gfgtdf> yes
20140320 04:23:47< iceiceice> afaik Soliton and shadowm
20140320 04:24:05< gfgtdf> hm ok
20140320 04:24:09-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140320 04:24:11< shadowm> What for?
20140320 04:24:46< gfgtdf> gfgtdf: my patch contains changes to the server, and i just wanted to know wether they are treated specialy or something
20140320 04:25:07< shadowm> I don't know why you are talking to yourself, but...
20140320 04:25:11< iceiceice> lol
20140320 04:25:32< shadowm> They are treated specially in that someone has to rebuild and restart the server afterwards, but that's it.
20140320 04:25:36< gfgtdf> i had teh wrong name in copypaste
20140320 04:25:38< shadowm> And if you break it we fry you alive.
20140320 04:26:29< gfgtdf> shadowm: hm i break compability with older versions, is that what you mean ?
20140320 04:26:46-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140320 04:26:47< shadowm> No, any form of unexpected breakage.
20140320 04:27:07< shadowm> It wouldn't be nice if the server started randomly segfaulting, to give an example!
20140320 04:27:53< shadowm> Hopefully you don't need to make backwards-incompatible changes in 1.12.
20140320 04:28:18< shadowm> Otherwise those: 1) can't happen after RC 1; and 2) can't go live before the next release.
20140320 04:28:52< gfgtdf> what is RC  ?
20140320 04:29:02< shadowm> Release Candidate.
20140320 04:29:19< gfgtdf> do we already have release candidate ?
20140320 04:29:27< shadowm> No, the last release is beta 2.
20140320 04:29:42< gfgtdf> hm then i have no problems with that conditions
20140320 04:30:34< gfgtdf> shadowm: i just noticed i didnt even delete the old code, so no the server should be backwards compatible
20140320 04:30:55-!- sachith500 [~kvirc@112.134.141.45] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140320 04:31:34< gfgtdf> shadowm: it's easy as that: not deleting old code => backward compability :)
20140320 04:31:42< gfgtdf> in this case
20140320 04:31:58-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has joined #wesnoth-dev
20140320 04:32:33< gfgtdf> shadowm: could you please take a look at the server code ? in https://github.com/wesnoth/wesnoth/pull/121/files
20140320 04:32:36< shadowm> Backwards compatibility in terms of old clients not crashing/running around like headless chickens, I mean.
20140320 04:33:51< shadowm> The SConscript diff looks weird, like there's an indentation format mismatch.
20140320 04:34:00< gfgtdf> yes that doesn't happen.
20140320 04:34:21< gfgtdf> hm true, i think i used tabs in SConscript file.
20140320 04:35:29< shadowm> I'm not really familiarized with wesnothd's innards, but ehhhh, how do I put it...
20140320 04:36:02< shadowm> Those multiline comments really need some spellchecking and formatting cleanup.
20140320 04:36:39< shadowm> Also, last time I added a comment in the first person I got told off.
20140320 04:37:54< gfgtdf> shadowm: whoudl i say 'we' ?
20140320 04:37:57< gfgtdf> should*
20140320 04:38:35< shadowm> The block here looks like it should really have been deleted and the explanation given in the commit message, "but I don't know". https://github.com/wesnoth/wesnoth/pull/121/files#diff-548cdebed1445f1147e1e9d2d227b4c0R746
20140320 04:38:53< shadowm> As I said, I'm not familiarized with wesnothd's innards, so I'm not the best person to look at this.
20140320 04:39:11< _8680_> Comments aren’t allowed to be written in the first person?
20140320 04:39:40< shadowm> https://github.com/wesnoth/wesnoth/pull/121/files#diff-548cdebed1445f1147e1e9d2d227b4c0R950 <- Is this the expected way to use simple_wml? When does that memory get released?
20140320 04:41:44< gfgtdf> shadowm: hmm i dont realy know, about simple_wml (thats whjy i asked you to look over it)  i though as soon as i dont add anything to a list or use new i dont have to care about memory.
20140320 04:42:06< shadowm> But you are using new, so... and so does other code.
20140320 04:42:23< _8680_> In the context of the Battle for Wesnoth sourcebase, would it be reasonable for bit-fiddly functions, intended to operate on standard fundamental integers, to be defined only for unsigned integers, and not for signed integers?
20140320 04:43:01< shadowm> I give up. I clearly have no idea what I'm doing.
20140320 04:43:14-!- incredible [~incredibl@14.139.122.114] has quit [Read error: Connection reset by peer]
20140320 04:43:56< gfgtdf> shadowm: oh true, 
20140320 04:44:40< shadowm> server/game.cpp in pristine master is full of naked pointer instantiations of simple_wml::document with new sans one.
20140320 04:44:47< gfgtdf> shadowm: i think i just copied from somewhere
20140320 04:45:01< shadowm> So it's probably intended.
20140320 04:45:24< gfgtdf> i add it to hitsory_ later whcih is of type vector<wml_document*>
20140320 04:45:38< gfgtdf> in record_data.
20140320 04:45:50< shadowm> Ah, clear_history() releases the simple_wml::document() instances registered with record_data(), yes.
20140320 04:47:16< shadowm> intf_is_synced() in scripting/lua.cpp has an incorrect copy-paste leftover at the start of the documentation block.
20140320 04:47:33< shadowm> Also a typo right afterwards.
20140320 04:48:11< shadowm> The newly added files have a license block but no copyright statement.
20140320 04:48:53< gfgtdf> shadowm: you'll find a lot typos if you search them :o, what is the difference between license block and copyright statement
20140320 04:49:49< shadowm> You generally have the copyright statement in the license block; it's the "Copyright (C) YEARS by John Foo <john.foo@example.com>" line.
20140320 04:50:26< shadowm> In some projects you may be required to assign the copyright to a specific person or organization but here people assign copyright to themselves and get away with it so...
20140320 04:51:06< shadowm> src/boilerplate-header.cpp provides an example where the copyright is assigned to Dave.
20140320 04:51:20< shadowm> Which made sense back when he was active, I guess, not so much nowadays.
20140320 04:51:49< RiftWalker> shadowm: would you mind reviewing my pull request?
20140320 04:52:45< gfgtdf> shadowm: you know who is expert for server code ?
20140320 04:54:37< shadowm> gfgtdf: Perhaps Soliton, otherwise there's probably nobody who understands it for sure! :D
20140320 04:56:29< shadowm> RiftWalker: I'm afraid I only fully understand the tabs commit. The rest escapes me.
20140320 04:58:03< RiftWalker> shadowm: Who might I contact for general STL expertise?
20140320 05:00:17< shadowm> Everyone but me, probably. I mean, it's not that I can't use the STL in general, it's just that I'm not familiarized with inserters.
20140320 05:01:39< RiftWalker> Ah, okay. Thanks anyway!
20140320 05:01:39-!- incredible [~incredibl@14.139.122.114] has joined #wesnoth-dev
20140320 05:02:06< gfgtdf> retv["new_seed"] = rand();//TODO: some rand() call 
20140320 05:02:07< gfgtdf> the TODO was already done very successfuly :)
20140320 05:02:48< gfgtdf> im off bb
20140320 05:02:55-!- gfgtdf [~chatzilla@f054138065.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 27.0.1/20140212131424]]
20140320 05:02:59< shadowm> RiftWalker: About the last commit <https://github.com/Rift-Walker/wesnoth/commit/923519d75ad30debefa683b3567ee9448f6396b0>: from what I gather, the config copy constructor can also throw an exception since it calls append_children(), so...
20140320 05:04:16< shadowm> The temporary config's destructor will call clear() on the original data too.
20140320 05:06:02< RiftWalker> shadowm: The idea here, with strong exception safety, isn't that the code won't throw at all, but that if it does, the data won't be affected. If the copy constructor throws, our config object isn't affected. In the previous code, let's say append_children throws an exception. We may want to handle that exception and continue, but we've already called clear. Our config is left empty.
20140320 05:07:34< shadowm> Ahh, right.
20140320 05:07:38< RiftWalker> And if we're assigning in this manner, we expect the destructor to clean up our old data.
20140320 05:16:01-!- RiftWalker [~nathan@129.59.115.25] has quit [Ping timeout: 240 seconds]
20140320 05:24:51-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20140320 05:25:25-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev
20140320 05:27:53-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has quit [Quit: Page closed]
20140320 05:39:03< iceiceice> gfgtdf: do you know if the new synchronize choice stuff will work on in replays generated by the server?
20140320 05:46:02-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140320 05:46:17-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 05:51:20-!- exciton_ [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 05:52:08-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20140320 05:53:38-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds]
20140320 05:55:03-!- exciton_ [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140320 05:55:30-!- RiftWalker [~nathan@129.59.115.25] has joined #wesnoth-dev
20140320 05:56:17-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 05:58:02-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 05:58:58-!- RiftWalker [~nathan@129.59.115.25] has quit [Client Quit]
20140320 05:59:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 255 seconds]
20140320 06:00:03-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140320 06:01:17-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 06:02:25-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140320 06:03:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140320 06:10:19-!- exciton_ [chuck-the-@95.73.255.101] has joined #wesnoth-dev
20140320 06:14:08-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds]
20140320 06:15:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140320 06:18:23-!- irker102 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20140320 06:43:49-!- beginteam [~beginteam@121.34.123.253] has joined #wesnoth-dev
20140320 06:47:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140320 06:59:32-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140320 07:09:36-!- exciton_ [chuck-the-@95.73.255.101] has quit [Read error: Connection reset by peer]
20140320 07:09:50-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 07:14:59-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 240 seconds]
20140320 07:33:38-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds]
20140320 07:34:08< iceiceice> Soliton: i coded up the "move tweaks to server" and some other things. haven't tested yet but please review at your leisure: https://github.com/wesnoth/wesnoth/pull/123
20140320 07:35:18-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 07:43:11-!- incredible [~incredibl@14.139.122.114] has quit [Read error: Connection reset by peer]
20140320 07:46:20-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 07:50:03-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140320 07:50:08-!- Gallaecio [~quassel@84.120.113.48.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
20140320 07:50:17-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 07:51:06-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140320 07:51:55-!- ykanarev [~ykanarev@212.55.118.222] has joined #wesnoth-dev
20140320 07:53:05-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140320 07:57:05-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140320 07:58:56-!- sachith500_ [70873438@gateway/web/freenode/ip.112.135.52.56] has joined #wesnoth-dev
20140320 08:03:15-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140320 08:04:08-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds]
20140320 08:05:19-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 08:24:00< Ivanovic> @gsoc students: make sure to submit your proposals to google ASAP!
20140320 08:24:22< Ivanovic> there will be no deadline extensions and those proposals not in google-melange can not be selected as project for gsoc 2014
20140320 08:25:23< Ivanovic> i see a larger number of proposals in the wiki then submitted to google
20140320 08:25:35< Ivanovic> so if you want to be in, submit to google!
20140320 08:26:01< Ivanovic> do not try to just get this done the last 5min, then you might fail since several steps are required for this like uploading your proof of enrollment
20140320 08:27:36< ykanarev> Ivanovic, is it real to update proposal after deadline if I already post it?
20140320 08:27:48< Ivanovic> yes, you can always update the wiki page!
20140320 08:28:01< Ivanovic> and you can update the google page at least until the deadline is reached
20140320 08:28:18< Ivanovic> so what you should do is: submit to google with a link to your page in our wiki
20140320 08:28:20< Ivanovic> that is *fine*
20140320 08:28:40< Ivanovic> you just need to be in the google tracker, otherwise we are not allowed to accept the proposal as gsoc project
20140320 08:28:53< ykanarev> ok. I did it. thanks.
20140320 08:30:14< sachith500_> Ivanovic it's already there :)
20140320 08:30:28< Ivanovic> sachith500_: yes, your proposal is in there
20140320 08:30:38< Ivanovic> but the proposal from several other students is not
20140320 08:30:41< sachith500_> all right :D
20140320 08:30:53< sachith500_> hmm I think there was another student interested in my idea
20140320 08:30:58< Ivanovic> i see 19 proposals in the wiki and only 12 at google melange
20140320 08:30:59< sachith500_> but I've never seen him on IRC
20140320 08:31:06< sachith500_> some of them have incomplete wiki pages
20140320 08:31:13< sachith500_> they probably won't be applying
20140320 08:31:34< ykanarev> I see more than 5 wiki pages about AI. Is one student for one task?
20140320 08:31:56< Ivanovic> or they might be just one hour late with submitting to google, missing the deadline and ask for an extension of the deadline which does not happen
20140320 08:32:05< Ivanovic> (stuff like this happens every year...)
20140320 08:32:06< sachith500_> yeah that too
20140320 08:32:09< sachith500_> really?
20140320 08:32:25< sachith500_> well It's actually quite simple to just add a link to the wiki page
20140320 08:32:29< sachith500_> I mean, come on.
20140320 08:32:32< Ivanovic> sachith500_: not necessarily for us, but there are many students saying "but we expected a deadline extension"
20140320 08:32:37< sachith500_> ahh
20140320 08:32:43< sachith500_> I see
20140320 08:32:46< Ivanovic> or "but the server did not work 2min before the deadline"
20140320 08:32:51< sachith500_> I guess university habits die hard :P
20140320 08:32:55< Ivanovic> or "my internet connection was broken 3min before the deadline"
20140320 08:33:05< Ivanovic> none of those will work to get the application in late
20140320 08:33:09< sachith500_> yeah
20140320 08:33:18< sachith500_> I've noticed how strict they are
20140320 08:33:22< sachith500_> I guess it makes sense
20140320 08:33:23< Ivanovic> nothing is stopping the students from at least writing "i want to do something" on the very first day
20140320 08:33:35< sachith500_> yup
20140320 08:33:45< sachith500_> I made sure to upload it within the day ^^
20140320 08:34:04< Ivanovic> that is already enough to be in the tracker, if there is no enough we will make sure to ask for more once we get to reviewing what was submitted
20140320 08:34:16< sachith500_> true
20140320 08:34:36< ykanarev> Ivanovic, I think it is not a good tactic(about "i want to do something").
20140320 08:34:55< sachith500_> ykanarev it's still better than coming late
20140320 08:35:05< sachith500_> they can have the stuff on wiki
20140320 08:35:10< sachith500_> and do something
20140320 08:35:22< sachith500_> past march 21 orgs can't do anything
20140320 08:35:42< sachith500_> to get new students
20140320 08:35:57< Ivanovic> ykanarev: if you submit sometihng close to empty on the first day and then, for the rest of the application time, work on improving it there is no problem at all
20140320 08:36:12< Ivanovic> ykanarev: noone will complain about the first submission being a placeholder
20140320 08:36:31< Ivanovic> on the other hand if you polish your application over weeks and are just 1min late with submitting there is no way to get in
20140320 08:36:40< Ivanovic> yes, even one second late means you are not in
20140320 08:37:02< Ivanovic> there is a reason why we clearly write on our wiki page that it has to be in the google tracker
20140320 08:39:12< ykanarev> I mean, spend some time and make first version of proposal more complete is better than "want to do something". But late is worse, of course
20140320 08:40:28< Ivanovic> ykanarev: honestly, what is bad about having a first submission to google which is only "placeholder"?
20140320 08:40:37< Ivanovic> we as mentoring org have no problem at all with this!
20140320 08:41:05< sachith500_> ykanarev it's supposed to be edited anyway
20140320 08:41:13< sachith500_> if google wanted a final proposal uploaded at first
20140320 08:41:17< sachith500_> they'd not allow it to be edited
20140320 08:41:19< ykanarev> Ok, it's only my opinion.
20140320 08:42:44< sachith500_> First Impressions are important, but not at the cost of potentially losing out on the project :P
20140320 08:48:28-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140320 08:51:20< Ivanovic> in the end our "first impression" is not the text submitted to google, it is how you interact in here
20140320 08:51:29< Ivanovic> since this is usually our main communication chanel
20140320 08:51:49< ykanarev> @Ivanovic, what if some students propose same task? Is it real they will be chosen?
20140320 08:52:22< Ivanovic> either only one of them is chosen or we work with them to make sure that the proposals can be worked on in parallel
20140320 08:52:36< Ivanovic> but we will not have 100% duplicate proposals accepted as project
20140320 08:52:42< Ivanovic> this is basically the same every year
20140320 08:53:32< sachith500_> it's messy to have mutliple students work on the same code
20140320 08:53:40< sachith500_> so many conflicts >.>
20140320 08:53:50< Ivanovic> sachith500_: that is why we will not have exactly the same project twice
20140320 08:53:51< ykanarev> ok, thanks. Need to invent something cool in AI task)
20140320 08:53:54< sachith500_> yeah
20140320 08:53:55< sachith500_> :D
20140320 08:53:56< Ivanovic> besides: commit early, commit often
20140320 08:53:59< Ivanovic> ;)
20140320 08:54:02< sachith500_> ;D
20140320 08:54:19< sachith500_> I actually meant to have an AI proposal too
20140320 08:54:29< sachith500_> so you guys could pick me (if at all) for the project you liked
20140320 08:54:36< sachith500_> but no one showed up for my project
20140320 08:54:40< sachith500_> so I decided not to :P
20140320 08:56:21< iceiceice> wesbot: bug #21759
20140320 08:56:21< wesbot> Bug #21759  Assigned to: None  Status: None  Priority: 5 - Normal
20140320 08:56:21< wesbot> Summary: timer refreshed too often when time runs out
20140320 08:56:21< wesbot> Original submission: When time runs out the timer bonus is given two times; ev
20140320 08:56:24< wesbot> en worse when there's still a random number coming from the server, timer bonus 
20140320 08:56:27< wesbot> URL: http://gna.org/bugs/?21759
20140320 08:56:57< iceiceice> Duthlet, in the bug report you suggested a fix,
20140320 08:57:13< iceiceice> why don't you just make a pull request?
20140320 09:05:13-!- sachith500_ [70873438@gateway/web/freenode/ip.112.135.52.56] has quit [Ping timeout: 245 seconds]
20140320 09:07:09< Duthlet> iceiceice: because I was told to report the bug, maybe I wasn't clear enough about having a fix
20140320 09:07:39< Soliton> it's fine to submit a bug report and make a pull request. ;-)
20140320 09:07:42< iceiceice> nothing wrong with doing both :)
20140320 09:08:47< Duthlet> ok, so if I make a pull request, do I have to make two, one for 1.12 and one for master?
20140320 09:08:49< iceiceice> if you make a PR you should title either the main commit or the PR itself with "fix bug #21759" 
20140320 09:09:39< iceiceice> i actually dont know the answer to that... i guess its the preference of whoever commits it
20140320 09:10:48< Soliton> i'd say make one for 1.12 and then it can get merged to master. we don't have a policy on how merges between branches should work now with git though...
20140320 09:14:04-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20140320 09:18:42-!- vernon [~quassel@catv-89-133-164-152.catv.broadband.hu] has joined #wesnoth-dev
20140320 09:19:06-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140320 09:21:47-!- Octalot [~noct@31.185.149.167] has joined #wesnoth-dev
20140320 09:21:51-!- bagzie [~bag@85-76-148-7-nat.elisa-mobile.fi] has joined #wesnoth-dev
20140320 09:22:33-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140320 09:25:44-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140320 09:26:59-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20140320 09:27:27-!- mjs-de [~mjs-de@f048101121.adsl.alicedsl.de] has joined #wesnoth-dev
20140320 09:32:22-!- vorobeez [558e9494@gateway/web/freenode/ip.85.142.148.148] has joined #wesnoth-dev
20140320 09:33:11-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140320 09:34:27-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 09:38:46-!- sachith500 [~kvirc@112.135.52.56] has joined #wesnoth-dev
20140320 09:39:13-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20140320 09:39:19-!- Octalot [~noct@31.185.149.167] has quit [Ping timeout: 265 seconds]
20140320 09:39:42-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140320 09:46:26-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 09:49:23-!- vorobeez [558e9494@gateway/web/freenode/ip.85.142.148.148] has quit [Ping timeout: 245 seconds]
20140320 10:11:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140320 10:22:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140320 10:26:29-!- stikonas [~gentoo@maths-pgs-002.maths.ed.ac.uk] has joined #wesnoth-dev
20140320 10:26:29-!- stikonas [~gentoo@maths-pgs-002.maths.ed.ac.uk] has quit [Changing host]
20140320 10:26:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140320 10:36:17-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140320 10:54:47-!- vernon [~quassel@catv-89-133-164-152.catv.broadband.hu] has quit [Read error: Connection reset by peer]
20140320 11:14:32-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140320 11:22:04-!- sachith500 [~kvirc@112.135.52.56] has quit [Read error: Connection reset by peer]
20140320 11:22:29-!- beginteam [~beginteam@121.34.123.253] has quit [Quit: leaving]
20140320 11:34:12-!- Octalot [~noct@31.185.149.167] has joined #wesnoth-dev
20140320 11:41:33-!- Kevin_Xi [~kevin@223.72.182.158] has joined #wesnoth-dev
20140320 12:02:51-!- sachith500 [~kvirc@112.135.52.56] has joined #wesnoth-dev
20140320 12:16:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140320 12:37:23-!- sachith500 [~kvirc@112.135.52.56] has quit [Read error: Connection reset by peer]
20140320 12:44:13-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has joined #wesnoth-dev
20140320 12:58:36-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140320 12:59:14-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 12:59:15-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has joined #wesnoth-dev
20140320 12:59:22-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has quit [Changing host]
20140320 12:59:22-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140320 13:01:50-!- Kevin_Xi [~kevin@223.72.182.158] has quit [Ping timeout: 265 seconds]
20140320 13:03:29-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140320 13:24:59-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140320 13:25:13-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140320 13:31:37-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer]
20140320 14:01:58-!- Aishiko_laptop [~unknown@198.85.71.253] has joined #wesnoth-dev
20140320 14:02:30-!- Kevin_Xi [~kevin@223.72.182.158] has joined #wesnoth-dev
20140320 14:08:15-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 14:08:57-!- gfgtdf [~chatzilla@f054138065.adsl.alicedsl.de] has joined #wesnoth-dev
20140320 14:13:27< gfgtdf> iceiceice: i havent tested the replays on teh server but i thought they have teh same content as the normal content ?
20140320 14:14:59< gfgtdf> EliDupree: I have found a another bug: http://pastebin.com/kS3cJMAb
20140320 14:19:12-!- spoffy [~spoffy@2001:630:d0:ed06:caf7:33ff:fe0a:4542] has joined #wesnoth-dev
20140320 14:19:38< gfgtdf> iceiceice: how can i get the replasy from teh server ?
20140320 14:19:53< gfgtdf> iceiceice: from a local instance i mean
20140320 14:25:23< Soliton> add the keys with replay in them as described in the man page to your server config file.
20140320 14:32:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140320 14:36:40-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has joined #wesnoth-dev
20140320 14:41:03-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has quit [Ping timeout: 245 seconds]
20140320 14:44:24< gfgtdf> Soliton: ok i added save_replays=false to the files userdata/lan_server.cfg, accoring to the man page the  replays should be defuault be placed in the direcory where wesnothd was sarted but i cannot find them there
20140320 14:44:53-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140320 14:45:13< Soliton> try with save_replays=true...
20140320 14:45:30-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 14:46:34< gfgtdf> Soliton: i did save_replays=true, i just copied  it wrong on here.
20140320 14:47:21< Soliton> no idea then.
20140320 14:49:30-!- gfgtdf [~chatzilla@f054138065.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]]
20140320 14:49:59-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140320 14:57:03-!- RiftWalker [~nathan@129.59.115.25] has joined #wesnoth-dev
20140320 14:58:07< RiftWalker> lipkab: Would you mind reviewing my pull request?
20140320 15:07:08-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Operation timed out]
20140320 15:07:15-!- Espreon [~espreon@wesnoth/developer/espreon] has quit [Read error: Operation timed out]
20140320 15:15:16-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140320 15:17:48-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140320 15:18:42-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has joined #wesnoth-dev
20140320 15:19:13-!- Espreon [~espreon@ai0867.net] has joined #wesnoth-dev
20140320 15:19:36-!- Espreon is now known as Guest22113
20140320 15:20:35-!- RiftWalker [~nathan@129.59.115.25] has quit [Quit: Leaving.]
20140320 15:27:10-!- sachith500 [~kvirc@112.135.52.56] has joined #wesnoth-dev
20140320 15:28:15< sachith500> It's strange, I was expecting more GSoC activity towards the end of the proposal period :P
20140320 15:30:46-!- Aishiko_laptop [~unknown@198.85.71.253] has quit [Ping timeout: 246 seconds]
20140320 15:31:53-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has quit [Ping timeout: 245 seconds]
20140320 15:32:23< sachith500> hey happygrue, Soliton, is there anything else I should do before the proposal close period?
20140320 15:36:13-!- sachith500|2 [~kvirc@112.135.194.51] has joined #wesnoth-dev
20140320 15:39:39-!- sachith500 [~kvirc@112.135.52.56] has quit [Ping timeout: 245 seconds]
20140320 15:45:25-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140320 15:46:10-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 15:47:41-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140320 15:50:54-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds]
20140320 15:54:27-!- ykanarev [~ykanarev@212.55.118.222] has quit [Quit: Leaving]
20140320 16:00:04-!- spoffy [~spoffy@2001:630:d0:ed06:caf7:33ff:fe0a:4542] has quit [Ping timeout: 245 seconds]
20140320 16:02:30-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20140320 16:08:20-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 16:08:32< happygrue> busy just now sachith500|2 I'll get back to you later today but nothing springs to mind just now.
20140320 16:08:52< sachith500|2> ok thanks
20140320 16:08:56< sachith500|2> I was just checking anyway :D
20140320 16:10:35-!- Aishiko_laptop [~unknown@198.85.71.253] has joined #wesnoth-dev
20140320 16:16:25-!- Aishiko_laptop [~unknown@198.85.71.253] has quit [Ping timeout: 240 seconds]
20140320 16:16:48-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140320 16:17:24-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 16:18:04-!- Aishiko_laptop [~unknown@198.85.71.253] has joined #wesnoth-dev
20140320 16:18:09-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer]
20140320 16:18:29-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 16:20:24-!- ALourenxo [c189db30@gateway/web/freenode/ip.193.137.219.48] has joined #wesnoth-dev
20140320 16:21:54-!- ALourenxo [c189db30@gateway/web/freenode/ip.193.137.219.48] has quit [Client Quit]
20140320 16:22:17-!- ALourenco [c189db30@gateway/web/freenode/ip.193.137.219.48] has joined #wesnoth-dev
20140320 16:24:29-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 241 seconds]
20140320 16:27:49-!- spoffy [~spoffy@dhcp-203-70.wireless.soton.ac.uk] has joined #wesnoth-dev
20140320 16:32:15-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140320 16:36:43-!- lipkab_ [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140320 16:36:55-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 265 seconds]
20140320 16:46:34-!- sachith500|2 [~kvirc@112.135.194.51] has quit [Read error: Connection reset by peer]
20140320 16:46:53-!- sachith500|2 [~kvirc@112.135.194.51] has joined #wesnoth-dev
20140320 16:47:04-!- lipkab_ [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 265 seconds]
20140320 16:47:35-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20140320 16:49:17-!- sachith500|2 [~kvirc@112.135.194.51] has quit [Read error: Connection reset by peer]
20140320 16:50:00-!- sachith500|2 [~kvirc@112.135.194.51] has joined #wesnoth-dev
20140320 16:50:25-!- sachith500|2 [~kvirc@112.135.194.51] has quit [Read error: Connection reset by peer]
20140320 16:50:44-!- sachith500|2 [~kvirc@112.135.194.51] has joined #wesnoth-dev
20140320 16:53:58-!- ALourenco [c189db30@gateway/web/freenode/ip.193.137.219.48] has quit [Ping timeout: 245 seconds]
20140320 16:54:04-!- spoffy [~spoffy@dhcp-203-70.wireless.soton.ac.uk] has quit [Ping timeout: 246 seconds]
20140320 17:00:45-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 0.4.1]
20140320 17:01:43-!- vorobeez [~firsov@85.142.148.12] has joined #wesnoth-dev
20140320 17:02:00-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20140320 17:02:00-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20140320 17:02:00-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20140320 17:05:37-!- sachith500|2 [~kvirc@112.135.194.51] has quit [Ping timeout: 240 seconds]
20140320 17:09:56-!- ALourenco [c189db30@gateway/web/freenode/ip.193.137.219.48] has joined #wesnoth-dev
20140320 17:12:26-!- vorobeez [~firsov@85.142.148.12] has quit [Quit: Leaving.]
20140320 17:17:17-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140320 17:17:54-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 17:22:18-!- ALourenco [c189db30@gateway/web/freenode/ip.193.137.219.48] has quit [Ping timeout: 245 seconds]
20140320 17:22:29-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140320 17:24:45-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140320 17:27:11-!- Aishiko_laptop [~unknown@198.85.71.253] has quit [Ping timeout: 265 seconds]
20140320 17:27:29-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140320 17:45:52-!- spoffy [~spoffy@dhcp-204-94.wireless.soton.ac.uk] has joined #wesnoth-dev
20140320 17:54:29-!- gus3000 [c1335331@gateway/web/freenode/ip.193.51.83.49] has joined #wesnoth-dev
20140320 17:55:03< gus3000> good morning / evening !
20140320 17:56:25< Soliton> greetings.
20140320 18:02:19< gus3000> I'm really annoyed : I would love to work on a game for the Google Summer of Code, and Battle for Wesnoth seems the perfect candidate, but I just discovered it so obviously I never commited anything on it (just played a little :p)
20140320 18:02:53< gus3000> Is there a way to show I will be able to work on it during 3 months this Summer ? Cause i can and really will !
20140320 18:04:10< Soliton> see http://wiki.wesnoth.org/SummerOfCodeIdeas
20140320 18:04:59< gus3000> yup, I was reading it :)
20140320 18:05:16< Soliton> important is that you apply to gsoc asap and then you still have some time to develop your proposal on our wiki and write some patches so we can see your coding skills etc.
20140320 18:06:52-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has joined #wesnoth-dev
20140320 18:07:05-!- Twooey [~Twooey@pool-108-16-205-233.phlapa.fios.verizon.net] has joined #wesnoth-dev
20140320 18:07:09< gus3000> glad to hear that, I feared that if my patches were after the gsoc deadline that wouldn't count :)
20140320 18:07:51< Soliton> also you can work all summer (or any other season) on wesnoth gsoc or no gsoc. ;-)
20140320 18:09:21< gus3000> haha that's true, but i'm even more motivated if it pays my rent :p
20140320 18:11:06 * Soliton nods.
20140320 18:12:36-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 18:14:32-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev
20140320 18:17:09-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds]
20140320 18:19:59-!- spoffy [~spoffy@dhcp-204-94.wireless.soton.ac.uk] has quit [Ping timeout: 240 seconds]
20140320 18:21:07< Twooey> Is there anything someone who is just learning to program can do to contribute to the project?
20140320 18:22:33< zookeeper> well, if you're willing to learn then sure
20140320 18:23:00< zookeeper> (...or if you want to do something other than code)
20140320 18:23:06< Twooey> I've been working my way through Bjarne Stroustrup's Programming Principles and Practice
20140320 18:23:47< Twooey> Been trying to find my way into coding for years, and this book just made sense
20140320 18:34:36-!- Gallaecio [~quassel@84.120.216.67.dyn.user.ono.com] has joined #wesnoth-dev
20140320 18:34:59-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has joined #wesnoth-dev
20140320 18:35:09< zookeeper> Twooey, unless you specifically want someone to name some tasks to do, you could just play the game a bit and see if you can spot something you could improve and then start messing with the code and learn as you go
20140320 18:36:01< Twooey> I've been playing it for years, but never from the aspect of thinking of what can be improved. I installed it again recently for the first time in a few years, and was amazed at how far it's come.
20140320 18:36:07< zookeeper> oh, right
20140320 18:36:37< Twooey> I don't think I'm at a point I can really do anything yet, still just learning. 
20140320 18:38:17-!- Twooey1 [~Twooey@pool-108-16-205-233.phlapa.fios.verizon.net] has joined #wesnoth-dev
20140320 18:38:18-!- Twooey [~Twooey@pool-108-16-205-233.phlapa.fios.verizon.net] has quit [Remote host closed the connection]
20140320 18:38:22< Dugi> Hello.
20140320 18:38:52< Dugi> fendrin_: Are you here, fabi?
20140320 18:40:57< zookeeper> Twooey, well i learned what little i know of c++ by just diving into a codebase and imitating existing code when i was in doubt, i don't think you really need to learn first and do then.
20140320 18:41:58-!- Kevin_Xi [~kevin@223.72.182.158] has left #wesnoth-dev []
20140320 18:45:11< Twooey1> I've been doing that more and more, finding something I don't understand, and googling
20140320 18:46:20-!- incredible [6add53ca@gateway/web/freenode/ip.106.221.83.202] has joined #wesnoth-dev
20140320 18:46:39-!- neXyon [~neXyon@85-127-242-206.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140320 18:47:03-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has quit [Quit: Page closed]
20140320 18:48:54-!- incredible_ [~incredibl@106.221.83.202] has joined #wesnoth-dev
20140320 18:49:11-!- incredible [6add53ca@gateway/web/freenode/ip.106.221.83.202] has quit [Client Quit]
20140320 18:54:19-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140320 18:56:58-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20140320 19:01:28< Crab_> to all summer of code students: hello! please note that we can only accept you if you make an application to Wesnoth in Google's Melange system (deadline is tomorrow, 21 March, 19 : 00 UTC )
20140320 19:02:30< Aishiko> hi Crab_, thank you for the heads up =)
20140320 19:03:05-!- gfgtdf [~chatzilla@f054138065.adsl.alicedsl.de] has joined #wesnoth-dev
20140320 19:03:14< Crab_> Aishiko: we can decide 'whom to pick' later and work to improve the proposals for a few more weeks, but getting the application in is important, even if it's a placeholder or a link to wiki.
20140320 19:03:57< Crab_> Aishiko: In the past, it happened that people had internet suddenly going down at the last possible moment. so it's better to submit something and then improve it, than risk trying to submit at the last possible moment.
20140320 19:03:58< Aishiko> mine's in, though I'm still not happy with it and I don't know if a blank intro of me is OK or not
20140320 19:04:40< Crab_> Aishiko: in a few days, once we'll know what application we'll have, we'll go over the list of application and try to talk to each of the students, so any questions can be resolved.
20140320 19:05:08-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20140320 19:05:08-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20140320 19:05:08-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140320 19:05:22< mordante> servus
20140320 19:05:50< Aishiko> Crab_, Okay, I'm following you.  I'm just getting swamped with schoolwork and want to do the best I can at both school and this.
20140320 19:07:19< Crab_> Aishiko: it's ok. you'll get email notifications if someone comments on your proposal in melange.
20140320 19:07:21< gfgtdf> hi 	mordante
20140320 19:07:28< mordante> hi gfgtdf 
20140320 19:08:50-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Remote host closed the connection]
20140320 19:09:06-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20140320 19:09:15-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20140320 19:11:38< Crab_> vorobeez: from lua state (in C++) you can get the C++ AI context for current side (there are C++ helper functions for this) and you can take srcdst from C++ function readonly_ai_context::get_srcdst()  from that C++ AI context.
20140320 19:11:59-!- Twooey1 [~Twooey@pool-108-16-205-233.phlapa.fios.verizon.net] has quit [Quit: Leaving]
20140320 19:13:25-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20140320 19:14:16< mordante> lipkab I'm around now ;-)
20140320 19:15:41< mordante> lipkab I'd like it better to discuss your proposal when you're around
20140320 19:16:15< mordante> lipkab if we don't manage to discuss it before the Google deadline just apply your current proposal
20140320 19:16:39-!- ykanarev [~ykanarev@78.81.70.234] has joined #wesnoth-dev
20140320 19:17:19< mordante> lipkab we _always_ ask for modifications after it has been submitted, so we expect the proposal to be improved during the selection procedure
20140320 19:17:49< mordante> lipkab this however requires a proposal to be submitted to Google
20140320 19:18:09-!- paradoq [~paradoq@72.135.25.221] has joined #wesnoth-dev
20140320 19:18:38< mordante> lipkab I will commit some of my changes this weekend so you can judge by yourself, but the texture class is very basic
20140320 19:20:59< mordante> aquileia will have a combobox eventually
20140320 19:21:27-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140320 19:21:35-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20140320 19:21:35-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host]
20140320 19:21:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140320 19:22:18-!- gus3000 [c1335331@gateway/web/freenode/ip.193.51.83.49] has quit [Ping timeout: 245 seconds]
20140320 19:22:48< mordante> aquileia every program has its own rand() sequence it is not shared between programs
20140320 19:22:50-!- incredible_ [~incredibl@106.221.83.202] has quit [Ping timeout: 246 seconds]
20140320 19:23:15< mordante> Aishiko, how are things going?
20140320 19:25:23< Ivanovic> mordante: libkab already submitted
20140320 19:25:31< Ivanovic> just check http://www.google-melange.com/gsoc/proposal/list/org/google/gsoc2014
20140320 19:25:37< Ivanovic> several others are probably missing though
20140320 19:25:50< Ivanovic> with other words:
20140320 19:25:59< mordante> Ivanovic, good to know, just finishing the log first, then will go to melange
20140320 19:26:05< Ivanovic> @all gsoc students: please make sure that your proposal is submitted to the tracker!
20140320 19:26:16< Ivanovic> if it is not there in time: no chance to get accepted
20140320 19:26:27< Ivanovic> there will be no deadline extension, no matter what your reason might be
20140320 19:26:49< Ivanovic> even if the complete google server were down for the last hour before the deadline it won't matter
20140320 19:27:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140320 19:30:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140320 19:30:22< Aishiko> mordante, in relation to my proposal I think they are going good, my instructor that looked over the technical part said that it looks like I've not forgotten anything and the times seem about right.
20140320 19:31:04< mordante> Aishiko, good, well I was just wondering in general I had no more questions regarding the image code
20140320 19:31:13< Aishiko> Ivanovic, =P Crab_ beat you to that announcement by like 5 minutes =)
20140320 19:31:34< mordante> we can't warn enough about it ;-)
20140320 19:31:44< Crab_> we once used a bot to warn about it :)
20140320 19:32:05< Crab_> because.. it'll really be not good if someone forgets about the deadline
20140320 19:32:13< Crab_> as there are no extensions.
20140320 19:32:29< Aishiko> mordante, I bet!  Well I had some questions, let me pull up the file, I'm not sure what they were off the top of my head
20140320 19:32:33< Dugi> Hm, do you think I have a chance to be chosen for GSoC too?
20140320 19:32:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140320 19:32:52< Crab_> Dugi: by now everyone has a chance. we'll still take a few weeks to select the students.
20140320 19:32:56< mordante> Dugi file a proposal and there is a chance 
20140320 19:33:14< Crab_> Dugi: usually we look for interaction, coding ability (z.b. proven by patches), and good proposal.
20140320 19:33:33< Dugi> But somebody told me that if somebody is in the first year of Informatics' study, he has very little chance to get there.
20140320 19:33:36< Ivanovic> Dugi: to be accepted you first need to be eligible
20140320 19:33:51< Ivanovic> no matter which term you are in, as long as you are a student you already have the basics
20140320 19:34:01< Dugi> I have almost finished the job at adding a ranking/reviewing system to add-ons.
20140320 19:34:21< Dugi> So, I have some experience with wesnoth's code.
20140320 19:34:36< Aishiko> and the basics are what we build on =)  no basics your foundation for the code is not going to be as sound as if you did
20140320 19:35:37-!- Ivanovic changed the topic of #wesnoth-dev to: GSOC: students have to submit proposals to google-melange until 21 March, 19:00 UTC; no deadline extension!!! | 1.12 beta planned for "soon" | string+feature freeze active on 1.12 | 228 bugs, 353 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140320 19:36:01< Ivanovic> Dugi: make sure to submit something to google ASAP
20140320 19:36:02< Aishiko> mordante, right now, the files that have my attention the most for the images are display.cpp and image.cpp, and I think I saw some in game.cpp and various Action directory files,  I've just not pared out the ones that don't matter
20140320 19:36:18< Ivanovic> once that is done (should include a link to the wiki page) you can work on the proposal text
20140320 19:36:26< Dugi> I was talking about an idea with fendrin, but I can't find him.
20140320 19:36:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140320 19:36:40< Ivanovic> sometimes he is off for several days
20140320 19:36:46< Dugi> Damn.
20140320 19:36:47< Ivanovic> you could ask the question in here, too
20140320 19:37:00< Ivanovic> maybe fendrin_ will stumble over it and reply, maybe someone else can help, too
20140320 19:37:37< Dugi> Well, he wanted to add a drag&drop system to GUI and create some functions to make the creation of RPG-like add-ons more comfortable.
20140320 19:38:16< Dugi> I wonder how feasible would that be.
20140320 19:38:56< Ivanovic> drag&drop to gui might be something mordante can give you info about
20140320 19:38:59< mordante> IMO drag and drop would be a rather bad timing
20140320 19:39:04< Ivanovic> since he has some experience with the new gui code
20140320 19:39:17< Ivanovic> for the rpg addon creation: hmmm, not sure
20140320 19:39:21< Dugi> Bad thing now... hm, then something else.
20140320 19:39:35< mordante> we want to move to SDL2 and I think adding new GUI features is not really the best time to do that
20140320 19:39:54< Dugi> I have the add-ons reviewing/ranking almost finished, I wouldn't get GSoC on that, I suppose.
20140320 19:40:29< mordante> well GSoC is supposed to be a job of several months ;-)
20140320 19:40:54-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 245 seconds]
20140320 19:41:00-!- RiftWalker [~nathan@129.59.115.25] has joined #wesnoth-dev
20140320 19:41:27< Dugi> I've spent almost a month doing that, but I was also studying, making thermal desorbtion experiments, writing lab reports etc.
20140320 19:42:40< Dugi> Where do I find those feature requests to see if I'll like something there?
20140320 19:45:26-!- RiftWalker [~nathan@129.59.115.25] has quit [Ping timeout: 265 seconds]
20140320 19:48:48-!- RiftWalker [~nathan@129.59.115.25] has joined #wesnoth-dev
20140320 19:49:25< Aishiko> mordante, would you agree that the spritesheet cache code would be best done in the images.cpp file?
20140320 19:49:40< gfgtdf> mordante: why do we disable crusade advancing if a unit has > 80 experience =
20140320 19:50:29< mordante> Dugi, best look at our student page for the ideas we're offering for GSoC
20140320 19:50:46< mordante> Dugi, custom ideas are also allowed, but it's a bit late for that
20140320 19:51:10< Dugi> Found it.
20140320 19:51:42< mordante> Aishiko, I'm not sure whether that is the best place, but I think that's not really important for the proposal
20140320 19:52:00< Aishiko> oh
20140320 19:52:17< mordante> Aishiko, it depends on the amount of code. I prefer small files with one task others like monster size files
20140320 19:52:55< Dugi> By the way, why don't you create an archive to hold all sprites instead of using a spritesheet? Less work, faster, more compatible. Seen this in Ogre3D.
20140320 19:53:05< mordante> gfgtdf, no idea, maybe you can look at the commit that introduced the change why it was done
20140320 19:53:10< mordante> Dugi, good
20140320 19:53:14< Aishiko> ahh, I'm in between I havn't decided what I personally prefer yet
20140320 19:53:44< mordante> Dugi, what do you mean with an archive?
20140320 19:53:57< Aishiko> I'm curious too
20140320 19:54:09< mordante> Aishiko, well personal preferences come with time, and change with time ;-)
20140320 19:54:21< gfgtdf> mordante: it was your commit thats why i asked you f8b0d3f7ca7132ac106667634a3a7f3acc934410  was "not getting into an infinita adcaement loop" the only reason?
20140320 19:54:56< Dugi> Like a generic zip archive where you just put all the sprites. You might be able to access them from WML just like before, you can create them just by zipping the entire folder.
20140320 19:56:34-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140320 19:56:58< mordante> Dugi, and how friendly is that for artists?
20140320 19:57:12< lipkab> Hello mordante.
20140320 19:57:23< Aishiko> mordante, we already compress the saves, so we could use the same sort of process for the images
20140320 19:57:27< mordante> gfgtdf, ah that commit, I think the comment in the patch is clear or not?
20140320 19:57:30< mordante> hi lipkab 
20140320 19:57:39< Dugi> Putting files into an archive? I think that WinRar is usable by everyone.
20140320 19:58:13< mordante> lipkab, I left some messages in the logs, also saw you committed a proposal :-)
20140320 19:58:14-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140320 19:58:29< mordante> Dugi, it's not it's only available for Windows users :-P
20140320 19:58:29< Dugi> .tar.bz2 that is used for saves is quite bad for archives with many files.
20140320 19:58:33< lipkab> mordante: Okay, will read.
20140320 19:58:42-!- paradoq [~paradoq@72.135.25.221] has quit []
20140320 19:58:48< Aishiko> but that brings up the question of do we get the same benefits with loading and less memory if we go with sheets versus ziping them all and loading them into memory
20140320 19:59:18< mordante> Dugi, I'm more wondering about editing a few pixels will require to unpack the archive, change and repack
20140320 19:59:33< Dugi> On Linux, you have it usually preinstalled, unlike on Windows, so it's even easier there. And I suppose Mac has something similar.
20140320 20:00:05< Dugi> Most archive managers allow you to replace just a single file.
20140320 20:00:07< mordante> Dugi, there is no Winrar for Linux, there are some rar programs
20140320 20:00:45-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 20:00:47< Dugi> Yes, I know. I am using Linux. And I know that archiving software is even easier to get there than WinRar on Windows.
20140320 20:00:53< Aishiko> I know ark seems to come as standard
20140320 20:01:04< Aishiko> well usually
20140320 20:01:17-!- exciton_ [chuck-the-@95.72.67.250] has joined #wesnoth-dev
20140320 20:01:27< Dugi> And, maybe it might not be necessary to have the stuff in an archive, it might search folders as well as archives.
20140320 20:01:41< mordante> yes but the problem I see with it you can't quickly use an image viewer to look at the files
20140320 20:02:02< iceiceice> gfgtdf: did you figure out how to get replays from the local instance of server?
20140320 20:02:11< iceiceice> i have had that working since yesterday
20140320 20:02:12< mordante> and every operation requires unpacking
20140320 20:02:19< mordante> IMO unacceptable for artists
20140320 20:02:26< Aishiko> I see a further issue of if the current compression we use isn't good for images adding another and maintaining it for the images
20140320 20:02:27< lipkab> RiftWalker: Tomorrow.
20140320 20:02:44< gfgtdf> iceiceice: yes
20140320 20:02:50< iceiceice> ok good
20140320 20:02:53< mordante> if somebody would make such a suggestion for the source files I would ask whether s/he was insane
20140320 20:03:13< iceiceice> yeah so the thing about the replay server is that it has its own code path to generate replays
20140320 20:03:26< lipkab> RiftWalker: (If you don't find someone else until then).
20140320 20:03:28< Dugi> That's true. But big images consisting of many smaller images impose problems with setting and reading coordinates.
20140320 20:03:29< Aishiko> I'm insane but then again sanity is over rated anyway.
20140320 20:03:32< mordante> so I won't suggest that artist need such a workflow
20140320 20:03:47< iceiceice> at least in <= 1.11.10 it does some unsual things like update the controller types of replay_start as the game proceeds
20140320 20:03:53< RiftWalker> lipkab: Thanks!
20140320 20:04:05< iceiceice> and i dont think it commits [change_control] signals to [replay]
20140320 20:04:10< iceiceice> i'm changing some of this
20140320 20:04:18< iceiceice> but tbh i dont really know what gets written to replay and what doesn't
20140320 20:04:25< iceiceice> and if synchronize choice does or doesn't
20140320 20:04:26< Dugi> mordante, Maybe normal images could be read as well as folders, you just place them away from the folder, change the files to look for them elsewhere, do all the tries and put them back into the archive.
20140320 20:04:38-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds]
20140320 20:04:46< iceiceice> i guess that probably it mostly works as expected except about the controller types, but i can't say for sure
20140320 20:05:07< gfgtdf> iceiceice: sync could gets written into replay
20140320 20:05:11-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 246 seconds]
20140320 20:05:12< iceiceice> there's not really that much code, it wouldn't be too hard to check. i think all the relevant code would be in server.cpp or game.cpp 
20140320 20:05:43< gfgtdf> iceiceice: i dodnt change anything about get_choice on serverside
20140320 20:05:45< iceiceice> what do the sync records look like?
20140320 20:05:46< gfgtdf> didn't
20140320 20:06:17< mordante> really putting images in an archive is a horrible idea for Wesnoth
20140320 20:06:18< gfgtdf> iceiceice: what do you mean ?
20140320 20:06:21< Aishiko> mordante, I've got to go, I need run some errands before the stores close.  I'll be back in a few minutes
20140320 20:06:51-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev
20140320 20:06:59< mordante> is Ogre 2d sprite art or 3D models?
20140320 20:07:19< lipkab> mordante: I'll be too tempted to start committing SDL2 patches right away :S Couldn't we make Google to launch SoC earlier?
20140320 20:07:35< lipkab> Alternatively, someone should revoke my commit rights.
20140320 20:08:25< Dugi> mordante, Nope, I was making a 3D game myself, but then I accidentally formatted my hard drive and all files are gone. They just used zip archives to store all graphics, its system accessed zip archives just like folders when looking for graphic files.
20140320 20:08:55< lipkab> mordante: I tested out partial redrawing, by the way, and it's definitely possible. SDL_RenderPresent doesn't reset the screen.
20140320 20:08:56< iceiceice> gfgtdf: i guess its this function: replay::user_input(std::string, const config) in replay.cpp?
20140320 20:09:12< mordante> lipkab, well it's not forbidden to work on code before GSoC, but it would be a good idea to coordinate the work
20140320 20:09:43< Dugi> I like the idea of a campaign wizard.
20140320 20:09:46< gfgtdf> iceiceice: yes but i changes that function, i also testedm taht the replays from server doesnt work because the "[start]" tag is missing
20140320 20:09:52< mordante> lipkab, yeah I also did some tests with it, did some work on a small test application
20140320 20:10:00< Dugi> Can you tell me more of it? That comment there is quite empty.
20140320 20:10:15< gfgtdf> iceiceice: i changesd the replay controller so that they now need teh [start] tag at teh beginiing of replays
20140320 20:10:23< iceiceice> hmm
20140320 20:10:25< iceiceice> we should change that on the server then
20140320 20:10:25< gfgtdf> iceiceice: like they are in normal replays
20140320 20:10:39< iceiceice> is that only on your branch or in general?
20140320 20:10:40< Ivanovic> Dugi: in which context would you create it?
20140320 20:10:59< iceiceice> i guess it must just be on your branch?
20140320 20:11:02< Ivanovic> would you create it as part of the normal editor or more likely of the eclipse editor which timotei once worked on?
20140320 20:11:19< Dugi> Currently the GUI I am the most used to is Qt, but I might do it in something else as well.
20140320 20:11:20< mordante> Dugi, IMO 3D models and 2d sprites are a different beast for 3D models I see an advantage for archives
20140320 20:11:36< iceiceice> gfgtdf: here's the relevant spot in server: https://github.com/wesnoth/wesnoth/blob/master/src/server/server.cpp#L2546
20140320 20:11:49< iceiceice> when it gets "[start_game]" from the host, it relays it to all the clients,
20140320 20:11:56< iceiceice> but it doesn't record it in the history
20140320 20:11:59< mordante> Dugi, for 2D sprites I don't see an advantage only disadvantages
20140320 20:12:00< iceiceice> so we would want to change that
20140320 20:13:12< Dugi> mordante: I've told you everything I could to persuade you, so the decision is now yours to take. My point was the advantage of not having 2000 files on the disk, not decreasing the size of the game.
20140320 20:13:29< gfgtdf> 	iceiceice: here what i mean: http://pastebin.com/PUDAf0D6
20140320 20:14:09< Dugi> Ivanovic: Currently the GUI I am the most used to is Qt, but I might do it in something else as well. Wondering if it would make sense to write it to be directly incorporated in wesnoth.
20140320 20:14:26< mordante> Dugi, not having 2000 files is an advantage, that is what the whole spritesheet idea is about
20140320 20:15:08< iceiceice> gfgtdf: if you want the server to add "[start_game]" to the replay, you need to use something like this function at the location i mentioned earlier: https://github.com/wesnoth/wesnoth/blob/master/src/server/game.cpp#L1310
20140320 20:15:19< gfgtdf> iceiceice: the [start] rag is nerver sended over the network currently
20140320 20:15:51< gfgtdf> iceiceice: not [start_game], just [start] as the first command inside the [replay] tag
20140320 20:15:59< iceiceice> oh
20140320 20:16:08< iceiceice> so [start] is something new you've made?
20140320 20:16:35< Dugi> mordante: I mean that it's also what the archives should help with. One archive instead of every folder, and you have it done. Spritesheets would bring countless technical difficulties with them.
20140320 20:16:48< gfgtdf> iceiceice	: no it was always there.
20140320 20:17:25< iceiceice> hmm that is confusing ><
20140320 20:17:48< iceiceice> so "[start]" corresponds to the time when start events are fired?
20140320 20:17:53< gfgtdf> iceiceice: but before it was just used durign the game as a dummy and ignored in repls.
20140320 20:17:56< iceiceice> but its different from "start_game"
20140320 20:18:05< zookeeper> images in archives is a terrible idea
20140320 20:18:07< mordante> I agree it might be easier for the game to use archives, but I think it will be too human unfriendly
20140320 20:18:32< zookeeper> you can't diff image commits, you can't even tell which images changed except from the message
20140320 20:18:32< gfgtdf> iceiceice: yes start it's added here: https://github.com/wesnoth/wesnoth/blob/master/src/replay.cpp#L237
20140320 20:18:35< mordante> and scare away (new) contributors
20140320 20:18:46< zookeeper> you have to uncompress/recompress every friggin time you want to do something
20140320 20:18:50< zookeeper> urgh
20140320 20:19:04< iceiceice> why isn't it sent over the network?
20140320 20:19:08< iceiceice> that's kind of odd
20140320 20:19:17 * mordante fully agrees with zookeeper 
20140320 20:19:48< iceiceice> anyways i guess you could just have the server generate it after [start_game] and add it to the history
20140320 20:20:04< iceiceice> the things recorded in history literally become the contents of [replay] in a server replay
20140320 20:20:33< Dugi> mordante:  The archives may not be mandatory. You write the path, it checks if that file exists, if it doesn't, it checks if there is an archive holding it. You can do the testing stuff without using archives, and pack it when done.
20140320 20:20:44< gfgtdf> iceiceice:  yes i tihnk thats right.
20140320 20:22:44< iceiceice> maybe at the end of this function is appropriate?
20140320 20:22:44< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/server/game.cpp#L156
20140320 20:23:10< mordante> Dugi, »You write the path« who writes? The artist the game somebody else?
20140320 20:24:19< gfgtdf> iceiceice: yes but we also have to check that we don't send it to observers/new players, because they also expect that it's not sended over network.
20140320 20:24:33< Dugi> mordante: I mean that the path in the unit's file contains it. If there is no such file in the archive, it checks if there isn't a normal folder with the same name and looks for the image there.
20140320 20:24:56< gfgtdf> gfgtdf: mybe we should just add a little hack in the file thats writes hitory_ to the file.
20140320 20:25:09< iceiceice> gfgtdf: things written to history dont go to new players
20140320 20:25:15< iceiceice> they will go to new observers
20140320 20:25:23< iceiceice> maybe thats what you mean
20140320 20:25:33< gfgtdf> iceiceice: yes do new players even exist ß
20140320 20:25:35< gfgtdf> ?*
20140320 20:25:52< iceiceice> i guess not
20140320 20:25:57< gfgtdf> :) 
20140320 20:26:02< iceiceice> so we could add it in save_replay
20140320 20:26:18< gfgtdf> iceiceice hmm maybe.
20140320 20:26:24< iceiceice> then it will only go int he saved file
20140320 20:26:40< iceiceice> it woudl be a hell of a lot simpler if the host just broadcast this
20140320 20:26:47< iceiceice> and it was recorded as a command 
20140320 20:27:10< iceiceice> is there a reason that would be bad?
20140320 20:27:56< gfgtdf> iceiceice: hmm idk, 
20140320 20:28:33< iceiceice> or the replay viewer could insert the tag itself i guess
20140320 20:28:47< iceiceice> if the host and clients are adding it themselves, why cant the replay controller also do this?
20140320 20:29:31< iceiceice>  nm the last thing i said doesn't make sense i guess
20140320 20:30:29< mordante> Dugi, I see what you mean. Still I think archives are not they way for Wesnoth and zookeeper's initial reaction confirms my suspicion
20140320 20:31:15< gfgtdf> iceiceice: wait i think obeservers DO expect the replay tag in the data they get from teh server.
20140320 20:31:17< mordante> Dugi, also if you want to seriously look into this you should propose it to our artists and see how they feel about the idea
20140320 20:31:37< mordante> Aishiko, do you have more questions?
20140320 20:31:43< gfgtdf> iceiceice: so https://github.com/wesnoth/wesnoth/blob/master/src/server/game.cpp#L156 would be the normal choice.
20140320 20:31:48< gfgtdf> like you said
20140320 20:32:22< Dugi> mordante: Hm, who should I contact? Seriously, the spritesheet idea seems like a nightmare to me.
20140320 20:32:32< iceiceice> so i guess one possible issue is that if there are prestart events that result in history being added
20140320 20:32:56< iceiceice> they should go before "[start_game]" ?
20140320 20:33:14< gfgtdf> iceiceice: no they go directly after [start] 
20140320 20:33:22< iceiceice> really?
20140320 20:33:37< iceiceice> so what is the significance of [start]
20140320 20:34:07< gfgtdf> its fire_preload() then add_start() then fire_prestart() then init_gui() then fire_start() on the client
20140320 20:34:51< iceiceice> ok
20140320 20:34:57< iceiceice> but preload things dont go in history i guess?
20140320 20:35:09< gfgtdf> iceiceice: they do,
20140320 20:36:08< gfgtdf> iceiceice: for example if a unit advanced in porestart events (is that possible?) then a [advance] type="Ranger" [/advance] or similar is saved in replays directly after start but feroe teh first [init_side]
20140320 20:36:13< gfgtdf> prestart*
20140320 20:36:27< iceiceice> why do we need to give [start] special treatment? why doesn't it just get broadcast
20140320 20:36:34< iceiceice> i dont see how the server could figure what the order should be
20140320 20:37:13< iceiceice> because if we put [start] in the history on server at e.g. https://github.com/wesnoth/wesnoth/blob/master/src/server/game.cpp#L156 then it will always be before preload events in the server replay i guess
20140320 20:38:05< gfgtdf> gfgtdf: ahh i was wrong i missready and thought you wrtor ptrstart instead of preload, yes preload things never go in history
20140320 20:38:17-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140320 20:38:18< gfgtdf> s/gfgtdf/iceiceice
20140320 20:38:24< iceiceice> i see
20140320 20:39:18< mordante> Dugi, try one of the art forums. Keep in mind you're not talking to coders, so explain the what archives would mean for the artists and how they would benefit from the change and what disadvantages it would mean for them
20140320 20:39:51< Dugi> mordante: Okay. I really wonder what will they prefer.
20140320 20:40:18-!- trademark [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 264 seconds]
20140320 20:40:22< mordante> Dugi, and make sure it is a proposal just to get their feedback
20140320 20:40:23< gfgtdf> 	iceiceice: but when i try to laod trom serverreplay i get an error missing child untested for or similar
20140320 20:40:53< iceiceice> so i guess i dont understand right now why we don't just "merge" the "[start_game]" and "[start]" tags
20140320 20:41:01< iceiceice> it sounds like they are both broad cast at the same time
20140320 20:41:02< gfgtdf> iceiceice: which is not because of teh start tag because for that i use assert(pstart->has_child("start"))
20140320 20:41:15< iceiceice> "[start_game]" is broadcast to clients but not written to history or replays
20140320 20:41:27< iceiceice> "[start]" is apparently written to replays before any events occur
20140320 20:41:33< iceiceice> but not broadcast
20140320 20:41:43< Aishiko> mordante, sorry I had to run I'm back now.  If you could let me know if I'm understanding the image subsystem correctly that would be great
20140320 20:41:59< iceiceice> wouldn't it be simpler if we just wrote start_game to history and replays
20140320 20:42:02< iceiceice> and got rid of start
20140320 20:42:22< iceiceice> and used "start_game" for its purpose?
20140320 20:42:55< gfgtdf> iceiceice: hmm i know nothing about start_game.
20140320 20:43:34< iceiceice> theres not much to know
20140320 20:43:41< iceiceice> i find only 4 places in the entire source with grep
20140320 20:43:53< Aishiko> mordante, right now it looks like the images are grabed off the disk and stored in a cache from there each image is then modified and the modified image is returned to cache, and used.  After a period of disuse, the modified images are dropped from the cache, and recreated as needed, the same with the base altered images, or do those stay in cache until some other point?
20140320 20:44:02< iceiceice> http://pastebin.com/97zF7HLc
20140320 20:44:06< mordante> Aishiko, please tell me which part you want me to check whether I understand it correctly? (I'll be leaving soon however)
20140320 20:44:39-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 245 seconds]
20140320 20:44:39< Aishiko> mordante, thank you I understand life and timezone diff and all that
20140320 20:45:03-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140320 20:45:04< mordante> I'm not leaving directly, but soon ;-)
20140320 20:45:22< Aishiko> basically I think the original images stay in cache for a longer period of time
20140320 20:46:04< gfgtdf> iceiceice: is the replay object correctly intilites when [start_game] is recived?, another issue is that the game uses recorder.empty() at some point to detemine wether we are in a replay or not.
20140320 20:47:35< mordante> Aishiko, yes different caches have different invalidation triggers
20140320 20:47:54< iceiceice> gfgtdf: so in mp clients, the game state is initialized from the config for the level in the function "level_to_gamestate"
20140320 20:48:05< iceiceice> and in there the recorder is initialized
20140320 20:48:18< mordante> Aishiko, and the raw images are flushed the least, modified images indeed more often
20140320 20:48:23< gfgtdf> in level_to_gamestate ?
20140320 20:48:28< Aishiko> and the original images are stored in a cache that is separate from the modified ones if I read it right
20140320 20:48:33< iceiceice> on the host, in multiplayer_connect_engine.cpp, this happens just after level_to_gamestate
20140320 20:48:51< iceiceice> in the other clients, they are in multiplayer_wait until they get "[start_game]"
20140320 20:49:03< iceiceice> i guess they probly call level_to_gamestate just after although i'm not sure atm
20140320 20:50:35< mordante> Aishiko, yes there are 6 different caches
20140320 20:51:04-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has joined #wesnoth-dev
20140320 20:51:32< aquileia> mordante: Hi
20140320 20:51:49< mordante> hi aquileia 
20140320 20:51:57< Aishiko> right now, I'm focused on the 2, that I know of, that directly concern the sprites, do I need to worry about or work with any of the other 4?
20140320 20:52:13< aquileia> So the combo lists are going to be ported?
20140320 20:54:19< aquileia> That would be nice - I could use them for the YAMG dialog to select season and climate!
20140320 20:55:10< mordante> Aishiko, which 2 are those?
20140320 20:55:49< mordante> aquileia, yes the goal is to have GUI2 replace GUI1, I think the transition to SDL2 will make parts of that transition easier
20140320 20:56:01-!- RiftWalker [~nathan@129.59.115.25] has quit [Ping timeout: 240 seconds]
20140320 20:56:01< aquileia> good to know
20140320 20:56:42< aquileia> Then it's probably a bad time to implement new widgets like my numbox, though...
20140320 20:56:46< Aishiko> gl::image and ohh phoo I can't recall the other one off the top of my head.
20140320 20:57:21< mordante> aquileia, numbox not since it does not really affect the drawing part, a combobox does
20140320 20:57:37< aquileia> ah, ok
20140320 20:57:46< Dugi> mordante: When thinking about ImagePathFunctionWML, maybe the spritesheet could be tried out on one faction without even having to do any C++ changes. And then you can proceed from experience.
20140320 20:57:54< mordante> in fact the numbox shouldn't directly touch any drawing code, it should use that code of its parent class
20140320 20:58:20< Aishiko> mordante, I want to say the other one is display, but not 100% on that one
20140320 20:58:23< aquileia> mordante: Right
20140320 20:59:09< Dugi> mordante: I've posted the question, I hope I did it right: http://forums.wesnoth.org/viewtopic.php?f=9&t=40190
20140320 20:59:21< aquileia> my vertical slider might interfere a little with the drawing code... hmm
20140320 21:02:17-!- neXyon_ [~neXyon@85-127-52-220.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140320 21:02:29< mordante> Dugi, I specifically asked to write at _non-coders_
20140320 21:03:06-!- neXyon [~neXyon@85-127-242-206.dynamic.xdsl-line.inode.at] has quit [Ping timeout: 264 seconds]
20140320 21:03:06< iceiceice> gfgtdf: i'm not completely sure about when the recorder is initialized on nonhost clients, it looks like there are two code paths, level_to_gamestate, and also a constructor of game state that takes level...
20140320 21:03:17< aquileia> mordante, is the addition of 'struct tcontent' ok or should I rather call get_value, get_selection_length & get_selection_start ?
20140320 21:03:22< iceiceice> and the criterion for when to use which seems obscure to me, although there is some comment that we should ask mordante
20140320 21:03:36-!- lipkab [~lipkab@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140320 21:04:02< Aishiko> http://forums.wesnoth.org/viewforum.php?f=23 mordante is that the correct area?
20140320 21:04:42< Dugi> mordante: What did I write wrong?
20140320 21:04:46< aquileia> mordante: Now that I read about it, I can absolutely understand if you want no changes to the ABC
20140320 21:04:55< Dugi> mordante: Ithink that zip archive is obvious.
20140320 21:04:58< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/multiplayer_wait.cpp#L381
20140320 21:05:57< Dugi> mordante: I mean manipulation with zip archives belongs to the IT knowledge everyone knows.
20140320 21:06:30< Ivanovic> Dugi: when thinking about the proposal please don't forget who the users will be
20140320 21:06:40< Ivanovic> Dugi: the users are not always as techy as we are
20140320 21:07:00< mordante> Dugi, NO! manipulating zip archives is not per se common knowledge, that's what I tried to tell you before
20140320 21:07:05< Ivanovic> some artists already got problems with using github and doing more than working on the sprites and attaching them in forum posts is difficult
20140320 21:07:35< Ivanovic> from those i would not expect to edit zip files unless this is directly integrated in a well designed workflow which is easy for them
20140320 21:08:04< Aishiko> Dugi, the plan for the spritesheets is, as I understand it, the artists them and make their use of them as invisible to the actual implementation of the sheets that they don't know and don't care how its done but just works.  As I understand it they (the artists) have been asking for spritesheets for years.
20140320 21:08:13< Ivanovic> imagine you had a sister who is like 13 to 15 years old and loves to draw
20140320 21:08:25< Ivanovic> for this she is able to use some software on a pc which makes "pretty pictures"
20140320 21:08:36-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140320 21:08:38< Ivanovic> would you expect someone like this to know the inner workings of zip?
20140320 21:08:45< iceiceice> Dugi: I have worked with a computer science professor at a top 10 university who was unhappy with zip attachments in emails XD
20140320 21:09:03< iceiceice> actually he is my thesis advisor :)
20140320 21:09:17< Dugi> Seems there is no easy explanation, I'll just delete the topic, okay?
20140320 21:09:41< Ivanovic> don't give up this quickly
20140320 21:09:55< Ivanovic> just consider who your "customer" would be and what they need
20140320 21:10:07< Aishiko> Dugi, that is up to you, however if the artists are not given a chance to weigh in you'd be doing them a dis-service by not giving them that chance
20140320 21:10:49< Ivanovic> and don't forget that there is this place where the artists tend to hand around (known as "forums")
20140320 21:11:02< Ivanovic> or you could try to get in contact with Jetrel though he can be very techy
20140320 21:11:25< Ivanovic> but he also has lots of experience with our sprite art as well as how other projects like frogatto handle spritesheets
20140320 21:11:30< mordante> Dugi, Ivanovic posted a reply
20140320 21:11:36< Aishiko> Ivanovic, I'm intending to post something there soon to get some feedback from the artists so I can further tailor their needs into my proposal
20140320 21:11:51< Ivanovic> Aishiko: great approach!
20140320 21:12:33< Dugi> Please, not Jetrel, he is the guy who rejects all works because they are too amateurish and whatever, that is why there are less and less animated sprites in mainline. And he called me a parasite.
20140320 21:13:00< Ivanovic> still he might be able to give you a hint regarding the technology
20140320 21:13:11< Aishiko> Ivanovic, I'm going to include visual aids =D we ALL know how much artists like those =)  (yes I'm pandering a bit) but my brother is an artist and I've seen and heard of his issues with software when doing his work (ok hobby)
20140320 21:13:11< mordante> Aishiko, yes Jetrel is a big fan of sprite-sheets
20140320 21:13:49< Ivanovic> Aishiko: visual aids are also helpful for me as a techie
20140320 21:13:51< Ivanovic> ;)
20140320 21:13:59< Ivanovic> okay, heading off to bed now, n8
20140320 21:14:11< mordante> Dugi, well we have high-quality images, which means it gets harder to include new art, especially since we don't like to lower the standard
20140320 21:14:15< mordante> night Ivanovic 
20140320 21:15:31< Aishiko> mordante, I do have a quick question, is there a term I can use to grep for the different caches and get all of them and then filter out the ones I won't need?
20140320 21:15:38< mordante> aquileia, I'm not entirely sure about the context of the tcontent in the code, best code something so I can review the code
20140320 21:16:00< mordante> aquileia, I will be off soon, so will look at it later
20140320 21:16:04< gfgtdf> iceiceice: do you know what controller.is_idle means ?
20140320 21:16:04< aquileia> mordante: Ok, I'll do so
20140320 21:16:17< Dugi> mordante: I know this argument, but the result is that new sprite with 20% better baseframe is added at the cost of frikkin unanimated eyesore combat. But that's not the point now.
20140320 21:16:19< iceiceice> gfgtdf: yes i made that
20140320 21:16:31< mordante> aquileia, good the ABC is rather good as it is
20140320 21:16:54-!- RiftWalker [~nathan@129.59.115.25] has joined #wesnoth-dev
20140320 21:16:58< iceiceice> a new feature in 1.12 is that sides can be assigned to "idle" controllers, if e.g. a side disconnects
20140320 21:17:02< gfgtdf> iceiceice: any what does it mean ? especialy is controller.is_idle(1) the same on all clients ?
20140320 21:17:03< RiftWalker> thunderstruck: how familiar are you with the config class implementation?
20140320 21:17:09< mordante> Aishiko, what display cache are you referring to?
20140320 21:17:15< iceiceice> currently when a side disconnects the host needs to reassign
20140320 21:17:18< iceiceice> immediately
20140320 21:17:26< iceiceice> but there may be no acceptable target
20140320 21:17:39< gfgtdf> iceiceice: so is_idle never happens ?
20140320 21:17:40< iceiceice> i.e., not self, not droid
20140320 21:17:45< thunderstruck> RiftWalker: Only a little. I've looked at the code occasionally. but I never changed it.
20140320 21:17:50< iceiceice> idle state appears as human, owned by host 
20140320 21:17:53< iceiceice> to other networked 
20140320 21:17:55< aquileia> mordante: It's just the difference between three calls or one call to get/set a copy for restore
20140320 21:17:55< iceiceice> and to the server
20140320 21:17:57-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 21:18:08< iceiceice> but on the host machine it can exist 
20140320 21:18:16< mordante> Aishiko, the image caches are all defined at line 117 at least the ones you should care about
20140320 21:18:19< iceiceice> it is different from null in that
20140320 21:18:35< iceiceice> if play proceeds to an idle side, no moves happen and end turn does not occur
20140320 21:18:38< RiftWalker> thunderstruck: Do you know who would be most familiar with it?
20140320 21:18:41< iceiceice> but the side blocks
20140320 21:18:42< Aishiko> mordante, ohhh that makes my life easier thank you.
20140320 21:18:45< iceiceice> until reassigned
20140320 21:19:00< gfgtdf> ah ye i see is_idle implies is_local :)
20140320 21:19:03< aquileia> and also it might solve your concern about doubling code
20140320 21:19:12< mordante> you're welcome Aishiko 
20140320 21:19:21< iceiceice> yes so i have been thinking actually it might be better to implement it differently
20140320 21:19:29< thunderstruck> RiftWalker: Not really. What do you want to know anyway?
20140320 21:19:35< Aishiko> mordante, I was thinking of looking at them all and seeing how they all worked to get a better grasp on the concepts but if I study those ones more indepth I'll be better able to work with them later
20140320 21:19:46< iceiceice> its not necessarily in a finished state, but for all intents and purposes i guess you should treat it as a local human for your code
20140320 21:20:19< iceiceice> it might make more sense acutally though to have it correspond to a networked side with no owner though ...
20140320 21:20:27< mordante> aquileia, I usually like getters to be one call, but it really depends on the code
20140320 21:20:39< iceiceice> not sure will have to test i guess
20140320 21:20:51< iceiceice> it seems to work in testing since i committed it 
20140320 21:21:08< mordante> Aishiko, these 6 caches are the same type the difference is the kind of image they store
20140320 21:21:13< Dugi> mordante: I have edited the post.
20140320 21:21:51< mordante> Aishiko, and that kind is only determined by some trivialities for the code itself
20140320 21:22:16< Aishiko> mordante, okay, I'm sorry but working with caches is a bit new to me, but I'm a fast learner
20140320 21:22:16< mordante> Aishiko, so there is no fundamental difference and maybe in the future we get more or less types
20140320 21:22:46< mordante> Aishiko, for example if the scaling is done by SDL2 the zomming part of the cache might be removed
20140320 21:23:04-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 265 seconds]
20140320 21:23:08< Aishiko> I'm following =)
20140320 21:23:10< mordante> Aishiko, no problem, we're here to help you
20140320 21:25:16< aquileia> mordante: http://ideone.com/jVwHLg
20140320 21:25:32< Aishiko> mordante, in part yes, but your also here because you like the game and wish to improve it.
20140320 21:26:08< aquileia> I'd probably also add maximum_length (in URF8 characters) to the struct
20140320 21:26:22< aquileia> *UTF8
20140320 21:26:57-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140320 21:27:10< mordante> aquileia, I'll review it later, please ping me if I forget it
20140320 21:27:38< aquileia> ok
20140320 21:28:02< mordante> Aishiko, of course, but joining GSoC as mentor gives you certain obligations ;-)
20140320 21:28:16< mordante> like helping students with their questions
20140320 21:28:22< Dugi> Guys, I needed to ask about GSoC, I want to code a campaign wizard, where do I submit it when the time is running short?
20140320 21:28:25< aquileia> but it's just for discussing, I'll add more functions in case you agree
20140320 21:29:14< RiftWalker> thunderstruck: Well, for starters, I'd like someone to review my pull request. It's related to the config assignment operator. Moving on from that, I was wondering how copying etc. might be improved by using std::shared pointer instead of raw pointers to children. Then, by separating the tree structure from the actual objects, we could potentially eliminate a lot of redundant data by sharing children instead of copying them.
20140320 21:29:20< Aishiko> mordante, lol even the clueless ones (no dugi not talking about you, talking about me in this case learning from scratch the caching system)
20140320 21:30:00< mordante> well we expect students not senior developers
20140320 21:30:39< mordante> and Wesnoth is not a small project you can learn after a few days of looking at the code
20140320 21:31:42< Aishiko> mordante, tied that and failed, so I can testify to that!
20140320 21:32:19< Coffee_irc> mordante: not to everyone is Wesnoth is a small project :P
20140320 21:32:43< thunderstruck> RiftWalker: Isn't std::shared part of C++11?
20140320 21:34:18< Dugi> Guys, sorry for spamming, but I am getting no replies and the time isn't unlimited, I needed to ask about GSoC, I want to code a campaign wizard, where do I submit it?
20140320 21:34:24< RiftWalker> thunderstruck: Ah, you're right. Boost has an equivalent though.
20140320 21:34:33< Ivanovic> Dugi: google-melange.com
20140320 21:34:52< Ivanovic> Dugi: this page lists the basic steps you should follow: http://wiki.wesnoth.org/SummerOfCodeIdeas
20140320 21:35:53< thunderstruck> RiftWalker: I briefly looked at your Change config assignment op to copy-and-swap commit
20140320 21:36:03< thunderstruck> RiftWalker: I think that kind of stuff is already in config.cpp
20140320 21:36:15< thunderstruck> RiftWalker: and is under HAVE_CXX11 define
20140320 21:36:46< mordante> Coffee_irc, I said it wasn't small
20140320 21:36:53< mordante> thunderstruck, yes
20140320 21:37:24-!- irker886 [~irker@ai0867.net] has joined #wesnoth-dev
20140320 21:37:24< irker886> wesnoth: Mark de Wever wesnoth:master e2ce7ec21969 / src/ (CMakeLists.txt SConscript sdl/texture.cpp sdl/texture.hpp): Add the initial SDL_Texture wrapper code. http://git.io/YSV_Gw
20140320 21:37:26< irker886> wesnoth: Mark de Wever wesnoth:master ba447c16e63c / src/sdl/ (window.cpp window.hpp): Add texture creation code for the window. http://git.io/bhn6cQ
20140320 21:37:28< irker886> wesnoth: Mark de Wever wesnoth:master 69b9b01dc42f / src/ (6 files in 2 dirs): Merge branch 'SDL_Texture' http://git.io/I7DC2A
20140320 21:37:35< mordante> uh oh Ivanovic is sleeptalking again
20140320 21:37:46< gfgtdf> iceiceice: i have a strange error where network::recieve_data doesnt recieve anything altough it has already been senden on the other side, and ir gets recieved by a later call of network::receive_data ? anyone knows why ?
20140320 21:38:18< mordante> lipkab I just committed the basics for the texture code, I also have some image loading code, but not commit worthy yet
20140320 21:38:20< Ivanovic> mordante: an old illness
20140320 21:38:49< Ivanovic> it came back together with this laryngitis...
20140320 21:39:11< Ivanovic> but finally, thanks to antibiotics the doc gave me on tuesday, it seems to be getting better...
20140320 21:39:37-!- ykanarev [~ykanarev@78.81.70.234] has quit [Quit: Leaving]
20140320 21:41:00< mordante> Gute Besserung
20140320 21:41:28< RiftWalker> thunderstruck: I saw that bit of code. Kind of baffled me. It apparently leaves the other config blank.
20140320 21:41:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20140320 21:42:10-!- exciton_ [chuck-the-@95.72.67.250] has quit [Read error: Connection reset by peer]
20140320 21:42:24-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140320 21:42:42< mordante> thunderstruck, we have some C++11 optimised parts in the code, but everything must work with C++98/03
20140320 21:42:50< RiftWalker> thunderstruck: also, copy-and-swap is nothing new. Is there any reason why it shouldn't be used in the default assignment operator?
20140320 21:47:21< mordante> RiftWalker, thunderstruck haven't looked at the pull request, but shared_ptr can have performance issues over raw pointer
20140320 21:47:25< Dugi> Hey, what should I write into the GSoC proposal it wants from me?
20140320 21:47:39< mordante> since I'm off now I don't have time to look at the request now
20140320 21:47:59< aquileia> mordante: Bye
20140320 21:48:26< Aishiko> mordante, bye and thank you for the starting point
20140320 21:48:40-!- Crab_ [~Crab_@wesnoth/developer/crab] has left #wesnoth-dev []
20140320 21:49:09-!- trewe [~trewe@87.46.54.77.rev.vodafone.pt] has joined #wesnoth-dev
20140320 21:49:12-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140320 21:49:18< thunderstruck> RiftWalker: Hmmm... is there a difference between std::swap in C++11 and before?
20140320 21:50:56< RiftWalker> thunderstruck: afaik, swap in this context is overridden for the config class.
20140320 21:51:13< iceiceice> gfgtdf: i don't know, maybe you can get the server to spit out more debugging code?
20140320 21:51:30-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has quit [Quit: Page closed]
20140320 21:51:31< iceiceice> or ask Soliton
20140320 21:51:48< iceiceice> i'm not actually sure what the guarantees of network:: are
20140320 21:53:36-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140320 21:53:55< iceiceice> question about the sprite sheets thing:
20140320 21:54:05< iceiceice> is a compromise actually feasible?
20140320 21:54:15< iceiceice> i.e. if it was determined that using archives is actually much faster,
20140320 21:54:35< iceiceice> couldn't there be some kind of build step that chops up the sprite sheets and makes archives?
20140320 21:55:02< iceiceice> i dont really have any idea how long that would take / if it would cripple the build time
20140320 21:56:00< shadowm> Aishiko: Any progress?
20140320 21:57:49< thunderstruck> RiftWalker: yes, that's true. Your best bet is probably to ask mordante when he'll be around again. I know too little about C++11.
20140320 21:58:40< RiftWalker> thunderstruck: Will do. Thanks for taking a look at it.
20140320 21:59:38-!- Gaben [~quassel@killer.teteny.bme.hu] has joined #wesnoth-dev
20140320 21:59:42< Aishiko> shadowm, working on it now
20140320 22:01:18< thunderstruck> RiftWalker: No problem. I guess that the previous version might be more efficient. You know got copy constructor involved.
20140320 22:01:27< thunderstruck> s/know/now
20140320 22:01:43< thunderstruck> RiftWalker: However, that's just a guess. I need to take a close look to be sure.
20140320 22:02:19< thunderstruck> RiftWalker: By the way, don't forget to submit your proposal to Google.
20140320 22:02:36< thunderstruck> RiftWalker: It's a hardline and if you miss it, there's nothing we can do about it.
20140320 22:02:42< thunderstruck> hard deadline*
20140320 22:03:21< RiftWalker> thunderstruck: Thanks. I won't.
20140320 22:03:21-!- gfgtdf [~chatzilla@f054138065.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20140320 22:04:32-!- gfgtdf [~chatzilla@f054156092.adsl.alicedsl.de] has joined #wesnoth-dev
20140320 22:07:36< gfgtdf> iceiceice: when i call newtork::receive_data twice in a row i get what i want tin the secoind try :s
20140320 22:07:56< iceiceice> on the client?
20140320 22:08:07< iceiceice> hmm does it have a return state
20140320 22:08:19< iceiceice> maybe it is telling you "false" = "oops i failed" the first time
20140320 22:09:28< gfgtdf> iceiceice: how can get i get return state ?
20140320 22:10:16< iceiceice> according to header: https://github.com/wesnoth/wesnoth/blob/master/src/network.hpp#L209
20140320 22:10:22< iceiceice> it will throw errors if it fails
20140320 22:10:27< iceiceice> and return "0" if it times out i guess
20140320 22:10:32< iceiceice> but that might not apply in your case
20140320 22:11:02< gfgtdf> i get return 0.
20140320 22:12:20< iceiceice> is this on first receive or something?
20140320 22:12:22< iceiceice> maybe its not initialized
20140320 22:12:31< iceiceice> i guess there shold not be anyway to time out to localhost?
20140320 22:12:42< iceiceice> you are using local server right?
20140320 22:12:51< gfgtdf> iceiceice: no it's a receive in the middle of a game that receives data that was sended by the server 10 seconds ago.
20140320 22:12:59< gfgtdf> iceiceice: ye i use local server
20140320 22:13:12< iceiceice> maybe server is stuck or lagging somehow
20140320 22:13:40< iceiceice> thats the only explanation i can think of
20140320 22:13:47< gfgtdf> iceiceice: hmm it's not liek calling it 20 seconds later would change anything  i tihnk.
20140320 22:13:59< thunderstruck> RiftWalker: Are you aware that you can work on your proposal for at least weeks after the Google deadline?
20140320 22:14:01< iceiceice> i mean should figure out what is happening on the server
20140320 22:14:12< iceiceice> its probably a bug
20140320 22:14:13< thunderstruck> s/weeks/a week/
20140320 22:14:25< iceiceice> depending on what the context is
20140320 22:14:43< gfgtdf> iceiceice: somehow the first call invokes something, maybe puts something in a buffer or to, that makes it return properly on teh second rty.
20140320 22:15:15< iceiceice> the server should never take 10 seconds to respond imo
20140320 22:15:22< iceiceice> that's almost intractable...
20140320 22:15:32< RiftWalker> thunderstruck: No, I didn't know that. That makes things a lot less stressful.
20140320 22:15:34< iceiceice> idk how many worker threads the server has
20140320 22:15:47< shadowm> Ivanovic: What does "soon" mean in the topic? I believe most developers here would like to know.
20140320 22:16:29< shadowm> My assumption is that you mean either this weekend or the next one but that's mostly because I know from past experience you tend to have more time on the weekends, and not everyone knows that.
20140320 22:16:55< iceiceice> Ivanovic: I hope we won't make a 1.12 beta release until we figure out bug 21808? its a *major* regression
20140320 22:17:16< thunderstruck> RiftWalker: When you submit your application to Google, just put a link to your proposal on wiki.
20140320 22:17:46< shadowm> Also, the topic makes it sound like it's a new thing when it'd be just the third beta in the series.
20140320 22:18:20< thunderstruck> RiftWalker: Then you can keep editing your proposal on our wiki.
20140320 22:18:33< thunderstruck> (after the Google's deadline)
20140320 22:19:55< spoffy> Phew. Initial submission to Google! Now I can go pass out for a bit :P
20140320 22:20:17< shadowm> 16:58:27 <Dugi> .tar.bz2 that is used for saves is quite bad for archives with many files.
20140320 22:20:24< shadowm> Dugi: We don't use .tar for saves.
20140320 22:20:33< gfgtdf> iceiceice: i asume bug 21808 happends because wesnothd properly saved replays from reloaded games ?
20140320 22:20:34< RiftWalker> thunderstruck: Oh, I see. Right now I'm trying to decide between going with the SP/MP code merge idea, or optimizing config and maybe some other data structures. Should I submit both?
20140320 22:20:52< iceiceice> gfgtdf: 21808 doesn't have anything to do with server replays
20140320 22:20:54< gfgtdf> s/properly/ does not properly 
20140320 22:20:56< iceiceice> its client hosting their own saves
20140320 22:21:20< thunderstruck> RiftWalker: You can do as you wish. But for optimisation, you'd have to find a mentor who's interested in this.
20140320 22:21:35< gfgtdf> iceiceice: did you see 19603 ?
20140320 22:21:56< shadowm> Dugi: Windows has built-in zip manipulation functionality nowadays, no need for an external application unless your zip was compressed in an exotic fashion or it isn't a real zip (zip != gz != tar.gz).
20140320 22:22:02< iceiceice> yes i actually hope to fix that
20140320 22:22:04< gfgtdf> iceiceice: no wrong number
20140320 22:22:19< thunderstruck> RiftWalker: And it might be hard to write two good proposals, in my opinion.
20140320 22:22:34< gfgtdf> iceiceice: i meant 19258
20140320 22:22:41< shadowm> Aishiko: ark is standard if you are using KDE, Gnome uses its own archive tool.
20140320 22:23:34< RiftWalker> Hm.. If i did decide to go with optimization, do you know who might be interested in mentoring it?
20140320 22:23:59< gfgtdf> iceiceice: hm no i forgot which i meant
20140320 22:24:02< Aishiko> shadowm ohh right, I normally find ark, but I should have added a qualifier to 2 there
20140320 22:24:25< iceiceice> i think i have seen both of these gfgtdf
20140320 22:25:00< iceiceice> 21808 is new, i painstakingly and manually bisected it to a particular commit in 1.11.7
20140320 22:25:44< thunderstruck> RiftWalker: Nope. Maybe someone would step up if you'd convinve that this would make a good GSoC project.
20140320 22:25:52< thunderstruck> s/convinve/convince
20140320 22:26:28< RiftWalker> thunderstruck: I see. Alright, well thanks for your help. I'm off for now
20140320 22:26:46< thunderstruck> RiftWalker: I think it would be important to hame some justifications for this. Optimising just for the sake of optimisation is not a best idea.
20140320 22:26:53< thunderstruck> RiftWalker: Ok. Bye.
20140320 22:27:09-!- RiftWalker [~nathan@129.59.115.25] has left #wesnoth-dev []
20140320 22:30:11< gfgtdf> iceiceice: wel i just tested on 1.11.11 and server replays from broken games are definitely broke
20140320 22:30:14-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140320 22:30:49< iceiceice> gfgtdf: i'm hoping to change things, i have a pull request #123 which will somewhat change the structure
20140320 22:30:55< iceiceice> among some other tings...
20140320 22:31:29< gfgtdf> iceiceice: s/broken/reploaded
20140320 22:31:34< gfgtdf> reloaded
20140320 22:31:48< iceiceice> i haven't tested that yet beyond compiling it though :/
20140320 22:32:25< iceiceice> gfgtdf: tbh i'm not sure if server replays of reloaded games have ever worked
20140320 22:33:25< gfgtdf> iceiceice: i thought the server replays are thesame thing that observing players get, so if those replays are broke that also means that players cannot observe
20140320 22:34:02< iceiceice> no they aren't really the same
20140320 22:34:09< iceiceice> afaik
20140320 22:34:23< iceiceice> let me clarify
20140320 22:34:25< iceiceice> if you observer a game
20140320 22:34:28< iceiceice> and save a replay after
20140320 22:34:35< iceiceice> it will be quite different from the server replay
20140320 22:34:59< Dugi> shadowm: Sorry for the delay. I remember that I had to install something from the Internet so that I could open zip archives on Windows 7. Maybe I had just a weird version.
20140320 22:35:22< iceiceice> so the way it works is, 
20140320 22:35:26< iceiceice> server keeps a "level_"
20140320 22:35:29< iceiceice> and a "history_"
20140320 22:35:39< iceiceice> the level corresponds to the level config that the host sent 
20140320 22:35:50< iceiceice> it is basically set it in stone after [start_game],
20140320 22:36:05< iceiceice> although even in master right now the server makes controller type changes to update as players leave the game
20140320 22:36:18< iceiceice> the history_ is like the replay recorder
20140320 22:36:34< iceiceice> the history becomes the [replay] tag in the server generated replay
20140320 22:36:43< iceiceice> and the *entire* level_ becomes [replay_start]
20140320 22:36:51< iceiceice> there are no other tags in a server generated replay
20140320 22:37:07< iceiceice> level_ and history are exactly the info that is sent to an observer whent hey join,
20140320 22:37:32< iceiceice> but if an observer joins a game they do further processing with level_
20140320 22:37:37< iceiceice> i.e. they use level_to_gamestate
20140320 22:37:55< iceiceice> and in that function, replay_start = level.remove_child("multiplayer",0)
20140320 22:38:13< iceiceice> so i dont know why the server doesn't also remove the [multiplayer] tag...
20140320 22:38:25< iceiceice> anyways in my branch i patch this and make the server do the same thing
20140320 22:38:34< iceiceice> but also there are other quirks about server replays like not having a snapshot
20140320 22:38:44< iceiceice> the server replays are really a totally different code path
20140320 22:42:49< iceiceice> let me clarify: when the observer joins the game, level_to_gamestate affects the replay_start that *they* wil generate if they should save a replay
20140320 22:43:03< iceiceice> so this is one way in which the client generated replay will be different from the server generated replay
20140320 22:51:45< Dugi> Okay, I have filled a GSoC application for GoblinThing's idea about Campaign Wizard.
20140320 22:57:14-!- A_Guy [925f62f1@gateway/web/freenode/ip.146.95.98.241] has joined #wesnoth-dev
20140320 22:57:21< A_Guy> Hey guys.
20140320 23:00:29< Dugi> A_Guy: Hello.
20140320 23:01:15-!- trewe [~trewe@87.46.54.77.rev.vodafone.pt] has quit [Remote host closed the connection]
20140320 23:01:46< A_Guy> I've been gone a while due to college work, but I've started working on Wesnoth again.
20140320 23:03:14< A_Guy> So how have you been?
20140320 23:03:20< A_Guy> Dugi
20140320 23:03:42-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev
20140320 23:04:18< A_Guy> Hello
20140320 23:07:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140320 23:17:24-!- Gaben [~quassel@killer.teteny.bme.hu] has quit [Remote host closed the connection]
20140320 23:22:19-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140320 23:24:34-!- Gaben [~quassel@killer.teteny.bme.hu] has joined #wesnoth-dev
20140320 23:26:37-!- RiftWalker [~androirc@129.59.115.25] has joined #wesnoth-dev
20140320 23:30:05-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20140320 23:32:07-!- RiftWalker [~androirc@129.59.115.25] has quit [Ping timeout: 265 seconds]
20140320 23:32:11< Aishiko> shadowm, I can't seem to see the extra serialization, when I look at the auto-saves, I only see one with each unit, and I did check a next scenario file.  I'll keep looking
20140320 23:38:23< gfgtdf> iceiceice: can a player make a side empty ?
20140320 23:38:30< gfgtdf> during a game
20140320 23:40:04< shadowm> Aishiko: It's impossible to serialize duplicate attributes, so if that's what you are looking for it means you didn't understand my message.
20140320 23:40:57< shadowm> How many days ago was this again...
20140320 23:40:58< Aishiko> I think that might be the case, unless your saying that if the unit doesn't have a special recall_cost you don't want a value stored
20140320 23:41:14< shadowm> Yes, that's what I was saying, probably.
20140320 23:41:40< shadowm> 20140318 06:58:20< shadowm> Aishiko_laptop: Units whose unit_type has a recall_cost appear to be serialized with that recall_cost even if they don't override it.
20140320 23:41:43< shadowm> 20140318 06:58:59< shadowm> (Found with :inspect.)
20140320 23:42:11< shadowm> Aishiko: Yes, what I mean is that if the [unit] doesn't override the recall_cost of the [unit_type], it shouldn't serialize it.
20140320 23:42:28< shadowm> On the other hand...
20140320 23:42:44< Aishiko> Okay I think I know exactly where the issue is then, and how I should handle it
20140320 23:42:45< shadowm> Now that I think of it, this is not actually a bug. <.<
20140320 23:43:05< shadowm> Because we already serialize all kinds of other crap that's not overridden from the unit_type.
20140320 23:43:18< shadowm> Recruit cost, possible advancements, etc.
20140320 23:43:52< Aishiko> I was a bit lost trying to figure out why if it wasn't duplicate data what the issue was I saw alot of stuff like unit_value that is never seen by the player either
20140320 23:44:06< shadowm> Race, alignment, level, ... everything is serialized even if not overridden, so never mind.
20140320 23:44:40< shadowm> Good to know I am really the only one reviewing this PR... sigh.
20140320 23:45:00< Aishiko> ohhh well then I think then I need to push these last 2 commits and it'll be ready for another look in a few minutes.
20140320 23:45:15< shadowm> What are the next two commits for?
20140320 23:45:40-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has joined #wesnoth-dev
20140320 23:45:40-!- stikonas [~gentoo@cpc18-sgyl27-2-0-cust35.18-2.cable.virginm.net] has quit [Changing host]
20140320 23:45:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140320 23:45:56< shadowm> Because... the only blocking thing I mentioned last time was this non-issue I didn't realize was a non-issue before. Sorry about that.
20140320 23:47:13< Aishiko> well I already pushed out the corrected changelog and the whiteboard one (did a mixed reset and push -f) after that it was just I think the display and about.cfg (adding me to that one file)
20140320 23:51:42< Aishiko> shadowm, there done, if there are any other issues concerns (like I screwed up my name placement in about.cfg) please let me know
20140320 23:52:06< Aishiko> its OK I've been known to make similar oops ;)
20140320 23:58:47-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Fri Mar 21 00:00:07 2014