--- Log opened Sun Apr 06 00:00:30 2014
20140406 00:00:34-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140406 00:04:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140406 00:12:37-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140406 00:15:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140406 00:22:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140406 00:37:11-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140406 00:54:34< aquileia> iceiceice: Do you by coincidence know which unit tests work?
20140406 00:55:00< iceiceice> i mean you can just run them
20140406 00:55:37< iceiceice> fabi put reports on the bug tracker for the failing ones, i think that was all inclusive
20140406 00:55:55< aquileia> I'm currently adding them to the VC project file and I'm not sure how to do that, so... currently I can't test it
20140406 00:56:07< aquileia> ah, ok
20140406 00:56:40< iceiceice> ok i'll pastebin the restuls of ./test for you
20140406 00:57:47< aquileia> thanks
20140406 00:59:24< iceiceice> http://pastebin.com/SGfaiGbW
20140406 00:59:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140406 00:59:35< iceiceice> ok, the first 3 about "formula/scripting" look new to me...
20140406 00:59:39< iceiceice> at least i never noticed them before
20140406 00:59:58< iceiceice> otherwise i think its the same 3 groups as when fabi made those bug reports
20140406 01:00:02-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140406 01:00:15-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140406 01:02:54< iceiceice> btw these are tests off of 1.12 branch
20140406 01:02:55< aquileia> ok, thanks again. Just to make sure... I'll have to run them, not only compile them, right?
20140406 01:03:11< iceiceice> yes you should get a test executable in the same place as ./wesnoth ends up
20140406 01:03:32< iceiceice> at root of the repo
20140406 01:03:40< iceiceice> i guess i dont know how it will work in codeblocks thoguh
20140406 01:03:40< aquileia> and auto run it in the build I guess
20140406 01:03:55< iceiceice> yes i guess i dont currently do that aprt
20140406 01:05:00< aquileia> I have plenty to read about unit tests in VC, but I'm confident I'll get it to work
20140406 01:06:00< aquileia> There's the 'Boost Unit Test Adapter' which might be handy for 
20140406 01:06:00< iceiceice> i'm not sure if theres a "special process", i think you just have to make sure you build src/tests/main.cpp, i could be wrong though
20140406 01:07:07< iceiceice> i guess our scons setup currently has "test" as a target maybe?
20140406 01:07:11< iceiceice> could check how that is set up
20140406 01:07:12< aquileia> I'll try it later on
20140406 01:08:23-!- gfgtdf [~chatzilla@f054143161.adsl.alicedsl.de] has quit [Ping timeout: 268 seconds]
20140406 01:17:55-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140406 01:19:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140406 01:23:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140406 01:38:36< mattsc> shadowm: ooo, turning off anti-aliasing makes things look much better.
20140406 01:39:29< mattsc> There seem to be a couple other issues though, do you mind if I ask for your advice on what can be done about them (or whether something should be done)?
20140406 01:40:00< shadowm> ... I don't think you turned off antialiasing.
20140406 01:41:09< mattsc> You’re right, I did the AA_GRAY thingy, same as in Windows…
20140406 01:41:24< mattsc> First problem I see is this:  http://imagebin.org/304025
20140406 01:41:40< shadowm> That'd be turning off RGB subpixel hinting.
20140406 01:41:58< mattsc> okay, sorry …  :|
20140406 01:42:08< shadowm> What's going on in the screenshot?
20140406 01:42:19< mattsc> Old version is at the bottom, new one at top.  I don’t like how things are bunched together like that at the top.
20140406 01:42:48< mattsc> I opened Wesnoth in two separate windows and put them on top of each other  :P
20140406 01:43:20< shadowm> Perhaps you need to play around with the pango_layout_set_spacing() call around text.cpp:120 ? (Note the linked forum post.)
20140406 01:44:01< mattsc> okay - I’ll look into that.
20140406 01:44:30< mattsc> Then there’s this:  http://imagebin.org/304026
20140406 01:44:48< mattsc> Any idea why the spacing in ‘Preferences’ seems so irregular?
20140406 01:45:13-!- sachith500 [~kvirc@112.134.89.200] has joined #wesnoth-dev
20140406 01:45:24< shadowm> No idea, and that dialog is GUI1, thus uses SDL_ttf and freetype instead of Pango and Cairo.
20140406 01:45:42< mattsc> okay …
20140406 01:45:57< shadowm> Here's how the tutorial introduction message renders for me with my current settings and platform: https://dl.dropboxusercontent.com/u/21371130/screenshots/wesnoth-1.13.0-font-rendering-ref-linux.png
20140406 01:46:54< shadowm> That's the Windows-like look I alluded to before -- full hinting.
20140406 01:47:33< mattsc> I see
20140406 01:48:11< mattsc> And the final one (that I have found so far):  http://imagebin.org/304027
20140406 01:48:26< mattsc> See how the text is misaligned w.r.t the buttons?
20140406 01:48:38< shadowm> Yeah.
20140406 01:49:06< shadowm> I'm not sure what could be causing that -- it might be related to the line height issue above.
20140406 01:49:27< mattsc> In the old version, if anything it was misaligned a little below center.
20140406 01:49:40< shadowm> Now, theoretically you shouldn't even have to change the pango_layout_set_spacing() call... I don't think it's supposed to yield different results on different platforms assuming the same dpi.
20140406 01:50:06< shadowm> And we override the platform's dpi in all cases, so... :\
20140406 01:51:03< shadowm> If Pango and Cairo continue to be antagonistic there you might need to talk with mordante about it.
20140406 01:51:47< mattsc> I just changed set_spacing to 3 * PANGO_SCALE and it makes no difference for either one of those issues.
20140406 01:52:10< shadowm> Perhaps it's ignoring some settings for some reason.
20140406 01:54:36< shadowm> After all, it's supposed to do part of the work with the platform's native font rendering API... Maybe the Pango/Cairo version(s) you have there are broken on OS X?
20140406 01:55:12< mattsc> Hmm, something’s weird.  I just changed the font size (a dozen or so lines above that) to 24, and that had no effect either…
20140406 02:01:22< mattsc> shadowm: just as an aside, I did upgrade SDL as well.
20140406 02:03:07< shadowm> What version?
20140406 02:05:17< vultraz> mattsc: quick question, are AIWML/MicroAIs the most up-to-date AI-related pages?
20140406 02:05:33< mattsc> shadowm: what the … ???
20140406 02:06:13< mattsc> shadowm: I’m going to hide somewhere again …
20140406 02:06:47< mattsc> vultraz: I’ve put quite a bit of effort into updating AiWML and MicroAIs (and keeping them up to date).
20140406 02:06:49< shadowm> Should I assume that means 2.0 with Wesnoth master?
20140406 02:07:13< mattsc> Only for SDL_ttf.  Also the other ones are 1.2.x
20140406 02:07:19< mattsc> s/Also/All
20140406 02:07:38< shadowm> No, SDL_ttf is good, it's just that its version numbering scheme is completely different to the other SDL libraries.
20140406 02:07:52< mattsc> Oh ...
20140406 02:08:24< shadowm> Here it's SDL_ttf 2.0.11, SDL_net 1.2.8, SDL_image 1.2.12, SDL_mixer 1.2.12, and SDL 1.2.15.
20140406 02:08:28< mattsc> In that case, SDL is 1.2.15.  SDL_ttf is 2.0.11
20140406 02:08:48< vultraz> mattsc: alright. Just that iceiceice mentioned that a lot of the other AI pages were out of date, and I'm not sure what to do now. I know nothing about the ai inner workings
20140406 02:09:03< mattsc> shadowm: yep, that’s exactly what I have
20140406 02:09:41< mattsc> vultraz: yeah, at some point I tried to summarize all of this here:  http://wiki.wesnoth.org/Practical_Guide_to_Modifying_AI_Behavior
20140406 02:10:05< mattsc> That page was up to date maybe 1.5 years ago, but I have not kept up with it as things were changing all the time.
20140406 02:10:07< vultraz> (oh, this reminds me of something)
20140406 02:10:43< mattsc> shadowm: yeah, so I seem to have exactly the same versions as you.
20140406 02:11:42< mattsc> shadowm: I do seem to be making modifications in the right part of the code.  Just changed the dpi setting and that’s definitely very noticeable.
20140406 02:14:14< vultraz> shadowm: should I create a section dedicated to the creation of custom GUI2 dialogs?
20140406 02:15:08< shadowm> Probably not, odds are it'll become out of date at some point and nobody will update it.
20140406 02:15:19< shadowm> Remember, GUI2 is a moving target, blah blah blah.
20140406 02:15:48< shadowm> But yeah, you are asking the wrong person. Your question really should be for mordante.
20140406 02:16:18< vultraz> Yeah, well I'm the one who's supposed to be the expert on custom gui2 dialogs
20140406 02:16:37< shadowm> How does that change anything?
20140406 02:17:01< shadowm> You asked "should I", not "can I".
20140406 02:17:14< mattsc> shadowm: oh, and set_spacing does have an effect on the lines in the dialog, just more subtly than I thought.  But setting it to 20 * PANGO_SPACE, it’s very clear.
20140406 02:17:26< mattsc> Does change the alignment inside the buttons though.
20140406 02:17:37< vultraz> I'd update it
20140406 02:18:02< shadowm> And then you get hit by a bus.
20140406 02:18:26< shadowm> Since it appears you already had an answer in mind and you were merely intent on wasting my time, do whatever you wish.
20140406 02:18:33< mattsc> s/Does/Does not
20140406 02:18:42< vultraz> I like asking people before doing it
20140406 02:18:51< shadowm> I already said you are asking the wrong person.
20140406 02:18:54< mattsc> Grrrr.  I really need to move on to some other things now, thanks for all the input, shadowm 
20140406 02:19:09< shadowm> mattsc: Okay, no problem.
20140406 02:19:11< aquileia> vultraz: It would be very nice if it explained [tooltip] and [helptip] which seem to be missing completely on the wiki...
20140406 02:19:22< mattsc> The growling was not at you, but at all the typos I am making trying to rush through things  :)
20140406 02:20:56< mattsc> So I know what to do about the line spacing.  No idea about the character spacing and button alignment so far, but 1/3 is better than 0/3 for starters.
20140406 02:21:00< mattsc> Bye for now.
20140406 02:22:08-!- Ivanovic_ [~ivanovic@x2f51b46.dyn.telefonica.de] has joined #wesnoth-dev
20140406 02:22:16< vultraz> aquileia: I never understood what [helptip] did
20140406 02:22:53< shadowm> Partially-implemented feature for a more detailed tooltip triggered by a keyboard shortcut instead of mouse-over.
20140406 02:24:33-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds]
20140406 02:26:19-!- Ivanovic_ [~ivanovic@x2f51b46.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20140406 02:26:22< vultraz> So why is it mandatory 
20140406 02:27:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140406 02:28:27< vultraz> Anyway, point being is that the GUI2 documentation is horrible opaque and hard to find
20140406 02:29:24< vultraz> However, if I make it known how to do it...more people will do it, and this destroy the uniqie nature of the campaign
20140406 02:29:29< vultraz> s/the/my
20140406 02:32:49< mattsc> vultraz: Well, Grnk Part 2 has a lot of innovative AI stuff in it - or stuff that would have been innovative and that is now all available in mainline in MAIs, while Grnk 2 is not out there yet.  Such is life.
20140406 02:34:02-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 265 seconds]
20140406 02:34:10< vultraz> SUch is the price of shared-platform developing
20140406 02:35:08-!- sachith500 [~kvirc@112.134.89.200] has quit [Ping timeout: 240 seconds]
20140406 02:35:12< shadowm> If uniqueness was your goal all along, then you made several glaring mistakes.
20140406 02:35:22< shadowm> Including stealing my code.
20140406 02:35:36< aquileia> mattsc: Grnk 2 will be awesome whether its AI code is unique or not!
20140406 02:35:41< shadowm> Code I specifically labeled so as to deter _you_.
20140406 02:35:53< vultraz> Yes, well stealing from giants will always help humans.
20140406 02:36:09< mattsc> vultraz: I wish you were right …  :P
20140406 02:36:22< vultraz> Unless you name is Jack
20140406 02:36:23< mattsc> oops, sorry, aquileia ^
20140406 02:37:50-!- Ivanovic [~ivanovic@x2f51b46.dyn.telefonica.de] has joined #wesnoth-dev
20140406 02:37:50-!- Ivanovic [~ivanovic@x2f51b46.dyn.telefonica.de] has quit [Changing host]
20140406 02:37:50-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140406 02:39:12< aquileia> Of course! What will it be this time... a mirror army with exactly the same units as you recruit... but twice? It's magic after all
20140406 02:40:23< aquileia> ... No, you don't fight against the army you created - you fight against two of them!
20140406 02:41:26< mattsc> aquileia: well, I can’t tell you, of course…  :)
20140406 02:41:43< aquileia> right...
20140406 02:42:06< mattsc> Grnk 2 was always supposed to be a little more mainstream (emphasis is on “a little”) than Part 1 - and as a result I don’t like it as much.  :P
20140406 02:42:28< mattsc> So I am reconsidering some parts, but the story as a whole likely won’t change.
20140406 02:44:20< vultraz> Grnk?
20140406 02:44:33< vultraz> Is this a goblin who doesn't know of vowels?
20140406 02:45:37< vultraz> And goes on the quest to find the Mythical Scroll of Vowels so his name may be pronounced like English and not ancient Egyptian?
20140406 02:46:19-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg]
20140406 02:46:34< vultraz> And along the way meets people such as the Master of Shadows and the Lord of Ice Times Three?
20140406 02:47:06< mattsc> Well, he definitely meets a Master.
20140406 02:47:24< vultraz> And they all showdown against the great Matt of SC?
20140406 02:49:53< mattsc> Let’s no go there.  Even Grnk doesn’t go there and he isn’t exactly used to a cushy life.  :D
20140406 03:11:54-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev
20140406 03:14:13< jamit> Did someone change the minimum supported Boost version?
20140406 03:14:49< jamit> I thought the minimum was 1.36, but BOOST_STATIC_ASSERT_MSG was added to Boot in 1.47.
20140406 03:15:03< jamit> (used in serialization/unicode.hpp)
20140406 03:15:40< jamit> Since I'm using Boost 1.40, trunk won't compile for me unless I change that line.
20140406 03:17:24< aquileia> AI0867: ^
20140406 03:22:13< aquileia> jamit: I guess AI0867 accidentally increased the requirement when creating his string conversion template
20140406 03:23:17< mattsc> jamit: yes (and it’s the reason why I started the whole Xcode upgrade thing)
20140406 03:23:50< mattsc> jamit: also, here’s a patch from AI0867 that fixes it: http://pastebin.com/
20140406 03:24:13< mattsc> uh …  Try this: http://pastebin.com/26CT6vUm
20140406 03:26:49< jamit> Better than the first link. :) So the minimum version will still be 1.36?
20140406 03:28:02-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140406 03:30:02< aquileia> That error is weird... http://pastebin.com/DFzX0ze3
20140406 03:30:31< aquileia> shouldn't __func__ be defined for any functions?
20140406 03:33:40< aquileia> or is it that test_control uses __func__ as well and the two conflict?
20140406 03:34:26< aquileia> if anyone wonders, it's in tests/gui/visitor.cpp
20140406 03:36:06< mattsc> jamit: well, you need to discuss that with AI0867.  I used it as an excuse to update Boost and everything else for Xcode (which was long overdue anyway), so it’s not an issue any more for OS X.
20140406 03:42:18< jamit> mattsc: I'll see what AI0867 has to say. I was surprised because I thought changes to compile requirements were discussed (or at least mentioned) on the mailing list.
20140406 03:45:18< mattsc> jamit: I don’ think this one was intentional (but I shouldn’t speak for AI either way)
20140406 03:49:57-!- cib0 [~cib@p5DD21679.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
20140406 03:55:53< iceiceice> shoot
20140406 03:56:04< iceiceice> i just realized i neglected to put a translation mark on a key string months ago...
20140406 03:56:06< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/playmp_controller.cpp#L577
20140406 04:01:54-!- cib0 [~cib@p5DD22847.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140406 04:02:26< aquileia> AI0867: In my compiler I just set "character set" to unicode... http://pastebin.com/iUNtuuWX
20140406 04:03:54< aquileia> I'll just revert it, but perhaps the error output might lead to where non-ASCII filenames are mishandled?
20140406 04:05:00< aquileia> It's not unlikely that fixing these would also  fix the bug, I think
20140406 04:19:27< iceiceice> Ivanovic: do you think its possible to break string freeze to get a string for this purpose? i fear that if we don't give users a message like this they could be very confused. i seriously doubt that there is a possible substitute string for "This side is in an idle state. To proceed with the game, the host must assign it to another controller."
20140406 04:27:18-!- exciton_ [chuck-the-@77.51.55.139] has joined #wesnoth-dev
20140406 04:31:08-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 240 seconds]
20140406 04:37:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140406 04:40:22-!- Necrosporus_ [~Necrospor@176.114.191.18] has joined #wesnoth-dev
20140406 04:43:27-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds]
20140406 04:49:43-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has quit [Quit: Page closed]
20140406 05:00:01-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140406 05:03:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Ciao]
20140406 06:12:00-!- exciton_ [chuck-the-@77.51.55.139] has quit [Read error: Connection reset by peer]
20140406 06:12:14-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140406 06:27:21-!- irker084 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140406 06:27:21< irker084> wesnoth: Chris Beck wesnoth:master 647c3e0c81fb / src/ (multiplayer_lobby.cpp playmp_controller.cpp): fixup user-displayed strings http://git.io/LQMYLQ
20140406 06:27:21< irker084> wesnoth: Chris Beck wesnoth:master f0519651222e / changelog: update changelog http://git.io/6T42NQ
20140406 06:36:00-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140406 06:52:05-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140406 07:01:06-!- dolphINshoes [~dolphINsh@46.229.231.211.vnet.sk] has joined #wesnoth-dev
20140406 07:04:15-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 252 seconds]
20140406 07:04:49< dolphINshoes> hi guys
20140406 07:05:11< dolphINshoes> how can I recall a unit using wml for different side?
20140406 07:05:39< dolphINshoes> in scenario 3, an ally unit (side 2) is made, and i wish to recall it for side 2 in scenario 4
20140406 07:06:04< dolphINshoes> playable side for player is side 1
20140406 07:12:55< vultraz> store it
20140406 07:14:04< dolphINshoes> how?
20140406 07:15:18< dolphINshoes> also... i am playing a scenario, where are few bugs and i am fixing it while playing it. problem is, that the shroud is used. how can i lift it off for side 1 and then get it back?
20140406 07:15:55< vultraz> if you want to get rid of shroud to look at something, type :debug and then :shroud
20140406 07:16:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140406 07:22:33-!- Necrosporus_ is now known as Necrosporus
20140406 07:24:02< Necrosporus> >  <AI0867>  // Why not to check on current codepage and iconv names into it if that's possible, if not use some way like %20 or maybe other replacement?
20140406 07:26:17< dolphINshoes> okay, thanks vultraz. now it looks like my villages are under shroud. so... i need to remove shroud from x,y 32,38
20140406 07:26:20< Necrosporus>  <mattsc> There are a whole bunch of possible ways to deal with this (go back to an older version of Growl, change the code in game_display.cpp, silence the warnings, …) all of which have their own advantages and disadvantages.  Any advice what I should do about this? // I think the right way is to replace functions to something which is not deprecated, but make sure it works with older version too or 
20140406 07:27:08< vultraz> there's a [remove_shroud] WML tag if you want to remove it from a specific location VIA code
20140406 07:27:21< Necrosporus> Or maybe it's better not to use it at all?
20140406 07:28:49-!- Coffee_irc [~david@ppp118-210-45-181.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140406 07:33:18< dolphINshoes> well, i need shroud to cover some areas with secret passageways, so only someone who want to find them will find them :)
20140406 07:35:38< dolphINshoes> works, many thanks :)
20140406 07:41:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140406 07:45:02-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140406 07:47:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140406 07:51:48-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140406 07:52:04< mordante> servus
20140406 07:52:11< Coffee_irc> hi mordante
20140406 07:52:32< mordante> hi Coffee_irc 
20140406 07:56:33-!- sachith500 [~kvirc@112.134.105.180] has joined #wesnoth-dev
20140406 07:59:05-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140406 08:00:29-!- cib0 [~cib@p5DD22847.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20140406 08:02:13< dolphINshoes> servus? mordante where are you from? :)
20140406 08:03:21< vultraz> Netherlands 
20140406 08:05:16< Coffee_irc> I thought mordante was from Germany?
20140406 08:08:17< vultraz> I heard he's Dutch but likes to talk German 
20140406 08:08:23< mordante> dolphINshoes, from the Netherlands, but servus is a southern German greeting
20140406 08:08:39< dolphINshoes> just asking... in slovakia or czech republic, servus is greeting as well :)
20140406 08:09:01< dolphINshoes> and we have some words similar from german :) so it makes sense :)
20140406 08:10:50< mordante> over here we also have words similar to German
20140406 08:10:58< Coffee_irc> the 2 countries are next to each other, so I suppose it makes sense
20140406 08:11:20< Coffee_irc> in Australia we'd just consider them states of the same country ;)
20140406 08:13:05< dolphINshoes> i have a cousin in Sydney :)
20140406 08:13:14< mordante> Coffee_irc, I'm not sure whether that is a good idea, somebody already tried that and it turned into a huge mess
20140406 08:13:33< dolphINshoes> and you have a bit more cangaroos than us, europeans... that makes me sad... :)
20140406 08:13:35< vultraz> P. Sherman 42 Wallaby Way Sydney 
20140406 08:15:10< dolphINshoes> okay, i am thinking about a movie... its about a father, whose all kids (except one) was murdered and just with help of an insane woman he swimmed the whole ocean to get to him...
20140406 08:16:43< vultraz> ;)
20140406 08:16:59-!- sachith500 [~kvirc@112.134.105.180] has quit [Read error: Connection reset by peer]
20140406 08:17:44< Coffee_irc> dolphINshoes: if that's some bad Australian film I admit we've inflicted suffering to cinema goers in the past :)
20140406 08:18:40< vultraz> Coffee_irc: it's Finding Nemo
20140406 08:18:56< dolphINshoes> yep :)
20140406 08:19:11< dolphINshoes> and Dory was GREAT!
20140406 08:20:21< dolphINshoes> btw my campaign is completed right now :) and looking for someone to play it and send a savegame how he played it :)
20140406 08:21:18< dolphINshoes> damn, my internet connection is working on 2kb/s :) just great :) 2kB is bad, but 2kb... :D
20140406 08:23:10< Coffee_irc> over in Europe I noticed (some years ago) that you get unlimited Internet, but a bit slow
20140406 08:24:52< dolphINshoes> and now imagine 600 people in one building and 300 of them are surfing at once :)
20140406 08:25:51< dolphINshoes> and does anyone of you have wesnoth 1.11.x installed and some time to play it? :)
20140406 08:26:23< Coffee_irc> dolphINshoes: if you are looking for playtesters the forums would be more appropriate
20140406 08:26:41< Coffee_irc> believe it or not lots of us here can't really play that well
20140406 08:27:24< Coffee_irc> you'll find it difficult to get 1.11.x playtesters though
20140406 08:28:16< Coffee_irc> soon(ish) we'll release 1.12 and you'll be able to find more players willing to get you replays
20140406 08:28:19< dolphINshoes> well, 1.12 will be online shortly, we have beta 3 :)
20140406 08:31:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140406 08:38:25-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140406 08:49:30-!- mjs-de [~mjs-de@f053177011.adsl.alicedsl.de] has joined #wesnoth-dev
20140406 08:50:22< dolphINshoes> what will SDL2 change?
20140406 08:50:39< dolphINshoes> will it still work on slower older computers i hope :)
20140406 08:53:01< Coffee_irc> dolphINshoes: http://tech.slashdot.org/story/13/08/13/1235207/sdl-20-release-improves-2d3d-rendering-better-audio-new-features
20140406 08:54:20< Coffee_irc> dolphINshoes: wesnoth is not really that resource hungry a game (or shouldn't be anyway)
20140406 08:54:50< Coffee_irc> you could probably get it to work fine on a raspberry pi
20140406 08:56:40< dolphINshoes> core 2 duo with old intel graphics mean... problem or no problem? :)
20140406 08:57:33< dolphINshoes> current wesnoth works good
20140406 08:58:15< Coffee_irc> dolphINshoes: I would think that SDL 2.0 would make it run faster
20140406 08:59:02< mordante> Coffee_irc, Wesnoth is rather resource hungry at times, large screen resolutions are getting slow
20140406 09:00:05< Coffee_irc> well that might be alleviated by your student's sprite sheet project ;)
20140406 09:01:27< mordante> I doubt that ;-) That won't make the drawing itself faster
20140406 09:01:59< Coffee_irc> mordante: I suppose, but it would consolidate the textures into memory for drawing
20140406 09:02:45< mordante> it will mainly improve the loading speed and reduce the number of files
20140406 09:04:10< Coffee_irc> mordante: I don't know how the drawing is done now, but reading textures directly from surfaces might improve the rendering speed
20140406 09:04:27< Coffee_irc> if not done already
20140406 09:05:00< mordante> Coffee_irc, the image are already cached upon loading, but every image is loaded individually
20140406 09:05:35< mordante> the goal of the sprite sheets is to load a sheet and then 'cut out' the individual images
20140406 09:05:52< mordante> so less files are loaded
20140406 09:06:05< mordante> I expect more improvements from switching to SDL2
20140406 09:06:13< mordante> Aishiko, around?
20140406 09:26:45< mordante> AI0867, where are the bit_width functions used?
20140406 09:34:00< mordante> wesbot, seen ALourenco
20140406 09:34:00< wesbot> mordante: Person, who 13d 12h ago used nick ALourenco, last spoke 10d 14h ago.  6d 10h ago as ALourenco_ they left with the message: Ping timeout: 245 seconds
20140406 09:48:33-!- neXyon [~neXyon@85-127-180-55.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140406 10:05:37-!- mjs-de [~mjs-de@f053177011.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140406 10:17:18-!- dolphINshoes [~dolphINsh@46.229.231.211.vnet.sk] has quit [Ping timeout: 255 seconds]
20140406 10:27:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140406 10:58:34-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140406 11:11:11-!- spoffy [~spoffy@host-80-47-182-18.as13285.net] has joined #wesnoth-dev
20140406 11:21:21-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 268 seconds]
20140406 11:28:38-!- spoffy [~spoffy@host-80-47-182-18.as13285.net] has quit [Ping timeout: 240 seconds]
20140406 11:30:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140406 11:32:41-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140406 11:53:03-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140406 11:53:19-!- exciton [chuck-the-@77.51.55.139] has joined #wesnoth-dev
20140406 11:55:21-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20140406 11:59:06-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140406 12:07:32-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20140406 12:34:49-!- bagzie [~bag@85-76-84-29-nat.elisa-mobile.fi] has joined #wesnoth-dev
20140406 12:43:36-!- gfgtdf [~chatzilla@f054168198.adsl.alicedsl.de] has joined #wesnoth-dev
20140406 12:45:05-!- mjs-de [~mjs-de@f053177011.adsl.alicedsl.de] has joined #wesnoth-dev
20140406 12:48:35-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140406 12:49:21-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has joined #wesnoth-dev
20140406 12:56:11-!- gfgtdf [~chatzilla@f054168198.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]]
20140406 13:00:45-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140406 13:11:02< irker084> wesnoth: Mark de Wever wesnoth:master 050085622037 / src/sdl/ (texture.cpp texture.hpp): Improve code formatting. http://git.io/Z-X0qg
20140406 13:11:04< irker084> wesnoth: Mark de Wever wesnoth:master 1ad329c114de / src/sdl/ (texture.cpp texture.hpp): Use a SDL_Surface* instead of a surface. http://git.io/APm-cw
20140406 13:11:06< irker084> wesnoth: Mark de Wever wesnoth:master bf20045ecdfc / src/sdl/texture.cpp: Initialise a member in the initialiser list. http://git.io/hgBaPg
20140406 13:11:08< irker084> wesnoth: Mark de Wever wesnoth:master 3afebbb988d7 / src/sdl/ (texture.cpp texture.hpp): Remove the keep_surface parameter. http://git.io/2P9fTg
20140406 13:11:10< irker084> wesnoth: Mark de Wever wesnoth:master 210eb6a7a092 / src/sdl/texture.cpp: Improve exception path. http://git.io/nCyuqw
20140406 13:11:12< irker084> wesnoth: Mark de Wever wesnoth:master abe73ab915b7 / src/sdl/texture.cpp: Check the result of SDL_UpdateTexture. http://git.io/ZiZClw
20140406 13:11:14< irker084> wesnoth: Mark de Wever wesnoth:master 345fc7f9de50 / src/sdl/ (texture.cpp texture.hpp): Change order of parameters in constructor. http://git.io/LGKScg
20140406 13:11:16< irker084> wesnoth: Mark de Wever wesnoth:master e1d054d6ff5d / src/sdl/texture.hpp: Improve documentation. http://git.io/UWucYg
20140406 13:11:18< irker084> wesnoth: Mark de Wever wesnoth:master 6d4545df783c / src/sdl/texture.cpp: Change destruction order. http://git.io/aZIERA
20140406 13:11:20< irker084> wesnoth: Mark de Wever wesnoth:master f583f616f041 / src/sdl/ (texture.cpp texture.hpp): Merge branch 'SDL_Texture_polishing' http://git.io/_DpFfg
20140406 13:27:01< mordante> I'm off bye
20140406 13:27:04-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140406 13:34:20-!- exciton [chuck-the-@77.51.55.139] has quit [Read error: Connection reset by peer]
20140406 13:34:34-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140406 13:46:17< Necrosporus> AI0867, but other programs on C++ somehow do solve problem of filenames. Why not to pick one or two and examine it?
20140406 13:46:20-!- spoffy [~spoffy@94.117.52.174] has joined #wesnoth-dev
20140406 13:48:16-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140406 13:53:38-!- spoffy [~spoffy@94.117.52.174] has quit [Ping timeout: 240 seconds]
20140406 14:03:11-!- trewe [~trewe@78.137.221.92] has joined #wesnoth-dev
20140406 14:24:01-!- Kexoth [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140406 14:24:37-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140406 14:26:08-!- Kexoth [~kex@89.205.75.19] has quit [Read error: Connection reset by peer]
20140406 14:26:17-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140406 14:27:23< AI0867> 05:14 < jamit> I thought the minimum was 1.36, but BOOST_STATIC_ASSERT_MSG was added to Boot in 1.47. ← weird. Ivanovic could (cross-)compile it for pandora using boost 1.41
20140406 14:37:43< Necrosporus> There's seem to be a bug in multiplayer on 1.10.7, as leader changes if shuffle side is selected
20140406 14:39:44< Necrosporus> or maybe not a bug? But leader was selected and when game started it was other than was selected
20140406 15:00:54< vultraz> iceiceice: thanks for compiling a list of some of the outdated ai pages :)
20140406 15:05:10< vultraz> wow, ok, there's a lot more pages on the Python AI stuff than I thought
20140406 15:07:35< vultraz> Ok, I'll just get rid of them all
20140406 15:07:58< iceiceice> thank you vultraz for this spring cleaning wiki push :)
20140406 15:08:10< iceiceice> i remember a few months ago i tried to learn about ai from the wiki and it was very frustrating...
20140406 15:08:23< iceiceice> i'm not sure if i would have done anything about it if there wasnt this larger push though
20140406 15:10:59-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140406 15:12:37< vultraz> Rofl. Someone actually named a page this... http://wiki.wesnoth.org/WhyWritingAWesnothAIIsHard
20140406 15:13:55-!- _8680_ [~8680@2002:4404:712c:0:24cc:9d45:1b90:608a] has quit [Ping timeout: 246 seconds]
20140406 15:15:08-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140406 15:15:09-!- _8680_ [~8680@2002:4404:712c:0:c419:8296:9abb:eab5] has joined #wesnoth-dev
20140406 15:16:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140406 15:20:07< iceiceice> haha
20140406 15:20:10< iceiceice> yeah it looks like Dave made that
20140406 15:20:14< iceiceice> its a pretty good page actually
20140406 15:22:16-!- pyromancer2 [~pyromance@130.68.246.9] has joined #wesnoth-dev
20140406 15:22:37-!- pyromancer2 [~pyromance@130.68.246.9] has left #wesnoth-dev []
20140406 15:22:56< vultraz> iceiceice: http://wiki.wesnoth.org/AI_Module
20140406 15:23:01< vultraz> seems pretty AI C++ useful
20140406 15:23:22< iceiceice> yeah, its in my list...
20140406 15:23:35< iceiceice> problem is it looks pretty out of date, i think it only accounts for a subset of files
20140406 15:23:48< iceiceice> and some of the content looks like placeholder
20140406 15:30:57-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 255 seconds]
20140406 15:42:15< AI0867> 06:02 < aquileia> AI0867: In my compiler I just set "character set" to unicode... http://pastebin.com/iUNtuuWX ← 'unicode' probably means UTF-8. which means you've just spotted the places where we pass const char* to a #define that takes const char* under ANSI, and const wchar_t* under UNICODE
20140406 15:42:36< AI0867> it's still a misuse of the API, but not the cause of our bugs
20140406 15:44:04< AI0867> 09:24 < Necrosporus> >  <AI0867>  // Why not to check on current codepage and iconv names into it if that's possible, if not use some way like %20 or maybe other  replacement? ← I recently found that save_index actually does something like that, but only for savefile names as stored in the index
20140406 15:45:29-!- neXyon [~neXyon@85-127-180-55.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20140406 15:47:56-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140406 15:48:22< AI0867> and for those who were wondering? boost::filesystem v3 wasn't really added until 1.46. Debian stable supports that now, but that'd mean ivanovic would have to statically link boost into his pandora builds from now on
20140406 15:48:54< AI0867> maybe for 1.13
20140406 16:00:59< AI0867> 11:26 < mordante> AI0867, where are the bit_width functions used? ← src/serialization/unicode.cpp, in byte_size_from_utf8_first
20140406 16:01:55< AI0867> Necrosporus: yes, they mostly just use the W-suffixed w32 API functions. We don't
20140406 16:02:11< AI0867> 15:46 < Necrosporus> AI0867, but other programs on C++ somehow do solve problem of filenames. Why not to pick one or two and examine it? ← in reply to this
20140406 16:03:05< AI0867> aquoops, I meant UTF-16 there
20140406 16:03:16< AI0867> aquileia: oops, I meant UTF-16 there
20140406 16:11:22-!- irker084 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140406 16:12:09< Necrosporus> AI0867, maybe one should use some ifdef macro, so w32 api for windows and standard function for rest of the world
20140406 16:12:37< Necrosporus> Or some reminder in installation and some way to guarantee there's no non-ascii chars in path
20140406 16:14:08-!- jamit [~jamit@wesnoth/developer/jamit] has quit [Ping timeout: 240 seconds]
20140406 16:16:06-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev
20140406 16:18:28-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140406 16:21:44-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140406 16:25:55-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140406 16:26:04< AI0867> http://www.boost.org/doc/libs/1_55_0/libs/locale/doc/html/default_encoding_under_windows.html ← hmm
20140406 16:26:22-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140406 16:26:29< AI0867> I do believe I tried something similar
20140406 16:28:05< AI0867> ah: http://www.boost.org/doc/libs/1_55_0/libs/locale/doc/html/running_examples_under_windows.html
20140406 16:28:38-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140406 16:28:41< lipkab> mordante: Are you sure 1ad329c114de is a good idea? Now if you query a surface pointer, you can't store it because it can get invalidated at any moment.
20140406 16:37:34< AI0867> mordante: err, the bit_width functions themselves are used by the (backup implementations of the) count_leading_zeros functions and the like
20140406 16:44:08-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140406 16:45:24-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140406 16:56:48-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140406 16:57:10-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140406 16:59:08< jamit> AI0867: That is weird. The Boost documentation does not describe BOOST_STATIC_ASSERT_MSG until 1.47.
20140406 16:59:36< jamit> AI0867: Maybe it was introduced earlier? It is not in my 1.40 version of Boost.
20140406 17:00:18< AI0867> http://www.boost.org/doc/libs/1_41_0/doc/html/boost_staticassert.html
20140406 17:01:10< AI0867> indeed looks like it was introduced in 1.47
20140406 17:01:32< AI0867> I'll change it to the regular macro
20140406 17:06:07-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140406 17:08:24< jamit> OK. So I don't need to upgrade Boost yet. :)
20140406 17:10:38-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140406 17:11:40-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140406 17:17:40-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 252 seconds]
20140406 17:19:29< shadowm> wesbot: seen Dugi
20140406 17:19:30< wesbot> shadowm: The person with the nick Dugi last spoke 2d 20h ago.  2d 17h ago they left with the message: Ping timeout: 245 seconds
20140406 17:19:31< shadowm> wesbot: seen Dugi_
20140406 17:19:33< wesbot> shadowm: Person, who 4d 18h ago used nick Dugi_, last spoke 2d 20h ago.  2d 17h ago as Dugi they left with the message: Ping timeout: 245 seconds
20140406 17:19:39-!- Kexoth [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140406 17:20:12-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140406 17:22:06-!- irker750 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140406 17:22:06< irker750> wesnoth: Alexander van Gessel wesnoth:master b542e8193a83 / src/serialization/unicode.hpp: Don't use BOOST_STATIC_ASSERT_MSG before 1.47 http://git.io/JMrnkA
20140406 17:22:58< AI0867> jamit: ^
20140406 17:24:48-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 255 seconds]
20140406 17:28:13< AI0867> aquileia: https://github.com/AI0867/wesnoth/tree/w32_unicode_compilation ← can you check if this helps?
20140406 17:48:52-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140406 18:01:56-!- travis-ci [~travis-ci@ec2-54-227-135-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20140406 18:01:56< travis-ci> [travis-ci] AI0867/wesnoth#22 (w32_unicode_compilation - 4e0ed70 : Alexander van Gessel): The build passed.
20140406 18:01:56< travis-ci> [travis-ci] Build details : http://travis-ci.org/AI0867/wesnoth/builds/22392069
20140406 18:01:56-!- travis-ci [~travis-ci@ec2-54-227-135-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20140406 18:14:43-!- aquileia [4e2ad392@gateway/web/freenode/ip.78.42.211.146] has joined #wesnoth-dev
20140406 18:16:40-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140406 18:18:31< aquileia> AI0867: I can verify that the first and third fix work, but SHGetSpecialFolderPathA isn't recognized
20140406 18:19:07-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140406 18:19:45< AI0867> that's weird
20140406 18:20:04-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140406 18:20:04< aquileia> The problem seems to be that SHGetSpecialFolderPath is defined a few lines above
20140406 18:20:45< aquileia> Is there a variant for SHGSFPAddress?
20140406 18:24:45-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 255 seconds]
20140406 18:28:56< AI0867> hmm, let's see
20140406 18:29:49< aquileia> just out of interest, what's the problem with  LPTSTR my_documents_path ?
20140406 18:29:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140406 18:30:32< AI0867> LPTSTR is LP (long pointer) to TSTR (TCHAR*)
20140406 18:30:42< AI0867> TCHAR is wchar_t on UNICODE, and char on ANSI
20140406 18:31:05< AI0867> so we'd have to convert things later on
20140406 18:32:55< AI0867> aquileia: updated the branch
20140406 18:33:43< AI0867> amusingly, it was already asking the DLL for the A version. It just used a variable prototype
20140406 18:33:52-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 246 seconds]
20140406 18:37:22< AI0867> as for why not LPTSTR, I'd prefer to either use a library or just use straight LPWSTR.
20140406 18:38:52< aquileia> AI0867: the wesnothlib build is fixed, I'll now build wesnoth and see whether it fixes the bug
20140406 18:39:56< AI0867> I would be very surprised if it did
20140406 18:40:30< AI0867> but it's good practice nonetheless
20140406 18:40:47< aquileia> It will take a long time though... unresolved external symbols, it needs a clean new build
20140406 18:40:51< AI0867> using ANSI encodings is backwards compatibility to the previous century
20140406 18:46:27< aquileia> oh, and by the way the compiler complains that the UNICODE macro is defined in windows_tray_notification.hpp, desktop_util, and 
20140406 18:46:51< aquileia> in windows_tray_notification.hpp and desktop_util
20140406 18:47:02-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140406 18:47:14< aquileia> it's only a warning, but...
20140406 18:53:45< aquileia> AI0867: I forgot to remark that line 528 needed an A suffix as well
20140406 18:56:11-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 265 seconds]
20140406 18:58:35< AI0867> aquileia: pushed.
20140406 18:58:55< AI0867> does it complain about UNICODE being defined twice or is there a #warning in one of those headers?
20140406 18:59:53< aquileia> warning C4005: 'UNICODE' : macro redefinition   windows_tray_notification.hpp
20140406 18:59:57< aquileia> so it
20140406 19:00:08< aquileia> 's a compiler warning
20140406 19:03:13< aquileia> AI0867: As you guessed the bug  persists, but at least the build with unicode is fixed now
20140406 19:04:02< AI0867> okay, added an extra commit that should silence that warning
20140406 19:04:29< AI0867> if you can confirm that everything works, I'll merge that into master
20140406 19:08:12< aquileia> everything's ok
20140406 19:11:33< irker750> wesnoth: Alexander van Gessel wesnoth:master 0b3142785409 / src/ (filesystem.cpp filesystem_win32.ii): Fix some win32 API usage http://git.io/rWX5DA
20140406 19:11:35< irker750> wesnoth: Alexander van Gessel wesnoth:master 724adc4ddceb / src/ (desktop_util.cpp windows_tray_notification.hpp): Silence a macro redefinition warning http://git.io/OVjVeg
20140406 19:11:37< irker750> wesnoth: Alexander van Gessel wesnoth:master a29ba939b76e / src/ (4 files): Merge branch 'w32_unicode_compilation' http://git.io/V0Knlw
20140406 19:17:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140406 19:22:59-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20140406 19:26:34-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140406 19:29:08-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140406 19:29:44-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140406 19:41:28-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 268 seconds]
20140406 19:42:31-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140406 19:46:15-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Client Quit]
20140406 19:47:03-!- gfgtdf [~chatzilla@f054168198.adsl.alicedsl.de] has joined #wesnoth-dev
20140406 19:47:09< gfgtdf> wesbot: seen iceiceice
20140406 19:47:09< wesbot> gfgtdf: The person with the nick iceiceice last spoke 4h 23m ago.  3h 18m ago they left with the message: Quit: Leaving
20140406 19:47:10-!- spoffy [~spoffy@host86-183-62-54.range86-183.btcentralplus.com] has joined #wesnoth-dev
20140406 19:50:09-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140406 19:51:03< aquileia> Aishiko: Do you consider the "Support variable recall cost in wml" EasyCoding task completed?
20140406 20:01:24-!- mjs-de [~mjs-de@f053177011.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds]
20140406 20:06:09-!- mjs-de [~mjs-de@f053048085.adsl.alicedsl.de] has joined #wesnoth-dev
20140406 20:08:22-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140406 20:12:33-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140406 20:12:36-!- spoffy [~spoffy@host86-183-62-54.range86-183.btcentralplus.com] has quit [Quit: Leaving]
20140406 20:22:07-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140406 20:32:05-!- _8680_ [~8680@2002:4404:712c:0:c419:8296:9abb:eab5] has quit [Ping timeout: 246 seconds]
20140406 20:33:27-!- _8680_ [~8680@2002:4404:712c:0:b8f2:1639:bbd0:fbd4] has joined #wesnoth-dev
20140406 20:37:24-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has joined #wesnoth-dev
20140406 20:38:10< Dugi> shadowm_desktop: Were you looking for me?
20140406 20:41:00-!- gfgtdf_ [~chatzilla@f054168198.adsl.alicedsl.de] has joined #wesnoth-dev
20140406 20:44:02-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140406 20:48:25-!- Netsplit *.net <-> *.split quits: gfgtdf, trademark_, Ardonik, timotei_
20140406 20:49:07-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140406 20:52:08-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has quit [Ping timeout: 240 seconds]
20140406 20:54:41-!- Netsplit over, joins: Ardonik
20140406 20:55:44-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140406 20:56:05-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has joined #wesnoth-dev
20140406 20:57:39-!- jamit [~jamit@wesnoth/developer/jamit] has quit [Ping timeout: 255 seconds]
20140406 21:04:42-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev
20140406 21:05:19-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140406 21:06:57< shadowm> Dugi: mordante was, see the logs.
20140406 21:07:18-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has quit [Ping timeout: 245 seconds]
20140406 21:08:46< shadowm> Okay then. I don't have time for this.
20140406 21:12:09< gfgtdf_> jamit: in movements, was there a special reason why we acted different in replays than in orignal game? (is is_replay_ variable) I assumed that was a leftover from the time when vision wasn't calculated correctly during replays so i disables it, but i thought it might be a good idea to ask you before i remove it.
20140406 21:12:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140406 21:20:42-!- gfgtdf [~chatzilla@d221137.adsl.hansenet.de] has joined #wesnoth-dev
20140406 21:22:37-!- gfgtdf_ [~chatzilla@f054168198.adsl.alicedsl.de] has quit [Ping timeout: 252 seconds]
20140406 21:22:43-!- spoffy [~spoffy@host86-183-62-54.range86-183.btcentralplus.com] has joined #wesnoth-dev
20140406 21:23:53< spoffy> Hey trade!
20140406 21:24:09< spoffy> .....That was meant to be in a dialog. *Whistles tunelessly*
20140406 21:31:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140406 21:39:27-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 252 seconds]
20140406 21:48:05< iceiceice> Vultraz: Do you think we should use this?
20140406 21:48:06< iceiceice> http://wiki.wesnoth.org/Category:Candidates_for_deletion
20140406 21:48:29< iceiceice> its kind of pointless for me to propose deletion of things with http links on forum
20140406 21:48:43< iceiceice> vultraz: ^^
20140406 21:51:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20140406 21:56:04-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has joined #wesnoth-dev
20140406 21:56:25-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140406 21:56:40< Dugi> Oops, I joined #wesnoth.dev instead of #wesnoth-dev and wondered why I saw no activity there.
20140406 21:59:28< jamit> gfgtdf: As I recall is_replay_ is supposed to override some checks in an attempt to keep replays in sync.
20140406 22:00:25< jamit> gfgtdf: It can help a replay keep going, even if something else is out of sync. I do not recall it ever being related to vision specifically.
20140406 22:00:49< jamit> err.. strike "ever" in that, since it predates when I started messing with movement.
20140406 22:01:06-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 255 seconds]
20140406 22:01:49< jamit> gfgtdf: Disabling it is probably a bad idea and I would not recommend disabling it for the sake of disabling something.
20140406 22:02:19< gfgtdf> but does it realy make sense to continue replay in that case? I mean woudn't it be better to let the viewer know that we have an OOS ?
20140406 22:02:41< iceiceice> it sounds like if the system has changed enough it could also cause oos
20140406 22:02:52< gfgtdf> jamit: becasue it think especialy if one want to know when a oos happend it might be better to let him know rather soonet than later
20140406 22:03:24< gfgtdf> iceiceice: what do you mean ? 
20140406 22:03:55< gfgtdf> s/it/i
20140406 22:04:54< iceiceice> i mean obviously its better if as few command as possible are checking "is_replay_" because we want everything to work the same regardless to the extent possible
20140406 22:05:21< iceiceice> but i dont know the code you are mentioning
20140406 22:05:32< gfgtdf> iceiceice: ah ye that what i thought too.
20140406 22:06:40-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140406 22:06:53< shadowm> Dugi: Did you rea the logs?
20140406 22:07:07< Dugi> shadowm: No. I'll check'em out.
20140406 22:07:33< jamit> gfgtdf: The user probably had already been told that an OOS happened, and the player opted to try to continue the replay.
20140406 22:07:33< shadowm> _Always_ read the logs. mordante left you a few messages yesterday or so.
20140406 22:07:33< jamit> gfgtdf: If you can find a case where movement is the first symptom of OOS, and that flag is suppressing a message to the player, then there would be something to look at.
20140406 22:08:53< Dugi> shadowm: I have read it.
20140406 22:15:50< gfgtdf> jamit: I have already diabled (but not deleted) is_replay_ (that doent mean i coudn't reenable it)  and i didn't get problems with it. And the only case when that's could be useful is when something went out of sync. Also is_replay_ is also used in mp replays wich can result in players can move though an ambush in mp without the other player getting a notification.
20140406 22:16:42< jamit> gfgtdf: How does that allow players to mover through an ambush?
20140406 22:19:06< jamit> gfgtdf: That sounds like a rather serious bug that should not be papered over by disabling is_replay_.
20140406 22:19:16-!- ALourenco_ [c189db30@gateway/web/freenode/ip.193.137.219.48] has joined #wesnoth-dev
20140406 22:19:44< gfgtdf> jamit: i havent tested it but accorign to https://github.com/wesnoth/wesnoth/blob/master/src/actions/move.cpp#L665 ambush is diables during replays, and the other player can just send him a [move] which moves though the ambush without teh first player chacks it
20140406 22:19:50< ALourenco_> hello
20140406 22:19:53< ALourenco_> have good news
20140406 22:20:17< ALourenco_> my new laptop has already been ordered and I have next week free, so I can start working on wesnoth
20140406 22:20:40< gfgtdf> jamit: also move_unit doesnt check wether the unit has enough movepoints left
20140406 22:25:03< Dugi> wesbot: seen mordante
20140406 22:25:03< wesbot> Dugi: The person with the nick mordante last spoke 8h 58m ago.  8h 58m ago was here and on the channel #wesnoth-de with the message: Quit: Leaving
20140406 22:25:05< gfgtdf> iceiceice: do you know a good file upload platform? (to upload a savefile)
20140406 22:25:22-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140406 22:25:33-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140406 22:25:47-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140406 22:25:53< iceiceice> shadowm: before i forget
20140406 22:26:05< iceiceice> i merged a PR from Duthlet like a week and a half ago which was his first commit
20140406 22:26:24< iceiceice> iiuc i'm supposed to tell you or ivanovic or someone to mark him as code & wml contributor in forums
20140406 22:26:38< iceiceice> i pm'd ivanovic like a week ago but i guess he didn't get it
20140406 22:26:49< gfgtdf> jamit: look at this savefile and replay it: http://pastebin.com/rQ9X18z7, te same can heppen in mp
20140406 22:27:40< gfgtdf> (it has nothing to do with is_replay_ i think, but im not sure.)
20140406 22:28:04< gfgtdf> replay it with 1.11.11
20140406 22:28:14< gfgtdf> or 1.12
20140406 22:30:58-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140406 22:32:06< jamit> gfgtdf: I have neither a 1.11.11 nor a 1.12 checkout at the moment. If your changes are already in trunk, please make a Gna bug report so I can get back to this after I set those up.
20140406 22:33:20< jamit> anyone: Does anyone have a guess off the top of their head why my test campaign cannot find its first scenario after I copied it from 1.11 to 1.13?
20140406 22:34:18-!- travis-ci [~travis-ci@ec2-54-205-122-91.compute-1.amazonaws.com] has joined #wesnoth-dev
20140406 22:34:18< travis-ci> [travis-ci] AI0867/wesnoth#27 (boost_filesystem_win - bbb83d3 : Alexander van Gessel (AI0867)): The build failed.
20140406 22:34:18< travis-ci> [travis-ci] Build details : http://travis-ci.org/AI0867/wesnoth/builds/22407582
20140406 22:34:18-!- travis-ci [~travis-ci@ec2-54-205-122-91.compute-1.amazonaws.com] has left #wesnoth-dev []
20140406 22:34:18< jamit> I didn't see anything in the changelog that looked like the culprit, but I could have missed something.
20140406 22:34:22< AI0867> aquileia: here's my boost branch: https://github.com/AI0867/wesnoth/compare/boost_filesystem_win
20140406 22:34:30< Coffee_irc> jamit: have you checked the config file for a static path set?
20140406 22:34:47< jamit> "static" path set?
20140406 22:35:09< Coffee_irc> _main.cfg with a defined 'binary_path'
20140406 22:36:21< jamit> Yes, _main.cfg defines a binary path. Why is that "static"?
20140406 22:36:33< Coffee_irc> jamit: to check you could create an alias or soft link to the old folder in the 1.13 version to the 1.11 version
20140406 22:37:07< AI0867> aquileia: make that https://github.com/AI0867/wesnoth/compare/boost_filesystem
20140406 22:37:10< Coffee_irc> works for me whilst there are no compatibility issues between 1.11 and 1.13 for my addon
20140406 22:38:27< jamit> Coffee_irc: To be more precise, I did not actually copy my test campaign. I made a soft link to the the version sitting in my 1.10 directory. (Which is also soft linked to my 1.11 directory. It's not exactly 1.10 compatible at the moment, but still loads under 1.10.)
20140406 22:38:39< jamit> So, already done. ;)
20140406 22:39:22< Coffee_irc> jamit: no idea then why it wouldn't work
20140406 22:39:55< Coffee_irc> unless it is something to do with the merging of multiplayer and single player campaigns
20140406 22:40:10< aquileia> AI0867: Hmm, too much code for me to eeven consider reading through all of it...
20140406 22:40:13-!- travis-ci [~travis-ci@ec2-54-205-122-91.compute-1.amazonaws.com] has joined #wesnoth-dev
20140406 22:40:13< travis-ci> [travis-ci] AI0867/wesnoth#28 (boost_filesystem - bbb83d3 : Alexander van Gessel (AI0867)): The build failed.
20140406 22:40:13< travis-ci> [travis-ci] Build details : http://travis-ci.org/AI0867/wesnoth/builds/22407905
20140406 22:40:13-!- travis-ci [~travis-ci@ec2-54-205-122-91.compute-1.amazonaws.com] has left #wesnoth-dev []
20140406 22:40:16< aquileia> but: https://github.com/AI0867/wesnoth/compare/boost_filesystem#diff-a03424219939aade3192ff3e761ed89dR348
20140406 22:40:36< aquileia> you might want to apply your patch  there as well
20140406 22:40:53< Coffee_irc> need to head off here
20140406 22:44:22-!- mjs-de [~mjs-de@f053048085.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140406 22:44:23< aquileia> AI0867: Where does travis get boost from?
20140406 22:45:50< AI0867> APT
20140406 22:47:26< jamit> Strange, now my test campaign loads. Not sure what I did. I thought I just added some logging to figure out what it was choking on.
20140406 22:47:56< shadowm> iceiceice: Link?
20140406 22:48:23< shadowm> Dugi: mordante reads the logs, so if you need to tell him something just leave it here.
20140406 22:49:57< Dugi> shadowm: Uhm, okay, I'll reply.
20140406 22:50:58< Dugi> mordante: I know you aren't here, but it seems that we rarely visit in the same hour. I'll just reply now, I was told you read the logs. My only possible alternative nickname is Dugi_ when something goes wrong.
20140406 22:52:44< Dugi> mordante: I don't know which implementation details are you missing, can you ask questions to explain what are you missing? It seems to be detailed enough for now to me, so I want to know why I am wrong to think so.
20140406 22:56:23< Dugi> mordante: I expect to finish it all during the summer, the point isn't to allow all possible things that can be done in WML (because that is already programming and a wizard isn't for that), just the basics. If I'll lack time, I'll just leave out things like EffectWML that aren't necessary to be there. But I think that I can do it all, the add-on reviews' system took me so much time because I needed to study large parts of the cod
20140406 22:57:27< Dugi> mordante: The campaign wizard would affect the existing files much less, meaning that I would mostly work with my own codes.
20140406 23:05:38-!- travis-ci [~travis-ci@ec2-54-227-135-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20140406 23:05:38< travis-ci> [travis-ci] AI0867/wesnoth#29 (boost_filesystem - e21d079 : Alexander van Gessel): The build passed.
20140406 23:05:38< travis-ci> [travis-ci] Build details : http://travis-ci.org/AI0867/wesnoth/builds/22407965
20140406 23:05:38-!- travis-ci [~travis-ci@ec2-54-227-135-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20140406 23:06:04< happygrue> Dugi: I haven't followed your exchanges fully with mordante, but if he's asking for implementation details I would guess he's asking you to expand on what you have on the wiki for question 4.5.  Perhaps making a whole section about it.  That is the meat of the proposal right there -what challenges are there, how are you going to implement them.  Saying more than "there will be a GUI" is ideal.  Mockup images could be done.  Have you 
20140406 23:06:04< happygrue> spoken to fabi about what already exists?  IIRC he has some tool that already has some of the functionality you are talking about there.
20140406 23:06:13< happygrue> I could be wrong, just some thoughts after a glance at your wiki.
20140406 23:07:20< happygrue> you could look at what some of the other proposals look like for that section to get an idea if you are really stumped for inspiration.
20140406 23:07:41< happygrue> (not just for that project, I mean in general)
20140406 23:10:56< Dugi> happygrue: Looking at most other proposals, most of them have less information than mine, but the spritesheet one has a good description. I will elaborate the description of the GUI more, then.
20140406 23:11:18< happygrue> Dugi: the key thing to remember is that "most" will also not be accepted.  ;)
20140406 23:12:32< Dugi> happygrue: I know. But the sprite sheet one seems to be going to be accepted. Though I find that idea really bad and hope that it will not get accepted (nothing personal against that guy).
20140406 23:12:33< happygrue> anyway, I was just guessing at what mordante might be asking for, as I haven't followed any proposal for that project very much.  I just threw out my thoughts since he isn't here to answer better atm.
20140406 23:12:38-!- spoffy [~spoffy@host86-183-62-54.range86-183.btcentralplus.com] has quit [Ping timeout: 240 seconds]
20140406 23:13:19< Dugi> happygrue: I tried to contact fabi several times, sent him PMs and such, but he seems only to check some stuff from time to time, but he is very inactive lately.
20140406 23:15:24< happygrue> I see.
20140406 23:20:25-!- cib0 [~cib@p5DD22847.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140406 23:22:13< jamit> gfgtdf: OK, the other stuff I was working on lead me to the commit I guess you were talking about earlier: https://github.com/wesnoth/wesnoth/commit/d0ded837af1a6e159cb3a40fbb9106aa50813c91
20140406 23:23:01< gfgtdf> jamit: yes
20140406 23:23:13< jamit> gfgtdf: I read the commit message, and I am still left with a question: why is this change being made? When were mover results in the replay not the same as during the game?
20140406 23:26:24< gfgtdf> jamit: the changes were made becasue changing the replay data after the move is not not always posbile. (storing early_stop) becasue the game now can send the replay data even before the move is finished.
20140406 23:28:13< jamit> gfgtdf: Why can the game now send the replay data before the move is finished?
20140406 23:30:54< gfgtdf> jamit: this could even happen before but only in rare case: if for example durign a enter_hex event form side 1 the wml calls [get_global_variable] with fromside=2 the side 2 needs to evaluate the get to teh same point where the get_global_variable is now this happends more often becasue the game replay is sended as soon as we call [get_variable]rand=  becasue we want teh server to generate...
20140406 23:30:56< gfgtdf> ...a random seed in this case.
20140406 23:33:21< gfgtdf> did you understand ? because i think i forgot some words.
20140406 23:34:07< jamit> [get_global_variable] has a fromside= key?
20140406 23:35:08-!- Necrosporus [~Necrospor@176.114.191.18] has quit [Ping timeout: 240 seconds]
20140406 23:35:44< gfgtdf> jamoit: no, the key is called 'side'
20140406 23:36:01< gfgtdf> jamit: http://wiki.wesnoth.org/PersistenceWML
20140406 23:37:07< jamit> That page will take time to parse because it does not follow the format of the other WML documentation.
20140406 23:39:50< gfgtdf> jamit: i didn't have tis problem. I didn't wrote it, and i dont know much  about how the wiki works. I copied some here : http://pastebin.com/E7miiJbB
20140406 23:39:59< jamit> gfgtdf:  Hmm... why does side 2 need to get to the same point in order to tell the active side what the value of its global variable is?
20140406 23:41:35< gfgtdf> jamit: thats how sm_sync work, side 1 doesnt't send a 'get  global variable', it just sends the replay and waits until side 2 gets to the point of [get_global_variable] and then side 2 sends  a [global_variable]
20140406 23:41:40< gfgtdf> mp_sync
20140406 23:42:01-!- gtnhuh [~gtnhuh@195.74.88.49] has joined #wesnoth-dev
20140406 23:42:08< jamit> gfgtdf: And doesn't the mere use of global variables threaten to make a replay inherently out of sync? The point of persistence is that a value is remembered. So when you load the replay, the value is likely different than when you played the original game. (If it is even your game that you are watching the replay of.)
20140406 23:42:44< gfgtdf> 	jamit: no teh value is stored in teh replay
20140406 23:42:45< gfgtdf> the*
20140406 23:43:02< gfgtdf> thats what geT_user_choice does
20140406 23:43:08-!- fabi_ [~fabi@88-134-21-163-dynip.superkabel.de] has joined #wesnoth-dev
20140406 23:43:08-!- fabi_ [~fabi@88-134-21-163-dynip.superkabel.de] has quit [Changing host]
20140406 23:43:08-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20140406 23:44:05< jamit> gfgtdf: There probably should be a way to send a "get global variable".
20140406 23:44:33-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140406 23:44:43< jamit> gfgtdf: Otherwise, you may need to wait for the other sides to catch up in the replay, and the player might not want that. Particularly if the player did something like delay shroud updates so he could undo moves.
20140406 23:45:38< jamit> If instead the one game could send a "get global variable", that could be resolved right away, and the value could be put in the replay data sent to other clients, and everyone is happy, no?
20140406 23:46:38-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 240 seconds]
20140406 23:48:09< gfgtdf> jamit: hm from current engines point of view, get_global_variable is a user input form side 2 and as soon as as have a user input form side 2 we have an information gain that prevents undoing.
20140406 23:49:06-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 255 seconds]
20140406 23:50:50< jamit> gfgtdf: But it's not user input. It's reading a variable. There is no change in game state, and no new information given to the player (not directly, nor right away, at least). From the player's perspective there is no reason this act should block undoing.
20140406 23:53:02-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140406 23:53:23< jamit> gfgtdf: Oh, and the reason I looked up this commit in the first place: why do lines 1233-1236 in src/menu_events.cpp form a separate code block? (Lines 1225-1228 when the commit was made.)
20140406 23:54:36< gfgtdf> jamit: i think thats a leftover from a commit that vanished durign rebasing. 
20140406 23:58:55< gfgtdf> jamit: but how'd you implement get_global variable? For example if a set_global_avrible happends before get_global varible that would be skipped by just sending a get global varible over the network. If we also send the set global varible we'd allow side 1 to set the global variable to any value it wants, and allow serious cheating in ump that relied on global variablewants.
20140406 23:59:18-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140406 23:59:23< gfgtdf> jamit: i think the problems with that approach are quite huge.
--- Log closed Mon Apr 07 00:00:21 2014