--- Log opened Sun Apr 13 00:00:07 2014
20140413 00:01:02< aquileia> AI0867: The tutorial is shown correctly
20140413 00:02:20< aquileia> WML works perfectly (but I think that was already the case before)
20140413 00:03:15< aquileia> AI0867: good night and a nice weekend
20140413 00:07:27-!- gfgtdf [~chatzilla@e177146162.adsl.alicedsl.de] has joined #wesnoth-dev
20140413 00:29:05-!- SigurdFD [~SigurdFD@24.154.98.89] has joined #wesnoth-dev
20140413 00:29:23-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20140413 00:30:38-!- trewe [~trewe@244.163.54.77.rev.vodafone.pt] has quit [Quit: quit]
20140413 00:36:11-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140413 00:36:57-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140413 00:46:28-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has quit [Quit: Page closed]
20140413 01:24:41-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140413 01:59:04-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20140413 01:59:53< gfgtdf> any c++ expert here ?
20140413 01:59:57-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Remote host closed the connection]
20140413 02:07:54< gfgtdf> or a formula expert maybe ?
20140413 02:10:43< gfgtdf> im currently investigating why formula unit filters doesnt work and crash, and what i found is https://github.com/wesnoth/wesnoth/blob/master/src/unit.cpp#L1657 where a temporary std::pair<map_location, unit>is passes and then referenced in https://github.com/wesnoth/wesnoth/blob/master/src/callable_objects.hpp#L149. I think thi is the error.
20140413 02:11:47-!- Ivanovic_ [~ivanovic@x2f3cb30.dyn.telefonica.de] has joined #wesnoth-dev
20140413 02:13:26-!- Ivanovic [~ivanovic@x2f50bf1.dyn.telefonica.de] has quit [Ping timeout: 245 seconds]
20140413 02:13:40-!- Ivanovic_ is now known as Ivanovic
20140413 02:14:55< gfgtdf> i personlay don't know why we pass a std::pair to the function instead of passing 2 arguments, any1 here who knows ?
20140413 02:25:46< gfgtdf> ok, i made a bug report for this issue: 21909
20140413 02:27:17-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev
20140413 02:44:52-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 231 bugs, 351 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140413 02:45:29-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20140413 03:14:44-!- vultraz [~chatzilla@124.109.10.167] has quit [Remote host closed the connection]
20140413 03:21:55-!- ancestral [~ancestral@75-161-229-57.mpls.qwest.net] has joined #wesnoth-dev
20140413 03:21:59-!- gfgtdf [~chatzilla@e177146162.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]]
20140413 03:33:09-!- Netsplit *.net <-> *.split quits: enchilado, Gambit, SigurdFD, Rhonda, ejls, Ivanovic, molgrum, apoi, irker571, shadowm,  (+14 more, use /NETSPLIT to show all of them)
20140413 03:33:22-!- Netsplit *.net <-> *.split quits: knotwork_, Soliton, crimson_penguin, Coffee_irc, Gallaecio, loonycyborg, AI0867, DDR, EliDupree, timotei,  (+12 more, use /NETSPLIT to show all of them)
20140413 05:16:26-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20140413 05:16:26-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140413 05:16:26-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140413 05:16:26-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has joined #wesnoth-dev
20140413 05:16:26-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20140413 05:16:26-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140413 05:16:26-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev
20140413 05:16:26-!- justinzane [~justinzan@host-12-172-184-180.nctv.com] has joined #wesnoth-dev
20140413 05:16:26-!- Coffee_irc [~david@ppp118-210-77-53.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140413 05:16:26-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20140413 05:16:26-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20140413 05:16:26-!- fabi__ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20140413 05:16:26-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20140413 05:16:26-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20140413 05:16:26-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has joined #wesnoth-dev
20140413 05:16:26-!- melinath [~melinath@li341-41.members.linode.com] has joined #wesnoth-dev
20140413 05:16:31-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140413 05:16:31-!- ejls [~ejls@ejls.fr] has joined #wesnoth-dev
20140413 05:16:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140413 05:16:38-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev
20140413 05:16:38-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140413 05:16:38-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20140413 05:16:38-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20140413 05:16:38-!- irker637 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140413 05:16:38-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140413 05:16:38-!- _8680_ [~8680@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140413 05:16:40-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20140413 05:16:40-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20140413 05:16:40-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20140413 05:18:06-!- Smar [smar@nano.smar.fi] has joined #wesnoth-dev
20140413 05:18:06-!- Ivanovic [~ivanovic@x2f3cb30.dyn.telefonica.de] has joined #wesnoth-dev
20140413 05:18:12-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-rujgexwqeagnilrb] has joined #wesnoth-dev
20140413 05:18:25-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140413 05:18:25-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140413 05:18:25-!- Fortescue [sid1929@gateway/web/irccloud.com/x-hkbkjcvpidvvyswg] has joined #wesnoth-dev
20140413 05:18:25-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20140413 05:18:37-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140413 05:18:37-!- MaraJade [goossenm@shell.onid.oregonstate.edu] has joined #wesnoth-dev
20140413 05:18:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20140413 05:18:41-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20140413 05:18:41-!- Ardonik [~user@adsl-75-28-103-78.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20140413 05:29:37-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Quit: Going down for reboot…]
20140413 05:30:54-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev
20140413 05:39:34-!- Sulfur [~Miranda@p5B008F23.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140413 05:53:25-!- higgins [~higgins@li125-242.members.linode.com] has joined #wesnoth-dev
20140413 06:03:20-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has joined #wesnoth-dev
20140413 06:09:25< vorobeez> Ivanovic: hello, i don't know did you saw my comment in my GSoC page, but i update my wiki-page ( http://wiki.wesnoth.org/SoC2014_vorobeez_AI ) and create pull request( https://github.com/wesnoth/wesnoth/pull/145 )
20140413 06:27:03-!- _8680_ [~8680@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Quit: Going down for reboot…]
20140413 06:55:47-!- vorobeez [558e940c@gateway/web/freenode/ip.85.142.148.12] has quit [Quit: Page closed]
20140413 07:15:09-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140413 07:18:56-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140413 07:19:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140413 07:22:40-!- mjs-de [~mjs-de@f049174167.adsl.alicedsl.de] has joined #wesnoth-dev
20140413 07:24:05-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 258 seconds]
20140413 07:29:09-!- mjs-de [~mjs-de@f049174167.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140413 07:37:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140413 07:48:08-!- sachith500 [~kvirc@112.134.141.27] has joined #wesnoth-dev
20140413 07:50:35-!- sachith500 [~kvirc@112.134.141.27] has quit [Read error: Connection reset by peer]
20140413 07:55:38-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140413 08:00:33-!- irker637 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140413 08:12:53-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140413 08:13:16-!- sachith500 [~kvirc@112.134.141.27] has joined #wesnoth-dev
20140413 08:17:39< zookeeper> ok, so in jenkins build history, how do i know which one i want (for windows)?
20140413 08:24:40< thunderstruck> iceiceice: I believe this commit https://github.com/wesnoth/wesnoth/commit/72632ff03b3c2698a3f4883e752cacb53ed47dfe introduces a segfault in networked MP campaigns
20140413 08:25:28< thunderstruck> iceiceice: I'll look into it myself later on if I'll have time, if not I'll give you a test campaign
20140413 08:25:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Ciao]
20140413 08:26:08< thunderstruck> iceiceice: and by the way, I'm not sure if putting a sound stuff in 'engine' class was a good idea..
20140413 08:39:52-!- bagzie [~bag@85-76-137-167-nat.elisa-mobile.fi] has joined #wesnoth-dev
20140413 08:40:13< thunderstruck> wesbot: bug #21910
20140413 08:40:14< wesbot> Bug #21910  Assigned to: Chris Beck <involution>  Status: None  Priority: 7 - High
20140413 08:40:17< wesbot> Summary: Segmentation fault in networked MP Campaigns
20140413 08:40:19< wesbot> Original submission: It looks like segmentation fault was introduced with this
20140413 08:40:22< wesbot>  commit https://github.com/wesnoth/wesnoth/commit/72632ff03b3c2698a3f4883e752cac
20140413 08:40:25< wesbot> URL: http://gna.org/bugs/?21910
20140413 08:40:45< thunderstruck> iceiceice: ^
20140413 08:44:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140413 08:44:50-!- neXyon [~neXyon@85-127-180-43.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140413 08:44:52-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 232 bugs, 351 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140413 08:54:10-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20140413 09:02:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140413 09:15:42-!- _8680_ [~8680@2002:4404:712c:0:284c:647a:3b12:87c3] has joined #wesnoth-dev
20140413 09:15:46-!- _8680_ [~8680@2002:4404:712c:0:284c:647a:3b12:87c3] has quit [Client Quit]
20140413 09:15:49-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140413 09:18:22-!- Netsplit *.net <-> *.split quits: DDR
20140413 09:19:38-!- Netsplit over, joins: DDR
20140413 09:21:12-!- _8680_ [~8680@2002:4404:712c:0:397d:d562:e4ca:ae10] has joined #wesnoth-dev
20140413 09:21:36-!- _8680_ is now known as Guest87462
20140413 09:22:32-!- Guest87462 [~8680@2002:4404:712c:0:397d:d562:e4ca:ae10] has quit [Client Quit]
20140413 09:23:22-!- _8680__ [~8680@2002:4404:712c:0:397d:d562:e4ca:ae10] has joined #wesnoth-dev
20140413 09:24:46-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140413 09:27:14-!- Unnheulu [~ieuan@host109-153-144-210.range109-153.btcentralplus.com] has joined #wesnoth-dev
20140413 09:28:14-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20140413 09:37:24-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20140413 10:34:46-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140413 10:35:00< AI0867> aquileia: you know how I said I would be gone for the weekend? I'm about to leave, but I have a new commit for you to test
20140413 10:35:10< AI0867> all the relevant stuff is in the commit message
20140413 10:35:26< AI0867> playing things with lots of different music is probably going to bloat your memory footprint
20140413 10:35:28-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20140413 10:35:28-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140413 10:39:11-!- irker642 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140413 10:39:11< irker642> wesnoth: ln-zookeeper wesnoth:1.12 6905294ccf66 / data/campaigns/Eastern_Invasion/scenarios/10_Lake_Vrug.cfg: Tweaks to two event triggers http://git.io/RZjLTg
20140413 10:39:58-!- knotwork_ [~markm@unaffiliated/knotwork] has quit [Read error: Connection reset by peer]
20140413 10:40:33-!- knotwork_ [~markm@142.68.84.150] has joined #wesnoth-dev
20140413 10:40:33-!- knotwork_ [~markm@142.68.84.150] has quit [Changing host]
20140413 10:40:33-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20140413 10:40:40< irker642> wesnoth: ln-zookeeper wesnoth:master 416ede246de9 / data/campaigns/Eastern_Invasion/scenarios/10_Lake_Vrug.cfg: Tweaks to two event triggers http://git.io/82jPng
20140413 10:46:40-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 276 seconds]
20140413 10:48:33-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140413 10:59:33-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140413 11:07:16-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Remote host closed the connection]
20140413 11:08:20-!- _8680__ [~8680@2002:4404:712c:0:397d:d562:e4ca:ae10] has quit [Ping timeout: 258 seconds]
20140413 11:09:26-!- _8680_ [~8680@2002:4404:712c:0:e48f:22a9:c01f:b2c1] has joined #wesnoth-dev
20140413 11:09:43-!- _8680_ is now known as Guest45716
20140413 11:11:09-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20140413 11:17:27-!- tomreyn [~tomreyn@p57954314.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140413 11:17:27-!- tomreyn [~tomreyn@p57954314.dip0.t-ipconnect.de] has quit [Changing host]
20140413 11:17:27-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140413 11:20:38-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20140413 11:21:13-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20140413 11:27:05-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140413 11:29:23< irker642> wesnoth: ln-zookeeper wesnoth:master 59e9dd1c43f4 / changelog data/campaigns/Eastern_Invasion/scenarios/11_Captured.cfg: Don't bother with stolen gold if there wasn't any http://git.io/hDxyTA
20140413 11:30:31-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140413 11:32:42< irker642> wesnoth: ln-zookeeper wesnoth:1.12 62549bfccb01 / changelog data/campaigns/Eastern_Invasion/scenarios/11_Captured.cfg: Don't bother with stolen gold if there wasn't any http://git.io/C5DDzA
20140413 11:37:20< thunderstruck> Coffee_irc: Hi. Do you remember our discussion about "Use map settings" and factions, leaders and genders?
20140413 11:41:01-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 258 seconds]
20140413 11:45:01-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140413 11:51:41-!- Sulfur [~Miranda@p5B008F23.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140413 12:04:11-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140413 12:15:49-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140413 12:16:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140413 12:16:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20140413 12:16:53-!- neXyon [~neXyon@85-127-180-43.dynamic.xdsl-line.inode.at] has quit [Ping timeout: 240 seconds]
20140413 12:17:00-!- neXyon_ [~neXyon@85-127-45-150.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140413 12:24:16-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Read error: Connection reset by peer]
20140413 12:27:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20140413 12:27:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140413 12:29:59-!- Unnheulu [~ieuan@host109-153-144-210.range109-153.btcentralplus.com] has quit [Ping timeout: 276 seconds]
20140413 12:30:43< loonycyborg> zookeeper: get from debian7-32
20140413 12:31:22< loonycyborg> gentoo cross-build uses too bleeding edge stuff and didn't work last time I tried to run it :P
20140413 12:32:07-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140413 12:32:28< loonycyborg> oh build history? I think it's irrelevant
20140413 12:32:53< loonycyborg> wordir will always have latest build from appropriate build configuration
20140413 12:32:58< zookeeper> ok, i got it but as some others i tried previously, libgcc_s_sjlj-1.dll is missing
20140413 12:34:17-!- neXyon_ is now known as neXyon
20140413 12:38:05< loonycyborg> hmm, didn't you already get that file? and stdc++ one too
20140413 12:39:01< zookeeper> how would i have gotten such a file?
20140413 12:39:46< loonycyborg> I've placed it in workdir for you before for some time. I think you were able to run it after that
20140413 12:39:57< zookeeper> what's workdir?
20140413 12:40:11< loonycyborg> the place you download that .exe from
20140413 12:40:43< zookeeper> in workspace there's only wesnoth-master.exe
20140413 12:42:12< zookeeper> but obviously i have no understanding of that site whatsoever and i'm more or less pressing buttons at random and hoping i'll come across something
20140413 12:42:12< loonycyborg> Yes, now it is. But did you succeed at running binary from jenkins in the past?
20140413 12:42:18< zookeeper> i don't recall
20140413 12:42:49< loonycyborg> I think you did once.
20140413 12:43:02< zookeeper> maybe
20140413 12:44:28< loonycyborg> hmm, I think I'll just make it link those libs statically..
20140413 12:44:38< zookeeper> static linking is the best
20140413 12:50:43-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 250 seconds]
20140413 13:03:18-!- Sulfur [~Miranda@p5B008F23.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140413 13:03:24-!- sachith500|2 [~kvirc@112.134.230.170] has joined #wesnoth-dev
20140413 13:03:44-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 255 seconds]
20140413 13:05:15-!- exciton [chuck-the-@77.51.136.102] has joined #wesnoth-dev
20140413 13:06:01-!- sachith500 [~kvirc@112.134.141.27] has quit [Ping timeout: 258 seconds]
20140413 13:13:45-!- Guest45716 [~8680@2002:4404:712c:0:e48f:22a9:c01f:b2c1] has quit [Ping timeout: 252 seconds]
20140413 13:19:01-!- _8680_ [~8680@2002:4404:712c:0:1909:1a5b:3ab5:5fbb] has joined #wesnoth-dev
20140413 13:19:19-!- _8680_ is now known as Guest51028
20140413 13:25:55-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140413 13:26:53< iceiceice> thunderstruck: just saw this report
20140413 13:27:23< iceiceice> i had to read it a second time, but yes it looks like a logic error on my part
20140413 13:28:35< iceiceice> also, what do you think would be a less hacky way to play the sound? i think that the party full bell thing was my first commit... i had very little idea of the code organization at that point
20140413 13:30:11< thunderstruck> iceiceice: Well, ideally, it should be done in mp::connect and not in mp::connect_engine
20140413 13:30:52< thunderstruck> iceiceice: Basically, connect relies on connect_engine to handle all logic stuff depending on user's input
20140413 13:32:00< thunderstruck> iceiceice: Do you know why previous approach didn't work?
20140413 13:32:26< thunderstruck> iceiceice: (when sound was called from mp::connect and not engine)
20140413 13:33:44< iceiceice> it worked but it played at slgihtly the wrong time
20140413 13:34:22< iceiceice> it goes back to the thing about whether we can start the game before the last player has finished picking sides
20140413 13:34:53< iceiceice> in the first implementation, the bell would play as soon as the last slot was full
20140413 13:35:14< thunderstruck> Do you know what's the behaviour in current stable?
20140413 13:35:51< iceiceice> i think it's correct now, or it seemed correct when i tested it
20140413 13:35:59< iceiceice> i might test it again to be sure
20140413 13:36:36< thunderstruck> What's correct?
20140413 13:36:55< iceiceice> it should only play when it is possible to click the start button more or less
20140413 13:37:25< iceiceice> it's basically serving as a notification...
20140413 13:37:44< iceiceice> now that i think of it serving a notification "game is full" might also be a good idea
20140413 13:39:03< iceiceice> the purpose is just to tell the host to come back if she started doing something else while waiting for the game to fill
20140413 13:40:28< thunderstruck> iceiceice: I looked in to that commit more closely
20140413 13:40:49< thunderstruck> iceiceice: if I understand this right, previously the bell would ring after everyone was ready
20140413 13:40:52-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140413 13:41:06< thunderstruck> iceiceice: now it rings, after someone joins
20140413 13:41:13< thunderstruck> iceiceice: is that true?
20140413 13:41:25< iceiceice> im going to reread to be sure
20140413 13:41:37-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140413 13:41:40-!- Guest51028 [~8680@2002:4404:712c:0:1909:1a5b:3ab5:5fbb] has quit [Ping timeout: 258 seconds]
20140413 13:42:16-!- _8680_ [~8680@2002:4404:712c:0:3c08:c42d:4023:6a22] has joined #wesnoth-dev
20140413 13:42:34-!- _8680_ is now known as Guest54860
20140413 13:43:16-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140413 13:43:20< irker642> wesnoth: loonycyborg wesnoth:master cf8f78654674 / scons/cross_compile.py: scons: link statically against libstdc++ and libgcc for mingw32 cross-compile http://git.io/6tJxsQ
20140413 13:45:02-!- sachith500|2 [~kvirc@112.134.230.170] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140413 13:45:23< thunderstruck> iceiceice: hmmm.. maybe that's not the case. It still checks for can_start_game()
20140413 13:46:36< iceiceice> hmm so i think when i fixed a certain bug...
20140413 13:46:56< iceiceice> https://gna.org/bugs/index.php?21758
20140413 13:47:03< iceiceice> when i did that i made a change to side_engine i think
20140413 13:47:38< iceiceice> yes in side_engine::ready_for_start() 
20140413 13:48:27< iceiceice> in case of a network player, the network player is not "ready" unless they got a chance to choose their faction, and they were allowed to do so
20140413 13:49:21-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140413 13:49:25< thunderstruck> iceiceice: I'm aware of that fix.
20140413 13:49:27< iceiceice> so the result of that should be that in multiplayer_connect_engine::can_start_game, the result will be false unless all the sides are ready 
20140413 13:49:40< iceiceice> and got to choose their faction if appropriate
20140413 13:50:05< thunderstruck> iceiceice: I still have a few questions about this.
20140413 13:50:08< iceiceice> ok
20140413 13:50:17< thunderstruck> iceiceice: What does was_waiting_for_faction do here?
20140413 13:51:00< iceiceice> its a flag that is supposed to be false if we are still waiting for that player to pick a faction
20140413 13:51:00< thunderstruck> iceiceice: is it related to observers?
20140413 13:51:03< iceiceice> or true that is
20140413 13:51:18< iceiceice> its not related to observers
20140413 13:51:46< iceiceice> if i remember the places that adjust it are,
20140413 13:51:53< iceiceice> when a new player joins the game it is set one way,
20140413 13:52:05< iceiceice> and when that side engine gets its faction info updated it is set the other wya
20140413 13:52:25< iceiceice> so this means that when the player joins they will block the start until either they assign a faction,
20140413 13:52:35< iceiceice> or the host clicks and gives them a faction
20140413 13:53:16< thunderstruck> iceiceice: But you're already checking for waiting_to_choose_faction in  side_engine::ready_for_start() which is called from can_start_game()?
20140413 13:53:32< iceiceice> yes
20140413 13:56:15< thunderstruck> iceiceice: Does it mean that "if (was_waiting_for_faction && can_start_game()) {" could be changed to "if (can_start_game()) {"?
20140413 13:58:16< iceiceice> hmm
20140413 13:58:36< iceiceice> i guess that there is no other time that the client would send the host a "change_faction" than when they just joined?
20140413 13:58:45< iceiceice> if that's right then i think you are right
20140413 13:59:04-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140413 13:59:14< iceiceice> i guess what i didn't want was for there to be some scenario where the game is full and ready to start, but somone is adjusting their configuration
20140413 13:59:21< iceiceice> and every time they make a change it makes noise for the host
20140413 13:59:54< iceiceice> but it might be that in the current code that change wouldn't have any effect
20140413 14:00:04< iceiceice> and we could delete the segfault line 
20140413 14:00:35< thunderstruck> iceiceice: What I meant, if "can_start_game()" checks for that flag, then the check for flag in the if statement is redundant
20140413 14:00:52< thunderstruck> because if statement includes "can_start_game()"
20140413 14:00:55< iceiceice> i think its not strictly redundant
20140413 14:01:16< iceiceice> we are gettting "was_waiting_for_faction" just before processing the change signal
20140413 14:01:30< iceiceice> so it will tell us if before the most recent change were ready start or not
20140413 14:01:41< iceiceice> and we only want to play the sound if we weren't ready before and now we are
20140413 14:01:49-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140413 14:01:56< thunderstruck> iceiceice: yes, but can_start_game() tells you if everyone is ready
20140413 14:02:14< iceiceice> yes
20140413 14:02:24< thunderstruck> so, is "Jim & Joe" ready is not the same as (Jim) & (Jim & Joe) ready?
20140413 14:02:53< iceiceice> the check i'm intending was "was Jim not ready at t=-1 and now ready at t=0"
20140413 14:03:24< iceiceice> the import_user can result in a change in the value of "waiting_for_faction
20140413 14:03:33< iceiceice> and therefore in can_start_game as well
20140413 14:03:40< thunderstruck> ahh.. ok
20140413 14:03:42< thunderstruck> I see it now
20140413 14:03:46-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has joined #wesnoth-dev
20140413 14:04:22< thunderstruck> another thing I noticed was that you don't check for "!silent"
20140413 14:04:32< thunderstruck> I guess that's related to code being moved to engine
20140413 14:05:55< iceiceice> yeah i'm not sure why i dropped that...
20140413 14:06:01< iceiceice> probably a mistake i guess
20140413 14:06:22< iceiceice> i havent noticed that the bell plays when i don't have ui sounds on 
20140413 14:06:40< iceiceice> but i didnt test specifically i guess
20140413 14:06:51< thunderstruck> it might be an advanced option in preferences
20140413 14:07:26< thunderstruck> anyway, it would be good to move that stuff back to mp::connect to avoid adding more stuff to engine, if possible
20140413 14:07:42< iceiceice> ok, i'll work on it
20140413 14:08:33< thunderstruck> iceiceice: By the way, I was looking at https://gna.org/bugs/?21903
20140413 14:08:59< thunderstruck> iceiceice: But I bumped into that segfault and then into some problems with factions leaders and genders
20140413 14:09:06< thunderstruck> it seems that the latter is quite broken
20140413 14:09:21< iceiceice> yeah...
20140413 14:09:26< thunderstruck> I have some fixes locally
20140413 14:09:37< iceiceice> i think that fixing it on master would be hard,
20140413 14:09:55< iceiceice> i made this change some time ago to move "controller tweaks" to the server
20140413 14:10:08< iceiceice> basically i had made some assumptions about how transitions work that i think weren't right
20140413 14:10:16< aquileia> AI0867: You fully fixed the loading of images, sound, music and fonts! Wesnoth now runs perfectly under any path, it seems
20140413 14:10:37< thunderstruck> iceiceice: So, I'll attempt to fix FLG by today or tomorrow, but I won't be able to look into 21903 soon, because I'll be away for a week or so
20140413 14:10:42< iceiceice> ok
20140413 14:10:44< aquileia> AI0867: The only problem is... it errors on exiting
20140413 14:10:57< thunderstruck> iceiceice: By the way, what are these controller tweaks?
20140413 14:11:22< aquileia> AI0867: It can't destruct your structs correctly http://pastebin.com/vrzzsPwA
20140413 14:11:39< iceiceice> thunderstruck: when the game begins, the host sends the level to the server right? which relays it to the clients
20140413 14:11:46< iceiceice> the clients need to insert themselves for the sides they own
20140413 14:11:51< iceiceice> and mark the host's sides as network
20140413 14:12:01< iceiceice> previously this was done in play_campaign.cpp
20140413 14:12:19< iceiceice> i remember at first i fixed a bug here that was making it hard to reload mp campaigns...
20140413 14:12:37< iceiceice> but we decided that actually that code shouldnt be there at all, these "tweaks" should be issues by the server
20140413 14:13:43-!- travis-ci [~travis-ci@ec2-54-237-114-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20140413 14:13:43< travis-ci> [travis-ci] wesnoth/wesnoth#2309 (master - cf8f786 : loonycyborg): The build has errored.
20140413 14:13:43< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/22885514
20140413 14:13:43-!- travis-ci [~travis-ci@ec2-54-237-114-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20140413 14:15:26< iceiceice> i think i didnt realize that the start game mechanism wouldnt repeat when the scenario transitions so for that reason its quite broken in master
20140413 14:15:55< iceiceice> but i guess there were also many preexisting bugs about these transitions so i'd rather approach it carefully
20140413 14:16:01< iceiceice> *more carefully
20140413 14:16:47< thunderstruck> iceiceice: yeah, there are lots of problems with some of the code
20140413 14:17:15< thunderstruck> iceiceice: some of it needs major refactoring :)
20140413 14:17:23< iceiceice> hehe
20140413 14:17:53< aquileia> fabi / fendrin / fabi__ : It seems that your orb color seting needs two additional files that it can't find: orb-active.png and orb-disabled.png
20140413 14:17:59< thunderstruck> I attempted to sort out FLG stuff during gsoc, but there are still problems with it
20140413 14:17:59< aquileia> *setting
20140413 14:21:53< iceiceice> ok, i'm going to try to figure out a fix for the bell again, hopefully i'll have it up shortly
20140413 14:22:45< iceiceice> i guess that most likely i will want to pass the bell signal out in the return type of process_network_data?
20140413 14:23:29< iceiceice> or perhaps just...
20140413 14:23:34< iceiceice> move the logic out of the engine
20140413 14:23:54< iceiceice> and have mp connect just check if we became ready to start after scanning the most recent packet
20140413 14:26:30< thunderstruck> iceiceice: I personally, don't see a disadvantage between previous approach and this one.
20140413 14:26:53< thunderstruck> But maybe that's because I usually play with these sounds off :)
20140413 14:28:46< iceiceice> hehe
20140413 14:29:26< iceiceice> so you think its fine to check the sound in update_playerlist_state?
20140413 14:29:40< iceiceice> now that i look at it now i think i would want to put it just one higher in the call stack
20140413 14:30:08< iceiceice> in connect::process_network_data, maybe right after update_playerlist is called
20140413 14:31:19< thunderstruck> iceiceice: But then the result is almost the same
20140413 14:31:19< iceiceice> i am thinking also that i might make a separate commit to issue a desktop notification at this time...
20140413 14:31:46< iceiceice> yeah, it is almost the same
20140413 14:31:47< thunderstruck> the code was used to be at the end of update_playerlist function
20140413 14:32:29< thunderstruck> By the way, was there a reason why it was in that function and not just in process_network_data?
20140413 14:32:36< iceiceice> i think i just didnt know the code very well
20140413 14:32:48< iceiceice> it was literally my first commit on the project :)
20140413 14:32:53< thunderstruck> Would that mean that there are other cases when the bell should ring outside of process_network_data?
20140413 14:33:17< iceiceice> hmm i dont think so
20140413 14:33:23< iceiceice> are there other places that update_playlist is called?
20140413 14:33:57< iceiceice> hmm i guess so
20140413 14:33:58< thunderstruck> yes, but then it forces silent
20140413 14:34:20< iceiceice> in the constructor
20140413 14:34:22< iceiceice> and in process_event
20140413 14:34:49< iceiceice> hmm
20140413 14:35:11< thunderstruck> ahhh
20140413 14:35:25< thunderstruck> so it's also a notification for other players if host changed any of the configuraitons
20140413 14:35:32< thunderstruck> I guess that might be important
20140413 14:36:24< iceiceice> you mean the bell?
20140413 14:36:29< thunderstruck> yes
20140413 14:36:44< iceiceice> i thought that it would only play on the host, the other players will be in mp_wait, right?
20140413 14:36:47< iceiceice> or am i wrong about this
20140413 14:36:52< thunderstruck> hmmm
20140413 14:37:26< thunderstruck> yes, that's true
20140413 14:37:31< thunderstruck> I keep getting confused with this
20140413 14:37:46< iceiceice> hehe
20140413 14:38:37< thunderstruck> I think then it is notification for a host that something happened to a side
20140413 14:38:45< thunderstruck> so that's either someone joined or quit
20140413 14:38:51< thunderstruck> or chose a faction?
20140413 14:38:57< iceiceice> yes
20140413 14:39:09< iceiceice> i mean its supposed to signify "it is now possible to click the start game button"
20140413 14:39:16< thunderstruck> hmm
20140413 14:39:22< thunderstruck> not necesserily I think
20140413 14:39:39< iceiceice> i mean thats what i hoped for the bell to do
20140413 14:39:43< iceiceice> maybe it does more things now
20140413 14:39:51< iceiceice> but at least i didnt intend it :)
20140413 14:40:27< thunderstruck> I think it should no longer play the bell for the host when players join or quit
20140413 14:40:37< thunderstruck> But I can't really test this on one PC
20140413 14:40:41< thunderstruck> or could I
20140413 14:40:41< thunderstruck> ?
20140413 14:40:51< iceiceice> you could i think
20140413 14:40:59-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has quit [Quit: Page closed]
20140413 14:40:59< thunderstruck> I could disable sounds for one of the instances of Wesnoth I guess
20140413 14:40:59< iceiceice> you'd have to start multiple instances of wesnoth i guess
20140413 14:41:02< iceiceice> yeah
20140413 14:41:50< iceiceice> i have a little bash script for this i guess that starts wesnothd and 3 wesnoth instances which connect to it
20140413 14:42:17< thunderstruck> I have something like that too
20140413 14:42:21< iceiceice> it doesnt do anything about the sounds though, but its not so much
20140413 14:42:25< thunderstruck> It looks like sounds are still there
20140413 14:42:35< thunderstruck> But I'd have to check with current stable to be sure
20140413 14:42:42< thunderstruck> Anyway, I have to do some other stuff now
20140413 14:42:45< iceiceice> ok
20140413 14:42:46< iceiceice> me also
20140413 14:42:58< iceiceice> thanks for pointing out about the segfault
20140413 14:43:03< thunderstruck> no problem
20140413 14:59:13-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140413 14:59:27-!- exciton [chuck-the-@77.51.136.102] has quit [Read error: Connection reset by peer]
20140413 14:59:41-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140413 15:02:34< loonycyborg> zookeeper: I've made it pass appropriate flags now.
20140413 15:03:12< zookeeper> loonycyborg, great, thanks
20140413 15:19:24-!- ancestral [~ancestral@72.21.225.66] has joined #wesnoth-dev
20140413 15:24:07< zookeeper> loonycyborg, yeah, works
20140413 15:24:17< loonycyborg> cool
20140413 15:24:44-!- Bodhi-Baum [~Bodhi@dslb-084-063-060-110.pools.arcor-ip.net] has joined #wesnoth-dev
20140413 15:26:19-!- ancestral [~ancestral@72.21.225.66] has quit [Quit: Smell ya later!]
20140413 15:30:34-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20140413 15:30:35-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20140413 15:30:35-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140413 15:30:50< mordante> servus
20140413 15:31:12< mordante> thanks aquileia
20140413 15:31:27-!- neXyon [~neXyon@85-127-45-150.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20140413 15:32:53-!- ancestral [~ancestral@72.21.225.66] has joined #wesnoth-dev
20140413 15:34:35-!- Bodhi-Baum [~Bodhi@dslb-084-063-060-110.pools.arcor-ip.net] has quit [Ping timeout: 276 seconds]
20140413 15:34:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Ciao]
20140413 15:36:41-!- ancestral_ [~ancestral@72.21.225.66] has joined #wesnoth-dev
20140413 15:37:23-!- ancestral [~ancestral@72.21.225.66] has quit [Ping timeout: 245 seconds]
20140413 15:37:23-!- ancestral_ is now known as ancestral
20140413 15:39:55-!- ancestral [~ancestral@72.21.225.66] has quit [Client Quit]
20140413 15:41:51-!- Bodhi-Baum [~Bodhi@dslb-084-063-060-110.pools.arcor-ip.net] has joined #wesnoth-dev
20140413 15:44:59-!- gfgtdf [~chatzilla@e177146162.adsl.alicedsl.de] has joined #wesnoth-dev
20140413 15:45:29< irker642> wesnoth: Mark de Wever wesnoth:master 8d875498b8f8 / src/windows_tray_notification.cpp: Properly memset a variable. http://git.io/A1936w
20140413 15:48:05-!- Sulfur [~Miranda@p5B008F23.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140413 16:00:37-!- Bodhi-Baum [~Bodhi@dslb-084-063-060-110.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140413 16:08:57< mordante> Aishiko, around?
20140413 16:09:08-!- Kexoth [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140413 16:09:45-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140413 16:10:44< Aishiko> mordante, I'm here 
20140413 16:14:05-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140413 16:16:48< mordante> Aishiko, how are you doing?
20140413 16:17:20< Aishiko> I'm doing OK, really stressed and busy but OK, and yourself?
20140413 16:18:17< mordante> doing fine
20140413 16:18:48< mordante> busy with school stuff?
20140413 16:19:11-!- Bodhi-Baum [~Bodhi@dslb-084-063-026-120.pools.arcor-ip.net] has joined #wesnoth-dev
20140413 16:19:21-!- travis-ci [~travis-ci@ec2-50-19-205-165.compute-1.amazonaws.com] has joined #wesnoth-dev
20140413 16:19:22< travis-ci> [travis-ci] wesnoth/wesnoth#2311 (master - 8d87549 : Mark de Wever): The build passed.
20140413 16:19:22< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/22890482
20140413 16:19:22-!- travis-ci [~travis-ci@ec2-50-19-205-165.compute-1.amazonaws.com] has left #wesnoth-dev []
20140413 16:20:40< Aishiko> mostly, I have 6 classes this semester, but I have had a chance to work on the patch, just not working right yet 
20140413 16:22:40< irker642> wesnoth: loonycyborg wesnoth:1.12 26cddd3a7364 / scons/cross_compile.py: scons: link statically against libstdc++ and libgcc for mingw32 cross-compile http://git.io/i_pFRw
20140413 16:22:47< mordante> good to hear you managed to get some things done on the patch
20140413 16:23:25< mordante> I don't want to stress you but the Google selection deadline is getting really close and I really like to see some code
20140413 16:23:31< mordante> what's not working yet?
20140413 16:23:51< Aishiko> I'll back burner some other stuff and get something out today or tomorrow then 
20140413 16:24:49< mordante> that would be really great, as you can see in the timeline [1] Google expects us to select students at the 15th latest
20140413 16:24:55< mordante> [1] http://www.google-melange.com/gsoc/events/google/gsoc2014?ModPagespeed=noscript
20140413 16:25:47< mordante> so even if you have something not working, please submit it along with its problems
20140413 16:25:50< Aishiko> right today or tomorrow morning then
20140413 16:26:06< Aishiko> at the latest, and I'll do that
20140413 16:26:27< mordante> that way there is at least some code for me to review
20140413 16:27:09< Aishiko> right, I should have been thinking more about that, I'll try to be more diligent
20140413 16:27:27< mordante> also if you have question, best ask them now, I'll be off in about an hour
20140413 16:28:17< mordante> I understand students also have a lot of things to do for school
20140413 16:28:24< mordante> and other obligations
20140413 16:30:51< Aishiko> at the moment I'm saving a few points to sort of block out the areas that have been searched like say 100,150 to say 0,0 to 100,150 has been searched and don't bother looking there again its when it gets to a second row that it might not work right and I'm thinking of using an X  (like 100) to set a ceiling for each row that comes after but not sure if that is the best way to go about it
20140413 16:32:10< mordante> not entirely sure what you mean
20140413 16:34:01< Aishiko> its visual basically once a sprite has been found in the first row, instead of checking any empty space above or to the right/left of the found sprite it says "i'll ignore this area" as it's found something and then continues to the right or left looking for the next one.
20140413 16:34:46< mordante> yes
20140413 16:35:35< mordante> well I assume you start at the top left then search at the second row where the columns start
20140413 16:36:34< mordante> and then you only need to look for the start of the next row and validate the known offsets and look whether there are more at the right
20140413 16:36:35< Aishiko> actually I was going on the assumption that the sprites would be in rows columns but no enforcement of spacing or anything like that
20140413 16:37:20< mordante> I'd like to do some enforcement, makes it much easier to write the code and makes the sheet look more consistent
20140413 16:37:29< mordante> (at least for the first version)
20140413 16:37:35< Aishiko> so the end of a column would be the outer edge +1 of the last found sprite
20140413 16:37:39-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140413 16:37:50< mordante> then, if needed, we can relax these rules
20140413 16:38:10< mordante> let me ascii art how I envision a sprite sheet
20140413 16:38:20< Aishiko> OK
20140413 16:39:40< Aishiko> so I shouldn't be worrying about error handling for malformed sheets.. yet
20140413 16:40:16< mordante> no just error reporting
20140413 16:40:43< mordante> this is about the worse case I expect the code to handle
20140413 16:40:49< mordante> http://paste.debian.net/93530/
20140413 16:41:34< mordante> so varying cell width and height and a different number of columns per row
20140413 16:41:57< mordante> but once a column boundary is found it will not change again
20140413 16:42:04< Aishiko> all pushed up against each other or with whitespace (I was assuming whitespace of somekind)
20140413 16:42:39< mordante> the whitespace is the art (since I'm not an artist you have to imagine the great art)
20140413 16:42:55< mordante> the lines are all 1 px is the same colour
20140413 16:43:32< mordante> for the real code in the game we might change the rules a bit if needed
20140413 16:43:48< mordante> but this is a coding example to show me how skilled you are
20140413 16:44:03< mordante> and how you approach a problem etc.
20140413 16:44:26< mordante> even if it's an example I like to see clean and documented code
20140413 16:44:33< Aishiko> no I mean whitespace between the boxes that are holding the art like http://paste.debian.net/93532/
20140413 16:44:58< Aishiko> will do
20140413 16:45:35< mordante> no there is no whitespace between so every box in my example holds an image
20140413 16:46:31-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20140413 16:46:31< Aishiko> ohh that's been my biggest issue, dealing with whitespace between image boxes, that'll make things more easier
20140413 16:47:14-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has joined #wesnoth-dev
20140413 16:47:48-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 245 seconds]
20140413 16:48:14< mordante> no I don't think it will be needed and if people ask for it I'd like to know why they want it
20140413 16:48:38< mordante> also please don't hesitate to ask if you have questions or get stuck
20140413 16:49:00< mordante> we're here as mentors, meaning we're here to assist you
20140413 16:49:00< Aishiko> its also how I see alot of spritesheets if they have borders around the images, so I was sort of following that template
20140413 16:49:22< mordante> ok
20140413 16:50:42< mordante> could be, but I'm convinced, once you have the simple case working the more complex cases could be added
20140413 16:51:10-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140413 16:51:14< mordante> the basis is to detect horizontal and vertical lines in an image
20140413 16:51:23< Aishiko> alright I'll simplify
20140413 16:52:14< mordante> well if you have something more complex and working you can leave it like that
20140413 16:52:25< Aishiko> well more complex, hardly working
20140413 16:54:19< mordante> then indeed, better simplify
20140413 16:55:19-!- Sulfur [~Miranda@p5B008F23.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140413 16:57:21-!- neXyon [~neXyon@85-127-45-150.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140413 16:58:02< Aishiko> In which case I'll eat lunch and then hopefully have something that works to post by dinner
20140413 16:59:23< mordante> ok would be great, good luck
20140413 17:03:00< Aishiko> thank you
20140413 17:03:08< mordante> you're welcome
20140413 17:04:45< Aishiko> and now to work with me
20140413 17:10:05-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140413 17:10:34-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140413 17:21:05< mordante> I'm off bye
20140413 17:21:21< Aishiko> bye and thank you for the clarification mordante 
20140413 17:21:36< mordante> you're welcome
20140413 17:22:02-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140413 17:26:06-!- Ivanovic [~ivanovic@x2f3cb30.dyn.telefonica.de] has quit [Changing host]
20140413 17:26:06-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140413 17:27:48< Ivanovic> back at last...
20140413 17:28:53-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140413 17:29:16-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140413 17:31:47< Ivanovic> mordante, iceiceice, AI0867, mattsc, aquilea, vorobeez: i just saw that you pinged me sometime during the past week
20140413 17:31:56< Ivanovic> i will not read through the complete logs to find those entries
20140413 17:32:13< Ivanovic> if it is something i should look at, please send another message providing some context
20140413 17:34:24< gfgtdf> Ivanovic: i had a question, mordante said i shoudl ask you before i (partly) backport pr 121, it doesn't add new features or new strings, but i it incompatilbe ito previous versions in mp&replay
20140413 17:34:45< Ivanovic> what does it fix?
20140413 17:34:57< Ivanovic> (i mean what does it fix that makes it worth backporting?)
20140413 17:37:18< gfgtdf> Ivanovic: it fixes soem bugs related to [get_global_variable], makes attack related events and turn end events mp save, it makes it impossible to cause OOS by using rand= in select events, any sometign i dont remember right now now.
20140413 17:38:04< gfgtdf> and*
20140413 17:38:07-!- neXyon [~neXyon@85-127-45-150.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20140413 17:39:53< Ivanovic> go for it
20140413 17:40:29< Ivanovic> but make sure to update the release_notes, too!
20140413 17:42:05< gfgtdf> Ivanovic: so te changelod and release_notes ?
20140413 17:42:24-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 258 seconds]
20140413 17:44:46-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140413 17:44:53-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140413 17:46:22< gfgtdf> wesbot: seen boucman
20140413 17:46:23< wesbot> gfgtdf: The person with the nick boucman last spoke 34d 9h ago.  23d 17h ago they left with the message: Remote host closed the connection
20140413 17:48:16-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140413 17:51:21< gfgtdf> iceiceice: when i want to put my local changes from feature branch into master can i just do 'push https://github.com/wesnoth/wesnoth master' ?
20140413 17:52:15< iceiceice> hmm i woudl have to review but i *think* that `push ... master` will always push the master branch regardless of what branch you are currently checked out on
20140413 17:52:39< iceiceice> i think the way you sually do it is, checkout master, then do `merge topic`
20140413 17:52:43< iceiceice> and then push master
20140413 17:52:45-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 250 seconds]
20140413 17:53:20< iceiceice> you might also be able to do something like `push https://... topic:master` but its not what i do
20140413 17:53:45< iceiceice> if there are no merge conflicts then merge topic will just be a fast forward merge
20140413 17:54:23< iceiceice> if there are merge conflicts then i think the `push ... topic:master` will fail
20140413 17:55:44< gfgtdf> iceiceice: i'll tr y the branch:master thing
20140413 17:56:50< iceiceice> definitely dont use -f if it fails
20140413 17:58:33< Ivanovic> gfgtdf: correct
20140413 17:58:42< Ivanovic> [19:31:47] <Ivanovic> mordante, iceiceice, AI0867, mattsc, aquilea, vorobeez: i just saw that you pinged me sometime during the past week
20140413 17:59:52< gfgtdf> iceiceice: it tells me 'error: failed to push some refs to 'https://github.com/wesnoth/wesnoth'
20140413 17:59:54< gfgtdf> hint: Updates were rejected because a pushed branch tip is behind its remote counterpart. Check out this branch and integrate the remote changes (e.g. 'git pull ...') before pushing again.'
20140413 18:00:03< gfgtdf> i'll try the merge into master thing then
20140413 18:02:31< irker642> wesnoth: gfgtdf wesnoth:master f7c3d1f7c580 / src/ (actions/create.cpp actions/move.cpp synced_context.cpp synced_context.hpp): disallow undo when action was sended http://git.io/57FHFw
20140413 18:02:33< irker642> wesnoth: gfgtdf wesnoth:master 6dae3e85a3c6 / src/synced_context.hpp: revmoved unused code http://git.io/q9JmNQ
20140413 18:02:35< irker642> wesnoth: gfgtdf wesnoth:master 37cd42238efa / src/synced_context.hpp: remove outdated comments. http://git.io/8y7lnQ
20140413 18:03:05< gfgtdf> something worked.
20140413 18:08:28< iceiceice> Ivanovic: idk if you read my earlier ping or not, do you want me to explain it again?
20140413 18:09:38< gfgtdf> iceiceice: "<Ivanovic>	i will not read through the complete logs to find those entries" i'd take this as a yes.
20140413 18:09:50< iceiceice> oh i missed this 
20140413 18:09:56< iceiceice> ok let me read the logs again myself :p
20140413 18:21:39< iceiceice> Ivanovic: i found my old message, here's what i wrote about
20140413 18:23:11< iceiceice> i found that in a commit from Feb 21, from before string freeze, i wrote a string which I forgot to put a translation mark on:
20140413 18:23:12< iceiceice> https://github.com/wesnoth/wesnoth/blob/d6c259468661974b820bfdf1f12524288f09b55e/src/playmp_controller.cpp#L556
20140413 18:23:25< iceiceice> the string is "This side is in an idle state. To proceed with the game, the host must assign it to another controller."
20140413 18:23:59< iceiceice> i really dont think its likely that i could make a string using the existing entries to communicate this
20140413 18:24:17< iceiceice> i mean i could make something but it would not be great
20140413 18:24:43-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140413 18:24:47< iceiceice> i wanted to ask, is it possible to break string freeze so i can get this string translated?
20140413 18:24:58-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20140413 18:25:23< iceiceice> (I would replace the one just before it, "Wesnoth", as a blank I think, it makes more sense that way)
20140413 18:27:04-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20140413 18:27:31< iceiceice> i fixed this already on master here: https://github.com/wesnoth/wesnoth/commit/647c3e0c81fb7ae144d1f760555c92ee6d9b11b8
20140413 18:48:44< iceiceice> btw, sorry that i made this mistake
20140413 18:54:40< Ivanovic> i think i already mentioned before that i really hate stringchanges at this time
20140413 18:54:49< Ivanovic> just add it to the list of 1.12.1 changes
20140413 18:57:17< gfgtdf> iceiceice: can we reasign an empty side during a game ?
20140413 18:57:57< iceiceice> Ivanovic: okay, thank you
20140413 18:58:07< iceiceice> gfgtdf: you can do it on local without problems i guess,
20140413 18:58:18< iceiceice> mattsc has a scenario where he assigns a side to empty
20140413 18:58:24< iceiceice> i'm not sure if the server will properly handle such things
20140413 18:58:34< iceiceice> could check in src/server/game.cpp
20140413 18:59:00< gfgtdf> iceiceice: i mean wilth :control
20140413 18:59:03< gfgtdf> with*
20140413 18:59:57< iceiceice> i dont think theres a way to do that, no
20140413 19:00:12-!- Bodhi-Baum [~Bodhi@dslb-084-063-026-120.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140413 19:00:30< iceiceice> for one i think that when the server is figuring out what turn it is, it just counts how many end turns it has seen, divided by number of nonempty sides
20140413 19:00:41< iceiceice> so if that number is changing the code would have to change
20140413 19:01:20< iceiceice> :control only allows you to change th player which is controlling the side, not the controller type
20140413 19:01:30< iceiceice> :droid allows you to toggle human and ai types
20140413 19:01:37< iceiceice> so i dont think you could make a side empty
20140413 19:01:47< gfgtdf> i just tested and i can asign side 3 in caves of basiisk
20140413 19:02:07< iceiceice> does it do anything though?
20140413 19:02:42< iceiceice> tbh its probably a bug i would say, the server probably should reject attempts to take control of an empty side
20140413 19:04:49< gfgtdf> iceiceice: yes i can play side 3 with that (not realy since it has no movable unit though)
20140413 19:05:09< iceiceice> hmm
20140413 19:05:18< iceiceice> i bet if you look in lobby though it will bug the turn cont
20140413 19:05:22< iceiceice> *turn count
20140413 19:05:43< iceiceice> maybe not in master but in 1.12
20140413 19:05:56< iceiceice> no i guess in an version
20140413 19:06:36-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140413 19:06:42-!- Guest54860 [~8680@2002:4404:712c:0:3c08:c42d:4023:6a22] has quit [Ping timeout: 240 seconds]
20140413 19:08:05-!- _8680_ [~8680@2002:4404:712c:0:e5c1:93b5:2e8a:c0f1] has joined #wesnoth-dev
20140413 19:08:23-!- _8680_ is now known as Guest96594
20140413 19:09:55-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: Vannak idők, mikor menni kell]
20140413 19:11:10-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140413 19:19:41-!- Guest96594 [~8680@2002:4404:712c:0:e5c1:93b5:2e8a:c0f1] has quit [Ping timeout: 252 seconds]
20140413 19:20:35-!- _8680__ [~8680@2002:4404:712c:0:5c34:3e06:47d9:bad5] has joined #wesnoth-dev
20140413 19:25:03-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 250 seconds]
20140413 19:25:27-!- _8680__ [~8680@2002:4404:712c:0:5c34:3e06:47d9:bad5] has quit [Ping timeout: 252 seconds]
20140413 19:26:42-!- _8680__ [~8680@2002:4404:712c:0:2ccd:37b0:70ab:9a29] has joined #wesnoth-dev
20140413 19:34:59-!- _8680__ [~8680@2002:4404:712c:0:2ccd:37b0:70ab:9a29] has quit [Ping timeout: 252 seconds]
20140413 19:35:55-!- _8680__ [~8680@2002:4404:712c:0:7092:850f:e63e:23b9] has joined #wesnoth-dev
20140413 19:45:34-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140413 19:49:52-!- ancestral [~ancestral@ip-64-134-224-124.public.wayport.net] has joined #wesnoth-dev
20140413 19:57:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20140413 19:57:26-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140413 20:04:10-!- ancestral [~ancestral@ip-64-134-224-124.public.wayport.net] has quit [Quit: i go nstuf kthxbai]
20140413 20:09:53< irker642> wesnoth: gfgtdf wesnoth:master fad4f6fa4384 / src/play_controller.cpp: a check for deterministic mode in mp. http://git.io/k-Casw
20140413 20:09:55< irker642> wesnoth: gfgtdf wesnoth:master 6e3218959939 / src/ (ai/actions.cpp synced_context.cpp synced_context.hpp): remove the 'only_attacks' random mode http://git.io/pGqrog
20140413 20:13:47-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140413 20:20:03-!- ALourenco [~ALourenco@a95-95-183-13.cpe.netcabo.pt] has joined #wesnoth-dev
20140413 20:25:25-!- neXyon [~neXyon@85-127-45-150.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20140413 20:42:29-!- ALourenco [~ALourenco@a95-95-183-13.cpe.netcabo.pt] has quit [Ping timeout: 240 seconds]
20140413 20:44:52-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 233 bugs, 351 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140413 20:48:33-!- Sulfur [~Miranda@p5B008F23.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140413 21:00:57-!- mjs-de [~mjs-de@f049174167.adsl.alicedsl.de] has joined #wesnoth-dev
20140413 21:05:02-!- ALourenco [~ALourenco@a95-95-183-13.cpe.netcabo.pt] has joined #wesnoth-dev
20140413 21:08:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140413 21:08:55-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has joined #wesnoth-dev
20140413 21:12:32< aquileia> gfgtdf: playturn_controller.cpp & hpp are new by the way, so the VC project needs an update.
20140413 21:13:30< aquileia> My work on enabling the unit tests is pretty slow, so I won't do a PR which could include it soon
20140413 21:15:11< ALourenco> hey
20140413 21:15:30< ALourenco> finaly I have a new laptop
20140413 21:15:34< ALourenco> I can work!!!! yay
20140413 21:21:54< Aishiko> what was wrong with the old laptop ALourenco 
20140413 21:25:40< ALourenco> hdd broke
20140413 21:25:52< ALourenco> and it was really overdated
20140413 21:26:24< ALourenco> building wesnoth took me ages for example
20140413 21:26:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140413 21:27:13-!- travis-ci [~travis-ci@ec2-50-19-205-165.compute-1.amazonaws.com] has joined #wesnoth-dev
20140413 21:27:13< travis-ci> [travis-ci] gfgtdf/wesnoth-old#84 (sync_fix_2 - 05244c5 : gfgtdf): The build passed.
20140413 21:27:13< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/22904791
20140413 21:27:13-!- travis-ci [~travis-ci@ec2-50-19-205-165.compute-1.amazonaws.com] has left #wesnoth-dev []
20140413 21:27:46< gfgtdf> forgot to disble
20140413 21:30:24< aquileia> AI0867: By the way, this might interest you http://wiki.libsdl.org/FAQDevelopment#Do_I_.23include_.3CSDL.h.3E_or_.3CSDL.2FSDL.h.3E.3F
20140413 21:38:23-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has quit [Quit: Page closed]
20140413 21:39:02-!- gfgtdf_ [~chatzilla@e176185093.adsl.alicedsl.de] has joined #wesnoth-dev
20140413 21:40:29-!- gfgtdf [~chatzilla@e177146162.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140413 21:40:42-!- gfgtdf_ is now known as gfgtdf
20140413 21:49:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20140413 22:02:53-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140413 22:04:28-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140413 22:04:35-!- _8680__ [~8680@2002:4404:712c:0:7092:850f:e63e:23b9] has quit [Ping timeout: 252 seconds]
20140413 22:06:42-!- _8680_ [~8680@2002:4404:712c:0:a896:9181:5dcd:61c4] has joined #wesnoth-dev
20140413 22:06:59-!- _8680_ is now known as Guest81354
20140413 22:07:46-!- ALourenco [~ALourenco@a95-95-183-13.cpe.netcabo.pt] has quit [Quit: Leaving]
20140413 22:09:21< gfgtdf> iceiceice: do you know what happends if we use :control during an ai turn ?
20140413 22:14:50-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140413 22:19:03-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds]
20140413 22:26:57< Coffee_irc> thunderstruck: in case you read the logs, yes I remember the discussion about team lock, but mainly that was because of an error with MP settings that we need to avoid reintroducing
20140413 22:52:48-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 245 seconds]
20140413 23:03:40-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140413 23:04:27-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140413 23:10:00-!- irker642 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140413 23:14:25-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140413 23:21:06-!- mjs-de [~mjs-de@f049174167.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140413 23:47:59-!- cib0 [~cib@p20030067CE5CD701267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140413 23:51:02-!- bagzie [~bag@85-76-137-167-nat.elisa-mobile.fi] has quit []
--- Log closed Mon Apr 14 00:00:08 2014