--- Log opened Wed Apr 16 00:00:35 2014 20140416 00:04:21-!- justinzane [~justinzan@host-12-172-184-180.nctv.com] has quit [] 20140416 00:04:36< aquileia> resolution bug reported 20140416 00:06:46-!- justinzane [~justinzan@host-12-172-184-180.nctv.com] has joined #wesnoth-dev 20140416 00:15:20< aquileia> iceiceice: I just looked... the [tutorial] tag is used to display tutorial as the scenario type in the load menu. If you work around that, the tag is superfluous 20140416 00:15:32< aquileia> Just so that you know 20140416 00:16:23< iceiceice> thx, i have no plans to do anything about it 20140416 00:17:14< aquileia> ok 20140416 00:17:42< aquileia> the next_turn issue should be resolved, though... 20140416 00:26:33-!- justinzane [~justinzan@host-12-172-184-180.nctv.com] has quit [Remote host closed the connection] 20140416 00:29:21< iceiceice> AI0867: I actually just now encountered some confusion about the savegame's with spaces in the filename issue 20140416 00:29:48< iceiceice> so if you take a save generated by the game, but messup the filename (accidentally) by say putting "Server " at the beginning 20140416 00:30:04< iceiceice> what will happen is the file will still appear in the load game dialog 20140416 00:30:08< iceiceice> but it will be listed as "invalid" 20140416 00:30:16< iceiceice> if you try to load it, it gives an inscrutable error message 20140416 00:30:31< iceiceice> and only after some digging will you learn that Filesystem.cpp is reporting that it cannot find the file 20140416 00:31:27< iceiceice> The current error message is "Error" "The game could not be loaded:" 20140416 00:31:34-!- gfgtdf [~chatzilla@e177123157.adsl.alicedsl.de] has joined #wesnoth-dev 20140416 00:53:44< aquileia> gfgtdf: hmm... error replay: We called random 0 times, but the original game called random -99 times. 20140416 00:54:17< gfgtdf> aquileia: which version, durign replay,mp, or normal game ? 20140416 00:54:23< aquileia> Even if I'm on a topic branch that might cause some issues, this shouldn't be there I think 20140416 00:54:42< aquileia> 1.13 dev + sdl changes, tutorial 20140416 00:55:04< aquileia> when saving the replay, Wesnoth noticed this 20140416 00:55:23< aquileia> the end of scenario replay, to be precise 20140416 00:55:32< gfgtdf> aquileia: did you tsaved teh replay during a action executes ? 20140416 00:55:35< gfgtdf> save* 20140416 00:57:02< aquileia> the tutorial shows a message at the end, but I didn't do anything but click the end scenario button 20140416 00:57:26< aquileia> I'll try if I can reproduce it or if it was just once 20140416 01:00:07< gfgtdf> aquileia: i just tried on 1.12+dev, which my changes plied and i couldn't reproduce. i'll try again with the 1.13-dev version 20140416 01:01:53< aquileia> gfgtdf: Ok, the second time I tried it I couldn't reproduce the issue 20140416 01:05:56< gfgtdf> aquileia: do you still have teh stderr file from whe teh bug appeared ? 20140416 01:05:58< gfgtdf> the* 20140416 01:07:18< gfgtdf> aquileia: below the "We called random ..." line should be a printed config, i'd like to know. 20140416 01:07:50< aquileia> yes http://pastebin.com/6efaqB1B 20140416 01:08:10-!- Kevin_Xi [~kevin@223.72.182.158] has joined #wesnoth-dev 20140416 01:08:18< aquileia> the advice_turn entries are unrelated 20140416 01:09:13< aquileia> no idea if the gui/event could have consumed a random number or sth. 20140416 01:10:12< gfgtdf> aquileia: do you have a replay from when teh bug occured ? 20140416 01:11:07< aquileia> no, sorry 20140416 01:11:34< iceiceice> thunderstruck: if you get a chance to see this, there is an issue right now where there isn't a good way to load a replay... 20140416 01:11:48< iceiceice> i think it may actually be my fault in a sense, so i might do something about it soon, but if you could help think through it i would appreciate 20140416 01:12:40< iceiceice> i added a warning that appears now when the user attempts to load a multiplayer game through the load game button on the title start 20140416 01:13:23< gfgtdf> aquileia: and it happend when you clicked "end scenario" that bug appeared ? 20140416 01:13:25< iceiceice> the reason is that that codepath immediately causes controller tweaks to be applied and it caused confusing bugs for me at some point which wasted a bunch of time 20140416 01:14:04< iceiceice> the relevant code is here: https://github.com/wesnoth/wesnoth/blob/master/src/game_controller.cpp#L543 20140416 01:14:26< aquileia> gfgtdf: My stderr.txt isn't loaded continuously, but it wasn 20140416 01:14:27< iceiceice> i can't remember what the buggy issue was... 20140416 01:14:52< iceiceice> i think the issue may have been resolved after later commits to fix controller type bugs 20140416 01:14:58< aquileia> wasn't there shortly before the scenario end and I saw it during scenario 2 20140416 01:15:21< iceiceice> but anyways i am finding that now because of the warning, there is no way to watch a replay without warnings or errors 20140416 01:15:41< iceiceice> because if you try to load a replay file in "multiplayer -> load game" like the warning text suggests, 20140416 01:15:48< iceiceice> it actually says "invalid: no id found for scenario" 20140416 01:15:57< iceiceice> and if you disable that warning it says "invalid: no sides found" 20140416 01:16:24< iceiceice> so i think that whatever logic is in the load game button that detects that it is replay, just isn't there for the mp lobby / mp connect stuff 20140416 01:16:37< iceiceice> these "invalid: ..." errors occur in 1.10 as well 20140416 01:17:08< iceiceice> it would be nice if we made it possible to load replays from multiplayer -> load game, 20140416 01:17:18< iceiceice> otoh 20140416 01:17:25< iceiceice> i'm not sure if the warning even needs to be there anymore 20140416 01:17:45< aquileia> AI0867: There is a second way to get the crash: disable music in the preferences 20140416 01:18:46< gfgtdf> aquileia: you have all commits form master in your branch ? 20140416 01:20:04< aquileia> yes 20140416 01:21:30< aquileia> oh, but I did a partial build... hypothetically they aren't necessarily in there... 20140416 01:22:35< aquileia> I guess I'll do a full build overnight and see if it appears again 20140416 01:28:40< gfgtdf> aquileia: normaly this bug should be impossible, although it could be triggered n a very rare case of wrong use of [allow_undo]. So if thats not the case i definitel have to look into this. 20140416 01:28:56< gfgtdf> aquileia: if if doens thappen in a replay. 20140416 01:28:59< gfgtdf> doesn't 20140416 01:29:51< aquileia> gfgtdf: The tutorial uses allow_undo in a move_to event, and find_in is part of this event... I think you found the reason 20140416 01:30:07< gfgtdf> what does find_in ? 20140416 01:31:35< aquileia> oh, sorry, I confused final_hex_x and find_in.x 20140416 01:32:01< aquileia> but final_hex_x should be part of a move_to as well, right? 20140416 01:32:34< aquileia> So it all boils down to that allow_undo 20140416 01:33:37-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 265 seconds] 20140416 01:35:07< gfgtdf> aquileia: yes final_hewy is a checkup zo ensure, that the final hex in a movement is the saem as in the replay. 20140416 01:35:13< gfgtdf> to 20140416 01:35:17< gfgtdf> same* 20140416 01:35:47< aquileia> gfgtdf: Do you know why that move_to is a "wrong use of [allow_undo]"? Is it the [redraw] tag, perhaps? 20140416 01:36:45< gfgtdf> no moveto is normal no wrong use in disallow undo, only if you to gamechaning things in it. 20140416 01:36:53< aquileia> https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/tutorial/scenarios/1_Tutorial.cfg#L275 20140416 01:37:00< aquileia> This is the event 20140416 01:38:05< gfgtdf> aquileia: i can find nothing wrong with that event 20140416 01:39:33< aquileia> well, we'll never know... as it isn't reproducible, it's hard to track the circumstances down 20140416 01:40:49< gfgtdf> aquileia: did you do something with shroud updates durign the game ? 20140416 01:41:02< aquileia> no shroud at all 20140416 01:41:09< gfgtdf> ah true 20140416 01:41:11-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has quit [Ping timeout: 276 seconds] 20140416 01:49:59< irker705> wesnoth: gfgtdf wesnoth:master 6845d5d9fef9 / src/replay.cpp: removed invalid comment. http://git.io/3_JfpQ 20140416 01:50:07-!- Kevin_Xi [~kevin@223.72.182.158] has quit [Quit: Leaving.] 20140416 01:54:46< gfgtdf> aquileia: coudl you reproduce it a second time ? 20140416 01:56:10< gfgtdf> aquileia: di you use debug mode? 20140416 01:58:42< aquileia> up until now I couldn't reproduce it 20140416 01:59:06< aquileia> and I didn't use debug that time 20140416 01:59:33-!- _8680__ [~8680@2002:4404:712c:0:8423:6d83:d2fa:81e3] has quit [Remote host closed the connection] 20140416 01:59:55-!- _8680_ [~8680@2002:4404:712c:0:ed38:8df3:ed87:a6e7] has joined #wesnoth-dev 20140416 02:00:15-!- _8680_ is now known as Guest11551 20140416 02:02:10-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140416 02:02:42-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 02:03:11< gfgtdf> aquileia: ok acrding to your debuglog that happend durign turn 3 20140416 02:03:27-!- sachith500 [~kvirc@112.134.21.85] has joined #wesnoth-dev 20140416 02:05:18< aquileia> ah, you measured in units of error message blocks? 20140416 02:06:32< gfgtdf> yes :) 20140416 02:07:27-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 265 seconds] 20140416 02:07:55< gfgtdf> i happend in second 50 of 66 of turn 3 :p 20140416 02:08:18< gfgtdf> aquileia;: you know what you did in second 50 of 66 of turn 4 ? 20140416 02:08:21< gfgtdf> 3* 20140416 02:08:29-!- Ivanovic_ [~ivanovic@x2f3b76e.dyn.telefonica.de] has joined #wesnoth-dev 20140416 02:09:14< aquileia> no idea, I probably read my log =p 20140416 02:10:50-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds] 20140416 02:12:23-!- Ivanovic_ is now known as Ivanovic 20140416 02:12:59-!- sachith500 [~kvirc@112.134.21.85] has quit [Ping timeout: 252 seconds] 20140416 02:13:15-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140416 02:23:41< gfgtdf> aquileia: can you make stackstraces when you find the bug ? 20140416 02:23:55< gfgtdf> because i still couldn't preododuce it 20140416 02:25:15-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 258 seconds] 20140416 02:26:43< aquileia> Me neither and I really have to go to bed now... 20140416 02:28:05-!- justinzane [~justinzan@12.172.184.180] has joined #wesnoth-dev 20140416 02:28:42< aquileia> It's unfortunate that the issue can't be found, but meh, there are more pressing bugs... bugs that really break things 20140416 02:30:35< gfgtdf> aquileia: ok when you ever find that bug a second time can you send me a stderror + replay ? 20140416 02:31:32-!- sachith500 [~kvirc@112.134.21.85] has joined #wesnoth-dev 20140416 02:32:43-!- Sulfur [~Miranda@p5B00963D.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140416 02:33:49< aquileia> gfgtdf: Sure 20140416 02:33:59< aquileia> good night 20140416 02:34:07< gfgtdf> night 20140416 02:34:19-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has quit [Quit: Page closed] 20140416 02:36:34< iceiceice> gfgtdf: 20140416 02:36:40< iceiceice> i'm getting assert errors in replay_controller.cpp 20140416 02:36:45< iceiceice> when i try to load server replays 20140416 02:36:56< gfgtdf> iceiceice : has_child/(start) ? 20140416 02:36:57< iceiceice> you wont be able to reproduce unless you pull my topic though :p 20140416 02:37:05< iceiceice> yeah at line 297 20140416 02:37:17< iceiceice> hmm 20140416 02:37:31< iceiceice> you know what this is rom a replay from before your patch , this is a stupid reprot 20140416 02:37:32< gfgtdf> ye i think we have taked about this before, that the server doesnt add the [start] at teh beginning og the replays 20140416 02:37:46< iceiceice> does it do it in master now? 20140416 02:37:51< gfgtdf> i think no 20140416 02:38:02< iceiceice> :O 20140416 02:38:14< iceiceice> hmm 20140416 02:38:22< iceiceice> so what needs to happen? 20140416 02:38:31< gfgtdf> note that observer create the [start] tag on their own, so putting it into [history] would be wrong 20140416 02:38:32< iceiceice> there needs to be a [start] tag? 20140416 02:38:37< iceiceice> hmm 20140416 02:38:48-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140416 02:39:03< iceiceice> so wait how do non server replays work 20140416 02:39:13< iceiceice> does replay controller add the [start] ? 20140416 02:39:27< gfgtdf> no tehy are in teh replay: normal rplay look like this: http://pastebin.com/12Ln2sw5 20140416 02:39:32< gfgtdf> replays* 20140416 02:39:52< gfgtdf> but teh [command][start][/start][/command] is missing in server sided replays. 20140416 02:40:06< gfgtdf> the [checkup] is not required though 20140416 02:40:11< iceiceice> so the command [start] is set from host?? 20140416 02:40:27< gfgtdf> each client sets it indiviualy 20140416 02:40:30< iceiceice> hmm 20140416 02:40:33< iceiceice> where? 20140416 02:41:26< iceiceice> in playsingle_controller.cpp i see? 20140416 02:41:36< gfgtdf> https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L394 20140416 02:42:06< gfgtdf> addin a [command][start][/start][/command] in the serversides save rplay method could fix tis problem 20140416 02:42:23< gfgtdf> before gitrpoy 20140416 02:42:26< gfgtdf> history 20140416 02:42:33< iceiceice> okay... 20140416 02:43:27< iceiceice> so why do we do it this way, why is [start] not transmitted 20140416 02:44:18< gfgtdf> all clients generate their own [start] i think teh main reason is that we dont want to wait for others to send [start] if it doesnt contain any importatn data anyway 20140416 02:44:29< gfgtdf> becasue we don't liek to wait 20140416 02:44:31< gfgtdf> like* 20140416 02:44:52-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 233 bugs, 350 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140416 02:45:07< iceiceice> why does it need to be in the replay at all? 20140416 02:45:19< iceiceice> if every replay is basically requried to start with [command] [start] [/start] [/command 20140416 02:45:29< iceiceice> then it isnt really conveying and info at all 20140416 02:45:35< iceiceice> *any info 20140416 02:46:08< gfgtdf> hm it contains a little chechup to cehckup whether we called the random generateo teh same times as we did in the origianl game, but its not thaaat important 20140416 02:46:47< gfgtdf> see liek link i posted above 20140416 02:46:50< gfgtdf> like* 20140416 02:46:53< gfgtdf> link* 20140416 02:47:23< iceiceice> what is the checkup? 20140416 02:48:13< gfgtdf> a meachnism to compare data we calculated during teh replay with the data we calculated during the original game, and if necesary overwrite the calculated data, or to notice OOS error as soon as possible 20140416 02:49:04< iceiceice> ok but if it isn't there no big deal? 20140416 02:50:11< iceiceice> it looks like in replay.cpp you dont do anything when you see the start tag 20140416 02:50:32< iceiceice> so nothing bad would happen if it wasn't there... ? 20140416 02:50:39< iceiceice> yet you assert if it is missing? 20140416 02:51:21< gfgtdf> its a technical reason why we need it: the synced context expects, that there is always a data on the replay to store the checkup: https://github.com/wesnoth/wesnoth/blob/master/src/synced_context.cpp#L283 20140416 02:52:39< gfgtdf> you can tr what happends if you click "continue" on the assert but i think you'd trigger https://github.com/wesnoth/wesnoth/blob/master/src/replay.cpp#L464, and maye a segfault. 20140416 02:52:41< gfgtdf> try* 20140416 02:52:47< gfgtdf> maybe 20140416 02:52:56< iceiceice> ok, i think instead of an assert, you should just have "if missing, then add_start" ? 20140416 02:52:56< gfgtdf> iceiceice: ^ 20140416 02:53:25< iceiceice> at the beginning of the replay? 20140416 02:53:29< gfgtdf> no add_start adds teh start at the end f teh replay 20140416 02:53:36< iceiceice> well that could be changed right? 20140416 02:53:54< iceiceice> you would never want to add the start to the end of the replay anyways 20140416 02:54:09< gfgtdf> probably not 20140416 02:55:08< iceiceice> idk maybe instead of this assertion check, 20140416 02:55:20< iceiceice> you can make it part of the constructor, if you dont see a [start] then add it before doing anything else 20140416 02:55:33< gfgtdf> of which contructor? 20140416 02:55:38< iceiceice> of replay i suppose 20140416 02:56:23< iceiceice> i guess its fine to require all replay files to have start, and we could put this in the server, 20140416 02:56:28< iceiceice> frankly that should have been part of 121 20140416 02:56:56< gfgtdf> ye i knew of this but i wasnt sure becasue i couldnt test it becasue i alwasy got another error 20140416 02:56:56< iceiceice> but it is really bizarre that wesnoth should crash on something so trivial as this 20140416 02:57:02< iceiceice> ok 20140416 02:57:09< iceiceice> i think i have fixed the other error now 20140416 02:57:14< gfgtdf> something with maditory child missing 20140416 02:57:44< iceiceice> if we can make [start] not require it will mean that people can load 1.10 server replays i believe 20140416 02:57:55< iceiceice> not sure though 20140416 02:58:01< iceiceice> hmm i guess not actually... 20140416 02:58:09< iceiceice> but anyways you would be able to load like 90% of them 20140416 02:58:19< iceiceice> or something 20140416 02:58:27< gfgtdf> no i changes teh rng verymuch, i doubt we can load any scenario from 1.10 aht used teh rng 20140416 02:58:28< iceiceice> if [start] is required it means they will all fail instantly this way 20140416 02:58:45< iceiceice> right 20140416 02:58:46< gfgtdf> any every scenario uses teh rmg 20140416 02:58:48< gfgtdf> rng 20140416 02:58:51< gfgtdf> and* 20140416 02:58:58< iceiceice> okay... 20140416 02:59:01< gfgtdf> for attacks/traits 20140416 02:59:04< gfgtdf> unitnames 20140416 02:59:40< iceiceice> okay i'm going to try to add your [command][start] [/start] [/command] to server replays i guess 20140416 02:59:44< gfgtdf> i think there was a scenario where you had 5 graphons and had to capture as much villages as possible, mabye that coudl still wokr :) 20140416 02:59:48< iceiceice> if it doesnt work you will help me? 20140416 02:59:52< gfgtdf> ye sure 20140416 02:59:54< iceiceice> ok 20140416 03:00:37< iceiceice> you should also make a note in http://wiki.wesnoth.org/SaveFileWML 20140416 03:00:45< iceiceice> if this [command] [start] thing is mandatory 20140416 03:00:48< iceiceice> idk 20140416 03:00:57-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral] 20140416 03:01:03< iceiceice> oh you did 20140416 03:01:09< iceiceice> but i guess it should be like, noted that it is mandatory? 20140416 03:01:13< iceiceice> hmm idk 20140416 03:01:39< gfgtdf> what did i ? 20140416 03:02:32< gfgtdf> i think i didnt't change http://wiki.wesnoth.org/SaveFileWML 20140416 03:03:06-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140416 03:04:04< gfgtdf> iceiceice: you can see what a special poersio added to the wiki: http://wiki.wesnoth.org/Special:Contributions/Gfgtdf 20140416 03:04:58< gfgtdf> iceiceice : do you plan to repair serversides replay completely ? 20140416 03:05:02< gfgtdf> replays* 20140416 03:05:07< iceiceice> yes 20140416 03:05:13< gfgtdf> meaning also from relaoded games ? 20140416 03:05:24< iceiceice> yes if possible 20140416 03:05:36< gfgtdf> in 1.12 ? 20140416 03:05:52< iceiceice> i dont think it will be very hard 20140416 03:06:11< gfgtdf> ok :) 20140416 03:06:16< iceiceice> there are actually established work arounds in the community, like 20140416 03:06:29< iceiceice> "open savefile in microsoft word, cut block here, paste here. save." 20140416 03:07:09< iceiceice> idk who was supposed to be maintaining this stuff but if they had ever looked on forums it seems like there are actually already bugfixes known 20140416 03:07:14< gfgtdf> iceiceice: do you also plan to fix: https://gna.org/bugs/?21866 20140416 03:07:22< iceiceice> the only thing the users wont do is actually code the C++ fix in most cases 20140416 03:07:46< iceiceice> idk how to fix that 20140416 03:08:21-!- TC01 [~quassel@128.220.109.252] has joined #wesnoth-dev 20140416 03:08:21< gfgtdf> hm ok. 20140416 03:12:39< iceiceice> i think its important that that be fixed, and maybe even should upgrade to blocker. but i think there are many people besides you and me who can look at it, they just havent found time to do it yet i guess 20140416 03:13:25< iceiceice> it was only a few weeks ago i remember a bunch of people chatting on irc about some underlying id issue 20140416 03:14:35< gfgtdf> ye i rmember 20140416 03:15:53< gfgtdf> iceiceice: yo you know about the state of the unifying sp&mp task ? 20140416 03:16:13< iceiceice> its gsoc right? 20140416 03:16:26< gfgtdf> idk 20140416 03:16:30< iceiceice> idk who all is applying but i think RiftWalker is one of them 20140416 03:17:04< vultraz> there are 2 proposals 20140416 03:17:11< vultraz> RiftWalker;s is the only good one 20140416 03:18:24< gfgtdf> who is teh other ? 20140416 03:19:18< vultraz> http://wiki.wesnoth.org/SoC2014_youngoli_UnifySPandMP 20140416 03:19:27< vultraz> he never even finished his proposal 20140416 03:20:02-!- Sulfur [~Miranda@p5B00963D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20140416 03:20:03< gfgtdf> ok ty 20140416 03:20:06< gfgtdf> i go to bed now 20140416 03:20:09-!- gfgtdf [~chatzilla@e177123157.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]] 20140416 03:43:03-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 03:47:40-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20140416 03:49:35-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 258 seconds] 20140416 03:55:16-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140416 03:58:28< AI0867> 19:54 < aquileia> AI0867: Is renaming 2_Tutorial.cfg to 2_Tütorial.cfg (and changing the scenario ID in both scenarios as well) enough to prove that WML loading works? ← I would suspect so, though moving the entire installation into a unicode-containing path might be more convincing 20140416 03:58:45< AI0867> 19:56 < aquileia> master has no problem with that, so boost::locale isn't obligatory to parse unicode WML file paths & contents AFAICT ← then it might just be saves and SDL stuff 20140416 03:59:02< AI0867> 20:11 < gfgtdf> what was the reason to disallow sapces in flienames ? ← spaces are evil 20140416 03:59:21< AI0867> also, various tools assume they're item separators 20140416 04:03:18< AI0867> 02:30 < iceiceice> if you try to load it, it gives an inscrutable error message ← that sounds like a bug to be fixed 20140416 04:03:47-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140416 04:04:01< AI0867> 03:17 < aquileia> AI0867: There is a second way to get the crash: disable music in the preferences ← that stops all music, and deletes all the relevant objects, just like closing the game does, so that's not surprising 20140416 04:09:29-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20140416 04:16:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 252 seconds] 20140416 04:45:40-!- sachith500 [~kvirc@112.134.21.85] has quit [Read error: Connection reset by peer] 20140416 04:48:48-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140416 04:50:03-!- irker705 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20140416 05:10:10-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140416 05:22:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20140416 05:25:52-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140416 05:31:13-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 05:35:45-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds] 20140416 05:46:53-!- Ivanovic [~ivanovic@x2f3b76e.dyn.telefonica.de] has quit [Changing host] 20140416 05:46:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140416 05:49:14-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Remote host closed the connection] 20140416 05:53:44-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev 20140416 05:55:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140416 06:02:51-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 06:05:41-!- sachith500 [~kvirc@112.134.21.85] has joined #wesnoth-dev 20140416 06:07:17-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds] 20140416 06:12:34-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140416 06:20:25-!- sachith500|2 [~kvirc@112.134.96.183] has joined #wesnoth-dev 20140416 06:22:55-!- sachith500 [~kvirc@112.134.21.85] has quit [Ping timeout: 258 seconds] 20140416 06:26:33-!- Guest11551 [~8680@2002:4404:712c:0:ed38:8df3:ed87:a6e7] has quit [Ping timeout: 245 seconds] 20140416 06:27:28-!- _8680_ [~8680@2002:4404:712c:0:35be:533f:a3ad:86e9] has joined #wesnoth-dev 20140416 06:27:50-!- _8680_ is now known as Guest2806 20140416 06:28:24-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Remote host closed the connection] 20140416 06:31:57-!- Guest2806 [~8680@2002:4404:712c:0:35be:533f:a3ad:86e9] has quit [Ping timeout: 252 seconds] 20140416 06:32:27< iceiceice> thunderstruck, gfgtdf: I now have an experimental branch where at least vanilla 1v1 games can yield readable server replays: 20140416 06:32:28< iceiceice> https://github.com/wesnoth/wesnoth/pull/150 20140416 06:33:24-!- _8680__ [~8680@2002:4404:712c:0:2c18:8b3a:e330:fc68] has joined #wesnoth-dev 20140416 06:39:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140416 06:41:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140416 06:47:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140416 06:53:22-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood] 20140416 06:54:53-!- _8680__ [~8680@2002:4404:712c:0:2c18:8b3a:e330:fc68] has quit [Ping timeout: 245 seconds] 20140416 06:55:22-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Changing host] 20140416 06:55:22-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev 20140416 06:56:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20140416 06:58:38-!- _8680__ [~8680@2002:4404:712c:0:f050:eaae:7651:f484] has joined #wesnoth-dev 20140416 06:58:45-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140416 06:59:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140416 07:04:42-!- _8680__ [~8680@2002:4404:712c:0:f050:eaae:7651:f484] has quit [Ping timeout: 258 seconds] 20140416 07:05:01-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection] 20140416 07:10:59-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140416 07:11:25-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140416 07:11:42-!- _8680__ [~8680@2002:4404:712c:0:c18a:833f:be6a:1a14] has joined #wesnoth-dev 20140416 07:13:53-!- bagzie [~bag@85-76-129-96-nat.elisa-mobile.fi] has joined #wesnoth-dev 20140416 07:21:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140416 07:21:49-!- _8680__ [~8680@2002:4404:712c:0:c18a:833f:be6a:1a14] has quit [Ping timeout: 246 seconds] 20140416 07:24:12-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving] 20140416 07:24:46-!- _8680__ [~8680@2002:4404:712c:0:d106:351e:58ef:d633] has joined #wesnoth-dev 20140416 07:28:16-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20140416 07:31:17-!- _8680__ [~8680@2002:4404:712c:0:d106:351e:58ef:d633] has quit [Ping timeout: 246 seconds] 20140416 07:31:42-!- _8680_ [~8680@2002:4404:712c:0:c511:ec2e:1a19:4734] has joined #wesnoth-dev 20140416 07:32:00-!- _8680_ is now known as Guest45400 20140416 07:44:42-!- Guest45400 [~8680@2002:4404:712c:0:c511:ec2e:1a19:4734] has quit [Ping timeout: 240 seconds] 20140416 07:45:49-!- _8680__ [~8680@2002:4404:712c:0:3567:338f:2577:f924] has joined #wesnoth-dev 20140416 08:00:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20140416 08:01:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140416 08:02:47-!- _8680__ [~8680@2002:4404:712c:0:3567:338f:2577:f924] has quit [Ping timeout: 252 seconds] 20140416 08:03:31-!- neXyon [~neXyon@178-191-148-131.adsl.highway.telekom.at] has joined #wesnoth-dev 20140416 08:03:46-!- _8680__ [~8680@2002:4404:712c:0:4c16:95b3:83d:228d] has joined #wesnoth-dev 20140416 08:22:48-!- _8680__ [~8680@2002:4404:712c:0:4c16:95b3:83d:228d] has quit [Ping timeout: 245 seconds] 20140416 08:23:33-!- _8680__ [~8680@2002:4404:712c:0:9c67:beeb:f50c:2b4b] has joined #wesnoth-dev 20140416 08:25:58-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 258 seconds] 20140416 08:35:40-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20140416 08:41:17-!- _8680__ [~8680@2002:4404:712c:0:9c67:beeb:f50c:2b4b] has quit [Ping timeout: 252 seconds] 20140416 08:41:56-!- _8680_ [~8680@2002:4404:712c:0:c4bc:d27:2e70:df26] has joined #wesnoth-dev 20140416 08:42:16-!- _8680_ is now known as Guest43647 20140416 08:44:52-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 234 bugs, 350 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140416 08:54:42-!- Guest43647 [~8680@2002:4404:712c:0:c4bc:d27:2e70:df26] has quit [Ping timeout: 240 seconds] 20140416 08:56:12-!- _8680__ [~8680@2002:4404:712c:0:1067:7071:7ed7:c579] has joined #wesnoth-dev 20140416 09:02:23-!- _8680__ [~8680@2002:4404:712c:0:1067:7071:7ed7:c579] has quit [Ping timeout: 258 seconds] 20140416 09:04:34-!- Ardonik [~user@adsl-75-28-103-78.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 240 seconds] 20140416 09:04:52-!- _8680__ [~8680@2002:4404:712c:0:2c1e:68db:974b:1d6e] has joined #wesnoth-dev 20140416 09:08:49-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has joined #wesnoth-dev 20140416 09:09:37-!- mjs-de [~mjs-de@f049002118.adsl.alicedsl.de] has joined #wesnoth-dev 20140416 09:09:47-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood] 20140416 09:10:18-!- _8680__ [~8680@2002:4404:712c:0:2c1e:68db:974b:1d6e] has quit [Ping timeout: 240 seconds] 20140416 09:11:45< aquileia> AI0867: "moving the entire installation into a unicode-containing path" wasn't possible as a test case on master as this needs your SDL fix. I confirmed that this works in the sdl_fix branch, so (except for the double free) everything but marcos is unicode safe now 20140416 09:14:06< aquileia> I phrased it ambiguously... the double free happens with and without unicode usage 20140416 09:14:10-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140416 09:14:47-!- _8680__ [~8680@2002:4404:712c:0:48f7:8731:47f4:b53c] has joined #wesnoth-dev 20140416 09:16:59-!- Ardonik [~user@adsl-75-28-103-78.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev 20140416 09:18:37< aquileia> Would somebody merge ? 20140416 09:18:54< aquileia> https://github.com/wesnoth/wesnoth/pull/149 20140416 09:20:41-!- _8680__ [~8680@2002:4404:712c:0:48f7:8731:47f4:b53c] has quit [Remote host closed the connection] 20140416 09:24:42-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds] 20140416 09:24:53< aquileia> shadowm: without sleep deprivation I see that eef30804a49 can't be the cause for this... 20140416 09:25:58-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 09:26:16-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer] 20140416 09:26:38-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20140416 09:29:40-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140416 09:32:11-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection] 20140416 09:33:54< aquileia> AI0867: https://github.com/wesnoth/wesnoth/commit/4474d22da <-- did this commit erally intend to produce this result? http://imagebin.org/305908 20140416 09:34:01< aquileia> *really 20140416 09:34:32-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 265 seconds] 20140416 09:35:28< aquileia> I think you rather wanted std::min(res.first/div, res.second/div) <=10 20140416 09:41:25-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20140416 09:44:13-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20140416 10:05:40-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 20140416 10:05:42-!- Kevin_Xi [~kevin@223.72.182.190] has joined #wesnoth-dev 20140416 10:06:26< aquileia> mordante: I could fix https://gna.org/bugs/?21915 by reverting your commit https://github.com/wesnoth/wesnoth/commit/04eea8963 20140416 10:07:41< Kevin_Xi> Hi! Any reason for the codeblocks-scons project file not include the game_controller.?pp(and many others)? The project file recently updated on 'Sun Oct 27 12:13:45 2013' and the game_controller file is already exist at that time. Is it obsolete? 20140416 10:10:32< aquileia> Kevin_Xi: Project files sometimes are updated just to add stuff from a single commit, the date of the last change doesn't say that it worked at that time... 20140416 10:11:48< aquileia> And codeblocks-scons isn't really maintained; the normal codeblocks was fixed by shadowm recently, you can take this as a base 20140416 10:13:09-!- vultraz [~chatzilla@124.109.10.167] has quit [Read error: Connection reset by peer] 20140416 10:14:18-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20140416 10:15:17< Kevin_Xi> aquileia: well I still use it...is that still deserve maintained? 20140416 10:15:18-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev 20140416 10:16:19< aquileia> Kevin_Xi: If you want to bring it up to date by copying from the standard codeblocks project, this would be great 20140416 10:18:23< aquileia> Most devs only think of scons and cmake when adding files, even XCode, VC and normal CB depend on people to repair from time to time 20140416 10:18:23< Kevin_Xi> aquileia: OK, thank you, I will create a PR. 20140416 10:25:53-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 250 seconds] 20140416 10:26:37< aquileia> Kevin_Xi: Before I forget it, currently playturn_network_adapter.?pp is neiter in CB nor in CB-scons 20140416 10:28:29-!- Sulfur [~Miranda@p5B00963D.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140416 10:28:49< aquileia> you might want to add it in both for your PR 20140416 10:29:32-!- Kevin_Xi [~kevin@223.72.182.190] has quit [Quit: Leaving.] 20140416 10:29:53-!- Kevin_Xi [~kevin@223.72.182.190] has joined #wesnoth-dev 20140416 10:31:16< Kevin_Xi> aquileia: sorry the wifi is down for a while. AFAICR there is a developer guide-like wiki page mentioned only about changelogs and scons, want to add this and can't find that... about project file: OK, I will diff the project files with what we have now, thank you! 20140416 10:33:03-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20140416 10:33:16< AI0867> aquileia: I just intended to filter out the too-ridiculous aspect ratios with that 20140416 10:33:32< AI0867> 16:10 is a valid one, and there might be others nearby 20140416 10:33:42< aquileia> Then I'd fix that if you don't mind 20140416 10:34:29< AI0867> okay 20140416 10:36:21-!- Kevin_Xi [~kevin@223.72.182.190] has quit [Quit: Leaving.] 20140416 10:37:30-!- irker125 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140416 10:37:30< irker125> wesnoth: aquileia wesnoth:master 4146d428b8ea / projectfiles/VC9/wesnoth.vcproj: Update VC project for 847067dac7 http://git.io/95_FfQ 20140416 10:37:32< irker125> wesnoth: aquileia wesnoth:master 066ae06083f1 / data/campaigns/tutorial/scenarios/1_Tutorial.cfg: Reapply a5cb1492c4 on 1_Tutorial.cfg http://git.io/KYOo4A 20140416 10:37:34< irker125> wesnoth: Alexander van Gessel wesnoth:master 681e667a47fd / data/campaigns/tutorial/scenarios/1_Tutorial.cfg projectfiles/VC9/wesnoth.vcproj: Merge pull request #149 from aquileia/clean_up http://git.io/Vv1YNA 20140416 10:40:16< aquileia> AI0867: thanks 20140416 10:46:57-!- EdB [~edb@80.215.194.216] has joined #wesnoth-dev 20140416 10:50:09-!- EdB [~edb@80.215.194.216] has quit [Read error: Connection reset by peer] 20140416 10:52:28-!- EdB [~edb@80.215.194.216] has joined #wesnoth-dev 20140416 10:56:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20140416 10:57:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140416 10:58:33-!- EdB [~edb@80.215.194.216] has quit [Read error: Connection reset by peer] 20140416 11:05:14< aquileia> ah, I think I found the bug: If a resolution is too small, it isn't displayed in the dialog... but it's still in the resolution list and will be picked. resolutions[static_cast(choice)] overlooks that 20140416 11:05:36< aquileia> Which means I can fix that easily, I think 20140416 11:06:39< AI0867> the standard "using the index from a filtered list on the unfiltered list" bug? 20140416 11:07:06-!- spoffy [~spoffy@host86-181-255-251.range86-181.btcentralplus.com] has joined #wesnoth-dev 20140416 11:10:14< aquileia> AI0867: exactly 20140416 11:15:37< aquileia> what of these is better style, (ratio[0] <= 10 && ratio[1] <= 10) or (std::min_element(ratio) <= 10) ? 20140416 11:16:02< aquileia> oh, never mind... they aren't the same 20140416 11:23:34-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 11:26:50-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds] 20140416 11:27:43-!- Kevin_Xi [~kevin@223.72.182.158] has joined #wesnoth-dev 20140416 11:37:28-!- neXyon [~neXyon@178-191-148-131.adsl.highway.telekom.at] has quit [Quit: bye] 20140416 11:38:58-!- neXyon [~neXyon@178-191-148-131.adsl.highway.telekom.at] has joined #wesnoth-dev 20140416 11:44:18< Aishiko> mordante I'll add a test file(one that should work perfectly) and a main.cpp to call and test it and post around lunch today, sorry about the delay Tuesday is my long day classes from 0900EST untill 2200EST 20140416 11:47:43-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW] 20140416 11:48:20-!- _8680_ [~8680@2002:4404:712c:0:cc60:41bc:34e4:a0d2] has joined #wesnoth-dev 20140416 11:48:33-!- _8680_ is now known as Guest85671 20140416 11:53:05-!- Guest85671 [~8680@2002:4404:712c:0:cc60:41bc:34e4:a0d2] has quit [Ping timeout: 246 seconds] 20140416 11:54:38-!- _8680__ [~8680@2002:4404:712c:0:a89f:25ea:e792:aa36] has joined #wesnoth-dev 20140416 12:00:38-!- _8680__ [~8680@2002:4404:712c:0:a89f:25ea:e792:aa36] has quit [Ping timeout: 258 seconds] 20140416 12:01:05-!- _8680__ [~8680@2002:4404:712c:0:412b:9e70:b612:7e37] has joined #wesnoth-dev 20140416 12:06:56< Soliton> sachith500|2: hi, got a minute? 20140416 12:06:58-!- _8680__ [~8680@2002:4404:712c:0:412b:9e70:b612:7e37] has quit [Ping timeout: 245 seconds] 20140416 12:07:46< sachith500|2> hey Soliton 20140416 12:07:49< sachith500|2> what's up 20140416 12:08:28< Soliton> mind if i pm you? 20140416 12:08:34< sachith500|2> sure go ahead 20140416 12:14:00-!- _8680__ [~8680@2002:4404:712c:0:212a:7ec8:e9d9:4070] has joined #wesnoth-dev 20140416 12:19:54-!- _8680__ [~8680@2002:4404:712c:0:212a:7ec8:e9d9:4070] has quit [Ping timeout: 240 seconds] 20140416 12:20:07-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds] 20140416 12:21:14-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 12:21:24-!- _8680__ [~8680@2002:4404:712c:0:d921:efa6:af0f:d40a] has joined #wesnoth-dev 20140416 12:26:26-!- _8680__ [~8680@2002:4404:712c:0:d921:efa6:af0f:d40a] has quit [Ping timeout: 252 seconds] 20140416 12:29:37-!- Sulfur [~Miranda@p5B00963D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20140416 12:34:47-!- happygrue [~happygrue@2601:6:4380:7df:59cd:e1f:3ffb:4034] has joined #wesnoth-dev 20140416 12:34:47-!- happygrue [~happygrue@2601:6:4380:7df:59cd:e1f:3ffb:4034] has quit [Changing host] 20140416 12:34:47-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140416 12:50:03-!- _8680_ [~8680@2002:4404:712c:0:143:32d6:5068:10fa] has joined #wesnoth-dev 20140416 12:50:18-!- _8680_ is now known as Guest83251 20140416 12:54:18-!- Guest83251 [~8680@2002:4404:712c:0:143:32d6:5068:10fa] has quit [Ping timeout: 240 seconds] 20140416 12:55:57-!- Sulfur [~Miranda@p5B00963D.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140416 13:04:00-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev 20140416 13:04:13-!- _8680__ [~8680@2002:4404:712c:0:e0a5:9820:5bf4:d3fe] has joined #wesnoth-dev 20140416 13:04:54< aquileia> https://github.com/wesnoth/wesnoth/pull/151 ready for commit, https://gna.org/bugs/?21915 ready to be closed 20140416 13:05:27-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Client Quit] 20140416 13:06:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping] 20140416 13:09:47< aquileia> Oh, and could somebody cherry-pick 066ae06083 from master to 1.12, please? 20140416 13:10:18-!- _8680__ [~8680@2002:4404:712c:0:e0a5:9820:5bf4:d3fe] has quit [Ping timeout: 240 seconds] 20140416 13:15:52< aquileia> mordante: selection2-border-[topleft, topright, botleft, botright] are overlays and need selection2-border-[top, right, bottom, left] below them I think, but the listbox chooses these too short leading to edges like in this screenshot http://imagebin.org/305908 20140416 13:16:09-!- _8680__ [~8680@2002:4404:712c:0:e4d4:4e8c:9c66:298b] has joined #wesnoth-dev 20140416 13:16:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140416 13:16:54< aquileia> The border around the selected item has rather distracting edges due to this 20140416 13:17:14< aquileia> I have no idea where to fix this 20140416 13:17:55< aquileia> But at least the other bug is fixed 20140416 13:22:23-!- _8680__ [~8680@2002:4404:712c:0:e4d4:4e8c:9c66:298b] has quit [Ping timeout: 245 seconds] 20140416 13:23:14-!- _8680__ [~8680@2002:4404:712c:0:19ec:3c8a:b0a4:ad33] has joined #wesnoth-dev 20140416 13:31:19-!- _8680__ [~8680@2002:4404:712c:0:19ec:3c8a:b0a4:ad33] has quit [Ping timeout: 252 seconds] 20140416 13:37:36-!- irker125 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20140416 13:38:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140416 13:42:23-!- sachith500|2 [~kvirc@112.134.96.183] has quit [Read error: Connection reset by peer] 20140416 13:42:39-!- sachith500|2 [~kvirc@112.134.96.183] has joined #wesnoth-dev 20140416 13:44:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140416 13:49:48-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140416 13:50:24-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 13:50:36-!- _8680_ [~8680@2002:4404:712c:0:1c12:146e:7472:e2ff] has joined #wesnoth-dev 20140416 13:50:55-!- _8680_ is now known as Guest72426 20140416 13:51:21-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 13:52:58-!- Kexoth [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140416 13:53:19-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 13:54:03-!- spoffy [~spoffy@host86-181-255-251.range86-181.btcentralplus.com] has quit [Ping timeout: 252 seconds] 20140416 13:54:28-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20140416 13:56:09-!- spoffy [~spoffy@host86-181-255-251.range86-181.btcentralplus.com] has joined #wesnoth-dev 20140416 14:01:20-!- Guest72426 [~8680@2002:4404:712c:0:1c12:146e:7472:e2ff] has quit [Ping timeout: 265 seconds] 20140416 14:02:46-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar] 20140416 14:12:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140416 14:15:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping] 20140416 14:20:48< AI0867> aquileia: http://ai.ai0867.net/tmp/rwops_debug.diff may give some useful output 20140416 14:21:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140416 14:28:50< AI0867> valgrind with default options didn't tell me anything =/ 20140416 14:34:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140416 14:34:10< aquileia> Can't do it right now, have to proof read sth. with a deadline 20140416 14:34:37< AI0867> okay 20140416 14:34:54< aquileia> I'll have time later today 20140416 14:37:22-!- Aishiko_laptop [~unknown@198.85.71.253] has joined #wesnoth-dev 20140416 14:45:05< mattsc> I wonder if I could write an AI (AIs) that could win all of HttT on easy … 20140416 14:49:58< Soliton> once upon a time that was a goal for AI development. 20140416 14:50:25< AI0867> it still is, mostly 20140416 14:50:25< mattsc> Soliton: yeah, I know I saw it somewhere on the wiki at some point. 20140416 14:50:50< mattsc> I do have an AI that has never lost the first scenario in all the test runs I have done. But I haven’t gone beyond that yet. 20140416 14:50:51< AI0867> Two Brothers on easy needs only minor tweaks, I think 20140416 14:52:26< mattsc> wesnoth -t The_Elves_Besieged :) 20140416 14:53:35< mattsc> AI0867, Soliton: so would the goal be to write one AI that can play through the whole campaign(s), or would it be okay to set up specialized behaviors for individual scenarios? 20140416 14:53:50< aquileia> mattsc: I think the only thing you need would be parsing objectives into ai aspects... the micro AIs are really advanced 20140416 14:54:41< aquileia> thatks to you 20140416 14:54:44< aquileia> *thanks 20140416 14:54:45-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140416 14:54:52< mattsc> aquileia: well, that’s what I am doing with HttT:The_Elves_Besieged. That uses the Protect Unit MAI. 20140416 14:55:54< mattsc> aquileia: thanks - but the MAIs are pretty easy to do. If I could get a decent MP AI going, I’d be much happier. :P 20140416 14:56:28< aquileia> And nontheless an MAI can play HttT1 20140416 14:56:38< aquileia> easy, but impressive 20140416 14:57:27< mattsc> Don’t get me wrong, I’m not saying that I am not happy with that. :) 20140416 14:58:16< mattsc> It’s just that Fred drives me crazy at times. And it makes me appreciate every time how good the default AI actually is as a general purpose AI. 20140416 14:59:52-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140416 15:00:58< sachith500|2> haha yeah 20140416 15:01:09< sachith500|2> I was playing isar's cross on ffa on multiplayer today 20140416 15:01:17< sachith500|2> made me realize it would be pretty hard 20140416 15:01:23< sachith500|2> for an ai to deal with that kind of thing 20140416 15:01:41< iceiceice> i mean, ffa is mostly about politics, no? 20140416 15:01:53< sachith500|2> yeah no politics here 20140416 15:01:57< sachith500|2> even then 20140416 15:02:05< sachith500|2> it becomes a mess of probability 20140416 15:02:11< sachith500|2> who attacks whom 20140416 15:03:02< sachith500|2> if we could teach an AI politics now that would be truly interesting haha 20140416 15:03:36< AI0867> mattsc: tailoring each scenario's "player AI" to the objectives and various other properties is fine 20140416 15:03:38< mattsc> FFA - Football Federation of America? 20140416 15:03:45< sachith500|2> free for all 20140416 15:03:46< sachith500|2> :P 20140416 15:03:48< mattsc> s/America/Australia 20140416 15:03:48< sachith500|2> no teams 20140416 15:04:06< sachith500|2> it get's really really messy 20140416 15:04:10< sachith500|2> *gets 20140416 15:05:07< iceiceice> idk i mean its more complicated because there is more moving parts, but at the same time its not actually possible to perform that much better the more you think about it 20140416 15:05:21< iceiceice> if you can convince the other players to attack someone other than you, then you win 20140416 15:05:23< iceiceice> otherwise, you lose 20140416 15:05:56< iceiceice> and you cant control them, so it just comes down to, what is the smallest amount i can recruit so that i am still not easy to conquer, but also dont seem threatening, and can bank otherwise 20140416 15:06:05< AI0867> aquileia: I think 10:10 might be a bit low of a limit. Do you think 1280:600 (32:15) sounds reasonable or not? 20140416 15:06:06< mattsc> AI0867: yeah, you pretty much have to. Having the AI figure out the best strategy on its own would be really hard. I might make that my next project. :) 20140416 15:06:26< sachith500|2> hmm true 20140416 15:07:23< aquileia> AI0867: I interpreted your code as x:10 being the limit that should be shown. I can change that of course 20140416 15:07:57< aquileia> but 16:9 is standard and everything above is unusual for a normal user 20140416 15:08:29< aquileia> So IMHO 32:15 isn't really a help for most people 20140416 15:08:50< AI0867> 16:10 is pretty common too 20140416 15:09:02< aquileia> and 16:10 is allowed as well 20140416 15:09:22< AI0867> and my intention with the >= 10 was just to filter out ridiculous cases where div is 1 or 2 or something like that 20140416 15:09:34< AI0867> true 20140416 15:09:40-!- Aishiko_laptop [~unknown@198.85.71.253] has quit [Ping timeout: 240 seconds] 20140416 15:10:01< AI0867> prime:otherprime 20140416 15:10:17< aquileia> oh, right, I'd be 8:5 20140416 15:10:25-!- irker078 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140416 15:10:25< irker078> wesnoth: aquileia wesnoth:master 9e34f5d0bc57 / src/preferences_display.cpp: Fix aspect ratio in resolution setting dialog http://git.io/U8AK6w 20140416 15:10:25< irker078> wesnoth: aquileia wesnoth:master e93dfa01a84f / src/ (preferences_display.cpp video.cpp): Fix bug #21915: Resolution selection dialog http://git.io/BPKx1g 20140416 15:10:26< irker078> wesnoth: Alexander van Gessel wesnoth:master 8cb1e4f9898e / src/ (preferences_display.cpp video.cpp): Merge pull request #151 from aquileia/clean_up http://git.io/OLkeZQ 20140416 15:11:25< AI0867> have I offered you commit access yet? 20140416 15:12:20< aquileia> no, but currently I'd prefer to learn more git before that... 20140416 15:12:23< AI0867> okay 20140416 15:13:37< aquileia> I still shudder when thinking about that one message that I nearly force pushed to master once because my remote was set wrongly 20140416 15:13:59< aquileia> Having no access can be an advantage 20140416 15:15:58< aquileia> AI0867: Could you cherry-pick 9e34f5d0bc & 066ae06083 to 1.12, please? 20140416 15:16:42-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 240 seconds] 20140416 15:26:22-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has joined #wesnoth-dev 20140416 15:29:25-!- bagzie [~bag@85-76-129-96-nat.elisa-mobile.fi] has quit [] 20140416 15:35:27-!- gfgtdf [~chatzilla@e177123157.adsl.alicedsl.de] has joined #wesnoth-dev 20140416 15:38:03-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has quit [] 20140416 15:38:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140416 15:41:11< irker078> wesnoth: aquileia wesnoth:1.12 fa3935a149d7 / src/preferences_display.cpp: Fix aspect ratio in resolution setting dialog http://git.io/7SS66Q 20140416 15:41:13< irker078> wesnoth: aquileia wesnoth:1.12 19bc318236dd / data/campaigns/tutorial/scenarios/1_Tutorial.cfg: Reapply a5cb1492c4 on 1_Tutorial.cfg http://git.io/L5j1MQ 20140416 15:43:02-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140416 15:46:14< aquileia> AI0867: thanks 20140416 15:46:32< aquileia> AI0867: here's your debug output: http://pastebin.com/8uJi4Qxp 20140416 15:54:36< aquileia> the eighth and last entry vastly differ 20140416 15:54:48-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev 20140416 15:55:19< aquileia> *entries 20140416 16:09:52-!- Kexoth [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140416 16:10:26-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 16:10:57-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140416 16:11:07-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 16:17:25-!- _8680_ [~8680@2002:4404:712c:0:9d5:b8bb:1a47:8bdd] has joined #wesnoth-dev 20140416 16:17:44-!- _8680_ is now known as Guest22192 20140416 16:19:53-!- sachith500 [~kvirc@112.134.149.88] has joined #wesnoth-dev 20140416 16:20:30-!- sachith500 [~kvirc@112.134.149.88] has quit [Read error: Connection reset by peer] 20140416 16:20:47-!- sachith500 [~kvirc@112.134.149.88] has joined #wesnoth-dev 20140416 16:21:04-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev 20140416 16:22:48-!- sachith500|2 [~kvirc@112.134.96.183] has quit [Ping timeout: 245 seconds] 20140416 16:22:56-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20140416 16:35:40-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 20140416 16:45:53< aquileia> AI0867: The list is shorter when the bug is produced by directly exiting wesnoth: http://pastebin.com/ZVWgW9Wm 20140416 16:47:14< irker078> wesnoth: mattsc wesnoth:master d4917d534e32 / data/ai/micro_ais/cas/ (ca_healer_initialize.lua ca_healer_may_attack.lua ca_healer_move.lua): Healer Support Micro AI: code cleanup http://git.io/MIsSZQ 20140416 16:47:16< irker078> wesnoth: mattsc wesnoth:master 8fa3a60e5681 / data/ai/micro_ais/cas/ca_protect_unit_move.lua: Protect Unit Micro AI: fix bug in goal selection http://git.io/L7_q6g 20140416 16:47:18< aquileia> Deleting most of core/music and the references to it doesn't seem to reduce the number of calls 20140416 16:47:18< irker078> wesnoth: mattsc wesnoth:master f6830897aaf8 / data/ai/micro_ais/cas/ (ca_protect_unit_attack.lua ca_protect_unit_finish.lua ca_protect_unit_move.lua): Protect Unit Micro AI: code cleanup http://git.io/DYfDcA 20140416 16:47:20< irker078> wesnoth: mattsc wesnoth:master 4a7292e99329 / data/ai/micro_ais/cas/ca_goto.lua: Goto Micro AI: code cleanup http://git.io/Xrtm2g 20140416 16:48:41< irker078> wesnoth: mattsc wesnoth:1.12 cce0dcba9de5 / data/ai/micro_ais/cas/ (ca_healer_initialize.lua ca_healer_may_attack.lua ca_healer_move.lua): Healer Support Micro AI: code cleanup http://git.io/19ZEYg 20140416 16:48:43< irker078> wesnoth: mattsc wesnoth:1.12 04bf7c56e08f / data/ai/micro_ais/cas/ca_protect_unit_move.lua: Protect Unit Micro AI: fix bug in goal selection http://git.io/P7KApw 20140416 16:48:45< irker078> wesnoth: mattsc wesnoth:1.12 3b8b923d7f58 / data/ai/micro_ais/cas/ (ca_protect_unit_attack.lua ca_protect_unit_finish.lua ca_protect_unit_move.lua): Protect Unit Micro AI: code cleanup http://git.io/snUR7w 20140416 16:48:47< irker078> wesnoth: mattsc wesnoth:1.12 9396f20e5925 / data/ai/micro_ais/cas/ca_goto.lua: Goto Micro AI: code cleanup http://git.io/JO7fTg 20140416 16:49:28-!- TC01 [~quassel@128.220.109.252] has quit [Ping timeout: 245 seconds] 20140416 16:49:34-!- TC01__ [~quassel@128.220.109.252] has joined #wesnoth-dev 20140416 16:52:01-!- sachith500 [~kvirc@112.134.149.88] has quit [Read error: Connection reset by peer] 20140416 16:52:18-!- sachith500 [~kvirc@112.134.149.88] has joined #wesnoth-dev 20140416 16:53:43< mattsc> Ivanovic: are you still planning on releasing 1.11.13 this weekend? I know you have a really busy travel schedule, but forgot the details. 20140416 16:53:54< Ivanovic> mattsc: might be 20140416 16:54:06< Ivanovic> i am back from travel right now and will be gone again next week thursday 20140416 16:54:38-!- bagzie [~bag@85-76-144-140-nat.elisa-mobile.fi] has joined #wesnoth-dev 20140416 16:54:50< mattsc> I see. Okay, sounds good, thanks. 20140416 16:55:54-!- sachith500 [~kvirc@112.134.149.88] has quit [Client Quit] 20140416 16:59:05-!- neXyon [~neXyon@178-191-148-131.adsl.highway.telekom.at] has quit [Quit: bye] 20140416 16:59:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140416 17:10:01< gfgtdf> iceiceice: i have a possible fix for 21866: https://github.com/gfgtdf/wesnoth-old/commit/8d4ef1dbce5bd88c678b8a6d6710bc6abba30a52 20140416 17:10:39< iceiceice> hmm 20140416 17:10:55< iceiceice> i'm not the person to ask about it but agree it looks like a good idea 20140416 17:12:18< gfgtdf> iceiceice: did you see what Ivanovic wrote above ? 20140416 17:12:32< iceiceice> yes 20140416 17:12:59< gfgtdf> iceiceice: if you want i can merge 121 into 12 now 20140416 17:13:54< iceiceice> ok, if you think its ready then go for it 20140416 17:14:34< iceiceice> the things i would like to finish are, get the ready blocker working, 20140416 17:14:43< iceiceice> and maybe merge this server replay thing 20140416 17:16:27< gfgtdf> iceiceice: are there still problems with non relode server replays ? 20140416 17:16:33< gfgtdf> reloaded* 20140416 17:16:52< iceiceice> yes, there are problems with all server replays 20140416 17:16:55< iceiceice> in master right now 20140416 17:17:27< gfgtdf> 20140416 06:32:27< iceiceice> thunderstruck, gfgtdf: I now have an experimental branch where at least vanilla 1v1 games can yield readable server replays: 20140416 17:18:08< iceiceice> oh you mean on my branch 20140416 17:18:29< iceiceice> well i havent tested it enough to know what the limits are 20140416 17:18:43< aquileia> AI0867: I played a little bit and replaced if (buffer_.unique) by if (rwops_->type == 5) 20140416 17:18:55< aquileia> no crashes 20140416 17:19:00< gfgtdf> but it's better then teh currentl server relays in any case i ssume ? 20140416 17:19:07< mattsc> gfgtdf: this is no comment at all on whether that fix up there would work, but underlying ids start at 1, not 0. 20140416 17:19:07< gfgtdf> assume* 20140416 17:19:22< aquileia> AI0867: and these are the calls where it made a difference: http://pastebin.com/cctYnanP 20140416 17:19:52< gfgtdf> mattsc: the level["next_underlying_unit_id"] = 0; was also there before my patch before 20140416 17:19:58< iceiceice> gfgtdf: before my branch, loading the replay in any manner will give a "mandatory wml child missing" error which i think was introduced SoC refactor, and then after that it will crash with an assert failure from your 121 code 20140416 17:20:20< aquileia> AI0867: line 4 and 6 were when I started / ended the tutorial, I think 20140416 17:20:30< mattsc> gfgtdf: oh, ok. Well, just saying that if you start a scenario, the first unit has under_lying id 1. 20140416 17:20:46< gfgtdf> mattsc: is there a special reason for that ? 20140416 17:20:46< aquileia> AI0867: just in case that helps 20140416 17:20:55< iceiceice> i fixed both of these things (first, by using a fallback if the wml child is missing, second by making the [start] on server side as you suggested), and now they seem to load as well as they did in 1.10 at least, although i dont know 20140416 17:21:26< mattsc> gfgtdf: No idea; in my knowledge base that’s an empirical finding, not an argument that is should be like that. :) 20140416 17:21:35< gfgtdf> i think "i dont know" is beter than "it never works" 20140416 17:21:45< iceiceice> gfgtdf, mattsc: maybe it works by "unit.id = ++game_state.underlying_id" or someting like this? 20140416 17:22:18< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/blob/master/src/unit_id.cpp#L45 20140416 17:22:19< iceiceice> obv the classes arent actually like that but you get the point 20140416 17:22:35< iceiceice> aha i was right :) 20140416 17:23:08< mattsc> gfgtdf, iceiceice: okay - just tell me to shut up next time I comment on anything C++ ;) 20140416 17:24:14< iceiceice> whoa github has fixed a "bug" of theirs now :) 20140416 17:24:24< iceiceice> it used to say on the wesnoth page "10,000+ commits" 20140416 17:24:33< iceiceice> now we have 56,417 commits 20140416 17:24:43< irker078> wesnoth: gfgtdf wesnoth:1.12 882d8271be11 / src/ (CMakeLists.txt SConscript random.cpp simple_rng.cpp): put simple_rng methods in own file. http://git.io/M89ccg 20140416 17:24:45< irker078> wesnoth: gfgtdf wesnoth:1.12 217a11691055 / src/ (8 files): add new rng http://git.io/eVQMxA 20140416 17:24:47< irker078> wesnoth: gfgtdf wesnoth:1.12 ad54d3b7f2c0 / src/ (SConscript replay_helper.cpp replay_helper.hpp): add replay_helper class http://git.io/6FR89Q 20140416 17:24:49< irker078> wesnoth: gfgtdf wesnoth:1.12 f16a8ecc206e / src/ (CMakeLists.txt SConscript config_assign.cpp config_assign.hpp): add config_of function http://git.io/EPLZCA 20140416 17:24:51< irker078> wesnoth: gfgtdf wesnoth:1.12 f003dab34041 / src/ (replay.cpp replay.hpp): add functions in replay http://git.io/Nur9uQ 20140416 17:24:53< irker078> wesnoth: gfgtdf wesnoth:1.12 4ea0582d2d10 / src/ (8 files): add synced_context class http://git.io/toKgQA 20140416 17:24:55< irker078> wesnoth: gfgtdf wesnoth:1.12 b576385ea5ac / src/playturn.cpp: give a better error message. http://git.io/W-cyKA 20140416 17:24:57< irker078> wesnoth: gfgtdf wesnoth:1.12 8b89c0112b76 / src/multiplayer_connect_engine.cpp: use rand() instead of get_random() for side shuffle http://git.io/BOxJPQ 20140416 17:24:59< irker078> wesnoth: gfgtdf wesnoth:1.12 a9ba84d4d1e1 / src/replay_controller.cpp: fixes wrong side during end turn events in replay http://git.io/QvQ95g 20140416 17:25:01< irker078> wesnoth: gfgtdf wesnoth:1.12 61fb13db0d17 / src/play_controller.cpp: fix a bug when players leave in mp. http://git.io/KMDMYA 20140416 17:25:03< irker078> wesnoth: gfgtdf wesnoth:1.12 b7b7a722275c / src/server/ (game.cpp game.hpp server.cpp): serverside code for the new rng. http://git.io/pCdqyw 20140416 17:25:05< irker078> wesnoth: gfgtdf wesnoth:1.12 5b047962464b / src/ (6 files in 3 dirs): use new synced_context: use new rng http://git.io/FhvSKA 20140416 17:25:07< irker078> wesnoth: gfgtdf wesnoth:1.12 f6fbde5790be / src/ (playmp_controller.cpp playturn.cpp replay.cpp): use synced_context: fix mp observers http://git.io/akKfhw 20140416 17:25:09< irker078> wesnoth: gfgtdf wesnoth:1.12 b1b8b0d59150 / src/ (game_events/action_wml.cpp persist_var.cpp replay.cpp replay.hpp): use synced_context: change get_user_input http://git.io/vWAGiw 20140416 17:25:11< irker078> wesnoth: gfgtdf wesnoth:1.12 aabb5b650c68 / src/ (5 files): use synced context: sync the turn ... events and prestart events. http://git.io/Yq2-Pw 20140416 17:25:13< irker078> wesnoth: gfgtdf wesnoth:1.12 aea7a9dac1ce / src/ (11 files in 4 dirs): use synced_context http://git.io/WuZhcw 20140416 17:25:15< irker078> wesnoth: gfgtdf wesnoth:1.12 839d6e384f68 / src/ (10 files in 3 dirs): use synced_context in moves http://git.io/Oe5Ybg 20140416 17:25:17< irker078> wesnoth: gfgtdf wesnoth:1.12 ed49b172e746 / src/ (8 files in 4 dirs): use synced_context in recruits/recalls http://git.io/vvH9SQ 20140416 17:25:19< irker078> wesnoth: gfgtdf wesnoth:1.12 83b107f2b280 / src/ (replay.cpp replay.hpp): add third argument to recorder.user_input http://git.io/lWLIig 20140416 17:25:21< irker078> wesnoth: gfgtdf wesnoth:1.12 dd653ef838e1 / src/replay.cpp: remove unused replay.cpp::type_by_index http://git.io/1H_nQA 20140416 17:25:23< irker078> wesnoth: gfgtdf wesnoth:1.12 ad18df295f3d / src/ (8 files in 4 dirs): use synced_context in undo and rest http://git.io/RiwCdw 20140416 17:25:25< irker078> wesnoth: gfgtdf wesnoth:1.12 fe03a227392b / src/synced_context.cpp: add from_side check for require_random http://git.io/-MxnNQ 20140416 17:25:27< irker078> wesnoth: gfgtdf wesnoth:1.12 a56ac608ed8a / src/scripting/lua.cpp: fixup forgotten user_choice in lua.cpp http://git.io/7ST5Tg 20140416 17:25:29< irker078> wesnoth: gfgtdf wesnoth:1.12 192bb9ea01c5 / src/ (16 files in 5 dirs): removed unused rng code. http://git.io/9EZpCA 20140416 17:25:31< irker078> wesnoth: gfgtdf wesnoth:1.12 a1ebe0228737 / src/ (replay.cpp replay_controller.cpp): stop replay when we have reached the end. http://git.io/X7lbBw 20140416 17:25:33< irker078> wesnoth: gfgtdf wesnoth:1.12 53065ba35092 / src/ (actions/attack.cpp actions/attack.hpp ai/actions.cpp synced_commands.cpp): bring back unit_advancements_aspect http://git.io/N-3hCA 20140416 17:25:35< irker078> wesnoth: gfgtdf wesnoth:1.12 1f9ea7539bd4 / src/ (mouse_events.cpp mouse_events.hpp): removed unused code http://git.io/V5TI5A 20140416 17:25:37< irker078> wesnoth: gfgtdf wesnoth:1.12 dad56a4422d7 / src/actions/move.cpp: added a check for unit's destination in moves http://git.io/nGaiLQ 20140416 17:25:39< irker078> wesnoth: gfgtdf wesnoth:1.12 c71e11923864 / src/replay.cpp: correct the value of pos_ in replays. http://git.io/vu1smQ 20140416 17:25:41< irker078> wesnoth: gfgtdf wesnoth:1.12 b1d8491aa97b / src/ (replay_controller.cpp server/game.cpp synced_context.hpp): rearrange comments and debuglogs http://git.io/aii77A 20140416 17:25:43< irker078> wesnoth: gfgtdf wesnoth:1.12 0d34222c7942 / src/ (5 files in 2 dirs): add skip_ally_sighted to replay http://git.io/t0ZCYw 20140416 17:25:45< irker078> wesnoth: gfgtdf wesnoth:1.12 d61a2e68ed19 / src/replay.hpp: add comment in replay.hpp http://git.io/36x7_w 20140416 17:25:47< irker078> wesnoth: gfgtdf wesnoth:1.12 62af5ac0c7cf / src/ (replay.cpp replay.hpp): removed unused code http://git.io/R2JsuQ 20140416 17:25:49< irker078> wesnoth: gfgtdf wesnoth:1.12 5cb88e8976e3 / src/ (replay.cpp replay.hpp): change get_user_choice http://git.io/Ua8Q8g 20140416 17:25:51< irker078> wesnoth: gfgtdf wesnoth:1.12 99c64f078aa7 / src/replay.cpp: removed unused replay_source_manager http://git.io/KYj5Zw 20140416 17:25:53< irker078> wesnoth: gfgtdf wesnoth:1.12 9176d6a1c07a / src/ (replay.cpp synced_context.cpp synced_context.hpp): don't send data if it's not needed http://git.io/hagvwQ 20140416 17:25:55< irker078> wesnoth: gfgtdf wesnoth:1.12 28292ca68a61 / src/replay.cpp: removed outcommented code in replay.cpp + add comments http://git.io/T2RvsQ 20140416 17:25:57< irker078> wesnoth: gfgtdf wesnoth:1.12 8a57de6fc4ce / src/ (6 files in 2 dirs): removed dialogs::advance_unit http://git.io/z_7k_A 20140416 17:25:59< irker078> wesnoth: gfgtdf wesnoth:1.12 7b38e8fdb106 / src/ (playmp_controller.cpp playturn.cpp playturn.hpp): fix currently active side quits during action http://git.io/TZjZ1A 20140416 17:26:01< irker078> wesnoth: gfgtdf wesnoth:1.12 11b61cea63d2 / src/playturn.cpp: fix skip_replay part1 http://git.io/LaeW3Q 20140416 17:26:03< irker078> wesnoth: gfgtdf wesnoth:1.12 57c87aefcacb / src/playmp_controller.cpp: fix skip_replay part2 http://git.io/cloqaQ 20140416 17:26:05< irker078> wesnoth: gfgtdf wesnoth:1.12 b131ece4086d / src/ (replay.cpp replay.hpp synced_context.cpp): removed unused 'do_until' argument http://git.io/JOxTVQ 20140416 17:26:07< irker078> wesnoth: gfgtdf wesnoth:1.12 3dadc9ba99c8 / src/ (playmp_controller.cpp playturn.cpp playturn.hpp): remove unused argument http://git.io/x3p29w 20140416 17:26:09< irker078> wesnoth: gfgtdf wesnoth:1.12 925c5a48040a / src/ (6 files): give do_replays return a better name http://git.io/CGFAyQ 20140416 17:26:11< irker078> wesnoth: gfgtdf wesnoth:1.12 9d2df2cb4398 / src/ (9 files): fix bug chat during action http://git.io/D6HomA 20140416 17:26:13< irker078> wesnoth: gfgtdf wesnoth:1.12 a423e910f965 / src/ (synced_context.cpp synced_context.hpp): use events::command_disabler in synced context http://git.io/FwUTOA 20140416 17:26:15< irker078> wesnoth: gfgtdf wesnoth:1.12 fbfdc37205c2 / src/server/game.cpp: temporarily disable check for backwards compatibility http://git.io/5fbTLA 20140416 17:26:17< irker078> wesnoth: gfgtdf wesnoth:1.12 643f752e5c2d / src/replay.cpp: disable get_user_choice during prestart events http://git.io/CpS4Jg 20140416 17:26:19< irker078> wesnoth: gfgtdf wesnoth:1.12 385b03a9418c / src/ (persist_var.cpp replay.cpp replay.hpp scripting/lua.cpp): allow user_choice in prestart for invisible choices http://git.io/6XGiGA 20140416 17:26:21< irker078> wesnoth: gfgtdf wesnoth:1.12 246b9ec33523 / src/replay_controller.cpp: fix 21905 http://git.io/x80SCA 20140416 17:26:23< irker078> wesnoth: gfgtdf wesnoth:1.12 cf9bec2fb770 / src/replay.cpp: use const config& for value check http://git.io/rowoQA 20140416 17:26:25< irker078> wesnoth: gfgtdf wesnoth:1.12 00d317264b0e / src/replay_controller.cpp: disable RESET_REPLAY during actions http://git.io/q5ADFg 20140416 17:26:27< irker078> wesnoth: gfgtdf wesnoth:1.12 e35ec1b71c02 / src/actions/create.cpp: enable undo recruits/recalls if no rng was used http://git.io/iLee8A 20140416 17:26:29< irker078> wesnoth: gfgtdf wesnoth:1.12 bd73f46cdc23 / src/gamestatus.hpp: removes unused variable http://git.io/tTZthw 20140416 17:26:31< irker078> wesnoth: gfgtdf wesnoth:1.12 b3c6922c4ad2 / src/ (actions/create.cpp actions/move.cpp synced_context.cpp synced_context.hpp): disallow undo when action was sended http://git.io/a66BiQ 20140416 17:26:33< irker078> wesnoth: gfgtdf wesnoth:1.12 6e9c647360a2 / src/synced_context.hpp: revmoved unused code http://git.io/ONVRyg 20140416 17:26:35< irker078> wesnoth: gfgtdf wesnoth:1.12 028c9634ea07 / src/ (playmp_controller.cpp playturn.cpp playturn.hpp): fix host reassignes side during choice http://git.io/0KRKTw 20140416 17:26:37< irker078> wesnoth: gfgtdf wesnoth:1.12 9cbee4571424 / src/ (ai/actions.cpp synced_context.cpp synced_context.hpp): remove the 'only_attacks' random mode http://git.io/Ww2Aww 20140416 17:26:39< irker078> wesnoth: gfgtdf wesnoth:1.12 d9b915dbdb13 / src/synced_context.hpp: remove outdated comments. http://git.io/xGq6tA 20140416 17:26:41< irker078> wesnoth: gfgtdf wesnoth:1.12 913532578263 / src/synced_context.cpp: don't call user_interace during screenlock http://git.io/3rxHgw 20140416 17:26:43< irker078> wesnoth: gfgtdf wesnoth:1.12 a15a92538e28 / src/actions/create.cpp: don't use sycned checkup for wml things http://git.io/zlnohg 20140416 17:26:45< irker078> wesnoth: gfgtdf wesnoth:1.12 65f1d5dff888 / src/actions/create.cpp: remove a checksum http://git.io/QcWk5A 20140416 17:26:47< irker078> wesnoth: gfgtdf wesnoth:1.12 7ee5a2e074db / src/ (mp_game_utils.cpp playcampaign.cpp): fix 21866 http://git.io/XTGr8w 20140416 17:26:49< gfgtdf> iceiceice: i pushed the rng thing to 1.12 :) 20140416 17:27:04< iceiceice> ok 20140416 17:27:12< iceiceice> so now i can push the server tweaks? 20140416 17:27:26< mattsc> gfgtdf: this introduces new files, doesn’t it? 20140416 17:27:34< gfgtdf> mattsc: yes 20140416 17:27:36< aquileia> gfgtdf: You added exactly the same files as in master, right? 20140416 17:27:47< mattsc> okay; I’ll update the Xcode project ... 20140416 17:27:49< gfgtdf> aquileia: yes 20140416 17:29:26< aquileia> mattsc: it should be able to cherry-pick the XCode update 20140416 17:30:24< mattsc> aquileia: no, that’s a bad idea in this case. The Xcode projects are very different between 1.12 and 1.13 at the moment, and there are some “magical numbers” in the project files that don’t always just copy over. 20140416 17:30:36< mattsc> It’s easy enough to just add those files manually. 20140416 17:30:36< aquileia> ah, ok 20140416 17:31:10< mattsc> The reason for the difference is that I upgraded all the libs in 1.13, but not 1.12. 20140416 17:31:12< aquileia> In the VC project the files are just updated manually in order not to change these IDs 20140416 17:31:23-!- Coffee_irc [~david@ppp118-210-77-53.lns20.adl2.internode.on.net] has quit [Ping timeout: 252 seconds] 20140416 17:31:37< iceiceice> ok, i will cherry-pick the server tweak stuff in an hour or so i think 20140416 17:31:40< mattsc> We’ve tried that in Xcode, it does not seem to work (or we did it wrong) 20140416 17:32:11-!- ancestral [~ancestral@17.114.44.172] has joined #wesnoth-dev 20140416 17:32:24-!- Bodhi-Baum [~Bodhi@dslb-084-063-022-095.pools.arcor-ip.net] has joined #wesnoth-dev 20140416 17:32:41< Kevin_Xi> I'm just finish updated the codeblocks project file 20140416 17:33:14< iceiceice> gfgtdf: do you know what kinds of non-server replays work right now? 20140416 17:33:18< iceiceice> i guess that you did some testing recently 20140416 17:34:02< gfgtdf> iceiceice: i think all non server replays shoudl work. (assuming teh there is no wml that casues OOS) 20140416 17:34:05-!- ancestral [~ancestral@17.114.44.172] has quit [Client Quit] 20140416 17:34:12< gfgtdf> there* 20140416 17:34:25-!- ancestral [~ancestral@17.114.44.172] has joined #wesnoth-dev 20140416 17:34:29< iceiceice> wow how did you fix that? 20140416 17:34:41< gfgtdf> did they ever not work ? 20140416 17:34:44< iceiceice> afaik there have been errors with replays saved of reloaded games forever 20140416 17:34:52< iceiceice> whether server generated or not 20140416 17:34:55< gfgtdf> mp game soyu mean ? 20140416 17:34:58< gfgtdf> you* 20140416 17:35:07< iceiceice> yes 20140416 17:35:24< gfgtdf> hm yes i thought you mean sp games 20140416 17:36:19< gfgtdf> i didnt test mp reloaded replay games, i can text 20140416 17:36:22< iceiceice> do reloads of sp games work? 20140416 17:36:41< iceiceice> one of the grand final tgt replay games got corrupted this year: 20140416 17:36:42< iceiceice> http://forums.wesnoth.org/viewtopic.php?f=15&t=39175&start=315 20140416 17:39:17< iceiceice> wait you seriously didnt test any mp reloaded games after rewriting replay.cpp :O 20140416 17:39:23< iceiceice> and just pushed to 1.12?? 20140416 17:39:40< aquileia> gfgtdf: Would you cherry-pick 45f52737c89ee and 4146d428b8ea from master to 1.12, please? There should be no conflicts 20140416 17:39:59< aquileia> They are the VC updates for your files 20140416 17:40:38< gfgtdf> iceiceice: i did test reloaded mp games i just doidnt try to replay them, i not tried replaysing realoded an then saved mp game and it seems to work 20140416 17:40:58< gfgtdf> iceiceice: sure do reloads of spgames work 20140416 17:40:59< iceiceice> oh ok 20140416 17:41:07< gfgtdf> i now* 20140416 17:41:22< gfgtdf> s/i not tried/i now tried 20140416 17:41:25< gfgtdf> iceiceice: ^ 20140416 17:41:54< iceiceice> well that's good 20140416 17:42:02< iceiceice> maybe should port whatever is happening in sp to the mp side of things then 20140416 17:42:08< gfgtdf> aquileia: error: Commit 45f52737c89eef66099f2d0c1a9aa4ab22caef55 is a merge but no -m option was given. 20140416 17:44:54< gfgtdf> shall i try again with -m ? 20140416 17:45:38< aquileia> you need to specify -m and a number 20140416 17:45:58< aquileia> I think it's git cherry-pick -m 1 45f52737c89ee 20140416 17:46:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140416 17:46:09< iceiceice> dont cherry-pick the merege? 20140416 17:46:14< aquileia> but I'd rather ask 20140416 17:46:15< iceiceice> just cherry-pick the actual changes 20140416 17:47:50< aquileia> iceiceice: thanks 20140416 17:48:02< aquileia> gfgtdf: The correct commit is edfe6e4a744afe , then 20140416 17:48:11< irker078> wesnoth: aquileia wesnoth:1.12 835197b94aa0 / / (5 files in 3 dirs): Update projectfiles and corresponding readme http://git.io/yBk0AQ 20140416 17:48:13< irker078> wesnoth: aquileia wesnoth:1.12 1bef0263d1eb / projectfiles/VC9/wesnoth.vcproj: Update VC project for 847067dac7 http://git.io/3fXXHg 20140416 17:48:53< aquileia> gfgtdf: thanks 20140416 17:49:12< aquileia> now VC is up to date 20140416 17:50:23-!- Kevin_Xi [~kevin@223.72.182.158] has quit [Quit: Leaving.] 20140416 17:50:28< aquileia> iceiceice: The reason I first had given the merge commit was that I couldn't find the real commit as it was long before that 20140416 17:51:24-!- ancestral [~ancestral@17.114.44.172] has quit [Quit: ancestral] 20140416 17:52:00-!- ancestral [~ancestral@17.114.44.172] has joined #wesnoth-dev 20140416 17:55:15< iceiceice> ok now to make changelog entries for 1.12 :O 20140416 17:57:09< irker078> wesnoth: mattsc wesnoth:1.12 7e9e46729f2f / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project http://git.io/VQp_uA 20140416 17:58:39< irker078> wesnoth: Chris Beck wesnoth:1.12 d43c2606c501 / src/ (replay.cpp server/game.cpp server/server.cpp): make server level_ reflect true start of game position http://git.io/lrgdrw 20140416 17:58:41< irker078> wesnoth: Chris Beck wesnoth:1.12 5e046acb2541 / src/ (7 files in 2 dirs): move controller tweaks to server http://git.io/glAGOA 20140416 17:58:43< irker078> wesnoth: Chris Beck wesnoth:1.12 330a447e815d / changelog: update changelog http://git.io/Ws6ebw 20140416 17:58:46< irker078> wesnoth: Chris Beck wesnoth:1.12 ae351052a5a9 / / (6 files in 4 dirs): Merge branch '1.12' of https://github.com/wesnoth/wesnoth into 1.12 http://git.io/Aifhwg 20140416 18:00:28< irker078> wesnoth: Chris Beck wesnoth:1.12 6b8e303ee26c / src/server/game.cpp: fixup server controller tweaks http://git.io/LcXPNQ 20140416 18:00:47-!- ancestral [~ancestral@17.114.44.172] has quit [Quit: ancestral] 20140416 18:06:56< irker078> wesnoth: gfgtdf wesnoth:1.12 d008da92e1ce / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/EN4Hvw 20140416 18:07:40< iceiceice> gfgtdf: did you test that your change does fix 21866? 20140416 18:08:37-!- Guest22192 [~8680@2002:4404:712c:0:9d5:b8bb:1a47:8bdd] has quit [Ping timeout: 252 seconds] 20140416 18:09:18< irker078> wesnoth: gfgtdf wesnoth:1.12 4d4162c51a8a / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/wHltBA 20140416 18:09:23< aquileia> Could someone mark https://gna.org/bugs/?21915 as fixed or tell me how to do that? 20140416 18:09:42-!- _8680_ [~8680@2002:4404:712c:0:f855:adb2:c730:ff47] has joined #wesnoth-dev 20140416 18:09:55< irker078> wesnoth: Kevin_Xi wesnoth:master 09b0aad1f837 / projectfiles/ (3 files in 2 dirs): Add missed files to and remove obsolete file from CodeBlocks-SCons and CodeBlock http://git.io/63C0Jw 20140416 18:09:57< irker078> wesnoth: Charles Dang wesnoth:master d0a25737a5a9 / projectfiles/ (3 files in 2 dirs): Merge pull request #152 from Kevin-Xi/update-cb-proj http://git.io/XuW3wQ 20140416 18:10:02-!- _8680_ is now known as Guest87885 20140416 18:10:06< gfgtdf> iceiceice: i only teste dit for local mp games 20140416 18:10:56< iceiceice> what about the case the OP reported? 20140416 18:11:31< aquileia> vultraz: pretty much everything from PR 152 applies to 1.12 as well... 20140416 18:11:53< gfgtdf> iceiceice: yes i tested this case in local mp 20140416 18:12:01< happygrue> aquileia: done, marked as "fixed", should that be "invalid"? 20140416 18:12:04< iceiceice> ok good 20140416 18:12:22< iceiceice> hmm so what is the list of blockers now? 20140416 18:12:36< aquileia> happygrue: I reported it yesterday and fixed it today 20140416 18:12:49< happygrue> okay, fixed is fine 20140416 18:13:05< happygrue> I closed it too by mistake, but I guess I'll just leave that. 20140416 18:13:26< aquileia> what's the problem with closed? 20140416 18:14:04< iceiceice> i guess we aren't supposed to close them, to make it easy to find them if they become an issue again in next release candidate or smth? 20140416 18:14:12< happygrue> IIRC shadowm or Ivanovic usually like to go through and close them all together 20140416 18:14:25< vultraz> aquileia: not sure how to cherry pick it back (I don't have a clone yet atm anyway) 20140416 18:15:56< iceiceice> im on 1.12 right now, do you want me to do it? 20140416 18:18:13< iceiceice> bbl 20140416 18:18:15-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving] 20140416 18:18:49< aquileia> iceiceice: I'd like to check if it applies completely before, if you don't mind 20140416 18:19:12< aquileia> But it'd be great if you could do the cherry-pick after that 20140416 18:21:58< mattsc> gfgtdf: fyi, I just tried to replay one of my SotBE games (saved with 1.11.8+dev) and it works with 1.11.12, but not with 1.11.12+dev that I just compiled. 20140416 18:22:41< gfgtdf> mattsc: https://github.com/wesnoth/wesnoth/commit/d008da92e1cecf9eb4ec4eb4449e721e3336badd 20140416 18:23:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140416 18:23:52< mattsc> gfgtdf: ah … 20140416 18:24:14-!- bagzie [~bag@85-76-144-140-nat.elisa-mobile.fi] has quit [] 20140416 18:26:48< aquileia> We have a little issue... CB uses backslashes, CB-scons uses slashes 20140416 18:27:02< aquileia> I mean the project files 20140416 18:27:20< aquileia> I don't think there is any reason for that 20140416 18:29:26< aquileia> other that that, src\unit_animation.hpp, src\wesconfig.h, src/gui/auxiliary/widget_definition/tooltip.hpp, src/gui/auxiliary/widget_definition/tree_view.cpp are only in one of these 20140416 18:30:59-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20140416 18:34:52< aquileia> shadowm, happygrue: Is there a reason to use "\" in CB? 20140416 18:38:51-!- TC01__ is now known as TC01 20140416 18:40:13< happygrue> aquileia: IIRC it doesn't matter, I think it parses either way 20140416 18:40:47< happygrue> if you copy paste some of the lines from the walkthrough I think you'll get a mix 20140416 18:41:59< aquileia> Someone could hypothetically want to use CB on Linux, and then he'd need "/" I think 20140416 18:42:23< aquileia> The question is... is it worth changing? 20140416 18:43:16< happygrue> ah, maybe so. I'm not sure. 20140416 18:44:08< aquileia> Then I'll leave it as is and only add the differing files 20140416 18:48:28-!- Bodhi-Baum [~Bodhi@dslb-084-063-022-095.pools.arcor-ip.net] has quit [Ping timeout: 240 seconds] 20140416 18:52:13< irker078> wesnoth: Nils Kneuper wesnoth:1.12 11233790cd34 / changelog players_changelog po/wesnoth-ai/cs.po po/wesnoth/cs.po: updated Czech translation http://git.io/SwyzXA 20140416 18:52:15< irker078> wesnoth: Nils Kneuper wesnoth:1.12 9a5242b06ca5 / / (5 files in 4 dirs): updated French translation http://git.io/mSTpiA 20140416 18:52:17< irker078> wesnoth: Nils Kneuper wesnoth:1.12 278c2b24cd44 / po/wesnoth-thot/sk.po: updated Slovak translation http://git.io/wu4F1w 20140416 18:52:19< irker078> wesnoth: Nils Kneuper wesnoth:master d7531af29e78 / changelog players_changelog po/wesnoth-ai/cs.po po/wesnoth/cs.po: updated Czech translation http://git.io/S1vjhw 20140416 18:52:21< irker078> wesnoth: Nils Kneuper wesnoth:master 49a5b55010ec / / (5 files in 4 dirs): updated French translation http://git.io/rwVnmg 20140416 18:52:23< irker078> wesnoth: Nils Kneuper wesnoth:master a0ae8255b22d / po/wesnoth-thot/sk.po: updated Slovak translation http://git.io/H18dMg 20140416 18:59:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140416 19:02:25-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20140416 19:03:24-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has joined #wesnoth-dev 20140416 19:04:51< iceiceice> ok, here are the things currently listed as blcokers which have no status on gna: 20140416 19:05:03< iceiceice> wesbot: bug #21491 20140416 19:05:03< wesbot> Bug #21491 Assigned to: Fabian Müller Status: None Priority: 5 - Normal 20140416 19:05:06< wesbot> Summary: Unit drag-and-drop functionality lost (regression) 20140416 19:05:09< wesbot> Original submission: The unit drag-and-drop functionality for moving and attac 20140416 19:05:12< wesbot> king was lost in version 1.11.8 as the result of a regression related to the int 20140416 19:05:15< wesbot> URL: http://gna.org/bugs/?21491 20140416 19:05:21< iceiceice> wesbot: bug #21093 20140416 19:05:21< wesbot> Bug #21093 Assigned to: Jody Northup Status: None Priority: 5 - Normal 20140416 19:05:24< wesbot> Summary: Bank teller crashes next load of test scenario 20140416 19:05:27< wesbot> Original submission: I ran the test scenario (wesnoth -t) and stopped by the " 20140416 19:05:30< wesbot> Bank Teller" hex. The following was stored in persist/demo.cfg:[sub] [name] 20140416 19:05:33< wesbot> URL: http://gna.org/bugs/?21093 20140416 19:05:39< iceiceice> wesbot: bug #21916 20140416 19:05:39< wesbot> Bug #21916 Assigned to: None Status: None Priority: 6 20140416 19:05:39< wesbot> Summary: Game is ready blocked at inappropriate times 20140416 19:05:39< wesbot> Original submission: Originally reported by gfgtdf.This is a secondary issue 20140416 19:05:42< wesbot> caused (apparently) by the fix to 21808.See PR 148 ( https://github.com/wes 20140416 19:05:45< wesbot> URL: http://gna.org/bugs/?21916 20140416 19:05:52< iceiceice> wesbot: bug #21903 20140416 19:05:53< wesbot> Bug #21903 Assigned to: Andrius Silinskas Status: None Priority: 5 - Normal 20140416 19:05:56< wesbot> Summary: Scenario transitions in networked MP don't work unless host transitions first 20140416 19:05:59< wesbot> Original submission: When a scenario ends and goes to linger mode before trans 20140416 19:06:02< wesbot> itioning to the next scenario, players may linger as long as they like until the 20140416 19:06:05< wesbot> URL: http://gna.org/bugs/?21903 20140416 19:06:07< wesbot> Attached file (1st): http://gna.org/bugs/download.php?file_id=20504 20140416 19:06:27< iceiceice> gfgtdf: i guess you fixed 21866? 20140416 19:07:00< gfgtdf> iceiceice: i think yes 20140416 19:07:06< iceiceice> also: bug #20193 20140416 19:07:11< iceiceice> wesbot: bug #20193 20140416 19:07:11< wesbot> Bug #20193 Assigned to: Ignacio R. Morelle Status: None Priority: 5 - Normal 20140416 19:07:15< wesbot> Summary: wesnoth does not start fullscreen with wrong resolution set 20140416 19:07:17< wesbot> Original submission: Steps to reproduce:1. Set the xresolution and yresoluti 20140416 19:07:20< wesbot> on to some arbitrary numbers, f.ex. 1920x1080.2. Let me have a 1280x1024 scre 20140416 19:07:23< wesbot> URL: http://gna.org/bugs/?20193 20140416 19:07:26< wesbot> Attached file (1st): http://gna.org/bugs/download.php?file_id=16599 20140416 19:20:46< iceiceice> hmm i dont understand why git tells me this: 20140416 19:20:47< iceiceice> # On branch 1.12 20140416 19:20:47< iceiceice> # Your branch is ahead of 'upstream/1.12' by 5 commits. 20140416 19:20:47< iceiceice> # (use "git push" to publish your local commits) 20140416 19:21:17-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140416 19:21:26< iceiceice> after pulling to local, and pushing local to fork, they look identical: 20140416 19:21:27< iceiceice> https://github.com/wesnoth/wesnoth/commits/1.12 20140416 19:21:34< iceiceice> https://github.com/cbeck88/wesnoth/commits/1.12 20140416 19:21:35-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 19:24:25< iceiceice> oh i guess i just needed to fetch 20140416 19:27:00-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 19:29:03-!- Kexoth [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140416 19:29:09-!- kex_ [~kex@89.205.75.19] has joined #wesnoth-dev 20140416 19:29:51< aquileia> iceiceice: I think the differences between 1.12 and master are a little too much to cherry-pick and revert... 20140416 19:30:25-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds] 20140416 19:30:27< aquileia> I'm preparing an update for 1.12 20140416 19:30:34< iceiceice> ok 20140416 19:39:55< aquileia> the src\tools files shouldn't be compiled, right? 20140416 19:40:11< aquileia> or at least only a small subset 20140416 19:40:29-!- cib_ [~cib@p5DD23F40.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140416 19:41:40< aquileia> and wesmage as well... 20140416 19:51:47-!- bagzie [~bag@85-76-140-172-nat.elisa-mobile.fi] has joined #wesnoth-dev 20140416 20:00:47-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev 20140416 20:01:59-!- Twooey [~Twooey@pool-108-16-205-233.phlapa.fios.verizon.net] has joined #wesnoth-dev 20140416 20:03:00-!- cib_ [~cib@p5DD23F40.dip0.t-ipconnect.de] has quit [Quit: Leaving] 20140416 20:04:41-!- Coffee_irc [~david@ppp118-210-40-39.lns20.adl2.internode.on.net] has joined #wesnoth-dev 20140416 20:05:44< aquileia> iceiceice: I pushed some fixes to https://github.com/aquileia/wesnoth/tree/code_blocks 20140416 20:06:57< aquileia> 093c49662fc68f and 5a21d5d8c8a6e are for master, the final state is for 1.12 20140416 20:08:03-!- kex_ [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140416 20:09:39< iceiceice> do you want to merge now? 20140416 20:09:47< iceiceice> or are you still working on it? 20140416 20:09:56< aquileia> I'm done with it 20140416 20:11:25< aquileia> I guess there is no chance to apply all relevant changes on 1.12, so I'd say the best way is to copy the file, change branches and overwrite it with the version from code_blocks 20140416 20:11:48< aquileia> for master there are only two commits to cherry-pick 20140416 20:12:05< iceiceice> ok wait i'm confused 20140416 20:12:12< iceiceice> this branch is based off of master, right? 20140416 20:12:17< iceiceice> or 1.12 20140416 20:12:31< iceiceice> and the idea is i should merge to 1.12, then cherry-pick the first two to master? 20140416 20:12:46< aquileia> It is based on master, but only two of the three commits are to be merged 20140416 20:13:04< aquileia> iceiceice: If you could do it as you described, that would be perfect 20140416 20:13:14< Coffee_irc> hi 20140416 20:13:15< aquileia> But I think it wont apply cleanly 20140416 20:13:20< iceiceice> ok 20140416 20:13:45< Coffee_irc> do you guys mind if I push a minor change to wesnoth master or should I wait a couple of minutes? 20140416 20:13:48< iceiceice> if it doesnt work, then maybe you can make a different branch to merge to master? i really dont want to try to do this stuff by hand, i would have no idea what i'm doing 20140416 20:13:57< iceiceice> Coffee: go right ahead 20140416 20:14:00< Twooey> Are there any (very)beginner friendly bug's I see if I could figure out. The bug's I've looked at are well beyond me. 20140416 20:14:24< Twooey> I'm just learning c++ 20140416 20:15:31< aquileia> Twooey: http://wiki.wesnoth.org/EasyCoding 20140416 20:15:33< iceiceice> Twooey: there's a whole bunch of new tasks on the EasyCoding page 20140416 20:15:40< iceiceice> hehe aquileia beat me to it :) 20140416 20:15:43< irker078> wesnoth: David Mikos wesnoth:master 858286fad94d / / (3 files in 2 dirs): Fix bug #21914: allow drake walking corpse variation to move on unwalkable http://git.io/Gr9O3w 20140416 20:15:49< iceiceice> if you really want to fix bugs and not just do random tasks... 20140416 20:15:57< iceiceice> i guess the easiest bugs right now mgiht be interface related? 20140416 20:16:01< iceiceice> like some hotkeys not working? 20140416 20:16:32< Coffee_irc> Twooey: you could look for bugs like the one I just pushed then :) 20140416 20:17:07< Twooey> I have been looking through the gnu buglist 20140416 20:17:29< Coffee_irc> Twooey: I find that I am more comfortable with animation code bebcause I have worked with animation coding in the past on other things 20140416 20:18:04< Coffee_irc> Twooey: if you have worked with GUIs before, or have aprticular area you are interested in it might be easier to learn that aspect of wesnoth 20140416 20:18:12< Coffee_irc> *particular 20140416 20:18:40< Twooey> The most advanced thing I've done so far is conway's game of life. I used sfml for a display with some help from c++-basic. 20140416 20:18:59< Coffee_irc> sorry about my misspellings -- it's early in the morning here and I am on my first coffee for the day ;) 20140416 20:19:45-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!] 20140416 20:21:14< Coffee_irc> Twooey: there's the GUI code, animation engine, WML engine, lua interface, AI, documentation, planning mode, and networking as areas that are quite different from each other 20140416 20:21:39< Coffee_irc> each one has easy to fix things, just that they might be hard to find if that makes sense 20140416 20:21:45< Twooey> Here is my copy of conways game of life. https://github.com/kb3pev/GOL/blob/master/gol.cpp and here is a project euler problem that I did differently from what I learned. https://github.com/kb3pev/Project.Euler/blob/master/Problem11/Problem11.cpp 20140416 20:22:10< Twooey> I got really chewed out on conways due to my use of c arrays. :P 20140416 20:24:04< irker078> wesnoth: Chris Beck wesnoth:1.12 b2d7814670c1 / src/savegame.cpp: fix mandatory child missing WML error http://git.io/yR6hlg 20140416 20:24:06< irker078> wesnoth: Chris Beck wesnoth:1.12 468524c792ba / src/server/game.cpp: add [start] tag to server replays as needed by gfgtdf http://git.io/7fLEiQ 20140416 20:24:08< irker078> wesnoth: Chris Beck wesnoth:1.12 c7eccfbe8661 / changelog: update changelog http://git.io/rabz9Q 20140416 20:24:49< aquileia> iceiceice: I'm preparing a second branch 20140416 20:24:59< iceiceice> ok 20140416 20:25:27< iceiceice> wow ccache is really the greatest, thank you so much AI :) 20140416 20:25:50< iceiceice> had to set my cache size to 2 GB to get good results, but now i compile after checking out 1.12 / master in like < 5 min 20140416 20:25:51< aquileia> https://github.com/aquileia/wesnoth/tree/code_blocks is now ready to be merged in master 20140416 20:26:13< irker078> wesnoth: Chris Beck wesnoth:master 4c9c25ade1fc / src/savegame.cpp: fix mandatory child missing WML error http://git.io/LZZfuw 20140416 20:26:15< irker078> wesnoth: Chris Beck wesnoth:master f25511d2eeab / src/server/game.cpp: add [start] tag to server replays as needed by gfgtdf http://git.io/tGwJ5A 20140416 20:26:17< irker078> wesnoth: Chris Beck wesnoth:master f2a3e25c2f67 / changelog: update changelog http://git.io/8Scglw 20140416 20:27:40-!- Ivanovic_ [~ivanovic@frnk-4d01602e.pool.mediaWays.net] has joined #wesnoth-dev 20140416 20:27:50< Twooey> yea, pretty sure most of this is still beyond me 20140416 20:27:57< mattsc> iceiceice: I am way too impatient to wait for all the recompiling needed when switching between branches, so I simply have to entire local copies on my computer, one set to master, one to 1.12. 20140416 20:28:51< Coffee_irc> Twooey: looking at your game of life, you are probably right, although at some point everyone has to "jump into the deep end" as it were 20140416 20:29:25< Twooey> I was planning on rewriting that with the thing's I've learned the last few days. Going to add a grid, and attempt to figure out mouse input. 20140416 20:29:47< Coffee_irc> Twooey: I wouldn't be discouraged if your first contribution to a major open source project took longer than you expect 20140416 20:30:11-!- Ivanovic_ [~ivanovic@frnk-4d01602e.pool.mediaWays.net] has quit [Changing host] 20140416 20:30:11-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140416 20:30:32< Twooey> I just wish I could find something I could work on now :). Project Euler is fun, but in small portions. 20140416 20:31:27< Coffee_irc> Twooey: have you had a look on https://gna.org/bugs/?group=wesnoth ? 20140416 20:31:29-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20140416 20:31:46-!- Ivanovic_ is now known as Ivanovic 20140416 20:31:47< Coffee_irc> maybe you can find something and ask about how hard it might be here to fix? 20140416 20:31:55< Twooey> coffee_irc: I have been going through it slowly. 20140416 20:32:32< iceiceice> aquileia: does this stuff need a changelog entry? 20140416 20:33:04< aquileia> I don't know... 20140416 20:33:13< iceiceice> i guess probly not its just changelog files 20140416 20:34:02< irker078> wesnoth: aquileia wesnoth:master 093c49662fc6 / projectfiles/ (CodeBlocks-SCons/wesnoth.cbp CodeBlocks/wesnoth.cbp): Align CB and CB-scons project files http://git.io/2K7mAg 20140416 20:34:04< irker078> wesnoth: aquileia wesnoth:master 5a21d5d8c8a6 / projectfiles/ (CodeBlocks-SCons/wesnoth.cbp CodeBlocks/wesnoth.cbp): CodeBlocks: Don't compile tools & wesmage http://git.io/7gE8bg 20140416 20:34:06< irker078> wesnoth: Chris Beck wesnoth:master b9cc315e5c4d / projectfiles/ (CodeBlocks-SCons/wesnoth.cbp CodeBlocks/wesnoth.cbp): Merge remote-tracking branch 'aquileia/code_blocks' http://git.io/1GlSvQ 20140416 20:34:19< iceiceice> err not changelog files, project files 20140416 20:34:21< iceiceice> you know what i mean :) 20140416 20:38:15-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Read error: Operation timed out] 20140416 20:38:33< iceiceice> hey am i supposed to do the cherry-pick thing or wait for a second branch? 20140416 20:40:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer] 20140416 20:40:47-!- irker078 [~irker@fehu.ai0867.net] has quit [Ping timeout: 250 seconds] 20140416 20:41:40-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds] 20140416 20:41:53< aquileia> iceiceice: please wait 20140416 20:42:04-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20140416 20:42:25< Twooey> what about https://gna.org/bugs/?20937 20140416 20:42:29-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20140416 20:43:15-!- Ivanovic [~ivanovic@frnk-4d01602e.pool.mediaWays.net] has joined #wesnoth-dev 20140416 20:43:15< iceiceice> ok i will have to go to plug in and get more battery soon, so if i leave just leave a link behind for me, ok? 20140416 20:43:51-!- Ivanovic [~ivanovic@frnk-4d01602e.pool.mediaWays.net] has quit [Changing host] 20140416 20:43:51-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140416 20:44:52-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 236 bugs, 350 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140416 20:45:40-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140416 20:45:51< gfgtdf> EliDupree: about 21697: i think the following code is now mp/replaysave: http://pastebin.com/c4rHNVys 20140416 20:46:45< EliDupree> Yay! 20140416 20:47:42< aquileia> iceiceice: It's already uploading, no idea why it takes so long... 20140416 20:48:45< gfgtdf> EliDupree: still not commited though 20140416 20:48:48-!- ancestral [~ancestral@17.114.45.169] has joined #wesnoth-dev 20140416 20:48:56< aquileia> iceiceice: https://github.com/aquileia/wesnoth/tree/code_blocks_1.12 is ready for 1.12 20140416 20:50:48-!- irker114 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140416 20:50:48< irker114> wesnoth: aquileia wesnoth:1.12 da7463406d42 / projectfiles/ (CodeBlocks-SCons/wesnoth.cbp CodeBlocks/wesnoth.cbp): CodeBlocks: Downgrade project files to 1.12 http://git.io/qUuLHw 20140416 20:50:56-!- Ivanovic_ [~ivanovic@frnk-d933319d.pool.mediaWays.net] has joined #wesnoth-dev 20140416 20:52:15< iceiceice> looks good? 20140416 20:52:36< aquileia> yes. Thanks! 20140416 20:52:48< iceiceice> de nada 20140416 20:54:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds] 20140416 20:54:28-!- Ivanovic_ [~ivanovic@frnk-d933319d.pool.mediaWays.net] has quit [Changing host] 20140416 20:54:28-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140416 20:55:06-!- Ivanovic_ is now known as Ivanovic 20140416 20:56:11-!- Twooey [~Twooey@pool-108-16-205-233.phlapa.fios.verizon.net] has quit [Quit: Leaving] 20140416 20:59:49-!- Sulfur [~Miranda@p5B00963D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20140416 21:04:08-!- neXyon [~neXyon@178-191-148-131.adsl.highway.telekom.at] has joined #wesnoth-dev 20140416 21:04:12-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has quit [Ping timeout: 258 seconds] 20140416 21:04:44-!- Coffee_irc [~david@ppp118-210-40-39.lns20.adl2.internode.on.net] has quit [Ping timeout: 265 seconds] 20140416 21:13:33-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140416 21:13:41< gfgtdf> iceiceice: whats bas about these anouncements ? 21928 20140416 21:13:44< gfgtdf> bad* 20140416 21:14:09< iceiceice> they are just visual noise 20140416 21:14:17< iceiceice> they are only relevant to the person who is controllingt he moves, 20140416 21:14:22< iceiceice> not the observer who is replaying 20140416 21:14:37< iceiceice> idk they didnt happen in 1.10 20140416 21:15:35< gfgtdf> iceiceice: i personaly have no problem with seeing them in replays. Or is it becasue tey also appear durign blindfolded ? 20140416 21:15:47< gfgtdf> theyy* 20140416 21:15:52-!- Coffee_irc [~david@ppp121-45-92-187.lns20.adl6.internode.on.net] has joined #wesnoth-dev 20140416 21:15:59< iceiceice> no, its just about observing games using quick replays, i think they are annoying 20140416 21:16:36< iceiceice> i guess if they happened during blindfold is could be bad in some obscure case 20140416 21:18:02< iceiceice> one side could learn that it is being watched by another side with faster units or smth... i guess it would most likely only be relevant for conquest 20140416 21:18:07< gfgtdf> iceiceice: well maybe i can disable them durign quick replays, (which includes blingfold i think ?) 20140416 21:18:25< iceiceice> yeah it would 20140416 21:24:50-!- mjs-de [~mjs-de@f049002118.adsl.alicedsl.de] has quit [Remote host closed the connection] 20140416 21:24:52< gfgtdf> iceiceice: did you test that it happends when you had quick replays on ? 20140416 21:25:07< irker114> wesnoth: David Mikos wesnoth:1.12 b7d22fea3b20 / changelog data/core/macros/animation-utils.cfg: AnimationWML: Fix sound timings for drake fire animation macros http://git.io/wru9iA 20140416 21:25:08< gfgtdf> from looking at the the code i'd say it doesnt 20140416 21:25:33< irker114> wesnoth: David Mikos wesnoth:master f5c4ee56900e / changelog data/core/macros/animation-utils.cfg: AnimationWML: Fix sound timings for drake fire animation macros http://git.io/R_ytKw 20140416 21:26:18< iceiceice> hmm 20140416 21:26:27< iceiceice> ok so i guess the issue is, 20140416 21:26:32< iceiceice> there is no quick replay option for the replay controller 20140416 21:26:42< iceiceice> you can only get to the replay controller from title screen -> load game 20140416 21:26:52< iceiceice> so maybe the check should be for whether acceleration is on? 20140416 21:27:01< iceiceice> if you even want to play this messages at all? 20140416 21:29:44-!- gfgtdf_ [~chatzilla@f054140201.adsl.alicedsl.de] has joined #wesnoth-dev 20140416 21:30:58< gfgtdf_> iceiceice: did 21929 ever work ? 20140416 21:31:56< gfgtdf_> iceiceice: what is teh intention of show replays in mp ? wantching replays together so that people can chat abd discuss about them ? 20140416 21:31:58-!- gfgtdf [~chatzilla@e177123157.adsl.alicedsl.de] has quit [Ping timeout: 276 seconds] 20140416 21:32:00< gfgtdf_> intetnion* 20140416 21:32:09-!- gfgtdf_ is now known as gfgtdf 20140416 21:32:28< iceiceice> the behavior shouldnt be different, 20140416 21:32:33-!- ancestral [~ancestral@17.114.45.169] has quit [Quit: ancestral] 20140416 21:32:46< iceiceice> but right now if you try to load a [multiplayer] file with title screen -> load, 20140416 21:32:50< iceiceice> it will convert the file to SP 20140416 21:32:57< iceiceice> and if you save you will get [scenario] afaik 20140416 21:33:04< gfgtdf> iceiceice: but you can watch mp replay with the normal sp load game -> show dilaod 20140416 21:33:11< gfgtdf> show replay 20140416 21:33:16< iceiceice> if you do that right now in master, 20140416 21:33:25< iceiceice> you will get a warning "this is an mp scenario. it might not work correctly in sp" 20140416 21:33:32< gfgtdf> iceiceice: ignore that warnign 20140416 21:33:39< iceiceice> yes,i know 20140416 21:33:54< gfgtdf> idk why that wanring was introduced 20140416 21:33:56< iceiceice> but i think it would be better if the mp load dialog was an alternative 20140416 21:34:03< iceiceice> it was introduced because it could create bizarre bugs 20140416 21:34:12< iceiceice> if you load mp scenarios in sp that way 20140416 21:34:17< iceiceice> esp with mp campaigns 20140416 21:34:31< iceiceice> the conversion process sort of screws up all the controller types 20140416 21:34:43< iceiceice> and i wasted a lot of time once trying to figure out whatw as wrong, so i added the warning 20140416 21:35:14< iceiceice> it might be that we dont need it anymore because we fixed enough bugs, 20140416 21:35:24< iceiceice> but still regardless of that it would be better if both load methods work 20140416 21:35:54< iceiceice> afaik there are still cases in mp where you will screw up your files if you load with the title screen -> load button 20140416 21:36:23< gfgtdf> iceiceice: THE IS A SIMMILAR BUG. https://gna.org/bugs/index.php?20895 20140416 21:36:27< gfgtdf> sry for caps 20140416 21:36:36< gfgtdf> ddi accidenty 20140416 21:36:39< gfgtdf> did* 20140416 21:36:51< iceiceice> y i saw that also, 20140416 21:37:01< iceiceice> i think its not the real bug there though 20140416 21:37:05< iceiceice> although it is mentioned 20140416 21:37:26< iceiceice> it is mentioned because it causes some other work around to fail, but in that bug there is something legitimately wrong with the map generator 20140416 21:38:23< gfgtdf> iceiceice: i still hope that some lot of bugs solve themselves when we try to unify sp and mp, but that wont happen in 1.12 20140416 21:38:45< Aishiko> and no one has tracked down the map gen bug that is the root cause? 20140416 21:38:49< iceiceice> if we resolve some of these bugs by comparing the logic and getting rid of broken parts, 20140416 21:38:56< iceiceice> it will make it much easier to unfiy sp and mp 20140416 21:39:15< iceiceice> if we hold off on fixing all of those bugs until e.g. RiftWalker comes along we will basically force him to figure out all of them 20140416 21:39:47< iceiceice> Aishiko: no one has stepped up to the task it seems 20140416 21:39:47< gfgtdf> so want the opposite stategy :p. No i never wanted RiftWalker to do it all alone. 20140416 21:40:29< iceiceice> hehe 20140416 21:40:37< iceiceice> idk if its the opposite 20140416 21:40:55< iceiceice> we just look at what each branch does, and if one has a bug, try to merge the logic with the other, to make them harmonious 20140416 21:40:59< iceiceice> before they get merged 20140416 21:42:52< irker114> wesnoth: gfgtdf wesnoth:1.12 11c33d6e4474 / src/ (display.cpp synced_context.cpp synced_context.hpp): leave the synced context for drawing http://git.io/L8lXdA 20140416 21:42:54< irker114> wesnoth: gfgtdf wesnoth:1.12 abb052a68abc / src/ (replay.cpp replay.hpp): add replay::add_start_if_not_there_yet http://git.io/1pTOSA 20140416 21:42:56< irker114> wesnoth: gfgtdf wesnoth:1.12 92822790715f / src/ (replay.cpp replay_controller.cpp): fix 21926 http://git.io/Prilbg 20140416 21:44:37< gfgtdf> iceiceice: maybe we could try to expand teh avefile format and tehn ensure that the secnario things on teh server are always valid saves. 20140416 21:45:10< gfgtdf> savefile 20140416 21:47:21< iceiceice> why you think we need to expand? 20140416 21:47:25< iceiceice> just to make it easier for the server? 20140416 21:48:13< iceiceice> so the server now currently works for "vanilla" replays 20140416 21:48:41< iceiceice> idk if it works with all the sync choice stuff, that is something you will have to tell me although i cant imagine why it would be broken 20140416 21:48:57< iceiceice> i expect that its broken for replays of reloaded, and also for campaigns 20140416 21:49:12< iceiceice> and i guess campaign transitions are probably still broken 20140416 21:51:07< iceiceice> btw, gfgtdf: i saw this bug just now: https://gna.org/bugs/?16492 20140416 21:51:14< iceiceice> do you know anything about that? 20140416 21:53:47< gfgtdf> iceiceice: i removed the [results] tag and replaced it with the [checkup] tag. These tags contain data to make an additional check whether the data calculates in replays match the data calculated during teh proiginal game. But this is not needed for a vaild replay, and it is not lways present in server replays 20140416 21:54:01< gfgtdf> the original game* 20140416 21:54:08< gfgtdf> always* 20140416 21:55:11< iceiceice> hmm 20140416 21:55:16< iceiceice> did you talk to anyone before doing that? 20140416 21:55:23< gfgtdf> no 20140416 21:55:37< iceiceice> it sounds like Soliton wanted the [results] tag to be there 20140416 21:56:27< iceiceice> i wonder if there's anyone else who has made a replay parser 20140416 21:56:38< iceiceice> or use them for some other purpose 20140416 21:56:41< gfgtdf> teh problem that these arent present in teh servergenerated replays was there before and is still there after 20140416 21:56:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20140416 21:57:05< iceiceice> i dont understand, 20140416 21:57:17< iceiceice> they could easily be generated by the host and become part of the server's history 20140416 21:57:29< gfgtdf> iceiceice: how ? 20140416 21:57:35< iceiceice> ? 20140416 21:57:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140416 21:57:51< iceiceice> well whenver an attack command is given for example, 20140416 21:58:00< iceiceice> the client coudl be expected to record the results when broadcasting 20140416 21:58:16< iceiceice> not just the random seeds used 20140416 21:58:26< gfgtdf> yes they are generated on all sides, but the attack commands are sended bofre tehy are gerated on teh client. 20140416 21:58:43< gfgtdf> no tzhe client broadcasts before calculating them 20140416 21:58:59< iceiceice> ok, then the client could immedaitely send a [results] after calculating 20140416 21:59:04< gfgtdf> the random seed used is calculated b the server 20140416 21:59:50< gfgtdf> iceiceice: could be possible but i personly wouldn't give this a high riority 20140416 21:59:55< gfgtdf> priority 20140416 21:59:57< iceiceice> ok 20140416 22:00:40< iceiceice> well why dont you maybe write something in the 16492 history and say [results] is now removed in 1.12 , 1.13-dev 20140416 22:00:55< gfgtdf> iceiceice: also as soon as the scnenario containg any wml the [checkop] tag wont help you in that case 20140416 22:00:56< iceiceice> maybe someone will make a low priority request to put [results] back later 20140416 22:01:45< gfgtdf> iceiceice: the checkop contaings (just liek the old [results]) only data about the "normal" actions 20140416 22:01:50< gfgtdf> contains* 20140416 22:02:25< iceiceice> i'm not saying the [results] should have a like, significant for the game 20140416 22:02:29< iceiceice> it can just be ignored by the clients that recieve it 20140416 22:02:36< iceiceice> i guess 20140416 22:02:51< iceiceice> it *might* help to catch an oos if the checkup mechanism is broken somehow 20140416 22:03:01< iceiceice> it *might* help someone to debug an issue like that 20140416 22:03:12< gfgtdf> iceiceice: the other client would nromaly also have generated their own [checkup] at when the other side send it to teh server 20140416 22:03:14< iceiceice> it *might* help someone to make a 'lightweight' replay parser 20140416 22:03:32< gfgtdf> a very lightweigt. 20140416 22:03:49< iceiceice> yeah that would not detect oos, be saveable or anything else 20140416 22:04:03< iceiceice> idk it might be helpful with sachith's gsoc 20140416 22:04:13< iceiceice> he wants to make a web interface which will help to analyze a database of replays 20140416 22:04:51< gfgtdf> iceiceice: normal replays containg checkup with store information about every sngle hit like this: http://pastebin.com/LN0DMq5k 20140416 22:05:09< iceiceice> oh 20140416 22:05:31< iceiceice> i see so [results] is really just obsoloete now 20140416 22:05:46< iceiceice> i thought [checkup] was like the one you showed me before in [start], where it just tracks random calls 20140416 22:06:09< gfgtdf> iceiceice: yes in teh nk above teh last [checkup] also cntaing teh random calls 20140416 22:06:29< gfgtdf> link* 20140416 22:06:32< gfgtdf> contains* 20140416 22:06:38< iceiceice> y i get it 20140416 22:06:47< iceiceice> ok so we should probably just close 16492, 20140416 22:06:59< iceiceice> i'm not sure if its a "won't fix" now? but the point is [results] is obsoleted 20140416 22:07:32< gfgtdf> iceiceice: but the [checkuo] is nearly teh same data as teh old [results] 20140416 22:07:36< gfgtdf> checkup* 20140416 22:07:51< gfgtdf> except that is nor also caonting a check for random_calls 20140416 22:07:54< gfgtdf> now* 20140416 22:07:59< gfgtdf> contains 20140416 22:08:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds] 20140416 22:08:35< iceiceice> ok well, phrase it however you like, 20140416 22:09:02< iceiceice> my point is that item 16492 should be updated, because right now most likely you are the only person who knows the real status now 20140416 22:09:28-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 245 seconds] 20140416 22:09:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140416 22:11:41< iceiceice> ok gfgtdf: i read the report of 20895 again mroe carefully 20140416 22:11:50< iceiceice> i guess i see now that you mostly fixed the assertion thingy :) 20140416 22:11:56< iceiceice> so the only issue is this invalid id thing 20140416 22:12:18< gfgtdf> iceiceice: yes i basicly removes the file where the assertion thing happend. 20140416 22:12:23< gfgtdf> removed* 20140416 22:12:48< iceiceice> ok i may try to fix that and backport to 1.12 20140416 22:13:17< iceiceice> but its less priority than, 20140416 22:13:26< iceiceice> getting the ready block thing to work 20140416 22:14:26-!- Coffee_irc [~david@ppp121-45-92-187.lns20.adl6.internode.on.net] has quit [Quit: Konversation terminated!] 20140416 22:14:59-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping] 20140416 22:20:14< iceiceice> hehe, gfgtdf, did you ever look at this ohloh thing? 20140416 22:20:18< iceiceice> http://www.ohloh.net/p/wesnoth/estimated_cost 20140416 22:20:31< iceiceice> they estimate that if wesnoth had been a paid project from the beginning, it would have cost 11 million dollars to develop 20140416 22:20:58< gfgtdf> i wonder how the estimate 20140416 22:21:00< gfgtdf> thry* 20140416 22:21:03< iceiceice> just the code, not the art 20140416 22:21:22< iceiceice> i dont really know they are using some model called Cocomo 20140416 22:22:14< gfgtdf> but we still have less than 1 million lines :p 20140416 22:22:48< gfgtdf> lets write 256k lines very fast. 20140416 22:23:53< iceiceice> lol 20140416 22:25:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140416 22:51:06-!- bagzie [~bag@85-76-140-172-nat.elisa-mobile.fi] has quit [] 20140416 22:58:16-!- neXyon_ [~neXyon@88-117-21-81.adsl.highway.telekom.at] has joined #wesnoth-dev 20140416 23:01:13-!- neXyon [~neXyon@178-191-148-131.adsl.highway.telekom.at] has quit [Ping timeout: 265 seconds] 20140416 23:01:44-!- neXyon_ is now known as neXyon 20140416 23:04:06< gfgtdf> iceiceice: what are those 'id's in pp scenarios ? are they differet from teh sp ids ? 20140416 23:04:09< gfgtdf> mp* 20140416 23:04:32< iceiceice> i dont really know 20140416 23:16:25-!- neXyon [~neXyon@88-117-21-81.adsl.highway.telekom.at] has quit [Quit: gn8] 20140416 23:18:18-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20140416 23:18:52-!- Guest87885 [~8680@2002:4404:712c:0:f855:adb2:c730:ff47] has quit [Remote host closed the connection] 20140416 23:19:15-!- _8680_ [~8680@2002:4404:712c:0:b94f:18e5:be5c:f9c7] has joined #wesnoth-dev 20140416 23:19:35-!- _8680_ is now known as Guest13226 20140416 23:21:50-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20140416 23:22:29-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 265 seconds] 20140416 23:26:01< gfgtdf> wesbot: seen crab_ 20140416 23:26:01< wesbot> gfgtdf: The person with the nick Crab_ last spoke 27d 3h ago. 26d 15h ago they left with the message: Quit: Crab_ 20140416 23:27:57-!- spoffy [~spoffy@host86-181-255-251.range86-181.btcentralplus.com] has quit [Ping timeout: 258 seconds] 20140416 23:28:18-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has quit [Ping timeout: 240 seconds] 20140416 23:34:51-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 258 seconds] 20140416 23:35:01-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20140416 23:36:19< irker114> wesnoth: gfgtdf wesnoth:1.12 1b6b22663be2 / src/ (callable_objects.hpp unit.cpp): fix 21909 http://git.io/XA6xnw 20140416 23:39:45-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 250 seconds] 20140416 23:40:01-!- gfgtdf [~chatzilla@f054140201.adsl.alicedsl.de] has quit [Read error: Connection reset by peer] 20140416 23:42:39-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20140416 23:44:16-!- gfgtdf [~chatzilla@f054140201.adsl.alicedsl.de] has joined #wesnoth-dev 20140416 23:59:00-!- justinzane [~justinzan@12.172.184.180] has quit [Ping timeout: 258 seconds] --- Log closed Thu Apr 17 00:00:04 2014