--- Log opened Thu Apr 17 00:00:04 2014
20140417 00:10:10-!- ancestral [~ancestral@17.114.45.222] has joined #wesnoth-dev
20140417 00:24:56< gfgtdf> ancestral: is there a reason why 20709 is still open: 
20140417 00:25:07< gfgtdf> or maybe i forgot it myself to clode it ?
20140417 00:25:46< gfgtdf> close*
20140417 00:27:24< gfgtdf> wesbot: seen alarantalara
20140417 00:27:24< wesbot> gfgtdf: Sorry, I don't know of alarantalara.
20140417 00:52:18-!- sachith500 [~kvirc@112.134.149.88] has joined #wesnoth-dev
20140417 01:00:03-!- Samual_ [diotecktec@c-71-195-88-69.hsd1.pa.comcast.net] has joined #wesnoth-dev
20140417 01:00:03-!- Samual_ [diotecktec@c-71-195-88-69.hsd1.pa.comcast.net] has quit [Changing host]
20140417 01:00:03-!- Samual_ [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20140417 01:00:47-!- Samual [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 250 seconds]
20140417 01:01:44-!- ancestral [~ancestral@17.114.45.222] has quit [Quit: ancestral]
20140417 01:03:06< irker114> wesnoth: Chris Beck wesnoth:master 39ea04fa174d / src/replay_controller.cpp: fixup replay controller next side button http://git.io/8ddICA
20140417 01:03:08< irker114> wesnoth: Chris Beck wesnoth:master 845213694345 / changelog players_changelog: update changelogs http://git.io/K_bqSg
20140417 01:05:50< irker114> wesnoth: Chris Beck wesnoth:1.12 a1054cc22414 / src/replay_controller.cpp: fixup replay controller next side button http://git.io/1RsVlA
20140417 01:05:52< irker114> wesnoth: Chris Beck wesnoth:1.12 f23bc9d8d61a / changelog players_changelog: update changelogs http://git.io/OCuvqw
20140417 01:05:54< irker114> wesnoth: Chris Beck wesnoth:1.12 91ac54fa9d59 / / (10 files in 3 dirs): Merge branch '1.12' of https://github.com/wesnoth/wesnoth into 1.12 http://git.io/WEezKg
20140417 01:08:03-!- sachith500 [~kvirc@112.134.149.88] has quit [Read error: Connection reset by peer]
20140417 01:09:58-!- sachith500 [~kvirc@112.134.149.88] has joined #wesnoth-dev
20140417 01:18:23-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has quit [Quit: Page closed]
20140417 01:22:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 240 seconds]
20140417 01:22:06-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 240 seconds]
20140417 01:22:25-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20140417 01:25:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20140417 01:27:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 01:30:05< iceiceice> Ivanovic: a quick update on things that might be considered blockers
20140417 01:30:10< iceiceice> in my email i listed 5 items
20140417 01:30:25< iceiceice> 1.) was getting server replays to work at least at 1.10 level quality
20140417 01:30:45< iceiceice> I can currently load vanilla 1v1 replays without a problem on 1.12
20140417 01:31:04< iceiceice> i dont know if there are other cases that are broken, but i dont know of anything we could load in 1.10 successfully that we can't currently in 1.12
20140417 01:31:14< iceiceice> 2.) was fixing up this check victory thing
20140417 01:31:30< iceiceice> i have not personally tested that properly
20140417 01:32:05< iceiceice> but i also havent noticed any bugs yet in the week or two of testing for other issues , and mattsc reports that it works in his usecase
20140417 01:32:18< iceiceice> 3.) was this map generator segfault
20140417 01:32:26< iceiceice> i guess gfgtdf actually fixed that although i didnt understand at the time that i wrote the email
20140417 01:32:57< iceiceice> 4.) was merging gftdf's sync stuff, that is now done and has been tested quite a bit
20140417 01:33:13< iceiceice> 5.) was a possible partial disablement of whiteboard,
20140417 01:33:22< iceiceice> no one has spoke against it or stepped up to do anything about it yet
20140417 01:33:58< iceiceice> there are some blocker items listed on gna, the one i am working on is #21916
20140417 01:35:03< iceiceice> so in summary, unless more testing reveals more problems, the only potential blockers i know of are "do something with whiteboard" and whatever is on gna
20140417 01:35:18-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 245 seconds]
20140417 01:46:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140417 01:48:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140417 01:51:54< mattsc> gfgtdf: I see you’re closing a lot of bug reports (which is great that they are fixed!).  Are those all in released versions yet?
20140417 01:53:52< gfgtdf> mattsc: in 1.11.12+dev
20140417 01:54:03< mattsc> So not in a released version.
20140417 01:54:06< gfgtdf> no
20140417 01:54:24< gfgtdf> is that a problem ?
20140417 01:54:25< mattsc> As a general rule, we marke such bugs as fixed, but don’t close them until after the next release comes out.
20140417 01:54:33< gfgtdf> hm
20140417 01:54:40< gfgtdf> for which reason ?
20140417 01:54:52< mattsc> That’s what I was told at least.
20140417 01:55:00< sachith500> ooh software development life cycle?
20140417 01:55:09< sachith500> *software process model
20140417 01:55:16< sachith500> was just reading about it yesterday
20140417 01:55:25< mattsc> I don’t know the reason, but I’d guess that it is so that people who do not compile their own version have access to a version with the bug fixed in it.
20140417 01:56:05< mattsc> Remember, I’m just somebody who stares at the stars and doesn’t really know anything about anything.  :)
20140417 01:56:21< gfgtdf> mattsc: shall i open them again ?
20140417 01:56:55< mattsc> gfgtdf: that would be consistent with what other people are doing, so I’d say yes.  (But I personally don’t have a strong opinion on it one way or the other.)
20140417 01:57:46-!- justinzane [~justinzan@12.172.184.180] has joined #wesnoth-dev
20140417 01:58:59< iceiceice> gfgtdf: fwiw i closed a bug report once and shadowm later came by and reopened it
20140417 01:59:10< iceiceice> and may have "hit me with a squeaky rubber mallet" or some such :p
20140417 01:59:36< gfgtdf> nah ok i'll reopen
20140417 01:59:51< sachith500> it's probably easier to verify the changelog too
20140417 01:59:55< sachith500> if the bugs are open?
20140417 02:00:54< iceiceice> idk i mean all that kind of stuff should be much easier if we didnt use gna :/
20140417 02:01:08-!- justinzane [~justinzan@12.172.184.180] has quit [Client Quit]
20140417 02:02:02< gfgtdf> reopened 7 bugs / fetue requests 
20140417 02:02:54< gfgtdf> iceiceice: what systen would youi prefer ?
20140417 02:03:35< iceiceice> idk, apparently we discussed moving to either redmine or chilli project, and crab even figured out how to grab all of the current bug reports out of gna: http://wiki.wesnoth.org/WesnothGIT
20140417 02:04:00< iceiceice> cant remember where i read the crab part, maybe in a fosdem log or smth
20140417 02:04:43< iceiceice> http://wiki.wesnoth.org/Fosdem2014#Bugtracker_.2F_single_login
20140417 02:04:44< iceiceice> yeah
20140417 02:10:41-!- Samual_ [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 252 seconds]
20140417 02:10:42-!- Samual [diotecktec@c-71-195-88-69.hsd1.pa.comcast.net] has joined #wesnoth-dev
20140417 02:10:42-!- Samual [diotecktec@c-71-195-88-69.hsd1.pa.comcast.net] has quit [Changing host]
20140417 02:10:42-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20140417 02:12:18-!- justinzane [~justinzan@12.172.184.180] has joined #wesnoth-dev
20140417 02:13:56-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140417 02:17:48-!- Ivanovic_ [~ivanovic@frnk-5f75142a.pool.mediaWays.net] has joined #wesnoth-dev
20140417 02:19:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 02:20:39-!- sachith500|2 [~kvirc@112.134.237.232] has joined #wesnoth-dev
20140417 02:20:50-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 258 seconds]
20140417 02:21:41-!- Ivanovic_ is now known as Ivanovic
20140417 02:23:44-!- sachith500 [~kvirc@112.134.149.88] has quit [Ping timeout: 265 seconds]
20140417 02:31:48-!- sachith500|2 [~kvirc@112.134.237.232] has quit [Read error: Connection reset by peer]
20140417 02:36:06-!- gfgtdf [~chatzilla@f054140201.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]]
20140417 02:36:56-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 258 seconds]
20140417 02:44:52-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 232 bugs, 347 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140417 02:48:09< Aishiko> mordante, I have the test file(s) and a main I'm getting an error and I'm not sure why as of yet (the program crashes, compiles but crashes now)
20140417 02:57:10-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140417 02:59:57-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg]
20140417 03:04:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140417 03:31:31-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140417 04:05:57-!- irker114 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140417 04:06:12-!- Guest13226 [~8680@2002:4404:712c:0:b94f:18e5:be5c:f9c7] has quit [Ping timeout: 265 seconds]
20140417 04:07:06-!- _8680_ [~8680@2002:4404:712c:0:9c6d:82e4:89f2:9f6] has joined #wesnoth-dev
20140417 04:07:26-!- _8680_ is now known as Guest18960
20140417 04:10:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 04:22:19-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Ping timeout: 252 seconds]
20140417 04:23:57-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140417 04:28:17-!- irker313 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140417 04:28:17< irker313> wesnoth: mattsc wesnoth:master 4e98ab314a48 / data/campaigns/Son_Of_The_Black_Eye/scenarios/02_The_Human_Army.cfg: SotBE S2: adjust starting villages http://git.io/rMdogA
20140417 04:28:17< irker313> wesnoth: mattsc wesnoth:master a30b6cb77c35 / data/campaigns/Son_Of_The_Black_Eye/scenarios/02_The_Human_Army.cfg: SotBE S2: end scenario if Kapou'e is already at signpost http://git.io/ghq9Vg
20140417 04:28:18< irker313> wesnoth: mattsc wesnoth:master 9ec2cdec3c89 / data/campaigns/Son_Of_The_Black_Eye/scenarios/03_Toward_Mountains_of_Haag.cfg: SotBE S3: make the two sets of objectives consistent with each other http://git.io/S_WOjA
20140417 04:29:59< irker313> wesnoth: mattsc wesnoth:1.12 160f80cc635b / data/campaigns/Son_Of_The_Black_Eye/scenarios/02_The_Human_Army.cfg: SotBE S2: adjust starting villages http://git.io/9mJI9Q
20140417 04:30:01< irker313> wesnoth: mattsc wesnoth:1.12 007082009aec / data/campaigns/Son_Of_The_Black_Eye/scenarios/02_The_Human_Army.cfg: SotBE S2: end scenario if Kapou'e is already at signpost http://git.io/_YOjdg
20140417 04:30:03< irker313> wesnoth: mattsc wesnoth:1.12 c70ecc9b650c / data/campaigns/Son_Of_The_Black_Eye/scenarios/03_Toward_Mountains_of_Haag.cfg: SotBE S3: make the two sets of objectives consistent with each other http://git.io/lnHNwQ
20140417 04:44:43-!- sachith500|2 [~kvirc@112.134.237.232] has joined #wesnoth-dev
20140417 04:53:19-!- justinzane [~justinzan@12.172.184.180] has quit [Ping timeout: 276 seconds]
20140417 04:59:16-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140417 05:09:56-!- justinzane [~justinzan@24.49.207.201] has joined #wesnoth-dev
20140417 05:28:50-!- Sulfur [~Miranda@p5B327131.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140417 05:33:05-!- justinzane [~justinzan@24.49.207.201] has quit [Ping timeout: 252 seconds]
20140417 05:39:06-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140417 05:39:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20140417 05:39:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 05:43:30-!- justinzane [~justinzan@host-12-172-184-180.nctv.com] has joined #wesnoth-dev
20140417 05:46:58-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140417 05:53:41-!- Ivanovic [~ivanovic@frnk-5f75142a.pool.mediaWays.net] has quit [Changing host]
20140417 05:53:41-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140417 05:59:29-!- justinzane [~justinzan@host-12-172-184-180.nctv.com] has quit [Ping timeout: 252 seconds]
20140417 06:13:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140417 06:17:14-!- vultraz_ [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140417 06:17:40-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 240 seconds]
20140417 06:17:48-!- vultraz_ is now known as vultraz
20140417 06:17:59-!- mjs-de [~mjs-de@g228039218.adsl.alicedsl.de] has joined #wesnoth-dev
20140417 06:21:19-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20140417 06:21:19-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140417 06:39:26-!- justinzane [~justinzan@host-12-172-184-180.nctv.com] has joined #wesnoth-dev
20140417 07:07:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140417 07:14:52-!- Sulfur [~Miranda@p5B327131.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140417 07:20:38-!- sachith500|2 [~kvirc@112.134.237.232] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140417 07:22:22< Soliton> iceiceice: note that sever side replays can be fixed any time with a server update (unless client side changes are needed for some reason) so it is not necessarily tied to release schedules.
20140417 07:23:31< iceiceice> i see, that makes sense
20140417 07:25:38< Soliton> gfgtdf: so replays contain a [checkup] tag that contains a list of [checkup] tags? maybe that can be made a tiny bit less confusing..? also [checkup] tells me pretty much nothing while [results] was understandable.
20140417 07:30:13-!- irker313 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140417 07:32:34< iceiceice> Soliton: so one thing which i have learned that i broke is that networked scenario transitions don't work properly anymore
20140417 07:32:38< iceiceice> since the server controller tweaks
20140417 07:32:58< iceiceice> it seems like we discovered some preexisting bugs in that mechanism as well,
20140417 07:33:24< iceiceice> i think i will be able to figure out what to do about it, but if you had any thoughts ofc it would be helpful
20140417 07:37:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140417 08:07:14-!- irker505 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140417 08:07:14< irker505> wesnoth: Chris Beck wesnoth:1.12 b745bd756e07 / src/ (multiplayer_connect_engine.cpp multiplayer_connect_engine.hpp): fix bug #21916, ready blocked at inappropriate times http://git.io/uKFp8Q
20140417 08:07:14< irker505> wesnoth: Chris Beck wesnoth:1.12 5253d2de5673 / changelog: update changelog http://git.io/VU8-Wg
20140417 08:07:14< irker505> wesnoth: Chris Beck wesnoth:1.12 fd6038a7460e / data/campaigns/Son_Of_The_Black_Eye/scenarios/ (02_The_Human_Army.cfg 03_Toward_Mountains_of_Haag.cfg): Merge branch '1.12' of https://github.com/wesnoth/wesnoth into 1.12 http://git.io/4X4K7Q
20140417 08:09:40< irker505> wesnoth: Chris Beck wesnoth:master 5053fe1563dc / src/ (multiplayer_connect_engine.cpp multiplayer_connect_engine.hpp): fix bug #21916, ready blocked at inappropriate times http://git.io/nx0cOA
20140417 08:09:42< irker505> wesnoth: Chris Beck wesnoth:master 6a3b12df4503 / changelog: update changelog http://git.io/30FaeA
20140417 08:09:44< irker505> wesnoth: Chris Beck wesnoth:master 961a778d15e6 / data/campaigns/Son_Of_The_Black_Eye/scenarios/ (02_The_Human_Army.cfg 03_Toward_Mountains_of_Haag.cfg): Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/picS9Q
20140417 08:11:06-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has joined #wesnoth-dev
20140417 08:13:02< aquileia> iceiceice: Just out of interest, why do you get these merge commits on 1.12? Do you pull before pushing?
20140417 08:13:17< iceiceice> yeah 
20140417 08:13:50< iceiceice> i mean if i worked on something for a while then its going to result in a mege
20140417 08:13:52< iceiceice> *merge
20140417 08:14:15< iceiceice> i guess sometimes i will rebase my topic branch so that this doesn't happen,
20140417 08:14:39< iceiceice> but i guess i've come to see that its not a big problem
20140417 08:15:34< iceiceice> when you rebase it sort of destroys history in the sense that you are pretending that all of your commits happened later in time, and if you check them out and test them you wont get the same results potentially if they conflict with some commit going on meanwhile on someone elses branch
20140417 08:16:33< aquileia> thanks for the clarification - I didn't know how useful rebase is
20140417 08:17:01< iceiceice> yeah rebase is great :)
20140417 08:17:27< aquileia> I probably would have done a cherry pick - there's so much of git I have no idea of yet...
20140417 08:19:20< iceiceice> oh,
20140417 08:19:27< iceiceice> i mean in that case i did use cherry pick
20140417 08:19:32< iceiceice> i just didnt pull 1.12 before i did
20140417 08:20:11< iceiceice> didnt see mattsc's commits above
20140417 08:20:15-!- neXyon [~neXyon@88-117-21-81.adsl.highway.telekom.at] has joined #wesnoth-dev
20140417 08:20:38< aquileia> ah, ok
20140417 08:22:17< vultraz> anyone know how to properly use wmllint: who cmnnets?
20140417 08:23:18< Soliton> iceiceice: my thoughts are that it doesn't surprise me at all. :-P
20140417 08:24:12< iceiceice> Soliton: so there is a pretty strange bug that i found also that i think may even affect 1.10
20140417 08:24:27< iceiceice> the bug is that, when there is a transition to the next scenario from linger mode,
20140417 08:24:51< iceiceice> if the host does not transition first then the other players dont transition successfully
20140417 08:25:29< aquileia> vultraz: Isn't it just e.g. # wmllint: who NYM is Nym before the first usage of {NYM}, like in UtBS?
20140417 08:26:11< vultraz> so it identifies a character macro as that character?
20140417 08:26:29< aquileia> that's the standard use
20140417 08:27:20< aquileia> It probably can identify other things as well, but characters are the intended purpose
20140417 08:28:18< Soliton> iceiceice: i suppose the host only sends the next scenario data upon leaving linger mode?
20140417 08:28:35< vultraz> And I guess that means I no longer have to turn off wmllint validation on sides that use character macros?
20140417 08:29:27< iceiceice> i think thats right
20140417 08:29:27< Soliton> iceiceice: ideally it'd send the data right when the scenario finished. which would still allow other clients to be faster so either way there is some mechanism needed for them to wait for the next scenario data to be available.
20140417 08:29:34< aquileia> vultraz: exactly
20140417 08:29:41< vultraz> ah
20140417 08:30:00< Soliton> (which i'm guessing there isn't right now.)
20140417 08:30:01< iceiceice> Soliton: i think i've even seen, although not sure what build it is in, sometimes the clients can transition to an mp::wait screen
20140417 08:30:06< iceiceice> until the host sends the data
20140417 08:30:11< iceiceice> it just seems that that doesnt work right sometimes
20140417 08:30:26< iceiceice> i had some tests where the clients just reload the original level
20140417 08:30:30< iceiceice> then the host moves to the next level
20140417 08:30:34< iceiceice> and things become OOS quickly
20140417 08:30:37< Soliton> that's some new stuff from the mp/sp unification i think. don't know anything about that.
20140417 08:30:39< iceiceice> err, alreayd are oos
20140417 08:30:46< iceiceice> hmm ok
20140417 08:32:04< aquileia> vultraz: You can also give it a comma separated list of characters included in the macro like done in DW
20140417 08:36:57< aquileia> Scrap the "probably can identify other things", I just grepped mainline: all 22 matches identify characters
20140417 08:37:14< vultraz> ok
20140417 08:38:00-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140417 08:46:10-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140417 08:52:02-!- Kevin_Xi [~kevin@223.72.182.158] has joined #wesnoth-dev
20140417 08:56:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20140417 08:57:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140417 09:03:39-!- cib [~cib@132.231.178.77] has joined #wesnoth-dev
20140417 09:04:03-!- cib is now known as Guest58261
20140417 09:04:40-!- Coffee_irc [~david@ppp121-45-92-187.lns20.adl6.internode.on.net] has joined #wesnoth-dev
20140417 09:10:04-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 276 seconds]
20140417 09:20:13-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 09:27:54-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140417 09:30:52-!- cib0 [~cib0@overbeck.rtk0.net] has joined #wesnoth-dev
20140417 09:36:27-!- Kevin_Xi [~kevin@223.72.182.158] has quit [Ping timeout: 250 seconds]
20140417 09:41:21< cib0> Getting the strangest issue..
20140417 09:42:10< cib0> Defined a lua menu action, when I use it upon scenario end it'll nuke my recall lists.. if I don't use it, everything is fine. Also if I use it, then save, then reload, everything is fine as well.
20140417 09:49:24-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has joined #wesnoth-dev
20140417 09:51:49-!- Guest58261 [~cib@132.231.178.77] has quit [Quit: Leaving]
20140417 09:53:32< cib0> Okay, it's definitely a bug with the engine, found a wesnoth version that doesn't have the problem. I'm going to bisect and report an issue.
20140417 10:02:09-!- bagzie [~bag@85-76-130-162-nat.elisa-mobile.fi] has joined #wesnoth-dev
20140417 10:04:12-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20140417 10:37:52< aquileia> mattsc: Is the following AI related or a bug in the scenario? http://pastebin.com/0dHdeCLA
20140417 10:50:40< aquileia> gfgtdf, iceiceice: I'm just wondering... why are [unit]s copied into saves instead of using [base_unit] and just adding the additional data like traits?
20140417 10:53:08< aquileia> I don't understand how saves work, but it seems a little superfluous to have these copies, so I thought I'd ask
20140417 11:09:47-!- irker505 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140417 12:12:44-!- cib_ [~cib@132.231.64.158] has joined #wesnoth-dev
20140417 12:30:53-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has joined #wesnoth-dev
20140417 12:30:53-!- happygrue [~happygrue@c-66-30-155-184.hsd1.ma.comcast.net] has quit [Changing host]
20140417 12:30:53-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140417 12:33:10-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140417 12:39:25-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140417 12:39:34-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140417 12:40:02-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 12:40:28-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer]
20140417 12:40:54-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 12:45:23-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140417 12:55:15-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 258 seconds]
20140417 12:58:23-!- c74d3a4 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140417 13:13:11-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 13:21:05-!- Aishiko_laptop [~unknown@198.85.71.253] has joined #wesnoth-dev
20140417 13:32:38-!- Sulfur [~Miranda@p5B327131.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140417 13:44:03-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20140417 13:44:22-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has quit [Ping timeout: 276 seconds]
20140417 13:47:22< mattsc> aquileia: that’s an AI error, I think.  How do you get it?
20140417 13:47:59< aquileia> I started a local game against experimental AI
20140417 13:48:16< mattsc> Which version?
20140417 13:48:18< aquileia> but I'm not sure I've got your last fixes in by build
20140417 13:48:28< aquileia> built yesterday from master
20140417 13:49:43< aquileia> If you want I can do a fresh build and retry
20140417 13:49:58< mattsc> aquileia: thanks, I get it to.  I’ll look into it shortly.
20140417 13:52:44< aquileia> A little unusual was that the AI had no healer
20140417 13:52:47-!- neXyon [~neXyon@88-117-21-81.adsl.highway.telekom.at] has quit [Quit: bye]
20140417 13:53:28< aquileia> but I guess that doesn't matter in this case
20140417 13:53:31-!- cib_ [~cib@132.231.64.158] has quit [Ping timeout: 258 seconds]
20140417 13:58:31< mattsc> No, it doesn’t.  It happens in the part when the AI tries to figure out if it has healers.
20140417 14:07:43-!- happygrue [~happygrue@2601:6:4380:7df:e4cd:ee7b:75f3:4d43] has joined #wesnoth-dev
20140417 14:07:43-!- happygrue [~happygrue@2601:6:4380:7df:e4cd:ee7b:75f3:4d43] has quit [Changing host]
20140417 14:07:43-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140417 14:10:30-!- cib_ [~cib@132.231.64.158] has joined #wesnoth-dev
20140417 14:11:53-!- irker612 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140417 14:11:53< irker612> wesnoth: mattsc wesnoth:master f1faf1d6e32e / data/ai/lua/generic_rush_engine.lua: Experimental AI: fix a parameter in call to healer support AI http://git.io/xhjDXQ
20140417 14:13:01< irker612> wesnoth: mattsc wesnoth:1.12 c64d8f0f84ae / data/ai/lua/generic_rush_engine.lua: Experimental AI: fix a parameter in call to healer support AI http://git.io/i3MIiA
20140417 14:13:10< mattsc> aquileia: ^
20140417 14:13:38< mattsc> aquileia: thanks, it was due to a change I made 2 days ago.  I’m glad you found it before 1.11.13 is released!
20140417 14:13:53< aquileia> no problem
20140417 14:14:42-!- cib_ [~cib@132.231.64.158] has quit [Ping timeout: 240 seconds]
20140417 14:18:35< aquileia> I can confirm on the same save that it's fixed
20140417 14:18:55< mattsc> Thank you.
20140417 14:22:37-!- Kevin_Xi [~kevin@223.72.182.158] has joined #wesnoth-dev
20140417 14:23:29-!- Guest18960 [~8680@2002:4404:712c:0:9c6d:82e4:89f2:9f6] has quit [Ping timeout: 246 seconds]
20140417 14:26:46-!- _8680_ [~8680@2002:4404:712c:0:355c:36eb:472a:5351] has joined #wesnoth-dev
20140417 14:27:06-!- _8680_ is now known as Guest3906
20140417 14:27:43< aquileia> Kevin_Xi: I made some tiny changes to the CB-scons file after your PR
20140417 14:29:14< aquileia> just to let you know...
20140417 14:39:15< Kevin_Xi> aquileia: Thank you for the note! I have seen your change just now, and I can't find "..\..\src\gui\auxiliary\widget_definition\tooltip.?pp" either in master or 1.12 branch. Where are these two files?
20140417 14:41:18< aquileia> Oops... I knew it doesn't exist in 1.12, but didn't check in master
20140417 14:42:03-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 14:42:08< Kevin_Xi> aquileia: yes, also don't exist in master
20140417 14:44:33-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140417 14:45:12< Kevin_Xi> aquileia: anyway, it seems very little people use CodeBlocks-Scons, I diff a bunch of missed/obsolete files before the PR
20140417 14:46:45< loonycyborg> exact files don't affect compilation
20140417 14:47:10< loonycyborg> Because scons reads files to build from src/SConscript anyway
20140417 14:48:52< aquileia> Kevin_Xi: I compared the CB and CB-scons files and the tooltip files were in the scons version after your PR, so I added them to CB
20140417 14:49:28< aquileia> I missed the fact that they no longer exist (but checked before the patch to 1.12)
20140417 14:50:32< aquileia> loonycyborg: Would you mind deleting them from the project files of CB and CB-scons?
20140417 14:51:57< loonycyborg> if those cpp files aren't actually used..
20140417 14:52:13< aquileia> they no longer exist
20140417 14:52:23-!- Kevin_Xi [~kevin@223.72.182.158] has quit [Ping timeout: 245 seconds]
20140417 14:52:26< loonycyborg> then definitely remove references to them
20140417 14:53:07< aquileia> well, I can't do it myself
20140417 14:53:29< aquileia> I could do a PR or a branch
20140417 14:54:43-!- Kevin_Xi [~kevin@223.72.182.158] has joined #wesnoth-dev
20140417 14:55:00-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140417 14:55:28-!- cib_ [~cib@132.231.178.7] has joined #wesnoth-dev
20140417 14:56:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20140417 14:57:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140417 14:59:10< aquileia> https://github.com/aquileia/wesnoth/tree/code_blocks
20140417 14:59:52< Kevin_Xi> aquileia: I think I got disconnected accidently. About the project file: sorry it's my fault...
20140417 15:00:10< aquileia> No, it isn't
20140417 15:00:54< aquileia> I should have checked which of the files is correct
20140417 15:01:03< Kevin_Xi> aquileia: well after finished that file I should grep and diff again to make sure
20140417 15:03:03< aquileia> loonycyborg, iceiceice: Would one of you include the single commit added in that branch, please?
20140417 15:03:41< iceiceice> where is it supposed to go?
20140417 15:03:59< aquileia> master
20140417 15:04:25< Kevin_Xi> loonycyborg: yes it don't affect compilation but I think it affect debug mode. I still can't track which line the program is currently on after set break point to main() I think it is because the program run into the missed file
20140417 15:04:28< aquileia> sorry to bother you again, I accidentally added a file that doesn't exist
20140417 15:04:57< aquileia> iceiceice: ^
20140417 15:05:21< loonycyborg> Kevin_Xi: Yeah, it might affect debugger and stuff like code completion
20140417 15:05:54< irker612> wesnoth: aquileia wesnoth:master 963690884d30 / projectfiles/ (CodeBlocks-SCons/wesnoth.cbp CodeBlocks/wesnoth.cbp): Fix CodeBlocks project files http://git.io/t_U29w
20140417 15:06:20< aquileia> thanks
20140417 15:06:35-!- spoffy [~spoffy@host86-181-255-251.range86-181.btcentralplus.com] has joined #wesnoth-dev
20140417 15:06:35< iceiceice> no problem
20140417 15:10:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 15:16:12-!- cib_ [~cib@132.231.178.7] has quit [Remote host closed the connection]
20140417 15:17:15-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140417 15:30:23-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has joined #wesnoth-dev
20140417 15:38:07-!- spoffy [~spoffy@host86-181-255-251.range86-181.btcentralplus.com] has quit [Ping timeout: 276 seconds]
20140417 15:38:59< Kevin_Xi> aquileia: Should bother you again. I just pull from the origin and try to build using CodeBlock-Scons and got this: http://pastebin.com/9nb40wpm. I see https://github.com/wesnoth/wesnoth/blob/master/SConstruct#L50, are you sure it should be capitalize?
20140417 15:40:07-!- travis-ci [~travis-ci@ec2-107-20-0-147.compute-1.amazonaws.com] has joined #wesnoth-dev
20140417 15:40:07< travis-ci> [travis-ci] wesnoth/wesnoth#2381 (master - 9636908 : aquileia): The build has errored.
20140417 15:40:07< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/23212356
20140417 15:40:07-!- travis-ci [~travis-ci@ec2-107-20-0-147.compute-1.amazonaws.com] has left #wesnoth-dev []
20140417 15:42:21< aquileia> Kevin_Xi: Another reason not to change a project file you didn't test... sorry
20140417 15:43:32< aquileia> Fixing my errors is more work than producing them
20140417 15:44:17-!- Sulfur [~Miranda@p5B327131.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140417 15:46:16< aquileia> At least the travis build just errored instead of failing
20140417 15:46:50< Kevin_Xi> aquileia: I can help to test this part, I'll inform you if it has issues. And actually I think we may use script to generate the project file automatically.
20140417 15:46:53-!- neXyon [~neXyon@88-117-21-81.adsl.highway.telekom.at] has joined #wesnoth-dev
20140417 16:01:02-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has quit [Quit: leaving]
20140417 16:02:15-!- cib [~cib@132.231.178.78] has joined #wesnoth-dev
20140417 16:02:38-!- cib is now known as Guest77404
20140417 16:03:21-!- apoi [~andi@85.126.180.242] has joined #wesnoth-dev
20140417 16:05:54-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 16:17:26-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev
20140417 16:20:55< Kevin_Xi> aquileia: It doesn't cost that much to fix, just ~ the 'R' and 'D' it will work. But I still can't see that little yellow arrow indicated the current location  in CodeBlocks.
20140417 16:21:05< Kevin_Xi> aquileia: I press the 'Campaign' in the main screen and the flow should be 'main()-->do_gameloop()-->new_campaign()', but after press six times 'continue' it just jump through the breakpoint I set at do_gameloop() and I don't know where it is currently at.
20140417 16:23:01< aquileia> I think I can't help you with that... I don't know which discrepancy could be the cause
20140417 16:25:25-!- gfgtdf [~chatzilla@f054140201.adsl.alicedsl.de] has joined #wesnoth-dev
20140417 16:26:04-!- Guest77404 [~cib@132.231.178.78] has quit [Ping timeout: 240 seconds]
20140417 16:26:53< aquileia> gfgtdf: Out of interest, do you know where / how the [unit] tags of save games are created?
20140417 16:27:14< Kevin_Xi> aquileia: OK, I'll try if I can fix it. But how should we deal with the project file now?
20140417 16:27:30< gfgtdf> Soliton:  have no prblem with naming the [checkup] how'd you name it? Note that it is not only used for attack results, but also to check whether the unit checksum in a recalled unit matched the one in orginal game, and to check whether we called the rng the same amount of times as we did durign teh original game.
20140417 16:29:22< Kevin_Xi> aquileia: new to here and not quite familiar with the way we work, should I just fix the capitalize for now?
20140417 16:29:29< aquileia> Kevin_Xi: It's not any more broken than it was before you fixed it, and you know how long nobody cared... IMHO the fix can wait until you found the second issue (if you want to do that)
20140417 16:29:54< gfgtdf> aquileia: there are sidderent [unit]'s in scenarios, in savefiles, and in savefiles there are units in the [snapshot] and in [carryover_sides], we have unit::write function that converts a unit to a config.
20140417 16:29:58< gfgtdf> different*
20140417 16:32:00< aquileia> Ok, then I guess it'd be rather hard to compress these with [base_unit]
20140417 16:32:35< gfgtdf> aquileia: hm ye note the nearly everything about a unit can change from it's types values
20140417 16:32:57< gfgtdf> liek wml can easily add attacks abilities or similar to a single unit
20140417 16:33:00< gfgtdf> like*
20140417 16:33:06< gfgtdf> or abilites*
20140417 16:33:15< Kevin_Xi> aquileia: OK I will try it later. It's late in my timezone and I should get some sleep to catch morning class tomorrow. BTW, what debugger you use for Wesnoth project? gdb?
20140417 16:34:19< aquileia> but it's extremely rare that animations change, and usually changes are just adding a [modification] block - that's the reason I thought it might work.
20140417 16:36:40< gfgtdf> 	aquileia: hm maybe you are right  especialy becasue as soon as the unit has [object] with duration= level, the unit is recalculated after scenario end anyways, but that would only be true of unit's in [carryover_sides] then.
20140417 16:37:12< aquileia> Kevin_Xi: I'm not on a Unix system, but I think there are multiple debuggers in use
20140417 16:37:37< gfgtdf> aquileia: but i also think that thre are a lot of addons that chang nits directly without modifications.
20140417 16:38:11< gfgtdf> units
20140417 16:38:36< aquileia> gfgtdf: It was just an idea, not necessarily a good one
20140417 16:38:41< Kevin_Xi> aquileia: I see, thank you
20140417 16:38:57-!- Kevin_Xi [~kevin@223.72.182.158] has quit [Quit: Zzz]
20140417 16:43:29-!- Sulfur [~Miranda@p5B327131.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140417 16:47:27-!- Aishiko_laptop [~unknown@198.85.71.253] has quit [Ping timeout: 265 seconds]
20140417 16:48:32< gfgtdf> Soliton: i just wasn't happy with the [random] name because it was also used for things where random was not involved like unit chekcsums when recalling. https://github.com/wesnoth/wesnoth/blob/c0435769bd0d4231aabdc505ee7017c959dd8fef/src/actions/create.cpp#L768
20140417 16:49:12< gfgtdf> an itfelt wrong to call a function named set/get_random_results
20140417 16:49:16< gfgtdf> for that
20140417 16:57:09< gfgtdf> Soliton: do you think [result] inside of [chekup] would be better ?
20140417 16:57:28< gfgtdf> instead of  [checkup] inside of [checkup]
20140417 17:04:13-!- Bodhi-Baum [~Bodhi@dslb-084-063-051-031.pools.arcor-ip.net] has joined #wesnoth-dev
20140417 17:04:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140417 17:14:13-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has quit [Quit: Page closed]
20140417 17:21:05-!- Kexoth [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140417 17:21:41-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 17:26:16-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 258 seconds]
20140417 17:34:39-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20140417 17:34:39-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20140417 17:34:39-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140417 17:35:08< mordante> servus
20140417 17:41:59< mordante> Aishiko, have you figured out why your code crashes?
20140417 17:44:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140417 17:44:32< mordante> aquileia reverting 04eea8963 won't work since once we move to SDL2 it will still be broken
20140417 17:45:09< mordante> aquileia since it's trunk only I'd rather look at a proper fix
20140417 17:46:35< cib0> Do we have a "commits must compile" policy? I'm bisecting and I'm having to skip a lot of commits because they don't compile. =/
20140417 17:46:49< mordante> cib0, yes we have
20140417 17:47:00-!- ancestral [~ancestral@17.114.44.242] has quit [Quit: ancestral]
20140417 17:48:05< mordante> cib0, but it can be files are missing for your project file
20140417 17:48:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 17:50:27-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 17:50:27-!- ancestral [~ancestral@17.114.44.242] has quit [Client Quit]
20140417 17:51:26-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 17:52:15< cib0> Now that I think about it, I only did make clean, didn't re-run cmake..
20140417 17:52:16-!- sachith500 [~kvirc@112.135.67.165] has joined #wesnoth-dev
20140417 17:53:39-!- ancestral [~ancestral@17.114.44.242] has quit [Client Quit]
20140417 17:54:55< mordante> aquileia I see the image and what's wrong, but don't understand the rest of your remarks
20140417 17:54:56-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has joined #wesnoth-dev
20140417 17:55:26< aquileia> mordante: already fixed
20140417 17:55:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140417 17:56:04< mordante> aquileia, what's fixed?
20140417 17:56:20< aquileia> The resolution selection dialog
20140417 17:56:37< aquileia> The list box issue is still there, though
20140417 17:56:56< mordante> aquileia, how is it fixed by reverting?
20140417 17:57:14< aquileia> No, a proper fix like you wanted
20140417 17:57:58< mordante> ok cool
20140417 17:58:00-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 17:58:59< aquileia> like AI put it: <AI0867> the standard "using the index from a filtered list on the unfiltered list" bug
20140417 17:59:44< aquileia> I just moved applied the filter before creating the list
20140417 18:05:56-!- irker612 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140417 18:08:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 18:09:17-!- Bodhi-Baum [~Bodhi@dslb-084-063-051-031.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140417 18:10:54-!- ancestral [~ancestral@17.114.44.242] has quit [Quit: ancestral]
20140417 18:11:09< aquileia> mordante: Is src/widgets/menu_style.cpp relevant for GUI2?
20140417 18:21:33< mordante> aquileia, will look later this evening, working on some GSoC stuff
20140417 18:30:03-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 18:34:18-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 18:36:36-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has joined #wesnoth-dev
20140417 18:36:37-!- c74d3a4 is now known as c74d
20140417 18:39:06-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 265 seconds]
20140417 18:39:09< cib0> Huh, apparently compiling with gcc is faster than with clang.. Strange.
20140417 18:40:18< iceiceice> cib0: i think you might be the only one who gets that :p
20140417 18:40:35< iceiceice> for me and for the travis builds it seems about 2-3 times faster with clang
20140417 18:40:48< iceiceice> and for some others recently
20140417 18:41:05< iceiceice> aquileia: about compressing animations,
20140417 18:41:08< cib0> Yeah, clang should be faster.. Wonder if my clang install is messed up somehow.
20140417 18:41:36< iceiceice> so, what are you hoping to save by not outputting the animations?
20140417 18:41:48< iceiceice> *comrpessing units
20140417 18:42:09< iceiceice> if you are hoping to improve size of save files / performance in transmitting things over the network,
20140417 18:42:15< iceiceice> i dont think it will improve much,
20140417 18:43:03< iceiceice> my guess is that for each unit type that you have, you will essentially only write the animations for it once no matter how many of those units you have, because of gzip / bzip
20140417 18:43:15< iceiceice> the size of the [replay] tag usually seems to dominate 
20140417 18:43:34< iceiceice> i guess it makes the save files a bit cleaner and easier to read by hand if you dont have all the extra stuff,
20140417 18:43:40< iceiceice> but i dont know what other benefit there would be
20140417 18:43:58< cib0> I'd like that, actually, but that's because I debug using savefiles a lot..
20140417 18:44:15< iceiceice> heh, yeah its definitely a pain...
20140417 18:45:52< aquileia> iceiceice: Ok, if readability isn't important it's not too useful
20140417 18:46:03< aquileia> I agree
20140417 18:46:05< cib0> It's generally confusing why you'd ever store any "flavor" stuff that hasn't changed from the base type. This includes stuff like desc.
20140417 18:46:38< iceiceice> thats true
20140417 18:46:44< cib0> It also matters for save compatability, but I don't know how much value is placed on that.
20140417 18:46:47< iceiceice> maybe could instead store like a "diff" from the default config
20140417 18:48:00< iceiceice> fwiw there are tricks you can do to make reading configs easier,
20140417 18:48:17< iceiceice> i guess some people said there are text editors that will let you click to collapse tags,
20140417 18:48:44< iceiceice> i used a script once to convert [,] in wml to <,> so you can give to an xml parser,
20140417 18:49:14< iceiceice> but i guess when you are just printing configs to std::err its kind of a pain to do those things
20140417 18:49:43< cib0> Yeah if it's *only* about readability it'd be easier to just write a script that strips the clutter.
20140417 18:49:54-!- Guest3906 [~8680@2002:4404:712c:0:355c:36eb:472a:5351] has quit [Quit: leaving]
20140417 18:50:20-!- _8680_ [~8680@2002:4404:712c:0:38db:e821:4b7b:cb19] has joined #wesnoth-dev
20140417 18:53:57< aquileia> iceiceice: The reason I propagated [base_unit] is that it worked to manually change that in a savefile... the only thing that would have to be changed is unit::write
20140417 18:58:17-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has quit []
20140417 18:58:23< aquileia> mordante: The listbox bug could be solved by  a) overlaying the images and saving the result   b) adding an option to show_dialog.cpp dialog_frame::draw_border
20140417 18:58:29< cib0> Is there a way to tell cmake not to do the update-mo target?
20140417 18:58:36< aquileia> a) seems easier
20140417 18:59:28< aquileia> mordante: GSoC is more important, no need to answer today
20140417 19:00:25-!- ancestral is now known as ancestral-lunch
20140417 19:07:09< Dugi> ancestral-lunch: Bon appétit.
20140417 19:08:14-!- sachith500 [~kvirc@112.135.67.165] has quit [Ping timeout: 258 seconds]
20140417 19:09:43< Aishiko> mordante, I've not I've got a list of what is not the cause but I've not found the reason yet
20140417 19:12:10< gfgtdf> iceiceice: is there a reason for what you do with LOG_MP in  43603e0568d436b3e6351a733a9a304194525006 ? 
20140417 19:12:51< iceiceice> :O
20140417 19:13:04< iceiceice> i think that was an error that slipped past me when i rebased
20140417 19:13:48< Aishiko> I'm thinking I'm not handling the return right as it fails at that line of code, any print statements within the function never fire
20140417 19:17:34< mordante> Aishiko, have a good look at the code and you can find the first reason for the crash
20140417 19:18:17< mordante> also Aishiko do you know why using »using namespace std;« in a header is a bad idea?
20140417 19:18:19< Aishiko> and changing it to a void and passing by ref didn't work, So now I'm going to take a systematic approach to the functions and what I can fine
20140417 19:18:39< mordante> what debugger do you use?
20140417 19:18:45< Aishiko> because it draws in a lot of packages and makes it larger
20140417 19:19:02< iceiceice> gfgtdf: thx for catching, i will try to fix soon
20140417 19:19:27< Aishiko> mordante, I'm using gcc from within codeblocks
20140417 19:19:35< mordante> also using gdb?
20140417 19:20:14< mordante> the using doesn't pull in packages, but it does pollute the global namespace with several new names
20140417 19:20:28< cib0> codeblocks has a graphical debugger that uses gdb as backend.
20140417 19:20:28-!- ancestral-lunch [~ancestral@17.114.44.242] has quit [Quit: ancestral-lunch]
20140417 19:20:34< mordante> where did you learn about the »using namespace std;« ?
20140417 19:20:37< mordante> thanks cib0 
20140417 19:21:19< mordante> aquileia, true, but I also like to answer some of your questions ;-)
20140417 19:21:34< Aishiko> mordante, mostly self taught none of the classes I had covered optimizing only making it work
20140417 19:22:10< aquileia> mordante: I'll have a) ready in a few minutes
20140417 19:22:17< Aishiko> mordante, yes gdb is one of the available ones, but no more useful in the error messages then any of the others
20140417 19:22:29< aquileia> Then you can say if it's enough
20140417 19:22:53< mordante> Aishiko, best unlearn that part ;-) I know almost every example on the Internet uses it
20140417 19:23:19< mordante> Aishiko, it's nice for short examples, but horrible for production code
20140417 19:23:35< mordante> Aishiko, can you post a backtrace of the crash?
20140417 19:25:55< mordante> aquileia, in general the code in widgets is not relevant for GUI2, I used files over there get the images to be used in GUI2
20140417 19:26:01< Aishiko> mordante, its not actually giving me a backtrace, however I think I know where it is failing the for statement is wrong
20140417 19:26:10< mordante> aquileia, (I was right to expect it to be a trick question ;-) )
20140417 19:26:41< mordante> Aishiko, maybe cib0 knows how to get a backtrace in codeblocks
20140417 19:26:57< Aishiko> cib0, if you know I'm all ears
20140417 19:27:08< cib0> Okay, I did a make clean and re-ran cmake, this definitely doesn't compile. http://pastebin.com/raw.php?i=iKwAqNy5
20140417 19:27:35< aquileia> mordante: No, it was to decide whether it was widgets/menu_style or src/show_dialog
20140417 19:27:40< cib0> Ugh it's been ages, but there should be a window you can enable..
20140417 19:31:36< mordante> aquileia, the macros for the borders are in data/gui/default/macros/_initial.cfg
20140417 19:31:56< cib0> Aishiko: Yep, Debugging -> Debugging Windows -> Call Stack
20140417 19:32:18< aquileia> mordante: http://imagebin.org/306194
20140417 19:33:11< mordante> aquileia, btw show_dialog also sounds like GUI1
20140417 19:33:17< aquileia> no code changes
20140417 19:33:34< mordante> what did you change?
20140417 19:33:36-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140417 19:34:45< Aishiko> cib0, is it supposed to do a pop up window or is it a tab at the bottom of the IDE?
20140417 19:34:56< AI0867> aquileia: well, that tells me that there's definitely some sort of corruption going on in the long-lived objects. The type field gets clobbered on windows, probably after it has been freed. Nothing of the like happens on my machine though
20140417 19:35:45< gfgtdf> cib0: that eror was most likeley casued by me
20140417 19:35:51< AI0867> the strange bits are that you have a few clobbered RWops objects and then some valid ones
20140417 19:35:58< cib0> It does a popup window for me, but you can also move it into a tab. Codeblocks is flexible like that.
20140417 19:36:16< aquileia> mordante: the images themselves
20140417 19:36:43< cib0> gfgtdf: Yeah, the bisect definitely lands in a commit range with your name on it, I'll send you a friendly bug report later when I've got it pinned down. =P
20140417 19:37:00< gfgtdf> cib0: a bug report about what ?
20140417 19:38:05< cib0> I don't have a simple test case yet, but basically in my campaign triggering a lua function from a context menu kills the recall list once the scenario ends.
20140417 19:39:18< gfgtdf> cib0: do you use needs_select=yes ?
20140417 19:39:36< mordante> cib0, the current head compiles for me, or are you bi-secting?
20140417 19:39:48 * cib0 is bi-secting.
20140417 19:40:09< cib0> gfgtdf, not explicitly, no.
20140417 19:40:14< gfgtdf> hm ok
20140417 19:40:30< mordante> ah yes then I guess you have to manually pick a working commit, but all committed code should compile
20140417 19:41:03< mordante> aquileia, ah ok, maybe somebody changed the image and broke them that way
20140417 19:42:22< Aishiko> I think I figured out why I wasn't getting any sort of a backtrace
20140417 19:42:36< cib0> Yeah, I was asking earlier specifically about not breaking compilation even in local commits. I guess that's a new thing to worry about with git compared to svn.
20140417 19:43:20< mordante> nice Aishiko I look forward to your backtrace
20140417 19:43:33< aquileia> mordante: The current images were intended to be overlaid, I did that manually to fix it
20140417 19:44:16< mordante> cib0, local commits should be treated like real svn commits in every way
20140417 19:44:48< cib0> OK, good.
20140417 19:46:40< mordante> but I don't know whether everybody realises that part ;-)
20140417 19:46:49< cib0> Heheh.
20140417 19:49:38< cib0> Speaking of compilation issues, does wesnoth have continuous integration?
20140417 19:51:03< mordante> yes we have, but I don't know whether is compiles every change or just the whole change set
20140417 19:51:49< Aishiko> mine only changes the ones that changed and anything that depends on them, at least that is what it looked like to me
20140417 19:52:18< mordante> Aishiko, do you have a backtrace?
20140417 19:56:02-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140417 19:56:10< cib0> Aishiko: Does your debugger actually stop anywhere? I remember getting confused once because my breakpoint wouldn't be hit, only later realized there was an infinite loop that got the program stuck earlier in the function.
20140417 19:56:51< mordante> the program results in a segfault, so I assume it stops there
20140417 19:58:01< Aishiko> cib0, no the debugger currently remains a blank window I've figured out that at last 2 of the dependant functions are causing issues
20140417 19:58:39< mordante> Aishiko, I'm about to leave, could you tell me what you discovered thusfar
20140417 19:59:07< mordante> Aishiko, I really like to know what you found out, before I tell you how to resolve the first problems
20140417 19:59:36< Aishiko> I've discovered so far that the set_pixel and get_pixel are causing the issue, I'm thinking that it has to do with how I'm handling the pointers
20140417 20:00:58< Aishiko> I think that I need to reorder the arguements/prarms so that all the ref are at the beginning as a start
20140417 20:01:13< mordante> what's the surface you send to get_sprite_locations according to your debugger?
20140417 20:02:26< Aishiko> mordante, its not showing me that
20140417 20:03:18< Aishiko> is it because I'm trying to use a png and should be sending a bmp?
20140417 20:03:39< mordante> do you know what the value of the png is?
20140417 20:05:43-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 20:05:54< Aishiko> no, the backtrace has not yet given me anything to work with, I'm assuming since you'r bringing that up its either not loading correctly or not at all
20140417 20:05:57< ancestral> Dugi: Thanks. It was a good bagel sandwich :)
20140417 20:08:00< mordante> Aishiko, good guess the png0 is not a BMP file and can't be loaded that way
20140417 20:08:36< mordante> Aishiko, do you know why it crashed instead of giving the »Unable to load png« error message?
20140417 20:09:10< Aishiko> I'd love to, I tried using the SDL_Image but I wasn't sure if it was available in 1.12
20140417 20:09:20< mordante> Aishiko, you need to include the #include <SDL/SDL_image.h> header and link the SDL_image library
20140417 20:10:13< Aishiko> I wish that info was included in the SDL explaintion page, I guess they just assumed we would all know to add it
20140417 20:10:17< mordante> it is, we use it to load png's »SDL_Surface* png0 = IMG_Load("test_image0.png");« would load the png properly
20140417 20:10:54< mordante> Aishiko, when you have questions please don't be afraid to ask!
20140417 20:11:38-!- ancestral [~ancestral@17.114.44.242] has quit [Quit: ancestral]
20140417 20:11:53< mordante> Aishiko, we're here to help and guide you, GSoC is not about students trying to muddle along and hope to find enlightenment by magical means
20140417 20:11:55-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 20:12:39< Aishiko> I guess I need learn to ask more at the beginning when Looking for answers, but I've been sort of taught to look for the answers myself and then ask if I'm still having issues
20140417 20:13:22-!- lipkab [~lipkab@apn-130-43-216-247.vodafone.hu] has joined #wesnoth-dev
20140417 20:13:50< lipkab> Hi mordante.
20140417 20:14:07< Aishiko> Ask more often, got it.
20140417 20:14:11< lipkab> Can we talk about my work schedule now?
20140417 20:14:14< mordante> being able to find the answers yourself is a good trade, but make sure you use all resources available including us
20140417 20:14:56< mordante> Aishiko, found out why it doesn't warn?
20140417 20:15:12< Aishiko> http://wiki.libsdl.org is where I'm getting reference material but it is all SDL2.0
20140417 20:15:38< Aishiko> mordante, yes because I my copy of codeblocks was lacking some flags set, I'm fixing that now
20140417 20:17:06< mordante> Aishiko, I'm not aware of 1.2 documentation except for the header files of SDL
20140417 20:18:23< mordante> lipkab, unfortunately I'm about to leave.
20140417 20:18:38< mordante> lipkab, For your information the state of your work schedule will not influence whether or not we select you as a GSoC student
20140417 20:19:13< lipkab> mordante: Ok, thanks.
20140417 20:21:44< mordante> Aishiko, I'm leaving now please let me know in the logs why the warning didn't show up
20140417 20:21:56< Aishiko> mordante, thank you sorry, we're drummed into us that the internet has the most upto date information, that they never tell us to check the header files, infact they have never even mentioned them, must be because I'm not at a university
20140417 20:22:18< Aishiko> mordante, will do 
20140417 20:22:31-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 20:23:00< mordante> Aishiko, the amount of documentation in header files varies from project to project
20140417 20:23:08< mordante> lipkab, you're welcome
20140417 20:23:25< Aishiko> I'm used to there not being much 
20140417 20:24:23< Aishiko> but then that project was sparse on all documentation
20140417 20:26:46< mordante> it really depends on the project and in a project it can also depend a lot on the author
20140417 20:26:49< aquileia> stupid question: why does 'git commit' abort with 'empty commit message' before I can type anything?
20140417 20:27:15-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140417 20:27:25< mordante> the amount of comment in Wesnoth varies a lot
20140417 20:27:52< Aishiko> mordante, they took an attitude of the code is self-explanatory, comments are not needed and patches with "excessive" commenting would be rejected
20140417 20:28:41< mordante> I know that attitude and it's often wrong
20140417 20:29:04< Aishiko> frustrated me to no end trying to figure out what was going on
20140417 20:29:08< mordante> there can be excessive comment, but that doesn't happen often
20140417 20:29:45< Aishiko> "If you need a comment to explain how and why your code is doing something, you've got bad code."
20140417 20:30:04-!- justinzane [~justinzan@host-12-172-184-180.nctv.com] has quit [Ping timeout: 240 seconds]
20140417 20:30:13< Aishiko> dangerous position to take and makes maintaining said code harder for new people
20140417 20:30:58< mordante> yeah that quote belongs to that attitude
20140417 20:31:02-!- ancestral [~ancestral@17.114.44.242] has quit [Quit: ancestral]
20140417 20:31:33< mordante> to code should normally explain the »how« part
20140417 20:31:47< mordante> but comment is really needed for the »why« part
20140417 20:32:08< Aishiko> comments to expl.... yeah that's the thought I had over the >>how<<
20140417 20:33:20< mordante> also a function like »foo(tx begin, tx end);« will probably do something with a range
20140417 20:33:46< mordante> but is it an open, half open or closed range, that can't be deducted
20140417 20:34:05-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140417 20:34:31< mordante> if the code is C++ code I expect [begin, end) but still a guess
20140417 20:35:01-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 20:35:48< aquileia> https://github.com/aquileia/wesnoth/tree/border_fix
20140417 20:36:04< mordante> but I'm off now, bye
20140417 20:36:23< Aishiko> like my comments (which I now think were not used enough) to explain why in the recall dialog we were using the magic number of -1 so that the next person to come along doesn't have to go looking in the unit or unit_types files
20140417 20:36:28< Aishiko> bye mordante 
20140417 20:37:27< mordante> Aishiko, then give a good example of proper comment usage in your patch ;-)
20140417 20:37:34< mordante> I look forward to it
20140417 20:37:55-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140417 20:40:54< gfgtdf> cib0: i just took a loke at the code ad it seems like menu items could fire an additional select event now, idk whether that can be realted to your bug 
20140417 20:41:05< gfgtdf> in any case it should be fixed
20140417 20:47:35-!- ancestral [~ancestral@17.114.44.242] has quit [Quit: ancestral]
20140417 20:48:10-!- lipkab [~lipkab@apn-130-43-216-247.vodafone.hu] has quit [Ping timeout: 276 seconds]
20140417 20:48:18-!- lipkab [~lipkab@apn-130-43-216-247.vodafone.hu] has joined #wesnoth-dev
20140417 20:49:04-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 20:58:46< aquileia> is a tiny graphical fix (http://imagebin.org/306194) worth an entry in players_changelog?
20140417 20:59:26< happygrue> no
20140417 20:59:55< aquileia> ok
20140417 21:00:44< happygrue> basically, if the fix is probably only interesting to the kind of person who would already read the changelog over players changelog, then don't put it in the players changelog - keep the latter short and sweet.
20140417 21:01:12< happygrue> (IMO of course)... ;)
20140417 21:02:16< aquileia> well, it affects every GUI2 listbox, and there are plenty of these
20140417 21:02:32< aquileia> but - less work for me, I like it
20140417 21:06:36-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140417 21:09:10< aquileia> Could someone apply https://github.com/aquileia/wesnoth/tree/border_fix & https://github.com/aquileia/wesnoth/tree/border_fix_12 , please?
20140417 21:13:02-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140417 21:18:48-!- neXyon [~neXyon@88-117-21-81.adsl.highway.telekom.at] has quit [Quit: bye]
20140417 21:21:45-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140417 21:23:36-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140417 21:24:40-!- ancestral [~ancestral@17.114.44.242] has quit [Quit: ancestral]
20140417 21:26:49-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 265 seconds]
20140417 21:28:56-!- gfgtdf_ [~chatzilla@e177166210.adsl.alicedsl.de] has joined #wesnoth-dev
20140417 21:30:50-!- gfgtdf [~chatzilla@f054140201.adsl.alicedsl.de] has quit [Ping timeout: 258 seconds]
20140417 21:30:51-!- gfgtdf_ is now known as gfgtdf
20140417 21:35:03< aquileia> Dugi: As to http://r.wesnoth.org/p569526 ... is gameplay_entry["time"] the playtime in the database or the time to be added to it?
20140417 21:40:28< Dugi> aquileia: gameplay_entry["time"] is the time fromt the database.
20140417 21:40:36< aquileia> IIUC the problem 6 iceiceice had was this line: gameplay_entry["time"] = (epoch - gameplay_entry["timestamp"].to_int()) / 30;
20140417 21:41:54< aquileia> In case someone seems to cheat, you pretty much punish the author because you reset his gameplay_entry["time"]
20140417 21:42:14< aquileia> you probably meant +=, right?
20140417 21:43:21< Dugi> aquileia: Yes, you're right.
20140417 21:43:47< aquileia> and you need the string casts as well, I think
20140417 22:08:50-!- Sulfur [~Miranda@p5B327131.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140417 22:10:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140417 22:18:59-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 22:21:06-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has quit [Quit: Page closed]
20140417 22:21:24-!- aquileia [6dc00d61@gateway/web/freenode/ip.109.192.13.97] has joined #wesnoth-dev
20140417 22:25:57< gfgtdf> cib0: do you have more information about that error?
20140417 22:29:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20140417 22:30:00-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140417 22:32:34-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140417 22:34:58-!- _8680_ [~8680@2002:4404:712c:0:38db:e821:4b7b:cb19] has quit [Ping timeout: 265 seconds]
20140417 22:35:27-!- _8680_ [~8680@2002:4404:712c:0:1854:850c:54be:ca99] has joined #wesnoth-dev
20140417 22:37:56-!- ancestral [~ancestral@17.114.44.242] has joined #wesnoth-dev
20140417 22:37:56-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140417 22:38:50-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 265 seconds]
20140417 22:40:33-!- mjs-de [~mjs-de@g228039218.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140417 22:40:55< aquileia> Could someone apply https://github.com/aquileia/wesnoth/tree/border_fix to master & https://github.com/aquileia/wesnoth/tree/border_fix_12 to 1.12, please?
20140417 22:44:32< iceiceice> aquileia: on it
20140417 22:45:00< aquileia> iceiceice: thanks again
20140417 22:45:21-!- irker233 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140417 22:45:21< irker233> wesnoth: aquileia wesnoth:master 965a2a5d1c55 / images/dialogs/ (8 files): Fix border of selected GUI2 elements http://git.io/JgP-Ow
20140417 22:45:58< irker233> wesnoth: aquileia wesnoth:1.12 5c3fb2e53859 / images/dialogs/ (8 files): Fix border of selected GUI2 elements http://git.io/FxdbCQ
20140417 22:46:00< irker233> wesnoth: aquileia wesnoth:1.12 a684466748b8 / changelog: Changelog entry for graphical fix http://git.io/Uos92Q
20140417 22:46:19< iceiceice> no problem
20140417 22:46:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140417 22:50:08-!- lipkab [~lipkab@apn-130-43-216-247.vodafone.hu] has quit [Read error: Connection reset by peer]
20140417 22:51:26-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140417 22:51:33-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 22:53:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140417 23:02:43-!- bagzie [~bag@85-76-130-162-nat.elisa-mobile.fi] has quit []
20140417 23:08:42< gfgtdf> is there a special reason why we don't allow to save replays when commands_disabled ?
20140417 23:11:52< gfgtdf> i propose enabling it even when commands_diabled, unlike save game which will lead to currupt snapshots when commands_disabled, replays are never invalid.
20140417 23:12:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20140417 23:12:48-!- Dugi [93fbd156@gateway/web/freenode/ip.147.251.209.86] has quit [Ping timeout: 240 seconds]
20140417 23:13:49-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140417 23:17:59-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140417 23:20:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140417 23:23:39< iceiceice> gfgtdf: thats an interesting idea
20140417 23:28:32< gfgtdf> iceiceice: the intention is, that for example when you are in situation where you have commands diabled and the game waits for a remote input, you could still save something.
20140417 23:29:55-!- travis-ci [~travis-ci@ec2-54-198-166-234.compute-1.amazonaws.com] has joined #wesnoth-dev
20140417 23:29:55< travis-ci> [travis-ci] wesnoth/wesnoth#2382 (master - 965a2a5 : aquileia): The build passed.
20140417 23:29:55< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/23244802
20140417 23:29:55-!- travis-ci [~travis-ci@ec2-54-198-166-234.compute-1.amazonaws.com] has left #wesnoth-dev []
20140417 23:30:47< iceiceice> hmm so if its easy to allow replays and there's no problem then yeah it sounds like a good idea
20140417 23:30:55< iceiceice> what kind of things can make the snapshot illegal?
20140417 23:31:04< iceiceice> is it just these sync operations that are supposed to be atomic?
20140417 23:31:14< iceiceice> ideally we would like,
20140417 23:31:44< iceiceice> make a backup of the gamestate whenever commands are disabled for example, 
20140417 23:31:49< iceiceice> and if they try to save then save that
20140417 23:31:59< iceiceice> and drop the backup when commands are enabled again
20140417 23:32:09< iceiceice> idk if that would actually work 
20140417 23:32:16< iceiceice> and its more work anyways than the replay thing it seems
20140417 23:32:53< gfgtdf> iceiceice: yes they are, saving in the middle would to wrong  replays, but also image a player would save during an attack, and in the save be made after 2 of 6 hit took place.  
20140417 23:33:10< iceiceice> hmm
20140417 23:33:25< gfgtdf> iceiceice: that i idea shoudl. not bee too hard to implement its i just don't know about the performans f serializing teh gamestate
20140417 23:33:30< iceiceice> i guess i would want for the save to be before the attack
20140417 23:33:32< gfgtdf> performance
20140417 23:33:43< iceiceice> yeah idk either
20140417 23:33:47< iceiceice> err
20140417 23:33:51< iceiceice> i guess i tried to do it once :)
20140417 23:34:57< iceiceice> when i worked on the monte carlo simulations ai i did some kind of backups of game objects
20140417 23:35:02< gfgtdf> iceiceice: with replays you chould still generate the gamestate with replaying and then save from the replay, 
20140417 23:35:04< iceiceice> i dont think it was noticeably slow but i dont remember
20140417 23:35:09< iceiceice> i didnt profile it carefully
20140417 23:35:11< gfgtdf> alsought it's not tha t user friendly
20140417 23:35:27< iceiceice> still its good
20140417 23:35:38< iceiceice> there are users who do that sometimes if they get a bugged gamestate some other way
20140417 23:35:57< gfgtdf> iceiceice: taking the snapshot is done with play_controller::to_config
20140417 23:36:08< iceiceice> y
20140417 23:36:12< iceiceice> you dont need to make a snap shot though,
20140417 23:36:19< iceiceice> you can just make a copy of the play_controller i guess?
20140417 23:36:30< iceiceice> in my testing thing i made backup copies of unit_map
20140417 23:36:39< iceiceice> that didnt seem to cause any noticeable performance hit
20140417 23:37:01< gfgtdf> i wouldn't replay on that beeing able to copy play controller without kowing more:/ 
20140417 23:37:17< iceiceice> y its complicated for sure
20140417 23:37:31< iceiceice> the save replay thing sounds like a good idea
20140417 23:37:43< gfgtdf> iceiceice: it might alse depend on which scenaro you play, sure  in a 1vs1 mpmap default, is much easier that complicated umc,
20140417 23:37:52< iceiceice> yeah, its true
20140417 23:40:30< iceiceice> bbl
20140417 23:40:31-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140417 23:48:52-!- Aishiko_laptop [~unknown@2606:a000:bcc1:2b00:226:5eff:fe65:125c] has joined #wesnoth-dev
20140417 23:52:12< gfgtdf> do we have an equivelent for the normal assert ? meaning a assert that isnt present in release builds ?
20140417 23:54:12< gfgtdf> gfgtdf: that isn't present in the offical build, for example becasue it asserts something from which i think it should be true, but i also don't see a reason why it coudl break something, to i woudn't like to have an error message in the offical build ?
20140417 23:54:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
--- Log closed Fri Apr 18 00:00:08 2014