--- Log opened Sat May 10 00:00:51 2014 20140510 00:11:46-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20140510 00:15:32-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140510 00:15:48-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140510 00:20:29-!- _8680_ [~8680@2002:4404:712c:0:dfe:cece:f050:751b] has quit [Ping timeout: 246 seconds] 20140510 00:21:20-!- _8680_ [~8680@2002:4404:712c:0:488b:5d7a:737a:4ed1] has joined #wesnoth-dev 20140510 00:25:43< irker065> wesnoth: fendrin wesnoth:master 00954d4c7630 / src/addon/ (info.cpp info.hpp validation.cpp validation.hpp): Synced addon_type_strings wih the enumeration, missing initializers. http://git.io/RKSX2A 20140510 00:25:56< fabi> ^ shadowm 20140510 00:28:42-!- _8680_ [~8680@2002:4404:712c:0:488b:5d7a:737a:4ed1] has quit [Ping timeout: 240 seconds] 20140510 00:29:39-!- _8680_ [~8680@2002:4404:712c:0:85eb:57ba:1497:50dd] has joined #wesnoth-dev 20140510 00:45:21-!- gfgtdf [~chatzilla@f054170229.adsl.alicedsl.de] has joined #wesnoth-dev 20140510 00:55:00< gfgtdf> is there a reason why bad_lexical_cast (https://github.com/wesnoth/wesnoth/blob/master/src/util.hpp#L79) doesnt't devide from std::exception or game:error ? 20140510 01:07:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140510 01:16:48< AI0867> gfgtdf: probably not? 20140510 01:17:28< shadowm> fabi: Rebuilt and restarted again. 20140510 01:17:45< gfgtdf> AI0867: ok, do you think deving from which std::exception or game:error is better? 20140510 01:23:20-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 276 seconds] 20140510 01:27:58< AI0867> invalid_utf8_exception and game::error itself derive from std::exception 20140510 01:28:05< AI0867> everything else seems to derive from game::error 20140510 01:28:09< AI0867> make of that what you will 20140510 01:28:41< AI0867> (the difference is probably including or "exceptions.hpp" 20140510 01:28:43< AI0867> ) 20140510 01:36:41-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140510 01:36:57-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20140510 01:43:51< gfgtdf> AI0867: i'll try to find find more occurences of objects thworn that don't devide from std::exception. 20140510 01:45:40-!- trewe [~trewe@63.47.103.87.rev.vodafone.pt] has quit [Quit: quit] 20140510 01:50:06< shadowm> For simplicity I've opted to throw very bland (read: empty) structs in my code in some cases, but those are never intended to unwind the stack too far. 20140510 01:52:14< gfgtdf> shadowm: ye i found some structs that are defined in the cpp files. I assume you mean those? 20140510 01:52:17< shadowm> So if you ever see an uncaught instance of those vanilla structs it means something changed. 20140510 01:53:15< shadowm> Shrug, it shouldn't be too hard to tell what's my code and what isn't. 20140510 01:54:18< shadowm> It tends to have my name plastered all over it. 20140510 01:54:47< shadowm> And have an overall quaint feel to it. 20140510 01:56:15< shadowm> In general, if I'm trying to signal a caller that something went wrong in a recoverable way (UI-wise, usually), I'm probably going to use something with little overhead that's not too hard to write. 20140510 01:57:23-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds] 20140510 02:00:13-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140510 02:00:33< gfgtdf> shadowm: my original intention as to fix "lua caught unknown exception" occurances, and since i know dotn know much about the circumstances, my plan was to make everying that gets thown and is not obviously for intetnal use, devide frm stgd::exception. 20140510 02:02:29< shadowm> Well, I'm rather sure I've not applied that methodology to code that runs in a less predictable context like that. :p 20140510 02:04:14< shadowm> Of course in such a context you'd want to have as much information available as possible. 20140510 02:11:25-!- gfgtdf [~chatzilla@f054170229.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 28.0/20140314220517]] 20140510 02:36:31-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140510 02:38:42-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg] 20140510 02:48:37-!- Ivanovic_ [~ivanovic@frnk-5f74c7ec.pool.mediaWays.net] has joined #wesnoth-dev 20140510 02:51:59-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 255 seconds] 20140510 02:52:31-!- Ivanovic_ is now known as Ivanovic 20140510 03:06:24< irker065> wesnoth: Chris Beck wesnoth:master 851519cd0781 / data/test/macros/wml_unit_test_macros.cfg: enable linger mode to unit test macros ASSERT, RETURN http://git.io/OimLEA 20140510 03:19:11-!- Ivanovic [~ivanovic@frnk-5f74c7ec.pool.mediaWays.net] has quit [Changing host] 20140510 03:19:11-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140510 03:28:07-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140510 03:37:38< irker065> wesnoth: Chris Beck wesnoth:master c611481e260b / data/test/scenarios/readme.txt: fixup readme.txt http://git.io/sDXaDg 20140510 04:12:42-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds] 20140510 04:21:25-!- TC01_ is now known as TC01 20140510 05:13:05-!- sachith500 [~kvirc@112.134.116.234] has joined #wesnoth-dev 20140510 05:49:09-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140510 05:53:31-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection] 20140510 06:27:13-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20140510 06:31:01-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has quit [Quit: Leaving] 20140510 06:37:40-!- irker065 [~irker@109.237.218.218] has quit [Quit: transmission timeout] 20140510 06:53:11-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 250 seconds] 20140510 06:53:25-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20140510 07:05:21-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20140510 07:07:35-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140510 07:12:42-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 265 seconds] 20140510 07:22:44-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140510 07:29:31-!- sachith500|2 [~kvirc@112.134.66.83] has joined #wesnoth-dev 20140510 07:32:31-!- sachith500 [~kvirc@112.134.116.234] has quit [Ping timeout: 265 seconds] 20140510 07:40:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20140510 07:53:29-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140510 07:57:38-!- ancestral [~ancestral@12.23.74.29] has quit [Ping timeout: 240 seconds] 20140510 08:07:19-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20140510 08:15:08-!- sachith500|2 [~kvirc@112.134.66.83] has quit [Ping timeout: 240 seconds] 20140510 08:30:11-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev 20140510 08:30:11-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host] 20140510 08:30:11-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20140510 08:30:27< mordante> servus 20140510 08:32:21-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20140510 08:33:08< Coffee_irc> hi mordante 20140510 08:33:35< Coffee_irc> just out of interest, what is happening with Aishiko's spritesheet project? 20140510 08:34:00< mordante> hi Coffee_irc 20140510 08:34:25< mordante> Coffee_irc, what do you exactly want to know? 20140510 08:34:48< Coffee_irc> if you guys are making a spec up for this? 20140510 08:36:32-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving] 20140510 08:37:16< mordante> I haven't spoken with Aishiko for a while, but GSoC hasn't officially started 20140510 08:37:23< Coffee_irc> oh, ok 20140510 08:37:35< mordante> FYI happygrue is Aishiko's mentor so he might know more 20140510 08:38:16< mordante> also if you have input/questions best ask Aishiko directly 20140510 08:38:36< Coffee_irc> fair enough 20140510 08:39:10< Coffee_irc> I suppose I was just curious as to why it was a bit quiet with this, but if GSoC hasn't started it makes sense ;) 20140510 08:42:20< mordante> it starts on the 19th of May 20140510 08:48:12-!- sachith500|2 [~kvirc@112.134.66.83] has joined #wesnoth-dev 20140510 08:51:44< Coffee_irc> just wondering another thing more general 20140510 08:51:52< Coffee_irc> I sent a mail on the ML saying that I think that the next release for stable could be 1.12 release candidate 20140510 08:52:06< Coffee_irc> all the major bugs look to me to be fixed 20140510 08:53:05< Coffee_irc> I think Ivanovic said that the next release should be sometime this weekend 20140510 08:53:41< Coffee_irc> there are no more showstoppers are there? 20140510 09:02:10-!- mjs-de [~mjs-de@f048007194.adsl.alicedsl.de] has joined #wesnoth-dev 20140510 09:03:58< zookeeper> i guess that the newly added [disable] weapon special not working is not exactly a showstopper 20140510 09:22:10< Coffee_irc> zookeeper: need a hand with that bug? 20140510 09:22:50< zookeeper> well fabi said he'd take care of it, dunno if he'd mind if you did :p 20140510 09:23:07< Coffee_irc> I can't find a bug report for it 20140510 09:23:46< zookeeper> there's none (yet) 20140510 09:23:52< Coffee_irc> ... 20140510 09:24:07< zookeeper> for example: if i [disable] the unit's first attack, then in the attack dialog i pick the second attack (which is the only option...), the unit will attack using the first attack. 20140510 09:25:08-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 265 seconds] 20140510 09:26:21-!- cib_ [~cib@p5DC74C76.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140510 09:26:40< Coffee_irc> I'll look when it was added 20140510 09:27:48< Coffee_irc> looks like it was introduced in a4f6249627a1df6cf5f25d45e96ee0b657fb5eb2 20140510 09:30:25< Coffee_irc> ok, I think I see the problem 20140510 09:30:58< Coffee_irc> zookeeper: could you make a bug report? 20140510 09:31:37< Coffee_irc> in case any follow up needs to be done afterwards 20140510 09:32:51< zookeeper> sure 20140510 09:34:36-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140510 09:37:29< zookeeper> Coffee_irc, done, https://gna.org/bugs/index.php?22030 20140510 09:44:56-!- sachith500|2 [~kvirc@112.134.66.83] has quit [Read error: Connection reset by peer] 20140510 09:48:37-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140510 09:53:37-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has quit [Remote host closed the connection] 20140510 10:23:13-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20140510 10:24:50< AI0867> Coffee_irc: so the [disable] special was always broken for attacks that weren't the last? 20140510 10:25:02< Coffee_irc> AI0867: looks like it 20140510 10:25:25< Coffee_irc> I have reverted the HEAD of my local branch to the first commit a4f6249627a1df6cf5f25d45e96ee0b657fb5eb2 20140510 10:25:29< Coffee_irc> and it is not working also 20140510 10:25:29-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20140510 10:25:35< AI0867> well, the standard "using the filtered list's index as an index for the unfiltered list" bug strikes again 20140510 10:25:52< Coffee_irc> yeah 20140510 10:27:18< Coffee_irc> funnily enough I am trying to comment out all the disable features from that commit and it still disables the weapon 20140510 10:29:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140510 10:30:34< AI0867> - return defender_stats_->attack_num; 20140510 10:30:35< AI0867> + return defender_stats_ ? defender_stats_->attack_num : -1; 20140510 10:30:40< AI0867> I kind of wonder what this is about 20140510 10:30:44-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has joined #wesnoth-dev 20140510 10:30:58< AI0867> does the commit allow for the possibility that defender_stats_ is NULL when attacker_stats_ isn't? 20140510 10:31:18< AI0867> or is it a precaution? Because I think I caught all of those 20140510 10:32:07< Coffee_irc> that might be the thing that does it 20140510 10:32:31< Coffee_irc> all the other things from that commit don't really change much 20140510 10:32:34< AI0867> fabi: ^ 20140510 10:32:48< AI0867> nah, that line just prevents a segfault 20140510 10:33:05< AI0867> but only if a segfault is actually in danger of happening, which I doubt 20140510 10:33:30< Coffee_irc> I've gone one commit back and that is definitely the commit that causes the issus (and introduces the new feature) 20140510 10:33:39-!- Bodhi-Baum [~Bodhi@dslb-084-063-056-046.pools.arcor-ip.net] has joined #wesnoth-dev 20140510 10:40:48-!- Bodhi-Baum [~Bodhi@dslb-084-063-056-046.pools.arcor-ip.net] has quit [Quit: Verlassend] 20140510 10:50:35< AI0867> well, I may take a look at it late tomorrow, but if you can fix it before then, that'd be great. 20140510 10:51:27< Coffee_irc> AI0867: takes a while for my computer to compile the different versions 20140510 10:51:39< Coffee_irc> I made a mistake before when I thought something, because when I did a git recert it wiped out my shaman changes :P 20140510 10:51:55< Coffee_irc> this version of wesnoth still had an error preventing addons from loading for me 20140510 10:56:40-!- wesbot changed the topic of #wesnoth-dev to: 1.11.14 (1.12 beta 5) planned for "very soon" | string+feature freeze active on 1.12 | 243 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140510 11:03:31-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev 20140510 11:37:32-!- irker898 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140510 11:37:32< irker898> wesnoth: Mark de Wever wesnoth:master b67d0f428dfa / src/sdl/alpha.hpp: Update formatting. http://git.io/VeYlsw 20140510 11:37:32< irker898> wesnoth: Mark de Wever wesnoth:master 22c56b49c7ad / src/sdl/ (texture.cpp texture.hpp): Refactor the ttexture image loading constructor. http://git.io/TcS_sg 20140510 11:37:33< irker898> wesnoth: Mark de Wever wesnoth:master 0f6b1c12bc94 / src/sdl/ (texture.cpp texture.hpp window.cpp window.hpp): Add a texture constructor taking a SDL_Surface. http://git.io/az15bg 20140510 11:37:34< irker898> wesnoth: Mark de Wever wesnoth:master 8840a9f0f8b6 / src/sdl/ (texture.cpp texture.hpp window.cpp window.hpp): Add a texture constructor taking a surface. http://git.io/vjhdGA 20140510 11:37:35< irker898> wesnoth: Mark de Wever wesnoth:master 6edb01b228f9 / src/sdl/ (texture.cpp texture.hpp window.cpp window.hpp): Add a draw function for the window. http://git.io/ir2qhQ 20140510 11:37:36< irker898> wesnoth: Mark de Wever wesnoth:master d20c12019ba6 / src/sdl/ (window.cpp window.hpp): Add a clear function to the window. http://git.io/B7EcEQ 20140510 11:37:38< irker898> wesnoth: Mark de Wever wesnoth:master 525cd6ea425a / CMakeLists.txt src/CMakeLists.txt src/tools/sdl2/sdl2.cpp: Adds a basic version of the SDL2 test tool. http://git.io/tuA9bQ 20140510 11:37:40< irker898> wesnoth: Mark de Wever wesnoth:master 3fd618b7f1f6 / src/ (5 files in 2 dirs): Implement the window command. http://git.io/FApMIw 20140510 11:37:42< irker898> wesnoth: Mark de Wever wesnoth:master 3e4689b6986f / / (11 files in 4 dirs): Merge branch 'SDL2_test_tool' http://git.io/szLbbg 20140510 11:43:27-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140510 11:45:28< irker898> wesnoth: David Mikos wesnoth:master 9b1a223b3d36 / changelog src/mouse_events.cpp: Fix bug #22030: correct index of weapon special disable in attack GUI http://git.io/Fvqq8Q 20140510 11:49:40-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140510 11:50:10< Coffee_irc> I think that fixes it 20140510 11:55:24-!- Spoffy_ [~sailfish@genkt-056-009.t-mobile.co.uk] has joined #wesnoth-dev 20140510 11:55:39-!- Spoffy [~sailfish@152.78.175.8] has quit [Ping timeout: 250 seconds] 20140510 11:55:39< irker898> wesnoth: David Mikos wesnoth:1.12 796115114e0e / changelog src/mouse_events.cpp: Fix bug #22030: correct index of weapon special disable in attack GUI http://git.io/gcUS1g 20140510 11:56:03< Coffee_irc> sorry Ivanovic for the late commit after saying all is well, but this is a minor bug fix ;) 20140510 11:57:51< Coffee_irc> fabi: ^ I tried to be clear in my fix there for the bug https://gna.org/bugs/index.php?22030 20140510 11:58:21< Coffee_irc> hopefully that all makes sense 20140510 12:05:11-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 20140510 12:07:04< mordante> I'm off bye 20140510 12:07:44-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20140510 12:30:43-!- Spoffy [~sailfish@152.78.175.8] has joined #wesnoth-dev 20140510 12:31:42-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140510 12:33:23-!- Spoffy_ [~sailfish@genkt-056-009.t-mobile.co.uk] has quit [Ping timeout: 255 seconds] 20140510 12:57:18-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Ping timeout: 240 seconds] 20140510 12:58:19-!- Spoffy [~sailfish@152.78.175.8] has quit [Read error: Connection reset by peer] 20140510 13:07:47-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20140510 13:08:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140510 13:10:53< fabi> Coffee_irc: hi 20140510 13:12:17< fabi> Coffee_irc: I also noticed while playing a scenario that selecting another unit of mine was not possible in all cases. Nothing happens when clicking on the unit. I needed to deselect with right click before it was possible. 20140510 13:19:18-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has joined #wesnoth-dev 20140510 13:28:41-!- Bodhi-Baum [~Bodhi@dslb-084-063-056-046.pools.arcor-ip.net] has joined #wesnoth-dev 20140510 13:32:29-!- cib_ [~cib@p5DC74C76.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20140510 13:32:41< irker898> wesnoth: Andrius Silinskas wesnoth:1.12 df5598f29dd5 / changelog src/multiplayer_connect_engine.cpp: Remove "controller" attribute if it is now longer needed. http://git.io/ho1Xaw 20140510 13:33:00< irker898> wesnoth: Andrius Silinskas wesnoth:master 9eaeab285056 / changelog src/multiplayer_connect_engine.cpp: Remove "controller" attribute if it is now longer needed. http://git.io/Bft_JQ 20140510 13:37:20-!- Sulfur [~Miranda@p5B327EEF.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140510 13:43:36-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev 20140510 13:50:07-!- trewe [~trewe@2001:8a0:d13e:a401:626c:66ff:fe92:9b7c] has joined #wesnoth-dev 20140510 13:51:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140510 14:22:29< zookeeper> Coffee_irc, cool, i'll test the fix ASAP 20140510 14:33:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140510 14:42:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140510 14:47:33-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140510 14:48:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds] 20140510 15:04:12-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140510 15:07:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140510 15:32:51-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20140510 15:36:47-!- prkc [~negusnyul@catv-89-134-173-85.catv.broadband.hu] has joined #wesnoth-dev 20140510 15:37:04-!- prkc [~negusnyul@catv-89-134-173-85.catv.broadband.hu] has left #wesnoth-dev [] 20140510 15:56:56-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20140510 15:57:38-!- Sulfur [~Miranda@p5B327EEF.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20140510 15:59:58-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 240 seconds] 20140510 16:02:08-!- cib_ [~cib@p5DC74C76.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140510 16:37:18-!- Bodhi-Baum [~Bodhi@dslb-084-063-056-046.pools.arcor-ip.net] has quit [Quit: Verlassend] 20140510 16:56:40-!- wesbot changed the topic of #wesnoth-dev to: 1.11.14 (1.12 beta 5) planned for "very soon" | string+feature freeze active on 1.12 | 241 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140510 18:11:32-!- Upthorn [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Quit: brb] 20140510 18:11:51-!- Upthorn [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev 20140510 18:11:53-!- Upthorn [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Remote host closed the connection] 20140510 18:13:47-!- Upthorn [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev 20140510 18:14:23< Ivanovic> AI0867, Coffee_irc, fabi_, happygrue, iceiceice, loonycyborg, shadowm, Soliton, thunderstruck, zookeeper, everyone else who cares: ready for the next 1.12.0 beta? 20140510 18:14:37< happygrue> sure 20140510 18:14:39< iceiceice> sure 20140510 18:14:58-!- irker898 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20140510 18:20:28-!- irker079 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140510 18:20:28< irker079> wesnoth: Nils Kneuper wesnoth:1.12 bf6bbdc93f8c / / (124 files in 18 dirs): pot-update and regenerated doc files http://git.io/sSXzPg 20140510 18:20:28< irker079> wesnoth: Nils Kneuper wesnoth:1.12 c08149495914 / Doxyfile changelog players_changelog src/wesconfig.h: bump version to 1.11.14 http://git.io/bJbR1Q 20140510 18:35:31-!- Ivanovic changed the topic of #wesnoth-dev to: releasing 1.11.14 (1.12 beta 5) | string+feature freeze active on 1.12 | 241 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140510 18:37:33< irker079> wesnoth: Chris Beck wesnoth:master b56b34d2a179 / / (6 files in 2 dirs): add new wml tests script http://git.io/pJqNxg 20140510 18:37:35< irker079> wesnoth: Chris Beck wesnoth:master 0376e4a3e87a / / (14 files in 4 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/rFKctw 20140510 18:59:02-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20140510 18:59:16< irker079> wesnoth: ivanovic wesnoth: c08149495914 tagged as 1.11.14 20140510 19:00:15-!- Ivanovic changed the topic of #wesnoth-dev to: released 1.11.14 (1.12 beta 5), announcing "soon" | string+feature freeze active on 1.12 | 241 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140510 19:08:55-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving] 20140510 19:27:06-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140510 19:27:35-!- travis-ci [~travis-ci@ec2-54-198-29-194.compute-1.amazonaws.com] has joined #wesnoth-dev 20140510 19:27:35< travis-ci> [travis-ci] wesnoth/wesnoth#2622 (1.11.14 - c081494 : Nils Kneuper): The build passed. 20140510 19:27:35< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/24878470 20140510 19:27:35-!- travis-ci [~travis-ci@ec2-54-198-29-194.compute-1.amazonaws.com] has left #wesnoth-dev [] 20140510 19:27:42-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140510 19:32:41-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds] 20140510 20:01:36< Aishiko> EuroVision? 20140510 20:02:12< zookeeper> the worst and campiest song contest in the world? 20140510 20:03:04< Aishiko> no clue it was in a Global Notice I just got and I have no idea what it is other then a TV channel I assume since it said "Go watch Eurovision!" 20140510 20:03:06-!- _8680_ [~8680@2002:4404:712c:0:85eb:57ba:1497:50dd] has quit [Ping timeout: 240 seconds] 20140510 20:03:12< zookeeper> yep 20140510 20:04:30-!- _8680_ [~8680@2002:4404:712c:0:c58e:c9a0:8f02:1684] has joined #wesnoth-dev 20140510 20:04:42-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer] 20140510 20:05:32< prophile> http://www.eurovision.tv/ 20140510 20:08:39-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140510 20:10:22< irker079> wesnoth: Chris Beck wesnoth:master 07a165422785 / .travis.yml run_wml_tests wml_test_schedule: add unix timeout option to wml test script, enable empty_test http://git.io/me27BQ 20140510 20:21:47-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 252 seconds] 20140510 20:22:35< Ivanovic> Aishiko: this is a competition where the europeans select the worst singer of all their countries 20140510 20:25:49< Aishiko> Ivanovic, sounds like that idol show in the states 20140510 20:26:06< Ivanovic> Aishiko: those are there on a per country base in europe 20140510 20:26:20< Ivanovic> Aishiko: this is a competition like a european championship in being really bad 20140510 20:26:39< Ivanovic> as if all american idol winners had a competition among themselves 20140510 20:29:55-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140510 20:30:52-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood] 20140510 20:31:09-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev 20140510 20:31:09-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host] 20140510 20:31:09-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20140510 20:31:29< irker079> wesnoth: Chris Beck wesnoth:master 5b87baf1e469 / run_wml_tests wml_test_schedule: cleanup wml test script http://git.io/hVW4gA 20140510 20:36:09-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140510 20:37:46< irker079> wesnoth: Chris Beck wesnoth:master d560acb9f448 / run_wml_tests: fixup cleanup wml test script http://git.io/pz0_dQ 20140510 20:41:05-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds] 20140510 20:41:13-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer] 20140510 20:51:58-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140510 20:54:03-!- _8680_ [~8680@2002:4404:712c:0:c58e:c9a0:8f02:1684] has quit [Ping timeout: 252 seconds] 20140510 20:59:55-!- _8680_ [~8680@2002:4404:712c:0:c58e:c9a0:8f02:1684] has joined #wesnoth-dev 20140510 20:59:58-!- _8680_ is now known as Guest91835 20140510 21:04:49-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer] 20140510 21:15:32-!- cib_ [~cib@p5DC74C76.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20140510 21:18:35-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20140510 21:30:59-!- bumbadadabum is now known as Guest15600 20140510 21:46:28-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20140510 22:03:29-!- mjs-de [~mjs-de@f048007194.adsl.alicedsl.de] has quit [Remote host closed the connection] 20140510 22:12:49-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140510 22:25:07-!- gfgtdf [~chatzilla@f054129053.adsl.alicedsl.de] has joined #wesnoth-dev 20140510 22:36:20< gfgtdf> iceiceice: i saw you implemented a issue_attack_command and issue_move_command. Why not just allow a more generic do_replay which acepts the same tags as the replay and calls run_in_synced_context_if_not_already? 20140510 22:36:56-!- blarumyrran [~Bbbb123@wesnoth/artist/blarumyrran] has joined #wesnoth-dev 20140510 22:36:59< iceiceice> :) 20140510 22:37:03< iceiceice> that sounds much nicer than what i did 20140510 22:44:20< iceiceice> are the possible replay tags documented or would i have to document them in that case 20140510 22:46:18< gfgtdf> iceiceice: thereis a documentation in teh wiki but its a little outdated. 20140510 22:46:26< gfgtdf> http://wiki.wesnoth.org/ReplayWML 20140510 22:47:00< gfgtdf> iceiceice: i tihnk i updated most of it already but i forgot to press confirm 20140510 22:48:50< iceiceice> ah thats too bad 20140510 22:49:21< iceiceice> hmm so if i make a [do_replay] tag, will that tag be replay safe 20140510 22:49:47< iceiceice> i guess it wont itself be added to replay, it will just do what you said... 20140510 22:50:07< iceiceice> hmm also, 20140510 22:50:12< iceiceice> what is a good way to intentionally break a replay 20140510 22:50:22< iceiceice> i sort of need to come up with a good sanity check mechanism, 20140510 22:50:24< gfgtdf> yes you have to use the 'synced_context::run_in_synced_context_if_not_already' function and it wont work in preload events 20140510 22:50:32< iceiceice> so that i know that the unit test thing is detecting broken replays 20140510 22:50:38< gfgtdf> what do you mean by breakign teh replay ? 20140510 22:50:50< gfgtdf> ah ok 20140510 22:50:51< iceiceice> make it go out of sync or throw an error 20140510 22:51:23< gfgtdf> makle the gamestate depend on luas unsynced rnadom for example 20140510 22:51:28< gfgtdf> random 20140510 22:51:36< iceiceice> hmm ok 20140510 22:51:36< gfgtdf> math.random i think is the function 20140510 22:51:55< gfgtdf> ofc it migth happen taht youll get teh same results in teh replay and then there wont be an error 20140510 22:52:21< iceiceice> hmm but i could make that probability very small :) 20140510 22:53:24< iceiceice> i guess it depends on how good the lua random is :) 20140510 22:54:05< iceiceice> in my experience it is fine though 20140510 22:54:40< gfgtdf> i hink it used c++'s rand() function internaly 20140510 22:57:52< irker079> wesnoth: Chris Beck wesnoth:master 8acf5dbe2c63 / run_wml_tests: wml test script can recieve list of tests as an argument http://git.io/dmIUVA 20140510 22:57:54< irker079> wesnoth: Chris Beck wesnoth:master f08db9b3a4d0 / run_wml_tests: better handling of error logs for wml unit test script http://git.io/4b2elg 20140510 23:02:10-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140510 23:03:45< iceiceice> gfgtdf: what am i supposed to put for [source] in replay tags? 20140510 23:03:56< iceiceice> like [source] x = ... y = ... [/source] ? 20140510 23:04:20< iceiceice> also are the x and y like, as they would be in .cfg or as they would be in engine? 20140510 23:04:27< iceiceice> b/c the engine subtracts one iirc 20140510 23:05:34< gfgtdf> i think the replays store the x,y like they are in the game. the [source] is the ocation of teh attacker i think 20140510 23:05:40< gfgtdf> location 20140510 23:06:34< iceiceice> ok thk u 20140510 23:06:54< gfgtdf> iceiceice: i think a possible implementation would look similar to this: http://pastebin.com/FiefD9WA (didn't test) 20140510 23:08:56< gfgtdf> iceiceice: updated version: http://pastebin.com/VbZxfvqe (comment wording) 20140510 23:10:17< gfgtdf> iceiceice: for attack teh "turn" and tog attributtes are just for bookkeeping i think and aren't used during the replay,. 20140510 23:10:20< gfgtdf> tod 20140510 23:18:35< iceiceice> hmm ok it compiles at least :) 20140510 23:18:41< iceiceice> i had to use the default option for error_handler though 20140510 23:18:52< iceiceice> i guess a nicer way would be to try to cancel if there's an error? 20140510 23:19:09< iceiceice> or throw a wml error rather than a replay oos error idk 20140510 23:19:18< iceiceice> i'm not sure if it makes much difference 20140510 23:19:42< gfgtdf> iceiceice: why did you have to use teh default option ? i think teh default option gives you a nice assert(false) if i remember corrctly 20140510 23:19:47< gfgtdf> the* 20140510 23:20:39< iceiceice> http://pastebin.com/aBkhT1eR 20140510 23:21:29< iceiceice> hmm maybe its something on 1.12 but not on master? 20140510 23:21:39< iceiceice> what's the on_replay_error function 20140510 23:22:10< gfgtdf> iceiceice : my bad i pasted wrongly : http://pastebin.com/Z7NL48EA 20140510 23:24:17< iceiceice> ah ok that builds 20140510 23:24:33< iceiceice> i will try to refactor the thing i was using [issue_attack_command] in 20140510 23:24:47< iceiceice> if it all works i guess i will remove the [issue...] things 20140510 23:24:57-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game] 20140510 23:25:03< gfgtdf> iceiceice : you could also set a local variable with boost bind or thow an exception. I'm not sure whether its excpetion save, but if not it would be hard to make it safe. 20140510 23:25:14< gfgtdf> throw in teh error function i mean 20140510 23:26:01< iceiceice> hmm i see 20140510 23:26:12< iceiceice> so the main place i hope to use these things actually is in unit test scenarios 20140510 23:26:19< iceiceice> like, if you want to test that sighted events work, 20140510 23:26:28< iceiceice> or you have some complicated attack triggered lua code or something, 20140510 23:26:38< iceiceice> if the scenario is noninteractive then you have to coerce an ai to do it 20140510 23:26:49< iceiceice> or use something like [do_replay] 20140510 23:27:14< iceiceice> if we only write to err_ng when theres a problem then i'm not even sure if that will make the unit test fail 20140510 23:27:38< gfgtdf> i dotn know how the unit test is inplemented. 20140510 23:27:40< gfgtdf> don't 20140510 23:27:50< iceiceice> yeah so i worked on it a month ago and then picked it up again 20140510 23:27:54< iceiceice> its pretty simple, 20140510 23:28:02< iceiceice> its just any old test scenario 20140510 23:28:07< iceiceice> that is supposed to run noninteractively 20140510 23:28:15< gfgtdf> i dont know whether failing as soon as we get an error log is a nice idea 20140510 23:28:16< iceiceice> and eventually report victory or defeat if the test passes or fails 20140510 23:28:27< iceiceice> y i mean that's not what i'm proposing 20140510 23:28:33< gfgtdf> an error in log i mean 20140510 23:28:37< iceiceice> but in this case i think exception might be better than log_ng 20140510 23:31:10< gfgtdf> iceiceice: i personaly also think in usecases for a wml developer. And i fear that it might casue corrupt replay with a thow becasue we moght not remove the commands from teh replay if we called that function from insidde a select events. https://github.com/wesnoth/wesnoth/blob/master/src/synced_context.cpp#L60 20140510 23:32:02< iceiceice> ok 20140510 23:32:27< gfgtdf> iceiceice: but the run_in_synced_context function isnt that long/complicated and that should be fixable. 20140510 23:32:37< iceiceice> y i mean hopefully we can write tests that are robust, presumably if some [do_replay] doesn't work the test will realize 20140510 23:34:13< iceiceice> do you think we should allow any replay child? 20140510 23:34:22< iceiceice> the only ones i had actually thought would be useful were like, 20140510 23:34:26< iceiceice> attack, move, recall, recruit 20140510 23:38:31< gfgtdf> iceiceice: there are also some like fire_event/lua_ai which could be used by a wml develpoer to enter the synced context from inside select event. You can find all available commands in synced_commands.cpp, there arent that mutch :) . and i think we shoudl forbid [auto_shroud], [update_shroud] as long as we aren't sure that that doesn't confuse the undo stack, so teh only one we didint als... 20140510 23:38:33< gfgtdf> ...about yet is disband. which rmeoves a unit from teh recall list 20140510 23:39:19< gfgtdf> iceiceice: i think at some point the debug command might also be synced with that system. That might also be useful. 20140510 23:39:50< gfgtdf> s/als/talked 20140510 23:46:37< iceiceice> ok, i'm adding a list to action_wml.cpp of what will be allowed, 20140510 23:46:51< iceiceice> im thinking now to include besides the 4 i said, also update_shroud, and disband 20140510 23:46:53< iceiceice> based on what you said 20140510 23:48:09-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Killed (wilhelm.freenode.net (Nickname regained by services))] 20140510 23:49:11< gfgtdf> iceiceice: but i said that update_shroud/auto_shoud currently shoudl be allowed becasue i fear that this might break teh undo stack.:/ 20140510 23:49:18< gfgtdf> shouldn't 20140510 23:49:55< iceiceice> oh 20140510 23:50:01< gfgtdf> i think everything in synced_commands.cpp except update_shroud/auto_shoud shoudl be allowed 20140510 23:50:01< iceiceice> i misread oops 20140510 23:50:06< iceiceice> hmm 20140510 23:50:28< iceiceice> wait so it is desirable for a wml developer to enter synced context from inside select event? 20140510 23:50:31< iceiceice> haha 20140510 23:50:41< iceiceice> i misunderstood then 20140510 23:50:44< gfgtdf> ye i thought that'd be a useful feature 20140510 23:50:49-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140510 23:54:09< iceiceice> ok now my list is "attack", "move", "recruit", "recall", "disband", "fire_event", "lua_ai" 20140510 23:54:28< gfgtdf> ok. i think that is a good list 20140510 23:55:40< gfgtdf> iceiceice : do you use that list for eth documentation or implemenation or both ? 20140510 23:56:27< iceiceice> implementation 20140510 23:56:32< iceiceice> no doc yet, no testing yet :) 20140510 23:56:49< iceiceice> i'm somewhat distracted atm --- Log closed Sun May 11 00:00:53 2014