--- Log opened Mon May 12 00:00:54 2014
20140512 00:03:57-!- Upthorn [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Read error: Connection reset by peer]
20140512 00:04:20-!- Upthorn [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140512 00:09:59-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 255 seconds]
20140512 00:14:48-!- trewe [~trewe@2001:8a0:d12a:3101:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20140512 00:18:34-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140512 00:41:21-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140512 00:43:18-!- wesbot [~wesbot@asteria.debian.or.at] has quit [Ping timeout: 240 seconds]
20140512 00:43:33-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev
20140512 00:50:38-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Ping timeout: 240 seconds]
20140512 00:51:00-!- elias [~allefant@allefant.com] has quit [Ping timeout: 240 seconds]
20140512 00:52:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140512 00:52:56-!- elias_ [~allefant@allefant.com] has joined #wesnoth-dev
20140512 00:52:56-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140512 00:52:56-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20140512 01:08:57-!- Samual_ is now known as Samual
20140512 01:11:33-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140512 01:23:28-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 276 seconds]
20140512 01:37:08-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140512 01:50:37-!- Gallaecio_ [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev
20140512 01:50:40-!- blarumyrran [~Bbbb123@wesnoth/artist/blarumyrran] has joined #wesnoth-dev
20140512 01:51:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 240 seconds]
20140512 01:51:17-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has quit [Ping timeout: 240 seconds]
20140512 01:51:18-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20140512 01:51:21-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Ping timeout: 240 seconds]
20140512 01:51:21-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140512 01:52:07-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140512 01:52:30-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 276 seconds]
20140512 01:52:33-!- timotei [~timotei@79.119.103.66] has joined #wesnoth-dev
20140512 01:52:33-!- timotei [~timotei@79.119.103.66] has quit [Changing host]
20140512 01:52:33-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140512 01:54:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20140512 01:57:18-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140512 01:58:18-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140512 02:01:29-!- molgrum [~molgrum@212.85.89.43] has quit [Ping timeout: 250 seconds]
20140512 02:04:22-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140512 02:04:36-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140512 02:05:01-!- kex [~kex@78.157.29.205] has quit [Read error: Connection reset by peer]
20140512 02:05:21-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140512 02:11:54-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140512 02:45:29-!- Ivanovic_ [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has joined #wesnoth-dev
20140512 02:49:29-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 264 seconds]
20140512 02:50:53-!- groggy [~chatzilla@68-118-24-196.dhcp.ahvl.nc.charter.com] has joined #wesnoth-dev
20140512 02:51:22-!- Ivanovic_ is now known as Ivanovic
20140512 02:52:32-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has quit [Changing host]
20140512 02:52:32-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140512 03:36:03-!- groggy [~chatzilla@68-118-24-196.dhcp.ahvl.nc.charter.com] has quit [Remote host closed the connection]
20140512 03:40:17-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection]
20140512 03:56:24-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140512 03:59:50-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140512 04:14:28-!- irker555 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140512 04:33:45-!- _8680_ [~8680@2002:4404:712c:0:ad3e:d801:7f14:dcb6] has quit [Ping timeout: 252 seconds]
20140512 04:34:28-!- _8680_ [~8680@2002:4404:712c:0:f9c4:7a51:3c60:bc9d] has joined #wesnoth-dev
20140512 04:39:11-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140512 04:39:11-!- _8680_ [~8680@2002:4404:712c:0:f9c4:7a51:3c60:bc9d] has quit [Ping timeout: 265 seconds]
20140512 04:39:59-!- _8680_ [~8680@2002:4404:712c:0:7d0b:b79b:21e3:6353] has joined #wesnoth-dev
20140512 04:41:43-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140512 04:57:03-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140512 05:02:00-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 252 seconds]
20140512 05:37:41-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20140512 05:39:57-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140512 06:41:53-!- Jetrel_ [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140512 06:42:43-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 250 seconds]
20140512 06:45:10-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140512 06:49:38-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 240 seconds]
20140512 06:59:39-!- mjs-de [~mjs-de@f049107143.adsl.alicedsl.de] has joined #wesnoth-dev
20140512 07:02:46-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140512 07:16:22-!- Jetrel_ [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 258 seconds]
20140512 07:28:19-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140512 07:40:56-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140512 07:45:30-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 258 seconds]
20140512 07:57:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140512 08:01:13-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 245 seconds]
20140512 08:01:52-!- cib_ [~cib@p5DD23D86.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140512 08:29:34-!- blarumyrran [~Bbbb123@wesnoth/artist/blarumyrran] has quit [Quit: Leaving]
20140512 08:31:26-!- markus__ [~mjs-de@f048022115.adsl.alicedsl.de] has joined #wesnoth-dev
20140512 08:34:34-!- mjs-de [~mjs-de@f049107143.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140512 08:36:13-!- cib_ [~cib@p5DD23D86.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20140512 08:47:07-!- cib_ [~cib@p5DD23D86.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140512 08:52:52-!- groggy [~chatzilla@68-118-24-196.dhcp.ahvl.nc.charter.com] has joined #wesnoth-dev
20140512 09:06:57-!- Trademar_ [~trademark@2001:660:3004:64:11ff:77f3:e92a:4770] has joined #wesnoth-dev
20140512 09:10:56-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.]
20140512 09:14:01-!- groggy [~chatzilla@68-118-24-196.dhcp.ahvl.nc.charter.com] has quit [Remote host closed the connection]
20140512 09:20:40-!- aquileia [863c54a8@gateway/web/freenode/ip.134.60.84.168] has joined #wesnoth-dev
20140512 09:30:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140512 09:32:00-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140512 09:33:19-!- _8680_ [~8680@2002:4404:712c:0:7d0b:b79b:21e3:6353] has quit [Ping timeout: 252 seconds]
20140512 09:34:19-!- cib_ [~cib@p5DD23D86.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140512 09:36:02< aquileia> Coffee_irc: I think that in https://github.com/wesnoth/wesnoth/blob/master/src/mouse_events.cpp#L505 (on which you just worked) we don't need the "selected_u != resources::units->end() &&"
20140512 09:36:38< aquileia> It can't pass the line before without that being the case
20140512 09:36:42< Coffee_irc>  aquileia: it is always good to check that the unit exists
20140512 09:37:25< aquileia> How do you mean that? Isn't line 504 enough for that?
20140512 09:37:28< Coffee_irc> it does need to be that way I htink
20140512 09:37:32< Coffee_irc> *think
20140512 09:37:33< aquileia> ok
20140512 09:37:45-!- Spoffy [~chatzilla@152.78.175.8] has joined #wesnoth-dev
20140512 09:37:48< Coffee_irc> the ands and ors are confusingly grouped
20140512 09:38:02< Coffee_irc> but if you track it carefully you should see the need for it
20140512 09:38:28< Coffee_irc> I changed it originally because you couldn't undo a premove
20140512 09:38:47< Coffee_irc> which IMO is worse than not being able to select another friendly unit without deselecting first
20140512 09:38:55< Coffee_irc> but now you can do both
20140512 09:39:26< aquileia> Well, I can't see a reason for (selected_u == resources::units->end()) || (selected_u != resources::units->end() && some condition)
20140512 09:40:21< Coffee_irc> selected_u == resources.end() means that there is no unit where clicked
20140512 09:40:43< Coffee_irc> and the other one makes sure that you can still attack
20140512 09:40:56< aquileia> but that case is already caught by the first line, I thought?
20140512 09:41:11< Coffee_irc> clicked and selected are 2 different hexes
20140512 09:41:25< Coffee_irc> e.g. attacker and attacked units
20140512 09:41:37< aquileia> One below that...
20140512 09:41:46< aquileia> sorry for being confusing
20140512 09:42:06< Coffee_irc> aquileia: all I know is that there are bugs if it is not like that :P
20140512 09:42:58< aquileia> ok, then I probably don't understand how the compiler optimizes the code
20140512 09:43:43< aquileia> Thanks for bearing with my stubbornness
20140512 09:44:54< Coffee_irc> it's actually an interesting puzzle
20140512 09:45:05< Coffee_irc> a || (!a && b)
20140512 09:45:18< Coffee_irc> how to simplify
20140512 09:46:26< aquileia> I still think that logic says it's equal to a || b, but... compilers might see a difference in evaluation order, I guess
20140512 09:46:43< aquileia> else there couldn't be a bug
20140512 09:47:46< Coffee_irc> aquileia: https://www.wolframalpha.com/input/?i=simplify%28a+or+%28not+a+and+b%29%29
20140512 09:48:13< Coffee_irc> you may be right
20140512 09:48:25< aquileia> I didn't know WA has an own syntax for that, good to know!
20140512 09:48:53< Coffee_irc> the syntax (symbols) are universal logic symbols
20140512 09:49:11< aquileia> yes, I mean the textinput
20140512 09:49:35< aquileia> I'm not that dumb =P
20140512 09:49:56< Coffee_irc> oh yeah, it's worth learning mathemtica syntax if you do advanced math of any sort and want quick answers ;)
20140512 09:50:31< aquileia> Where's the fun in that? ;)
20140512 09:50:34< Coffee_irc> normally the program takes square brackets, but the online version is more flexible
20140512 09:51:32< Coffee_irc> aquileia: I feel like I should only change wesnoth master
20140512 09:51:59< Coffee_irc> given we are close (maybe :P) to an eventual (one day) release candidate for 1.12
20140512 09:52:48< aquileia> I agree, it's probably safer - after all, I wouldn't want to reintroduce a bug in a release and get beheaded
20140512 09:52:56< Coffee_irc> aquileia: oh
20140512 09:53:03< Coffee_irc> actually it does need to be like that
20140512 09:53:07< Coffee_irc> to avoid a segfault
20140512 09:53:17< aquileia> but why?
20140512 09:53:35< Coffee_irc> if selected_u is not checked to be an actual unit then selecting information from a non-existant unit will crash the game
20140512 09:53:57< aquileia> but... the check is just one line above!
20140512 09:54:14< Coffee_irc> hmm
20140512 09:54:28< Coffee_irc> ok, if the unit doesn't exist then it will match the first expression
20140512 09:54:29< Coffee_irc> right
20140512 09:57:53-!- irker107 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140512 09:57:53< irker107> wesnoth: David Mikos wesnoth:master 70e98edec1aa / src/mouse_events.cpp: Simplify condition check for mouse action/move. http://git.io/CzpXrw
20140512 09:58:02< Coffee_irc> aquileia: done ^ ;)
20140512 09:58:14< aquileia> thanks
20140512 09:59:01-!- _8680_ [~8680@2002:4404:712c:0:19e7:9cc:b215:3606] has joined #wesnoth-dev
20140512 09:59:04< aquileia> bye
20140512 09:59:09< Coffee_irc> see you
20140512 09:59:15< aquileia> next class awaits...
20140512 09:59:21-!- aquileia [863c54a8@gateway/web/freenode/ip.134.60.84.168] has quit [Quit: Page closed]
20140512 10:06:19-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140512 10:14:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140512 10:23:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140512 10:37:22< stikonas> btw, what is this Debian7-32.zip doing in the git repository?
20140512 10:37:57< stikonas> isn't it inefficient to store executables in git repository
20140512 10:38:27-!- Spoffy [~chatzilla@152.78.175.8] has quit [Ping timeout: 250 seconds]
20140512 10:39:13< loonycyborg> hmm
20140512 10:39:26< loonycyborg> looks like it got there by mistake
20140512 10:41:11< loonycyborg> zookeeper's work. I remember he doesn't like git much. Probably that's one of reasons why. He got screwed by git add :P
20140512 10:41:13-!- TC01_ [~quassel@128.220.109.159] has joined #wesnoth-dev
20140512 10:41:34-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Read error: Connection reset by peer]
20140512 10:42:17-!- TC01 [~quassel@128.220.109.159] has quit [Ping timeout: 264 seconds]
20140512 10:49:51< irker107> wesnoth: loonycyborg wesnoth:master 1be545661475 / Debian7-32.zip: Remove accidentally committed windows binary http://git.io/EQsxzQ
20140512 10:53:48-!- TC01 [~quassel@128.220.109.159] has joined #wesnoth-dev
20140512 10:53:59-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 252 seconds]
20140512 10:54:17-!- TC01_ [~quassel@128.220.109.159] has quit [Ping timeout: 264 seconds]
20140512 11:09:50-!- EdB [~edb@ARennes-658-1-64-158.w2-14.abo.wanadoo.fr] has joined #wesnoth-dev
20140512 11:12:41-!- _8680_ [~8680@2002:4404:712c:0:19e7:9cc:b215:3606] has quit [Ping timeout: 252 seconds]
20140512 11:14:12-!- _8680_ [~8680@2002:4404:712c:0:a590:9a42:424c:45c8] has joined #wesnoth-dev
20140512 11:15:08< zookeeper> loonycyborg, wait, what?
20140512 11:15:42< loonycyborg> There was Debian7-32.zip in the repo and git log said it was you
20140512 11:16:11< zookeeper> oh, indeed
20140512 11:16:15-!- cib [~cib@132.231.178.28] has joined #wesnoth-dev
20140512 11:16:39-!- cib is now known as Guest62331
20140512 11:17:22< zookeeper> dunno how i forgot to untick that checkbox. oh well.
20140512 11:18:04-!- Guest62331 is now known as cib1
20140512 11:19:51-!- TC01_ [~quassel@128.220.109.159] has joined #wesnoth-dev
20140512 11:20:17-!- TC01 [~quassel@128.220.109.159] has quit [Ping timeout: 252 seconds]
20140512 11:21:53-!- Octalot [~noct@27.74.208.46.dyn.plus.net] has quit []
20140512 11:22:18-!- _8680_ [~8680@2002:4404:712c:0:a590:9a42:424c:45c8] has quit [Ping timeout: 240 seconds]
20140512 11:33:31< irker107> wesnoth: trewe wesnoth:1.12 731401db1d08 / po/ (13 files in 13 dirs): update of European Portuguese translation http://git.io/lF1FFg
20140512 11:33:32< irker107> wesnoth: trewe wesnoth:1.12 ea661415d9c0 / changelog data/core/about.cfg players_changelog: touched changelogs and updated credits http://git.io/LSOnlw
20140512 11:33:34< irker107> wesnoth: trewe wesnoth:1.12 fbf1d7f27459 / data/core/images/help/l10n/pt/ (hpxp.png recruit.png tooltip.png): replaced fuzzy images in data/ for Portuguese http://git.io/xVcH3Q
20140512 11:33:36< irker107> wesnoth: Alexander van Gessel wesnoth:1.12 e47ccb311bf3 / / (19 files in 16 dirs): Merge PR #164 http://git.io/nC4Fwg
20140512 11:41:10-!- elias_ is now known as elias
20140512 11:43:03-!- Trademar_ [~trademark@2001:660:3004:64:11ff:77f3:e92a:4770] has quit []
20140512 11:44:06-!- _8680_ [~8680@2002:4404:712c:0:a590:9a42:424c:45c8] has joined #wesnoth-dev
20140512 11:52:47-!- TC01_ is now known as TC01
20140512 12:16:29-!- cib1 [~cib@132.231.178.28] has quit [Ping timeout: 264 seconds]
20140512 12:54:48-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140512 13:13:22-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140512 13:15:29-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140512 13:15:56-!- _8680_ [~8680@2002:4404:712c:0:a590:9a42:424c:45c8] has quit [Ping timeout: 240 seconds]
20140512 13:17:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140512 13:20:57-!- _8680_ [~8680@2002:4404:712c:0:75a3:1d73:a9ae:25ba] has joined #wesnoth-dev
20140512 13:27:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140512 13:54:46-!- EdB [~edb@ARennes-658-1-64-158.w2-14.abo.wanadoo.fr] has quit [Quit: Konversation terminated!]
20140512 13:57:00-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140512 14:07:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140512 14:27:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140512 14:33:40-!- irker107 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140512 14:35:09-!- sachith500|2 [~kvirc@112.135.188.103] has joined #wesnoth-dev
20140512 14:47:46-!- sachith500|2 [~kvirc@112.135.188.103] has quit [Read error: Connection reset by peer]
20140512 14:48:03-!- sachith500|2 [~kvirc@112.135.188.103] has joined #wesnoth-dev
20140512 14:58:11-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140512 15:01:43-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20140512 15:03:52-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140512 15:11:19-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140512 15:38:48-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140512 15:43:05-!- cib [~cib@132.231.178.75] has joined #wesnoth-dev
20140512 15:43:41-!- cib is now known as Guest68607
20140512 15:43:55-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140512 15:49:30-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Quit: leaving]
20140512 15:49:47-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140512 15:53:39-!- sachith500|2 [~kvirc@112.135.188.103] has quit [Read error: Connection reset by peer]
20140512 15:53:56-!- sachith500|2 [~kvirc@112.135.188.103] has joined #wesnoth-dev
20140512 15:59:24-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140512 16:06:57-!- sachith500 [~kvirc@112.134.37.108] has joined #wesnoth-dev
20140512 16:08:43-!- irker966 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140512 16:08:43< irker966> wesnoth: Chris Beck wesnoth:master 91d545c7d730 / data/_main.cfg data/test/_main.cfg src/tests/utils/game_config_manager.cpp: fixup test directory http://git.io/5hpmNQ
20140512 16:08:43< irker966> wesnoth: Chris Beck wesnoth:master 090566effd64 / run_wml_tests: fixup run_wml_tests http://git.io/gn7sww
20140512 16:08:44< irker966> wesnoth: Chris Beck wesnoth:master 20e35b471a36 / / (9 files in 3 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/1GvH2w
20140512 16:09:14-!- sachith500|2 [~kvirc@112.135.188.103] has quit [Ping timeout: 240 seconds]
20140512 16:11:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140512 16:11:58-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
20140512 16:12:50-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has joined #wesnoth-dev
20140512 16:14:23-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has quit [Client Quit]
20140512 16:17:07-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has joined #wesnoth-dev
20140512 16:17:58-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20140512 16:19:42-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has quit [Client Quit]
20140512 16:21:54-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140512 16:23:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Client Quit]
20140512 16:23:48-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has joined #wesnoth-dev
20140512 16:23:48-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has quit [Changing host]
20140512 16:23:48-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140512 16:24:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140512 16:30:43-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140512 16:31:20-!- sachith500 [~kvirc@112.134.37.108] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140512 16:32:41-!- Guest68607 [~cib@132.231.178.75] has quit [Ping timeout: 252 seconds]
20140512 16:35:57< irker966> wesnoth: Chusslove Illich (Часлав Илић) wesnoth:1.12 be7322caa4af / l10n-track: Updated l10n-track. http://git.io/Pnu5pA
20140512 16:36:04< RiftWalker> ls
20140512 16:36:06< RiftWalker> o
20140512 16:36:55-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140512 16:36:58< RiftWalker> hey, is anyone familiar with add-on downloading code? in particular, _info.cfg?
20140512 16:37:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20140512 16:40:29-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Remote host closed the connection]
20140512 16:40:56-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has joined #wesnoth-dev
20140512 16:41:11-!- Ivanovic [~ivanovic@frnk-5f74f931.pool.mediaWays.net] has quit [Changing host]
20140512 16:41:11-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140512 16:42:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140512 16:52:56-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Remote host closed the connection]
20140512 16:53:58-!- gfgtdf [~chatzilla@e177019177.adsl.alicedsl.de] has joined #wesnoth-dev
20140512 16:54:31-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Quit: Lost terminal]
20140512 16:55:27-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Remote host closed the connection]
20140512 16:55:29-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev
20140512 16:58:10-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140512 17:00:00-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Remote host closed the connection]
20140512 17:00:11-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer]
20140512 17:02:26-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140512 17:05:28-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140512 17:07:24-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Remote host closed the connection]
20140512 17:11:16-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20140512 17:11:56-!- markus__ [~mjs-de@f048022115.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140512 17:32:56-!- gfgtdf [~chatzilla@e177019177.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140512 17:36:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140512 17:37:23-!- MaraJade [goossenm@shell.onid.oregonstate.edu] has quit [Changing host]
20140512 17:37:23-!- MaraJade [goossenm@osuosl/staff/MaraJade] has joined #wesnoth-dev
20140512 17:40:27< Soliton> best to ask an actual question. if you really need the definitive expert for a piece of code git annotate is your friend.
20140512 17:44:20-!- Guest68607 [~cib@p5DD23D86.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140512 17:56:24-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140512 17:56:43< iceiceice> hmm something broke with test scenarios now... it looks like it has to do with "cores" but it might also have to do with a change a just pushed...
20140512 17:57:00< iceiceice> try running "wesnoth -t animals" 
20140512 17:57:02< iceiceice> i get this: 
20140512 17:57:02< iceiceice> http://pastebin.com/xyJTLjUu
20140512 17:58:04< iceiceice> false alarm i was on an old branch
20140512 17:58:05< iceiceice> :)
20140512 17:59:05< mattsc> iceiceice: hi
20140512 17:59:21< iceiceice> hi
20140512 17:59:32< mattsc> Was it you who did something recently (within the last week or two) with smoothing out unit motion?
20140512 18:03:24-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20140512 18:08:02< iceiceice> i didnt do anything with unit motion,
20140512 18:08:10< iceiceice> i dont think ive done anything aniation related
20140512 18:08:14< iceiceice> *animation
20140512 18:08:56< iceiceice> main things i'm looking at now are trying to get this wml unit tests thing launched, and the boost random thing
20140512 18:09:03< iceiceice> and fix various mp bugs
20140512 18:09:40< mattsc> iceiceice: okay.  I vaguely remember somebody doing something along those lines, but don’t remember who.  Since you’re currently one of the most active people here, I figured I ask.
20140512 18:10:10< mattsc> I’m trying to figure out who might be responsbile for the second bug that caused us not to announce 1.11.14 without doing the footwork.  :P
20140512 18:10:19-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 276 seconds]
20140512 18:10:54< mattsc> Still haven’t had time for that …
20140512 18:11:01< iceiceice> y pretty unfortunate :/
20140512 18:11:14< iceiceice> idk how we could test for stuff like that
20140512 18:11:31< iceiceice> like automatically i mean
20140512 18:12:00< mattsc> I don’t think you can, in all cases.
20140512 18:12:26< mattsc> That’s why we release beta releases, I guess…
20140512 18:12:39< iceiceice> idk, from way back when i remember there was a java class "robot" that you could use to simulate mouse click event messages from the OS
20140512 18:12:53< iceiceice> theres probably something similar for sdl, 
20140512 18:13:28< iceiceice> if we wanted it to be really robust we could probably make little unit tests to make sure that clicking in certain ways makes the right thing happen
20140512 18:14:16< iceiceice> it would probably be alot of work to make this happen though :/
20140512 18:14:20< iceiceice> maybe someday
20140512 18:15:04< mattsc> The question I’d ask is whether it’s worth the effort …
20140512 18:15:10< mattsc> It might be, it might not be.
20140512 18:17:17-!- Spoffy [~chatzilla@152.78.175.8] has joined #wesnoth-dev
20140512 18:17:19< iceiceice> yeah its debateable
20140512 18:17:55< iceiceice> err, i'd rather not debate it :) but its "questionable"
20140512 18:18:23< mattsc> hehe - don’t worry, I won’t
20140512 18:22:09-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20140512 18:28:13< fabi_> http://forums.wesnoth.org/viewtopic.php?f=5&p=570375 Damn, a bathroom. While I am so desperately searching for a kitchen.
20140512 18:31:07< iceiceice> these spammers need to be more market savvy. "If you buy a kitchen now, we'll throw in a bathroom and some viagra absolutely free!"
20140512 18:34:59-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wsyhsbeqmmznashd] has quit [Ping timeout: 252 seconds]
20140512 18:35:24< fabi_> :-)
20140512 18:36:13< fabi_> iceiceice: If you are bombed with viagra a bathroom is certainly more useful than a kitchen.
20140512 18:40:21-!- gfgtdf [~chatzilla@e177019177.adsl.alicedsl.de] has joined #wesnoth-dev
20140512 18:41:49< gfgtdf> mattsc: coffee did some changes to that recently: https://github.com/wesnoth/wesnoth/commit/f2f30b175768e7c456255a3207e6f4b3ffc57b60
20140512 18:42:30< mattsc> gfgtdf: ah, yes, that might be the one I was thinking about.
20140512 18:42:53< mattsc> But I have started a bisect by now anyway, so I’ll know pretty soon which commit caused the problem.
20140512 18:44:41< gfgtdf> mattsc: does bisecting require compiling each version, or is there a trick ?
20140512 18:46:35< fabi_> gfgtdf: It needs compiling each version but the trick is that git can do most of the work for you.
20140512 18:47:01< gfgtdf> fabi_: git can compile ?
20140512 18:47:19< fabi_> gfgtdf: No, but it can make the bisection pretty easy.
20140512 18:47:27< iceiceice> gfgtdf: you can give git a script to execute i guess
20140512 18:47:34< iceiceice> at each commit
20140512 18:47:49< iceiceice> so the script can be like "compile, then run tests"
20140512 18:47:51-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-amhktywhvzcalyrv] has joined #wesnoth-dev
20140512 18:48:57-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-amhktywhvzcalyrv] has quit [Changing host]
20140512 18:48:57-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20140512 18:48:57-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20140512 18:48:57-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-amhktywhvzcalyrv] has joined #wesnoth-dev
20140512 18:50:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140512 18:50:42< fabi_> iceiceice, gfgtdf: bisect is a git command
20140512 18:50:45< mattsc> gfgtdf: and once you home in close to the commit, compiling becomes pretty fast
20140512 18:50:55< gfgtdf> iceiceice: still that would take very long , assuming average 20min for compilation and 20 commits it already 7 hours. 
20140512 18:51:12< fabi_> http://stackoverflow.com/questions/4713088/how-to-use-git-bisect
20140512 18:51:22< iceiceice> gfgtdf: 7 hours is fine as long as i don't have to be there :)
20140512 18:51:33< mattsc> gfgtdf: you can’t do incremental builds?
20140512 18:51:56< iceiceice> it doesnt take 7 hours to check the result,
20140512 18:52:07< iceiceice> if it says the bug happened at commit X, you can just build X test, and test the previous commit
20140512 18:52:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140512 18:52:35< iceiceice> mattsc: when doing ai testing,
20140512 18:52:45< iceiceice> if i use this "--multiplayer-repeat" argument
20140512 18:52:51< iceiceice> how do i get the ai stats at the end
20140512 18:53:29< mattsc> iceiceice: uh, I have no idea.  I didn’t even know that argument existed.  :P
20140512 18:53:36< iceiceice> :O
20140512 18:53:41< iceiceice> how am i supposed to do ai testing
20140512 18:53:47< gfgtdf> mattsc: i can, without it takes up to 1 hour, with it depends on the diff, fom from 1 min to 1 hour.
20140512 18:54:47< mattsc> gfgtdf: okay - I guess a full build only takes 20 min for me (1.11/1.12) or <10 min (1.13)
20140512 18:54:55< mattsc> iceiceice: that depends on what you want to test
20140512 18:55:25< iceiceice> i have a very simple scenario with two ais
20140512 18:55:33< iceiceice> i want like, to run it many times and get the odds of each side winning
20140512 18:55:43< gfgtdf> mattsc: hm most likely becasue msvc is too stupid to use mutiple coes when using cincremental builds, why is 1.13 faster ?
20140512 18:57:10< mattsc> iceiceice: here’s a very simple script I am using to test Fred:  http://pastebin.com/52NaDYpV
20140512 18:57:21< mattsc> Then just pipe the output to a file and do a grep on it
20140512 18:57:42< iceiceice> :O you dont use no gui?
20140512 18:57:52< mattsc> Oh, the —no-gui is usually enabled …
20140512 18:58:06< iceiceice> oh ok
20140512 18:58:21< mattsc> Yes, I do.  Just saw that.  I did a couple runs where I wanted to see what’s going on recently, that’s why the is commented out.
20140512 18:58:48< mattsc> iceiceice: also, Fred as a CA built in that specifically outputs some extra statistics.
20140512 18:59:33< mattsc> gfgtdf: I upgraded all the Mac compile stuff for 1.13 (but it’s still too rough around the edges to be backported to 1.12)
20140512 18:59:48< mattsc> My guess for the increased speed is that it’s now 64-bit mode.
20140512 19:00:34< mattsc> gfgtdf: what sucks in the bisecting is when a specific commit doesn’t compile - which is what just happened …
20140512 19:01:22< mattsc> Oh, that’s just a warning though, that’s easy  :)
20140512 19:02:10< gfgtdf> mattsc: that means using a 63 bit version of the cimpiler or that the compiler generates 64 bit assemblies?
20140512 19:02:52< gfgtdf> s/63/64  :)
20140512 19:03:06< mattsc> gfgtdf: yes (I think); and that all the libraries are compiled in x86_64 mode as well.
20140512 19:03:37< iceiceice> mattsc: oh, the multiplayer-repeat thing does work, its just that i funneled all the ai testing output to a log domain like a week ago :facepalm:
20140512 19:03:56< mattsc> :D
20140512 19:10:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140512 19:10:41< iceiceice> bbl
20140512 19:10:43-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has quit [Quit: Leaving]
20140512 19:26:30< mattsc> AI0867: the MOVE_UNIT macro bug seems to be caused by this commit:  https://github.com/wesnoth/wesnoth/commit/0343748a7f233608f1daa64b418228c81639efef
20140512 19:27:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20140512 19:27:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140512 19:27:53< mattsc> And before somebody asks, no, I have not filed a bug report.  The bisecting, with as little of a duty cycle as it has, already used up more time than I should have spent on this.
20140512 19:28:15< mattsc> If a bug report is desired, I can file one tonight (in about 6 hours or so).
20140512 19:31:06< gfgtdf> mattsc: can you just tell agin what the bug is ?
20140512 19:31:10< gfgtdf> again*
20140512 19:31:43-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140512 19:31:47< mattsc> 20140511 14:10:22< mattsc> 2. Using the MOVE_UNIT macro, the unit is moved, but then it’s image disappears at the goal location (only the bar etc. remain), it briefly blinks at the original location and then its image disappears altogether (or sometimes it remains visible at the start location).
20140512 19:33:29< mattsc> It might be as simple as adding a redraw somewhere in the Lua code that does [move_unit], but … well, as I said, no time right now …  Also, it might be indicative of an underlying problem that should be fixed instead.
20140512 19:33:44-!- shadowm_desktop [ignacio@186.10.3.238] has joined #wesnoth-dev
20140512 19:34:12-!- shadowm_desktop is now known as Guest23194
20140512 19:36:07-!- irker966 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140512 19:37:18-!- Guest23194 [ignacio@186.10.3.238] has quit [Changing host]
20140512 19:37:18-!- Guest23194 [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140512 19:37:28-!- Guest23194 is now known as shadowm_desktop
20140512 19:47:23-!- Guest68607 [~cib@p5DD23D86.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140512 19:48:05-!- prophile [~alynn@oftn/member/prophile] has quit [Ping timeout: 258 seconds]
20140512 19:52:26-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140512 19:52:41-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 258 seconds]
20140512 19:56:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140512 20:04:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140512 20:05:13-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20140512 20:13:46-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 258 seconds]
20140512 20:25:21-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140512 20:25:41-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140512 20:30:39-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20140512 20:33:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140512 20:37:49-!- Kexoth [~kex@89.205.75.19] has quit [Read error: Connection reset by peer]
20140512 20:38:09-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140512 20:54:32-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Quit: .]
20140512 20:55:21-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140512 20:58:20-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140512 20:58:25-!- Crendgrim [~quassel@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20140512 21:01:14-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140512 21:01:49-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140512 21:05:58-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140512 21:09:42-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140512 21:10:51-!- mjs-de [~mjs-de@f048022115.adsl.alicedsl.de] has joined #wesnoth-dev
20140512 21:17:44-!- gfgtdf_ [~chatzilla@f054143158.adsl.alicedsl.de] has joined #wesnoth-dev
20140512 21:19:47-!- gfgtdf [~chatzilla@e177019177.adsl.alicedsl.de] has quit [Ping timeout: 252 seconds]
20140512 21:19:54-!- gfgtdf_ is now known as gfgtdf
20140512 21:19:55-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140512 21:21:38-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 245 seconds]
20140512 21:37:56< gfgtdf> iceiceice: did you test how undoing wokrs with [do_command] ?
20140512 21:38:09< iceiceice> no
20140512 21:41:19< Coffee_irc> hi mattsc
20140512 21:41:29< Coffee_irc> you posted a bug here https://gna.org/bugs/index.php?21883
20140512 21:42:18< Coffee_irc> I assume it was fixed (you seemed to say so at the time)
20140512 21:44:27< Coffee_irc> rading the irc chat it looks like the problem is with the MOVE_UNIT macro implementation
20140512 21:44:31< Coffee_irc> *reading
20140512 21:45:47-!- _8680_ [~8680@2002:4404:712c:0:75a3:1d73:a9ae:25ba] has quit [Ping timeout: 265 seconds]
20140512 21:48:19-!- _8680_ [~8680@2002:4404:712c:0:38b9:653c:e76e:aa5f] has joined #wesnoth-dev
20140512 21:48:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20140512 21:48:32-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140512 21:49:14< mattsc> Coffee_irc: yes bug 21883 was fixed.  The MOVE_UNIT bug has nothing to do with that AFAICT.
20140512 21:49:46< Coffee_irc> mattsc: are you doing a bisection to find out the commit that introduced the bug?
20140512 21:49:56< mattsc> Coffee_irc: I did.
20140512 21:50:05< Coffee_irc> and...
20140512 21:50:15 * Coffee_irc *drum roll*
20140512 21:50:19< mattsc> hold on, need to find the right place ...
20140512 21:50:45< mattsc> 20140512 19:26:30< mattsc> AI0867: the MOVE_UNIT macro bug seems to be caused by this commit:  https://github.com/wesnoth/wesnoth/commit/0343748a7f233608f1daa64b418228c81639efef
20140512 21:51:05< mattsc> from the log of this channel, 3.5h ago
20140512 21:51:08< Coffee_irc> :)
20140512 21:51:14< Coffee_irc> good, it wasn't me :P
20140512 21:51:29< mattsc> Yeah, I was trying to blame you for it, but couldn’t quite pull it off.  :)
20140512 21:52:03-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140512 21:53:18-!- _8680_ [~8680@2002:4404:712c:0:38b9:653c:e76e:aa5f] has quit [Ping timeout: 245 seconds]
20140512 21:54:31-!- _8680_ [~8680@2002:4404:712c:0:c434:faed:fe6a:5f8c] has joined #wesnoth-dev
20140512 22:01:19-!- _8680_ [~8680@2002:4404:712c:0:c434:faed:fe6a:5f8c] has quit [Ping timeout: 252 seconds]
20140512 22:02:26-!- _8680_ [~8680@2002:4404:712c:0:2d4f:5843:8af6:e62d] has joined #wesnoth-dev
20140512 22:03:04-!- mjs-de [~mjs-de@f048022115.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140512 22:08:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20140512 22:37:16-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140512 22:39:05-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Ping timeout: 250 seconds]
20140512 22:41:08-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140512 22:45:07< gfgtdf> mattsc: what was teh other bug ?
20140512 22:46:04< iceiceice> hmm thats wierd
20140512 22:46:14< gfgtdf> what ?
20140512 22:46:15< iceiceice> i was working on a C++ unit test,
20140512 22:46:24< iceiceice> and it caused a completely different unit test to start segfaulting
20140512 22:46:36< iceiceice> something in the mp connect part, at malloc...
20140512 22:46:39< iceiceice> http://pastebin.com/BW6qsbvJ
20140512 22:46:50< iceiceice> i can't build the "test" executable with debugging symbols lol
20140512 22:46:58< iceiceice> maybe should figure out how to dot hat
20140512 22:47:14< gfgtdf> mattsc: i think that problem can be fixed by calling unit.anim_.reset(), in lua_unit's function on put. 
20140512 22:47:58< iceiceice> hmm maybe i can build it with debugging symbols...
20140512 22:48:10< mattsc> gfgtdf: the other one was that you couldn’t select another unit while one was selected by simply clicking on it
20140512 22:48:56< mattsc> gfgtdf: I can’t comment on how to fix the 2nd bug (definitely not at this time).  Discuss is with AI0867.  :)
20140512 22:49:00< gfgtdf> iceiceice	: i think there is no drawback of build with debugging symbols.
20140512 22:49:21< iceiceice> yeah i didnt realize that "scons test build=debug" woudl work...
20140512 22:49:40< iceiceice> it ooks like it might be working, although it will take a while because i didnt build master with debug in a long time
20140512 22:50:08< iceiceice> gfgtdf: i think the only drawback is you have to disable compiler optimizations
20140512 22:51:38< gfgtdf> iceiceice: usually build with debuggign symbold and with optimisations :p , but its sometimes confusion when some variables doesn't exist becasue of opimisation.
20140512 22:51:48< iceiceice> lol
20140512 22:52:18< iceiceice> yeah i think i learned in school not to do that... idk what else the optimizations can do :p
20140512 22:52:28< iceiceice> scons seems to do it that way by default
20140512 22:53:05< iceiceice> i mean i guess at -O3 some functions might not exist because of inlining?
20140512 22:53:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140512 22:53:26< iceiceice> idk what it says if you segfault in some loop that has been unrolled either...
20140512 22:53:34< iceiceice> rather not to find out these things i guess
20140512 22:54:38< gfgtdf> iceiceice: hm in msvc the option isn called O3 but yes that can happen :). Still It can be useful, and a lot of things still work.
20140512 22:55:40< iceiceice> y i see what you mean, at least you dont have to rebuild
20140512 22:56:04< gfgtdf> ye
20140512 22:56:20< gfgtdf> plus without optimisation is can be very slow
20140512 23:00:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Ciao]
20140512 23:05:55< gfgtdf> iceiceice: do you think i should remove wesnoth.is_synced and make it a field is_synced of wesnoth.current instead ?
20140512 23:06:09< gfgtdf> the wesnoth,is_synced function i mean,
20140512 23:06:17< gfgtdf> s/,/.
20140512 23:07:20< iceiceice> hmm i have to look at the docs to say
20140512 23:08:29< iceiceice> y it looks like a good idea
20140512 23:08:37< iceiceice> are people already using it in 1.12 though?
20140512 23:09:05< iceiceice> maybe change in 1.13 and add something to wmllint, idk
20140512 23:09:41< iceiceice> you could also i guess just change in 1.12, there are probably not many people using it besides EP I guess? idk up to you
20140512 23:10:24< iceiceice> i have learned that something wierd is happening in my unit tests, it is not properly storing replays somehow
20140512 23:10:28< EliDupree> even I haven't used it yet
20140512 23:10:52< iceiceice> is there any documentation for it yet?
20140512 23:11:27< iceiceice> looks like not, in that case i would say fair game
20140512 23:16:30< gfgtdf> iceiceice: i think it is not even in 1.12. although i'd like to have it there :)
20140512 23:17:23-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140512 23:17:28< gfgtdf> iceiceice: hmm whats wrng with the replays ?
20140512 23:18:43< iceiceice> so its a bit funny
20140512 23:18:49< iceiceice> they dont have any replay_start or replay
20140512 23:18:59< iceiceice> so when i load them they end successfully immedaitely
20140512 23:19:05< iceiceice> if you load with gui it just says "the end" 
20140512 23:19:18< iceiceice> i think that it might be that what i am doing here doesn't work:
20140512 23:20:28< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/game_controller.cpp#L482
20140512 23:20:31< iceiceice> like,
20140512 23:20:43< iceiceice> I am running play_game and getting its return value,
20140512 23:20:49< iceiceice> then only after that do i call save game
20140512 23:20:56< iceiceice> but it might be that the state is already in a bad place to be saved
20140512 23:21:13< iceiceice> so maybe i need to work the save code in earlier
20140512 23:21:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140512 23:21:58< iceiceice> i thought that maybe the fact that its "test" or is noninteractive was messing up the saves but i dont think that's it any more
20140512 23:27:48< gfgtdf> iceiceice: maybe they get clear here: https://github.com/wesnoth/wesnoth/blob/master/src/playcampaign.cpp#L532
20140512 23:27:54< gfgtdf> cleared
20140512 23:29:01-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140512 23:31:00< iceiceice> hmm yeah you are right
20140512 23:31:02< iceiceice> :)
20140512 23:31:41< iceiceice> yeah stuff like this gets a bit annoying...
20140512 23:31:56< iceiceice> i did not want to start editing things that deep into the game to make the unit tests work...
20140512 23:32:13< iceiceice> just have it all exist in game contoller
20140512 23:32:17< iceiceice> and game.cpp
20140512 23:32:22< iceiceice> but i guess maybe i ahve no choice
20140512 23:32:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140512 23:34:48< iceiceice> if i am going to start doing this it might be worth thinking about trying to do the timeout properly as well
20140512 23:35:23< iceiceice> in boost threading, when you want one thread to be able to kill another thread, you basically have to have the killed thread use "interrupt points",
20140512 23:35:33< iceiceice> like it has to run some "check for interrupt" boost thread code
20140512 23:35:41< iceiceice> which will kill it with an exception if another thread asked
20140512 23:35:55< iceiceice> im not even sure where the right place is to put such code in wesnoth, it seems extremely complicated
20140512 23:36:10< iceiceice> could just put something in "play_slice" but idk what will happen if lua goes in an infinite loop, etc.
20140512 23:36:41< fabi_> hello
20140512 23:36:49-!- fabi_ is now known as fendrin
20140512 23:38:08-!- ancestral [~ancestral@17.114.45.165] has joined #wesnoth-dev
20140512 23:38:38< fendrin> hi ancestral
20140512 23:44:30< iceiceice> hmm does anyone know much about boost unit test library?
20140512 23:44:46< iceiceice> it looks like a global fixture is not running idk why
20140512 23:44:47-!- ancestral [~ancestral@17.114.45.165] has quit [Ping timeout: 255 seconds]
20140512 23:46:11< iceiceice> not in my file, in mp_connect...
20140512 23:48:18-!- ancestral [~ancestral@17.114.45.165] has joined #wesnoth-dev
--- Log closed Tue May 13 00:00:05 2014