--- Log opened Fri May 16 00:00:00 2014
20140516 00:03:53< Necrosporus> error scripting/lua: [string "print(wesnoth.dofile(/etc/hosts))"]:1: unexpected symbol near '/'
20140516 00:05:12< shadowm> Yeah now you forgot to surround the string value (path) in quotes. Still not sure what you are trying to accomplish.
20140516 00:06:41-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140516 00:08:22< iceiceice> hmm i decided to again perform my biweekly ritual of trying to play legend of wesmere as a networked mp campaign until i encounter a blocker :p
20140516 00:08:33< iceiceice> the new blocker is, scenario 4 consistently goes out of sync
20140516 00:08:41< iceiceice> either on 2nd or 3rd turn it seems
20140516 00:08:45< Necrosporus> Seems like this bug doesn't present in 1.10
20140516 00:08:46< iceiceice> for the other client and the observer
20140516 00:09:18< shadowm> Necrosporus: I linked you to a page that states that wesnoth.have_unit() was implemented in 1.11.x.
20140516 00:09:28< shadowm> Still, what were you trying to accomplish?
20140516 00:09:37< Necrosporus> I know, but there's other functions with files
20140516 00:09:47< Necrosporus> there're
20140516 00:09:56< Necrosporus> wesnoth.dofile e.g.
20140516 00:10:22< shadowm> Yeah and I expect them to be affected by the bug, it's just that your test case is a little off.
20140516 00:10:33< shadowm> What were you trying to accomplish?
20140516 00:10:56< Necrosporus> maybe load /etc/hosts as wml and so drop some error?
20140516 00:12:45< shadowm> Well, if you ever manage to do that I'd like to hear of it, but not here.
20140516 00:13:35-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 255 seconds]
20140516 00:14:31< shadowm> Not that I need more confirmation from Lua.
20140516 00:24:01< shadowm> All: I have a proposed fix here, but I haven't tried it out and you might want to evaluate it first for inclusion in 1.10, 1.12, and master: https://gna.org/bugs/index.php?22042
20140516 00:24:17< shadowm> (Sorry, developers only.)
20140516 00:24:36< shadowm> Also note my remark about the other thing.
20140516 00:28:03-!- gfgtdf [~chatzilla@d227074.adsl.hansenet.de] has joined #wesnoth-dev
20140516 00:28:35-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140516 00:29:16< gfgtdf> iceiceice: dou you knwpo what exaclty triggeres teh oos ?
20140516 00:29:23< iceiceice> not sure yet
20140516 00:29:47< iceiceice> i think its when the orcish units move but i'm not sure
20140516 00:29:55< gfgtdf> shadowm: do you think as a first step we coudl just not accept teh .\ syntax if current_dir  is empty ?
20140516 00:30:27< iceiceice> gfgtdf: i made a bug report
20140516 00:31:24< shadowm> gfgtdf: That's also an option, but in that case it'd also be important to ensure current_dir doesn't start with / or [A-Za-z]:[\/] either.
20140516 00:31:53< shadowm> No idea yet exactly how that case would come to pass.
20140516 00:32:16< shadowm> I literally started reading this code an hour ago. :p
20140516 00:33:00< shadowm> Ah, that seems to be why _the other thing_ isn't affected -- it passes a current_dir.
20140516 00:35:32< shadowm> Then if current_dir is empty it should default to something within the safe areas.
20140516 00:36:11< shadowm> Possibly <data dir>/data, since that's the root of the WML tree, or <data dir> itself.
20140516 00:37:23< shadowm> Not sure why anyone would use "./images/game-icon.png" to refer to /images/game-icon.png. Really if current_dir is empty we should complain loudly.
20140516 00:38:10< shadowm> The problem is that there is C++ code that relies on an empty current_dir meaning something, including GUI2.
20140516 00:38:24< gfgtdf> shadowm: do you think we can manage to pass teh dir of teh currently executed lua file in case of these lua functions ?
20140516 00:38:53< gfgtdf> 	shadowm: reayy can you show code ?
20140516 00:39:07< shadowm> Well, actually, it doesn't rely on a meaning -- it doesn't pass an explicit "./" in the path.
20140516 00:39:37< shadowm> src/gui/widgets/settings.cpp:495:                               get_wml_location("gui/schema.cfg"));
20140516 00:39:52< shadowm> In that case it should be falling into the `result = game_config::path + "/data/" + filename;` logic.
20140516 00:40:26< shadowm> gfgtdf: Do we handle such information in Lua? Also, what about :lua?
20140516 00:42:06< gfgtdf> shadowm: that is what i asked you, i think ye can just default it to sometingk for cases liek :lua
20140516 00:42:45< shadowm> The game_config::path default would make sense, I think.
20140516 00:43:31< shadowm> That's essentially just what other code expects -- it's just unfortunate that we decided to have "foo/bar" and "./foo/bar" have different semantics.
20140516 00:45:24 * shadowm wonders if there's any way to obtain a file without having Lua throw an error.
20140516 00:46:47< shadowm> Files passed to those functions are required to be syntactically-valid Lua and run immediately, right? There is no way to capture their contents for delayed execution?
20140516 00:47:08< gfgtdf> hm i think no.
20140516 00:47:14< gfgtdf> not
20140516 00:47:49< gfgtdf> not in the senser there is not way
20140516 00:47:52< gfgtdf> no
20140516 00:48:16< gfgtdf> ahh
20140516 00:48:18< shadowm> Means there _might_ be a way?
20140516 00:48:33< gfgtdf> i thing what you said is correct
20140516 00:48:35< gfgtdf> think
20140516 00:48:46< Necrosporus> By the way, it should also be checked if path contains '..' stuff if it isn't yet
20140516 00:48:47< shadowm> Because I'm not sure I can bump the priority further without breaking the form. :p
20140516 00:49:46< shadowm> It'll bail out if it finds two adjacent ASCII dots anywhere in the path, no exceptions made.
20140516 00:51:02< shadowm> Those used to be made but then someone figured out that could result in arbitrary file inclusions.
20140516 00:53:10< gfgtdf> iceiceice: i get immiedealy a lua error in scneario 3 of low 
20140516 00:53:27< gfgtdf> got nil expected string in replace mao
20140516 00:53:33< iceiceice> hmmm
20140516 00:53:39< gfgtdf> you too ?
20140516 00:53:48< iceiceice> i dont remember now, might be
20140516 00:53:54< iceiceice> let me try
20140516 00:54:15-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140516 00:54:33< Necrosporus> There are some files in /proc even reading which might be dangerous... afair reading one in android smartphones brick the phone
20140516 00:54:59< shadowm> As non-root?
20140516 00:55:11< Necrosporus> can't remember
20140516 00:55:26< Aishiko> I thought we didn't support android?
20140516 00:55:31< shadowm> I'd never heard before of a sysfs or procfs read having side-effects, though.
20140516 00:55:48< shadowm> So... citation needed.
20140516 00:57:52< iceiceice> gfgtdf: i dont get a lua error immediately
20140516 00:59:28< iceiceice> my version at the top is 8a7e4d6-clean
20140516 00:59:55< iceiceice> 1.11.14+dev
20140516 01:00:55< iceiceice> hmm one thing that is wierd though
20140516 01:01:03< iceiceice> the orcish slayer at the top of the screen which is the leader of green side
20140516 01:01:07< iceiceice> has name "iceiceice" on the host
20140516 01:01:13< iceiceice> but has some other orc name on the client and observer
20140516 01:02:41< gfgtdf> iceiceice: https://gna.org/bugs/?21945
20140516 01:03:18< iceiceice> ok yeah img etting the same one
20140516 01:03:26< iceiceice> but in scenario 3 of chapter 1
20140516 01:03:47< iceiceice> idk is that already an out of sync?
20140516 01:04:10< iceiceice> i guess not... anyways i wonder why its doing that
20140516 01:04:12< gfgtdf> hm onyl of teh code depends on teh units name whcih is generally not reccomended
20140516 01:04:24< gfgtdf> becasue rtanslation might also differ
20140516 01:05:03< gfgtdf> iceiceice: like when 2 player from different languages play against teh names can also be differnet i tink
20140516 01:05:12< gfgtdf> so i'd say no
20140516 01:05:14< iceiceice> y i see
20140516 01:07:02< gfgtdf> iceiceice: i think 16f08c46d277304283269ec0613df234eca22905 broke the scenario 3 for me, becasue LoW's [replace_map] uses the map header 
20140516 01:07:08< iceiceice> hmm it looks like i dont go out of sync if i dont attack with elves
20140516 01:07:11< gfgtdf> i use 1.13-dev
20140516 01:07:15< iceiceice> like if i just pass my turns constantly
20140516 01:07:31< iceiceice> so idk still not sure what's going on here
20140516 01:08:11< gfgtdf> iceiceice: can you see any differences between the units on both sides ? especialy traits/max_moves ?
20140516 01:08:50< iceiceice> let me run again and do what i did to get the oos
20140516 01:09:02< gfgtdf> ok i think i foudn something
20140516 01:09:13< gfgtdf> somehere teh rng goes oos
20140516 01:09:16< gfgtdf> the rng
20140516 01:09:54< gfgtdf> iceiceice: the traits of teh "Elvis Hero" units are differnt here
20140516 01:10:04< iceiceice> hmm
20140516 01:12:21< gfgtdf> iceiceice: i think this is a engine bug
20140516 01:13:11< gfgtdf> iceiceice: maybe rnadom genders of leader are still unsynced
20140516 01:13:46< iceiceice> ok i didnt get the elvish hero to have different traits on this run
20140516 01:14:38< iceiceice> hmmmm
20140516 01:14:43< gfgtdf> iceiceice: hm maybe i just misslokey now teh reias are teh same
20140516 01:14:45< iceiceice> maybe its in the mp connect engine or smth?
20140516 01:14:47< gfgtdf> lislookel
20140516 01:14:51< gfgtdf> mislooked
20140516 01:14:58< gfgtdf> traits
20140516 01:15:10< gfgtdf> but still i wonder whether leaders geneder are save
20140516 01:15:11< iceiceice> i remember there was some question about whether to use synced or unsynced in the mp connect
20140516 01:15:25< iceiceice> maybe in single scenario it is but in campaign its not for some reason?
20140516 01:15:34< iceiceice> idk im just brainstorming
20140516 01:15:53< gfgtdf> iceiceice: the mo connect nromaly works by teh host resolving all random and ten sendn teh results to thores
20140516 01:17:33< iceiceice> y
20140516 01:17:49< gfgtdf> iceiceice: do you also bedin with you elves in the river in scenario 3 ?
20140516 01:17:52< gfgtdf> gebin
20140516 01:17:54< gfgtdf> begin
20140516 01:19:22< gfgtdf> fabi_: 16f08c46d277304283269ec0613df234eca22905 breaks the scenario 3 of LoW, becasue LoW's [replace_map] uses the map header in https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Legend_of_Wesmere/lua/replace_map.lua#L11
20140516 01:20:22-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140516 01:21:25< iceiceice> gfgtdf: i began with my elves in the forest
20140516 01:21:30< iceiceice> i didnt get oos this time i ran it
20140516 01:21:35< iceiceice> at least not yet
20140516 01:21:40< iceiceice> i'm going to restart again if i dont get it in the next turn
20140516 01:21:51< gfgtdf> iceiceice: which turn are you ?
20140516 01:23:40-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 258 seconds]
20140516 01:23:49< gfgtdf> iceiceice: last time a played this scenario my elves stated near teh caslte no they stare in a river giging me disadvantage ..
20140516 01:23:54< gfgtdf> s/a/i
20140516 01:24:03< gfgtdf> s/no/now
20140516 01:24:07< iceiceice> what difficulty are you on?
20140516 01:24:09< iceiceice> i just hit normal i think
20140516 01:24:32< iceiceice> but it sounds like you had some kind of map bug anyways
20140516 01:24:46< gfgtdf> normal
20140516 01:25:27-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140516 01:25:51-!- Necrosporus_ is now known as Necrosporus
20140516 01:28:24< gfgtdf> iceiceice: do you have replays from both sides when teh OOS occured ?
20140516 01:29:12< iceiceice> no just the client and observer
20140516 01:29:18< iceiceice> i got it the first 3 times i did it 
20140516 01:29:46< gfgtdf> you already reproduced this bug 3 times ?
20140516 01:29:57< iceiceice> yes
20140516 01:30:03< iceiceice> but the 4th time failed
20140516 01:30:10< iceiceice> you asked me questions i didnt know the answer to :p
20140516 01:30:57< gfgtdf> hm ok you you next time please give me a replay from the both sided (the one that makes themove, and teh one that gets teh OOS message) ?
20140516 01:32:30-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140516 01:32:47< iceiceice> y ok
20140516 01:34:38< iceiceice> ok
20140516 01:34:39< iceiceice> first one is
20140516 01:35:06< iceiceice> calculated source of movement did not match
20140516 01:35:10< iceiceice> x = 21 23
20140516 01:35:13< iceiceice> err
20140516 01:36:33< gfgtdf> iceiceice: did the units (that moved) has teh same max_moves and traits on all clients?
20140516 01:36:33< iceiceice> shoot i saved it and now i cant find the exact error message
20140516 01:36:41< iceiceice> its hard to say it happened during ai turn
20140516 01:36:51< iceiceice> but i am noticing in the console that i am also getting this: "20140515 21:34:29 error network: found unknown command:
20140516 01:36:51< iceiceice> [random_seed]
20140516 01:36:51< iceiceice> 	seed = 1871395250
20140516 01:36:51< iceiceice> [/random_seed]
20140516 01:36:51< iceiceice> "
20140516 01:37:31< iceiceice> i wonder if my server is not built properly or something??
20140516 01:37:57< iceiceice> ah ok i can get the exact oos message from observer i just remember
20140516 01:38:00< gfgtdf> iceiceice;: the message suggests there was a [random_seed] not packed intoa [command]
20140516 01:39:11< iceiceice> hmm
20140516 01:39:16< iceiceice> heres my console log from host:
20140516 01:39:29< iceiceice> or part of it
20140516 01:39:42< iceiceice> http://pastebin.com/VkP8Gizz
20140516 01:39:53< gfgtdf> iceiceice: not i see i get those unknown commands too
20140516 01:39:55< gfgtdf> now
20140516 01:41:00< gfgtdf> iceiceice: i think tahts harmless
20140516 01:41:03< gfgtdf> harmless
20140516 01:41:11< iceiceice> heres my exact oos message: http://i.imgur.com/8PpzGZX.png
20140516 01:41:27< iceiceice> during AI turn
20140516 01:42:38< iceiceice> hmm actually
20140516 01:42:42< iceiceice> its not during ai turn i guess
20140516 01:42:44< gfgtdf> iceiceice: the fund unknown commands is realted to and package sended by by teh server before 1.11.13 whcih i didnt delete for backward compabilty
20140516 01:42:44< iceiceice> its during host turn
20140516 01:43:08< gfgtdf> iceiceice: and do they have teh same max_moves ?
20140516 01:43:11< gfgtdf> the*
20140516 01:43:17< iceiceice> idk
20140516 01:43:18< gfgtdf> and same traits
20140516 01:43:23< iceiceice> im going to launch another wesnoth and watch the replay
20140516 01:43:27< iceiceice> i'm still not sure which unit it was that moved
20140516 01:43:55-!- groggy [~chatzilla@24-182-87-155.dhcp.hckr.nc.charter.com] has joined #wesnoth-dev
20140516 01:44:10< iceiceice> ahh
20140516 01:44:12< iceiceice> elvish scout
20140516 01:44:17< iceiceice> is quick intelligent vs dextrous intelligent
20140516 01:44:47< gfgtdf> hm that you explain why teh units moves further on teh one client
20140516 01:45:21< gfgtdf> iceiceice: did you a) recruit that unit b) recalled that unit c) had that unti form teh beginning
20140516 01:45:28< iceiceice> i was given it at the start of scenario
20140516 01:45:29< gfgtdf> that woudl explan *
20140516 01:45:34< iceiceice> no recruits or anything yet
20140516 01:45:45< iceiceice> its stil turn 1 i guess
20140516 01:45:54< iceiceice> all i did was, on blues turn i wailed on the orcs
20140516 01:46:32< iceiceice> now i'm on browns turn after the ai moved, but client and obs are oos
20140516 01:46:44< iceiceice> do you want me to save replays on all and post them
20140516 01:46:44< iceiceice> ?
20140516 01:46:55< iceiceice> idk if it will be helpful, i guess it cant hurt
20140516 01:47:00< gfgtdf> iceiceice: i assume it was we talked about earlier that teh creation of units/leasder insode teh [side] tag is not peroperly synced
20140516 01:47:26< iceiceice> hmm i see
20140516 01:48:21< gfgtdf> iceiceice: depending on where in teh code the unti is created fixing this is hard or easy
20140516 01:52:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140516 01:53:08< gfgtdf> iceiceice: ok i think i have a posible fix
20140516 01:53:17< iceiceice> that was fast :)
20140516 01:53:17< wesbot> iceiceice: Sometimes we are fast
20140516 01:55:54< gfgtdf> iceiceice: http://pastebin.com/mMt3SPmY,  wrap build_team_stage_two with a set_random_determinstic 
20140516 01:56:25< gfgtdf> in play_controller::init
20140516 01:56:28< gfgtdf> iceiceice: ^
20140516 01:56:49< iceiceice> hmm
20140516 01:58:31< iceiceice> where is thsi code right now?
20140516 01:58:48-!- groggy [~chatzilla@24-182-87-155.dhcp.hckr.nc.charter.com] has quit [Remote host closed the connection]
20140516 01:58:51< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/blob/master/src/play_controller.cpp#L235
20140516 01:59:18< iceiceice> thx
20140516 02:00:04< gfgtdf> iceiceice: can you test it for 1.12 ?
20140516 02:00:51< iceiceice> y i think you are right
20140516 02:00:53< iceiceice> yeah i will test
20140516 02:01:03< iceiceice> if you push to your fork i will pull and test
20140516 02:05:17< gfgtdf> iceiceice: my 1.12 fork ?
20140516 02:06:05< iceiceice> sure
20140516 02:06:09< iceiceice> or topic, whatever you like
20140516 02:06:46< gfgtdf> iceiceice: my currentl local is a ^1.13, but i can so that with the gitbub webinterface :)
20140516 02:08:27< iceiceice> hehe ok
20140516 02:13:20< gfgtdf> iceiceice: i accidently made it on my master is that ok ?
20140516 02:13:42-!- irker755 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140516 02:13:42< irker755> wesnoth: Chris Beck wesnoth:master 7b6a1ec74dc3 / / (3 files in 2 dirs): fixup messed up whitespace and similar http://git.io/t-uQ9A
20140516 02:13:46< iceiceice> y its ok
20140516 02:13:48< iceiceice> i'll figure it out
20140516 02:13:53< iceiceice> what am i supposed to pull?
20140516 02:15:02< gfgtdf> iceiceice: cherrypick https://github.com/gfgtdf/wesnoth-old/commit/cd66a2a755c16b90ffd0113545d928db5de2e133
20140516 02:17:00< iceiceice> ahh ccache so good :)
20140516 02:17:37< iceiceice> done building
20140516 02:17:39< gfgtdf> iceiceice: ??
20140516 02:17:44< gfgtdf> ccache
20140516 02:18:02< gfgtdf> iceiceice:  that was fast
20140516 02:18:02< wesbot> gfgtdf: Sometimes we are fast
20140516 02:18:10< gfgtdf> fast
20140516 02:18:15< gfgtdf> was fast
20140516 02:18:15< wesbot> gfgtdf: Sometimes we are fast
20140516 02:18:22< gfgtdf> s fast
20140516 02:18:25< gfgtdf> as fast
20140516 02:18:31< iceiceice> haha
20140516 02:19:40< iceiceice> ccache is this fancy compiler tool we have in the scons script
20140516 02:19:48< iceiceice> i only vaguely understand what it does,
20140516 02:20:04< iceiceice> it like caches the source associated to each command
20140516 02:20:07< iceiceice> and hashes or something
20140516 02:20:19< iceiceice> and if the hash matches a record when you build,
20140516 02:20:21< iceiceice> it just gets the result from before
20140516 02:20:25< iceiceice> instead of compiling
20140516 02:20:36< iceiceice> so if you are using git and you change branches, you dont have to totally rebuild
20140516 02:20:42< iceiceice> its like ridiculously faster
20140516 02:20:58< iceiceice> i set my ccache cache size to like 5 gb
20140516 02:21:14< iceiceice> only using 3.2 gb atm
20140516 02:21:43< iceiceice> it still will miss liek 1/3 of the time but when it hits the compile is basically instant
20140516 02:24:20< gfgtdf> iceiceice: did you teset already
20140516 02:24:33< iceiceice> no i did it wrong, have to try again
20140516 02:26:19-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140516 02:28:29< gfgtdf> i go to sleep now , bb
20140516 02:28:31-!- gfgtdf [~chatzilla@d227074.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140516 02:29:51< iceiceice> ok it looks like all the traits are right
20140516 02:34:18< shadowm> mattsc: Might want to take a look at this: http://forums.wesnoth.org/viewtopic.php?p=570491#p570491
20140516 02:41:13-!- Ivanovic_ [~ivanovic@frnk-4d016b23.pool.mediaways.net] has joined #wesnoth-dev
20140516 02:42:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 245 seconds]
20140516 02:43:07-!- Ivanovic_ is now known as Ivanovic
20140516 02:56:50< iceiceice> ok gfgtdf i got through chapter 1
20140516 02:59:45< Aishiko> shadowm, that bluish tint really makes it seem more menacing, like stepping out of the shadows of the night to attack and will fade away back into those midnight blue shadows and darkness afterwards preventing counter attack
20140516 03:00:23< shadowm> It'd work better if it were a little purple-er.
20140516 03:08:55< mattsc> Hmm, funny.  Things started being blue in 1.11.12.
20140516 03:09:08< mattsc> I’ll add it to the list ...
20140516 03:11:08< shadowm> mattsc: It seems like it doesn't affect all images, though. What happens if you use an image editor to import and reexport them?
20140516 03:11:37< shadowm> I would suspect a decoding error of some sort.
20140516 03:13:12-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140516 03:13:50< mattsc> shadowm: if I look at the assassin’s portrait in the 1.11.13 data/core/… directory with an image viewer, it looks just fine.
20140516 03:14:23< shadowm> Yeah, but I would imagine it's not using the same version and build of libpng as us.
20140516 03:14:35< shadowm> Maybe it's not even using libpng at all.
20140516 03:15:26< mattsc> Yeah - I did recently start packaging on an old OS X 10.5.8 laptop for an entirely unrelated reason.  I might have started that at 1.11.12.  I’ll check whether that’s the cause of the problem.
20140516 03:18:25< mattsc> Actually, no, that’s not the reason, because it looks the same in 1.11.14+dev on my OS X 10.9 computer.
20140516 03:20:54< mattsc> shadowm: are you aware of anything that might have changed with libpng recently (between 1.11.11 and 1.11.12).
20140516 03:21:24< mattsc> I am reasonably certain that I did not change any of the Mac libraries during that time...
20140516 03:22:00< mattsc> At least not for the 1.12 branch.  I did change everything on master.  Maybe I mixed up something somewhere ...
20140516 03:26:35< mattsc> Uh….  “This web page at imagebin.org has been reported as an attack page and has been blocked based on your security preferences.”
20140516 03:27:03< mattsc> I was going to show that it looks even worse in 1.13.0-dev, but I guess I won’t.
20140516 03:27:15< iceiceice> use imgur :)
20140516 03:27:23< mattsc> (and yes, I know there are other sites, but I don’t care enough)
20140516 03:27:25< mattsc> :P
20140516 03:28:39< mattsc> iceiceice: alright, because it’s you…  ;)   http://imgur.com/guxOdtQ
20140516 03:28:48-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140516 03:29:33-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 245 seconds]
20140516 03:31:38-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140516 03:32:27< mattsc> IT’s this image: https://github.com/wesnoth/wesnoth/blob/master/data/core/images/portraits/orcs/transparent/assassin.png
20140516 03:32:30< shadowm> mattsc: The reason I suggested rewriting images is that our optimization processes rely on external tools that produce results that occasionally trigger bugs in PNG decoding implementations.
20140516 03:32:35< mattsc> that is being displayed in the help menu, right?
20140516 03:33:27< shadowm> Also, I suggested that because I see a sprite rendered normally in the same screenshot, as well as several other graphics (including the section icons and the dialog frame and background), so that'd point to an issue with specific files.
20140516 03:33:48< shadowm> Files that tend to only change at the whim of the wesnoth-optipng pipeline.
20140516 03:34:46< mattsc> shadowm: right, that’s why I am asking.  Because github claims that that file has not been changed in 3 years.
20140516 03:34:49< shadowm> It doesn't seem like that one in particular has changed since 2011, but perhaps some other environmental factor has.
20140516 03:35:39< shadowm> Now, if you can reproduce it with every other portrait in the help system that'd be another story.
20140516 03:36:22< shadowm> It just occurred to me that our scaling algorithm has also been tweaked during 1.11.x, no idea how recently though.
20140516 03:36:22< mattsc> I can.  They all look blue.
20140516 03:36:29< mattsc> But only in the help menu.
20140516 03:36:42< mattsc> If I use them in a message, they look just fine.
20140516 03:37:20< mattsc> http://imgur.com/JU16bVp
20140516 03:37:33< shadowm> imagebin became an attack vector? Huh.
20140516 03:39:04< mattsc> http://imgur.com/q1ef9mX
20140516 03:39:19< mattsc> So something’s specific about the help menu portraits.
20140516 03:40:59< mattsc> I’ll do some bisecting tomorrow to see if I can trace it to a specific commit.  Right now I am too distraught by Fred’s reawakened stupidity.
20140516 03:41:51< shadowm> Actually...
20140516 03:42:08< shadowm> I've been looking in the wrong place, probably. The scaling is specified by WML: small_profile="portraits/orcs/transparent/assassin.png~SCALE(205,205)"
20140516 03:42:49-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 258 seconds]
20140516 03:42:52< shadowm> ~SCALE() uses scale_surface() from src/sdl_utils.cpp.
20140516 03:42:55< mattsc> Hmm...
20140516 03:44:05< shadowm> The only relevant change in months was Pandora-specific, so... 
20140516 03:45:04< mattsc> shadowm: If I scale the message image to 205x205, the assassin still doesn’t look blue, so that’s not it.
20140516 03:45:35< shadowm> Okay, I'm leaving the rest to you. :P
20140516 03:46:03< mattsc> shadowm: alright.  Tomorrow…  Thanks for the pointers though.
20140516 04:04:51-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140516 04:05:02< iceiceice> gfgtdf: ok i have managed to get through like half of LoW after your patch
20140516 04:05:11< iceiceice> i think it is clearly good, i am going to apply to 1.12 and master
20140516 04:07:31< irker755> wesnoth: gfgtdf wesnoth:1.12 86675bee65c9 / src/play_controller.cpp: sync unit creation in [side] http://git.io/nPURQQ
20140516 04:08:14< irker755> wesnoth: gfgtdf wesnoth:master da388ce21a7d / src/play_controller.cpp: sync unit creation in [side] http://git.io/6EQ2MA
20140516 04:10:22< iceiceice> good news everyone, LoW can now be successfully played in networked mp through like scenario 9 of 15 before encountering blockers!
20140516 04:10:33< iceiceice> previously we usually peetered out around scenario 2 or 3
20140516 04:10:50< mattsc> yay!
20140516 04:10:52< iceiceice> so from the standpoint of networked mp, this is the most productive day yet in the history of 1.12 :)
20140516 04:11:26< mattsc> Now if I could only whip up a worthy AI opponent for you …  :(
20140516 04:12:43< iceiceice> well theres always another day but lets drink to our successes, shall we
20140516 04:13:49< mattsc> Oh, don’t think that I am only starting now …
20140516 04:14:25< mattsc> But yes, cheers to you(s)
20140516 04:28:18< mattsc> shadowm: I have by now ruled out the SDK I am using as the potential cause as well.  At some point I switched from the OS X 10.8 to the 10.9 SDK, but that’s not it either.
20140516 04:42:46-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection]
20140516 04:43:19-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140516 04:43:46-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 258 seconds]
20140516 04:47:39-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 252 seconds]
20140516 04:55:21-!- wesbot changed the topic of #wesnoth-dev to: 1.11.14 (1.12 beta 5) is too buggy to be announced | string+feature freeze active on 1.12 | 240 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140516 05:10:09< mattsc> shadowm: Well, since it’s mostly just sitting and waiting, I did the bisecting after all.
20140516 05:10:22< mattsc> It’s actually one of yours: https://github.com/wesnoth/wesnoth/commit/9144fe1e3cb5fdb6360fecea6d6aac64503f4461
20140516 05:10:58< mattsc> But don’t ask me why, I don’t understand those kinds of things.
20140516 05:18:29< shadowm> I think I'll have to defer to mordante for this one. Could you file a bug?
20140516 05:19:42< shadowm> Where is the ~BG() function involved, though?
20140516 05:19:54-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 240 seconds]
20140516 05:20:28< shadowm> src/help.cpp:1412:                      ss << "<img>src='" << male_portrait << "~BG()' align='right'</img> ";
20140516 05:20:31< shadowm> src/help.cpp:1416:                      ss << "<img>src='" << female_portrait << "~BG()' align='right'</img> ";
20140516 05:20:34< shadowm> Okay, I got my answer.
20140516 05:21:39< shadowm> So, a fix for a bug creates a platform-specific bug. Sigh.
20140516 05:22:16 * shadowm just remembered why he's not felt like working in Wesnoth for a while. ¬_¬
20140516 05:24:16-!- Ivanovic [~ivanovic@frnk-4d016b23.pool.mediaways.net] has quit [Changing host]
20140516 05:24:16-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140516 05:27:33 * mattsc is moving toward a Wesbreak as well …
20140516 05:28:25-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20140516 05:28:42< mattsc> shadowm: agreed.  Sigh.  I’ll do the bug report, but I’ve way overstretched my allowable time for Wesnoth today, so as simple as it is, it’ll have to wait until tomorrow.
20140516 05:37:33< shadowm> I really want to know exactly when game_config::path can be empty and not screw up everything, including security.
20140516 05:39:45< shadowm> Not early startup, not campaignd, not wesnothd. I'll assume the best and drop an assert.
20140516 05:40:33< shadowm> Hmph, the changelog is a grammatical mashup of incompatible tenses.
20140516 05:40:54< shadowm> Ah, some day, some day...
20140516 05:41:33-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Disconnected by services]
20140516 05:41:48-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140516 05:48:34< irker755> wesnoth: Groggy Dice wesnoth:1.12 f859ceee06d7 / data/tools/addon_manager/style.css: style.css: no margin-bottom for <pre> http://git.io/7YlLYQ
20140516 05:48:36< irker755> wesnoth: Groggy Dice wesnoth:1.12 58c8e35b5e13 / data/tools/wmllint: wmllint: warn about no side key in [set/(dis)allow_recruit],[store_gold] http://git.io/vd7xsQ
20140516 05:48:38< irker755> wesnoth: Groggy Dice wesnoth:1.12 02aff87a26a5 / data/tools/wmllint: wmllint: warn about no side key in [*_shroud],[gold],[modify_side/ai] http://git.io/obcPog
20140516 05:48:40< irker755> wesnoth: Groggy Dice wesnoth:1.12 be1fc5a6dee2 / data/tools/wmllint: wmllint: put off dryrun's verbosity check until after options are processed http://git.io/NcoRvw
20140516 05:48:42< irker755> wesnoth: Groggy Dice wesnoth:1.12 625f22e595aa / data/tools/wmllint: wmllint: add option to turn off missing side= key warning http://git.io/0gRDeQ
20140516 05:48:44< irker755> wesnoth: Groggy Dice wesnoth:1.12 b7b8e54c0676 / data/tools/addon_manager/html.py: html.py: hone regexes for URL linking http://git.io/tOcY7g
20140516 05:48:46< irker755> wesnoth: Groggy Dice wesnoth:master e3adf001a87a / data/tools/addon_manager/html.py: html.py: hone regexes for URL linking http://git.io/rojLgQ
20140516 05:48:48< irker755> wesnoth: Groggy Dice wesnoth:master 1a794a2d1e84 / data/tools/wmllint: wmllint: warn about no side key in [set/(dis)allow_recruit],[store_gold] http://git.io/iLVk9w
20140516 05:48:50< irker755> wesnoth: Groggy Dice wesnoth:master d866189a0e80 / data/tools/wmllint: wmllint: warn about no side key in [*_shroud],[gold],[modify_side/ai] http://git.io/6VTx0Q
20140516 05:48:52< irker755> wesnoth: Groggy Dice wesnoth:master 93353ee0a67b / data/tools/wmllint: wmllint: add option to turn off missing side= key warning http://git.io/ElmLnw
20140516 05:50:37< irker755> wesnoth: Ignacio R. Morelle wesnoth:master 314425ab0e57 / changelog src/filesystem.cpp: fs: Use game data path to resolve ./ in the absence of a current_dir http://git.io/SQDGog
20140516 05:50:40< irker755> wesnoth: Ignacio R. Morelle wesnoth:master 9f458d1bb29c / src/filesystem.cpp: fs: Assert that game_config::path is not empty in get_wml_location() http://git.io/ZbgOgg
20140516 06:03:35-!- cib [~cib@p508BCD3D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140516 06:03:59-!- cib is now known as Guest94417
20140516 06:04:00< irker755> wesnoth: Ignacio R. Morelle wesnoth:1.10 af61f9fdd15c / changelog src/filesystem.cpp: fs: Use game data path to resolve ./ in the absence of a current_dir http://git.io/T_Zg1g
20140516 06:04:14< irker755> wesnoth: Ignacio R. Morelle wesnoth:1.12 4f413130fb92 / changelog src/filesystem.cpp: fs: Use game data path to resolve ./ in the absence of a current_dir http://git.io/9WMZ8Q
20140516 06:13:38-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140516 06:16:11< shadowm> Ivanovic: For your consideration: https://gna.org/bugs/index.php?22042   Do what you feel best with the information provided therein.
20140516 06:16:51-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140516 06:25:37-!- groggy [~chatzilla@24-182-87-155.dhcp.hckr.nc.charter.com] has joined #wesnoth-dev
20140516 06:30:14-!- Guest94417 [~cib@p508BCD3D.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20140516 06:32:48< irker755> wesnoth: Ignacio R. Morelle wesnoth:master eb931a5ea373 / changelog src/game_events/action_wml.cpp: Refresh team flags after using [modify_side] color= without a new flag set http://git.io/JLmiGg
20140516 06:32:51< irker755> wesnoth: Ignacio R. Morelle wesnoth:1.12 68b5fc188435 / changelog src/game_events/action_wml.cpp: Refresh team flags after using [modify_side] color= without a new flag set http://git.io/kI14oQ
20140516 06:33:24-!- travis-ci [~travis-ci@ec2-54-83-147-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20140516 06:33:24< travis-ci> [travis-ci] wesnoth/wesnoth#2667 (1.10 - af61f9f : Ignacio R. Morelle): The build is still failing.
20140516 06:33:24< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25305298
20140516 06:33:24-!- travis-ci [~travis-ci@ec2-54-83-147-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20140516 06:34:00< shadowm> groggy: Hi.
20140516 06:37:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140516 06:39:16< shadowm> groggy: I wonder if you realize that while 7ba550a63edac4e5208b3b6a41796ed79bca8b07 fixes the issue for users of the web interface, they are a tiny minority compared to the number of Linux and OS X users who experience the same issue with the built-in add-ons client due to the authors' incompetence.
20140516 06:40:43< shadowm> And while some people would propose having image::get_image() (and others) automatically replace backslashes with forward slashes, this might have a considerable performance penalty, especially for areas such as the terrain graphics builder.
20140516 06:41:36< Necrosporus> shadowm, maybe you rather reject path with \\ even in windows?
20140516 06:41:38< shadowm> An alternative would be to do the substitution only in the add-ons manager dialog implementation... and encourage more sloppy coding practices on the part of UMC maintainers that way.
20140516 06:41:57< Necrosporus> So addon' author will see their solution doesn't work immediately
20140516 06:42:18< shadowm> Necrosporus: That sounds easy to do until you consider that Windows or the user might throw a path containing \ at Wesnoth, i.e. for setting the data, config, or userdata paths.
20140516 06:42:44-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140516 06:43:35< shadowm> Although image::get_image() and the WML preprocessor both use relative paths for the most part, hm.
20140516 06:43:49< Necrosporus> shadowm, what about checking it when path is in wml code? or just throwing a warning when {} image path or sound path contain backslashes?
20140516 06:43:57< shadowm> The check would still need to be done at a higher level than I'd like.
20140516 06:45:45< Necrosporus> WML preprocessor?
20140516 06:46:03< shadowm> Meh, I don't want to give it much though. I just wanted to point out the futility in catering to add-on web users instead of the broader audience.
20140516 06:46:08< shadowm> thought
20140516 06:47:15< shadowm> There are like six candidates in filesystem.cpp for path validation.
20140516 06:47:40< shadowm> I'm not quite sure how many of them may randomly get fed a system-provided path.
20140516 06:53:38-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 255 seconds]
20140516 06:54:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140516 07:01:11< nurupo> do you guys have enough devs with windows installed?
20140516 07:03:35< nurupo> can provide with win xp license
20140516 07:11:06< Necrosporus> I'd rather have a playtester
20140516 07:20:06< groggy> I have a Linux partition, so I am aware of those x-platform issues
20140516 07:25:44-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140516 07:26:52< groggy> of course, some image paths get broken not because authors are "sloppy", but because images get renamed or moved around
20140516 07:28:36< groggy> like all the links to the loyalist horse unit sprites that are broken because they were deleted, and the new base sprites moved into subfolders
20140516 07:29:58< Necrosporus> Why not to avoid messing with existing image paths in core?
20140516 07:31:28-!- cib [~cib@132.231.178.205] has joined #wesnoth-dev
20140516 07:31:52-!- cib is now known as Guest13793
20140516 08:01:53-!- groggy [~chatzilla@24-182-87-155.dhcp.hckr.nc.charter.com] has quit [Remote host closed the connection]
20140516 08:17:14-!- Guest13793 [~cib@132.231.178.205] has quit [Ping timeout: 240 seconds]
20140516 08:31:47-!- mjs-de [~mjs-de@f049245026.adsl.alicedsl.de] has joined #wesnoth-dev
20140516 08:35:01< zookeeper> hah, the fun bug again
20140516 08:35:07< zookeeper> {DEBUG_MSG "22222222"}
20140516 08:35:25< zookeeper> prints out: 2.22222e+007
20140516 09:03:56-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 265 seconds]
20140516 09:05:07-!- mjs-de [~mjs-de@f049245026.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140516 09:21:17-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20140516 09:30:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140516 09:42:17< AI0867> zookeeper: did you want that as a string? Because that's a perfectly valid numerical representation
20140516 09:42:43< zookeeper> well i didn't want it any particular way, just a pointless debug message
20140516 09:44:37-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140516 09:50:52-!- ivanovic-work [a98ff473@gateway/web/freenode/ip.169.143.244.115] has joined #wesnoth-dev
20140516 09:54:47-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140516 10:02:35-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Quit: Vannak idők, mikor menni kell]
20140516 10:04:46-!- Guest13793 [~cib@132.231.178.83] has joined #wesnoth-dev
20140516 10:34:40-!- Octalot [~noct@87.113.142.209] has joined #wesnoth-dev
20140516 10:46:16-!- mjs-de [~mjs-de@f049245026.adsl.alicedsl.de] has joined #wesnoth-dev
20140516 10:55:21-!- wesbot changed the topic of #wesnoth-dev to: 1.11.14 (1.12 beta 5) is too buggy to be announced | string+feature freeze active on 1.12 | 239 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140516 11:18:55-!- EdB [~edb@ARennes-658-1-64-158.w2-14.abo.wanadoo.fr] has joined #wesnoth-dev
20140516 11:58:18-!- ivanovic-work [a98ff473@gateway/web/freenode/ip.169.143.244.115] has quit [Ping timeout: 240 seconds]
20140516 12:13:06-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer]
20140516 12:13:15-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140516 12:36:27-!- irker755 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140516 12:52:04-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Changing host]
20140516 12:52:04-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20140516 13:06:29-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140516 13:18:02-!- EdB [~edb@ARennes-658-1-64-158.w2-14.abo.wanadoo.fr] has quit [Quit: Konversation terminated!]
20140516 13:29:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140516 13:38:28-!- Guest13793 [~cib@132.231.178.83] has quit [Read error: Connection reset by peer]
20140516 13:46:02-!- Netsplit *.net <-> *.split quits: Gallaecio_, cib0, Appleman1234, loonycyborg
20140516 13:46:03-!- Netsplit over, joins: cib0
20140516 13:47:09-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20140516 13:47:13-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev
20140516 13:47:38-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has joined #wesnoth-dev
20140516 14:03:45-!- gfgtdf [~chatzilla@d227074.adsl.hansenet.de] has joined #wesnoth-dev
20140516 14:04:13< gfgtdf> does anyone knwos why we use "helper.set_wml_var_metatable(_G)" in the example in the wiki ? helper.set_wml_var_metatable(_G) is the last i'd do.
20140516 14:08:13-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140516 14:44:20-!- Sulfur [~Miranda@p5B0083F4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140516 14:45:09-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140516 14:51:19< gfgtdf> ok i'll rmeove the sameplcode to use helper.set_wml_var_metatable(_G) from the wiki, and reccomend not to do so
20140516 15:09:00-!- Guest13793 [~cib@p508BCD3D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140516 15:16:57< mattsc> shadowm, mordante: blue color bug in unit help on Mac OS X  reported: https://gna.org/bugs/index.php?22045
20140516 15:17:13< mattsc> Should I assign it to either one of you?
20140516 15:19:58-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140516 15:42:28< gfgtdf> does anyone know whether there is a way to know in lua wheter we are in a replay or not in 1.12?
20140516 16:00:59< mattsc> gfgtdf: nothing that I am aware of
20140516 16:03:40< gfgtdf> mattsc: i think maybe settign a gobal variable and thene checking whether teh gobal variable equals the value could work.
20140516 16:03:49< gfgtdf> at lest fpor my purposes
20140516 16:03:51< gfgtdf> for
20140516 16:45:01-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140516 16:54:38-!- Bodhi-Baum [~Bodhi@dslb-084-063-057-150.pools.arcor-ip.net] has joined #wesnoth-dev
20140516 16:55:21-!- wesbot changed the topic of #wesnoth-dev to: 1.11.14 (1.12 beta 5) is too buggy to be announced | string+feature freeze active on 1.12 | 240 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140516 17:05:17-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140516 17:15:59-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Ping timeout: 276 seconds]
20140516 17:17:09-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140516 17:20:53< zookeeper> gfgtdf, you typoed the add-on, it should be "prepAration" :P
20140516 17:20:57 * zookeeper is looking at the code
20140516 17:21:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140516 17:21:17< gfgtdf> in the name you mean ?
20140516 17:21:34< zookeeper> yes
20140516 17:21:38< gfgtdf> ok fixed
20140516 17:23:14< gfgtdf> 	zookeeper: the addon on teh server onyl works with 1.13 but i will soon release a version that should work with version 1.11.13+ too
20140516 17:25:52< zookeeper> gfgtdf, hmh, got some lua errors after confirming the unit setup: http://pastebin.com/Bxmb116a
20140516 17:26:11< zookeeper> (on 1.11.13)
20140516 17:28:27< gfgtdf> ye the version of the server doesnt work with 1.11.13
20140516 17:29:30< gfgtdf> zookeeper: i uploaded a version that shoudl work with 1.11.13 too
20140516 17:30:08< zookeeper> okay
20140516 17:32:02< gfgtdf> 	zookeeper: i include the luafiles in the wml to not require download, the disadvantage is that that doesnt give good erromessages, if you want better errormessafges you can define "PYR_NPT_REQUIRE_DOWNLOAD" in the file macros/lua.cfg  there yould be an out commented code somewhere
20140516 17:38:20< gfgtdf> zookeeper: can you please tell me whether it works wit that version ?
20140516 17:38:43< gfgtdf> (0.4)
20140516 17:40:41< zookeeper> web interface still shows 0.3.2
20140516 17:41:06< zookeeper> it updates with a delay, or so i recall someone saying
20140516 17:41:14< zookeeper> dunno what the port is so i could connect in-game
20140516 17:41:18-!- Sulfur [~Miranda@p5B0083F4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140516 17:42:05< gfgtdf> 	zookeeper: idnt it teh default for 1.11 and 1.13 ?
20140516 17:42:10< gfgtdf> isn't it teh default
20140516 17:42:55< zookeeper> oh nvm
20140516 17:43:21< zookeeper> i just didn't remember that the default sorting in-game isn't the order of download anymore
20140516 17:43:39< zookeeper> 20140516 20:42:49 error general: A problem occurred when trying to create the files necessary to install this add-on.
20140516 17:44:19< gfgtdf> 	zookeeper: :O on downloading teh addon ?
20140516 17:44:30< zookeeper> yes
20140516 17:44:37< zookeeper> it did delete the old files though
20140516 17:44:44< zookeeper> i just relaunched the game and tried again and it worked then
20140516 17:44:50< gfgtdf> :/, teh whole folder ?
20140516 17:44:53< zookeeper> yes
20140516 17:44:54< gfgtdf> ah ok
20140516 17:45:49< zookeeper> yeah, no errors now
20140516 17:46:11< gfgtdf> :)
20140516 17:46:25< zookeeper> dunno if intentional or not, but in hotseat i got the unit picking dialogs for both sides one after the other, instead of unit picking for side 2 happening at the beginning of side 2's turn
20140516 17:47:19< gfgtdf> zookeeper: intentional all sides pick their untis in tht start event
20140516 17:48:00< zookeeper> even in networked? okay
20140516 17:48:51< gfgtdf> zookeeper: in networked mp teh y shoudl pick their units simulaniusly in the start event. ('one after another' is not the intended behaviour)
20140516 17:49:37< zookeeper> yeah, i just tested networked and it happened concurrently
20140516 17:49:54< gfgtdf> :)
20140516 17:49:56< zookeeper> that's pretty neat, although maybe confusing for side 1 when they're done and are wondering why they can't do anything or even end turn?
20140516 17:50:08< zookeeper> (because others are still picking)
20140516 17:51:36< gfgtdf> zookeeper: you think we shoudl add a notification about that somehwere? i don't think i't possible to make a 'waiting fot other players input' somewhere
20140516 17:51:48< gfgtdf> dialog
20140516 17:52:00-!- Sulfur [~Miranda@p5B0083F4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140516 17:53:33< gfgtdf> 	zookeeper: or we add something in teh code a messaage that always appeary when a client waits for networkes input for > 5sec of something
20140516 17:53:40< gfgtdf> cpp code i mean
20140516 17:54:11< zookeeper> well it could be something simple like an equivalent of [print]. i dunno how your lua code works (in fact i'm surprised concurrent picking can even work; it's rather cool) so can't say what it could do
20140516 17:55:54< gfgtdf> 	zookeeper: the 'waiting' loop takes place in teh c++ code (it's this loop https://github.com/wesnoth/wesnoth/blob/master/src/replay.cpp#L979), we i cannot change it form lua/cpp
20140516 17:55:58< gfgtdf> lua/wml i mean
20140516 17:57:17< gfgtdf> 	zookeeper: not that in 1.11 'the std::set<int> sides' contins always just 1 element
20140516 17:57:44-!- EdB [~edb@ARennes-658-1-64-158.w2-14.abo.wanadoo.fr] has joined #wesnoth-dev
20140516 17:59:57< gfgtdf> s/not/note
20140516 18:05:27-!- Octalot [~noct@87.113.142.209] has quit []
20140516 18:08:48< iceiceice> happygrue: hey, i noticed a minor change that Horus made to one of the mainline maps that i think we should merge into mainline
20140516 18:09:01< iceiceice> its not really a balance change, its more of a notice to the player that something funny is going on
20140516 18:09:20< iceiceice> in Elensefar courtyard there is this region at the right of the map that is unaffected by the day night cycle
20140516 18:09:44< iceiceice> but it is perhaps a bit hard to figure out what is going on there if you are a new player
20140516 18:09:52< iceiceice> i posted in the forums about this once like 6 months ago
20140516 18:11:50< happygrue> That seems like a good idea to me.  busy at the moment, but let's run it by Velensk and maybe he can write up something about it.
20140516 18:11:51< iceiceice> in the PYRA addon there is a small message given to all the players explaining that it's unaffected
20140516 18:11:51< iceiceice> http://pastebin.com/j1xRyzXC
20140516 18:11:51< iceiceice> http://pastebin.com/qkam67iV
20140516 18:11:54< iceiceice> ok
20140516 18:12:35< happygrue> he needs some more commits I guess, so lettting him do it would and make the PR would be a good idea I think.
20140516 18:13:13< iceiceice> hehe ok
20140516 18:13:32< iceiceice> Velensk: ^^
20140516 18:24:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140516 18:45:51-!- _8680_ [~8680@2002:4404:712c:0:a8bf:1765:6930:b16] has quit [Ping timeout: 252 seconds]
20140516 18:46:35-!- _8680_ [~8680@2002:4404:712c:0:b0d0:c31e:eda6:c3f1] has joined #wesnoth-dev
20140516 18:50:56-!- Guest13793 [~cib@p508BCD3D.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20140516 19:09:06< iceiceice> btw: i tracked down my forum post that complained about it, it was this one: http://forums.wesnoth.org/viewtopic.php?f=4&t=39388#p560111
20140516 19:12:18< iceiceice> another thing I guess we could do is, add notes for schedule-underground-illum and/or schedule-indoors to the TOD help, i think its in data/core/help.cfg
20140516 19:17:03-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Read error: Connection reset by peer]
20140516 19:29:42< iceiceice> gfgtdf:
20140516 19:29:47< iceiceice> i think there might be a bug here: https://github.com/wesnoth/wesnoth/blob/master/src/synced_commands.cpp#L279
20140516 19:29:58< iceiceice> in the one check you check attribute "skip_sighed"
20140516 19:30:02< iceiceice> and in the other you check "skip_sighted"
20140516 19:30:34< iceiceice> i was going to go through and change all the "sighed" to "sighted" but leave a check to "sighed" for backwards compatibility
20140516 19:30:49< iceiceice> but now i wonder if we shouldnt just abandon sighed if theres already a bug
20140516 19:31:10< happygrue> I think ideally terrian that is permenently a certain ToD would have a visual marker on it (ray of light, shadow somewhere, mix of both for neutral?), but it really only comes into play when it is different than most of the map terrian
20140516 19:31:14< gfgtdf> the code that writes it also used 'skip_sighed'
20140516 19:31:20< gfgtdf> butye it is a bug
20140516 19:31:29< gfgtdf> https://github.com/wesnoth/wesnoth/blob/master/src/replay_helper.cpp#L73
20140516 19:31:47< happygrue> iceiceice: did you mention siege of elensefar anywhere there too?  That has a cave that is night
20140516 19:32:09< iceiceice> what's siege of elensefar?
20140516 19:32:26< happygrue> a major scenario in HttT
20140516 19:32:36< iceiceice> oh i think i might know that one :)
20140516 19:32:41< happygrue> it probably gets used elesewhere in mainline
20140516 19:32:44< iceiceice> is that the one where you get 4 thieves and try to assassinate the leader?
20140516 19:32:59< iceiceice> err rogues or something
20140516 19:33:09< happygrue> any time you have a regular map and then go into a cave for part of it, I would guess the writer probably would make it night there (aka underground)
20140516 19:33:14< happygrue> yes
20140516 19:33:19< happygrue> that one
20140516 19:33:29< iceiceice> hmm so looking in the data/core/help we already have a listing for underground (cave)
20140516 19:33:29< gfgtdf> iceiceice: i think ' if(child["skip_sighed"] == "all" || child["skip_sighted"] == "all" ) ' would look very stupid i think
20140516 19:33:33< happygrue> it DOES show as different in the ToD box when you hover over it
20140516 19:33:45< iceiceice> gfgtdf: could so something like
20140516 19:33:46< happygrue> (it shows up as underground), but that is not always helpful to a new player
20140516 19:33:50< happygrue> and you have to be looking for it
20140516 19:33:59< gfgtdf> i prsonaly have no problme with abandon  it
20140516 19:34:02< gfgtdf> problem
20140516 19:34:08< iceiceice> ok
20140516 19:34:15< iceiceice> i guess it will break save compatibility, idk if we care
20140516 19:34:21< iceiceice> thats the only reason i borught it up
20140516 19:34:27< gfgtdf> but it moght break replay compability to ceryio  1.11.13
20140516 19:34:44< gfgtdf> save can sill be loaded but not replays i guess
20140516 19:34:45< iceiceice> happygrue: the thing i was worried about when i was a new player is,
20140516 19:34:47< gfgtdf> still
20140516 19:34:54< iceiceice> what is it going to do in the NEXT tod?
20140516 19:35:28< iceiceice> even though it shows you the bonuses when you mouse over i dont know what it will be the next turn
20140516 19:35:51< iceiceice> gfgtdf: ok lets just abandon i would say then
20140516 19:36:04< happygrue> yeah, I have wondered about that too, but on the other hand, it could also be MORE confusing for new players if they have to not only mess with ToD now but also means of shifting around and seeing future ToD
20140516 19:36:04< iceiceice> i dont think theres any important replays out there right now, or even any posted in bug reports that i recall
20140516 19:36:06< gfgtdf> 	iceiceice: but if we do so we halla have to do it before the next 1.11 release
20140516 19:36:12< happygrue> IMO that is just what you learn with experience
20140516 19:36:22< iceiceice> y
20140516 19:36:31< happygrue> at least, there is a risk of making it even more complicated
20140516 19:36:32< iceiceice> but for the mainline TOD we can at least say what the picture means in the help
20140516 19:36:57< gfgtdf> iceiceice: i think most beoeple dont used teh 1..11.13 version anyway becasue of the annoying move+attack bot working bug
20140516 19:37:01< gfgtdf> people
20140516 19:37:04< iceiceice> y
20140516 19:50:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20140516 19:51:47-!- irker930 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140516 19:51:47< irker930> wesnoth: Chris Beck wesnoth:master 403af25e9da7 / src/ (actions/move.cpp replay_helper.cpp replay_helper.hpp synced_commands.cpp): fix a bug, replace sighed -> sighted in move records http://git.io/8aTQsA
20140516 19:53:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140516 19:55:08< iceiceice> hmm i think maybe i will make a unit test to check sighted events, just to make sure this is workign now
20140516 19:58:11< Necrosporus> Can I make units leave traces on map?
20140516 19:58:18-!- _8680_ [~8680@2002:4404:712c:0:b0d0:c31e:eda6:c3f1] has quit [Ping timeout: 245 seconds]
20140516 19:58:23< Necrosporus> I mean on specific terrains
20140516 19:58:26< Necrosporus> Like snow or sand
20140516 19:58:35< Necrosporus> but not grass of forest
20140516 19:59:06-!- _8680_ [~8680@2002:4404:712c:0:d17a:a232:c560:b22c] has joined #wesnoth-dev
20140516 20:03:10-!- EdB [~edb@ARennes-658-1-64-158.w2-14.abo.wanadoo.fr] has quit [Quit: Konversation terminated!]
20140516 20:04:23< gfgtdf> Necrosporus: you could try doung so  with the leave_hey event
20140516 20:04:29< gfgtdf> doing
20140516 20:04:34< gfgtdf> leave_hex
20140516 20:07:29< Necrosporus> gfgtdf, my ability doesn't seem to work with resting either
20140516 20:07:34-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140516 20:07:54< gfgtdf> 	Necrosporus: the hides ability ?
20140516 20:08:30< Necrosporus> http://pastebin.com/3SzLPrmf
20140516 20:08:33< Necrosporus> Yes
20140516 20:14:14< gfgtdf> hmm still looks correct to me
20140516 20:14:33< gfgtdf> 	Necrosporus: and itworks in human vs human games ?
20140516 20:14:47< gfgtdf> iceiceice: you pish that to 1.12 too ?
20140516 20:14:54< iceiceice> y i got distracted, one sec :)
20140516 20:15:22< Necrosporus> gfgtdf, not tested, though with _only_ moves=$this_unit.max_moves it worked, if I remember correctly
20140516 20:16:08< gfgtdf> 	Necrosporus: how did you test that it doesnt work with ai units ?
20140516 20:16:09< Necrosporus> Seems AI is dropping moves to 0 without apparent reason in 1.10.7
20140516 20:17:11< Necrosporus> gfgtdf, I start wesnoth in debug mode, then use airlock march or something, giving leaders the ability, then I droid one and observe
20140516 20:17:32< gfgtdf> what is airlock march ?
20140516 20:19:50< irker930> wesnoth: Chris Beck wesnoth:1.12 bd4dd0535f21 / src/ (actions/move.cpp replay_helper.cpp replay_helper.hpp synced_commands.cpp): fix a bug, replace sighed -> sighted in move records http://git.io/3bR8Aw
20140516 20:19:52< irker930> wesnoth: Chris Beck wesnoth:1.12 a07cb9e99408 / changelog: update changelog http://git.io/_QxlQA
20140516 20:20:01< Necrosporus> gfgtdf, 3p map from default set
20140516 20:21:27-!- Bodhi-Baum [~Bodhi@dslb-084-063-057-150.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140516 20:22:06-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140516 20:25:24< gfgtdf> Necrosporus: i just tested myself and teh ability forkes for my ai leader too
20140516 20:25:28< gfgtdf> worked
20140516 20:25:34< gfgtdf> iceiceice: :)
20140516 20:27:32< iceiceice> gfgtdf: yeah i mean i havent really tested it, i'm going to make a unit test for that though i think
20140516 20:27:51< iceiceice> i dont see that it could be worse than it was anyways
20140516 20:27:55< gfgtdf> iceiceice: how did you notied that bug ?
20140516 20:28:18< iceiceice> i decided to go through and fix various typos in the source,
20140516 20:28:27< iceiceice> before there was one about "get_syced_state"
20140516 20:28:40< gfgtdf> ah ok, so you didn't notice it ingame ?
20140516 20:28:41< iceiceice> it just makes it harder to write the code if you have to remember unusual spellings
20140516 20:28:46< iceiceice> no i didnt notice in game
20140516 20:29:09< iceiceice> i found on stackoverflow there is some way you can do recursive find and replace in a git repo
20140516 20:29:21< iceiceice> apparently you can get big big problems if you do it naively,
20140516 20:29:33< iceiceice> like if the find and replace goes into your .git folders then i guess you correupt your whole repo
20140516 20:29:58< gfgtdf> iceiceice: i usually eigher copy functionnmaes or use the ide's auto completion
20140516 20:29:58< iceiceice> but if you use git grep then it works
20140516 20:30:04< iceiceice> y i dont use an ide :)
20140516 20:30:05< gfgtdf> so i dont notice 
20140516 20:30:26< iceiceice> anyways i saw "sighed" in my console log at some point so i decide to do the same thing
20140516 20:30:44< iceiceice> but then i saw the bug thing
20140516 20:30:45< gfgtdf> iceiceice: how does debuggign work without an ide ? :O
20140516 20:30:54< iceiceice> idk what do hyou mean
20140516 20:31:13< iceiceice> i guess i just use gdb
20140516 20:31:27< gfgtdf> hm ok i'll look gdb at google
20140516 20:32:24< gfgtdf> lol, googelign 'gdb' google gave me 'Grad der Behinderung'
20140516 20:34:18< iceiceice> lol
20140516 20:34:35< iceiceice> heres the wiki page: http://en.wikipedia.org/wiki/GNU_Debugger
20140516 20:36:03< gfgtdf> ye i found, 'grad der behinderung' is just funny becasue thats means 'Level of annoyance' translated.
20140516 20:36:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Ciao]
20140516 20:37:12< iceiceice> oh i see
20140516 20:37:46< iceiceice> its weird the way that different people get different things when they google for stuff like that
20140516 20:39:42-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140516 20:48:47-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140516 20:53:33< irker930> wesnoth: Chris Beck wesnoth:master 34402b6a88b3 / changelog: update changelog http://git.io/gDv8Ew
20140516 20:56:25< gfgtdf> iceiceice: you you think we need a changelog entry for a bug that was never in a previously released version ?
20140516 20:57:12< iceiceice> you mean like it wasnt in 1.10?
20140516 20:57:22< iceiceice> idk it was in 1.11.13, no?
20140516 20:57:39< iceiceice> maybe im being silly, i just reflexively put it in
20140516 20:59:22< gfgtdf> iceiceice: yes it was in 1.13, and no the skip_sighted key was new in 1.11.13 
20140516 20:59:28< gfgtdf> in 1.11.13 i mean
20140516 21:02:03-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
20140516 21:02:29< gfgtdf> iceiceice: do you know whether RiftWalkers gsoc project implies enabling mod in sp ? Or is that a differnt taks ?
20140516 21:16:03-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140516 21:18:25-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140516 21:18:54< iceiceice> gfgtdf: i'm not sure
20140516 21:29:48-!- gfgtdf_ [~chatzilla@e177164014.adsl.alicedsl.de] has joined #wesnoth-dev
20140516 21:32:05-!- gfgtdf [~chatzilla@d227074.adsl.hansenet.de] has quit [Ping timeout: 276 seconds]
20140516 21:32:13-!- gfgtdf_ is now known as gfgtdf
20140516 21:33:26< gfgtdf> do you think we need a offical variables naming convention so taht variables used by addon, erays and scenario don't interfere with each other ?
20140516 21:33:55< shadowm> Variables?
20140516 21:33:58< gfgtdf> for lua/wml variable sin assons i mean
20140516 21:34:02< gfgtdf> assons
20140516 21:34:04< gfgtdf> add ons
20140516 21:34:33< shadowm> Well, in mainline macros we always prefix variables with "temp_MACRO_NAME", don't we?
20140516 21:35:07< shadowm> e.g. "temp_MACRO_NAME_i" for an iteration value.
20140516 21:35:53< gfgtdf> i dont know. but i thought more about persitent variables than about temp vraiables
20140516 21:36:13< shadowm> Aren't people supposed to use namespaces for those?
20140516 21:36:32< gfgtdf> what namespaces do you mean ?
20140516 21:36:46< shadowm> http://wiki.wesnoth.org/PersistenceWML#About_Namespaces  http://wiki.wesnoth.org/PersistenceWML#namespace
20140516 21:37:17< gfgtdf> no not that persistent i just mena tnormal wml/lua variables that last longer than one event
20140516 21:37:18< shadowm> Althouhg the feature was broken up to 1.10.something and caused various memory corruption issues.
20140516 21:38:05< shadowm> OK, I think mods and eras should make sure to do the same as mainline macros and allow the primary add-ons to do whatever they want with regards to naming
20140516 21:39:09< shadowm> And surely we don't have an official convention, but how many people do you think would bother to read and comply with one if it exists?
20140516 21:39:18< shadowm> *existed   gods i can't type today blaaargh
20140516 21:39:34< gfgtdf> hm sounds valid.
20140516 21:40:32< gfgtdf> shadowm: i just came to this topic when i saw that the wiki suggested to use H.set_wml_var_metatable(_G) which can have suprirsing effect for other addons/modifications
20140516 21:54:50-!- mjs-de [~mjs-de@f049245026.adsl.alicedsl.de] has quit [Ping timeout: 276 seconds]
20140516 22:09:00-!- Sulfur [~Miranda@p5B0083F4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140516 22:10:08< irker930> wesnoth: Chris Beck wesnoth:master 0201fe3247b5 / data/test/ (macros/wml_unit_test_macros.cfg maps/generic_unit_test.map): put generic unit test map in its own file http://git.io/DaYZXw
20140516 22:10:10< irker930> wesnoth: Chris Beck wesnoth:master 9df026f8e8c3 / data/test/ (maps/test_grunt_tod_damage.map scenarios/test_grunt_tod_damage.cfg): move test_grunt_tod_damage map to a map file http://git.io/MxkKiA
20140516 22:10:12< irker930> wesnoth: Chris Beck wesnoth:master 94fdab4389eb / / (6 files in 3 dirs): add sighted events unit tests http://git.io/dRNUZQ
20140516 22:12:49< gfgtdf> iceiceice: but that doest test the skip_sighted key in do_command does it ?
20140516 22:13:22< iceiceice> no
20140516 22:13:45< iceiceice> still need to make that
20140516 22:14:09< gfgtdf> ok
20140516 22:23:01-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20140516 22:25:21< iceiceice> hmm
20140516 22:25:44< iceiceice> gfgtdf: I think maybe should demote this to info:
20140516 22:25:44< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/synced_commands.cpp#L263
20140516 22:25:55< iceiceice> if its warning then it will be treated as an error i guess
20140516 22:25:58< iceiceice> in the unit tests
20140516 22:27:24< gfgtdf> iceiceice: hm do you know ans situation when we gat this waning and it woudl not ba a bug?
20140516 22:27:27< gfgtdf> any
20140516 22:27:33< iceiceice> no
20140516 22:27:41< iceiceice> but it sounds like you want to proceed with test?
20140516 22:27:41< iceiceice> idk
20140516 22:27:46< iceiceice> *proceed with move?
20140516 22:28:03< iceiceice> i mean the comment thinks there is some scenario i gues
20140516 22:28:46< gfgtdf> iceiceice: that code is suiet old, and i didnt write that code, but normal a user cannot trigger a move to a hey that is occuped from his point ov wiew
20140516 22:29:22< gfgtdf> iceiceice:not that thsi code uses find_visible_unit whcih i think shoudl alsorady ignore hidden /figged units or similar
20140516 22:29:28< gfgtdf> already*
20140516 22:30:09< iceiceice> hmm so maybe we should return false there i guess
20140516 22:30:43-!- c74d is now known as Guest38090
20140516 22:30:47-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140516 22:31:20< iceiceice> idk maybe its fine
20140516 22:31:27< gfgtdf> iceiceice: i didnt know so i left it how it is
20140516 22:31:38< iceiceice> y i guess it really shouldnt ever run
20140516 22:31:41< iceiceice> so it should be an error in the tests
20140516 22:31:55< iceiceice> but if its possible to continue the replay or w/e then why not
20140516 22:32:12< gfgtdf> we cna also call the error_handler and continue then nromaly without returning
20140516 22:32:13< gfgtdf> can
20140516 22:32:22-!- Guest38090 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140516 22:32:45< iceiceice> what does the error handler look like?
20140516 22:32:55< iceiceice> its a wrapper for some log?
20140516 22:32:58< iceiceice> or it throws an exception
20140516 22:33:10-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140516 22:33:47-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140516 22:34:02< gfgtdf> we do that on https://github.com/wesnoth/wesnoth/blob/master/src/synced_commands.cpp#L113 too, it depends on the caller, in replay it gives an OOS message, for normal human invoked actions it gives a assert(false) and for [do_command] it just gives a wanring.
20140516 22:34:41< iceiceice> i see
20140516 22:35:29-!- Netsplit *.net <-> *.split quits: higgins, iwaim__, happygrue, cjhopman
20140516 22:35:29< gfgtdf> iceiceice: but i dtn really have a problem with the current imeplemenation
20140516 22:35:42< iceiceice> y i guess its fine
20140516 22:36:04-!- Netsplit over, joins: happygrue, cjhopman, higgins
20140516 22:36:17-!- Netsplit over, joins: iwaim__
20140516 22:36:48< shadowm> gfgtdf: I don't really know what helper.set_wml_var_metatable() does, and I imagine whoever implemented and documented it might've only considered its usage in single-player.
20140516 22:37:25< shadowm> I don't know if it's just a stupid impression I have, but it seems like most past developers were more single-player-minded.
20140516 22:37:55< shadowm> Also, back then we didn't have MP mods, so there's that too.
20140516 22:37:58-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140516 22:38:07< gfgtdf> shadowm: i added soem comments here: http://wiki.wesnoth.org/LuaWML:Variables#helper.set_wml_var_metatable
20140516 22:40:06< happygrue> iceiceice: just checking the log and I noticed you don't have a cloak.  Did you want one?
20140516 22:40:20< iceiceice> whats a cloak?
20140516 22:40:45< happygrue> masks your ip when you log on and off, if you poke around in the log you'll see it (or do /whois)
20140516 22:40:51< shadowm> When I /whois iceiceice I get this: 18:40:38 [Freenode] -!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com]
20140516 22:41:01< gfgtdf> happygrue: i want a cloac too :)
20140516 22:41:02< iceiceice> oh i see
20140516 22:41:06< iceiceice> yeah cloak would be nice :)
20140516 22:41:12< shadowm> And when I /whois shadowm I get this: 18:41:00 [Freenode] -!- shadowm [~ignacio@wesnoth/developer/shadowmaster]
20140516 22:41:44< happygrue> Is it just Ivanovic who does it, or are you also a tailor shadowm?
20140516 22:41:50< shadowm> First thing is that you need to register and identify with nickserv.
20140516 22:42:03< shadowm> And make sure to have your client always identify on connect.
20140516 22:42:26< shadowm> Here's freenode's instructions on the matter: http://freenode.net/faq.shtml#nicksetup
20140516 22:42:50< shadowm> After you are set up, you have to ask Ivanovic for a cloak.
20140516 22:45:08-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Quit: this quit message is 100% guaranteed not to contain obscenity.]
20140516 22:45:16< happygrue> I think it's developers, translaters, and mp mods
20140516 22:45:25< shadowm> Forum mods too.
20140516 22:45:28< happygrue> ah, right.
20140516 22:45:32< shadowm> Also artists.
20140516 22:46:50-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140516 23:13:29< gfgtdf> wesbot: seen mattsc
20140516 23:13:29< wesbot> gfgtdf: The person with the nick mattsc last spoke 7h 12m ago.  2h 37m ago was here and on the channels #wesnoth, #wesnoth-de and #wesnoth-umc-dev with the message: Quit: Ciao
20140516 23:20:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20140516 23:29:16< iceiceice> hmmm
20140516 23:29:24< iceiceice> well the skip sighted seems to work but i get some wierd errors
20140516 23:29:27< iceiceice> err
20140516 23:29:28< iceiceice> not errors
20140516 23:29:30< iceiceice> its like,
20140516 23:29:39< iceiceice> in the cases where the test fails,
20140516 23:29:45< iceiceice> because you assert he ends at the wrong spot,
20140516 23:29:55< iceiceice> when you are in linger mode it appears he has some wierd subsequent orders
20140516 23:30:57< iceiceice> like here
20140516 23:30:57< iceiceice> http://i.imgur.com/a9oPaaM.png
20140516 23:31:07< iceiceice> idk what those other orders are, i did not click on anything and they aren't in my scenario
20140516 23:32:07-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140516 23:32:09< iceiceice> i'll commit the tests and someone can try to reproduce if they like
20140516 23:36:14< irker930> wesnoth: Chris Beck wesnoth:master 2c486ed6991d / / (3 files in 3 dirs): add tests of the [move] skip_sighted_option http://git.io/EthguQ
20140516 23:46:53< gfgtdf> iceiceice: you get the data strnage moves with skip_sighted?no too ?
20140516 23:47:08< iceiceice> its very strange
20140516 23:47:12< iceiceice> i think i get them whenever share_view = yes
20140516 23:47:19< iceiceice> and also when share_view = no, and skip_sighted = all
20140516 23:47:39< iceiceice> and only when the tests are set to "fail" by passing up the constants
20140516 23:47:48< iceiceice> if the tests end in victory i dont get the moves
20140516 23:47:58< iceiceice> s/passing/messing 
20140516 23:48:13< iceiceice> i'm making a bug report, with patch to break the constants easily
20140516 23:51:26< iceiceice> ohhh hmmm
20140516 23:51:33< iceiceice> so i think the issue is i miscounted actually
20140516 23:51:42< iceiceice> i ordered the grunt to move from x = 16 to x = 10
20140516 23:51:45< iceiceice> and it only have 5 mp
20140516 23:51:53< iceiceice> but still it should have given me OOS or something
20140516 23:53:01< iceiceice> oh its very wierd now
20140516 23:53:07< iceiceice> so heres what i did
20140516 23:53:23< iceiceice>             [move]
20140516 23:53:24< iceiceice>                 x=16,15,14,13,12,11,10
20140516 23:53:24< iceiceice>                 y=3,3,3,3,3,3
20140516 23:53:24< iceiceice>                 skip_sighted={SKIP_SIGHTED}
20140516 23:53:24< iceiceice>             [/move]
20140516 23:53:29< iceiceice> so theres 7 x numbers
20140516 23:53:32< iceiceice> and 6 y numbers
20140516 23:53:43< iceiceice> so there should have been a check that those lists are the same length i think
20140516 23:53:59< iceiceice> i guess whats happening is the last one is like a memory corruption or smth
20140516 23:54:14< iceiceice> like, the last y is out of bounds so it results in a crazy order
20140516 23:57:12< gfgtdf> iceiceice: im just looking at teh code
20140516 23:57:19< gfgtdf> iceiceice: and its indeeed funny
20140516 23:59:12< gfgtdf> iceiceice: in fact we use teh same function tahet we also use for location filters, so teh follwoign code is valis: x=1, y =1-3, which si equivalent to x=1,1,1, y = 1,2,3
20140516 23:59:17< gfgtdf> valid
20140516 23:59:36< gfgtdf> leving out a value default to 0-map_hewight/width
20140516 23:59:40< gfgtdf> leaving
--- Log closed Sat May 17 00:00:10 2014