--- Log opened Mon May 19 00:00:27 2014
20140519 00:02:26-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140519 00:03:15< gfgtdf> iceiceice: hm it currently seems ike something faild wuith the buidl bug msvc told me "success" ..
20140519 00:04:15< iceiceice> yeah i haven't used an ide in like 10 years so i couldn't really help you
20140519 00:04:28< gfgtdf> iceiceice: so maybe thats why i culd have an older version
20140519 00:04:33< iceiceice> y
20140519 00:04:40< iceiceice> whats the error?
20140519 00:04:45< iceiceice> i wonder if we introduced some msvc only bug
20140519 00:04:53< gfgtdf> no i fpound it
20140519 00:04:59< gfgtdf> i accidently lcicked debug build
20140519 00:05:01< gfgtdf> clicked
20140519 00:05:05-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 264 seconds]
20140519 00:05:19< gfgtdf> and then the .exe file got into the /debug folder
20140519 00:05:49< gfgtdf> iceiceice: ^
20140519 00:05:58< gfgtdf> and compiling again ...
20140519 00:06:12< iceiceice> ok
20140519 00:07:58< gfgtdf> iceiceice: ok the debug build gives me an assertion error immideately
20140519 00:08:05< iceiceice> where
20140519 00:08:19< iceiceice> debug wesnoth or debug tests
20140519 00:08:28< gfgtdf> i think debug wesnoth
20140519 00:08:38-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140519 00:08:44< gfgtdf> the message is tryign to dereference a vector<bool>
20140519 00:09:06< iceiceice> this is current master?
20140519 00:09:13< gfgtdf> iceiceice: yes
20140519 00:09:26< iceiceice> i usually build both release and debug,
20140519 00:09:40< iceiceice> but i think i dont have one since the chagne to team :/
20140519 00:09:43< iceiceice> so it will take a whiel to build it
20140519 00:10:01< gfgtdf> iceiceice: did you recently do something with vector<bool> ?
20140519 00:10:09-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140519 00:10:11< iceiceice> i dont think so
20140519 00:11:12< mattsc> iceiceice: you asked something about my directional code last night or this morning, but I forgot what it was.
20140519 00:11:25< iceiceice> i think i didnt but i think vultraz mentioned it
20140519 00:11:45< mattsc> One guess about the problem I observed is that maybe you don’t deal with the difference between even and odd x coordinates correctly?
20140519 00:11:50< mattsc> ok
20140519 00:11:58< iceiceice> y so
20140519 00:12:11< mattsc> My code converts everything onto a square grid first, so it doesn’t have that issue.
20140519 00:12:42< iceiceice> how do you deal with like border =1 stuff?
20140519 00:12:45< mattsc> Not saying that that’s the best way to do it if you need it to me done a gazillion times each second, just saying that that’s what I am doing.
20140519 00:12:51< iceiceice> can you always assume odd is lower than even?
20140519 00:12:56< iceiceice> vertically?
20140519 00:13:02< iceiceice> *more southern
20140519 00:13:26< mattsc> As I said, I go to square coordinates, so I don’t have that issue.
20140519 00:13:44< iceiceice> i think you have to make an assumption
20140519 00:13:45< mattsc> If a hex is lower on the map, then it has a larger y coordinate.
20140519 00:14:07< mattsc> Well, yes, I assume something about the hex in the top left corner, I guess.
20140519 00:14:17< iceiceice> does wesnoth always do that?
20140519 00:14:22< iceiceice> the 1,1 hex is vertically higher than 2,1?
20140519 00:14:43-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg]
20140519 00:14:59< gfgtdf> iceiceice: ok it's related to teh hotkeys code
20140519 00:15:09< iceiceice> ok
20140519 00:15:17< iceiceice> mattsc: the reason we started doing this,
20140519 00:15:27< iceiceice> i wrote some unit tests for map_location,
20140519 00:15:41< iceiceice> if we are ever going to do a pathfind refactor i want to have unit tests for map_location and that first
20140519 00:15:49< iceiceice> and i found that some natural assertions were failing
20140519 00:15:52< iceiceice> about get_relative_dir,
20140519 00:16:01< iceiceice> so i made a routine that makes plots like this:
20140519 00:16:01< iceiceice> http://i.imgur.com/NbuEfoC.png
20140519 00:16:39< iceiceice> the terrain at position p corresponds to, result of "void_hex.relative_dir(p)"
20140519 00:16:51< iceiceice> however i think my routine makes a bad assumption unfortuantely,
20140519 00:17:04< iceiceice> but it might also be that the vector arithmetic in map_location makes a bad assumption, i'm not sure yet
20140519 00:17:10< iceiceice> anyways i think it wont be too hard to sort it out
20140519 00:17:17< iceiceice> but we dont convert to square coordinates like you say
20140519 00:17:17< mattsc> I see.
20140519 00:17:37< mattsc> I saw that plot yesterday, but didn’t know what it was supposed to mean (and didn’t have time to read the logs)
20140519 00:17:51< mattsc> Give me a couple minutes and I’ll show you an example plot.
20140519 00:18:39< gfgtdf> iceiceice: ok seems the reason for the potential segfault are soem strange command=null hotkeys in my preferences file
20140519 00:19:04< iceiceice> geez
20140519 00:19:08< iceiceice> we have to fix this preference file business
20140519 00:19:42< iceiceice> does that mean i can stop compiling debug now
20140519 00:19:57< iceiceice> only got to "leader_scroll_dialog" sof ar...
20140519 00:20:33< iceiceice> our plots were looking so good at the end :( http://i.imgur.com/2NRgBUl.png
20140519 00:25:32< mattsc> iceiceice: having trouble with imgur now …
20140519 00:26:16< mattsc> Ah, there it is: http://imgur.com/9qCX1rE
20140519 00:28:16< mattsc> iceiceice: my code also does this:  http://imgur.com/22BoNmk
20140519 00:28:27< mattsc> or this: http://imgur.com/GnAVE7G
20140519 00:28:47< mattsc> … or anything else along those lines you might want, pretty much automatically.
20140519 00:29:17< mattsc> But as I said, it might not be the fastest for something that needs to be done all the time, I really didn’t care about that.
20140519 00:31:32< iceiceice> mattsc: what do you use it for?
20140519 00:33:23-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140519 00:33:24< mattsc> iceiceice: nothing
20140519 00:33:41< mattsc> It was an “intellectual exercise”  ;)
20140519 00:33:47< iceiceice> i see :)
20140519 00:34:32< mattsc> No, seriously, there was some horrendously complicated code in one of the mainline scenarios, to give the player some “I think the enemy is in xxx direction” information.
20140519 00:34:54< mattsc> So we replaced it with that.  And shadowm uses it in one of his campaigns too, IIRC.
20140519 00:34:59< irker252> wesnoth: Alexander van Gessel wesnoth:master c3c2b25a8223 / .travis.yml: Use xvfb on travis http://git.io/PjcQ_g
20140519 00:35:01< irker252> wesnoth: Alexander van Gessel wesnoth:master 9dae74cd5de9 / src/tests/test_mp_connect.cpp: Disable some failing tests http://git.io/Ki5Ejw
20140519 00:36:38< mattsc> iceiceice: https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg#L373
20140519 00:37:08< iceiceice> that's funy
20140519 00:37:51< mattsc> Agreed.  Which aspect of it do you find funnnnny?
20140519 00:38:00< shadowm> I am perfectly aware of the dangers of throwing floating point math around in performance-sensitive code, but in AtS I only use that code for setting unit facings during dialogue -- hardly a performance-sensitive task except in some rare cases where it's applied to a multitude of units at once, and even then it's all set offscreen.
20140519 00:38:43< mattsc> shadowm: right - that’s why I said that for what I wrote it for it really didn’t matter.
20140519 00:39:07-!- _8680_ [~8680@2002:4404:712c:0:25f2:c523:415c:67cc] has quit [Ping timeout: 252 seconds]
20140519 00:39:09< iceiceice> idk i only started looking into it because i found some bad behavior in a map_location fucntion, then i decided i shoudl just start unit testing much of it
20140519 00:39:14< iceiceice> since its pretty essential to the project
20140519 00:39:22-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140519 00:39:26< iceiceice> although as i've learend many of the vector ops are not that important...
20140519 00:39:35< aquileia> EliDupree: You might be interested in https://github.com/aquileia/wesnoth-resources/tree/master/units/dragon
20140519 00:39:36< iceiceice> but hey, at least we (sort of) got rid of the legacy ops
20140519 00:39:37-!- _8680_ [~8680@2002:4404:712c:0:ec54:337:fbc6:75f4] has joined #wesnoth-dev
20140519 00:40:41< aquileia> EliDupree: There's a slight fix to the flight animation in https://github.com/aquileia/wesnoth-resources/commit/b160e7551a76c91
20140519 00:41:38< EliDupree> who me?
20140519 00:41:42< mattsc> iceiceice: I’m not complaining about what you did or why you did it.  :)
20140519 00:42:38< mattsc> Just that I found some funny behavior trying to watch Fred beat the RCA AI yet again.  You should have a look at it at 16x accelertion, it’s even better then.
20140519 00:42:59< mattsc> That’s why I mistook it for a problem with wesnoth.put_unit() at first and made AI0867 all nervous.
20140519 00:43:10< aquileia> EliDupree: Aren't you Elvish_Hunter?
20140519 00:43:17-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140519 00:43:17< EliDupree> No, Elvish_Pillager
20140519 00:43:25< aquileia> oh, sorry then
20140519 00:43:31< EliDupree> heh, no worries :)
20140519 00:45:50-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20140519 00:46:27-!- _8680_ [~8680@2002:4404:712c:0:ec54:337:fbc6:75f4] has quit [Ping timeout: 252 seconds]
20140519 00:48:13-!- _8680_ [~8680@2002:4404:712c:0:a546:60f4:f56b:d6f4] has joined #wesnoth-dev
20140519 00:48:31-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 00:48:40< gfgtdf> iceiceice: ok i just compiled a vlid master release  build and coudl succesfully test the defeat_condition
20140519 00:50:06< gfgtdf> valid
20140519 00:50:19-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has quit [Quit: Page closed]
20140519 00:50:59< iceiceice> howd you test it?
20140519 00:51:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140519 00:51:42< gfgtdf> hm i played with some sides using different defeat_condition
20140519 00:56:59< iceiceice> ok
20140519 00:57:09< iceiceice> do you know if it fixes these scenarios that are ending early?
20140519 00:57:21< iceiceice> i gues it probably does
20140519 00:59:11< gfgtdf> iceiceice: well i was suprised myself about how wearly check_vctory is called. I thuinking about removing this one: https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L807
20140519 00:59:17-!- _8680_ [~8680@2002:4404:712c:0:a546:60f4:f56b:d6f4] has quit [Ping timeout: 252 seconds]
20140519 00:59:20< gfgtdf> early
20140519 01:00:23-!- _8680_ [~8680@2002:4404:712c:0:2843:1098:fe38:b886] has joined #wesnoth-dev
20140519 01:00:25< gfgtdf> iceiceice: this also triggeres a check_victory between 'start' and 'turn 1'.
20140519 01:00:26< iceiceice> idk its up to you
20140519 01:00:43< iceiceice> lol i didnt realize start and turn1 aren't synonymous
20140519 01:00:57< gfgtdf> iceiceice: how do you mean ?
20140519 01:01:07< iceiceice> i thought they were literally equivalent actually
20140519 01:01:28< gfgtdf> iceiceice: no start fires eralier.
20140519 01:01:33< iceiceice> lol now i know
20140519 01:01:33< shikadibot> And knowing is half the battle!
20140519 01:01:59< mattsc> And the other half is decided by the RNG!
20140519 01:03:05< gfgtdf> iceiceice: thinking about it it most likley wont give invoke a check_victory between those so i think i'll leave it as it is
20140519 01:04:25< iceiceice> gfgtdf: what do you think is better: http://pastebin.com/k95WzgTY
20140519 01:04:48< iceiceice> urgh not exactly right but
20140519 01:05:22< iceiceice> there
20140519 01:05:23< iceiceice> http://pastebin.com/MWbKp07K
20140519 01:05:55-!- _8680_ [~8680@2002:4404:712c:0:2843:1098:fe38:b886] has quit [Ping timeout: 240 seconds]
20140519 01:06:42-!- _8680_ [~8680@2002:4404:712c:0:908a:c7ac:31:86c9] has joined #wesnoth-dev
20140519 01:08:36< gfgtdf> iceiceice: does the second compile ? If i rememember correctly i usualy get a compiler error when trying an implicit int -> enum cast.
20140519 01:09:17< iceiceice> i think arithmetic with enums is legal
20140519 01:09:38< iceiceice> maybe i'm wrong
20140519 01:09:41< iceiceice> we'll see if it doesnt compile
20140519 01:10:53< gfgtdf> iceiceice: i think i'd still use the first.
20140519 01:12:29-!- _8680_ [~8680@2002:4404:712c:0:908a:c7ac:31:86c9] has quit [Ping timeout: 252 seconds]
20140519 01:13:08-!- _8680_ [~8680@2002:4404:712c:0:f18a:1ea7:301f:599] has joined #wesnoth-dev
20140519 01:15:08< iceiceice> do you think its actually much easier to read?
20140519 01:16:43-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140519 01:17:59-!- _8680_ [~8680@2002:4404:712c:0:f18a:1ea7:301f:599] has quit [Ping timeout: 252 seconds]
20140519 01:18:29< gfgtdf> iceiceice: ye i thin its easier to real, also is there a reason why you use k%6 in the second ?
20140519 01:18:46-!- groggy [~chatzilla@75-131-164-14.dhcp.spbg.sc.charter.com] has joined #wesnoth-dev
20140519 01:19:04< gfgtdf> istead of just (d + k )%6
20140519 01:19:05-!- _8680_ [~8680@2002:4404:712c:0:b0cf:b227:e8e6:2d6c] has joined #wesnoth-dev
20140519 01:19:22< iceiceice> because if k is very large or negative i dont want that
20140519 01:19:35-!- _8680_ is now known as Guest63208
20140519 01:20:17< iceiceice> i think i really need two %6u i guess
20140519 01:20:46-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140519 01:21:01< iceiceice> most of the time k will be a constant anyways i expect
20140519 01:21:22< gfgtdf> iceiceice: i think we can ignore the very large k cases, and i also dont see how %6 changes anythign for negative values
20140519 01:22:21< iceiceice> y i guess if its one outer %6u its fine
20140519 01:22:36< Aishiko> gfgtdf, negative won't matter if the value is stored in an unsigned int
20140519 01:23:05< gfgtdf> Aishiko: the function takes an int
20140519 01:23:13< iceiceice> hmm yeah i guess thats the thing
20140519 01:23:20< iceiceice> if i mod k by 6u right away
20140519 01:23:25< iceiceice> then it becomse unsigned and in the right range immediately
20140519 01:23:34-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20140519 01:23:35< Aishiko> and what does it return after doing the %6?
20140519 01:24:23< iceiceice> idk i think its also good because the one line version can be cheaply inlined
20140519 01:24:31< iceiceice> the other one i guess incurs branch prediction and god knows what
20140519 01:25:17< iceiceice> idk thats not why i did it thugh,i actually think its legitimately simpler if the directions are ordered 0 - 5 on a circle
20140519 01:25:23< iceiceice> instead of being opaque things we must switch on
20140519 01:27:28< iceiceice> idk probly the cheapest is a static lookup table ig uess
20140519 01:27:59< iceiceice> idk it could be useful, i am thinking to write a function that rotates a map_location around another with a specified angle,
20140519 01:28:10< iceiceice> maybe someone wants to make a map_editor feature so you can rotate some piece of your map
20140519 01:32:51-!- sachith500 [~kvirc@112.134.221.69] has quit [Read error: Connection reset by peer]
20140519 01:33:55-!- gfgtdf [~chatzilla@f054150090.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140519 01:35:46-!- trewe [~trewe@2001:8a0:d132:ed01:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20140519 01:39:32-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 01:40:41-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140519 02:02:40< shadowm> GSoC coding starts tomorrow I heard?
20140519 02:03:12< Aishiko> yes officially it does
20140519 02:03:34< shadowm> Great, can't wait to see how broken Wesnoth will be in just a couple of weeks! ;)
20140519 02:03:59< shadowm> (Or how much _more_ broken it'll be, from what I've heard.)
20140519 02:04:51< Aishiko> I'm going to try avoid breaking things (though I'm sure I'll have something break on me)
20140519 02:05:26< shadowm> Aishiko: Are you comfortable with the existing image loading/caching architecture yet?
20140519 02:07:48< Aishiko> shadowm, I think so, I'm actually going over it right now, and figuring out what needs to be added or changed
20140519 02:10:17< shadowm> Okay. I'm not terribly up to date on the internals (especially since someone completely refactored the image modifications code after I did my last major change to it), but I am able to offer help/advice on existing WML usage if you need it at some point.
20140519 02:11:29< shadowm> As long as you don't ask me questions including the words "neutral" and "surface" together, I guess.
20140519 02:12:02< Aishiko> thank you, at this point I'm thinking that I might have the "load_image_file" determine if its a spritesheet or not and load it into the proper cache
20140519 02:16:38< shadowm> That'd be by inspecting the proposed spritesheets table ([spritesheet] tags)?
20140519 02:20:06< Aishiko> shadowm, yes but I'm not sure the best way to go
20140519 02:22:08< Aishiko> ahh that would not be the place
20140519 02:23:52-!- gfgtdf [~chatzilla@e177017072.adsl.alicedsl.de] has joined #wesnoth-dev
20140519 02:24:29< groggy> why is janebot not listed in the credits under "Bots"?
20140519 02:24:53< shadowm> No idea. Why are the bots listed instead of their masters?
20140519 02:26:18< Aishiko> appeasing the bots in case of the great robot uprising?
20140519 02:27:28< shadowm> I can guarantee shikadibot is programmed to not harm humans or allow them to come to harm through inaction.
20140519 02:28:16< mattsc> By contrast, the main objective of all the bots I am working on is to do maximum harm.
20140519 02:28:56< mattsc> Alas, all my attempts to build a competent SkyNet have failed so far.
20140519 02:28:57< shadowm> That's why you are only allowed to write AI bots to play within safe and cozy sandboxes.
20140519 02:29:11< mattsc> :)
20140519 02:37:05-!- sachith500 [~kvirc@112.134.221.69] has quit [Read error: Connection reset by peer]
20140519 02:37:16< gfgtdf> iceiceice: i pushed https://github.com/gfgtdf/wesnoth-old/commit/12d190ff9f12a333bb57873235f752f0792081cf and d948a04d9d4a40a9b60e7d53e8c0730a3e731d16
20140519 02:37:56< iceiceice> ok i will test it at some point
20140519 02:38:19-!- Ivanovic_ [~ivanovic@frnk-d933071b.pool.mediaWays.net] has joined #wesnoth-dev
20140519 02:40:54-!- Ivanovic [~ivanovic@frnk-5f751def.pool.mediaWays.net] has quit [Ping timeout: 240 seconds]
20140519 02:42:13-!- Ivanovic_ is now known as Ivanovic
20140519 02:43:54< iceiceice> ok i read the commits, it looks good
20140519 02:46:36-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 02:47:04-!- sachith500 [~kvirc@112.134.221.69] has quit [Read error: Connection reset by peer]
20140519 02:48:07-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 02:48:18-!- sachith500 [~kvirc@112.134.221.69] has quit [Client Quit]
20140519 02:50:17-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 02:51:08-!- sachith500 [~kvirc@112.134.221.69] has quit [Read error: Connection reset by peer]
20140519 02:52:33-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 02:53:03-!- sachith500 [~kvirc@112.134.221.69] has quit [Read error: Connection reset by peer]
20140519 02:54:09< gfgtdf> :)
20140519 02:54:14< gfgtdf> gotta speep now
20140519 02:54:18< gfgtdf> sleep
20140519 02:54:19-!- gfgtdf [~chatzilla@e177017072.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140519 02:58:00-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 03:15:44-!- groggy [~chatzilla@75-131-164-14.dhcp.spbg.sc.charter.com] has quit [Remote host closed the connection]
20140519 03:25:32-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140519 03:37:52-!- sachith500 [~kvirc@112.134.221.69] has quit [Read error: Connection reset by peer]
20140519 03:51:41-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 04:13:53-!- sachith500 [~kvirc@112.134.221.69] has quit [Ping timeout: 246 seconds]
20140519 04:38:12-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection]
20140519 04:38:44-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140519 04:39:19-!- sachith500 [~kvirc@112.134.221.69] has joined #wesnoth-dev
20140519 04:42:58-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 240 seconds]
20140519 05:06:22-!- cib_ [~cib@p5DC75E1A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140519 05:15:00< irker252> wesnoth: Chris Beck wesnoth:master eba19db16625 / src/multiplayer_connect_engine.cpp: in debug mode, add team strings as well as names for hidden sides. http://git.io/o3wqnQ
20140519 05:15:19< irker252> wesnoth: Chris Beck wesnoth:1.12 04191ff6fcf0 / src/multiplayer_connect_engine.cpp: in debug mode, add team strings as well as names for hidden sides. http://git.io/ayVINA
20140519 05:20:18< irker252> wesnoth: Chris Beck wesnoth:master a77ac836d3a3 / src/ (map_location.cpp map_location.hpp tests/test_map_location.cpp): add map_location rotate functions, and tests http://git.io/gw8W9A
20140519 05:20:20< irker252> wesnoth: Chris Beck wesnoth:master d93b01b836e1 / src/ (map_location.cpp map_location.hpp tests/test_map_location.cpp): Merge branch 'add_map_location_rotate' http://git.io/O1zIew
20140519 05:34:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140519 05:41:44-!- cib__ [~cib@p508BC245.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140519 05:45:48-!- cib_ [~cib@p5DC75E1A.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
20140519 05:47:00-!- travis-ci [~travis-ci@ec2-54-242-197-35.compute-1.amazonaws.com] has joined #wesnoth-dev
20140519 05:47:00< travis-ci> [travis-ci] wesnoth/wesnoth#2714 (master - d93b01b : Chris Beck): The build was broken.
20140519 05:47:00< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25489792
20140519 05:47:00-!- travis-ci [~travis-ci@ec2-54-242-197-35.compute-1.amazonaws.com] has left #wesnoth-dev []
20140519 05:48:00-!- sachith500 [~kvirc@112.134.221.69] has quit [Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/]
20140519 05:56:58< irker252> wesnoth: Chris Beck wesnoth:master 1a1f7a5cf87c / src/ (map_location.cpp map_location.hpp): get_relative_dir may take a const & argument http://git.io/CrotcA
20140519 05:57:00< irker252> wesnoth: Chris Beck wesnoth:master be1c1f882ee3 / src/map_location.hpp: fixup header to restore gcc builds http://git.io/6JKXgA
20140519 06:12:17-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 264 seconds]
20140519 06:23:04-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140519 06:27:19-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev
20140519 06:31:28-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 240 seconds]
20140519 06:32:59-!- travis-ci [~travis-ci@ec2-54-87-145-36.compute-1.amazonaws.com] has joined #wesnoth-dev
20140519 06:32:59< travis-ci> [travis-ci] wesnoth/wesnoth#2714 (master - d93b01b : Chris Beck): The build was broken.
20140519 06:32:59< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25489792
20140519 06:32:59-!- travis-ci [~travis-ci@ec2-54-87-145-36.compute-1.amazonaws.com] has left #wesnoth-dev []
20140519 06:35:42-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140519 06:36:15-!- cib__ [~cib@p508BC245.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20140519 06:39:54-!- travis-ci [~travis-ci@ec2-54-242-197-35.compute-1.amazonaws.com] has joined #wesnoth-dev
20140519 06:39:54< travis-ci> [travis-ci] wesnoth/wesnoth#2715 (master - be1c1f8 : Chris Beck): The build was fixed.
20140519 06:39:54< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25490854
20140519 06:39:54-!- travis-ci [~travis-ci@ec2-54-242-197-35.compute-1.amazonaws.com] has left #wesnoth-dev []
20140519 06:44:15-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140519 06:44:39-!- Ivanovic [~ivanovic@frnk-d933071b.pool.mediaWays.net] has quit [Changing host]
20140519 06:44:39-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140519 06:45:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140519 07:00:34-!- Necrosporus_ is now known as Necrosporus
20140519 07:36:57-!- DHost [~Pcy@vps.pyws.fr] has joined #wesnoth-dev
20140519 07:39:56-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140519 07:41:01< AI0867> iceiceice: starting xvfb before running the tests seems to have helped a lot. See travis
20140519 07:41:14< AI0867> still, quite a number of them fail
20140519 07:41:23-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140519 07:41:51< irker252> wesnoth: Alexander van Gessel wesnoth:1.12 96a9e2df9136 / .travis.yml: Use xvfb on travis http://git.io/DhDvqQ
20140519 07:41:53< irker252> wesnoth: Alexander van Gessel wesnoth:1.12 484bcb539867 / src/tests/test_mp_connect.cpp: Disable some failing tests http://git.io/WH7n4A
20140519 07:41:55< irker252> wesnoth: Alexander van Gessel wesnoth:1.12 80bd6a06e72a / / (32 files in 10 dirs): Merge branch '1.12' of github.com:wesnoth/wesnoth into 1.12 http://git.io/tCJkhA
20140519 07:46:28-!- mjs-de [~mjs-de@f048215213.adsl.alicedsl.de] has joined #wesnoth-dev
20140519 08:04:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140519 08:05:08-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140519 08:42:37-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140519 08:55:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140519 09:09:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140519 09:16:47< AI0867> thunderstruck: I've disabled a few CHECK statements in mp_connect, so I should soon be able to make build success depend on test success
20140519 09:22:15< AI0867> iceiceice: well, previously it returned 124, which meant timeout killed it. Now it returns 1, for some other reason it seems
20140519 09:22:30< AI0867> that means 12 test succeed now, as they expected a return value of 1
20140519 09:23:10< AI0867> (travis tests didn't previously fail because of libcaca, it seems)
20140519 09:32:02-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140519 09:33:44-!- boucman_work1 [~rosen@193.56.60.160] has joined #wesnoth-dev
20140519 09:34:29-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 264 seconds]
20140519 09:36:32-!- cib [~cib@132.231.178.149] has joined #wesnoth-dev
20140519 09:36:56-!- cib is now known as Guest23773
20140519 09:41:26-!- john3213 [john3213@static-72-66-66-50.washdc.fios.verizon.net] has joined #wesnoth-dev
20140519 09:44:00< Coffee_irc> mattsc: if you are experiencing animation problems on master I think we'll fix them later :P
20140519 09:44:18< Coffee_irc> I pushed recently a change to smooth out the unit offsets between hexes
20140519 09:44:37< Coffee_irc> so that they don't just jump up and down when moving off keeps or over bridges
20140519 09:44:50< Coffee_irc> this may have affected performance on your system with fog on
20140519 09:45:29< Coffee_irc> but at some point in this next wesnoth 1.13.x cycle I plan to try to speed up significantly the animation drawings in some places
20140519 09:45:54< Coffee_irc> and Aishiko's spritesheets and move to SDL 2 may also help
20140519 09:46:28-!- john3213 [john3213@static-72-66-66-50.washdc.fios.verizon.net] has left #wesnoth-dev []
20140519 09:52:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140519 09:55:26-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Remote host closed the connection]
20140519 10:02:29-!- Guest23773 [~cib@132.231.178.149] has quit [Ping timeout: 258 seconds]
20140519 10:06:39-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140519 10:34:37-!- mjs-de [~mjs-de@f048215213.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140519 11:23:44< zookeeper> Coffee_irc, ohh, that offset smoothing sounds very nice. it's always been a small annoyance.
20140519 11:25:49< AI0867> yes please
20140519 11:45:53-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140519 11:54:05-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20140519 12:29:27-!- higgins [~higgins@192.241.198.49] has quit [Quit: ERC Version 5.3 (IRC client for Emacs)]
20140519 12:32:14-!- higgins [~higgins@192.241.198.49] has joined #wesnoth-dev
20140519 12:38:53-!- irker252 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140519 12:48:06-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has quit [Quit: leaving]
20140519 12:48:25-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140519 13:41:41< mattsc> Coffee_irc: did you actually look at the movie I posted?  I doubt very much that that is a performance issue.
20140519 13:45:15< mattsc> Also, this is on HttT S1.  No fog.
20140519 13:55:12-!- mjs-de [~mjs-de@f048238126.adsl.alicedsl.de] has joined #wesnoth-dev
20140519 13:59:17-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140519 14:12:23-!- irker728 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140519 14:12:23< irker728> wesnoth: Andrius Silinskas wesnoth:master d908fde2ec2f / changelog src/multiplayer_connect_engine.cpp: Always indicate that faction was chosen when placing player. http://git.io/kfG81g
20140519 14:12:23< irker728> wesnoth: Andrius Silinskas wesnoth:master b4f6c6544e59 / src/multiplayer_connect_engine.cpp: Minor style improvements. http://git.io/QfZWYw
20140519 14:12:40< irker728> wesnoth: Andrius Silinskas wesnoth:1.12 14965f466751 / changelog src/multiplayer_connect_engine.cpp: Always indicate that faction was chosen when placing player. http://git.io/epswew
20140519 14:12:42< irker728> wesnoth: Andrius Silinskas wesnoth:1.12 1e3a10423c3a / src/multiplayer_connect_engine.cpp: Minor style improvements. http://git.io/KXv_lA
20140519 14:26:10-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140519 14:29:19-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140519 14:46:48-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140519 15:02:24-!- Guest23773 [~cib@p508BC245.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140519 15:32:29-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140519 15:38:19-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has joined #wesnoth-dev
20140519 15:44:58< aquileia> There's probably a good reason to have the windmill & campfire both under core\images\terrain\misc and core\images\scenery, right? And to preserve that horribly outdated rubble tile in the latter while there are three newer ones under misc?
20140519 15:46:54< aquileia> The windmills are cropped differently, but the fires seem identical
20140519 15:51:56-!- gfgtdf [~chatzilla@e177017072.adsl.alicedsl.de] has joined #wesnoth-dev
20140519 15:52:46< gfgtdf> is there currenty a way to change the order of the [event]s ? Similar to an order=... key shich specifies in which order the event handler are exected ?
20140519 15:58:28< iceiceice> if there is its news to me
20140519 15:58:47< gfgtdf> 	iceiceice: hm any reason against implementing it ?
20140519 15:59:02< iceiceice> what kind of things do you want to change/
20140519 16:00:31< gfgtdf> 	iceiceice: iwa tot o be able to chande from wml whcih event happen first if i have mutiple events, currently its determined by teh order in which they are created which i think is fine as a default, but aso think it woudl be nice to be able to change it.
20140519 16:00:45< gfgtdf> s/iwa tot/i want to
20140519 16:00:57< iceiceice> y i mean there are many subtle things about it that are now baked into umc
20140519 16:01:19< iceiceice> in the unit test thread anonymissimus suggested making a unit test that they hapen in the order of creation
20140519 16:01:35< iceiceice> what would be the alternate mode?
20140519 16:01:42< iceiceice> * the other aspect is,
20140519 16:01:46< iceiceice> if an event creates an event,
20140519 16:01:50< iceiceice> it goes to the end of the line
20140519 16:01:59< iceiceice> i actually do have a unit test for that already
20140519 16:02:39< gfgtdf> iceiceice	: well that behaviour shouldnt change unless you explicitly specify it.
20140519 16:02:44< iceiceice> y
20140519 16:02:54< gfgtdf> iceiceice: so teh test will stay valid
20140519 16:03:36< gfgtdf> iceiceice: but this issue isnt high priority for me.
20140519 16:03:46< iceiceice> y idk
20140519 16:04:05< iceiceice> i dont see any compelling use for it, but i'm not opposed if you want to make an alternate mode, maybe someone will want to use it
20140519 16:04:21-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140519 16:05:46< gfgtdf> iceiceice: what i also want and which is higher priority,  is a limit= key for unit filters which limits the possible units for filter that returns mutiple units like store_unit
20140519 16:06:16< iceiceice> for efficiency reasons?
20140519 16:07:53< gfgtdf> 	iceiceice: also but not mainly, for example [recall] currently only reaclls 1 unit if a am correct, i think it'd be better if recall recalls all units martching teh filter, and with somethign liek limit= one coudl easily arcieve the previous behaviour
20140519 16:08:40< iceiceice> what does it do if it gets multiple matches?
20140519 16:08:46< iceiceice> just tries to spawn them all at the same spot?
20140519 16:09:44< gfgtdf> iceiceice: in the hexes next to it i thought
20140519 16:10:31< iceiceice> y so i guess its like if you used {UNIT repeatedly?
20140519 16:11:11-!- boucman_work1 [~rosen@193.56.60.160] has quit [Ping timeout: 255 seconds]
20140519 16:11:13< gfgtdf> iceiceice: i thought UNIT just creates a new unit ?
20140519 16:11:39< iceiceice> y, but also it will try to find the nearest vacant spot if its occupied
20140519 16:13:01< iceiceice> i think limit is probably good
20140519 16:13:08< gfgtdf> hm ye similar like that, i think that also teh current recall default behaviour
20140519 16:13:19< iceiceice> it would also be nice if like,
20140519 16:13:28< iceiceice> unit filters were all implemented in one place
20140519 16:14:25< iceiceice> i guess we have a "standard unit filter" concept,
20140519 16:14:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140519 16:14:34< iceiceice> but in the C++ it tends to be like this: https://github.com/wesnoth/wesnoth/blob/master/src/game_events/conditional_wml.cpp#L74
20140519 16:15:09< iceiceice> maybe it has to be like that idk
20140519 16:15:09< gfgtdf> iceiceice: but the filtering is done by u.matched_filer
20140519 16:15:23< iceiceice> y...
20140519 16:15:25< iceiceice> for many times thoguh
20140519 16:15:28< aquileia> noy: Oh, I just noticed you're here!
20140519 16:15:29< iceiceice> your filter is just like "id = "
20140519 16:15:34< iceiceice> or "x , y  = ... ,..."
20140519 16:15:37< noy> ?
20140519 16:15:42< iceiceice> and the right operation is to just go to the unit_map
20140519 16:15:50< iceiceice> not iterate over resource units
20140519 16:16:22< aquileia> noy: I and Wrathbox are currently working on a khalifate campaign and would need to decide when we can weave it into the timeline
20140519 16:16:47< gfgtdf> 	iceiceice: i think x,y also support ranges = liek x=1-3, y=2-5 thats makes it more compilcated
20140519 16:17:48< noy> I have the skeleton of one
20140519 16:18:02< iceiceice> gfgtdf: y...
20140519 16:18:12< aquileia> As you placed the first reliable contacts around 500 YW we don't have many choices for our wesnothian war of succession
20140519 16:18:14< noy> along with some notes about how they figure into the world
20140519 16:18:40< noy> unfortunately I must go right now
20140519 16:18:57< aquileia> noy: Ok, see you
20140519 16:19:38-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev
20140519 16:20:44< iceiceice> gfgtdf: idk i still think it would be if there was something like "std::vector<unit*> match_standard_unit_filter ( config cfg ) "
20140519 16:20:47< iceiceice> which we used in most places
20140519 16:21:17< iceiceice> and then if we wanted to make it work better / differently for some kind of filters there would be one place
20140519 16:21:34< iceiceice> since we have the "standard unit filter" idea in docs might as well also have it in code, no?
20140519 16:22:01< gfgtdf> iceiceice: hm ye seems rasonable.
20140519 16:26:43-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140519 16:28:12-!- mjs-de [~mjs-de@f048238126.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140519 16:28:14< irker728> wesnoth: Chris Beck wesnoth:master de4caa876847 / src/ (map_location.cpp map_location.hpp): add a "radial mode" option to get relative dir. (just for kicks) http://git.io/tIgNOg
20140519 16:28:16< irker728> wesnoth: Chris Beck wesnoth:master 748ba751bc46 / src/ (map_location.cpp map_location.hpp): move default relative dir mode to .cpp file, for ease of testing http://git.io/ixTsDA
20140519 16:33:45-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140519 16:38:01-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140519 16:50:04< Necrosporus> I have out of sync error in replay. error replay: unfound location for source of movement: 4,26 -> 5,21
20140519 16:50:33< Necrosporus> And when I opened save it was the unit I moved by [move_unit] action in an event later
20140519 16:50:49< Necrosporus> It was previously on 4,26
20140519 16:51:03< Necrosporus> then [move_unit] moved it 
20140519 16:52:08-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20140519 16:52:53-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140519 16:53:45< Necrosporus> 1.10.7
20140519 16:55:21-!- wesbot changed the topic of #wesnoth-dev to: 1.11.14 (1.12 beta 5) is too buggy to be announced | string+feature freeze active on 1.12 | 238 bugs, 344 feature requests, 28 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140519 17:00:57-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140519 17:03:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140519 17:04:08< Necrosporus> So move_unit doesn't remove unit from previous point where it was
20140519 17:04:14< Necrosporus> or something
20140519 17:06:46-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 276 seconds]
20140519 17:06:54-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140519 17:09:39< Necrosporus> gfgtdf, any idea?
20140519 17:14:52< gfgtdf> Necrosporus: hm i dot know much about howthings worked in 1.10,  especiayl because there were some changes on replays durign the 1.11 branch, also i have heated teh move_unit is currently a little bugges in on curretn 1.12 branch
20140519 17:15:20-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140519 17:15:46< gfgtdf> Necrosporus: deom which event do ou move te unit ?
20140519 17:15:49< gfgtdf> from
20140519 17:18:12< Necrosporus> attack
20140519 17:20:12-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140519 17:21:12< Necrosporus> Is it planned to make 1.10.8 eventually?
20140519 17:21:19-!- spoffy [~spoffy@152.78.175.8] has quit [Ping timeout: 265 seconds]
20140519 17:22:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140519 17:22:38< happygrue> no
20140519 17:24:19-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140519 17:29:27< Necrosporus> happygrue, won't bugs in 1.10.7 stay unfixed forever?
20140519 17:35:27-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140519 17:37:04< gfgtdf> Necrosporus: i just tested chaning a units position inside an attack event and it worked liek it should
20140519 17:38:23< Necrosporus> Maybe it was so because of shroud
20140519 17:38:51< gfgtdf> 	Necrosporus: hmj move unit shouold ignore shroud
20140519 17:39:24< Necrosporus> I guess, maybe I should take a look once more, this time in debug mode removing shroud
20140519 17:39:41-!- iceiceice [~chris@207-237-132-90.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140519 17:42:05-!- kex [~kex@212.158.180.15] has joined #wesnoth-dev
20140519 17:48:34-!- kex [~kex@212.158.180.15] has quit [Remote host closed the connection]
20140519 17:49:05-!- kex [~kex@212.158.180.15] has joined #wesnoth-dev
20140519 17:53:23< irker728> wesnoth: gfgtdf wesnoth:master 495deb0e4625 / changelog: Update changelog add 'defeat_condition' http://git.io/0_a5BA
20140519 17:58:00< irker728> wesnoth: gfgtdf wesnoth:master 87c492e0a199 / src/hotkey/hotkey_item.cpp: don't load null hotkeys http://git.io/O1-jLQ
20140519 17:58:57< irker728> wesnoth: gfgtdf wesnoth:master 26d60c0a8fb3 / src/ (play_controller.cpp scripting/lua.cpp team.cpp team.hpp): replace fight_on_without_leader with defeat_condition http://git.io/kse_yA
20140519 17:58:59< irker728> wesnoth: gfgtdf wesnoth:master 12d190ff9f12 / src/ (play_controller.cpp team.cpp team.hpp): add "always" defeat_condition http://git.io/P2HQmA
20140519 17:59:01< irker728> wesnoth: gfgtdf wesnoth:master d948a04d9d4a / src/ (play_controller.cpp play_controller.hpp playsingle_controller.cpp): rename remove_from_carryover_on_leaders_loss_ http://git.io/p1LyxQ
20140519 17:59:03< irker728> wesnoth: gfgtdf wesnoth:master b258433650bf / src/ (6 files in 2 dirs): Merge pull request #165 from gfgtdf/defeat_condition http://git.io/zyOHBQ
20140519 18:00:17-!- Guest63208 [~8680@2002:4404:712c:0:b0cf:b227:e8e6:2d6c] has quit [Ping timeout: 264 seconds]
20140519 18:00:58-!- _8680_ [~8680@2002:4404:712c:0:b4b1:ff76:b74a:c2de] has joined #wesnoth-dev
20140519 18:03:31-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140519 18:05:57-!- _8680_ [~8680@2002:4404:712c:0:b4b1:ff76:b74a:c2de] has quit [Ping timeout: 252 seconds]
20140519 18:06:51-!- _8680_ [~8680@2002:4404:712c:0:c470:9a8:3a56:65a4] has joined #wesnoth-dev
20140519 18:10:22< gfgtdf> iceiceice: i psuhed teh defeat_condition to master
20140519 18:10:41< iceiceice> y i see
20140519 18:10:44< iceiceice> i didnt test it yet
20140519 18:10:58< iceiceice> i might write a unit test for it if i have time i guess
20140519 18:11:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140519 18:11:13< iceiceice> idk or you can if you already did tests, up to you
20140519 18:12:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140519 18:19:36-!- EdB [~edb@25.145.124.78.rev.sfr.net] has joined #wesnoth-dev
20140519 18:24:09< gfgtdf> iceiceice: i think wml_message is not what i neeed since it puts the output to bith stderr and chat, but what i wanted is only console
20140519 18:24:15< gfgtdf> ony stderr i mean
20140519 18:24:55< iceiceice> hmm yeah thats kind of pointless
20140519 18:25:07< iceiceice> shadowm said something about it yesterday, i think the purpose is not to disturb the player
20140519 18:25:18< iceiceice> so maybe the impl doesnt quite work anymore?
20140519 18:25:23< happygrue> Necrosporus: I could be wrong.  Perhaps if there is enough reason (fixes) for another release before 1.12 is out then there could be a 1.10.8 release.  At this point I would imagine the focus is going to be on release candidates rather than 1.10.x
20140519 18:27:51< gfgtdf> iceiceice: i think shadowm meant player = people who dont use log--...=, which is most likley correct. But what i wanted is printing a small bug description in taht chat and a very detailed (>100 lines maybe) in the stderr file
20140519 18:28:34-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20140519 18:29:23< iceiceice> theres a special logger for "wml_message" if you look in log.?pp
20140519 18:30:03< iceiceice> hmm it has an odd purpose though i gues:
20140519 18:30:04< iceiceice>  * Use this logger to send errors due to deprecated WML.
20140519 18:30:04< iceiceice>  * The preferred format is:
20140519 18:30:04< iceiceice>  * xxx is deprecated; support will be removed in version X. or
20140519 18:30:04< iceiceice>  * xxx is deprecated; support has been removed in version X.
20140519 18:30:05< iceiceice>  *
20140519 18:30:07< iceiceice>  * After every wml-event the errors are shown to the user,
20140519 18:30:09< iceiceice>  * so they can inform the campaign maintainer.
20140519 18:30:11< iceiceice>  */
20140519 18:30:35< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/blob/master/src/game_events/pump.cpp#L404
20140519 18:30:37< iceiceice> idk maybe you want to make a "console-only" option for the wml message thing?
20140519 18:30:51< gfgtdf> iceiceice: ye that way my idea aswell
20140519 18:30:55< gfgtdf> was
20140519 18:31:24-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev
20140519 18:33:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140519 18:34:17-!- vernon [~quassel@77-234-83-36.pool.digikabel.hu] has joined #wesnoth-dev
20140519 18:35:55< irker728> wesnoth: Chris Beck wesnoth:master 3f5350a5ef5b / data/test/scenarios/test_relative_dir.cfg src/game_events/action_wml.cpp: add wml relative dir query tag, and interactive test scenario http://git.io/ddtdzg
20140519 18:35:57< irker728> wesnoth: Chris Beck wesnoth:master aaff4bdfeebb / / (8 files in 4 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/EW2CXA
20140519 18:36:40-!- EdB [~edb@25.145.124.78.rev.sfr.net] has quit [Quit: Konversation terminated!]
20140519 18:37:34-!- kex [~kex@212.158.180.15] has quit [Remote host closed the connection]
20140519 18:38:13-!- kex [~kex@212.158.180.15] has joined #wesnoth-dev
20140519 18:39:58< Necrosporus> gfgtdf, second time this bug doesn't seem to repeat. The case when it appeared was when moved unit killed other unit
20140519 18:40:02< gfgtdf> AI0867: do you think we can move the #define UNICODE from windows_tray_notification.hpp to global.hpp ?
20140519 18:40:10-!- kex [~kex@212.158.180.15] has quit [Read error: Connection reset by peer]
20140519 18:40:38< gfgtdf> 	Necrosporus: hm usually the attack event fires before any unit attacks ?
20140519 18:40:46< gfgtdf> so how can it kill the other unit ?
20140519 18:41:52-!- vernon [~quassel@77-234-83-36.pool.digikabel.hu] has quit [Remote host closed the connection]
20140519 18:50:39< Necrosporus> gfgtdf, because of this http://pastebin.com/q9xaQ3RF
20140519 18:52:18< Necrosporus> Actually I mistaken it was from custom event fired by attack event
20140519 19:16:05< aquileia> iceiceice: I assume the addition of 'C++' in https://github.com/wesnoth/wesnoth/commit/c611481e2 was by accident? Or don't I understand the WML unit tests at all?
20140519 19:16:37< iceiceice> its a clarifying remark
20140519 19:16:45< iceiceice> that .txt was there before i made the wlm unit tests
20140519 19:17:11< iceiceice> i dont think any of the C++ unit tests used any scenario files... because its just too much of a pain to make a mockup fixture to run unit tests like that i guess
20140519 19:17:22< iceiceice> but whoever implemented the system hoped that we would i guess
20140519 19:17:44< aquileia> But it's the readme located with your tests
20140519 19:17:58< aquileia> So the 'C++' is misguiding I think
20140519 19:18:01< iceiceice> y so right now the C++ unit test material in data/test/
20140519 19:18:08< iceiceice> and the WML unit test material 
20140519 19:18:10< iceiceice> coexist
20140519 19:18:18< aquileia> ah, ok
20140519 19:18:29< iceiceice> there was some question if i should have made a seperate location adn config pathway
20140519 19:18:36< iceiceice> i havent bothered because speed isn't really an issue
20140519 19:19:04< aquileia> Thanks for the clarification
20140519 19:19:17< iceiceice> i guess maybe i should write this in the readme
20140519 19:19:45< aquileia> I'm fixing it anyhow
20140519 19:20:56< iceiceice> ok th
20140519 19:20:57< iceiceice> x
20140519 19:33:12-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140519 19:33:38< shadowm> iceiceice: I didn't say anything about it.
20140519 19:33:50< shadowm> About its design, that is.
20140519 19:34:10< shadowm> :|
20140519 19:34:16< iceiceice> hmm well anyways gfgtdf found it and figured out what you said
20140519 19:37:56< gfgtdf> iceiceice: my copiler complains : RELATIVE_DIR_MODE not found, did you adda new file ?
20140519 19:38:27< iceiceice> no
20140519 19:38:33< iceiceice> i did change map_location.hpp
20140519 19:38:37< Necrosporus> gfgtdf, what do you think about the code?
20140519 19:39:39< iceiceice> push was 4 hours ago, travis built successfully 1 hour ago
20140519 19:41:35< shadowm> The WML API in 1.12.x is still not stable? :p
20140519 19:43:06< gfgtdf> shadowm: no :(
20140519 19:43:36< iceiceice> nope, unfortunately we had to change things like check_victory that we can't adequately test ourselves
20140519 19:43:37< shadowm> Well, time to quit any pretenses of being beta I guess... (kidding)
20140519 19:43:39< gfgtdf> shadowm: i also have to backport 26d60c0a8fb3 
20140519 19:44:34< iceiceice> hmm i'm getting something weird now, new in the last hour or so: 20140519 15:41:30 error config: Error loading game configuration files
20140519 19:44:34< iceiceice> Unexpected characters after variable name (expected , or =)
20140519 19:44:34< iceiceice> at core/macros/utils.cfg:188
20140519 19:44:34< iceiceice>     included from ai/ais/ai_default_rca_strong.cfg:2
20140519 19:44:34< iceiceice>     included from /_main.cfg:30
20140519 19:44:36< iceiceice> Unexpected characters after variable name (expected , or =)
20140519 19:44:38< iceiceice> at core/macros/utils.cfg:188
20140519 19:44:40< iceiceice>     included from ai/ais/ai_default_rca_strong.cfg:2
20140519 19:44:42< shadowm> Yes,
20140519 19:44:42< iceiceice>     included from /_main.cfg:30
20140519 19:44:47< shadowm> IRC is not for multiline pastes.
20140519 19:48:53< iceiceice> is it a rule that macros have to be capitalized?
20140519 19:49:38< shadowm> The WML preprocessor doesn't care, but if you are writing reusable, maintainable code, you'd better stick to the conventions.
20140519 19:54:20< shadowm> "Additionally, git has special support for the kinds of unit tests we have" -- don't you mean GitHub or travis, or is this related to git bisect somehow?
20140519 19:54:30-!- Ardonik [~user@adsl-75-28-99-95.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 245 seconds]
20140519 19:54:51-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Ping timeout: 252 seconds]
20140519 19:58:09-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has quit [Ping timeout: 252 seconds]
20140519 19:58:21< Necrosporus> So what should I do with replay error out of sync?
20140519 19:58:31-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has quit [Ping timeout: 252 seconds]
20140519 19:58:56-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has joined #wesnoth-dev
20140519 19:59:07< Necrosporus> Just write a workaround or do something to identify the problem closer?
20140519 20:00:10< iceiceice> shadowm: yeah i was just referring to the git bisect thing
20140519 20:00:37< iceiceice> if i didnt make wesnoth give an error code when it ran tests i dont think we could script it (at least not easily)
20140519 20:01:40< shadowm> Your post could use more [b] for emphasis.
20140519 20:01:59< gfgtdf> iceiceice: ok i foudn teh issue
20140519 20:02:19< shadowm> I've figured it's the best way to convince users to do soemthinconstructive things.
20140519 20:02:37< shadowm> GRRR.
20140519 20:02:51< shadowm> *constructive things
20140519 20:03:38< shadowm> In general, the prettier a post looks, the greater are the chances that you'll manage to grab the attention of even the most apathetic and lazy people.
20140519 20:04:05< gfgtdf> is there a reason why we include map.cpp this way ? https://github.com/wesnoth/wesnoth/blob/master/src/minimap.hpp#L17
20140519 20:04:14< gfgtdf> in those bracetsi mean
20140519 20:04:18< gfgtdf> bracets
20140519 20:04:42< shadowm> They are brackets, not braces.
20140519 20:05:03< gfgtdf> ok brackets then
20140519 20:05:45< shadowm> I'd bet that's just a mistake -- that'll give preference to a file named 'map.hpp' in the compiler's default inclusion dirs.
20140519 20:06:32< gfgtdf> i'll make it #include "map.hpp" then.
20140519 20:07:02-!- Ardonik [~user@adsl-75-28-99-95.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20140519 20:07:24-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140519 20:07:52< shadowm> Funnily enough, I spent the last year pondering whether and _how_ to write a unit test framework for AtS.
20140519 20:08:49< shadowm> I guess I use a lot of underspecified functionality there, so I'll see what I can find for inclusion in mainliene lter.tatrer.
20140519 20:09:57< shadowm> Apologies for the typos, my ssh connection is currently about the same quality as excrement.
20140519 20:11:08-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has joined #wesnoth-dev
20140519 20:12:26< happygrue> perhaps you mean to say it's the same quality as  ?
20140519 20:14:50-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140519 20:14:50-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 255 seconds]
20140519 20:14:53-!- shadowm_desktop2 is now known as shadowm_desktop
20140519 20:15:08< shadowm_desktop> "mosh: Last reply 1:43 ago. [To quit: Ctrl-^ .]" -- yes, definitely.
20140519 20:19:05-!- kex [~kex@31.11.98.42] has joined #wesnoth-dev
20140519 20:22:33< iceiceice> shadowm: :) awesome
20140519 20:38:48-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20140519 20:43:29-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140519 20:45:15< mattsc> gfgtdf, iceiceice: just to clarify, I need to change the settings for the leaderless MAI test scenarios again, right?
20140519 20:45:43< gfgtdf> mattsc: if you used fight_on_with_no leaer then es
20140519 20:46:06< gfgtdf> mattsc: i updated http://wiki.wesnoth.org/SideWML already
20140519 20:46:15< mattsc> gfgtdf: I just saw that
20140519 20:47:16< mattsc> gfgtdf: yes, I had to change several scenarios to use fight_on_without_leader because they didn’t work any more recently.
20140519 20:47:48< iceiceice> y this new thing is better than fight on, it is better named and it will hopefully make everyone able to get the behavior they want
20140519 20:47:52< mattsc> gfgtdf: I suggest you make that a very emphasized point in the release notes, so that we don’t get everybody missing it yet again.
20140519 20:48:24< mattsc> That way, only most everybody will miss it.  :D
20140519 20:48:53< gfgtdf> mattsc: hm ye im gonna add it to teh release notes, i think i ahve a typo no_unit <-> no_units somehwere, but i dotn know if its in teh doc or in teh code
20140519 20:49:12< mattsc> I’ll make sure the MAI test scenarios get changed before 1.11.15 comes out.
20140519 20:50:06< gfgtdf> mattsc: so fight_on_without_leader was already used in current master or 1.12 ? becasue i did a search and foudn nothing (in current master)
20140519 20:50:49< aquileia> iceiceice: Could you cherry-pick 6dac05134caf and 8d99538d3a5f from https://github.com/aquileia/wesnoth/tree/minor_VC_fix onto master, please?
20140519 20:51:01< mattsc> gfgtdf: do a ` grep -ir fight_on data/ai/`
20140519 20:51:33< gfgtdf> mattsc: in current master ?
20140519 20:51:45< mattsc> master or 1.12.  It’s in both.
20140519 20:51:48< aquileia> iceiceice: I wanted to get VC to run your tests as well, but bourne shell on Windows...
20140519 20:52:39< iceiceice> ok, give me a minute
20140519 20:54:13< aquileia> iceiceice: wait...
20140519 20:54:24< aquileia> I forgot a newline character
20140519 20:54:39< aquileia> If you didn't commit yet, I'd amend that
20140519 20:54:41< mattsc> gfgtdf: the whole thing with fight_on_… started because the MAI test scenarios suddenly didn’t work any more.  (Not the only reason in the end, of course, but that’s what kicked it off.)  I think it was iceiceice whom I talked to first back then, but I might misremember.
20140519 20:55:00< aquileia> else - it's not really important
20140519 20:56:54< gfgtdf> mattsc: some devs have complained about that the curretn implementation doesnt give enough control over the check_victory mechanism, thats why i replaces check_victory .. with defeat_condition which has options that th old version had (no_leader/no_units) but also 'never' which can disable teh defeat check for a side
20140519 20:57:01< gfgtdf> dome umc devs
20140519 20:57:02< gfgtdf> some*
20140519 20:57:32< iceiceice> aquileia: iddint do it yet :)
20140519 20:58:05< mattsc> gfgtdf: you might be misunderstanding me.  I’m not complaining.  I just wanted to confirm that I need to change those fight_on keys.
20140519 20:58:23< mattsc> I’m too busy at the moment to follow everything that is being discussed on irc.
20140519 20:58:23< aquileia> iceiceice: The new commit numbers are 6dac05134caf and ba71d1d8ef42f
20140519 20:58:32< aquileia> sorry for the inconvenience
20140519 20:58:39< iceiceice> np
20140519 20:59:05< gfgtdf> yes fight_on_ ... will have no effect in 1.12, defeat_condition=no_units will have the same effect as fight_on_with_no_leader had .
20140519 20:59:12< iceiceice> i need to commit current changes first, and i have to set up my aquileia remotes again anyway, its going to take me a few more minutes still
20140519 21:00:03< aquileia> iceiceice: I'm thankful that you go through the hassle at all, no worries
20140519 21:01:51-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140519 21:06:48< mattsc> gfgtdf: okay, I’ll change those scenarios.  It’s not a big deal.
20140519 21:11:32< iceiceice> aquileia: cherry-pick in that order?
20140519 21:12:02< aquileia> They do not depend upon each other
20140519 21:12:15< iceiceice> hmm it said bad revision 8d99538d3a5f
20140519 21:12:40< aquileia> iceiceice: That's because I replaced that one
20140519 21:12:53< aquileia> The new commit numbers are 6dac05134caf and ba71d1d8ef42f
20140519 21:12:55< iceiceice> oh crap
20140519 21:12:56< iceiceice> ok 
20140519 21:13:16< iceiceice> thx
20140519 21:13:41< irker728> wesnoth: Chris Beck wesnoth:master ab29ba7e4397 / data/test/scenarios/test_relative_dir.cfg src/game_events/action_wml.cpp: add map location rotate wml interface http://git.io/Ti_SzA
20140519 21:13:43< irker728> wesnoth: Chris Beck wesnoth:master 2a927871b7be / src/map_location.cpp: fixup radial mode get_relative_dir http://git.io/Lwb3lA
20140519 21:13:45< irker728> wesnoth: Chris Beck wesnoth:master cf19cc551625 / src/map_location.cpp: get_relative_dir to use radial_symmetry mode, until we fix default http://git.io/JEh2Og
20140519 21:13:47< irker728> wesnoth: aquileia wesnoth:master a69ee6e0c14a / projectfiles/VC9/wesnoth.vcproj: Update VC project for b4ea561e37 http://git.io/TxcFPQ
20140519 21:13:49< irker728> wesnoth: aquileia wesnoth:master 8136065f75e0 / data/test/ (macros/readme.txt scenarios/readme.txt): Fix readme files about unit test scenarios http://git.io/Tsrr4Q
20140519 21:14:11< aquileia> thanks for committing
20140519 21:14:26< iceiceice> yeah np
20140519 21:17:12< iceiceice> mattsc: ok the animations are looking normal for me now, feel free to test
20140519 21:18:44< iceiceice> not the final implementation but at least it wont bother you in your tests
20140519 21:19:54< iceiceice> Coffee_irc: i did some more work on get_relative_dir, we should go back to that at some point
20140519 21:20:54< irker728> wesnoth: Chris Beck wesnoth:master aace2c028861 / .travis.yml: turn on very verbose logging for wml unit tests on travis http://git.io/r1ri6Q
20140519 21:23:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140519 21:27:38-!- gfgtdf_ [~chatzilla@e176189249.adsl.alicedsl.de] has joined #wesnoth-dev
20140519 21:28:38-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 240 seconds]
20140519 21:29:47-!- gfgtdf [~chatzilla@e177017072.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds]
20140519 21:29:48-!- gfgtdf_ is now known as gfgtdf
20140519 21:48:22-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140519 21:48:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140519 21:49:54-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20140519 21:50:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20140519 21:57:43< iceiceice> hmm this is what travis is saying:
20140519 21:57:44< iceiceice> Error (strict mode, strict_level = 1): wesnoth reported on channel error filesystem
20140519 22:06:57< irker728> wesnoth: Chris Beck wesnoth:master 7046c3906e6f / src/tests/test_map_location.cpp: fixup map_location unit tests http://git.io/5xmxlg
20140519 22:06:59< irker728> wesnoth: Chris Beck wesnoth:master 3eb02d338bf5 / .travis.yml: disable strict mode on travis, so we can see the error messages http://git.io/p5Gpsg
20140519 22:07:00< shadowm> gfgtdf: Why write_to=chat/console instead of something like show_in_game=yes/no?
20140519 22:08:00< shadowm> It also doesn't seem proper to use strings instead of enum types to specify parameters within C++ land.
20140519 22:09:27< shadowm> (And in a different context it could even be detrimental -- a std::string occupies far more memory than an enum type assuming enums implemented as native word-size integers.)
20140519 22:11:00< gfgtdf> shadowm: hm write_to also allows to only print it to chat. I just thought it wasnt performance critical enough to write another string <-> enum conversion. If we use that code in another place some day we can do that.
20140519 22:13:46< shadowm> Why would anyone want to print only to chat using [wml_message] when there's [chat_message]?
20140519 22:14:21< shadowm> I'd say that subverting [wml_message] to not pass the message to the loggers violates its intended purpose.
20140519 22:15:05< iceiceice> y i kind of agree with that actually, maybe the option shoudl just be "also_chat = yes / no"
20140519 22:15:38< iceiceice> [chat] message = blah [/chat] is what i usually use for this anyways
20140519 22:15:50< shadowm> I think it'd be nice to not use 'chat' for the option either way.
20140519 22:16:17< shadowm> What if we eventually decide to separate in-game chat messages from wml_message and console messages?
20140519 22:16:34< gfgtdf> shadowm: but [chat] doenst allow to specify a logger=
20140519 22:17:02< shadowm> Of course it doesn't. Why would you specify a logger for [wml_message] when you don't want to pass the message to the logger?
20140519 22:19:25< gfgtdf> shadowm: the logger also spcifies when the chat message in wml_message is printed. Althoughi currently don't use it.
20140519 22:19:25-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Quit: On the road again]
20140519 22:19:30< mattsc> iceiceice: yes, that fixes it for me as well.  Thank you.  :)
20140519 22:19:35-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has quit [Ping timeout: 252 seconds]
20140519 22:19:52< shadowm> So let me ask now: why would you want the message to show up in-game but not in stderr?
20140519 22:20:46< iceiceice> mattsc: y, if you want to see the new results we have, run "wesnoth -t test_relative_dir"
20140519 22:20:52< shadowm> Relatedly: which is more reliable for persistent storage: in-game, which cannot be redirected, or stderr, which can be redirected to a file or piped to another process?
20140519 22:21:34< iceiceice> mattsc: the new version i made is based on a hex rotate function... so fairly complicated and not that fast, we might fix it up
20140519 22:21:49< iceiceice> im thinking of things i could use it for though
20140519 22:22:04< iceiceice> i remember when i made maps i sometimes wanted to be able to grab hexes and rotate them, or rotate the whole map...
20140519 22:22:19< iceiceice> it might also be kind of nifty if we had like a, rotate map option for in game
20140519 22:22:35< iceiceice> so you could shift over in increments of 60 degrees, and use the current pipeline
20140519 22:22:41< iceiceice> for graphics
20140519 22:22:58< iceiceice> idk most chess programs i ever used allow you to rotate the board, it sometimes helps you to figure out what to do for some reason
20140519 22:23:31< gfgtdf> shadowm:  I dont want to, but i still so see its harm.
20140519 22:23:39< gfgtdf> s/so/don't
20140519 22:24:12< mattsc> iceiceice: that might be handy for writing AIs for Side 2 on Freelands too  :P
20140519 22:24:20< iceiceice> haha
20140519 22:24:46< mattsc> I’m off again though, I might have a look at that test scenario later ...
20140519 22:25:20-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Ping timeout: 255 seconds]
20140519 22:26:07< shadowm> gfgtdf: It's not about seeing harm or not. It's about clean, minimalistic design.
20140519 22:26:56< shadowm> Sure, you could throw every single feature you don't need at your code, and either end up with a huge unmaintainable mess immediately, or end up with a huge unmaintainable mess later when you inadvertently apply the same mindset to every other thing you work on.
20140519 22:27:20-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140519 22:27:39< shadowm> Designing a concise, to-the-point interface is part of avoiding that.
20140519 22:29:17< shadowm> Incidentally, when I first implemented [wml_message] I also made a few mistakes in that regard and ended up with more complicated code than it was actually needed.
20140519 22:29:46< shadowm> I made several superfluous aliases for the log levels when nobody had a realistic use for those.
20140519 22:30:01-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140519 22:30:09< iceiceice> y idk, we should just think about what we have and figure out whats the right balance between, features people want, and KISS / "options are bad"
20140519 22:30:33< shadowm> I don't know why you don't know, why do you ask me?  :p
20140519 22:30:35< iceiceice> its kind of true that [chat] and [wml_message] overlap
20140519 22:31:31< iceiceice> idk how many umc actually use [wml_message] though?
20140519 22:31:46< shadowm> I don't see it like that. [chat] came much later and it has a different purpose.
20140519 22:31:56< iceiceice> also i guess maybe its worth asking, why do you want to write to the logs and not tellt he user
20140519 22:32:03< shadowm> And [wml_message] started its life without the ability to echo messages in-game.
20140519 22:32:05< iceiceice> vast majority of users dont even know how to get the console output
20140519 22:32:16< iceiceice> if you want it to be like, a message for the maintainer,
20140519 22:32:28< iceiceice> maybe have like a "chat only if in debug mode" option
20140519 22:33:22< shadowm> #ifdef DEBUG_MODE   [wml_message] ...
20140519 22:33:35< iceiceice> oh i didnt know that worked
20140519 22:33:45< iceiceice> hmm that reminds me
20140519 22:33:46< shadowm> Although I personally just set the log level to something below warning and start Wesnoth with --log-{info|debug}=wml.
20140519 22:34:05< shadowm> Also, the #ifdef is actually the least optimal possibiity. I believe with Lua you can check whether debug mode is on at runtime.
20140519 22:34:50< iceiceice> shadowm: i think all this code at the top of data/_main.cfg may be dead
20140519 22:34:51< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/data/_main.cfg#L9
20140519 22:35:02< shadowm> As a side note, as with every other thing I have implemented (including [true] and [false]), I did know I would use [wml_message].
20140519 22:35:37< iceiceice> i'm not sure how to like, grep back in time for "NO_GUI" and figure out when it got removed as a preproc
20140519 22:37:28< iceiceice> i guess i could just make data/_main chat and see what's going on there
20140519 22:37:37< iceiceice> err...
20140519 22:37:49< iceiceice> [wml_message]...
20140519 22:37:50< iceiceice> will that work ?
20140519 22:38:02< iceiceice> i guess i probably cant log error messages before we've entered a scenario
20140519 22:38:33< shadowm> Yeah no, you can only do that in events.
20140519 22:38:53< iceiceice> i guess i could do #ifdef NO_GUI \\ {"this_file_does_not_exist"} \\ #endif
20140519 22:38:54< shadowm> As for [wml_message]'s usage (1.12 campaign only): http://pastebin.com/gyJ2yBkn
20140519 22:39:43< shadowm> There's a simpler way to have the preprocessor fail a line unconditionally.
20140519 22:40:10< shadowm> Eh, we still haven't documented it? Anyway, #error <message here>.
20140519 22:40:35< iceiceice> hmm this is what travis says: 
20140519 22:40:37< iceiceice> 20140519 22:37:53 error filesystem: Could not open '/home/travis/.config/wesnoth/preferences' for reading.
20140519 22:47:42-!- mjs-de [~mjs-de@f048238126.adsl.alicedsl.de] has joined #wesnoth-dev
20140519 22:50:14-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has quit [Quit: Page closed]
20140519 22:52:19-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has joined #wesnoth-dev
20140519 22:55:46< gfgtdf> shadowm: ok i'll rewrite that code to have an atribute show_in_chat=yes(default)/no then
20140519 22:56:26< shadowm> What did I say about avoiding the 'chat' terminology? :p
20140519 22:57:11< shadowm> Sure, I guess it doesn't matter until it happens (and then we'll have to maintain legacy syntax).
20140519 22:58:07< shadowm> to_chat=yes*/no and chat=yes*/no are also suitable alternatives.
20140519 23:02:05-!- kex [~kex@31.11.98.42] has quit [Remote host closed the connection]
20140519 23:02:05< gfgtdf> shadowm: ok just becasue it make the commit message shorter than 50 chars i'll use to_chat.
20140519 23:02:39-!- kex [~kex@31.11.98.42] has joined #wesnoth-dev
20140519 23:07:31-!- kex [~kex@31.11.98.42] has quit [Ping timeout: 276 seconds]
20140519 23:16:20< irker728> wesnoth: Chris Beck wesnoth:master 987e34a3e315 / .travis.yml run_wml_tests travis_wml_unit_tests.sh: fixup travis unit tests http://git.io/8YZutg
20140519 23:19:05-!- Guest23773 [~cib@p508BC245.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140519 23:43:38-!- spoffy [~spoffy@152.78.175.8] has quit [Ping timeout: 265 seconds]
20140519 23:56:08-!- Kexoth [~kex@78.157.29.205] has joined #wesnoth-dev
--- Log closed Tue May 20 00:00:38 2014