--- Log opened Fri May 23 00:00:58 2014 20140523 00:05:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140523 00:14:20-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20140523 00:17:24< gfgtdf> mattsc: i backported the defeat_condition thing 20140523 00:24:57-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20140523 00:32:14-!- spoffy [~spoffy@152.78.175.8] has quit [Ping timeout: 240 seconds] 20140523 00:42:22-!- gfgtdf [~chatzilla@e177123014.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds] 20140523 00:46:56-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev 20140523 00:54:45-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140523 01:09:13-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral] 20140523 01:18:46-!- sachith500 [~kvirc@112.134.219.20] has joined #wesnoth-dev 20140523 01:21:13-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20140523 01:23:55-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds] 20140523 01:30:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140523 01:32:56-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140523 01:40:46< loonycyborg> AI0867: If I use a wide-string only winapi function in wesnoth then to which encoding should I convert it? :P 20140523 01:41:50< loonycyborg> Namely this one: http://msdn.microsoft.com/en-us/library/windows/desktop/bb762188%28v=vs.85%29.aspx 20140523 01:47:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140523 01:58:41-!- Netsplit *.net <-> *.split quits: irker396, knotwork 20140523 01:59:19-!- Netsplit over, joins: knotwork 20140523 01:59:19-!- knotwork [~markm@142.68.84.150] has quit [Changing host] 20140523 01:59:19-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20140523 02:07:16-!- sachith500 [~kvirc@112.134.219.20] has quit [Read error: Connection reset by peer] 20140523 02:17:22< mattsc> gfgtdf: thanks 20140523 02:25:43-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140523 02:33:40-!- Ivanovic_ [~ivanovic@frnk-5f74d580.pool.mediaWays.net] has joined #wesnoth-dev 20140523 02:36:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds] 20140523 02:37:34-!- Ivanovic_ is now known as Ivanovic 20140523 02:45:55-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds] 20140523 02:51:06-!- irker959 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140523 02:51:06< irker959> wesnoth: mattsc wesnoth:1.12 06740c103eee / data/ai/micro_ais/scenarios/ (animals.cfg bottleneck_defense.cfg protect_unit.cfg wolves.cfg): MAI test scenarios: fight_on_without_leader -> defeat_condition http://git.io/wiqlDQ 20140523 02:52:10< irker959> wesnoth: mattsc wesnoth:master 54b303067689 / data/ai/micro_ais/scenarios/ (animals.cfg bottleneck_defense.cfg protect_unit.cfg wolves.cfg): MAI test scenarios: fight_on_without_leader -> defeat_condition http://git.io/X_f3-g 20140523 02:53:06-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140523 02:56:40< mattsc> Ivanovic: with that ^ I am all set for 1.11.15 20140523 03:00:26< irker959> wesnoth: Chris Beck wesnoth:master 7cd205832f34 / / (5 files in 4 dirs): add config attribute value tests, put them in project files also. http://git.io/Z8KDrQ 20140523 03:00:28< irker959> wesnoth: Chris Beck wesnoth:master f70cd0d6bc11 / data/ai/micro_ais/scenarios/ (animals.cfg bottleneck_defense.cfg protect_unit.cfg wolves.cfg): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/FfJaeA 20140523 03:09:10-!- sachith500 [~kvirc@112.134.219.20] has joined #wesnoth-dev 20140523 03:19:37-!- sachith500 [~kvirc@112.134.219.20] has quit [Read error: Connection reset by peer] 20140523 03:22:26-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20140523 03:24:12-!- sachith500 [~kvirc@112.134.219.20] has joined #wesnoth-dev 20140523 03:26:03< irker959> wesnoth: Chris Beck wesnoth:1.12 454720492239 / src/play_controller.cpp: refactor is_observer out of check_victory http://git.io/MzOwUg 20140523 03:33:34-!- ancestral_ [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140523 03:41:13-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140523 04:12:25< irker959> wesnoth: Chris Beck wesnoth:1.12 e45c40931d83 / changelog: update changelog http://git.io/_IlPig 20140523 04:12:27< irker959> wesnoth: Chris Beck wesnoth:1.12 4651007d9c74 / RELEASE_NOTES: update release notes http://git.io/PZLFmw 20140523 04:20:08-!- sachith500 [~kvirc@112.134.219.20] has quit [Ping timeout: 246 seconds] 20140523 04:30:33-!- c74d is now known as Guest20784 20140523 04:32:39-!- Guest20784 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 252 seconds] 20140523 04:33:13-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20140523 04:33:18< irker959> wesnoth: Chris Beck wesnoth:1.12 f72c2efa91e0 / src/ (6 files in 3 dirs): fixup error logging, catch parsing exceptions in editor, -p option http://git.io/hISiqQ 20140523 04:33:20< irker959> wesnoth: Chris Beck wesnoth:1.12 cc55a33bc70d / src/multiplayer_create_engine.cpp: Catch config::error exception which could be thrown by parser. http://git.io/07KdzQ 20140523 04:33:22< irker959> wesnoth: Chris Beck wesnoth:1.12 900a39a011d2 / changelog: update changelog http://git.io/3JbDrA 20140523 04:34:12-!- sachith500 [~kvirc@112.134.219.20] has joined #wesnoth-dev 20140523 04:37:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140523 04:39:50< irker959> wesnoth: Chris Beck wesnoth:master 688747e469d2 / src/multiplayer_create_engine.cpp: Catch config::error exception which could be thrown by parser. http://git.io/n7fbYg 20140523 04:41:49-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection] 20140523 04:42:03-!- Guest89373 [~cib@p5DD23FC5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140523 04:42:33-!- ancestral_ [~ancestral@12.23.74.29] has quit [Remote host closed the connection] 20140523 04:45:23-!- Guest89373 [~cib@p5DD23FC5.dip0.t-ipconnect.de] has quit [Client Quit] 20140523 04:45:41-!- cib [~cib@p5DD23FC5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140523 04:45:49< mattsc> Hi fabi__: it’s your intorduction of “cores” here: https://github.com/wesnoth/wesnoth/commit/b4ea561e376192316be76c7c021c6ae9605cb802 20140523 04:46:05-!- cib is now known as Guest29045 20140523 04:46:23< mattsc> that causes the duplication of campaigns in the campaign menu I showed earlier: http://imgur.com/TOEU0VX 20140523 04:46:49< mattsc> and all the duplicate unit messages of type “error config: Multiple [unit_type]s with id=Draug encountered.” 20140523 04:47:27< mattsc> on my system. I did a git bisect and that’s the commit which introduced it. 20140523 04:50:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Ciao] 20140523 04:55:21-!- wesbot changed the topic of #wesnoth-dev to: 1.11.15 (1.12 beta 5) planned for Saturday, May 24th | string+feature freeze active on 1.12 | 240 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140523 05:02:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140523 05:03:11< mattsc> Hmm, and when I click on the cores button in the main menu the game crashes with an assert: 20140523 05:03:17< mattsc> Assertion failed: (index < items_.size()), function select_item, file ../../src/gui/widgets/generator_private.hpp, line 646. 20140523 05:04:48< mattsc> Maybe I’m just doing something stupid, but I gotta run now, so no time to look into it any more tonight. 20140523 05:04:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Client Quit] 20140523 05:09:01-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev 20140523 05:44:40-!- Ivanovic [~ivanovic@frnk-5f74d580.pool.mediaWays.net] has quit [Changing host] 20140523 05:44:41-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140523 06:31:37-!- Guest29045 [~cib@p5DD23FC5.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds] 20140523 06:49:48-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20140523 06:52:33-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev 20140523 06:56:52-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140523 06:58:40-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140523 07:01:43-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20140523 07:04:08-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140523 07:07:05-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 276 seconds] 20140523 07:27:02-!- sachith500 [~kvirc@112.134.219.20] has quit [Read error: Connection reset by peer] 20140523 07:27:38-!- sachith500 [~kvirc@112.134.219.20] has joined #wesnoth-dev 20140523 07:39:53-!- irker959 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20140523 07:47:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20140523 08:01:49-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140523 08:05:01-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev 20140523 08:05:31-!- Necrosporus_ is now known as Necrosporus 20140523 08:06:03-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.] 20140523 08:19:31-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection] 20140523 08:20:07-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140523 08:24:14-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 240 seconds] 20140523 08:33:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140523 08:49:18-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140523 08:51:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140523 08:52:11-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev 20140523 09:06:03-!- kex [~kex@78.157.29.205] has quit [Remote host closed the connection] 20140523 09:06:35-!- kex [~kex@78.157.29.205] has joined #wesnoth-dev 20140523 09:07:21-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Ping timeout: 276 seconds] 20140523 09:08:01-!- mjs-de [~mjs-de@f049237167.adsl.alicedsl.de] has quit [Ping timeout: 252 seconds] 20140523 09:11:05-!- kex [~kex@78.157.29.205] has quit [Ping timeout: 258 seconds] 20140523 09:13:47-!- sachith500 [~kvirc@112.134.219.20] has quit [Ping timeout: 246 seconds] 20140523 09:14:08-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 09:21:56< c74d> Necrosporus, Aishiko: 20140523 09:22:10< c74d> zookeeper: If you want a GUI for Git, I hear SmartGit is as good as they come, and it’s free for non-commercial use. 20140523 09:23:13-!- mjs-de [~mjs-de@f049237167.adsl.alicedsl.de] has joined #wesnoth-dev 20140523 09:23:16< c74d> loonycyborg, AI0867: I’ve never programmed for Microsoft Windows and the subject is quite over my head, but maybe would help? 20140523 09:23:50< c74d> shadowm: The more placeholder-y name would be ‘C++1y’. 20140523 09:24:42< loonycyborg> c74d: I'm already aware of it. 20140523 09:25:23< loonycyborg> I was just asking him how to handle this until his filesystem branch is merged :P 20140523 09:25:34< c74d> Mm, I oughtn’t have spoken when I know nothing of the matter; my apologies. 20140523 09:25:36< loonycyborg> or maybe just wait for it.. 20140523 09:36:07-!- mjs-de [~mjs-de@f049237167.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds] 20140523 09:45:34-!- sachith500 [~kvirc@112.135.3.141] has left #wesnoth-dev ["Once you know what it is you want to be true, instinct is a very useful device for enabling you to know that it is"] 20140523 09:45:45-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 09:46:54-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140523 09:49:41-!- sachith500 [~kvirc@112.135.3.141] has quit [Client Quit] 20140523 09:55:42-!- mjs-de [~mjs-de@f049237167.adsl.alicedsl.de] has joined #wesnoth-dev 20140523 09:57:01-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 09:57:04-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev 20140523 09:57:14-!- sachith500 [~kvirc@112.135.3.141] has quit [Client Quit] 20140523 09:57:30-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 10:00:25-!- sachith500 [~kvirc@112.135.3.141] has quit [Read error: Connection reset by peer] 20140523 10:00:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140523 10:00:43-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 10:01:37-!- sachith500 [~kvirc@112.135.3.141] has quit [Read error: Connection reset by peer] 20140523 10:01:55-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 10:02:52-!- sachith500 [~kvirc@112.135.3.141] has quit [Read error: Connection reset by peer] 20140523 10:13:56-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 10:21:07-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 245 seconds] 20140523 10:21:29-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev 20140523 10:23:12-!- _8680_ [~8680@2002:4404:712c:0:a8d7:85ee:3fb2:639f] has quit [Ping timeout: 245 seconds] 20140523 10:24:24-!- _8680_ [~8680@2002:4404:712c:0:1826:75c0:98b1:2ec5] has joined #wesnoth-dev 20140523 10:24:56-!- _8680_ is now known as Guest87151 20140523 10:26:21-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 10:28:58-!- cib [~cib@132.231.178.142] has joined #wesnoth-dev 20140523 10:29:27-!- cib is now known as Guest22235 20140523 10:35:36-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev 20140523 10:39:08-!- sachith500 [~kvirc@112.135.3.141] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 20140523 10:55:21-!- wesbot changed the topic of #wesnoth-dev to: 1.11.15 (1.12 beta 5) planned for Saturday, May 24th | string+feature freeze active on 1.12 | 241 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140523 11:08:06-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game] 20140523 11:16:37-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev 20140523 11:24:56-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140523 11:25:29-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 11:26:09-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 11:30:20-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds] 20140523 11:42:59-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!] 20140523 12:10:16< AI0867> iceiceice: we're getting random test issues again on jenkins: http://baldras.wesnoth.org:8080/job/Wesnoth/150/ 20140523 12:11:19-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev 20140523 12:16:14-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds] 20140523 12:19:59-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140523 12:20:07< iceiceice> AI0867: im looking at log here: http://baldras.wesnoth.org:8080/job/Wesnoth/150/branch=master,compiler=default,label=Debian7-32/console 20140523 12:20:48< iceiceice> it says "Saved options: .. build_dir = 'build-default-1.12', strict = True, jobs = 4 20140523 12:20:48< iceiceice> Building Wesnoth version 1.13.0-dev" 20140523 12:21:28< iceiceice> then at the end before it runs the wml tests, it says "+ [ master != 1.12 ]" 20140523 12:22:14< iceiceice> so i cant see the errors but my bet is that its actually building 1.12 but is trying to use configuration files for master... 20140523 12:23:56< iceiceice> its better to run something like https://github.com/wesnoth/wesnoth/blob/master/travis_after_failure.sh after the tests, so we can see the errors if they exist 20140523 12:24:38< iceiceice> or pass verbose flag -v to "./run_wml_tests" 20140523 12:26:25< iceiceice> idk whats going on here: http://baldras.wesnoth.org:8080/job/Wesnoth/150/branch=1.12,compiler=default,label=Debian7-64/console 20140523 12:26:51< iceiceice> it sounds similar t what mattsc is reporting earlier 20140523 12:32:18-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140523 12:39:04-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev 20140523 12:40:49-!- markus_ [~mjs-de@f048032164.adsl.alicedsl.de] has joined #wesnoth-dev 20140523 12:44:13-!- mjs-de [~mjs-de@f049237167.adsl.alicedsl.de] has quit [Ping timeout: 258 seconds] 20140523 12:47:35-!- markus_ is now known as mjs-de 20140523 12:59:27-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 13:00:33-!- sachith500 [~kvirc@112.135.3.141] has quit [Read error: Connection reset by peer] 20140523 13:04:13< Soliton> for sane comparisons "[ master != 1.12 ]" should mean that some variable contained master and is being compared to 1.12. 20140523 13:04:44-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 13:10:10-!- sachith500 [~kvirc@112.135.3.141] has quit [Remote host closed the connection] 20140523 13:20:46-!- irker719 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140523 13:20:46< irker719> wesnoth: Guorui Xi(Kevin) wesnoth:master 8082cef7075a / src/ai/actions.cpp: Fix typos in comment http://git.io/7vCD9A 20140523 13:26:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140523 13:35:12-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 13:35:24< fabi__> hi mattsc 20140523 13:35:39< mattsc> hi fabi__ 20140523 13:36:00< fabi__> mattsc: Your problems with the core support might be caused by a missing _main.cfg file at toplevel. 20140523 13:36:03-!- Sulfur [~Miranda@p5B008448.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140523 13:36:31< fabi__> Do you start wesnoth from the source directory or is it "installed" properly? 20140523 13:37:15< fabi__> The _main.cfg (there are the cores defined) might not get installed with the rest of the data contents. 20140523 13:37:44< mattsc> fabi__: top level meaning inside the data/ directory or one level above it? 20140523 13:38:02< fabi__> data/_main.cfg 20140523 13:38:10< fabi__> this file is new 20140523 13:38:15< mattsc> There is a _main.cfg there 20140523 13:38:39< fabi__> And you are sure that your copy is using the right data directory? 20140523 13:38:54< fabi__> What is the content of the _main.cfg? 20140523 13:39:09< mattsc> It does include {core/} 20140523 13:39:17< fabi__> Are there several [core] definitions in it? 20140523 13:39:49< fabi__> sorry, I lied 20140523 13:40:03< fabi__> the _main.cfg I am speaking about is one level above data 20140523 13:40:25< mattsc> oh, alright then. 20140523 13:40:49< mattsc> Ah, I think I know what happened then ... 20140523 13:41:00< fabi__> You did not checkout at toplevel? 20140523 13:41:26< mattsc> No, it’s there in the repository 20140523 13:41:47< mattsc> But I need to tell Xcode to copy the resources to the build directory. 20140523 13:41:57< mattsc> And that file is not included there, I need to add that. 20140523 13:42:10< fabi__> Yeah, that is what I meant. 20140523 13:42:33< fabi__> I guess every other way of installing from source is missing the copy instruction as well. 20140523 13:43:02< fabi__> Thus it is not only broken on mac but for everyone who does not work from the source directory. 20140523 13:43:43< mattsc> Hmm, but I just copied over the file manually and that does not fix the problems. Do I need to do anything else? 20140523 13:44:18< fabi__> Can you verify that it works when you specify the source toplevel as data dir? 20140523 13:44:57< fabi__> ./wesnoth ./ should do the trick 20140523 13:46:07< mattsc> No, not on a Mac :P 20140523 13:46:42< fabi__> hmmm 20140523 13:46:56< fabi__> Any suspicious output? 20140523 13:47:20< mattsc> fabi__: I meant on a Mac that path is not quite right 20140523 13:47:36< mattsc> Yes, if I use the toplevel src dir it works 20140523 13:47:59< fabi__> okay, that restores some hope in me again... 20140523 13:48:14< mattsc> If I use the toplevel build dir it works as well. 20140523 13:48:55< mattsc> That’s one level above what is usually used as data dir (on the Mac at least), so that’s why it didn’t work without that. 20140523 13:49:27< fabi__> strange 20140523 13:49:48< mattsc> Usually data/ is used as data-dir. Isn’t that what it should be? 20140523 13:49:57< fabi__> I understand the code that it always loaded (before I changed it) /data/_main.cfg 20140523 13:50:28< mattsc> Hmm, maybe I am wrong about that? 20140523 13:51:02< mattsc> Okay, I was wrong about that… 20140523 13:51:06< fabi__> So I just changed it to load /_main.cfg for the core definitions plus the current specified core path which still defaults to /data/_main.cfg. 20140523 13:51:48< mattsc> It must be something how Xcode sets up the paths etc. The file structure in Mac Apps is somewhat … unintuitive. 20140523 13:52:29< mattsc> fabi__: anyway, I think I know what’s going on now and will figure out how to fix that for Xcode builds sometime. Thanks for the help. 20140523 13:53:13-!- sachith500 [~kvirc@112.135.3.141] has quit [Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/] 20140523 13:53:19< fabi__> mattsc: If it helps you the location of the core definition file can be moved, inside data for example. 20140523 13:55:11< mattsc> fabi__: okay, thanks. I don’t want to look into it right now in case this turns into a longer problem. I’m too busy for being distracted by fun things like that today :P 20140523 13:55:32-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 13:56:22< fabi__> mattsc: You are welcome :-) Just yell at me when you have the time for further investigations... 20140523 13:57:09< mattsc> Will do. My guess is that it’s a trivial fix once I figure out where to look. 20140523 14:00:45< AI0867> loonycyborg: a utf16::string to other encoding conversion function probably doesn't exist yet, but I can code one up pretty quickly 20140523 14:01:25< loonycyborg> I can use winapi function 20140523 14:01:39< loonycyborg> since that code will be winapi specific anyway 20140523 14:02:27< loonycyborg> But I must know which encoding to target :P 20140523 14:02:37< loonycyborg> oem or utf8 20140523 14:04:05< AI0867> iceiceice: I think the 1.12 dir is just one of the option-cache files being set up a bit weirdly 20140523 14:04:22< AI0867> anyway, I've just added the -v flag, I'll trigger another build now 20140523 14:04:40< AI0867> I don't even know what 'oem' means here 20140523 14:04:49< AI0867> "whatever the current ANSI encoding is"? 20140523 14:04:52< AI0867> always use utf8 20140523 14:06:59-!- knotwork [~markm@unaffiliated/knotwork] has quit [Read error: Connection reset by peer] 20140523 14:07:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping] 20140523 14:08:52< loonycyborg> That's nice in theory, but winapi expects ansi encoding 20140523 14:09:01< loonycyborg> And if we aren't doing any conversions 20140523 14:09:08< loonycyborg> I'll have to use ansi 20140523 14:09:26-!- travis-ci [~travis-ci@ec2-54-198-159-149.compute-1.amazonaws.com] has joined #wesnoth-dev 20140523 14:09:26< travis-ci> [travis-ci] wesnoth/wesnoth#2764 (master - 8082cef : Guorui Xi(Kevin)): The build was broken. 20140523 14:09:26< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25871013 20140523 14:09:26-!- travis-ci [~travis-ci@ec2-54-198-159-149.compute-1.amazonaws.com] has left #wesnoth-dev [] 20140523 14:11:35< iceiceice> AI0867, fabi_: the "multiple [unit_types]s with id=X encountered" errors are the same as what mattsc reported 20140523 14:11:55< iceiceice> can we veriy that jenkins is moving the root level _main.cfg file properly? 20140523 14:19:49-!- sachith500 [~kvirc@112.135.3.141] has quit [Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/] 20140523 14:20:51< iceiceice> AI0867: as for the master build: i dont know why all the tests are failing and not giving output... 20140523 14:20:56< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/run_wml_tests#L101 20140523 14:21:23< iceiceice> oh 20140523 14:21:31< iceiceice> i guess i changed it, it will only do that if you use -w instead of -v 20140523 14:23:18< loonycyborg> AI0867: It's passing strings without conversions to system apis like _mkdir all over the place. 20140523 14:23:59-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 14:24:28< loonycyborg> boost.filesystem branch will use proper encodings for syscalls and honor our utf8 standard 20140523 14:25:11< loonycyborg> but currently our current encoding for filenames on windows seems to be 'ansi', 'oem', or however it's called.. 20140523 14:27:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140523 14:28:23< AI0867> iceiceice: what do you mean, moving it properly? 20140523 14:28:36< AI0867> http://baldras.wesnoth.org:8080/job/Wesnoth/151/branch=master,compiler=default,label=Debian7-32/console 20140523 14:28:40< iceiceice> did you read this thing above between fabi and mattsc? 20140523 14:29:18< AI0867> iceiceice: now building with -w 20140523 14:29:24< AI0867> no 20140523 14:29:29< iceiceice> the "cores" things introduces a new file _main.cfg which is below data/ i guess? (if i followed correctly) 20140523 14:29:57< iceiceice> for mattsc's xcode build this somehow wasnt recognized, 20140523 14:30:03< iceiceice> and the result was that core was loaded twice 20140523 14:30:09< iceiceice> and all campaigns appeared twice in the menu 20140523 14:30:12< iceiceice> and all units were loaded twice 20140523 14:30:27< AI0867> ah, that sounds like it 20140523 14:31:53< AI0867> loonycyborg: this sounds like something that should be fixed on the gentoo slave. Can you fix it? I need to leave soon 20140523 14:31:59-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev 20140523 14:32:38< AI0867> loonycyborg: there's some utf8/ansi conversion in the saves system. It's hidden (for some reason) inside space2underscore and reverse 20140523 14:32:53< loonycyborg> What exactly needs to be fixed on gentoo slave? 20140523 14:33:02< loonycyborg> I don't know much about testing scripts.. 20140523 14:33:04< AI0867> the 'cores' _main.cfg 20140523 14:33:27< AI0867> that is, wesnoth-git/_main.cfg, rather than wesnoth-git/data/_main.cfg 20140523 14:34:08< AI0867> it appears that {_main.cfg} is loaded twice, as there's some path issue there 20140523 14:34:20< AI0867> which is causing this failure: http://baldras.wesnoth.org:8080/job/Wesnoth/151/branch=1.12,compiler=4.7,label=Gentoo-64/console 20140523 14:34:30< AI0867> on all gentoo master builds 20140523 14:34:48< loonycyborg> I see no _main.cfg in wesnoth-git/ 20140523 14:35:08< AI0867> or that's what I'd expect to happen... 20140523 14:35:12< loonycyborg> oh wait 20140523 14:35:16< AI0867> but that's the 1.12 branch 20140523 14:35:56< loonycyborg> something weird is happening 20140523 14:36:08< loonycyborg> ls _main.cfg 20140523 14:36:14< loonycyborg> it showed such file exists 20140523 14:36:21< loonycyborg> I tried it again abit later 20140523 14:36:25< loonycyborg> and it doesn't exist 20140523 14:36:30< loonycyborg> spooky! 20140523 14:37:11-!- sachith500 [~kvirc@112.135.3.141] has quit [Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/] 20140523 14:37:17< loonycyborg> Something creates and removes it I guess? 20140523 14:37:34< Necrosporus> The last scenario of south guard is vinnable on 3rd turn 20140523 14:40:11-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 14:40:36< AI0867> loonycyborg: I'm running a build 20140523 14:40:46< AI0867> so yeah, I'd expect that to happen as it repeatedly checks out 1.12 and master 20140523 14:41:14< loonycyborg> maybe just git rm it then? 20140523 14:41:23< AI0867> ? 20140523 14:41:45< loonycyborg> if it exists in a repository and is causing problems 20140523 14:41:50< AI0867> NO 20140523 14:42:27< AI0867> it's supposed to be there, but the binary seems to find a different file (data/_main.cfg) instead in some cases 20140523 14:42:41< AI0867> causing the entire tree to be loaded twice, rather than 3 small nodes to be appended 20140523 14:43:13< AI0867> anyway, just 4 more unchanged builds to do and you'll have a static slave to test on 20140523 14:43:14< loonycyborg> I thought it never will run 2 builds in parallel on same slave 20140523 14:43:18< AI0867> it doesn't 20140523 14:43:28< AI0867> but it's running builds rapidly as nothing has changed since the last build 20140523 14:43:31< AI0867> other than the build script 20140523 14:43:45< loonycyborg> how can it end up with a different file then? 20140523 14:44:02-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds] 20140523 14:44:03< AI0867> xcodee had the same issue, and I believe you're doing out-of-tree builds? 20140523 14:44:39< AI0867> anyway, I *really* need to be off now 20140523 14:44:43< loonycyborg> partially out-of-tree :P 20140523 14:45:00< loonycyborg> all products except binaries will be in different dirs 20140523 14:45:14-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 14:45:15< AI0867> 2 more builds to go, and apparently, half the master builds fail on gentoo now 20140523 14:45:20< loonycyborg> binaries will be created in wesnoth-get/ 20140523 14:45:22< loonycyborg> *git 20140523 14:45:26< AI0867> this seems to be very nondeterministic 20140523 14:45:38< AI0867> just look at this grid: http://wesnoth.org:8080/job/Wesnoth/152/ 20140523 14:46:40< loonycyborg> http://baldras.wesnoth.org:8080/job/Wesnoth/branch=master,compiler=4.7,label=Gentoo-64/152/console 20140523 14:46:46< loonycyborg> it seems to mention timeouts 20140523 14:47:14< loonycyborg> oh wait 20140523 14:47:17< loonycyborg> it's expected 20140523 14:54:12< Aishiko> Coffee_irc, mattsc I have a small issue with tracking an image through the system, I can once it hits the C++ code but the lua/wml layer that tells it which is a bit murky, I think its the part about the overlays is that right? afk back in a bit 20140523 14:57:26< Necrosporus> New Giant Scorpion sprite is much more dreadful than old one, but it's just first level, is such a big sprite appropriate? 20140523 14:57:54< Necrosporus> maybe make it lvl2 or lvl3 monster? 20140523 15:14:27-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has joined #wesnoth-dev 20140523 15:14:54-!- lord-knyghtmare [~tahsinjah@203.188.163.173] has joined #wesnoth-dev 20140523 15:15:19< aquileia> Necrosporus: It was considered back when zero created the sprite, but balancing was deemed more important 20140523 15:16:04< aquileia> After all, you'd have to change the stats accordingly and rebalance every campaign featuring them 20140523 15:17:42< aquileia> Sorry that I had to leave that suddenly, and thanks again zookeeper 20140523 15:19:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140523 15:19:25< Necrosporus> aquileia, introduce new unit "Scorpion King" with new sprite and leave old one with old 20140523 15:19:39< Necrosporus> Then you won't need to rebalance anything 20140523 15:20:35< aquileia> Well, they took a different solution - and after all you don't need more units but better sprites for those you have 20140523 15:20:48< Necrosporus> I'm not sure old sprite is better 20140523 15:21:02< Necrosporus> * new sprite 20140523 15:21:15< Necrosporus> It's not animated also 20140523 15:22:25< aquileia> I'm one of those people disliking non-animated replacements, but... for scorpions it's fine IMHO 20140523 15:23:22< aquileia> By the way, if you want to discuss sprites, ask Jetrel 20140523 15:26:20< Necrosporus> I don't think scorpions are any different for this matter 20140523 15:28:12< aquileia> noy: As I don't know about your timezone I'm assuming you won't have much time right now? 20140523 15:28:34< noy> Its 830 am... unfortunately I'm about to head to work 20140523 15:28:42< aquileia> ah, ok 20140523 15:29:06< lord-knyghtmare> Sorry, for changing the topic, but I needed to discuss something. How is the number of AI sides on the map related to the speed of gameplay? I find that maps having a large number of AI sides tend to be the slowest in terms of turns. There was a map in which a turn took 5 minutes. Is there any way to counteract this? 20140523 15:29:49-!- Guest22235 [~cib@132.231.178.142] has quit [Ping timeout: 258 seconds] 20140523 15:36:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds] 20140523 15:36:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140523 15:36:47< Necrosporus> it's not quite a bug, but in 1.11 05_Choice_In_The_Fog.cfg is quite slow, at least at the start, also Wesnoth seem to eat even more CPU than in 1.10 20140523 15:37:27< Necrosporus> There are only two or three AI sides 20140523 15:37:56< Necrosporus> also it started to be slow even before AI recruited anything 20140523 15:38:08< Necrosporus> Maybe it's because of fog+shroud? 20140523 15:41:34< lord-knyghtmare> The scenario that I'm referring to is one of my own. It has a total of 15 sides. Yes, 15 sides, with the AI having control over 14 of them. 20140523 15:42:05< lord-knyghtmare> The map itself is around 66x66. 20140523 15:42:15< lord-knyghtmare> Plus, there's fog and shroud 20140523 15:42:57< lord-knyghtmare> However, the objectives only involve the player, exploring a minor part of it. The rest of it is the background of an epic battle. 20140523 15:45:18< aquileia> lord-knyghtmare: mattsc wrote an AI for scenarios like the NR finale... perhaps that's a solution for you? 20140523 15:45:34< lord-knyghtmare> The next scenario that I'm planning is one of the last ones of TLB, and involves a large map and around 10 AI sides, 12 sides overall. Should reconsider the design and reduce the amount of sides (allies and enemies?) Or, should I continue with my current plans? 20140523 15:45:49< lord-knyghtmare> There's an AI specially designed for this? 20140523 15:46:04< lord-knyghtmare> Which wesnoth version does it appear in? 20140523 15:46:08< aquileia> It computes faster, but is a little less efficient 20140523 15:46:10< mattsc> Did somebody summon me? 20140523 15:46:24< lord-knyghtmare> I have Wesnoth 1.11.11 currently installed 20140523 15:46:34< mattsc> lord-knyghtmare: hi, I can’t stay around, but the AI aquileia is talking about is this: 20140523 15:46:44-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140523 15:46:49< mattsc> http://wiki.wesnoth.org/Micro_AIs#Fast_Micro_AI_.28ai_type.3Dfast_ai.29 20140523 15:47:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds] 20140523 15:47:09-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20140523 15:47:28< mattsc> It’s in mainline only in 1.13, but since it’s entirely Lua, it can be used in 1.11/1.12 as well, with minor effort: 20140523 15:47:40< mattsc> http://wiki.wesnoth.org/Micro_AIs#Using_Development_.281.13.29_Version_Micro_AIs_in_your_Stable_.281.12.29_Version_Add-on 20140523 15:47:58< lord-knyghtmare> Thank you, that's just the AI I have been looking for. However, I cannot apply it to 1.10 I suppose 20140523 15:48:13-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140523 15:48:22< mattsc> No, it won’t work in 1.10. 20140523 15:48:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140523 15:48:40< mattsc> Necrosporus: you could turn fog off in debug mode to see if that is the reason. 20140523 15:48:46-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 15:49:08< lord-knyghtmare> Well, if better performance means having to drop support for 1.10, then so be it. Is this micro_ai available in 1.12? 20140523 15:49:09< mattsc> lord-knyghtmare: that AI has seen essentially no testing, so any feeback would be most welcome. 20140523 15:49:14-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140523 15:49:35< mattsc> lord-knyghtmare: see my comment a few lines up there (and the link) 20140523 15:49:36-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 15:50:20< mattsc> clarification: it has seen essentially no testing in “real” campaign use. I’ve done quite a bit of testing of it in test scenarios, of course. 20140523 15:50:36< lord-knyghtmare> Thus, I copy the files into my campaign's directory and then apply the instructions provided? 20140523 15:50:43< lord-knyghtmare> Sounds simple enough. 20140523 15:51:07< mattsc> yes. Just let me know if you have any problems with it. 20140523 15:51:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140523 15:52:05< lord-knyghtmare> All right. I shall download the necessary files and start with implementation process. It shouldn't take me long. 20140523 15:52:36< mattsc> lord-knyghtmare: sounds good. I’ll be online but not necessarily around much today (just FYI). 20140523 15:54:08< Necrosporus> mattsc, fog seem to be the reason 20140523 15:54:34< mattsc> lord-knyghtmare: one more comment, this AI hasn’t been tested in such a massive scenario. So I don’t know how it will do, neither for speed nor for behavior. I’d appreciate if you let me know how it works out for you. There’s also a feedback thread on Micro AIs in the Coders’ Corner forum, if you want to use that. 20140523 15:55:07< mattsc> Necrosporus: okay, if it’s not AI related, then I can’t help. 20140523 15:56:00< lord-knyghtmare> Don't worry. I have no intention of trying it out today as well. It's 10:02PM and I got studying to do since my IAL exams are currently in progress. However, I shall provide feedback. Necrosporus: I can disable the fog option. It would allow players to witness the epic battle :p 20140523 15:56:30< mattsc> lord-knyghtmare: okay, good luck 20140523 15:59:19< aquileia> lord-knyghtmare: As to dropping 1.10 support... IIRC you can easily keep backwards compatibility by disabling the AI on 1.10 20140523 15:59:50< aquileia> I don't know about the details, though 20140523 16:00:24< lord-knyghtmare> Meaning that players who are on 1.10 would have to undergo frustration while those on 1.12, enjoy the fast play? It's a sufficient sacrifice. 20140523 16:02:01< aquileia> I'm not too sure how you mean that... which sacrifice, dropping 1.10 or slow 1.10? 20140523 16:03:09< lord-knyghtmare> I meant the slow performance in 1.10 20140523 16:03:56< aquileia> AtS is a prime candidate if you want an example how to use the #ifver WESNOTH_VERSION > 1.11.x 20140523 16:04:22< lord-knyghtmare> However, I might keep that scenario as the only big scenario in TLB. As for future scenarios, I might cut down AI sides. 20140523 16:04:40< lord-knyghtmare> Another problem: How do I use multiple leaders for the same AI side? 20140523 16:07:56-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20140523 16:08:53< mattsc> lord-knyghtmare: depends very much on what you mean by “use”. For the most part (and most AIs) don’t support multiple leaders. 20140523 16:08:54< aquileia> Ok, AtS was a prime example... seems most of that has been dropped by now. But you can still look at the commit: https://github.com/shikadilord/After_the_Storm/commit/fd2b6fd0cea1566761 20140523 16:09:15< mattsc> However, recruiting with multiple leaders is supported as of 1.11.7 (or thereabouts) 20140523 16:09:44< mattsc> http://wiki.wesnoth.org/AI_Recruitment#Some_notes_on_multiple_leaders 20140523 16:11:58< lord-knyghtmare> This is applicable for 1.11 and above? 20140523 16:12:32< mattsc> 1.11.7 (I think, might be 1.11.8) and later 20140523 16:13:03< lord-knyghtmare> I have 1.11.11, so that won't be a problem. 20140523 16:13:47< iceiceice> lord-knyghtmare: you should know that "officially" wesnoth only supports 9 sides right now, 20140523 16:14:03< iceiceice> that is hard coded into the server, you wont be able to play your campaign as an mp campaign if it has more sides than that 20140523 16:15:34< lord-knyghtmare> TLB (and its sequel, if I ever get around to that) is SP only. I made an MP campaign once, but it ended in disaster. Thus, I am sticking to SP development. 20140523 16:15:46< iceiceice> ok just thought i would let you know :) 20140523 16:16:32-!- StandYourGround [~Adium@CPE-24-209-146-0.wi.res.rr.com] has joined #wesnoth-dev 20140523 16:18:38< lord-knyghtmare> Thanks anyways though. BTW, are there any MP factions that want to make their debut in Irdya (in the TLB sequel)? I'm looking for something new rather than just plain orc, undead, and minotaur thrashing scenarios. 20140523 16:20:12-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving] 20140523 16:23:47-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev 20140523 16:25:34-!- StandYourGround [~Adium@CPE-24-209-146-0.wi.res.rr.com] has quit [Quit: Leaving.] 20140523 16:28:29-!- sachith500 [~kvirc@112.135.3.141] has quit [Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/] 20140523 16:30:24-!- cib [~cib@p5DD216FB.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140523 16:30:48-!- cib is now known as Guest36501 20140523 16:31:12-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140523 16:31:31-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 16:35:33-!- sachith500 [~kvirc@112.135.3.141] has joined #wesnoth-dev 20140523 16:39:57-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev 20140523 16:43:43-!- lord-knyghtmare [~tahsinjah@203.188.163.173] has left #wesnoth-dev [] 20140523 16:48:21-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140523 16:51:05-!- sachith500 [~kvirc@112.135.3.141] has quit [Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/] 20140523 16:56:07-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20140523 16:57:27-!- Sulfur [~Miranda@p5B008448.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20140523 16:57:35< Necrosporus> I have finished first tutorial and Lisar lost exp she gained in battle, is it ok? 20140523 17:03:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140523 17:04:40< happygrue> probably not, but I don't recall if the dialogue explains that somehow 20140523 17:04:50< Necrosporus> It doesn't 20140523 17:05:01< Necrosporus> I guess it's a bug introduced in 1.11 20140523 17:05:04< happygrue> seems like the kind of thing that would be very confusing to a new player 20140523 17:05:11< happygrue> could you file a report please? 20140523 17:05:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140523 17:05:40< Necrosporus> Maybe we could highlight zookeeper? 20140523 17:05:51-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral] 20140523 17:06:22< happygrue> maybe we could, maybe. 20140523 17:06:38< Necrosporus> happygrue, I do not like that stuff, registering, filing reports and so on... And I guess it's quite trivial 20140523 17:07:34-!- spoffy [~spoffy@152.78.175.8] has quit [Ping timeout: 258 seconds] 20140523 17:07:38< happygrue> who knows if it's trivial or not. Did your other units keep their xp? 20140523 17:07:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20140523 17:10:19< Necrosporus> probably 20140523 17:13:41< Necrosporus> line 432 data/campaigns/tutorial/scenarios/2_Tutorial.cfg 20140523 17:15:28< Necrosporus> happygrue, I guess I fixed it, let's check 20140523 17:15:41-!- Sulfur [~Miranda@p5B008448.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140523 17:19:04< Soliton> bug reporting is indeed quite trivial and does not require registering. 20140523 17:20:27< happygrue> Necrosporus: what version are you using? 20140523 17:21:23< Necrosporus> yesterday's 1.12't git 20140523 17:21:46< happygrue> line 432 is: canrecruit=yes 20140523 17:22:56-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 17:23:15-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140523 17:26:29< Necrosporus> no, I didn't fix it 20140523 17:27:09< Necrosporus> type=Fighteress 20140523 17:27:13< Necrosporus> if you want 20140523 17:27:20< Necrosporus> not this line exactly 20140523 17:28:13-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140523 17:29:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140523 17:29:36< zookeeper> yes, just add experience=$student.experience after line 432 20140523 17:30:12< Necrosporus> It didn't work 20140523 17:30:36-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 17:30:52< zookeeper> err, s/student/student_save i mean 20140523 17:31:05-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds] 20140523 17:31:37-!- vernon [~quassel@77-234-83-36.pool.digikabel.hu] has joined #wesnoth-dev 20140523 17:31:51< zookeeper> although that whole if block seems very pointless except for the objectives. the leader is already carried over so there's no need to re-create the unit. 20140523 17:33:39< Necrosporus> zookeeper, there's other problem, I leveled Li'sar at 1st scenario and she got only 32 hp again 20140523 17:33:41-!- kex [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140523 17:33:45-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 17:33:49< Necrosporus> So it's not enough to fix whole problem 20140523 17:34:00< zookeeper> indeed 20140523 17:34:42< zookeeper> if someone could be bothered to do it, i'd say remove the whole if block and do the objective text via a variable 20140523 17:35:35< zookeeper> ...and making sure that the leader carryover actually does work right 20140523 17:37:30< Necrosporus> wesnoth: ./wesnoth/src/gui/widgets/grid.cpp:529: virtual void gui2::tgrid::place(const gui2::tpoint&, const gui2::tpoint&): Assertion `false' failed. 20140523 17:37:52< Necrosporus> By the way game crashed when I tried to use inspect window to inspect student_save variable 20140523 17:39:46-!- Kexoth [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140523 17:40:01-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 17:53:41-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev 20140523 17:54:27-!- ancestral [~ancestral@17.114.45.98] has quit [Client Quit] 20140523 17:59:58-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev 20140523 18:03:31< iceiceice> Necrosporus: i looked at the code that is failing assertion, 20140523 18:04:02< iceiceice> i think there might be a logic error, grid.cpp:466 ? 20140523 18:04:30< iceiceice> i think maybe it should be || instead of && there, dont know though 20140523 18:06:33< Necrosporus> I didn't look at the code, I just pointed out a problem I encountered 20140523 18:07:04< iceiceice> y so the thing is 20140523 18:07:14< iceiceice> theres like maybe 1 or 2 people who would know what the problem is there 20140523 18:07:21< iceiceice> and they are not going to read all of the logs every day 20140523 18:07:30< iceiceice> just skim for "name: ..." 20140523 18:07:45< iceiceice> if you file a bug report then they will see that 20140523 18:07:54< iceiceice> or at least, odds are better 20140523 18:08:16< iceiceice> stuff that is said on irc and not immediately responded to by a dev is basically forgotten 20140523 18:08:27< iceiceice> and even then may still be forgotten :) 20140523 18:11:20< Necrosporus> zookeeper, I removed all the block in [then] except objectives and it seem to work 20140523 18:20:10< Necrosporus> Also recalled fighters got no traits 20140523 18:21:43-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140523 18:22:19-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 18:26:33-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds] 20140523 18:27:49-!- vernon [~quassel@77-234-83-36.pool.digikabel.hu] has quit [Read error: Connection reset by peer] 20140523 18:30:39< Necrosporus> Seems this code was not changed since 1.10 20140523 18:43:37-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!] 20140523 18:51:24< Necrosporus> zookeeper, I just checked (with 1.10) if it was Konrad, XP was not cleared, so it's perhaps not intended 20140523 18:52:04< Necrosporus> I guess you could just remove whole storing unit / killing / restoring and it would be enough 20140523 18:54:43-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds] 20140523 18:56:12-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20140523 18:56:14-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has quit [Ping timeout: 276 seconds] 20140523 19:03:27-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game] 20140523 19:06:21-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!] 20140523 19:11:13-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev 20140523 19:18:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140523 19:22:06-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev 20140523 19:25:07< Necrosporus> shadowm, could you replace '&&' with '||' in ./wesnoth/src/gui/widgets/grid.cpp:466 ? It seem to fix my problem with inspect window in 1.12 20140523 19:29:47-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20140523 19:31:53< shadowm> Why are you asking me? 20140523 19:32:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20140523 19:32:12< Necrosporus> because of you being in commit history of this file 20140523 19:32:26-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 19:32:31< shadowm> That doesn't mean I really know much about gui2::tgrid. 20140523 19:33:23< Necrosporus> is Mark de Wever here? 20140523 19:33:33< shadowm> Best open a bug and attach a patch for mordante, or make a pull request. In either case you are expected to be able to justify your patch. 20140523 19:33:44< shadowm> Mark de Wever is mordante. 20140523 19:36:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20140523 19:36:44< Necrosporus> I do not know how should I justify the patch. It's just works after change and didn't work before 20140523 19:37:28< Necrosporus> if it's better fixed other way, then let it be 20140523 19:37:34< shadowm> I don't like unsolicited CTCPs. 20140523 19:37:50-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds] 20140523 19:39:16< Necrosporus> zookeeper, do I need to file bug for tutorial problem? It also affects 1.10 20140523 19:39:59< zookeeper> if no one else really can, then i guess i can deal with it right away 20140523 19:40:08< zookeeper> as much as i detest touching the tutorial 20140523 19:46:45< Necrosporus> zookeeper, I also used grep student_save and it doesn't seem to be used anywhere else... Why does it exist at all? 20140523 19:46:48< Necrosporus> Soliton, 20140523 19:47:57< Necrosporus> https://github.com/wesnoth/wesnoth/blame/1.12/data/campaigns/tutorial/scenarios/2_Tutorial.cfg 20140523 19:48:38-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev 20140523 19:49:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140523 19:51:01< irker719> wesnoth: ln-zookeeper wesnoth:1.12 e582e51acd2b / data/campaigns/tutorial/scenarios/2_Tutorial.cfg: Fixed Li'sar not carrying over correctly http://git.io/cjYung 20140523 19:53:46< irker719> wesnoth: ln-zookeeper wesnoth:master 91c13b82c0a6 / data/campaigns/tutorial/scenarios/2_Tutorial.cfg: Fixed Li'sar not carrying over correctly http://git.io/I2mMZA 20140523 19:53:48< zookeeper> that should do it 20140523 20:00:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140523 20:01:27< Necrosporus> So 1.10 won't be fixed? 20140523 20:01:59< shadowm> The odds of another 1.10 release at this point are pretty much nil. 20140523 20:06:58< Necrosporus> but it has security fix 20140523 20:09:29< zookeeper> no, i won't fix 1.10. 20140523 20:12:07< shadowm> It has one security fix and I already pointed Ivanovic to it and received no response, so I assume he doesn't consider it significant enough to warrant a 1.10.8 release. 20140523 20:13:21< shadowm> I won't be pushing for it unless someone can prove that my analysis in the last comment to the tracker entry is incorrect. 20140523 20:14:31< shadowm> It's unfortunate, but that's the way things work here. 20140523 20:15:59< shadowm> aquileia: You could've referred to the latest tagged AtS version -- the compatibility drop is going to be in version 0.9.10, which hasn't been released yet. 20140523 20:17:06< aquileia> Well, that commit has all the compatibility code in one place 20140523 20:17:36< shadowm> Only for 1.10. I dropped 1.11.x bug workarounds and such in a more staggered fashion. 20140523 20:25:53-!- trewe [~trewe@177.53.54.77.rev.vodafone.pt] has joined #wesnoth-dev 20140523 20:30:27-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev 20140523 20:31:18< iceiceice> shadowm: abt the patch Necrosporus just mentioned: 20140523 20:31:30< iceiceice> he reported an assertion failure in that function, 20140523 20:31:38< iceiceice> i examined the function and it looks like there is a logic error, 20140523 20:31:54< iceiceice> && -> || was an obvious alternative, 20140523 20:31:56< janebot_> iceiceice: Of course! 20140523 20:32:27< iceiceice> i havent tested it though... 20140523 20:33:50< Necrosporus> iceiceice, I didn't test it extensively but at least there's no longer assertion failures and inspector seem to work (though I don't like that horizontal scrolling) 20140523 20:34:29< iceiceice> woudl ahve to read more code to know if its actually a good idea 20140523 20:36:57< shadowm> iceiceice: I have no idea, ask mordante. 20140523 20:38:18-!- Sulfur [~Miranda@p5B008448.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20140523 20:43:10< irker719> wesnoth: Chris Beck wesnoth:master 24155ad537e7 / src/map_location.hpp: refactor map_location.hpp to drop util.hpp include http://git.io/OKLHrw 20140523 20:43:12< irker719> wesnoth: Chris Beck wesnoth:master ef3e0e4ad1c2 / data/campaigns/tutorial/scenarios/2_Tutorial.cfg: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/-4LB3w 20140523 20:48:55-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140523 20:49:33< Necrosporus> How can I sync my local copy with git server? 'git fetch origin' seem not enough 20140523 20:50:14< aquileia> git pull 20140523 20:50:15< Aishiko> Necrosporus, try 'git pull origin' 20140523 20:52:47< Necrosporus> I got a bunch of conflicts 20140523 20:54:19< aquileia> Do you want to preserve your local changes? 20140523 20:54:36< Necrosporus> I guess not, there were only two files 20140523 20:55:03< aquileia> git reset --hard HEAD will get you to a clean state, then git pull origin 20140523 20:55:49< shadowm> It'll also default to HEAD if HEAD isn't specified. 20140523 20:55:59< Necrosporus> still lots of conflicts 20140523 20:56:47< Necrosporus> CONFLICT (content): Merge conflict in data/ai/micro_ais/scenarios/animals.cfg 20140523 20:58:42< aquileia> hmm, the reset should bring that file back to the state where the changes apply cleanly... 20140523 20:58:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140523 20:59:28< aquileia> I'm no expert, but could you link a paste to the output of git status? 20140523 21:01:22< aquileia> s/to/of 20140523 21:01:59< Necrosporus> http://pastebin.com/K8qR8h2z 20140523 21:02:06< Necrosporus> I didn't change listed files 20140523 21:02:39< aquileia> yeah, the git fetch changed them 20140523 21:02:47< aquileia> I guess 20140523 21:03:14< aquileia> and you did use the --hard for the reset? 20140523 21:03:35< Necrosporus> ye 20140523 21:04:47< Necrosporus> I guess it's easier to just remove git dir and wait for release tarball 20140523 21:05:07< trewe> fetch does not change the working checkout 20140523 21:05:32< trewe> do just a git reset --hard HEAD^ 20140523 21:07:00< Necrosporus> this time it works 20140523 21:07:08< Necrosporus> though what does "^" mean? 20140523 21:07:18< shadowm> "The commit that is the first ancestor of HEAD." 20140523 21:07:34< shadowm> i.e. the previous commit. 20140523 21:08:07< shadowm> It sounds like you somehow wound up with an additional commit that isn't merged upstream. 20140523 21:09:27< Necrosporus> Thank you, it's the case yes 20140523 21:11:04< iceiceice> Necrosporus: if you want to make "experimental commits", its best to make a temporary branch 20140523 21:11:11< iceiceice> like, checkout -b experiment 20140523 21:11:12< iceiceice> then make your commits 20140523 21:11:25< iceiceice> and you can checkout experiment later if you want to 20140523 21:13:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140523 21:25:31-!- travis-ci [~travis-ci@ec2-54-198-159-149.compute-1.amazonaws.com] has joined #wesnoth-dev 20140523 21:25:31< travis-ci> [travis-ci] wesnoth/wesnoth#2767 (master - ef3e0e4 : Chris Beck): The build was broken. 20140523 21:25:31< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25904503 20140523 21:25:31-!- travis-ci [~travis-ci@ec2-54-198-159-149.compute-1.amazonaws.com] has left #wesnoth-dev [] 20140523 21:36:50-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20140523 21:38:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140523 21:39:39< iceiceice> gfgtdf: i made some extensions to your make_enum macro: https://github.com/cbeck88/wesnoth/compare/makeenum 20140523 21:40:08-!- Guest36501 [~cib@p5DD216FB.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds] 20140523 21:45:40< Necrosporus> http://wiki.wesnoth.org/AbilitiesWML I can't find where is described what's difference between new format and "deprecated format for its description, using its name as the first line" 20140523 21:48:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140523 21:51:42-!- mjs-de [~mjs-de@f048032164.adsl.alicedsl.de] has quit [Remote host closed the connection] 20140523 21:55:08< zookeeper> no matches for "deprecated format" on the whole page 20140523 21:56:12< Necrosporus> Though game complains 20140523 21:56:49< Necrosporus> But it seems just ability description doesn't need "Ability name:" as first line anymore 20140523 22:14:47< Coffee_irc> ping Aishiko 20140523 22:17:15-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!] 20140523 22:18:00< Aishiko> ping Coffee_irc 20140523 22:18:19< Coffee_irc> Aishiko: you're having trouble tracking images throughout the code life cycle? 20140523 22:19:03< Coffee_irc> boucman gave me a good tutorial on irc about how it all linked together once 20140523 22:19:26< Coffee_irc> what are you looking to do? 20140523 22:19:34< Necrosporus> I wonder if there's any wesnoth art beside portraits and sprites... like this http://upload.wikimedia.org/wikipedia/commons/5/5b/Elf_markwoman_by_Kitty.png 20140523 22:19:39< Aishiko> sort of, I can track an image once the C++ is invocced but before that I get murky 20140523 22:20:06< Coffee_irc> Aishiko: ah, so you want how to turn WML into C++? 20140523 22:20:13< Coffee_irc> for unit animations 20140523 22:20:33< Aishiko> Coffee_irc, ^^ basically I wanted to look at the code from WML is processed so that the C++ in image.cpp is called 20140523 22:20:39< Aishiko> Coffee_irc, bingo! 20140523 22:20:49< Coffee_irc> ok 20140523 22:20:59< Coffee_irc> it is read in via a "config" object 20140523 22:21:00< Aishiko> the wiki covers how to use it but not how it works sadly 20140523 22:22:02< Coffee_irc> Aishiko: I wrote some debug functions that might give you a good idea of how it works 20140523 22:22:08< Coffee_irc> just looking for them 20140523 22:23:15< Aishiko> Thank you, I'm sort of glad no one answered earlier, I was out playing mover for family, when their friend with the truck left them in the lurch on their day off to do the move 20140523 22:23:33< Coffee_irc> Aishiko: I wrote in unit_animation.cpp the std::ostream& operator << function 20140523 22:23:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Ciao] 20140523 22:23:55< Coffee_irc> Aishiko: we all have other things happening in life ;) 20140523 22:24:01< aquileia> Necrosporus: story art! e.g. https://github.com/aquileia/wesnoth-resources/tree/master/story_art 20140523 22:24:15< Coffee_irc> Aishiko: np if you need to say you need to take a break and come back later 20140523 22:24:24< Coffee_irc> you're not tied to irc :P 20140523 22:24:43< aquileia> iceiceice: Please tell me there'll never be non-ascii names for wml unit tests... 20140523 22:24:46-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140523 22:25:10< iceiceice> i hope not :) 20140523 22:25:16< aquileia> ok 20140523 22:25:24< Coffee_irc> Aishiko: the function "unit_animation::add_anims" in unit_animation.cpp could be good to look at also 20140523 22:25:42< Aishiko> no we're done I'm not getting heat stroke, plus 2 women are no match for some of the furniture! 20140523 22:26:43< Coffee_irc> Aishiko: did you at least get those sack-truck things? 20140523 22:27:20< Coffee_irc> they make moving objects like furniture much easier 20140523 22:28:06 * Coffee_irc asks not to be hit if mentioning an easy way to do this after you spent hours hauling stuff by hand :P 20140523 22:28:13< Aishiko> sack-truck? ohhh a dolly or a hand-truck, we had one but we'd still have to have lifted it into my little toy truck, she is looking at doing a 1 day uhaul for the remainer 20140523 22:29:33< Aishiko> we did mostly boxes today, stuff that one person could lift, leaving the bigger pieces for another day 20140523 22:31:55< Coffee_irc> you might want to check that "friend with a truck" shows up before committing to more work :P 20140523 22:33:12< Aishiko> thankfully I have a small/light truck so we got a good 3 or 4 trips leaving only 2 or 3 for the next day with a truck with a ramp for the bigger furniture pieces! 20140523 22:34:41< Aishiko> void unit_animation::fill_initial_animations is a good one too, it builds the vectors used for the animations used later! 20140523 22:34:53< Coffee_irc> well if it were me I would make sure I would at least get free beer for the effort beforehand :) 20140523 22:35:47< Coffee_irc> Aishiko: what I would suggest is to add in unit_animation::add_anims a "new type" of test animation maybe called [spritesheet] and work back 20140523 22:35:51< Aishiko> lol I can't stand beer! but, I was compenesated for my time and effor 20140523 22:37:03< Aishiko> Coffee_irc, I was thinking along the same lines, and I was thinking of using a vector to hold all of them and have the sprites start the numbering at 0 and have one vector for each unit 20140523 22:37:53< Coffee_irc> Aishiko: I suggest that you try to put objects in a test type of animation and just print them out on the command line as a start 20140523 22:38:44< Coffee_irc> Aishiko: standing_animation is at the same level in the unit WML files as what you want in the end I think anyway with the spritesheet 20140523 22:41:29-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving] 20140523 22:41:54< Aishiko> Coffee_irc, right I was thinking in the end, but small steps to get there, I understand that 20140523 22:42:40< Coffee_irc> Aishiko: do you have your own branch for your work? 20140523 22:43:44< Aishiko> yes, I'm working on a test branch before pushing to the spritesheet branch 20140523 22:45:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20140523 22:45:15< Coffee_irc> Aishiko: as we are still early in 1.13 I might suggest (once you get a bit further) to push your work that extends the current code until it starts to change the way the current code works 20140523 22:45:33< Coffee_irc> Aishiko: and then work from a separate branch before merging 20140523 22:45:37< happygrue> Aishiko: You haven't pushed anything there yet, right? Perhaps we should sync the spritesheet branch one last time with master to be as close as possible when things get merged back at the end? Maybe it doesn't matter, I don't know if that will impact the ease of the eventual merge 20140523 22:45:53-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Ping timeout: 264 seconds] 20140523 22:46:26< Aishiko> I was planning on doing perodic what is it called "rebase"? to keep it as synced to the master as possible 20140523 22:47:15< happygrue> I asked mordante about that, but he suggested it would be best to stay seperate from master, since the SDL stuff would be going directly there 20140523 22:47:29-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev 20140523 22:47:31< Aishiko> and no I have not yet 20140523 22:47:38< Aishiko> ohhh so I should do that now 20140523 22:47:43< happygrue> I think the idea is that stuff in master might be breaking your stuff while it's in development, but it should straigten itself out by the end 20140523 22:48:00-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev 20140523 22:48:36< happygrue> it's probably not old enough to matter, he suggested it (hopefully!) won't be too hard to merge, he just didn't want the spritesheet and the SDL breaking each other as stuff gets commited before it's all ready, if I understand right 20140523 22:49:10< happygrue> but if no SDL stuff has been added yet it wouldn't hurt to sync up now either 20140523 22:49:17< Aishiko> ahhh, that makes sense, the spritesheets shouldn't because the main functions used in SDL are the same in SDL1.2 and SDL2.0 20140523 22:50:29< Coffee_irc> happygrue/Aisiko: AFAICT the WML loading and image loading are separated in the C++ code 20140523 22:50:44< happygrue> I don't really understand it, but he (mordante) thought it would be best not to pull or merge into master from the spritesheet branch until the end. 20140523 22:51:02< Aishiko> the main ones being SDL_Rect and SDL_Surface, but having them isolated makes it easier to track who broke what 20140523 22:51:23< iceiceice> i mean SDL stuff could also go on a branch? 20140523 22:51:30< Coffee_irc> logically the WML loading and image drawing parts are separate and quite modular 20140523 22:51:43< iceiceice> idk i wont get involved :) 20140523 22:51:50< Aishiko> it also means that if they break something and it doesn't compile for a week the spritesheet branch shouldn't have any issue compiling 20140523 22:52:17< happygrue> yes, that too. I think basically he wanted to avoid a situation where either one of you was slowing the other down if something stopped working :D 20140523 22:52:42< iceiceice> hmm well if someone has a long term work branch, we can probably set travis up to build it also if desired, hopefully to minimize breakage 20140523 22:53:09< happygrue> That would be nice I think. 20140523 22:53:19< Aishiko> Coffee_irc, as I read it, the unit_anim looks at the config file after its loaded, and builds a vector for each type of animation and then when its called the vector for that animation is gone through with the proper timing 20140523 22:53:34< iceiceice> i guess travis doesnt really check much image path stuff right now but it cant hurt anyways 20140523 22:53:41< Coffee_irc> Aishiko: you got it :) 20140523 22:54:22< happygrue> I guess it's not too important as we will be building it from time to time anyway, but it wouldn't hurt to have travis double checking too. :D 20140523 22:54:34< Coffee_irc> Aishiko: except the vector also builds another vector to add overlays, change the unit offset, etc. 20140523 22:55:07< Coffee_irc> Aishiko: hence, you will see 2 of the same type of things in unit_frame and such 20140523 22:55:18< Aishiko> and what I want to do, is create spritesheet vector (in the end) that has all the SDL_Rects in it, or to parse it out and basically use the spritesheet to build the vectors that are currently built with single images 20140523 22:56:16< Aishiko> which do you think would be the better way to go about it? 20140523 22:56:43< Coffee_irc> Aishiko: I would use the same flow as what happens now and same functions where drawing is occurring 20140523 22:57:09< Coffee_irc> this would minimize the work needed and I think minimize bugs 20140523 22:57:51< Aishiko> I have to agree. 20140523 22:58:14< Coffee_irc> that is, load the WML from the same functions where the current WML is loaded (unit_animation.cpp) and display in the 3 drawing routines 20140523 22:58:32< Coffee_irc> why 3 drawing routines you ask :P 20140523 22:59:20< Coffee_irc> well, in unit.cpp there is unit::redraw_unit 20140523 22:59:22< Aishiko> background, unit, foreground 20140523 22:59:37< Coffee_irc> Aishiko: sort of 20140523 23:00:07< Coffee_irc> the redraw_unit if you commend out anim_redraw(params) at the end of redraw_unit you will get a blank unit 20140523 23:00:20< Aishiko> and then we have image.cpp which has some unit image stuff if I recall right, and for sure has all the caches for the images 20140523 23:00:26< Coffee_irc> this function adds height offsets for terrain and overlays 20140523 23:00:49< Coffee_irc> in unit_animation.cpp and unit_frame.cpp there are 2 redraw functions 20140523 23:01:08< Coffee_irc> one is for the frame (general) and the other the unit in question 20140523 23:01:19< Coffee_irc> I believe this is for caching purposes 20140523 23:01:37< Coffee_irc> but really this split also takes into account timing 20140523 23:03:36< Aishiko> the vectors do they currently have the image-path/filename or are they the actual in use images as modified? 20140523 23:05:13< Coffee_irc> Aishiko: see unit_animation::add_anims in unit_animation.cpp 20140523 23:06:05< Coffee_irc> the filenames get injected into the vectors there as full file paths 20140523 23:06:42< Coffee_irc> relative to the core directories of course 20140523 23:07:18< Coffee_irc> so /data/core/images/units/_unit_/image.jpg for each image that is used 20140523 23:09:12< Coffee_irc> Aishiko: it is worth printing out the values of the variables in unit_frame::redraw in unit_frame.cpp 20140523 23:09:15< Aishiko> of course, so if we keep the same configuration we'd have that (for the base file) and just add an SDL_Rect, and adding it with a default of SDL_Rect=full surface might be a good way to go about it 20140523 23:10:05< Coffee_irc> Aishiko: there are several ways you could approach this 20140523 23:10:37< Coffee_irc> Aishiko: but I suspect if you can get the WML to load into a vector along side the current information it should make sense then 20140523 23:10:53< Aishiko> I'm just thinking out loud as it were, trying to think through it and get feedback 20140523 23:12:25< Coffee_irc> Aishiko: if spritesheets need a separate loading mechanism you can always pass a "spritesheet=true" boolean across the C++ code 20140523 23:13:38< Coffee_irc> Aishiko: are you planning on making everything a logical spritesheet? 20140523 23:13:51< Aishiko> ideally, after loading the sheet, the parts could be taken out and passed through as if they were a single image in a single file 20140523 23:13:56-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20140523 23:14:24< Coffee_irc> Aishiko: yes, you could do that or convert single images in the code to spritesheets 20140523 23:14:26< Aishiko> Coffee_irc, that is one idea I had 20140523 23:14:55< Coffee_irc> I think this should be more obvious once you print out the correct information passed through WML and get it to appear in the appropriate parts of the code 20140523 23:15:07< Coffee_irc> that's what I would do anyway 20140523 23:15:45< Aishiko> convert single images to spritesheets? 20140523 23:15:59< Coffee_irc> Aishiko: just before processing for output on the screen 20140523 23:16:12< Coffee_irc> or in the loading part 20140523 23:18:09< Coffee_irc> I figure the easiest solution would come out if you passed the WML information in the form you want and got it to print out in the various C++ functions 20140523 23:19:40< Aishiko> I often find that is a good way to verify that a function is doing what I want it to do in the early stages 20140523 23:21:43< Aishiko> and It helps when you break things too 20140523 23:21:50< Coffee_irc> :) 20140523 23:22:53-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev 20140523 23:23:09< Aishiko> I should know I break things..... alot 20140523 23:23:42< Coffee_irc> that's the best way to learn 20140523 23:26:14< Coffee_irc> looks like 1.11.15 is being released today :) 20140523 23:26:27< Aishiko> but it really helps when the code gives you decent errors about what went wrong 20140523 23:26:29< Coffee_irc> or tomorrow depending on your timezone 20140523 23:26:51< Coffee_irc> Aishiko: have a look at all the debug functions 20140523 23:27:47< Coffee_irc> Aishiko: some of the objects such as unit animations can be passed to std::cout 20140523 23:27:55< Aishiko> I was more or less thinking of my php class this past semester and the fact that it often gave me no error information or it would fail on my end but worked perfectly fine for my professor 20140523 23:28:00< Coffee_irc> and others have ".debug_info" functions 20140523 23:28:34< Coffee_irc> Aishiko: this happens a lot in the real world :P 20140523 23:29:01< Coffee_irc> Aishiko: this is why you never upgrade a production server without testing on a clone server first if it always needs to be up and running 20140523 23:29:34< Aishiko> and that goes double if your dealing with the doze! 20140523 23:30:18< Aishiko> I recall reading about a company that applied an M$ patch that borked their whole install and did it production wide without testing it first 20140523 23:30:37< Coffee_irc> Aishiko: yes, this happens also :P 20140523 23:30:54< Coffee_irc> Aishiko: unix servers are more commonly used for websites that need high uptime 20140523 23:32:05< Coffee_irc> a lot of them are virtualised on server farms with full restore backups 20140523 23:32:05< Aishiko> yeah, I deal with doze fanbois at school a lot 20140523 23:32:37< Coffee_irc> you should always be able to restore your production server to an earlier state in full 20140523 23:32:38< Aishiko> they don't like that *nix is the server of choice for a good chunk of the internet 20140523 23:32:52< Aishiko> I totally agree with you on that! 20140523 23:34:56< Coffee_irc> Aishiko: it does depend on your industry though 20140523 23:35:14< Coffee_irc> I know the chemists seem to like Windows servers for some reason 20140523 23:35:26< Coffee_irc> but the physicists only use unix boxes 20140523 23:35:40< Coffee_irc> for high end computer simulation software 20140523 23:36:18< Aishiko> true and when I was a writer and editor at a paper Macs were the platform of choice 20140523 23:36:31-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral] 20140523 23:36:46< Coffee_irc> I work with artists now and they like Macs as well 20140523 23:37:57< Aishiko> it was mostly because the software for the layout of the paper ran better on a mac then on doze and *nix was considered too hard to teach new people to use 20140523 23:37:59< Coffee_irc> but I think this is for purely asthetic reasons and not actually getting stuff done :P 20140523 23:38:10-!- gfgtdf [~chatzilla@e177125066.adsl.alicedsl.de] has joined #wesnoth-dev 20140523 23:38:49< gfgtdf> iceiceice: :/ was there a reason against the changes i made earlier? 20140522 19:32:21< gfgtdf_> iceiceice_: updatd version: http://pastebin.com/60BKh34Z 20140523 23:39:09< iceiceice> i think i just missed it 20140523 23:39:56< iceiceice> ok i will incorporate it 20140523 23:40:04< iceiceice> i have added some additional stuff, 20140523 23:40:25< iceiceice> i got the lexical cast syntax to work, and i gave it an ostream & operator << implementation as well 20140523 23:41:26< gfgtdf> iceiceice: so we use teh defautl lexical_cast whixch uses the << operator ? 20140523 23:41:39< iceiceice> y 20140523 23:41:42-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game] 20140523 23:42:11< iceiceice> lexical_cast (class::enumname) just calls class::enumname_to_string 20140523 23:42:34< iceiceice> i will push updates to my fork... 20140523 23:42:41< gfgtdf> iceiceice: do we need that specialisationw hen we have teh << operator ? 20140523 23:42:42< iceiceice> had to recompile though 20140523 23:43:03< iceiceice> there are somet imes you might want it i geuss, 20140523 23:43:06< iceiceice> like in an initialization list 20140523 23:43:16-!- irker719 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20140523 23:43:20< iceiceice> because you can just do lexical_cast (identifier) 20140523 23:44:03< gfgtdf> iceiceice: no i meant teh default lexical_cast tempalte which calls the << operatore will worke then too if we have teh << operator ? 20140523 23:44:12< iceiceice> oh hmm is that true? 20140523 23:44:19< gfgtdf> iceiceice: i didnt test 20140523 23:44:33< iceiceice> ok i can try 20140523 23:45:26< iceiceice> hmm so how come you made it named "string_to_enumname_default" 20140523 23:45:27< iceiceice> instead of just overload? 20140523 23:46:02< iceiceice> (fork is now updated, but i didnt put your changes in yet) 20140523 23:46:22< gfgtdf> hmm just becasse we also ahve it on lexical_cast and lexicl_cast default, i didnt reaayl think about it nd teh isnt the mot important change 20140523 23:46:38< gfgtdf> feel free to leave out the '_default' 20140523 23:46:43< gfgtdf> iceiceice: ^ 20140523 23:48:15< iceiceice> oh i ddint realize thats our syntax 20140523 23:48:23< iceiceice> y i guess it should be the same 20140523 23:48:59< gfgtdf> iceiceice: is there a reason why that commit also changes 'terrain_builder.cpp' in the sceons procetfile ? it seems to me like that is unrlated 20140523 23:49:16< iceiceice> it just sorts it 20140523 23:49:24< iceiceice> i put it in with the t entries 20140523 23:49:36< iceiceice> its basicalyl fixing up from the last time i change things in the project file... 20140523 23:49:42< iceiceice> that one used to be "builder.cpp" but i renamed it 20140523 23:49:48< iceiceice> and didnt resort last time 20140523 23:50:17< iceiceice> idk if you see that i messed up a project file letme know, i tried not to 20140523 23:51:13< iceiceice> gfgtdf: i also named it MAKE_ENUM instead of MAKEENUM, 20140523 23:51:18< iceiceice> its easier for me to read... 20140523 23:51:28< iceiceice> i will leave the helper macros as MAKEENUM though iguess 20140523 23:52:06-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev 20140523 23:58:24< iceiceice> gfgtdf: i dont know if i'm templating properly to get this: https://github.com/wesnoth/wesnoth/blob/master/src/util.hpp#L174 20140523 23:58:41< iceiceice> err that wasnt what i emant 20140523 23:59:10< iceiceice> hmm i dont see that theres anywhere that we overload ostream << using wesnoth lexical cast --- Log closed Sat May 24 00:00:17 2014