--- Log opened Sat May 24 00:00:17 2014
--- Day changed Sat May 24 2014
20140524 00:00:17< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/blob/master/src/util.hpp#L94
20140524 00:01:21< iceiceice> ok so there we define lexical cast using ostream
20140524 00:01:26< iceiceice> but it would also be nice if you could do something like
20140524 00:01:39< iceiceice> std::cout << (team) t.controller << std::endl
20140524 00:01:51< iceiceice> and have it give you the string value of the enum, rather than the meaningless number
20140524 00:02:05< gfgtdf> iceiceice: and whats teh problems with that ?
20140524 00:02:15< iceiceice> none its just you have to define it
20140524 00:02:36< gfgtdf> 	iceiceice: ye you have to defien the operator <<
20140524 00:02:38< iceiceice> y i did
20140524 00:02:49< gfgtdf> iceiceice: and teh code abotu still doesnt work ?
20140524 00:02:51< gfgtdf> above
20140524 00:02:54< iceiceice> no it works
20140524 00:03:05-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140524 00:03:07< gfgtdf> iceiceice: so whats teh prbolem ?
20140524 00:03:21< gfgtdf> iceiceice: did you also overlaod operator >> ?
20140524 00:03:37< iceiceice> i think i just misunderstood something you said earlier
20140524 00:03:41-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 00:03:44< iceiceice> no i didnt overload >>
20140524 00:03:50< iceiceice> do you think i should?
20140524 00:04:06< iceiceice> i dont like that syntax as much i think
20140524 00:04:34< iceiceice> gfgtdf: is this correct adaptation?
20140524 00:04:34< iceiceice> #define MAKE_ENUM_IN_CLASS(NAME, CONTENT) \
20140524 00:04:34< iceiceice> MAKEENUMTYPE(NAME, CONTENT) \
20140524 00:04:34< iceiceice> MAKEENUMCAST(NAME, static , CONTENT) 
20140524 00:04:34< iceiceice> #define MAKE_ENUM_IN_NAMESPACE(NAME, CONTENT) \
20140524 00:04:34< iceiceice> MAKEENUMTYPE(NAME, CONTENT) \
20140524 00:04:34< iceiceice> MAKEENUMCAST(NAME,  , CONTENT) 
20140524 00:05:01< gfgtdf> iceiceice: is teh any reayson why it shoudl onyl work in class ?
20140524 00:05:16< iceiceice> i think static will not behave as intended?
20140524 00:05:42< gfgtdf> iceiceice: hm i think static will work in clases and outside
20140524 00:06:06< iceiceice> y but it will do this filescope vs global scope thing, right/
20140524 00:06:15< iceiceice> or am i wrong about this
20140524 00:06:35< gfgtdf> iceiceice: hm i think filescope is what we want becasue we put teh definition in teh header and otherwide we migth get a double definition error
20140524 00:06:50< gfgtdf> iceiceice: durign linking
20140524 00:07:13< iceiceice> i think it would mean that like
20140524 00:07:23< iceiceice> oh hmm
20140524 00:08:15< gfgtdf> iceiceice: think of #include as a raw 'put that file here'
20140524 00:08:38< iceiceice> y you are right
20140524 00:08:41-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140524 00:08:47< iceiceice> it would be fine in a header
20140524 00:09:08< iceiceice> ok :) well that improves things significantly
20140524 00:11:42< iceiceice> hmm so in new version the names are quoted strings?
20140524 00:12:26< gfgtdf> iceiceice: hm ye i liked that more, since it are strings we shodul jsut pass string to teh marco
20140524 00:12:34< iceiceice> y its much better imo
20140524 00:14:23-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20140524 00:14:27-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20140524 00:14:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140524 00:14:34< iceiceice> hmm this is a bit odd: http://pastebin.com/CviyzBbc
20140524 00:16:10< iceiceice> i guess i have to amke it virtual 
20140524 00:16:23< iceiceice> hmmm
20140524 00:18:46< gfgtdf> iceiceice: m cimpller didnt complain, maybe make it a struct instead of class ?
20140524 00:18:55< iceiceice> ok
20140524 00:19:36< gfgtdf> iceiceice: no i think struct bad_lexical_cast : std::exception lacks the public
20140524 00:20:16< iceiceice> y that did it
20140524 00:20:21< iceiceice> i also added const throw()
20140524 00:20:25< iceiceice> to your what()
20140524 00:20:44< iceiceice> hmm no its still broken...
20140524 00:20:47< iceiceice> just took longer :(
20140524 00:21:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140524 00:22:13-!- trewe [~trewe@177.53.54.77.rev.vodafone.pt] has quit [Quit: quit]
20140524 00:22:28< iceiceice> i think it doesnt like that it has a private std::string
20140524 00:22:50< iceiceice> http://stackoverflow.com/questions/11837149/over-riding-error-lax-c-language-spec-violation-maybe
20140524 00:24:52< gfgtdf> iceiceice: hmm maybe you need an explicit destructor
20140524 00:25:12< gfgtdf> iceiceice:  like 	~bad_enum_cast() throw() {}
20140524 00:25:19< iceiceice> y
20140524 00:25:25< iceiceice> ok that did it :)
20140524 00:33:21< iceiceice> hmm so its taking a while to compile still because i also refactored team::DEFEAT_CONDITION to use the macro stuff
20140524 00:33:46< iceiceice> because then the wml unit test for that can help to catch bugs
20140524 00:34:43< gfgtdf> iceiceice: my curretn workign version looks liek this: http://pastebin.com/hNu2TThU
20140524 00:36:07< iceiceice> oh i also changed util.hpp
20140524 00:36:13< iceiceice> so it was public std::exception 
20140524 00:36:14< iceiceice> :/
20140524 00:36:26< iceiceice> i guess thats the other reason
20140524 00:36:59< gfgtdf> iceiceice: did you see my versioj above ?
20140524 00:37:25< iceiceice> wait so what changed?
20140524 00:37:25< iceiceice> you added >> ?
20140524 00:37:58< gfgtdf> iceiceice: the MAKE_ENUM_STREAMOP
20140524 00:38:11< iceiceice> i already have something like that
20140524 00:38:12< gfgtdf> iceiceice: which enables lexical_cast
20140524 00:38:37< iceiceice> oh
20140524 00:38:40< iceiceice> i guess thats a bit cleaner
20140524 00:39:44-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 00:40:01< iceiceice> hmm so the thing i'm not sure about
20140524 00:40:12< iceiceice> if you want to use the << and >> operators to define lexical cast,
20140524 00:40:12< iceiceice> what will throw bad lexical cast?
20140524 00:40:21< iceiceice> because our lexical cast implementation doesnt catch exceptions?
20140524 00:41:05< iceiceice> you will have ostream throw bad lexical cast?
20140524 00:41:12< iceiceice> or we will set ostream to "bad" or something?
20140524 00:41:24< gfgtdf> iceiceice: well operator >> might thow bad_lexical_cast which this nto optimila, but since lexicakl_cast can thwor that anyway it doesnt matter for that.
20140524 00:41:47< gfgtdf> not optimal.
20140524 00:42:01< iceiceice> y its kind of unexpected
20140524 00:42:55< iceiceice> b/c if someone just uses >> they will get exceptions they might not expect
20140524 00:43:04< iceiceice> and it will be hidden deep in a macro
20140524 00:44:02< gfgtdf> iceiceice: hmm ye we might use somethign liek steewam.mark_this_stream_as_bad but i dotn know very much about std streams so i didnt do that yet
20140524 00:44:29-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140524 00:45:48< iceiceice> i think its this:
20140524 00:45:48< iceiceice> http://www.cplusplus.com/reference/ios/ios/setstate/
20140524 00:45:50-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140524 00:45:54< iceiceice> either badbit or failbit...
20140524 00:47:34< iceiceice> ok heres the version that just compiled and passed all the tests: https://github.com/cbeck88/wesnoth/compare/makeenum
20140524 00:49:09< iceiceice> ok look slike change to util.hpp was unnecessary ...
20140524 00:49:27-!- spoffy [~spoffy@152.78.175.8] has quit [Ping timeout: 245 seconds]
20140524 00:50:12< gfgtdf> iceiceice: hmm i still think teh public there is better to have it even if it comples without
20140524 00:50:29< iceiceice> really?
20140524 00:50:35< iceiceice> even though its a struct?
20140524 00:51:19< iceiceice> ok
20140524 00:51:38-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 00:52:13< gfgtdf> hmm: ok i jst saw "a struct has public inheritance by default"
20140524 00:52:16< gfgtdf> iceiceice: ^
20140524 00:52:21< gfgtdf> iceiceice: so it shouldnt matter
20140524 00:52:58< iceiceice> lol crap
20140524 00:53:06< iceiceice> ok i'll restrat compiling ...
20140524 00:53:41< gfgtdf> iceiceice: i personyl like the explicit verion more becasuw you dont have to think about which is the default, but in exceptions.hpp we also leave out the 'public'
20140524 00:54:07< iceiceice> ok i thik i will just leave it with public,
20140524 00:54:14< iceiceice> maybe bad_lexical_cast will be a class someday anyways
20140524 00:55:02-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 00:55:30< iceiceice> hmm so one thing i wasnt sure,
20140524 00:55:39< iceiceice> i wasnt sure why i needed to have a "make steam ops" and "declare stream ops"
20140524 00:55:43< iceiceice> but i seemed to get linked problems when i ddint do that
20140524 00:56:15< gfgtdf> 	iceiceice	: maybe becasue your strream ops didnt have static ?
20140524 00:56:41-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140524 00:59:03< iceiceice> hmm y
20140524 00:59:06< iceiceice> i gues that could do it
20140524 00:59:53-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 265 seconds]
20140524 01:08:40-!- sachith500 [~kvirc@112.134.132.179] has joined #wesnoth-dev
20140524 01:08:48< iceiceice> hmm
20140524 01:08:59< iceiceice> so heres hte version i want to use:
20140524 01:09:25< iceiceice> http://pastebin.com/xA7PYDNj
20140524 01:09:36< iceiceice> i think we dont need bad_enum_cast to derive from bad_lexical_cast
20140524 01:09:56< iceiceice> because as long as we correctly signal failure to ostream, we will get a bad_lexical_cast the usual way
20140524 01:10:20< gfgtdf> iceiceice: why did you use CL isntead of namepsace and without teh  :: ?
20140524 01:11:02< iceiceice> idk is that useful?
20140524 01:11:20< gfgtdf> 	iceiceice: well it might have a different effect if NAMEPACE/CL is empty 
20140524 01:11:24< iceiceice> ok
20140524 01:11:27< iceiceice> thats a good point
20140524 01:12:00< gfgtdf> iceiceice: i think :: referes to teh global namespace? (not sure)  while wothut it is teh current namespace
20140524 01:12:04< gfgtdf> the*
20140524 01:12:41< iceiceice> i think the CL version is a bit friendlier,
20140524 01:12:45< iceiceice> i go to team class and write
20140524 01:12:54< iceiceice> make_enum( blah , ... )
20140524 01:13:33< iceiceice> then at the bottom,
20140524 01:13:33< iceiceice> make_enum_stream_ops ( team, blah )
20140524 01:13:33< iceiceice> if i have to write team:: its just odd
20140524 01:13:33< iceiceice> because that would normally be a syntax error
20140524 01:13:34< iceiceice> it doesnt matter though...
20140524 01:13:44< iceiceice> you shouldnt define these in global space anyways...
20140524 01:13:56< iceiceice> but maybe if you are in an anonymous namespace or smth there is a use case, idk
20140524 01:15:49< gfgtdf> iceiceice: http://pastebin.com/rgSEWH4v
20140524 01:16:31< iceiceice> gfgtdf:
20140524 01:16:43< gfgtdf> one have to write MAKE_ENUM_STREAMOP(dd, enumname) which is not what i like.
20140524 01:16:59< iceiceice> in my version fo the code you are suppseod to declare the stream ops out side of the namespace...
20140524 01:17:08< iceiceice> otherwise will lexical cast be able to see them?
20140524 01:17:41< gfgtdf> iceiceice: hm i tested and yes
20140524 01:17:52< iceiceice> hmm ok i didnt expect that
20140524 01:18:01< iceiceice> i wonder why that is?
20140524 01:18:40< gfgtdf> hm well the problme is that you cannot define such an oprtato for another class inside a class not that its no visible
20140524 01:19:01< gfgtdf> so one can use it in a nemaspece but not inside a class
20140524 01:19:47< gfgtdf> iceiceice: so MAKE_ENUM_STREAMOP inside a class just wont compile.
20140524 01:19:59< iceiceice> y so my version is how it should be
20140524 01:20:06< iceiceice> outside of class
20140524 01:20:25< iceiceice> i guess i didnt realize it can be in the namespace, thats wierd
20140524 01:21:00-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140524 01:21:13< iceiceice> is it some special rule for operators?
20140524 01:21:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140524 01:22:57< iceiceice> i guess i dont believe that this would work in standard C++
20140524 01:22:58< iceiceice> http://pastebin.com/rgSEWH4v
20140524 01:23:09< iceiceice> if you define the straem ops in the name space, then outside the namespace they dont exist
20140524 01:23:12< iceiceice> therefore lexical cast will fail
20140524 01:23:31< iceiceice> maybe its compiler specific?
20140524 01:23:53< gfgtdf> hm it ditn compile for you ? :o 
20140524 01:24:05-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds]
20140524 01:24:16< iceiceice> i havent tried
20140524 01:24:18-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has quit [Ping timeout: 240 seconds]
20140524 01:24:19< gfgtdf> iceiceice: http://stackoverflow.com/questions/171862/namespaces-and-operator-overloading-in-c
20140524 01:24:55< gfgtdf> iceiceice: they will be seen even inside tha namespace
20140524 01:25:26< iceiceice> ok
20140524 01:25:35< iceiceice> i didnt know about this :X
20140524 01:27:12< iceiceice> ok so what do you want to do?
20140524 01:28:28< gfgtdf> iceiceice: hm i prefer my verion where you have to type the :: in the macro using just because of this.
20140524 01:28:41< iceiceice> ok
20140524 01:28:42< iceiceice> i have switched to that
20140524 01:29:44< iceiceice> so its cl::enumname
20140524 01:29:45< iceiceice> for a class
20140524 01:29:50< iceiceice> sorry
20140524 01:29:58< iceiceice> make_enum_stream_ops(dd::, enumname)
20140524 01:30:01< iceiceice> is the correct syntax?
20140524 01:30:22< gfgtdf> when dd is a class yes.
20140524 01:31:20< gfgtdf> iceiceice: ^
20140524 01:31:39< iceiceice> and when its inside the name space, its also dd?
20140524 01:31:40< iceiceice> or just ::
20140524 01:32:44< gfgtdf> no then just MAKE_ENUM_STREAM_OPS(, enumname) and empty argument
20140524 01:32:47< gfgtdf> an
20140524 01:32:56< gfgtdf> for "current naemapce"
20140524 01:33:22< gfgtdf> or default/implicit namespace  whatever it is called
20140524 01:33:33< iceiceice> ok
20140524 01:33:37< gfgtdf> iceiceice: just liek one woudl do oustide an namespace
20140524 01:33:54< iceiceice> even outside the namespace it is (, enumname) ?
20140524 01:34:01< iceiceice> or then it is (dd::, enumname) liek the class
20140524 01:34:16< iceiceice> because of this ADL thing you pointed out?
20140524 01:34:30< iceiceice> ok i think i understand
20140524 01:35:02< gfgtdf> 	iceiceice: no you use MAKE_ENUM_STREAM_OPS inside the nanemspace just after teh MAKE_ENUM
20140524 01:35:23< gfgtdf> iceiceice: ondie one woudl have to use dd:: but its better to keep things together i think
20140524 01:35:26< gfgtdf> outside
20140524 01:36:00-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140524 01:37:01-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 258 seconds]
20140524 01:39:07-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 252 seconds]
20140524 01:41:32< gfgtdf> i'll then be offline too
20140524 01:41:34-!- gfgtdf [~chatzilla@e177125066.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140524 01:43:32-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140524 01:45:54< iceiceice> gfgtdf: i disconnected :(
20140524 01:46:12< iceiceice> i think that msvc preprocessor implementation may not be the same as others
20140524 01:47:48-!- thejason [~tehjason@71-85-248-239.dhcp.stls.mo.charter.com] has joined #wesnoth-dev
20140524 01:49:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140524 02:04:30< iceiceice> gfgtdf: i'm having problems with the non-CL syntax,
20140524 02:04:44< iceiceice> i have decided to split up all my commits and try to just run tests, i'm not sure what the issue is,
20140524 02:09:09-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140524 02:10:34-!- prophile [~alynn@oftn/member/prophile] has quit [Read error: Connection reset by peer]
20140524 02:13:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140524 02:15:04-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20140524 02:17:19-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140524 02:27:40-!- Grickit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140524 02:28:29-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 264 seconds]
20140524 02:32:12-!- Ivanovic_ [~ivanovic@frnk-d9330f09.pool.mediaWays.net] has joined #wesnoth-dev
20140524 02:35:35-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds]
20140524 02:36:07-!- Ivanovic_ is now known as Ivanovic
20140524 02:42:53-!- Ivanovic [~ivanovic@frnk-d9330f09.pool.mediaWays.net] has quit [Changing host]
20140524 02:42:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140524 02:43:20-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140524 02:54:16-!- sachith500 [~kvirc@112.134.132.179] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140524 03:01:41-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 265 seconds]
20140524 03:54:19-!- sachith500 [~kvirc@112.134.132.179] has joined #wesnoth-dev
20140524 04:34:10-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140524 04:34:45-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has quit [Ping timeout: 252 seconds]
20140524 04:35:36-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has joined #wesnoth-dev
20140524 04:44:59-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140524 04:49:01-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140524 05:02:37-!- thejason [~tehjason@71-85-248-239.dhcp.stls.mo.charter.com] has quit [Read error: Connection reset by peer]
20140524 05:03:32-!- thejason [~tehjason@71-85-248-239.dhcp.stls.mo.charter.com] has joined #wesnoth-dev
20140524 05:11:26-!- sachith500|2 [~kvirc@112.134.201.23] has joined #wesnoth-dev
20140524 05:14:05-!- sachith500 [~kvirc@112.134.132.179] has quit [Ping timeout: 252 seconds]
20140524 05:30:19-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20140524 05:41:52-!- thejason [~tehjason@71-85-248-239.dhcp.stls.mo.charter.com] has quit [Quit: Leaving]
20140524 05:50:34-!- Grickit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140524 05:51:26-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Ping timeout: 276 seconds]
20140524 05:52:15-!- Necrosporus_ is now known as Necrosporus
20140524 05:52:39-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140524 06:22:04-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Remote host closed the connection]
20140524 06:22:09-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140524 06:40:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140524 06:50:28-!- Sulfur [~Miranda@p5B0081BE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140524 06:58:35-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140524 07:01:59-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140524 07:06:52-!- Guest36501 [~cib@p5DD216FB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140524 07:16:19-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140524 07:18:22-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140524 07:19:39-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140524 07:30:37-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140524 07:41:44-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has joined #wesnoth-dev
20140524 07:53:34-!- john3213 [john3213@static-72-66-66-50.washdc.fios.verizon.net] has joined #wesnoth-dev
20140524 07:58:36-!- john3213 [john3213@static-72-66-66-50.washdc.fios.verizon.net] has left #wesnoth-dev []
20140524 08:09:13< aquileia> loonycyborg: Do you know by coincidence whether wesnoth.exe will set %ERRORLEVEL% like it does with $?
20140524 08:09:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140524 08:10:00< aquileia> that is - does it set the return value?
20140524 08:37:37-!- mjs-de [~mjs-de@f048032164.adsl.alicedsl.de] has joined #wesnoth-dev
20140524 09:08:51-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140524 09:09:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20140524 09:10:37< Necrosporus> Palms are replaced with new tropical forest. If I want palms from 1.10 back, do I need to introduce new terrain type and copy sprites from 1.10 dir?
20140524 09:37:37-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140524 09:40:03-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 09:51:05-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 252 seconds]
20140524 09:51:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140524 09:51:57-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140524 09:52:42< Necrosporus> Is there a collection of abandoned mainline portraits and sprites?
20140524 09:53:03< Necrosporus> If mainline stopped using certain portrait, umc still can
20140524 09:53:49< Necrosporus> I know they must be in git/svn, but it's quite a work to find them
20140524 09:55:39-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Read error: Connection reset by peer]
20140524 09:55:47-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140524 09:59:19< aquileia> Two hours later: http://pastebin.com/QHKZu6HQ
20140524 10:00:38< aquileia> Oh, and now that I look into my stderr: Error in command line: unrecognised option '--log-strict=warning'
20140524 10:01:36< aquileia> can anyone tell me why it doesn't exist on a Windows build but on travis'?
20140524 10:09:35< loonycyborg> aquileia: I think #ERRORLEVEL% is the same thing as return value
20140524 10:09:40< loonycyborg> so it should be the same
20140524 10:10:26< aquileia> loonycyborg: By now I found the issue - see above
20140524 10:10:35< aquileia> now I wonder: why?
20140524 10:10:42< loonycyborg> our command line is cross-platform
20140524 10:11:17< loonycyborg> available options can depend on version though
20140524 10:11:26< aquileia> it should be... but it isn't, it seems
20140524 10:11:33< loonycyborg> --log-strict doesn't seem familiar
20140524 10:11:48< aquileia> I'm on a 1.13 build
20140524 10:12:27< loonycyborg> I mostly ever use --log-debug=<whatever> etc
20140524 10:13:07-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: Vannak idők, mikor menni kell]
20140524 10:13:49< aquileia> I copied the --log-strict from travis' post-build script
20140524 10:15:20-!- Guest36501 [~cib@p5DD216FB.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20140524 10:17:06-!- sachith500|2 [~kvirc@112.134.201.23] has quit [Read error: Connection reset by peer]
20140524 10:18:21< aquileia> and the really unusual thing is... if I put it into a script, ERRORLEVEL will always return 0
20140524 10:18:33< aquileia> the latter is a cmd bug, though
20140524 10:27:51-!- Guest36501 [~cib@p508BC650.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140524 10:40:23-!- sachith500 [~kvirc@112.135.151.102] has joined #wesnoth-dev
20140524 10:43:06-!- Sulfur [~Miranda@p5B0081BE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140524 10:43:17< aquileia> loonycyborg: You were right... it was added last week and my checkout was older
20140524 10:43:26< aquileia> thanks for your help
20140524 10:43:36< loonycyborg> yw :P
20140524 10:47:57< aquileia> I gave break_replay_with_lua_random 5 minutes and it still timed out on my PC... damn, travis is fast to do it in 10s
20140524 10:53:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140524 11:22:40-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140524 11:23:18-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 11:27:53-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140524 11:35:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140524 11:38:21-!- Sulfur [~Miranda@p5B0081BE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140524 12:17:07-!- Octalot [~noct@132.53.125.91.dyn.plus.net] has joined #wesnoth-dev
20140524 12:32:38-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 12:37:41-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds]
20140524 12:37:53-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140524 12:44:14-!- mjs-de [~mjs-de@f048032164.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140524 12:56:40-!- mjs-de [~mjs-de@f053055092.adsl.alicedsl.de] has joined #wesnoth-dev
20140524 13:06:30-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140524 13:09:15-!- knotwork_ [~markm@142.68.141.247] has joined #wesnoth-dev
20140524 13:09:27-!- knotwork_ [~markm@142.68.141.247] has quit [Changing host]
20140524 13:09:27-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20140524 13:12:29-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 252 seconds]
20140524 13:16:54-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 252 seconds]
20140524 13:18:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140524 13:19:00-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140524 13:31:40-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 276 seconds]
20140524 13:32:01-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140524 13:37:59-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140524 13:38:53< iceiceice> aquileia: it shoudlnt take 2 hours, all of the tests (except expected timeouts) should take about a second
20140524 13:39:09< iceiceice> on my machine its about half a second to load the config cache,
20140524 13:39:30< iceiceice> then the actual test should be much less
20140524 13:39:50< iceiceice> you might want to use either wesnoth --timeout,
20140524 13:39:58< iceiceice> or a windows batch analogue of unix timeout,
20140524 13:40:19< iceiceice> i dont know windows, but this was suggested: http://stackoverflow.com/questions/12394338/windows-batch-analogue-for-timeout-command
20140524 13:44:56< aquileia> iceiceice: I'm using wesnoth --timeout
20140524 13:45:10< aquileia> but it's so damn slow
20140524 13:45:35< iceiceice> so wesnoth --timeout isn't working/
20140524 13:45:40< iceiceice> or running the test is just slow
20140524 13:45:49< aquileia> iceiceice: the latter
20140524 13:46:03< iceiceice> i wonder why
20140524 13:46:26< iceiceice> maybe try running with showgui?
20140524 13:47:31< iceiceice> or could profile i guess
20140524 13:47:39< aquileia> I just started a new build, can't test it right now
20140524 13:48:47< aquileia> But as soon as the build finished, I'll try showgui
20140524 13:50:08< aquileia> Weren't it for the massive duration and a cmd (Windows shell) bug, I could add your tests to the VC project
20140524 14:01:48< iceiceice> y ... it would be nice if could figure out how to make the stuff done by the script be done by wesnoth itself..
20140524 14:02:20< iceiceice> unfortunately there is no "Boost process" library
20140524 14:02:57< iceiceice> and to do timeout properly with threads would have to like...
20140524 14:03:01< iceiceice> go into every part of the code where there could be a loop and put "boost::check for interrupt" or whatever the right syntax is
20140524 14:03:26< iceiceice> i just dont think thats a good idea
20140524 14:04:05-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140524 14:04:40< Soliton> http://www.highscore.de/boost/process/
20140524 14:05:48< aquileia> iceiceice: Converting you script was a good exercice for me - it's just that after 5min on one processor core, every test should pass
20140524 14:05:57< aquileia> s/you/your
20140524 14:06:28< aquileia> and I can't figure out why it still hits that timeout
20140524 14:06:40< aquileia> but let's see whether the new build fixes it
20140524 14:14:08< AI0867> fabi__: the actual issue is that if _main.cfg cannot be found, it loads data/_main.cfg instead, which causes all these issues
20140524 14:14:14< AI0867> it's then also happy to cache this doubled WML tree and proclaim it valid on future loads, unless you use --nocache
20140524 14:15:05< fabi__> AI0867: I see.
20140524 14:15:53< fabi__> AI0867: I think the best solution is to rename _main.cfg to cores.cfg and load it directly.
20140524 14:16:33< fabi__> s/directly/explicitly
20140524 14:17:10< AI0867> yeah, that might be the best
20140524 14:20:49-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 14:25:35-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds]
20140524 14:48:58-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20140524 14:48:58-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20140524 14:48:58-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140524 14:49:14< mordante> servus
20140524 14:51:05< mordante> iceiceice, where is the logic error you mentioned exactly?
20140524 14:51:36< iceiceice> so i'm not sure if its wrong, it just looked funny to me
20140524 14:51:54< iceiceice> grid.cpp:466
20140524 14:51:56< iceiceice> 	if(best_size.x <= size.x && best_size.y <= size.y) {
20140524 14:52:09< iceiceice> then there are checks "if best_size.x < size.x { ... } "
20140524 14:52:22< iceiceice> and "if best_size.y < size.y { ... } "
20140524 14:53:33< iceiceice> at the bottom there is an assert 
20140524 14:53:39< iceiceice> Necrosporus was hitting that assert
20140524 14:53:44< mordante> Aishiko, rebasing is often considered somewhat evil, I think merging back would be much easier
20140524 14:54:57-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has quit [Quit: Page closed]
20140524 14:55:03< iceiceice> idk it looks we have a handler for the case "best_size.x < size.x" and also one for y
20140524 14:55:09< iceiceice> so i suggested to put an || instead of &&
20140524 14:55:26< iceiceice> but i ahve no knoweldge of the internal workings, however Necrosporus reported that assertion failure went away...
20140524 14:56:21< iceiceice> at this point i realized that I would not be able to quickly understand calculate_best_size was though and stopped thinking about it
20140524 14:56:52< mordante> is there a bug report?
20140524 14:57:16< iceiceice> not to the best of my knowledge
20140524 14:58:45< iceiceice> i think the situation was, he was trying to use inspect dialog to debug a campaign
20140524 14:58:58< iceiceice> would have to look in the logs to figure out exactly
20140524 14:59:07< mordante> Necrosporus, I read you found a bug and a possible fix, could you post your fix and tell me how to reproduce the issue?
20140524 14:59:23< mordante> lipkab, around?
20140524 14:59:52< lipkab> mordante: I am.
20140524 15:04:25-!- Octalot [~noct@132.53.125.91.dyn.plus.net] has quit []
20140524 15:22:40-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140524 15:25:26-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140524 15:26:46-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 15:28:27-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: Vannak idők, mikor menni kell]
20140524 15:47:59< Necrosporus> mordante, the issue is assertion failure when trying to use inspect window
20140524 15:48:03< Necrosporus> possible fix
20140524 15:48:31< Necrosporus> replace '&&' with '||' in ./wesnoth/src/gui/widgets/grid.cpp:466 
20140524 15:50:18< mordante> Necrosporus, ok thanks I'll have a look at it later
20140524 15:57:12-!- gfgtdf [~chatzilla@g224120008.adsl.alicedsl.de] has joined #wesnoth-dev
20140524 15:57:23< Necrosporus> mordante, if that's relevant, failure happens for me when I try to inspect variable created by [store_unit]
20140524 15:58:14< mordante> Necrosporus, would it be possible to file a bug report with a savegame to reproduce it?
20140524 15:58:56< Necrosporus> I already changed that line and recompiled
20140524 16:00:03< iceiceice> Necrosporus: it might not be the real issue, it was just something i made up as an experiment
20140524 16:00:30< Necrosporus> mordante, if you won't be able to reproduce it highlight me and I could try to change it back and recompile
20140524 16:01:02< Necrosporus> Though is it hard to open inspect window in any sufficiently complex scenario?
20140524 16:01:10< Necrosporus> :debug :inspect
20140524 16:01:21< iceiceice> Necrosporus: i tink its about reproducing the exact scenario
20140524 16:01:40< mordante> Necrosporus, well it's easier to reproduce it the same way
20140524 16:01:58< Necrosporus> mordante, do you have a copy of wesnoth 1.11?
20140524 16:02:04< mordante> I'm not 100% sure the proposed fix is correct so want to test it a bit
20140524 16:02:21< Necrosporus> I'm not sure either
20140524 16:02:23< mordante> I have a Git checkout so can get every release
20140524 16:04:11< Necrosporus> I was using 1.11.14+dev
20140524 16:04:30< Necrosporus> fc1ca38
20140524 16:08:18< happygrue>  mordante, Coffee_irc, zookeeper, anyone else interested in spritesheets/WML: Aishiko is proposing this WML format for the spritesheets: http://wiki.wesnoth.org/SpriteSheetApplicationSAB#Current_Thoughts
20140524 16:09:11< happygrue> comments welcome.  :D
20140524 16:09:28< happygrue> looked fine to me, but perhaps there are issues I haven't thought of.
20140524 16:11:24< zookeeper> well, all tags and keys should be lowercase
20140524 16:11:33< zookeeper> and then SpriteID and SpriteName should just be id and name
20140524 16:12:06< zookeeper> file= should probably be image= for consistency
20140524 16:12:35< zookeeper> just minor syntactic things of course, but never too early to get those right :J
20140524 16:13:06< Necrosporus> happygrue, what each attribute does exactly?
20140524 16:13:28< Necrosporus> Can you post also an example of attack animation using sprite instead of file
20140524 16:13:51< Necrosporus> or something like that where a sprite or portrait is used
20140524 16:14:05< Necrosporus> Also I wonder why do we need spritesheets at all?
20140524 16:14:21< happygrue> Necrosporus: start at the top of the page and read down if you want to know more
20140524 16:14:55< happygrue> but basically so we don't have so many files with some speed gain as well (hopefully).
20140524 16:15:35< Necrosporus> but it might be harder for umc devs, as they will have to calculate coordinates which is error prone
20140524 16:16:02< Necrosporus> And if it's quite easy with standard sized sprites what about large ones?
20140524 16:17:25< happygrue> Necrosporus: this is a GSoC project, you can read about the original idea here:  http://wiki.wesnoth.org/SoC_Ideas_SpriteSheets2014
20140524 16:17:47< zookeeper> Aishiko, btw, i don't think there's anything wrong with Location=[x,y,w,h], but just in case you didn't know, they could just be 4 normal separate keys because you could still write them as x,y,w,h=0,0,64,32
20140524 16:25:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140524 16:31:49< AI0867> loonycyborg: the 4.6 master fail seems to be timeouts, so maybe we should bump up the time limit
20140524 16:39:32< Necrosporus> happygrue, what if I want to both have spritesheets and individual files in single animation?
20140524 16:40:54< Necrosporus> currently it's possible to take frames of other units for example
20140524 16:41:11< Necrosporus> Also is it possible to have text ids for sprites?
20140524 16:41:44< Necrosporus> so it would be possible to use names like attack, defend and so on even when having all sprites in same file
20140524 16:41:55< mordante> Necrosporus, can't reproduce the problem :-(
20140524 16:42:20< Necrosporus> mordante, do you use 1.12 head or exact same commit?
20140524 16:42:44< mordante> the exact commit
20140524 16:43:21< mordante> I really expect it to depend on the information in :inspect
20140524 16:44:36< Necrosporus> mordante, ok, it was tutorial stage 2 when used Li'sar 
20140524 16:46:28< mordante> Necrosporus, any specific location? I'm about to leave so will look another time
20140524 16:46:42< mordante> but having more information will make it easier
20140524 16:47:03< Necrosporus> mordante, trying to inspect student_save
20140524 16:47:13< Necrosporus> Also it might be related to screen resolution
20140524 16:47:58< Necrosporus> and did you try to inspect all the variables?
20140524 16:49:16< mordante> not all of them, several
20140524 16:49:29< mordante> it will depend on the resolution, what do you use?
20140524 16:50:54< gfgtdf> mordante: do you think https://gna.org/bugs/?22046 can be fixed by replacing (height -20) with if(height > 20, height -20, 0) in _initial.cfg ?
20140524 16:52:22< mordante> gfgtdf, I've to look into it, but as said before I'm about to leave
20140524 16:52:35< mordante> please ping me next time if I forget about it
20140524 16:52:40< mordante> I'm off bye
20140524 16:53:19< Necrosporus> could you at least try the save file?
20140524 16:54:16< mordante> no sorry I really have to go now
20140524 16:54:27< mordante> I downloaded it so can test later
20140524 16:54:52-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140524 16:55:20< loonycyborg> AI0867: Why are there timeouts in the first place?
20140524 16:55:38< loonycyborg> To guard against infinite loops?
20140524 16:55:44< loonycyborg> They can be quite large then
20140524 17:03:30< gfgtdf> wesbot: seen RiftWalker
20140524 17:03:31< wesbot> gfgtdf: The person with the nick RiftWalker last spoke 2d 23h ago.  10h 41m ago they left with the message: Remote host closed the connection
20140524 17:03:47< iceiceice> gfgtdf: here's current working version of make enum: https://github.com/cbeck88/wesnoth/compare/make_enum_fixup
20140524 17:03:55< gfgtdf> iceiceice: do you know why we have different tags [multiplayer] and [scenario] i think where already a discaussion about ti but i couldnt fing
20140524 17:04:15< iceiceice> i think that,
20140524 17:04:21< iceiceice> it has to dow ith campaigns
20140524 17:04:32< iceiceice> if you have a campaign, it may say "campaign_type = multiplayer"
20140524 17:04:36< iceiceice> or "singleplayer"
20140524 17:04:40< iceiceice> (more or less)
20140524 17:04:51< iceiceice> and this will control which game_config is loaded,
20140524 17:04:56< iceiceice> and hence which scenario id's are available
20140524 17:05:45< iceiceice> gfgtdf: i had to abandon this syntax with "make_enum(foo::, enumname)"
20140524 17:06:00< iceiceice> CAT(foo::, enumname) doesn't compile for me
20140524 17:06:12-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140524 17:06:19< gfgtdf> your CAT2 you mean ?
20140524 17:06:23< iceiceice> y
20140524 17:07:22< iceiceice> specifically this doesn't compile: http://pastebin.com/Cs8xndXn
20140524 17:07:29< thunderstruck> gfgtdf: [multiplayer] tag is for stand-alone scenarios
20140524 17:07:34< iceiceice> err
20140524 17:07:38< iceiceice> sry that was old 
20140524 17:08:07< gfgtdf> 	thunderstruck: so [multiplayer] is nothign more than a shortcut for [campaign] and [scenario] in one ?
20140524 17:08:39< thunderstruck> gfgtdf: well, [multiplayer] was available for MP games before [campaign]
20140524 17:08:54< iceiceice> http://pastebin.com/sWnWpRjT
20140524 17:09:01< thunderstruck> gfgtdf: but with my changes it's now possible to use SP syntax in MP
20140524 17:09:18< thunderstruck> gfgtdf: it's not actually a shortcuit
20140524 17:09:36< thunderstruck> gfgtdf: it shouldn't be used for MP campaigns, because some things won't be supported then
20140524 17:11:12< gfgtdf> thunderstruck: but what is teh reason to use multiplayer insteead of scenario aside tht you have to write a [campaign] tag then ?
20140524 17:11:14< thunderstruck> gfgtdf: also note if you're interested, that internally [multiplayer] is actually used for proper MP campaigns with [campaign] tag
20140524 17:13:06< gfgtdf> thunderstruck: but from the wml authout point of view are there any features that [multiplayer] supports which [scenario][campaign] doesn't ?
20140524 17:13:13< thunderstruck> gfgtdf: well, as I said, [multiplayer] is for stand-alone scenarios. [campaign] with [scenario] allows you to have the same syntax for MP as for SP and so you can have difficulties and other benefits of proper campaigns
20140524 17:14:00< thunderstruck> gfgtdf: no, there is none
20140524 17:14:25< gfgtdf> thunderstruck: so what is the reason to keep [multiplayer] istead of a little less writing ?
20140524 17:14:34< gfgtdf> s/instead/aside
20140524 17:14:44< gfgtdf> despite*
20140524 17:14:50< thunderstruck> gfgtdf: to not break existing WML
20140524 17:15:16< iceiceice> also, mp scenarios?
20140524 17:15:20< thunderstruck> yeah
20140524 17:15:54< thunderstruck> it's also a way to differentiate between MP campaigns and stand-alone scenarios
20140524 17:15:56< gfgtdf> thunderstruck: we could also always convert [multiplayer] into [scenario][campaign] at wml laoding and dont bother wil teh differentces after.
20140524 17:16:08< thunderstruck> I suppose so
20140524 17:17:23< gfgtdf> thunderstruck: hmm ok
20140524 17:17:52< thunderstruck> It was way easier for me to leave that [multiplayer] and focus on other tasks during GSoC
20140524 17:18:21< thunderstruck> but yeah, at some point it would be probably better to get rid of this unnecessary tag
20140524 17:20:00< gfgtdf> thunderstruck: hmm ok but i don't want to work on that until 1.12 is ready. And i also don't want to interfere with thecurrent gsoc i think 
20140524 17:20:26< thunderstruck> iceiceice: could you briefly tell me why your fix didn't work for #22068?
20140524 17:20:54< thunderstruck> gfgtdf: yeah, RiftWalker's project would have to touch those parts
20140524 17:21:57< iceiceice> thunderstruck: i tried two things actually
20140524 17:21:58< iceiceice> https://github.com/cbeck88/wesnoth/compare/wesnoth:1.12...fixup_mp_sos_saves
20140524 17:22:02< iceiceice> after discussing with gfgtdf
20140524 17:22:58< iceiceice> i attached link to my console error log in github
20140524 17:23:02< iceiceice> i dont know anything more than that
20140524 17:23:07< gfgtdf> iceiceice: what error did you get on CAT2(foo::, enumname)  ?
20140524 17:23:19< iceiceice> gfgtdf: i put it in my pastebin
20140524 17:23:44< iceiceice> gfgtdf: actually i have an idea, why dont we rename "string_to_enumname" to "enumname_from_string", because then we wont ever have to pass two arguments to MAKE_STREAM_OPS
20140524 17:24:15< thunderstruck> iceiceice: http://wiki.wesnoth.org/SavefileWML
20140524 17:24:29< thunderstruck> Do you know if this page is up-to date?
20140524 17:24:54< iceiceice> no i have no idea
20140524 17:25:07< iceiceice> i would have asked you actually :O
20140524 17:25:23< iceiceice> according to history it was last updated by Ayne?
20140524 17:25:26< thunderstruck> iceiceice: :)
20140524 17:25:35< iceiceice> maybe concurrent with this commit that Sigurd found
20140524 17:25:36< thunderstruck> iceiceice: I'm not an expert with savegames
20140524 17:25:50< thunderstruck> Although I messed with them a little bit during my GSoC project
20140524 17:26:09< gfgtdf> iceiceice:: ok it seems indeed liek your complier it a litte stricter than mine with the ## 
20140524 17:26:48-!- SigurdFD [~SigurdFD@24.154.98.89] has joined #wesnoth-dev
20140524 17:28:47< iceiceice> gfgtdf: yeah :( it unfortunately took me a while to figure that out
20140524 17:29:10< gfgtdf> iceiceice: it seems like empty macro arguemtns arent even legal in the oldest c++ version we support
20140524 17:29:34< iceiceice> i think if we rename string_to_enumname like i said,
20140524 17:29:39< iceiceice> we would be able to just write
20140524 17:29:48< iceiceice> `make_enum_streap_ops ( foo::enumname )`
20140524 17:29:52< iceiceice> for classes and namespaces
20140524 17:32:40< gfgtdf> hmm i think your version with MAKE_ENUM_STREAM_OPS1 and MAKE_ENUM_STREAM_OPS2 is fine.
20140524 17:33:36< iceiceice> ok
20140524 17:34:21< iceiceice> the other hting i found:
20140524 17:34:26< iceiceice> the reason iw as getting linker errors was
20140524 17:34:37< iceiceice> even if the function is marked static, we include team.hpp in multiple of the library components
20140524 17:34:39< iceiceice> when we build
20140524 17:34:46< iceiceice> like i think it goes in wesnoth-lib, and wesnoth-extra,
20140524 17:34:48< iceiceice> maybe others
20140524 17:34:57< iceiceice> so you have to mark inline or you get linker errors at the last step
20140524 17:36:38< iceiceice> thunderstruck: it seems very difficult to figure out what's going on with the config cache / game config, because its way too big to dump it for debugging output
20140524 17:36:44< gfgtdf> iceiceice: i also think it woudl be nice if you could make a sp game into a mp game during the game. without restarting/reloading
20140524 17:37:08< iceiceice> gfgtdf: how would that work though?
20140524 17:37:17< iceiceice> you dont have observers
20140524 17:37:49< iceiceice> thunderstruck: maybe should make like a "core" using fabi's mechanism with only test stuff in the data/ dir or something like this so its small enough to dump?
20140524 17:38:05< gfgtdf> iceiceice: hmm i'll think about it
20140524 17:38:16< iceiceice> i really have no idea how i would try to debug this otherwise, if i didnt have experience using these things
20140524 17:39:46< gfgtdf> iceiceice, thunderstruck: do you knwo about https://gna.org/bugs/?21801 ? i dont exactl know ho terring building buwky but this bug annoys me too
20140524 17:41:43< iceiceice> gfgtdf: i dont know that works
20140524 17:41:49< iceiceice> i guess the bug is since the new minimap was used in lobby?
20140524 17:41:53< iceiceice> because the new minimap needs terrain info
20140524 17:42:41< iceiceice> maybe there can be a redux version when you just need a minimap? idk
20140524 17:42:48< iceiceice> i'm not even sure exactly what the terrain builder is responsible to do
20140524 17:42:58< iceiceice> it sounds like it has been passed over a few times for refactor though
20140524 17:44:38< iceiceice> bbl
20140524 17:44:52< gfgtdf> iceiceice: i think its unrelated to teh "tactical" minimap mode.
20140524 17:45:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140524 17:55:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140524 18:01:38< AI0867> loonycyborg: the test doesn't end until the scenario does, so a broken test can sit there forever
20140524 18:03:09-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140524 18:04:33< Ivanovic> AI0867, AI0867, boucman, Coffee_irc, elias, fabi__, happygrue. iceiceice, loonycyborg, sachith500, shadowm, Soliton, thunderstruck, zookeeper, everyone else who cares: ready for 1.11.15?
20140524 18:04:54< loonycyborg> yes
20140524 18:05:03< sachith500> oh yes! :D
20140524 18:05:24< sachith500> I was just playing world conquest haha
20140524 18:10:42-!- irker584 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140524 18:10:42< irker584> wesnoth: Nils Kneuper wesnoth:1.12 f24fd7d4e492 / Doxyfile changelog players_changelog src/wesconfig.h: bump version to 1.11.15 http://git.io/NydtLQ
20140524 18:10:42< irker584> wesnoth: Nils Kneuper wesnoth:1.12 4894cbe3a63d / / (196 files in 14 dirs): pot-update and regenerated doc files http://git.io/HD98FQ
20140524 18:16:12< gfgtdf> Ivanovic: ahh i still have do add something in the  changelog is that still possible ?
20140524 18:16:32< Ivanovic> uhm, i just did all the initial packaging and am about to test it now...
20140524 18:16:45< Ivanovic> why don't you folks directly do the changelog entries together with the commits?!?
20140524 18:17:17< iceiceice> gfgtdf: whats the changelog entry?
20140524 18:17:27< iceiceice> i added a changelog entry for the 1.12 backport of defeat conditions
20140524 18:17:29< gfgtdf> iceiceice: about defeat_condition=
20140524 18:17:33< gfgtdf> ah ok :)
20140524 18:17:36< iceiceice> and a release notes
20140524 18:17:38< iceiceice> y i already di that yesterday :)
20140524 18:17:46< iceiceice> Ivanovic: i am also ready to go :)
20140524 18:18:56< gfgtdf> iceiceice: did aou alsoe add the remove_from_carryover_on_leader_loss -> remove_from_carryover_on_defeat ?
20140524 18:19:02< gfgtdf> you also*
20140524 18:19:08< iceiceice> https://github.com/wesnoth/wesnoth/blob/1.12/changelog
20140524 18:21:52< gfgtdf> iceiceice: hmm but  386893d6dff7e6d is not in it seems. Maybe uit enought to add that in the release notes
20140524 18:23:26-!- sachith500 [~kvirc@112.135.151.102] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140524 18:23:46< iceiceice> it looks like its in? https://github.com/cbeck88/wesnoth/blob/1.12/src/team.cpp
20140524 18:24:13< gfgtdf> iceiceice: not in teh changelog i mean
20140524 18:24:15< gfgtdf> the*
20140524 18:24:15< iceiceice> oh
20140524 18:24:32< iceiceice> i mean defeat_condtiions was not in the previous release
20140524 18:24:52< iceiceice> we could write something if you want
20140524 18:25:09< iceiceice> heres what i wrote
20140524 18:25:09< iceiceice> https://github.com/wesnoth/wesnoth/blob/1.12/RELEASE_NOTES
20140524 18:26:51< gfgtdf> iceiceice: hm i think the term "game event" might be missleadign since it might be connected to the [event]s
20140524 18:27:26< iceiceice> y it would be good if you would help release people rewrite some parts of that i guess,
20140524 18:27:32< iceiceice> theres some parts also i wasnt sure about some details
20140524 18:27:42< shadowm> You have 6 hours to make sure R_N is up to date.
20140524 18:27:55< shadowm> Just FYI. All.
20140524 18:28:29< gfgtdf> shadowm: the R_N is just for the forums ?
20140524 18:28:41-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140524 18:28:43< shadowm> Grumble grumble. Yes.
20140524 18:29:00< gfgtdf> shadowm: no i meant becasue i wantet to know what i cna use there
20140524 18:29:03< gfgtdf> can
20140524 18:29:37< shadowm> I'll generally take care of the formatting myself since I almost always have to rewrite some awkward or opaque wording.
20140524 18:29:58< shadowm> ('Opaque' meaning "makes no sense to a user".)
20140524 18:32:00< gfgtdf> iceiceice: for example there is no check between a pre_recall and recall, in general there is one check after ever human/ai invoked action liek recruit/recall/move/attack/menu_item_click/.. .
20140524 18:32:26< iceiceice> ok
20140524 18:33:01< iceiceice> maybe it shold say, "after many (most?) game events, and after any user action"
20140524 18:33:16< iceiceice> is that accurate?
20140524 18:34:02< gfgtdf> iceiceice: why just not "after every user action" 
20140524 18:34:14< gfgtdf> at teh end ofthem
20140524 18:34:49< iceiceice> ok
20140524 18:35:13< gfgtdf> iceiceice: hmm but for exampe, the is non after a "select" event its just after every synced user action
20140524 18:35:15< irker584> wesnoth: ivanovic wesnoth: 4894cbe3a63d tagged as 1.11.15
20140524 18:35:43< Ivanovic> okay, this version seems to work
20140524 18:36:05-!- Ivanovic changed the topic of #wesnoth-dev to: tagged 1.11.15 (1.12 beta5), announcing "soon" | string+feature freeze active on 1.12 | 241 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140524 18:36:33< gfgtdf> iceiceice: do you  think "synced user action" is understandalve for normal palyers ?
20140524 18:37:13< iceiceice> im not sure you should ask shadowm :)
20140524 18:37:13< iceiceice> it probably is i think
20140524 18:37:22< iceiceice> maybe just say user action (specifically, every synced user action)
20140524 18:38:42< gfgtdf> iceiceice: hm ye
20140524 18:49:00< AI0867> Ivanovic: I think I'm good
20140524 18:55:03< gfgtdf> iceiceice: we currently see on travis 1) whether gcc+unit test passed 2) whether sceons+unit test passed, maybe it woudl be better to see 1) whether gcc passed 2) whether scons passed 3) whether unit test passed ?
20140524 18:55:32< iceiceice> how would we do that?
20140524 18:55:39< iceiceice> also the tests might pass differently for gcc / scons
20140524 18:56:25-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140524 18:56:32< Necrosporus> has been replaced with [tt]"defeat_condition"=always/no_leader_left/no_units_left/never[/tt] // It should vbe called no_leaders_left
20140524 18:57:18< iceiceice> lol the first time i read that i thought you were emoting it
20140524 19:02:00< gfgtdf> Necrosporus: i have no opinion on whether it should  be no_leader_left/no_leaders_left.
20140524 19:04:57-!- travis-ci [~travis-ci@ec2-54-198-191-17.compute-1.amazonaws.com] has joined #wesnoth-dev
20140524 19:04:57< travis-ci> [travis-ci] wesnoth/wesnoth#2769 (1.11.15 - 4894cbe : Nils Kneuper): The build passed.
20140524 19:04:57< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25953383
20140524 19:04:57-!- travis-ci [~travis-ci@ec2-54-198-191-17.compute-1.amazonaws.com] has left #wesnoth-dev []
20140524 19:07:38< Necrosporus> gfgtdf, but leaders are normal units with canrecruit=yes and one side could have several
20140524 19:08:18-!- Octalot [~noct@132.53.125.91.dyn.plus.net] has joined #wesnoth-dev
20140524 19:09:16< Necrosporus> So no_leader_left could be misleading
20140524 19:09:45< gfgtdf> RiftWalker: are you going to eliminate this codepath in your gsoc ? https://github.com/wesnoth/wesnoth/blob/master/src/playcampaign.cpp#L295
20140524 19:09:56< Ivanovic> aquileia, mordante: okay, i gave those "other" libs a try and i can't just use them as drop in replacement
20140524 19:10:42-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140524 19:10:42< irker584> wesnoth: Chris Beck wesnoth:master e8266ba9323e / src/util.hpp: add public to the definition of bad_lexical_cast http://git.io/ex222w
20140524 19:10:42< Necrosporus> iceiceice, if you use this option, and have several leaders, one is defined in [side] and other as [unit] somewhere else, will this option check for only first one or all the leaders?
20140524 19:10:44< irker584> wesnoth: Chris Beck wesnoth:master 215de94390e7 / / (8 files in 6 dirs): Add make_enum macros and a unit test, also add to project files http://git.io/z3hadw
20140524 19:10:46< irker584> wesnoth: Chris Beck wesnoth:master ea428a506c87 / src/ (scripting/lua.cpp team.cpp team.hpp): refactor team to use MAKE_ENUM macro for team::DEFEAT_CONDITION http://git.io/CiQWmg
20140524 19:11:04< iceiceice> Necrosporus: it doesnt matter if it's in side or not
20140524 19:11:12< iceiceice> it behaves exactly the same as it always did
20140524 19:11:22< iceiceice> we didnt change the behavior of no_leader_left
20140524 19:11:27< iceiceice> thats just the default behavior as always
20140524 19:11:38< iceiceice> perhaps that should be emphasized in RELEASE_NOTES
20140524 19:11:58< gfgtdf> iceiceice: in ouy commit in Example Usage: you forgot teh " i think
20140524 19:12:00< gfgtdf> your
20140524 19:12:35< Necrosporus> iceiceice, so it must be called no_leaders_left
20140524 19:13:07< Necrosporus> to be consistent with no_units_left
20140524 19:13:23< iceiceice> Necrosporus: i think there was a dev grammar debate a few days ago
20140524 19:13:46< iceiceice> i'm sure this point was raised, idk what the rationale was
20140524 19:13:56< shadowm> I didn't even think of the multiple leaders possibility when I partook in it.
20140524 19:14:33< Necrosporus> I know at least one campaign where it takes places
20140524 19:14:56< shadowm> I have a campaign where multiple leaders happen too.
20140524 19:15:24< iceiceice> gfgtdf: yeah you are right
20140524 19:16:01< iceiceice> maybe should just delete that and say "look at the unit test"
20140524 19:16:01< Necrosporus> Though if this is default then if one writes no_leaders_left the result would be no different, right?
20140524 19:16:24< Necrosporus> or game would complain?
20140524 19:16:34< gfgtdf> iceiceice: i also suggest to change teh assert(false) into assert(false && "Corrupted enum found") r somethign like this
20140524 19:16:39< gfgtdf> or
20140524 19:16:48-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140524 19:17:11< iceiceice> ok
20140524 19:17:15 * shadowm hates pot-updates.
20140524 19:17:44< shadowm> I'm not sure why they result in so large object packs, it's all supposed to be easily diffable.
20140524 19:18:04< shadowm> *such
20140524 19:18:27< shadowm> And it's all supposed to be delivered compressed according to the git output, so what gives?
20140524 19:19:15< gfgtdf> what are pot-updates ?
20140524 19:19:50< shadowm> Translation catalogue templates (.pot files) regeneration and reconciliation with the actual translation catalogues (.po files).
20140524 19:20:14< iceiceice> hmm gfgtdf: do you know why i didnt have to inlcude iostream?
20140524 19:20:20< iceiceice> is that part of boost preprocessor or something?
20140524 19:20:27< shadowm> 14:10:41 <irker584> wesnoth: Nils Kneuper wesnoth:1.12 4894cbe3a63d / / (196 files in 14 dirs): pot-update and regenerated doc files http://git.io/HD98FQ
20140524 19:20:30< iceiceice> *included with?
20140524 19:20:31< shadowm> ^ As in this stuff.
20140524 19:21:53< gfgtdf> iceiceice: i thought it was becasue of util.hpp but you removed the incude of that file so idk
20140524 19:22:16< iceiceice> :/
20140524 19:22:18< iceiceice> i guess maybe
20140524 19:22:26< iceiceice> everything with team includes util,
20140524 19:22:35< iceiceice> and the unit tests get it from the boost unit test package?
20140524 19:22:40< iceiceice> i think imight need to add iostream or smething
20140524 19:24:04-!- trewe [~trewe@2001:8a0:d139:9701:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20140524 19:28:36< gfgtdf> fabi_: do you knwo about http://gna.org/bugs/?22073 ? What was the reason why you removed that header ?
20140524 19:28:39< gfgtdf> know
20140524 19:35:01< iceiceice> shadowm: i think you guys should decide whether "multiplayer start of scenario saves don't work" should be mentioned as a known bug in the release notes
20140524 19:35:13< iceiceice> i didnt think to add it
20140524 19:35:15< iceiceice> dont have strong opinion either
20140524 19:48:38-!- travis-ci [~travis-ci@ec2-54-198-226-188.compute-1.amazonaws.com] has joined #wesnoth-dev
20140524 19:48:38< travis-ci> [travis-ci] wesnoth/wesnoth#2770 (master - ea428a5 : Chris Beck): The build was broken.
20140524 19:48:38< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25954729
20140524 19:48:38-!- travis-ci [~travis-ci@ec2-54-198-226-188.compute-1.amazonaws.com] has left #wesnoth-dev []
20140524 19:48:53< gfgtdf> shadowm: it seemls liek there are some keys assigned twice in the default hotkeys file, do you know who can do somethign against that ?
20140524 19:50:05< shadowm> fabi
20140524 19:53:07< iceiceice> well this is annoying: http://pastebin.com/8bxgW1r1
20140524 19:53:16< iceiceice> i should have tried compiling with gcc i guess
20140524 19:54:35< iceiceice> maybe can fix this with a template parameter?
20140524 19:54:38-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140524 19:54:44< iceiceice> boost::is_enum or smth?
20140524 19:55:12-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 20:00:20-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 276 seconds]
20140524 20:03:31-!- Guest36501 [~cib@p508BC650.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140524 20:05:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140524 20:09:25< gfgtdf> iceiceice: maybe youhave to write To res = To(); instead of To res;
20140524 20:09:59< iceiceice> are enums default constructable though?
20140524 20:10:28< gfgtdf> hm i suppose they are just inilizes with whatever their 0 value ois
20140524 20:10:40< gfgtdf> initilised
20140524 20:11:28< gfgtdf> iceiceice: ^
20140524 20:11:49< iceiceice> y idk why gcc isnt doing that
20140524 20:12:22< iceiceice> hmm you kow
20140524 20:12:26< iceiceice> i'm not sure if that's the issue
20140524 20:12:53< iceiceice> i tested that gcc and clang compile this: http://pastebin.com/THLMLv7q
20140524 20:13:07< iceiceice> but there it doesnt complain about default construction
20140524 20:13:29< gfgtdf> iceiceice: sure becasue you assign it later
20140524 20:13:40< iceiceice> maybe its because gcc thinks if str << a fails,
20140524 20:13:51< iceiceice> then the str >> res wont execute?
20140524 20:14:06< gfgtdf> iceiceice: ye, or teh compiler doesnt even know that >> assign the value.
20140524 20:14:18< gfgtdf> iceiceice: i mean teh operator youd be defiend any way
20140524 20:14:21< gfgtdf> could
20140524 20:14:39< iceiceice> y
20140524 20:21:56-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 252 seconds]
20140524 20:26:57< iceiceice> idk if theres a good way to fix this, we dont have boost typetraits library i guess...
20140524 20:27:19< iceiceice> maybe have to add lexical cast definitions for enum to the stream ops
20140524 20:27:46< iceiceice> otherwise i would say we could fixup the templates in util.hpp
20140524 20:27:47-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140524 20:29:43< iceiceice> i think i'm just going to commit that as a temporary measure unless someone has a better idea
20140524 20:31:33< gfgtdf> iceiceice: the To res = To();  =
20140524 20:31:35< gfgtdf> ?
20140524 20:31:50< iceiceice> ok i can try that
20140524 20:32:55< iceiceice> hmm well clang seems to like that
20140524 20:34:07-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Remote host closed the connection]
20140524 20:35:38< iceiceice> gcc also
20140524 20:35:40< iceiceice> at least so far
20140524 20:35:56< iceiceice> hmm for some reason i didnt think that would work but it looks like it is :)
20140524 20:36:16-!- Sulfur [~Miranda@p5B0081BE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140524 20:36:20< iceiceice> it will only fail fairly late in process though
20140524 20:36:49< gfgtdf> iceiceice: so it failed ?
20140524 20:37:50< iceiceice> i think it might work
20140524 20:37:51< iceiceice> we'll see
20140524 20:38:03< iceiceice> compiling from scratch with gcc will take a while...
20140524 20:38:16< iceiceice> i dont have any ccache with gcc
20140524 20:39:26< iceiceice> i guess i can try to compile a code sample
20140524 20:39:28< gfgtdf> iceiceice	: do you think we can ccache work with travis ?
20140524 20:39:29< irker584> wesnoth: Nils Kneuper wesnoth:1.12 9b71767cd3c0 / Doxyfile changelog players_changelog src/wesconfig.h: post release version bump to 1.11.15+dev http://git.io/UyMVaQ
20140524 20:39:34-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140524 20:39:37< iceiceice> gfgtdf i never thoguht of that
20140524 20:39:47< iceiceice> my guess is no,
20140524 20:39:52< iceiceice> i think each travis worker is like in the cloud somewhere
20140524 20:39:58< iceiceice> but maybe we can on jenkins or smth
20140524 20:44:45-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140524 20:49:29< gfgtdf> iceiceice: do you know whether there is a way to find out who is the host from inside a wml ?
20140524 20:49:59< iceiceice> i doubt it
20140524 20:54:06< iceiceice> hmm there is a play_controller "is_host" function
20140524 20:54:12< iceiceice> so now its more likely :)
20140524 20:55:19< iceiceice> ok, but its never called by wml...
20140524 20:55:30< iceiceice> my guess is that the only way would be something really extreme
20140524 20:56:01< iceiceice> idk like, WML crashes a client and watches where the droids go :)
20140524 20:57:27< gfgtdf> iceiceice: hmm that too extreme, also won't work in a sp game.
20140524 20:59:14< iceiceice> i think otherwise its transparent to wml
20140524 20:59:30< iceiceice> is it useful to expose this info?
20140524 21:02:49< gfgtdf> iceiceice: hmm in my addon i wanted to be able to read a list of recruits from a file, but i want to use the host's version. That's why i asked. Its not that  important thought.
20140524 21:03:13< loonycyborg> Ivanovic: 1.11.15 windows installer is uploaded
20140524 21:03:35< iceiceice> gfgtdf: can you get the version from a client? i didnt know that
20140524 21:04:03< gfgtdf> no the host version of teh file, in case all clients have a differnet file
20140524 21:04:07< iceiceice> oh
20140524 21:04:08< iceiceice> i see
20140524 21:04:34< gfgtdf> iceiceice: but i tink you can get the version of a client in lua
20140524 21:04:42< gfgtdf> with wesnoth.compare_versions
20140524 21:11:45< iceiceice> maybe you should just take the version from the client with the latest version?
20140524 21:14:37< gfgtdf> iceiceice: hmm no im not even conviced of what i original wante to do anymore
20140524 21:15:36< gfgtdf> iceiceice: so i'll chage "game event" into "user action"  in the releasenotes ?
20140524 21:16:34< iceiceice> sure
20140524 21:16:44< iceiceice> its not up to me, its up to you and the release team
20140524 21:17:42< gfgtdf> iceiceice: i think a more generic [option]=dialog in the mp create screen woudl be cool, something that pops up a lua gui2 dialog.
20140524 21:17:48-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 21:18:37< gfgtdf> iceiceice: but i think teh lua engine is not initilized at that point :s
20140524 21:19:28< iceiceice> y it woudl be kind of cool
20140524 21:20:00< iceiceice> when i tried to make smething like that what i have done is make a "setup" scenario
20140524 21:22:19-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140524 21:24:38< gfgtdf> iceiceice: hm as my adon is a modification a setup scenario isnt possible
20140524 21:25:23< iceiceice> y 
20140524 21:25:39< iceiceice> but you could just make the whole thing a setup scenario :)
20140524 21:25:48< iceiceice> instead of a modification
20140524 21:25:48< gfgtdf> how ?
20140524 21:26:12< gfgtdf> hm but i want to modify things like play Low + mod
20140524 21:26:12< iceiceice> well what exactly does it do
20140524 21:26:22< iceiceice> oh then y what i'm saying wont work
20140524 21:26:51< gfgtdf> iceiceice: is like similar to zookeepers Pyr mod
20140524 21:27:24< gfgtdf> iceiceice: the more i think about it i liek the [option]type=dialog
20140524 21:27:53< gfgtdf> s/i liek/the more i like
20140524 21:31:27< iceiceice> gfgtdf: i also have a mod that is a bit like zookeeper's Pyr mod :)
20140524 21:31:39< gfgtdf> iceiceice: really ?
20140524 21:31:45< iceiceice> y
20140524 21:31:52< gfgtdf> iceiceice: which one ?
20140524 21:31:57< iceiceice> Captain's mode
20140524 21:32:33< iceiceice> it was my first one, i made it and then promptly forgot about it, but i mgiht come back to it esp. after pyra tournament
20140524 21:32:39< gfgtdf> iceiceice: i dont find it on teh addon server
20140524 21:32:48< iceiceice> its on 1.10
20140524 21:33:11< gfgtdf> iceiceice: hm i think 1.10 sidnt support mods ?
20140524 21:33:12< iceiceice> whoa i got 700 DL :)
20140524 21:33:16< gfgtdf> didin't
20140524 21:33:36< iceiceice> it did if you use the "setup scenario" approach
20140524 21:34:10< gfgtdf> iceiceice: hm how did that work with other scenarios ?
20140524 21:34:41< iceiceice> you just endlevel and set the next_scenario using an argument controled by menus
20140524 21:34:58< gfgtdf> hm but then you ahve to know the possible next scenarios
20140524 21:35:14< iceiceice> well you make a list of possibilities you want
20140524 21:35:15< iceiceice> or let the user type an id
20140524 21:35:34< gfgtdf> iceiceice: user usialy dont knwo teh idd
20140524 21:35:36< gfgtdf> the*
20140524 21:35:39< iceiceice> true
20140524 21:35:50< iceiceice> i assumed that most people would want to play my add-on using the RBY map pack
20140524 21:35:58< iceiceice> so i give each of those as an option
20140524 21:36:03< gfgtdf> iceiceice:  what is RBY ?
20140524 21:36:19< iceiceice> RBY is the random map pack used by the wesnoth ladder
20140524 21:36:48< iceiceice> it contains some mainline maps and some other maps from the community that are at "acceptable" balance for ladder play as determined by ladder council
20140524 21:37:25< iceiceice> i am now maintaining it actually
20140524 21:37:50< iceiceice> i patched a bug in their rng :)
20140524 21:38:23-!- gfgtdf_ [~chatzilla@d222100.adsl.hansenet.de] has joined #wesnoth-dev
20140524 21:39:14< irker584> wesnoth: gfgtdf wesnoth:1.12 34f7f53e4047 / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/9jwETQ
20140524 21:39:20< iceiceice> gfgtdf: your TO() thing worked perfectly
20140524 21:39:23< gfgtdf_> iceiceice: ^
20140524 21:39:54< gfgtdf_> (the commit)
20140524 21:40:38-!- gfgtdf [~chatzilla@g224120008.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140524 21:40:48-!- gfgtdf_ is now known as gfgtdf
20140524 21:43:09< irker584> wesnoth: Chris Beck wesnoth:1.12 87cd72a22dc7 / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/M4j5Hw
20140524 21:45:12< irker584> wesnoth: Chris Beck wesnoth:master 59e738a09321 / changelog: update changelog http://git.io/-u5wzw
20140524 21:45:14< irker584> wesnoth: Chris Beck wesnoth:master 17d63fce9d11 / src/make_enum.hpp: fixup includes and docs of make_enum http://git.io/dSOerQ
20140524 21:45:16< irker584> wesnoth: Chris Beck wesnoth:master 0e2e54c6320c / src/util.hpp: fixup lexical cast implementation. http://git.io/sTJwMw
20140524 21:45:48-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140524 21:46:19< iceiceice> crap i made a mistake in commit message ><
20140524 21:46:22< iceiceice> oh well
20140524 21:46:35< iceiceice> gfgtdf: i also revised RELEASE_NOTES
20140524 21:47:00< gfgtdf> iceiceice: a typo in the first word of the commit message ?
20140524 21:47:20< iceiceice> no i wrote that the problem was when From was of type enum when its actually To
20140524 21:47:27< iceiceice> but it doesnt really matter, they will figure it out i think
20140524 21:47:41< gfgtdf> iceiceice: ye i saw. When i first saw you made a commit i already thought this was an edit war :)
20140524 21:48:47< iceiceice> did we update the wiki stuff with this new stuff?
20140524 21:49:22< gfgtdf> iceiceice: ye: http://wiki.wesnoth.org/SideWML
20140524 21:53:13< irker584> wesnoth: Chris Beck wesnoth:1.12 faecfabc289b / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/cz1i7Q
20140524 22:05:33< gfgtdf> iceiceice: why did you choose 1bd43bb6a99803f77020aa02eed51b067077cea7 instead of 7836f5edc2013d21090f0b7ddacaed8c370e9a89 ?
20140524 22:07:41< iceiceice> because the docs are fairly specific that you are supposed to lose as soon as your leader dies
20140524 22:07:51< iceiceice> and thats what the original one was set up to do
20140524 22:08:04< iceiceice> victory_when_enemies_defeated = no is a fairly wierd setting i guess...
20140524 22:08:16< iceiceice> in the normal mode everyone will win / lose at the same time i guess
20140524 22:08:39< iceiceice> but with victory_when_enemies_defeated=no, they drop out as their leaders dissappear
20140524 22:08:50< iceiceice> the change i made is based on 3 possibilities
20140524 22:08:58< iceiceice> 1.) you control a human side, and your leader is alive
20140524 22:09:14< iceiceice> 2.) you control a human side but your leader is gone
20140524 22:09:14< iceiceice> 3.) you dont control a human side
20140524 22:09:23< iceiceice> only 2 is supposed to be defeated, because 3 contains the mp observers
20140524 22:09:51< iceiceice> but anyways the check i wrote is beter than is_observer i think
20140524 22:10:11< gfgtdf> iceiceice: what was bad bout is_observer ?
20140524 22:10:23< iceiceice> corner cases involving someone controlling only droids
20140524 22:10:59< iceiceice> also just like,
20140524 22:11:00< gfgtdf> hmm still victory_when_enemies_defeated=no, doenst casue drop outs as seeon as their leader diaspears 
20140524 22:11:19< gfgtdf> the: all living sides must be allied is still valid with that
20140524 22:11:53< iceiceice> all living sides must be allied is just a condition for the function to continue
20140524 22:12:06< iceiceice> if that's not the case then the game continues regardless of victory_when
20140524 22:12:07< gfgtdf> iceiceice: and i currently cannot imagene where teh current or teh previous behaviour is desired
20140524 22:12:26< iceiceice> the change i made mainly only will affect observers in mp games
20140524 22:12:29< iceiceice> normally when you spectate a game,
20140524 22:12:37< iceiceice> if it ends, it also ends and goes to linger mode on your machine
20140524 22:12:50< iceiceice> with the victory_when=no though, 
20140524 22:12:56< iceiceice> idk 
20140524 22:13:05< iceiceice> i think that it wouldnt register scenario ending for the observer
20140524 22:13:20< iceiceice> at least, it wouldnt be working the way it does for normal scenarios without victory_When... = no
20140524 22:13:33< iceiceice> so all i really did was brought that into agreement
20140524 22:13:48< iceiceice> if the last human side is defeated in a victory_no scenario,
20140524 22:13:56< iceiceice> the observer will see the secnario end message
20140524 22:14:06< gfgtdf> iceiceice: well in a simple 1vs1 scenario and victory_on_.. = no, if side 1 wins teh result is that 2 gets teh defeated message but side 1 doesnt get teh victory messasge
20140524 22:14:15< iceiceice> thats right
20140524 22:14:22< iceiceice> thats whats supposed to happen
20140524 22:14:29< iceiceice> i think
20140524 22:14:44< gfgtdf> iceiceice: i cannot imageing when this is desired
20140524 22:14:54< iceiceice> victory_when = no is only supposed to end when the wml says [endlevel] victory = yes
20140524 22:15:03< iceiceice> or all the players are defeated
20140524 22:15:16< gfgtdf> iceiceice:   but taht not the case
20140524 22:15:43< iceiceice> whats the bugged case?
20140524 22:15:56< gfgtdf> iceiceice: the gaem still goes on for teh one side who has "won"
20140524 22:16:10< gfgtdf> iceiceice: bot not for teh others
20140524 22:16:22< iceiceice> in what circumstances?
20140524 22:16:31< iceiceice> when 2's leader is removed?
20140524 22:16:35< iceiceice> or when wml ends the scenario
20140524 22:16:51< gfgtdf> when 2s leader is removes
20140524 22:16:57< iceiceice> ok thats not a bug
20140524 22:17:00< gfgtdf> wml ends is indpeendednt from that
20140524 22:17:06< gfgtdf> why is that not a big
20140524 22:17:10< gfgtdf> bug
20140524 22:17:59< gfgtdf> iceiceice: ^
20140524 22:18:01< iceiceice> victory_when_enemies_defeated: when this is set to yes (default), the player wins once all non-allied units with canrecruit=yes (aka leaders) are killed. (Currently this only controls the win condition for when all enemies are defeated; it does not prevent the player from losing if he has no leader.)
20140524 22:18:17< iceiceice> when you set it to no, it disables the win condition
20140524 22:18:22< iceiceice> it doesnt disalbe the defeat condition
20140524 22:19:04< gfgtdf> iceiceice: i think that was written with Sp in mind
20140524 22:19:26< gfgtdf> in teh sense of 'it doesnt prevent the ai from winning'
20140524 22:22:24< gfgtdf> iceiceice: what i mean is: just becasue it it written in the wiki it doesnt mean it is teh intened behaviour
20140524 22:22:31-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has joined #wesnoth-dev
20140524 22:28:43< gfgtdf> iceiceice: hm mabye we shouldnt change it short before 1.12 but i think we realy should think about it for 1.13
20140524 22:29:18< iceiceice> what do you want to change it to?
20140524 22:30:03< iceiceice> imo its best to keep stuff like this in a legacy state
20140524 22:30:14< iceiceice> we already made defeat condition, they shold be able to do literally anythign now
20140524 22:30:33< aquileia> iceiceice: It took me ages to debug my script... when I rebuilt VC I haf to install 5 GB of updates
20140524 22:30:34< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/commit/7836f5edc2013d21090f0b7ddacaed8c370e9a89
20140524 22:30:51< gfgtdf> iceiceice: hm as soon as i see no use for the curent bahaviour i consider this a bug
20140524 22:31:01< iceiceice> aquileia: thats crazy
20140524 22:31:02< gfgtdf> iceiceice: as long
20140524 22:31:06< iceiceice> 5gb of updates to VC?
20140524 22:31:08< iceiceice> how big is VC?
20140524 22:31:13< aquileia> But now it's working and thanks to your showgui tip I found the issue with the extraordinairy timeouts
20140524 22:31:31< aquileia> 8 GB... before
20140524 22:31:34< iceiceice> what was going on?
20140524 22:31:57< aquileia> no idea, it was just labeled as 'Update 2'
20140524 22:32:07< shadowm> iceiceice, gfgtdf : Is 1.11.15 MP and replay-compatible with 1.11.13?
20140524 22:32:07< aquileia> oh, you mean the tests
20140524 22:32:20< gfgtdf> shadowm: ye
20140524 22:32:35< gfgtdf> shadowm: ad lest i didnt cahgne it
20140524 22:32:38< gfgtdf> at least
20140524 22:32:44< gfgtdf> change
20140524 22:32:47< iceiceice> hmm i guess we renamed fight_on
20140524 22:32:49< iceiceice> err
20140524 22:32:54< iceiceice> we removed fight_on
20140524 22:32:59< shadowm> Okay then it isn't.
20140524 22:33:01< iceiceice> and we renamed carry_over_leaders_defeated
20140524 22:33:02< gfgtdf> ah true
20140524 22:33:05< aquileia> iceiceice: the timeout command line option can stall wesnoth while the victory dialogue is shown
20140524 22:33:33< iceiceice> ok
20140524 22:33:43< iceiceice> that's wierd
20140524 22:33:56< shadowm> Remember that you have until RC 1 to break it again (try to avoid doing that though).
20140524 22:33:57< aquileia> removing it fixes all tests but those that should run infinitely
20140524 22:34:14< iceiceice> shadowm: no plans to do so
20140524 22:34:31< shadowm> *only have
20140524 22:34:59< iceiceice> shadowm: imo the only "major" bug left is the thing about start of scenario saves
20140524 22:35:02< iceiceice> i dont think that would require to break save compatibility
20140524 22:35:03< aquileia> oh, and I ran into an assert as well once (probably due to that)
20140524 22:35:30< iceiceice> aquileia: y so the wesnoth --timeout is pretty bad...
20140524 22:35:30< iceiceice> i really struggled to make a good implementation
20140524 22:35:45< shadowm> What happened to fight_on_without_leader, though?
20140524 22:35:54< iceiceice> shadowm: it was subsumed by defeat_condition
20140524 22:35:54< shadowm> Is it still accepted? Are there wmllint conversion rules?
20140524 22:36:08< iceiceice> how do i write wmllint conversion rules?
20140524 22:36:19< shadowm> Sigh.
20140524 22:36:23< aquileia> iceiceice: The problem is that there's no real alternative on Windows, I think
20140524 22:36:28< shadowm> Does that mean it's not accepted anymore?
20140524 22:36:32< iceiceice> nope
20140524 22:36:34-!- travis-ci [~travis-ci@ec2-54-205-52-158.compute-1.amazonaws.com] has joined #wesnoth-dev
20140524 22:36:34< travis-ci> [travis-ci] wesnoth/wesnoth#2774 (master - 0e2e54c : Chris Beck): The build was fixed.
20140524 22:36:34< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/25960614
20140524 22:36:34-!- travis-ci [~travis-ci@ec2-54-205-52-158.compute-1.amazonaws.com] has left #wesnoth-dev []
20140524 22:36:39< shadowm> *grgrgrgrgrg*
20140524 22:36:42< gfgtdf> shadowm: fight_on onyl existed in 1.11.13
20140524 22:36:46< iceiceice> or the other one
20140524 22:36:49< iceiceice> carry_on_removed _leadders
20140524 22:36:54< iceiceice> that one existed since 1.11.7
20140524 22:37:19< shadowm> iceiceice: First you read wmllint to figure out how to add a new rule, then you do it.
20140524 22:37:28< iceiceice> ok
20140524 22:37:34< shadowm> There are like four different mechanisms to do so.
20140524 22:37:46< shadowm> I'm surprised nobody brought this up before.
20140524 22:37:47< iceiceice> i just read the script?
20140524 22:37:55< iceiceice> is there like a wiki page?
20140524 22:37:59< shadowm> No.
20140524 22:38:11< iceiceice> ok well i never thought to read the script
20140524 22:38:54< shadowm> Did it occur to anyone that although the previous version "only" existed in a single (*beta* release), that doesn't mean nobody could have possibly deployed it in production in the meantime?
20140524 22:39:52< shadowm> Do you mind if I attach both your names to the "Incompatibilities with 1.11.13" block? >:)
20140524 22:40:11< shadowm> * and 1.11.14
20140524 22:44:04-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140524 22:48:17< shadowm> I'll take that as a no.
20140524 22:48:50< shadowm> "the [c]remove_from_carryover_on_leaders_loss[/c] attribute introduced in 1.11.13"
20140524 22:48:55< shadowm> You mean 1.11.7?
20140524 22:49:41< iceiceice> iirc it was introduced by thunderstruck in 1.11.7
20140524 22:49:45< iceiceice> but the impl was also bugged, i doubt if people were using it
20140524 22:50:01< shadowm> I read the changelog, the changelog says 1.11.7, but the R_N blurb claims 1.11.13, hence the question.
20140524 22:50:28< iceiceice> fight_on was 1.11.13
20140524 22:50:33< iceiceice> defeat condition replaced that in 1.11.15
20140524 22:50:46< iceiceice> remove_from..._on_leaders_loss was 1.11.7
20140524 22:50:51< iceiceice> reove_from..._on_defeat is 1.11.15
20140524 22:51:41< iceiceice> *actually i dont recall now if the impl was bugged when thunderstruck committed it, but he had a different idea about how it should work, that changed and then at some point it was bugged
20140524 22:51:54< iceiceice> it all currently should be working, i committed like 20 unit tests to check defeat_condition
20140524 22:52:15< iceiceice> and gfgtdf separately tested manually iiuc
20140524 22:54:08< iceiceice> y i guess we should have recognized the old values, didnt think of it...
20140524 22:54:13< iceiceice> anything but the squeaky hammer :O
20140524 22:57:13< shadowm> "The victory check process is simple"
20140524 22:57:31< shadowm> It's at that point that the explanation doesn't belong in the announcement anymore, but rather in the wiki.
20140524 22:58:49< iceiceice> y i actualy was thinking to make a section in scenariowml about that but didnt get around to it
20140524 22:59:28< shadowm> I'll leave it in for now, but it really needs to be in the wiki instead, for anyone who might need to read the explanation at a later time.
20140524 22:59:52< iceiceice> we could just make a wiki page now and put a link to itin the release notes
20140524 23:05:56-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140524 23:09:17-!- gfgtdf [~chatzilla@d222100.adsl.hansenet.de] has quit [Ping timeout: 264 seconds]
20140524 23:10:14-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140524 23:12:14< irker584> wesnoth: Chris Beck wesnoth:master 12fad6efbc5b / data/tools/wmllint: fixup wmllint to include 1.11.15 changes http://git.io/lX7wxQ
20140524 23:12:29< iceiceice> can someone check that that looks right? ^^
20140524 23:13:22< shadowm> Consistency is appreciated in Python-land, even if wmllint itself is about as far from ideal Python as can be.
20140524 23:14:32< shadowm> Although that memo is probably more relevant for whoever added the flag lines.
20140524 23:14:58< shadowm> Your substitution rules are dumb and won't cover variant punctuation.
20140524 23:15:14< shadowm> For example, /fight_on_without_leader=yes/ doesn't match fight_on_without_leader="yes".
20140524 23:15:20-!- Guest87151 [~8680@2002:4404:712c:0:1826:75c0:98b1:2ec5] has quit [Ping timeout: 265 seconds]
20140524 23:15:45< shadowm> In general linechanges is only useful for attribute name changes and other dumb substitutions.
20140524 23:16:02-!- _8680_ [~8680@2002:4404:712c:0:9838:9696:b9b7:a0c1] has joined #wesnoth-dev
20140524 23:18:00< shadowm> You could bloat it further and it'd still not match unusual whitespace layouts (`attribute=                 value` etc.)
20140524 23:23:50< aquileia> iceiceice: I wrote the script, but as it takes considerable time to run it, I'll refrain from adding it to the VC project for now... https://github.com/aquileia/wesnoth/commit/8ac2ecb60b949d3 
20140524 23:24:31< aquileia> It would be nice if someone else with Windows could test it on speed
20140524 23:25:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140524 23:25:45< aquileia> Oh, hi noy
20140524 23:30:08-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140524 23:33:19-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140524 23:38:03-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has quit [Quit: Page closed]
20140524 23:43:47< iceiceice> shadowm: i just mimicked what i saw above
20140524 23:43:51< iceiceice> i dont know python
20140524 23:44:24< iceiceice> las
20140524 23:44:30< ancestral> iceiceice: I didn’t really until I started using it two months ago
20140524 23:44:47< iceiceice> ancestral: i thik i just dont have a motivation to learn it
20140524 23:44:58< shadowm> Here's your motivation: wmllint! ;)
20140524 23:45:00< ancestral> iceiceice: Do you know JavaScript?
20140524 23:45:03< iceiceice> one of my friends from college wasl ike "there's nothing to learn, python is just english"
20140524 23:45:28< shadowm> I've been adding stuff to wmllint since before learning Python, so...
20140524 23:45:32< iceiceice> but actually everything i've ever had to do has been covered by C/C++/java and bash shell scripts
20140524 23:45:41< ancestral> iceiceice: Then it’ll be familiar
20140524 23:46:07< iceiceice> aquileia: i think there is a windows alternative to --timeout
20140524 23:46:17< iceiceice> wesnoth timeout is not very good unfortunately...
20140524 23:46:20-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140524 23:46:28< iceiceice> it is currently implemented with threads but that is not appropriate
20140524 23:46:37< iceiceice> it uses SDL kill thread which unreliable,
20140524 23:46:50< iceiceice> the alternative would be to comb the entire project and insert boost::interruption_point() statements
20140524 23:47:02< iceiceice> but i really have no idea where are all of the appropriate points to do that...
20140524 23:47:10< iceiceice> i dont know what the performance implications are
20140524 23:47:20< iceiceice> i woudl rather have the unit tests run as a black box
20140524 23:47:28< iceiceice> and if it runs over then just bag the whole process
20140524 23:47:37< iceiceice> however there is no cross platform boost process library available to us unfortuantely
20140524 23:47:42< iceiceice> hence, scripts
20140524 23:48:05< iceiceice> the SDL kill thread works like 99% of the time but i have noticed that it gets stuck sometimes, i dont know why...
20140524 23:48:16< iceiceice> i'm pretty sure that strictly speaking it is "undefined behavior"
20140524 23:48:34< iceiceice> but if the thread dies, i'm happy, even if it dies kicking and screaming
20140524 23:48:41< iceiceice> if i have to comb the project for interrupt poit locations,
20140524 23:48:42< iceiceice> and i miss one
20140524 23:48:48< iceiceice> then it wont die
20140524 23:49:48< iceiceice> aquileia: i get various hits on google for "windows timeout process batch file"
20140524 23:49:50< iceiceice> http://stackoverflow.com/questions/10583411/setup-timeout-for-commands-in-windows-bat-file
20140524 23:49:59< iceiceice> http://stackoverflow.com/questions/13515254/how-to-set-a-timeout-for-a-process-under-windows-7
20140524 23:50:04< iceiceice> i'm sure its possible
20140524 23:51:13< iceiceice> tbh it might even be a good idea to deprecate wesnoth --timeout argument unless a better solution comes around,
20140524 23:51:20< iceiceice> i think its okay for users though as long as you aren't running many tests
20140524 23:51:31< iceiceice> idk i'm really undecided about it
20140524 23:54:36-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140524 23:55:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140524 23:58:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140524 23:59:04< iceiceice> idk it should be much easier than this to add attribute name changes to wmllint
20140524 23:59:22< iceiceice> there should just be a list of renamed attributes, if the line changes isnt doing that then wml lint should be consuming white space for me
20140524 23:59:30< iceiceice> isnt this thing totally broken because of lua also?
--- Log closed Sun May 25 00:00:13 2014