--- Log opened Mon May 26 00:00:45 2014
20140526 00:01:23-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 252 seconds]
20140526 00:06:25-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Ping timeout: 276 seconds]
20140526 00:09:07-!- gfgtdf [~chatzilla@f054168225.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140526 00:13:15-!- happygrue_ [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140526 00:14:19-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140526 00:19:34-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 00:24:02-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 245 seconds]
20140526 00:32:19-!- ancestral_ [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140526 00:32:19-!- ancestral_ [~ancestral@12.23.74.29] has quit [Client Quit]
20140526 00:58:44< irker881> wesnoth: Chris Beck wesnoth:master 28c6dbfa2bb4 / src/playturn.cpp: Refactor, since this logic is in MAKE_ENUM now for team:controller http://git.io/60lNEQ
20140526 00:58:46< irker881> wesnoth: Chris Beck wesnoth:master 853768ce8513 / src/playturn.cpp: Merge branch 'refactor_play_turn_to_avoid_string_literals' http://git.io/RYsFHg
20140526 01:03:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 01:15:17-!- trewe [~trewe@2001:8a0:d139:9701:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20140526 01:21:44-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140526 01:24:27-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 245 seconds]
20140526 01:24:33-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140526 01:45:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140526 01:49:25-!- sachith500 [~kvirc@112.134.55.85] has joined #wesnoth-dev
20140526 01:54:37-!- sachith500 [~kvirc@112.134.55.85] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140526 02:07:44-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 02:11:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 02:12:53-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 264 seconds]
20140526 02:13:24< shadowm> mattsc: ... Is there a specific reason you haven't told me that the OS X package is already up?
20140526 02:24:13< mattsc> 20140525 04:46:03< mattsc> shadowm, Ivanovic: 1.11.15 OS X package is up on SF
20140526 02:24:49< shadowm> Huh.
20140526 02:24:57< shadowm> What time zone is that?
20140526 02:25:12< mattsc> Whatever the log says.  UTC, I think.
20140526 02:25:22< mattsc> That was 21 or 22 hours ago.
20140526 02:25:25< shadowm> If it's the wesnoth.org log, yes.
20140526 02:25:31< mattsc> It is
20140526 02:26:26< shadowm> Oh, I missed it due to the portrait syntax stuff.
20140526 02:27:03< mattsc> Yeah, there was a lot of traffic at the time.  I actually waited for a break with posting that, but then things picked up right after it again.
20140526 02:27:39< shadowm> Well, it's only been 24 + <maths < (72 - 24)> hours since the tag, so I'm not too late.
20140526 02:28:00< mattsc> Indeed.  :)
20140526 02:36:51< shadowm> iceiceice: For future reference, "Wesnoth" in announcements should always go capitalized like the proper noun it is.
20140526 02:37:27< shadowm> The only exceptions are when you are referring specifically to the executable image itself (`wesnoth` or `wesnoth.exe`), but this should be rare.
20140526 02:37:42< vultraz> Is the windows package up?
20140526 02:37:45< shadowm> *proper name
20140526 02:37:51< shadowm> It was up before OS X.
20140526 02:38:07< vultraz> k
20140526 02:38:15< vultraz> Need to get out of 1.11.12
20140526 02:40:38< vultraz> bleghh
20140526 02:41:13< shadowm> Too bad that you dropped the part about finalizing syntax for better backwards compatibility _in the future_. Unless I misinterpreted the whole deal and that wasn't you people's goal.
20140526 02:41:55-!- happygrue_ [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140526 02:42:19< shadowm> If it isn't, then you might want to take a look at what this guy's opinion on the matter: http://forums.wesnoth.org/viewtopic.php?f=2&t=40215
20140526 02:42:26< shadowm> s/what//
20140526 02:43:14< shadowm> Sure, having a GUI for wmllint helps to some extent... except that it doesn't make wmllint any less broken for UMC.
20140526 02:58:25-!- shadowm changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 242 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140526 02:58:33< shadowm> Announcement posted.
20140526 03:01:36< shadowm> Since the Issues block formatting made its debut earlier than I expected, perhaps I should take mattsc's OS X issue list and post it now... mattsc?
20140526 03:03:18< mattsc> shadowm: sure - either way is fine by me
20140526 03:09:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 03:19:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 03:22:31< mattsc> Hey All, I’ll have to sign off shortly and will be traveling until Saturday (May 31).  I think I’ll have a bit more time than usual to check the logs this time, but you never know…  At the very least I’ll search them for my nick once or twice a day.
20140526 03:29:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Traveling until May 31]
20140526 03:55:56-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 03:56:52< shadowm> s/backwards compatibility _in the future_/forwards compatibility/
20140526 04:00:33-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140526 04:10:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 04:21:40-!- rjaguar3 [~rjaguar3@dynamic-oit-pu-dormnet-bb-f-55.Princeton.EDU] has joined #wesnoth-dev
20140526 04:37:00-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 04:37:48-!- Guest47335 [~cib@p5DC7514B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140526 04:47:27< irker881> wesnoth: Ignacio R. Morelle wesnoth:1.12 1857760b9541 / RELEASE_NOTES: Purge RELEASE_NOTES http://git.io/Z79mjA
20140526 04:47:30< irker881> wesnoth: Ignacio R. Morelle wesnoth:1.12 2aea091cf8bb / / (7 files in 5 dirs): Merge branch '1.12' of github.com:wesnoth/wesnoth into 1.12 http://git.io/RJso0w
20140526 04:53:38-!- rjaguar3 [~rjaguar3@dynamic-oit-pu-dormnet-bb-f-55.Princeton.EDU] has quit [Quit: Leaving]
20140526 04:55:21-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 243 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140526 05:04:17-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140526 05:08:09-!- Sulfur [~Miranda@p5B0088CE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140526 05:12:10-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140526 05:25:37-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140526 05:30:03-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140526 05:44:04-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 05:48:19-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140526 05:51:13-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140526 05:54:30-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140526 06:04:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140526 06:20:25-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140526 06:22:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 06:24:12-!- vernon [~quassel@77-234-83-36.pool.digikabel.hu] has joined #wesnoth-dev
20140526 06:36:17-!- Guest47335 [~cib@p5DC7514B.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20140526 06:43:40-!- vernon [~quassel@77-234-83-36.pool.digikabel.hu] has quit [Remote host closed the connection]
20140526 06:44:26-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 252 seconds]
20140526 06:46:41-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140526 06:47:29-!- Octalot [~noct@132.53.125.91.dyn.plus.net] has joined #wesnoth-dev
20140526 07:00:59-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140526 07:32:14-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 07:36:41-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140526 07:38:34-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 07:42:30-!- Sulfur [~Miranda@p5B0088CE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140526 07:43:22-!- cib [~cib@132.231.178.150] has joined #wesnoth-dev
20140526 07:43:46-!- cib is now known as Guest16460
20140526 08:04:54-!- Sulfur [~Miranda@p5B0088CE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140526 08:15:41-!- mjs-de [~mjs-de@g228128119.adsl.alicedsl.de] has joined #wesnoth-dev
20140526 09:04:29-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 264 seconds]
20140526 09:13:07-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140526 09:13:42-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 09:14:42-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 09:17:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140526 09:17:49-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140526 09:18:15-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140526 09:24:29-!- sachith500 [~kvirc@112.134.209.104] has joined #wesnoth-dev
20140526 09:25:33< AI0867> hmm: http://forums.wesnoth.org/viewtopic.php?p=570866#p570866
20140526 09:28:32< zookeeper> yeah that's just... great D:
20140526 09:31:07< AI0867> do units really disappear or are they just not shown?
20140526 09:31:22< AI0867> I suspect the latter, but…
20140526 09:32:55-!- sachith500 [~kvirc@112.134.209.104] has quit [Read error: Connection reset by peer]
20140526 09:33:12-!- sachith500 [~kvirc@112.134.209.104] has joined #wesnoth-dev
20140526 09:43:07-!- Necrosporus_ is now known as Necrosporus
20140526 09:57:05-!- sachith500 [~kvirc@112.134.209.104] has quit [Read error: Connection reset by peer]
20140526 09:57:22-!- sachith500 [~kvirc@112.134.209.104] has joined #wesnoth-dev
20140526 10:00:38-!- Guest16460 [~cib@132.231.178.150] has quit [Read error: Connection reset by peer]
20140526 10:12:16-!- sachith500 [~kvirc@112.134.209.104] has quit [Read error: Connection reset by peer]
20140526 10:12:35-!- sachith500 [~kvirc@112.134.209.104] has joined #wesnoth-dev
20140526 10:39:22< Necrosporus> What's the difference between items and terrain graphics?
20140526 10:41:19< zookeeper> you should word your questions better.
20140526 10:44:13< AI0867> Necrosporus: everything?
20140526 10:44:14< Necrosporus> zookeeper, I see pines are placed on map with [item]
20140526 10:44:49< AI0867> I'm getting a hint as to what your thoughts are, but you should still explain more, and ask an actual question
20140526 10:44:53< AI0867> (a specific one)
20140526 10:45:05< Necrosporus> if I want to place an image onto map, what's difference if I use [terrain_graphics] or [item] beside second could be removed
20140526 10:45:19< zookeeper> no difference.
20140526 10:45:25< zookeeper> (assuming both would look the same)
20140526 10:45:28< AI0867> [terrain_graphics] describes how a terrain can be rendered
20140526 10:45:34< Necrosporus> Could I have animated item?
20140526 10:45:43< zookeeper> with halo= yes, otherwise no.
20140526 10:45:46< AI0867> an [item] is an image placed by WML
20140526 10:46:19< zookeeper> AI0867, [terrain_graphics] can be used independent of any terrain, which is presumably what he failed to refer to.
20140526 10:46:47< AI0867> whaaaaaaaa
20140526 10:47:14< Necrosporus> I want to place a permanent object on map
20140526 10:47:33< zookeeper> AI0867, [terrain_graphics] is valid in [scenario], meaning you can use it to place graphics on the map, see core campfires for example
20140526 10:48:25< Necrosporus> Like a lighthouse, mill or flowers but my own. I see I could try to use [item] or terrain graphics (possibly with custom terrains
20140526 10:49:05< zookeeper> AI0867, or a more complicated example would be the SoF:02
20140526 10:49:12< zookeeper> ...gate thing
20140526 10:50:34< zookeeper> it's a rarely used but very neat little feature
20140526 10:50:47< AI0867> zookeeper: it still describes a way to render terrain
20140526 10:50:51< AI0867> just very specific
20140526 10:51:38< Necrosporus> AI0867, if you control both map and code you could edit map to place a terrain pattern if you want to
20140526 10:51:44< zookeeper> AI0867, to render a location, more like. it's just that 99% of the time it's used to render locations which have a given terrain :P
20140526 10:52:17< zookeeper> but you could just as well make a core terrain graphics rule which draws an image at given fixed coordinates regardless of any terrain
20140526 10:52:34< AI0867> Necrosporus: sure, so?
20140526 10:52:56< Necrosporus> So the question is, what way is preferable?
20140526 10:53:20< zookeeper> ok, so let's see
20140526 10:53:24< AI0867> generally, [item], unless it's part of the map itself in some way
20140526 10:54:55< zookeeper> "i want to place a permanent animated tile on the map. is there any particular reason why i should use either [item] or [terrain_graphics] to do so?"
20140526 10:57:06< zookeeper> if that is what you meant to ask, then no, no reasons besides animations or >72x72 images (unless you can use a halo)
20140526 10:57:07-!- Upthorn [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Disconnected by services]
20140526 10:58:29-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140526 11:00:07< Necrosporus> zookeeper, so I can't use >72x72 item?
20140526 11:02:03< Necrosporus> Is there a difference between halo and image beside first is drawn above second?
20140526 11:10:20-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140526 11:12:46-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140526 11:22:25-!- sachith500 [~kvirc@112.134.209.104] has quit [Read error: Connection reset by peer]
20140526 11:31:19< zookeeper> first is drawn above everything
20140526 11:31:57-!- sachith500 [~kvirc@112.134.209.104] has joined #wesnoth-dev
20140526 11:32:34-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140526 11:36:43-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 276 seconds]
20140526 11:52:27-!- Kexoth [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140526 11:53:03-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 11:57:07-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140526 12:09:43-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140526 12:10:08-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140526 12:14:26< zookeeper> AI0867, they only turn invisible
20140526 12:15:05-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20140526 12:15:27< zookeeper> but yeah... that's not exactly a minor bug -.-
20140526 12:17:54-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140526 12:28:47-!- sachith500 [~kvirc@112.134.209.104] has quit [Ping timeout: 246 seconds]
20140526 12:41:29-!- sachith500 [~kvirc@112.135.10.98] has joined #wesnoth-dev
20140526 12:44:59-!- mjs-de [~mjs-de@g228128119.adsl.alicedsl.de] has quit [Ping timeout: 276 seconds]
20140526 12:56:47-!- mjs-de [~mjs-de@f049244162.adsl.alicedsl.de] has joined #wesnoth-dev
20140526 13:05:12-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 13:29:09-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140526 13:38:40-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Leaving]
20140526 13:41:00-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140526 13:49:52< happygrue> vultraz: if it is, it's not linked on the download page it seems
20140526 13:50:54< happygrue> I get 1.11.13 when I try to download, but it does look like it's there: http://sourceforge.net/projects/wesnoth/files/wesnoth/
20140526 13:51:16< happygrue> shadowm: I guess we need the windows download link fixed on the homepage?
20140526 13:52:14< zookeeper> for what it's worth, i successfully downloaded 1.13.15 from the front page a few hours ago
20140526 13:52:26-!- Guest16460 [~cib@132.231.178.37] has joined #wesnoth-dev
20140526 13:52:55< happygrue> zookeeper: can you try again?  and see what file you get?
20140526 13:53:23< zookeeper> the same (or at least the filename is)
20140526 13:53:58< happygrue> It's correct here:  http://wiki.wesnoth.org/Download#Development_.281.11_branch.29
20140526 13:54:11< happygrue> but from the actual homepage if you click "windows" it will take you to 1.11.13
20140526 13:54:47< zookeeper> uh... no :P that's all i can say
20140526 13:55:02< happygrue> hmm
20140526 13:56:07< Necrosporus> Not just windows but all links at mainpage point to 13
20140526 13:56:17< happygrue> cache issue for me I guess
20140526 13:56:19< happygrue> you are right
20140526 13:57:04< Necrosporus> Now it's changed to 15
20140526 13:57:29< happygrue> not sure why, but I had an older version of the homepage, had to shift-reload
20140526 13:58:15-!- gfgtdf [~chatzilla@e177117105.adsl.alicedsl.de] has joined #wesnoth-dev
20140526 13:58:45-!- Guest16460 [~cib@132.231.178.37] has quit [Ping timeout: 258 seconds]
20140526 13:59:41< gfgtdf> does any1 else have teh problem that they cannot open the unit help on master? (invalid_utf8_exception)
20140526 14:02:11< AI0867> gfgtdf: which part of the unit help?
20140526 14:03:10< gfgtdf> AI0867: when i click on any unit in the help i get "corrupted original file" error.
20140526 14:03:18-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140526 14:04:12< gfgtdf> AI0867: sometimes (i dont know how to reproduce) wesnoth also crashes with an uncatched  invalid_utf8_exception.
20140526 14:05:19< AI0867> do you have any add-ons installed?
20140526 14:06:08< gfgtdf> AI0867: yes i have
20140526 14:06:20< gfgtdf> AI0867: should i try without ?
20140526 14:08:09< gfgtdf> AI0867: after renaming the add-ons directory the problem still persists.
20140526 14:11:03< gfgtdf> AI0867: after renaming the 'userdata' directory the problem persists too.
20140526 14:13:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 14:14:00< AI0867> gfgtdf: okay, well, I couldn't reproduce just now, I'm pulling and rebuilding
20140526 14:14:44< zookeeper> i can't but wonder how the AI-units-turning-invisible issue has crept in between betas.
20140526 14:15:04< AI0867> and a find/file/grep command couldn't find any non-ASCII files in core
20140526 14:15:33< AI0867> zookeeper: I'm afraid it's an issue related to what caused 1.11.14 to be discarded
20140526 14:15:56-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140526 14:16:14< gfgtdf> AI0867: hmm git status didn't show me any changes
20140526 14:18:05-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140526 14:18:17-!- Octalot [~noct@132.53.125.91.dyn.plus.net] has quit [Ping timeout: 252 seconds]
20140526 14:18:45-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 14:20:40< AI0867> gfgtdf: still can't reproduce. OS?
20140526 14:20:52< gfgtdf> AI0867: win  64 bit
20140526 14:20:55< gfgtdf> win 7
20140526 14:21:51< AI0867> I suspect that's related
20140526 14:21:55< AI0867> the windows bit, that is
20140526 14:22:03< AI0867> could you get me a backtrace?
20140526 14:23:11-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 255 seconds]
20140526 14:24:22< gfgtdf> AI0867: of teh point when teh exception is thrown ?
20140526 14:24:52< AI0867> yes
20140526 14:26:22-!- Octalot [~noct@132.53.125.91.dyn.plus.net] has joined #wesnoth-dev
20140526 14:28:34-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has joined #wesnoth-dev
20140526 14:31:38< gfgtdf> AI0867: it seems to be related to "alignment"
20140526 14:32:28< AI0867> in master? could you test e8266ba9323e731c58
20140526 14:33:21< aquileia> AI0867, gfgtdf: It might be possible that the utf8 related functions I implemented in https://github.com/wesnoth/wesnoth/commit/52c80db79 are the cause
20140526 14:33:32< gfgtdf> AI0867: i have that commit (also structs have public inheritance by default)
20140526 14:34:26< aquileia> Some of them assume the caller handles thrown exceptions
20140526 14:35:41< AI0867> gfgtdf: what do you mean by "I have that commit"?
20140526 14:36:27< gfgtdf> AI0867: that the commit e8266ba9323e731c58 is on curretn masster and onyl on my local bbranch whch im testing
20140526 14:36:47< gfgtdf> also
20140526 14:36:55< gfgtdf> s/onyl/also
20140526 14:37:43< AI0867> yes, it's an ancestor of master. I meant, can you check out that commit, so you effectively back out some recent commits?
20140526 14:39:12< gfgtdf> AI0867: hm it seems like there is currewntly a problem with prevent me from getting valid stacktraces
20140526 14:39:43< AI0867> aquileia: that's pretty long ago. I suspect it would have been discovered by now
20140526 14:40:18< aquileia> Well, but it's a possibility, s oI wanted to say it just in case
20140526 14:43:45< aquileia> I just double-checked, fortunately all of these are caught. No rubber mallet!
20140526 14:45:23< AI0867> ugh, looks like my previous bugfix broke it: d2f7df568c6fabd1d
20140526 14:52:52< gfgtdf> AI0867: the bug i reported ot another ?
20140526 14:54:47< gfgtdf> AI0867:  maybe teh casue it that https://github.com/wesnoth/wesnoth/blob/master/src/unit_types.hpp#L255 returns a reference to the local 'str'  bu i dont know for sure how gettet works
20140526 15:01:57< gfgtdf> any1 who knows how gettext works: ^
20140526 15:02:49-!- sachith500 [~kvirc@112.135.10.98] has quit [Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/]
20140526 15:08:10-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140526 15:14:20-!- Guest16460 [~cib@p5DD21C4B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140526 15:18:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 15:34:12-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140526 15:37:36< AI0867> gfgtdf: I was referring to the invisible skip AI moves thing
20140526 15:37:43< AI0867> as for what you linked, that code seems correct
20140526 15:38:06< AI0867> er, wait
20140526 15:38:35< AI0867> yes that may indeed be an issue
20140526 15:42:55-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has quit [Quit: Page closed]
20140526 15:43:49-!- Sulfur [~Miranda@p5B0088CE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140526 15:48:25-!- Sulfur [~Miranda@p5B0088CE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140526 15:48:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 15:54:45-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 15:57:20-!- irker881 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140526 15:59:13-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140526 16:02:07-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 16:13:23< AI0867> gfgtdf: well, the function you pointed at takes statically stored c-strings as far as I can see, so no issue there
20140526 16:13:55 * AI0867 notices that he is blind
20140526 16:14:02< AI0867> the strings are stored in a temporary first...
20140526 16:14:09< AI0867> er, local var
20140526 16:18:22< AI0867> iceiceice: ^
20140526 16:18:52< AI0867> iceiceice: also, does unit_type::alignment_description exist in both unit_types.{c,h}pp now?
20140526 16:26:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 16:26:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 16:28:37-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds]
20140526 16:38:51-!- irker846 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140526 16:38:51< irker846> wesnoth: Chris Beck wesnoth:master 861a2bffe641 / src/ (gamestatus.cpp gamestatus.hpp): remove dead code from gamestatus object http://git.io/cWYHHg
20140526 16:41:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140526 16:41:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 16:46:57< Necrosporus> imagine a divine entity plays wesnoth and then reports all the bugs which exist in latest development version in one day
20140526 16:47:05< Necrosporus> Would you be happy about it?
20140526 16:47:33< Necrosporus> I mean all, possibly thousands or more
20140526 16:50:49-!- kex [~kex@89.205.75.19] has quit [Remote host closed the connection]
20140526 16:51:26-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 16:55:21-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 244 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140526 16:55:57-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 252 seconds]
20140526 17:05:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 17:10:11-!- Sulfur [~Miranda@p5B0088CE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140526 17:10:52-!- mjs-de [~mjs-de@f049244162.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140526 17:14:42-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140526 17:15:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140526 17:42:43-!- aquileia [2edf524c@gateway/web/freenode/ip.46.223.82.76] has joined #wesnoth-dev
20140526 17:48:30< aquileia> zookeeper: Looking at DM scenario 21 I can see two possible improvements... objections to implementing Kalenz' statement "We have acquired orcish weapons"?
20140526 17:50:20< zookeeper> i don't understand the question
20140526 17:50:54< aquileia> Kalenz says they will fight with orcish weapons, but it isn't implemented in WML as far as I can see
20140526 17:51:03< zookeeper> oh, right
20140526 17:51:24< zookeeper> what should it change though? attack icons only?
20140526 17:51:34< zookeeper> if so, then sure, sounds like a nice detail to add
20140526 17:51:45< aquileia> icons, weapon names, and possibly tweaking stats
20140526 17:54:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140526 17:54:16< aquileia> an elvish marksman won't get the same damage out of an orcish bow, but we can leave that as is for the sake of simplicity
20140526 17:54:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20140526 17:54:28< zookeeper> frankly, i'd just change the icons... for swords only, i guess? it's not like they'd have any need to switch their bows
20140526 17:55:02< aquileia> arrows are the most important thing, but we can't change them separately
20140526 17:55:11-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 17:55:44< zookeeper> yeah, but they can just stick orcish arrows on the bodies when they're done
20140526 17:55:56< aquileia> but I can just do swords if you prefer so
20140526 17:56:08< aquileia> that is, if I have the time for it
20140526 17:56:13-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20140526 17:56:55< aquileia> zookeeper: Why should they search all arrows they shot and replace them if they can just use orcish ones?
20140526 17:57:04< zookeeper> yeah, everyone but the shaman line has swords so you'd see that detail plenty of times... and the idea is probably as much to leave orcish weapons behind than it is to make the wounds look as if inflicted by orcs
20140526 17:57:23 * zookeeper shrugs
20140526 17:57:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140526 17:57:41< aquileia> I'll just assume their elvish bows shoot orcish arrows
20140526 17:57:57< zookeeper> maybe orcish arrows are too short to be used with elvish bows :P
20140526 17:58:45< aquileia> glue two of them together! Even better, then it'll look more like the typical orcish miss ratio ;)
20140526 17:59:25-!- kex [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds]
20140526 17:59:30< zookeeper> sure, sure... :p
20140526 18:02:13< irker846> wesnoth: Chris Beck wesnoth:master 793cbaf47974 / src/ (17 files in 5 dirs): Refactor to make campaign_type an enum http://git.io/D6JEgg
20140526 18:06:07-!- iceiceice_ [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140526 18:06:11< iceiceice_> hi
20140526 18:06:12< iceiceice_> did i break something?
20140526 18:06:15< iceiceice_> i just saw logs
20140526 18:07:51< iceiceice_> here was befroe my commit:
20140526 18:07:51< iceiceice_> https://github.com/wesnoth/wesnoth/blob/a723d5fa59dae3742c0bf9b94bcaa8dd0f08ff6b/src/unit_types.cpp#L844
20140526 18:08:05< iceiceice_> here was after my commit
20140526 18:08:06< iceiceice_> https://github.com/wesnoth/wesnoth/blob/master/src/unit_types.hpp#L255
20140526 18:08:33< iceiceice_> AI0867: no i commented out the vresion in .cpp
20140526 18:08:51< iceiceice_> https://github.com/wesnoth/wesnoth/blob/master/src/unit_types.cpp#L825
20140526 18:13:55< gfgtdf> iceiceice_: sgettext might returns his arguemt in this case alignment_description returns a reference to a local variable
20140526 18:14:11< gfgtdf> iceiceice_: i think we should alignment_description make return a std::string
20140526 18:14:24< iceiceice_> ok
20140526 18:14:55< iceiceice_> let me try to compile that
20140526 18:14:55-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Quit: leaving]
20140526 18:15:14-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140526 18:15:48< gfgtdf> iceiceice_: you'll have to change it here too mhttps://github.com/wesnoth/wesnoth/blob/684d1c35c64e9317e331f3860aeb0fb98088ac28/src/reports.cpp#L350
20140526 18:16:25< iceiceice_> y good catch
20140526 18:16:33< iceiceice_> i think thats maybe the only other place?
20140526 18:16:34< Soliton> seems like a bad deal to exchange the nice static const string against a dynamically allocated std::string.
20140526 18:16:37< iceiceice_> idk where else its used except in the gui
20140526 18:17:11< iceiceice_> Soliton: its sort of dynamically allocated anyways, no?
20140526 18:17:14< iceiceice_> because of the gettext
20140526 18:17:36< iceiceice_> sgettext means it will have to look it up in the po file i think
20140526 18:18:07< Soliton> as gfgtdf already mentioned the input pointer may be returned.
20140526 18:18:28< iceiceice_> no, it will always go thrugh gettext
20140526 18:19:05< Soliton> "The translation of the string msgid is returned if it is available in the current domain. If it is not available, the argument itself is returned."
20140526 18:19:31< iceiceice_> ok but its not like the compiler will see through the gettext library
20140526 18:19:48< Soliton> no idea why it needs to.
20140526 18:19:49< iceiceice_> what do you achieve by making it const char *?
20140526 18:20:00< Necrosporus> Wesnoth 1.11.15 seem to be slow when moving unit clears shroud
20140526 18:20:04< iceiceice_> look in getttext.cpp
20140526 18:20:19< Necrosporus> Movement animation is not smooth
20140526 18:20:22< gfgtdf> i think most functions convert the retrun value into a string anyway and i believe in Return value optimization.
20140526 18:20:32< gfgtdf> Necrosporus: did you see teh same behaviour in 1.11.13 ?
20140526 18:20:39< iceiceice_> you will always run gettext on the char *
20140526 18:20:41< iceiceice_> that is opaque to the compiler
20140526 18:20:44< Necrosporus> I didn't test 1.11.13
20140526 18:21:12< Soliton> i still don't see how that's relevant to how the string is allocated.
20140526 18:21:41-!- kex [~kex@89.205.75.19] has joined #wesnoth-dev
20140526 18:22:11< Soliton> if the return value is always used as a std::string then it doesn't change much indeed.
20140526 18:22:29< Necrosporus> gfgtdf, do I need to test with a specific commit?
20140526 18:22:58< Soliton> i wonder if that is the case with all uses of those new enum macros or why it's useful to use std::strings there.
20140526 18:23:34< iceiceice_> there are a couple of ways to use the enum macros,
20140526 18:23:51< iceiceice_> if you use "enumname_to_string" then that will indeed expand to an if else block
20140526 18:23:53< iceiceice_> with string constants
20140526 18:24:13< iceiceice_> if you use lexical cast, it will get string stream involved at some point and therefore be slower...
20140526 18:24:15< iceiceice_> but i find the syntax more convenient
20140526 18:24:21< iceiceice_> esp. wiht lexical cast default
20140526 18:24:45< iceiceice_> the advanatge of lexical cast also is that there is some built in error reporting to the streaming ops
20140526 18:24:51< iceiceice_> if you try to convert a string to enum, and the value is not legal,
20140526 18:25:05< iceiceice_> a twml_exception (transient gui warning) will throw, if you are runing in game_config::debug==true
20140526 18:26:17< iceiceice_> so lexical cast default is a no throw way to get error reporting that we want for free with all of these enums
20140526 18:26:17< iceiceice_> when you are converting the enum to a string,
20140526 18:26:17< iceiceice_> then there should be no conversion issue
20140526 18:26:20< iceiceice_> unless the enum got corrupted somehow 
20140526 18:26:53< iceiceice_> so you dont need to use the lexical cast but i have been doing it anyway
20140526 18:26:53< Soliton> i see, that sounds good.
20140526 18:28:54< Soliton> then i agree just making the return type std::string is a good way to go.
20140526 18:29:12< iceiceice_> ok cool :)
20140526 18:30:26< iceiceice_> gfgtdf: the change to std::string compile,d i am testing now
20140526 18:35:38< irker846> wesnoth: Chris Beck wesnoth:master 0656e93134b7 / src/ (reports.cpp unit_types.hpp): fixup alignment_type function (returns const std::string now) http://git.io/VoXxbw
20140526 18:36:49< iceiceice_> shoot i hate when i make typos in commit messages :(
20140526 18:38:57-!- travis-ci [~travis-ci@ec2-54-227-86-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20140526 18:38:57< travis-ci> [travis-ci] wesnoth/wesnoth#2798 (master - 793cbaf : Chris Beck): The build was broken.
20140526 18:38:57< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26066928
20140526 18:38:57-!- travis-ci [~travis-ci@ec2-54-227-86-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20140526 19:00:20-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Ping timeout: 252 seconds]
20140526 19:00:37-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20140526 19:00:40-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Ping timeout: 276 seconds]
20140526 19:00:49-!- irker846 [~irker@fehu.ai0867.net] has quit [Ping timeout: 258 seconds]
20140526 19:02:01< Necrosporus> Inspect should really show events
20140526 19:02:05-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140526 19:02:31-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20140526 19:02:42-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20140526 19:02:42-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140526 19:04:27-!- Guest16460 [~cib@p5DD21C4B.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20140526 19:04:46-!- irker669 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140526 19:04:46< irker669> wesnoth: Chris Beck wesnoth:master cec797bcb4cd / .travis.yml: travis now takes 15 seconds to timeout a test rather than 10 http://git.io/mDjiUg
20140526 19:06:33-!- stikonas_ is now known as stikonas
20140526 19:12:30< gfgtdf> Necrosporus: inspect currently doesn't show events. You can still save the game and then inspect  the savegame file in an editor (you can disable the savegame compression in the advancesd options). 
20140526 19:14:21< Necrosporus> I know I can but it's not quite comfortable
20140526 19:15:10< iceiceice_> its not a bad idea to have it show events
20140526 19:15:20< iceiceice_> the thing is inspect dialog is not very good at showing lots of wml anyways
20140526 19:15:21< iceiceice_> its better for variables
20140526 19:15:28< gfgtdf> Necrosporus: since :inspect doesnt allow such things as textsearch i think that more confortable than :inspect if you have verymuch events.
20140526 19:15:59< iceiceice_> it woudl be nice if it could show you a panel of events, and then give you a copy button
20140526 19:16:02-!- travis-ci [~travis-ci@ec2-54-83-250-234.compute-1.amazonaws.com] has joined #wesnoth-dev
20140526 19:16:02< travis-ci> [travis-ci] wesnoth/wesnoth#2799 (master - 0656e93 : Chris Beck): The build was broken.
20140526 19:16:02< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26068881
20140526 19:16:02-!- travis-ci [~travis-ci@ec2-54-83-250-234.compute-1.amazonaws.com] has left #wesnoth-dev []
20140526 19:16:53< iceiceice_> does anyone know wtf error code 200 is?
20140526 19:16:59< iceiceice_> or why our test executable would returnt hat?
20140526 19:17:01< gfgtdf> iceiceice_: no i dont
20140526 19:17:03< iceiceice_> it did this before as well
20140526 19:17:21< iceiceice_> i am thinking to wrap the test executable in a script that rerruns if it it gives 200
20140526 19:17:22< iceiceice_> and doesnt tell travis
20140526 19:17:32< iceiceice_> maybe like 10 times or smth
20140526 19:20:37< Necrosporus> I can't understand why doesnt' my event do anything
20140526 19:32:58< aquileia> iceiceice_: Could you mean https://github.com/wesnoth/wesnoth/blob/master/src/multiplayer_error_codes.hpp#L31 ?
20140526 19:33:13< aquileia> I don't know what you're testing
20140526 19:33:25< iceiceice_> travis ran one of my buidls,
20140526 19:33:31< iceiceice_> and it failed because, the ./test executable
20140526 19:33:33< iceiceice_> generated no output
20140526 19:33:36< iceiceice_> and returnd exit code 200
20140526 19:33:49< iceiceice_> usually the test script will say "running 140 tests..." when it begins
20140526 19:33:51< aquileia> did you add MP tests by now?
20140526 19:33:53< iceiceice_> no
20140526 19:34:08< iceiceice_> i think it means the worker failed to start the test process
20140526 19:34:08< aquileia> that's indeed weird
20140526 19:34:19< iceiceice_> but i cant find any documentation on what error code 200 is
20140526 19:34:20< iceiceice_> but this happened once before
20140526 19:36:56< iceiceice_> idk we'll keep ubilding,
20140526 19:37:08< iceiceice_> if it turns out its a transient fault like i think then im going to add a 200 wrapper
20140526 19:37:39-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 252 seconds]
20140526 19:39:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 19:41:27-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140526 19:41:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20140526 19:41:56-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140526 19:52:58-!- travis-ci [~travis-ci@ec2-54-83-250-234.compute-1.amazonaws.com] has joined #wesnoth-dev
20140526 19:52:58< travis-ci> [travis-ci] wesnoth/wesnoth#2801 (master - cec797b : Chris Beck): The build was broken.
20140526 19:52:58< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26070986
20140526 19:52:58-!- travis-ci [~travis-ci@ec2-54-83-250-234.compute-1.amazonaws.com] has left #wesnoth-dev []
20140526 19:57:59< gfgtdf> iceiceice_: whats reason for d734b09d187d9856517463edaacb4c29c628e6fa ?
20140526 19:59:13< iceiceice_> i wrote "now its a const std::string" in the previous commit message
20140526 19:59:28< iceiceice_> so i just wanted to make that accurate
20140526 19:59:31< iceiceice_> do you think it shuldnt be const?
20140526 19:59:58< gfgtdf> iceiceice_: no i dont think returning a const non-reference makes sense.
20140526 20:00:31< iceiceice_> alright, i'll make remove the const from the function call, or you can
20140526 20:01:01< Necrosporus> what should happen when you use [base_unit] and define animations?
20140526 20:03:18-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 258 seconds]
20140526 20:04:29< Necrosporus> or they should merge?
20140526 20:05:19-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140526 20:05:51< irker669> wesnoth: Chris Beck wesnoth:master 96d616eb4d7d / .travis.yml test_wrapper.sh: travis reruns ./test in case of error code 200, 10 times max http://git.io/W_OTLA
20140526 20:08:28-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140526 20:09:28< aquileia> zookeeper: retrieving member of non-existent WML container, this_unit.attack[0].damage
20140526 20:09:44< aquileia> Could you tell me which part is incorrect?
20140526 20:10:50< aquileia> I'm trying to give stronger units orcish greatswords, but I need the damage for that
20140526 20:12:05< Necrosporus> aquileia, does it retrieve the damage nevertheless?
20140526 20:12:20< Necrosporus> also where do you use it, in SUF or event?
20140526 20:12:47< Necrosporus> I mean, filter or action?
20140526 20:13:04< aquileia> It currently doesn't work, and it's in a [filter_condition]
20140526 20:13:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 20:13:33< Necrosporus> maybe you need just $unit?
20140526 20:14:20< Necrosporus>  this_unit: inside a standard unit filter, this is the unit currently being considered for a possible match
20140526 20:14:33< Necrosporus> So $this_unit is only valid in SUF
20140526 20:15:11< aquileia> But [filter_condition] should be part of a SUF, or not?
20140526 20:15:17< Necrosporus> no
20140526 20:15:50< zookeeper> aquileia, those are commonly harmless errors
20140526 20:16:07< zookeeper> i don't know where they originate
20140526 20:16:21< Necrosporus> gfgtdf said he knows but doesn't know how to fix
20140526 20:16:37< Necrosporus> something about whiteboard
20140526 20:16:57< zookeeper> aquileia, i can't say anything more without seeing the code
20140526 20:17:03< gfgtdf> Necrosporus: that was about your error but this_unti inside a filter_condition was never supported i think
20140526 20:17:04< aquileia> So I should just drop that feature and give everyone but Elvish Champions standard orcish swords?
20140526 20:17:21< Necrosporus> aquileia, you didn't show the code
20140526 20:17:30< Necrosporus> What are you trying to filter?
20140526 20:17:33< aquileia> I'm pasting it right now
20140526 20:18:20< Necrosporus> aquileia, [filter_condition] ...  is same as [if] ... [then] rest of event [/then] [/if]
20140526 20:18:31< aquileia> http://pastebin.com/HSBDGUpS
20140526 20:18:31< Necrosporus> if I understand it correctly
20140526 20:18:45< Necrosporus> So you could use [have_unit] and so on
20140526 20:18:47< Necrosporus> with SUF
20140526 20:18:53< Necrosporus> but not SUF directly
20140526 20:19:31< aquileia> Necrosporus: I'm trying to add an [effect] to units with sword damage > 7
20140526 20:19:57< zookeeper> there's no [filter_condition] in [effect]
20140526 20:20:41< Necrosporus> though you have [filter]
20140526 20:20:59-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20140526 20:21:34< Necrosporus> aquileia, use [filter] [filter_wml] and $this_unit ...
20140526 20:22:06< zookeeper> i'd say just use two [effect]s, [filter]ing both for the right unit types and not trying to check the damage directly
20140526 20:22:31< gfgtdf> aquileia: nah better use [filter] formula= :p
20140526 20:23:01< Necrosporus> Won't my suggestion work too?
20140526 20:23:15< gfgtdf> Necrosporus: idk but i liek formula= in filters
20140526 20:23:18< gfgtdf> like
20140526 20:23:32< Necrosporus> I do not know how to use it
20140526 20:24:27< zookeeper> doing it based on damage just makes the code harder to comprehend. the sword type depends on unit type after all, not damage.
20140526 20:24:50< aquileia> ok, I'll do it with type...
20140526 20:24:53< zookeeper> well, assuming you wanted to map elvish greatswords to orcish ones, i dunno.
20140526 20:24:57< gfgtdf> [filter] formula= "size(filter(attacks, range = 'melee' and type = 'blade' and damage > 7)) > 0" [filter]
20140526 20:25:32< Necrosporus> zookeeper, there's has_weapon
20140526 20:25:47< zookeeper> sure, that'd work too
20140526 20:26:09< zookeeper> well, actually it won't
20140526 20:27:00< aquileia> zookeeper: There's only one elvish greatsword wielder, but I'd prefer to dole them out to heroes, marshals and avengers as well
20140526 20:27:26< Necrosporus> maybe filter by level2?
20140526 20:27:32< zookeeper> aquileia, yeah, makes sense i guess. i'd still do it by unit type myself :J
20140526 20:27:53< Necrosporus> or you don't want to give it to rangers?
20140526 20:28:09< aquileia> rangers are weak ;)
20140526 20:28:13-!- iceiceice_ [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has quit [Ping timeout: 240 seconds]
20140526 20:28:18< Necrosporus> Then probably unit type
20140526 20:28:33< Necrosporus> your conditions are more complex than that
20140526 20:28:41-!- stikonas_ is now known as stikonas
20140526 20:29:40-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140526 20:30:02< iceiceice> gfgtdf: i'm going to push the remove of const
20140526 20:30:08< iceiceice> since it looks like builds are stable now
20140526 20:32:41< Necrosporus> Why does SUF not have a [filter_attack] but only has_weapon?
20140526 20:33:19< gfgtdf> Necrosporus: becasue noone has implemnted it yet, 
20140526 20:33:50< gfgtdf> Necrosporus: its not like there is a reason against it i tthink
20140526 20:34:11< gfgtdf> Necrosporus: well except that one can most likley can get teh same with formula= in filters
20140526 20:34:40< Necrosporus> but then you actually don't need anything else than formula at all
20140526 20:34:51< aquileia> I'm an idiot... I forgot the "set_" and therefore filtered instead of changing the units!
20140526 20:34:57< Necrosporus> I guess you could use formula= to filter any criterion
20140526 20:35:14< gfgtdf> Necrosporus: im not a formula expert so idk
20140526 20:37:49< irker669> wesnoth: Chris Beck wesnoth:master a28ca002af7e / src/unit_types.hpp: remove const from alignment_description return type http://git.io/JQ5L2Q
20140526 20:40:31< shadowm> happygrue: What's wrong with it?
20140526 20:41:09< shadowm>   <li><a href="http://sourceforge.net/projects/wesnoth/files/wesnoth/wesnoth-1.11.15/wesnoth-1.11.15-win32.exe/download">Windows</a> (357.2MB)</li>
20140526 20:41:36< shadowm> "Your download will start in 5 seconds..." It works for me?
20140526 20:50:48< Necrosporus> shadowm, I guess it was said before the link was replaced
20140526 20:51:29< shadowm> My cached version from right after publishing the announcement also contained a working link and none of the other admins were awake at that time.
20140526 20:53:04-!- Samual_ [~dioteckte@xonotic/core-team/Samual] has joined #wesnoth-dev
20140526 20:53:17< Necrosporus> shadowm, I don't know. It was link to 1.13 for me too
20140526 20:54:40-!- Samual [~dioteckte@xonotic/core-team/Samual] has quit [Ping timeout: 258 seconds]
20140526 20:55:04< shadowm> You kind of need to use F5.
20140526 20:58:57< happygrue> shadowm: nothing, as indicated just after that it was my fault for not updating my cache
20140526 20:59:24< happygrue> I should have checked it first, sorry!
20140526 21:00:15-!- gfgtdf [~chatzilla@e177117105.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20140526 21:00:33< shadowm> I need to get index.html's cache policy set and that's as good a reminder as any.
20140526 21:01:59< happygrue> er, right.  That's what I've been saying all along!  ;)
20140526 21:06:13< irker669> wesnoth: gfgtdf wesnoth:master 830eb0c1233a / src/ (playmp_controller.cpp whiteboard/manager.cpp whiteboard/manager.hpp): remove whiteboard continue_execute_all http://git.io/0caY2w
20140526 21:12:15-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140526 21:18:44-!- gfgtdf [~chatzilla@f054137115.adsl.alicedsl.de] has joined #wesnoth-dev
20140526 21:19:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 21:20:28< gfgtdf> wesbot:seen mordante
20140526 21:20:32< gfgtdf> wesbot: seen mordante
20140526 21:20:33< wesbot> gfgtdf: The person with the nick mordante last spoke 1d 9h ago.  1d 9h ago was here and on the channel #wesnoth-de with the message: Quit: Leaving
20140526 21:21:50< gfgtdf> iceiceice: do you knwo why we have diferent LINGER_MP and LINGER_SP in https://github.com/wesnoth/wesnoth/blob/master/src/game_display.hpp#L280 ?
20140526 21:22:57< iceiceice> i dont know
20140526 21:23:04< iceiceice> it sounds like there were irc discussions about making them different
20140526 21:23:05< gfgtdf> iceiceice: i cannot se any soce that uses it in teh commit that introduces it: b7c86f8088950e2db88312b1cdeaa4489abb90c9
20140526 21:23:17< iceiceice> if it wont change the behavior i would suggest to delete
20140526 21:23:27< iceiceice> i also deleted a simialr thing you pointed out,
20140526 21:23:30< iceiceice> in gamestatus.hpp
20140526 21:23:33< iceiceice> the history field
20140526 21:24:03< iceiceice> the proper workflow is, if someone makes a feature do it in a sequence of functional commits...
20140526 21:24:10< iceiceice> its goofy to have like, commit a bunch fo deadcode ...
20140526 21:24:13< iceiceice> then wait 6 months
20140526 21:24:17< iceiceice> and maybe do the feature if you get around to it
20140526 21:24:23< iceiceice> that is not maintainable
20140526 21:24:28< iceiceice> so if you see deadcode i think you should remove it
20140526 21:25:02< iceiceice> most likely both examples predate our use of git anyways i guess
20140526 21:26:21< iceiceice> hmm i gues in this case it was functional
20140526 21:26:26< iceiceice> but someone removed the difference?
20140526 21:27:36< gfgtdf> which difference ?
20140526 21:27:50< iceiceice> idk the commit message claims that the map is slightly darker for linger mp
20140526 21:27:51< iceiceice> or something
20140526 21:27:53< gfgtdf> iceiceice: also: do you think there is a situation where it kes sense to ahve time limits in sp ?
20140526 21:28:12< gfgtdf> iceiceice: ye that was a change normal mode <-> linger map
20140526 21:28:15< iceiceice> gfgtdf: maybe idk
20140526 21:28:46< iceiceice> i dont see that having the option can hurt
20140526 21:28:55< iceiceice> maybe for some puzzle mode or something
20140526 21:29:04< iceiceice> wesnoth hex tetris :)
20140526 21:35:56< aquileia> iceiceice: Do you still have your checkout of my fork? Else I'll make a pull request
20140526 21:36:19< iceiceice> its easy to restore but PR is preferabel
20140526 21:36:36< iceiceice> if i do it locally though i will run the tests before pushing
20140526 21:36:46< aquileia> zookeeper: Can we call it a bug fix and put it in 1.12? =P
20140526 21:37:31< aquileia> iceiceice: It's only a change to a scenario
20140526 21:37:38< aquileia> no feature
20140526 21:37:47< gfgtdf> aquileia: which scenario ?
20140526 21:38:07< aquileia> Delfadors Memoirs, scenario 21, clash at the manor
20140526 21:38:11< aquileia> https://github.com/aquileia/wesnoth/commit/9b51a3a877ad51dc
20140526 21:38:43< aquileia> It only changes the displayed weapons for your units to orcish ones
20140526 21:39:51< irker669> wesnoth: Chris Beck wesnoth:master f4fa57f09f6a / .gitignore: add "do_build_and_tests.sh" to .gitignore http://git.io/MiSUNg
20140526 21:39:52< gfgtdf> aquileia: _"greatsword" is a known string from wesnoth ?
20140526 21:39:53< irker669> wesnoth: Chris Beck wesnoth:master f11b7ac6e72b / src/ (playmp_controller.cpp whiteboard/manager.cpp whiteboard/manager.hpp): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/kO6FGg
20140526 21:39:56< aquileia> iceiceice: of course I can do a PR if you prefer
20140526 21:40:17< aquileia> gfgtdf: It was translated to Krummschwert, so... yes
20140526 21:40:42< iceiceice> aquileia: its fine, whatever you prefer
20140526 21:40:52< gfgtdf> ok, i see no reason against then.
20140526 21:41:50< aquileia> iceiceice: If we put it in 1.12 as well, we'll have to do that manually in any case, right?
20140526 21:42:05< iceiceice> y
20140526 21:42:10< iceiceice> *yes
20140526 21:42:52< aquileia> iceiceice: Then could you cherry-pick it to both at once? It seems the cleaner solution
20140526 21:43:16< iceiceice> y thats true
20140526 21:43:21< aquileia> iceiceice: Sorry that I use you as my personal committer...
20140526 21:43:54< iceiceice> oh i actually already ahve your remote
20140526 21:44:12< iceiceice> what branch is in question?
20140526 21:44:23< aquileia> DM_fix
20140526 21:44:47< iceiceice> ok building and testing
20140526 21:45:07< zookeeper> aquileia, eh, that's such a very minor thing that i'd rather not take the exceedingly small risk that it'll screw something up
20140526 21:46:48< aquileia> But what could go wrong? I tested all three parts (Kalenz, recalling, recruiting) and that it'll be reset for the next scenario
20140526 21:51:35< aquileia> zookeeper: However, I got a warning "Unknown attribute 'previous_recruits' discarded." which appears on master
20140526 21:58:22< zookeeper> aquileia, well there's no matches for "previous_recruits" in data/campaigns/
20140526 21:58:39< zookeeper> so that must be coming from an add-on, if it's coming from WML at all
20140526 21:58:58< zookeeper> (neither in core/macros/)
20140526 21:59:24< aquileia> It's in src/gamestatus.cpp
20140526 21:59:52< aquileia> but I'm not totally up to date, so it might have been fixed the last week
20140526 22:07:20< iceiceice> ok sry i'm back
20140526 22:07:24< iceiceice> what am i suppsoed to do /
20140526 22:07:27< iceiceice> merge to master?
20140526 22:08:35< iceiceice> aquileia, zookeeper: i think previous_recruits was introduced to help the multiplayer_connect_engine, by the looks of the grep results
20140526 22:09:03< iceiceice> or more precisely hte flg_manager perhaps...
20140526 22:10:52< zookeeper> i wouldn't know anything about it
20140526 22:11:46< gfgtdf> iceiceice: what the reason for this line: https://github.com/wesnoth/wesnoth/blob/master/src/playmp_controller.cpp#L279 (i think you wrote it) ?
20140526 22:11:59< iceiceice> i dont think i did
20140526 22:12:03< iceiceice> i will run git blame
20140526 22:12:33< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/commit/3f4879ace449998d41469a638799e1e3fefaaccc
20140526 22:12:50< iceiceice> ok
20140526 22:12:55< iceiceice> the idle loop is a function i intrdouced
20140526 22:13:02< iceiceice> it is supposed to mimic the human loop
20140526 22:13:11< iceiceice> in many ways
20140526 22:13:31< gfgtdf> iceiceice: but you know why it is there ?
20140526 22:13:44< iceiceice> its there because it was in the human loop function just above
20140526 22:13:51< iceiceice> and id dint want to change idle from human excpet in a few ways
20140526 22:13:53< iceiceice> i dont know its purpose
20140526 22:13:59< gfgtdf> iceiceice: i think it's from teh old rng which was removed i'll remove it
20140526 22:14:06< iceiceice> if you want to rmeove also remove this i think: https://github.com/wesnoth/wesnoth/blob/master/src/playmp_controller.cpp#L181
20140526 22:17:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140526 22:17:09< irker669> wesnoth: gfgtdf wesnoth:master 022f78a3ae92 / src/playmp_controller.cpp: remove command_disabled_resetter http://git.io/eiHluw
20140526 22:17:33< aquileia> hmm... so I run a fresh build, and I get http://pastebin.com/wdHNYN8G
20140526 22:18:17< iceiceice> what compiler are you using?
20140526 22:18:28< aquileia> Visual C++
20140526 22:19:12< aquileia> I wnared to use clang, but it doesn't recognize most Windows specific flags
20140526 22:19:15< iceiceice> ok
20140526 22:19:21< iceiceice> gfgtdf: i'm going to add the thing from the other day
20140526 22:19:29< iceiceice> return a string after the assert(False)
20140526 22:19:39< iceiceice> i guess some compilers don't recognize assert(false) as ending the function
20140526 22:19:43< gfgtdf> ye thats good
20140526 22:19:56< gfgtdf> iceiceice: we asser false isnt guaranteed to end te function
20140526 22:20:09< gfgtdf> iceiceice: first if NDEBUG is defeined assert is ignored
20140526 22:20:19< iceiceice> hmm i didnt know that
20140526 22:20:30< gfgtdf> iceiceice: second user can still ckicl "ignore" in the assertion faile pupuo
20140526 22:20:33< gfgtdf> ckick
20140526 22:20:39< gfgtdf> pop-up
20140526 22:20:46< iceiceice> i think thats only on windows
20140526 22:21:01< iceiceice> i guess i will throw "42"
20140526 22:21:08< aquileia> nice
20140526 22:21:32< iceiceice> that's what we do here: https://github.com/wesnoth/wesnoth/blob/master/src/wml_exception.hpp#L73
20140526 22:21:38< iceiceice> i assume that is shadowm's doing 
20140526 22:21:46-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140526 22:21:56< iceiceice> idk if that stuff makes the compiler search for "catch 42" blocks? but at least if all the throws like that are the same it might be faster :)
20140526 22:21:58< gfgtdf> iceiceice: hm maybe idk how it is on other os, on windows i'll get a pop-up giving me the options "terminate" "ignore" "attach debugger"
20140526 22:24:07< iceiceice> aquileia: 
20140526 22:24:13< iceiceice> i forgot that iw as on your branch when i made this commit :/
20140526 22:24:19< iceiceice> but anyways now they are both merged to master locally
20140526 22:24:26< iceiceice> shoudl i push this?
20140526 22:25:01< iceiceice> hmm actually i'm just going to reset
20140526 22:25:41< aquileia> I think cherry-picking both would be the easiest solution
20140526 22:25:48< aquileia> But it's your choice
20140526 22:27:08< iceiceice> ok i'm going to push the compilation fix first
20140526 22:27:27< iceiceice> it takes a long time to compile anyways
20140526 22:31:26< iceiceice> alternatively, you could make a pull request.. it will liekly take about half an hour to full rebuild when i change a header like that
20140526 22:31:40< iceiceice> but maybe you want to compile locally before we merg idk
20140526 22:32:34< aquileia> Well, you'd have to push your fix to my fork if I should test it
20140526 22:32:49< aquileia> Or tell me where to get it from
20140526 22:34:05-!- Octalot [~noct@132.53.125.91.dyn.plus.net] has quit []
20140526 22:34:27< iceiceice> ok there's two ways we could do this
20140526 22:34:34< iceiceice> one is, we wait for me to finish compiling master
20140526 22:34:46< iceiceice> then, i merge your branch locally to my master
20140526 22:34:48< iceiceice> but push to my fork
20140526 22:34:51< iceiceice> and you can pull that compile and test
20140526 22:35:03< iceiceice> and then i will push to wesnoth master if it goes well
20140526 22:35:07< iceiceice> or,
20140526 22:35:11< iceiceice> i can push my fix to master
20140526 22:35:24< iceiceice> and you can pull master and merge and test?
20140526 22:35:39< gfgtdf> iceiceice: do you knwo whay turn_info (playturn.cpp) has a field curretn turn ?
20140526 22:35:42< gfgtdf> why
20140526 22:35:59< gfgtdf> i think we had this issure just yesterday
20140526 22:36:42< aquileia> iceiceice: you could also push the fix to my fork, you have commit access, then I could start compiling before you push to master
20140526 22:37:01< iceiceice> i remember we discussed why init_side takes an argument and doesnt just figure out for itself what the current side is
20140526 22:37:14< gfgtdf> iceiceice: ye this is a similar issue
20140526 22:37:21< gfgtdf> iceiceice: i'd like to remove that field
20140526 22:37:36< iceiceice> i wonder if someone was attempting to make the project more object oriented?
20140526 22:37:41< iceiceice> and reduce the use of resources:: ?
20140526 22:37:43< aquileia> but I'm sure throwing 42 is fine
20140526 22:38:10< iceiceice> aquleia: i dont think i can pull from your fork
20140526 22:38:15< iceiceice> *push to your fork
20140526 22:38:15< gfgtdf> aquileia: can you show me teh commit taht you talk about ?
20140526 22:38:25< iceiceice> i think you could pull from mine
20140526 22:38:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20140526 22:39:10< aquileia> gfgtdf: no, I don't have it
20140526 22:39:37< gfgtdf> aquileia: ok i thin i misunderstood then
20140526 22:39:40< gfgtdf> think
20140526 22:40:49< aquileia> iceiceice: Which branch to pull from?
20140526 22:41:01< irker669> wesnoth: Chris Beck wesnoth:master 694a2c4fd112 / src/make_enum.hpp: for some compilers, assert != terminate... fixup make_enum http://git.io/jLK5sA
20140526 22:41:02< iceiceice> just a sec
20140526 22:41:03< irker669> wesnoth: Chris Beck wesnoth:master f4708f52366b / src/playmp_controller.cpp: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/_a-31Q
20140526 22:41:19< aquileia> ok, master
20140526 22:41:29< iceiceice> y
20140526 22:41:34-!- mjs-de [~mjs-de@f049244162.adsl.alicedsl.de] has joined #wesnoth-dev
20140526 22:41:34< iceiceice> now i have pushed your change
20140526 22:42:10< irker669> wesnoth: gfgtdf wesnoth:master 8282b1b0d677 / src/playturn.hpp: add turn_info_send class http://git.io/ltwqaQ
20140526 22:43:00< iceiceice> well th etests pass... so that means your change didn't horribly corrupt the WML {core} tree somehow :)
20140526 22:44:28< irker669> wesnoth: gfgtdf wesnoth:master 12f117400c5f / src/playmp_controller.cpp: use turn_info_send in play_human_turn http://git.io/rRm92w
20140526 22:45:53< iceiceice> gfgtdf: one of the things that we should do is 
20140526 22:46:02< iceiceice> update some of the forum posts that describe MP bugs: http://forums.wesnoth.org/viewtopic.php?f=10&t=38487
20140526 22:46:31< iceiceice> http://forums.wesnoth.org/viewtopic.php?f=15&t=34363
20140526 22:47:18< gfgtdf> with update you mean edit the post or pst in teh thread ?
20140526 22:47:22< gfgtdf> post*
20140526 22:47:29< iceiceice> idk
20140526 22:47:47< iceiceice> maybe make a new post, unsticky the old one, and post a link tot he old version in the new version
20140526 22:47:50< iceiceice> and sticky the new version
20140526 22:47:58< iceiceice> in the coffee thread it hink just a reply is fine since its not sticky
20140526 22:48:31< iceiceice> for me its more about, i know like half of these in boht lists are fixed but some im not compeltely sure about
20140526 22:48:41< iceiceice> we should figure out which of these are actually real still and which ones we fixed
20140526 22:49:19< iceiceice> for instance i didnt know there was a bug with end of scenario saves
20140526 22:49:37< iceiceice> is it still important that the original host reloads?
20140526 22:49:42< iceiceice> i think probably its not
20140526 22:50:03< iceiceice> i think the reason that that was a problem was that, ai sides showed up as network
20140526 22:50:12< iceiceice> on the remote clients
20140526 22:50:23< iceiceice> and they are often marked "hidden" in the new game menu
20140526 22:50:34< irker669> wesnoth: gfgtdf wesnoth:master 52f271a39003 / src/playmp_controller.cpp: use turn_info_send in play_idle_loop http://git.io/fdDO_A
20140526 22:50:40< iceiceice> so if the nonhost tries to reload then mp_connect engine expects them to be filled with players and you get bugs
20140526 22:50:49< iceiceice> but thats not an issue now, i fixed it
20140526 22:51:29< iceiceice> do you know about this one? "OOS errors (online only):
20140526 22:51:29< iceiceice> - If a unit levels up and a victory on enemies defeat condition is active, then the unit will level up only for player of that side. In the next scenario other players will see a unit with xp above max and will lead to OOS state."
20140526 22:51:35< gfgtdf> iceiceice: ye it woudl definitely be useful to knwo whoch one of teh those are still valid.
20140526 22:51:49< gfgtdf> iceiceice: the unit levelup bug was fixed
20140526 22:52:21< gfgtdf> iceiceice: i rewrote the unit advancement after comat code very much
20140526 22:52:34< iceiceice> ok 
20140526 22:52:47< iceiceice> i think it would be good if you wrote down which ones you fixed,
20140526 22:52:52< iceiceice> idk either edit the post or make a follow up
20140526 22:53:00< iceiceice> i'll try to mark the ones i fixed or think are fixed
20140526 22:53:06< iceiceice> and we can test the others
20140526 22:53:11< iceiceice> or ask coffee too etc.
20140526 22:54:50< gfgtdf> iceiceice: do you know about "setting starting time to random leads to different values on different players machines from 2nd scenario onwards" ?
20140526 22:55:50< iceiceice> i sat down and decided to fix it,
20140526 22:55:57< iceiceice> then i discovered my plan was basically already implemented
20140526 22:56:02< iceiceice> then i tested it and i foudn that it was working
20140526 22:56:07< iceiceice> i posted this on the bugtracker about a month ago
20140526 22:56:18< iceiceice> idk if anyone is able to reproduce right now but i think it is fixed
20140526 22:56:57< iceiceice> the code to randomize the TOD now occurs in mp connect engine just after shuffle sides
20140526 22:57:15< iceiceice> the update_and_send_diff function takes an optional boolean parameter that decides if tod randomize happens,
20140526 22:57:19< iceiceice> it is onyl set to true at that one place...
20140526 22:57:22< iceiceice> (kind of bad design what w/e)
20140526 22:57:25< iceiceice> *but w/e
20140526 22:58:05< iceiceice> theres still a const_cast in the TOD manager which was so bizarre,
20140526 22:58:17< iceiceice> but if its not broken its not a bug now, its a refactor opportunity
20140526 22:59:14< gfgtdf> iceiceice: "replays do not work if variables are set in a prestart or start event that affect gameplay (e.g. setting number of turns, time of day, or gold" ?
20140526 22:59:53< iceiceice> i think the fact that you synced prestart and start means they work
20140526 23:00:14< iceiceice> i think all the unit tests woudl be failing on replay if they weren't being synced
20140526 23:00:42< iceiceice> i havent tested number of turns setting though
20140526 23:00:49< iceiceice> or the time of day
20140526 23:01:08< iceiceice> that's easy though, i can write some tests rihg tnow
20140526 23:06:31< iceiceice> looks like gold works
20140526 23:08:16< irker669> wesnoth: aquileia wesnoth:master 9b51a3a877ad / data/campaigns/Delfadors_Memoirs/scenarios/21_Clash_at_the_Manor.cfg: Implement temporary weapon swap in DM 21 http://git.io/IwRBTg
20140526 23:08:18< irker669> wesnoth: Chris Beck wesnoth:master 71190a0b051b / data/campaigns/Delfadors_Memoirs/scenarios/21_Clash_at_the_Manor.cfg: Merge remote-tracking branch 'aquileia/DM_fix' http://git.io/tTmvOw
20140526 23:08:20< gfgtdf> iceiceice: hm did you already tried unit tesing for mp?
20140526 23:08:20< irker669> wesnoth: Chris Beck wesnoth:master 7cc62266e98d / data/test/scenarios/prestart_settings.cfg wml_test_schedule: unit tests for giving gold in prestart http://git.io/dQ1bcg
20140526 23:08:22< irker669> wesnoth: Chris Beck wesnoth:master 0c504c54342d / src/ (playmp_controller.cpp playturn.hpp): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/NeqHeQ
20140526 23:08:28< iceiceice> gfgtdf: no
20140526 23:08:32< iceiceice> i wrote about it in my thread,
20140526 23:08:44< iceiceice> i figure that if the replay stays in sync its a good indicator of mp
20140526 23:08:50< iceiceice> but could make mp unit tests too
20140526 23:08:55< iceiceice> i'm not sur ehow it would work
20140526 23:09:03< aquileia> iceiceice: thanks
20140526 23:09:04< gfgtdf> iceiceice: how do i merge teh upstream master branch in order to push to master ?
20140526 23:09:10< iceiceice> git pull upstream master
20140526 23:09:23< gfgtdf> iceiceice: just ontop of my local cahnges ?
20140526 23:09:31< iceiceice> aquileia: np
20140526 23:09:37< iceiceice> gfgtdf: yi tshould work
20140526 23:09:42< iceiceice> if you have conflicts you have to resolve htem locally
20140526 23:09:50< iceiceice> but otheriwse just do it and push
20140526 23:09:55< iceiceice> and travis will tell us if someting bad happened
20140526 23:10:09< aquileia> gfgtdf: The cleanest solution would be to check your changes out into a different branch IMO
20140526 23:10:21< iceiceice> if they are already committed though its a pain
20140526 23:10:40< aquileia> iceiceice: It's even easier
20140526 23:10:55< iceiceice> it depends on if you already compiled and tested your local master
20140526 23:11:03< iceiceice> in that case its probaly better to merge
20140526 23:11:12< iceiceice> because if you rebase or chery-pick and destroy that history,
20140526 23:11:24< iceiceice> idk anytime there is a commit that is compiled and tested, we want it in the history
20140526 23:11:42< iceiceice> when you rebase / cherry-pick you lose the time stamps, and you can't recreate the tests that passed
20140526 23:11:56< irker669> wesnoth: gfgtdf wesnoth:master 562e1edd00b2 / src/ (7 files): remove do_replay s side parameter http://git.io/y3vQFw
20140526 23:11:58< irker669> wesnoth: gfgtdf wesnoth:master d28a1d6563fc / / (3 files in 3 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/-ItQeQ
20140526 23:12:12< aquileia> I'm not sure, but I'd do: git checkout -b new_name, git checkout master, git reset --hard to the state before, git pull upstream master, git checkout new_name, git rebase master
20140526 23:12:24< gfgtdf> iceiceice: ok it tried puslling an it worked
20140526 23:12:54< iceiceice> aquileia: y i have done that too in the past
20140526 23:13:03< iceiceice> at some point i switched over to mainly using merge
20140526 23:13:10< iceiceice> although i still use topic branches often
20140526 23:13:21< iceiceice> it depends if its like
20140526 23:13:26< iceiceice> "this doesnt compile, one line change is neeeded"
20140526 23:13:27< aquileia> ah, I remember... "embrace the merge commit"
20140526 23:13:29< iceiceice> then i do it right no master
20140526 23:13:43< iceiceice> if its like an actual project then always i do the topic branch and rebase
20140526 23:14:24< iceiceice> gfgtdf: one thing about doing mp tests,
20140526 23:14:33< iceiceice> i would have to make travis launch 3 processes
20140526 23:14:34< iceiceice> the server,
20140526 23:14:36< iceiceice> the host, 
20140526 23:14:38< iceiceice> the client
20140526 23:14:44< iceiceice> who just observes the test ig uess??
20140526 23:14:47< iceiceice> and reports if he oos's?
20140526 23:15:09< gfgtdf> iceiceice: well non of tehn shodul haev an oos to pass
20140526 23:15:11< iceiceice> there's no mechanism rihg tnow to like auto join an mp server and a game
20140526 23:15:13< gfgtdf> none
20140526 23:15:24< iceiceice> it would be a signifiacnt project
20140526 23:15:55< iceiceice> some day i guess
20140526 23:16:21< iceiceice> idk have you ever seen a scenario that OOS in mp but not in replay?
20140526 23:16:34< iceiceice> i woudl believe its possible but i would guess it has to be very wierd
20140526 23:20:01< iceiceice> idk maybe the replay sync and mp sync code is not as tightly linekd as i think... but in my experience theres alot of overlap
20140526 23:20:27< shadowm> iceiceice: I did what?
20140526 23:20:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140526 23:21:00< iceiceice> you were saying something before that you introduced the wml logger mechanism
20140526 23:21:29< iceiceice> idk i guessed that you had written a bunch of the stuff in wml_exception.hpp, maybe i'm wrong
20140526 23:21:38< shadowm> I introduced [wml_message] (originally [debug_message]). The file you linked to, wml_exception.hpp, I've got nothing to do with it.
20140526 23:21:42< iceiceice> dont worry i didnt accuse you of doing anything bad :)
20140526 23:22:06< iceiceice> i was continuing a tradition i found there
20140526 23:22:07< shadowm> In fact I believe it's got nothing to do with [wml_message].
20140526 23:22:35< iceiceice> hmm so theres also a lg:wml_error object floating around
20140526 23:23:01< iceiceice> i thought its related to [wml_message]
20140526 23:23:32< iceiceice> (as i've discovered wesnoth actually has a pretty elaborate logging system)
20140526 23:26:32< shadowm> It was slightly less elaborate until someone figured out we were relying on static initialization order across object files.
20140526 23:27:27< shadowm> Then the log classes instances were moved to their call sites.
20140526 23:29:47< iceiceice> i see
20140526 23:30:01< iceiceice> gfgtdf: do you know what happens with this command? http://wiki.wesnoth.org/DirectActionsWML#.5Bmodify_turns.5D
20140526 23:30:14< iceiceice> like, does it fire intermediate side turn events?
20140526 23:31:20< iceiceice> when you use current turn i mean
20140526 23:32:29< aquileia> gfgtdf: Other than the fact that a lot of the tests time out, not too bad, isn't it? http://imgur.com/lCNHejX
20140526 23:34:27< gfgtdf> aquileia: hm i dont know what you are talking about :S
20140526 23:35:08< gfgtdf> iceiceice: hm idk i have never seen this action before
20140526 23:35:09< aquileia> The inclusion of the WML unit tests into VC
20140526 23:35:17< gfgtdf> aquileia: oh
20140526 23:35:28< iceiceice> gfgtdf: it looks like modify turns skips over the events of earlier turns if you advance the counter
20140526 23:35:44< gfgtdf> iceiceice: ye
20140526 23:36:04< gfgtdf> iceiceice: but idk what happens fore example when you use it durign a side turn 5 event and set it o 10
20140526 23:36:18< gfgtdf> will te nexe event be the side turn 5 refrech of side turn 10 refresh ?
20140526 23:36:29< iceiceice> i can write a test for that :)
20140526 23:36:40< iceiceice> i am findingt htat it works properly even in prestart
20140526 23:36:47< iceiceice> in terms of skipping earlier events
20140526 23:36:55< gfgtdf> aquileia: are the normal unit tests integrated in VC ?
20140526 23:36:57< iceiceice> like, if you set to 42, in prestart
20140526 23:37:00< iceiceice> you wont have side 1 turn 1
20140526 23:37:20< aquileia> gfgtdf: I wanted to da that as well, but didn't succeed yet
20140526 23:37:30< aquileia> s/da/do
20140526 23:37:39< gfgtdf> aquileia: ok
20140526 23:37:45< iceiceice> hmm ok
20140526 23:37:48< iceiceice> side turn refresh still happen
20140526 23:37:49< iceiceice> s
20140526 23:37:58< iceiceice> if side turn 1 changes turn to 42,
20140526 23:38:03< iceiceice> you still have side turn 1 refresh fire
20140526 23:38:19< aquileia> And right now the WML ones aren't activated
20140526 23:40:25< gfgtdf> iceiceice: i tihnk shadowm introdced that: 7ceeff3dc0ce4e00cfe2b2d4ae35453c38a2e6b8
20140526 23:40:59< gfgtdf> iceiceice: mybe he knows everything about how that behaved during side turn side turn end events
20140526 23:41:37< iceiceice> y i mean im not suggesting its a bug, i dont have a strong opinion about how it shoudl work
20140526 23:41:46< iceiceice> for me, i would think its simplest if it fires all intermediate events
20140526 23:41:51< iceiceice> so the order of events is always the same
20140526 23:41:58< iceiceice> but thats also limiting in a sense
20140526 23:42:07< gfgtdf> iceiceice: hmm no iwouldnt do that
20140526 23:42:26< iceiceice> yeah i dont really care how it works
20140526 23:42:31< iceiceice> i think its good to commit tests thoguh
20140526 23:42:34< iceiceice> reflecting current bheavior
20140526 23:42:40< iceiceice> unless something unintended is happening
20140526 23:42:42< gfgtdf> iceiceice: i just would liek if during one "pack" of side turn events side turn, side X turn X ... the number wouldnt change
20140526 23:42:59< gfgtdf> or side turn end
20140526 23:43:25< shadowm> No I don't know.
20140526 23:44:23< iceiceice> hmm this is kind of wierd
20140526 23:44:25< shadowm> I think WML authors should just accept that changing the current turn number, ending the current turn from WML, or reassigning a wesnoth.wml_actions entry voids the warranty we don't offer in the first place.
20140526 23:44:55< iceiceice> hmm ok
20140526 23:45:08< iceiceice> im not sure if changing the turn fires any of the new turn events actually
20140526 23:45:20< gfgtdf> iceiceice: i thin it doent
20140526 23:45:26< gfgtdf> it just rested internaly
20140526 23:45:31< iceiceice> ok
20140526 23:45:33< gfgtdf> resets a numer*
20140526 23:46:51< iceiceice> y it resets the number you get from [store_turns]
20140526 23:47:08< iceiceice> but i guess not the one for events?
20140526 23:48:10< shadowm> I kind of assumed they are one and the same at the time.
20140526 23:49:16< iceiceice> i think its like, some part of the engine may store the turn number in a local variable
20140526 23:49:26< iceiceice> so if you change the turn number in side turn 1,
20140526 23:49:29< shadowm> The changelog also suggests that someone fixed that for me.
20140526 23:49:31< iceiceice> you will still get a side 1 turn 1 refresh
20140526 23:49:43< iceiceice> but if you change the turn number, then end turn,
20140526 23:49:46< shadowm> But since this was all in 1.5.x, I wouldn't be surprised if something changed in that regard.
20140526 23:49:47< iceiceice> then you wont get side 1 turn 1 end
20140526 23:50:25< iceiceice> idk i doubt if the exact behavior of this is important to anyone add-on
20140526 23:50:37< shadowm> It theoretically would be important to me.
20140526 23:50:43< iceiceice> hmm ok
20140526 23:50:48< iceiceice> what behavior do you need?
20140526 23:52:03< shadowm> Well, hm... AtS E3S7A.2 uses shifted turns. The catch is that I didn't bother to test how turn events were dispatched after changing the turn number in prestart, and instead assumed that they would be dispatched with the correct numbers. And because I didn't want to do the maths to generate event handlers (the turn shift is variable and depends upon the state at the end of the previous scenario)...
20140526 23:52:29< shadowm> ... I appear to be dispatching my own (WML-generated) turn 1-based turn events.
20140526 23:52:57< shadowm> Let's see what happens if I disable the synthetized events.
20140526 23:54:54< shadowm> It breaks the scenario completely, so I assume that the game is dispatching the shifted turn events rather than turn 1-based events.
20140526 23:55:58< shadowm> On version 1.11.15.
20140526 23:56:46< iceiceice> ok
20140526 23:56:57< shadowm> Yep, "turn 157 end" is dispatched by the engine on its own.
20140526 23:57:55-!- aboutGod [~aboutGod@static-72-66-66-50.washdc.fios.verizon.net] has joined #wesnoth-dev
20140526 23:59:40< iceiceice> ok im just going to commit tests based on current behavior
20140526 23:59:49< iceiceice> if someone is inclined to change what it is doing they can update the tests
--- Log closed Tue May 27 00:00:08 2014