--- Log opened Sat May 31 00:00:15 2014
20140531 00:00:17< iceiceice> but idk if its good it might make it hard to port stuff back to 1.12
20140531 00:00:45< iceiceice> if we get issues with play_controller fully sorted out i will do it
20140531 00:02:54< gfgtdf> iceiceice: hm i dont think we have to backport refactoring
20140531 00:03:18< iceiceice> we'll get lots of conflicts though
20140531 00:03:21< iceiceice> when we cherry-pick 
20140531 00:03:25< iceiceice> if we dont
20140531 00:03:38< gfgtdf> iceiceice: hmm ye in that case we should backport whats nesecary
20140531 00:03:44< iceiceice> i think strict refactor, like remove dead code, is okay to backport, that doesnt break a feature freeze
20140531 00:03:48< iceiceice> its not like we are in code freeze
20140531 00:04:11< iceiceice> if it doesnt change behavior its not a feature or a bug
20140531 00:04:27< iceiceice> its just a "problem" in that bugs can live in dead code, or conceal bugs
20140531 00:07:13-!- trewe [~trewe@2001:8a0:d125:ab01:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20140531 00:09:28< AI0867> 21:19 < zookeeper> shadowm, sure, but surely the engine doesn't have "one surface for each hex"? ← actually, it usually has more than one. image::locator returns a surface, so every image that is loaded results in at least one surface. IPFs create new surfaces from these, which are then blitted using the painter's algorithm (first draw the background, then draw everything over that in order)
20140531 00:09:53< gfgtdf> iceiceice: ok i think ill remove teh dead code i meantioned earlier
20140531 00:10:14< iceiceice> ok
20140531 00:10:41< AI0867> the animation engine contains a lot of logic regarding which surfaces need to be reblitted, to keep things fast. Animated terrain can really hurt performance precisely because it (and everything on it) needs to be redrawn often
20140531 00:11:58< iceiceice> gfgtdf: i might try to figure out how to remove "end_turn_record" 
20140531 00:16:44-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140531 00:16:45< irker746> wesnoth: gfgtdf wesnoth:master 881e2da2d10e / src/gamestatus.cpp: remove dead code. http://git.io/_GMGhQ
20140531 00:17:07< gfgtdf> iceiceice: ye ok
20140531 00:17:12< shadowm> AI0867: The idea is to apply it to hexes, not individual layers.
20140531 00:17:42< shadowm> I think.
20140531 00:18:22< iceiceice> would this stuff with surfaces improve if we use opengl or not?
20140531 00:18:36< iceiceice> i remember there were a bunch of fancy tricks with z-buffer you could do...
20140531 00:18:45< iceiceice> my knowledge is at least 10 years old so probably theres even more fancy stuf now
20140531 00:19:08< AI0867> iceiceice: very much so
20140531 00:19:19< AI0867> GPUs are essentially made to do this
20140531 00:19:23< gfgtdf> i'd be very happy is scale_surface was faster. 
20140531 00:19:23< wesbot> gfgtdf: Sometimes we are fast
20140531 00:19:30< gfgtdf> scale_surface_sharp
20140531 00:19:36< gfgtdf> if
20140531 00:20:24< AI0867> redrawing every pixel, every frame, using z-buffering is what pretty much every 3D game out there does
20140531 00:21:06< AI0867> frogatto does 2D this way
20140531 00:21:15< AI0867> also, shaders
20140531 00:28:11-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Ping timeout: 240 seconds]
20140531 00:29:11-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140531 00:31:45< gfgtdf> ciedo you kow why we shoudl need carryover_sides_start non non start-of-sceanrio saves ?
20140531 00:31:49< gfgtdf> iceiceice: 
20140531 00:31:52< gfgtdf> iceiceice: ^
20140531 00:32:15< iceiceice> y i think you need it for replays?
20140531 00:32:27< iceiceice> it contains like your gold and stuff
20140531 00:32:58< gfgtdf> hm i think the replay_start is made after carryover_sides_start is merged but i might be wrong
20140531 00:33:09< iceiceice> y it depends on that i guess
20140531 00:33:29< iceiceice> you might need it in case like,
20140531 00:33:36< iceiceice> there is a unit in the carryover from a previous level
20140531 00:33:42< iceiceice> that needs to reappear in the next level, but not this level?
20140531 00:33:55< gfgtdf> iceiceice: such information is in carryover_sides
20140531 00:34:01< iceiceice> but what if you reload
20140531 00:34:07< gfgtdf> iceiceice: its still in carryover sides
20140531 00:34:12< iceiceice> or watch the replay and start from the beginning
20140531 00:34:17< iceiceice> and then save
20140531 00:34:38-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140531 00:34:52< gfgtdf> iceiceice: hm if the [caryyover_sides_start] that infromation should again be in [carryover_sides]
20140531 00:35:12< iceiceice> do we read carryover_sides when you start a replay?
20140531 00:35:30< iceiceice> i thgouth its like, we read carryover_sides hwen you read snapshot
20140531 00:35:37< iceiceice> and carryover_sides_start when you read replay_start and then replay
20140531 00:37:18< gfgtdf> iceiceice: posible, but assuming that  [carryover_sides_start] is already merged in [replay_start] it woudt be unlogocal, but maybe there are some parts but other not. idk
20140531 00:37:24< gfgtdf> unlogical*
20140531 00:37:38< gfgtdf> spme parts merged already but other parts not*
20140531 00:37:40< gfgtdf> some
20140531 00:37:53< iceiceice> y i have only vague ideas how it is supposed to go
20140531 00:38:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140531 00:41:09< iceiceice> gfgtdf: do you know what "browse_" does in playsp controller?
20140531 00:41:40< gfgtdf> iceiceice: hm i think its to prevent player from doing things if its not their turn, but im not sure
20140531 00:41:41-!- _8680_ [~8680@2002:4404:712c:0:b5c9:5ab4:d537:5626] has quit [Ping timeout: 264 seconds]
20140531 00:42:19-!- _8680_ [~8680@2002:4404:712c:0:ad62:6532:5486:ba3b] has joined #wesnoth-dev
20140531 00:43:16-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140531 00:46:49-!- _8680_ [~8680@2002:4404:712c:0:ad62:6532:5486:ba3b] has quit [Ping timeout: 252 seconds]
20140531 00:47:47-!- _8680_ [~8680@2002:4404:712c:0:dcc8:77ed:5b74:c5db] has joined #wesnoth-dev
20140531 00:53:13-!- _8680_ [~8680@2002:4404:712c:0:dcc8:77ed:5b74:c5db] has quit [Ping timeout: 245 seconds]
20140531 00:54:16-!- _8680_ [~8680@2002:4404:712c:0:9066:5782:6066:eec3] has joined #wesnoth-dev
20140531 00:56:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140531 00:58:30< iceiceice> hmmm
20140531 00:59:04< iceiceice> its wierd that linger mode is differnt in mp and sp
20140531 00:59:59-!- sachith500 [~kvirc@112.134.248.25] has joined #wesnoth-dev
20140531 01:02:49< gfgtdf> iceiceice: well in mp we have to handle netwrok input in linger mode
20140531 01:03:05< gfgtdf> iceiceice: but ye its not good that its inplemented so differently
20140531 01:03:34< iceiceice> hmm so i have gotten rid of end_turn_record functions...
20140531 01:03:42< iceiceice> i want to rpelace turn_over_ with linger_ and get rid of it
20140531 01:03:44< iceiceice> but its hard to see if thats okay
20140531 01:03:58< iceiceice> i think it may be that in SP linger mode we never ever call play_human_turn() anyways
20140531 01:04:01< gfgtdf> to me that soubds good
20140531 01:04:13< iceiceice> y im like 99% sure its ok
20140531 01:04:17< gfgtdf> ye its implemented very different in mp and mp
20140531 01:04:24< gfgtdf> iceiceice: thats not good
20140531 01:05:13< gfgtdf> iceiceice: (the way its implemented i mean)
20140531 01:06:14< irker746> wesnoth: Chris Beck wesnoth:master b809585ca230 / src/ (playsingle_controller.cpp playsingle_controller.hpp): eliminate archaic functions http://git.io/Kyyb_g
20140531 01:06:26< iceiceice> gfgtdf: yeah i know what you mean
20140531 01:17:22< iceiceice> gfgtdf: i think maybe we should do something here? https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L534
20140531 01:17:38< iceiceice> mattsc said something about this,
20140531 01:17:47< iceiceice> that it causes inconvenience when you load save file?
20140531 01:17:51< iceiceice> oh i remember now
20140531 01:18:02< iceiceice> i guess its that the replay controller should set to "running" when you reset it?
20140531 01:18:44< gfgtdf> iceiceice: hm i dont really know what it does
20140531 01:22:20< irker746> wesnoth: Chris Beck wesnoth:master ef5417f60fa2 / src/ (playmp_controller.cpp playsingle_controller.cpp playsingle_controller.hpp): remove unnecessary variable "turn_over_" from play_controllers. http://git.io/TIi1WQ
20140531 01:22:24-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140531 01:25:29-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 264 seconds]
20140531 01:26:48< iceiceice> hmm
20140531 01:26:52-!- spoffy [~spoffy@152.78.175.8] has quit [Ping timeout: 265 seconds]
20140531 01:27:02< iceiceice> its funny that we call "check_victory" in "check_time_over"
20140531 01:27:16< iceiceice> so that at the last possible second before defeat we might still have victory
20140531 01:27:24< iceiceice> i guess in response to a "time over" event??
20140531 01:32:00< gfgtdf> iceiceice: y
20140531 01:33:56< iceiceice> hmm i think i could use this actually to simplify some of the unit tests :)
20140531 01:34:10< iceiceice> probly not worth it though
20140531 01:34:12< iceiceice> for the future though
20140531 01:40:40-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Read error: Connection reset by peer]
20140531 01:41:05-!- WinterD_ [~quassel@177.196.200.77.rev.sfr.net] has quit [Ping timeout: 264 seconds]
20140531 01:44:58-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has joined #wesnoth-dev
20140531 01:45:13< iceiceice> hmm
20140531 01:45:37-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140531 01:46:01< iceiceice> gfgtdf: do you think its significant that this line is "gui->viewing_team()" and not player_number_ - 1?
20140531 01:46:01< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/playmp_controller.cpp#L328
20140531 01:47:17< iceiceice> hmm i guess in other cases its not always player_number_ -1...
20140531 01:47:52< gfgtdf> iceiceice: hm gui_->viewing_team() and player_number_ -1 are usually different values, but i dont see which we shoudl pass there
20140531 01:57:16< iceiceice> y i wont mess around with it i tink
20140531 02:04:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140531 02:04:40-!- gfgtdf [~chatzilla@e177125237.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20140531 02:17:24-!- gfgtdf [~chatzilla@e177125237.adsl.alicedsl.de] has joined #wesnoth-dev
20140531 02:22:22< irker746> wesnoth: Chris Beck wesnoth:master d86ff4d65093 / src/ (play_controller.cpp play_controller.hpp playsingle_controller.cpp): eliminate unnecessary argument in play_controller http://git.io/SidCYg
20140531 02:22:24< irker746> wesnoth: Chris Beck wesnoth:master eb18ffc8a8ae / src/play_controller.cpp: clean up find_human_team_before function http://git.io/3CFaKA
20140531 02:24:14-!- Ivanovic_ [~ivanovic@frnk-5f7513a6.pool.mediaWays.net] has joined #wesnoth-dev
20140531 02:25:29-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20140531 02:25:52-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140531 02:26:09-!- sachith500|2 [~kvirc@112.135.108.123] has joined #wesnoth-dev
20140531 02:26:27-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20140531 02:28:08-!- Ivanovic_ is now known as Ivanovic
20140531 02:28:16-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140531 02:29:26-!- sachith500 [~kvirc@112.134.248.25] has quit [Ping timeout: 276 seconds]
20140531 02:48:32-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140531 03:08:45-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140531 03:09:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Traveling until May 31]
20140531 03:19:14-!- gfgtdf [~chatzilla@e177125237.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140531 03:32:26-!- fabi [~fabi@91-67-44-12-dynip.superkabel.de] has joined #wesnoth-dev
20140531 03:32:26-!- fabi [~fabi@91-67-44-12-dynip.superkabel.de] has quit [Changing host]
20140531 03:32:26-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20140531 03:46:06-!- Netsplit *.net <-> *.split quits: Samual, Ard0nik, shadowm_desktop
20140531 03:46:15-!- Netsplit over, joins: shadowm_desktop
20140531 03:46:15-!- Samual [diotecktec@c-24-3-185-118.hsd1.pa.comcast.net] has joined #wesnoth-dev
20140531 03:46:15-!- Samual [diotecktec@c-24-3-185-118.hsd1.pa.comcast.net] has quit [Changing host]
20140531 03:46:15-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20140531 03:46:19-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140531 03:46:41-!- Netsplit over, joins: Ard0nik
20140531 03:52:41-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140531 03:56:11-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140531 04:00:29-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Remote host closed the connection]
20140531 04:10:33-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Read error: Connection reset by peer]
20140531 04:10:50-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140531 04:34:33-!- shadowm_desktop2 is now known as shadowm_desktop
20140531 04:52:17-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 265 seconds]
20140531 05:00:18-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140531 05:33:26-!- Necrosporus_ is now known as Necrosporus
20140531 05:56:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140531 06:46:34-!- Sulfur [~Miranda@p5B008545.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140531 06:56:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140531 07:14:31-!- cib [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140531 07:14:55-!- cib is now known as Guest84395
20140531 07:15:01-!- Guest63621 [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140531 07:22:39-!- sachith500|2 [~kvirc@112.135.108.123] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140531 07:24:44-!- Ivanovic [~ivanovic@frnk-5f7513a6.pool.mediaWays.net] has quit [Changing host]
20140531 07:24:44-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140531 07:50:16-!- irker746 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140531 07:50:44-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140531 07:59:20-!- mjs-de [~mjs-de@f048194175.adsl.alicedsl.de] has joined #wesnoth-dev
20140531 08:00:19-!- zookeeper [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20140531 08:00:19-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20140531 08:00:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140531 08:05:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140531 08:15:46-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140531 08:25:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140531 08:34:34-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140531 08:50:55-!- sachith500 [~kvirc@112.135.108.123] has joined #wesnoth-dev
20140531 08:58:58-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140531 08:59:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140531 09:15:30-!- Guest84395 [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Quit: Leaving]
20140531 09:16:18-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140531 09:21:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140531 09:22:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140531 09:23:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140531 09:29:48-!- Sulfur [~Miranda@p5B008545.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140531 09:34:10-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140531 09:40:32-!- AI0867_ [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20140531 09:41:16-!- markus_ [~mjs-de@f048194175.adsl.alicedsl.de] has joined #wesnoth-dev
20140531 09:43:00-!- mjs-de [~mjs-de@f048194175.adsl.alicedsl.de] has quit [Disconnected by services]
20140531 09:43:04-!- markus_ is now known as mjs-de
20140531 09:44:16-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Ping timeout: 265 seconds]
20140531 09:55:46-!- Sulfur [~Miranda@p5B008545.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140531 10:08:47-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140531 10:58:21-!- Bodhi-Baum [~Bodhi@dslb-084-063-023-022.pools.arcor-ip.net] has joined #wesnoth-dev
20140531 11:31:55-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140531 11:35:43-!- Guest63621 [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20140531 11:44:13-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140531 11:48:36< Necrosporus> I get error display: Reference to non-existent rect id "villages-icon" and "units-icon" when I open editor
20140531 11:57:17-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140531 12:13:52-!- haudegen_ [~quassel@178.115.128.100.wireless.dyn.drei.com] has joined #wesnoth-dev
20140531 12:28:57-!- haudegen_ [~quassel@178.115.128.100.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140531 12:29:11-!- sachith500 [~kvirc@112.135.108.123] has quit [Ping timeout: 240 seconds]
20140531 12:29:40-!- haudegen_ [~quassel@178.115.128.100.wireless.dyn.drei.com] has joined #wesnoth-dev
20140531 12:31:40-!- sachith500 [~kvirc@112.134.79.207] has joined #wesnoth-dev
20140531 12:33:29-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140531 12:37:09-!- haudegen_ [~quassel@178.115.128.100.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140531 12:37:32-!- haudegen [~quassel@178.115.128.100.wireless.dyn.drei.com] has joined #wesnoth-dev
20140531 12:41:58-!- Bodhi-Baum [~Bodhi@dslb-084-063-023-022.pools.arcor-ip.net] has quit [Ping timeout: 245 seconds]
20140531 12:44:47-!- haudegen [~quassel@178.115.128.100.wireless.dyn.drei.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20140531 12:45:22-!- haudegen [~quassel@178.115.128.100.wireless.dyn.drei.com] has joined #wesnoth-dev
20140531 13:04:49-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20140531 13:04:49-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20140531 13:04:49-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140531 13:05:06< mordante> servus
20140531 13:07:45-!- kex [~kex@212.92.210.53] has joined #wesnoth-dev
20140531 13:07:57-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has joined #wesnoth-dev
20140531 13:08:04< thunderstruck> Does anyone know why [carryover_sides_start] does not have "id", but got "next_scenario" which contains current scenario id?
20140531 13:08:29< thunderstruck> s/got/has
20140531 13:14:06-!- kex [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140531 13:14:35-!- kex [~kex@212.92.210.53] has joined #wesnoth-dev
20140531 13:20:55-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140531 13:29:44-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140531 13:38:27-!- AI0867_ is now known as AI0867
20140531 14:12:15-!- Bodhi-Baum [~Bodhi@dslb-084-063-008-021.pools.arcor-ip.net] has joined #wesnoth-dev
20140531 14:14:10-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140531 14:19:57-!- matthiaskrgr is now known as mtthiaskrgr
20140531 14:20:12-!- mtthiaskrgr is now known as matthiaskrgr
20140531 14:26:13-!- haudegen [~quassel@178.115.128.100.wireless.dyn.drei.com] has quit [Ping timeout: 252 seconds]
20140531 14:26:57-!- gfgtdf [~chatzilla@e177125237.adsl.alicedsl.de] has joined #wesnoth-dev
20140531 14:27:38-!- spoffy [~spoffy@152.78.175.8] has joined #wesnoth-dev
20140531 14:29:39< gfgtdf> thunderstruck: i tihnk [carryover_sides_start] is mainly used for saves between games "start-of-scenario"-saves andthen it is the id of teh next scenario
20140531 14:31:46< gfgtdf> thunderstruck: so "current scenario id" would be missleading since there is currently no scenario running
20140531 14:32:01< gfgtdf> (in start-of-scenario saves)
20140531 14:34:05< gfgtdf> iceiceice_: is there a rason why we handle "next_scenario_append" in playcampaign as not as a member of "carryover_info" ?
20140531 14:36:24< gfgtdf> does anyone know why we have a "difficulcy" member in gamedata/carryover if there is already one in came_classification ?
20140531 14:37:18< iceiceice_> gfgtdf: now that i look again the carryover_wml should probably be in carryover_info and not in end level data...
20140531 14:37:53< iceiceice_> i think its just not very good design
20140531 14:38:14< iceiceice_> i wrote that like 6 months ago? and i tested it but not in mp... it might be that it needs to go into the level to work in mp
20140531 14:40:03< gfgtdf> hm ok so i ca change that
20140531 14:40:05< gfgtdf> can
20140531 14:42:14< iceiceice_> yes please do if you are inclined :)
20140531 14:42:16< gfgtdf> iceiceice_: i am thinking about replacing "state_of_game" with a seriaizes_game object, the state_of_game currently seems just lile an omipresent pos data that sometimes contains this data and that dat at another time  :s .
20140531 14:43:01< iceiceice_> gfgtdf: yeah im not sure what the right design should be ...
20140531 14:43:16< iceiceice_> i think there should be a class like "game_state" or "game_state_controller"
20140531 14:43:36< iceiceice_> to encapsulate the unit map, the game map, the tod manager, the list of teams
20140531 14:43:44< iceiceice_> and probably pathfinding also
20140531 14:44:02< iceiceice_> and also to manage serializing these
20140531 14:44:47< gfgtdf> hmm these are all part os [snapshot] teh current game_state is morea bout the things ouside of [snapshot].
20140531 14:45:01< iceiceice_> y the thing currently called game state is something else
20140531 14:46:55< gfgtdf> iceiceice_: hm ok i'll try to remove "difficulcy" from gamedata/carryover
20140531 14:48:35< iceiceice_> do you know how the lua interpreter gets initialized?
20140531 14:48:51< iceiceice_> right so the play controller constructs a new game_data_ which contains all the wml variables
20140531 14:49:04< iceiceice_> but there does not seem to be like a "lua manager" or anything?
20140531 14:49:15< iceiceice_> how does it make sure all the dead lua variables get destroyed
20140531 14:50:24< gfgtdf> the game_events manager ahndles then i think
20140531 14:50:33< gfgtdf> handles
20140531 14:57:50-!- lipkab [~the_new_l@apn-185-10-127-77.vodafone.hu] has joined #wesnoth-dev
20140531 14:59:11< lipkab> mordante: Hello.
20140531 14:59:43< Necrosporus> mordante, hello, so how is going?
20140531 15:07:58-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140531 15:09:01-!- haudegen_ [~quassel@178.115.128.100.wireless.dyn.drei.com] has joined #wesnoth-dev
20140531 15:15:57-!- haudegen_ [~quassel@178.115.128.100.wireless.dyn.drei.com] has quit [Quit: Weil so halt.]
20140531 15:16:17-!- haudegen [~quassel@178.115.128.100.wireless.dyn.drei.com] has joined #wesnoth-dev
20140531 15:21:14-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has quit [Quit: Leaving]
20140531 15:28:14-!- Bodhi-Baum [~Bodhi@dslb-084-063-008-021.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140531 15:34:54-!- kex [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140531 15:35:20-!- kex [~kex@212.92.210.53] has joined #wesnoth-dev
20140531 15:39:48-!- kex [~kex@212.92.210.53] has quit [Ping timeout: 240 seconds]
20140531 15:50:49-!- spoffy [~spoffy@152.78.175.8] has quit [Remote host closed the connection]
20140531 16:01:08-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 245 seconds]
20140531 16:01:58-!- haudegen [~quassel@178.115.128.100.wireless.dyn.drei.com] has quit [Ping timeout: 245 seconds]
20140531 16:06:45-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140531 16:07:18-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Client Quit]
20140531 16:07:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140531 16:14:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140531 16:18:11-!- lipkab [~the_new_l@apn-185-10-127-77.vodafone.hu] has quit [Ping timeout: 276 seconds]
20140531 16:24:12< thunderstruck> iceiceice_: https://github.com/thunderstruck/wesnoth/commit/59a31f26d0fe3aa19ab3aa8f5b18c576eb14f239
20140531 16:24:30< thunderstruck> iceiceice_: This is an attempt to fix MP start-of-scenario saves.
20140531 16:25:15< thunderstruck> iceiceice_: The problem I'm having is that [carryover_sides_start] contain some unexpected data. E.g. for all sides current_player= is set to host.
20140531 16:25:23< mordante> hi lobby 
20140531 16:25:34< thunderstruck> iceiceice_: And so that's not reflected well in MP Connect.
20140531 16:30:02-!- lipkab [~the_new_l@apn-94-44-255-216.vodafone.hu] has joined #wesnoth-dev
20140531 16:33:55-!- lipkabb [~the_new_l@apn-94-44-255-216.vodafone.hu] has joined #wesnoth-dev
20140531 16:34:27-!- lipkabb [~the_new_l@apn-94-44-255-216.vodafone.hu] has quit [Read error: Connection reset by peer]
20140531 16:35:31-!- lipkabb [~the_new_l@apn-94-44-255-216.vodafone.hu] has joined #wesnoth-dev
20140531 16:36:14-!- irker028 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140531 16:36:14< irker028> wesnoth: Mark de Wever wesnoth:master af98cf1781e7 / src/tests/test_map_location.cpp: Remove some useless casts. http://git.io/G0Lu8A
20140531 16:36:14< irker028> wesnoth: Mark de Wever wesnoth:master bc2e59082bb9 / src/ (floating_point_emulation.hpp sdl_utils.cpp tests/test_config.cpp): Fixes compilation of abs for C++11. http://git.io/yd-P9Q
20140531 16:38:20-!- lipkab [~the_new_l@apn-94-44-255-216.vodafone.hu] has quit [Ping timeout: 276 seconds]
20140531 16:38:29< irker028> wesnoth: gfgtdf wesnoth:master 14437136a9ce / src/ (5 files): go to next scenario if there is at least one human http://git.io/8QlWyQ
20140531 16:38:31< irker028> wesnoth: gfgtdf wesnoth:master 7aef4115141f / src/ (5 files): Merge pull request #176 from gfgtdf/carryover_on_defeeat http://git.io/NrNFGw
20140531 16:44:01< irker028> wesnoth: gfgtdf wesnoth:master 59880e984bbf / src/ (play_controller.cpp tod_manager.cpp tod_manager.hpp): sync random_start time the normal way http://git.io/nEFcmw
20140531 16:44:03< irker028> wesnoth: gfgtdf wesnoth:master dd8ac6754aac / src/ (play_controller.cpp tod_manager.cpp tod_manager.hpp): Merge pull request #172 from gfgtdf/random_tod http://git.io/6wY_Ng
20140531 16:44:39< gfgtdf> iceiceice_: i merged 2 pul request which should not be backported ^
20140531 16:49:05< gfgtdf> is there a way to get teh curent difficulcy from wml ?
20140531 16:50:22< gfgtdf> meaning with a tag. Not via marcos
20140531 17:04:48< iceiceice_> gfgtdf: i dont think so
20140531 17:05:07< iceiceice_> i mean you could use the macros to get it thouhg
20140531 17:05:14< iceiceice_> into variables if desired
20140531 17:06:25< gfgtdf> iceiceice_: hmm i think the case that i wanted to test is maybe no that omportant anyway
20140531 17:06:28< gfgtdf> is there a reaso why we use your own HAVE_CXX11 mcrso instead of boost config ?
20140531 17:06:30< iceiceice_> thunderstruck: i see
20140531 17:07:07< iceiceice_> gfgtdf: maybe so we can disable and enable CXX11 easily?
20140531 17:07:36< gfgtdf> iceiceice_: that would also be possible with boos config by putting teh #include in an #if
20140531 17:08:03< iceiceice_> hmm idk then
20140531 17:08:43< gfgtdf> mordante: do you know why we use our own HAVE_CXX11  marco instead of boost config ?
20140531 17:10:10-!- travis-ci [~travis-ci@ec2-54-83-134-82.compute-1.amazonaws.com] has joined #wesnoth-dev
20140531 17:10:10< travis-ci> [travis-ci] wesnoth/wesnoth#2884 (master - bc2e590 : Mark de Wever): The build was broken.
20140531 17:10:10< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26461345
20140531 17:10:10-!- travis-ci [~travis-ci@ec2-54-83-134-82.compute-1.amazonaws.com] has left #wesnoth-dev []
20140531 17:12:06-!- travis-ci [~travis-ci@ec2-54-80-185-182.compute-1.amazonaws.com] has joined #wesnoth-dev
20140531 17:12:06< travis-ci> [travis-ci] gfgtdf/wesnoth-old#115 (remove_diffic - a517e21 : gfgtdf): The build passed.
20140531 17:12:06< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/26461404
20140531 17:12:06-!- travis-ci [~travis-ci@ec2-54-80-185-182.compute-1.amazonaws.com] has left #wesnoth-dev []
20140531 17:16:45-!- cib [~cib@p5DD21474.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140531 17:17:09-!- cib is now known as Guest47265
20140531 17:18:39-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Ping timeout: 252 seconds]
20140531 17:20:00< mordante> gfgtdf, why not, this macro you can see what it does, with the boost version you need to look at boost
20140531 17:20:06-!- Sulfur [~Miranda@p5B008545.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140531 17:20:12< mordante> gfgtdf, we just ask the compiler to give us the answer
20140531 17:20:43-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140531 17:20:47< gfgtdf> 	mordante: hm but for compiler that provide onyl some cpp features (__cplusplus >= 201103L can eigher be true or false
20140531 17:20:54< gfgtdf> some c++11 featues
20140531 17:21:37< gfgtdf> mordante: with boost config can do things like #if !defined(BOOST_NO_RVALUE_REFERENCES)  ... do seomthign with rvalues
20140531 17:21:59< mordante> gfgtdf, since we do not officially support C++11 this seems good enough
20140531 17:22:09-!- Sulfur [~Miranda@p5B008545.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140531 17:22:49< mordante> gfgtdf, and if one day we want to switch to C++11 we should do so if it's supported on all platforms
20140531 17:23:18< mordante> gfgtdf, I see the BOOST_NO_RVALUE_REFERENCES and friend macros mainly useful in library code not in application code
20140531 17:24:09< gfgtdf> mordante: well but with the current solution you simple remove all c++11 features from msvc. Even msvc 2013 which suposts  s lot of c++11 featues hasnt  "__cplusplus >= 201103L "
20140531 17:26:45< gfgtdf> mordante: and i still dont see any reason against boost config 
20140531 17:27:24< mordante> really who cares it doesn't use it in C++11, all code /must/ work with C++98
20140531 17:28:31< mordante> I mainly added it for using OVERRIDE and FINAL so the compiler can complain about invalid virtual specifiers
20140531 17:29:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Cheers]
20140531 17:37:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140531 17:39:53-!- travis-ci [~travis-ci@ec2-54-198-93-138.compute-1.amazonaws.com] has joined #wesnoth-dev
20140531 17:39:53< travis-ci> [travis-ci] wesnoth/wesnoth#2886 (master - 7aef411 : gfgtdf): The build was broken.
20140531 17:39:53< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26461530
20140531 17:39:53-!- travis-ci [~travis-ci@ec2-54-198-93-138.compute-1.amazonaws.com] has left #wesnoth-dev []
20140531 17:44:14-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 17:44:58-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Read error: Connection reset by peer]
20140531 17:47:06-!- travis-ci [~travis-ci@ec2-54-80-185-182.compute-1.amazonaws.com] has joined #wesnoth-dev
20140531 17:47:06< travis-ci> [travis-ci] wesnoth/wesnoth#2887 (master - dd8ac67 : gfgtdf): The build was broken.
20140531 17:47:06< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26461902
20140531 17:47:06-!- travis-ci [~travis-ci@ec2-54-80-185-182.compute-1.amazonaws.com] has left #wesnoth-dev []
20140531 17:49:17-!- lipkabb [~the_new_l@apn-94-44-255-216.vodafone.hu] has quit [Ping timeout: 255 seconds]
20140531 17:55:39-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Read error: Connection reset by peer]
20140531 17:57:36-!- molgrum [~molgrum@212.85.89.43] has quit [Read error: Connection reset by peer]
20140531 17:58:02-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140531 17:59:09-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140531 17:59:27-!- sachith500 [~kvirc@112.134.79.207] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140531 18:00:29< AI0867> okay, and what about the broken testcase?
20140531 18:01:51< AI0867> apparently, std::abs() doesn't give the same result as our previous abs() implementation
20140531 18:03:22< AI0867> mordante, gfgtdf: ^
20140531 18:04:44-!- lipkabb [~the_new_l@apn-94-44-255-216.vodafone.hu] has joined #wesnoth-dev
20140531 18:04:49< AI0867> that is, std::abs(config::attribute_value("1.499").to_long_long() - 1.499) > 1e-6
20140531 18:04:56< AI0867> well, >=
20140531 18:05:51< AI0867> I'm confused about the usage of to_long_long here though
20140531 18:06:36-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Quit: riksteri]
20140531 18:06:38< iceiceice_> y i saw that just now as well... im not sure why i am storing long long result in a double :/
20140531 18:06:45< iceiceice_> *yes i saw that just now as well
20140531 18:07:12< AI0867> how did that manage to work previously? did abs cast to an integer or something?
20140531 18:09:43-!- nurupo is now known as nurupo|
20140531 18:09:47-!- nurupo| is now known as nurupo
20140531 18:11:04-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140531 18:11:56< irker028> wesnoth: gfgtdf wesnoth:master 08ff7ba7fa3e / src/multiplayer_connect_engine.cpp: add comment about random tod http://git.io/K0GC-Q
20140531 18:12:33< mordante> AI0867, before abs casted as integral and fabs for floats, that was what C++11 complained about
20140531 18:12:48< mordante> AI0867, how do I run these tests?
20140531 18:12:52< AI0867> ./test
20140531 18:13:19< AI0867> `scons test` builds them, and I'm sure cmake can do it too
20140531 18:13:56< AI0867> iceiceice_: x_dbl: 1
20140531 18:14:16< AI0867> so yeah, one bug papered over another
20140531 18:14:32< iceiceice_> i think i made a snafu when i copy pasted something...
20140531 18:14:43< AI0867> well, go fix it ;)
20140531 18:14:46< iceiceice_> ok :)
20140531 18:17:53< mordante> AI0867, seems to be the test case is wrong
20140531 18:20:16< AI0867> yes
20140531 18:21:23< mordante> working on a fix
20140531 18:27:34< AI0867> I think I just semi-ordered iceiceice_ to do that
20140531 18:28:47< iceiceice_> y i am fixin git
20140531 18:28:48< AI0867> I'm wondering what IRC client you're using, and whether it's effecting your apparent ability to miss half the conversation
20140531 18:28:52< iceiceice_> i am running the test
20140531 18:31:15< irker028> wesnoth: Mark de Wever wesnoth:master bafab2261d36 / src/tests/test_config.cpp: Fix a broken test case. http://git.io/wcn7GQ
20140531 18:32:01-!- _8680_ [~8680@2002:4404:712c:0:9066:5782:6066:eec3] has quit [Remote host closed the connection]
20140531 18:32:22< mordante> AI0867, iceiceice_ got the message too late^
20140531 18:32:23-!- _8680_ [~8680@2002:4404:712c:0:c1ce:1895:6149:c180] has joined #wesnoth-dev
20140531 18:33:35< AI0867> mordante: well, the travis report of the broken build happened right in the middle of your conversation about that very commit
20140531 18:44:21-!- lipkabb [~the_new_l@apn-94-44-255-216.vodafone.hu] has quit [Ping timeout: 252 seconds]
20140531 18:44:26-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 276 seconds]
20140531 18:46:50-!- travis-ci [~travis-ci@ec2-54-83-134-82.compute-1.amazonaws.com] has joined #wesnoth-dev
20140531 18:46:50< travis-ci> [travis-ci] wesnoth/wesnoth#2889 (master - 08ff7ba : gfgtdf): The build is still failing.
20140531 18:46:50< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26465673
20140531 18:46:50-!- travis-ci [~travis-ci@ec2-54-83-134-82.compute-1.amazonaws.com] has left #wesnoth-dev []
20140531 18:47:06< thunderstruck> iceiceice_: I'm planning to leave sos save problem for now. I think that there are two separate problems there and I believe I fixed one of them. I.e. it's now possible to load these saves.
20140531 18:47:38< thunderstruck> But I'm not sure about why [carryover_sides_start] contain such data.
20140531 18:48:05-!- Guest47265 is now known as cib1
20140531 18:48:14< iceiceice_> ok i might look into the second part soon
20140531 18:49:14< iceiceice_> AI0867: sorry, i was too slow, had to change branches and stash work...
20140531 18:50:07< irker028> wesnoth: Chris Beck wesnoth:master 5aba222f004d / src/tests/test_config.cpp: fixup tests http://git.io/qYkWvg
20140531 18:50:09< irker028> wesnoth: Chris Beck wesnoth:master 50ed2187e1f3 / src/ (12 files in 2 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/2JFJ5Q
20140531 18:55:24-!- lipkabb [~the_new_l@apn-94-44-255-216.vodafone.hu] has joined #wesnoth-dev
20140531 18:55:46-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140531 18:56:32< gfgtdf> iceiceice_: are you plaing to backport the sos saves thign to 1.12 ?
20140531 18:57:27< iceiceice_> you mean thunderstrucks commit, or hypothetical future commits of mine?
20140531 18:57:44< gfgtdf> iceiceice_: both
20140531 18:58:08< iceiceice_> i would rather not have to backport other peoples commits esp. if there end up to be conflicts...
20140531 18:58:14< thunderstruck> My commit is on 1.12.
20140531 18:58:16< iceiceice_> but i may do it anyways
20140531 18:58:17< iceiceice_> oh
20140531 18:58:32< thunderstruck> Well, technically it's on a branch which was branched from 1.12.
20140531 18:58:44< iceiceice_> gfgtdf: i havent even begun to investigate this other issue so i have no idea if i will backport
20140531 18:59:08< iceiceice_> gfgtdf: i think we should backport the things on master from this past week, like now
20140531 18:59:15< gfgtdf> iceiceice_: i asked becasue i migth also fix this but my commit yould most likey not got into 1.12 then
20140531 18:59:18< iceiceice_> or its going to start to get insane
20140531 18:59:28< gfgtdf> iceiceice_: ye the other related init_side/save thing
20140531 18:59:34< thunderstruck> iceiceice_: And please note, that it's not ready to be merged in Wesnoth's repo. Code needs some clean up. I would do that if the other part would be fixed.
20140531 18:59:35< iceiceice_> y lets go back and do this
20140531 18:59:41< iceiceice_> ok
20140531 18:59:51< iceiceice_> thunderstruck: lets try to get all the commits appearing in the same order on 1.12 and master
20140531 19:00:09< gfgtdf> iceiceice_: can you backport my commit e50a7785fdf1008393656e57601ee89805ea91f3 ?
20140531 19:00:37< iceiceice_> ok
20140531 19:00:46< iceiceice_> i will get my list out that i made the other day --
20140531 19:01:06< iceiceice_> i know there was a change, you said not to backport PR 175 but i have to go and figure out whcih one that is
20140531 19:01:38< iceiceice_> http://hastebin.com/eyikorupot.hs
20140531 19:01:40< iceiceice_> gfgtdf: ^
20140531 19:03:42< AI0867> iceiceice_: any particular reason you haven't merged #171 yet?
20140531 19:04:17< gfgtdf> iceiceice_: hm i think form my commit i only see a reason to backport e50a7785fdf100839365,   
20140531 19:04:30< gfgtdf> iceiceice_: i think 2999dab6e4ca1be48c96787b5a7e89c090e455d3 shouldnt be byckported
20140531 19:04:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140531 19:05:11< gfgtdf> iceiceice_: and 59880e984bbfc5024d1e685a5f4608ca3c194129 will even brakc compabilit
20140531 19:06:36< iceiceice_> AI0867: i decided to pm elvish_hunter and ask him what he thought since he thought quite a bit about this particular function, but he didnt get back to me yet
20140531 19:07:00< iceiceice_> gfgtdf: y i knew 599880 needs to go
20140531 19:09:36< iceiceice_> gfgtdf: hmm i think i want to backport the child_or_add refactors though, it makes it easier to read and understand
20140531 19:09:48< iceiceice_> i'm plannign to back port several other refactors of mine in that list
20140531 19:10:09< iceiceice_> as long as they are strit refactor
20140531 19:10:56< iceiceice_> if u want i guess i could squash 28ffcc5 and b6efcec as part of the cherry-pick i guess
20140531 19:10:57-!- travis-ci [~travis-ci@ec2-54-80-185-182.compute-1.amazonaws.com] has joined #wesnoth-dev
20140531 19:10:57< travis-ci> [travis-ci] wesnoth/wesnoth#2890 (master - bafab22 : Mark de Wever): The build has errored.
20140531 19:10:57< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26466758
20140531 19:10:57-!- travis-ci [~travis-ci@ec2-54-80-185-182.compute-1.amazonaws.com] has left #wesnoth-dev []
20140531 19:10:59< gfgtdf> iceiceice_: i commented my commits in the list: http://hastebin.com/xafadideve.hs
20140531 19:11:28< iceiceice_> ok thanks
20140531 19:11:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 252 seconds]
20140531 19:23:58-!- travis-ci [~travis-ci@ec2-54-80-185-182.compute-1.amazonaws.com] has joined #wesnoth-dev
20140531 19:23:58< travis-ci> [travis-ci] wesnoth/wesnoth#2891 (master - 50ed218 : Chris Beck): The build was fixed.
20140531 19:23:58< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26467555
20140531 19:23:58-!- travis-ci [~travis-ci@ec2-54-80-185-182.compute-1.amazonaws.com] has left #wesnoth-dev []
20140531 19:32:51-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140531 19:33:28-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 19:33:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140531 19:36:39-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140531 19:36:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140531 19:40:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140531 19:43:09< iceiceice_> gfgtdf: i get conflicts at e50a7785fdf1008393656e57601ee89805ea91f3
20140531 19:43:14< iceiceice_> stemming from the "only_visual" field
20140531 19:44:11< iceiceice_> hmm i think its not a big deal but ill pastebin it anyways
20140531 19:47:37< shadowm> iceiceice_: In the past ayne responded to new bug reports assigned to her rather quickly, is that no longer the case?
20140531 19:47:53< shadowm> Also, it's worth pointing out that the commit you linked in your post was done for GSoC 2012.
20140531 19:49:51< iceiceice_> its only in 1.11 branch i think
20140531 19:49:55< iceiceice_> unless i misread 
20140531 19:49:55< shadowm> I find your accussation of lack of testing a little extreme and misleading. At the time 1.12 was branched, I was actively testing my campaign and the only bug that directly affected me was the issue with unit attacks from a distance not performing attacks.
20140531 19:50:39< iceiceice_> shadowm: i believe i found that at that time, it was impossible for an observer to join a reloaded game from the mp lobby
20140531 19:50:48< shadowm> Perhaps it'd be better to clarify that many of the issues found since then affect replay/MP.
20140531 19:50:54< iceiceice_> thats something you can find by clicking aroudn liek a monkey for about 3 minutes
20140531 19:51:21< shadowm> It's not surprising that we wouldn't know much about those because not all of us have the time or interest to play MP.
20140531 19:51:33< iceiceice_> shadowm: i'm not saying everything was broken, but i actually do think that it may have been the case that
20140531 19:51:41< iceiceice_> people tested their topic branches diligently but not master
20140531 19:51:58< shadowm> Also, the issues found in 1.11.14 were unexpected regressions since 1.11.13.
20140531 19:52:23< shadowm> At least one of them was an unintended side-effect of a bug fix.
20140531 19:52:39< shadowm> I wasn't testing any topic branches with my campaign.
20140531 19:52:54< iceiceice_> hmm well if i understand correctly we've had issues in the point and click interface at least since the planned overhaul was made to be not the default
20140531 19:53:21< shadowm> Since it became the default for a single release, actually.
20140531 19:53:43< iceiceice_> i think i was confused about this when i began developing, i thought that i was not able to click on units but actually i just didnt understand i needed to right click...
20140531 19:53:51< iceiceice_> but i never really figured out what the story was for sure
20140531 19:53:55< happygrue> I would like to create a beta test group with some perks and ask (especially with an eye toward MP but also for SP) for people what have had some presense, preferablly also a few submitted bugs, to test things out at regular intervals
20140531 19:54:12< iceiceice_> shadowm: regarding mp. look, either we support mp or we dont
20140531 19:54:18< happygrue> this was an issue after the last stable release too
20140531 19:54:18< shadowm> For that to happen there were some changes under the hood to allow mouse input scheme customization. Those weren't reverted.
20140531 19:54:20< iceiceice_> if mp becomes unusable thats a major regression
20140531 19:54:44< shadowm> iceiceice_: I'm saying that you can't accuse us of poor testing without being more specific.
20140531 19:54:57< iceiceice_> i think i was pretty specific
20140531 19:55:19< iceiceice_> i made a pretty specific suggestion,
20140531 19:55:28< iceiceice_> 3 people should guarantee to have clicked around for 10 minutes
20140531 19:55:35< iceiceice_> if that had happened i dont think 1.11.14 would have been tagged,
20140531 19:55:43< iceiceice_> and i hope that we would have foudn some problems before 1.12 was brnached
20140531 19:56:04< happygrue> It is also clear there were a number of things that were quite broken that if they had been tested (and reported) would have held up the relase, so saying we failed at testing seems accurate on some level.
20140531 19:56:11< shadowm> It's the "If we had done internal testing before forking 1.12" paragraph that irks me.
20140531 19:56:16< happygrue> surely some people tested some things, but not enough was done.
20140531 19:56:30< iceiceice_> shadowm: ok, i'll write a follow up to clarify
20140531 19:56:36< shadowm> Sure, we aren't thorough, but it's not like we do nothing at all.
20140531 19:56:42< happygrue> also true
20140531 19:57:36< shadowm> Also keep in mind that whatever we say in the mailing list can be taken out of context by a random outsider and sold to a sleazy OSS tabloid. :)
20140531 19:57:56< shadowm> "wesnoth developers don't do internal testing! read all about it!"
20140531 19:58:00< iceiceice_> hmm ok
20140531 19:59:25< shadowm> happygrue: Having a established crew of MP players testing dev releases would be great. Unfortunately I suspect having them test from Git would be more of a pipe dream.
20140531 19:59:49< shadowm> Not everyone wants/can compile from source all the time.
20140531 19:59:50< happygrue> at first, that does seem ambitious
20140531 20:01:32< happygrue> I have some thoughts but little time right now, I'll write up something for the ML
20140531 20:01:57< happygrue> shadowm: a few perks that come to mind:  I line in the credits, forum title, other?  Could that be doable?
20140531 20:03:08-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140531 20:03:09< shadowm> I'm not sure about credits entries, that depends on how stable the group's structure is, I guess. As for forum ranks... sure, why not?
20140531 20:03:17< happygrue> I would think to start by jut having them click around first thing after a release.  Maybe we could get them binaries 24-48 hours before the annoucement
20140531 20:03:42-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 20:05:11-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140531 20:05:27< lipkabb> mordante: Ping.
20140531 20:07:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140531 20:08:08< happygrue> I think a checklist of basic things to do would also be good.  My thought with credits is something like: join the group, complete the checklist for 5-10 releases on the development branch (or every beta release leading up to stable or some such) then they could get mentioned in a "1.12 beta testers" section
20140531 20:08:09-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140531 20:08:52< happygrue> but as you say, that could come later if such a group is actually somewhat successful
20140531 20:13:23< mordante> lipkabb, pong
20140531 20:13:54< irker028> wesnoth: Mark de Wever wesnoth:master 954e068a5488 / src/ (48 files in 12 dirs): Move create_rect to the sdl namespace. http://git.io/ZMhJqw
20140531 20:14:14< mordante> lipkabb, I had a linker issue with your latest code, this ^ fixes it
20140531 20:14:23< mordante> (and does a bit more)
20140531 20:15:26< lipkabb> Oh, thanks for fixing.
20140531 20:15:47< lipkabb> mordante: So you've looked at the patch?
20140531 20:15:53< mordante> but I guess you didn't ping me because of that ;-)
20140531 20:18:16< mordante> lipkabb, yes I had a look at the patch
20140531 20:18:42< mordante> lipkabb, as said before I'm not sure what the best way is so I'm happy with this way
20140531 20:18:43< lipkabb> mordante: I've realized that I didn't check for error codes after each SDL_Query call; is that necessary?
20140531 20:18:49< gfgtdf> AI0867: which "test" do yuou mean in https://github.com/wesnoth/wesnoth/pull/177 ?
20140531 20:19:28< mordante> I tend to check after every call, not sure whether it is really required
20140531 20:19:45< mordante> I doubt C-coders will do it in C
20140531 20:20:05< mordante> (which is somewhat an issue with error handling in C)
20140531 20:21:33< lipkabb> Okay, I'll leave it as is for the time being, then.
20140531 20:22:32< lipkabb> mordante: Another thing: the next task is creating accelerated siblings for the rest of the functions in sdl_utils.
20140531 20:23:05< lipkabb> I thought this would be a good time to move sdl_utils into sdl/utils; what do you think?
20140531 20:24:12< mordante> lipkabb, I just did with the SDL_Rect ;-)
20140531 20:24:30< iceiceice_> shadowm: do you think my next email helped at all?
20140531 20:24:30< mordante> for the rest of the utils I would prefer to split the code in smaller headers
20140531 20:25:03< mordante> that way we don't create a new god header that forces a complete recompilation for every (minor) change
20140531 20:25:06< iceiceice_> also, am i wrong in my understanding of what "beta" means?
20140531 20:25:26< iceiceice_> my impression is that making a "large" revert in 1.12 branch would be a big no-no
20140531 20:25:44< iceiceice_> so it seems like a possible catch 22 if we branch new-stable at a bad time
20140531 20:29:15< shadowm> Yes, it's much clearer this way.
20140531 20:29:58< shadowm> As for the alpha/beta thing, any major code changes during beta are a bad idea since you never know when you failed to account for something that breaks a multitude of other things. Reverting large chunks of code is merely a particular case of this.
20140531 20:30:48< mordante> lipkabb, any more questions? I'll be leaving soon
20140531 20:30:51< shadowm> And 1.11.0 through 1.11.9 are implicitly the alpha phase.
20140531 20:31:18< lipkabb> mordante: I could do the split-up too, if you don't insist on doing it yourself.  (Or haven't done it already :P)
20140531 20:31:23< lipkabb> Nothing else.
20140531 20:33:09< mordante> haven't done the split-up ;-)
20140531 20:33:31< mordante> also not sure whether we need to copy the function 1 on 1 or look closer at them
20140531 20:33:56< mordante> it might be SDL2 offers options for a different API
20140531 20:35:25-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140531 20:35:52< lipkabb> My primary targets are the rectangle drawing functions, those could be nicely implemented via SDL2-s primitive API.
20140531 20:36:00-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 20:36:30< lipkabb> As for the surface manipulating stuff, I haven't checked thoroughly, but I think those are covered by ttexture's methods.
20140531 20:36:48< lipkabb> *SDL2's
20140531 20:37:08< iceiceice_> gfgtdf: 
20140531 20:37:19< iceiceice_> i got a wierd conflict in backport:
20140531 20:37:59< iceiceice_> http://hastebin.com/yepotaciyo.tex
20140531 20:38:14< mordante> exactly so we need to look what is and what is not needed from sdl_utils for SDL2
20140531 20:38:19< iceiceice_> it looks like we dont call before_human_turn / after_human_turn type things in the same places in 1.12 and master?
20140531 20:38:24< iceiceice_> i want to make sure i do the right thing here
20140531 20:38:30< iceiceice_> was there something earlier that should have been backported??
20140531 20:40:44< gfgtdf> iceiceice_: hmm tehre was something about skipped turns but i dotn remember exactly
20140531 20:40:53< iceiceice_> :O
20140531 20:40:58< iceiceice_> urghh
20140531 20:41:24< lipkabb> mordante: Well, we do need everything right now, unless someone's going to convert everything to ttexture overnight :)
20140531 20:41:34< gfgtdf> iceiceice_: 3b66f522980ad7c31657a93fdd44549e2f6ce11d
20140531 20:41:59< lipkabb> Or do you want to move only the stuff that's going to be used on a longer term?
20140531 20:42:36< gfgtdf> iceiceice_:  i think that should also be backported, maybe i just forget to backport it
20140531 20:42:42< iceiceice_> ok
20140531 20:42:50< iceiceice_> i guess we will likely discover all such things in the cherry-pick process
20140531 20:44:25< gfgtdf> iceiceice_: the commit above most likley gets mergign ginclocts becasue of e80fc181aea84ec9a0b26c61ed49c18a3410143d
20140531 20:44:41< gfgtdf> s/ginclocts(conflicts
20140531 20:45:15< gfgtdf> but i dont think there is a reason to backport e80fc181aea84ec9a0b26c61ed49c18a3410143d
20140531 20:46:09< iceiceice_> ok i wont backport if you dont want to
20140531 20:47:12< iceiceice_> it depends how many conflicst i get ...
20140531 20:47:19< mordante> lipkabb, not 100% sure what is the best way, what do you prefer?
20140531 20:47:29-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.]
20140531 20:48:00-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140531 20:48:37< iceiceice_> 3b66f only gives one conflict: http://hastebin.com/yorotupiya.tex
20140531 20:48:41-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140531 20:49:32< lipkabb> mordante: I lean towards moving everything and not making assumptions at this point about what's going to be removed.
20140531 20:50:02< lipkabb> Even if we once completely eliminate SDL_Surface from the code base, that might take a while.
20140531 20:50:19< iceiceice_> hmm its just a whitespace conflict i think
20140531 20:52:23< gfgtdf> no it's not
20140531 20:52:30< gfgtdf> but still you can just delete that bock
20140531 20:52:57< gfgtdf> iceiceice_: ^
20140531 20:53:08< iceiceice_> ok
20140531 20:53:51< AI0867> gfgtdf: the test that failed just now: to_long_long + abs/std::abs
20140531 20:54:08-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140531 20:54:21< mordante> lipkabb, seems acceptable, then it also doesn't make sense to split the sdl_utils into nice chunks
20140531 20:54:32< gfgtdf> AI0867: hm but i dint playn to remove that test my play was to inore that test since it sunrelated to my commit
20140531 20:54:53-!- cib1 [~cib@p5DD21474.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140531 20:55:11< gfgtdf> ignore*
20140531 20:55:44< lipkabb> mordante: Yeah, except possibly the rectangle things that would fit nicely in rect.
20140531 20:56:00< lipkabb> create_rect is so lonely there right now :)
20140531 20:57:35< iceiceice_> gfgtdf: 
20140531 20:57:35< iceiceice_> http://hastebin.com/ezeqorotum.coffee
20140531 20:57:55< iceiceice_> should 1.12 be sending turn data there?
20140531 21:00:27< mordante> lipkabb, true and true
20140531 21:01:10< gfgtdf> iceiceice_: it it didnt send before then it shouldnt i replayced "init_turn_data" with send_data.
20140531 21:02:35-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140531 21:02:39< AI0867> gfgtdf: true, but having travis pass your PR is always nice
20140531 21:02:55-!- gfgtdf_ [~chatzilla@e177164020.adsl.alicedsl.de] has joined #wesnoth-dev
20140531 21:03:20-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 21:03:26< iceiceice_> gfgtdf: hmm the cherry-pick seems to be introducing both "send_data" and init_turn_data....
20140531 21:03:44< gfgtdf_> :/
20140531 21:03:55< iceiceice_> if im reading the diff correclty
20140531 21:04:02< iceiceice_> maybe im reading 3way diff wrong
20140531 21:05:11-!- gfgtdf [~chatzilla@e177125237.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140531 21:05:20-!- gfgtdf_ is now known as gfgtdf
20140531 21:05:39< iceiceice_> hmm ok i think the cherry-pick is only bringing the send data
20140531 21:05:45< iceiceice_> so 1.12 shoudl just have init_turn_data?
20140531 21:06:08< gfgtdf> ye
20140531 21:13:20-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140531 21:13:59-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 21:15:01-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW]
20140531 21:15:43< iceiceice_> hmm ok, last conflict is this one:
20140531 21:15:43< iceiceice_> https://github.com/wesnoth/wesnoth/commit/ee89299987634b6aab7356005cff44d2f0740626
20140531 21:16:06< iceiceice_> http://hastebin.com/uxicitifar.coffee
20140531 21:17:00< gfgtdf> iceiceice_: they sync_netgwork shoudl stay there
20140531 21:17:01< iceiceice_> in master there is not this line turn_data.sync_network
20140531 21:17:04< iceiceice_> in 1.12 htere is
20140531 21:17:05< iceiceice_> hmm ok
20140531 21:17:15< gfgtdf> iceiceice_:  i replaced it 
20140531 21:17:25< gfgtdf> iceiceice_: with turn_info_sync sync_safe(turn_data_); above
20140531 21:17:41-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20140531 21:20:00< iceiceice_> ok thats the last time i try to cherry-pick things from a week ago to 1.12 :O
20140531 21:20:17< iceiceice_> i think we have to cherry-pick bugfxies immediately,
20140531 21:20:28< iceiceice_> i didnt realize the network code had divergred so much between 1.12 and master
20140531 21:20:46< iceiceice_> i dont think it is at all sound anymore to test things on master and assume they work on 1.12...
20140531 21:21:16< iceiceice_> hmm i think it might be a good idea to make a branch "1.12 + wml unit tests"
20140531 21:21:19< iceiceice_> that gets continually rebased
20140531 21:21:21< iceiceice_> to 1.12
20140531 21:24:44< iceiceice_> gfgtdf: https://github.com/wesnoth/wesnoth/pull/178
20140531 21:24:56< iceiceice_> can u make sure that all looks right?
20140531 21:25:40< iceiceice_> if travis builds it ok with gcc as well then i guess we should merge right away
20140531 21:29:49-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140531 21:30:19-!- trewe [~trewe@2001:8a0:d13d:6401:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20140531 21:33:12-!- Sulfur [~Miranda@p5B008545.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140531 21:41:25-!- haudegen [~quassel@77.119.131.90] has joined #wesnoth-dev
20140531 21:44:35< gfgtdf> iceiceice_: it is possible to make a pr to another branch than master ?
20140531 21:44:46< gfgtdf> how is it*
20140531 21:45:38< AI0867> that's simple enough
20140531 21:46:11< AI0867> when in the compare view, there's a bar with the two branches up top
20140531 21:46:17< gfgtdf> ah ok
20140531 21:46:20< AI0867> on the right there's an 'edit' button
20140531 21:46:29< iceiceice_> gfgtdf: yeah
20140531 21:48:16< iceiceice_> gfgtdf: im going for food, feel free to pull 178 if it all looks good ofc
20140531 21:48:21-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140531 22:12:49-!- lipkabb [~the_new_l@apn-94-44-255-216.vodafone.hu] has quit [Quit: Vannak idők, mikor menni kell]
20140531 22:22:33< mordante> I'm off bye
20140531 22:22:44< irker028> wesnoth: Mark de Wever wesnoth:master 81debc2fdba7 / src/gui/ (22 files in 5 dirs): Update formatting. http://git.io/DQ7ZdQ
20140531 22:22:46< irker028> wesnoth: Mark de Wever wesnoth:master b3403e29e86a / src/gui/auxiliary/event/handler.cpp: Disable the unicode for SDL2 key events. http://git.io/2BrVdw
20140531 22:22:49< irker028> wesnoth: Mark de Wever wesnoth:master abee16b16efc / src/gui/ (11 files in 2 dirs): Convert the GUI2 text API to take strings. http://git.io/x7b1mQ
20140531 22:22:50< irker028> wesnoth: Mark de Wever wesnoth:master 5cfd93488b05 / src/gui/auxiliary/event/handler.cpp: Implement the SDL2 text input event in GUI2. http://git.io/DnzNXA
20140531 22:22:52< irker028> wesnoth: Mark de Wever wesnoth:master 6deda4ca7f67 / src/gui/ (29 files in 4 dirs): Merge branch 'SDL2_GUI2_input' http://git.io/eQ0x1w
20140531 22:23:12-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140531 22:39:28-!- mjs-de [~mjs-de@f048194175.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140531 22:55:21-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 246 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140531 22:58:26-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140531 22:59:03-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 23:03:41-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140531 23:08:15-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer]
20140531 23:12:00-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140531 23:15:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140531 23:26:46< gfgtdf> does anyone knows what "parent" is savefeils does ?
20140531 23:26:49< gfgtdf> know*
20140531 23:27:43< iceiceice> gfgtdf: i think there are a bunch of savefiles that are about some kind of auto threading of savefiles
20140531 23:27:48< iceiceice> i dont really know what that means exactly,
20140531 23:28:00< iceiceice> if it refers to like, autosaves? or saves in a sequence from a campaign?
20140531 23:28:01< gfgtdf> iceiceice: what does auto threading mean ?
20140531 23:28:10< gfgtdf> iceiceice: n it unrelated to campaigns
20140531 23:28:29< iceiceice> idk i think will have to grep and google it, thats all i rememeber
20140531 23:28:50< gfgtdf> iceiceice: its just the name of teh savefeile that was saved before
20140531 23:28:54< iceiceice> *sorry i miswrote
20140531 23:28:57< gfgtdf> iceiceice: unrelated to in which campaign
20140531 23:29:09< iceiceice> *i think there are a bunch of code comments related to savefiles related to auto threading
20140531 23:35:34-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140531 23:36:07-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 23:36:40< iceiceice> hmm
20140531 23:36:46< iceiceice> it looks like theres still minor issues with end of scenario saves
20140531 23:37:01< iceiceice> for mp anyways
20140531 23:37:07< iceiceice> i didnt test sp yet
20140531 23:37:19< iceiceice> gfgtdf: do you think we should serialize the "linger_" variabe?
20140531 23:37:55< gfgtdf> iceiceice: i think completition=" .. which we save in teh savefile already impled that.
20140531 23:38:08< gfgtdf> linger_ = completition!=  running 
20140531 23:38:14< iceiceice> hmm
20140531 23:38:25< iceiceice> so i find that, 
20140531 23:38:27< gfgtdf> but im not 100% sure
20140531 23:38:29< iceiceice> if i run an mp scenario 
20140531 23:38:32< iceiceice> droid both sides 
20140531 23:38:35< iceiceice> and let it run to complete
20140531 23:38:38< iceiceice> and save it,
20140531 23:38:42< iceiceice> then... 
20140531 23:39:02< iceiceice> if i load as sp, it works and i go to linger, but the gui jumps around alot as soon as you load,
20140531 23:39:09< iceiceice> like it sets the gui to warp to each side in rapid succession
20140531 23:39:11< gfgtdf> iceiceice:  in local or in networked mp ?
20140531 23:39:15< iceiceice> local mp
20140531 23:39:24< iceiceice> if i load the save as mp, it doesnt actually go to linger
20140531 23:39:28< iceiceice> this is testing PR 178
20140531 23:39:40< iceiceice> btw do you see any reason not to merge that right away?
20140531 23:39:50< gfgtdf> no i don't
20140531 23:39:55< iceiceice> ok im going to merge then
20140531 23:40:56< gfgtdf> iceiceice: if you driod teh 2 sides do you get a victors or defeat ?
20140531 23:41:14< iceiceice> hmm wait actually
20140531 23:41:20< iceiceice> this time that i tested it was networked
20140531 23:41:26< iceiceice> the original game i mean
20140531 23:44:31< gfgtdf> iceiceice: hm when i reload a local mp game in which i droided dies i get a you are defeated message and thebn immideately linger
20140531 23:44:54< gfgtdf> iceiceice: this seems to be teh intended behaviour
20140531 23:45:02< iceiceice> on which branch?
20140531 23:45:17< iceiceice> i get the same behavior in local and networekd for mp,
20140531 23:45:20< iceiceice> its only sp thats different for me
20140531 23:45:28< iceiceice> sp = titlescreen => load
20140531 23:46:02-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140531 23:46:03< gfgtdf> iceiceice: master + r 177
20140531 23:46:24< iceiceice> im testing 1.12 + PR 178
20140531 23:46:40-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140531 23:47:18< gfgtdf> i reloaded a local mp game in the titlescreen load dialog
20140531 23:47:40< iceiceice> after it was linger?
20140531 23:47:56< gfgtdf> yes i sved from liner mode
20140531 23:48:05< iceiceice> hmm well maybe its different on master and 1.12
20140531 23:48:11< iceiceice> can you try on 1.12?
20140531 23:48:11< gfgtdf> saved*
20140531 23:48:46< gfgtdf> iceiceice: hm ok i'll downlaod 1.11.15 but taht coudl take a while
20140531 23:49:01< gfgtdf> (still faster than compiling)
20140531 23:49:17< iceiceice> can you pull cbeck88/1.12+bufix_backports_ii ?
20140531 23:50:12< iceiceice> b/c 1.15 wont have the relevant commits
20140531 23:50:18< iceiceice> *1.11.15
20140531 23:50:51< gfgtdf> :/ you sure this cahnges with these commits ?=
20140531 23:51:06< iceiceice> well i added a check to the saving of end of scenario saves
20140531 23:51:08< iceiceice> so it must be changing
20140531 23:51:21< iceiceice> https://github.com/cbeck88/wesnoth/commit/24eab27b52d0177f58be819b6190551cc586cb70
20140531 23:51:24< gfgtdf> and that check failed ?
20140531 23:51:26< iceiceice> this is the cherry-picked from master
20140531 23:51:48< iceiceice> if you dont have this you get wierd saves where all the units are missing
20140531 23:52:22< iceiceice> im just pointing it out as a thing we havent totally fixed yet, idk if we made new problems
20140531 23:52:31< iceiceice> i think these saves weren't working before either
20140531 23:52:41< iceiceice> but if they are working on current master then that's wierd
20140531 23:53:38< gfgtdf> hm you got teh error when reloading in mo or in sp ?
20140531 23:53:48< gfgtdf> i still didnt understant
20140531 23:53:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20140531 23:54:23< iceiceice> i got two different wierd behaviors
20140531 23:54:35< iceiceice> from loading an end of scenario save of an mp game
20140531 23:54:48< iceiceice> the first behavior is, when you load it, the screen jumps around a lot
20140531 23:55:05< gfgtdf> iceiceice: maybe it does teh usualy "scroll to leader" ?
20140531 23:55:09< iceiceice> my gues is that it is doing the "warp to leader" in succession for all of the teams
20140531 23:55:16< iceiceice> that affects all realods
20140531 23:55:26< iceiceice> the second behavior is, you dont end upin linger mode,
20140531 23:55:35< iceiceice> you dont have the linger mode overall, all your units have moves and you can move them
20140531 23:55:48< iceiceice> s/overall/overlay
20140531 23:56:08< iceiceice> that only affects reloading in mp
20140531 23:56:31< gfgtdf> iceiceice: hm wait
20140531 23:56:41< gfgtdf> iceiceice: maybe my current version is a little outdated
20140531 23:56:52< gfgtdf> iceiceice: i dont see teh units at all
20140531 23:56:56< gfgtdf> iceiceice:  liek before
20140531 23:56:58< gfgtdf> like
20140531 23:56:59< iceiceice> y my commit is supposed to fix that
20140531 23:57:07< iceiceice> 24eab27b
20140531 23:58:19< gfgtdf> iceiceice: i im compiling right not current master
20140531 23:58:42< gfgtdf> iceiceice: i think i maybe just get defeated becasue i have no units ..
20140531 23:59:02< iceiceice> hm wait you think being defeated after droiding side is a bug?
20140531 23:59:16< iceiceice> i think its not a bug,
20140531 23:59:29< iceiceice> the code in check vicotry is that, at the very last line when scenario ends,
20140531 23:59:37< iceiceice> its victory if there is a local human not defeated side
20140531 23:59:39< iceiceice> and defeat otherwise
20140531 23:59:57< iceiceice> so if you droid your side and the droid wins, its defeat
--- Log closed Sun Jun 01 00:00:15 2014