--- Log opened Sun Jun 01 00:00:15 2014
--- Day changed Sun Jun 01 2014
20140601 00:00:15< gfgtdf> iceiceice: ye i think that was ne of teh purposes of human_ai  controller that you still winds if teh ai winds teh scenario "for you"
20140601 00:00:18< gfgtdf> one
20140601 00:00:19< irker028> wesnoth: David Mikos wesnoth:master d7ba99aaaadb / changelog src/mouse_events.cpp: Fix bug #22116: unlock movement when attacking enemy+discovering in fog http://git.io/sy8l0w
20140601 00:00:32< irker028> wesnoth: David Mikos wesnoth:1.12 0a0b0a24fb34 / changelog src/mouse_events.cpp: Fix bug #22116: unlock movement when attacking enemy+discovering in fog http://git.io/n4gU2g
20140601 00:00:38-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140601 00:00:39< iceiceice> gfgtdf: y i think that was the reason it was added i guess...
20140601 00:00:51< iceiceice> human ai was like an "actually human" side that was droided
20140601 00:00:57< iceiceice> but since no one understood it, it had to go
20140601 00:01:44< gfgtdf> iceiceice: ok what happens if you manual open teh savefeile an chenge completion = to "victory" ?
20140601 00:02:00< gfgtdf> manualy
20140601 00:02:06-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140601 00:03:14< iceiceice> hmm i am recompiling to master atm, i will cancel to check though
20140601 00:03:49< gfgtdf> iceiceice: maybe i foudn the reason
20140601 00:04:17< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/blob/master/src/playmp_controller.cpp#L314
20140601 00:04:40< gfgtdf> iceiceice: the playsing_controller does it differently we have to do it teh same was in playmp_controller
20140601 00:05:03< gfgtdf> iceiceice: didint we taks about how bad it is that they a implemented so differently just yesterday ?
20140601 00:05:09< iceiceice> y
20140601 00:05:56< gfgtdf> iceiceice: try replacing teh line above with tis line: https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L842
20140601 00:06:17< gfgtdf> and you have to copy the set_completion  too or move it inot playsingles header
20140601 00:07:00< gfgtdf> that clas i mean
20140601 00:07:02< gfgtdf> iceiceice: ^
20140601 00:07:56< iceiceice> does the header include gamestate.hpp?
20140601 00:08:23< iceiceice> hmm im just oging to move it to gamestate.hpp actually maybe
20140601 00:08:27< gfgtdf> iceiceice: idk why do you ask ?
20140601 00:08:37< gfgtdf> iceiceice: i dont liek that
20140601 00:08:42< iceiceice> why?
20140601 00:08:54< gfgtdf> iceiceice:  want to cahnge that file ind i'd be happy if it'd be rather smaller than bigger
20140601 00:09:10< iceiceice> hmm ok i'll put it in playsingle_controller.hpp
20140601 00:12:21-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 00:12:58-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 00:16:19< iceiceice> ok that wroks
20140601 00:17:27-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 00:18:03-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 00:20:10< gfgtdf> :)
20140601 00:22:04-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 00:22:07-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140601 00:22:39-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 00:22:52< gfgtdf> iceiceice: did you test whether teh bug that the line intended to fix exists in teh current version 15545?
20140601 00:23:15< iceiceice> no im still testing it
20140601 00:24:18< iceiceice> i think recalllist is populated in the carryover anyways though
20140601 00:27:22< iceiceice> hmmm...
20140601 00:27:27< iceiceice> no it makes that bug return apparently
20140601 00:28:03< iceiceice> err,
20140601 00:28:22< iceiceice> in my current version wth the if (!linger) deleted,
20140601 00:28:32< iceiceice> if you play the south guard scenario 1 on droid,
20140601 00:28:36< iceiceice> and undroid at the last second,
20140601 00:28:42< iceiceice> and save in linger mode,
20140601 00:28:47< iceiceice> you wont have any recalls available apparently
20140601 00:29:24-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 00:29:58-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 00:32:23< gfgtdf> iceiceice: how did you test it ?
20140601 00:32:31< gfgtdf> im a moral sp cmpaign ?
20140601 00:32:34< gfgtdf> normal
20140601 00:33:00< iceiceice> normal sp campaign
20140601 00:33:04< iceiceice> just load up south guard
20140601 00:33:06< iceiceice> droid at turn 1
20140601 00:33:13< iceiceice> let it go for a minute or so,
20140601 00:33:23< iceiceice> i checked back to make sure droid didnt end scenario,
20140601 00:33:26< iceiceice> idk if that was necessary
20140601 00:33:29< iceiceice> maybe can undroid before save?
20140601 00:33:40< iceiceice> i assume something will break if you save with droid controlling
20140601 00:33:42< gfgtdf> and tehn you had no recall in the next scenario ?
20140601 00:33:45< iceiceice> y
20140601 00:34:30< iceiceice> hmm im goign to try without relaoding
20140601 00:34:31< gfgtdf> iceiceice: i think we maybe should save teh carryover (which contains recalls after the linger mode)
20140601 00:34:32< iceiceice> and see if it sbroken
20140601 00:34:54< gfgtdf> iceiceice:  currently we do that when teh "you get victory" message shows up
20140601 00:35:28< iceiceice> hmm the carryover is not stored in the savefil?
20140601 00:35:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140601 00:35:57< iceiceice> y i think it is broken because of the reload
20140601 00:36:29< iceiceice> it works if i dont reload
20140601 00:36:32< iceiceice> like, i will have recalls
20140601 00:36:38< iceiceice> even if droid was victorious
20140601 00:37:13< iceiceice> y it sounds like lingermode saves will only work if we save the carryover
20140601 00:38:08< iceiceice> hmm i wonder how long this has been broken...
20140601 00:38:19< iceiceice> i bet since the commit mentioned in email
20140601 00:38:28< iceiceice> or roughly then
20140601 00:39:06< gfgtdf> iceiceice: i dont even proceed to teh next scenario in this case :/
20140601 00:39:12< gfgtdf> whe  i reload form linger
20140601 00:39:21< iceiceice> hmm
20140601 00:39:22< gfgtdf> from*
20140601 00:39:35< gfgtdf> iceiceice: that casn be related to my recent change though
20140601 00:39:39< gfgtdf> that are onyl on master
20140601 00:39:44-!- haudegen [~quassel@77.119.131.90] has quit [Remote host closed the connection]
20140601 00:40:06-!- haudegen_ [~quassel@77.119.131.90.wireless.dyn.drei.com] has joined #wesnoth-dev
20140601 00:40:28< iceiceice> idk...
20140601 00:40:41< iceiceice> i think we need to merge this pr like now.
20140601 00:40:55< iceiceice> lets make a bug report for, reloading save game from linger mode in sp is broken
20140601 00:41:09< iceiceice> i'm going to commit the save_completion thing beause i dont see how that could be wrong
20140601 00:41:24-!- haudegen_ [~quassel@77.119.131.90.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140601 00:42:10< iceiceice> hmm oh
20140601 00:42:23-!- trewe [~trewe@2001:8a0:d13d:6401:626c:66ff:fe92:9b7c] has quit [Ping timeout: 245 seconds]
20140601 00:42:31< iceiceice> gfgtdf: i need to forward port the playmp_controller set_completion_setter to master
20140601 00:42:45< iceiceice> b/c i think its only on my 1.12 + branch now
20140601 00:42:52< iceiceice> so that mgiht be why you didnt go to the next scenario
20140601 00:43:17< gfgtdf> hmm
20140601 00:43:41< gfgtdf> nothat was an sp save
20140601 00:44:04< gfgtdf> it is most liley related to the "advnace to the next scenario if a network player does" commit
20140601 00:44:33< gfgtdf> iceiceice: that the decision whjether to advance to teh next scenario is bugged the reload from linger case now
20140601 00:44:53< iceiceice> ok
20140601 00:45:01< iceiceice> i should still port this change to master though?
20140601 00:46:50< iceiceice> https://github.com/cbeck88/wesnoth/commit/eccc67c0b1643983138f56477e5110401f0ba904
20140601 00:49:11< gfgtdf> iceiceice: i'd ´say yes
20140601 00:49:22< gfgtdf> iceiceice: i think fixing the other thing is also easy
20140601 00:49:47-!- Samual [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 240 seconds]
20140601 00:52:36-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 00:53:12-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 01:05:54< gfgtdf> iceiceice: the think that i introduced not te original bug i mean
20140601 01:06:00< gfgtdf> thing
20140601 01:14:17< iceiceice> man this is pretty annoying
20140601 01:14:24< iceiceice> change to play controller header causes full ai rebuild :O
20140601 01:17:13< iceiceice> hmm actually im not sure why im full rebuilding?
20140601 01:17:18< iceiceice> i guess its the other things i had to pull
20140601 01:18:30< iceiceice> oh i think its the sdl stuff
20140601 01:26:42-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 01:27:19-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 01:35:05-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 01:35:23-!- sachith500 [~kvirc@112.134.192.177] has joined #wesnoth-dev
20140601 01:35:45-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 01:38:05< gfgtdf> iceiceice: ok i was able the reproduce the "recalls lost" bug too on master
20140601 01:38:24< iceiceice> ok
20140601 01:38:43< iceiceice> i am about to push the linger mode thing
20140601 01:39:01-!- Turuk [Turuk@cpe-65-31-55-246.woh.res.rr.com] has joined #wesnoth-dev
20140601 01:39:04< irker028> wesnoth: Chris Beck wesnoth:master 03254fdb1e0b / src/ (playmp_controller.cpp playsingle_controller.cpp playsingle_controller.hpp): use completion setter object in mp linger mode http://git.io/ePJ4Mw
20140601 01:41:18-!- Turuk [Turuk@cpe-65-31-55-246.woh.res.rr.com] has quit [Client Quit]
20140601 01:41:33< irker028> wesnoth: gfgtdf wesnoth:1.12 5b94adc89eac / src/playsingle_controller.cpp: fix skip turn when a side has no units http://git.io/QummUA
20140601 01:41:35< irker028> wesnoth: Chris Beck wesnoth:1.12 5ed8494a895e / src/play_controller.cpp: save play_controller.init_side_done as a toplevel member of snapshot http://git.io/3MGByw
20140601 01:41:37< irker028> wesnoth: Chris Beck wesnoth:1.12 fe3395ccfea1 / src/playsingle_controller.cpp: call maybe_do_init_side when the engine starts a sides turn http://git.io/44REdA
20140601 01:41:39< irker028> wesnoth: gfgtdf wesnoth:1.12 c3d599dcbe01 / src/playcampaign.cpp: use config::child_or_add http://git.io/qTVxaw
20140601 01:41:41< irker028> wesnoth: gfgtdf wesnoth:1.12 26470b3836d8 / src/ (play_controller.cpp play_controller.hpp): fix reloading http://git.io/IEE0rg
20140601 01:41:43< irker028> wesnoth: Chris Beck wesnoth:1.12 0e5502688923 / src/play_controller.hpp: remove unnecessary virtual qualifiers http://git.io/JkOl6Q
20140601 01:41:45< irker028> wesnoth: Chris Beck wesnoth:1.12 f2504d85560a / src/play_controller.cpp: assert that do_init_side functions are never called with bad arg http://git.io/deHZMg
20140601 01:41:47< irker028> wesnoth: Chris Beck wesnoth:1.12 50f89d522a8c / src/ (6 files): remove unnecessary arguments http://git.io/JbqyJg
20140601 01:41:49< irker028> wesnoth: Chris Beck wesnoth:1.12 43d313683676 / src/ (7 files): remove more unnecessary arguments, from play_controller::play_side http://git.io/ttqI6w
20140601 01:41:51< irker028> wesnoth: Chris Beck wesnoth:1.12 a632aae4fd8a / src/playsingle_controller.cpp: fix gcc compilation http://git.io/ygB6Mw
20140601 01:41:53< irker028> wesnoth: Chris Beck wesnoth:1.12 22caf302535b / src/ (7 files): remove unnecessary arguments http://git.io/5GSruw
20140601 01:41:55< irker028> wesnoth: Chris Beck wesnoth:1.12 24eab27b52d0 / src/play_controller.cpp: fixup end of scenario saves http://git.io/Vz5fOQ
20140601 01:41:56-!- Turuk [Turuk@cpe-65-31-55-246.woh.res.rr.com] has joined #wesnoth-dev
20140601 01:41:57< irker028> wesnoth: Chris Beck wesnoth:1.12 8e4f94687f8c / src/playsingle_controller.cpp: fixup 77ead906927bec69d9136d349d637458f7a553f0 http://git.io/mWNYCQ
20140601 01:41:59< irker028> wesnoth: gfgtdf wesnoth:1.12 4c3bc2cdb03f / src/playsingle_controller.cpp: fix player_type_changed durign ai turn http://git.io/uokCAQ
20140601 01:42:01< irker028> wesnoth: Chris Beck wesnoth:1.12 eccc67c0b164 / src/ (playmp_controller.cpp playsingle_controller.cpp playsingle_controller.hpp): use completion setter object in mp linger mode http://git.io/49REjQ
20140601 01:42:03< irker028> wesnoth: Chris Beck wesnoth:1.12 60784562a33d / src/ (11 files): Merge pull request #178 from cbeck88/1.12+bufix_backports_ii http://git.io/Pn2jWw
20140601 01:43:07-!- sachith500 [~kvirc@112.134.192.177] has quit [Read error: Connection reset by peer]
20140601 01:44:16-!- sachith500 [~kvirc@112.134.192.177] has joined #wesnoth-dev
20140601 01:45:39-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 01:46:11-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 01:48:43< gfgtdf> iceiceice: do you knwo why we return VICTORY instead of SKIP_TOLINER in playsingle controller ?
20140601 01:48:56-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has quit [Read error: Connection reset by peer]
20140601 01:49:13< iceiceice> where?
20140601 01:49:48< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L579
20140601 01:50:11-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has joined #wesnoth-dev
20140601 01:50:16< iceiceice> are those enums of the same type?
20140601 01:50:25< gfgtdf> iceiceice: yes
20140601 01:50:32< iceiceice> hmm idk then
20140601 01:50:43-!- sachith500 [~kvirc@112.134.192.177] has quit [Read error: Connection reset by peer]
20140601 01:50:58< iceiceice> hmm i mean
20140601 01:50:59< gfgtdf> iceiceice: a good try for 1.12 woudl be returning SKIP_TO_INGER there and then out a if(res== skip_to_linger) {res = VICTORY} at th end of playsingle_scenario in playcampaign.cpp
20140601 01:51:05< gfgtdf> put*
20140601 01:52:15< iceiceice> good try to fix 15545?
20140601 01:52:17< iceiceice> or just in general
20140601 01:52:31< gfgtdf> to fix teh "recalls lost" bug
20140601 01:53:35< irker028> wesnoth: Chris Beck wesnoth:master 7828466e1a40 / changelog: update changelog http://git.io/FW8mqg
20140601 01:55:44< iceiceice> y i think you are right
20140601 01:55:48< iceiceice> maybe we should try it and test it,
20140601 01:55:53< iceiceice> and if it works then do it for playmp_scenario and the others there?
20140601 01:57:16< irker028> wesnoth: gfgtdf wesnoth:master 064dcc3d4eaa / src/ (5 files): fixup carryover_on_defeat http://git.io/15-tHg
20140601 01:57:17< gfgtdf> iceiceice: hm ye we coudl do it for playmp controller too
20140601 01:57:18< irker028> wesnoth: gfgtdf wesnoth:master 3da7515e5596 / / (4 files in 2 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/SpfboA
20140601 02:00:07-!- sachith500 [~kvirc@112.134.192.177] has joined #wesnoth-dev
20140601 02:00:33< irker028> wesnoth: gfgtdf wesnoth:master 913ebd6d4b8a / changelog: Update changelog http://git.io/FS-99g
20140601 02:00:34-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Remote host closed the connection]
20140601 02:09:01< irker028> wesnoth: Chris Beck wesnoth:master b342cd205672 / changelog: fixup update changelog http://git.io/h1M5Wg
20140601 02:10:37-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140601 02:11:10< irker028> wesnoth: Chris Beck wesnoth:1.12 0a001ea5b1cc / changelog: Update changelog http://git.io/8XhN7Q
20140601 02:15:15-!- gfgtdf [~chatzilla@e177164020.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140601 02:23:36-!- Ivanovic_ [~ivanovic@frnk-5f74d379.pool.mediaWays.net] has joined #wesnoth-dev
20140601 02:25:51-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 02:26:24-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 02:27:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 255 seconds]
20140601 02:27:30-!- Ivanovic_ is now known as Ivanovic
20140601 02:29:39-!- sachith500 [~kvirc@112.134.192.177] has quit [Read error: Connection reset by peer]
20140601 02:30:36-!- sachith500 [~kvirc@112.134.192.177] has joined #wesnoth-dev
20140601 02:33:12-!- Ivanovic [~ivanovic@frnk-5f74d379.pool.mediaWays.net] has quit [Changing host]
20140601 02:33:12-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140601 02:33:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140601 02:36:12-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 02:36:27-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140601 02:36:50-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 02:37:51-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140601 02:39:43-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 02:40:21-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 02:46:48-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 02:47:31-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 02:56:02-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Ping timeout: 255 seconds]
20140601 02:57:13-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20140601 02:59:55-!- Jetrel_ [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140601 03:01:33< irker028> wesnoth: gfgtdf wesnoth:master e93049732789 / src/tod_manager.cpp: fixup "sync random_start time the normal way" http://git.io/uKiHXg
20140601 03:02:17-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 252 seconds]
20140601 03:03:59-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 03:04:33-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 03:12:55-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20140601 03:16:33-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 03:17:08-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 03:18:35-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 03:19:13-!- kex [~kex@46.188.214.148] has joined #wesnoth-dev
20140601 03:30:05-!- kex [~kex@46.188.214.148] has quit [Read error: Connection reset by peer]
20140601 03:42:43-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140601 03:50:46-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140601 04:01:43< irker028> wesnoth: sigurdfdragon wesnoth:master de38d7a245a8 / projectfiles/CodeBlocks/wesnoth.cbp: Update CB project file. http://git.io/WhF1ig
20140601 04:01:45< irker028> wesnoth: Alexander van Gessel wesnoth:master 1979e5e1d1b1 / projectfiles/CodeBlocks/wesnoth.cbp: Merge pull request #179 from sigurdfdragon/CB_Update_2014-05-31 http://git.io/VB55qw
20140601 04:03:22-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20140601 04:05:07-!- cjhopman [cjhopman@nat/google/x-rthpxprhhxunhvxl] has quit [Ping timeout: 240 seconds]
20140601 04:14:34-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140601 04:21:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140601 04:23:44-!- sachith500 [~kvirc@112.134.192.177] has quit [Ping timeout: 266 seconds]
20140601 04:30:19-!- Turuk [Turuk@cpe-65-31-55-246.woh.res.rr.com] has quit [Ping timeout: 260 seconds]
20140601 04:32:21-!- cjhopman [cjhopman@nat/google/x-sdxelqdkxroxrzub] has joined #wesnoth-dev
20140601 04:37:01-!- knotwork [~markm@unaffiliated/knotwork] has quit [Excess Flood]
20140601 04:37:21-!- knotwork [~markm@142.68.141.247] has joined #wesnoth-dev
20140601 04:37:21-!- knotwork [~markm@142.68.141.247] has quit [Changing host]
20140601 04:37:21-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20140601 04:47:06-!- Sulfur [~Miranda@p5B009695.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140601 04:53:49-!- sachith500 [~kvirc@112.135.47.102] has joined #wesnoth-dev
20140601 04:54:20-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20140601 04:55:08-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140601 04:55:21-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 245 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140601 05:02:36-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit []
20140601 06:12:19-!- cjhopman [cjhopman@nat/google/x-sdxelqdkxroxrzub] has quit [Ping timeout: 240 seconds]
20140601 06:12:25-!- cib [~cib@p5DD23367.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140601 06:12:50-!- cib is now known as Guest95103
20140601 06:19:39< Coffee_irc>  might need to update the mp lobby text that says "the latest development release is 1.11.13"
20140601 06:49:02-!- cjhopman [~cjhopman@216.239.45.92] has joined #wesnoth-dev
20140601 06:59:51-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140601 07:01:47-!- irker028 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140601 07:07:49-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140601 07:32:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140601 08:19:11-!- mjs-de [~mjs-de@f048194175.adsl.alicedsl.de] has joined #wesnoth-dev
20140601 08:22:06-!- Sulfur [~Miranda@p5B009695.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140601 08:22:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140601 08:23:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140601 08:27:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140601 08:35:42-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 252 seconds]
20140601 08:36:42-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140601 08:37:58-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140601 08:49:46-!- kex [~kex@46.188.179.246] has joined #wesnoth-dev
20140601 08:52:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140601 09:00:30-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140601 09:02:13-!- kex [~kex@46.188.179.246] has quit [Ping timeout: 240 seconds]
20140601 09:09:51-!- Sulfur [~Miranda@p5B009695.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140601 09:10:32-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 09:19:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140601 09:22:17-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 09:22:53-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 09:24:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140601 09:24:41-!- Guest95103 is now known as cib1
20140601 09:27:32-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 09:28:10-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 09:31:42-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 09:32:18-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 09:36:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140601 09:50:05-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 09:50:40-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:06:45-!- haudegen_ [~quassel@77.119.131.90] has joined #wesnoth-dev
20140601 10:07:04-!- mjs-de [~mjs-de@f048194175.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140601 10:08:24-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:09:32-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:13:21-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:13:56-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:15:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140601 10:26:47-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:27:23-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:30:10-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:30:46-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:33:29-!- sachith500|2 [~kvirc@112.135.47.102] has joined #wesnoth-dev
20140601 10:33:29-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:34:05-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:34:40-!- sachith500|3 [~kvirc@112.135.47.102] has joined #wesnoth-dev
20140601 10:37:47-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:38:24-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:45:10-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140601 10:45:50-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:46:26-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:49:09-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:49:51-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:52:48-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 10:53:25-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 10:59:15-!- fabi [~fabi@91-67-38-136-dynip.superkabel.de] has joined #wesnoth-dev
20140601 10:59:15-!- fabi [~fabi@91-67-38-136-dynip.superkabel.de] has quit [Changing host]
20140601 10:59:15-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20140601 10:59:28-!- sachith500|2 [~kvirc@112.135.47.102] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140601 10:59:30-!- sachith500|3 [~kvirc@112.135.47.102] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140601 11:01:39-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140601 11:03:20-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:03:56-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:05:54-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:06:32-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:08:25-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:09:00-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:20:46-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:21:22-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:23:48-!- haudegen__ [~quassel@77.119.131.90.wireless.dyn.drei.com] has joined #wesnoth-dev
20140601 11:23:58-!- haudegen_ [~quassel@77.119.131.90] has quit [Remote host closed the connection]
20140601 11:25:46-!- Turuk [~Turuk@cpe-65-31-55-246.woh.res.rr.com] has joined #wesnoth-dev
20140601 11:26:09-!- Turuk is now known as Guest69295
20140601 11:27:53-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:28:28-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:38:13-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:38:56-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:41:39-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:42:11-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:51:04-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:51:42-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:55:14-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 11:55:49-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 11:57:14-!- Bodhi-Baum [~Bodhi@dslb-084-063-013-180.pools.arcor-ip.net] has joined #wesnoth-dev
20140601 12:00:41-!- haudegen__ [~quassel@77.119.131.90.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140601 12:03:19-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 12:03:55-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 12:14:38-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140601 12:24:15-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140601 12:27:25-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140601 12:28:53-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20140601 12:29:51-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 12:30:25-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 12:30:53-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140601 12:31:59-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140601 12:33:13-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 12:33:45-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 12:37:33-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 12:38:09-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 12:41:41-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 12:42:08-!- Guest69295 [~Turuk@cpe-65-31-55-246.woh.res.rr.com] has quit [Ping timeout: 276 seconds]
20140601 12:42:17-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 12:42:42-!- sachith500|2 [~kvirc@112.134.45.147] has joined #wesnoth-dev
20140601 12:44:17-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 12:44:39-!- sachith500 [~kvirc@112.135.47.102] has quit [Ping timeout: 252 seconds]
20140601 12:44:56-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 12:46:25-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 12:47:02-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 12:50:33-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 12:51:11-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 12:58:33-!- Sulfur2 [~Miranda@p5B009695.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140601 12:59:48-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:00:24-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:01:19-!- Sulfur [~Miranda@p5B009695.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20140601 13:02:46-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW]
20140601 13:05:05-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:05:41-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:08:29-!- Bodhi-Baum [~Bodhi@dslb-084-063-013-180.pools.arcor-ip.net] has quit [Ping timeout: 255 seconds]
20140601 13:12:13-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:12:52-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:16:20-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:16:54-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:23:16-!- Bodhi-Baum [~Bodhi@dslb-084-063-013-180.pools.arcor-ip.net] has joined #wesnoth-dev
20140601 13:27:18-!- horon [~horon@nttkyo210231.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20140601 13:30:39-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:31:13-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:33:43-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:34:22-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:36:15-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:36:50-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:39:42-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:40:14-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:42:00-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:42:36-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:44:31-!- kex [~kex@46.188.189.233] has quit [Remote host closed the connection]
20140601 13:45:10-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 13:45:36-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 13:46:03-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 14:00:19-!- mjs-de [~mjs-de@f048163052.adsl.alicedsl.de] has joined #wesnoth-dev
20140601 14:00:50-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 14:01:23-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 14:12:01-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 14:12:34-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 14:16:13-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 14:16:49-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 14:18:43-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 14:19:18-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 14:20:00-!- kex [~kex@46.188.189.233] has quit [Remote host closed the connection]
20140601 14:20:34-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 14:21:14-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 14:21:44-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 14:24:06-!- kex [~kex@46.188.189.233] has quit [Read error: No route to host]
20140601 14:28:00-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140601 14:49:31-!- _8680_ [~8680@2002:4404:712c:0:c1ce:1895:6149:c180] has quit [Ping timeout: 240 seconds]
20140601 14:50:19-!- _8680_ [~8680@2002:4404:712c:0:fdbf:c938:8a84:3d77] has joined #wesnoth-dev
20140601 15:00:17-!- sachith500 [~kvirc@61.245.163.47] has joined #wesnoth-dev
20140601 15:02:52-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 15:03:04-!- sachith500|2 [~kvirc@112.134.45.147] has quit [Ping timeout: 265 seconds]
20140601 15:09:29-!- Turuk [~Turuk@cpe-65-31-55-246.woh.res.rr.com] has joined #wesnoth-dev
20140601 15:09:53-!- Turuk is now known as Guest10067
20140601 15:11:45-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 15:12:24-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 15:13:50-!- Guest10067 [~Turuk@cpe-65-31-55-246.woh.res.rr.com] has quit [Client Quit]
20140601 15:25:16-!- Bodhi-Baum [~Bodhi@dslb-084-063-013-180.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140601 15:25:16-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 15:25:50-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 15:36:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140601 15:36:58-!- sachith500|2 [~kvirc@112.134.45.147] has joined #wesnoth-dev
20140601 15:37:25-!- Turuk [~Turuk@cpe-65-31-55-246.woh.res.rr.com] has joined #wesnoth-dev
20140601 15:38:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140601 15:40:11-!- sachith500 [~kvirc@61.245.163.47] has quit [Ping timeout: 252 seconds]
20140601 15:42:36-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 15:43:12-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 15:45:56-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 15:46:33-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 15:47:47-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140601 15:49:04-!- sachith500|2 [~kvirc@112.134.45.147] has quit [Read error: Connection reset by peer]
20140601 15:52:58-!- gfgtdf [~chatzilla@e177164020.adsl.alicedsl.de] has joined #wesnoth-dev
20140601 15:54:16-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 15:54:51-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 15:57:20-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 15:57:53-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:00:43-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 16:01:02-!- Sulfur2 [~Miranda@p5B009695.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140601 16:01:18-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:07:54-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 16:08:32-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:15:04-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 16:15:38-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:26:09-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 16:27:30-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:30:13-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 16:30:49-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:36:25-!- irker283 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140601 16:36:25< irker283> wesnoth: gfgtdf wesnoth:master f086963b3971 / src/ (6 files in 3 dirs): remove "difficulty_" from game_data and carryover http://git.io/fTSFUg
20140601 16:36:25< irker283> wesnoth: gfgtdf wesnoth:master 7ebbac36b363 / src/synced_context.cpp: removed unneeded check in synced_context.cpp http://git.io/kFf5eg
20140601 16:36:25< irker283> wesnoth: gfgtdf wesnoth:master b138912ce331 / src/ (gamestatus.cpp gamestatus.hpp play_controller.cpp): remove "random_mode_" from game_data http://git.io/pxR9AA
20140601 16:36:26< irker283> wesnoth: gfgtdf wesnoth:master c0b81688cb9d / src/gamestatus.cpp: fixup 'remove difficulcy_' http://git.io/C9oITQ
20140601 16:36:27< irker283> wesnoth: gfgtdf wesnoth:master ebbf813e03d0 / src/ (8 files in 3 dirs): Merge pull request #177 from gfgtdf/remove_diffic http://git.io/ioNu4Q
20140601 16:41:33-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 16:42:04< gfgtdf> iceiceice_: hmm  i looked in teh code of a documentation fo teh savegame theadng feature bug i foudn nothign relevent
20140601 16:42:09-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:42:15< gfgtdf> iceiceice_: and i aalso didnt find code that uses it
20140601 16:42:35< iceiceice_> hmm
20140601 16:43:00< iceiceice_> well if its not used then just delete i guess
20140601 16:43:54< gfgtdf> iceiceice_: it seems like there was once a plan to change teh laodgame dialog: https://mail.gna.org/public/wesnoth-dev/2009-05/msg00008.html
20140601 16:45:56< gfgtdf> iceiceice_:  hm lets delete it and see where i get a copilatio error
20140601 16:46:11< iceiceice_> y ok
20140601 16:49:56< iceiceice_> gfgtdf:
20140601 16:50:02< iceiceice_> i noticed something when workign on my refactor branch,
20140601 16:50:13< iceiceice_> when we do "reset" in the replay_controller,
20140601 16:50:20< iceiceice_> we reset the units and the teams
20140601 16:50:23< iceiceice_> but we dont reset the map
20140601 16:50:26< iceiceice_> so i wonder if,
20140601 16:50:35< iceiceice_> if wml used a "replace map" or one of those map mask things,
20140601 16:50:39< iceiceice_> if it would break the replay
20140601 16:50:55< iceiceice_> when you hit the square button and try to watch a second time
20140601 16:51:36< gfgtdf> iceiceice_: hm we dont know unless we test, esp since the map might get reset at some other playe you might have overlooked
20140601 16:51:37-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 16:51:48< iceiceice_> maybe
20140601 16:52:03< iceiceice_> but its hard to see where else it would be if not in replay_controller
20140601 16:52:13-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:52:23< gfgtdf> iceiceice_: idk
20140601 16:52:40< gfgtdf> maby restting teh unit map automiticly also resets teh terrin mpa or something
20140601 16:53:44< gfgtdf> iceiceice_: i dont think that but something sililar is still possible
20140601 16:54:07< iceiceice_> heh i mean alot is possible
20140601 16:54:32< gfgtdf> ye, thats why we dont know unless we tested
20140601 16:54:33-!- haudegen_ [~quassel@77.119.131.90.wireless.dyn.drei.com] has joined #wesnoth-dev
20140601 16:56:49-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 16:57:26-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 16:59:07< gfgtdf> iceiceice_: ok as i thought the "parent" is never read on written.
20140601 17:01:32< gfgtdf> s/on/only*
20140601 17:02:06-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:02:45-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 17:02:56< iceiceice_> gfgtdf: if travis builds this im going to merge it in like an hour i think
20140601 17:02:56< iceiceice_> https://github.com/wesnoth/wesnoth/pull/180
20140601 17:04:13< iceiceice_> i guess i will test the replay controller thing first though
20140601 17:06:16< gfgtdf> iceiceice_: but teh others are still in resources:: ?
20140601 17:06:35< iceiceice_> y i have to work incrementally
20140601 17:07:49< gfgtdf> iceiceice_:  you already fix 15545?
20140601 17:07:55< iceiceice_> no
20140601 17:08:40< iceiceice_> i just want to push things to master before they are stale... that sucked yesterday cherry-picking all that old stuff
20140601 17:10:23-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:10:58-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 17:12:55-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:13:13-!- haudegen_ [~quassel@77.119.131.90.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds]
20140601 17:13:27-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 17:14:58-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:15:34-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 17:15:52< iceiceice_> gfgtdf:
20140601 17:16:02< iceiceice_> hmm i find the map thing is actually a bug, and my commit didnt fix it apparnetly :/
20140601 17:16:14< gfgtdf> iceiceice_: which map thing ?
20140601 17:17:12< iceiceice_> heres my test case:
20140601 17:17:12< iceiceice_> http://hastebin.com/deyiyuvene.apache
20140601 17:17:27< iceiceice_> ther are events to apply terrain mask at certain turns,
20140601 17:17:41< iceiceice_> if you watch in replay it works correctly hte first time but is out of sync if you press stop
20140601 17:17:46< iceiceice_> because it doesnt reset the terrain
20140601 17:18:22< gfgtdf> iceiceice_: ok which commit ?
20140601 17:18:43< Necrosporus> Can someone help me understand terrain graphics?
20140601 17:19:07< iceiceice_> gfgtdf: i tested that at the end of my pull request
20140601 17:19:13< iceiceice_> i will rebuild master now though and try
20140601 17:19:31< Necrosporus> zookeeper maybe if you aren't busy or something
20140601 17:22:23-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:23:01-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 17:27:13< iceiceice_> hmm i wonder if the problem is game_board needs an explicit copy constructor
20140601 17:29:57< irker283> wesnoth: gfgtdf wesnoth:master 9ddce3185403 / src/ (gamestatus.cpp gamestatus.hpp savegame.cpp): remove "parent" from classification http://git.io/2VUaxQ
20140601 17:33:39< iceiceice_> gfgtdf: i think i may actually have noticed this replay out of sync thing before on utbs
20140601 17:35:35-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:36:09-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 17:41:16-!- haudegen [~quassel@213162068093.public.t-mobile.at] has joined #wesnoth-dev
20140601 17:41:57-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:42:12< irker283> wesnoth: Chris Beck wesnoth:master 5718992f9a69 / src/ (5 files): add game_board struct to hold map, units, teams http://git.io/njsggw
20140601 17:42:14< irker283> wesnoth: Chris Beck wesnoth:master 5fa083680eda / src/ (play_controller.cpp playsingle_controller.cpp replay_controller.cpp): cleanup for loops made ugly in previous commit http://git.io/x0qb6A
20140601 17:42:16< irker283> wesnoth: Chris Beck wesnoth:master 0e7769a12c46 / src/ (5 files): move some functionality out of play controller to game_board http://git.io/Cbm7HA
20140601 17:42:18< irker283> wesnoth: Chris Beck wesnoth:master 6fff2e8be26c / src/ (play_controller.cpp play_controller.hpp): move some of the savegame code from play_controller to game_board http://git.io/e7RWMw
20140601 17:42:20< irker283> wesnoth: Chris Beck wesnoth:master 471e7ab86543 / src/ (replay_controller.cpp replay_controller.hpp): replay controller uses game_board to do resets http://git.io/2bY1Ag
20140601 17:42:22< irker283> wesnoth: Chris Beck wesnoth:master 2afe4f4f5af6 / / (10 files in 5 dirs): move game_board to its own file, update project files http://git.io/jzq_gA
20140601 17:42:24< irker283> wesnoth: Chris Beck wesnoth:master 8b6339af9be0 / src/ (game_preferences.cpp game_preferences.hpp play_controller.cpp team.cpp team.hpp): move code managing preference encounters out of play controller http://git.io/q5rlYw
20140601 17:42:26< irker283> wesnoth: Chris Beck wesnoth:master d557ea51657f / src/ (game_board.hpp game_preferences.cpp game_preferences.hpp): add access controls to game_board http://git.io/Wlz8yQ
20140601 17:42:28< irker283> wesnoth: Chris Beck wesnoth:master df74d891d29a / src/ (21 files in 7 dirs): give global fcn's (find/get)_visible_unit a home in game_board http://git.io/zRIJAQ
20140601 17:42:30< irker283> wesnoth: Chris Beck wesnoth:master 2d2385b9522c / src/ (game_board.hpp mouse_events.cpp mouse_events.hpp play_controller.cpp): integrate game_board into mouse_handler http://git.io/SORDCA
20140601 17:42:32-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 17:42:32< irker283> wesnoth: Chris Beck wesnoth:master 096cb97cc177 / / (37 files in 11 dirs): Merge pull request #180 from cbeck88/add_game_board_struct_alternate http://git.io/PBF35g
20140601 17:47:09-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:47:45-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 17:49:42-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Quit: riksteri]
20140601 17:50:14-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 17:50:47-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 18:02:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20140601 18:09:34< Necrosporus> Does terraing graphic engine rotate or mirror sprites automatically like unit drawing engine does?
20140601 18:09:49< zookeeper> no
20140601 18:10:31< Necrosporus> So you need at least 64 sprites for a new terrain?
20140601 18:10:47< Necrosporus> one for terrain itself and 64 for possible transitions
20140601 18:10:57-!- kex [~kex@46.188.189.233] has quit [Remote host closed the connection]
20140601 18:11:06< zookeeper> 7
20140601 18:11:20< Necrosporus> Why 7?
20140601 18:11:31< zookeeper> you can have as little as 1 per side for transitions
20140601 18:11:57< zookeeper> most terrains have 2- and/or 3-way transitions, but that's not necessary
20140601 18:12:40< Necrosporus> if you have o t t (o - other, terrain, t - your terrain) triangle and you only have 7 sprites, then what happens?
20140601 18:12:50-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 18:13:20< Necrosporus> with o I mean
20140601 18:13:49< Necrosporus> Will you get transitions from both sides of 'o' hex?
20140601 18:14:00< zookeeper> so is o sw or nw of the middle t?
20140601 18:14:47< Necrosporus> In each intersection of hex-borders you got three hexes
20140601 18:15:21< Necrosporus> if two of them is your terrain and third is other terrain, will be transition drawn from both sides ?
20140601 18:16:09< zookeeper> yes
20140601 18:20:09-!- haudegen [~quassel@213162068093.public.t-mobile.at] has quit [Ping timeout: 252 seconds]
20140601 18:22:39-!- Kexoth [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 18:22:42-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 18:22:52-!- Kexoth [~kex@46.188.189.233] has quit [Remote host closed the connection]
20140601 18:23:15-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 18:33:43-!- cib1 [~cib@p5DD23367.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140601 18:37:44-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20140601 18:38:31-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140601 18:42:38-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 18:44:03-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 18:51:52-!- haudegen_ [~quassel@77.119.128.171.wireless.dyn.drei.com] has joined #wesnoth-dev
20140601 18:53:54-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140601 18:58:46< iceiceice_> gfgtdf:
20140601 18:58:55< iceiceice_> do you know how lua pointers to units work?
20140601 18:59:20< iceiceice_> like how they are implemented in C?
20140601 18:59:34< iceiceice_> is there some kind of wrapper or do they interface directly with a raw unit object
20140601 19:01:13< gfgtdf> iceiceice_: there is a type lua_unit ins somewhere, there are duiffretn types of lua_units, they can e eigher be "private" "on map" or "on recall list"
20140601 19:01:29< iceiceice_> hmm i see
20140601 19:01:55< iceiceice_> thanks, i wasnt sure if that was actually what that type was doing
20140601 19:05:11< gfgtdf> iceiceice_: do you know whether "gui_" in play_controller.hpp can ever be null ?
20140601 19:05:45< iceiceice_> i think if you run headlessly it might be but i'm really not sure...
20140601 19:05:45-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 19:05:53< iceiceice_> actually
20140601 19:05:59< iceiceice_> if that were the case i think the game would crash,
20140601 19:06:07< iceiceice_> apparently we require the gui in order to write save files :p
20140601 19:06:17-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 19:06:20< iceiceice_> because tehre are game state variables owned by the gui
20140601 19:06:26< iceiceice_> which is something we should change btw
20140601 19:07:03< gfgtdf> iceiceice_: ye thats wh i asked
20140601 19:07:31< gfgtdf> iceiceice_: i think i will simple move that into play_contoller::to_config for now
20140601 19:07:35< gfgtdf> simply*
20140601 19:07:44< iceiceice_> y
20140601 19:09:00< gfgtdf> iceiceice_: do tests also run with gui ?
20140601 19:09:07< gfgtdf> iceiceice_: i mean coudl gui be null there ?
20140601 19:09:31< iceiceice_> i think it can never actually be null
20140601 19:09:35< iceiceice_> maybe in a very old version
20140601 19:09:51< iceiceice_> idk if it can be null...
20140601 19:09:57< iceiceice_> i think it means that the unit tests may not have integrity
20140601 19:10:15< iceiceice_> hmm i guess should check with an assert or something
20140601 19:10:25< iceiceice_> i think there is anther function "non_interactive"
20140601 19:17:47-!- kex [~kex@46.188.189.233] has quit [Read error: Connection reset by peer]
20140601 19:18:22-!- kex [~kex@46.188.189.233] has joined #wesnoth-dev
20140601 19:19:41-!- Tobarja [~Tobarja@kazi.atholdings.us] has left #wesnoth-dev ["Leaving"]
20140601 19:23:37-!- Kexoth [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 19:26:58-!- kex [~kex@46.188.189.233] has quit [Ping timeout: 265 seconds]
20140601 19:46:17< gfgtdf> iceiceice_: do you see a reason against initilizing n_unit::id_manager::instance in play_controllers contructor and saving it in to_config ?
20140601 19:47:05< iceiceice_> where is it currently initialized?
20140601 19:48:18< iceiceice_> it looks like its done in gamestate?
20140601 19:48:35< iceiceice_> idk maybe thats good
20140601 19:48:52< iceiceice_> i am thinking that most things should be moved out of play controller to gamestate perhaps, if possible
20140601 19:48:58< iceiceice_> or to other places
20140601 19:49:03< gfgtdf> iceiceice_: curentyl its done in may differnt places
20140601 19:49:16< iceiceice_> it looks like in mp its done in this game_utils place as well
20140601 19:49:40< gfgtdf> iceiceice_: hmm moving things out of play_controller can be done later
20140601 19:49:42< iceiceice_> idk if you think it woudl be better to just put it in play controller i dont see a reason why not, we could move it later if it makes sense later
20140601 19:49:42< iceiceice_> yeah
20140601 20:18:38-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has quit [Ping timeout: 245 seconds]
20140601 20:20:58-!- StandYourGround [~Adium@CPE-24-209-146-0.wi.res.rr.com] has joined #wesnoth-dev
20140601 20:33:03< gfgtdf> shadowm: i think th 1.11+dev uses the same server as the 1.13-dev? so what shoud i do when i want to make checkes that arent intended to bre backported ?
20140601 20:37:32-!- StandYourGround [~Adium@CPE-24-209-146-0.wi.res.rr.com] has quit [Quit: Leaving.]
20140601 20:42:35-!- irker283 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140601 20:46:13-!- Kexoth [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 20:47:22-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 20:52:29-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 20:53:01-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 20:56:31-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140601 20:56:47< shadowm> gfgtdf: Could you try to be a little more specific (and clear)? What kind of checks?
20140601 20:57:15< gfgtdf> shadowm: changes*
20140601 20:57:51< gfgtdf> shadowm: about the format of teh scenarios that are sended at the beginning of an mp scenario
20140601 20:57:51-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 20:58:26-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 20:58:47< shadowm> If you want I can make 1.11+dev use the same instance as the latest 1.11.x release, but then you'll have to promise not to break the protocol or MP stats (or anything else that may cause sync issues) ever again in the 1.12 branch.
20140601 20:59:39< shadowm> Otherwise I can reject either 1.11+dev or 1.13.0-dev and force people to run local instances.
20140601 21:02:25-!- gfgtdf_ [~chatzilla@f054048245.adsl.alicedsl.de] has joined #wesnoth-dev
20140601 21:02:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140601 21:03:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140601 21:04:00< gfgtdf_> shadowm: hmm ok i don't intend to break compability again but i can't say until the changes are implemented since it may eigher happen that something comes up in the interim that prevents me from changing no nothign happens, or that i find a bug that is enough reason to backport.
20140601 21:04:18-!- gfgtdf [~chatzilla@e177164020.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140601 21:04:20-!- gfgtdf_ is now known as gfgtdf
20140601 21:04:22< gfgtdf> shadowm: do you think the the next 1.12 will be a rc ?
20140601 21:04:41< shadowm> I don't know, that's something the people actually doing work (i.e. you) have to decide.
20140601 21:05:01< shadowm> And then Ivanovic gets the last word on the matter.
20140601 21:05:35< shadowm> From iceiceice's email I get the impression you people don't feel confident on 1.12's current quality.
20140601 21:05:54< shadowm> To be honest I don't think we ever had such a high bug count at this stage.
20140601 21:07:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140601 21:09:33< iceiceice_> shadowm: i feel like i don't really have a very good idea how much actual testing is happening
20140601 21:10:04< iceiceice_> there are bugs being reported on the forum and such so i guess there is testing happening
20140601 21:10:11< gfgtdf> shadowm: do you know whether it is possible to see the "version" in the list on gna ?
20140601 21:10:48< iceiceice_> i feel like we might not be that far from release, but it on info that i dont have
20140601 21:14:34< shadowm> gfgtdf: In the main list? No idea.
20140601 21:15:03< iceiceice_> i think we have made a lot of progress... and most of the major bugs are gone i think
20140601 21:15:18< iceiceice_> it was also harder in 1.12 i think because there was sort of feature multiplication,
20140601 21:15:42< iceiceice_> mp campaigns were incompatible with a lot of things at first
20140601 21:15:54< iceiceice_> i think there are still bugs there tbh but its at least tolerable i think
20140601 21:32:56-!- trewe [~trewe@2001:8a0:d116:601:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20140601 21:39:44-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 21:53:14-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 21:55:04-!- irker065 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140601 21:55:04< irker065> wesnoth: Chris Beck wesnoth:master 124781c9d84e / src/ (6 files in 2 dirs): integrate game_board into turn_info object http://git.io/BzwSEg
20140601 21:57:36-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 21:58:12-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 22:00:27-!- gfgtdf_ [~chatzilla@f054137189.adsl.alicedsl.de] has joined #wesnoth-dev
20140601 22:02:18-!- gfgtdf [~chatzilla@f054048245.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140601 22:02:22-!- gfgtdf_ is now known as gfgtdf
20140601 22:02:55< gfgtdf> iceiceice_: why do you want to rmeove resources::teams ?
20140601 22:02:55-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 22:03:12< iceiceice_> because i think it will help to make the engine simpler
20140601 22:03:28-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 22:03:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140601 22:04:07< iceiceice_> it wont be removed, but you wont be able to get a non-const reference to teams as easily
20140601 22:05:59< iceiceice_> what i'm envisioning atm is that, gamestate will become a parent object containing game_board and game_data, and classification fields and game progress variables,
20140601 22:06:09< iceiceice_> and that the game will be saved by calling gamestate.to_config()
20140601 22:06:29< gfgtdf> which gamestate ?
20140601 22:06:31< iceiceice_> the gui may hold a const & to gamestate to get variables that it needs, but we wont serialized thigns from gui
20140601 22:06:40< iceiceice_> idk gamestate will have to change if this plan goes to completeion
20140601 22:06:50< iceiceice_> right now it doesnt do very much work obviously
20140601 22:07:08< gfgtdf> iceiceice_: i'd liek if you donge change gamestate rightnow
20140601 22:07:13< iceiceice_> maybe the new class needs a different name, but there should be a class that captures the idea "this is all the data that needs to be kept in sync, and saved and reloaded successfully"
20140601 22:07:20< iceiceice_> i wont do it for a long time
20140601 22:07:24< gfgtdf> iceiceice_: but can write a new calss
20140601 22:07:50< gfgtdf> iceiceice_: i just madea pr: https://github.com/wesnoth/wesnoth/pull/181
20140601 22:09:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20140601 22:10:29-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20140601 22:11:28-!- kex [~kex@46.188.141.156] has quit [Remote host closed the connection]
20140601 22:13:14-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 22:13:44-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 22:13:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140601 22:14:05-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 22:15:45< gfgtdf> iceiceice_: my play was more or less to first move things in play_controller.cpp and then later split play_controller.cpp in a "logic" and a "visual" class.
20140601 22:15:48< iceiceice_> gfgtdf i think this is good
20140601 22:16:28< iceiceice_> gfgtdf: y i think... there needs to be a logic class
20140601 22:16:38< iceiceice_> do you think there shold be a visual class besides game_display?
20140601 22:17:06< gfgtdf> iceiceice_: hm i dotn know taht much about the ui things so i cannot tell
20140601 22:17:09< iceiceice_> ok
20140601 22:17:18< gfgtdf> iceiceice_: i dont thik i ever looked into teh class game_display
20140601 22:17:30< iceiceice_> oh, well you are in for a treat then :X
20140601 22:17:53< gfgtdf> ?
20140601 22:18:11< iceiceice_> idk my impression is that it is somewhat notoriously complicated now
20140601 22:18:39< iceiceice_> its actualyl a hierarchy of 3 classes, video, display, and game_dispaly, the last of which has a singleton mechanism,
20140601 22:18:58< iceiceice_> they dont really own the shroud but manage it somehow??
20140601 22:19:17< iceiceice_> they own a bunch of fake units that i believe is not entirely sound
20140601 22:19:22< iceiceice_> they own all the maplocations
20140601 22:19:29< iceiceice_> and they own a bunch of gamestate variables
20140601 22:19:37< iceiceice_> s/map locations / map labels
20140601 22:19:58< iceiceice_> also they have to make the tray notificaitons but thats fairly reasonable i guess
20140601 22:21:31< iceiceice_> also they share a huge amount of graphics code with unit.cpp
20140601 22:21:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140601 22:23:06< iceiceice_> the wesnoth graphics engine is pretty much enormous, idk what fraction of the source it is but it's got to be a pretty significant piece
20140601 22:24:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140601 22:26:46< gfgtdf> iceiceice_:about the linger save bug: i think we should just instead of "copying all units in teh recalllist and then save all untis from teh recalllist" do "save all units on teh recalllist and on the map"
20140601 22:27:30< iceiceice_> yeah i think that makes the most sense
20140601 22:27:49< iceiceice_> one option is that when linger mode quits we could copy any not defeated units to recall
20140601 22:28:08< iceiceice_> or do it in playcampaign.cpp i guess
20140601 22:28:55-!- travis-ci [~travis-ci@ec2-54-82-99-224.compute-1.amazonaws.com] has joined #wesnoth-dev
20140601 22:28:55< travis-ci> [travis-ci] gfgtdf/wesnoth-old#119 (gamestate_refactor - 3c3eb3e : gfgtdf): The build passed.
20140601 22:28:55< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/26531753
20140601 22:28:55-!- travis-ci [~travis-ci@ec2-54-82-99-224.compute-1.amazonaws.com] has left #wesnoth-dev []
20140601 22:28:55-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 22:29:10< gfgtdf>  iceiceice_: but teh move untis to carryover currentyl takes place before the liner mode
20140601 22:29:28< gfgtdf> iceiceice_: but i dont like that since it makes teh savfeile normaot more complicated
20140601 22:29:33< gfgtdf> foemat*
20140601 22:29:37< gfgtdf> format*
20140601 22:29:52< iceiceice_> hmm
20140601 22:30:00-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 22:30:16< iceiceice_> i think i agree with you
20140601 22:30:33< iceiceice_> and if linger mode saves did not work before now anyways then i dont think anyone likely feels strongly about this
20140601 22:30:58< iceiceice_> im trying to imagine if there is something that breaks from saving the carryover after linger mode ends
20140601 22:31:09< gfgtdf> iceiceice_: the main reason it is done is that we need to show the carryover message before linger mode and it is easiert genrate teh carryover message with teh actual carryover
20140601 22:31:28< iceiceice_> hmm
20140601 22:31:30-!- haudegen_ [~quassel@77.119.128.171.wireless.dyn.drei.com] has quit [Quit: Weil so halt.]
20140601 22:31:41< iceiceice_> well why not just generate it twice?
20140601 22:31:54-!- haudegen_ [~quassel@77.119.128.171.wireless.dyn.drei.com] has joined #wesnoth-dev
20140601 22:32:01< gfgtdf> iceiceice_: hm idk about how much performance taht costsperformance
20140601 22:32:11< iceiceice_> i think it is probably negligible
20140601 22:32:52< gfgtdf> iceiceice_: well we have to copy the configs for all the units
20140601 22:33:19< iceiceice_> hmm idk
20140601 22:33:33< iceiceice_> carryover message seems to compute basically instantly right now
20140601 22:33:40< iceiceice_> if you add that time to the save time i dont think anyone will care or notice
20140601 22:33:55< gfgtdf> iceiceice_: hmm
20140601 22:33:58< iceiceice_> user is happy because they won anyways :)
20140601 22:34:05< gfgtdf> iceiceice_: that does depend on teh campaign
20140601 22:34:18< gfgtdf> iceiceice_: sure it is neglectable in mainline
20140601 22:34:27< gfgtdf> iceiceice_: but maybe not in UMC
20140601 22:34:36< iceiceice_> hmm well
20140601 22:34:47< iceiceice_> i would suggest to do the simplest thing first and get it working and passing tests etc.
20140601 22:34:56< iceiceice_> and then refactor to improve performance if inclined
20140601 22:35:00< iceiceice_> but do it how you like i guess
20140601 22:35:24< iceiceice_> i'm pretty convinced right now that the biggest bottleneck in the wesnoth engine right now is path finding
20140601 22:35:33< iceiceice_> i find that when i run the pathfind characterization tests,
20140601 22:35:37< iceiceice_> they run noticeably slower than the others
20140601 22:35:41< iceiceice_> like half a second
20140601 22:35:46< iceiceice_> maybe a second
20140601 22:36:00< iceiceice_> each of those tests "characterize_pathfinding_reach_1" ...
20140601 22:36:02< iceiceice_> that is just, 
20140601 22:36:12< iceiceice_> i took arcenclave citadel, clicked a bunch of units onto it in map editor
20140601 22:36:15< iceiceice_> but like not more than a normal game,
20140601 22:36:24< iceiceice_> and tried to compute all the reach of all of them and check accuracy
20140601 22:36:41< iceiceice_> its like 160 units in total or something
20140601 22:36:49< iceiceice_> i find that the test times out if i dont break it up
20140601 22:36:55< iceiceice_> so i broke it up into 7 pieces,
20140601 22:37:03< iceiceice_> each of which tests only 15 units iirc
20140601 22:37:07< iceiceice_> and already that is noticeably slow
20140601 22:37:22< iceiceice_> compared to the other tests
20140601 22:38:45< iceiceice_> so i think its a different perspective on "why is wesnoth ai hard",
20140601 22:38:58< iceiceice_> if you want ai that like, doesnt do a move without considering what the enemy's follow up is,
20140601 22:39:15< iceiceice_> it cant even do that because once it changes the position it has to recalculate everything which may take like, on the order of a second
20140601 22:39:24< iceiceice_> thats already a bottleneck
20140601 22:39:38< iceiceice_> so pretty much all you can do is ask the engine for moves once, then score them and use a greedy algorithm and repeat
20140601 22:40:08< iceiceice_> the time to get all the moves i could make, should be like, milliseconds
20140601 22:40:13< iceiceice_> for a given position
20140601 22:40:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140601 22:42:58-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 22:43:33-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 22:44:58-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140601 22:46:11-!- travis-ci [~travis-ci@ec2-54-82-99-224.compute-1.amazonaws.com] has joined #wesnoth-dev
20140601 22:46:11< travis-ci> [travis-ci] gfgtdf/wesnoth-old#120 (gamestate_refactor - 1a03e61 : gfgtdf): The build passed.
20140601 22:46:11< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/26532243
20140601 22:46:11-!- travis-ci [~travis-ci@ec2-54-82-99-224.compute-1.amazonaws.com] has left #wesnoth-dev []
20140601 22:46:46-!- mjs-de [~mjs-de@f048163052.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140601 22:47:08< gfgtdf> iceiceice_: do you knwo why we COPY teh gamemap here https://github.com/wesnoth/wesnoth/blob/master/src/playcampaign.cpp#L139 ?
20140601 22:47:52< iceiceice_> no, nor the TOD manager...
20140601 22:48:37< iceiceice_> here's a vaguely similar question: why do so many functions have "const map_location &" as their arguments?
20140601 22:48:42< iceiceice_> a map_location is 2 ints.
20140601 22:49:02< iceiceice_> dereferncing the pointer once is already requiring as much memory and time as just copying by value.
20140601 22:50:04-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 22:50:40-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 22:51:39-!- haudegen_ [~quassel@77.119.128.171.wireless.dyn.drei.com] has quit [Read error: Connection reset by peer]
20140601 22:51:48< gfgtdf> iceiceice_: well if for example just takes a const refernce and passes tehm to another function without doring nothing then copying one shousl still be faster
20140601 22:52:13< gfgtdf> iceiceice_: and if tehre is a long chain then that might have a bigger effect.
20140601 22:52:29< iceiceice_> idk i think its pretty marginal
20140601 22:52:37< iceiceice_> anyways you will always have worse memory
20140601 22:52:42< iceiceice_> becuase you will need to hold a pointer and 2 ints
20140601 22:52:45< iceiceice_> per maplocation
20140601 22:53:24< iceiceice_> so if you hold a lot of map_locations by reference and work with them...
20140601 22:53:57< iceiceice_> the threshold where you would start to get cache misses is 50% higher if you passed by value
20140601 22:56:35< irker065> wesnoth: gfgtdf wesnoth:master 9687383d0f94 / src/ (11 files): move carryover into its own file http://git.io/JdEIqQ
20140601 22:56:37< irker065> wesnoth: gfgtdf wesnoth:master a08efab4c042 / src/ (gamestatus.cpp gamestatus.hpp play_controller.cpp): remove unused variable http://git.io/x041tQ
20140601 22:56:39< irker065> wesnoth: gfgtdf wesnoth:master 83acdf287052 / src/gamestatus.cpp: remove unused variable continuance http://git.io/E8-bjg
20140601 22:56:41< irker065> wesnoth: gfgtdf wesnoth:master afbf5c6e5804 / src/ (20 files in 7 dirs): remove resources::state_of_game http://git.io/JwZHMQ
20140601 22:56:43< irker065> wesnoth: gfgtdf wesnoth:master 1a03e61165f6 / src/ (carryover.cpp playcampaign.cpp): move next_scenario_append/setting to carryover http://git.io/OkbHjQ
20140601 22:56:45< irker065> wesnoth: gfgtdf wesnoth:master 6a8827a07184 / src/ (27 files in 7 dirs): Merge pull request #181 from gfgtdf/gamestate_refactor http://git.io/fUDR4g
20140601 22:58:59< irker065> wesnoth: Chris Beck wesnoth:master a21baf01ef70 / src/tests/test_unit_map.cpp: add a check that unit_map.end() is invalid for dereference http://git.io/G0BECg
20140601 22:59:01< irker065> wesnoth: Chris Beck wesnoth:master 1c2dcdb6bc6f / src/ (27 files in 7 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/yJtN9A
20140601 23:03:14-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 23:05:46-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 23:10:19-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 23:10:56-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 23:23:42-!- kex [~kex@46.188.141.156] has quit [Read error: Connection reset by peer]
20140601 23:24:17-!- kex [~kex@46.188.141.156] has joined #wesnoth-dev
20140601 23:39:18-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140601 23:40:58-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 240 seconds]
20140601 23:42:21-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds]
20140601 23:54:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140601 23:58:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
--- Log closed Mon Jun 02 00:00:32 2014