--- Log opened Tue Jun 03 00:00:33 2014
20140603 00:19:44-!- mjs-de [~mjs-de@f049111005.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140603 00:29:05-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140603 01:00:27-!- sachith500 [~kvirc@112.134.19.25] has joined #wesnoth-dev
20140603 01:03:20-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140603 01:13:24-!- sachith500 [~kvirc@112.134.19.25] has quit [Read error: Connection reset by peer]
20140603 01:15:41-!- sachith500 [~kvirc@112.134.19.25] has joined #wesnoth-dev
20140603 01:20:11-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140603 01:29:04-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140603 01:42:18-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20140603 01:42:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140603 02:02:40-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140603 02:09:17-!- Spoffy [~chatzilla@152.78.175.8] has quit [Ping timeout: 252 seconds]
20140603 02:16:11-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140603 02:18:20-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has joined #wesnoth-dev
20140603 02:20:43-!- sachith500 [~kvirc@112.134.19.25] has quit [Read error: Connection reset by peer]
20140603 02:21:00-!- sachith500 [~kvirc@112.134.19.25] has joined #wesnoth-dev
20140603 02:26:05-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140603 02:39:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140603 02:45:07-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140603 02:48:38-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has quit [Ping timeout: 240 seconds]
20140603 02:50:03-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has joined #wesnoth-dev
20140603 02:50:28-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140603 03:06:14-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 252 seconds]
20140603 03:09:33-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140603 04:08:57-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20140603 04:22:19< shadowm> wesbot: seen happygrue
20140603 04:22:19< wesbot> shadowm: The person with the nick happygrue last spoke 2d 8h ago.  1h 37m ago was here and on the channels #wesnoth and #wesnoth-umc-dev with the message: Ping timeout: 240 seconds
20140603 04:23:57< shadowm> AI0867: Re http://forums.wesnoth.org/viewtopic.php?p=571196#p571196 , that commit isn't backportable at all.
20140603 04:24:18< shadowm> Is there a bug filed about the orbs issue so somebody will actually take a look at that monster of a commit?
20140603 04:31:47-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140603 04:37:17-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 255 seconds]
20140603 04:39:06-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140603 04:47:35-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140603 04:49:17-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140603 04:54:04-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140603 05:06:07< fabi> shadowm: A orb related bug is most likely mine.
20140603 05:13:12-!- cib [~cib@p5DC75A35.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140603 05:13:36-!- cib is now known as Guest38146
20140603 05:14:53-!- Guest38146 [~cib@p5DC75A35.dip0.t-ipconnect.de] has quit [Client Quit]
20140603 05:15:20-!- cib_ [~cib@p5DC75A35.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140603 05:27:47-!- irker285 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140603 05:35:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140603 05:43:16< iceiceice_> hmm does anyone have any idea whats going in this function?
20140603 05:43:17< iceiceice_> https://github.com/wesnoth/wesnoth/blob/master/src/display.cpp#L79
20140603 05:43:30< iceiceice_> i think it might be causing this bug, not sure...
20140603 05:43:31< iceiceice_> v
20140603 05:43:32< iceiceice_> https://gna.org/bugs/index.php?21723
20140603 05:47:31-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140603 06:16:24-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140603 06:16:45-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140603 06:33:22-!- cib_ [~cib@p5DC75A35.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140603 06:50:10-!- ArcusT7 [~arcus@s1722.dyn.hrz.tu-darmstadt.de] has joined #wesnoth-dev
20140603 06:59:11-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140603 06:59:32< ArcusT7> Hi, I've got a few questions. I'm using version 1.11.15 and noticed that i cant create forest-hills with the editor. The old combinated option is not available anymore. Is forest now kind of an overlay? Creating hills, creating forest above and get those 'forestified' hills? It isn't working for me anyway, so is it a bug or got this terrain removed?
20140603 07:00:23-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20140603 07:04:25-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140603 07:08:19-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 260 seconds]
20140603 07:08:29-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140603 07:12:50-!- groggy [~chatzilla@75-131-166-139.dhcp.spbg.sc.charter.com] has joined #wesnoth-dev
20140603 07:14:51< zookeeper> ArcusT7, yes, forest is now kind of an overlay, you should be able to paint them on hills by holding down shift (or ctrl, i forgot which)
20140603 07:16:15-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 260 seconds]
20140603 07:16:24-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140603 07:20:45-!- Kevin_Xi [~kevin@219.239.227.243] has joined #wesnoth-dev
20140603 07:23:05< Kevin_Xi> shadowm_desktop: https://gna.org/bugs/?22130 Done, thank you. I have read the guideline and hope it's the right format to report a bug(first time to do that).
20140603 07:26:31-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 260 seconds]
20140603 07:26:39-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140603 07:28:31-!- Kevin_Xi [~kevin@219.239.227.243] has quit [Quit: Leaving.]
20140603 07:31:31-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140603 07:33:34-!- kex [~kex@93-142-140-57.adsl.net.t-com.hr] has quit []
20140603 07:34:55-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 260 seconds]
20140603 07:35:33-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140603 07:45:38-!- ArcusT7 [~arcus@s1722.dyn.hrz.tu-darmstadt.de] has quit [Ping timeout: 240 seconds]
20140603 07:48:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140603 07:49:16-!- ArcusT7 [~arcus@s1722.dyn.hrz.tu-darmstadt.de] has joined #wesnoth-dev
20140603 07:54:00-!- sachith500|2 [~kvirc@112.134.157.163] has joined #wesnoth-dev
20140603 07:56:53-!- sachith500 [~kvirc@112.134.19.25] has quit [Ping timeout: 252 seconds]
20140603 08:13:17-!- ArcusT7 [~arcus@s1722.dyn.hrz.tu-darmstadt.de] has quit [Ping timeout: 240 seconds]
20140603 08:16:09-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140603 08:19:03-!- sachith500|2 [~kvirc@112.134.157.163] has quit [Ping timeout: 245 seconds]
20140603 08:25:59-!- kex [~kex@212.92.210.53] has joined #wesnoth-dev
20140603 08:30:58-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140603 08:33:14-!- sachith500|2 [~kvirc@112.134.157.163] has joined #wesnoth-dev
20140603 08:37:27-!- irker450 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140603 08:37:27< irker450> wesnoth: Boldizsár Lipka wesnoth:master ac96a2b91b32 / src/ (34 files in 6 dirs): Move some functions to sdl/rect. http://git.io/rJ-Hcg
20140603 08:37:29< irker450> wesnoth: Boldizsár Lipka wesnoth:master 7ca6ad8ad144 / src/ (33 files in 13 dirs): Move sdl_utils to sdl/utils. http://git.io/ps0luA
20140603 08:37:32< irker450> wesnoth: Boldizsár Lipka wesnoth:master 5a821a4d76de / src/sdl/rect.hpp: Correct a typo. http://git.io/AiPvgg
20140603 08:37:34< irker450> wesnoth: Boldizsár Lipka wesnoth:master bc214306405f / src/sdl/rect.hpp: Added doc comments in sdl/rect.hpp. http://git.io/RRdV7g
20140603 09:01:55-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 276 seconds]
20140603 09:07:57-!- groggy [~chatzilla@75-131-166-139.dhcp.spbg.sc.charter.com] has quit [Remote host closed the connection]
20140603 09:13:31-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has joined #wesnoth-dev
20140603 09:19:34-!- mjs-de [~mjs-de@f049072089.adsl.alicedsl.de] has joined #wesnoth-dev
20140603 09:19:49-!- haudegen_ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140603 09:44:31-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.]
20140603 09:47:29-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140603 09:49:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140603 10:01:58-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140603 10:10:22-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140603 11:24:04-!- Spoffy [~chatzilla@82.199.155.15] has joined #wesnoth-dev
20140603 11:29:29-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has quit [Ping timeout: 255 seconds]
20140603 11:32:52-!- cib_ [~cib@132.231.178.82] has joined #wesnoth-dev
20140603 11:37:36-!- irker450 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140603 12:02:33-!- cib_ [~cib@132.231.178.82] has quit [Ping timeout: 240 seconds]
20140603 12:43:56-!- Turuk_ [40399930@gateway/web/cgi-irc/kiwiirc.com/ip.64.57.153.48] has joined #wesnoth-dev
20140603 12:55:49< AI0867> 06:23 < shadowm> AI0867: Re http://forums.wesnoth.org/viewtopic.php?p=571196#p571196 , that commit isn't backportable at all. ← I know, that's why I said someone should dissect why it fixes the issue (in the forums)
20140603 13:17:00-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140603 13:18:00-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140603 14:15:16-!- cib_ [~cib@132.231.178.197] has joined #wesnoth-dev
20140603 14:20:57-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has joined #wesnoth-dev
20140603 14:22:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140603 14:26:33-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has quit [Ping timeout: 245 seconds]
20140603 14:26:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140603 14:27:23-!- cib_ [~cib@132.231.178.197] has quit [Ping timeout: 252 seconds]
20140603 14:28:28< iceiceice_> AI0867, shadowm : I don't think the behavior is actually different for the orb thing in 1.12, master, its just that the default preferences are different
20140603 14:34:55-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140603 14:37:03< AI0867> foiled by the preferences changes again?
20140603 14:37:48-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 252 seconds]
20140603 14:42:45-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140603 14:42:54-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140603 14:43:47< iceiceice_> hmm so why cant we backport the orb preferences?
20140603 14:44:00< iceiceice_> was it after feature freeze?
20140603 14:45:37< iceiceice_> y i guess its not backportable
20140603 14:55:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140603 15:06:51-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140603 15:23:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140603 15:26:14-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140603 15:30:05-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140603 15:49:18-!- Bodhi-Baum [~Bodhi@dslb-084-063-012-028.pools.arcor-ip.net] has joined #wesnoth-dev
20140603 15:53:05< iceiceice> AI0867, shadowm, anyone with a good sense for ui things: i made PRs to make statues not have movement orbs in master and 1.12, i think that this is the right way to to fix the issue, not try to subdivide fabi's commit
20140603 15:53:24< iceiceice> i dont normally make ui patches so i decided to make a PR rather than just merge unilaterally
20140603 15:53:33-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140603 15:58:42-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Read error: Connection reset by peer]
20140603 16:07:06-!- haudegen_ is now known as haudegen
20140603 16:07:48-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds]
20140603 16:21:09-!- cib_ [~cib@p5DC75A35.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140603 16:29:31-!- _8680_ [~8680@2002:4404:712c:0:f12e:e9eb:bef2:b2af] has quit [Ping timeout: 240 seconds]
20140603 16:30:32-!- _8680_ [~8680@2002:4404:712c:0:791f:f289:f536:ed27] has joined #wesnoth-dev
20140603 16:33:13-!- dacovale [~niklas@93.182.140.32] has joined #wesnoth-dev
20140603 16:33:56-!- irker321 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140603 16:33:56< irker321> wesnoth: Chris Beck wesnoth:master f364f217be76 / src/game.cpp: fixup c8699e2f057b14b19ba60dbd4e71f4647b45ca78 http://git.io/lGMk8Q
20140603 16:33:56< irker321> wesnoth: Chris Beck wesnoth:master 315152d11649 / src/ (63 files in 14 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/1UVjXw
20140603 16:34:04-!- kex [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140603 16:34:31-!- kex [~kex@212.92.210.53] has joined #wesnoth-dev
20140603 16:38:48-!- kex [~kex@212.92.210.53] has quit [Ping timeout: 240 seconds]
20140603 16:41:20< irker321> wesnoth: Chris Beck wesnoth:master 79f1e2e836db / .travis.yml: travis, don't run wml unit tests with gcc http://git.io/Y-Kcvg
20140603 16:48:55-!- Spoffy [~chatzilla@82.199.155.15] has quit [Ping timeout: 252 seconds]
20140603 16:50:43-!- kex [~kex@93-142-140-57.adsl.net.t-com.hr] has joined #wesnoth-dev
20140603 17:09:28< fabi> iceiceice: Yes, I will make them being absent the default, the UI to configure them might be a candidate for a 1.12.1 backport. Thank you, it is good to  have a bug report about them, please assign it to me.
20140603 17:09:50< iceiceice> fabi: do you like the patch i submitted?
20140603 17:10:19< fabi> iceiceice: I have not seen it yet, what is it doing? Please give me a link.
20140603 17:10:31< iceiceice> https://github.com/wesnoth/wesnoth/pull/186
20140603 17:10:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140603 17:10:38< iceiceice> idk maybe you have something else in mind, this makes sense to me
20140603 17:29:44< fabi> iceiceice: This will work well for 1.12. The preferences gui makes every orb being optional but it needs some string changes thus can't make it into 1.12
20140603 17:29:58-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140603 17:30:21< iceiceice> ok feel free to pull then, etiher version
20140603 17:44:04 * AI0867 goes to hit merge on both
20140603 17:44:23< irker321> wesnoth: Chris Beck wesnoth:master 0f2777e1679f / src/unit.cpp: no movement orbs for enemy statues http://git.io/pYO2Hg
20140603 17:44:25< irker321> wesnoth: Alexander van Gessel wesnoth:master eb9076af9a7c / src/unit.cpp: Merge pull request #186 from cbeck88/fixup_statue_orbs http://git.io/2eSpwA
20140603 17:44:32< irker321> wesnoth: Chris Beck wesnoth:1.12 089ba15ad5f7 / src/unit.cpp: no movement orbs for enemy statues http://git.io/uz1hxA
20140603 17:44:34< irker321> wesnoth: Alexander van Gessel wesnoth:1.12 01fe3f50bdae / src/unit.cpp: Merge pull request #187 from cbeck88/fixup_statue_orbs_1.12 http://git.io/bdAagA
20140603 17:51:08-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has quit [Quit: Leaving]
20140603 17:52:53-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140603 17:54:29-!- sachith500 [~kvirc@112.134.150.216] has joined #wesnoth-dev
20140603 17:56:07-!- haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Read error: Connection reset by peer]
20140603 17:56:42-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140603 17:56:56-!- sachith500|2 [~kvirc@112.134.157.163] has quit [Ping timeout: 255 seconds]
20140603 17:58:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140603 18:00:24-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20140603 18:00:24-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20140603 18:00:24-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140603 18:00:39< mordante> servus
20140603 18:01:26-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140603 18:05:03-!- gfgtdf [~chatzilla@d230129.adsl.hansenet.de] has joined #wesnoth-dev
20140603 18:06:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140603 18:08:28-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140603 18:21:36-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20140603 18:28:28< mordante> Kevin_Xi, iceiceice, shadowm the shift/caps lock issue is master only for me I think I broke it with some of the recent SDL2 input updates, will have a look later
20140603 18:31:38-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has quit [Ping timeout: 240 seconds]
20140603 18:35:51-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140603 18:35:59< iceiceice> hmm i am noticing a very wierd visual bug
20140603 18:36:01< iceiceice> in master
20140603 18:36:15< iceiceice> if you recruit a unit in planning mode,
20140603 18:36:21< iceiceice> its ghost image is like twitching
20140603 18:36:24< happygrue> shadowm: looking for me?
20140603 18:36:25< iceiceice> if the unit has an animated creation
20140603 18:36:33< iceiceice> like, for fencer or horseman
20140603 18:36:40< iceiceice> idk if it affects 1.12
20140603 18:36:50< Turuk_> happygrue: Yes
20140603 18:37:07-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20140603 18:40:58-!- cib_ [~cib@p5DC75A35.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140603 18:43:52< irker321> wesnoth: Boldizsár Lipka wesnoth:master c44163046784 / src/ (17 files in 5 dirs): Move fill_rect to sdl/rect.hpp. http://git.io/lSqdfg
20140603 18:43:54< irker321> wesnoth: Boldizsár Lipka wesnoth:master 51095a3df100 / src/ (16 files in 5 dirs): sdl_fill_rect -> fill_rect. http://git.io/YpPD8w
20140603 18:43:56< irker321> wesnoth: Boldizsár Lipka wesnoth:master 7f499f7f5070 / src/sdl/ (rect.cpp rect.hpp): Add fill_rect and draw_rect for SDL_Renderer. http://git.io/nOzdBA
20140603 18:44:15-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140603 18:45:12-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140603 18:45:38-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has joined #wesnoth-dev
20140603 18:45:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20140603 18:51:17< lipkab> Whenever Firefox starts to correctly expand "irclogs" to this month's url, I always have to realize that it's already next month :(
20140603 18:52:43< lipkab> Maybe I should purge the May url from the history.
20140603 18:53:35< mordante> http://wesnoth.debian.net/ holds the last ones always at the same place
20140603 18:54:28< lipkab> Oh, that's nice! Thanks!
20140603 18:55:02< lipkab> mordante: Yeah, by the way, I'm here for the weekly consultation.
20140603 18:56:39< iceiceice> mordante: thanks for that
20140603 19:00:32-!- Spoffy [~chatzilla@82.199.155.15] has joined #wesnoth-dev
20140603 19:00:59-!- shadowm_desktop [ignacio@186.9.9.125] has joined #wesnoth-dev
20140603 19:01:07< gfgtdf> iceiceice: you know when non_interactive() can be true?
20140603 19:01:26-!- shadowm_desktop is now known as Guest28067
20140603 19:02:21< iceiceice> i never read the code exactly
20140603 19:02:25< iceiceice> i just assume that it works :/
20140603 19:02:33< iceiceice> but i hope that it is, when we are using a fake display
20140603 19:02:43< iceiceice> like, running headless mp from command line for ai testing,
20140603 19:02:46< iceiceice> or running unit tests
20140603 19:03:07-!- sachith500 [~kvirc@112.134.150.216] has quit [Read error: Connection reset by peer]
20140603 19:03:23-!- sachith500 [~kvirc@112.134.150.216] has joined #wesnoth-dev
20140603 19:03:45< gfgtdf> iceiceice: in 65250df255e78405901927480ad98a25985e5f3f why did you changed it into not making a OOS savegame?
20140603 19:05:07< gfgtdf> iceiceice: is there some relation that non_interactive usually implies no disk or something ?
20140603 19:10:29-!- Bodhi-Baum [~Bodhi@dslb-084-063-012-028.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140603 19:10:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140603 19:12:00< iceiceice> gfgtdf: hmm let me see where you are talking about
20140603 19:12:27< iceiceice> hmm so
20140603 19:12:39< iceiceice> i guess for non_interactive you cannot ask the user how to proceed about oos
20140603 19:12:57< iceiceice> so you certainly cannot use the interactive savegame dialog
20140603 19:13:06< iceiceice> in the two cases imentioned,
20140603 19:13:09< iceiceice> ai testing and headless unit tests,
20140603 19:13:16< iceiceice> you dont want to try to proceed with the game,
20140603 19:13:19< iceiceice> you just want to have a command-line error
20140603 19:13:32< iceiceice> so i just made it throw game error in this case
20140603 19:13:40< iceiceice> which causes unit tests to fail
20140603 19:13:47< iceiceice> anyways you should not get OOS in a vanilla ai testing scenario
20140603 19:14:03< iceiceice> hmm actually htis code is even in the replay controller
20140603 19:14:09< gfgtdf> iceiceice: i tealked about https://github.com/wesnoth/wesnoth/blob/a706e059faa3d9205d6876cacea1bb83fb4bcfc9/src/replay_controller.cpp#L371 but i now think i usualy isnt important to save there anyways since you still have the save wich you original yrpelayed
20140603 19:14:13< iceiceice> i think the only way this could possibly be called is from the unit tests
20140603 19:14:17< iceiceice> so i made it do what i wanted
20140603 19:15:09< iceiceice> y i think its not too important to get the oos save when you are running the noninteractive unit test,
20140603 19:15:14< iceiceice> you can just run it again with --showgui
20140603 19:15:20< iceiceice> and then it will be interactive and you can do what you want.
20140603 19:15:42< iceiceice> so i dont see a big reason to change it although its not important that it stays how it is
20140603 19:21:31< gfgtdf> iceiceice: in https://github.com/wesnoth/wesnoth/blob/master/src/savegame.cpp#L864 we disallow some characters onyl for windows
20140603 19:21:46-!- sachith500 [~kvirc@112.134.150.216] has quit [Read error: Connection reset by peer]
20140603 19:21:46< gfgtdf> iceiceice: shouldnt we disallow then for every os?
20140603 19:22:03-!- sachith500 [~kvirc@112.134.150.216] has joined #wesnoth-dev
20140603 19:22:04< iceiceice> i think you have to ask someone else about that
20140603 19:22:18< iceiceice> idk i think the file system stuff is still WIP?
20140603 19:22:33< gfgtdf> iceiceice: idk eigher how teh curewnt state is
20140603 19:22:39< iceiceice> https://github.com/wesnoth/wesnoth/pull/155
20140603 19:23:14< gfgtdf> iceiceice: hm it seems liek that doesnt touch teh savefile.cpp file
20140603 19:23:42< iceiceice> y but still, i think probly they will get around to it when that gets merged eventually
20140603 19:24:02< iceiceice> could make a comment on PR i guess
20140603 19:24:03-!- Guest28067 is now known as shadowm_desktop
20140603 19:24:04-!- shadowm_desktop [ignacio@186.9.9.125] has quit [Changing host]
20140603 19:24:04-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140603 19:24:14< iceiceice> hmm are you thinking about changing before 1.12 though?
20140603 19:24:30< gfgtdf> iceiceice: no im currently only tinking about master
20140603 19:25:14< gfgtdf> iceiceice: i dont really think like i should change code the i dont really know much about in 1.12 anymore.
20140603 19:26:31< iceiceice> i think im just going to try to refactor master to make it simpler, and if i discover bugs in the process then fix them and try to backport
20140603 19:26:40< iceiceice> but i dont really want to just read 1.12 code...
20140603 19:28:19< iceiceice> btw i have read the whiteboard code now
20140603 19:28:29< iceiceice> it is actually quite nice
20140603 19:28:37< iceiceice> i dont think theres any bugs in it anymore,
20140603 19:28:45< iceiceice> maybe in the networked mp aspect, hard to say...
20140603 19:28:52< iceiceice> i think the issues are probably in the game_display fake_units
20140603 19:29:27-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: Vannak idők, mikor menni kell]
20140603 19:29:30< gfgtdf> iceiceice: you know what this code does : https://github.com/wesnoth/wesnoth/blob/master/src/savegame.cpp#L59
20140603 19:29:52< iceiceice> no idea
20140603 19:31:01< iceiceice> hmm i have a question
20140603 19:31:06< iceiceice> if unit facing is now made deterministic,
20140603 19:31:21< iceiceice> does that mean it is a bug if i create a networked game with observer
20140603 19:31:33< iceiceice> and the observer sees the leader facing differently from how its owner sees it?
20140603 19:31:46< gfgtdf> iceiceice: i'd say yes
20140603 19:31:50< gfgtdf> ah no
20140603 19:32:18< gfgtdf> iceiceice: i didnt real teh code exactly but maybe teh only effect normal recruitung idk?
20140603 19:32:35< gfgtdf> iceiceice: it seems like we undef some marcos the might have different meansing on windows and linux there, but i wonder how that could work
20140603 19:33:16< gfgtdf> iceiceice: especiayal becasue i think its wrong  to assume that windows.h wast already included by some other header (boost/std)so this might have no effect
20140603 19:33:29< gfgtdf> s/real/read
20140603 19:33:40< iceiceice> gfgtdf: you can run git blame i guess?
20140603 19:33:54< iceiceice> gfgtdf: i think maybe we should also make the team_builder generate leaders with deterministic facing
20140603 19:34:10< iceiceice> it looks like we successfully synced recruits being created facing
20140603 19:34:15< iceiceice> but not the leaders
20140603 19:34:53< iceiceice> pretty minor bug thouhg
20140603 19:35:44< irker321> wesnoth: Chris Beck wesnoth:master 1ec273c88265 / src/ (14 files in 3 dirs): move temporary unit movers to game_board, adapt slightly. http://git.io/mPzwMw
20140603 19:35:46< irker321> wesnoth: Chris Beck wesnoth:master 94b057f231fc / src/ (14 files in 3 dirs): Merge branch 'move_temp_unit_structs_to_game_board' http://git.io/n78eNg
20140603 19:37:21-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140603 19:38:08< iceiceice> idk those undefs were added here,
20140603 19:38:09< iceiceice> https://github.com/wesnoth/wesnoth/commit/9dee31d3
20140603 19:38:11< iceiceice> hard to say why
20140603 19:40:01< iceiceice> does it break something in windows.hpp if they are defined?
20140603 19:40:24< iceiceice> idk it might be some wierd compiler specific thing
20140603 19:41:06-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140603 19:41:13< gfgtdf> iceiceice:  i am sure that at least on my version these lines have no effect because windows.h is included earlier by some boost / std header
20140603 19:45:45-!- kex [~kex@93-142-140-57.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140603 19:46:17< iceiceice> hmm well if you want to remove it i would say just do it, and maybe make a note in changelog in case someone has an issue later
20140603 19:46:25< iceiceice> idk
20140603 19:46:32-!- kex [~kex@93.143.101.220] has joined #wesnoth-dev
20140603 19:46:34< iceiceice> maybe can ask the person who made the change?
20140603 19:46:50< iceiceice> if you are pretty sure it has no effect then its probably fine
20140603 19:47:05< iceiceice> idk its up to you
20140603 19:47:49-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Remote host closed the connection]
20140603 19:49:41-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev
20140603 19:51:30-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Remote host closed the connection]
20140603 19:52:10-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20140603 19:52:15-!- sachith500 [~kvirc@112.134.150.216] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140603 19:58:37< iceiceice> man this is pretty annoying
20140603 19:58:42< iceiceice> you cannot forward declare an enum?
20140603 19:58:46-!- Turuk_ [40399930@gateway/web/cgi-irc/kiwiirc.com/ip.64.57.153.48] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
20140603 19:59:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140603 20:01:43-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140603 20:01:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20140603 20:04:01< mordante> iceiceice, no you can't, it is possible with C++11
20140603 20:04:12< iceiceice> what is the best workaround?
20140603 20:04:36< iceiceice> i'm trying to pass the enum by reference instead...
20140603 20:04:41< iceiceice> this function will not be called often
20140603 20:06:09< shadowm> Isn't passing an integer by reference wasteful if it's the native word size?
20140603 20:06:31< shadowm> Not that there's any size guarantees with enums in previous C++ standards IIRC.
20140603 20:06:42< iceiceice> it is far more wasteful to include the relevant header...
20140603 20:07:29< Spoffy> C++11 is nice.
20140603 20:07:41< iceiceice> shadowm: fwiw, most of our code passes map locations by constant reference,
20140603 20:08:00< shadowm> I read that and I'm not too sure how that is a waste of space.
20140603 20:08:00< iceiceice> a map_location is 2 32-bit ints, iiuc then in a 64 bit machine that is one register
20140603 20:08:06< Spoffy> Well, nicer than C++03.
20140603 20:08:20< shadowm> But you aren't guaranteed to be running or compiling for a 64-bit platform.
20140603 20:08:31< iceiceice> y but even then when things are small enough it is a tradeoff
20140603 20:08:41< shadowm> All our Windows builds are 32-bit, for example.
20140603 20:08:53< iceiceice> if you pass a pointer p to a map_location,
20140603 20:09:06< iceiceice> then to get x, you need a register to hold p, and then a register to hold x
20140603 20:09:14< iceiceice> in reality whenever you get x, you also want y
20140603 20:09:18< iceiceice> so now you need 3 registers
20140603 20:09:22< iceiceice> and like 4 operations
20140603 20:09:53< iceiceice> gfgtdf points out that if you have a long sequence of functions where the map_location is passed by pointer,
20140603 20:09:57< iceiceice> then maybe there is savings
20140603 20:10:41< shadowm> To be honest I didn't have much interest in optimization when I started contributing, and I didn't know much about platform internals like that, so I just assumed that the convention was to use references for non-integral types.
20140603 20:10:50< mordante> iceiceice, I would just include the header, there are no real other solutions
20140603 20:10:55< iceiceice> i think differnet people have different conventions
20140603 20:11:05< iceiceice> mordante:
20140603 20:11:13< iceiceice> i really really dont want to include the header...
20140603 20:11:20< mordante> why not?
20140603 20:11:20< shadowm> It sucks to work in a project where that is true and there's no project-wide convention, though.
20140603 20:11:30< iceiceice> i'm trying to write a wrapper to go around unitmap, gamemap
20140603 20:11:35< iceiceice> and be a child of gamestate eventually
20140603 20:11:46< iceiceice> this object needs to be referred to in many places, including AI
20140603 20:11:51< iceiceice> if i include the map header,
20140603 20:11:58< iceiceice> then ai will now have to include terrain type, terrain translations etc.
20140603 20:12:01< iceiceice> when it compiles
20140603 20:12:31< iceiceice> thats currently what is happening in master as of a few days ago, and i think compilation got marginally slower because of it
20140603 20:13:02< iceiceice> if compilation takes more than 50 minutes on gcc then travis times out
20140603 20:13:11< gfgtdf> iceiceice: you coudl aslo put teh enum i a seperate header
20140603 20:13:15< gfgtdf> in a
20140603 20:13:22< iceiceice> y i may put it in global or osmeting
20140603 20:13:50< gfgtdf> iceiceice: no i dont think that this is what global is used for
20140603 20:14:07< iceiceice> hmm
20140603 20:14:21< iceiceice> well maybe i will just make the wrapper take an int instead
20140603 20:14:25< iceiceice> and use switch case to map it to an enum
20140603 20:14:31< iceiceice> because ... these functions are used in like 2 places
20140603 20:14:36< mordante> please don't add ugly code
20140603 20:14:46< mordante> if the enum is required use it
20140603 20:15:16< iceiceice> ok
20140603 20:16:19< gfgtdf> iceiceice: which enum to you tak about especialy ?
20140603 20:16:43< iceiceice> this function change_terrain
20140603 20:16:58< iceiceice> in gamemap, whcih i have added an interface to in game_board
20140603 20:17:06< iceiceice> i think it is used only by lua...
20140603 20:17:12< iceiceice> maybe should just change the type of it
20140603 20:18:55-!- dacovale [~niklas@93.182.140.32] has quit [Quit: Leaving.]
20140603 20:19:04< iceiceice> y thats what i will do
20140603 20:19:45< mordante> what enum is it?
20140603 20:21:19< mordante> which*
20140603 20:23:56-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140603 20:27:25< gfgtdf> iceiceice: i still suggest putting ti into a seperate new header file
20140603 20:28:07< iceiceice> i think it is working fine now,
20140603 20:28:09< gfgtdf> iceiceice: an i think i also changes my mind so that i dont think anymore that it is good to put an enum into a class that uses that enum
20140603 20:28:45< iceiceice> all i did was rearrange things,
20140603 20:28:55< iceiceice> the conversion to enum happens inside the wrapper, where we have the defn of enum
20140603 20:29:03< iceiceice> closer to where it is used
20140603 20:29:25< iceiceice> when we get to c++11 can change it back i guess
20140603 20:31:36< mordante> please don't uglify the code for something as silly as compile time
20140603 20:31:50< mordante> that only makes the code less maintainable
20140603 20:32:04< iceiceice> ok, i dont think this is uglier
20140603 20:32:09< iceiceice> you can be the judge though
20140603 20:37:20-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20140603 20:37:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140603 20:39:57< mordante> I'm off bye
20140603 20:40:13-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140603 20:51:45-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Ping timeout: 240 seconds]
20140603 21:00:13-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140603 21:06:44-!- iceiceice_ [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140603 21:09:58< gfgtdf> iceiceice_: i'm thinking about to change the makeenum macro to create soem kind of c++99 compatible enum class 
20140603 21:10:15< gfgtdf> iceiceice_: that woudl also be nor ptyesafe then
20140603 21:10:20< gfgtdf> more typesafe
20140603 21:10:29< iceiceice_> do as you like
20140603 21:10:36< iceiceice_> i guess in the next C++ we can make it an enum class?
20140603 21:11:06< iceiceice_> afaict its doing its job,
20140603 21:11:20< iceiceice_> i only wanted to have something that will auto flag a wml error if user configs or data are messedup
20140603 21:11:28< iceiceice_> that was prety much my criteria
20140603 21:11:37< iceiceice_> if you have more ambitions, knock yourself out :)
20140603 21:15:16-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140603 21:16:27< gfgtdf> iceiceice_: i just saw that we have a category "gobal" for hotkeys, but obvouslys there are some hotkeys in there which won't work in titlesscreen like "Raname Unit" so i wonder whether this is teh best olution
20140603 21:16:54< iceiceice_> idk i never looked there, i have very little idea about hotkeys
20140603 21:18:31< gfgtdf> or "Mute"
20140603 21:20:51< gfgtdf> ah ok i thought mute was an mp chat command what it was related to sound
20140603 21:21:16< iceiceice_> thats wierd
20140603 21:21:18< iceiceice_> i didnt know that
20140603 21:22:00-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140603 21:22:00< gfgtdf> didnt know what ?
20140603 21:22:17< iceiceice_> mute
20140603 21:22:41< gfgtdf> mute just disables sound i think
20140603 21:23:07< gfgtdf> maybe it's just relate to teh i usualy play without sond that i thought different
20140603 21:32:57-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140603 21:34:17-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140603 21:40:38-!- gfgtdf_ [~chatzilla@e177149032.adsl.alicedsl.de] has joined #wesnoth-dev
20140603 21:42:23-!- gfgtdf [~chatzilla@d230129.adsl.hansenet.de] has quit [Ping timeout: 255 seconds]
20140603 21:42:32-!- gfgtdf_ is now known as gfgtdf
20140603 21:49:25-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20140603 21:49:45< iceiceice_> gfgtdf: do you think this is ugly?
20140603 21:49:45< iceiceice_> https://github.com/wesnoth/wesnoth/pull/188
20140603 21:57:23-!- stikonas__ is now known as stikonas
20140603 21:57:41< gfgtdf> iceiceice_: have no problem with using a smaprtointer pointer member to avoid an include, and if the only function that uses that function always has a string anyways i also don't see a problem with passing a string argument.
20140603 21:59:17< iceiceice_> ok
20140603 21:59:17-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140603 21:59:40< iceiceice_> i think its not a big deal, very little is changing here and i dont like that making this class made us include a lot mroe things, that was not my intention
20140603 21:59:51< iceiceice_> every time travis times out i feel compelled to hack around on it to try to make it not do that...
20140603 22:02:09-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140603 22:02:44< gfgtdf> iceiceice_: what does sentry do ? https://github.com/wesnoth/wesnoth/blob/master/src/make_enum.hpp#L199
20140603 22:03:39-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140603 22:05:01-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has joined #wesnoth-dev
20140603 22:05:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20140603 22:05:46-!- haudegen [~quassel@178.115.128.144.wireless.dyn.drei.com] has joined #wesnoth-dev
20140603 22:06:13< iceiceice_> it makes sure the stream is not already screwed
20140603 22:06:31-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140603 22:06:52-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140603 22:07:00< iceiceice_> idk it is in all the code examples...
20140603 22:07:02< iceiceice_> i think the point is, 
20140603 22:07:06< iceiceice_> the stream has error codes built into it
20140603 22:07:17< iceiceice_> if it failed earlier int he << chain for some reason,
20140603 22:07:23< iceiceice_> if you then write more stuff to it,
20140603 22:07:30< iceiceice_> the code may now be different because of what you did
20140603 22:07:46< iceiceice_> idk its probably not really necesary
20140603 22:10:15< iceiceice_> gfgtdf: you shoudl also know,
20140603 22:10:20< iceiceice_> theres some more templates in .tpp somewhere
20140603 22:10:26< iceiceice_> i think the gui code already has some kind of smart enum
20140603 22:10:31< iceiceice_> idr exactly though
20140603 22:10:45< shadowm> They are just hacky emulations.
20140603 22:11:22< shadowm> Basically, you have an "enum class" (it's just a normal class) that's used to create a namespace for the enum members without C++11.
20140603 22:12:08< shadowm> e.g. class tmy_enum { public: enum scoped_enum { enum_member1, enum_member2 }; };
20140603 22:12:46< shadowm> So you use tmy_enum::enum_member1, tmy_enum::enum_member2 to refer to the enum members, and tmy_enum::scoped_enum to refer to the enum type itself.
20140603 22:12:48< iceiceice_> hmm this is almost exactly the same as what we did: https://github.com/wesnoth/wesnoth/blob/master/src/utils/enumerate.tpp
20140603 22:13:11< shadowm> As you can see it's pretty hacky and you'd still have to rearrange that code a bit the moment you get C++11 smart enums.
20140603 22:13:23< iceiceice_> maybe fancier it uses gettext
20140603 22:13:25< iceiceice_> hehe
20140603 22:13:39< iceiceice_>  i guess its just that it uses different errors...
20140603 22:13:52< iceiceice_> the make_enum throws twml exception, i think FAIL_WITH_DEV_MESSAGE does something else?
20140603 22:14:36< gfgtdf> shadowm: i actualy currently see nor disatvantages from class AAA {enum inner {A,B,C,}} over class enum
20140603 22:14:43< gfgtdf> s/nor/no
20140603 22:15:02< shadowm> "and tmy_enum::scoped_enum to refer to the enum type"
20140603 22:15:21-!- mjs-de [~mjs-de@f049072089.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140603 22:15:27< shadowm> If it were a true enum class you'd be able to refer to it as tmy_enum, right?
20140603 22:15:49< iceiceice_> hmm idk
20140603 22:15:51< gfgtdf> ah yes that can be fixed i think
20140603 22:15:55< iceiceice_> they are almost the same
20140603 22:15:58< shadowm> But since this isn't C++11, you can't do that.
20140603 22:16:00< iceiceice_> we defined a "bad_enum_cast" exception
20140603 22:16:10< iceiceice_> thats like the only difference
20140603 22:16:39< iceiceice_> also this namespace detail thing
20140603 22:16:44< iceiceice_> i guess we decided not to do that
20140603 22:17:16< gfgtdf> shadowm: i actualy liek the way itrs done in teh seconds post here: http://stackoverflow.com/questions/2503807/declaring-an-enum-within-a-class
20140603 22:17:32< gfgtdf> shadowmseconds answer = third post
20140603 22:17:42< gfgtdf> second answer = third post *
20140603 22:18:44< iceiceice_> the enum class?
20140603 22:18:48< iceiceice_> y that seems lke the best option
20140603 22:19:09< iceiceice_> and also that one can be forward declared
20140603 22:20:47< shadowm> Ah, seems like someone managed to break kdevelop.
20140603 22:21:05< shadowm> It's taking really long to parse wesnoth's source and it's using around 3 GiB of RAM for that.
20140603 22:22:12< gfgtdf> shadowm: was that coment related to the enum in teh post above ?
20140603 22:24:44< shadowm> No.
20140603 22:25:38-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has quit [Ping timeout: 240 seconds]
20140603 22:25:46< gfgtdf> iceiceice_: so my enummakecurrentl lookes liek this: http://pastebin.com/Ks6Eq44v
20140603 22:26:16< gfgtdf> currently*
20140603 22:27:04< iceiceice_> gfgtdf: what i think woudl actually be useful woudl be if
20140603 22:27:11< iceiceice_> the enum could take multiple strings per value
20140603 22:27:22< iceiceice_> so that if we change things we can make it backwards compatible easily
20140603 22:28:03< iceiceice_> like, each item is like, an int or whatever, and a list of strings
20140603 22:28:08< iceiceice_> the int always maps to the first in the list,
20140603 22:28:11< iceiceice_> but any in the list map to that int
20140603 22:28:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140603 22:28:21< gfgtdf> int ?
20140603 22:28:29< iceiceice_> the numeric value of enum
20140603 22:28:34< iceiceice_> er,
20140603 22:28:35< iceiceice_> identifier
20140603 22:29:05< iceiceice_> if you want to define & , | for enum like your comment says, will you allow to specify the bit pattern?
20140603 22:29:39< iceiceice_> note that i think thats not really necessary
20140603 22:29:43< gfgtdf> iceiceice_: no that was just a thought, but unlsees i see a specific use i wont implement
20140603 22:29:56< iceiceice_> i think only use is for unit states
20140603 22:30:03< iceiceice_> i dont see anywhere else that we do that though
20140603 22:30:08 * shadowm plucks his eyes out to be able to read campaign_server.cpp properly.
20140603 22:30:14< gfgtdf> iceiceice_: it's just that i always was anooyes form A & B returns an int if both are enums
20140603 22:32:12< gfgtdf> iceiceice_: note that teh new enums dont have a default contructor and also arent implicit vonvertible to int
20140603 22:32:29< gfgtdf> at least not an eplicit default contructor
20140603 22:32:34< gfgtdf> explicit
20140603 22:32:40< iceiceice_> hmm does that break anything atm?
20140603 22:32:47< iceiceice_> i thnk it will break the use for unit type alignments 
20140603 22:33:13< gfgtdf> iceiceice_: why ?
20140603 22:33:45< iceiceice_> https://github.com/wesnoth/wesnoth/blob/master/src/unit_types.hpp#L246
20140603 22:35:35< gfgtdf> iceiceice_:  whats so mena about that ?
20140603 22:35:52< iceiceice_> idk if you dont want them to be static castable then you have to fix that code, that's all
20140603 22:36:15< shadowm> iceiceice_: What about statues owned by the player, by the way?
20140603 22:36:16< iceiceice_> hmm maybe i'm wrong? does that not involve implicit cast to int?
20140603 22:36:28< shadowm> (No, I haven't looked at your PR. I'm busy.)
20140603 22:36:29< iceiceice_> shadowm: http://forums.wesnoth.org/viewtopic.php?f=5&t=40493&sid=80089ac2597b2ff16bb9002c8d3832db&start=30
20140603 22:36:34< iceiceice_> it got merged by AI
20140603 22:36:35< gfgtdf> iceiceice_: i dotn see wherer taht code does a mean cast to ?
20140603 22:36:42< iceiceice_> gfgtdf:
20140603 22:36:46< iceiceice_> i static cast the alignement enum
20140603 22:36:50< iceiceice_> to the alignment female enum
20140603 22:36:52< shadowm> Okay, that doesn't answer my question but whatever.
20140603 22:36:54< iceiceice_> so i can then convert to get the right string
20140603 22:36:58< iceiceice_> shadowm: 
20140603 22:37:05< gfgtdf> iceiceice_: ah 
20140603 22:37:21< iceiceice_> since tek complained and AI did all that work to bisect why the statues ahve a move orb,
20140603 22:37:36< iceiceice_> i decided to take a look, i think the right fix is,
20140603 22:37:50< iceiceice_> statues shoudl never have move orbs.
20140603 22:38:00< iceiceice_> fabi might think diferently though,
20140603 22:38:04< iceiceice_> so the thing i proposed was
20140603 22:38:07< gfgtdf> iceiceice_: i think that cn be solved, it not liek its impossible its just to prevent doing it implcit
20140603 22:38:09< iceiceice_> statues you don't control should never have move orbs
20140603 22:38:37< iceiceice_> you dont have to pay attention to this, i'm only mentioning to point out the resolution
20140603 22:38:59< shadowm> iceiceice_: Okay, but you coud have stuffed it all in a single line so the message would've been more readable. :p
20140603 22:39:16< shadowm> That means statues owned by the player (the *active* player) will still have orbs?
20140603 22:39:17< iceiceice_> sorry :X
20140603 22:40:50< iceiceice_> when *you* look at a statue controlled by an enemy side, it will always have no move orb
20140603 22:41:03< iceiceice_> it doesnt matter whose turn it is i believe
20140603 22:41:32< iceiceice_> if its your statue i guess you will get the "i cant move" orb
20140603 22:41:35< shadowm> Of course I mean the player who is playing the current turn, sigh.
20140603 22:42:02< iceiceice_> y
20140603 22:43:07< iceiceice_> it only depends on the "viewing_side" (whose flag is in the gui) not the "active side" (who is making moves atm)
20140603 22:43:20< shadowm> OK this is my first time checking out master in like two months and I'm already seeing stuff I don't like. Not from any of the present people, though.
20140603 22:44:02< shadowm> Does anyone here know offhand if we have functionality to match CIDR masks?
20140603 22:44:12< iceiceice_> i will have to google that :X
20140603 22:44:49< iceiceice_> idk my client is giving me some funny messages "Reeived a CTCP VERSION from shadowm"
20140603 22:45:40< shadowm> Yeah I was curious if you were using a mobile client or something. Sorry.
20140603 22:50:16< iceiceice_> gfgtdf: if you really want to change the enum thing to a struct,
20140603 22:50:30< iceiceice_> maybe that static cast can just become a really crazy cast?
20140603 22:50:35< iceiceice_> idk
20140603 22:50:53< iceiceice_> i would guess that class { int} and class {int } would be reinterpret castable in basically the way that enums are
20140603 22:51:07< iceiceice_> but its a bit gross
20140603 22:51:23< iceiceice_> its pretty rare we have to cast enums anyways thoguh
20140603 22:51:52< shadowm> I think we aren't supposed to use reinterpret_cast.
20140603 22:52:20< gfgtdf> iceiceice_: if we rely need it we can easiyl add a to_int /from_int method
20140603 22:52:23< gfgtdf> really*
20140603 22:52:44< iceiceice_> shadowm: hmm so did i miss a memo somewhere?
20140603 22:52:54< iceiceice_> we seem to use const cast from time to time
20140603 22:53:36< iceiceice_> idk if we aren't supposed to use reinterpret cast we should write on wiki or something
20140603 22:54:09< shadowm> "I think".
20140603 22:54:10< iceiceice_> actually we use a lot of reinterpret_casts :X
20140603 22:54:20-!- cjhopman [~cjhopman@216.239.45.92] has quit [Quit: Konversation terminated!]
20140603 22:54:28< shadowm> It's essentially a glorified C-style cast, isn't it?
20140603 22:55:21-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 248 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140603 22:55:25< iceiceice_> y
20140603 22:55:40< iceiceice_> i get like 20 or 30 hits wtih grep
20140603 22:56:40< iceiceice_> hmm this is the only one that looks questionable: https://github.com/wesnoth/wesnoth/blob/master/src/multiplayer_lobby.cpp#L394
20140603 22:57:06< iceiceice_> maybe not though ik
20140603 22:57:08< iceiceice_> *idk
20140603 23:01:13-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140603 23:03:02-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140603 23:05:39< gfgtdf> iceiceice_: if you communicate with a C library you sometime have to do such things
20140603 23:06:11< iceiceice_> y seems so
20140603 23:08:03< gfgtdf> iceiceice_: ´https://github.com/wesnoth/wesnoth/blob/1d2a59b0ab7cdc3907457842dd09ba8f2196197c/src/hash.cpp#L28
20140603 23:08:42< gfgtdf> and not even comminicating with a c library
20140603 23:10:40< iceiceice_> y the stuff in md5.cpp looks pretty gnarly
20140603 23:10:48< iceiceice_> idk what is that supposed to do?
20140603 23:12:59< gfgtdf> iceiceice_: some code uses it for password hases i think
20140603 23:13:46< shadowm> Did anything change as of late about how Wesnoth writes WML?
20140603 23:13:47< gfgtdf> iceiceice_: for from member certification on teh mpserver i think
20140603 23:14:03< gfgtdf> how "late" do you mean ?
20140603 23:14:15< gfgtdf> no i dotn know abot any late ahcnges
20140603 23:14:20< gfgtdf> late changes*
20140603 23:14:31-!- Grickit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140603 23:14:34< gfgtdf> for forum member*
20140603 23:14:48< shadowm> Since 1.12 and master diverged, yeah.
20140603 23:15:14< gfgtdf> shadowm: i think i didnt do anything with that files ince then
20140603 23:15:22< gfgtdf> shadowmwhy do you ask ?
20140603 23:15:26-!- haudegen__ [~quassel@178.115.128.144.wireless.dyn.drei.com] has joined #wesnoth-dev
20140603 23:16:38< shadowm> That's a good question.
20140603 23:19:58< shadowm> Somehow add-ons get multiple entries as they are reuploaded with the current master campaignd.
20140603 23:20:27-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-nefwlmgykqrgzikk] has quit [Write error: Broken pipe]
20140603 23:20:30-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140603 23:20:30-!- haudegen [~quassel@178.115.128.144.wireless.dyn.drei.com] has quit [Quit: No Ping reply in 180 seconds.]
20140603 23:20:56< iceiceice_> idk what code does that,
20140603 23:21:02< iceiceice_> if it was broken enough that it broke reloading save files,
20140603 23:21:06< iceiceice_> then the unit tests would not pass
20140603 23:21:11-!- Grickit is now known as Gambit
20140603 23:21:12< shadowm> That means something is horribly wrong with campaign_server.cpp:494.
20140603 23:21:14< iceiceice_> so most likely its like in src/serialization?
20140603 23:21:32< iceiceice_> so most likely its not in there i mean
20140603 23:21:32< shadowm> And the surrounding statements too.
20140603 23:21:42-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-fakvdxhslfxffwcu] has joined #wesnoth-dev
20140603 23:22:03< iceiceice_> hmm i wonder whats broken with this: https://github.com/cbeck88/wesnoth/commit/6dae73440cef8b2065bf8c878904a796a323c636
20140603 23:22:18< shadowm> Actually wtf is going on there.
20140603 23:22:29< shadowm> Seems like there's two different lowercasing methods in play there.
20140603 23:23:42< gfgtdf> iceiceice_: why shoudl that be broken ?
20140603 23:24:02< iceiceice_> gfgtdf: it fails assertions on all the unit tests
20140603 23:24:19< iceiceice_> something about scoped pointer
20140603 23:24:40-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has quit [Ping timeout: 252 seconds]
20140603 23:24:45< shadowm> Well, well, well.
20140603 23:25:14< shadowm> utf8::lowercase() doesn't return a lowercase version of its argument.
20140603 23:25:38< gfgtdf> iceiceice_: what does teh assertion eaxactly say ?
20140603 23:25:39< shadowm> AI0867: Who write this?
20140603 23:25:42< shadowm> wrote
20140603 23:27:51< shadowm> > name: After_the_Storm lowercase: After_the_Storm tested against: after_the_storm
20140603 23:27:52< iceiceice_> gfgtdf: running it locally
20140603 23:27:52< iceiceice_> actually i should be able to see on travis if my script works...
20140603 23:28:19< iceiceice_> every test says: wesnoth: /usr/include/boost/smart_ptr/scoped_ptr.hpp:91: T &boost::scoped_ptr<gamemap>::operator*() const [T = gamemap]: Assertion `px != 0' failed.
20140603 23:29:35< iceiceice_> im going to backtrace it
20140603 23:30:27< shadowm> This also affects 1.12, not good.
20140603 23:30:56< shadowm> On a goodness scale of 10 to -1000, this is minus infinity.
20140603 23:31:25-!- haudegen__ [~quassel@178.115.128.144.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140603 23:31:40< iceiceice_> hmm we should have some unit tests for the campaign server i guess
20140603 23:31:45< shadowm> It seems the official add-ons server doesn't have duplicate entries, perhaps I can use this info to bisect.
20140603 23:31:51< shadowm> This is not a campaignd-specific issue.
20140603 23:32:11< shadowm> Unless utf8::lowercase() depends on something else that campaignd doesn't have, of course.
20140603 23:32:31< iceiceice_> do you think its related to why the save game dialog is broken wheny ou type capital letters?
20140603 23:32:46< iceiceice_> although apparently that works in 1.12... so maybe its coincidence
20140603 23:32:58< shadowm> No, that's most likely something else.
20140603 23:33:06< shadowm> Lowercasing is needed for case-insensitive tests.
20140603 23:34:33< iceiceice_> hmm http://hastebin.com/edezakoruq.vala
20140603 23:34:37< iceiceice_> (not related to you shadowm)
20140603 23:36:10< gfgtdf> iceiceice_: well its seems like was also aug before its just tah teh new commtis adds teh asserion that detects it
20140603 23:36:12< iceiceice_> hmm oh i think i know what happend
20140603 23:36:20< shadowm> Okay, there's something weird going on here.
20140603 23:36:48< iceiceice_> gfgtdf: i think i have a bad copy constructor
20140603 23:36:48< shadowm> http://pastebin.com/88CpmW1t
20140603 23:36:58< iceiceice_> its swapping the pointers
20140603 23:37:04< iceiceice_> i think its getting the destroye pointer
20140603 23:37:07< iceiceice_> to the map
20140603 23:37:10< iceiceice_> *facepalm*
20140603 23:37:24< iceiceice_> idk i have to make sure but i have a strong supicion
20140603 23:37:37< gfgtdf> iceiceice_: was u copy contructor like map_(new gamemap(*(other.map_)))
20140603 23:38:40< shadowm> 1.12's utils::lowercase() uses tolower(), so...
20140603 23:38:50< iceiceice_> https://github.com/cbeck88/wesnoth/commit/6dae73440cef8b2065bf8c878904a796a323c636
20140603 23:39:06< iceiceice_> y my copy constructor is like that
20140603 23:39:14< iceiceice_> i think maybe my swap is not right?
20140603 23:39:17< iceiceice_> i thoguht that was correct 
20140603 23:39:22-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140603 23:40:57< shadowm> Isn't it frustrating when you are trying to implement something else and find a devastating bug in a low-level dependency? :p
20140603 23:41:22< shadowm> I guess I'll have to patch and check previous 1.11.x releases.
20140603 23:42:16< shadowm> Unless anyone thinks I'm using utils::lowercase() wrong in that paste.
20140603 23:42:19-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20140603 23:44:26< iceiceice_> shadowm: what.
20140603 23:44:38< iceiceice_> something bad has happened....
20140603 23:46:02< shadowm> It's pretty evident that the libc tolower() isn't the source of my problem, seeing as how campaignd successfully applies it on a string via the STL transform algo.
20140603 23:48:11< shadowm> 1.11.15 broken for me too.
20140603 23:48:52< iceiceice_> gfgtdf: when i dont use the pointer swaps it works...
20140603 23:49:14< gfgtdf> iceiceice_: what do you use instead ?
20140603 23:49:49< iceiceice_> http://hastebin.com/oyobujabog.avrasm
20140603 23:50:32< iceiceice_> doesnt make much sense to me though...
20140603 23:50:46< iceiceice_> maybe scoped pointer swap doesnt do what i think it does?
20140603 23:50:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140603 23:54:26< gfgtdf> iceiceice_: ise well those are 2 diferetn functions
20140603 23:54:50< shadowm> OK, I'm starting to get afraid something is horribly wrong with my system because my code is broken on 1.11.13 too.
20140603 23:54:51< gfgtdf> iceiceice_: once you pass a scoped_ptr to swap and ocde teh object it points to
20140603 23:54:59< iceiceice_> y
20140603 23:55:16< iceiceice_> i know, i mean the naive thing is to swap the values
20140603 23:55:26< gfgtdf> iceiceice_: i woudl have thought the teh defautl contructo contructs map_ with NULL so *map_ woudl be an error 
20140603 23:55:28< iceiceice_> but it should be ok to call swap on the pointers too i woudl think
20140603 23:55:42< iceiceice_> gfgtdf: i dont think i ever default construct a map_
20140603 23:55:49< iceiceice_> either scoped pointer or gamemap
20140603 23:55:53< iceiceice_> gamemap doesnt have a default constructor
20140603 23:56:08< gfgtdf> iceiceice_: ah ok
20140603 23:56:25< gfgtdf> iceiceice_:  idk why i thought that
20140603 23:56:33< iceiceice_> heres full impl's :
20140603 23:56:33< iceiceice_> http://hastebin.com/yagapatiqa.avrasm
20140603 23:57:28< iceiceice_> hmmm
20140603 23:59:40< iceiceice_> maybe it has to do with gamemap?
--- Log closed Wed Jun 04 00:00:36 2014