--- Log opened Thu Jun 05 00:00:09 2014
20140605 00:30:25-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140605 00:30:32-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 252 seconds]
20140605 00:30:40-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20140605 00:46:26-!- ancestral [~ancestral@17.114.45.98] has quit [Ping timeout: 255 seconds]
20140605 00:48:36-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140605 00:49:11-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has joined #wesnoth-dev
20140605 00:50:34-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140605 00:51:48-!- Kexoth [~kex@93-143-99-214.adsl.net.t-com.hr] has joined #wesnoth-dev
20140605 00:52:42-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has quit [Read error: Connection reset by peer]
20140605 00:53:44-!- trewe [~trewe@74.22.158.5.rev.vodafone.pt] has quit [Quit: quit]
20140605 00:54:33-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Ping timeout: 276 seconds]
20140605 00:54:53-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Ping timeout: 264 seconds]
20140605 00:55:08-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20140605 00:56:08-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev
20140605 01:04:42-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140605 01:06:39< iceiceice> gfgtdf: 
20140605 01:06:39< iceiceice> https://github.com/wesnoth/wesnoth/pull/191
20140605 01:07:06< iceiceice> i made a branch to try to slowly factor the end_turn_exceptions and end_level_exceptions out of play controller by incremental refactor
20140605 01:07:41< iceiceice> i made a "signal type" which can become the return type, and macros that you can wrap functions in that generate the exceptions, or propogate the return
20140605 01:07:42< iceiceice> values
20140605 01:08:03< iceiceice> i'm not sure exactly where it ends, i think maybe it ends with just replay code and game events code throwing?
20140605 01:08:33< iceiceice> at that point probably could get rid fo the macros but its a long way off
20140605 01:09:24< iceiceice> anyways i will be back later
20140605 01:09:28-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has quit [Quit: Leaving]
20140605 01:17:43< gfgtdf> iceiceice:  so is it your plan to remove the end_game exceptions completely out of the code or just to catch them earlier ? also is there a specaiyl reason you use do { .. } while(0) ?
20140605 01:25:46-!- Kexoth [~kex@93-143-99-214.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140605 01:29:55-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140605 01:31:59-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140605 01:51:02-!- iceiceice [~chris@pool-108-27-117-26.nycmny.east.verizon.net] has joined #wesnoth-dev
20140605 01:51:05< iceiceice> gfgtdf:
20140605 01:51:19< iceiceice> i think my plan for now is just to push the end_play_exceptions out of play_controller
20140605 01:51:27< iceiceice> maybe allow game_events::fire to throw
20140605 01:51:29< iceiceice> maybe replay can throw
20140605 01:51:40< iceiceice> im not really sure what allt he places that throw them are
20140605 01:51:55< gfgtdf> iceiceice: game event foir currenty doesnt thow
20140605 01:51:55< iceiceice> but i think if we pushed them out of play_controller it will create many refactor opportunities in play_controller perhaps
20140605 01:51:59< gfgtdf> fire*
20140605 01:52:04< iceiceice> i dont think thats true
20140605 01:52:06< iceiceice> when i was testing,
20140605 01:52:10< iceiceice> i forgot to put handle_...
20140605 01:52:14< iceiceice> on fire("start")
20140605 01:52:17< iceiceice> and it cuased unit tests to fail
20140605 01:52:23< iceiceice> and when i put it back they passed
20140605 01:52:42< gfgtdf> hm whcih was thrown end turn or end scenario ?
20140605 01:52:43< iceiceice> it caused the "test_return_fail" test to pass instead of failing
20140605 01:52:48< iceiceice> i think end scenario
20140605 01:52:51< iceiceice> *end_level
20140605 01:53:43< gfgtdf> iceiceice: hm you you know where ?
20140605 01:54:33< iceiceice> hmm actually
20140605 01:54:40< iceiceice> i think it was in fire_start(
20140605 01:54:43< iceiceice> in play_controller
20140605 01:54:48< iceiceice> not the game_events::fire("start")
20140605 01:55:57< iceiceice> i gues that throws because of check_end_level
20140605 01:56:24< iceiceice> hmm so you are sure that game_events::fire doesn't throw those?
20140605 01:56:41< iceiceice> i guess i could remove the wrappers and see what happens
20140605 01:58:35< gfgtdf> iceiceice: i think only check_end_level trows but not game_events::fire
20140605 01:58:56< iceiceice> what causes the WML to run?
20140605 01:59:03< iceiceice> does wml run right when game_events::fire is called?
20140605 01:59:05< gfgtdf> game_events:fire
20140605 01:59:08< gfgtdf> yes
20140605 01:59:12< iceiceice> hmm but [endlevel] doesnt throw?
20140605 01:59:19< gfgtdf> no it just sets a variable
20140605 01:59:24< iceiceice> right i think i remember this now
20140605 01:59:28< gfgtdf> that is checked in check_end_level
20140605 02:00:17< iceiceice> there are these hotkeys and menu events that throw htough
20140605 02:00:23< iceiceice> i dont really know where that happens from
20140605 02:00:26< iceiceice> is that in play_slice or smoething?
20140605 02:00:35< gfgtdf> ye play_slice does throw
20140605 02:03:05< iceiceice> hmm so wait does WML ever throw?
20140605 02:03:34< gfgtdf> current it can thwor network error for example
20140605 02:06:06< gfgtdf> iceiceice: and ofc all the deault stull like bad malloc or something
20140605 02:06:10< gfgtdf> default
20140605 02:06:30< iceiceice> yeah
20140605 02:08:43< iceiceice> y so idk i read soem more,
20140605 02:09:38< iceiceice> i think what you were saying about try { networking } catch (...) { }  in the destructor is actually not undefined behavior and safe according to the standard, at least based on what little reading i have done
20140605 02:10:01< iceiceice> as long as destructor is no thow
20140605 02:10:45< iceiceice> im not really sure though
20140605 02:11:36< shadowm> Long type names... yuck.
20140605 02:14:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140605 02:15:00< iceiceice> y the boost variant thing is kind of gross
20140605 02:15:06< iceiceice> it might be though that we can refactor and make it an enum
20140605 02:15:15< iceiceice> its not clear to me that end_level_exception needs to have level result as an arg,
20140605 02:15:24< iceiceice> if its only thrown by play_controller then it can just be a member variable insteda
20140605 02:15:57< iceiceice> also it might be that the "redo" variable can just be a constant, or like, current_player -1  or something
20140605 02:16:14< shadowm> No, I meant the possible_end_play_signal name. :p
20140605 02:17:08< shadowm> It's a typedef for a much longer name, but still.
20140605 02:17:42< iceiceice> idk i prefer to err on the side of clarity
20140605 02:17:47< iceiceice> whats a better name?
20140605 02:18:16< iceiceice> given that previous names were like "End_level_exception" i feel like im not doing much worse :p
20140605 02:19:34-!- Ivanovic_ [~ivanovic@frnk-d93338fa.pool.mediaways.net] has joined #wesnoth-dev
20140605 02:22:18-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 276 seconds]
20140605 02:23:12-!- Ivanovic_ [~ivanovic@frnk-d93338fa.pool.mediaways.net] has quit [Changing host]
20140605 02:23:12-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140605 02:23:43-!- Ivanovic_ is now known as Ivanovic
20140605 02:31:17-!- gfgtdf [~chatzilla@d149024.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140605 02:32:35-!- irker601 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140605 02:32:35< irker601> wesnoth: Ignacio R. Morelle wesnoth:master 33503f2f57b7 / src/campaign_server/campaign_server.cpp: campaignd: Use utf8::lowercase() instead of a direct call to libc tolower() http://git.io/8vkpWQ
20140605 02:35:42< irker601> wesnoth: Ignacio R. Morelle wesnoth:master 7435f341c4bc / src/campaign_server/campaign_server.cpp: campaignd: Remove dead code http://git.io/8UA4kg
20140605 02:49:04< shadowm> AI0867: Forgot to mark the bug as fixed? http://forums.wesnoth.org/viewtopic.php?p=571263#p571263
20140605 02:57:47< shadowm> Eh.
20140605 02:58:12< shadowm> :cl to another scenario in master results in the "The End" screen.
20140605 03:14:12-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has joined #wesnoth-dev
20140605 03:15:52-!- iceiceice [~chris@pool-108-27-117-26.nycmny.east.verizon.net] has quit [Ping timeout: 240 seconds]
20140605 03:19:29-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has quit [Ping timeout: 264 seconds]
20140605 03:24:43-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140605 03:26:20-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140605 03:26:25< iceiceice> shadowm: 1.12 also/
20140605 03:26:26< iceiceice> ?
20140605 03:34:36< shadowm> Nope.
20140605 03:37:01< shadowm> I wonder, would people mind if the gamestate inspector dialog was always as large as the Wesnoth window?
20140605 03:37:48< shadowm> I honestly find the constant layout recalculation irritating.
20140605 03:38:33< vultraz> No
20140605 03:38:36< vultraz> I would like it
20140605 03:38:46< vultraz> I find the constant resize irritating
20140605 03:39:12< shadowm> Do I hear an echo? :)
20140605 03:51:27< mattsc> I don’t really mind one way or the other.  If it were faster if it doesn’t have to resize, that’d be a plus (but not essential, it’s good enough).
20140605 03:51:32< iceiceice> i would like it either way as long as it doesnt fail assertions
20140605 03:54:06< iceiceice> it woudl also be ncie if it could inspect lua
20140605 03:56:08< iceiceice> i wonder why we cannot just like, 
20140605 03:56:08< iceiceice> have a command that fires up a lua interpreter bar?
20140605 03:56:08< iceiceice> that would be extremely handy
20140605 03:56:08< iceiceice> typing :lua constantly is fairly annoying
20140605 03:57:06< vultraz> Proxy command for :lua?
20140605 03:57:13< vultraz> Should be simple
20140605 04:00:20< iceiceice> maybe idk
20140605 04:00:22< iceiceice> i havent really thought aobut it
20140605 04:01:55< vultraz> I was going to suggest a multiline console before I remembered we don't have multiline textboxes
20140605 04:03:09< vultraz> I wonder how much effort it would take to implement those 
20140605 04:03:11< vultraz> Hm
20140605 04:03:45< iceiceice> vultraz: it would be pretty great
20140605 04:03:53< iceiceice> also if we could make them copy pasteable
20140605 04:04:05< vultraz> yess
20140605 04:04:29< iceiceice> we already have some clipboard functionality i guess
20140605 04:04:43< iceiceice> in the new add-on server windows 
20140605 04:04:57< iceiceice> idk how much harder it is to put it in other things
20140605 04:05:16< shadowm> Trivial.
20140605 04:05:28< iceiceice> oh awesome
20140605 04:05:33< iceiceice> we have a "copy to clipboard" function
20140605 04:05:40< shadowm> The hard part is making multiline textboxes that can be interacted with.
20140605 04:06:05< shadowm> The only existing precedent is the GUI1 textbox and it's horribly broken and crap.
20140605 04:09:48< vultraz> We can interact with the singleline box
20140605 04:09:53< vultraz> why is multiline so much harder
20140605 04:10:12< shadowm> I don't know, you could have a try.
20140605 04:10:32< vultraz> Me??
20140605 04:10:43< shadowm> Yes, since you appear to handle information I don't.
20140605 04:10:48< vultraz> How am I in any way qualified to make code
20140605 04:10:53< shadowm> Or at least logic I don't.
20140605 04:11:27< shadowm> (I tried fixing the GUI1 multiline textbox once, so I'm not speculating here.)
20140605 04:17:38-!- Guest56390 [~cib@p5DD22CEE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140605 04:21:17< shadowm> I'm afraid what I'm doing here might interfere with the :inspect assert.
20140605 04:23:04< shadowm> I guess I'll hold it back until #22095 is fixed.
20140605 04:33:47-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140605 04:40:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 260 seconds]
20140605 04:43:06-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140605 04:51:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 260 seconds]
20140605 04:53:18-!- Sulfur [~Miranda@p5B327E57.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140605 04:53:29-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140605 05:01:58-!- WinterD [~quassel@177.196.200.77.rev.sfr.net] has joined #wesnoth-dev
20140605 05:03:14-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has joined #wesnoth-dev
20140605 05:07:23-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 245 seconds]
20140605 05:07:38-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140605 05:51:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140605 06:06:57-!- c74d is now known as Guest24164
20140605 06:07:03-!- Guest24164 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 252 seconds]
20140605 06:09:35-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140605 06:35:38-!- Guest56390 [~cib@p5DD22CEE.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140605 06:36:48-!- Trademar_ [~trademark@mac-nomade-68.ircam.fr] has joined #wesnoth-dev
20140605 06:40:05-!- mjs-de [~mjs-de@f049171049.adsl.alicedsl.de] has joined #wesnoth-dev
20140605 06:52:02-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has joined #wesnoth-dev
20140605 06:55:09-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140605 06:56:47-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has quit [Ping timeout: 255 seconds]
20140605 07:01:41-!- groggy [~chatzilla@68.118.24.170] has joined #wesnoth-dev
20140605 07:08:16< groggy> Necrosporus: from last week, .git and other dot-files don't need to be added to server.ign: https://github.com/wesnoth/wesnoth/blob/master/src/addon/manager.cpp#L226
20140605 07:10:47-!- groggy [~chatzilla@68.118.24.170] has quit [Remote host closed the connection]
20140605 07:21:16-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140605 07:26:41-!- cib_ [~cib@132.231.178.204] has joined #wesnoth-dev
20140605 07:38:11-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 255 seconds]
20140605 07:40:08-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140605 07:48:32-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140605 07:49:54-!- cib_ [~cib@132.231.178.204] has quit [Ping timeout: 276 seconds]
20140605 07:57:22-!- Haudegen_ [~quassel@178.115.131.209.wireless.dyn.drei.com] has joined #wesnoth-dev
20140605 07:58:33-!- Haudegen_ is now known as Haudegen
20140605 08:11:20-!- cib_ [~cib@132.231.178.97] has joined #wesnoth-dev
20140605 08:15:38-!- cib_ [~cib@132.231.178.97] has quit [Ping timeout: 240 seconds]
20140605 08:17:51-!- cib_ [~cib@132.231.178.160] has joined #wesnoth-dev
20140605 08:24:34-!- cib_ [~cib@132.231.178.160] has quit [Read error: Connection reset by peer]
20140605 08:40:03-!- cib_ [~cib@132.231.178.161] has joined #wesnoth-dev
20140605 08:40:57-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has joined #wesnoth-dev
20140605 08:45:14-!- kex [~kex@93-143-99-214.adsl.net.t-com.hr] has quit [Ping timeout: 255 seconds]
20140605 08:59:50-!- sachith500 [~kvirc@112.134.164.3] has joined #wesnoth-dev
20140605 09:03:18-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20140605 09:07:00-!- markus_ [~mjs-de@f049107007.adsl.alicedsl.de] has joined #wesnoth-dev
20140605 09:10:20-!- mjs-de [~mjs-de@f049171049.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds]
20140605 09:15:10-!- Haudegen [~quassel@178.115.131.209.wireless.dyn.drei.com] has quit [Read error: Connection reset by peer]
20140605 09:15:39-!- Haudegen_ [~quassel@178.115.131.209.wireless.dyn.drei.com] has joined #wesnoth-dev
20140605 09:16:22-!- Sulfur [~Miranda@p5B327E57.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140605 09:16:49-!- Haudegen_ is now known as Haudegen
20140605 09:28:35-!- Haudegen [~quassel@178.115.131.209.wireless.dyn.drei.com] has quit [Ping timeout: 260 seconds]
20140605 09:34:24< irker601> wesnoth: ln-zookeeper wesnoth:1.12 8cee267b5af0 / data/campaigns/Son_Of_The_Black_Eye/scenarios/14_Back_Home.cfg: Return Grüü's gold to Kapou'e only if positive http://git.io/mHyA5Q
20140605 09:36:57-!- markus_ is now known as mjs-de
20140605 09:37:06< irker601> wesnoth: ln-zookeeper wesnoth:master 3229949ef1db / data/campaigns/Son_Of_The_Black_Eye/scenarios/14_Back_Home.cfg: Return Grüü's gold to Kapou'e only if positive http://git.io/eVzQsA
20140605 09:38:18-!- sachith500 [~kvirc@112.134.164.3] has quit [Read error: Connection reset by peer]
20140605 09:38:34-!- sachith500 [~kvirc@112.134.164.3] has joined #wesnoth-dev
20140605 09:40:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140605 09:44:24-!- sachith500 [~kvirc@112.134.164.3] has quit [Read error: Connection reset by peer]
20140605 09:45:13-!- sachith500 [~kvirc@112.134.164.3] has joined #wesnoth-dev
20140605 09:55:07-!- cib_ [~cib@132.231.178.161] has quit [Ping timeout: 252 seconds]
20140605 10:04:19< AI0867> iceiceice: http://bin-login.name/ftp/pub/docs/programming_languages/cpp/cffective_cpp/MEC/MI11_FR.HTM
20140605 10:06:36< AI0867> gfgtdf: the utf8 stuff in savegame.cpp is for converting our utf8 into the current ansi encoding (lossily), so we can pass it to the win32 API's implementation of std::fstream
20140605 10:09:52< AI0867> 18:19 < iceiceice> and the object is not actually deallocated ← I believe it *is* deallocated, but RAII may fail to function, as the destructor of a contained scoped pointer or the like may not be run
20140605 10:09:59-!- Sulfur [~Miranda@p5B327E57.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140605 10:11:02< iceiceice> AI0867: i read some more since yesterday,
20140605 10:11:34< vultraz> !log b58d40d9fb8e9942591604b02b26f15343899f9b
20140605 10:11:35< shikadibot> vultraz: Revision b58d40d9fb8e (Boldizsár Lipka) on Wed Feb 26 15:52:01 2014:
20140605 10:11:38< shikadibot> vultraz: Remove an unnecessary include.
20140605 10:11:41< shikadibot> vultraz: Web interface URL: https://github.com/wesnoth/wesnoth/commit/b58d40d9fb8e
20140605 10:12:05< iceiceice> i guess that X::~X() {  try { networking } catch(...) {} } is well defined, 
20140605 10:12:23< iceiceice> and there are libraries that do this "close database connection in destructor" thing, which may throw
20140605 10:13:05< iceiceice> i think that its not necessary for us to do this though.
20140605 10:13:48< iceiceice> afaict the main reason why we would want to use RAII to do networking transactions is,
20140605 10:14:01< iceiceice> all the code that handles turns ending etc. in play controller is based on using exceptions for flow control
20140605 10:14:15< iceiceice> which makes it extremely difficult to figure out what will happen next / guarantee that networking transactions happen
20140605 10:14:24< vultraz> Ok really, this has been sitting here forever: http://wiki.wesnoth.org/SpellingMistakes#Two_Brothers
20140605 10:14:28< vultraz> what is zookeeper's opinion
20140605 10:14:40< iceiceice> i think the right thing thouhg is, 
20140605 10:14:47< iceiceice> do not use exceptions for flow control in play controller.
20140605 10:15:06< iceiceice> then we would be able to write these functions normally,
20140605 10:15:17< iceiceice> and not have to look up obscure rules about exceptions in destructors
20140605 10:15:53< iceiceice> in my experience, in "normal" coding you almost never need to write an explicit destructor at all
20140605 10:16:08< iceiceice> iiuc the entire reason destructors were introduced to C++ was so that you could provide exception safety for classes that contain a pointer
20140605 10:16:17< iceiceice> but in modern C++ you can just use a smart pointer
20140605 10:16:35< iceiceice> so really the only times oyu really need ot write a destructor are like,
20140605 10:16:48< iceiceice> (1) i'm managing a resource from a C-library like a socket or something, and i need to close it
20140605 10:16:54< AI0867> shadowm: you mean the utf8, utf16 and ucs4 namespaces?
20140605 10:17:03< iceiceice> (2) i must write virtual X::~X() in my base class
20140605 10:17:37< iceiceice> other than those cases imo i would try very hard to avoid writing a destructor
20140605 10:18:14< iceiceice> not that its bad,
20140605 10:18:18< iceiceice> but i think throwing from a destructor is always bad
20140605 10:18:28< iceiceice> apparenlty in C++11 that will immediately cause your program to crash,
20140605 10:18:32< iceiceice> regardless of stack unwinding etc.
20140605 10:18:48< iceiceice> unless you specifically declare an object to be permitted to throw from destructors
20140605 10:20:05-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140605 10:20:39< iceiceice> so idk what the right thing is,
20140605 10:20:59< iceiceice> it sounds like if we move to C++11 then even error logging in a destructor could cause a crash?
20140605 10:21:18< iceiceice> for instance suppose that at some point, somewhere, there is a utf8 bug somewhere in the future
20140605 10:21:32< iceiceice> and someone writes a corrupted string to a logger or something
20140605 10:21:35< iceiceice> generating an exception
20140605 10:21:54< iceiceice> then, somewhere along the line as the play_controller stack is unwound (destroying nearly every object allocated in a game)
20140605 10:21:56< iceiceice> ,
20140605 10:22:06< iceiceice> someone has X::~X() { do some logging }
20140605 10:22:18< iceiceice> if the logger is corrupted and generates another exception
20140605 10:22:23< iceiceice> wesnoth will immediately crash
20140605 10:22:49< iceiceice> gfgtdf and i wrote these "smart enums" that do some conversion checking and generate tWML gui popup exceptions
20140605 10:22:56< iceiceice> what that means is,
20140605 10:23:04< iceiceice> std::cerr << enum << std::endl;
20140605 10:23:10< iceiceice> can throw this fancy exception
20140605 10:23:19< iceiceice> that is supposed to propogate to play_controller and be displayed as a gui to the user
20140605 10:23:26< iceiceice> if during that unwinding process,
20140605 10:23:45< iceiceice> someone somewhere wrote "X::~X() { output all values of resources::controller->current_team() }"
20140605 10:23:53< iceiceice> and a corrupted enum is displayed again,
20140605 10:23:58< iceiceice> it throws another exception,
20140605 10:24:01< iceiceice> crsahing to desktop immediately
20140605 10:24:50< iceiceice> so i'm not sure what we can do, it might be that you cannot do anything nontrivial in a destructor without putting try { } catch(...) {} to catch all possible exceptions
20140605 10:29:17< iceiceice> AI0867: i also started a branch to try to push some of these exceptions out of play_controller,
20140605 10:29:29< iceiceice> at least the ones that we are using for flow control
20140605 10:29:34< iceiceice> https://github.com/wesnoth/wesnoth/pull/191
20140605 10:29:44< zookeeper> vultraz, what the heck does "<X> V" even mean?
20140605 10:29:56< zookeeper> 12 V? 19 V? what?
20140605 10:30:04< vultraz> 12th day, 5th month I think
20140605 10:30:24< vultraz> That's how I read it
20140605 10:30:33< vultraz> Who originally wrote the campaign?
20140605 10:30:50< zookeeper> yes, seems like a mistake
20140605 10:30:55< zookeeper> what does that matter?
20140605 10:31:07< zookeeper> those are probably esr's work
20140605 10:31:17< vultraz> Heh
20140605 10:31:33< vultraz> Guess I'll make it V just to get it off the wiki
20140605 10:32:55< zookeeper> i wouldn't break the string in 1.12 just for that though, i'd ping Ivanovic and see if pofix could save at least some translations from fuzzying
20140605 10:33:58< zookeeper> i find those diagonal [edit] lines pretty fun though
20140605 10:36:44< vultraz> Yeah, that's a wiki bug
20140605 10:36:55< vultraz> I'll just do master for now
20140605 10:38:16< vultraz> Unless it was meant to be a text entry from the previous month...hm 
20140605 10:40:37-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has joined #wesnoth-dev
20140605 10:44:45< AI0867> 00:34 < gfgtdf> AI0867: from how i read the code in savegame.cpp ,  the function infilesystem.cpp (ostream_file) expcet a local encoding (latin 1 on windows) while the gui  code uses utf-8 ? Woudlnt it be better if the function in filesystem would do the utf8 <-> windows converting instead of the functions that use it ? ← yes. But that code predates me by quite a bit
20140605 10:47:17< zookeeper> vultraz, can't be, then it'd be dated earlier than the first scenario's
20140605 10:47:20< AI0867> 01:19 < gfgtdf> AI0867: meaning can i pass a &a[0] to a winapi function ? ← utf16::string is a std::vector<Uint16>, so you need to push_back a 0 first
20140605 10:47:25< zookeeper> ...and it speaks of mordak's death
20140605 10:47:30< vultraz> Ah
20140605 10:47:35< vultraz> Ok
20140605 10:48:47< AI0867> gfgtdf: there's also some code in windows_tray_notification.cpp that makes a std::wstring
20140605 10:49:05< AI0867> (actually, utf16::string is a std::vector<wchar_t>, but on windows, that's the same thing)
20140605 10:52:30< AI0867> 04:49 < shadowm> AI0867: Forgot to mark the bug as fixed? http://forums.wesnoth.org/viewtopic.php?p=571263#p571263 ← no. Nobody told me that they had filed a bug. I was unaware any report existed beyond a few forum posts.
20140605 10:53:29-!- Spoffy [~chatzilla@152.78.175.8] has joined #wesnoth-dev
20140605 10:55:21-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 247 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140605 10:56:31< irker601> wesnoth: Charles Dang wesnoth:master 74bbe0f76dc3 / data/campaigns/Two_Brothers/scenarios/03_Guarded_Castle.cfg: AToTB S3: fixed story date inconsistency http://git.io/eNdjLw
20140605 11:02:09< irker601> wesnoth: Charles Dang wesnoth:master 2af8c75e92d2 / data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg: TSG S3: "foul undead" -> "foul creatures", since there are no undead on EASY http://git.io/yQUb4g
20140605 11:06:22< vultraz> ok, that's everything in Spelling Mistakes
20140605 11:09:09-!- kex [~kex@212.92.210.53] has joined #wesnoth-dev
20140605 11:14:06 * vultraz gets back to improving the wiki
20140605 11:44:24-!- travis-ci [~travis-ci@ec2-107-20-115-116.compute-1.amazonaws.com] has joined #wesnoth-dev
20140605 11:44:24< travis-ci> [travis-ci] wesnoth/wesnoth#2961 (master - 74bbe0f : Charles Dang): The build was broken.
20140605 11:44:24< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/26842820
20140605 11:44:24-!- travis-ci [~travis-ci@ec2-107-20-115-116.compute-1.amazonaws.com] has left #wesnoth-dev []
20140605 11:51:51< AI0867> https://travis-ci.org/wesnoth/wesnoth/jobs/26842821 ← this one seems to have been killed as it was returning success
20140605 11:52:08< AI0867> iceiceice: what is the "throw 42" about? Should that exception never end up there or?
20140605 11:58:55-!- Spoffy_ [~chatzilla@152.78.175.8] has joined #wesnoth-dev
20140605 11:59:27-!- Haudegen_ [~quassel@213162068031.public.t-mobile.at] has joined #wesnoth-dev
20140605 12:00:31-!- Spoffy [~chatzilla@152.78.175.8] has quit [Ping timeout: 252 seconds]
20140605 12:00:35-!- Spoffy_ is now known as Spoffy
20140605 12:02:02-!- gfgtdf [~chatzilla@d149024.adsl.hansenet.de] has joined #wesnoth-dev
20140605 12:12:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140605 12:14:24< gfgtdf> fabi: about 21983 i think "not being able to not use default hotkeys" and "default hotkeys in the preferences file overlapping each other and thus havng no effect" are 2 different bugs. And to me it seems like the second only requires reoving some effectless entries in the default hotkeys preferences file. For which is see no reason not to do so in 1.12
20140605 12:14:48< gfgtdf> s/reoving/removing
20140605 12:24:20-!- cib [~cib@132.231.178.13] has joined #wesnoth-dev
20140605 12:24:45-!- cib is now known as Guest24695
20140605 12:27:39-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 252 seconds]
20140605 12:38:39-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Quit: No Ping reply in 180 seconds.]
20140605 12:39:04-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev
20140605 12:40:21< vultraz> fabi: "classic theme"?
20140605 12:42:27-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140605 12:44:16-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140605 12:46:05-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Remote host closed the connection]
20140605 12:48:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140605 12:49:59-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20140605 12:53:41-!- Haudegen_ [~quassel@213162068031.public.t-mobile.at] has quit [Ping timeout: 252 seconds]
20140605 13:07:48-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140605 13:11:02< fabi> gfgtdf: Yes, right. I thought so as well and fixed the overlapping default at my local repo already.
20140605 13:11:23< fabi> vultraz: yes?
20140605 13:15:09< vultraz> what does it do?
20140605 13:15:16< vultraz> I don't have a master build
20140605 13:21:37-!- sachith500|2 [~kvirc@112.134.245.197] has joined #wesnoth-dev
20140605 13:21:59-!- higgins [~higgins@192.241.198.49] has quit [Quit: ERC Version 5.3 (IRC client for Emacs)]
20140605 13:24:41-!- higgins [~higgins@192.241.198.49] has joined #wesnoth-dev
20140605 13:24:43-!- sachith500 [~kvirc@112.134.164.3] has quit [Ping timeout: 260 seconds]
20140605 13:25:18< iceiceice> AI0867: throw 42 will just terminate the program anyways?
20140605 13:25:58-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Remote host closed the connection]
20140605 13:26:16< iceiceice> as i understand we do that because assert(false) might not kill the program if the user attaches a debugger, so the compiler will do different things
20140605 13:26:35< iceiceice> looking now, i guess we could just call 'std::terminate' directly instead of throw 42?
20140605 13:28:59-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev
20140605 13:33:01< AI0867> iceiceice: I meant an explanation of why control should never reach that point, not an explanation of the considerations in using "throw 42" to terminate the program
20140605 13:34:35< fabi> vultraz: It is the theme you know from earlier wesnoth versions.
20140605 13:36:48< gfgtdf> iceiceice: no assert is always better
20140605 13:37:31< iceiceice> maybe i missed some context
20140605 13:37:52< gfgtdf> iceiceice: an throw/terminate doesnt give an erro rmessage unliek assert
20140605 13:38:11< gfgtdf> iceiceice: also when people ignore an assert then they have been warned and usualy expect undefined behaviur
20140605 13:38:38-!- Guest24695 [~cib@132.231.178.13] has quit [Ping timeout: 255 seconds]
20140605 13:38:39< iceiceice> hmm ok
20140605 13:38:43< lipkab> Wesnoth loadscreen with hardware-accelerated red background: https://www.dropbox.com/s/dkgd6l4qmy4vz4h/wensoth_loadscreen.png
20140605 13:39:25< iceiceice> gfgtdf: i think the point of throw 42 though is that the compiler can know that control will not proceed
20140605 13:39:54< iceiceice> idk you think that is not worthwhile and we should assert there instead?
20140605 13:40:33< gfgtdf> iceiceice: "marking a situation that should never be able to be reached and implied an error in the programm if it happens" is the normal use of assert
20140605 13:40:43< vultraz> fabi: black backgrounds, ugly button images?
20140605 13:40:50< zookeeper> lipkab, awesome, i bet you get 120fps on that red
20140605 13:40:56< zookeeper> so pretty
20140605 13:40:57< vultraz> or new images, old layout
20140605 13:41:12< iceiceice> gfgtdf: but it turns out that VC will complain if like, you do not return a value after assert(false)
20140605 13:41:19< iceiceice> where as clang and gcc don't do that
20140605 13:41:30< gfgtdf> iceiceice: yes then you can still thwor after that
20140605 13:41:30< fabi> vultraz: old layout, old images
20140605 13:41:33< iceiceice> so we have been using throw 42; where we want them all to compile
20140605 13:42:07< iceiceice> what do you think is better? assert(false) for error message, then std::terminate?
20140605 13:42:08< vultraz> fabi: ??? why!
20140605 13:42:55< fabi> vultraz: Some people including Turuk requested the old gui to be available.
20140605 13:43:23< gfgtdf> iceiceice: i personly like assert(false && "erro mssage") most, and if it gives a compile error then ad throw ... after it
20140605 13:43:31< fabi> vultraz: What is wrong with it? It served as gui for several years... 
20140605 13:43:41< vultraz> fabi: Options Are Bad
20140605 13:43:45< iceiceice> gfgtdf: ok
20140605 13:43:51< Turuk> fabi: VIB
20140605 13:43:58< Turuk> Vultraz Is Bad
20140605 13:44:02< fabi> rofl
20140605 13:44:07< vultraz> lmfao
20140605 13:44:29< iceiceice> AI0867: if you are asking me why i put throw 42 in the make_enum header,
20140605 13:44:53< iceiceice> its because i saw other error loggers handle it that way
20140605 13:45:01< Turuk> fabi: do you have an image of the new against the old?
20140605 13:45:01< iceiceice> in wml_exception.?pp
20140605 13:46:12< iceiceice> i have to say though, i think i like std::terminate better than throw 42
20140605 13:46:41< fabi> Turuk: Sorry not yet. I could produce one in no time but uploading is a pain. My internet is very slow right now.
20140605 13:47:11< iceiceice> im not even actually sure why throw 42 is figured out at compile time?
20140605 13:47:32< iceiceice> hmm i guess its thrown on but you have to look at all compilation units to realize that it results in termination?
20140605 13:47:46< Turuk> fabi: No worries, I know how that goes.  If you ever do have one though, let me know, I'd love to see the progress comparison
20140605 13:49:02< iceiceice> i guess throw 42 will result in all destructors being called also. (?) 
20140605 13:49:09< iceiceice> so in that way it is different from std::terminate?
20140605 13:51:14< gfgtdf> iceiceice: well std::terminate is just a function while throw is a language feature.
20140605 13:51:19< fabi> vultraz:  2 themes were removed, and I plan to remove some more. That reduces the maintain costs of the themes to default, classic and pandora for 1.12. Maintaining themes is not such of a burden, but we can remove the classic one once every UMC runs fine with the new one.
20140605 13:52:43-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140605 13:52:49-!- rikster [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140605 13:53:50-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 265 seconds]
20140605 13:58:10-!- Necrosporus_ is now known as Necrosporus
20140605 13:58:37< Necrosporus> fabi, I have tried all the themes with 1.11 and only default was working fine
20140605 13:58:55< vultraz> fabi: I see
20140605 13:59:41-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Quit: riksteri]
20140605 14:00:56< fabi> Necrosporus: What is wrong with "classic"?
20140605 14:01:10< Necrosporus> I can't remember
20140605 14:01:52< Necrosporus> fabi, it's just not present in my installation
20140605 14:02:00< Necrosporus> At least not in theme menu
20140605 14:02:13-!- irker601 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140605 14:02:48< fabi> Necrosporus: Ah yes. It is not backported to the 1.12 branch yet.
20140605 14:03:17< fabi> Necrosporus: New strings. It will reach 1.12.1.
20140605 14:04:38-!- rikster [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Quit: rikster]
20140605 14:04:46-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140605 14:07:09< iceiceice> gfgtdf: std::terminate is the function that "throw 42" is defined to call iiuc
20140605 14:07:25< Necrosporus> pandora worked better but I guess, it is not mean to work with bigger resolution
20140605 14:07:27< iceiceice> but it still might be better to throw 42 i guess...
20140605 14:07:50< iceiceice> because if someone has a socket object held by some class, it will be released by destructor before we exit, etc.
20140605 14:07:50< iceiceice> so idk
20140605 14:12:00-!- gfgtdf [~chatzilla@d149024.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140605 14:14:29< fabi> Necrosporus: Indeed it is hardcoded to the pandora's 800x480 for now.
20140605 14:18:46-!- Spoffy_ [~chatzilla@82.199.155.15] has joined #wesnoth-dev
20140605 14:20:35-!- Spoffy [~chatzilla@152.78.175.8] has quit [Ping timeout: 252 seconds]
20140605 14:20:40-!- Spoffy_ is now known as Spoffy
20140605 14:21:58-!- Haudegen_ [~quassel@213162068031.public.t-mobile.at] has joined #wesnoth-dev
20140605 14:30:17-!- Haudegen_ [~quassel@213162068031.public.t-mobile.at] has quit [Ping timeout: 264 seconds]
20140605 14:34:34< AI0867> iceiceice: well, I'd add an assert saying why that should never be reached ( assert(false && "whatever") )
20140605 14:34:35-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140605 14:34:51< AI0867> iceiceice: also, the throw statement makes the following break; quite unnecessary
20140605 14:35:10< iceiceice> AI0867: which code are you talking about?
20140605 14:35:12< iceiceice> in the enums?
20140605 14:35:58< AI0867> https://github.com/wesnoth/wesnoth/pull/191/files#diff-3d346939d33b7b49455cc83393ab6f89R476 ← this one
20140605 14:35:59-!- sachith500|2 [~kvirc@112.134.245.197] has quit [Read error: Connection reset by peer]
20140605 14:36:17-!- sachith500|2 [~kvirc@112.134.245.197] has joined #wesnoth-dev
20140605 14:41:06-!- cib [~cib@p5DD22CEE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140605 14:41:26-!- sachith500|2 [~kvirc@112.134.245.197] has quit [Read error: Connection reset by peer]
20140605 14:41:30-!- cib is now known as Guest46905
20140605 14:43:48-!- irker179 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140605 14:43:48< irker179> wesnoth: fendrin wesnoth:1.12 58fcb36947f1 / data/core/hotkeys.cfg: Resolved overlapping hotkey definitions. http://git.io/VEGE4Q
20140605 14:46:07< irker179> wesnoth: fendrin wesnoth:1.12 8d754e9ee3b3 / data/themes/ (unit_box.cfg widescreen.cfg): Delete non working themes from the 1.12 branch. http://git.io/Ykzy0Q
20140605 14:47:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140605 14:48:23-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 255 seconds]
20140605 14:49:09< iceiceice> AI0867: i see
20140605 14:49:11< iceiceice> yeah i shoudl fix that up
20140605 14:52:25< irker179> wesnoth: fendrin wesnoth:1.12 451b98bd9fb2 / src/hotkey/hotkey_command.cpp: Fix for bug #21717: "F5->reload" doesn't work in editor http://git.io/S1mHNA
20140605 14:54:26-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140605 14:54:44-!- _8680_ [~8680@2002:4404:712c:0:2c1d:25f1:32d6:d2ba] has quit [Ping timeout: 260 seconds]
20140605 14:55:23-!- _8680_ [~8680@2002:4404:712c:0:a983:f011:ebcd:acb5] has joined #wesnoth-dev
20140605 15:03:12< irker179> wesnoth: fendrin wesnoth:1.12 706cb6d714e6 / src/minimap.cpp: Made the classic minimap satellite view the default. http://git.io/DUA1-g
20140605 15:07:15-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140605 15:08:13-!- _8680_ [~8680@2002:4404:712c:0:a983:f011:ebcd:acb5] has quit [Ping timeout: 245 seconds]
20140605 15:08:50-!- Trademar_ [~trademark@mac-nomade-68.ircam.fr] has quit []
20140605 15:09:16-!- _8680_ [~8680@2002:4404:712c:0:50c3:ebe8:d724:9100] has joined #wesnoth-dev
20140605 15:10:36-!- Spoffy [~chatzilla@82.199.155.15] has quit [Ping timeout: 260 seconds]
20140605 15:19:47< irker179> wesnoth: fendrin wesnoth:1.12 22c00294f214 / src/ (display.cpp minimap.cpp): Made the classic minimap color coding the default. http://git.io/gsiAwg
20140605 15:21:06-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140605 15:30:25< irker179> wesnoth: fendrin wesnoth:1.12 45fe23d948d4 / data/campaigns/Liberty/scenarios/ (5 files): Liberty: Put the DEFAULT_SCHEDULE_* macros in use. http://git.io/4FNA4A
20140605 15:31:48-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Read error: Connection reset by peer]
20140605 15:33:50-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140605 15:35:45-!- Sulfur [~Miranda@p5B327E57.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140605 15:42:50< fabi> zookeeper: The unusual time schedule in DiD 04c is intentional? I wonder because on a first glance it is not mentioned in the story text.
20140605 15:44:26< zookeeper> 04c?
20140605 15:45:15< fabi> Mal_Ravanals_Capital
20140605 15:45:21< zookeeper> that's not DiD
20140605 15:45:29< fabi> oh yes
20140605 15:45:35< fabi> it is eastern invasion
20140605 15:45:41< fabi> That is yours as well?
20140605 15:45:46< zookeeper> yes
20140605 15:45:52< zookeeper> well i'm sure it's intentional
20140605 15:46:28-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20140605 15:46:48< fabi> zookeeper: Okay, I have put the modified DEFAULT_SCHEDULE_* macros in use. That makes a consistent time schedule in every mainline campaign.
20140605 15:48:02< zookeeper> so it seems
20140605 15:51:50< fabi> zookeeper: It is a UI issue. Not only a clean code thing.
20140605 15:52:41< zookeeper> oh right, current_time
20140605 15:53:07-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140605 15:53:36< fabi> Yes
20140605 16:01:50< irker179> wesnoth: fendrin wesnoth:1.12 8e9db71b3ddb / data/campaigns/ (8 files in 3 dirs): EI, TSG, TB: Put DEFAULT_SCHEDULE_* macros in use. http://git.io/lJmydQ
20140605 16:02:51-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW]
20140605 16:08:38-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has quit [Ping timeout: 245 seconds]
20140605 16:13:42-!- kex [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140605 16:17:32-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140605 16:17:42< mattsc> new york style drummer
20140605 16:17:53< mattsc> uh?
20140605 16:23:48-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds]
20140605 16:49:46-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140605 17:07:31-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has joined #wesnoth-dev
20140605 17:14:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140605 17:23:20-!- Haudegen_ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140605 17:26:41-!- Haudegen_ is now known as Haudegen
20140605 17:27:50-!- timotei_ is now known as timotei
20140605 17:31:36-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140605 17:43:23-!- Haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Ping timeout: 240 seconds]
20140605 17:45:26-!- Haudegen_ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140605 17:56:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140605 17:58:02-!- Haudegen_ is now known as Haudegen
20140605 18:05:53-!- Guest46905 [~cib@p5DD22CEE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140605 18:07:40-!- cib_ [~cib@p5DD22CEE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140605 18:09:38-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140605 18:12:04-!- ygtsjt [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140605 18:13:20-!- {V} [~V@72-69-ftth.on.nl] has quit [Disconnected by services]
20140605 18:13:28-!- ygtsjt is now known as {V}
20140605 18:22:06-!- gfgtdf [~chatzilla@d149024.adsl.hansenet.de] has joined #wesnoth-dev
20140605 18:41:29-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has joined #wesnoth-dev
20140605 18:43:52< gfgtdf> wesbot: seen RiftWalker
20140605 18:43:52< wesbot> gfgtdf: The person with the nick RiftWalker last spoke 5d 20h ago.  5d ago they left with the message: Read error: Connection reset by peer
20140605 18:45:45-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140605 18:50:18-!- cib_ [~cib@p5DD22CEE.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20140605 19:00:34< happygrue> wesbot: seen Aishiko_laptop
20140605 19:00:34< wesbot> happygrue: The person with the nick Aishiko_laptop last spoke 36d 19h ago.  22d 18h ago they left with the message: Remote host closed the connection
20140605 19:01:52-!- irker179 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140605 19:14:12< Turuk> wesbot: seen LordBob
20140605 19:14:12< wesbot> Turuk: Sorry, I don't know of LordBob.
20140605 19:14:49< fabi> wesbot: seen LordBob_
20140605 19:14:49< wesbot> fabi: Sorry, I don't know of LordBob_.
20140605 19:15:47< fabi> Last visit in forum was an april 12. I hope he is not lost.
20140605 19:22:03-!- irker869 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140605 19:22:03< irker869> wesnoth: fendrin wesnoth:1.12 3c1421ccf8a2 / data/themes/editor.cfg src/editor/editor_controller.cpp: Disabled the non working custom time schedule creator in the 1.12 branch http://git.io/DAGziw
20140605 19:32:18< irker869> wesnoth: fendrin wesnoth:1.12 bd52e2a0d7a6 / src/editor/palette/unit_palette.hpp: Disable the swap palette button when the unit palette is active. http://git.io/7ALLNA
20140605 19:34:07-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20140605 19:34:08-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has quit [Ping timeout: 255 seconds]
20140605 19:54:05-!- gfgtdf [~chatzilla@d149024.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140605 19:59:28-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20140605 20:19:42-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Quit: Leaving]
20140605 20:40:48-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140605 20:56:40-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140605 20:57:31-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140605 21:11:52-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140605 21:21:47-!- gfgtdf [~chatzilla@f054061141.adsl.alicedsl.de] has joined #wesnoth-dev
20140605 21:23:13-!- thunderstruck [~zaibotren@cpc13-sgyl31-2-0-cust696.18-2.cable.virginm.net] has quit [Quit: leaving]
20140605 21:31:05-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140605 21:37:14-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140605 21:37:55< iceiceice> gfgtdf: i think we should also try to unify the replay viewer and the play controller after we merge sp and mp
20140605 21:38:22< gfgtdf> iceiceice: with which intetnion ?
20140605 21:38:38-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140605 21:38:45< iceiceice> reduce code duplication
20140605 21:38:49< iceiceice> to guarantee that replay viewer works
20140605 21:39:00< iceiceice> also it would be useful to have some of the functionality,
20140605 21:39:10< iceiceice> players have often asked if they could have a replay button so they could replay the turns of their opponents
20140605 21:39:13< iceiceice> that happened while they are awa
20140605 21:39:14< iceiceice> y
20140605 21:39:38< gfgtdf> iceiceice: they caurrentlycan press stop networ i think ?
20140605 21:39:43< gfgtdf> currently*
20140605 21:39:57< iceiceice> yeah but its not as good as if they had a button
20140605 21:40:24< iceiceice> its also pretty counterintuitive, i dont know any other game where you can bring up on a menu to block network processing 
20140605 21:41:36< gfgtdf> iceiceice: hm i think that is playced in ameu becasue the place it limited and we only want the action that are uses very requently as button, note that player can still assign hotkeys to it
20140605 21:42:16< iceiceice> hmm so i guess maybe there could still be a replay viewer "theme" and a play controller "theme"
20140605 21:42:25< iceiceice> but i think at the C++ level they could be hte same object
20140605 21:45:43-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20140605 21:52:34< gfgtdf> AI0867: do you have  aproblem with me moving the windows specific code from savegame.cpp to filesystem.cpp ?
20140605 21:52:47< gfgtdf> AI0867: and use windows unicode functions then ?
20140605 21:54:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140605 21:56:28< gfgtdf> AI0867: the current implementqation is more than stupid: it converts utf8 to ansi (with a detour over utf16) just to let the windowapi internaly convert the anso back into utf 16. This also makes teh code more complicated
20140605 21:58:17< gfgtdf> AI0867: l lest soem of the
20140605 21:58:20< gfgtdf> at lest some
20140605 21:59:43< gfgtdf> of them
20140605 22:12:32< iceiceice> gfgtdf: i have to say i also quite like the whiteboard code
20140605 22:12:39< iceiceice> i wonder if we could model the gamestate object so that it works like that
20140605 22:13:12< gfgtdf> iceiceice: i dont rely know about the whiteboard code, what do you mea by "like that " ?
20140605 22:13:13< iceiceice> it has a nice abstraction for actions that know how to undo themselves if they are deleted without executing
20140605 22:13:26< iceiceice> and you can just have a container full of actions
20140605 22:16:44< gfgtdf> iceiceice: undo themself if they werent executed ?
20140605 22:17:55< iceiceice> did you ever use the whiteboard?
20140605 22:18:07< iceiceice> "planning mode"?
20140605 22:18:11< gfgtdf> iceiceice: ye
20140605 22:18:19< iceiceice> right so, when you use it you plan a move,
20140605 22:18:30< iceiceice> which has an immediate effect on graphics and unit map etc.
20140605 22:18:49< iceiceice> but you can cancel the move,
20140605 22:19:06< iceiceice> if you move a unit in the white board,
20140605 22:19:15< iceiceice> it applies a "temporary unit mover" object to it that moves it
20140605 22:19:33< iceiceice> and creates a fake unit that is "ghosted" behidn it
20140605 22:19:52< iceiceice> but you can cancel the move,
20140605 22:20:12< iceiceice> i cant remember how it works exactly now but im pretty sure it holds onto the temporary mover and just destroys it if the move doesnt happen
20140605 22:20:25< iceiceice> im very unsure how it works in networkd play though
20140605 22:20:39< iceiceice> it detects when the move would be OOS I guess?
20140605 22:27:34< iceiceice> idk it seems like a lot of code is duplicated
20140605 22:31:16< gfgtdf> i woudlnt think the whiteboard code is related to the oos code
20140605 22:31:52-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140605 22:32:21-!- irker869 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140605 22:32:34< iceiceice> gfgtdf: maybe that explains why its buggy then :O
20140605 22:32:56< gfgtdf> iceiceice: why should it? i thought teh whiteboard doesnt execute actions actualy
20140605 22:33:06< iceiceice> so on your client, it does
20140605 22:33:18< iceiceice> thats why you are able to get damage calculations
20140605 22:33:26< iceiceice> and why the unit you moved doesnt blcok pathing etc.
20140605 22:33:33< iceiceice> it actually modifies the unit map
20140605 22:33:43< iceiceice> it single player it doesnt really matter,
20140605 22:33:48< iceiceice> in mp its ovviously complicated
20140605 22:33:53< iceiceice> because you can use plannign mode when its not your turn
20140605 22:34:05< gfgtdf> so if you move a unit while other units have plany the unit map is of teh state of teh whiteboard ?
20140605 22:34:13< gfgtdf> plans*
20140605 22:34:23< iceiceice> i dont really know how it works, but my experience is,
20140605 22:34:33< iceiceice> if i plan to move a unit on my client while its my opponent's turn,
20140605 22:34:36< iceiceice> and then he decides to attack it or somtehing
20140605 22:34:42< iceiceice> it will cancel my planned move
20140605 22:34:46< iceiceice> because it became invalid
20140605 22:35:09< iceiceice> but it does this based on like ad-hoc checks
20140605 22:35:13< iceiceice> just looking at the unti map
20140605 22:35:20< iceiceice> what it should do is like,
20140605 22:35:32< iceiceice> there hsould be the global gamestate object, or perhaps the "networked" gamestate object,
20140605 22:35:40< iceiceice> and just ask "can_apply (my action) ?"
20140605 22:35:59< iceiceice> and that shoul be the same code that checks if user making an order normally would be valid
20140605 22:36:57< iceiceice> in my experinece you can sometimes get memory corruption with the ghost units in the whiteboard
20140605 22:37:06< iceiceice> idk if that is because of white board or the fake_units system though
20140605 22:37:18< iceiceice> i never figured it out its complicated
20140605 22:37:27< iceiceice> i only saw it in 1.10 also, it might be totally different now
20140605 22:37:53< iceiceice> i think it has to do with wha thappens if you have planned moves and a unit is killed though
20140605 22:42:08-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140605 22:55:06-!- Gambit is now known as DerekHoagland
20140605 22:55:13-!- DerekHoagland is now known as Gambit
20140605 23:00:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140605 23:09:38< iceiceice> gfgtdf: does turn_data_.process_network_data throw the end ... exceptions?
20140605 23:09:59< gfgtdf> i think yes
20140605 23:11:51-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140605 23:15:11-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140605 23:15:41< iceiceice> ok thx
20140605 23:21:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20140605 23:22:47< gfgtdf> iceiceice: do you know whether "." is a vlid filename on linux ?
20140605 23:22:50< gfgtdf> valid*
20140605 23:22:57< iceiceice> i think probly not
20140605 23:23:26< iceiceice> i think . and .. are special
20140605 23:23:31< iceiceice> or if not they should be
20140605 23:24:06< shadowm> They are reserved.
20140605 23:25:27-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 252 seconds]
20140605 23:25:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140605 23:26:17< gfgtdf> shadowm: do you know whether "....."  (5 dots) is a valid filename onlinux ?
20140605 23:26:40< iceiceice> http://en.wikipedia.org/wiki/Filename
20140605 23:26:45< iceiceice> i think yes
20140605 23:26:49< iceiceice> but we should still ban it
20140605 23:26:53< iceiceice> out of spite
20140605 23:27:13< shadowm> It is.
20140605 23:35:18-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140605 23:38:19-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140605 23:41:07-!- mjs-de [~mjs-de@f049107007.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140605 23:42:08-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20140605 23:48:16-!- aboutGod [~aboutGod@static-72-66-66-50.washdc.fios.verizon.net] has joined #wesnoth-dev
20140605 23:52:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140605 23:53:23-!- aboutGod [~aboutGod@static-72-66-66-50.washdc.fios.verizon.net] has left #wesnoth-dev []
20140605 23:55:42-!- irker612 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140605 23:55:42< irker612> wesnoth: Chris Beck wesnoth:master df71897d2f1e / data/lua/wml-tags.lua: add error reporting when [if] is evaluated with no actions http://git.io/xNsqVA
20140605 23:56:25-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140605 23:57:43< gfgtdf> AI0867: ok i think i'll just split savegame.cpp in 2 parts so i can concentrate on one part
20140605 23:58:14< irker612> wesnoth: Chris Beck wesnoth:master 1730099e8411 / changelog: update changelog http://git.io/RRqG9g
--- Log closed Fri Jun 06 00:00:12 2014