--- Log opened Sat Jun 07 00:00:29 2014
20140607 00:03:10< iceiceice> shadowm: ok
20140607 00:03:16< iceiceice> i dont think i will backport the wml unit tests
20140607 00:03:25< iceiceice> because that changes the run time behavior of the wesnoth so its probably a feature
20140607 00:03:38< shadowm> Yes, no, that's not backportable at all.
20140607 00:03:40< iceiceice> but if i see any C++ unit tests that might be productively backported i will
20140607 00:19:42-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140607 00:19:49-!- markus_ [~mjs-de@f048054179.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140607 00:21:17-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140607 00:21:17-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer]
20140607 00:22:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 245 seconds]
20140607 00:22:42-!- noy_ is now known as noy
20140607 00:29:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140607 00:32:10-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140607 00:33:21-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 01:06:19-!- fabi [~fabi@91-67-38-136-dynip.superkabel.de] has joined #wesnoth-dev
20140607 01:06:19-!- fabi [~fabi@91-67-38-136-dynip.superkabel.de] has quit [Changing host]
20140607 01:06:19-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20140607 01:10:22-!- sachith500 [~kvirc@112.134.165.154] has joined #wesnoth-dev
20140607 01:12:55-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has quit [Quit: Turuk]
20140607 01:13:19-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has joined #wesnoth-dev
20140607 01:16:37< irker266> wesnoth: Ignacio R. Morelle wesnoth:master f4515a673e85 / src/tests/test_addons.cpp: addon/validation: Add tests for the (un)encode_binary() functions http://git.io/ybT4EQ
20140607 01:20:36-!- sachith500 [~kvirc@112.134.165.154] has quit [Read error: Connection reset by peer]
20140607 01:21:31-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140607 01:23:00-!- sachith500 [~kvirc@112.134.165.154] has joined #wesnoth-dev
20140607 01:23:35-!- sachith500 [~kvirc@112.134.165.154] has quit [Client Quit]
20140607 01:25:19-!- sachith500 [~kvirc@112.134.165.154] has joined #wesnoth-dev
20140607 01:25:51-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140607 01:26:07-!- sachith500 [~kvirc@112.134.165.154] has quit [Read error: Connection reset by peer]
20140607 01:26:27-!- sachith500 [~kvirc@112.134.165.154] has joined #wesnoth-dev
20140607 01:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 247 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140607 01:31:45-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 01:34:52< irker266> wesnoth: Ignacio R. Morelle wesnoth:master c41361a1ea2b / src/tests/test_addons.cpp: addon/validation: Add test case for .. add-on name illegality http://git.io/9MLEzg
20140607 01:40:17-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140607 01:43:11< fabi> hello
20140607 01:43:28< shadowm> Hi.
20140607 01:44:41-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140607 01:44:41-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Changing host]
20140607 01:44:41-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140607 01:46:15< iceiceice> gfgtdf: i can reproduce this bug now: https://gna.org/bugs/?21873
20140607 01:46:22< iceiceice> wesbot: bug #21873
20140607 01:46:23< wesbot> Bug #21873  Assigned to: None  Status: Need Info  Priority: 5 - Normal
20140607 01:46:26< wesbot> Summary: multiplayer forcing a player to exit upon loss
20140607 01:46:28< wesbot> Original submission: I submitted my operating system, I'm not sure about the o
20140607 01:46:31< wesbot> perating system of the guy actually experiencing this bug.We played a couple
20140607 01:46:34< wesbot> URL: http://gna.org/bugs/?21873
20140607 01:47:01< iceiceice> i actually just played a full mp scenario vs an ai, when i executed the last attack which killed the enemy leader, client and obs both crashed
20140607 02:01:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140607 02:01:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140607 02:02:31-!- Spoffy_ [~chatzilla@152.78.175.8] has joined #wesnoth-dev
20140607 02:04:26-!- Spoffy [~chatzilla@82.199.155.15] has quit [Ping timeout: 240 seconds]
20140607 02:04:40-!- Spoffy_ is now known as Spoffy
20140607 02:17:58-!- Ivanovic_ [~ivanovic@frnk-5f750014.pool.mediaWays.net] has joined #wesnoth-dev
20140607 02:20:08-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds]
20140607 02:21:53-!- Ivanovic_ is now known as Ivanovic
20140607 02:58:17< shadowm> std::string() == "" vs. std::string().empty()
20140607 02:59:42< shadowm> Is there a practical difference? I presume there's an operator== overload so that the "" doesn't have to be implicitly packed into a new std::string instance (although I'm assuming this without looking at the source and I may be wrong).
20140607 03:03:22-!- sachith500 [~kvirc@112.134.165.154] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140607 03:05:44-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140607 03:06:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140607 03:15:45< c74d> C++’s type system isn’t sufficiently expressive to distinguish an empty C-string from a non-empty C-string.
20140607 03:16:49< c74d> Oh, never mind.
20140607 03:16:53< c74d> >_<
20140607 03:17:23< c74d> I thought you meant an overload specifically for empty C-strings.
20140607 03:17:29< c74d> <_>
20140607 03:19:00< shadowm> I'd speculate that checking whether s[0] == '\0' isn't too different from checking a std::string's emptiness even if it were defined by a separate flag by some implementation.
20140607 03:19:28< shadowm> Or more generally, a std::basic_string.
20140607 03:20:43-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140607 03:34:26-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140607 03:40:41-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 04:05:51-!- _8680_ [~8680@2002:4404:712c:0:7521:cf54:703f:f165] has quit [Ping timeout: 252 seconds]
20140607 04:06:28-!- _8680_ [~8680@2002:4404:712c:0:c4b6:73de:f126:904a] has joined #wesnoth-dev
20140607 04:13:26-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140607 04:18:23-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 04:43:29-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20140607 04:43:29-!- vultraz_ [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140607 04:43:37-!- vultraz_ is now known as vultraz
20140607 04:44:16-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20140607 04:44:16-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140607 04:49:54-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: Smell ya later!]
20140607 05:20:39-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 05:29:36-!- Sulfur [~Miranda@p5B327F74.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140607 05:41:30-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20140607 05:45:25-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140607 05:47:25-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 252 seconds]
20140607 06:03:24-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140607 06:08:55-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140607 06:34:41-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140607 06:35:26-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140607 06:48:52-!- _8680_ [~8680@2002:4404:712c:0:c4b6:73de:f126:904a] has quit [Quit: leaving]
20140607 06:49:18-!- _8680_ [~8680@2002:4404:712c:0:296f:468b:c7b1:da35] has joined #wesnoth-dev
20140607 07:08:11-!- Haldric [~Instantbi@wesnoth/translator/Haldric] has joined #wesnoth-dev
20140607 07:16:02-!- irker266 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140607 07:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 248 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140607 07:31:45-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140607 07:32:31-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140607 07:41:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140607 07:44:10-!- Jetrel_ [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140607 07:47:26-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 276 seconds]
20140607 07:51:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140607 07:55:18-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has quit [Read error: Connection reset by peer]
20140607 08:07:04-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140607 08:11:46-!- Ivanovic [~ivanovic@frnk-5f750014.pool.mediaWays.net] has quit [Changing host]
20140607 08:11:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140607 08:15:08-!- mjs-de [~mjs-de@f048054179.adsl.alicedsl.de] has joined #wesnoth-dev
20140607 08:26:35-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140607 08:30:41-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has quit [Client Quit]
20140607 08:52:14-!- Sulfur [~Miranda@p5B327F74.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140607 08:58:45-!- Netsplit *.net <-> *.split quits: Smar, Fortescue, vultraz, Spoffy, higgins, DHost_
20140607 08:58:54-!- Netsplit over, joins: vultraz, Spoffy, higgins, Fortescue, Smar, DHost_
20140607 09:01:19-!- Netsplit *.net <-> *.split quits: iwaim, c74d
20140607 09:01:43-!- Netsplit over, joins: c74d, iwaim
20140607 09:01:43-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.]
20140607 09:01:49-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Excess Flood]
20140607 09:01:56-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20140607 09:01:58-!- iwaim changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 248 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140607 09:02:04-!- Netsplit *.net <-> *.split quits: Spoffy, vultraz
20140607 09:02:04-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Max SendQ exceeded]
20140607 09:03:25-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 09:04:39-!- Netsplit over, joins: vultraz, Spoffy
20140607 09:05:17-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140607 09:06:05-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140607 09:07:20-!- markus_ [~mjs-de@f048227114.adsl.alicedsl.de] has joined #wesnoth-dev
20140607 09:11:04-!- mjs-de [~mjs-de@f048054179.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds]
20140607 09:21:01-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140607 09:29:52-!- cib [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140607 09:30:16-!- cib is now known as Guest61143
20140607 09:35:23-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 260 seconds]
20140607 09:37:10-!- Guest61143 [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20140607 09:41:06-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Read error: Connection reset by peer]
20140607 09:45:30-!- Haudegen [~quassel@178.115.130.65.wireless.dyn.drei.com] has joined #wesnoth-dev
20140607 10:14:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140607 10:43:50-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20140607 10:50:07-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140607 11:17:47-!- kex [~kex@93-143-125-5.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 11:33:12-!- markus_ [~mjs-de@f048227114.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140607 11:35:38-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140607 12:56:28-!- Haudegen [~quassel@178.115.130.65.wireless.dyn.drei.com] has quit [Ping timeout: 260 seconds]
20140607 12:57:29-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140607 13:01:11-!- _8680_ [~8680@2002:4404:712c:0:296f:468b:c7b1:da35] has quit [Ping timeout: 252 seconds]
20140607 13:01:34-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140607 13:02:11-!- _8680_ [~8680@2002:4404:712c:0:3d4f:d609:a1cd:6878] has joined #wesnoth-dev
20140607 13:06:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140607 13:06:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20140607 13:20:17-!- boucan_mobile [~boucman@178.251.23.94] has joined #wesnoth-dev
20140607 13:20:35-!- kex [~kex@93-143-125-5.adsl.net.t-com.hr] has quit [Read error: Connection reset by peer]
20140607 13:21:11-!- kex [~kex@93-143-125-5.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 13:22:43-!- Bodhi-Baum [~Bodhi@dslb-084-063-022-200.pools.arcor-ip.net] has joined #wesnoth-dev
20140607 13:25:59-!- kex [~kex@93-143-125-5.adsl.net.t-com.hr] has quit [Ping timeout: 265 seconds]
20140607 13:26:20-!- boucan_mobile [~boucman@178.251.23.94] has quit [Ping timeout: 260 seconds]
20140607 13:32:09-!- boucan_mobile [~boucman@178.251.23.94] has joined #wesnoth-dev
20140607 13:33:14-!- boucan_mobile2 [~boucman@178.251.23.94] has joined #wesnoth-dev
20140607 13:33:14-!- boucan_mobile [~boucman@178.251.23.94] has quit [Read error: Connection reset by peer]
20140607 13:35:39-!- boucan_mobile2 [~boucman@178.251.23.94] has quit [Read error: Connection reset by peer]
20140607 13:39:18-!- cib [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140607 13:39:42-!- cib is now known as Guest35177
20140607 13:41:55< fabi> hello
20140607 13:54:47-!- boucan_mobile [~boucman@178.251.23.94] has joined #wesnoth-dev
20140607 13:58:35-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140607 13:58:51< mordante> servus
20140607 14:01:35-!- Haudegen [~quassel@213162068087.public.t-mobile.at] has joined #wesnoth-dev
20140607 14:03:25< mordante> Aishiko, around?
20140607 14:14:41-!- boucan_mobile [~boucman@178.251.23.94] has quit [Remote host closed the connection]
20140607 14:14:57-!- boucan_mobile [~boucman@178.251.23.94] has joined #wesnoth-dev
20140607 14:15:05< fabi> mordante: hello
20140607 14:15:54< mordante> servus fabi 
20140607 14:17:12< fabi> mordante: I have searched through the unassigned bugs, there might be some gui2 related you want to adopt.
20140607 14:26:37-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140607 14:27:49< mordante> fabi, I'd rather nuke them ;-)
20140607 14:28:11< fabi> Yeah, that is the spirit!
20140607 14:30:24< mordante> fabi, are there still plans for WESSB?
20140607 14:31:37< fabi> mordante: No, not in the near future. I am at a good health again, now I need to consolidate my financial situation first. But I really love to have such an event someday.
20140607 14:31:46< fabi> mordante: So don't stop to ask my about it :-)
20140607 14:32:32< mordante> maybe we should just all show up at your place ;-)
20140607 14:35:05< fabi> Currently I do not even have a proper internet connection. We would have to share a 8kb/sec line.
20140607 14:35:33-!- irker052 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140607 14:35:33< irker052> wesnoth: Mark de Wever wesnoth:master bb1b4071a651 / src/CMakeLists.txt: Fix some CMake linker problems. http://git.io/3wjsVw
20140607 14:35:33< irker052> wesnoth: Mark de Wever wesnoth:master 6663ebd7e535 / src/game_preferences.cpp: Make a function static. http://git.io/IXp2Sg
20140607 14:35:34< irker052> wesnoth: Mark de Wever wesnoth:master 09122880e0d5 / src/savegame.hpp: Remove redundant declarations. http://git.io/4gr3Mw
20140607 14:35:51< mordante> luckily we use Git ;-)
20140607 14:37:44< fabi> mordante: What is the state of the 1.12 release?
20140607 14:40:11-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 276 seconds]
20140607 14:44:31< mordante> not entirely sure, but it's not progressing really fast
20140607 14:47:09< fabi> mordante: Sure? My stuff is nearly there in between and the bug tracker does not list many more blockers and important issues.
20140607 14:50:16-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140607 14:50:18< irker052> wesnoth: fendrin wesnoth:1.12 54c15592f7b8 / data/multiplayer/scenarios/ (2p_Dark_Forecast.cfg 9p_Merkwuerdigliebe.cfg): Put the DEFAULT_SCHEDULE_* macros in use. http://git.io/pOgS2Q
20140607 14:50:40< irker052> wesnoth: fendrin wesnoth:1.12 65750635608a / data/campaigns/Legend_of_Wesmere/scenarios/chapter1/03_Kalian_under_Attack.cfg: Fix coordinates after a map change. http://git.io/aoxpNQ
20140607 14:52:38< aquileia> fabi: Out of interest, why don't you apply these to master?
20140607 14:53:35< fabi> aquileia: They need to end in both branches, is the way to apply them to 1.12 first and then to master the better one?  I am not a git expert.
20140607 14:53:54< aquileia> I just wondered
20140607 14:54:49< mordante> fabi, not sure, but that is the fibe I got on the dev-ml
20140607 14:55:58-!- Haudegen [~quassel@213162068087.public.t-mobile.at] has quit [Ping timeout: 240 seconds]
20140607 14:56:32< fabi> mordante: Ah yes, I have not read them for a long time. Let me catch up.
20140607 14:56:45-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140607 15:02:46< aquileia> shadowm: How is the campaign server classified? I can't find campaign_server.cpp in the VC project...
20140607 15:04:18< aquileia> Or did just nobody bother to include it there?
20140607 15:04:40< mordante> I expect the latter
20140607 15:04:45< aquileia> ok
20140607 15:05:43< aquileia> I'm still not too familiar with the server interaction, and it can't hurt to ask
20140607 15:05:44< aquileia> thanks
20140607 15:07:10< irker052> wesnoth: Mark de Wever wesnoth:master 8a9e9c7f16e3 / src/gui/widgets/text.cpp: Fix using the shift key in the text widgets. http://git.io/GsSJ1A
20140607 15:11:21-!- knotwork_ [~markm@142.68.133.2] has joined #wesnoth-dev
20140607 15:11:21-!- knotwork_ [~markm@142.68.133.2] has quit [Changing host]
20140607 15:11:21-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20140607 15:14:18-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 240 seconds]
20140607 15:23:41< fabi> mordante: Okay I am through the list.
20140607 15:30:53-!- Sulfur [~Miranda@p5B327F74.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140607 15:37:58-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140607 15:39:48-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 240 seconds]
20140607 15:41:16-!- boucan_mobile [~boucman@178.251.23.94] has quit [Remote host closed the connection]
20140607 15:41:25-!- boucan_mobile [~boucman@178.251.23.94] has joined #wesnoth-dev
20140607 15:41:58-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140607 15:48:20-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140607 15:52:15< irker052> wesnoth: fendrin wesnoth:1.12 a25ff8d6087d / src/editor/editor_controller.cpp: Disabled the editor item tool for 1.12. http://git.io/95PnPg
20140607 15:53:49< fabi> Any ideas for a default hotkey for the "Show Terrain Description" action?
20140607 15:57:10-!- Kexoth [~kex@93-142-140-89.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 15:58:44-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140607 16:01:49< fabi> mordante: The "Show Global Helptip" action, default bound to "f10" is only used by gui2 and not working anywhere currently, right?
20140607 16:06:55-!- Haldric [~Instantbi@wesnoth/translator/Haldric] has quit [Quit: Leave]
20140607 16:11:16-!- boucan_mobile [~boucman@178.251.23.94] has quit [Read error: No route to host]
20140607 16:12:03-!- Kexoth [~kex@93-142-140-89.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140607 16:12:36-!- Kexoth [~kex@93-142-140-89.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 16:15:10-!- Bodhi-Baum [~Bodhi@dslb-084-063-022-200.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140607 16:17:05-!- Kexoth [~kex@93-142-140-89.adsl.net.t-com.hr] has quit [Ping timeout: 265 seconds]
20140607 16:20:33-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140607 16:22:15-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140607 16:54:28< irker052> wesnoth: fendrin wesnoth:1.12 8750dec007f8 / src/hotkey/ (hotkey_command.cpp hotkey_command.hpp): 2x change from return by copy to return by reference on const strings. http://git.io/kTbJqg
20140607 16:58:18-!- Haudegen [~quassel@cpe90-146-97-175.liwest.at] has joined #wesnoth-dev
20140607 16:58:57< irker052> wesnoth: fendrin wesnoth:1.12 acf3dfdb2650 / src/hotkey/hotkey_preferences_display.cpp: Display the tooltip for hovered hotkey actions. http://git.io/cOhvAg
20140607 17:06:50-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20140607 17:10:16-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140607 17:20:37-!- Kexoth [~kex@93-142-140-89.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 17:29:01-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140607 17:30:18-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 240 seconds]
20140607 17:30:59-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW]
20140607 17:41:51-!- Sulfur [~Miranda@p5B327F74.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140607 17:45:24< mordante> fabi, I think it is indeed not used yet I think I added it for you
20140607 17:45:48< fabi> oh
20140607 17:53:48-!- mjs-de [~mjs-de@p508CBF96.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140607 17:56:06< irker052> wesnoth: fendrin wesnoth:1.12 498b9001def0 / src/hotkey/hotkey_preferences_display.cpp: Enabled the corresponding action icons to be shown in the list. http://git.io/EqW5hA
20140607 17:56:29-!- shadowm_desktop [ignacio@190.91.76.121] has joined #wesnoth-dev
20140607 17:56:53-!- shadowm_desktop is now known as Guest74653
20140607 17:57:20-!- Guest74653 [ignacio@190.91.76.121] has quit [Client Quit]
20140607 17:57:53-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140607 17:58:32< shadowm> aquileia: It's classified as "not for anyone who isn't helping with wesnoth.org".
20140607 17:58:46< shadowm> Especially not Windows users.
20140607 18:00:56-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 240 seconds]
20140607 18:10:11-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 18:18:32-!- Guest35177 [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20140607 18:28:02-!- shadowm_desktop2 is now known as shadowm_desktop
20140607 18:48:21-!- Kexoth [~kex@93-142-140-89.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140607 18:51:44-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 276 seconds]
20140607 18:56:54-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140607 19:01:39< mordante> I'm off bye
20140607 19:02:23-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140607 19:12:55-!- Sulfur [~Miranda@p5B327F74.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140607 19:15:14-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Read error: Connection reset by peer]
20140607 19:20:28-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20140607 19:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 247 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140607 19:40:39-!- Kexoth [~kex@93-142-140-89.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 19:40:53-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140607 19:43:39< aquileia> Three PR's for project files in half an hour - what a coincidence
20140607 19:47:42< irker052> wesnoth: fendrin wesnoth:1.12 5634c55e0a4f / src/hotkey/hotkey_preferences_display.cpp: Repair the sorting of the hotkey list. http://git.io/gVHO2A
20140607 19:48:17-!- Kexoth [~kex@93-142-140-89.adsl.net.t-com.hr] has quit [Ping timeout: 276 seconds]
20140607 19:50:28-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 19:52:12-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140607 19:55:00-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 19:57:23< irker052> wesnoth: fendrin wesnoth:1.12 1e3f3dd0c4bf / src/hotkey/hotkey_command.cpp: Hide non working editor tool actions from the hotkey preferences. http://git.io/F2HxQg
20140607 20:01:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140607 20:04:38< irker052> wesnoth: fendrin wesnoth:1.12 22266c0a42f7 / data/core/hotkeys.cfg: Default hotkeys for editor brushes(1-5) and terrain description(ctr+t). http://git.io/rGow3w
20140607 20:05:40-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140607 20:08:05< irker052> wesnoth: aquileia wesnoth:master 9d3dfb04a98c / projectfiles/VC9/wesnoth.vcproj: Update VC project for 7ca6ad8 http://git.io/OPXsfQ
20140607 20:08:07< irker052> wesnoth: aquileia wesnoth:master f75cf3580df2 / projectfiles/VC9/wesnoth.vcproj: Update VC project for 294379a http://git.io/3gOSEQ
20140607 20:08:09< irker052> wesnoth: Ignacio R. Morelle wesnoth:master d21376f2bef9 / projectfiles/VC9/wesnoth.vcproj: Merge pull request #197 from aquileia/VC_update http://git.io/_OGx4w
20140607 20:08:12< irker052> wesnoth: sigurdfdragon wesnoth:master 6996d0598530 / projectfiles/CodeBlocks/wesnoth.cbp: CodeBlocks project update. http://git.io/JBg49A
20140607 20:08:14< irker052> wesnoth: Ignacio R. Morelle wesnoth:master 660719d52cf8 / projectfiles/CodeBlocks/wesnoth.cbp: Merge pull request #196 from sigurdfdragon/CodeBlocks_Update_20140607 http://git.io/MyRaJw
20140607 20:08:48< irker052> wesnoth: aquileia wesnoth:1.12 b0d8e2bb3112 / projectfiles/VC9/ (liblua.vcproj wesnoth.vcproj wesnothd.vcproj wesnothlib.vcproj): delete deprecated NDEBUG flag from VC project http://git.io/eUcltg
20140607 20:08:50< irker052> wesnoth: aquileia wesnoth:1.12 ad11aeb8242c / projectfiles/VC9/README.txt: Restore instructions for VC dependencies http://git.io/U-Ta3g
20140607 20:08:52< irker052> wesnoth: aquileia wesnoth:1.12 42a26a1905f6 / projectfiles/VC9/wesnoth.vcproj: Update 1.12 VC project for ebf797f65f and 2ed0908eb5 http://git.io/ylfocg
20140607 20:08:54< irker052> wesnoth: aquileia wesnoth:1.12 f599266adf74 / src/util.hpp: add missing <algorithm> header to util.hpp http://git.io/H4pKRQ
20140607 20:08:56< irker052> wesnoth: Ignacio R. Morelle wesnoth:1.12 1c9d39cfa769 / / (6 files in 2 dirs): Merge pull request #195 from aquileia/VC_fix_1.12 http://git.io/jX8pXw
20140607 20:11:38< shadowm> aquileia: That's a large header. Why is it required?
20140607 20:21:32< aquileia> shadowm: min & max
20140607 20:22:02< aquileia> Yeah, two tiny functions, but nontheless they are used
20140607 20:23:22< shadowm> I see.
20140607 20:23:54< aquileia> and thanks for merging, btw
20140607 20:36:10< iceiceice_> gfgtdf: i'm getting weird errors in the following scenario:
20140607 20:36:17< iceiceice_> set elf archer unit's max hp to 8
20140607 20:36:24< iceiceice_> have it kill an orc by attacking it
20140607 20:36:30< irker052> wesnoth: fendrin wesnoth:1.12 74138b294441 / src/editor/map/context_manager.cpp: Show the selected area changed status in the area menu. http://git.io/ZaMsdg
20140607 20:36:33-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140607 20:36:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20140607 20:37:01-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140607 20:37:04< iceiceice_> I get this:
20140607 20:37:04< iceiceice_> Error (strict mode, strict_level = 1): wesnoth reported on channel error engine
20140607 20:37:04< iceiceice_> 20140607 16:17:57 error engine: unit at 13,4tried to adcance more than 20 times
20140607 20:37:04< iceiceice_> FAIL TEST : alice_kills_bob_on_retal_levelup
20140607 20:37:23< iceiceice_> i think you wrote that error message but its hard to see why that is happening...
20140607 20:37:37< iceiceice_> i think it may represent a bug in the new advancement code?
20140607 20:38:38< iceiceice_> im not sure, it might only affect the game in noninteractive mode i think
20140607 20:38:52< iceiceice_> but that shouldnt make a difference
20140607 20:38:57-!- Haudegen [~quassel@cpe90-146-97-175.liwest.at] has quit [Remote host closed the connection]
20140607 20:39:01-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-fakvdxhslfxffwcu] has quit [Remote host closed the connection]
20140607 20:39:13-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 20:41:55-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140607 20:45:14< irker052> wesnoth: fendrin wesnoth:1.12 f704b4a1625b / data/themes/editor.cfg: Fix error message about missing ui elements. http://git.io/qTfiIA
20140607 20:45:50-!- gfgtdf [~chatzilla@d148062.adsl.hansenet.de] has joined #wesnoth-dev
20140607 20:46:18< gfgtdf> iceiceice_: ok maybe that's a stupid question, bug did the attacker has enough xp to levelup more than 20 times ?
20140607 20:46:25< gfgtdf> but*
20140607 20:46:26< iceiceice_> no it should only level up once
20140607 20:46:32< iceiceice_> i dont get error when i run with --showgui
20140607 20:47:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140607 20:48:04-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140607 20:48:26< gfgtdf> iceiceice_: did you get someting in log display
20140607 20:49:06< iceiceice_> 20140607 16:48:46 info display: animate_unit_advancement suppressed: invalid option
20140607 20:49:26< iceiceice_> with display replay and engine on, i get this about 20 times:
20140607 20:49:34< iceiceice_> http://hastebin.com/fozubekewi.md
20140607 20:49:40< iceiceice_> with those at log-debug= i mean
20140607 20:49:57-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 20:50:42< iceiceice_> i think that maybe the loop should not depend on "will_certainly_advance" ?
20140607 20:50:50< iceiceice_> maybe should store boolean result from "advance_unit" ?
20140607 20:50:56< iceiceice_> which tells whether it actually advanced?
20140607 20:51:01< iceiceice_> but thats a separate thing i guess
20140607 20:51:58< gfgtdf> iceiceice_: in non gui mode are all side ai sudes or are still human sides possible ?
20140607 20:52:05< iceiceice_> human is possible
20140607 20:53:20-!- trewe [~trewe@2001:8a0:d13e:4001:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20140607 20:54:31-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has quit [Ping timeout: 265 seconds]
20140607 20:56:12< gfgtdf> hm no i think making teh loop depoend on will _ceratinly advance ic corrext
20140607 20:56:27< gfgtdf> iceiceice_: teh bug is that teh adnavemnt dislod doent return teh correct value
20140607 20:56:31< gfgtdf> the advancement
20140607 20:57:06< iceiceice_> is "force_dialog" ever used?
20140607 20:57:30-!- ancestral [~ancestral@adsl-76-248-166-148.dsl.pltn13.sbcglobal.net] has joined #wesnoth-dev
20140607 20:57:58< gfgtdf> idk about force_dialog
20140607 20:58:22< iceiceice_> looking at "unit_advancement_choice"
20140607 20:58:24< iceiceice_> in attack.cpp
20140607 20:58:30< gfgtdf> ah i remembrer
20140607 20:58:33< iceiceice_> derives from mp_sync::userchoice
20140607 20:58:46< iceiceice_> i think maybe ad to there a check to resources::controller->non_interactive() ?
20140607 20:59:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140607 21:00:11-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140607 21:00:13< iceiceice_> hmm ok
20140607 21:00:25< iceiceice_> it looks ot me that the force_dialog argument to "advance_unit_at" is never used?
20140607 21:00:26< gfgtdf> iceiceice_: yes "force_dialog" is used by the advance wesnothconsole command
20140607 21:00:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140607 21:00:29< iceiceice_> ohh
20140607 21:00:53< iceiceice_> wait no are you sure?
20140607 21:00:58< iceiceice_> i think that might be argument to ai_advancement?
20140607 21:01:15< gfgtdf> iceiceice_: ye a check in unit_advancement_choice ::query_user seems to be the best option
20140607 21:01:30< gfgtdf> no it is a bool
20140607 21:01:35< gfgtdf> ai_advanement is no bool
20140607 21:01:49< gfgtdf> a check for nogui i mean
20140607 21:02:43< iceiceice_> hmm wait
20140607 21:02:45< iceiceice_> so in C++
20140607 21:03:05< iceiceice_> if i have f(int x, bool f = false, int y); as my declaration,
20140607 21:03:10< iceiceice_> i can write f(5,7)
20140607 21:03:12< gfgtdf> iceiceice_: no there is an overload: https://github.com/wesnoth/wesnoth/blob/302b0a831bfdd2685c233f6305e4eac9fbb99e38/src/actions/attack.hpp#L214
20140607 21:03:33-!- ancestral [~ancestral@adsl-76-248-166-148.dsl.pltn13.sbcglobal.net] has quit [Quit: i go nstuf kthxbai]
20140607 21:03:33< iceiceice_> oh i see
20140607 21:03:45< fabi> happygrue: I don't know how to handle this bug. https://gna.org/bugs/?21298 Do we really want to be those overlays completely invisible in the minimap as well?
20140607 21:04:24-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-cawopisbivexfcdg] has joined #wesnoth-dev
20140607 21:07:17< gfgtdf> iceiceice_: just add a "&& resources::controller->non_interactive()" in here : https://github.com/wesnoth/wesnoth/blob/master/src/actions/attack.cpp#L1392   ?
20140607 21:07:36< iceiceice_> y thats what i just did
20140607 21:08:44-!- ancestral [~ancestral@76.248.166.148] has joined #wesnoth-dev
20140607 21:12:29< iceiceice_> gfgtd: i was wrong, non_interactive() is actually just at global namespace
20140607 21:12:35< iceiceice_> but its defined in video.hpp / .cpp
20140607 21:13:18-!- gfgtdf_ [~chatzilla@e177179220.adsl.alicedsl.de] has joined #wesnoth-dev
20140607 21:15:20-!- gfgtdf [~chatzilla@d148062.adsl.hansenet.de] has quit [Ping timeout: 260 seconds]
20140607 21:15:27-!- gfgtdf_ is now known as gfgtdf
20140607 21:17:33< iceiceice_> fabi: i think we do
20140607 21:17:48< iceiceice_> unless its tactical minimap i guess
20140607 21:18:02< iceiceice_> if its classic minimap then imo they should be invisible
20140607 21:18:07< fabi> okay
20140607 21:21:56< irker052> wesnoth: Chris Beck wesnoth:master f43cb8edc2f4 / / (3 files in 3 dirs): add tests for scenario ending by killing enemy leader http://git.io/nCNNkw
20140607 21:21:58< irker052> wesnoth: Chris Beck wesnoth:master 8f428f93a93b / projectfiles/ (CodeBlocks/wesnoth.cbp VC9/wesnoth.vcproj): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/34K5LA
20140607 21:22:00< irker052> wesnoth: fendrin wesnoth:1.12 729bea854e39 / data/core/terrain.cfg: Fix for bug #21298: Minimap shows invisible overlays http://git.io/zlghRQ
20140607 21:22:17-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 21:22:47-!- Sulfur [~Miranda@p5B327F74.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140607 21:28:44< happygrue> fabi: I honestly don't use the minimap much, but it seems okay to me to have them be invisible.
20140607 21:30:01< fabi> happygrue: The satellite view will display the underlying terrain now, the semantic (or tactical) view will show a mixed color between both base terrains.
20140607 21:30:01-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-cawopisbivexfcdg] has quit [Changing host]
20140607 21:30:01-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20140607 21:30:01-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20140607 21:30:01-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-cawopisbivexfcdg] has joined #wesnoth-dev
20140607 21:35:16< fabi> happygrue: I have a bug report complaining about mushroom groove terrains not displayed as mixed terrain when combined with grass or hills. 
20140607 21:37:28< happygrue> I see.
20140607 21:37:31< fabi> happygrue: I think this is also how the engine handles the terrain. Everything with fungi on it is just fungus terrain, nothing else.
20140607 21:37:42< fabi> Is that true?
20140607 21:37:56< fabi> Or better: Is that how it is for ages and how we like it to be?
20140607 21:37:59< happygrue> I don't know.  I didn't recall that mushroom groves could go on other things
20140607 21:38:33< happygrue> I guess it *should* be treated as mixed terrian like anything else?
20140607 21:38:40< fabi> Have a look at hornsharks island.
20140607 21:38:46< iceiceice_> happygrue: i wrote this report because i saw it on hornshark island, and got slightly confused
20140607 21:38:55< iceiceice_> y idk if its intended or what
20140607 21:39:12< iceiceice_> maybe Doc Paterson liked the look of the hills but intended them to just be mushrooms?
20140607 21:39:13< shadowm> It should behave however forests behave too, except using the fungi terrain base instead of the forest one.
20140607 21:39:15< happygrue> probably at one time it was just on caves, perhaps as a seperate terrian
20140607 21:39:19< iceiceice_> i really have no idea i thought i would report anyways
20140607 21:39:35< happygrue> it's old, I don't recall when mixed terrian got involved but maybe it just didn't get adjusted then?
20140607 21:39:42 * fabi wants to hint out that the "fix" might break multiplayer balance.
20140607 21:39:58< happygrue> yes
20140607 21:40:02< fabi> And singleplayer balance.
20140607 21:41:50< happygrue> I would ask Velensk about that, but IMO we should make it like all the other terrian and then rebalance a bit if need be.
20140607 21:42:12< happygrue> I doubt it would cause too much trouble, but perhaps more mushrooms have entered the maps than I recall.
20140607 21:43:00-!- mjs-de [~mjs-de@p508CBF96.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20140607 21:43:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140607 21:44:13-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140607 21:44:34-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 21:45:38< irker052> wesnoth: fendrin wesnoth:1.12 18282b542fe4 / data/core/terrain.cfg: Fix bug #21971: visual glitch of terrains on 2p - Hornshark Island http://git.io/PKI4Lw
20140607 21:45:55< fabi> ^ Made it similar to forest overlay terrains.
20140607 21:46:05< fabi> Better defense worse movement.
20140607 21:46:23< shadowm> When was this decision made?
20140607 21:47:38< happygrue> fabi: really should check with Velensk about that
20140607 21:48:08< fabi> What is the alternative?
20140607 21:48:11< happygrue> from a general balance point of view it should be fine, and that's how it should work, but there might be a reason it's picked on that map
20140607 21:48:36< iceiceice_> fabi: i guess another alternative is to replace hills mushroom with just mushroom flat in the map
20140607 21:48:46< happygrue> well, making the change is probably fine but send him a message and just ask if it's actually an issue or what his thoughts are about it
20140607 21:48:47< iceiceice_> that would only change the visual appearance without the semantics
20140607 21:48:49< fabi> grass land with mushroom working like fungus groove is fine but fungus on hills just being fungus isn't very player friendly.
20140607 21:49:10-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140607 21:49:35< shadowm> Also don't forget to land those in master at some point.
20140607 21:50:10< shadowm> Not related: Deeply-indented loop containing a kilometric if-else-if chain, or an awkwardly set-up (boost::bind, std::pair, etc.) list of functions and the conditions to call them? Choose one.
20140607 21:50:21-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has joined #wesnoth-dev
20140607 21:50:29< happygrue> fabi: I 100% agree with the change, but it might but there might be a very specific reason for that terrian being picked in a map (in fact, often there is when odd terrian is present).  So just give him a heads up, so he can decide if there is actually an issue or if it's just a good change as is.
20140607 21:50:55-!- Spoffy [~chatzilla@152.78.175.8] has quit [Read error: Connection reset by peer]
20140607 21:51:13< fabi> happygrue: Yes, the mp devs must consider if we need map changes to keep balancing.
20140607 21:51:55< shadowm> You mean they should consider the change that would prompt such a thing.
20140607 21:52:22< happygrue> Velensk is the keeper of maps right now, he is going to care about it.  The mp devs are not going to be as current about that, in general
20140607 21:53:14< shadowm> iceiceice_: You like cleaning-up code, right?
20140607 21:53:31< fabi> happygrue: Ah okay, I was just writing in #wesnoth-mp about it.
20140607 21:53:32< happygrue> we outsourced the job to him because he was already more current with maps and when exactly this sort of thing would come up we didn't have a good answer.  In general, that is a good and player friendly change BUT the map might play a bit differently, which is something that Velensk thinks about.
20140607 21:54:40< shadowm> I guess I'm fine with the change because I always assumed it worked that way, not that anyone cares about SP map-makers. :p
20140607 21:54:56< happygrue> probably he will say it's fine, maybe he'll say that he can make some other tweak, or maybe there is some small chance that he really counted on that piece of terrian for some reason.
20140607 21:55:02< iceiceice_> shadowm: it depends
20140607 21:55:24< iceiceice_> fabi: might want to put something in 1.12 release notes also just as heads up for people
20140607 21:55:38< shadowm> iceiceice_: Just wondering if you might have an opinion even though it's not client-side code.
20140607 21:55:42< fabi> shadowm: Everybody thought it would work that way since the terrain text told them so. Only the new semantic display reveals the flaw.
20140607 21:55:56< iceiceice_> hmm good point
20140607 21:56:01< shadowm> The terrain text didn't specify.
20140607 21:56:34< fabi> I guess everyone assumed that Hills/Mushroom meant a mixed terrain behavior.
20140607 21:56:50< shadowm> Yeah, it just listed the base and overlay terrains, not the gameplay relationship between both.
20140607 21:57:22< fabi> The next step is to also reveal the rules like better of worse off 
20140607 21:57:49< fabi> Another thing maybe worth for a 1.12.1 backport.
20140607 21:57:55< shadowm> Defense vs. movement effects.
20140607 21:58:26< fabi> Yes Defense vs. movement vs. vision effects.
20140607 21:58:55< irker052> wesnoth: Chris Beck wesnoth:1.12 bb5aaf208193 / src/tests/test_serialization.cpp: backport lower case unit tests http://git.io/byD7yQ
20140607 21:58:57< irker052> wesnoth: Chris Beck wesnoth:1.12 80cce8f30a67 / data/core/terrain.cfg: Merge branch '1.12' of git://github.com/wesnoth/wesnoth into 1.12 http://git.io/ML-Zcw
20140607 22:01:26< aquileia> shadowm, iceiceice_: As you mentioned cleaning up... https://github.com/aquileia/wesnoth/compare/VC_update
20140607 22:02:34< aquileia> What do you think about restructuring the .gitignore file? If it ain't broke don't fix it? Or should I include it in my next PR?
20140607 22:03:02< shadowm> Different PR.
20140607 22:03:11< shadowm> That reminds me of my plan to delete all .gitignore files but the root one.
20140607 22:03:20< iceiceice_> aquileia: "if it ain't broke don't fix it" is an evil mentality
20140607 22:03:22< iceiceice_> imo
20140607 22:03:30< iceiceice_> maintanence = cleanup and refactor
20140607 22:03:33< shadowm> I even wrote a script, I should take a look at that mess again.
20140607 22:03:35< iceiceice_> not just, ignore until it breaks
20140607 22:04:14< aquileia> shadowm: Feel free to use my changes as a base and apply your script to it
20140607 22:04:42< aquileia> That would at least save a PR number
20140607 22:04:54< iceiceice_> hehe
20140607 22:04:59< iceiceice_> i sure hope we dont run out of those :p
20140607 22:05:24< iceiceice_> shadowm: if you have a simple question, please ask b/c i will leave for lunch soon
20140607 22:06:05< shadowm> My question isn't really simple, unfortunately. I guess I'll have to finish writing code and then compare the results.
20140607 22:06:50< irker052> wesnoth: fendrin wesnoth:1.12 cd429818f8ea / RELEASE_NOTES: Add section hinting about the changed fungus terrain to the notes. http://git.io/LaZ8TA
20140607 22:07:17< fabi> iceiceice_: ^
20140607 22:08:06< iceiceice_> shadowm: there are multiple .gitignore files??
20140607 22:08:11< iceiceice_> that is pretty evil i didnt realize we did that
20140607 22:08:44< iceiceice_> y wow there is a lot of cruft there
20140607 22:08:52< iceiceice_> we apparently ignore src/test/
20140607 22:09:00< iceiceice_> i wonder if that is why our unit tests are in src/tests/
20140607 22:09:04< aquileia> several of them only contain "*.gmo"
20140607 22:19:24< aquileia> oops, my regex just ignored the other lines...
20140607 22:30:53-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140607 22:42:04-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20140607 22:42:24-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140607 22:58:47-!- TC01_ [~quassel@venus.arosser.com] has joined #wesnoth-dev
20140607 23:05:53-!- ancestral [~ancestral@76.248.166.148] has quit [Quit: i go nstuf kthxbai]
20140607 23:13:18-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140607 23:14:32-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has quit [Ping timeout: 240 seconds]
20140607 23:21:42< aquileia> Oh... there is actually a gitignore rule that ignores three files in the repo: *.pyc in data/tools
20140607 23:23:57< aquileia> Elvish Hunter will have to decide whether to un-ignore them separately or just delete that rule
20140607 23:24:09-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140607 23:31:56< shadowm> fabi: The changelogs.
20140607 23:39:18-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140607 23:42:29-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds]
20140607 23:43:01-!- Necrosporus_ is now known as Necrosporus
20140607 23:53:03< aquileia> shadowm: Git didn't complain about some of my rules but in fact they're incorrect... I guess you won't have much use of the current state of the .gitignore in my branch...
20140607 23:53:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20140607 23:54:57< aquileia> which means as well that git (at least in my installation) is inconsistent in how it handles ignored files, great!
20140607 23:56:12< aquileia> I'll reboot under Ubuntu and see whether it's just me or a bug
20140607 23:56:22-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Quit: Page closed]
--- Log closed Sun Jun 08 00:00:50 2014