--- Log opened Sun Jun 08 00:00:50 2014
20140608 00:21:50-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140608 00:22:05< iceiceice> aquileia: if a file is added to the repo,
20140608 00:22:07< iceiceice> that overrides git ignore
20140608 00:22:15< iceiceice> git ignore only makes git ignore files that match and aren't in the repo
20140608 00:22:28< iceiceice> so if you specifically add a file, it wont ever be ignored
20140608 00:25:02< iceiceice> example is this file "test_wrapper.sh" i added to root directory
20140608 00:25:11< iceiceice> it is ignored becuase it matches test*
20140608 00:25:19< iceiceice> but i have specifically added it so it is part of the repo
20140608 00:25:34< iceiceice> and git will even point out unstaged changes if i change it
20140608 00:28:01-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140608 00:32:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Cheers]
20140608 00:42:41-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140608 00:44:00< aquileia> iceiceice: I already figured it out, but thanks
20140608 00:44:46< aquileia> That means we have dozens if not hundreds of files that match .gitignore rules, but are accepted...
20140608 00:46:35< aquileia> Especially Makefiles & CMakeLists.txt's
20140608 00:47:48< aquileia> I'll have a look at it tomorrow and try to refine some of the rules to consider this 
20140608 00:49:06< aquileia> after all, there's the "!" operator to selectively cancel out a rule
20140608 00:49:18< aquileia> but for now I'm off
20140608 00:49:30-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Quit: Page closed]
20140608 01:00:13-!- trewe [~trewe@2001:8a0:d13e:4001:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20140608 01:11:48-!- Guest35177 [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140608 01:17:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 01:23:18-!- Kexoth [~kex@93-143-69-228.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140608 01:27:54-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 01:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 243 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140608 01:30:11< gfgtdf> iceiceice: i marked https://gna.org/bugs/?22147 as Ready to test, will you test it forst or should i backport the fix mow ?
20140608 01:30:27< iceiceice> y i tested it
20140608 01:30:30< iceiceice> i think you should backport it
20140608 01:32:07-!- Guest35177 [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20140608 01:34:19< irker052> wesnoth: gfgtdf wesnoth:1.12 1b8199685e21 / src/playturn_network_adapter.cpp: fix network errors in playturn_network_adapter  http://git.io/4QYieg
20140608 01:41:03-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20140608 01:49:45-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 01:51:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 01:51:57< irker052> wesnoth: Chris Beck wesnoth:master 67e7f4c873b5 / src/game_end_exceptions.hpp: add end_play_signal type and visitors http://git.io/LRec0A
20140608 01:51:59< irker052> wesnoth: Chris Beck wesnoth:master c11088c4b426 / src/ (playsingle_controller.cpp playsingle_controller.hpp): push end_play exceptions down one level in playsingle_controller http://git.io/U5obqg
20140608 01:52:01< irker052> wesnoth: Chris Beck wesnoth:master b7c18c81d942 / src/ (playsingle_controller.cpp playsingle_controller.hpp): push end_play_exceptions one down in call stack, at "play_turn()" http://git.io/q07IvQ
20140608 01:52:03< irker052> wesnoth: Chris Beck wesnoth:master 554af4bd362d / src/playsingle_controller.cpp: remove unnecessary handler macro from events::raise_draw_event http://git.io/UvcHRA
20140608 01:52:05< irker052> wesnoth: Chris Beck wesnoth:master cb9a84b4e8de / src/ (playsingle_controller.cpp playsingle_controller.hpp): push end play exceptions out of play_controller::check_time_over http://git.io/xoYAPw
20140608 01:52:07< irker052> wesnoth: Chris Beck wesnoth:master 570e0a40d133 / src/ (play_controller.hpp playsingle_controller.cpp): finish_turn() cannot throw end play exceptions, remove handlers http://git.io/CEkPIA
20140608 01:52:09< irker052> wesnoth: Chris Beck wesnoth:master 7c20ca5f23f6 / src/playsingle_controller.cpp: remove handler from finish_side_done http://git.io/eAa6mQ
20140608 01:52:11< irker052> wesnoth: Chris Beck wesnoth:master 22ee9bc0cee4 / src/ (replay_controller.cpp replay_controller.hpp): push end play exceptions out of replay controller top level http://git.io/8lcuiA
20140608 01:52:13< irker052> wesnoth: Chris Beck wesnoth:master 6eb71ad6eb00 / src/ (hotkey/command_executor.hpp replay_controller.cpp replay_controller.hpp): push end play exceptions out of replay_controller::play_replay http://git.io/YkCl8g
20140608 01:52:15< irker052> wesnoth: Chris Beck wesnoth:master fed87a93837b / src/play_controller.hpp: remove unnecessary pure virtual function definition https://github.com/wesnoth/wesnoth/commit/fed87a93837bde3651a26d426cf8a92335c6be4d
20140608 01:52:17< irker052> wesnoth: Chris Beck wesnoth:master 051b204113a7 / src/ (5 files): push end play exceptions out of play_side() http://git.io/fXklWg
20140608 01:52:19< irker052> wesnoth: Chris Beck wesnoth:master 34d294eb55ea / src/ (hotkey/command_executor.hpp replay_controller.cpp replay_controller.hpp): replay_next_turn signals rather than throws, in replay_controller http://git.io/jahDxQ
20140608 01:52:21< irker052> wesnoth: Chris Beck wesnoth:master ccbe0b574bbe / src/ (hotkey/command_executor.hpp replay_controller.cpp replay_controller.hpp): replay_next_side signals rather than throws, in replay_controller http://git.io/j1pX-g
20140608 01:52:23< irker052> wesnoth: Chris Beck wesnoth:master 08edc7702a40 / src/ (replay_controller.cpp replay_controller.hpp): play_turn signals instead of throwing in replay_controller http://git.io/4bBZwg
20140608 01:52:25< irker052> wesnoth: Chris Beck wesnoth:master 2034f0661775 / src/ (replay_controller.cpp replay_controller.hpp): replay_controller::play_side signals rather than throws http://git.io/lWqKLg
20140608 01:52:27< irker052> wesnoth: Chris Beck wesnoth:master de026e6215b9 / src/ (4 files): play_controller::init_side signals rather than throws http://git.io/OjTRsQ
20140608 01:52:29< irker052> wesnoth: Chris Beck wesnoth:master 154f3db81246 / src/ (4 files): play_network_turn now signals rather than throws http://git.io/IX-4BQ
20140608 01:52:31< irker052> wesnoth: Chris Beck wesnoth:master 13f5b2797131 / src/ (4 files): play_human_turn signals rather than throwing http://git.io/LqfH9g
20140608 01:52:33< irker052> wesnoth: Chris Beck wesnoth:master 29ad76c3958a / src/ (4 files): play_idle_loop signals rather than throwing http://git.io/48hMuA
20140608 01:52:35< irker052> wesnoth: Chris Beck wesnoth:master 5e0f420277a9 / src/ (4 files): before_human_turn signals rather than throwing http://git.io/KWAbqQ
20140608 01:52:37< irker052> wesnoth: Chris Beck wesnoth:master 9da0b4c4c849 / src/ (10 files in 2 dirs): Merge pull request #191 from cbeck88/fixup_exceptions http://git.io/N1qOdQ
20140608 01:53:00< iceiceice> gfgtdf: i merged the exceptions catching thing
20140608 01:53:13< gfgtdf> oh
20140608 01:53:15< iceiceice> you will write changelogs for the 22147?
20140608 01:54:38-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 01:55:13-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 01:55:25-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140608 01:55:54< gfgtdf> hm ye i can, but you can do too.
20140608 01:57:17< gfgtdf> iceiceice: ok i'll do it
20140608 01:59:13< irker052> wesnoth: gfgtdf wesnoth:1.12 7e78c3b66345 / changelog: Update changelog http://git.io/lynlFg
20140608 01:59:18< gfgtdf> iceiceice: ^
20140608 02:01:18< gfgtdf> iceiceice: about the exceptions thing, couldnt we also instead or returning the check/victory make it part of end_game_data ?
20140608 02:02:04< gfgtdf> iceiceice: hm mabe that wont work for the end_turn thing then ...
20140608 02:02:43-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:03:29-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:06:54-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:07:08< gfgtdf> iceiceice: is it possible that an idle side thorws an end turn exception ?
20140608 02:07:18< gfgtdf> iceiceice: i thought idlse sides can do nothing ?
20140608 02:07:22< gfgtdf> idle*
20140608 02:07:32< gfgtdf> iceiceice: or can they still end turn 
20140608 02:07:36-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:09:26-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:10:11-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:11:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 02:11:10-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140608 02:13:38< iceiceice> gfgtdf: i think that
20140608 02:13:47< iceiceice> when the host executes :control
20140608 02:13:52< iceiceice> to give away the idle side
20140608 02:13:59< iceiceice> that results in end turn exception somewhere
20140608 02:14:03< iceiceice> it might only be in play_slice though
20140608 02:14:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 02:15:17< gfgtdf> hm ye i think its maybe just wrng that we have teh same exception for reassigned for ending turns
20140608 02:15:21< gfgtdf> wrong*
20140608 02:15:34< gfgtdf> for reassigning and for ending turns
20140608 02:15:37< gfgtdf> iceiceice: ^
20140608 02:15:45-!- Ivanovic_ [~ivanovic@frnk-5f752194.pool.mediaWays.net] has joined #wesnoth-dev
20140608 02:15:56< gfgtdf> iceiceice: the later shouldn't be handles in play_side at all.
20140608 02:15:56< iceiceice> y idk
20140608 02:16:32< iceiceice> its pretty complicated as it is and i think there are still bugs in it
20140608 02:16:36< iceiceice> the reassigining mechanism i mean
20140608 02:19:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20140608 02:19:03-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:19:39-!- Ivanovic_ is now known as Ivanovic
20140608 02:19:57-!- gfgtdf [~chatzilla@e177179220.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140608 02:21:17-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:22:44-!- Ivanovic [~ivanovic@frnk-5f752194.pool.mediaWays.net] has quit [Changing host]
20140608 02:22:44-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140608 02:24:39-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:25:24-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:28:04-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:28:39-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:30:55-!- _8680_ [~8680@2002:4404:712c:0:3d4f:d609:a1cd:6878] has quit [Ping timeout: 265 seconds]
20140608 02:31:51-!- _8680_ [~8680@2002:4404:712c:0:8dac:4502:390:9988] has joined #wesnoth-dev
20140608 02:32:38-!- sachith500 [~kvirc@112.134.167.90] has joined #wesnoth-dev
20140608 02:37:21-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:37:33< happygrue> does the feature freeze include map tweaks, or are they okay?
20140608 02:38:06-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:38:08< shadowm> They show up as "remote scenario" when the contents differ and otherwise work the same as usual.
20140608 02:40:40< happygrue> but if Velensk was to commit some balance changes to master, would cherry picking them to 1.12 be frowned upon, or is that fine?
20140608 02:40:40-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:41:26-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:42:04< shadowm> I for one wouldn't particularly care until RC 1 is out.
20140608 02:42:12< iceiceice> happygrue: if it's in relation to bug #21971 i would consider it to be part of the bugfix
20140608 02:43:07< shadowm> iceiceice: In bb5aaf208193247f902f220feb4065d4f93f1f95 you backported the BOOST_AUTO_TEST_SUITE and BOOST_AUTO_TEST_SUITE_END macro substitution sites found in the file's version from master. Do you know offhand what they do?
20140608 02:43:25< iceiceice> i think that when boost gets a failed test,
20140608 02:43:26< shadowm> (And why they aren't in a separate commit.)
20140608 02:43:32< happygrue> Velensk wanted to look into that hornshark issue a bit more, but didn't think there would be a problem.  But he mentioned he has some other things he's been working on and wasn't sure if the feature freeze encompassed maps.
20140608 02:43:36< iceiceice> it looks at the last boost auto test suite label
20140608 02:43:43< iceiceice> and says "last checkpoint: X"
20140608 02:43:45< happygrue> I'll tell him "soon" and he should be okay
20140608 02:43:52< iceiceice> sorry, not just a failed test.
20140608 02:43:55< iceiceice> if like, a test segfaults,
20140608 02:44:10< iceiceice> i think it will generally tell you the label of the test suite that blew up
20140608 02:44:35< iceiceice> i dont think that it changes the behavior other than that
20140608 02:44:40< shadowm> happygrue: He should just make sure that the changes aren't too significant (e.g. not replacing a whole map) and don't modify or add translatable strings.
20140608 02:45:00< shadowm> Deleting translatable strings is fine, but they cannot be reintroduced afterwards.
20140608 02:45:19< happygrue> Okay
20140608 02:45:33< shadowm> iceiceice: Okay, next time make sure to not lump that kind of unrelated changes together, please.
20140608 02:45:40< iceiceice> ok
20140608 02:49:03-!- kex [~kex@46.188.170.118] has quit [Read error: Connection reset by peer]
20140608 02:49:37-!- kex [~kex@46.188.170.118] has joined #wesnoth-dev
20140608 02:49:43< fabi> happygrue: That means you have spoken to Velensk about the Fungus Terrain already?
20140608 02:50:08< happygrue> fabi: I sent him a PM about it, as I'm not sure how much he reads the logs
20140608 02:50:48-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140608 02:51:02< happygrue> and he responded that it seemed okay but that he wanted to look into it a bit more to be sure.  But agreed that it makes more sense to have fixed it.
20140608 02:51:14-!- sachith500|2 [~kvirc@112.134.167.90] has joined #wesnoth-dev
20140608 02:52:25-!- sachith500 [~kvirc@112.134.167.90] has quit [Ping timeout: 252 seconds]
20140608 02:52:27-!- sachith500|2 [~kvirc@112.134.167.90] has quit [Read error: Connection reset by peer]
20140608 03:01:39< shadowm> I guess that you can't extend scope using a const reference that's a class member: http://pastebin.com/gwycQd8N
20140608 03:07:55-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140608 03:13:48-!- kex [~kex@46.188.170.118] has quit [Remote host closed the connection]
20140608 03:18:06-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140608 03:25:25-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer]
20140608 03:28:28-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140608 03:28:56-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140608 03:33:56-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 03:39:08< iceiceice> shadowm: yeah i think that doesn't work
20140608 03:42:57-!- sachith500 [~kvirc@112.135.95.158] has joined #wesnoth-dev
20140608 03:44:01< shadowm> Well, it says "UB!!!", so that means I already figured it out.
20140608 03:44:05< shadowm> Example: https://dl.dropboxusercontent.com/u/21371130/screenshots/boom.png
20140608 03:46:16< shadowm> If I were to use `struct A { const std::string s; A(): s(func()) {} };`, I guess there's pretty much no way that doesn't involve calling the copy constructor for std::string, right?
20140608 03:47:21< shadowm> Not that that's a problem since it's just a tiny string, but still.
20140608 03:49:13< shadowm> I'm not too happy with the design I came up with. :\ It's an improvement in readability, but it also feels more cumbersome.
20140608 03:50:21< iceiceice> shadowm: 
20140608 03:50:32< iceiceice> i guess you could use like, shared_ptr to it or something
20140608 03:50:37< iceiceice> if you really dont want to call copy constructor
20140608 03:50:55< iceiceice> but other than that i think you probably need to make a copy
20140608 03:51:26< shadowm> It's a temporary returned by a function I can't control, so I pretty much don't have an option there.
20140608 03:52:57-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 03:59:11< shadowm> I don't know, I think I'm doing this whole thing wrong and I should abandon the effort.
20140608 03:59:42< shadowm> Here's a branch on my fork in case anyone is remotely interested in taking a look: <https://github.com/shikadilord/wesnoth/compare/feature;campaignd-refactoring-crazy-handlers?expand=1>
20140608 04:07:59< irker052> wesnoth: Chris Beck wesnoth:master 55d5a11c1e3a / src/preferences.cpp: catch exceptions in preferences manager destructor http://git.io/B7tjcg
20140608 04:08:01< irker052> wesnoth: Chris Beck wesnoth:master 4b2ea78702ba / src/multiplayer_create.cpp: catch exceptions from multiplayer_create destructor http://git.io/7jouhA
20140608 04:08:03< irker052> wesnoth: Chris Beck wesnoth:master f165a55657d0 / src/playmp_controller.cpp: catch exceptions from playmp_controller destructor http://git.io/A8cCXA
20140608 04:08:05< irker052> wesnoth: Chris Beck wesnoth:master 4e7aa8364749 / src/game_display.cpp: catch exceptions in game_display, game_display::fake_unit dtor's http://git.io/A_Ht5A
20140608 04:08:07< irker052> wesnoth: Chris Beck wesnoth:master 7b0c4e6f8eb2 / src/game_board.cpp: catch exceptions in temporary mover, placer, remover dtor's http://git.io/AZVpwQ
20140608 04:08:09< irker052> wesnoth: Chris Beck wesnoth:master c65d367c44cb / src/ai/manager.cpp: catch exceptions thrown in ai::holder dtor http://git.io/H6Eg8g
20140608 04:08:11< irker052> wesnoth: Chris Beck wesnoth:master 675eb58975f8 / src/whiteboard/highlighter.cpp: catch exceptions thrown in whiteboard highlighter dtor http://git.io/FRed3w
20140608 04:08:13< irker052> wesnoth: Chris Beck wesnoth:master 8231aa9345fd / src/whiteboard/utility.cpp: catch exceptions thrown in whiteboard temporary unit hider dtor http://git.io/alvvuw
20140608 04:08:15< irker052> wesnoth: Chris Beck wesnoth:master 84b2cb2f6762 / src/whiteboard/mapbuilder.cpp: catch exceptions thrown in whiteboard mapbuilder dtor http://git.io/yx-8TQ
20140608 04:08:20< irker052> wesnoth: Chris Beck wesnoth:master 0ce40e751c24 / src/tooltips.cpp: catch exceptions thrown in tooltips manager dtor http://git.io/N8LA1A
20140608 04:08:20< irker052> wesnoth: Chris Beck wesnoth:master 0e24beb6aa7e / src/unit.cpp: catch exceptions thrown in unit dtor http://git.io/ibX1Hg
20140608 04:08:21< irker052> wesnoth: Chris Beck wesnoth:master bdd3edd58c96 / src/unit.cpp: catch exceptions thrown in unit_movement_resetter dtor http://git.io/3F7Dog
20140608 04:08:23< irker052> wesnoth: Chris Beck wesnoth:master 9dd32c490e57 / src/server/ban.cpp: catch exceptions thrown in server man_manager dtor http://git.io/WGR4jA
20140608 04:08:25< irker052> wesnoth: Chris Beck wesnoth:master a784abd04568 / src/replay.cpp: catch exceptions thrown from replay_network_sender dtor http://git.io/LnVqeA
20140608 04:08:27< irker052> wesnoth: Chris Beck wesnoth:master 312df6536eb7 / src/playturn_network_adapter.cpp: catch exceptions thrown from playturn_network_adapter dtor http://git.io/luKyCA
20140608 04:08:29< irker052> wesnoth: Chris Beck wesnoth:master b9b3a3bdc75a / src/multiplayer_configure.cpp: catch exceptions thrown from multiplayer_configure dtor http://git.io/DbT_iQ
20140608 04:08:31< irker052> wesnoth: Chris Beck wesnoth:master 5c5eb5bc4353 / src/multiplayer_wait.cpp: catch exceptions thrown from multiplayer_wait dtor http://git.io/8LOyDg
20140608 04:08:33< irker052> wesnoth: Chris Beck wesnoth:master 29cce9cc978f / src/game_controller.cpp: catch exceptions thrown from game_controller dtor http://git.io/W2pI5Q
20140608 04:08:35< irker052> wesnoth: Chris Beck wesnoth:master db09f880c2e0 / src/server/game.cpp: catch exceptions thrown from server/game dtor http://git.io/UChtdA
20140608 04:08:37< irker052> wesnoth: Chris Beck wesnoth:master 3c90eeb12530 / src/whiteboard/manager.cpp: catch exceptions thrown from whiteboard future_map dtor http://git.io/IGZMqA
20140608 04:08:39< irker052> wesnoth: Chris Beck wesnoth:master 2cf2025ae476 / src/whiteboard/manager.cpp: catch exceptions thrown from whitebaord future_map_if_active dtor http://git.io/EgvPYg
20140608 04:13:53< iceiceice> shadowm: what went wrong?
20140608 04:16:56< shadowm> Nothing code-wise, it's the design that doesn't convince me.
20140608 04:18:50< shadowm> Since for all intents and purposes I've been the sole campaignd maintainer (for certain definitions of 'maintainer') since 2012, I shouldn't really care so much about this, but I'm still unconvinced by my own code.
20140608 04:19:38-!- sachith500 [~kvirc@112.135.95.158] has quit [Read error: Connection reset by peer]
20140608 04:20:01-!- sachith500 [~kvirc@112.135.95.158] has joined #wesnoth-dev
20140608 04:23:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 04:26:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140608 04:26:59-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20140608 04:29:49-!- shadowm_desktop [ignacio@186.10.4.30] has joined #wesnoth-dev
20140608 04:30:02-!- shadowm_desktop is now known as Guest22483
20140608 04:30:47-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140608 04:53:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 05:22:45-!- Guest22483 [ignacio@186.10.4.30] has quit [Ping timeout: 252 seconds]
20140608 05:45:05-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140608 06:24:13-!- Mifta [~aboutGod@static-72-66-66-50.washdc.fios.verizon.net] has joined #wesnoth-dev
20140608 06:29:19-!- Mifta [~aboutGod@static-72-66-66-50.washdc.fios.verizon.net] has left #wesnoth-dev []
20140608 06:32:07-!- Sulfur [~Miranda@p5B009E8D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140608 06:43:26-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140608 06:45:26-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 06:47:01-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140608 06:47:11-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 06:48:16-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140608 06:50:38-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 06:51:04-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140608 06:51:23-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 06:51:32-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has joined #wesnoth-dev
20140608 06:56:29-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has quit [Ping timeout: 276 seconds]
20140608 07:02:41-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140608 07:03:21-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 07:08:31-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140608 07:08:41-!- irker052 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140608 07:09:56-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 07:10:48-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140608 07:28:38-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 07:52:31-!- mjs-de [~mjs-de@p508CBC52.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140608 07:59:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140608 08:02:30-!- ancestral_ [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 08:05:25-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140608 08:05:25-!- ancestral_ is now known as ancestral
20140608 08:06:21-!- irker139 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140608 08:06:21< irker139> wesnoth: Mark de Wever wesnoth:master 970c36bbcc22 / src/playmp_controller.cpp: Avoid narrowing; it's not allowed in C++11. http://git.io/W3-U1w
20140608 08:24:14-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140608 08:35:42-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140608 08:40:21-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has joined #wesnoth-dev
20140608 08:44:47-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has quit [Ping timeout: 252 seconds]
20140608 08:54:46-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 08:56:13-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140608 08:58:57< irker139> wesnoth: Boldizsár Lipka wesnoth:master 8db561f334f8 / src/sdl/rect.hpp: Use references where NULL pointers aren't allowed. http://git.io/BvjpmA
20140608 08:58:59< irker139> wesnoth: Boldizsár Lipka wesnoth:master eea2f2dae6f9 / src/sdl/rect.hpp: Use const arguments where appropriate. http://git.io/n6HF7Q
20140608 08:59:01< irker139> wesnoth: Boldizsár Lipka wesnoth:master 91f00a4c656f / src/loadscreen.hpp: Apply a more conventional indent style. http://git.io/ddCycA
20140608 08:59:03< irker139> wesnoth: Boldizsár Lipka wesnoth:master bccfa899103f / src/sdl/ (texture.cpp texture.hpp): Add a default ctor for ttexture. http://git.io/tz8iZQ
20140608 08:59:05< irker139> wesnoth: Boldizsár Lipka wesnoth:master f3258c7504c5 / src/sdl/ (window.cpp window.hpp): Add a function that clears the window with a specified color. http://git.io/-xoS1w
20140608 08:59:07< irker139> wesnoth: Boldizsár Lipka wesnoth:master 0ec70a22fdeb / src/sdl/ (texture.cpp texture.hpp): Add a function to check if the handled pointer is NULL. http://git.io/4Xs7ew
20140608 08:59:09< irker139> wesnoth: Boldizsár Lipka wesnoth:master d85f74e64d70 / src/ (video.cpp video.hpp): Make the global twindow object globally available. http://git.io/KKb8mw
20140608 08:59:11< irker139> wesnoth: Boldizsár Lipka wesnoth:master 2bdb4568eb71 / src/ (loadscreen.cpp loadscreen.hpp): Use SDL2's render API to clear the background and render the logo. http://git.io/Riy1sA
20140608 09:10:47-!- sachith500 [~kvirc@112.135.95.158] has quit [Read error: Connection reset by peer]
20140608 09:11:03-!- sachith500 [~kvirc@112.135.95.158] has joined #wesnoth-dev
20140608 09:14:35-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 09:18:14-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140608 09:26:38-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 276 seconds]
20140608 09:26:46-!- sachith500 [~kvirc@112.135.95.158] has quit [Read error: Connection reset by peer]
20140608 09:27:19-!- sachith500 [~kvirc@112.135.95.158] has joined #wesnoth-dev
20140608 09:27:50< aquileia> Now that I had another look I found some minor consistency issues... e.g. readme.txt, README.txt, README coexist in several instances all over the repo
20140608 09:29:12< aquileia> 4 / 4 / 16 instances
20140608 09:30:13-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140608 09:33:13-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140608 09:34:36< aquileia> Then, several of the po/ subdirs ignore Makefiles, but two contain one - I'm not too sure that's intended
20140608 09:36:00< aquileia> Ivanovic: Do you know by coincidence whether po/wesnoth-manpages/Makefile & po/wesnoth-manual/Makefile should be in the repo?
20140608 09:36:26< Ivanovic> those are special ones so yes, they should be there IIRC
20140608 09:36:33< aquileia> ok, thanks
20140608 09:37:09< Ivanovic> at least that is what i guess about those two
20140608 09:37:27< Ivanovic> might be that by now mordante changed things in the cmake recipe rendering those not required anymore
20140608 09:40:32-!- Sulfur [~Miranda@p5B009E8D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140608 09:49:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 09:52:41-!- Haudegen [~quassel@cpe90-146-97-175.liwest.at] has joined #wesnoth-dev
20140608 10:11:07-!- Sulfur [~Miranda@p5B009E8D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140608 10:14:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 10:29:06-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has joined #wesnoth-dev
20140608 10:34:14-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has quit [Ping timeout: 276 seconds]
20140608 10:34:38-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140608 10:35:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140608 10:40:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 10:46:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 10:54:36-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has joined #wesnoth-dev
20140608 10:56:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 10:58:59-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has quit [Ping timeout: 252 seconds]
20140608 11:12:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 12:06:53< irker139> wesnoth: Chris Beck wesnoth:master 368ce7f871fe / src/game.cpp: main catches and handles "std::exception" and "...", returning 1 http://git.io/eAfWxA
20140608 12:06:55< irker139> wesnoth: Chris Beck wesnoth:master 6c2dc69a7f36 / src/game.cpp: Add also exception handlers for strings thrown as exceptions http://git.io/Caw__g
20140608 12:06:57< irker139> wesnoth: Chris Beck wesnoth:master 0d0c5df85a62 / src/game.cpp: Merge pull request #194 from cbeck88/add_catch_all_to_main http://git.io/bpkfSA
20140608 12:09:57-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20140608 12:16:09-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has joined #wesnoth-dev
20140608 12:20:49-!- Netsplit *.net <-> *.split quits: aquileia
20140608 12:47:32-!- sachith500 [~kvirc@112.135.95.158] has quit [Read error: Connection reset by peer]
20140608 12:53:53-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140608 13:07:00-!- Bodhi-Baum [~Bodhi@dslb-084-063-032-176.pools.arcor-ip.net] has joined #wesnoth-dev
20140608 13:35:17-!- sachith500 [~kvirc@112.135.95.158] has joined #wesnoth-dev
20140608 13:37:55-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140608 13:37:58-!- sachith500|2 [~kvirc@112.135.37.25] has joined #wesnoth-dev
20140608 13:38:01-!- happygrue_ [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140608 13:39:03-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW]
20140608 13:40:30-!- sachith500 [~kvirc@112.135.95.158] has quit [Ping timeout: 240 seconds]
20140608 13:41:24-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140608 13:54:57-!- mjs-de [~mjs-de@p508CBC52.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20140608 13:59:06-!- sachith500|2 [~kvirc@112.135.37.25] has quit [Read error: Connection reset by peer]
20140608 14:01:17-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Read error: No route to host]
20140608 14:05:58< fabi> hello
20140608 14:15:28-!- sachith500|2 [~kvirc@112.135.37.25] has joined #wesnoth-dev
20140608 14:39:31-!- happygrue_ [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140608 14:43:15-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140608 14:44:53< aquileia> Ivanovic: Another stupid question - what about \po\wesnoth-utbs\remove-potcdate.sin ? It seems that it is only renamed from .sed and therefore wasn't deleted automatically
20140608 14:45:04< aquileia> Intended?
20140608 14:45:18-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has quit [Quit: Leaving]
20140608 14:49:49-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140608 14:51:43< Ivanovic> i don't think that one is intended
20140608 14:52:11< aquileia> ok, thanks again
20140608 14:56:52< fabi> shadowm: around?
20140608 14:59:29-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20140608 14:59:29-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20140608 14:59:29-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140608 14:59:45< mordante> servus
20140608 15:03:01< mordante> Ivanovic, not sure whether these Makefiles are required seems mog (the original cmake maintainer) added them 
20140608 15:03:34< mordante> I did the language updates later and probably didn't bother with them since we also had autotools at the time
20140608 15:04:55< mordante> the last change was by you dfd9b70697bb85fa293729e34b011fd5e6040562 already guessing they were unused
20140608 15:05:37< fabi> hi mordante
20140608 15:07:07< mordante> servus fabi 
20140608 15:11:06< fabi> mordante: I have a problem with the terrain system.
20140608 15:11:39< fabi> zookeeper: Forest terrain does not work as overlay terrain for us.
20140608 15:12:48< fabi> The problem is that all combinations with flat terrain give cavalary the better defense which can't be.
20140608 15:13:01-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140608 15:14:55< zookeeper> fabi, that'd be the flat+forest exception for cavalry
20140608 15:15:12< zookeeper> IIRC done in the relevant movetype
20140608 15:15:40< fabi> zookeeper: My approach to the problem would be another trait similar to the Feral one the bat uses.
20140608 15:16:35< fabi> zookeeper: Something like "bulky" meaning the unit is to big to benefit from forest.
20140608 15:22:48< mordante> fabi, what kind of problem?
20140608 15:24:16< fabi> mordante: The one I already discuss with zookeeper. This is really a bad thing and should be fixed before the next release.
20140608 15:26:22< fabi> I guess the best thing to do right now is bring all the hardcoded forest terrains back.
20140608 15:27:12< zookeeper> and why is all this such a problem right now?
20140608 15:29:16< mordante> fabi, I guess it's a bit late in the release to do that for 1.12
20140608 15:29:31< mordante> it will probably affect MP balancing
20140608 15:29:45< mordante> (to be honest I've never been a big fan of the overlays)
20140608 15:30:00< zookeeper> i hope the reason isn't again simply that you're having a problem in UMC
20140608 15:34:02-!- cib_ [~cib@p20030067CE126501267703FFFEE75B84.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140608 15:34:29-!- Octalot [~noct@132.53.125.91.dyn.plus.net] has joined #wesnoth-dev
20140608 15:35:40< fabi> mordante: Well, something must be done. The current forest terrain is broken.
20140608 15:38:28-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140608 15:46:19< fabi> zookeeper: Some of the broken terrain is already in 1.10. The UI changes just revealed the bug.
20140608 15:48:10< fabi> zookeeper: And it has nothing to do with any UMC. I will just fill a bug report and mark it as blocker.
20140608 15:49:32< mordante> if it's already broken in 1.10 I don't think it needs to be a blocker for 1.12
20140608 15:49:49< zookeeper> so what's the bug?
20140608 15:50:06< zookeeper> so far you've only talked about an intentional and very conscious change
20140608 15:50:50< zookeeper> ignoring that and only saying "bug" is just willful misleading, unless there's something more to it than the cavalry on forests thing.
20140608 15:52:53< fabi> So you suggest to keep it the way it is now?
20140608 15:53:12< fabi> That is fine with me.
20140608 15:53:45< fabi> I was certain at least the MP devs would be eager to get this fixed before 1.12.
20140608 15:54:19< zookeeper> i'm not suggesting anything, there's no good solutions really.
20140608 15:54:47< zookeeper> this, along with feral, are very unfortunate
20140608 15:55:06< fabi> I guess it will end up with hardcoding the forest terrains again.
20140608 15:56:53< fabi> Which isn't so nice for being used in the editor and not maintainer friendly. But should work without any breakage of map compatibility.
20140608 15:57:20< fabi> At the end there will be even more forest terrains as we had in 1.10.
20140608 16:01:12< fabi> Or a rule in [terrain_type] that says if based on flat then different movetype.
20140608 16:01:49< mordante> well since it has there since 1.10 I assume the MP devs already balanced with the new situation
20140608 16:02:01< mordante> anyway food is ready, bbl
20140608 16:02:14< fabi> I don't think so.
20140608 16:02:28< fabi> The new forest terrains are not that heavily used on mp maps.
20140608 16:02:56< fabi> Velensk requested the fix from me.
20140608 16:07:21-!- Sulfur [~Miranda@p5B009E8D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140608 16:15:12-!- Haudegen [~quassel@cpe90-146-97-175.liwest.at] has quit [Remote host closed the connection]
20140608 16:28:48-!- irker139 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140608 16:29:05-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140608 16:45:04-!- irker413 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140608 16:45:04< irker413> wesnoth: Chris Beck wesnoth:master 8534aa28518f / src/ (5 files): remove unnecessary argument to game_display::scroll_to_leader http://git.io/BK1qEQ
20140608 17:01:56-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has joined #wesnoth-dev
20140608 17:06:23-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has quit [Ping timeout: 252 seconds]
20140608 17:10:25-!- Bodhi-Baum [~Bodhi@dslb-084-063-032-176.pools.arcor-ip.net] has quit [Ping timeout: 252 seconds]
20140608 17:12:23-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140608 17:21:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 17:23:59-!- Netsplit *.net <-> *.split quits: Upth, {V}
20140608 17:24:22-!- Netsplit over, joins: {V}
20140608 17:27:09-!- Upth [~ogmar@108-85-89-233.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20140608 17:30:18-!- Netsplit *.net <-> *.split quits: Upth
20140608 17:30:38-!- Netsplit over, joins: Upth
20140608 17:35:18-!- Bodhi-Baum [~Bodhi@dslb-084-063-032-176.pools.arcor-ip.net] has joined #wesnoth-dev
20140608 17:38:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 17:48:22-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140608 17:57:09-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140608 17:58:44-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Quit: riksteri]
20140608 17:59:47< aquileia> shadowm: https://github.com/aquileia/wesnoth/compare/ignore
20140608 18:01:06< aquileia> This time I used ls-files to check what consequences it'll have
20140608 18:02:12< aquileia> And I might apply a few more commits merging other gitignores in case you don't want to do it with your script
20140608 18:13:53< irker413> wesnoth: fendrin wesnoth:1.12 24d6015767b1 / changelog: Mention mostly editor related changes. http://git.io/Y3fthA
20140608 18:22:09-!- gfgtdf [~chatzilla@e177179220.adsl.alicedsl.de] has joined #wesnoth-dev
20140608 18:35:19-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140608 18:36:27< shadowm> fabi: You know you can leave messages for me when I'm not...
20140608 18:37:11< fabi> What do you think about the terrain issue?
20140608 18:37:13< aquileia> shadowm, I pruned the repo except for src/ of gitignore's
20140608 18:37:32< shadowm> fabi: I think I said mushroom groove should behave just like forest but with a different movetype.
20140608 18:38:09< shadowm> aquileia: I haven't taken a look at the gitignore situation yet, I'm rather busy with other things.
20140608 18:38:16< fabi> shadowm: Another one. All forest overlay terrains act like forest/flat which gives cavalary better values on them. 
20140608 18:38:53< iceiceice> fabi: isnt here like some "-30" defense thing for cavalry?
20140608 18:38:57< mordante> Necrosporus, I've good and bad news; the bad: your patch is indeed wrong and not required; the good: it looks like I found a fix
20140608 18:39:02< iceiceice> i remember i asked this question onceon forums
20140608 18:39:07< shadowm> What iceiceice said.
20140608 18:39:08< iceiceice> maybe its that that's broken?
20140608 18:39:29< fabi> iceiceice: No, that is feral and for bats on villages.
20140608 18:39:45< aquileia> fabi: What about a little hack - a single 'forest' base terrain that is used in case we don't want forest to behave as an overlay? Any forest can be overlaid with it and we won't have the issue
20140608 18:39:53< shadowm> Horsemen clearly have 30% defense on Forest here and 40% on Grassland.
20140608 18:40:10< shadowm> So I'm not sure what the issue is.
20140608 18:40:11< iceiceice> fabi: here was thread: http://forums.wesnoth.org/viewtopic.php?f=21&t=39863
20140608 18:41:03< aquileia> fabi: The terrain would be forest with forest overlay, but who cares
20140608 18:41:30< Necrosporus> mordante, so have you found out what the problem?
20140608 18:43:19< shadowm> mordante: I'm interested in the situation with the :inspect dialog assert too, I've got a few changes to the dialog pending and I don't want to rob you of a valuable test case.
20140608 18:44:26< mordante> Necrosporus, shadowm src/gui/widgets/scrollbar_container.cpp:266 is the problem
20140608 18:44:45< mordante> it tries the make the listbox as small as possible
20140608 18:45:14< fabi> shadowm: I don't get how that works. And why Velensk wants to have it fixed.
20140608 18:45:19< mordante> but it uses the minimum width for the horizontal scrollbar and ignores the space required for the vertical scrollbar
20140608 18:45:48< mordante> then the placement algorithm fails since it can't place a 95 width item in a 70 width box
20140608 18:46:39< mordante> shadowm, what kind of changes do you have pending, the inspect dialog now has unwanted calls to window_invalidate()
20140608 18:46:55< shadowm> fabi: Non-elvish cavalry having worse defense on forest is intentional, so yeah why does he want to change that? (happygrue?)
20140608 18:47:27< mordante> I still want to test a bit further, but I'm quite sure I have the proper fix
20140608 18:47:40< shadowm> mordante: Some changes to the layout. The window_invalidate() calls were already there when I started hacking in the dialog, so I presume they were added by the original author.
20140608 18:48:47< mordante> they were a kind of work-around for this bug, so I'd like to remove them
20140608 18:48:54< fabi> shadowm: Velensk complained about cavalary having the better defense on the forest terrain because now all of them are forest/flat or similar. And the coding should give him right, the problem exists. The forest overlay takes the better from both for defense. Now you discover that the defense values are in fact right in the game.
20140608 18:49:03< mordante> shadowm, does that conflict with your changes?
20140608 18:49:04< fabi> That means something else must be broken.
20140608 18:49:45< shadowm> mordante: I don't think so, since most of my changes are in WML.
20140608 18:50:06< mordante> actually shadowm it doesn't matter, feel free to commit I'm working on a bug fix branch
20140608 18:50:39< shadowm> But then that'd make it harder for someone else to confirm whether the bug is fixed.
20140608 18:50:58< mordante> true
20140608 18:53:39-!- mjs-de [~mjs-de@p508CBC52.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140608 18:56:18-!- sachith500|2 [~kvirc@112.135.37.25] has quit [Read error: Connection reset by peer]
20140608 18:56:35-!- sachith500|2 [~kvirc@112.135.37.25] has joined #wesnoth-dev
20140608 18:57:11< fabi> shadowm: Okay, I see. Someone fixed it with a "-70" syntax I am not aware of.
20140608 18:58:54< shadowm> Right.
20140608 18:58:57< fabi> shadowm: Then the fix is to use the minus syntax for the cavalry and fungus as well.
20140608 19:00:04-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140608 19:00:38< zookeeper> there was no bug that was fixed with the -70.
20140608 19:00:53< irker413> wesnoth: Chris Beck wesnoth:master 57cc44be6408 / src/ (5 files in 2 dirs): game_display uses game_board in it's constructor http://git.io/jsqwUA
20140608 19:00:58< zookeeper> and as you may recall, i immediately told you that the exception is in the movetype
20140608 19:03:05-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140608 19:03:31-!- Sulfur [~Miranda@p5B009E8D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140608 19:03:37< fabi> zookeeper: Yes, you are great. And I didn't get it. Anyway, I have my solution and you had some fun showing me what an idiot I am. I call that a win-win situation :-P
20140608 19:07:44-!- sachith500|2 [~kvirc@112.135.37.25] has quit [Read error: Connection reset by peer]
20140608 19:08:39-!- sachith500|2 [~kvirc@112.135.37.25] has joined #wesnoth-dev
20140608 19:10:34< aquileia> Could someone merge https://github.com/wesnoth/wesnoth/pull/198, please?
20140608 19:11:10< aquileia> I have another PR that I can't send before that
20140608 19:14:20< shadowm> Okay, did someone change something about exception handling in 1.12 recently?
20140608 19:15:07< shadowm> Or some other thing that can explain that not closing a WML tag properly now produces valid but semantically incorrect WML?
20140608 19:18:28< iceiceice> idk i saw that forum post also
20140608 19:18:29< shadowm> Okay, I guess it must be my fault because it goes all the way back to 1.11.11.
20140608 19:18:43< shadowm> wesnoth-1.11.10: error while loading shared libraries: libboost_regex.so.1.54.0: cannot open shared object file: No such file or directory
20140608 19:18:53< shadowm> I'll continue gathering more information after a rebuild.
20140608 19:21:24-!- sachith500|2 [~kvirc@112.135.37.25] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140608 19:21:35< iceiceice> shadowm: maybe try to set a breakpoint on the gui notification in gdb?
20140608 19:21:39< iceiceice> in the version where it works correctly?
20140608 19:21:44< iceiceice> and then check that that line does in current vrsions?
20140608 19:21:47< iceiceice> or smth
20140608 19:21:55< iceiceice> idk how hard it will be to bisect that one
20140608 19:22:06< shadowm> Why would it be hard?
20140608 19:22:30< iceiceice> it depends if it goes back to like a gigantic commit or not
20140608 19:22:38< shadowm> All I need are a good tag and a bad tag to work with.
20140608 19:23:14< shadowm> Oh wait.
20140608 19:23:30< shadowm> I removed the bogus line from my test case before starting checking past versions, duh.
20140608 19:24:03< shadowm> 1.11.15 is bad and 1.11.14 is good.
20140608 19:24:19< iceiceice> ok that narrows it down alot :)
20140608 19:24:21< shadowm> Confirmed it's at least not directly my fault.
20140608 19:26:31< iceiceice> hmm oh so i remember a wierd issue with exceptions in 1.11.14 to 1.11.15
20140608 19:26:37< iceiceice> we had two definitions of bad_lexical_cast
20140608 19:26:44< iceiceice> we discovered one here: https://github.com/wesnoth/wesnoth/commit/7247cb4e2ef6b4847b2dc59900f46773a5e872c4
20140608 19:26:56< iceiceice> one here: https://github.com/wesnoth/wesnoth/commit/7247cb4e2ef6b4847b2dc59900f46773a5e872c4
20140608 19:28:22< iceiceice> be back later
20140608 19:28:23-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140608 19:28:44-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 244 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140608 19:29:20< shadowm> Both links are indentical.
20140608 19:29:25< shadowm> *identical
20140608 19:29:45-!- Bodhi-Baum [~Bodhi@dslb-084-063-032-176.pools.arcor-ip.net] has quit [Ping timeout: 252 seconds]
20140608 19:33:13 * shadowm grabs the squeaky mallet.
20140608 19:33:39< shadowm> iceiceice: We have a winner: http://pastebin.com/wM9Gv8Lp
20140608 19:34:33< shadowm> iceiceice: Why does that commit replace several '\n's with endl manipulators that aren't needed for the unbuffered stderr stream?
20140608 19:35:07< shadowm> There is a lot of noise in the diff as a result.
20140608 19:35:48< shadowm> Also, why isn't this information in the commit message?
20140608 19:36:23< shadowm> I surmise the problem is that config_cache::read_configs() is catching an exception that is supposed to propagate.
20140608 19:38:07< shadowm> That would explain why in the add-on case it's possible to get a malformed but valid WML document, but it doesn't explain why if I remove the slash from the first closing [/objectives] tag in HttT scenario 1 I get gui2::twml_error instantiated with text from the infamous "missing WML child yet untested for" error.
20140608 19:38:18-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20140608 19:39:02< shadowm> Note that the exceptions are supposed to propagate to game_config_manager::load_game_config().
20140608 19:40:52< shadowm> ... which calls config_cache::get_config(), which calls config_cache::load_configs(), which calls config_cache::read_configs() which is the likely culprit.
20140608 19:43:30 * shadowm lets out a big sigh.
20140608 19:45:25-!- kex [~kex@93-143-105-144.adsl.net.t-com.hr] has joined #wesnoth-dev
20140608 19:48:58< mordante> the std::endl indeed look horrible
20140608 19:49:27< shadowm> Okay, config_cache::read_cache() is just one culprit. Disabling the catch there only causes the exception to be caught by a more silent handler somewhere up the stack.
20140608 20:02:20< shadowm> Or maybe it's because it's reading the cached malformed WML.
20140608 20:04:27-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140608 20:04:27-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Changing host]
20140608 20:04:27-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140608 20:04:36< iceiceice_> shadowm: the std::endl are necessary
20140608 20:04:46< iceiceice_> i began adding those because one time i was getting an assert failure,
20140608 20:04:50< iceiceice_> and i began logging debug info,
20140608 20:04:57< iceiceice_> and i didn't get any output...
20140608 20:05:01< iceiceice_> because not flushing the streams.
20140608 20:05:13< iceiceice_> i have been adding those since then
20140608 20:05:26< iceiceice_> i regard that as a minor bugfix each time i do it, which requires no explanation and cannot possibly cause a problem,
20140608 20:05:32< iceiceice_> and might save someone else an hour in the future
20140608 20:06:24< iceiceice_> i didn't know the config::error exceptions weren't supposed to throw,
20140608 20:06:52< iceiceice_> were supposed to throw that is,
20140608 20:06:56< mordante> iceiceice_, did you then make std::cerr buffered?
20140608 20:07:24< iceiceice_> mordante: i did not make it buffered
20140608 20:07:28< mordante> normally std::cerr is unbuffered
20140608 20:07:33< iceiceice_> are all of the loggers though?
20140608 20:08:40< iceiceice_> are the loggers all supposed to resolve to std::cerr?
20140608 20:09:27< mordante> normally yes there is a way to redirect the output, not sure where it is used
20140608 20:09:46< mordante> s/yes/yes, but
20140608 20:10:14< iceiceice_> so looking at the logger, it looks like "wml_error" is just a string stream, so that one is definitely buffered
20140608 20:10:32< iceiceice_> all i know is that one time i got an extremely annoying issue like this,
20140608 20:10:41< iceiceice_> i prefer to use std::endl because then i dont have any ambiguity
20140608 20:10:50< iceiceice_> if you guys don't liek that then let's figure something else out,
20140608 20:10:56< iceiceice_> i didnt know some people think std::endl is ugly
20140608 20:11:15< iceiceice_> i thought its the preferred way to write to a stream
20140608 20:12:17< shadowm> iceiceice_: Mixing up multiple bugfixes in the same commit leads to situations like this being harder to inspect.
20140608 20:12:20< mordante> it's not since it forces flushing, which is not always wanted
20140608 20:12:28-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer]
20140608 20:12:38< iceiceice_> thats just an optimization issue though
20140608 20:12:44< iceiceice_> if you need to get an error message,
20140608 20:12:49< iceiceice_> and you aren't sure if you need to flush or not,
20140608 20:12:52< iceiceice_> why would you not flush?
20140608 20:12:54< mordante> therefore the std::cerr automatically flushes
20140608 20:13:14< shadowm> I broke gdb. :(
20140608 20:13:17< mordante> and that should even directly output every char
20140608 20:13:38< iceiceice_> hmm 
20140608 20:13:49< iceiceice_> well its possible i didn't fully understand the issue,
20140608 20:13:58< mordante> which OS do you use
20140608 20:14:02< iceiceice_> but looking at the logger it hink wml_error absolutely needs std::endl
20140608 20:14:04< iceiceice_> i use linux
20140608 20:14:08< iceiceice_> linux mint 16
20140608 20:14:11-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140608 20:14:23< shadowm> Is there anything speaking against making wml_error autoflush instead?
20140608 20:14:26< iceiceice_> if you want me to remember to use \n with the loggers that aren't wml_error, i guess i can try to do that
20140608 20:15:07< iceiceice_> but i also don't see any particularly compelling reason not to use std::endl
20140608 20:15:24< shadowm> std::endl is ugly and harder to write.
20140608 20:15:45< iceiceice_> fine you dont have to write it, i prefer to write it
20140608 20:15:57< iceiceice_> i dont think its ugly, i prefer because i know exactly what will happen
20140608 20:16:31< shadowm> I'd rather keep the code consistent and have us all adhere to one option or the other.
20140608 20:17:12< iceiceice_> ok well a few weeks ago at about the same time as this commit i systematically changed all error and warning level logs to terminate with std::endl
20140608 20:17:15< iceiceice_> on master branch
20140608 20:17:52< iceiceice_> b/c those levels of logging trigger strict mode whcih is used by the wml unit tests
20140608 20:17:54-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140608 20:17:58< iceiceice_> so i didnt want there to be any ambiguity about whether they happen
20140608 20:18:15< iceiceice_> logging to those triggers a wml unit test to fail
20140608 20:18:48< iceiceice_> i didnt think that this woudl be an issue
20140608 20:19:12< iceiceice_> https://github.com/wesnoth/wesnoth/commit/3c9844889bab027653c588f75bddbf94f6232c4b
20140608 20:19:16< iceiceice_> https://github.com/wesnoth/wesnoth/commit/03a956d05ce08b0f4da37c07c268dae016b08936
20140608 20:19:34< mordante> iceiceice_, as stated in the documentation of wml_error they should be shown after the event completes
20140608 20:20:40< iceiceice_> why is that a good idea?
20140608 20:20:49< iceiceice_> what if there is segfault before the event completes
20140608 20:21:26< iceiceice_> and then a dev mistakenly assumes the sefault is before logging and not after?
20140608 20:22:31< mordante> because that error is supposed to be shown in a dialogue if possible to the WML author can be warned
20140608 20:23:00< mordante> so it is /not/ a generic logger
20140608 20:23:06< iceiceice_> i think it goes to console also thouh?
20140608 20:23:49< shadowm> Had I remembered that wml_error existed, I'd have chosen a different name for gui2::twml_error.
20140608 20:25:00< shadowm> Reading this conversation is rather confusing while I'm dealing with the decision chain leading to the latter. Anyway, it seems the problem lies within config_cache::read_configs() after all, it's just that Wesnoth proceeded to read from the malformed WML cache on my next run with the catch disabled.
20140608 20:25:09< mordante> iceiceice_, also but they are supposed to be buffered and I doubt your endl change changed that part
20140608 20:25:53< iceiceice_> i remember i was writing a test which used do_command,
20140608 20:26:06< iceiceice_> it wasn't working, and i couldn't get logging output until i used std::endl
20140608 20:26:13< iceiceice_> i didn't add all the endl's for fun
20140608 20:26:24< iceiceice_> maybe theres a bug in the logging mechanism somewhere idk
20140608 20:26:45< mordante> or you changed your std::cerr to be buffered
20140608 20:26:53< mordante> IDK
20140608 20:26:53< iceiceice_> using 2>  will dot hat?
20140608 20:27:58< iceiceice_> that is how all the unit tests run currently
20140608 20:28:30< mordante> no that should not change it
20140608 20:29:45< shadowm> iceiceice_: More to the point, what should we do about this issue with WML load errors being caught down the stack before the game_config_manager methods?
20140608 20:30:22< shadowm> This is a rather serious issue because Wesnoth is essentially being fed half-parsed garbage.
20140608 20:30:39< iceiceice_> idk rethrow them?
20140608 20:30:54< shadowm> Don't tell me "I don't know" because you made the change.
20140608 20:31:22< iceiceice_> ok i would suggest to rethrow
20140608 20:31:34-!- trewe [~trewe@2001:8a0:d138:6a01:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20140608 20:31:45< shadowm> How is that different from not catching the exception in the config cache method?
20140608 20:31:59< iceiceice_> some other programmer in the future won't be confused about whther it is an uncaught exception?
20140608 20:32:09< shadowm> All that handler does is print a message to stderr which I do not want because it defeats the point of several of my previous changes.
20140608 20:32:35< iceiceice_> i guess could put a line comment at the end fo the read "this is supposed to throw config::error and be caught (5 functions back up the call stack at X)
20140608 20:32:36< shadowm> If there is a case where the exception needs to be caught upstream then that is what should be done instead.
20140608 20:32:37< iceiceice_> "
20140608 20:32:52< shadowm> So tell me, what prompted the catch?
20140608 20:33:06< iceiceice_> i saw that in game.cpp the -p error 
20140608 20:33:09< iceiceice_> had an uncaught exception
20140608 20:33:19< shadowm> Then the implementation of -p should deal with it.
20140608 20:33:24< iceiceice_> so i fixed and looked for similar instances
20140608 20:33:31< iceiceice_> apparently i got confused on this other case and made a mistake
20140608 20:34:20< iceiceice_> it would be much easier if there were explicit comments saying where exceptions should and should not be thrown
20140608 20:34:31< shadowm> Should I revert the entire commit then, or just remove the try-catch in config_cache::read_configs()?
20140608 20:34:36< iceiceice_> normally in a large programming project each function is supposed to explicitly declare
20140608 20:34:45< iceiceice_> with a comment what it throws and isn't suppsoed to throw
20140608 20:35:19< iceiceice_> i would suggest to just delete the try catch and put a comment that the line is supposed to throw and be caught at what ever place you have in mind
20140608 20:35:25< iceiceice_> or that the function is supposed to throw etc.
20140608 20:35:39< shadowm> It's not the function per se that's supposed to throw.
20140608 20:35:53< iceiceice_> well if it does and it isn't declared, someone might think its a bug
20140608 20:36:03< shadowm> Anything that involves loading WML can throw config::error (and/or preproc_error if it calls the preprocessor).
20140608 20:36:13< iceiceice_> hmm well maybe that should be documented somewhere
20140608 20:36:36< iceiceice_> since i found another case where such a function was throwing uncaught
20140608 20:36:42< mordante> I'm off bye
20140608 20:36:59-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140608 20:37:13< iceiceice_> idk what you guys would like to do with std::endl, you can revert my commits if you like
20140608 20:37:49< iceiceice_> i really didn't think anyone would have an issue with that
20140608 20:37:50< shadowm> I'll leave it to mordante but I personally don't want to make unnecessary use of std::endl.
20140608 20:40:04< shadowm> This commit has an equivalent in master, right?
20140608 20:40:11< iceiceice_> i believe so
20140608 20:42:45< iceiceice_> mordante: if you guys decide to revert all the std::endl introductions, 
20140608 20:42:49< iceiceice_> most of them are on may 20'th i think
20140608 20:45:51< shadowm> I'm curious how else you expected WML parser errors to be caught and presented to the user. :p
20140608 20:46:14-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140608 20:48:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140608 20:48:13-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140608 20:51:24< iceiceice_> shadowm: idk i think i tested my commit... apparently not well enough :/
20140608 20:51:59< iceiceice_> do you want to fix the erroneous catch or do you want me to?
20140608 20:52:07< shadowm> I'm already writing the commit message.
20140608 20:56:33< iceiceice_> thanks
20140608 20:56:45< iceiceice_> sorry for causing the bug
20140608 21:07:56-!- Bodhi-Baum [~Bodhi@dslb-084-063-032-176.pools.arcor-ip.net] has joined #wesnoth-dev
20140608 21:08:39-!- Bodhi-Baum [~Bodhi@dslb-084-063-032-176.pools.arcor-ip.net] has quit [Remote host closed the connection]
20140608 21:10:10< happygrue> fabi: I am a bit confused about this terrian issue.  Is the problem some (fairly) recent change, or is it that we never noticed the issue until now?
20140608 21:10:12< irker413> wesnoth: Ignacio R. Morelle wesnoth:master f7c34dfaad55 / src/config_cache.cpp: Don't catch config::error in config_cache::read_configs() http://git.io/F4XeEg
20140608 21:10:15< irker413> wesnoth: Ignacio R. Morelle wesnoth:1.12 0751431d7d31 / RELEASE_NOTES changelog players_changelog src/config_cache.cpp: Don't catch config::error in config_cache::read_configs() http://git.io/aiGwaw
20140608 21:10:18< irker413> wesnoth: Ignacio R. Morelle wesnoth:1.12 56defec6bb76 / changelog: Rearrange Editor changelog entries and change header http://git.io/sesI8g
20140608 21:11:33-!- gfgtdf_ [~chatzilla@f054157094.adsl.alicedsl.de] has joined #wesnoth-dev
20140608 21:11:44< happygrue> Perhaps what we need to do is rethink the terrian rules and try to work this out so that we don't need feral or any other crazy work arounds, but from what I can see so far in the log I think we should leave everything as is for stable and start this process in 1.13
20140608 21:12:18< shadowm> Wheee I forgot to change the culprit hash for the 1.12 version of that commit.
20140608 21:12:32< shadowm> Oh well.
20140608 21:13:32-!- gfgtdf [~chatzilla@e177179220.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20140608 21:13:43-!- gfgtdf_ is now known as gfgtdf
20140608 21:18:59< fabi> happygrue: hello
20140608 21:19:32-!- Sulfur [~Miranda@p5B009E8D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140608 21:19:37< shadowm> Wesnoth 2.0 the Gameplay Rules Update confirmed!
20140608 21:19:40< happygrue> hi fabi
20140608 21:19:58< fabi> happygrue: I hope that I got all the knowledge to handle the issue in the meantime, or at least to speak about it properly.
20140608 21:20:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 21:21:21< fabi> happygrue: The problem is that since we started with forest terrains being overlays a part of the terrain was pure forest while the new terrains were always forest/flat.
20140608 21:21:49< fabi> happygrue: With the 1.12 release every forest terrain will be overlayed, thus always forest/flat.
20140608 21:22:23< zookeeper> happygrue, the history is that both villages and forests used to _not_ be overlays. so once they were made into overlays, regular villages became flat+village, so bats would have used flat defense instead of village defense (because their flat defense is better), so feral is the workaround for that.
20140608 21:22:58< happygrue> yes, I recall that mess.  Still on the list of things we could do better
20140608 21:23:07< fabi> happygrue: And the workaround for cavalry is the "-70" value for forest defense in their movetype.
20140608 21:23:08< happygrue> (feral that is)
20140608 21:23:08< zookeeper> and same with forests for cavalry; regular forests became flat+forest, so cavalry would get 40% there instead of the old 30%... hence their movetype got an exception capping them to 30% in forests regardless of base terrain.
20140608 21:23:41< happygrue> okay, and that is already implemented and working?
20140608 21:23:46< zookeeper> yes
20140608 21:24:02< fabi> happygrue: But the problem repeats with fungus terrain.
20140608 21:24:06< zookeeper> it's just a sort of an invisible hack, not an explained one like feral is
20140608 21:24:55< fabi> And Velensk seems to have discovered more problems.
20140608 21:25:27< zookeeper> it's an unfortunate big mess which we can't have solved in a proper way because it'd affect balancing
20140608 21:25:39< happygrue> I see
20140608 21:25:47< zookeeper> apparently 50% for bats in villages was not acceptable, and same for 40% for cavalry in forests
20140608 21:25:57< zookeeper> err, s/50/60 i guess
20140608 21:26:06< happygrue> I have to go for a bit, I'll be back later. and read up
20140608 21:26:19-!- mjs-de [~mjs-de@p508CBC52.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20140608 21:29:01-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20140608 21:29:47-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 245 seconds]
20140608 21:37:02-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Changing host]
20140608 21:37:02-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20140608 21:38:17< fabi> happygrue: I suggest we follow the advice of Velensk and check all the terrain for such problems. At least the fungus terrain needs a similar solution for the "mounted" movetype.
20140608 21:39:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 21:40:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140608 21:46:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140608 21:48:42< fabi> happygrue: Later, the unit description page can be enhanced to inform the user about the issue. 
20140608 21:50:31< fabi> Why and since when are all orbs magenta colored? Or is it just my copy?
20140608 21:56:16< shadowm> master or 1.12?
20140608 21:58:23< fabi> 1.12
20140608 21:59:06< shadowm> I only saw the issue for some time in master after the 1.12 branch was created, but I don't get anything unusual anymore with either branch.
20140608 22:00:04< fabi> Delete your preferences file.
20140608 22:00:15< shadowm> I used wesnoth-defaults to check.
20140608 22:00:20< fabi> Or move it away
20140608 22:00:46< shadowm> That means Wesnoth doesn't read from my preferences dir.
20140608 22:06:56< fabi> The newly written preferences file contains so many attributes with only empty strings values. This does not look right.
20140608 22:10:01< shadowm> https://dl.dropboxusercontent.com/u/21371130/junk/wesnoth-1.10-default-prefs
20140608 22:10:06< shadowm> https://dl.dropboxusercontent.com/u/21371130/junk/wesnoth-1.13-default-prefs
20140608 22:12:56< shadowm> If you run either until just the titlescreen, the files end up identical except for the addition of a wml_tree_root option in 1.13.
20140608 22:13:15< shadowm> I fail to see the issue. It only shows that the preferences writer is working as intended.
20140608 22:14:11< shadowm> Besides, I'm sure you have seen this a lot while working on the hotkeys code in 1.11.x. ;)
20140608 22:14:29< fabi> moved_orb_color=""
20140608 22:15:00< gfgtdf> does anyonw know why we have a [carryover_sides_start] in mod scenario savegames ?
20140608 22:15:04< gfgtdf> anyone*
20140608 22:15:21< shadowm> Most preferences options work on a "the value set by the user or a default if it's empty", don't they?
20140608 22:15:30< shadowm> *" basis, 
20140608 22:15:53< gfgtdf> s/mod/mid
20140608 22:18:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20140608 22:19:38< fabi> shadowm: I hope the problems I experience are caused by using a 1.12 binary with a 1.13 config.
20140608 22:20:55< shadowm> Hm, no, that also looks fine to me.
20140608 22:21:07< shadowm> Not that it's a good idea to do that.
20140608 22:21:45< shadowm> fabi: Was it you who once suggested to me to have a way to detect and import configuration from previous versions?
20140608 22:21:57< fabi> yes
20140608 22:22:09< shadowm> Is there an FR filed for that?
20140608 22:23:56< fabi> no
20140608 22:24:11< fabi> You did not seem to like the idea back then.
20140608 22:24:33< shadowm> I'll have to make a note to check my logs again later.
20140608 22:38:34-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140608 22:51:40< irker413> wesnoth: gfgtdf wesnoth:master bbcae1c14eef / src/savegame.hpp: remove unused function http://git.io/HlG3Ww
20140608 23:03:23< irker413> wesnoth: gfgtdf wesnoth:master 6f0fbc58fb57 / src/synced_commands.cpp: change a warning log message. http://git.io/KgdLlA
20140608 23:29:29-!- trewe [~trewe@2001:8a0:d138:6a01:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20140608 23:36:48-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140608 23:37:41< iceiceice> aquileia: is PR 198 ready to merge?
20140608 23:39:00< irker413> wesnoth: Chris Beck wesnoth:master 358531e06c7d / src/ (game_board.hpp menu_events.cpp menu_events.hpp play_controller.cpp): menu handler uses game_board in it's constructor http://git.io/SfR5gg
20140608 23:39:02< irker413> wesnoth: Chris Beck wesnoth:master 39c8aab076c5 / src/ (game_board.cpp game_board.hpp): add variants of "find visible unit" to game_board http://git.io/Jjwo3A
20140608 23:39:04< irker413> wesnoth: Chris Beck wesnoth:master 49a7d0b14047 / src/ (config_cache.cpp savegame.hpp synced_commands.cpp): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/PjLEJA
20140608 23:39:37-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140608 23:42:56-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 260 seconds]
20140608 23:57:51-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140608 23:58:34< aquileia> iceiceice: Both 198 and 199 are ready
20140608 23:59:14< irker413> wesnoth: aquileia wesnoth:master 32212f71ddf7 / projectfiles/VC9/WML_tests.cmd: Windows WML Tests: Add total duration to output http://git.io/DkrkQA
20140608 23:59:16< irker413> wesnoth: Chris Beck wesnoth:master ea26ebdd4adf / projectfiles/VC9/WML_tests.cmd: Merge pull request #198 from aquileia/VC_update http://git.io/q4Wf-A
20140608 23:59:50< iceiceice> hmm i guess maybe someone other than me should review 199?
--- Log closed Mon Jun 09 00:00:02 2014