--- Log opened Fri Jun 13 00:00:14 2014
20140613 00:00:17-!- travis-ci [~travis-ci@ec2-54-205-63-188.compute-1.amazonaws.com] has joined #wesnoth-dev
20140613 00:00:17< travis-ci> [travis-ci] wesnoth/wesnoth#3134 (master - 912456b : Ignacio R. Morelle): The build passed.
20140613 00:00:17< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27445715
20140613 00:00:17-!- travis-ci [~travis-ci@ec2-54-205-63-188.compute-1.amazonaws.com] has left #wesnoth-dev []
20140613 00:00:20< shadowm> Probably not.
20140613 00:01:52< happygrue> Necrosporus: what happens when you play on hard?
20140613 00:02:01< iceiceice_> Necrosporus: ladder is much more tactical, campaign requires you to play with a much larger horizon / scope
20140613 00:02:27< iceiceice_> idk im not expert in either, i probably shouldn't comment but that's my impression
20140613 00:08:45-!- Haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Read error: Connection reset by peer]
20140613 00:22:45< gfgtdf> iceiceice_: do you know why we set modifications variables via events and not directly with vaiables ?
20140613 00:22:53< iceiceice_> no
20140613 00:26:08< gfgtdf> iceiceice_: i think implementign it as variables would be easier to implement and also has the advantage that they'd be available in prestart/preload events to
20140613 00:27:20< iceiceice_> i know very little about how it works, you might want to ask lipkab?
20140613 00:27:27< iceiceice_> but it sounds like a good idea
20140613 00:28:08< gfgtdf> wesnoth: sel likab
20140613 00:28:12< gfgtdf> wesnoth: seen likab
20140613 00:28:20< gfgtdf> wesbot: seen lipkab
20140613 00:28:20< wesbot> gfgtdf: The person with the nick lipkab last spoke 1d 5h ago.  10h 13m ago was here and on the channel #wesnoth with the message: Ping timeout: 244 seconds
20140613 00:29:56-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140613 00:31:26-!- travis-ci [~travis-ci@ec2-54-205-164-255.compute-1.amazonaws.com] has joined #wesnoth-dev
20140613 00:31:26< travis-ci> [travis-ci] wesnoth/wesnoth#3135 (master - 62eb55a : Ignacio R. Morelle): The build passed.
20140613 00:31:26< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27446013
20140613 00:31:26-!- travis-ci [~travis-ci@ec2-54-205-164-255.compute-1.amazonaws.com] has left #wesnoth-dev []
20140613 00:33:29-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140613 00:33:40-!- travis-ci [~travis-ci@ec2-54-205-63-188.compute-1.amazonaws.com] has joined #wesnoth-dev
20140613 00:33:40< travis-ci> [travis-ci] gfgtdf/wesnoth-old#138 (gamestate_refactor - c1edcbb : gfgtdf): The build is still failing.
20140613 00:33:40< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/27452287
20140613 00:33:40-!- travis-ci [~travis-ci@ec2-54-205-63-188.compute-1.amazonaws.com] has left #wesnoth-dev []
20140613 00:40:36< gfgtdf> iceiceice_: do you know what hat message in teh wml tests of teh travis above mena s?
20140613 00:41:47< iceiceice_> if you click on "travis_after_failure.sh" tab to expand it, it shows you waht errors it captured:
20140613 00:41:48< iceiceice_> wesnoth: src/game_display.cpp:992: void game_display::set_team(size_t, bool): Assertion `teamindex < dc_->teams().size()' failed.
20140613 00:42:32< gfgtdf> iceiceice_: can it give me a strcktrace ?
20140613 00:42:41< iceiceice_> no b/c its not a debug build
20140613 00:43:35< gfgtdf> iceiceice_: since this appears on all scenarios i assume this is rather somethign related to no desplay mode than to the thing that is tested in teh test
20140613 00:43:54< iceiceice_> hmm so i think that the game_display object is always constructed even in the no display mode
20140613 00:43:59< iceiceice_> because its required for saving
20140613 00:44:33< irker485> wesnoth: Chris Beck wesnoth:master 4406cdfae078 / src/display.hpp: add accessors for selected, moused-over hex to class display http://git.io/W8280Q
20140613 00:44:35< irker485> wesnoth: Chris Beck wesnoth:master 5145c9422c2d / src/ (8 files in 3 dirs): display takes a pointer to whiteboard manager http://git.io/8PQmLg
20140613 00:44:37< irker485> wesnoth: Chris Beck wesnoth:master 7078dd34e61b / src/reports.cpp: purge a useless "report()" function in reports.cpp http://git.io/-lTiPw
20140613 00:44:38< irker485> wesnoth: Chris Beck wesnoth:master 8faa4bf059f7 / src/ (display.cpp reports.cpp reports.hpp scripting/lua.cpp): refactor reports to take display_context as an argument http://git.io/AupHlw
20140613 00:44:41< irker485> wesnoth: Chris Beck wesnoth:master f4754496d3ae / src/display.hpp: remove unnecessary (duplicated) accessors http://git.io/TAKLqQ
20140613 00:44:42< irker485> wesnoth: Chris Beck wesnoth:master 2a2a50a1788b / src/ (play_controller.cpp resources.cpp resources.hpp): make whiteboard a shared_pointer in resources http://git.io/6p6C2A
20140613 00:44:45< irker485> wesnoth: Chris Beck wesnoth:master 816be79aa2c4 / src/ (display.cpp reports.cpp reports.hpp scripting/lua.cpp): add reports::context structure, and use it for reports http://git.io/Xzl2xA
20140613 00:44:46< irker485> wesnoth: Chris Beck wesnoth:master dd8e0159f90a / src/ (display.cpp reports.cpp reports.hpp scripting/lua.cpp): add tod manager to report::context http://git.io/eZXtlg
20140613 00:44:49< irker485> wesnoth: Chris Beck wesnoth:master 89c22a827982 / src/ (display.hpp reports.cpp): add virtual fcns to display, remove refs to game_display in reports http://git.io/gpbXDA
20140613 00:44:50< irker485> wesnoth: Chris Beck wesnoth:master 2c312a11ef02 / src/ (13 files in 4 dirs): Merge branch 'refactor_reports' http://git.io/nYflLg
20140613 00:49:45< gfgtdf> lipkab, thunderstruck: do you know why we add the mp era/modification events in [modifcation][event] and add them to the game in play_controler cpp insted of direct writing [event]s into teh scenario ?
20140613 00:52:34< irker485> wesnoth: Chris Beck wesnoth:master b1356923797d / src/reports.hpp: remove some unnecessary includes in header http://git.io/ggZJyQ
20140613 00:52:58-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140613 00:54:47-!- travis-ci [~travis-ci@ec2-54-205-164-255.compute-1.amazonaws.com] has joined #wesnoth-dev
20140613 00:54:47< travis-ci> [travis-ci] gfgtdf/wesnoth-old#139 (gamestate_refactor - 1d8a058 : gfgtdf): The build is still failing.
20140613 00:54:47< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/27452952
20140613 00:54:47-!- travis-ci [~travis-ci@ec2-54-205-164-255.compute-1.amazonaws.com] has left #wesnoth-dev []
20140613 00:55:28< gfgtdf> iceiceice_: whta is teh best was to add putput that  can see in travis builds ?
20140613 00:56:09< iceiceice_> hmm
20140613 00:56:12< iceiceice_> i mean std::cerr will not fail
20140613 00:56:19< iceiceice_> but i think writing to any logger should give output?
20140613 00:56:39< gfgtdf> the log debug is enabled ?
20140613 00:56:46< iceiceice_> maybe just error and warning
20140613 00:56:59< iceiceice_> i think log debug is not enabled
20140613 00:58:02< iceiceice_> i mean you can also just run the wml unit tests locally
20140613 00:58:07< iceiceice_> you dont need to do it on travis
20140613 00:59:41< gfgtdf> iceiceice_: do the wml test require any new c++ files ?
20140613 01:00:07< iceiceice_> no
20140613 01:00:29< iceiceice_> if you want to run with the timeout you need to build aquileia's thing
20140613 01:00:37< iceiceice_> but if you are just trying to debug assertion failure
20140613 01:01:03< iceiceice_> y so travis doesnt give the verbose expression anymore 
20140613 01:01:04< iceiceice_> but its like
20140613 01:01:10< iceiceice_> wesnoth -u test_return --showgui
20140613 01:01:16< iceiceice_> or, put the test that failed there
20140613 01:02:20< gfgtdf> iceiceice_: worked ty :)
20140613 01:04:02< gfgtdf> iceiceice_: so teh unit_tst use twh replay controller ?
20140613 01:04:05< gfgtdf> use*
20140613 01:04:14< iceiceice_> the first part uses the single controller
20140613 01:04:19< iceiceice_> the replay part uses the replay controller
20140613 01:08:10< gfgtdf> ok it seems liek the problem was that i wrote "replay" instead of "replay_start" somewhere
20140613 01:08:40-!- travis-ci [~travis-ci@ec2-54-205-164-255.compute-1.amazonaws.com] has joined #wesnoth-dev
20140613 01:08:40< travis-ci> [travis-ci] gfgtdf/wesnoth-old#140 (gamestate_refactor - e21da6f : gfgtdf): The build is still failing.
20140613 01:08:40< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/27453587
20140613 01:08:40-!- travis-ci [~travis-ci@ec2-54-205-164-255.compute-1.amazonaws.com] has left #wesnoth-dev []
20140613 01:08:50-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 244 seconds]
20140613 01:31:12-!- sachith500 [~kvirc@112.134.75.56] has joined #wesnoth-dev
20140613 01:37:08-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140613 01:38:57< Spoffy> Having a weird issue with latest master not being able initialize fonts. Anyone else?
20140613 01:45:28-!- groggy [~chatzilla@96-37-252-169.dhcp.leds.al.charter.com] has joined #wesnoth-dev
20140613 01:45:47< iceiceice_> idk it was reported on forums
20140613 01:46:19< Spoffy> Not sure if C++ or build scripts again.
20140613 01:47:00< Spoffy> It's annoying, I just want to test whether my merge of master + asio_umcd worked, but I can't because master doesn't build for me, or there's an issue with the fonts... *sighs*
20140613 01:47:15< Spoffy> Guess I'm patching these first :P
20140613 01:48:39< Spoffy> iceiceice_: Got a link to the thread?
20140613 01:49:14< irker485> wesnoth: Chris Beck wesnoth:master a5b9489e13cb / src/ (9 files in 4 dirs): refactor tod_manager::get_illuminated_tod to take map as an arg http://git.io/0KDgHg
20140613 01:49:34< iceiceice_> http://forums.wesnoth.org/viewtopic.php?f=4&t=40546
20140613 01:50:02< iceiceice_> http://forums.wesnoth.org/viewtopic.php?f=5&t=40543&p=571655#p571655
20140613 01:51:43-!- groggy [~chatzilla@96-37-252-169.dhcp.leds.al.charter.com] has quit [Remote host closed the connection]
20140613 01:51:58< Spoffy> Well, at least it's not just me. Shame there isn't more info on it. Links much appreciated iceiceice_
20140613 01:57:43-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140613 01:57:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20140613 01:59:12-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20140613 02:00:13-!- travis-ci [~travis-ci@ec2-54-196-211-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20140613 02:00:13< travis-ci> [travis-ci] gfgtdf/wesnoth-old#143 (gamestate_refactor - a198b40 : gfgtdf): The build passed.
20140613 02:00:13< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/27456041
20140613 02:00:13-!- travis-ci [~travis-ci@ec2-54-196-211-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20140613 02:04:39< gfgtdf> finaly it passed :)
20140613 02:04:43< iceiceice_> hehe
20140613 02:05:27< gfgtdf> iceiceice_: do you think adjusted map settings like turns or shoud sjoudl effect all scenarios in a campaign or just teh first one ?
20140613 02:05:33< gfgtdf> shroud*
20140613 02:05:46< iceiceice_> i think turns probly should not
20140613 02:05:49< iceiceice_> shroud is a tough call
20140613 02:06:10< iceiceice_> i guess probly should affect all
20140613 02:06:27< iceiceice_> idk
20140613 02:10:00-!- Ivanovic_ [~ivanovic@frnk-d93304eb.pool.mediaWays.net] has joined #wesnoth-dev
20140613 02:13:07-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds]
20140613 02:13:55-!- Ivanovic_ is now known as Ivanovic
20140613 02:20:35< irker485> wesnoth: Chris Beck wesnoth:master 80be563f1a2c / src/ (9 files in 4 dirs): refactor tod_manager::get_illuminated_tod to take unit_map as arg http://git.io/gl1t9g
20140613 02:31:27< shadowm> Spoffy: How are you trying to run Wesnoth and from where?
20140613 02:32:23< Spoffy> shadowm: cd wesnothdir; scons install ./temp; cd temp; ./bin/wesnoth
20140613 02:32:53< shadowm> You don't need to *install* Wesnoth to run it.
20140613 02:33:19< Spoffy> shadowm: Copying the files from the temp' dir up to the main wesnoth dir results in it working, which makes me think the build script is off.
20140613 02:33:28< shadowm> Also, since you are not running it from the root of the source tree, try passing it the path to that as the last argument in the command line.
20140613 02:33:47< Spoffy> Default scons doesn't generate the main wesnoth binary I don't believe? 
20140613 02:33:53< Spoffy> (just 'scons' on its own)
20140613 02:34:05< shadowm> It does, the default build targets are wesnothd and wesnoth.
20140613 02:35:53< Spoffy> Going to re-test default scons then. Also, shouldn't 'scons install 'dir'' mean that it works when run from that directory? (Conceptually at least, this would make sense?)
20140613 02:36:50< Spoffy> Yeah, passing it the wesnoth dir let it boot.
20140613 02:37:16< shadowm> Since I have not installed Wesnoth once in all these years working on it, I don't really know what scons install does or does not, and in fact I didn't know you could specify a path to install without using the prefix= option, which does set a C preprocessor symbol at compile-time to help Wesnoth know its installation path without external assistance.
20140613 02:37:47< Spoffy> Also, the font error messages are unhelpful, they don't actually tell you what file they can't open, just that 'Could not open file, could not initialize fonts'.
20140613 02:37:50< shadowm> What I do know is that you don't need to install it because it normally can autodetect its data dir: http://shadowm.rewound.net/blog/?p=212
20140613 02:39:08< shadowm> scons leaves the binaries it builds on the root of the source dir, so that would work out of the box on Linux. It's cmake that currently demands a less obvious layout to work with.
20140613 02:40:07< Spoffy> Urgh. CMake in master is currently erroring when linking SDL.
20140613 02:40:13< Spoffy> Not an issue with my libraries, scons does it fine.
20140613 02:40:38< Spoffy> SCons is a much nicer build tool.
20140613 02:52:50-!- gfgtdf [~chatzilla@d107250.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140613 02:57:46< shadowm> Wow @ the thread.
20140613 02:58:07< shadowm> Yes, everybody has experienced that issue, just not the people who decided to post there.
20140613 02:59:07< shadowm> I'll see if I can catch those errors somehow to point users in the right direction.
20140613 03:02:55< Spoffy> Sweet.
20140613 03:08:43-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140613 03:10:05< shadowm> iceiceice_: The bug tracker isn't an optimal location for website issues.
20140613 03:11:27< shadowm> The fact that you had to fill in the Version field for #22181 kind of shows how out of place those are there.
20140613 03:12:04-!- Guest9028 [~cib@p5DD23679.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140613 03:16:47-!- Guest9028 [~cib@p5DD23679.dip0.t-ipconnect.de] has quit [Client Quit]
20140613 03:17:03-!- cib_ [~cib@p5DD23679.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140613 03:33:33-!- sachith500 [~kvirc@112.134.75.56] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140613 03:41:26< irker485> wesnoth: Ignacio R. Morelle wesnoth:master 1b483bbf314c / src/font.cpp: Don't call preprocess_file() on an empty path if fonts.cfg can't be found http://git.io/mn3x9w
20140613 04:01:17-!- Spoffy [~chatzilla@152.78.175.8] has quit [Ping timeout: 272 seconds]
20140613 04:17:38< Necrosporus> And now it's too easy, even :droid won the scenario (after setting moves of Dacyn to 0 in order to avoid getting it killed)
20140613 04:22:48-!- Kexoth [~kex@93-137-15-159.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140613 04:23:34-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140613 04:53:45< irker485> wesnoth: Ignacio R. Morelle wesnoth:master 30f1e2536988 / changelog src/game.cpp: Suggest checking the data dir path when unable to initialize fonts http://git.io/Cye-0g
20140613 04:56:30< iceiceice_> shadowm: yeah i guess posting in website would have been better
20140613 04:56:41< irker485> wesnoth: Ignacio R. Morelle wesnoth:1.12 51f395e16dab / src/font.cpp: Don't call preprocess_file() on an empty path if fonts.cfg can't be found http://git.io/gMfHkw
20140613 04:56:44< irker485> wesnoth: Ignacio R. Morelle wesnoth:1.12 170bd82ba19b / changelog src/game.cpp: Suggest checking the data dir path when unable to initialize fonts http://git.io/BU4Mmw
20140613 04:56:51< shadowm> iceiceice_: Not really.
20140613 04:57:00< shadowm> Website is for user support, not dev talk.
20140613 04:59:47-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 252 seconds]
20140613 05:11:33< irker485> wesnoth: Ignacio R. Morelle wesnoth:master 75f1345ff235 / src/game.cpp: Add documentation for warn_early_init_failure() http://git.io/VsineA
20140613 05:11:49< irker485> wesnoth: Ignacio R. Morelle wesnoth:1.12 8cb7d9b6c240 / src/game.cpp: Add documentation for warn_early_init_failure() http://git.io/FP2rUA
20140613 05:19:22< irker485> wesnoth: Chris Beck wesnoth:master fe00d72dd2d3 / src/ (6 files in 2 dirs): refactor tod_manager::set_turn, next_turn, accept game_data arg http://git.io/J-YZ3g
20140613 05:19:24< irker485> wesnoth: Chris Beck wesnoth:master 8531ddeae59e / src/ (editor/map/map_context.cpp play_controller.cpp tod_manager.cpp tod_manager.hpp): add gamemap argument to tod_manager::add_time_area(config &c) http://git.io/f3RG3Q
20140613 05:19:26< irker485> wesnoth: Chris Beck wesnoth:master b339cc217af7 / changelog src/font.cpp src/game.cpp: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/vYluhQ
20140613 05:23:49-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140613 05:44:06< irker485> wesnoth: Chris Beck wesnoth:master 95749ec22b32 / src/ (display.cpp resources.cpp resources.hpp scripting/lua.cpp): remove resources::display_context http://git.io/p7AQQA
20140613 05:53:55-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20140613 05:55:52-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140613 05:57:10-!- Ivanovic [~ivanovic@frnk-d93304eb.pool.mediaWays.net] has quit [Changing host]
20140613 05:57:10-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140613 06:01:56< irker485> wesnoth: Chris Beck wesnoth:master 7df5aab23e9f / src/ (play_controller.cpp playsingle_controller.cpp): remove unnecessary resource:: ptr uses http://git.io/ZDmHAg
20140613 06:11:57-!- Kexoth [~kex@93-137-15-159.adsl.net.t-com.hr] has joined #wesnoth-dev
20140613 06:12:59-!- cib_ [~cib@p5DD23679.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140613 06:16:49-!- Kexoth [~kex@93-137-15-159.adsl.net.t-com.hr] has quit [Ping timeout: 272 seconds]
20140613 06:21:21-!- cib_ [~cib@p5DD23679.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140613 06:29:38-!- Sulfur [~Miranda@p5B008431.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140613 06:32:40-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 272 seconds]
20140613 06:36:02-!- cib_ [~cib@p5DD23679.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140613 06:39:00< irker485> wesnoth: Ignacio R. Morelle wesnoth:1.12 ee4a74af41d8 / changelog src/gui/dialogs/wml_error.cpp: gui2/twml_error: Ignore empty _info.cfg [info] title= attribute http://git.io/lInVog
20140613 06:39:03< irker485> wesnoth: Ignacio R. Morelle wesnoth:master c9c33660dd31 / changelog src/gui/dialogs/wml_error.cpp: gui2/twml_error: Ignore empty _info.cfg [info] title= attribute http://git.io/NNby7g
20140613 06:52:29-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140613 07:15:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140613 07:29:31-!- thunderstruck [~zaibotren@cpc7-cowc7-2-0-cust670.14-2.cable.virginm.net] has joined #wesnoth-dev
20140613 07:30:30< thunderstruck> 20140612 15:16:36< gfgtdf> thunderstruck: can you take  look at (you dont have to real all content it's mainly about commit message): https://github.com/gfgtdf/wesnoth-old/commit/8c2deec47997da36d2afe442ea4160ac5f877dd1
20140613 07:30:59< thunderstruck> Commit looks good (I didn't carefully check the code, though).
20140613 07:31:19-!- _8680_ [~8680@2002:4404:712c:0:50d8:d7aa:8db0:3e15] has quit [Ping timeout: 252 seconds]
20140613 07:31:37< thunderstruck> However, I'm wondering whether this would not clash with RiftWalker's work as he is about to start to merge SP and MP codepaths.
20140613 07:32:03< thunderstruck> 20140613 00:49:45< gfgtdf> lipkab, thunderstruck: do you know why we add the mp era/modification events in [modifcation][event] and add them to the game in play_controler cpp insted of direct writing [event]s into teh scenario ?
20140613 07:32:07< thunderstruck> No.
20140613 07:32:20-!- _8680_ [~8680@2002:4404:712c:0:481d:a07f:66:2a59] has joined #wesnoth-dev
20140613 07:35:56< Necrosporus> if I droid my side then when it wins I got defeat, is it OK?
20140613 07:38:05-!- _8680_ [~8680@2002:4404:712c:0:481d:a07f:66:2a59] has quit [Ping timeout: 264 seconds]
20140613 07:38:56-!- _8680_ [~8680@2002:4404:712c:0:d538:9566:87b6:8652] has joined #wesnoth-dev
20140613 07:44:02-!- cib_ [~cib@132.231.178.206] has joined #wesnoth-dev
20140613 07:51:27-!- cib_ [~cib@132.231.178.206] has quit [Ping timeout: 245 seconds]
20140613 07:55:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 264 seconds]
20140613 08:00:39-!- Kexoth [~kex@93-137-15-159.adsl.net.t-com.hr] has joined #wesnoth-dev
20140613 08:04:40-!- _8680_ [~8680@2002:4404:712c:0:d538:9566:87b6:8652] has quit [Ping timeout: 260 seconds]
20140613 08:05:12-!- Kexoth [~kex@93-137-15-159.adsl.net.t-com.hr] has quit [Ping timeout: 245 seconds]
20140613 08:05:35-!- _8680_ [~8680@2002:4404:712c:0:d5f4:c603:6f99:102d] has joined #wesnoth-dev
20140613 08:23:32-!- Kexoth [~kex@93-137-15-159.adsl.net.t-com.hr] has joined #wesnoth-dev
20140613 08:28:04-!- Kexoth [~kex@93-137-15-159.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140613 08:28:33-!- thunderstruck [~zaibotren@cpc7-cowc7-2-0-cust670.14-2.cable.virginm.net] has quit [Ping timeout: 272 seconds]
20140613 08:34:34-!- thunderstruck [~zaibotren@cpc7-cowc7-2-0-cust670.14-2.cable.virginm.net] has joined #wesnoth-dev
20140613 08:54:21-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140613 09:03:03-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20140613 09:15:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140613 09:18:44-!- Haudegen_ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140613 09:25:47-!- Haudegen_ is now known as Haudegen
20140613 09:31:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140613 09:32:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20140613 09:32:35-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140613 09:34:32< vultraz> Can we use a higher res icon for the Github page so it doesn't look blurry? 
20140613 09:39:23-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140613 09:47:14-!- mjs-de [~mjs-de@f048210113.adsl.alicedsl.de] has joined #wesnoth-dev
20140613 09:55:41-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140613 10:06:10-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140613 10:07:52-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140613 10:08:07< aquileia> zookeeper: While looking for a route the khalifa in tMotTT could take, I noticed that:
20140613 10:08:18< aquileia> At the curernt rate I guess most 1.12 users will see English map labels no matter what language they play.
20140613 10:08:26< aquileia> There are lots of localization overlays for the old map in the repo.
20140613 10:08:31< zookeeper> tMotTT?
20140613 10:09:00< aquileia> the march of the ten thousand, my project together with Wrathbow
20140613 10:09:22< zookeeper> ok
20140613 10:09:24< aquileia> at least that's the working title
20140613 10:10:07< zookeeper> and yes, it has less localization than the old map
20140613 10:10:39< aquileia> I'll say that, later on, legends would call it thus in glorification to the event; the actual number of mercs will be unnamed but lower
20140613 10:13:43< aquileia> So I'd suggest including https://github.com/wesnoth/resources/pull/1 and referencing it in next release's announcement (there's a paragraph for translators)
20140613 10:14:05< aquileia> not sure though whether the png's should be deleted
20140613 10:16:51< zookeeper> i don't know if i'm expected to say something, but i can't think of anything to say.
20140613 10:18:54< aquileia> I just thought it'd be nice to give them an additional incentive
20140613 10:20:18< zookeeper> yeah, see, i'm not following at all. what incentive?
20140613 10:23:25< aquileia> Sorry if I'm unclear. I wanted to say that the reminder to the translation teams that the map overlays should to be redone one day could help in speeding things up.
20140613 10:23:59< zookeeper> oh, sure.
20140613 10:24:30< aquileia> And the reference to the 'new' xcf files is as good a reason as any to put it in the release announcement
20140613 10:25:31< zookeeper> although arguably it's probably quite a bit less important than translating the actual text elsewhere, but a reminder certainly wouldn't hurt.
20140613 10:59:46-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140613 11:03:49-!- niraj [~niraj@122.161.61.200] has joined #wesnoth-dev
20140613 11:13:07-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140613 11:20:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140613 11:34:06-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Quit: Page closed]
20140613 11:35:45-!- Spoffy [~chatzilla@152.78.175.8] has joined #wesnoth-dev
20140613 11:38:41-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140613 11:45:13-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140613 11:46:55-!- sachith500 [~kvirc@112.135.89.248] has joined #wesnoth-dev
20140613 11:58:16-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140613 12:01:12-!- cib_ [~cib@132.231.178.7] has joined #wesnoth-dev
20140613 12:12:25-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140613 12:18:56-!- Sulfur [~Miranda@p5B008431.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140613 12:22:44-!- niraj [~niraj@122.161.61.200] has quit [Remote host closed the connection]
20140613 12:28:09-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20140613 12:29:05-!- sachith500 [~kvirc@112.135.89.248] has quit [Read error: Connection reset by peer]
20140613 12:29:20-!- sachith500 [~kvirc@112.135.89.248] has joined #wesnoth-dev
20140613 12:30:12-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Client Quit]
20140613 12:45:57-!- Sulfur [~Miranda@p5B008431.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140613 12:52:56< Spoffy> Can someone do me a favour, and try to build wesnoth master latest using cmake?
20140613 12:53:28< Spoffy> I want to double check this is actually a build-system before I try and patch something that may just be a config error.
20140613 12:53:35< Spoffy> build-system bug*
20140613 13:00:01-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20140613 13:14:39-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140613 13:32:23-!- cib_ [~cib@132.231.178.7] has quit [Ping timeout: 252 seconds]
20140613 13:32:35-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140613 13:38:55< irker485> wesnoth: Guorui Xi(Kevin) wesnoth:master fa5fce419cb4 / src/ai/manager.cpp: Fix mixed tabs and spaces http://git.io/dypFVg
20140613 13:40:54-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has joined #wesnoth-dev
20140613 13:42:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140613 13:45:18-!- ArcusT7 [~arcus@pc139.riednet.wh.tu-darmstadt.de] has quit [Ping timeout: 255 seconds]
20140613 13:58:18-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140613 13:59:25< Rhonda> I found a b0rked string in the manpages
20140613 13:59:32< Rhonda> msgid "path the path of the data directory and exits."
20140613 13:59:37< Rhonda> That can't be right  :)
20140613 13:59:41< Rhonda> "path the path"
20140613 14:00:21-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140613 14:00:21-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Changing host]
20140613 14:00:21-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140613 14:02:16-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Remote host closed the connection]
20140613 14:02:27-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140613 14:09:06-!- crend [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20140613 14:09:55-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 240 seconds]
20140613 14:10:14-!- crend is now known as Crendgrim
20140613 14:10:24-!- sachith500|2 [~kvirc@112.134.6.77] has joined #wesnoth-dev
20140613 14:13:08-!- sachith500 [~kvirc@112.135.89.248] has quit [Ping timeout: 244 seconds]
20140613 14:15:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140613 14:19:29-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140613 14:19:54-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140613 14:27:04< irker485> wesnoth: aquileia wesnoth:master 9b1fea031f51 / .gitignore: Restructure .gitignore file http://git.io/gzwLVA
20140613 14:27:07< irker485> wesnoth: aquileia wesnoth:master f30a332963c2 / .gitignore: gitignore: Restructure existing rules http://git.io/379cqA
20140613 14:27:08< irker485> wesnoth: aquileia wesnoth:master 88d3d76c1234 / .gitignore: gitignore: Keep README and COPYING files http://git.io/olYQHA
20140613 14:27:10< irker485> wesnoth: aquileia wesnoth:master cdd8b932ee6c / .gitignore: gitignore: Additional cmake rules http://git.io/na_5bw
20140613 14:27:13< irker485> wesnoth: aquileia wesnoth:master af9761fa81f2 / / (28 files in 28 dirs): gitignore: Merge rules from po/**/.gitignore files http://git.io/APYBOg
20140613 14:27:14< irker485> wesnoth: aquileia wesnoth:master 665a29744580 / po/ (26 files in 25 dirs): Remove unnecessary translation scripts http://git.io/rZ-t7g
20140613 14:27:17< irker485> wesnoth: aquileia wesnoth:master 05641062c8bd / / (83 files in 83 dirs): gitignore: Merge dozens of "Thumbs.db" rules http://git.io/ayJsbA
20140613 14:27:18< irker485> wesnoth: aquileia wesnoth:master 0abdaf7a96a9 / .gitignore: gitignore: Reduce number of false positives http://git.io/uA1NUw
20140613 14:27:21< irker485> wesnoth: aquileia wesnoth:master 15503ff27e46 / .gitignore: gitignore: Fix order of rules for Makefiles http://git.io/AWYYcA
20140613 14:27:23< irker485> wesnoth: aquileia wesnoth:master 5db587182d57 / .gitignore: gitignore: Block some extensions http://git.io/N9pwmA
20140613 14:27:25< irker485> wesnoth: aquileia wesnoth:master 1e9a50879552 / / (7 files in 7 dirs): gitignore: Merge rules from projectfiles/ http://git.io/qFJknQ
20140613 14:27:27< irker485> wesnoth: aquileia wesnoth:master 1715ab314591 / .gitignore data/lua/.gitignore scons/.gitignore utils/.gitignore: gitignore: Include more rules from subdirectories http://git.io/sGQn0g
20140613 14:27:29< irker485> wesnoth: aquileia wesnoth:master c19e729c6b59 / / (10 files in 10 dirs): gitignore: Merge rules from doc/ and data/tools http://git.io/GPRxhw
20140613 14:27:31< irker485> wesnoth: aquileia wesnoth:master ca1e632b627c / utils/wescamp_import: Remove remove-potcdate.sin from wescamp-import http://git.io/YHA1Ig
20140613 14:27:33< irker485> wesnoth: Alexander van Gessel wesnoth:master 07a6ba695e67 / / (155 files in 129 dirs): Merge pull request #199 from aquileia/ignore http://git.io/Gvx4RQ
20140613 14:28:44-!- crend [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20140613 14:29:34-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 240 seconds]
20140613 14:29:47-!- crend is now known as Crendgrim
20140613 14:33:16-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140613 14:39:40-!- Kexoth [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140613 14:59:18-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140613 15:02:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140613 15:07:26-!- cib [~cib@p5DD22D04.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140613 15:07:52-!- cib is now known as Guest22059
20140613 15:17:12-!- Guest22059 [~cib@p5DD22D04.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140613 15:20:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140613 15:22:07-!- sachith500|2 [~kvirc@112.134.6.77] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140613 15:24:42-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140613 15:26:45< aquileia> AI0867: thanks for merging
20140613 15:32:13< irker485> wesnoth: Chris Beck wesnoth:master fddd04366318 / src/play_controller.cpp: change unnecessary resources:: ptrs to local variable uses http://git.io/3eNHlg
20140613 15:32:15< irker485> wesnoth: Chris Beck wesnoth:master b36c4e60f1e5 / / (158 files in 131 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/qmG3Sw
20140613 15:33:23< irker485> wesnoth: Chris Beck wesnoth:master 63e33955833f / .gitignore: add callgrind output files to .gitignore http://git.io/oQRAgQ
20140613 15:44:32-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection reset by peer]
20140613 15:45:50-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140613 15:46:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140613 15:47:02-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Remote host closed the connection]
20140613 15:49:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140613 15:58:16-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140613 15:59:20-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140613 15:59:38-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140613 15:59:38-!- iceiceice_ [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Changing host]
20140613 15:59:38-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140613 16:00:08< irker485> wesnoth: Chris Beck wesnoth:master d2fe8d1e3f5d / src/serialization/parser.cpp: optimize parser http://git.io/ryVlVw
20140613 16:04:46-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140613 16:17:27-!- scimitar [~krishna@117.213.206.197] has joined #wesnoth-dev
20140613 16:19:17< scimitar> Hello all!
20140613 16:20:03-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140613 16:23:15-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds]
20140613 16:23:31-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has quit [Quit: leaving]
20140613 16:23:39< scimitar> Can someone help me with the cloning of Wesnoth source code? I executed  'git clone https://github.com/wesnoth/wesnoth.git' in the terminal, but the size is simply too high(>3 gigs). What's worse is that it cannot be interrupted and my ISP sucks. Neither can I download the .zip(400 MB) in one sitting 'cause my net gets disconnected way too often. How can I do this in a way that allows me to resume where I left off from?
20140613 16:27:05-!- Haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Remote host closed the connection]
20140613 16:28:24-!- Haudegen_ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140613 16:29:19-!- Haudegen_ is now known as Haudegen
20140613 16:34:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140613 16:35:10-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140613 16:35:30< AI0867> iceiceice_: how much does that improve runtimes?
20140613 16:38:34-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140613 16:39:56-!- Sulfur [~Miranda@p5B008431.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140613 16:41:41-!- noy [~Noy@184.69.143.198] has joined #wesnoth-dev
20140613 16:41:44-!- noy [~Noy@184.69.143.198] has quit [Changing host]
20140613 16:41:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140613 16:42:29-!- scimitar [~krishna@117.213.206.197] has quit [Ping timeout: 264 seconds]
20140613 16:53:38< iceiceice_> AI0867: after the change, valgrind reports that the % attributed to tokenizer::next_token() drops from 20% to 15%
20140613 16:54:12< iceiceice_> for wesnoth -u characterize_pathfinding_reach_1
20140613 16:57:43-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20140613 16:57:56-!- Ivanovic [~ivanovic@frnk-d93304eb.pool.mediaWays.net] has joined #wesnoth-dev
20140613 17:00:38< iceiceice_> AI0867: i guess i dont know what it means in terms of run times, as call grind doesn't measure that directly, it uses some idealized measurement
20140613 17:00:52< iceiceice_> i dont think the change could slow anything down though, and it made some noticeable improvement
20140613 17:01:15< iceiceice_> at least when using the tool
20140613 17:02:38-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140613 17:03:07-!- Haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Ping timeout: 245 seconds]
20140613 17:03:24-!- Ivanovic [~ivanovic@frnk-d93304eb.pool.mediaWays.net] has quit [Changing host]
20140613 17:03:24-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140613 17:11:59< AI0867> iceiceice_: well, there's runtimes in the various runscripts, I think
20140613 17:12:26< iceiceice_> i think i dont know where to find those
20140613 17:21:04< iceiceice_> AI0867: do you know about using scons to build wesnoth on windows?
20140613 17:21:26< iceiceice_> i am looking at the SConstruct script, it looks like we have a line there: 
20140613 17:21:26< iceiceice_> if env["PLATFORM"] == "win32":
20140613 17:21:27< iceiceice_>     env.Tool("mingw")
20140613 17:21:52< iceiceice_> so i guess we don't allow to use it with the visual studio compiler?
20140613 17:23:05-!- Spoffy [~chatzilla@152.78.175.8] has quit [Ping timeout: 272 seconds]
20140613 17:23:42-!- Samual [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 240 seconds]
20140613 17:23:51-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140613 17:23:53-!- Guest22059 [~cib@p5DD22D04.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140613 17:28:13-!- Haudegen [~quassel@213162068020.public.t-mobile.at] has joined #wesnoth-dev
20140613 17:28:37< loonycyborg> iceiceice_: simply because I don't test with it
20140613 17:28:55< iceiceice_> ok
20140613 17:29:04< iceiceice_> i think i may have given some bad advice on the forums in this thread:
20140613 17:29:05< loonycyborg> I don't have msvc installed, and don't have hdd space for it
20140613 17:29:33< iceiceice_> http://forums.wesnoth.org/viewtopic.php?f=5&t=40551
20140613 17:30:15< iceiceice_> i thought that scons should be expected to work and successfully build wesnoth on more or less any platform provided you have a c++ compiler and can configure it successfully, and get the dependencies in whatever way is appropriate to your platform
20140613 17:30:43< iceiceice_> but i guess thats not what we recommend, actually on the wiki we suggest to everyone that they should use ide's to build unless they are on unix
20140613 17:30:52< iceiceice_> http://wiki.wesnoth.org/Compilingwesnoth#Compiling_Wesnoth
20140613 17:32:53< AI0867> iceiceice_: I don't even know if you can do a proper command-line build using MSVC
20140613 17:33:42< AI0867> last time I looked into that, it turned out you can't do an object-by-object build, though that may have been incorrect
20140613 17:33:46< iceiceice_> AI0867: i saw some instructions on the scons website that seemed to suggest this? 
20140613 17:33:47< iceiceice_> http://www.scons.org/wiki/PlatformSpecificNotes#Visual_C.2B-.2B-
20140613 17:33:53< iceiceice_> maybe im wrong though
20140613 17:34:55< AI0867> it looks like my information is the bit that is wrong
20140613 17:35:18-!- Kexoth [~kex@93-137-12-32.adsl.net.t-com.hr] has joined #wesnoth-dev
20140613 17:51:12< iceiceice_> be back later
20140613 17:51:14-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140613 17:52:03-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20140613 18:04:55< loonycyborg> I replied to that posh, http://forums.wesnoth.org/viewtopic.php?f=5&t=40551&start=15#p571800
20140613 18:06:11-!- gfgtdf [~chatzilla@d107250.adsl.hansenet.de] has joined #wesnoth-dev
20140613 18:12:21-!- Haudegen [~quassel@213162068020.public.t-mobile.at] has quit [Ping timeout: 244 seconds]
20140613 18:21:34-!- Bodhi-Baum [~Bodhi@dslb-084-063-033-194.pools.arcor-ip.net] has joined #wesnoth-dev
20140613 18:22:18< gfgtdf> thunderstruck: do you know why here: https://github.com/wesnoth/wesnoth/blob/7154ab4609afb1524f96e87982aadd655b1cad80/src/multiplayer_connect_engine.cpp#L874 we update teh controllers before we adjust the controller values ("network" -> "human") ?
20140613 18:22:26-!- Spoffy [~chatzilla@152.78.175.8] has joined #wesnoth-dev
20140613 18:22:47< AI0867> mordante: http://hastebin.com/xuqiyebado
20140613 18:25:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140613 18:27:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has left #wesnoth-dev []
20140613 18:28:25-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140613 18:31:16-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Quit: riksteri]
20140613 18:32:18-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140613 18:35:26-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140613 18:35:50< mordante> servus
20140613 18:39:30< mordante> AI0867, do you have any context for the patch?
20140613 18:41:05< mordante> Spoffy, what linker errors do you get with CMake? Are you using SDL1.2 or SDL2 ?
20140613 18:43:07< Spoffy> mordante: SDL 1.2.15 I think, not sure. I traced it back to a badly configured CMake.
20140613 18:43:42< Spoffy> mordante: Bug doesn't occur if you pass ENABLE_TESTS=1 to CMake, as it then correctly builds all the libaries.
20140613 18:43:59< mordante> Spoffy, it just matters whether it's 1.2.x or 2.0.x
20140613 18:44:20< Spoffy> Gottit, definitely 1.2.x.
20140613 18:44:26< mordante> ok
20140613 18:45:36< Spoffy> wesnoth/src/CMakeLists.txt, line 1007 and below is where the dependencies go weird I believe.
20140613 18:47:30< mordante> I will have a look later today or tomorrow
20140613 18:47:47< mordante> guess I always compile with the tests enabled
20140613 18:49:16< Spoffy> Yeah, that's why I figured it hadn't been caught before.
20140613 18:49:33< Ivanovic> i also get cmake compile errors over here
20140613 18:49:39< mordante> and since there are no bug reports I didn't notice over here
20140613 18:49:45< mordante> Ivanovic, compile or linker errors?
20140613 18:49:47< Ivanovic> media-libs/libsdl-1.2.15-r5:0
20140613 18:49:48< Spoffy> Ivanovic: sdl::rect and thinks?
20140613 18:49:48< Ivanovic> linker
20140613 18:49:52< Spoffy> things*
20140613 18:50:58< Ivanovic> uhm, good question
20140613 18:51:05< Ivanovic> i just know that the log is *huge* with errors!
20140613 18:51:17< Spoffy> Have a quick look for create_rect
20140613 18:51:27< AI0867> mordante: er, detecting which screen we're on? Right now we're just unconditionally using display #0
20140613 18:51:29< Spoffy> If that pops up, it's probably the same bug.
20140613 18:51:53< mordante> yeah I fixed a bug in that area, but I guess not for all cases (guess I don't have all possible permutations enabled here)
20140613 18:53:08< mordante> AI0867, ok I assumed something like that, I'll have a look at it later… I have some other issues on my plate
20140613 18:54:17< Spoffy> Yeah, confirmed. Mark de Wever patched it in commit bb1b4071a6 "Fix some CMake linker problems", but didn't apply them to the non ENABLE_TESTS bit. I'm not actuallt 100% sure what the purpose of this if...else block is, as there's no obvious sign of any tests being built.
20140613 18:55:14< Ivanovic> Spoffy, mordante: this is the error i get: http://pastebin.com/rRsHUsUD
20140613 18:56:04< mordante> Spoffy, yup that's the commit
20140613 18:56:13< mordante> Ivanovic, thanks
20140613 18:56:28< Spoffy> Cool. Thanks for checking Ivanovic.
20140613 18:59:48< mordante> Spoffy, Ivanovic I'll ping you after I committed a fix
20140613 19:00:23< Spoffy> mordante: Great, thanks.
20140613 19:06:09< irker485> wesnoth: Mark de Wever wesnoth:master 152d50d5a830 / src/ (config.hpp game.cpp): Remove the wesconfig.h dependency from config.hpp. http://git.io/Tlapmg
20140613 19:09:13< irker485> wesnoth: Mark de Wever wesnoth:master 7b07dd34d441 / src/tools/sdl2/sdl2.cpp: Fix a compilation error in the SDL2 tool. http://git.io/gstK0w
20140613 19:12:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140613 19:13:33< irker485> wesnoth: mattsc wesnoth:master 4253b6b5fd48 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project http://git.io/1c6nRg
20140613 19:13:49-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140613 19:14:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140613 19:15:48-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Cheers]
20140613 19:16:01-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140613 19:16:37-!- Bodhi-Baum [~Bodhi@dslb-084-063-033-194.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140613 19:17:51-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140613 19:20:14-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140613 19:39:02< irker485> wesnoth: mattsc wesnoth:master dac6a2e152dc / data/campaigns/Son_Of_The_Black_Eye/scenarios/ (15_Civil_War.cfg 17_The_Human_Attack.cfg 18_Northern_Alliance.cfg): SotBE: minor rebalancing of scenarios 15, 17 and 18 http://git.io/6Odl7g
20140613 19:39:04< irker485> wesnoth: mattsc wesnoth:master 306bf0cce840 / changelog: Update changelog (and eliminate trailing spaces) http://git.io/crUVcg
20140613 19:40:41< irker485> wesnoth: mattsc wesnoth:1.12 054c96be2809 / data/campaigns/Son_Of_The_Black_Eye/scenarios/ (15_Civil_War.cfg 17_The_Human_Attack.cfg 18_Northern_Alliance.cfg): SotBE: minor rebalancing of scenarios 15, 17 and 18 http://git.io/nfpgTw
20140613 19:42:07< irker485> wesnoth: mattsc wesnoth:1.12 536458c2705a / changelog: Update changelog (and eliminate trailing spaces) http://git.io/Bm-dHw
20140613 19:46:49< mattsc> zookeeper, Turuk: with that ^ rebalancing of SotBE is complete on all difficulty levels (meaning specifically also on nightmare), as far as I am concerned.
20140613 19:48:28< mattsc> Turuk: a handful of changes to messages and objectives that cannot go into 1.12 because of the string freeze were discussed on the forums and in PMs.  Do you want to help with that (or do them) for 1.13?   :P 
20140613 19:56:22< irker485> wesnoth: Mark de Wever wesnoth:master 3f3461edbd88 / src/CMakeLists.txt: Fix some CMake linker problems. http://git.io/cCHQow
20140613 19:56:30< mordante> Spoffy, Ivanovic that should fix it ^
20140613 19:57:18< Spoffy> Thanks mordante
20140613 19:59:50< mordante> you're welcome
20140613 20:00:03< mordante> let me know if it doesn't fix it for you
20140613 20:00:31< mordante> I created a new cmake build and got the errors like Ivanovic did and this change fixed it
20140613 20:03:44< mordante> I'm off bye
20140613 20:04:24-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140613 20:05:38-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140613 20:09:37-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140613 20:11:21-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140613 20:11:21-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Client Quit]
20140613 20:18:44< iceiceice_> gfgtdf: do you know when i can start making changes to play controller?
20140613 20:18:52< iceiceice_> i would like to try to branch of the game_state object
20140613 20:19:17< iceiceice_> theres other things i can do in the meantime but that one is fairly important
20140613 20:20:30< gfgtdf> iceiceice_: what exactly do you want to do ?
20140613 20:20:50< iceiceice_> rename saved_game child from game_state to saved_game_
20140613 20:20:54< iceiceice_> the local variable name
20140613 20:20:56< iceiceice_> then,
20140613 20:21:10< iceiceice_> move some managers to be under a struct called game_state
20140613 20:21:21< iceiceice_> and slowly branch it off and start moving functionality from other places to there
20140613 20:21:33< iceiceice_> *branch it off to its own file
20140613 20:21:49< iceiceice_> i have a list of what things i think should fit under game_state
20140613 20:21:55< iceiceice_> on wiki
20140613 20:24:59< iceiceice_> if theres too much contention over play_controller right now i will wait, but id rather start to do this sooner rather than later before gsocs are too far underway
20140613 20:26:14-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140613 20:30:18< gfgtdf> iceiceice_: Idk, i'm currently waiting for an answer on 'why are mp options implemented they way they are implemented' from lipk. In general i think i have done most of the things i wanted to do but there is still needed testing. The you can see the 2 commits that'd most lilely cause merging conflicts here:  https://github.com/gfgtdf/wesnoth-old/commits/gamestate_refactor/src/playsingle_controller
20140613 20:30:19< gfgtdf> .cpp (yes playsingle controller not play_controller) so if you think it wont cause much merging conflics you can push
20140613 20:30:33< gfgtdf> bah irc cutted the link in the middle
20140613 20:30:44< iceiceice_> gfgtdf: ok i will wait
20140613 20:30:55< iceiceice_> i think im going to try to fix the unit pointers thing
20140613 20:32:05< irker485> wesnoth: Chris Beck wesnoth:master d7c2675c589d / src/serialization/ (parser.cpp tokenizer.cpp tokenizer.hpp): tokenizer debug code is disabled by default http://git.io/M5Sn3Q
20140613 20:32:07< irker485> wesnoth: Chris Beck wesnoth:master 36d59f764601 / src/ (unit_map.cpp unit_map.hpp): put unit_map debug mode compilation on its own define http://git.io/XV5ADw
20140613 20:32:09< irker485> wesnoth: Chris Beck wesnoth:master d1a4a52f40e2 / / (9 files in 5 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/FY0kIA
20140613 20:32:12< gfgtdf> iceiceice_: which unit pointer thign ?
20140613 20:32:25< iceiceice_> so we have these annoying bugs in the animation system
20140613 20:32:32< shadowm> iceiceice_: "Note: The commit message is unfortunately misleading --" ... Then rewrite the commit?
20140613 20:32:42< iceiceice_> shadowm: how do i do that?
20140613 20:33:05< iceiceice_> once its on master i cant rewrite afaik
20140613 20:33:06< gfgtdf> iceiceice_: with rebase, i think but of if you relada have pushed to maser
20140613 20:33:09< iceiceice_> yeah
20140613 20:33:31< shadowm> iceiceice_: Oh, right, I thought it was a PR.
20140613 20:33:33< iceiceice_> is there a better way to add a note like that than github comments?
20140613 20:33:50< iceiceice_> gfgtdf: the unit pointer thing is, 
20140613 20:33:51 * shadowm lets out a big sigh.
20140613 20:34:37< iceiceice_> the unit's each hold a pointer to their unit_animation object, it hink a scoped pointer
20140613 20:34:46< iceiceice_> and the animation also needs to have a pointer back to the unit
20140613 20:34:59< iceiceice_> however it cannot be a smart pointer because units are not owned by the animations
20140613 20:35:17< iceiceice_> units are owned in raw pointers by like, one of six different modules
20140613 20:36:03< iceiceice_> there's like, a complicated contract that mostly works as intended to transfer ownership between unit_map, recall list, lua, wml variables, fake_units list, fake_unit object in C++ function...
20140613 20:36:11< iceiceice_> but once in a while it doesn't work right
20140613 20:36:20< iceiceice_> if any of these modules destroys its unit before the animation is done,
20140613 20:36:23< iceiceice_> you crash with segfault
20140613 20:36:40< iceiceice_> you can reproduce by going to debug mode and clicking "kill" twice on the same unit very quickly
20140613 20:36:52< iceiceice_> or i guess Elvish Pillager reproduced using some complicated lua code
20140613 20:37:12< iceiceice_> so the idea is to use reference counting through the whole system
20140613 20:37:16< iceiceice_> so unit_pod will go away
20140613 20:37:20< iceiceice_> and be replaced with boost::shared_ptr
20140613 20:37:34< iceiceice_> the unit_map iterator wont change, just its implementation
20140613 20:37:37< gfgtdf> iceiceice_: by ref couting you mean boost_shard:ptr ?
20140613 20:37:39< iceiceice_> yeah
20140613 20:37:49< iceiceice_> the game_display fake units list has tow ork with shared pointers instead
20140613 20:37:56< iceiceice_> and lua unit needs to hold a shared pointer
20140613 20:37:58< iceiceice_> and whatever other places
20140613 20:38:01< RiftWalker> like boost shared pointers?
20140613 20:38:06< iceiceice_> then i guess unit animation will hold a weak poitner
20140613 20:38:09< gfgtdf> hi RiftWalker 
20140613 20:38:11< RiftWalker> yeah
20140613 20:38:17< shadowm> If the class isn't inherited from then you can safely remove the default destrutor implementation.
20140613 20:38:19< RiftWalker> good idea.
20140613 20:38:25< RiftWalker> hey gfgtdf 
20140613 20:38:27< shadowm> Referring to parser, that is.
20140613 20:38:49< gfgtdf> RiftWalker: i recently made a pr: https://github.com/wesnoth/wesnoth/pull/201 if not 100% compleded but it chages mp
20140613 20:40:12< gfgtdf> RiftWalker: i think you are also wokring on simiar isues so do you think this will cause conflicts ?
20140613 20:41:12< gfgtdf> RiftWalker: mergign conflicts
20140613 20:41:15< gfgtdf> merging*
20140613 20:41:42< gfgtdf> RiftWalker: do you have a publick github branch for what you are doing ?
20140613 20:42:58< RiftWalker> I think conflicts should be minimal from what i'm seeing. still reading though.
20140613 20:44:34-!- Haudegen [~quassel@178.115.128.160.wireless.dyn.drei.com] has joined #wesnoth-dev
20140613 20:44:43< shadowm> loonycyborg: Why do you use openmp for the official Windows builds? I thought we had concerns about its benefits and most of us on Linux weren't even building with it enabled at this time.
20140613 20:44:48-!- Blaze [bed5dfa2@gateway/web/freenode/ip.190.213.223.162] has joined #wesnoth-dev
20140613 20:44:54< RiftWalker> and yes, github.com/Rift-Walker/wesnoth
20140613 20:44:55< Blaze> good afternoon
20140613 20:45:05< shadowm> Hello there, Blaze.
20140613 20:45:06< Blaze> wesnoth creators
20140613 20:45:09< RiftWalker> Hello
20140613 20:45:12-!- Blaze is now known as Guest75140
20140613 20:45:31< shadowm> Best use a nick no-one else actually owns. ;)
20140613 20:45:31< Guest75140> let me just say you're game is awesome
20140613 20:45:46< Guest75140> okay
20140613 20:45:46< RiftWalker> I'm currently working on a pull request; the branch is scenario_define
20140613 20:46:01< Guest75140> i love playing it
20140613 20:46:24< Guest75140> i just read about your upgrades to battle for wesnoth
20140613 20:46:32< Guest75140> i also saw sprites
20140613 20:46:39< Guest75140> what do you guys mean by sprites
20140613 20:46:43< loonycyborg> shadowm: are you confusing it with libana? :P
20140613 20:46:52< Guest75140> no
20140613 20:46:58< loonycyborg> boucman told me to enable openmp and it worked fine so far
20140613 20:47:09< shadowm> loonycyborg: No, but okay.
20140613 20:47:25< Guest75140> does sprites mean that every time its battle mode, both characters will be on either side and fight 
20140613 20:47:38< Guest75140> they will have their own animations to battle?
20140613 20:47:48< shadowm> Guest75140: You probably mean spritesheets? That is the only thing that would be news in that front. We have used sprites ever since Wesnoth's development began in 2003.
20140613 20:48:19< Guest75140> yeah spritesheets
20140613 20:48:31< Guest75140> so is what i said sprite sheets
20140613 20:48:36< Guest75140> you mean like this: 
20140613 20:49:10< RiftWalker> They probably could have attack animations. It would be more complex config though, no?
20140613 20:49:19< Guest75140> http://www.feplanet.net/sprites-archive-battle-sheets/r/737
20140613 20:49:27< shadowm> Spritesheets would simply enable us to store collections of sprites in a single file instead of having one file for each sprite like we do at the moment. It's mostly a filesystem-oriented optimization and a small workflow change for artists.
20140613 20:49:44< Guest75140> so it wont be like up above link
20140613 20:50:14< shadowm> That'd be the same principle, actually.
20140613 20:50:44< Guest75140> ooh
20140613 20:50:54< Guest75140> wesnoth will be even greater now
20140613 20:51:10< shadowm> We already have animations since ages, though, it's just that every frame is its own sprite file instead of being all packed together.
20140613 20:51:11< Guest75140> cant wait to see merfolk's new spritesheets
20140613 20:51:21< RiftWalker> whoa
20140613 20:51:41< RiftWalker> new defines system makes startup soooooooo much faster
20140613 20:51:45< shadowm> The spritesheets project is just a change to the way sprites are stored. New art has always been developed separately from those code changes and it'll continue to be that way.
20140613 20:52:07< Guest75140> i'm still happy
20140613 20:52:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140613 20:55:47< gfgtdf> 	RiftWalker: in mp you mena ?
20140613 20:55:50< gfgtdf> mean*
20140613 20:58:33-!- Guest75140 [bed5dfa2@gateway/web/freenode/ip.190.213.223.162] has quit [Quit: Page closed]
20140613 21:00:40< shadowm> iceiceice_: Do you have any numbers for the results of the tokenizer composition optimization?
20140613 21:01:08< iceiceice_> yeah, see earlier in irc
20140613 21:01:48< shadowm> Right.
20140613 21:02:12< iceiceice_> callgrind suggests that the amount of work done under parser operator()() goes from 20% of overall to 15% of overall
20140613 21:02:54< shadowm> I assume you made sure there wasn't any input variance between runs.
20140613 21:04:17< gfgtdf> are there any drawbacks of this optimisation ?
20140613 21:04:28< shadowm> No, I'm just trying to understand how it works.
20140613 21:04:42< gfgtdf> k
20140613 21:06:30< shadowm> Because at first glance, both { T* foo; foo->bar(); } and { T foo; foo.bar(); } look to me like a call to a fixed-address function with a different value for 'this' that's in RAM. I suppose there's a memory caching detail at work there which goes beyond my basic understanding of low-level stuff.
20140613 21:07:17< shadowm> The resulting memory layout optimization is more evident, though.
20140613 21:07:22< Necrosporus> error ai/actions: Error #2007 (E_NOT_REACHED_DESTINATION) in full move by side 2 from location 3,11 to location 1,7
20140613 21:07:26< Necrosporus> What does it mean?
20140613 21:07:45< shadowm> (As long as we assume structure alignment isn't a concern, at least.)
20140613 21:08:44< Necrosporus> Is it bad enough to care?
20140613 21:09:25< shadowm> Your error? It probably means the AI made a mistaken assumption that proved wrong after it finished its move. In the worst case that means the AI made a strategical mistake.
20140613 21:10:01< shadowm> It'd be worth reporting as a bug anyway, if you have a recipe to reproduce it reliably every time.
20140613 21:10:23< mattsc> It means that the AI tried to move a unit from 3,11 to 1,7 and for some reason it did not work.  Running into a hidden unit might be one reason.
20140613 21:10:54< mattsc> It’s most likely not a bug and can be ignored.
20140613 21:11:01< Necrosporus> It is "capturing the ogres of EI"
20140613 21:11:16< Necrosporus> There were no hidden units
20140613 21:11:28< mattsc> that’s just one example
20140613 21:11:43< shadowm> mattsc: Scenarios are supposed to not generate errors or warnings of any kind, though. Making the code less verbose would be a valid fix if the behavior is intended.
20140613 21:12:08< shadowm> Every time a player finds such a message in stderr, they think "oooo, error, must report", and rightly so.
20140613 21:12:10< Necrosporus> I guess in this case there's fixed algo to move ogres away and AI gets this error if ogre runs into human?
20140613 21:12:54< mattsc> shadowm: I am writing my AIs so that these errors (hopefully) don’t happen.  But there are quite a few instances when the default AI throws these.  So avoiding these error would require changing things quite deeply in the AI code.
20140613 21:13:32< iceiceice_> Necrosporus: it means that the ai ordered a move but the result that happened wasn't expected
20140613 21:13:41< iceiceice_> so it means that something is wrong i think
20140613 21:13:43< mattsc> As for it being “intended”, I’m not sure that’s the word I would use ...
20140613 21:14:42< shadowm> mattsc: That probably means that they are definitely not undeserving of not having the "not a bug" qualification. :)
20140613 21:15:11< Necrosporus> Anyway there was non-default AI
20140613 21:16:01< mattsc> Necrosporus: yeah, that scenario now uses a custom AI that I wrote, so if it happened on an ogre move, it shouldn’t happen.
20140613 21:16:24< mattsc> If you have a savefile for which this happens reproducibly, could you PM it to me?
20140613 21:17:20< mattsc> shadowm: too many “not”s in that sentence …  :P  But, yes …
20140613 21:20:46< mattsc> Looking at it, three “not”s and an “un”, plus a “probably” _and_ a “definitely” all in the same short sentence.  That’s definitiely more sophisticated use of language than I can handle.  Probably.
20140613 21:21:03-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20140613 21:24:36< iceiceice_> shadowm: about the alignment thing
20140613 21:24:51< iceiceice_> i'm not sure if the alignment of the parser object is terribly important
20140613 21:24:58< iceiceice_> because we never have many of them at once afaict
20140613 21:25:00< c74d> Folding the negatives in “not undeserving of not having the "not a bug" qualification” from left to right… → “deserving of not having the "not a bug" qualification” → “deserving of having the "a bug" qualification”.
20140613 21:25:28< iceiceice_> and its not clear to me what hte alignment of it was before the change,
20140613 21:25:56-!- Haudegen [~quassel@178.115.128.160.wireless.dyn.drei.com] has quit [Ping timeout: 252 seconds]
20140613 21:26:07< RiftWalker> iceiceice: I have a question: you stated that your optimization saved millions of calls to new(), but i'm not seeing it. next_token() doesn't call new().
20140613 21:26:25< RiftWalker> Am i missing something?
20140613 21:27:21< Necrosporus> So the problem seem to happen when orges disappear at the edge of map
20140613 21:27:37< iceiceice_> Riftwalker: my commit message was wrong
20140613 21:27:43< RiftWalker> ah.
20140613 21:27:45< iceiceice_> i added a github comment
20140613 21:27:48< iceiceice_> after i realized
20140613 21:28:13< mattsc> Yes, it happens when the unit is killed in the moveto event.  There is nothing that can be done about that from the AI side.
20140613 21:28:35< mattsc> From the AI coding side, I mean.
20140613 21:28:39< RiftWalker> well, your change does make for more readable code.
20140613 21:28:44< mattsc> We could have the AI not produce the error, I guess.
20140613 21:28:49< Necrosporus> mattsc, why not to make it in turn start event?
20140613 21:28:52< mattsc> anyways, I need to be afk for ~30 min.
20140613 21:29:18< Necrosporus> When orgre is at edge of map, it disappears before start of human turn
20140613 21:29:21< shadowm> From what I've heard, the readability of . vs -> is subjective. I personally prefer . myself.
20140613 21:29:50< Necrosporus> Ogres surrender at the some of turn-related events
20140613 21:30:03< Necrosporus> Why not to make them disappear in same event?
20140613 21:30:39< iceiceice_> ahh this unit map refactor is fairly annoying i realized
20140613 21:30:49< iceiceice_> i think im going to just do it in many stages to be careful
20140613 21:31:21< iceiceice_> if you just replace unit_pod with shared_ptr and then fixup the syntax, the ref_count numbers are wrong because they are all higher by one than what they would be with the unit_pod object
20140613 21:35:16-!- thunderstruck [~zaibotren@cpc7-cowc7-2-0-cust670.14-2.cable.virginm.net] has quit [Quit: leaving]
20140613 21:40:56-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140613 21:41:43-!- Guest22059 [~cib@p5DD22D04.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140613 21:47:07-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140613 21:47:33-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140613 21:47:52< shadowm> wesbot: seen fabi
20140613 21:47:53< wesbot> shadowm: The person with the nick fabi last spoke 3d 6h ago.  2d 19h ago was here and on the channels #wesnoth, #wesnoth-de and #wesnoth-umc-dev with the message: Ping timeout: 240 seconds
20140613 21:50:14-!- gfgtdf_ [~chatzilla@f054147096.adsl.alicedsl.de] has joined #wesnoth-dev
20140613 21:52:12-!- gfgtdf [~chatzilla@d107250.adsl.hansenet.de] has quit [Ping timeout: 255 seconds]
20140613 21:52:25-!- gfgtdf_ is now known as gfgtdf
20140613 21:54:33< Ivanovic> mordante: works now, thanks!
20140613 21:58:01< mattsc> Necrosporus: what I meant is: *if* you want to use a moveto event to make the unit disappear, there is nothing that can be done from within the custom AI code to prevent this error message.
20140613 21:58:36< shadowm> Who knew I'd wind up patching the play controller code while dealing with a purely GUI issue.
20140613 21:59:34< mattsc> Also, I like having them disappear as the reach the map edge - so maybe this shouldn’t be a bug?  Or maybe the did-we-reach-the-end-of-the-move check should be done before the moevto event fires.
20140613 21:59:45< mattsc> I don’t know if that’s possible though.
20140613 22:00:52< mattsc> c74d: yeah, I did that “maths” myself.  :)  However, “not undeserving” is not necessarily the same as “deserving” (and so on), when it comes to the nuances.
20140613 22:02:31< c74d> Yes, you’re quite right; my apologies.
20140613 22:03:09< mattsc> c74d: nah, not necessary.  As I said, I did the same in order to try to figure out what shadowm was saying.
20140613 22:04:28< mattsc> shadowm: so out of curiosity, what’s your take on that cause of the error message?  [AI unit gets taken off in a moveto event which causes the E_NOT_REACHED_DESTINATION message]
20140613 22:04:42< mattsc> Obviously, it would be nice for this not to happen.
20140613 22:04:58< shadowm> mattsc: Is it trying to move off-map perhaps?
20140613 22:05:02< mattsc> But at which level in the chain of events should it be suppressed.
20140613 22:05:30< mattsc> shadowm: what’s ahppening is that we take ogres off the map when they reach the edge of the map.  That’s done by killing the unit in a moveto event.
20140613 22:05:54< mattsc> The moveto event is triggered before the AI checks whether the unit is now at the destination it was supposed to get to.
20140613 22:06:06< mattsc> This happens for the default AI in the same way as for custom AIs.
20140613 22:06:26< mattsc> (really simple test is to make a moveto event that unconditionally kills the moving unit)
20140613 22:06:40< shadowm> Is there a way to check beforehand that that is what will happen and tell the AI in advance to not care if the unit "fails" to get to the destination?
20140613 22:07:17< mattsc> shadowm: there is not currently, AFAIK.  It might be easy enough to add; or difficult or impossible.
20140613 22:07:26< mattsc> I should probably query Crab_ about this ...
20140613 22:07:44< mattsc> Let me add it to “the List”
20140613 22:07:49< shadowm> I know nothing about the AI code other than the fact that it takes about as long as GUI2 to compile. :p
20140613 22:08:09< mattsc> :)
20140613 22:08:42< shadowm> The alternative is to declare the intentionality of those error messages in the moveto event with a [wml_message] to the warning logger.
20140613 22:08:54< mattsc> I was just wondering if you thinnk this sequence of events should produce an error message.
20140613 22:09:00< shadowm> But that'd be kind of weird.
20140613 22:09:03< mattsc> Hmm...
20140613 22:09:06< mattsc> yes
20140613 22:10:08< mattsc> Anyways, I’ll talk to Crab_ about it.  There might be a reason why it is done like this.  Or there might also have been a reason that isn’t relevant any more.  Or ...
20140613 22:13:11< Necrosporus> Btw isn't it a tomato surprise when three cuttlefishes appear in "Undead crossing"?
20140613 22:14:03-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140613 22:14:15< aquileia> zookeeper: Calling error for procedure 'gimp-item-set-visible': Procedure 'gimp-item-set-visible' has been called with value '-1' for argument 'item' (#1, type GimpItemID). This value is out of range.
20140613 22:14:49< aquileia> I tried to localize the map but the script returned an error...
20140613 22:15:16< zookeeper> humm
20140613 22:16:00< zookeeper> aquileia, does the labels layer contain any yellow text?
20140613 22:16:04< aquileia> do you know by coincidence whether I made a mistake, GunCleoc didn't prepare the localization.xcf correctly or the script is outdated?
20140613 22:16:10< aquileia> Yes, it does
20140613 22:16:24< zookeeper> i guess i'll need to take a look at the file
20140613 22:16:36< zookeeper> i'll be afk for a few minutes but i'll check it then
20140613 22:17:58< shadowm> Are replays causing a segmentation fault on master for anyone else? (When loading them.)
20140613 22:18:53< shadowm> Hm, I guess it's *the* replay that's causing it.
20140613 22:19:59< shadowm> Pffft, the AI can't play AtS E1S1 without committig suicide.
20140613 22:20:32< shadowm> I am disappointed.
20140613 22:21:06< mattsc> Being disappointed in the AI is a time-honored tradition
20140613 22:22:41< shadowm> Also, I consistently get a segmentation fault when trying to play a replay of that scenario.
20140613 22:23:08< shadowm> Not so when trying to play a replay of one of the mainline MP maps I made the other day for gui2::tchat_log testing purposes.
20140613 22:24:27< mattsc> shadowm: are you seriously interested in an AI to play that scenario, or was that just a test whether it could?
20140613 22:24:31< shadowm> The fault happens before the display even appears. Surely that can't be because I'm tampering with the usual gameplay flow by undroiding a side?
20140613 22:25:06< mattsc> shadowm: in my AI tests I do a lot of (un)droinding of sides, and that doesn’t affect the replays.
20140613 22:25:25< shadowm> mattsc: I wanted to test that just so I could get a replay without playing. To be fair, I probably should instruct it to protect Mal Keshar (who the AI keeps sacrificing circa turn 4) and Elynia.
20140613 22:26:02< shadowm> But since I don't intend the campaign to be played by the AI, I really won't bother.
20140613 22:26:30< mattsc> I see.  Yeah, the protect_unit MAI should work well for that, if …  (yes, what you say after that)
20140613 22:26:47< shadowm> At leaast I have made sure the crash isn't related to my next patch.
20140613 22:27:27-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140613 22:29:42< shadowm> This is kind of wrong, though. An HttT S1 replay desn't crash the game.
20140613 22:33:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140613 22:33:50< aquileia> zookeeper: If you're wondering why I didn't send you the file yet - I'm having issues with uploading
20140613 22:33:54< shadowm> One more item to add to my kilometric list of dubious UMC accomplishments, I guess.
20140613 22:34:16< aquileia> I'm off for a minute, hopefully I can  fix it in the meantime
20140613 22:37:04-!- aquileia_ [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140613 22:38:12< aquileia_> zookeeper: https://www.dropbox.com/s/hyeaee96uu77m3s/de2.xcf
20140613 22:38:40-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140613 22:40:38-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140613 22:43:37< iceiceice_> shadowm: where is the segfault coming from?
20140613 22:43:41< iceiceice_> it could be from gfgtdf or myself
20140613 22:43:44< iceiceice_> most likely
20140613 22:44:01< zookeeper> aquileia_, ok, reproduced...
20140613 22:44:46< shadowm> iceiceice_: http://pastebin.com/rRf5WwND
20140613 22:46:20< zookeeper> aquileia_, the layer was named "Labels", not "labels" :p
20140613 22:46:36< aquileia_> and that's the issue?
20140613 22:46:43< zookeeper> ok, i got another error too apparently
20140613 22:46:52< zookeeper> let me check what that's about...
20140613 22:47:18< aquileia_> Because I noticed that but thought "it's like that in the PR"...
20140613 22:47:57< shadowm> I found this in replay_controller.cpp: `if(true){ //block for set_scontext_synced`
20140613 22:47:59< aquileia_> So this one is for GunCleoc to fix before merging
20140613 22:48:19< shadowm> Just wanted to remind you that in C++ you don't need a control structure to create a scope with braces.
20140613 22:48:43< shadowm> { int this_is_a_scoped_variable_too = 0; }
20140613 22:50:57< zookeeper> aquileia_, ok, same for "Label placement guide"; just uncapitalize both names, _and_ "merge layer group" for both layers
20140613 22:51:28< aquileia_> and then it'll work?
20140613 22:51:29< zookeeper> the script can't deal with layer groups
20140613 22:51:31< zookeeper> worked for me
20140613 22:51:48< aquileia_> ok, thanks!
20140613 22:52:05< zookeeper> (make sure the placement guide layer doesn't get that trailing "#1" in its name)
20140613 22:52:40< iceiceice_> shadowm: what's going on at line 123 of replay_controller.cpp?
20140613 22:52:57< iceiceice_> shouldn't it be like, tod_manager_ = tod_manager_start_?
20140613 22:53:14< iceiceice_> the way it is, it looks like you initialize tod_manager_start_ in the initalizer ist and then throw it away
20140613 22:53:35< iceiceice_> oh i just saw your name in git blame, i guess that commit was from 2011
20140613 22:54:01< iceiceice_> wait so what has changed in play_controller  / replay_controller recently
20140613 22:54:08< shadowm> I have no idea what you are talking about!
20140613 22:54:23< zookeeper> aquileia_, i should really make the script more robust and all that... sometime :p
20140613 22:55:10< aquileia_> For now I'll comment on the PR and hope he fixes it on his side
20140613 22:55:26< iceiceice_> shadowm: it's not the cause of the bug,
20140613 22:55:33< iceiceice_> theres just some redundant code in this commit: https://github.com/wesnoth/wesnoth/commit/cc77a7dc#diff-21122e0c91c886f669478f26d9f6ed40R74
20140613 22:55:58< iceiceice_> that commit didn't actually do anything,
20140613 22:56:16< iceiceice_> the tod_manager_ in play_controller is constructed the play_controller constructor, using tod_manager(level)
20140613 22:56:29< iceiceice_> the replay_controller constructor also constructs tod_manager_start_ using tod_manager(level)
20140613 22:56:42< iceiceice_> so the line there which is now at 123 just copy constructs one thing using an equal thing
20140613 22:56:51-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140613 22:57:06-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140613 22:57:09< shadowm> iceiceice_: Are you looking at what the code did considering all historical context?
20140613 22:57:09< iceiceice_> err,
20140613 22:57:41< iceiceice_> so i guess tod_manager construction used to have wierd side effects or somthing?
20140613 22:57:46< iceiceice_> that's the only explanation i can take from this
20140613 22:57:47< shadowm> It says February 25 2011, first included in 1.9.5. Everything has changed since then.
20140613 22:58:12< iceiceice_> alright
20140613 22:58:21 * shadowm goes to hunt for bugs to cite in his next two commits.
20140613 22:59:35< iceiceice_> ok well this is pretty confusing
20140613 22:59:47< iceiceice_> i dont think im going to figure out the cause of segfault by scanning the code, maybe best to bisect
20140613 23:00:01< shadowm> Did you even manage to reproduce it?
20140613 23:00:18-!- mjs-de [~mjs-de@f048210113.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140613 23:02:40< iceiceice_> no i didnt try
20140613 23:02:53< shadowm> Then how is bisect going to help you?
20140613 23:03:16< iceiceice_> well i'm suggesting that you bisect
20140613 23:03:31< iceiceice_> sometimes these things can be spotted easily but not this time it hink
20140613 23:03:47< shadowm> Ohhhh. *checks agenda*
20140613 23:03:59< shadowm> Maybe next week.
20140613 23:04:03< iceiceice_> the change that i made that might affect this is that
20140613 23:04:13< shadowm> Which is?
20140613 23:04:17< iceiceice_> the pathfinding and whiteboard are initialized before the gui
20140613 23:04:23< iceiceice_> because the gui needs to have valid pointers to these
20140613 23:05:39< iceiceice_> i'm not sure if there's some wierd initialization happening for the replay controller though
20140613 23:05:43< iceiceice_> as a rule of thumb, the answer is yes...
20140613 23:06:01< shadowm> The replay controller initialization right now is giving me a migraine, yes.
20140613 23:06:01< iceiceice_> imo the replay controller should never have been separated from the play controller but unfortunately here we are
20140613 23:07:07< shadowm> If I press the stop button during a start event, everything goes to hell.
20140613 23:07:36< shadowm> It's not obvious because there is no stop button during start without my patch.
20140613 23:08:12< gfgtdf> shadowm: the quare button in tehreplay controller should have o effec during a start event
20140613 23:08:21< gfgtdf> square*
20140613 23:08:25< shadowm> Sigh, I just want to fix a GUI consistency bug, I'm not interested in dealing with this clusterfuck.
20140613 23:08:36< shadowm> gfgtdf: That's called the Stop button.
20140613 23:09:49-!- aquileia_ [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140613 23:10:02< shadowm> Although I guess in Wesnoth it works more like a Rewind button.
20140613 23:10:47< shadowm> I give up. I'm going to deploy the non-replay side of my patch and see what happens.
20140613 23:11:03-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140613 23:11:20< iceiceice_> shadowm: i believe the replay viewer works fine in current master
20140613 23:11:46< iceiceice_> at least, i haven't observed any segfaults with any mainline or mp scenarios
20140613 23:11:47< shadowm> No, it doesn't.
20140613 23:12:05< iceiceice_> how to reproduce?
20140613 23:12:08< shadowm> Exactly, but it crashes with my add-on. That means it doesn't work fine.
20140613 23:12:17< iceiceice_> what's going on in your add-on?
20140613 23:12:28< shadowm> Just a run of the mill prestart/start sequence.
20140613 23:12:48< shadowm> I also store a few units and MUF them around, nothing special.
20140613 23:13:37< iceiceice_> it looks like theres some lua executing in prestart
20140613 23:13:43< shadowm> And unrelated to my add-on, during any scenario's start event half of the replay GUI is in an indeterminate state because it's not fully initialized.
20140613 23:13:57< iceiceice_> something happens with a std::set of maplocations that ends up with a null map_location ithink
20140613 23:14:04< shadowm> Well, [event] and half of the mainline WML actions are implemented in Lua in general, so there's that.
20140613 23:14:34< shadowm> If you are trying to suggest it'd also crash in non-replay mode, no, it doesn't, and that'd also be a bug in the engine.
20140613 23:15:03< iceiceice_> " during any scenario's start event half of the replay GUI is in an indeterminate state because it's not fully initialized" i can't reproduce that
20140613 23:15:33< shadowm> Go into a replay of HttT S1, it has a start event.
20140613 23:15:59< shadowm> Tell me if you can see the replay, minimap, and end-turn buttons during the first run of that event.
20140613 23:16:22< iceiceice_> you're right
20140613 23:16:30< iceiceice_> it doesnt reset the gui because of hte [story] event
20140613 23:16:33< iceiceice_> but that's pretty minor
20140613 23:16:41< iceiceice_> in scenarios without [story] i dont think there is a problem
20140613 23:16:43< shadowm> s/reset/initialize/
20140613 23:16:46< iceiceice_> also it might affect 1.12 i'm not sure
20140613 23:17:14< shadowm> The internal data structures are there but the managed GUI1 widgets aren't signaled to draw themselves.
20140613 23:17:16< iceiceice_> but it's not any scenario's start event, i think its only the story issues
20140613 23:17:26< iceiceice_> idk
20140613 23:17:30< iceiceice_> would require more testing
20140613 23:17:39< shadowm> Well, I've yet to find a scenario start that doesn't come accompanied with a storyscreen sequence.
20140613 23:17:59< iceiceice_> ok, well i've found many
20140613 23:18:34< shadowm> It's symmetric with a non-replay issue that AFAICT doesn't require a storyscreen to occur.
20140613 23:19:11< shadowm> Waaait.
20140613 23:19:24< shadowm> What is this thing about storyscreens you are saying? The storyscreen isn't even played for the replay.
20140613 23:21:00< iceiceice_> i'm compiling with 1.12 to see if it looks the same
20140613 23:23:45< shadowm> I'm not even using 1.12 for this.
20140613 23:24:15< iceiceice_> ok but i'm actually just interested in figuring out if recent changes caused a bug or not.
20140613 23:24:17< shadowm> Though it's irrelevant. I'm going to let you figure out the replay mess.
20140613 23:25:50-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140613 23:25:55-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140613 23:29:18-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140613 23:35:14-!- Haudegen [~quassel@178.115.128.160.wireless.dyn.drei.com] has joined #wesnoth-dev
20140613 23:36:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20140613 23:39:25-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140613 23:39:38< iceiceice> shadowm: the replay ui issue affects 1.12 as well
20140613 23:39:45< iceiceice> i suggest you report a minor ui bug
20140613 23:39:54< shadowm> As expected.
20140613 23:40:14< irker485> wesnoth: Ignacio R. Morelle wesnoth:1.12 f93b439e1373 / changelog players_changelog src/playsingle_controller.cpp: Call set_button_state() from playsingle_controller::init_gui() http://git.io/cqloeQ
20140613 23:40:17< irker485> wesnoth: Ignacio R. Morelle wesnoth:master 8e3cfc8a2b30 / changelog players_changelog src/playsingle_controller.cpp: Call set_button_state() from playsingle_controller::init_gui() http://git.io/MmzdCQ
20140613 23:40:26-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140613 23:43:03-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20140613 23:45:06< shadowm> iceiceice: And who would handle it?
20140613 23:45:30< iceiceice> why are you asking me?
20140613 23:45:52< shadowm> I am asking you because you and gfgtdf have been working as a team on this stuff.
20140613 23:46:01< iceiceice> i don't think we did anything related to this
20140613 23:46:28< iceiceice> the last time i remember anyone saying that they did anything about the replay viewer ui was mattsc, and he decided that he broke something and reverted his commit iirc
20140613 23:46:30< shadowm> The last four commits to replay_controller.cpp are yours.
20140613 23:46:40< iceiceice> the problem affects 1.12
20140613 23:46:50< iceiceice> so the last four commits on master are almost surely not the culprit
20140613 23:46:57< shadowm> I'm not blaming you.
20140613 23:47:19< iceiceice> what then?
20140613 23:47:42< shadowm> I'm merely pointing out that I'd feel more comfortable filing a bug and including my patch if I knew it was going to be handled by knowledgeable people and not some random person who will take the patch and commit it without a second thought.
20140613 23:48:18< shadowm> Otherwise I might as well finish the research myself since it's essentially just a matter of ensuring the replay controls are disabled/ignored during that critical step.
20140613 23:48:59< shadowm> The problem is, to my knowledge, nobody here truly grasps the *controller internals.
20140613 23:49:15< shadowm> Nobody of the active devs line-up, to be specific.
20140613 23:49:32< iceiceice> i doubt if anyone really understood in the last 5 years tbh
20140613 23:50:43-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140613 23:51:27< shadowm> To me, a relative outsider (as in, my field is not the *controller classes), the design looks like it's held together by duck tape and the frame built with matchsticks, all entangled and twisted together in a four-dimensional space.
20140613 23:51:33< irker485> wesnoth: Chris Beck wesnoth:master 678d43a0569e / src/replay_controller.cpp: remove code made dead in 84556b11 http://git.io/R3Fklg
20140613 23:51:36< irker485> wesnoth: Chris Beck wesnoth:master 81874be9f9d8 / changelog players_changelog src/playsingle_controller.cpp: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/txuzDA
20140613 23:51:51-!- Haudegen [~quassel@178.115.128.160.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140613 23:51:55-!- Necrosporus_ is now known as Necrosporus
20140613 23:52:00-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Necrosporus]
20140613 23:54:41< shadowm> So there's a bare-bones play_controller (P), replay_controller (R) and playsingle_controller (S) are its subclasses, and playmp_controller (M) is in turn a subclass of playsingle_controller. (P->R, P->S->M)
20140613 23:55:33< shadowm> I'm really curious why it was decided that this made more sense than having a single controller P optionally aggregate functionality from R and M instead.
20140613 23:56:05< shadowm> After all, the "you are not in control" situation also happens in S all the time when you press End Turn.
20140613 23:57:09< shadowm> Aside from the game knowing how things will play out in advance, the difference between S and R doesn't seem enough to warrant the divergent design and all the UX woes stemming from it.
20140613 23:58:16< shadowm> (Of course this is a UI-centric rant because I'm biased and find UI stuff more interesting and fun to work with. Unless P, R, S or M are involved.)
20140613 23:59:53< iceiceice> shadowm: its usually a very bad idea to use inheritance when not necessary in C++, at least in my limited experience
--- Log closed Sat Jun 14 00:00:19 2014