--- Log opened Tue Jun 17 00:00:39 2014
20140617 00:05:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140617 00:08:59-!- kex_ [~kex@93-142-142-215.adsl.net.t-com.hr] has joined #wesnoth-dev
20140617 00:09:47-!- Kexoth [~kex@93-143-44-239.adsl.net.t-com.hr] has quit [Ping timeout: 245 seconds]
20140617 00:13:30< AI0867> iceiceice: I agree we should ditch gna. Who did the forgeplucker run against gna again?
20140617 00:14:02< iceiceice> idk i just saw it on the wiki page
20140617 00:14:41< iceiceice> i think there was maybe osmething in a FOSDEM log?
20140617 00:15:06< iceiceice> http://wiki.wesnoth.org/Fosdem2014#Bugtracker_.2F_single_login
20140617 00:16:08< ancestral> I was asking about that earlier
20140617 00:18:34< vultraz> It's unfortunate GH only allows certain types of attachments 
20140617 00:18:44< vultraz> Else it would be perfect
20140617 00:18:56< iceiceice> ancestral: i wrote an email to the dev list partly because you asked
20140617 00:26:52-!- mjs-de [~mjs-de@g228034065.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140617 00:47:04-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140617 00:47:45-!- Jetrel_ [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Read error: Connection reset by peer]
20140617 00:48:21-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140617 00:50:52-!- sachith500 [~kvirc@112.135.22.103] has joined #wesnoth-dev
20140617 01:04:48-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140617 01:06:09-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Remote host closed the connection]
20140617 01:12:07< irker346> wesnoth: gfgtdf wesnoth:master f80f7104d2af / src/carryover.cpp: fix recuits carryover http://git.io/GMz0_w
20140617 01:12:57-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140617 01:13:58-!- sachith500 [~kvirc@112.135.22.103] has quit [Read error: Connection reset by peer]
20140617 01:14:30-!- sachith500 [~kvirc@112.135.22.103] has joined #wesnoth-dev
20140617 01:15:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140617 01:22:07-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20140617 01:23:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140617 01:25:36-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140617 01:27:05-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds]
20140617 01:27:09-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140617 01:28:44-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 239 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140617 01:37:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140617 01:38:57-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has quit [Quit: Leaving]
20140617 01:42:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140617 01:53:48-!- stikonas__ is now known as stikonas
20140617 02:04:04-!- Samual [~dioteckte@xonotic/core-team/Samual] has joined #wesnoth-dev
20140617 02:05:06-!- Ivanovic_ [~ivanovic@frnk-4d016ed7.pool.mediaWays.net] has joined #wesnoth-dev
20140617 02:05:06-!- Ivanovic_ [~ivanovic@frnk-4d016ed7.pool.mediaWays.net] has quit [Changing host]
20140617 02:05:06-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140617 02:07:00-!- gfgtdf_ [~chatzilla@f050176252.adsl.alicedsl.de] has joined #wesnoth-dev
20140617 02:08:03-!- gfgtdf [~chatzilla@e177158136.adsl.alicedsl.de] has quit [Ping timeout: 244 seconds]
20140617 02:08:10-!- gfgtdf_ is now known as gfgtdf
20140617 02:08:20-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds]
20140617 02:09:05-!- Ivanovic_ is now known as Ivanovic
20140617 02:11:17-!- sachith500 [~kvirc@112.135.22.103] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140617 02:11:46< irker346> wesnoth: Chris Beck wesnoth:master ab23b03b22db / src/ (7 files in 2 dirs): move actions::unit_can_move to be a method of display_context:: http://git.io/Kpjtig
20140617 02:11:48< irker346> wesnoth: Chris Beck wesnoth:master 0be1d731d5ce / / (15 files in 4 dirs): add drawable unit class http://git.io/m36_lg
20140617 02:11:50-!- kex_ [~kex@93-142-142-215.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140617 02:11:50< irker346> wesnoth: Chris Beck wesnoth:master f0fc9ff5c7a8 / / (19 files in 5 dirs): Merge branch 'drawable_units' http://git.io/Re6cTQ
20140617 02:12:26-!- Kexoth [~kex@93-142-142-215.adsl.net.t-com.hr] has joined #wesnoth-dev
20140617 02:13:36< iceiceice> gfgtdf: do you know why we have two unit mover classes?
20140617 02:14:22< gfgtdf> no i only know the one in actions/move mean ?
20140617 02:14:32< gfgtdf> which isthe other one ? *
20140617 02:18:06< iceiceice> theres one in unit_display::
20140617 02:18:10< iceiceice> and one in actions/move
20140617 02:18:18< iceiceice> i guess they are both used in actions/move.cpp ?
20140617 02:19:26< gfgtdf> iceiceice: hm i think the in unit_display does the visual things and the in acntions_move does the calculations like fireing events, calculation movepoints, giving oos messages
20140617 02:19:56< iceiceice> i see
20140617 02:20:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140617 02:23:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140617 02:24:28-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 264 seconds]
20140617 02:26:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20140617 02:26:06-!- gfgtdf [~chatzilla@f050176252.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140617 02:27:11-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Quit: Ex-Chat]
20140617 02:35:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140617 02:37:50-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140617 02:45:02-!- Kexoth [~kex@93-142-142-215.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140617 02:45:37-!- Kexoth [~kex@93-142-142-215.adsl.net.t-com.hr] has joined #wesnoth-dev
20140617 02:46:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140617 03:07:31-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140617 03:07:47< mattsc> Man, how many files did you guys add in the last 24 hours ?  :P
20140617 03:21:16< irker346> wesnoth: mattsc wesnoth:master f78fbdb36acb / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project http://git.io/Q29wkg
20140617 03:26:14-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140617 03:43:55-!- higgins [~higgins@192.241.198.49] has quit [Ping timeout: 240 seconds]
20140617 03:46:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140617 03:46:34-!- higgins [~higgins@192.241.198.49] has joined #wesnoth-dev
20140617 03:48:43-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140617 04:18:57< irker346> wesnoth: Lari Nieminen resources:master af14d60f9f50 / image-localization/maps/Legend_of_Wesmere/ (labels_flat.png localization.xcf): Added localization files for LoW bigmap http://git.io/wiowdQ
20140617 04:29:17-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140617 05:15:50-!- cib_ [~cib@p508BCAB7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140617 05:22:45-!- groggy [~chatzilla@24-182-84-61.dhcp.hckr.nc.charter.com] has joined #wesnoth-dev
20140617 05:26:16-!- _8680_ [~8680@2002:4404:712c:0:6c71:c0f2:c0ae:cc6a] has quit [Remote host closed the connection]
20140617 05:26:36-!- _8680_ [~8680@2002:4404:712c:0:850c:367d:d6c0:d1ee] has joined #wesnoth-dev
20140617 05:33:31-!- _8680_ [~8680@2002:4404:712c:0:850c:367d:d6c0:d1ee] has quit [Ping timeout: 240 seconds]
20140617 05:39:12-!- _8680_ [~8680@2002:4404:712c:0:c84f:cbc3:4b1:7855] has joined #wesnoth-dev
20140617 05:42:19< ancestral> There’s a new DejaVu font version from last August: http://sourceforge.net/p/dejavu/code/HEAD/tree/tags/version_2_34/dejavu-fonts/NEWS
20140617 05:43:01< ancestral> Among other things, fixes some issues with anchors/cedillas
20140617 05:45:38< ancestral> Looks like they added condensed versions
20140617 05:57:07-!- groggy [~chatzilla@24-182-84-61.dhcp.hckr.nc.charter.com] has quit [Remote host closed the connection]
20140617 06:02:37-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds]
20140617 06:18:09-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140617 06:20:10< irker346> wesnoth: Chris Beck wesnoth:master 4ff77b84c80f / src/ (display.cpp display.hpp drawable_unit.cpp drawable_unit.hpp game_display.cpp): redraw_unit takes display & as an argument http://git.io/zfr8Hw
20140617 06:20:12< irker346> wesnoth: Chris Beck wesnoth:master 504e4932b51b / / (29 files in 10 dirs): split off animation fcs from unit to unit_animation_component http://git.io/GOetkw
20140617 06:20:14< irker346> wesnoth: Chris Beck wesnoth:master 027a135118f6 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/xrzZWw
20140617 06:36:00-!- cib_ [~cib@p508BCAB7.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20140617 07:01:18< Necrosporus> In SoBE #11 Clash of Armies there is plot inconsistency if you manage to kill Earl, you will get scenario finished but Horde won't arrive and it would be said "earl has been retreated" anyway
20140617 07:03:15< vultraz> report to mattsc 
20140617 07:12:38< Necrosporus> mattsc
20140617 07:13:16< Necrosporus> vultraz, it's possibly intentional, as it would be extremely hard to do probably
20140617 07:16:03-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20140617 07:27:16< vultraz> Necrosporus: hard to do what?
20140617 07:27:36< Necrosporus> To kill enemy leader
20140617 07:27:43< Necrosporus> The task is to hold 24 turns
20140617 07:27:48< Necrosporus> Not to kill
20140617 07:28:17< vultraz> is Earl relevant to the plot later?
20140617 07:40:27-!- cib_ [~cib@132.231.178.16] has joined #wesnoth-dev
20140617 07:50:51-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140617 07:53:49-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140617 07:55:12-!- cib_ [~cib@132.231.178.16] has quit [Ping timeout: 255 seconds]
20140617 08:01:38-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140617 08:16:40-!- Netsplit *.net <-> *.split quits: ancestral, iceiceice, Coffee_irc, Crendgrim, vultraz, EliDupree, timotei, _8680_
20140617 08:16:46-!- Netsplit *.net <-> *.split quits: higgins, Smar, Fortescue, iwaim
20140617 08:21:24-!- Netsplit over, joins: iwaim, higgins, Fortescue, Smar
20140617 08:21:30-!- Netsplit over, joins: ancestral, _8680_, vultraz, EliDupree, Crendgrim, iceiceice, timotei, Coffee_irc
20140617 08:27:48-!- Jozrael [Jozrael@cpe-23-242-93-245.socal.res.rr.com] has joined #wesnoth-dev
20140617 08:28:00-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has quit [Write error: Broken pipe]
20140617 08:28:32< Jozrael> Hey all, is http://forums.wesnoth.org/viewtopic.php?f=5&t=40493&p=572012#p572012 a known bug in 1.11.15? Units disappearing on move (I haven't seen anyone else report it, so it's likely an edge case of some sort)
20140617 08:29:43< Jozrael> Also spammer: http://forums.wesnoth.org/viewtopic.php?f=4&t=12139&start=180
20140617 08:33:34-!- Netsplit *.net <-> *.split quits: Jozrael, ancestral, iceiceice, Crendgrim, vultraz, EliDupree, timotei, _8680_
20140617 08:44:19-!- Netsplit over, joins: Jozrael, ancestral, _8680_, vultraz, EliDupree, Crendgrim, iceiceice, timotei
20140617 08:49:02-!- mjs-de [~mjs-de@g228034065.adsl.alicedsl.de] has joined #wesnoth-dev
20140617 09:07:44-!- markus_ [~mjs-de@g228037045.adsl.alicedsl.de] has joined #wesnoth-dev
20140617 09:10:34-!- Haudegen_ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140617 09:11:12-!- mjs-de [~mjs-de@g228034065.adsl.alicedsl.de] has quit [Ping timeout: 244 seconds]
20140617 09:20:20-!- irker346 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140617 09:20:30-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140617 09:20:40-!- Haudegen_ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Remote host closed the connection]
20140617 09:21:07< AI0867> Jozrael: that's a bug I've since fixed
20140617 09:27:23< Jozrael> Thanks AI0867 :)
20140617 09:30:03-!- Haudegen__ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140617 09:31:12-!- Haudegen__ is now known as Haudegen
20140617 09:47:59-!- DHost [~Pcy@vps.ponchy.fr] has quit [Quit: leaving]
20140617 10:02:30-!- markus_ is now known as mjs-de
20140617 10:09:38-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.]
20140617 10:21:26-!- DHost [~Pcy@vps.ponchy.fr] has joined #wesnoth-dev
20140617 10:26:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 10:54:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140617 10:57:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 10:58:37-!- sachith500 [~kvirc@112.135.88.190] has joined #wesnoth-dev
20140617 11:09:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140617 11:09:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 11:09:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20140617 11:12:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 11:26:16-!- Kexoth [~kex@93-142-142-215.adsl.net.t-com.hr] has quit [Ping timeout: 264 seconds]
20140617 11:31:58-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140617 12:04:17-!- ygtsjt [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140617 12:05:01-!- {V} [~V@72-69-ftth.on.nl] has quit [Disconnected by services]
20140617 12:05:06-!- ygtsjt is now known as {V}
20140617 12:10:40-!- sachith500 [~kvirc@112.135.88.190] has quit [Ping timeout: 264 seconds]
20140617 12:10:43-!- sachith500|2 [~kvirc@112.135.88.190] has joined #wesnoth-dev
20140617 12:35:02-!- Haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Remote host closed the connection]
20140617 12:39:25-!- Haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140617 12:58:04-!- aquileia [863c36a8@gateway/web/freenode/ip.134.60.54.168] has joined #wesnoth-dev
20140617 13:00:25< aquileia> zookeeper: I just tried to add the labels to the LoW localization.xcf (like in GunChleoc's PR) and lost about an hour to find out there's no deform guide...
20140617 13:01:00< aquileia> It's the outline of the transformed map, right?
20140617 13:01:20< zookeeper> ohh right, i totally forgot about that
20140617 13:01:31< zookeeper> i'll add it right away, hang on
20140617 13:01:40< aquileia> I only saw the issue after reading the script
20140617 13:02:11< aquileia> thousand thanks - it really harassed me, and I don't think I could add it correctly
20140617 13:02:19-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140617 13:05:57-!- irker061 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140617 13:05:57< irker061> wesnoth: Lari Nieminen resources:master def045d355a2 / image-localization/maps/Legend_of_Wesmere/localization.xcf: Added missing deform guide path http://git.io/4qhk3w
20140617 13:06:14< zookeeper> that should do it
20140617 13:08:33< zookeeper> aquileia, also, if you really spent a whole hour figuring it out, then i hope you'd have told me sooner :P
20140617 13:13:48< aquileia> I thought it'd be something else... I checked every yellow label, copied all layers in a clean file, ...
20140617 13:15:48< zookeeper> yeah i just built the file looking at an existing one for reference, and didn't remember that anything except the regular layers were needed... so i forgot about the path
20140617 13:17:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140617 13:22:51< mattsc> Necrosporus: it is indeed supposed to be impossible to kill the Earl, and I don’t think anybody ever has or we would have heard about it (because the rest of the campaign won’t work).
20140617 13:22:57< mattsc> How did you manage to do that?
20140617 13:23:24< aquileia> erm... what? The image I get is upside down...
20140617 13:26:22< aquileia> zookeeper: Could you try whether you get the same error, please? https://www.dropbox.com/s/1pdpk3q6egu12cc/master.xcf
20140617 13:26:44< zookeeper> sure
20140617 13:26:51< aquileia> Perhaps the path is directional and it somehow got reversed?
20140617 13:28:16< zookeeper> yeah i get an error of some kind, checking...
20140617 13:30:07< aquileia> Oh, I probably uploaded the unmerged layer groups, sorry
20140617 13:30:22< aquileia> two clicks and it will produce an overlay
20140617 13:30:23< zookeeper> yeah, the labels layer needed merging
20140617 13:30:47< aquileia> but the overlay was upside-down for me...
20140617 13:31:06< aquileia> there's two layer groups
20140617 13:31:16< zookeeper> huh. not for me.
20140617 13:31:59< zookeeper> oh wait, it is
20140617 13:32:40 * zookeeper investigates
20140617 13:39:26< zookeeper> yeah it's the path
20140617 13:40:02< zookeeper> but i copied it from another file initially, so that means that one must be broken as well... urgh, and i already forgot which one it was
20140617 13:43:52< zookeeper> or not
20140617 13:44:16< zookeeper> works on the DW file, but when i just copy that path over to this one, it ends up reversing the result
20140617 13:45:06< aquileia> I checked - crudely inverting the path direction works
20140617 13:45:24< mattsc> gfgtdf: I now always seem trigger an assert when I try to save any game from a replay.  Tried with MP, SP and test scenario replay.
20140617 13:45:35< mattsc> Assertion failed: (not_corrupt()), function write_carryover, file /mats/misc/Wesnoth/wesnoth/src/saved_game.cpp, line 173.
20140617 13:47:33< zookeeper> aquileia, you can do that in the meantime, sure. the end result will be the same as soon as i get this figured out, anyway.
20140617 13:48:11< zookeeper> the correct places for the corner points are the corners of the heightmap
20140617 13:48:15< zookeeper> in case you need precision
20140617 13:48:22< aquileia> But you'll probably invert it exactly via a script, I guerss?
20140617 13:48:37< aquileia> Ah, that makes sense...
20140617 14:05:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140617 14:05:46-!- sachith500|2 [~kvirc@112.135.88.190] has quit [Read error: Connection reset by peer]
20140617 14:06:04-!- sachith500|2 [~kvirc@112.135.88.190] has joined #wesnoth-dev
20140617 14:07:03< aquileia> zookeeper: My file now works correctly, thanks again. If you don't mind I'll add it in a PR (similar to GunChleoc)
20140617 14:07:32< zookeeper> eh, no need, i'll upload the fix myself
20140617 14:07:45< zookeeper> i've just gotten stuck trying to figure out the cause
20140617 14:07:47-!- sachith500|2 [~kvirc@112.135.88.190] has quit [Read error: Connection reset by peer]
20140617 14:08:23< aquileia> But your file doesn't have the labels so that translators only need to type and then merge
20140617 14:08:40< aquileia> I just paralleled what GC did to the other ones
20140617 14:09:48< aquileia> So I think it'd be nice to have it in his PR, what I unfortunately can't do - but I can issue a new one
20140617 14:10:18< aquileia> In any case, I've got to go... bye
20140617 14:10:25-!- aquileia [863c36a8@gateway/web/freenode/ip.134.60.54.168] has quit [Quit: Page closed]
20140617 14:19:50-!- cib [~cib@132.231.178.84] has joined #wesnoth-dev
20140617 14:20:14-!- cib is now known as Guest14466
20140617 14:26:51-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20140617 14:27:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140617 14:27:31< irker061> wesnoth: Lari Nieminen resources:master b89e08fcc734 / image-localization/maps/Legend_of_Wesmere/localization.xcf: Fixed mysteriously botched deform guide path http://git.io/IPyMjQ
20140617 14:27:54< zookeeper> aquileia, i committed the fix anyway just in case someone grabs it in the meantime... if the PR is merged then it'll be overwritten and that's fine
20140617 14:31:33-!- gfgtdf [~chatzilla@f050176252.adsl.alicedsl.de] has joined #wesnoth-dev
20140617 14:32:05< gfgtdf> mattsc: does that bug only appear with replays from older versions or also with replays saved yesterday ?
20140617 14:32:46< mattsc> gfgtdf: it appears with replays saved right this moment (I tried that specifically)
20140617 14:34:35< mattsc> gfgtdf: try this: start any mainline campaign, save replay (you don’t even need to do anything), load replay, save game -> assert
20140617 14:35:42< gfgtdf> mattsc: i currently am on another pc and cannot do that :( . could you please open the replaysavefile and see whats inside [carrryover_sides_start] ?
20140617 14:37:24< mattsc> gfgtdf: there is no such tag.  There a [carrryover_sides], but not a [carrryover_sides_start]
20140617 14:38:15< gfgtdf> hmm ok tym that it's not the savefile that corrupt but teh code that loads it
20140617 14:39:43< mattsc> gfgtdf: no rush AFAIAC, I don’t have time for Wesnoth today, and I can test Fred with 1.11.15+dev anyway.
20140617 14:40:56-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140617 14:40:56-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has quit [Changing host]
20140617 14:40:56-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140617 14:40:57< gfgtdf> mattsc: i guess code that was intended to convert pre 1.10 save to 1.11 saves breaks it. maybe a fix would be checking for teh savefiles version before doing these conversions.
20140617 14:42:06< mattsc> gfgtdf: I can’t comment on that, I’ve really not been following how all of this works…  :|
20140617 14:44:46-!- sachith500|2 [~kvirc@112.135.88.190] has joined #wesnoth-dev
20140617 14:55:30-!- Guest14466 [~cib@132.231.178.84] has quit [Ping timeout: 255 seconds]
20140617 15:32:27-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has joined #wesnoth-dev
20140617 15:42:37-!- gfgtdf_ [~chatzilla@f050176252.adsl.alicedsl.de] has joined #wesnoth-dev
20140617 15:45:56-!- gfgtdf [~chatzilla@f050176252.adsl.alicedsl.de] has quit [Ping timeout: 244 seconds]
20140617 15:46:02-!- gfgtdf_ is now known as gfgtdf
20140617 15:50:59-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140617 15:51:59-!- cib [~cib@p508BCAB7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140617 15:52:24-!- cib is now known as Guest33895
20140617 15:56:12-!- gfgtdf [~chatzilla@f050176252.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140617 16:09:01-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has quit [Quit: Leaving]
20140617 16:10:06-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has joined #wesnoth-dev
20140617 16:10:25-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 272 seconds]
20140617 16:11:33-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has quit [Client Quit]
20140617 16:11:50-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has joined #wesnoth-dev
20140617 16:13:40-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140617 16:14:52-!- Kexoth [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140617 16:15:25-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140617 16:18:28-!- ancestral [~ancestral@12.23.74.29] has quit [Ping timeout: 264 seconds]
20140617 16:20:16-!- Kexoth [~kex@212.92.210.53] has quit [Ping timeout: 264 seconds]
20140617 16:30:34-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140617 16:33:05-!- dacovale [~niklas@93.182.140.32] has joined #wesnoth-dev
20140617 16:39:56-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140617 16:39:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140617 16:41:03-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140617 16:44:23< irker061> wesnoth: Chris Beck wesnoth:master 6603de667b46 / src/ (8 files): move animations vector to animation component, drop header in unit http://git.io/tcf-pQ
20140617 16:44:25< irker061> wesnoth: Chris Beck wesnoth:master 405632174ad7 / src/ (dialogs.cpp unit.cpp unit.hpp): inline unit::still_image, only used in a dialog function http://git.io/OtohNQ
20140617 16:44:27< irker061> wesnoth: Chris Beck wesnoth:master 39d64b3ca0c8 / src/ (drawable_unit.cpp unit.cpp unit.hpp): forward declare SDL_Color in unit.hpp header http://git.io/U0E9Dg
20140617 16:44:29< irker061> wesnoth: Chris Beck wesnoth:master 045f38196d4f / src/ (ai/manager.cpp ai/testing/ca.cpp team.hpp): forward declare SDL_Color in team.hpp http://git.io/b9L_Yg
20140617 16:44:31< irker061> wesnoth: Chris Beck wesnoth:master 8c2a293d1462 / src/unit.cpp: remove unnecessary headers from unit.cpp http://git.io/hOudgg
20140617 16:47:06-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140617 16:47:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has left #wesnoth-dev []
20140617 16:48:09-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140617 16:52:52< irker061> wesnoth: Boldizsár Lipka wesnoth:master 6181499b1c4a / src/loadscreen.cpp: Don't rotate the logo on the loadscreen. http://git.io/ezG0Lg
20140617 16:52:54< irker061> wesnoth: Boldizsár Lipka wesnoth:master 561cb5bc7de3 / src/image.cpp: Add a separate cache for brightened images. http://git.io/AqcKLw
20140617 16:52:56< irker061> wesnoth: Boldizsár Lipka wesnoth:master 10af944c1d5d / src/sdl/texture.cpp: Do set the color mod on the actual texture. http://git.io/9An5MA
20140617 16:52:58< irker061> wesnoth: Boldizsár Lipka wesnoth:master 752b42c02e5d / src/image.cpp: Use the correct cache for non-hexed images. http://git.io/nPpnow
20140617 16:53:00< irker061> wesnoth: Boldizsár Lipka wesnoth:master 616ab5f656ab / src/sdl/ (texture.cpp texture.hpp): Store alpha value in ttexture and set it before drawing. http://git.io/HXH6zw
20140617 16:53:02< irker061> wesnoth: Boldizsár Lipka wesnoth:master f698ddabdc48 / src/sdl/ (texture.cpp texture.hpp): Remove set_blend_mode from ttexture. http://git.io/iiSaNg
20140617 16:53:04< irker061> wesnoth: Boldizsár Lipka wesnoth:master 20b0ea6ab31d / src/sdl/texture.cpp: Initialize texture alpha mod to 255 instead of 0. http://git.io/YBdRhg
20140617 16:53:06< irker061> wesnoth: Boldizsár Lipka wesnoth:master d6ea2e02909c / src/sdl/texture.cpp: Set the color mod before rendering. http://git.io/DG2c0g
20140617 16:53:08< irker061> wesnoth: Boldizsár Lipka wesnoth:master 4bbdc09af689 / src/sdl/ (texture.cpp texture.hpp): Return an int for the width/height of ttexture. http://git.io/AMg2_w
20140617 16:53:10< irker061> wesnoth: Boldizsár Lipka wesnoth:master c69b5a3bb64a / src/sdl/texture.cpp: When retrieving dimensions, return the scaled size of the texture. http://git.io/k6EM_g
20140617 16:53:12< irker061> wesnoth: Boldizsár Lipka wesnoth:master 26d40c15c9b3 / src/storyscreen/ (render.cpp render.hpp): Render background layers as textures on the storyscreen. http://git.io/cEORXg
20140617 16:53:14< irker061> wesnoth: Boldizsár Lipka wesnoth:master fac9ea5617b2 / src/storyscreen/ (part.cpp part.hpp render.cpp): Render floating images as textures on the storyscreen. http://git.io/NGuSDg
20140617 16:53:16< irker061> wesnoth: Boldizsár Lipka wesnoth:master 976e439d977b / src/sdl/ (rect.cpp rect.hpp): Match function declarations with definitions. http://git.io/GCtJnA
20140617 16:53:18< irker061> wesnoth: Boldizsár Lipka wesnoth:master c59414b121d0 / src/ (text.cpp text.hpp): Enable rendering text as a texture. http://git.io/RPuA-g
20140617 16:53:20< irker061> wesnoth: Boldizsár Lipka wesnoth:master 050235c43931 / src/loadscreen.cpp: Render everything on the loadscreen using the renderer API. http://git.io/_UEdKA
20140617 16:53:33-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140617 16:56:40-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140617 17:11:27-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 245 seconds]
20140617 17:12:03-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140617 17:13:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20140617 17:15:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 17:17:52< irker061> wesnoth: Chris Beck wesnoth:master 1cc51deb87a5 / src/ (16 files in 6 dirs): remove unit.hpp include from game_display.hpp http://git.io/3KbBtA
20140617 17:17:54< irker061> wesnoth: Chris Beck wesnoth:master 8106be91e579 / src/ (12 files in 3 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/skFXfQ
20140617 17:30:49-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 244 seconds]
20140617 17:33:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140617 17:37:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 17:40:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20140617 17:51:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 17:53:58-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140617 17:54:26< irker061> wesnoth: gfgtdf wesnoth:master d1ec28507e48 / src/ (saved_game.cpp saved_game.hpp): more log on corrupt saves http://git.io/0QvGqA
20140617 17:54:28< irker061> wesnoth: gfgtdf wesnoth:master 6b3af33fc8dd / src/saved_game.cpp: fix replay saves http://git.io/-yv6uw
20140617 17:55:07-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140617 17:55:22< mordante> servus
20140617 17:57:54< mordante> shadowm, using inspect in the test-scenario and selecting different items looks bad
20140617 17:58:52-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140617 17:59:39< lipkab> Hi mordante.
20140617 17:59:51< mordante> hi lipkab 
20140617 18:00:26-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has quit [Quit: Leaving]
20140617 18:00:48< lipkab> mordante: I've run into a couple of problems.
20140617 18:00:48-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has joined #wesnoth-dev
20140617 18:01:30< lipkab> The first and gravest is that the software renderer is apparently incapable of handling semi-transparent pixels.
20140617 18:01:52< lipkab> When using textures, it works for surfaces.
20140617 18:03:44< mordante> I also tested with it last weekend and wasn't able to get good results
20140617 18:04:01< mordante> still somewhat baffled if it's really impossible…
20140617 18:04:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140617 18:04:32< lipkab> I found it weird, too, but I can't find anything in the docs.
20140617 18:05:34< lipkab> My last hope is that this software renderer is an internal engine in SDL2, and we can still rely on OpenGL's software renderer instead.
20140617 18:05:49< mordante> there are blend mode flags, but they seem to fail
20140617 18:06:12< lipkab> Yeah, they only work for the accelerated renderer.
20140617 18:06:56< mordante> you already tested that?
20140617 18:07:00< lipkab> Yes.
20140617 18:07:34< mordante> they also do some things for the other renderer, both add and mod 'hide' the logo (thus not useful)
20140617 18:08:06< mordante> (btw compiling your last changes and looking at them)
20140617 18:08:11< mordante> other issues?
20140617 18:08:26< lipkab> Yes, SDL2's color modulating algorithm is completely senseless and unusable.
20140617 18:09:08< lipkab> It calculates the target pixel as src * (mod / 255) where mod is a 8 but unsigned integer.
20140617 18:09:31< lipkab> Thus color modding can't be used to brighten the texture...
20140617 18:09:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140617 18:09:46< lipkab> Which kinda kills the point.
20140617 18:10:14-!- Bodhi-Baum [~Bodhi@dslb-084-063-056-047.pools.arcor-ip.net] has joined #wesnoth-dev
20140617 18:10:32< mordante> :-(
20140617 18:10:40< lipkab> And the last thing: the "linear" scaling algorithm is rather low quality.
20140617 18:11:13< lipkab> It's way worse than the algorithm we use right now.
20140617 18:12:09< lipkab> To be honest, I'm starting to think that moving SDL2 is a bad idea :/
20140617 18:12:23< lipkab> *moving to
20140617 18:12:31< mordante> hmm why was I somewhat thinking in the same area
20140617 18:12:51< mordante> I'm really surprised it looks so horrible (not that I disagree)
20140617 18:14:38< lipkab> I don't know, maybe we should consult the SDL people?
20140617 18:14:58< mordante> did you also test with the nearest scaling method?
20140617 18:15:14< lipkab> No, but I assume it's even worse.
20140617 18:15:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 18:16:39< mordante> ok
20140617 18:17:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20140617 18:17:10< mordante> I first want to look at your patches and then discuss further
20140617 18:18:06< mordante> I'm not too happy with the changes to ttext::rerender, the hardcoded CVideo::get_window()
20140617 18:18:59< mordante> maybe let the render_as_texture take a window as parameter and use that to get the texture
20140617 18:19:12< lipkab> Alright.
20140617 18:19:25-!- Bodhi-Baum [~Bodhi@dslb-084-063-056-047.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140617 18:19:38< mordante> I'm not sure whether we will use multiple windows in the future
20140617 18:19:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 18:20:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20140617 18:22:35-!- Guest33895 [~cib@p508BCAB7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140617 18:23:20< mordante> regarding width() and height() please add the fact that size is scaled size in the Doxygen comment
20140617 18:23:39< mordante> also I think it makes more sense to return a floating point value
20140617 18:24:19-!- Guest33895 [~cib@p508BCAB7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140617 18:25:27< lipkab> I'm not sure about that. The actual rendered texture will always have integer dimensions.
20140617 18:25:55< mordante> is that value truncated or rounded?
20140617 18:26:47< lipkab> Hmm. I don't know.
20140617 18:28:17< irker061> wesnoth: Chris Beck wesnoth:master a8a132692d9b / src/ (game_display.cpp game_display.hpp): remove unused member of game_display http://git.io/aH1zPw
20140617 18:28:19< irker061> wesnoth: Chris Beck wesnoth:master 3d6bcb4c399f / src/ (play_controller.cpp play_controller.hpp unit_animation_component.cpp): move animation cache from play_controller to only fcn that uses it http://git.io/18IKpA
20140617 18:28:20< lipkab> Oh well.
20140617 18:28:21< irker061> wesnoth: Chris Beck wesnoth:master 9266fd392612 / src/ (saved_game.cpp saved_game.hpp): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/dIxfkw
20140617 18:28:51< lipkab> I'm stupid.
20140617 18:29:00< lipkab> mordante: It's truncated, of course.
20140617 18:30:21< lipkab> The target rectangle is calculated in line 199, with the same formulae as used in the accessor methods.
20140617 18:30:44< mordante> then maybe also add that in the comment
20140617 18:30:50< mordante> no other comments on your code
20140617 18:31:15< lipkab> Okay.
20140617 18:31:58< mordante> was a nice set of commits
20140617 18:32:42< lipkab> Thanks.
20140617 18:33:47< mordante> switching to the hardware renderer indeed seems to solve the ragged edges and ugly text in the load screen
20140617 18:35:29-!- travis-ci [~travis-ci@ec2-54-87-241-23.compute-1.amazonaws.com] has joined #wesnoth-dev
20140617 18:35:29< travis-ci> [travis-ci] wesnoth/wesnoth#3255 (master - 8106be9 : Chris Beck): The build has errored.
20140617 18:35:29< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27793996
20140617 18:35:29-!- travis-ci [~travis-ci@ec2-54-87-241-23.compute-1.amazonaws.com] has left #wesnoth-dev []
20140617 18:35:52< zookeeper> aww, images/misc/font8x8.png's magenta background isn't TC magenta
20140617 18:36:14< zookeeper> i wanted to ~BLIT some letters from it
20140617 18:36:28< lipkab> mordante: Only problem is that you can't see anything afterwards :)
20140617 18:37:25< mordante> lipkab, true but that at least confirms »Yeah, they only work for the accelerated renderer.«
20140617 18:38:05< mordante> so it seems like a bug to me
20140617 18:38:31< mordante> so at least we don't need to hunt for it further
20140617 18:38:53< lipkab> I'll look around in SDL's bug tracker to see if they're aware of this.
20140617 18:39:15< mordante> ok I just was about to do the same ;-)
20140617 18:40:42< mordante> last time you asked about the get_hex() code
20140617 18:41:21< mordante> it seems you can render to a SDL_Texture by using the SDL_TEXTUREACCESS_TARGET flag that might help
20140617 18:41:39< mordante> another option is only available when using OGL
20140617 18:41:54< mordante> there you can use a stencilbuffer https://gist.github.com/sealfin/d22f4ba4d1022e1b89dd
20140617 18:43:07< lipkab> Oh, so that's why you linked that for me :)
20140617 18:44:23< mordante> yup, do you know what a stencil buffer is?
20140617 18:45:02< lipkab> I figured from the docs that rendering to textures is not necessarily supported by the renderer, so I'm a bit reluctant to do that.
20140617 18:45:09< lipkab> No I don't.
20140617 18:46:02< lipkab> However, if using OGL calls introduces a new build dependency, then it's probably not worth it to replace the current method.
20140617 18:46:42< lipkab> (I.e. applying the mask on a surface and then creating a texture from it)
20140617 18:47:11< lipkab> Meanwhile: https://bugzilla.libsdl.org/show_bug.cgi?id=2198
20140617 18:47:26< mordante> the stencil buffer is a way to mask an image
20140617 18:47:46< mordante> by setting for every pixel whether or not it will be drawn
20140617 18:48:14< mordante> so you can render all kind of shapes and ignoring the parts you don't want
20140617 18:49:12< lipkab> I see.
20140617 18:49:38< mordante> the fact the bug is open for about half a year doesn't seem to be too hopeful
20140617 18:49:39< AI0867> 20:09 < lipkab> It calculates the target pixel as src * (mod / 255) where mod is a 8 but unsigned integer. ← I hope that's pseudocode, or it would be just src * ((bool)mod == 255)
20140617 18:50:18< mordante> but at least they are aware of it
20140617 18:50:20< lipkab> Hehe.
20140617 18:50:59< lipkab> AI0867: Of course it's pseudocode, it's not THAT bad :)
20140617 18:51:14< AI0867> I dunno, I've seen terrible things in SDL 1.2
20140617 18:52:17-!- sachith500|2 [~kvirc@112.135.88.190] has quit [Ping timeout: 245 seconds]
20140617 18:53:08-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140617 18:56:33< mordante> I assume OGL will add a build dependency
20140617 18:57:04-!- ancestral is now known as ancestral_lunch
20140617 18:57:11< irker061> wesnoth: Alexander van Gessel wesnoth:master 673934c12708 / jenkins-wrap.sh: Test wrapper for jenkins http://git.io/i2hZQw
20140617 19:01:12< mordante> lipkab, I'm not sure whether we should stick with plain SDL2 or have a look at SDL2 + OGL or even stick with SDL 1.2 :-(
20140617 19:01:38< mordante> can you have a look at SDL2 + OGL?
20140617 19:01:54< lipkab> *gulp*
20140617 19:02:00< lipkab> Yeah...
20140617 19:02:26< lipkab> I'll try to forget how intimidating OGL was when I once tried to use it.
20140617 19:03:53-!- Kexoth [~kex@93-142-142-215.adsl.net.t-com.hr] has joined #wesnoth-dev
20140617 19:04:24< mordante> :-)
20140617 19:04:39< mordante> well I'm not really sure what direction we should go
20140617 19:04:49< mordante> I expected SDL2 to be more mature
20140617 19:05:50< mordante> (of course we could also move to SDL2 and keep surfaces, but then the benefits are probably very small)
20140617 19:06:17< lipkab> And what's even worse, I'd be out of a job :)
20140617 19:06:43< mordante> yup, then we have to find you something different to work on during the summer
20140617 19:07:30< mordante> but I think there are enough things left to do in Wesnoth to keep you from getting bored ;-)
20140617 19:08:50< lipkab> I think I'll leave alone coding for a bit now and spend the next week exploring our options with SDL and OGL.
20140617 19:09:07< mordante> ok
20140617 19:09:17< mordante> how long do you think you need?
20140617 19:09:39< irker061> wesnoth: Alexander van Gessel wesnoth:1.12 fa39a1cb20ce / jenkins-wrap.sh: Test wrapper for jenkins http://git.io/u-2Fog
20140617 19:09:51< lipkab> I don't know.
20140617 19:10:53< irker061> wesnoth: Alexander van Gessel wesnoth:master 05d2fdfe4a69 / jenkins-wrap.sh: Make jenkins-wrap.sh executable http://git.io/4V3c2A
20140617 19:10:55< irker061> wesnoth: Alexander van Gessel wesnoth:1.12 9ec95b9339b1 / jenkins-wrap.sh: Make jenkins-wrap.sh executable http://git.io/0-5cNQ
20140617 19:11:36< mordante> I'm not sure whether I'll be around next Tuesday so I'd like to move our meeting to Thursday, does that also fit your schedule?
20140617 19:11:50< lipkab> Yes.
20140617 19:12:08< mordante> ok
20140617 19:12:18< lipkab> (Not this Thursday but the next one, I assume?)
20140617 19:12:49< mordante> yes
20140617 19:13:15< mordante> if you have some sample code, could you e-mail it so I can look at it before we meet?
20140617 19:13:25< lipkab> Sure.
20140617 19:14:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 19:14:24< mordante> do you have more questions for the moment?
20140617 19:14:47< lipkab> Yeah, there's something I forgot to ask last week.
20140617 19:15:05< lipkab> I see some OpenMP macros in image.cpp.
20140617 19:15:30< lipkab> Well, I have no clue how this stuff works, should I care about that right now?
20140617 19:16:02-!- Haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Read error: Connection reset by peer]
20140617 19:16:03< mordante> I'm not sure, not even sure whether OpenMP even works
20140617 19:16:31< mordante> boucman, implemented the OpenMP code, maybe he can explain it to you
20140617 19:17:03< lipkab> Okay.
20140617 19:17:11< lipkab> Well, then I'm done.
20140617 19:17:42< mordante> ok, then I'm off bye
20140617 19:18:26-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140617 19:18:36-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: .]
20140617 19:37:33-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140617 19:39:54< irker061> wesnoth: Chris Beck wesnoth:master 1aed8cb3edc0 / src/actions/ (create.cpp move.cpp): use a cheaper version of get_visible_unit when we only want bool http://git.io/DT_bdw
20140617 19:40:24-!- travis-ci [~travis-ci@ec2-54-87-241-23.compute-1.amazonaws.com] has joined #wesnoth-dev
20140617 19:40:24< travis-ci> [travis-ci] wesnoth/wesnoth#3257 (master - 9266fd3 : Chris Beck): The build has errored.
20140617 19:40:24< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27799495
20140617 19:40:24-!- travis-ci [~travis-ci@ec2-54-87-241-23.compute-1.amazonaws.com] has left #wesnoth-dev []
20140617 19:49:11-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140617 19:51:13-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW]
20140617 19:51:21-!- Jozrael [Jozrael@cpe-23-242-93-245.socal.res.rr.com] has quit [Ping timeout: 244 seconds]
20140617 19:52:01-!- Jozrael [~Jozrael@209.133.52.230] has joined #wesnoth-dev
20140617 19:53:11-!- ancestral_lunch is now known as ancestral
20140617 20:01:55< irker061> wesnoth: Chris Beck wesnoth:master d5aa4d3058f5 / src/actions/create.cpp: fixup a warning http://git.io/kpqVPw
20140617 20:02:14< AI0867> build is broken on jenkins, it seems
20140617 20:03:03< AI0867> http://baldras.wesnoth.org:8080/job/Wesnoth/183/branch=master,compiler=4.7,label=Gentoo-64/console
20140617 20:03:46< iceiceice> yeah i made a mistake like 5 minutes ago...
20140617 20:03:50< iceiceice> it should be fixed now
20140617 20:12:50< shadowm> mordante: I'll ask once again: Any specific examples? (It's not like the test scenario's inspect dialog info changes every run until you begin triggering events.)
20140617 20:13:09-!- gfgtdf [~chatzilla@f050176252.adsl.alicedsl.de] has joined #wesnoth-dev
20140617 20:16:35-!- travis-ci [~travis-ci@ec2-54-87-241-23.compute-1.amazonaws.com] has joined #wesnoth-dev
20140617 20:16:35< travis-ci> [travis-ci] wesnoth/wesnoth#3258 (master - 673934c : Alexander van Gessel): The build passed.
20140617 20:16:35< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27801539
20140617 20:16:35-!- travis-ci [~travis-ci@ec2-54-87-241-23.compute-1.amazonaws.com] has left #wesnoth-dev []
20140617 20:19:18-!- Netsplit *.net <-> *.split quits: timotei, Kexoth, vultraz, EliDupree, _8680_, Guest33895, Crendgrim
20140617 20:20:10-!- Netsplit over, joins: Crendgrim, _8680_, vultraz, Kexoth, Guest33895, timotei, EliDupree
20140617 20:24:49-!- Netsplit *.net <-> *.split quits: {V}, Coffee_irc
20140617 20:27:22-!- Guest33895 [~cib@p508BCAB7.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140617 20:28:47-!- Netsplit over, joins: Coffee_irc
20140617 20:29:31-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140617 20:33:46< irker061> wesnoth: Chris Beck wesnoth:master 6547c7e9e898 / src/ (7 files in 4 dirs): remove unit_map include from unit header http://git.io/aaufpg
20140617 20:35:42-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140617 20:36:40-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140617 20:36:48-!- travis-ci [~travis-ci@ec2-54-196-250-177.compute-1.amazonaws.com] has joined #wesnoth-dev
20140617 20:36:48< travis-ci> [travis-ci] wesnoth/wesnoth#3259 (1.12 - fa39a1c : Alexander van Gessel): The build has errored.
20140617 20:36:48< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27802438
20140617 20:36:48-!- travis-ci [~travis-ci@ec2-54-196-250-177.compute-1.amazonaws.com] has left #wesnoth-dev []
20140617 20:37:04< gfgtdf> iceiceice: can you currently play teh first scnraio of HttT ?
20140617 20:37:07< gfgtdf> the*
20140617 20:37:39< iceiceice> i think so
20140617 20:37:50< gfgtdf> iceiceice: can you test pls ?
20140617 20:37:55< iceiceice> yeah i just did
20140617 20:38:00< iceiceice> where is it breaking for you?
20140617 20:38:01< gfgtdf> iceiceice: hm
20140617 20:38:13< gfgtdf> i ge a segfault after teh story is sown
20140617 20:38:18< gfgtdf> get
20140617 20:38:20< gfgtdf> shown*
20140617 20:38:22< iceiceice> the only thing thats annoying is that the end turn hotkey doesnt work for me
20140617 20:38:46< iceiceice> do you have current master?
20140617 20:39:09< gfgtdf> iceiceice: off by a few commits i think
20140617 20:39:21< gfgtdf> but not more than 10
20140617 20:39:23< iceiceice> what commit is segfaulting?
20140617 20:40:09< gfgtdf> iceiceice: after i relbased 6b3af33fc8ddd2e4482b72d047d1bfe1314e9400 onto master
20140617 20:41:15< iceiceice> idk
20140617 20:41:54< gfgtdf> ill update to head and test agn
20140617 20:54:35< gfgtdf> iceiceice: 6547c7e9e898299070e95a4f94722d1ca5c589e6 segfaults too
20140617 20:55:19< iceiceice> after rebase or directly?
20140617 20:55:49< gfgtdf> update ref + cehckout to upstream master
20140617 20:56:14< gfgtdf> iceiceice: stacktrace http://pastebin.com/aXrpweF2
20140617 20:57:13< iceiceice> i dont think that commit caused it most likely
20140617 20:57:45< gfgtdf> iceiceice: like i said at 6b3af33fc8ddd2e4482b72d047d1bfe1314e9400 is was broken too
20140617 20:58:13< iceiceice> can you test this one?
20140617 20:58:14< iceiceice> 0be1d731d5ced297817aacdd023f47ec51f8cd5d
20140617 20:58:14< gfgtdf> iceiceice: at 63c07fea3e895a0791c95f954ac9686870f98878 it deinitly worked
20140617 20:59:38< gfgtdf> definitely*
20140617 21:12:00-!- dacovale [~niklas@93.182.140.32] has quit [Quit: Leaving.]
20140617 21:13:23< iceiceice> so the issue is the team is null?
20140617 21:14:44< iceiceice> idk its hard for me to do anything when i cant reproduce locally
20140617 21:15:47-!- gfgtdf_ [~chatzilla@e177166211.adsl.alicedsl.de] has joined #wesnoth-dev
20140617 21:15:55< gfgtdf_> iceiceice: why do you think tam is null ?
20140617 21:16:10< gfgtdf_> iceiceice: 0be1d731d5ced297817aacdd023f47ec51f8cd5d did not have this bug
20140617 21:16:13< iceiceice> idk what else would cause segfault at htis line:        wesnoth.exe!team::get_minimap_color(int side)  Zeile 803 + 0x1c Bytes   C++
20140617 21:18:27-!- gfgtdf [~chatzilla@f050176252.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds]
20140617 21:18:27-!- gfgtdf_ is now known as gfgtdf
20140617 21:18:29< gfgtdf> why should get_minimap_color give a segfauklt if tem is null ? i dont see how that line used this
20140617 21:18:40< iceiceice> if its being called on a null team i guess
20140617 21:19:01< AI0867> iceiceice: could we have run_wml_tests return something other than 1 on failure?
20140617 21:19:02< gfgtdf> iceiceice: calling something on a null doesnt cause a segfault
20140617 21:19:07< AI0867> that's what xvfb-run does
20140617 21:19:29< gfgtdf> iceiceice: only if *this is sctualy used
20140617 21:19:32< gfgtdf> actualy
20140617 21:19:49< gfgtdf> iceiceice: except for virtual functions
20140617 21:20:04< gfgtdf> that somehow of *this via teh vtable
20140617 21:20:18< iceiceice> AI0867: sure i dont see a problem
20140617 21:20:37< AI0867> iceiceice: I now rerun anythin that returns 1 up to 9 times
20140617 21:20:50< AI0867> because xvfb may mysteriously fail at random times
20140617 21:21:10< iceiceice> yeah i did that to the test executable a while ago
20140617 21:21:14< iceiceice> on travis
20140617 21:21:21< AI0867> so now, if a wml test fails, they all get rerun 9 times
20140617 21:21:36< AI0867> yeah, I cribbed quite a bit from that script
20140617 21:23:14< iceiceice> yeah
20140617 21:23:21< iceiceice> i think its only the last line of run_wml_tests that controls what it outputs
20140617 21:23:47< AI0867> of course, I forgot the most important bit
20140617 21:23:52< AI0867> returning a value
20140617 21:24:17< irker061> wesnoth: Alexander van Gessel wesnoth:master 1536aa102182 / jenkins-wrap.sh: Actually return the script's output http://git.io/MpR4Ig
20140617 21:24:28< irker061> wesnoth: Alexander van Gessel wesnoth:1.12 c997732df16d / jenkins-wrap.sh: Actually return the script's output http://git.io/YY-kVA
20140617 21:31:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20140617 21:33:47-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140617 21:35:21< iceiceice> gfgtdf: i think its that game_config::team_rgb_range is statically initialized?
20140617 21:35:28< iceiceice> its never initalized by play controller i think
20140617 21:35:35< iceiceice> so its probably a static initialiation order thing :/
20140617 21:35:45-!- Haudegen [~quassel@178.165.131.152.wireless.dyn.drei.com] has joined #wesnoth-dev
20140617 21:36:05< gfgtdf> iceiceice: hm but that code that causes the error doesnt run during static initilisation staticly
20140617 21:36:48< iceiceice> is static initialization guaranteed to take place before play_controller is contruscted?
20140617 21:36:55< iceiceice> *constructed
20140617 21:37:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20140617 21:38:34< iceiceice> idk those rules are really obscure to me
20140617 21:39:03< gfgtdf> iceiceice: yes it is
20140617 21:39:25< gfgtdf> iceiceice: ply_controller is not staicly contructoes
20140617 21:40:10< AI0867> iceiceice: yeah, I saw that. Is it okay if I bump that to 2 or something?
20140617 21:40:24< iceiceice> AI0867: y ofc
20140617 21:40:42-!- Jozrael2 [~Jozrael@209.133.52.233] has joined #wesnoth-dev
20140617 21:40:46< iceiceice> gfgtdf: hmm 
20140617 21:41:24-!- Jozrael [~Jozrael@209.133.52.230] has quit [Ping timeout: 255 seconds]
20140617 21:41:46< irker061> wesnoth: Alexander van Gessel wesnoth:master 3fe799a09168 / run_wml_tests: Change run_wml_tests failure exit code from 1 to 2 http://git.io/BnP3dw
20140617 21:42:24-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140617 21:42:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 21:43:08-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has left #wesnoth-dev []
20140617 21:45:47< iceiceice> gfgtdf: idk i dont really have a theory 
20140617 21:46:43< iceiceice> did you change your colors.cfg file?
20140617 21:49:15< gfgtdf> iceiceice: no
20140617 21:49:23< gfgtdf> iceiceice: also get_minimap_color is a static function
20140617 21:50:43-!- travis-ci [~travis-ci@ec2-54-89-18-138.compute-1.amazonaws.com] has joined #wesnoth-dev
20140617 21:50:43< travis-ci> [travis-ci] wesnoth/wesnoth#3262 (master - 1aed8cb : Chris Beck): The build was broken.
20140617 21:50:43< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27804468
20140617 21:50:43-!- travis-ci [~travis-ci@ec2-54-89-18-138.compute-1.amazonaws.com] has left #wesnoth-dev []
20140617 21:50:55< iceiceice> gfgtdf: the color info happens here: 	game_config::add_color_info(level);
20140617 21:50:59< iceiceice> hmm bad link
20140617 21:51:03< iceiceice> its in play_Controller.cpp anyways
20140617 21:58:05< Jozrael2> Question: should the amount of gold spent on recalls in statistics reflect the recall cost, or the unit's cost.
20140617 21:58:21< Jozrael2> E.g. if I recall a white mage, should I have a recall cost in statistics of 20 (what I paid) or 40 (what a white mage is worth)
20140617 21:58:26-!- Jozrael2 is now known as Jozrael
20140617 21:58:53< Jozrael> Current behavior (at least in 1.11.12): the latter. I feel like the former might be more relevant.
20140617 21:59:08< Jozrael> As the latter isn't what I'm ever actually spending.
20140617 21:59:37-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140617 21:59:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20140617 22:00:56-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140617 22:02:19< iceiceice> Jozrael: if its the latter that sounds like a bug to me
20140617 22:04:43< Jozrael> kk
20140617 22:06:47-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140617 22:07:18-!- mjs-de [~mjs-de@g228037045.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140617 22:08:09< gfgtdf> iceiceice: hm ok i'll make a debug build
20140617 22:09:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 22:09:52-!- Kexoth [~kex@93-142-142-215.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140617 22:09:54-!- kex_ [~kex@93-137-12-223.adsl.net.t-com.hr] has joined #wesnoth-dev
20140617 22:09:54-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140617 22:10:32< iceiceice> jozrael: it looks like the current code has been in place since 2006
20140617 22:22:44-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140617 22:23:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140617 22:23:34-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140617 22:25:37-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has quit [Ping timeout: 245 seconds]
20140617 22:26:54< iceiceice> Jozrael: i think you should make a bug report
20140617 22:31:09< gfgtdf> iceiceice: and ofc the debug build crashed on startup most liley related to soemthign completely different ..
20140617 22:31:58< iceiceice> :/
20140617 22:38:58-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has joined #wesnoth-dev
20140617 22:40:49< gfgtdf> iceiceice: can you fix: https://github.com/wesnoth/wesnoth/blob/master/src/actions/create.cpp#L195 ? You canot dereference the iterator before you have checked iterator. == end
20140617 22:42:23-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has quit [Remote host closed the connection]
20140617 22:42:27< iceiceice> y sry
20140617 22:43:17< iceiceice> gfgtdf: hmm its wierd though
20140617 22:43:24< iceiceice> it looks like thats what the code was doing before also
20140617 22:43:29< iceiceice> https://github.com/wesnoth/wesnoth/commit/9e7dc5ba008298d823c13cff214f7477601b5efd#diff-28078bf70ba7d9cfc59a6e9ae6390742R228
20140617 22:44:02< iceiceice> no i just misunderstood
20140617 22:44:03< iceiceice> ok
20140617 22:46:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140617 22:49:01< irker061> wesnoth: Chris Beck wesnoth:master a0b849596cab / src/actions/create.cpp: fixup 9e7dc5ba008298d823c13cff214f7477601b5efd http://git.io/qT434g
20140617 22:53:11< gfgtdf> ok on forth try i finally get the same bug as in the release mode
20140617 22:54:28-!- travis-ci [~travis-ci@ec2-54-196-250-177.compute-1.amazonaws.com] has joined #wesnoth-dev
20140617 22:54:28< travis-ci> [travis-ci] wesnoth/wesnoth#3260 (master - 05d2fdf : Alexander van Gessel): The build passed.
20140617 22:54:28< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27802506
20140617 22:54:28-!- travis-ci [~travis-ci@ec2-54-196-250-177.compute-1.amazonaws.com] has left #wesnoth-dev []
20140617 22:57:18-!- Haudegen [~quassel@178.165.131.152.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140617 23:01:23< gfgtdf> iceiceice: ok i have absolutely no idea what happens ... from looking at the asm code it seems like the code trie to dereference the passed "int side" argument :/
20140617 23:02:12< iceiceice> idk maybe try to clean the build and try again?
20140617 23:02:27< iceiceice> it sounds like the compiler got confused somehow
20140617 23:04:47< gfgtdf> iceiceice: http://pastebin.com/BpbZW9z3
20140617 23:07:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20140617 23:08:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140617 23:09:52< iceiceice> ok i still broke the build i think
20140617 23:11:42< gfgtdf> iceiceice: i think you just could have moved the line UnitPtr & recall_list_element = *recall_list_it; in the else block.
20140617 23:11:52< iceiceice> yeah i should have done that
20140617 23:11:52< iceiceice> im going to patch it
20140617 23:12:00< iceiceice> idk i am tired rihgt now or something :/
20140617 23:14:44-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has quit [Remote host closed the connection]
20140617 23:15:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140617 23:16:02-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140617 23:20:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20140617 23:21:04< irker061> wesnoth: Chris Beck wesnoth:master d119fe7e1892 / src/actions/create.cpp: fixup the fixup http://git.io/3F97aA
20140617 23:24:38-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140617 23:27:26< iceiceice> gfgtdf: what do you think will be helpful with the segfault?
20140617 23:27:39< iceiceice> i guess i could try to make assembly code also and compare/
20140617 23:27:39< iceiceice> idk
20140617 23:27:45< iceiceice> do you have another compiler?
20140617 23:27:51< gfgtdf> iceiceice: no
20140617 23:28:10< iceiceice> maybe you can install mingw32 or smth and see if that also segfaults?
20140617 23:28:18< iceiceice> or upgrade/
20140617 23:28:18< iceiceice> idk
20140617 23:28:37< iceiceice> do you think its a compiler bug?
20140617 23:29:23< gfgtdf> hm i have never occured a compiler bug.. so its kinda hard to believe..
20140617 23:29:36< iceiceice> heh i mean i never heard of gcc segfaulting until yesterday
20140617 23:30:35< gfgtdf> iceiceice: maybe its teh same bug :O
20140617 23:31:02< iceiceice> idk
20140617 23:31:08< iceiceice> i think the segfault was in replay.cpp
20140617 23:31:20< iceiceice> and its gone now afaict 
20140617 23:35:09< irker061> wesnoth: Chris Beck wesnoth:master 393a16e87168 / src/ai/ (actions.cpp actions.hpp): favor to return a smart pointer in ai/actions recall_unit http://git.io/YZ5udw
20140617 23:52:49< AI0867> iceiceice: when does this occur?
20140617 23:53:48< iceiceice> only on gfgtdf's machine
20140617 23:53:56< iceiceice> afaik
20140617 23:55:13< AI0867> always in this place?
20140617 23:56:20< iceiceice> i only know what's in the chat log
--- Log closed Wed Jun 18 00:00:20 2014