--- Log opened Wed Jun 18 00:00:20 2014
--- Day changed Wed Jun 18 2014
20140618 00:00:20< AI0867> and why is line 27 not equal to line 15?
20140618 00:00:40< AI0867> I mean, edx instead of eax, but it says [ebp-8], not [side]
20140618 00:00:44< AI0867> er +8
20140618 00:01:43< gfgtdf> http://pastebin.com/K4vxt62M
20140618 00:02:56< gfgtdf> AI0867: hm good question 
20140618 00:03:23< AI0867> that second bit looks much more sane
20140618 00:03:33< AI0867> it's essentially the same function with the segfault stripped out
20140618 00:03:44< AI0867> that ptr [ebp+8] twiddling
20140618 00:08:38-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has joined #wesnoth-dev
20140618 00:18:44-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has quit [Quit: Turuk]
20140618 00:19:04-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has joined #wesnoth-dev
20140618 00:21:51< gfgtdf> AI0867: the code are different: teh good code seems to search for side in ebp+8 the base code searches for side in ebp+c
20140618 00:22:53< gfgtdf> AI0867: the bas code sems to assume some pointer to the return valure passed in ebp+8
20140618 00:22:55< gfgtdf> bad
20140618 00:24:13< AI0867> makes sense for something that doesn't fit in eax
20140618 00:24:20< AI0867> SDL_Color is 32 bits wide, but still
20140618 00:28:40-!- sachith500|2 [~kvirc@112.134.25.125] has joined #wesnoth-dev
20140618 00:31:02-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140618 00:31:45-!- travis-ci [~travis-ci@ec2-54-89-18-138.compute-1.amazonaws.com] has joined #wesnoth-dev
20140618 00:31:45< travis-ci> [travis-ci] wesnoth/wesnoth#3267 (master - 3fe799a : Alexander van Gessel): The build has errored.
20140618 00:31:45< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27813568
20140618 00:31:45-!- travis-ci [~travis-ci@ec2-54-89-18-138.compute-1.amazonaws.com] has left #wesnoth-dev []
20140618 00:32:24-!- sachith500 [~kvirc@112.135.23.102] has joined #wesnoth-dev
20140618 00:32:33-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has quit [Ping timeout: 240 seconds]
20140618 00:34:33-!- sachith500|2 [~kvirc@112.134.25.125] has quit [Ping timeout: 240 seconds]
20140618 00:35:22< gfgtdf> iceiceice:  about https://github.com/wesnoth/wesnoth/commit/045f38196d4fd9de20c7110b814a955f3b598724
20140618 00:35:26-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140618 00:35:56< gfgtdf> iceiceice: why do you forward-declare SDL_Color if get_minimap_color returns it by value ?
20140618 00:35:57< mattsc> gfgtdf: btw, have you been able to confirm the assert I mentioned earlier?
20140618 00:36:22< gfgtdf> mattsc: shoudl have need fixed in https://github.com/wesnoth/wesnoth/commit/6b3af33fc8ddd2e4482b72d047d1bfe1314e9400
20140618 00:36:33< iceiceice> gfgtdf: i thought that was okay
20140618 00:36:36< iceiceice> it seems to compile fine
20140618 00:36:56-!- prophile [~alynn@oftn/member/prophile] has quit [Client Quit]
20140618 00:36:58< mattsc> gfgtdf: ah, okay, sorry.  I’ve been swamped at work, so haven’t been able to keep up with you guys.
20140618 00:37:04< iceiceice> http://stackoverflow.com/questions/553682/when-can-i-use-a-forward-declaration
20140618 00:37:08< mattsc> I’ll test it in a little while.
20140618 00:37:24< iceiceice> including SDL.h is fairly heavy,
20140618 00:37:33< iceiceice> we shouldn't need to do that except in graphics related code.
20140618 00:37:46< iceiceice> the core engine should be able to run without including SDL
20140618 00:38:06< iceiceice> or at least, the basic types like unit_map and team
20140618 00:38:18< iceiceice> at least in the header anyways
20140618 00:38:36< iceiceice> if we include SDL.h in team thats going to result in almost all of the code including it
20140618 00:38:53< iceiceice> because team is used by most of the highlevel code and also the low level code
20140618 00:39:01< gfgtdf> iceiceice: hm i was pretty sure that you arent alowed to forward declare a by-value returnvalue, gotta look it up on google i think
20140618 00:40:45-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140618 00:41:05-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has joined #wesnoth-dev
20140618 00:42:27< aquileia> iceiceice: just so that you know, test_unit_map aborts on my build
20140618 00:43:24< iceiceice> :/
20140618 00:43:29< aquileia> alice_kills_bob as well...
20140618 00:43:42< iceiceice> are you getting segfaults?
20140618 00:43:44< aquileia> 'll rerun them as soon as they are done
20140618 00:46:54< gfgtdf> iceiceice: ok seems liek this is indeed a msvc bug: http://stackoverflow.com/questions/4312679/is-returning-a-forward-declared-structure-undefined-behavior
20140618 00:47:14-!- aquileia_ [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140618 00:48:07-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140618 00:48:53< iceiceice> ok thats wierd
20140618 00:48:54< aquileia_> Hmm... I can't reproduce it!
20140618 00:49:08< iceiceice> gfgtdf: what do you want to do?
20140618 00:49:28< iceiceice> we could i guess try to rearrange the headers until it works like the thing says
20140618 00:49:39< iceiceice> i guess we could just not forward declare structures
20140618 00:50:01< gfgtdf> iceiceice: idk my first idea was include "SDL.h" before "team.hpp" in all files that use that function
20140618 00:50:03< iceiceice> in this case could probably return const ref anyways, its like a team color?
20140618 00:50:11< iceiceice> oh 
20140618 00:50:15< iceiceice> yeah thats a good idea anyways i guess
20140618 00:50:22< irker061> wesnoth: mattsc wesnoth:master 9593d10050e5 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project http://git.io/Hgk8SA
20140618 00:51:42< gfgtdf> iceiceice: gotta test whether that works before still
20140618 00:52:53< gfgtdf> or maybe i shgoudl just ge a newer version of msvc ..
20140618 00:53:36< iceiceice> gfgtdf: i also forward declare unit_map::extract
20140618 00:53:43< iceiceice> it returns UnitPtr now...
20140618 00:54:05< iceiceice> aquileia_: ^ that might explain if you are failing a test?
20140618 00:55:58< aquileia_> iceiceice: I'm not reproducibly failing any tests right now... three runs, five errors, none twice
20140618 00:58:43< mattsc> gfgtdf: yep, it’s working again.  Thanks!
20140618 00:58:45< iceiceice> aquileia_: what version of VC do you have?
20140618 00:59:05< aquileia_> VC12 from 2013
20140618 01:00:35< aquileia_> It's cetainly not good to randomly fail tests, but its not that big an issue as long as no test fails twice
20140618 01:01:49< aquileia_> And right now I passed all of the WML tests without exception
20140618 01:02:37< aquileia_> As I don't really have time, I'll call that fixed =P
20140618 01:05:50< iceiceice> ok so you dont think you have the same thing as gfgtdf/
20140618 01:05:52< iceiceice> ?
20140618 01:06:30< aquileia_> iceiceice: It's definitely someting else I'd say
20140618 01:06:42< aquileia_> *something
20140618 01:08:55< iceiceice> ok
20140618 01:08:59< iceiceice> thx
20140618 01:09:29< iceiceice> gfgtdf: im not sure if include "SDL.h" will work in all the places that use the function?
20140618 01:09:36< iceiceice> because they must be getting the full definition eventually or it wouldnt compile
20140618 01:09:54< iceiceice> so i guess its already the case that they include "SDL.h" somehow
20140618 01:11:04< gfgtdf> iceiceice: i dont understand
20140618 01:12:26< iceiceice> so you could just revert my commit
20140618 01:12:30< iceiceice> and include SDL.h in team.hpp
20140618 01:12:50< iceiceice> if you are just going to add SDL.h in all the compilation units that use the fcn,
20140618 01:12:57< iceiceice> i guess that wont fix it?
20140618 01:12:58-!- aquileia_ [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140618 01:13:01< iceiceice> because the compilation units already have SDL.h
20140618 01:13:15-!- travis-ci [~travis-ci@ec2-54-196-250-177.compute-1.amazonaws.com] has joined #wesnoth-dev
20140618 01:13:15< travis-ci> [travis-ci] wesnoth/wesnoth#3270 (master - 393a16e : Chris Beck): The build passed.
20140618 01:13:15< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27820297
20140618 01:13:15-!- travis-ci [~travis-ci@ec2-54-196-250-177.compute-1.amazonaws.com] has left #wesnoth-dev []
20140618 01:13:18< iceiceice> the bug is some wierd MSVC thing, it depends on the order that headers appear or something (acording to stack over flow)
20140618 01:15:08-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140618 01:21:46< gfgtdf> mut some of then include t before team.h ad some after
20140618 01:21:49< gfgtdf> but*
20140618 01:22:12< gfgtdf> so the plan is to always include sdl.h before incluning team.h for all units that use that function 
20140618 01:23:56< iceiceice> hmm ok
20140618 01:26:14< gfgtdf> bbl
20140618 01:26:16-!- gfgtdf [~chatzilla@e177166211.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140618 01:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 240 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140618 01:37:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140618 01:45:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140618 01:47:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140618 01:47:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20140618 01:57:01-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has left #wesnoth-dev []
20140618 02:04:26-!- Ivanovic_ [~ivanovic@frnk-5f74fdc2.pool.mediaWays.net] has joined #wesnoth-dev
20140618 02:04:26-!- Ivanovic_ [~ivanovic@frnk-5f74fdc2.pool.mediaWays.net] has quit [Changing host]
20140618 02:04:26-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140618 02:07:41-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20140618 02:08:21-!- Ivanovic_ is now known as Ivanovic
20140618 02:12:46-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 02:13:39-!- kex_ [~kex@93-137-12-223.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140618 02:14:27< gfgtdf> iceiceice: im not anymore sure that including sdl.h before tema.h is a good idea.  If you think SDL.h is a too bug include why not just inlude SDL_video.h ?
20140618 02:14:58< iceiceice> idk i dont know anything about SDL,
20140618 02:15:03-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has joined #wesnoth-dev
20140618 02:15:07< iceiceice> but i'm pretty sure its not really necessary to be incldued for the interface of team
20140618 02:15:12-!- Jozrael [~Jozrael@209.133.52.233] has quit [Ping timeout: 245 seconds]
20140618 02:15:12< iceiceice> so i tried to move it out
20140618 02:15:35< shadowm> >idk i dont know
20140618 02:15:38< iceiceice> the only reason it needs it is to return SDL_Color
20140618 02:18:43-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has joined #wesnoth-dev
20140618 02:19:21-!- Jozrael [~Jozrael@cpe-23-242-93-245.socal.res.rr.com] has joined #wesnoth-dev
20140618 02:20:03-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140618 02:20:57-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140618 02:24:11-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds]
20140618 02:27:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140618 02:28:18-!- sachith500 [~kvirc@112.135.23.102] has quit [Read error: Connection reset by peer]
20140618 02:34:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140618 02:43:41-!- sachith500 [~kvirc@112.135.23.102] has joined #wesnoth-dev
20140618 02:44:23-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Read error: Connection reset by peer]
20140618 02:45:47-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140618 02:47:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140618 02:48:45-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 255 seconds]
20140618 02:51:49-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20140618 02:51:54-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20140618 02:51:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140618 03:01:37-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140618 03:03:50-!- sachith500|2 [~kvirc@112.134.152.150] has joined #wesnoth-dev
20140618 03:04:22-!- sachith500 [~kvirc@112.135.23.102] has quit [Ping timeout: 245 seconds]
20140618 03:06:30-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140618 03:07:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140618 03:13:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140618 03:19:36-!- sachith500|2 [~kvirc@112.134.152.150] has quit [Read error: Connection reset by peer]
20140618 03:48:30-!- sachith500 [~kvirc@112.134.136.64] has joined #wesnoth-dev
20140618 03:51:53-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20140618 03:56:47-!- Guest33895 [~cib@p5DD20F4D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140618 04:00:46-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140618 04:04:15-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has joined #wesnoth-dev
20140618 04:08:34-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140618 04:28:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140618 04:35:12-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140618 04:35:21-!- Guest33895 is now known as cib1
20140618 04:38:40-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140618 04:42:04-!- Necrosporus_ is now known as Necrosporus
20140618 04:45:29-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140618 04:55:07-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 0.4.2]
20140618 04:55:57-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20140618 04:55:57-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20140618 04:55:57-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20140618 04:56:28-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140618 05:00:12-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 245 seconds]
20140618 05:20:16-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 264 seconds]
20140618 05:24:15-!- mjs-de [~mjs-de@g228037045.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 05:24:26-!- markus_ [~mjs-de@g228037045.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 05:24:32-!- markus_ [~mjs-de@g228037045.adsl.alicedsl.de] has quit [Client Quit]
20140618 05:38:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140618 05:38:34-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20140618 05:38:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Client Quit]
20140618 05:39:06-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140618 05:52:57-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has joined #wesnoth-dev
20140618 05:57:24-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has quit [Ping timeout: 244 seconds]
20140618 06:14:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20140618 06:15:22-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140618 06:19:55-!- Netsplit *.net <-> *.split quits: shadowm, sachith500
20140618 06:22:19-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140618 06:24:02-!- Netsplit over, joins: shadowm, sachith500
20140618 06:33:57-!- cib1 [~cib@p5DD20F4D.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20140618 06:49:08-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140618 07:11:11-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140618 07:19:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140618 07:20:51-!- Trademark [~trademark@2001:660:3004:64:59d1:5cab:1e4e:83e3] has joined #wesnoth-dev
20140618 07:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 241 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140618 07:39:23-!- cib_ [~cib@132.231.178.90] has joined #wesnoth-dev
20140618 07:40:21-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has joined #wesnoth-dev
20140618 07:41:55-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has joined #wesnoth-dev
20140618 07:46:25-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has quit [Ping timeout: 244 seconds]
20140618 07:46:29-!- cib_ [~cib@132.231.178.90] has quit [Ping timeout: 272 seconds]
20140618 08:09:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140618 08:22:20-!- irker061 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140618 08:36:28-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20140618 08:42:04-!- Bodhi-Baum [~Bodhi@dslb-084-063-015-243.pools.arcor-ip.net] has joined #wesnoth-dev
20140618 08:43:30-!- Bodhi-Baum [~Bodhi@dslb-084-063-015-243.pools.arcor-ip.net] has quit [Client Quit]
20140618 09:01:38-!- Haudegen_ [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20140618 09:07:44-!- markus_ [~mjs-de@f049247187.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 09:11:24-!- mjs-de [~mjs-de@g228037045.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140618 09:12:15-!- Haudegen_ is now known as Haudegen
20140618 09:12:23-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140618 09:25:09-!- sachith500 [~kvirc@112.134.136.64] has quit [Read error: Connection reset by peer]
20140618 09:30:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20140618 09:30:17-!- vultraz_ [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140618 09:31:29-!- _8680_ [~8680@2002:4404:712c:0:c84f:cbc3:4b1:7855] has quit [Ping timeout: 264 seconds]
20140618 09:31:48-!- _8680_ [~8680@2002:4404:712c:0:e0ed:e56a:d542:3376] has joined #wesnoth-dev
20140618 09:33:59-!- markus_ is now known as [Naldar]Jorgas
20140618 09:34:43-!- vultraz_ [~chatzilla@124.109.10.167] has quit [Ping timeout: 240 seconds]
20140618 09:39:23-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140618 09:39:33-!- Kexoth [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140618 09:39:55-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140618 09:40:06-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20140618 09:54:34-!- cib_ [~cib@132.231.178.201] has joined #wesnoth-dev
20140618 09:57:06-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140618 09:57:06-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20140618 09:57:06-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140618 10:07:03-!- [Naldar]Jorgas [~mjs-de@f049247187.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds]
20140618 10:08:05-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140618 10:09:10-!- travis-ci [~travis-ci@ec2-54-89-18-138.compute-1.amazonaws.com] has joined #wesnoth-dev
20140618 10:09:10< travis-ci> [travis-ci] wesnoth/wesnoth#3267 (master - 3fe799a : Alexander van Gessel): The build passed.
20140618 10:09:10< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27813568
20140618 10:09:10-!- travis-ci [~travis-ci@ec2-54-89-18-138.compute-1.amazonaws.com] has left #wesnoth-dev []
20140618 10:18:27-!- cib_ [~cib@132.231.178.201] has quit [Ping timeout: 264 seconds]
20140618 10:19:11-!- [Naldar]Jorgas [~mjs-de@vp-c-69.cs.uni-dortmund.de] has joined #wesnoth-dev
20140618 10:23:57-!- [Naldar]Jorgas is now known as mjs-de
20140618 10:29:39-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has joined #wesnoth-dev
20140618 10:37:08-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140618 10:44:52-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140618 11:03:59-!- sachith500 [~kvirc@112.134.136.64] has joined #wesnoth-dev
20140618 11:09:33-!- sachith500 [~kvirc@112.134.136.64] has quit [Ping timeout: 240 seconds]
20140618 11:09:53-!- sachith500 [~kvirc@112.134.154.15] has joined #wesnoth-dev
20140618 11:10:11-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW]
20140618 11:10:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140618 11:15:51< AI0867> according to jenkins, the sighted events is replay-broken on 64-bit debian: http://wesnoth.org:8080/job/Wesnoth/branch=master,compiler=default,label=Debian7-64/185/console (but only on that VM)
20140618 11:18:09< AI0867> iceiceice: ^
20140618 11:30:48< vultraz> I think [end_turn] may be broken
20140618 11:30:52< vultraz> I have to test again
20140618 11:47:26-!- sachith500|2 [~kvirc@112.135.131.128] has joined #wesnoth-dev
20140618 11:47:42-!- sachith500 [~kvirc@112.134.154.15] has quit [Ping timeout: 245 seconds]
20140618 11:49:23-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140618 11:59:31-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20140618 12:00:50-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140618 12:04:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140618 12:09:31-!- cib_ [~cib@132.231.178.142] has joined #wesnoth-dev
20140618 12:16:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140618 12:24:22-!- cib_ [~cib@132.231.178.142] has quit [Ping timeout: 245 seconds]
20140618 12:25:59-!- sachith500|2 [~kvirc@112.135.131.128] has quit [Read error: Connection reset by peer]
20140618 12:26:15-!- sachith500|2 [~kvirc@112.135.131.128] has joined #wesnoth-dev
20140618 12:28:24-!- mjs-de [~mjs-de@vp-c-69.cs.uni-dortmund.de] has quit [Ping timeout: 240 seconds]
20140618 12:33:46-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20140618 12:43:56-!- mjs-de [~mjs-de@f049247187.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 12:45:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140618 12:47:33-!- mjs-de [~mjs-de@f049247187.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140618 12:51:31-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140618 12:53:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140618 13:02:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140618 13:17:19-!- Trademark [~trademark@2001:660:3004:64:59d1:5cab:1e4e:83e3] has quit [Ping timeout: 252 seconds]
20140618 13:21:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140618 13:22:07-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140618 13:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 242 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140618 13:39:41-!- Turuk_ [40399531@gateway/web/cgi-irc/kiwiirc.com/ip.64.57.149.49] has joined #wesnoth-dev
20140618 13:42:53-!- Turuk_ [40399531@gateway/web/cgi-irc/kiwiirc.com/ip.64.57.149.49] has quit [Client Quit]
20140618 13:43:04-!- Turuk_ [40399531@gateway/web/cgi-irc/kiwiirc.com/ip.64.57.149.49] has joined #wesnoth-dev
20140618 13:44:07-!- sachith500 [~kvirc@112.134.117.182] has joined #wesnoth-dev
20140618 13:44:33-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140618 13:46:01-!- sachith500|2 [~kvirc@112.135.131.128] has quit [Ping timeout: 244 seconds]
20140618 14:00:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140618 14:09:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140618 14:24:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140618 14:25:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20140618 14:27:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140618 14:29:03-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 14:29:39< gfgtdf> is there any reason aginst compiling for x64 instead of for 32bit for windows?
20140618 14:30:26< iceiceice> AI0867: i think i know what the problem is that you mentioned
20140618 14:35:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140618 14:40:04-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140618 14:45:51< AI0867> gfgtdf: besides distribution to x86 users?
20140618 14:46:10< AI0867> does windows have fat binaries?
20140618 14:52:15-!- mjs-de [~mjs-de@f049247187.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 14:55:07-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 14:55:20< gfgtdf> AI0867: for personal use. What are fat binaries ?
20140618 14:56:19< gfgtdf> AI0867: ok i looked up fat binare, it seems like windows oesnt have
20140618 14:56:24< gfgtdf> binaries
20140618 14:56:42< gfgtdf> ofc x64 os can run 32bit binaries
20140618 14:57:08< gfgtdf> at lest for normal user programms, idk whether that also true for drivers
20140618 15:06:04< iceiceice> AI0867: ok i really dont have any idea right now what is going wrong there but i will try to figure it out
20140618 15:06:20< iceiceice> its very wierd that it would only happen now and not 5 days ago
20140618 15:20:15-!- cib_ [~cib@p5DD20F4D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140618 15:23:10< AI0867> iceiceice: it also happened in just one of the 8 native master builds
20140618 15:23:24< mattsc> gfgtdf: fat binaries are those that contain both the x86 and 64-bit executables (or whatever multiple versions).  So the 64-bit OS would use the 64-bit version, but they can also be run on 32bit-only systems.
20140618 15:25:11< iceiceice> AI0867: yeah but there mgiht be some pointer problem 
20140618 15:25:21< iceiceice> idk if its undefined behavior it might only sure up rarely
20140618 15:25:23< iceiceice> *show up
20140618 15:25:49< iceiceice> i made a large change here,
20140618 15:25:51< iceiceice> https://github.com/wesnoth/wesnoth/commit/9e7dc5ba008298d823c13cff214f7477601b5efd#diff-28078bf70ba7d9cfc59a6e9ae6390742R415
20140618 15:27:56< iceiceice> does anyone know why we dont assign a new underlying id when a unit is copy constructed?
20140618 15:28:14< iceiceice> maybe that's related idk
20140618 15:33:52-!- irker692 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140618 15:33:52< irker692> wesnoth: Chris Beck wesnoth:master 000c71a2c24b / src/actions/create.cpp: fixup 9e7dc5ba008298d823c13cff214f7477601b5efd http://git.io/r1wY4g
20140618 15:33:52< irker692> wesnoth: Chris Beck wesnoth:master 12515a646679 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/2Gz9Kw
20140618 15:34:19-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140618 15:38:47-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 15:44:59-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140618 15:45:18-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140618 15:47:25-!- sachith500 [~kvirc@112.134.117.182] has quit [Read error: Connection reset by peer]
20140618 15:56:19-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140618 16:08:43-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 272 seconds]
20140618 16:17:18-!- Haudegen [~quassel@85-126-180-242.volume.xdsl-line.inode.at] has quit [Remote host closed the connection]
20140618 16:19:02-!- travis-ci [~travis-ci@ec2-54-242-73-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20140618 16:19:02< travis-ci> [travis-ci] wesnoth/wesnoth#3273 (master - 12515a6 : Chris Beck): The build has errored.
20140618 16:19:02< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27875913
20140618 16:19:02-!- travis-ci [~travis-ci@ec2-54-242-73-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20140618 16:22:20-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140618 16:32:36-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140618 16:55:10-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140618 16:56:00-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140618 16:59:20< AI0867> iceiceice: maybe the original can be destroyed before the copy goes back on the map?
20140618 16:59:29< AI0867> actually, I'm sure that happens in some cases
20140618 17:00:39< AI0867> the optimization we did a while back prevented units on the heap from being copied and discarded if lua placed them back on the map
20140618 17:01:05< iceiceice> i think maybe we shuold change the unit_map
20140618 17:01:09< iceiceice> so that it doesnt copy the units privately
20140618 17:01:13< iceiceice> and just takes unit pointers
20140618 17:01:17< iceiceice> with the reference counting
20140618 17:01:18< AI0867> it does that?
20140618 17:01:21< iceiceice> yeah
20140618 17:01:23< AI0867> copy units by value?
20140618 17:01:38< AI0867> er, that's two things, but you get what I mean
20140618 17:02:07< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/unit_map.cpp#L74
20140618 17:02:17< iceiceice> thats the current state, but its after a faithful refactor
20140618 17:02:46< iceiceice> here's from 2012: https://github.com/wesnoth/wesnoth/blob/6ca69b2df58faeeb2fa13091c8e8acd1bd2b39e4/src/unit_map.cpp#L82
20140618 17:03:23< AI0867> yeah, I just found that
20140618 17:03:37< AI0867> that's because it takes references, and wants to own a pointer
20140618 17:05:10< iceiceice> yeah
20140618 17:05:22< iceiceice> i mean i guess it has to do that with the old system
20140618 17:05:44< iceiceice> if we always store units in an intrusive_ptr though, then i dont think it needs to make a copy
20140618 17:08:36-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140618 17:08:54< AI0867> well, that depends
20140618 17:09:06< AI0867> if someone takes a pointer to a unit owned by unit_map
20140618 17:09:09< AI0867> and then inserts that
20140618 17:09:24< AI0867> (not that I think that's a situation that currently happens)
20140618 17:10:11< AI0867> rust has such nice borrowed_reference vs owned box semantics for this
20140618 17:10:37< AI0867> though I suppose we could use const for this
20140618 17:11:24-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20140618 17:11:58< iceiceice> so what i would like to do is have most of the modules always handle units in UnitPtr's
20140618 17:12:06< iceiceice> and not pass const unit * around
20140618 17:12:40< iceiceice> i already made it so that unit_map::extract returns a unit_ptr and not a unit *
20140618 17:13:03< iceiceice> theres still some places where unit *'s are passed around of couse but afaik not in any module that "owns" a unit
20140618 17:13:18< iceiceice> if you own a unit that is supposed to mean you incremented its reference counter
20140618 17:13:34< iceiceice> and its stored with the unit, so there's no way another module could get confused about this
20140618 17:14:47< iceiceice> in current master at least, the unit map doesn't destroy any units anymore
20140618 17:15:05< iceiceice> when you "extract" all that means is that it destroyed its UnitPtr, which decremented the unit ref count
20140618 17:15:23< iceiceice> if there's some other module with a valid pointer (or the extracted ptr), that keeps the unit alive
20140618 17:18:48< iceiceice> if we use a system like this then i think we would never need to make copies of the unit object, other than when it is allocated from a config or something
20140618 17:19:24< iceiceice> but i might not have thought of every situation yet, im just changing things over slowly
20140618 17:24:02< AI0867> iceiceice: yes, but you can now both extract and find, and the former will give you a UnitPtr, and the latter will give you an iterator that you can dereference to get a UnitPtr
20140618 17:24:34< iceiceice> yeah i mean that part wont change i guess
20140618 17:24:50-!- Haudegen_ [~quassel@91.141.2.26.wireless.dyn.drei.com] has joined #wesnoth-dev
20140618 17:27:48< iceiceice> hmm about the "fix VC build" thing
20140618 17:28:01< iceiceice> i thoguht that intrusive_ptr was like smart_ptr, and would resolve to bool
20140618 17:28:15< iceiceice> is that not actually true?
20140618 17:28:18< AI0867> yeah, but if you now insert a UnitPtr, it will get a location. If you got it from extract, that's fine. If you got it from an iterator, you've broken the previous location of the unit
20140618 17:28:26< AI0867> iceiceice: safe_bool
20140618 17:28:41< AI0867> so you can't accidentally use it to index a string or something like that
20140618 17:29:02< AI0867> which is typically implemented as a pointer to some private time
20140618 17:29:12< AI0867> NULL is false, everything else is true
20140618 17:29:13< iceiceice> yeah
20140618 17:29:26< iceiceice> you're right, its the "unspecified bool type" 
20140618 17:29:27< iceiceice> http://www.boost.org/doc/libs/1_55_0/libs/smart_ptr/intrusive_ptr.html
20140618 17:29:41< iceiceice> does VC not do that or something?
20140618 17:30:37< AI0867> I dunno
20140618 17:30:42< AI0867> VC is being stupid
20140618 17:30:57< AI0867> it's *meant* to be used as if(intrusive_ptr)
20140618 17:32:49< iceiceice> "if you now insert a UnitPtr it will get a location"
20140618 17:33:09< iceiceice> yeah i guess if i want it not to make copies i will have to review all the places that add is used
20140618 17:36:24-!- Haudegen_ is now known as Haudegen
20140618 17:40:55< AI0867> this could already happen by doing unit_map.insert(&*unit_map.find(...)), but that's less likely to happen
20140618 17:42:04-!- Kexoth [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140618 17:44:41< iceiceice> i mean one quesiton though is, why do we want to make copies of units
20140618 17:44:44< iceiceice> thats fairly expensive
20140618 17:44:50< iceiceice> and i guess we already tried to facotr it out
20140618 17:44:57< iceiceice> at least in one place
20140618 17:46:48< AI0867> well, if you want to unstore a unit to copy it (from WML)
20140618 17:49:31< iceiceice> yeah so i'm looking at that code in action_wml.cpp
20140618 17:49:42< iceiceice> it looks like we construct the unit once using the constructor that takes a config
20140618 17:50:01< iceiceice> then we add it 
20140618 17:50:12< iceiceice> which will call the copy constructor
20140618 17:50:15< iceiceice> and the original is destroyed
20140618 17:51:06< iceiceice> at least in that place i'm not sure if the side effect is important
20140618 17:51:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140618 17:54:30< irker692> wesnoth: Chris Beck wesnoth:master a4b194c0794d / / (25 files in 11 dirs): add recall list manager http://git.io/9NLX5g
20140618 17:54:32< irker692> wesnoth: Chris Beck wesnoth:master c3ad891fba57 / / (25 files in 11 dirs): Merge pull request #208 from cbeck88/add_recall_list_mgr http://git.io/XemuUg
20140618 18:01:06< AI0867> myav claims the "attack end" event works, even though only "attack_end" is mentioned in the source
20140618 18:01:09< AI0867> any ideas?
20140618 18:02:10< iceiceice> what is meant by "works"/
20140618 18:02:25< iceiceice> you can name an event whatever you like
20140618 18:02:53< iceiceice> oh hmm i think also zookeeper explained this to me once
20140618 18:03:10< iceiceice> i think the story is that _ and space are equivalent for purpose of firing events
20140618 18:03:15< zookeeper> yes
20140618 18:03:21< irker692> wesnoth: Turuk wesnoth:master a15c39fe17b4 / data/campaigns/Northern_Rebirth/_main.cfg: Changed from 4 to 3 difficulty levels for balancing. http://git.io/L5D3QA
20140618 18:03:35< zookeeper> "attack_end" == "attack end"... unless someone has broken it, of course
20140618 18:03:45< zookeeper> same for all spaces and underscores in event names
20140618 18:04:00< irker692> wesnoth: Turuk wesnoth:master 46f5ff36d39f / data/campaigns/Northern_Rebirth/_main.cfg: Altered difficulties= http://git.io/tLUaag
20140618 18:04:08-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Quit: riksteri]
20140618 18:05:59< irker692> wesnoth: Chris Beck wesnoth:master bc4b4a95692e / src/unit.hpp: remove declarations of fcns that we were moved http://git.io/wvyeOA
20140618 18:06:01< irker692> wesnoth: Chris Beck wesnoth:master 458c2f0f066c / .travis.yml: set travis back to gcc 4.6 version http://git.io/e-DZUw
20140618 18:06:03< irker692> wesnoth: Chris Beck wesnoth:master 32848679ad3b / data/campaigns/Northern_Rebirth/_main.cfg: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/aA9TmQ
20140618 18:06:14-!- sachith500 [~kvirc@112.134.117.182] has joined #wesnoth-dev
20140618 18:07:04< irker692> wesnoth: Turuk wesnoth:master 9ad308501e6e / data/campaigns/Northern_Rebirth/scenarios/01_Breaking_the_Chains.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/UYPBBg
20140618 18:10:16< iceiceice> zookeeper: do you know if it applies to custom events also?
20140618 18:10:32< iceiceice> or just the predefined types
20140618 18:11:01< zookeeper> iceiceice, nope, i've never tried... but of course it should
20140618 18:12:25< irker692> wesnoth: Turuk wesnoth:master 130574cd9a7b / data/campaigns/Northern_Rebirth/scenarios/02_Infested_Caves.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/1XLLIw
20140618 18:13:45< irker692> wesnoth: Turuk wesnoth:master 85913e2ac2b5 / data/campaigns/Northern_Rebirth/scenarios/03_To_the_Mines.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/bJL17g
20140618 18:16:35-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has joined #wesnoth-dev
20140618 18:17:20< irker692> wesnoth: Turuk wesnoth:master ac36feeee18d / data/campaigns/Northern_Rebirth/scenarios/04_Clearing_the_Mines.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/Ki6sxA
20140618 18:20:29-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140618 18:28:49-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140618 18:30:43< irker692> wesnoth: Turuk wesnoth:master 8e645c460536 / data/campaigns/Northern_Rebirth/scenarios/05a_The_Pursuit.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/m3D-Jw
20140618 18:33:26< iceiceice> ai: i tested this commit with the "double debug kill" bug, it seems to fix it:
20140618 18:33:27< iceiceice> https://github.com/wesnoth/wesnoth/pull/209
20140618 18:33:31< iceiceice> AI0867: ^
20140618 18:35:07-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140618 18:37:32-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140618 18:42:47< irker692> wesnoth: Turuk wesnoth:master a12340c3d55e / data/campaigns/Northern_Rebirth/scenarios/06a_Old_Friend.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/GI6zeA
20140618 18:45:38< irker692> wesnoth: Turuk wesnoth:master b7b74b4b96dc / data/campaigns/Northern_Rebirth/scenarios/07a_Settling_Disputes.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/Q1lYAQ
20140618 18:46:08< iceiceice> Aishiko: did you see this bug report? https://gna.org/bugs/index.php?22213
20140618 18:46:19< iceiceice> it sounds like the statistics isnt getting recall costs properly
20140618 18:46:30< iceiceice> i think it probably predates you but it sounds like its also a bug with the variable units recall cost feature
20140618 18:46:41< iceiceice> is it alright if i assign it to you?
20140618 18:47:17-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 245 seconds]
20140618 18:47:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140618 18:50:57< irker692> wesnoth: Turuk wesnoth:master a062c17ebe33 / data/campaigns/Northern_Rebirth/scenarios/08a_Elvish_Princess.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/ZYW84A
20140618 18:51:26-!- ancestral is now known as ancestral_lunch
20140618 18:51:37< AI0867> zookeeper, iceiceice: really? I didn't find any code that does such a thing, though I didn't look very hard
20140618 18:52:00< AI0867> extra confusing is that some events are named with underscores and others with spaces
20140618 18:54:33< iceiceice> AI0867: http://forums.wesnoth.org/viewtopic.php?f=21&t=40014&hilit=+verbatim#p566992
20140618 18:55:51-!- sachith500 [~kvirc@112.134.117.182] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140618 19:03:23-!- spoffy [~spoffy@host86-183-57-156.range86-183.btcentralplus.com] has joined #wesnoth-dev
20140618 19:03:31-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 272 seconds]
20140618 19:05:15-!- spoffy [~spoffy@host86-183-57-156.range86-183.btcentralplus.com] has quit [Client Quit]
20140618 19:06:24-!- Jozrael [~Jozrael@cpe-23-242-93-245.socal.res.rr.com] has quit [Ping timeout: 240 seconds]
20140618 19:08:58< irker692> wesnoth: Turuk wesnoth:master 2e5eafc2c6e9 / data/campaigns/Northern_Rebirth/scenarios/09a_Introductions.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/bss_9Q
20140618 19:09:39-!- spoffy [~spoffy@host86-183-57-156.range86-183.btcentralplus.com] has joined #wesnoth-dev
20140618 19:10:57-!- Jozrael [~Jozrael@209.133.52.230] has joined #wesnoth-dev
20140618 19:11:19-!- travis-ci [~travis-ci@ec2-54-242-73-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20140618 19:11:19< travis-ci> [travis-ci] wesnoth/wesnoth#3276 (master - a15c39f : Turuk): The build was canceled.
20140618 19:11:19< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27888266
20140618 19:11:19-!- travis-ci [~travis-ci@ec2-54-242-73-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20140618 19:12:18< iceiceice> Turuk: I cancelled the builds associated to all but the last of your commits because other wise my pull request will never get built, its not an error
20140618 19:12:54< iceiceice> gfgtdf: i was trying to test the various animation segfault issues,
20140618 19:13:02< iceiceice> i got a wierd assertion failure associated to replay
20140618 19:13:27< iceiceice> it looks like, if you hit "stop" button on the replay viewer while an animation is happening, you can get asseritons about "init side in synced context"
20140618 19:14:52< iceiceice> report is here: http://hastebin.com/huyojibaqi.vbs
20140618 19:14:58< Turuk_> iceiceice: sounds good, do I need to do anything about that relevant to those commits?
20140618 19:15:10< iceiceice> i got it at this point
20140618 19:15:11< iceiceice> https://gna.org/bugs/?21905
20140618 19:15:24< iceiceice> Turuk: no, i'm just telling you so you dont think the travis message is your fault or something
20140618 19:15:46< iceiceice> i didnt know it would message us about cancelled builds
20140618 19:16:19-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140618 19:16:23< Turuk_> iceiceice: appreciated, thank you
20140618 19:19:54< spoffy> 2
20140618 19:19:59< spoffy> Whoops, sorry.
20140618 19:20:11-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140618 19:20:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20140618 19:22:28-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140618 19:23:07-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 245 seconds]
20140618 19:24:16-!- ancestral_lunch [~ancestral@17.114.45.98] has quit [Quit: ancestral_lunch]
20140618 19:24:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20140618 19:24:35-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140618 19:25:11< irker692> wesnoth: Turuk wesnoth:master 0b18d2aac5e2 / data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/id_m0A
20140618 19:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 245 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140618 19:32:29-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 19:32:29< irker692> wesnoth: Turuk wesnoth:master 54b8fd958197 / data/campaigns/Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/cEIZ2Q
20140618 19:32:43< gfgtdf> iceiceice: do oyu hvae  callatck of that OOS ?
20140618 19:33:03< iceiceice> which oos
20140618 19:33:49-!- travis-ci [~travis-ci@ec2-54-242-73-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20140618 19:33:49< travis-ci> [travis-ci] wesnoth/wesnoth#3278 (master - 3284867 : Chris Beck): The build was broken.
20140618 19:33:49< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27888519
20140618 19:33:49-!- travis-ci [~travis-ci@ec2-54-242-73-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20140618 19:34:23-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140618 19:34:32< iceiceice> crap the segfault is back :O
20140618 19:35:25< gfgtdf> iceiceice: r while an animation is happening, you can get asseritons about "init side in synced context"
20140618 19:35:37< iceiceice> yeah so its assertion not OOS
20140618 19:35:42< iceiceice> i get it by,
20140618 19:35:43< gfgtdf> iceiceice: ye i meant that ?
20140618 19:35:48< iceiceice> set animation speed to .25
20140618 19:35:49< gfgtdf> s/?/.
20140618 19:35:55< iceiceice> load mattsc's save
20140618 19:35:55< iceiceice> https://gna.org/bugs/?21905
20140618 19:36:05< iceiceice> click stop button while the wolfrider is being created
20140618 19:36:14< iceiceice> the call stack was in hastebin
20140618 19:36:26< irker692> wesnoth: Turuk wesnoth:master 9e0b9ab6f0e5 / data/campaigns/Northern_Rebirth/scenarios/12a_Get_the_Gold.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/H6Y6bQ
20140618 19:36:53< iceiceice> oh thats not callstack
20140618 19:36:53< iceiceice> oops
20140618 19:37:16< iceiceice> oh 
20140618 19:37:28< iceiceice> so also the test is on a branch i didnt merge yet
20140618 19:37:32< iceiceice> but probably is hould merge it now ig uess
20140618 19:37:44< iceiceice> i think the assertion would happen with my merge or not,
20140618 19:37:56< iceiceice> https://github.com/wesnoth/wesnoth/pull/209
20140618 19:38:28< irker692> wesnoth: Turuk wesnoth:master 0b3ea2a36e58 / data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg: Altered WML that allowed for 4 difficulty levels. http://git.io/pwJQIg
20140618 19:39:02< gfgtdf> iceiceice: i just trie a normal save and i coudnlt press the stop button
20140618 19:39:07< gfgtdf> tried*
20140618 19:39:34< iceiceice> ok
20140618 19:39:42< iceiceice> my report is not appropriate yet i think, i have to decide if im going to merge that branch
20140618 19:40:00< iceiceice> i think it fixes the animation segfaults, but i havent tested copmletely yet
20140618 19:40:03-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140618 19:41:23< gfgtdf> iceiceice: mattsc savefiel game me a oos immideately
20140618 19:41:43< gfgtdf> iceiceice: which is expectable since its form 1.11.13
20140618 19:41:46< gfgtdf> 1.11.12*
20140618 19:42:51< iceiceice> yeah
20140618 19:42:54< iceiceice> i ignored that i guess
20140618 19:42:57< iceiceice> i see so that's the problem?
20140618 19:43:42< gfgtdf> idk i didn even come tothe points wher ei coudl show an animation
20140618 19:46:45-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140618 19:46:45-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140618 19:46:50< iceiceice> you can't proceed past the oos?
20140618 19:49:50< irker692> wesnoth: Chris Beck wesnoth:master 94d68dc322f4 / .travis.yml: disable all tests on gcc builds, to prevent timeouts http://git.io/8xNkSA
20140618 19:49:52< irker692> wesnoth: Chris Beck wesnoth:master 45b2db4e24ce / data/campaigns/Northern_Rebirth/scenarios/ (13 files): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/MS2wEw
20140618 19:49:53< gfgtdf> iceiceice: i usual dont try
20140618 19:50:17< iceiceice> ok i think my report was pointless
20140618 19:50:27< iceiceice> idk how we can update the bug report, maybe mattsc can make antoher save file
20140618 19:50:53< gfgtdf> iceiceice: the oos message says "It might not make much senst to cotinue" for a reason
20140618 19:51:15< iceiceice> y i didnt understand the nature of the change here i guess
20140618 19:55:13-!- AustinDelaundry [47a6227a@gateway/web/freenode/ip.71.166.34.122] has joined #wesnoth-dev
20140618 19:55:14< AustinDelaundry> hello
20140618 19:55:39-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 264 seconds]
20140618 19:59:50< Turuk_> welcome AustinDelaundry
20140618 19:59:55-!- Turuk_ [40399531@gateway/web/cgi-irc/kiwiirc.com/ip.64.57.149.49] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
20140618 20:04:19< irker692> wesnoth: Chris Beck wesnoth:master 823d8c2d38c0 / src/ (fake_unit.hpp unit.hpp unit_animation.cpp unit_animation.hpp): use UnitPtr (intrusive_ptr) in unit_animations http://git.io/T2h-3g
20140618 20:04:21< irker692> wesnoth: Chris Beck wesnoth:master bc9de3650833 / src/ (fake_unit.hpp unit.hpp unit_animation.cpp unit_animation.hpp): Merge pull request #209 from cbeck88/reference_counting_in_animations http://git.io/ZHg3qw
20140618 20:05:05< gfgtdf> iceiceice: im gettign a segfault here: https://github.com/wesnoth/wesnoth/blob/master/src/scripting/lua.cpp#L771
20140618 20:06:19-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20140618 20:08:41-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140618 20:09:00< mattsc> iceiceice, gfgtdf: I don’t think there was anything specific to that save.  You should be able to test that with any save that currently works.
20140618 20:09:40< iceiceice> gfgtdf: when do you get it?
20140618 20:10:27< gfgtdf> iceiceice: http://pastebin.com/ADY8c8jk but i dont know how i triggered t, i did teh same action mutiple tmes before
20140618 20:12:00< iceiceice> gfgtdf: do you know if lua ever makes fake units?
20140618 20:12:10< gfgtdf> iceiceice:  no idk
20140618 20:12:38< iceiceice> its possible that the code here: https://github.com/wesnoth/wesnoth/commit/bc9de36508338bc665e3658438af9a2f65c6cc12
20140618 20:12:43< iceiceice> in src/fake_unit.hpp
20140618 20:12:48< iceiceice> is necessary to prevent segfaults
20140618 20:12:54-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140618 20:13:04< iceiceice> i didnt think about it when i first made the commit but probably it is
20140618 20:13:32< iceiceice> tbh the whole fake unit thing is broken imo, i think maybe it should just be replaced with scoped_ptr<unit>
20140618 20:14:15< iceiceice> or i guess just UnitPtr
20140618 20:14:28-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140618 20:15:24< iceiceice> the commit i made prevents units on the unit map and in lua from causing animation to segfault
20140618 20:15:35< iceiceice> but it wont prevent fake units disappearing and causing segfault
20140618 20:19:15< lipkab> gfgtdf: You were looking for me?
20140618 20:19:30-!- cib_ [~cib@p5DD20F4D.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20140618 20:20:58< AI0867> Turuk: if you do a change like this, please push all the commits at the same time
20140618 20:21:11< AI0867> this way makes the campaign unplayable between the first and last commit
20140618 20:21:57< AI0867> even better if you do it on a branch and then merge that branch into master
20140618 20:22:13< AI0867> that way it's atomic to the rest of us
20140618 20:22:34< lipkab> ...and even better if the campaign is playable after each commit!
20140618 20:23:01< gfgtdf> hmm ye do you know where there is a reasonyl why in level_to_gamestate we wrote the mpera/mpmod events in a tags [modification]/[era] and read that in play_controllers contructor instead of writing the [event] directly into the scenario in level_to_gamestate?
20140618 20:23:23< gfgtdf> lipkab: ^
20140618 20:25:25< AI0867> as lipkab said, it's even better if every intermediate state is also sane
20140618 20:25:48< AI0867> that's the only excuse for "huge commits"
20140618 20:27:32< lipkab> gfgtdf: I don't why era events are written there, it's been so for ages. Mod events are there because era events were also there.
20140618 20:27:44< gfgtdf> lipkab: ok
20140618 20:28:23< lipkab> *don't know
20140618 20:28:32< gfgtdf> iceiceice: did you any other forward delcatarions of return value except SDL_Color ?
20140618 20:28:35< gfgtdf> add*
20140618 20:28:47< iceiceice> ye
20140618 20:29:14< iceiceice> i think i mention, UnitPtr is forward declared 
20140618 20:29:15< gfgtdf> whcih ones ?
20140618 20:29:17< iceiceice> i think you suggested that
20140618 20:29:33< gfgtdf> where is unti ptr forward declared ?
20140618 20:29:46< iceiceice> actually idk if it counts
20140618 20:29:46< iceiceice> it probably does
20140618 20:29:51< iceiceice> so in many functions that returned unit *
20140618 20:30:09< iceiceice> they now return UnitPtr
20140618 20:30:09< iceiceice> which is defined in src/unit_ptr.hpp
20140618 20:30:16< iceiceice> the intrusive_ptr ops and unit are forward declared there
20140618 20:30:30< gfgtdf> ye but UnitPtr is not ?
20140618 20:30:30< iceiceice> idk if it counts as a "small struct" thoguh
20140618 20:30:58< iceiceice> i mean its typedef'd there as an incomplete type
20140618 20:31:25< iceiceice> so i think that means it's forward declared
20140618 20:31:29< iceiceice> but idk fully what the nature of the VC bug is
20140618 20:32:32< iceiceice> oh i think unit_animation_component and unit_formula_manager are forward declared in unit also
20140618 20:32:41< iceiceice> i guess maybe #include "unit.hpp" should be moved after those includes
20140618 20:32:51-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 264 seconds]
20140618 20:33:25< gfgtdf> iceiceice: i think we never return unit_animation_component by balue i unit .hpp
20140618 20:33:37< iceiceice> oh
20140618 20:33:45< iceiceice> then those are probably fine
20140618 20:33:49-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140618 20:34:12< iceiceice> idk is map_location ever returned by value?
20140618 20:34:22< iceiceice> i guess its probably included
20140618 20:36:06< iceiceice> https://github.com/wesnoth/wesnoth/blob/6ca69b2df58faeeb2fa13091c8e8acd1bd2b39e4/src/whiteboard/action.hpp#L92
20140618 20:36:16< iceiceice> that link is 2012 state,
20140618 20:36:26< iceiceice> it looks like map_location is included, but idk if this other one is
20140618 20:43:31< AI0867> gfgtdf: for a fix, I'd suggest struct SDL_Color;\n#ifdef MSVC\n#include <SDL_video.h>\n#endif
20140618 20:43:53< AI0867> with a comment about how MSVC is being stupid
20140618 20:44:00< gfgtdf> AI0867: in teh header sou mean ?
20140618 20:44:12< gfgtdf> you*
20140618 20:45:23< iceiceice> i guess in team.hpp
20140618 20:45:58< iceiceice> idk its up to you
20140618 20:46:11< iceiceice> they apparently fixed in MSVC 2012, is there someway to check the version number?
20140618 20:46:24< iceiceice> http://connect.microsoft.com/VisualStudio/feedback/details/649953
20140618 20:46:28< gfgtdf> iceiceice: yes there is
20140618 20:52:31< irker692> wesnoth: gfgtdf wesnoth:master a0e47b95abe1 / src/team.hpp: dont forward declare return values in msvc <= 2010 http://git.io/Kw41mg
20140618 20:52:39< gfgtdf> AI0867, iceiceice ^
20140618 20:53:42< iceiceice> gfgtdf: i think you should also do it in unit.hpp
20140618 20:53:52< iceiceice> the struct is also forward declared there
20140618 20:53:55< gfgtdf> ok
20140618 20:54:16< Turuk> AI0867: Noted. It should be playable either way with the starting removal of the fourth choice in _main.cfg, but will do in the future.  I was working without an immediate copy in front of me
20140618 20:56:19-!- AustinDelaundry [47a6227a@gateway/web/freenode/ip.71.166.34.122] has quit [Ping timeout: 246 seconds]
20140618 20:57:35< irker692> wesnoth: gfgtdf wesnoth:master 876b24b5310e / src/unit.hpp: dont forward declare return values in msvc <= 2010 http://git.io/pn0EMA
20140618 20:58:25-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140618 21:01:49-!- tomreyn [~tomreyn@p57954954.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140618 21:01:57-!- tomreyn [~tomreyn@p57954954.dip0.t-ipconnect.de] has quit [Changing host]
20140618 21:01:57-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140618 21:06:39-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140618 21:08:48-!- travis-ci [~travis-ci@ec2-54-83-255-64.compute-1.amazonaws.com] has joined #wesnoth-dev
20140618 21:08:48< travis-ci> [travis-ci] wesnoth/wesnoth#3293 (master - 45b2db4 : Chris Beck): The build passed.
20140618 21:08:48< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27896430
20140618 21:08:48-!- travis-ci [~travis-ci@ec2-54-83-255-64.compute-1.amazonaws.com] has left #wesnoth-dev []
20140618 21:13:54-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140618 21:17:00-!- mode/#wesnoth-dev [+o shadowm] by ChanServ
20140618 21:17:13-!- mode/#wesnoth-dev [-bbq *!*@*199.115.228.135 *!*@*199.115.229.249 *!*@wesnoth/artist/blarumyrran] by shadowm
20140618 21:17:28-!- mode/#wesnoth-dev [+bq-o $j:#wesnoth $j:#wesnoth shadowm] by shadowm
20140618 21:19:59-!- gfgtdf_ [~chatzilla@f054156062.adsl.alicedsl.de] has joined #wesnoth-dev
20140618 21:21:55-!- gfgtdf [~chatzilla@e177016036.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140618 21:22:09-!- gfgtdf_ is now known as gfgtdf
20140618 21:24:42< Soliton> shadowm: re 62eb55a5, we should remember the current fifo_path and just not reopen it if it didn't change. in practice we're not really ever changing it.
20140618 21:29:06< Soliton> should be a good easy coding task...
20140618 21:30:25-!- ancestral [~ancestral@17.115.177.242] has joined #wesnoth-dev
20140618 21:33:20-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140618 21:41:59-!- mode/#wesnoth-dev [-q $j:#wesnoth] by ChanServ
20140618 21:50:24< shadowm> It seems trivial except for the part where I need to go and try to reproduce the whole SIGHUP thing with precise timing.
20140618 21:59:14< irker692> wesnoth: Chris Beck wesnoth:master fd9379e276fa / src/display.cpp: fixup 13155c4f41c7d60f9dec1e323eaa9477a54aaec3 http://git.io/HGDdaw
20140618 21:59:16< irker692> wesnoth: Chris Beck wesnoth:master 44a0752cb4b7 / src/ (display.cpp fake_unit_manager.hpp game_display.cpp): fake unit manager returns a range rather than & to container http://git.io/3qXsUg
20140618 22:00:06< AI0867> iceiceice: regarding #209, where does the reference_count get decremented?
20140618 22:00:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20140618 22:00:50< iceiceice> it doesnt, the fake_unit allocation works differently...
20140618 22:01:02< iceiceice> the idea is that, the caller allocates a fake unit on the stack most likely
20140618 22:01:18< iceiceice> it automatically (more or less) registers itself with the fake_unit_manager
20140618 22:01:30< iceiceice> the fake_unit_manager used to just be the game_display object but i split it off because that is silly and confusing
20140618 22:01:46< iceiceice> the manager hodls a list of pointers,
20140618 22:01:55< iceiceice> at various times the game_display and display will ask for those units to draw them
20140618 22:02:04< iceiceice> i think animations may also be involved at that point
20140618 22:02:19< iceiceice> the animations now hold units in these smart pointers,
20140618 22:02:26< iceiceice> and i dont want them to delete the fake_units because the caller owns them
20140618 22:02:39< iceiceice> so the fake unit object is just defined to increment its counter in the constructor
20140618 22:02:47< iceiceice> which more or less disables the reference counting
20140618 22:02:55< iceiceice> its still the callers job to delete as always
20140618 22:04:49< iceiceice> i think the best thing would probably be if instead of class fake_unit we had class fake_unit_ptr
20140618 22:05:01-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has quit [Quit: leaving]
20140618 22:05:14< iceiceice> the only thing class fake_unit contributes is a destructor which removes the link from the fake_unit_manager
20140618 22:06:08< irker692> wesnoth: Chris Beck wesnoth:master 3e2d27f58a7c / .travis.yml: add --debug=time to scons line in travis http://git.io/3Kc0AA
20140618 22:11:14-!- kex_ [~kex@93-142-150-19.adsl.net.t-com.hr] has joined #wesnoth-dev
20140618 22:13:57-!- Kexoth [~kex@93-137-12-223.adsl.net.t-com.hr] has quit [Ping timeout: 245 seconds]
20140618 22:15:46< AI0867> iceiceice: so then what is the advantage of using the UnitPtr, rather than a const unit*?
20140618 22:16:01< iceiceice> in the animations?
20140618 22:16:34< iceiceice> it doesnt change anything for the fake units right now, it only changes things for the rest of them
20140618 22:16:49< iceiceice> for the other units, like those on the unit map, 
20140618 22:16:53< AI0867> so how does it fix the bug?
20140618 22:16:58< iceiceice> if the unit_map removes a unit,
20140618 22:17:06< iceiceice> and it has an active animation,
20140618 22:17:09< iceiceice> it isnt destroyed
20140618 22:17:09< AI0867> oh, right
20140618 22:17:12< iceiceice> until the animation finishes
20140618 22:17:23< AI0867> it can hold both fake and real units
20140618 22:17:58< AI0867> I'd rather convert all fake_unit uses to use a UnitPtr though
20140618 22:18:06< AI0867> and then get rid of the increment
20140618 22:18:10< iceiceice> yeah that woudl be better
20140618 22:18:19< iceiceice> next step :
20140618 22:18:20< iceiceice> :)
20140618 22:32:55< irker692> wesnoth: mattsc wesnoth:master 4b10e1b9fb14 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project http://git.io/WUnSjA
20140618 22:42:36< irker692> wesnoth: Chris Beck wesnoth:master 8481b90b96a9 / src/ (game_display.cpp game_display.hpp): move game_display::footsteps_images into game_display.cpp http://git.io/q6j43Q
20140618 22:42:39< irker692> wesnoth: Chris Beck wesnoth:master d5cc615bfa35 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/qAdyBA
20140618 22:45:58-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 240 seconds]
20140618 22:51:09-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140618 22:51:15-!- travis-ci [~travis-ci@ec2-54-242-73-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20140618 22:51:15< travis-ci> [travis-ci] wesnoth/wesnoth#3297 (master - 44a0752 : Chris Beck): The build has errored.
20140618 22:51:15< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27907287
20140618 22:51:15-!- travis-ci [~travis-ci@ec2-54-242-73-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20140618 22:55:09-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20140618 22:57:16-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Remote host closed the connection]
20140618 23:04:53-!- ancestral [~ancestral@17.115.177.242] has quit [Quit: ancestral]
20140618 23:05:21-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140618 23:08:49-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140618 23:12:31< irker692> wesnoth: gfgtdf wesnoth:master 0ac850847f65 / src/hotkey/ (hotkey_command.cpp hotkey_item.cpp): fix a segfault http://git.io/jgyr8g
20140618 23:17:57-!- ancestral [~ancestral@17.115.177.242] has joined #wesnoth-dev
20140618 23:18:36-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140618 23:22:37-!- ancestral [~ancestral@17.115.177.242] has quit [Ping timeout: 244 seconds]
20140618 23:22:42< AI0867> aquileia: see the PR
20140618 23:34:12-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140618 23:40:22< gfgtdf> AI0867: i have a question about this code: http://pastebin.com/j5sXENup  do you know ?
20140618 23:43:02-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Killed (dickson.freenode.net (Nickname regained by services))]
20140618 23:43:02-!- _8680_ is now known as c74d
20140618 23:43:53-!- c74d is now known as Guest41975
20140618 23:43:53-!- Guest41975 [~8680@2002:4404:712c:0:e0ed:e56a:d542:3376] has quit [Killed (asimov.freenode.net (Nickname regained by services))]
20140618 23:44:10-!- _8680_ [~8680@2002:4404:712c:0:acda:70a1:e38c:3a99] has joined #wesnoth-dev
20140618 23:46:33-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140618 23:47:40< gfgtdf> AI0867: or rather: is a "t_this& rval_to_lval() {return *this; }" function valid c++ ?
20140618 23:48:56< AI0867> I don't see why it wouldn't be?
20140618 23:49:20-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140618 23:49:43< AI0867> what's the error?
20140618 23:51:02< gfgtdf> AI0867: there is no error, i just think its strange that if F takes a t_this&  than F(t_this()) is an error, but F(t_this().rval_to_lval()) is valid.
20140618 23:51:54< gfgtdf> AI0867: so im wondering if a do someing thats not allowed
20140618 23:52:01< gfgtdf> if i am doing*
20140618 23:52:15< AI0867> yes, so what's the error for the 'invalid' thing?
20140618 23:53:01< AI0867> oh, I think I see something
20140618 23:53:05< AI0867> print takes a BA&
20140618 23:53:12< AI0867> a non-const reference
20140618 23:53:18< AI0867> BA(2) constructs a temporary
20140618 23:53:50< AI0867> BA(2).set_a(6) returns *this, which is a reference to a temporary, but the compiler can't know that
20140618 23:54:05< AI0867> so yeah, undefined behaviour
--- Log closed Thu Jun 19 00:00:16 2014