--- Log opened Thu Jun 19 00:00:16 2014
20140619 00:00:32< gfgtdf> AI0867: hm i just searched in the internet, in this post: http://stackoverflow.com/questions/11508607/rvalue-to-lvalue-conversion-visual-studio second answer it's said that it's legal
20140619 00:08:11-!- dacovale [~niklas@dynamic.1.12.c0255ce81c80.4ce6762eb925.cust.bredband2.com] has joined #wesnoth-dev
20140619 00:10:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140619 00:10:28-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140619 00:16:45-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140619 00:21:17-!- Haudegen [~quassel@91.141.2.26.wireless.dyn.drei.com] has quit [Read error: Connection reset by peer]
20140619 00:25:50-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 29.0.1/20140506152807]]
20140619 00:27:49< iceiceice> ok i think i broke the whiteboard :O
20140619 00:28:09< iceiceice> i think probably need to change it to use UnitPtr instead of boost::shared_ptr<unit>, didin't think about it before
20140619 00:28:47< shadowm> <whiteboard> what did i do to deserve this why are you people so cruel to meeee
20140619 00:31:59< iceiceice> oh its only in my branch
20140619 00:31:59< iceiceice> ok i think i know what i did
20140619 00:36:45-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140619 00:46:44-!- mjs-de [~mjs-de@f049247187.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140619 00:50:16< AI0867> gfgtdf: no, it says MSVC accepts it as an extension, with no chance of UB. That doesn't make it valid C++
20140619 00:50:50< AI0867> attaching a non-const reference to a temporary is not valid C++
20140619 00:58:17-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140619 01:03:36-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140619 01:04:34-!- kex_ [~kex@93-142-150-19.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140619 01:09:01< iceiceice> AI0867: https://github.com/wesnoth/wesnoth/pull/210
20140619 01:09:40< iceiceice> taking a break for now, there's still debugging to do, as playing with the whiteboard will make evident...
20140619 01:09:46< iceiceice> i'm not sure if it indicates a problme in this commit or in pevious commits though
20140619 01:11:12-!- spoffy [~spoffy@host86-183-57-156.range86-183.btcentralplus.com] has quit [Remote host closed the connection]
20140619 01:16:20< AI0867> I just saw it. It looks okay, but I didn't look at it very hard
20140619 01:17:02-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140619 01:20:05-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has joined #wesnoth-dev
20140619 01:20:12< Laundry> Hello?
20140619 01:20:32-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140619 01:20:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20140619 01:20:48< Laundry> Hello?
20140619 01:20:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140619 01:21:14< c74d> Hello, Laundry.
20140619 01:21:32-!- happygrue_ [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140619 01:21:52-!- vultraz_ [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140619 01:21:57-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20140619 01:22:02< Laundry> I am new here, and I'd like to develop for Wesnoth
20140619 01:22:09-!- vultraz_ is now known as vultraz
20140619 01:22:39< Laundry> I did go to the site which had me to download the development release
20140619 01:23:48-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140619 01:24:36< happygrue_> hi Laundry, have a look at this:  http://wiki.wesnoth.org/Easycoding
20140619 01:25:04< AI0867> Laundry: did you download 1.11.15 or did you get the git clone?
20140619 01:25:07< Laundry> I did not even see this. I didn't know there was a Wiki
20140619 01:25:16< Laundry> I'm downloading the git now
20140619 01:25:18< happygrue_> Parts could be out of date, so ask about anything here before getting too involved in it.
20140619 01:25:24< Laundry> ok
20140619 01:26:56< happygrue_> Laundry: also checking the bug list ( https://gna.org/bugs/?group=wesnoth  )for anything that looks like a simple fix and then asking about that is a fair thing to do.
20140619 01:27:19< Laundry> I actually spotted one there that looked like a simple fix I could do
20140619 01:27:39< happygrue_> Laundry: and iceiceice wrote a git crash course which is worth a read through: http://wiki.wesnoth.org/Git_for_Wesnoth_Crash_Course
20140619 01:28:03< Laundry> Thank you very much!
20140619 01:28:14< happygrue_> but you don't have to have a full understanding of everything at once.  Feel free to ask.  ;)
20140619 01:28:44-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 243 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140619 01:29:18< Laundry> What is WML? I've been seeing it and I don't know what it stands for
20140619 01:30:17< c74d> Wesnoth Markup Language.
20140619 01:30:20< Laundry> and also do you guys use Eclips?
20140619 01:30:24< Laundry> Ok cool.
20140619 01:30:32< Laundry> Eclpise*
20140619 01:30:36< AI0867> some of us do. Most don't
20140619 01:30:38< c74d> It isn’t actually a markup language though; it’s a data definition language (like JSON).
20140619 01:30:47< Laundry> OOOh Ok
20140619 01:31:46< Laundry> What IDE's are preferred Al?
20140619 01:33:26< iceiceice> Laundry: it depends what platform you are on
20140619 01:33:32< Laundry> Linux
20140619 01:33:34< iceiceice> i guess on windows its either code::blocks or visual studio
20140619 01:33:49< iceiceice> afaik most linux devs dont use an ide but im actually not sure about htat
20140619 01:33:53< Laundry> I was thinking code::blocks
20140619 01:35:01< iceiceice> yeah so if you are on linux, you can probably build very easily with scons... although i've made ambitious claims about this in the past
20140619 01:35:06< iceiceice> idk it has always worked for me on the first try :)
20140619 01:35:26< iceiceice> if you want to use code::blocks, you can look at the CodeBlocks-Scons project file maybe?
20140619 01:35:39< Laundry> I'll take a look.
20140619 01:35:44< iceiceice> idk if anyone is using it but it hink we have been keeping it up to date
20140619 01:40:11-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has quit [Remote host closed the connection]
20140619 01:41:26-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140619 01:43:04-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140619 01:43:25-!- happygrue_ [~happygrue@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20140619 01:47:31-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140619 01:48:13-!- Samual [~dioteckte@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20140619 01:53:06-!- happygrue [~quassel@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140619 01:53:53-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140619 01:54:37-!- prophile [~alynn@oftn/member/prophile] has quit [Client Quit]
20140619 01:54:43-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has quit [Quit: Laundry]
20140619 01:56:22-!- happygrue [~quassel@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20140619 02:04:21-!- Ivanovic_ [~ivanovic@frnk-5f74c5fc.pool.mediaWays.net] has joined #wesnoth-dev
20140619 02:07:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 264 seconds]
20140619 02:08:15-!- Ivanovic_ is now known as Ivanovic
20140619 02:10:21-!- Jozrael2 [~Jozrael@12.89.226.214] has joined #wesnoth-dev
20140619 02:10:32-!- Jozrael [~Jozrael@209.133.52.230] has quit [Ping timeout: 244 seconds]
20140619 02:12:33-!- irker692 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140619 02:21:11-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140619 02:23:11-!- Jozrael [~Jozrael@209.133.52.230] has joined #wesnoth-dev
20140619 02:23:58-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 244 seconds]
20140619 02:25:31-!- Jozrael2 [~Jozrael@12.89.226.214] has quit [Ping timeout: 240 seconds]
20140619 02:27:36-!- Jozrael [~Jozrael@209.133.52.230] has quit [Ping timeout: 255 seconds]
20140619 02:27:43-!- Jozrael [~Jozrael@cpe-23-242-93-245.socal.res.rr.com] has joined #wesnoth-dev
20140619 02:40:14-!- Necrosporus_ is now known as Necrosporus
20140619 02:53:16-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has joined #wesnoth-dev
20140619 02:57:45-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has quit [Ping timeout: 255 seconds]
20140619 03:04:48< shadowm> OK, why does a mainline campaign failing to load cause the game to exit back to desktop now?
20140619 03:05:00< shadowm> On master.
20140619 03:08:23< shadowm> Hm, okay, it seems it's actually done this for quite a while.
20140619 03:09:13< shadowm> Since at least Wesnoth 1.10.7, to be specific, so never mind.
20140619 03:11:33< iceiceice> what should it do?
20140619 03:11:52< iceiceice> also what do you mean, like if scenario 2 or 3 fails to load?
20140619 03:12:23< shadowm> The config loader doesn't know what a scenario is.
20140619 03:12:39< shadowm> This is a to-do item for me, in any case.
20140619 03:19:13-!- irker224 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140619 03:19:13< irker224> wesnoth: Turuk wesnoth:master f39142c676fd / data/campaigns/Northern_Rebirth/scenarios/ (02_Infested_Caves.cfg 05a_The_Pursuit.cfg): Fixed Gold arguments. http://git.io/OgbYWQ
20140619 03:20:46-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140619 03:21:44-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140619 03:30:31-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140619 03:44:51-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140619 03:56:10< shadowm> wesbot: seen fabi
20140619 03:56:10< wesbot> shadowm: The person with the nick fabi last spoke 8d 12h ago.  8d 1h ago was here and on the channels #wesnoth, #wesnoth-de and #wesnoth-umc-dev with the message: Ping timeout: 240 seconds
20140619 03:58:38-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140619 04:00:54-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140619 04:10:18-!- Jozrael [~Jozrael@cpe-23-242-93-245.socal.res.rr.com] has quit [Read error: Connection reset by peer]
20140619 04:10:21-!- Jozrael2 [~Jozrael@cpe-23-242-93-245.socal.res.rr.com] has joined #wesnoth-dev
20140619 04:12:25-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20140619 04:15:07-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140619 04:41:14-!- cib_ [~cib@p5DD20330.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140619 04:42:06-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has joined #wesnoth-dev
20140619 04:44:06-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140619 04:46:33-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140619 05:00:00-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 244 seconds]
20140619 05:04:17-!- jamit [~jamit@wesnoth/developer/jamit] has joined #wesnoth-dev
20140619 05:04:31-!- jamit [~jamit@wesnoth/developer/jamit] has quit [Client Quit]
20140619 05:04:49-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20140619 05:10:32-!- Sulfur [~Miranda@p5B009192.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140619 05:12:00< shadowm> I can't reproduce the wesnothd socket reset bug on my desktop. :|
20140619 05:16:02-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 245 seconds]
20140619 05:18:38< shadowm> I suppose I could go and commit the patch anyway, or look into simulating/actually causing the necessary system load to reproduce the bug.
20140619 05:21:20-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20140619 05:25:50-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 244 seconds]
20140619 06:10:14-!- Ivanovic [~ivanovic@frnk-5f74c5fc.pool.mediaWays.net] has quit [Changing host]
20140619 06:10:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140619 06:12:05-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140619 06:13:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140619 06:15:03-!- groggy [~chatzilla@68-119-217-88.dhcp.hckr.nc.charter.com] has joined #wesnoth-dev
20140619 06:30:57-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has joined #wesnoth-dev
20140619 06:35:45-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has quit [Ping timeout: 272 seconds]
20140619 06:40:40< irker224> wesnoth: Ignacio R. Morelle wesnoth:1.12 2ffdcb7e4571 / data/gui/default/widget/slider_minimal.cfg: gui2/tslider: Add minimal variant without a text label http://git.io/79qYfA
20140619 06:40:43< irker224> wesnoth: Ignacio R. Morelle wesnoth:1.12 eee57afbd2f2 / data/gui/default/window/chat_log.cfg src/gui/dialogs/chat_log.cpp: gui2/tchat_log: Use a separate proper label for the page number text http://git.io/p0RyJg
20140619 06:40:46< irker224> wesnoth: Ignacio R. Morelle wesnoth:master a286bf190890 / data/gui/default/widget/slider_minimal.cfg: gui2/tslider: Add minimal variant without a text label http://git.io/StWJmg
20140619 06:40:49< irker224> wesnoth: Ignacio R. Morelle wesnoth:master 8a30f348b196 / data/gui/default/window/chat_log.cfg src/gui/dialogs/chat_log.cpp: gui2/tchat_log: Use a separate proper label for the page number text http://git.io/x3GjqA
20140619 06:41:29-!- vultraz [~chatzilla@124.109.10.167] has quit [Remote host closed the connection]
20140619 06:42:58-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140619 06:46:11-!- groggy [~chatzilla@68-119-217-88.dhcp.hckr.nc.charter.com] has quit [Remote host closed the connection]
20140619 06:48:49-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140619 07:07:31-!- Haudegen_ [~quassel@77.119.130.86.wireless.dyn.drei.com] has joined #wesnoth-dev
20140619 07:09:50-!- Haudegen_ is now known as Haudegen
20140619 07:11:37< Necrosporus> Is Irdya whole universe or just one planet?
20140619 07:12:22< Necrosporus> And is it actually a nearly-spherical planet like Earth or it has other topology (like a flat disk)?
20140619 07:13:29< shadowm> Does it matter?
20140619 07:13:52< shadowm> I always make sure that everyone asking that kind of questions ask themselves that question first.
20140619 07:17:24< Necrosporus> possibly
20140619 07:19:59< Necrosporus> shadowm, it could matter in some technical setting
20140619 07:20:17< Necrosporus> for example a campaign about stellar expansion
20140619 07:20:26< shadowm> Technical setings kind of don't belong in Irdya to begin with.
20140619 07:21:31-!- Sulfur [~Miranda@p5B009192.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140619 07:21:45< shadowm> Technological, I mean.
20140619 07:21:53< Necrosporus> is Yechnagoth extrairdyan being (extraterrestrial)?
20140619 07:23:11< shadowm> No idea.
20140619 07:23:38< shadowm> As far as I know, whether she is or not from Irdya is entirely irrelevant to the story told by UtBS.
20140619 07:25:09-!- Rh0nda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20140619 07:27:54-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 252 seconds]
20140619 07:27:54-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 252 seconds]
20140619 07:27:56-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 252 seconds]
20140619 07:28:12-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20140619 07:29:00-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20140619 07:29:05< Necrosporus> shadowm, what about your race using same spriteset?
20140619 07:30:45< c74d> The WML refers to Yechnagoth as an “alien”, at least.
20140619 07:32:07< shadowm> Necrosporus: As far as I know my race is not mainline.
20140619 07:32:25< shadowm> c74d: It might be used in a more qualitative sense.
20140619 07:33:02< Necrosporus> are there any campaigns where planet (or whatever where wesnoth is located) exists but come actions goes outside of it?
20140619 07:33:43< Necrosporus> * some
20140619 07:36:23< irker224> wesnoth: Ignacio R. Morelle wesnoth:1.12 1537394818eb / src/serialization/schema_validator.cpp: validator: Conform to the new parser and preprocessor output style http://git.io/-PUCXg
20140619 07:36:26< irker224> wesnoth: Ignacio R. Morelle wesnoth:1.12 e109f9b23bb7 / src/serialization/schema_validator.cpp: validator: Remove redundant "on line N" output fragments http://git.io/z9pkqQ
20140619 07:36:29< irker224> wesnoth: Ignacio R. Morelle wesnoth:1.12 d95b07740e57 / src/serialization/schema_validator.cpp: validator: Make missing attribute error format more consistent with the rest http://git.io/vxxSlA
20140619 07:36:32< irker224> wesnoth: Ignacio R. Morelle wesnoth:1.12 980594e2ac41 / changelog: validator: Update changelog for previous three commits http://git.io/PBhHsQ
20140619 07:36:35< irker224> wesnoth: Ignacio R. Morelle wesnoth:master eed4ae8a5242 / src/serialization/schema_validator.cpp: validator: Conform to the new parser and preprocessor output style http://git.io/SWuXgA
20140619 07:36:38< irker224> wesnoth: Ignacio R. Morelle wesnoth:master b58a2d6ba1aa / src/serialization/schema_validator.cpp: validator: Remove redundant "on line N" output fragments http://git.io/hGNN9w
20140619 07:36:41< irker224> wesnoth: Ignacio R. Morelle wesnoth:master 0e8b3afedf8a / src/serialization/schema_validator.cpp: validator: Make missing attribute error format more consistent with the rest http://git.io/as70dg
20140619 07:36:44< irker224> wesnoth: Ignacio R. Morelle wesnoth:master 5044300e4485 / changelog: validator: Update changelog for previous three commits http://git.io/hLRmeg
20140619 07:46:01-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit []
20140619 07:49:50-!- cib__ [~cib@p5DD20330.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140619 07:53:08-!- cib__ [~cib@p5DD20330.dip0.t-ipconnect.de] has quit [Client Quit]
20140619 07:56:14-!- Rh0nda is now known as Rhonda
20140619 08:02:29-!- Sulfur [~Miranda@p5B009192.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140619 08:05:53-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has joined #wesnoth-dev
20140619 08:12:20< vultraz> [18:33:01]	Necrosporus	are there any campaigns where planet (or whatever where wesnoth is located) exists but come actions goes outside of it?
20140619 08:12:20-!- sachith500 [~kvirc@112.134.243.33] has joined #wesnoth-dev
20140619 08:12:22< vultraz> no
20140619 08:13:03< vultraz> unless you count After the Storm, which references other worlds and features a short ending cutscene on one of them
20140619 08:14:47-!- sachith500 [~kvirc@112.134.243.33] has quit [Client Quit]
20140619 08:15:11< Necrosporus> vultraz, but it is other planet or other 'parallel word'?
20140619 08:15:26< vultraz> no
20140619 08:19:45-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has joined #wesnoth-dev
20140619 08:21:27-!- cib_ [~cib@p5DD20330.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20140619 08:21:57-!- cib_ [~cib@p5DD20330.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140619 08:24:05-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has quit [Ping timeout: 244 seconds]
20140619 08:38:32-!- mjs-de [~mjs-de@f049247187.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 08:43:33-!- sachith500 [~kvirc@112.134.243.33] has joined #wesnoth-dev
20140619 08:57:37-!- groggy [~chatzilla@68-119-217-88.dhcp.hckr.nc.charter.com] has joined #wesnoth-dev
20140619 09:03:56-!- Haudegen [~quassel@77.119.130.86.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds]
20140619 09:04:02-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140619 09:07:44-!- markus_ [~mjs-de@f048077164.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 09:11:33-!- mjs-de [~mjs-de@f049247187.adsl.alicedsl.de] has quit [Ping timeout: 272 seconds]
20140619 09:12:25< Necrosporus> Is SoBE #12 Giving Some Back meant to strip player of excessive high-level units/
20140619 09:13:01< Necrosporus> It seems quite hard, as there are lots of lancers, which tend to insta-kill even lvl3 units
20140619 09:14:13< Necrosporus> So I do not know, what to do. If I recruit lvl1, then they are too weak and enemy kills more than I
20140619 09:27:53-!- markus_ is now known as mjs-de
20140619 09:44:30-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has quit [Read error: Connection reset by peer]
20140619 09:45:10-!- sachith500|2 [~kvirc@112.135.62.244] has joined #wesnoth-dev
20140619 09:46:17-!- Haudegen [~quassel@213162068019.public.t-mobile.at] has joined #wesnoth-dev
20140619 09:46:53-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has joined #wesnoth-dev
20140619 09:48:09-!- sachith500 [~kvirc@112.134.243.33] has quit [Ping timeout: 255 seconds]
20140619 09:49:42-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140619 09:52:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140619 09:54:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20140619 09:56:00-!- groggy [~chatzilla@68-119-217-88.dhcp.hckr.nc.charter.com] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140619 09:58:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140619 09:59:45-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has joined #wesnoth-dev
20140619 10:05:46-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140619 10:19:48-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140619 10:19:48-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit]
20140619 10:21:26-!- Haudegen [~quassel@213162068019.public.t-mobile.at] has quit [Ping timeout: 240 seconds]
20140619 10:22:03-!- sachith500|2 [~kvirc@112.135.62.244] has quit [Ping timeout: 240 seconds]
20140619 10:22:31-!- sachith500 [~kvirc@112.135.62.244] has joined #wesnoth-dev
20140619 10:26:42-!- prkc [~prkc@catv-89-134-163-99.catv.broadband.hu] has joined #wesnoth-dev
20140619 10:34:54-!- Haudegen_ [~quassel@91.141.3.201.wireless.dyn.drei.com] has joined #wesnoth-dev
20140619 10:36:52-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140619 10:39:55-!- Haudegen_ [~quassel@91.141.3.201.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds]
20140619 10:51:58-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140619 10:52:19-!- happygrue [~quassel@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140619 10:53:17-!- aquileia_ [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140619 10:53:44< aquileia_> zookeeper: SOF has a heightmap opacity of 15 instead of 20 - deliberate choice or error?
20140619 10:54:35< zookeeper> aquileia, i don't recall, but most likely deliberate; i know i sometimes used slightly different values for a particular heightmap
20140619 10:54:45< aquileia_> ok
20140619 10:56:19-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140619 10:56:26-!- Sulfur [~Miranda@p5B009192.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140619 11:08:37-!- irker224 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140619 11:12:16< aquileia_> zookeeper: BTW I'll add a comment to the wiki that DW has no forests and translators need to temporarily add one for the script to work
20140619 11:12:31-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has quit [Quit: Turuk]
20140619 11:12:44< aquileia_> In fact I'll add it to the file as well
20140619 11:13:03-!- Sulfur [~Miranda@p5B009192.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140619 11:13:10< zookeeper> aquileia_, uh, good idea
20140619 11:14:07< aquileia_> There's already a coment that you need yellow labels, but it's easy to forget that there's a mainline map with that case
20140619 11:14:21< aquileia_> so it can't hurt
20140619 11:14:40< zookeeper> yes
20140619 11:16:58-!- Haudegen_ [~quassel@91.141.3.201.wireless.dyn.drei.com] has joined #wesnoth-dev
20140619 11:17:36-!- Haudegen_ is now known as Haudegen
20140619 11:49:39-!- Sulfur [~Miranda@p5B009192.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140619 12:04:55-!- aquileia_ [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140619 12:10:53-!- Sulfur [~Miranda@p5B009192.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140619 12:29:04-!- happygrue [~quassel@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20140619 12:29:55-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140619 12:53:18-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140619 12:57:03-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has joined #wesnoth-dev
20140619 12:57:23-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has joined #wesnoth-dev
20140619 12:57:46< aquileia> zookeeper: I merged GunChleoc's PR into mine, if you want to merge both separately, I might have to rebase again, but that'd be no problem
20140619 12:58:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140619 13:00:26-!- mjs-de [~mjs-de@f048077164.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20140619 13:06:45-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140619 13:09:52< aquileia> zookeeper: As tothe comment here... https://github.com/aquileia/wesnoth/commit/557a45d90a76c
20140619 13:11:22< aquileia> I have a localization PR for both repos, so I could move them if you agreed
20140619 13:14:16< zookeeper> yeah i think all the old campaign maps and their localizations would be nice to retain in resources
20140619 13:14:34< zookeeper> as to who does it and how i don't really care :p
20140619 13:15:12< aquileia> you want tokeep even those overlays that have been replaced?
20140619 13:17:05< zookeeper> sure? there might be some UMC use for them somehow somewhere sometime, and if the maps are kept somewhere for that purpose, then of course their localizations should be too
20140619 13:17:28< zookeeper> of course one can always just dig them up from the history, but...
20140619 13:17:53< aquileia> What UMC would use an old-style map if thre is a new one from the same area?
20140619 13:18:55< aquileia> I'd retain the titlescreen one as it's guaranted to be distributed on every OS (even when mainline campaigns are excluded)
20140619 13:19:16< aquileia> but  can't really see any usein the others
20140619 13:19:43< zookeeper> i dunno
20140619 13:20:12< zookeeper> maybe someone likes the old map better than the new one and/or it fits their UMC better for whatever reason
20140619 13:21:16< aquileia> Then I'd really say in that particular case the person could lift it fom history
20140619 13:21:48-!- Kexoth [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140619 13:21:49< zookeeper> sure. i don't have a strong opinion on it, especially when i wouldn't do the work anyway.
20140619 13:22:00< aquileia> Ive go to geton my train, I'm off but I'll read the logs
20140619 13:28:13-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140619 13:29:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140619 13:41:52-!- kex_ [~kex@212.92.210.53] has joined #wesnoth-dev
20140619 14:06:04< AI0867> aquileia: if MSVC cannot use the former, then why is it not using the latter?
20140619 14:07:56< AI0867> (in c++11, you can, but in c++98, it indeed shouldn't be considered)
20140619 14:08:10< AI0867> (so in c++11, the latter is gone)
20140619 14:09:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140619 14:15:24-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 14:20:01< Laundry> Can I build Wesnoth directly from the Github code?
20140619 14:20:34-!- sachith500 [~kvirc@112.135.62.244] has quit [Read error: Connection reset by peer]
20140619 14:21:49< iceiceice> Laundry: yes
20140619 14:21:57< Laundry> Coolcoolcool
20140619 14:22:00-!- sachith500 [~kvirc@112.135.62.244] has joined #wesnoth-dev
20140619 14:22:19< iceiceice> gfgtdf: did you ever look at this code?
20140619 14:22:20< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/game_events/pump.cpp#L137
20140619 14:22:29< gfgtdf> AI0867: i think return ptr; failing to compile is exactly what one would expect from a explicit operator
20140619 14:23:28< gfgtdf> AI0867: do you compile wesnoth with c++11 enabled ?and gcc 4.6+ ?
20140619 14:26:21-!- irker927 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140619 14:26:21< irker927> wesnoth: Chris Beck wesnoth:master 0182224407ac / src/cursor.hpp: remove unnecessary include http://git.io/pJ4Dhw
20140619 14:26:21< irker927> wesnoth: Chris Beck wesnoth:master 6b4ad80a6592 / / (7 files in 6 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/Y4NUMg
20140619 14:28:43< gfgtdf> iceiceice: hm not realy
20140619 14:28:54< iceiceice> i looked at a question tek asked
20140619 14:29:15< iceiceice> i think that line i linked is the line that moves the new events to the event queue after we finish firign an event?
20140619 14:29:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140619 14:29:25< iceiceice> but it seems wierd, it seems like we only do that if we handle an exception or smth?
20140619 14:32:58< gfgtdf> iceiceice: do you compile wesnth with c++1 enabled ?
20140619 14:33:08< iceiceice> no i use c++98
20140619 14:33:17< iceiceice> i try to do the same as travis
20140619 14:33:57< gfgtdf> iceiceice: maybe we should add a c++ 11 build :p
20140619 14:34:17< Laundry> I thought we used 98? are we moving to 11?
20140619 14:35:25< gfgtdf> Laundry: no we officialy support 98, idk if we officialy support c++11 too.
20140619 14:36:00-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140619 14:36:23-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 14:36:30< Laundry> Ok.
20140619 14:36:45< gfgtdf> iceiceice: hm which question tek asked do you mean ?
20140619 14:37:10< iceiceice> http://forums.wesnoth.org/viewtopic.php?f=8&t=40449#p572135
20140619 14:38:47< iceiceice> hmm i think i get it actually
20140619 14:40:28< iceiceice> well im not sure 
20140619 14:40:37< iceiceice> i guess if done() = true that means all events were consumed?
20140619 14:40:51< iceiceice> so we can just leave it with whatever was added afterwards?
20140619 14:42:58< iceiceice> hmm also, wouldn't it be better if event handlers were stored in a map?
20140619 14:43:42-!- mjs-de [~mjs-de@f048077164.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 14:44:07< gfgtdf> iceiceice: what map ?
20140619 14:44:16< gfgtdf> iceiceice: name -> event ß
20140619 14:44:19< gfgtdf> ?*
20140619 14:44:25< iceiceice> yea
20140619 14:49:04< iceiceice> i guess its not that big a deal
20140619 14:49:15-!- kex_ [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140619 14:49:17< iceiceice> it depends what kind of scenario you are running
20140619 14:50:10< iceiceice> idk if you have lots of custom post_advance stuff or something,
20140619 14:50:19< iceiceice> i guess all of that stuff will be iterated over when you fire enter_hex
20140619 14:51:03-!- _8680_ [~8680@2002:4404:712c:0:acda:70a1:e38c:3a99] has quit [Ping timeout: 240 seconds]
20140619 14:52:14-!- _8680_ [~8680@2002:4404:712c:0:1d14:efe0:7c73:36e1] has joined #wesnoth-dev
20140619 14:53:12< irker927> wesnoth: Chris Beck wesnoth:master 4c06902df520 / src/map_location.hpp: fixup an include http://git.io/pUCTIQ
20140619 15:02:21-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140619 15:02:42-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140619 15:06:49< gfgtdf> iceiceice: i think the reason wh you cannot use map is becasue [event]name= is a vconfig, also it can match mutiple events name="moveto,attack,$my_variable"
20140619 15:07:11< iceiceice> hmm but when we fire it's always a string, right?
20140619 15:07:18< iceiceice> oh
20140619 15:07:32< iceiceice> wait so the classification of an event can change?
20140619 15:07:35< iceiceice> depending on variables?
20140619 15:07:51< gfgtdf> iceiceice: i thi yes but im not 100% sure
20140619 15:08:01< iceiceice> i dont think we should support that
20140619 15:08:07-!- _8680_ [~8680@2002:4404:712c:0:1d14:efe0:7c73:36e1] has quit [Ping timeout: 272 seconds]
20140619 15:08:14< iceiceice> it would be so much more efficient to just use a map
20140619 15:08:26< iceiceice> idk maybe im wrong
20140619 15:08:39-!- _8680_ [~8680@2002:4404:712c:0:9154:828c:f6a3:e953] has joined #wesnoth-dev
20140619 15:09:05< iceiceice> it makes it alot more confusing i guess...
20140619 15:09:19< iceiceice> it means that if you have an event on the queue that changes a variable,
20140619 15:09:23< iceiceice> it can prevent a later event from firing
20140619 15:09:25< iceiceice> or cause it to fire
20140619 15:09:30< iceiceice> by changing its name
20140619 15:09:41< iceiceice> i guess we alreayd have the "remove" event syntax?
20140619 15:10:05< iceiceice> idk its sort of redundant
20140619 15:11:24-!- sachith500 [~kvirc@112.135.62.244] has quit [Read error: Connection reset by peer]
20140619 15:12:44< gfgtdf> iceiceice: events have names an ids
20140619 15:13:05< iceiceice> oh hmm
20140619 15:13:15< iceiceice> so its the delayed_variable_substitution thing right?
20140619 15:15:13< iceiceice> i mean there coudl be a map for the events that dont have that on
20140619 15:16:06< gfgtdf> iceiceice: hm thtas would aotmaticly explude all events inside [scenario]
20140619 15:16:14< gfgtdf> iceiceice: i tihnk that would make teh code more ompilcated
20140619 15:16:40< iceiceice> y but it might greatly improve performance in some cases
20140619 15:16:44< iceiceice> as it stands, any time an event is fired
20140619 15:16:49< iceiceice> you have to basically read the entire level
20140619 15:16:57< iceiceice> if the level has very large number of custom events
20140619 15:17:13< iceiceice> idk if you have an era where many units have event handlers defined for post_Advance etc.
20140619 15:17:15< iceiceice> or recruit
20140619 15:17:32< iceiceice> you were talking before about having a "mouse enter hex" event
20140619 15:17:42< iceiceice> if you do that then every time you scroll over a new hex you need to read the entire event list
20140619 15:19:02-!- Sulfur [~Miranda@p5B009192.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20140619 15:19:05< iceiceice> idk if its actually a bottleneck right now, probably it isnt, but at some point i think it becomes one
20140619 15:26:37< gfgtdf> iceiceice: hm but evnts inside units also dont have variable subtituin applied before they are placed into the scenario
20140619 15:27:33< iceiceice> y but they wont go into the map until then either
20140619 15:28:21< iceiceice> i think we know at compile time if the event config is a vconfig or not
20140619 15:28:33< iceiceice> all we would do is make a separate pathway to speed up the ones that aren't vconfig
20140619 15:29:45< gfgtdf> iceiceice: i tihnk even with delayed vaiable substutuiton=no the reuslt is a vconfig
20140619 15:30:18< gfgtdf> name="$|my_variable" is the way with delayed variable substitution = yes i tihnk
20140619 15:30:59< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/game_events/action_wml.cpp#L791
20140619 15:31:27-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140619 15:32:06< gfgtdf> so?
20140619 15:32:19< iceiceice> the ones at cfg.get_config() are a config not a vconfig
20140619 15:32:23< iceiceice> i think those ones can go into a map
20140619 15:32:55< gfgtdf> iceiceice: no the config can still containg $
20140619 15:33:02< gfgtdf> contain "$"
20140619 15:33:26< gfgtdf> and then if teh config is converted to a vconfig the is a variable substitution
20140619 15:34:05< iceiceice> i think the configs after cfg.get_config() have their event name defined as a constant string at that point
20140619 15:34:21< iceiceice> the wiki explains that at that time, the name is fixed if delayed variable substitution is no
20140619 15:34:32< iceiceice> so even if the rest of the config contains $ the name is known
20140619 15:34:40-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has joined #wesnoth-dev
20140619 15:35:11< gfgtdf> iceiceice: hm i would believe the wiki unles i test
20140619 15:35:21< gfgtdf> iceiceice: note that we aready have map: https://github.com/wesnoth/wesnoth/blob/f09d4056296632ada3eb68c69fcad840372ee7f3/src/game_events/handlers.cpp#L66
20140619 15:36:04< iceiceice> oh its more complicated than i saw :O
20140619 15:36:13< iceiceice> so the event_queue is really a map of queues?
20140619 15:36:48< gfgtdf> event_queue just contains teh event that needs to be fred not the [event]s
20140619 15:37:23< gfgtdf> like {name="atack", pos = {x=9,y=6}} are enteies
20140619 15:37:26-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140619 15:38:23-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has quit [Quit: Laundry]
20140619 15:46:42-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 15:48:03-!- mjs-de [~mjs-de@f048077164.adsl.alicedsl.de] has quit [Quit: On the road again]
20140619 15:58:01-!- Bodhi-Baum [~Bodhi@dslb-084-063-002-093.pools.arcor-ip.net] has joined #wesnoth-dev
20140619 16:03:07-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20140619 16:06:19-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20140619 16:07:06-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140619 16:07:06-!- iceiceice [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has quit [Changing host]
20140619 16:07:06-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140619 16:10:32< irker927> wesnoth: Chris Beck wesnoth:master 78b538bc1f60 / src/ (events.hpp sound.cpp soundsource.cpp tooltips.cpp): fixup includes, remove include SDL.h from src/events.hpp http://git.io/RNjAMw
20140619 16:10:34< irker927> wesnoth: Chris Beck wesnoth:master 98922ff0af9f / src/mouse_handler_base.hpp: fixup unnecessary include http://git.io/0MPtXA
20140619 16:10:36< irker927> wesnoth: Chris Beck wesnoth:master 10d78ba4a55a / src/ (3 files in 2 dirs): fixup includes http://git.io/YPwDGQ
20140619 16:10:38< irker927> wesnoth: Chris Beck wesnoth:master 9b4756964f2e / src/ (3 files in 2 dirs): fixup includes http://git.io/OgBNyg
20140619 16:10:40< irker927> wesnoth: Chris Beck wesnoth:master cec386ad35a1 / src/ (clipboard.cpp clipboard.hpp): fixup includes in clipboard http://git.io/fHRGPQ
20140619 16:10:42< irker927> wesnoth: Chris Beck wesnoth:master 871f2f4591cf / src/ (key.cpp key.hpp): fixup includes, use uint8_t in key.hpp instead of Uint8 http://git.io/-bOoOA
20140619 16:13:32< irker927> wesnoth: Chris Beck wesnoth:master 16da9a707437 / src/key.hpp: fixup 871f2f4591cf http://git.io/Sxge5A
20140619 16:14:17-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140619 16:17:52< irker927> wesnoth: Turuk wesnoth:master 475bcf504d91 / data/campaigns/Northern_Rebirth/ (maps/01_Breaking_the_Chains.map scenarios/01_Breaking_the_Chains.cfg): NR S1 Dialogue/Map Update http://git.io/zk-X6w
20140619 16:28:38-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140619 16:28:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140619 16:29:01-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140619 16:30:24< irker927> wesnoth: mattsc wesnoth:1.12 8969c7a60eb5 / changelog data/ai/micro_ais/cas/ca_recruit_random.lua: Random Recruit Micro AI: fix bug with custom castle terrain http://git.io/gji2QA
20140619 16:33:25< irker927> wesnoth: mattsc wesnoth:master 1491934224f1 / changelog data/ai/micro_ais/cas/ca_recruit_random.lua: Random Recruit Micro AI: fix bug with custom castle terrain http://git.io/ZDVlCQ
20140619 16:34:38-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140619 16:40:01-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140619 16:41:51-!- Bodhi-Baum [~Bodhi@dslb-084-063-002-093.pools.arcor-ip.net] has quit [Ping timeout: 264 seconds]
20140619 16:55:14< irker927> wesnoth: Chris Beck wesnoth:master 8aa0d99ff220 / src/joystick.hpp: fixup includes (put inside the include guard) http://git.io/MEcf6Q
20140619 16:55:16< irker927> wesnoth: Chris Beck wesnoth:master a43fbf79f93e / src/key.hpp: fixup 16da9a707437 http://git.io/Ai9_QA
20140619 16:55:18< irker927> wesnoth: Chris Beck wesnoth:master 267ebd3385d4 / / (4 files in 4 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/uvhzYg
20140619 16:57:10-!- happygrue [~quassel@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140619 17:06:01< Necrosporus> Is it normal if I can't win scenario directly but only way I finished it is assassinating enemy leaders?
20140619 17:06:27-!- Haudegen [~quassel@91.141.3.201.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds]
20140619 17:08:24-!- Bodhi-Baum [~Bodhi@dslb-084-063-002-093.pools.arcor-ip.net] has joined #wesnoth-dev
20140619 17:14:48< mattsc> Necrosporus: depends on the scenario
20140619 17:19:15< Turuk> Necrosporus: when you say directly, do you mean wiping out all the units?
20140619 17:33:07< zookeeper> error general: The game map could not be loaded: Illegal tile in map: (Gd^Xff) 'Gd^Xff'
20140619 17:33:07< zookeeper> The map cannot be loaded.
20140619 17:33:28< zookeeper> ^ i get that as a consequence of including scenarios (which include maps, obviously) before including terrain definitions
20140619 17:33:44< zookeeper> but why does the game try to interpret maps at loading time?
20140619 17:34:33< zookeeper> i'd think the include order shouldn't make any sort of difference... because if it does, then it means the game is trying to figure out terrains immediately when it's including the map file somewhere, no?
20140619 17:38:55-!- lord-knyghtmare [~tahsinjah@203.188.163.173] has joined #wesnoth-dev
20140619 17:44:38< iceiceice> hmm thats a bit weird
20140619 17:44:39< iceiceice> src/sound.cpp:27:10: fatal error: 'SDL_sound.h' file not found
20140619 17:44:39< iceiceice> #include "SDL_sound.h"
20140619 17:47:49< irker927> wesnoth: Chris Beck wesnoth:master 54f4b77966e9 / src/ (map_location.cpp map_location.hpp): inline functions using expensive boost includes in map_location http://git.io/l4QZFA
20140619 17:47:51< irker927> wesnoth: Chris Beck wesnoth:master aabdd2969aa5 / src/sound.cpp: fixup travis http://git.io/rSStKg
20140619 17:49:45-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140619 17:51:18-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 17:51:39< gfgtdf> iceiceice: i wonder why we include SDL.h in ".." instead of <..> since its an external resource ?
20140619 17:51:58< iceiceice> gfgtdf: i dont really know
20140619 17:52:02< iceiceice> i think we aren't consistent about it
20140619 17:52:19< iceiceice> i looked at some clang diagnostics to try to figure out why our build is slow,
20140619 17:52:24< iceiceice> here's two things i learned
20140619 17:52:32< iceiceice> 1) many boost includes do not use include guards
20140619 17:52:48< iceiceice> #include <boost/function.hpp> does not have an internal include guard
20140619 17:52:59< iceiceice> so for many of our compilation units we include it many times
20140619 17:53:24-!- travis-ci [~travis-ci@ec2-54-226-0-109.compute-1.amazonaws.com] has joined #wesnoth-dev
20140619 17:53:24< travis-ci> [travis-ci] wesnoth/wesnoth#3316 (master - 267ebd3 : Chris Beck): The build was broken.
20140619 17:53:24< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27973604
20140619 17:53:24-!- travis-ci [~travis-ci@ec2-54-226-0-109.compute-1.amazonaws.com] has left #wesnoth-dev []
20140619 17:53:28< iceiceice> 2) the multindex include is very expensive, it results in like 100 headers being included
20140619 17:53:38-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140619 17:54:04-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140619 17:54:17< iceiceice> it turns out that we include several multiindex component in the header of t_string
20140619 17:54:33< iceiceice> i think it should be moved into a compilation unit instead
20140619 17:57:28< gfgtdf> iceiceice: you mean this file ? https://github.com/wesnoth/wesnoth/blob/master/src/tstring.hpp
20140619 17:57:48< iceiceice> in the shared_object.hpp
20140619 17:57:56< iceiceice> shared_object is only used by t_string
20140619 17:58:50< gfgtdf> h  see
20140619 17:59:47-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140619 18:01:34< gfgtdf> iceiceice:  but they have aan include guard 
20140619 18:01:36< irker927> wesnoth: Chris Beck wesnoth:master 06b05067b50e / src/ (soundsource.cpp tooltips.cpp): finish fix up in aabdd2969aa5430614a1c1bfe249a88aca7e8fdd http://git.io/Le2U4A
20140619 18:01:44< gfgtdf> iceiceice: you know how to enable c++11 in the travis buidl ?
20140619 18:01:52< iceiceice> gfgtdf: yeah
20140619 18:01:57< iceiceice> its just like, scons std=c++11 or something
20140619 18:02:07< iceiceice> gfgtdf: which has an include guard?
20140619 18:02:17< gfgtdf> iceiceice: boost multi index files
20140619 18:02:33< iceiceice> y those ones do but they are still really huge
20140619 18:02:42< iceiceice> if they are included in t_string then they go in practically every compilation unit unnecessarily
20140619 18:04:15-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20140619 18:04:31< mordante> servus
20140619 18:04:33< mordante> Aishiko, around?
20140619 18:05:29-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev
20140619 18:06:24-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140619 18:08:42-!- Netsplit *.net <-> *.split quits: {V}, esr, Kexoth, nurupo, Coffee_irc, Crendgrim, EliDupree, [Relic]
20140619 18:08:52< Necrosporus> Turuk, yes
20140619 18:09:08-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140619 18:09:20< Necrosporus> In order to avoid losing key units I had to kill leaders before enemy units would reach them
20140619 18:10:19< mattsc> Necrosporus: which scenario (you were talking about SotBE recently)?
20140619 18:10:25-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140619 18:10:43-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140619 18:10:43-!- Netsplit over, joins: Crendgrim, [Relic], Kexoth, nurupo, Coffee_irc, esr, {V}, EliDupree
20140619 18:11:03-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Max SendQ exceeded]
20140619 18:11:04< gfgtdf> iceiceice: do you think this will work https://github.com/gfgtdf/wesnoth-old/commit/a074cbf5648b93af30c66396f0e563820aed00be ?
20140619 18:11:16< gfgtdf> iceiceice: i juat want to test whether the curentl code works with c++11
20140619 18:11:19< gfgtdf> just
20140619 18:11:34< iceiceice> i think we should make another build if you want that
20140619 18:11:52< gfgtdf> iceiceice: no i just want to test it once
20140619 18:11:54< iceiceice> idk i guess you could push to a pull request?
20140619 18:11:55< iceiceice> idk
20140619 18:12:00< iceiceice> i think it shoudl work
20140619 18:12:10< gfgtdf> iceiceice: why poull requests ?
20140619 18:12:12< iceiceice> i can try on my machine
20140619 18:12:40< iceiceice> if you make a pull request i think it will read your .travis.yml
20140619 18:12:59< iceiceice> ok it on my machine
20140619 18:13:02< iceiceice> *didnt work
20140619 18:13:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140619 18:13:23-!- happygrue [~quassel@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20140619 18:13:48< iceiceice> it looks like you are supposed to use, 
20140619 18:13:54< iceiceice> scons cxx0x=yes
20140619 18:14:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140619 18:14:41-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140619 18:15:04-!- Netsplit *.net <-> *.split quits: {V}, esr, Kexoth, nurupo, Coffee_irc, Crendgrim, EliDupree, [Relic]
20140619 18:15:08-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140619 18:15:08-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140619 18:15:08< Aishiko> I'm here mordante 
20140619 18:15:24< mordante> hi Aishiko 
20140619 18:15:34< mordante> Aishiko, you still had some questions for me
20140619 18:15:35< Aishiko> hi mordante how are you doing?
20140619 18:15:45-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140619 18:15:49< mordante> I'm doing fine, thank you. How are you doing
20140619 18:15:50< mordante> ?
20140619 18:16:19-!- Netsplit over, joins: Crendgrim, [Relic], Kexoth, nurupo, Coffee_irc, esr, {V}, EliDupree
20140619 18:17:12< Aishiko> doing OK, as for the questions, the biggest one is I'm not sure how to set the loop to go through all the sprites.  I was hoping you might have some ideas
20140619 18:17:56< gfgtdf> iceiceice: ok i'll try this one: https://github.com/gfgtdf/wesnoth-old/commit/4b36bd94fe74ed310c87f000e0e89b59e37d14df
20140619 18:18:02-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140619 18:19:07< Aishiko> mordante, that applies to that while() statement, you noticed
20140619 18:19:31< iceiceice> gfgtdf: i got errors with c++ 0x
20140619 18:19:31< iceiceice> http://hastebin.com/adekugepeh.js
20140619 18:19:42 * mordante nods, looking at the code at the moment
20140619 18:20:12< gfgtdf> iceiceice: ok that's all i wanted to know
20140619 18:20:39< mordante> Aishiko, you also saw my remark regarding  »if(type == SPRITESHEET) { ... type = SPRITESHEET;«
20140619 18:20:57< gfgtdf> iceiceice: i wanted to whether know https://github.com/aquileia/wesnoth/commit/82a354c5acf739ecdb5d37a9463a3fcc903f680c was a c++11 or a msvc  speciafic fic
20140619 18:21:08< Aishiko> mordante, I did and it was removed, since it wasn't needed obviously
20140619 18:21:16< mordante> Aishiko, ok
20140619 18:23:02< iceiceice> gfgtdf: do all the smart pointer uses need to be explicitly casted to bools then/
20140619 18:23:26< gfgtdf> well you can still use it in if(ptr_)
20140619 18:23:35< gfgtdf> but bool a = ptr_ is wng
20140619 18:23:42< gfgtdf> wrong*
20140619 18:23:50< gfgtdf> iceiceice: ^
20140619 18:24:46< gfgtdf> bool a = ptr_;*
20140619 18:25:47< Turuk> Necrosporus: That's not ideal, but not absurd
20140619 18:27:24-!- travis-ci [~travis-ci@ec2-50-16-145-21.compute-1.amazonaws.com] has joined #wesnoth-dev
20140619 18:27:24< travis-ci> [travis-ci] gfgtdf/wesnoth-old#156 (master - 4b36bd9 : gfgtdf): The build failed.
20140619 18:27:24< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/27979380
20140619 18:27:24-!- travis-ci [~travis-ci@ec2-50-16-145-21.compute-1.amazonaws.com] has left #wesnoth-dev []
20140619 18:27:48< irker927> wesnoth: mattsc wesnoth:1.12 28d2c9e2794d / changelog data/ai/micro_ais/cas/ca_return_guardian.lua: Return Guardian MAI: fix bug when path to return hex is blocked http://git.io/dYy2QA
20140619 18:29:32< iceiceice> hmm i wonder why it was failing then
20140619 18:29:39< iceiceice> gfgtdf: ^
20140619 18:29:58< gfgtdf> well you return a ptr_; to a bool
20140619 18:30:02< iceiceice> oh i see
20140619 18:30:09< mordante> Aishiko, looking at it…
20140619 18:30:31< irker927> wesnoth: mattsc wesnoth:master 474b8990d8d1 / changelog data/ai/micro_ais/cas/ca_return_guardian.lua: Return Guardian MAI: fix bug when path to return hex is blocked http://git.io/Upo4eg
20140619 18:32:55< Aishiko> mordante, I'm hoping I might be able to do something like a for loop and not have to but I'm not sure how the for loops that the animations set up, though I have been looking
20140619 18:33:04-!- {V} [~V@72-69-ftth.on.nl] has quit [Excess Flood]
20140619 18:33:05-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Excess Flood]
20140619 18:33:22-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140619 18:33:24< mordante> Aishiko, but are there already WML files for the spritesheets?
20140619 18:33:58< iceiceice> gfgtdf: ok after, i fixed that one, i get this:
20140619 18:34:19-!- Jozrael2 [~Jozrael@cpe-23-242-93-245.socal.res.rr.com] has quit [Ping timeout: 240 seconds]
20140619 18:34:28< iceiceice> http://hastebin.com/fibetipobe.rb
20140619 18:34:38-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20140619 18:34:38< Aishiko> mordante, not yet, I could get one for testing first if you'd prefer
20140619 18:34:56< mordante> Aishiko, it should be possible to loop over them with something like »FOREACH(const AUTO & g, cfg.child_range("gui"))«
20140619 18:35:06< mordante> but that only works if they are loaded
20140619 18:35:31< gfgtdf> iceiceice: hm it abviously sys that std::auto_ptr is deprecated in c++11
20140619 18:35:31< mordante> Aishiko, is the code already in a branch of our main repository or only in your own?
20140619 18:35:43-!- Jozrael [~Jozrael@209.133.52.230] has joined #wesnoth-dev
20140619 18:35:44< iceiceice> y so i guess we have to remove that at some point
20140619 18:35:48< irker927> wesnoth: Chris Beck wesnoth:master cd596499b5bb / src/unit_map.hpp: fixup an implicit cast to bool http://git.io/XCt4VA
20140619 18:35:50< irker927> wesnoth: Chris Beck wesnoth:master 8a18fa1e404a / changelog data/ai/micro_ais/cas/ca_return_guardian.lua: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/xTOYtw
20140619 18:35:59< iceiceice> i already removed it from whiteboard actually
20140619 18:35:59< iceiceice> iirc
20140619 18:36:24< mordante> gfgtdf, iceiceice std::auto_ptr can most of the time be replaced with std::unique_ptr
20140619 18:36:25< gfgtdf> iceiceice: i think bool(ptr_) is better than (bool)ptr_. to cast
20140619 18:36:39< Aishiko> mordante, my own as it doesn't yet compile do you want me to move it?  I didn't want to commit anything that didn't compile to the "master/origin/whatever" repo
20140619 18:36:57< mordante> gfgtdf, using C-style casts is outlawed in Wesnoth
20140619 18:37:17< mordante> Aishiko, well it makes downloading the code a lot easier for me
20140619 18:37:29< gfgtdf> mordante: bool(ptr_) is a cstyle cast too ?
20140619 18:37:58< irker927> wesnoth: Chris Beck wesnoth:master a570e5b88f97 / src/unit_map.hpp: fixup previous commit http://git.io/4OmxRQ
20140619 18:38:13< mordante> gfgtdf, no just ugly in C++ you should use the xxx_casts
20140619 18:38:36< mordante> Aishiko, and if I want test something and fix it I can directly commit the fix
20140619 18:38:56< Aishiko> mordante, alright I'll push them over today
20140619 18:38:57< gfgtdf> mordante: i actualy think bool(ptr_) looks liek a nroaml contuctor call
20140619 18:39:01< gfgtdf> normal*
20140619 18:39:27< mordante> gfgtdf, iceiceice but what is the talk about c++11?
20140619 18:39:49< mordante> Aishiko, it would be great if you can do so now, then I can directly have a look at it
20140619 18:40:14< irker927> wesnoth: Chris Beck wesnoth:master 184ea58c858e / src/unit_map.hpp: fixup previous commit http://git.io/rrT6Wg
20140619 18:40:30< gfgtdf> mordante: the motivation was current code not compiling with vs 2013 where c++11 is enabled by default 
20140619 18:40:30< Aishiko> mordante, OK logging in to do that
20140619 18:43:43< mordante> gfgtdf, it is a constructor call
20140619 18:43:55< mordante> gfgtdf, do you have an error message
20140619 18:44:12< gfgtdf> mordante: no i don't
20140619 18:44:20< Aishiko> mordante, I have it pull requested, should I merge it?
20140619 18:44:30< gfgtdf> mordante: aquileia has
20140619 18:44:54 * mordante hates Microsoft for enabling C++11 unconditionally in their compiler
20140619 18:45:07< mordante> Aishiko, yes please merge and push
20140619 18:45:27-!- ancestral is now known as ancestral_lunch
20140619 18:45:49< irker927> wesnoth: Aishiko wesnoth:spritesheet 9404196dee19 / src/ (unit_animation.cpp unit_animation.hpp): Start the basis for parsing the spritesheet tags http://git.io/eBIANg
20140619 18:45:51< irker927> wesnoth: Aishiko wesnoth:spritesheet ad3d8e8eb79a / src/ (image.cpp unit_animation.cpp): Add comments and put structs into configs http://git.io/FWwDTQ
20140619 18:45:53< irker927> wesnoth: Aishiko wesnoth:spritesheet b954162ad82f / src/ (spritesheet.cpp spritesheet.hpp): Add spritesheet.cpp and spritesheet.hpp http://git.io/6Oop1A
20140619 18:45:55< irker927> wesnoth: Aishiko wesnoth:spritesheet d1ef1ac2fd93 / src/unit_animation.cpp: Add spritesheet.hpp to unit_animation.cpp http://git.io/E2gDHg
20140619 18:45:57< irker927> wesnoth: Aishiko wesnoth:spritesheet 8d3ea756e9dd / src/image.cpp: Remove redundant if statement http://git.io/um7zdQ
20140619 18:45:59< irker927> wesnoth: Aishiko wesnoth:spritesheet 9ef80d5c1842 / src/ (image.cpp spritesheet.cpp spritesheet.hpp unit_animation.cpp unit_animation.hpp): Merge pull request #211 from Aishiko/spritesheet http://git.io/AlfHRA
20140619 18:47:28-!- nurupo is now known as |-]-|-[-]-|-[-|
20140619 18:48:09< mordante> Aishiko, I've made a clone, compiling now
20140619 18:52:13-!- |-]-|-[-]-|-[-| is now known as \-\-\-\-\-\-\-\
20140619 18:52:37-!- \-\-\-\-\-\-\-\ is now known as nurupo
20140619 18:53:55-!- lord-knyghtmare [~tahsinjah@203.188.163.173] has quit [Quit: lord-knyghtmare]
20140619 19:00:07-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has joined #wesnoth-dev
20140619 19:01:55-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20140619 19:06:31< mordante> Aishiko, how are spritesheets stored? In the unit or a global file with the defintions of the spritesheets?
20140619 19:09:05< Aishiko> I thought we were doing it in the unit's cfg file when I asked that very question I was told that it should remain with the unit to make it easier on the artists
20140619 19:09:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140619 19:09:16< irker927> wesnoth: Chris Beck wesnoth:master 8f0fe88635c0 / src/ (24 files in 12 dirs): put include guards on boost/function http://git.io/hx3IlQ
20140619 19:09:18< irker927> wesnoth: Chris Beck wesnoth:master c4c69d6d796b / src/gui/widgets/ (helper.cpp helper.hpp): remove unnecessary include http://git.io/YJNQZQ
20140619 19:09:20< irker927> wesnoth: Chris Beck wesnoth:master aa999669c174 / src/ (24 files in 12 dirs): Merge branch 'include_guards_on_boost_function' http://git.io/Bd5qGg
20140619 19:10:58< Aishiko> mordante, and for the add-ons as well the unit.cfg provides the best way to accommodate both mainline and add-on
20140619 19:11:04-!- Bodhi-Baum [~Bodhi@dslb-084-063-002-093.pools.arcor-ip.net] has quit [Quit: Verlassend]
20140619 19:12:26< mordante> so a unit will have zero or more [spritesheet] configurations?
20140619 19:13:48-!- Haudegen_ [~quassel@91.141.3.201.wireless.dyn.drei.com] has joined #wesnoth-dev
20140619 19:14:03< mordante> for testing purposes it would be a good idea to add a spritesheet to a unit for testing, this can be a spitesheet with one spite… the current image
20140619 19:15:07< Aishiko> OK I'll get a test sheet today, and push it out
20140619 19:16:09< Laundry> How do I claim a bug on GNA
20140619 19:16:20< Laundry> like I want to work on one of them
20140619 19:18:04< zookeeper> Laundry, you can't unless you're part of the developers group... but you can just add a comment saying that you'll work on it
20140619 19:18:27< Laundry> oK
20140619 19:18:34< Laundry> Ok* THanks
20140619 19:18:49< zookeeper> which bug would that be, anyway?
20140619 19:18:55-!- Haudegen_ [~quassel@91.141.3.201.wireless.dyn.drei.com] has quit [Ping timeout: 272 seconds]
20140619 19:19:07< Laundry> bug #15650: lobby messages keep getting deleted
20140619 19:19:53< mordante> Aishiko, then best add a function like spritesheets() to the unit like http://paste.debian.net/105886/
20140619 19:21:29< Aishiko> mordante, and that is like the unit animations use to get all them?
20140619 19:22:24< irker927> wesnoth: Chris Beck wesnoth:master 6b477dad0ddb / src/gui/widgets/window.hpp: remove unnecessary include http://git.io/LcDXIA
20140619 19:22:34< mordante> Aishiko, http://paste.debian.net/105887/
20140619 19:22:45< zookeeper> Laundry, okay, looks good
20140619 19:22:48< mordante> Aishiko, then that part of the code needs to get the unit in question
20140619 19:23:26< Laundry> zookeeper, I'll get started asap
20140619 19:23:28< Aishiko> mordante, okay I'm following
20140619 19:26:15< mordante> Aishiko, since the animations are tied to a unit the fill_spritesheet_locations should not be static
20140619 19:27:06-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has quit [Quit: Laundry]
20140619 19:27:32< mordante> Aishiko, and probably it should take the unit it initialises as parameter
20140619 19:29:01< Aishiko> mordante, I don't think it is static, "void unit_animation::fill_spritesheet_locations( std::vector<sprite_data> & sprites, const config & cfg)"
20140619 19:29:04-!- ancestral_lunch is now known as ancestral
20140619 19:30:06< mordante> Aishiko, it's a static class member » static void fill_spritesheet_locations( std::vector<sprite_data> & sprites, const config & cfg);«
20140619 19:30:06< Aishiko> mordante, hmm your right though it is turning up as static which was not my intent
20140619 19:30:40< mordante> good :-)
20140619 19:32:41< Aishiko> mordante, this is the first time I've had something like this happen, do you know what it static when I didn't tell it to be static? is it as simple as put in the wrong place?
20140619 19:34:02< mordante> Aishiko, it's static because you added "static" in front of the function in the class definition in the header
20140619 19:34:17< mordante> in C++ static can have several meanings
20140619 19:34:33< mordante> a static function in a .cpp file affects its linking
20140619 19:34:34< irker927> wesnoth: Chris Beck wesnoth:master 19f85dffcbf4 / src/ (thread.cpp thread.hpp): move SDL threading includes out of header http://git.io/nc-Jug
20140619 19:34:52< Aishiko> ohh, well that was smart of me wasn't it?
20140619 19:35:08< mordante> a static function in a class, means it the scope of the name is the class, but it is not part of a class instance
20140619 19:35:25< mordante> (I hope that last sentence wasn't to technical)
20140619 19:35:46< mordante> Aishiko, I would say, you learned something
20140619 19:36:23< Aishiko> its not I translate that to mean, that static, when used in a class is just a behaviour of the class and not part of an object created by the class
20140619 19:37:19< Aishiko> and I did learn something, a few things actually
20140619 19:37:23< mordante> yeah something like that, so it's can't access variables of the class (unless they are also static)
20140619 19:37:41< mordante> they should normally be very rare
20140619 19:38:07< gfgtdf> wesbot: seen 	aquileia
20140619 19:38:14< gfgtdf> wesbot: seen aquileia
20140619 19:38:14< wesbot> gfgtdf: The person with the nick aquileia last spoke 6h 16m ago.  6h 10m ago they left with the message: Ping timeout: 246 seconds
20140619 19:38:22-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20140619 19:38:22< travis-ci> [travis-ci] wesnoth/wesnoth#3320 (master - 474b899 : mattsc): The build passed.
20140619 19:38:22< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27980449
20140619 19:38:22-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20140619 19:38:41< mordante> good you're here to learn
20140619 19:39:01< mordante> I think we overuse static member functions in Wesnoth
20140619 19:39:22< mordante> but the most common good example can be found in config_cache.hpp
20140619 19:39:38< Aishiko> I found another small error like that one, that I had fixed at one point (I thought I had) but it didn't get pushed out
20140619 19:39:45< mordante> the class is supposed to be a singleton (whether singletons are evil is another discussion)
20140619 19:40:05< mordante> there the static member function returns the instance of the singleton
20140619 19:41:08< iceiceice> mordante, can i ask if you something else that i did was ugly / evil?
20140619 19:41:32< iceiceice> i added this class "drawable_unit" which derives from unit, because i wanted to move the draw functions out of unit.cpp
20140619 19:41:46< iceiceice> the display objects cast a unit * to a drawable unit * when they want to call the function,
20140619 19:41:53< iceiceice> since it has no new member variables this is legal
20140619 19:42:16< iceiceice> *static cast's 
20140619 19:42:44< iceiceice> most of the other animation stuff i ended up putting in unit_animation_component, but that one i treated differently
20140619 19:44:29< irker927> wesnoth: Chris Beck wesnoth:master 7dfc3760e62e / src/gui/widgets/event_executor.hpp: remove unnecessary include http://git.io/TIW85w
20140619 19:45:29< mordante> iceiceice, what would be the advantage?
20140619 19:46:39< iceiceice> i think its good to separate game logic from game display to the extent possible
20140619 19:47:16< mordante> I agree with that, but this feels really hacky
20140619 19:47:22< iceiceice> it makes it alot easier to figure out what's going on if those things are separate, and the game logic parts dont need to include or call the display parts
20140619 19:47:29< mordante> and I'm not even 100% sure whether it's safe
20140619 19:47:42< iceiceice> hmm
20140619 19:48:00< mordante> and it might be now, but once somebody make a change to drawable_unit it might break things
20140619 19:48:09< iceiceice> so the alternative would have been like, make a friend class or something
20140619 19:48:21< iceiceice> instead of using inheritance
20140619 19:48:27< iceiceice> or just add draw_unit to the display class i guess
20140619 19:48:51< mordante> well friend classes also break encapsulation, and thus can do evil things, but it's better that this
20140619 19:49:19< iceiceice> idk if thers no good reason to have the draw function in unit.cpp
20140619 19:49:26< iceiceice> and it allows to drop alot of includes from a 3000 line file
20140619 19:49:36< iceiceice> i thought it would be worth it
20140619 19:49:55< mordante> casting a class to a superclass sounds very unsafe (at least when the object was not instanciated as superclass)
20140619 19:50:24< mordante> I don't disagree to move the code out of unit.cpp
20140619 19:50:28< iceiceice> yeah i was a bit surprised, but if it works as a static cast i figured it cant be that unsafe
20140619 19:50:31< iceiceice> but yeah its not ideal
20140619 19:50:42< iceiceice> i only went this way because i didnt want to have to retype the whole function
20140619 19:50:46-!- aquileia [863c36a4@gateway/web/freenode/ip.134.60.54.164] has joined #wesnoth-dev
20140619 19:51:11< mordante> the question is, does it need to be a friend of unit or can it use the getters/setters from unit to achieve the same
20140619 19:51:16< aquileia> gfgtdf: just to let you know, I'll be at home in 1 1/2 hours
20140619 19:52:39< iceiceice> mordante: i'll check
20140619 19:52:41-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140619 19:53:00< iceiceice> i think i had to change a bunch of member variables to be "protected" to get it to work,
20140619 19:53:03< mordante> static_cast allows it since »unit* foo = new drawable_unit(...); drawable_unit* bar = static_cast<drawable_unit*>(foo);« is safe
20140619 19:53:07< shadowm> mordante: Still no answer?
20140619 19:53:27< aquileia> The error message was that VC can't convert UnitPtr to bool (yes, the message is crap compared to the scons ones)
20140619 19:54:03< aquileia> And it's based on explicit bool not being accepted as a bool retuen value
20140619 19:54:11< mordante> shadowm, will look later, somewhat busy
20140619 19:54:16-!- aquileia [863c36a4@gateway/web/freenode/ip.134.60.54.164] has quit [Client Quit]
20140619 19:54:36< shadowm> I'd especially like to know if you went through the hassle of cleaning up chat_log's grow_factor mess like I did for my screenshots.
20140619 19:54:48< iceiceice> mordante: that doesn't require a dynamic_cast?
20140619 19:54:57< iceiceice> i think i didnt realize that
20140619 19:55:03< iceiceice> is it only because its with pointers?
20140619 19:55:07< mordante> Aishiko, do you need more help or will you be able to proceed?
20140619 19:55:41< mordante> iceiceice, try with a static_cast and a dynamic_cast, both will work in the case I stated
20140619 19:55:47< mordante> iceiceice, then try with
20140619 19:56:11< mordante> »unit* foo = new unit(...); drawable_unit* bar = static_cast<drawable_unit*>(foo);«
20140619 19:56:30< mordante> the static_cast will do something the dynamic_cast will return NULL
20140619 19:56:43< mordante> shadowm, I didn't make more modifications
20140619 19:56:51< mordante> shadowm, if you did it probably can work
20140619 19:57:05< shadowm> I mean gamestate_inspector.
20140619 19:57:37< Aishiko> mordante, I think I've got enough to go on right now on that front, the naming of an extracted sprite so it can be found we can work on next week
20140619 19:57:51< Aishiko> and by we I mean me after getting your thoughts
20140619 19:58:09-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140619 19:58:30< shadowm> mordante: Perhaps you'd ike to test the patch yourself when you have time? https://dl.dropboxusercontent.com/u/21371130/junk/fullscreen_gamestate_inspector.diff
20140619 19:58:32< iceiceice> i see
20140619 19:58:38< iceiceice> alright i'll fix it up
20140619 19:58:52-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20140619 19:58:52< travis-ci> [travis-ci] wesnoth/wesnoth#3321 (master - 8a18fa1 : Chris Beck): The build passed.
20140619 19:58:52< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27980854
20140619 19:58:52-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20140619 20:00:11-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140619 20:00:13< mordante> shadowm, I will, probably this weekend
20140619 20:00:55< mordante> Aishiko, good to know, let me know if you have more questions
20140619 20:01:52< mordante> iceiceice, I think the main problem is that your class hierarchy feels the upside down
20140619 20:02:09< Aishiko> I will and I'll place them in the files if appropriate or needed for context
20140619 20:02:21< iceiceice> hmm
20140619 20:02:33-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20140619 20:02:53< mordante> Aishiko, ok :-)
20140619 20:03:25-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20140619 20:03:25< travis-ci> [travis-ci] gfgtdf/wesnoth-old#159 (master - f1fddc0 : gfgtdf): The build passed.
20140619 20:03:25< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/27984518
20140619 20:03:25-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20140619 20:03:44< irker927> wesnoth: gfgtdf wesnoth:master 0e3b185f6284 / src/server/game.cpp: fix servergenerated replays http://git.io/qAZ1Mw
20140619 20:03:46< irker927> wesnoth: gfgtdf wesnoth:master af2d16a0d2f2 / src/ (4 files in 3 dirs): remove code duplication of unit advancements http://git.io/5pIqlw
20140619 20:04:01< mordante> but refactoring unit.cpp is somewhat hard, I did some work on it locally but never achieved a state usable to commit
20140619 20:04:50-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140619 20:05:03-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20140619 20:05:03< travis-ci> [travis-ci] wesnoth/wesnoth#3325 (spritesheet - 9ef80d5 : Aishiko): The build was broken.
20140619 20:05:03< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27981666
20140619 20:05:03-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20140619 20:05:19< iceiceice> i guess what i was thinking was that i want it to be more like model view controller
20140619 20:05:36< iceiceice> so like the unit would be in the model,
20140619 20:05:44< iceiceice> and presumably have several components that control different aspects
20140619 20:05:48< iceiceice> like the traits and abilities,
20140619 20:05:52< iceiceice> the ai variables, 
20140619 20:05:53< iceiceice> etc.
20140619 20:06:08< iceiceice> and when it needs to be drawn there is some adapter that figures out how to draw it / make it drawable or something
20140619 20:06:13< iceiceice> whne it is passed to the view
20140619 20:07:19< Aishiko> thank you travis-ci we were aware of that already
20140619 20:07:24< mordante> :-)
20140619 20:08:23< mordante> iceiceice, I'm not the biggest MVC fan, but it should be usable in this case
20140619 20:08:46< iceiceice> i see
20140619 20:08:51< iceiceice> what do you like better than MVC>
20140619 20:08:52< iceiceice> ?
20140619 20:09:03< shadowm> Isn't MVC what the chat_log and gamestate_inspector use?
20140619 20:09:17< mordante> but AFAIK the view and controller have a reference to the model and do not inherit from the model
20140619 20:09:38< mordante> shadowm, the gamestate_inspector does for certain
20140619 20:09:52< shadowm> Because both have succeeded on giving me nightmares.
20140619 20:10:08< iceiceice> fwiw the change_controller dialog was implemented using MVC i think
20140619 20:10:12< iceiceice> and it works very well :)
20140619 20:10:41< iceiceice> shadowm: i guess there are many levels at whcih MVC can be applies,
20140619 20:10:49< shadowm> I don't see a change_controller.cpp.
20140619 20:10:56< iceiceice> i dont think its in change_controller.cpp 
20140619 20:11:00< iceiceice> i cant remember what hte file is called
20140619 20:11:10< iceiceice> its the thing that comes up when you type :give_control
20140619 20:11:15< shadowm> mp_change_control.cpp.
20140619 20:12:17< iceiceice> so i guess at a high level, the play_controller is not really a controller like in MVC,
20140619 20:12:18< shadowm> I'm definitely not a fan of having the class declaration double as its implementation. :\
20140619 20:12:28< iceiceice> its more like a mediator 
20140619 20:12:43< iceiceice> thers no game state object, its all just exposed everywhere in resources
20140619 20:12:53< iceiceice> also some of the games state is member variables of display
20140619 20:13:03< iceiceice> and play controller orchestrates everything
20140619 20:13:16< iceiceice> which is why if you look at all of P R S M, its like 20,000 lines of code or something
20140619 20:13:41< iceiceice> it would be nicer imo if we had like a game_state which acted as a model
20140619 20:13:52< iceiceice> maybe it exposes an interface view, which the display attaches to
20140619 20:14:18< mordante> iceiceice, it often feels kludgy in my opinion, especially when there is only one view and one controller
20140619 20:14:18< iceiceice> or you can use an observer pattern, so that when the game state changes the display is automatically told to invalidate / redraw
20140619 20:14:37< shadowm> I can't say whether mp_change_control works very well because of its internal architecture or because the person who wrote it knew what he was doing, but I just wanted to point out that this design feels unnecessarily complex for the chat_log case at least.
20140619 20:14:38< iceiceice> and can move that code out of play controller
20140619 20:15:09< mordante> iceiceice, but like with every design pattern, at some point in time it becomes a hype and is (ab)used to solve every problem
20140619 20:15:27< shadowm> To add a single widget I needed to add a lot more lines than if it was a standard flat GUI2 dialog.
20140619 20:16:11< iceiceice> yeah i mean it might be overkill for small things i dont really know
20140619 20:16:14< iceiceice> i never tried to write gui stuff
20140619 20:16:23< iceiceice> but i guess with gui its also important to be disciplined
20140619 20:16:40< shadowm> Compare 9b065fd9a0dd066418c4b0b1c1aa304f7889a015 and e4bed0ce962f4e95ae36f285702fc23f75303f67 filtering on src/gui/
20140619 20:16:52< iceiceice> i think it would be a huge improvement though if we could sipmlify the play_controller code
20140619 20:17:02< iceiceice> and separate the concerns of, making the next step fo the game happen vs. make sure the gui si updated
20140619 20:17:07-!- cib_ [~cib@p5DD20330.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140619 20:17:30< iceiceice> i guess that might not require an MVC pattern though
20140619 20:18:07-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Ping timeout: 245 seconds]
20140619 20:19:57< mordante> Aishiko, if you have more questions, make sure to leave them in the log or send me an e-mail
20140619 20:20:07-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140619 20:20:15< mordante> Aishiko, good luck with working on the spritesheet code
20140619 20:22:57< iceiceice> shadowm: i don't think i know how to do that
20140619 20:23:02< iceiceice> is that in the git interface?
20140619 20:23:05< iceiceice> or github
20140619 20:23:38< shadowm> iceiceice: `git show -p <commit> -- paths/whose diff/you/want`
20140619 20:23:59< RiftWalker> thunderstruck: Hey
20140619 20:24:15< shadowm> Though the -- is optional if the paths don't look like a ref of any sort.
20140619 20:25:43< mordante> I'm off bye
20140619 20:25:58-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20140619 20:32:27< mattsc> Ivanovic: FYI, I will be traveling for a week starting Saturday.  And while I can build the 1.11.16 OS X package while I’m on the road, I do not know if I’ll have access to an Internet connection that lets me upload a 400MB package to SF.
20140619 20:33:06< mattsc> So for me it’s either tomorrow (Friday, June 20), or otherwise possibly not until Sunday, June 29.
20140619 20:33:13< RiftWalker> can anyone explain this section of code for me? https://github.com/wesnoth/wesnoth/blob/master/src/multiplayer.cpp#L539
20140619 20:33:15< RiftWalker> It seems to not be functional at all.
20140619 20:33:17< mattsc> Either of which is fine by me, just letting you know.
20140619 20:35:23< iceiceice> shadowm: i think its only one example
20140619 20:35:29< iceiceice> what if you wanted to add tabs / pages to the chat log?
20140619 20:35:36< iceiceice> then i think you would be much happier with a mvc
20140619 20:35:52< iceiceice> otherwise you will have to rewrite alot of code
20140619 20:36:13< shadowm> It already features pages in a way, but it's nothing that couldn't be achieved with a traditional design.
20140619 20:36:39< iceiceice> yeah i suppose so
20140619 20:37:03< shadowm> I'm conveniently ignoring gamestate_inspector because it's a more complicated thing that might actually warrant that implementation model (no pun intended).
20140619 20:37:48-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140619 20:39:28-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has joined #wesnoth-dev
20140619 20:39:35< shadowm> It does feel shoehorned, mostly because of my aversion to inline class implementations I noted above.
20140619 20:39:52< shadowm> There is a reason the first step in my campaignd refactoring was to kick the interface out of campaign_server.cpp.
20140619 20:42:04-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140619 20:42:39< gfgtdf> loonycyborg: do you know about this warning: ..\..\src\network_asio.cpp(144): warning C4996: 'boost::asio::basic_socket<Protocol,SocketService>::cancel': By default, this function always fails with operation_not_supported when used on Windows XP, Windows Server 2003, or earlier. Consult documentation for details.
20140619 20:43:51< loonycyborg> sounds vaguely famliliar
20140619 20:43:58-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140619 20:44:07-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140619 20:44:56< gfgtdf> loonycyborg: do you think i can ignore this warning ?
20140619 20:45:37< loonycyborg> if you introduced it then yes
20140619 20:45:40< loonycyborg> otherwise no
20140619 20:47:41< gfgtdf> loonycyborg: i didn't indtroduce it, idk why i get it now, maybe it's because recent changes in include system also hide some #pragma warning disable/enable.
20140619 20:49:21< gfgtdf> or maybe its causes by me accidently changing msvc properties wouldn't be the first time
20140619 20:50:12-!- Guest58470 [~travis-ci@ec2-54-226-0-109.compute-1.amazonaws.com] has joined #wesnoth-dev
20140619 20:50:12< Guest58470> [travis-ci] wesnoth/wesnoth#3326 (master - aa99966 : Chris Beck): The build has errored.
20140619 20:50:12< Guest58470> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27983499
20140619 20:50:12-!- Guest58470 [~travis-ci@ec2-54-226-0-109.compute-1.amazonaws.com] has left #wesnoth-dev []
20140619 20:51:10-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140619 20:53:53-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140619 21:05:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140619 21:06:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20140619 21:10:41< gfgtdf> iceiceice: i got a segfautl again
20140619 21:10:53< gfgtdf> iceiceice: similar to teh one i had yestartday
20140619 21:10:57< iceiceice> hmm
20140619 21:11:02< iceiceice> in same place?
20140619 21:11:24< iceiceice> i added more forward declares but i have been adding the msvc safety code also
20140619 21:11:34< gfgtdf> iceiceice: http://pastebin.com/SMX7CSTf
20140619 21:12:05< gfgtdf> iceiceice: it somehow looks like intrusive_ptr_release throws
20140619 21:12:11< gfgtdf> segfaults*
20140619 21:12:38< iceiceice> ok
20140619 21:12:45< iceiceice> lets go to unit_ptr.hpp
20140619 21:12:52< iceiceice> and put ifdef MSVC inculde unit.hpp
20140619 21:15:40< gfgtdf> hmm i dont thinkt thats it snce the msvc bug shoudl onyl appear with snall structs which unit definitely is not
20140619 21:17:52< iceiceice> y but idk what UnitPtr is
20140619 21:17:56< iceiceice> it might be a struct somehow
20140619 21:18:29< iceiceice> i think boost::intrusive_ptr<unit> mgiht be struct { unit * mine ; .... //methods }
20140619 21:18:32< iceiceice> i mean who knows
20140619 21:19:01< iceiceice> i guess if you didnt get this bug when we were using shared_ptr and intrusive_ptr before then its not likely
20140619 21:19:23-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140619 21:19:37-!- gfgtdf_ [~chatzilla@e177120185.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 21:20:44< gfgtdf_> buf we dont forward declare UnitPtr i think ?
20140619 21:21:27-!- gfgtdf [~chatzilla@f054156062.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds]
20140619 21:21:33-!- gfgtdf_ is now known as gfgtdf
20140619 21:23:07< iceiceice> we do
20140619 21:23:25< iceiceice> i mean, when you incoude unit_ptr.hpp and not unit.hpp,
20140619 21:23:29< iceiceice> UnitPtr is an incomplete type
20140619 21:23:56< iceiceice> hmm idk actually, i guess that cant be true
20140619 21:24:01-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140619 21:24:12< iceiceice> because i use it as member variables of things after including UnitPtr.hpp
20140619 21:24:25< iceiceice> but you definitely dont have unit at that time
20140619 21:24:54< iceiceice> idk its some template thing i guess
20140619 21:24:58-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140619 21:25:07-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has joined #wesnoth-dev
20140619 21:25:17< iceiceice> idk if intrusive_ptr<incomplete_type> is technically considered incomplete or not
20140619 21:29:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20140619 21:31:47< iceiceice> i guess you're right its not forward declared
20140619 21:32:12-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 0.4.2]
20140619 21:33:58< aquileia> gfgtdf: I you wanted to discuss the VC / C++11 issue, I'm here
20140619 21:34:15< Laundry> I'm going to listen to this...
20140619 21:34:54< gfgtdf> aquileia: no i wantd to ask you whether you have this bug https://gna.org/bugs/?21887 too
20140619 21:36:00< aquileia> I'll check that
20140619 21:38:39-!- gfgtdf_ [~chatzilla@e177120240.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 21:39:22-!- gfgtdf [~chatzilla@e177120185.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20140619 21:39:34-!- gfgtdf_ is now known as gfgtdf
20140619 21:39:39< gfgtdf> iceiceice: i still dont understand teh refount syste: we use 2 different refcounts in in unit_pod and one in unit ?
20140619 21:39:50< iceiceice> y its in an intermediate state
20140619 21:40:01< iceiceice> its too hard to refactor it all at once
20140619 21:40:06< iceiceice> so i just get to an intermediate state that works
20140619 21:40:08< iceiceice> and test
20140619 21:40:20< iceiceice> i guess utlimately, unit_pod will go away most likely
20140619 21:40:52< iceiceice> i guess each iterator will hold an intrusive_ptr by value as it moves
20140619 21:40:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140619 21:41:06< iceiceice> so if the unit_map removes its entry the iterator still has a ptr that wont go invalid
20140619 21:41:15< iceiceice> and the two counts will be merged then
20140619 21:41:41-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20140619 21:41:44< iceiceice> its pretty ugly right now but its just temporary...
20140619 21:41:48< gfgtdf> hm ok
20140619 21:41:50< iceiceice> there are already bugs in the system that i made some how
20140619 21:41:55< iceiceice> the whiteboard is screwd up atm
20140619 21:42:01-!- Jozrael2 [~Jozrael@209.133.52.233] has joined #wesnoth-dev
20140619 21:42:27-!- Jozrael [~Jozrael@209.133.52.230] has quit [Ping timeout: 264 seconds]
20140619 21:44:32< iceiceice> urghh..
20140619 21:44:45< iceiceice>  error: a typedef cannot be a template
20140619 21:45:16< aquileia> No, it works for me (build from yesterday, it that good enough?)
20140619 21:45:27-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20140619 21:45:31< aquileia> it took me quite a while because I coldnt use :n
20140619 21:45:35< aquileia> gfgtdf: ^
20140619 21:46:00< gfgtdf> aquileia: do alt + r work normal and you had the mouse over teh wenoth window ?
20140619 21:46:23< gfgtdf> iceiceice: ok it now looks liek teh vtable of the unit is corrupt
20140619 21:46:25< aquileia> alt + r opened the recall meu without anything special
20140619 21:46:34< gfgtdf> aquileia: hm ok
20140619 21:46:42< gfgtdf> aquileia: which vrsion of SDL are you using ?
20140619 21:46:46< gfgtdf> version
20140619 21:46:50< iceiceice> gfgtdf:
20140619 21:46:56< iceiceice> ok
20140619 21:47:04< iceiceice> mordante said that this thing i did was probably illegal
20140619 21:47:06< iceiceice> in drawable_unit
20140619 21:47:07< iceiceice> i will fix that
20140619 21:47:14< iceiceice> then unit will not have a vtable
20140619 21:47:16< gfgtdf> iceiceice: which thing ?
20140619 21:47:27< iceiceice> i was just trying to pull code out of unit.cpp
20140619 21:47:36< iceiceice> i put alot of the anmation code and state in something called unit_animation_component
20140619 21:47:43< iceiceice> more or less doing copy paste + syntax fixup
20140619 21:47:51< iceiceice> there's a fucntion called redraw_unit used only by display
20140619 21:47:59< iceiceice> so i moved that to a class drawable_unit which derives from unit
20140619 21:48:07< iceiceice> and adds no member variables, just the new function
20140619 21:48:37< iceiceice> i thought/(think?) it's legal to static cast from subclass to superclass then if the memory layout is the same, but apparently it mgiht not be
20140619 21:48:39< aquileia> gfgtdf: 1.12.14 jus as you do
20140619 21:49:29< gfgtdf> iceiceice: you shoudl be able to do stic cast even if teh memprtylayout is not teh same , meaning teh devided class added members
20140619 21:49:58< iceiceice> so what happens now is display static_casts a unit* to a drawable_unit *
20140619 21:50:00-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140619 21:50:39< iceiceice> it might be that it can be easily changed from " static_cast<drawable_unit*>(next_unit_ptr)->redraw() "
20140619 21:50:41< gfgtdf> iceiceice: static casts adjusts the pointer, especialy (void*) static_cast(B*)(a) it usual< different from (void*) (a) 
20140619 21:50:57< iceiceice> to " static_cast<drawable_unit>( *next_unit_ptr ).redraw() "
20140619 21:51:13-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20140619 21:51:13< travis-ci> [travis-ci] wesnoth/wesnoth#3329 (master - 7dfc376 : Chris Beck): The build passed.
20140619 21:51:13< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/27986331
20140619 21:51:13-!- travis-ci [~travis-ci@ec2-54-198-39-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20140619 21:51:17< gfgtdf> aquileia: hm ok
20140619 21:51:23< gfgtdf> :S
20140619 21:51:31< iceiceice> i think i will make it completely different though and not use inheritance
20140619 21:51:40< iceiceice> this was just the quickest thing to do
20140619 21:51:50< iceiceice> i thought it was safe, it didnt crash my machine
20140619 21:55:50-!- Haudegen [~quassel@91.141.3.201.wireless.dyn.drei.com] has joined #wesnoth-dev
20140619 22:05:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140619 22:06:46-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140619 22:13:05-!- kex_ [~kex@93-142-146-157.adsl.net.t-com.hr] has joined #wesnoth-dev
20140619 22:13:12< gfgtdf> iceiceice: here is more information about the segfault: http://imgur.com/Cgk0yIG
20140619 22:14:15-!- Kexoth [~kex@93-142-150-19.adsl.net.t-com.hr] has quit [Ping timeout: 264 seconds]
20140619 22:16:44< gfgtdf> looking at the "007100ec" is sems liek someone wanted to write 2 short values there
20140619 22:16:55< gfgtdf> but that's just aguess
20140619 22:27:27< iceiceice> ok
20140619 22:27:27< iceiceice> i think the thing i did is probably illegal
20140619 22:27:27< iceiceice> i will rewrite drawable unit
20140619 22:28:18< gfgtdf> iceiceice: i still cannot reliably reproduce so idk what causes that
20140619 22:31:52< gfgtdf> iceiceice: i can assume that ref_count_ shoudl never go below 0 ?
20140619 22:32:29< iceiceice> y that should never happen
20140619 22:32:40< iceiceice> it is only manipulated by intrusive_ptr
20140619 22:37:42-!- Aishiko [~Aishiko@cpe-065-191-176-226.nc.res.rr.com] has quit [Ping timeout: 245 seconds]
20140619 22:38:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140619 22:44:46-!- gfgtdf [~chatzilla@e177120240.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20140619 22:53:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20140619 22:56:27< shadowm> Why isn't the GUI2 label wrap option enabled by default, really...
20140619 23:03:50-!- irker927 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140619 23:05:56-!- gfgtdf [~chatzilla@e177120240.adsl.alicedsl.de] has joined #wesnoth-dev
20140619 23:06:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20140619 23:06:38< gfgtdf> iceiceice: in the current implementation wouldn't (*ptr) unit() reset the refcount ?
20140619 23:06:57< gfgtdf> (*ptr)  = unit() ; *
20140619 23:07:04< iceiceice> yeah
20140619 23:07:10< iceiceice> that would be bad
20140619 23:07:26< iceiceice> well
20140619 23:07:27< iceiceice> yeah i think that would be bad
20140619 23:08:04< iceiceice> do you think that is happening somewhere?
20140619 23:08:26< gfgtdf> no i just niticed this while looking at teh code
20140619 23:08:36< gfgtdf> iceiceice: do we initilize ref_count_ somewhere ?
20140619 23:08:40< gfgtdf> initilize*
20140619 23:08:45< gfgtdf> initialize*
20140619 23:09:37< iceiceice> i think its in constructor
20140619 23:10:10< iceiceice> no i guess not :/
20140619 23:10:24< iceiceice> y i guess that might be bad
20140619 23:11:27-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Ping timeout: 240 seconds]
20140619 23:12:39< Laundry> So, the bug about chat's getting deleted
20140619 23:13:02< gfgtdf> Laundry: which chats?
20140619 23:13:10< gfgtdf> Laundry: ingame or lobby ?
20140619 23:13:12< Laundry> gfgtdf: Multiplayer
20140619 23:13:17< Laundry> gfgtdf: lobby
20140619 23:13:31< Laundry> gfgtdf: It was recognized as a bug but it isn't a bug
20140619 23:13:35< gfgtdf> ok i donkt realy knwo about teh lobby
20140619 23:13:46< gfgtdf> is that a 1.13 only bug ?
20140619 23:13:55< Laundry> It was posted in 2012
20140619 23:14:08-!- DHost [~Pcy@vps.ponchy.fr] has quit [Remote host closed the connection]
20140619 23:14:12< gfgtdf> Laundry: i dot'n realy know about the code from 2012
20140619 23:14:25< Laundry> It's not a bug, it's just that the chat clears when you leave the lobby page
20140619 23:14:54< Laundry> gfgtdf: ^
20140619 23:15:19< gfgtdf> hm ok
20140619 23:15:48< gfgtdf> iceiceice: will you add ref_count_ to the initlizers list ?
20140619 23:15:54< Laundry> Someone was complaining about how it does that, and thought it was a bug. I feel like if we want to fix this we'd have to revamp the whole chat
20140619 23:15:58< iceiceice> im tryign to rewrite drawable_unit
20140619 23:16:02< iceiceice> i'll add ref_count_ after that
20140619 23:16:24< iceiceice> but if you want to go ahead
20140619 23:18:24< gfgtdf> iceiceice: do you think it's save to assume that there arent more than 1000 references ?
20140619 23:18:50< iceiceice> 1000 unit_ptr?
20140619 23:19:02< gfgtdf> ref_count_ < 1000
20140619 23:19:04< iceiceice> you mean to a single unit or overall
20140619 23:19:08< gfgtdf> single
20140619 23:19:15< aquileia> Laundry: Perhap it shold be classified as a feature request  before closing?
20140619 23:20:58< Laundry> aquileia: I agree. I don't have the permission to close bugs and stuff. It's bug number 15650
20140619 23:21:12< shadowm> If it's to be closed then it's either Invalid/Won't Fix or implemented in a previous released.
20140619 23:21:31< shadowm> version.
20140619 23:24:06-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140619 23:24:44< Laundry> Can someone set that to this bug?
20140619 23:25:41< AI0867> iceiceice, gfgtdf, aquileia: http://stackoverflow.com/questions/6242768/is-the-safe-bool-idiom-obsolete-in-c11
20140619 23:28:34-!- irker686 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140619 23:28:34< irker686> wesnoth: Alexander van Gessel wesnoth:master ebaea5812de2 / src/unit_map.hpp: Rewrite some logic so C++11 considers it a boolean context http://git.io/c5-knQ
20140619 23:28:35< AI0867> iceiceice, gfgtdf, aquileia: also ^
20140619 23:30:10< irker686> wesnoth: gfgtdf wesnoth:master 11bd01b91aef / src/unit.cpp: added test checks in intrusive_ptr_add_ref/release http://git.io/qNCRXA
20140619 23:30:44< irker686> wesnoth: Alexander van Gessel wesnoth:master bde0a3ab5225 / src/serialization/string_utils.cpp: Special-case si_string(0) so we don't get 0.0 yocto-whatever http://git.io/rNd_1w
20140619 23:30:45< AI0867> shadowm: ^
20140619 23:30:46< irker686> wesnoth: Alexander van Gessel wesnoth:master ad7cf1317d12 / src/unit.cpp: Merge branch 'master' of github.com:wesnoth/wesnoth http://git.io/QXiMMw
20140619 23:32:28< shadowm> AI0867: Yay!
20140619 23:33:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140619 23:37:14-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140619 23:38:27< gfgtdf> AI0867: I persoanly dislike to bool convertion generally, and the only case wherer i consider them useful is in assignments inside of if statemants like if(config& a = cfg.child("a")){  ...  }
20140619 23:40:21< aquileia> AI0867: Elegant, simple and fixes the issue - wow
20140619 23:47:11-!- Haudegen [~quassel@91.141.3.201.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140619 23:51:53-!- bumbadadabum [~bumbadada@173-15-188-225-BusName-Philadelphia.hfc.comcastbusiness.net] has joined #wesnoth-dev
20140619 23:52:40< aquileia> AI0867: removed my fix from the PR
20140619 23:59:11< Laundry> bug #15893 should be moved to ideas
--- Log closed Fri Jun 20 00:00:18 2014