--- Log opened Tue Jun 24 00:00:33 2014
20140624 00:03:46< Necrosporus> 09 Houses of the undead has no bonus
20140624 00:06:07< Necrosporus>  type=Ghost,Wraith,Shadow,Ghoul,Necrophage from #10, needs adding 'Ghast' as it's new unit introduced in 1.10
20140624 00:06:47< Necrosporus> Also probably order should be reversed to recall higher unit first
20140624 00:08:16< ancestral> A new unit?
20140624 00:08:49< ancestral> Oh, you’re talking about a campaign
20140624 00:09:15< Necrosporus> ancestral, yes
20140624 00:09:23< Necrosporus> But ghast is a new unit, lvl3 ghoul
20140624 00:09:39< Necrosporus> which probably was not present when this scenario was edited last time
20140624 00:09:45< ancestral> http://wesnoth.io/bestiary/ghast
20140624 00:09:47< ancestral> Yeah
20140624 00:10:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20140624 00:13:58< shadowm> Necrosporus: Since the people watching the channel at any given time might not have the opportunity to act on your reports immediately, are you writing down all this stuff to post in the tracker or the forums at a later time?
20140624 00:14:27-!- Kexoth [~kex@93-137-30-230.adsl.net.t-com.hr] has joined #wesnoth-dev
20140624 00:14:44-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral]
20140624 00:15:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140624 00:16:07< Necrosporus> shadowm, nope. Anyway, I believe, DM needs complete refactoring, there are a lot of small quirks
20140624 00:16:31< shadowm> That isn't going to happen, so if you could write this down somewhere more permanent it'd be great.
20140624 00:17:15< Necrosporus> Why not? 
20140624 00:17:59< Necrosporus> Even I could fix most of it
20140624 00:18:01< shadowm> Because the closest thing we have to a mainline campaigns maintainer said: 17:32:16 <zookeeper> i don't want to touch DM
20140624 00:18:17< shadowm> Oh, if you could submit pull requests dealing with these issues that'd also be great.
20140624 00:18:18< Necrosporus> There's Turuk 
20140624 00:18:39< shadowm> Turuk has his plate full with SotBE, I believe.
20140624 00:19:09< Necrosporus> I just finished SotBE, so I could help some here too
20140624 00:19:31< shadowm> The thing is that it's generally hard for most people to keep note of reports that aren't posted somewhere.
20140624 00:19:51-!- sachith500 [~kvirc@112.134.101.176] has joined #wesnoth-dev
20140624 00:20:05< shadowm> Unless they are right there looking at the relevant files and ready to commit.
20140624 00:23:29-!- vultraz_ [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140624 00:23:38-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20140624 00:23:47-!- vultraz_ is now known as vultraz
20140624 00:26:19-!- sachith500 [~kvirc@112.134.101.176] has quit [Read error: Connection reset by peer]
20140624 00:26:40-!- sachith500 [~kvirc@112.134.101.176] has joined #wesnoth-dev
20140624 00:33:33-!- prkc [~prkc@5400907B.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20140624 00:37:11-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140624 00:54:01-!- kex_ [~kex@93-142-130-167.adsl.net.t-com.hr] has joined #wesnoth-dev
20140624 00:54:25< Turuk> shadowm, Necrosporus: I'm splitting campaign maintenance duties with zookeeper
20140624 00:54:33-!- Kexoth [~kex@93-137-30-230.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds]
20140624 00:54:59-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140624 00:55:10< Turuk> And it would be helpful if they were documented permanently somewhere outside of chat logs
20140624 00:55:16< Turuk> I write down what I can, but they tend to get lost
20140624 01:04:37-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140624 01:28:00< irker738> wesnoth: Turuk wesnoth:master 9af0b83de285 / data/campaigns/Delfadors_Memoirs/scenarios/07_Night_in_the_Swamp.cfg: Altered objectives to reflect carryover bonus. http://git.io/sSE-qA
20140624 01:39:19< irker738> wesnoth: Turuk wesnoth:master 6698f59e253b / data/campaigns/Delfadors_Memoirs/scenarios/ (07_Night_in_the_Swamp.cfg 10_The_Gate_Between_Worlds.cfg): DM 07: Objective Change/DM 10: Add Ghast to [role] http://git.io/6XHnUg
20140624 01:41:52-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140624 01:49:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140624 01:52:33-!- ancestral_ [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140624 02:01:57-!- sachith500 [~kvirc@112.134.101.176] has quit [Ping timeout: 255 seconds]
20140624 02:03:21< irker738> wesnoth: Turuk wesnoth:1.12 ee0bcb9f99fb / data/campaigns/Delfadors_Memoirs/scenarios/10_The_Gate_Between_Worlds.cfg: DM S10: Add Ghast to [role] to complete list http://git.io/nNLMRg
20140624 02:21:52-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140624 02:21:59-!- kex_ [~kex@93-142-130-167.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140624 02:25:19-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 272 seconds]
20140624 02:38:39-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140624 02:42:04-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20140624 02:42:04-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140624 02:44:11< aquileia> Turuk_, Necrosporus_, as to the 09 carryover AFAIK there were issues with people milking the scenario for gold (if there's no bonus, why should I abandon a map with several villages before the last turn?)
20140624 02:46:53-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Quit: Page closed]
20140624 02:49:43-!- sachith500 [~kvirc@112.135.146.32] has joined #wesnoth-dev
20140624 02:53:42-!- Necrosporus_ is now known as Necrosporus
20140624 02:54:56-!- Ivanovic_ [~ivanovic@frnk-5f74c3e0.pool.mediaWays.net] has joined #wesnoth-dev
20140624 02:56:36-!- gfgtdf [~chatzilla@e177122136.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140624 02:58:20-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 244 seconds]
20140624 02:58:50-!- Ivanovic_ is now known as Ivanovic
20140624 03:04:08-!- Ivanovic [~ivanovic@frnk-5f74c3e0.pool.mediaWays.net] has quit [Changing host]
20140624 03:04:08-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140624 03:19:27-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140624 03:21:09-!- sachith500 [~kvirc@112.135.146.32] has quit [Ping timeout: 255 seconds]
20140624 03:24:03< aquileia> iceiceice: You broke openMP again (especially that curly brace at https://github.com/wesnoth/wesnoth/blob/master/src/display.cpp#L3107 is unfortunate)
20140624 03:55:49-!- mjs-de [~mjs-de@f049113174.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140624 03:58:27-!- ancestral_ [~ancestral@12.23.74.29] has quit [Quit: ancestral_]
20140624 04:10:10-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Ping timeout: 246 seconds]
20140624 04:15:31-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140624 04:15:50< aquileia> https://github.com/wesnoth/wesnoth/pull/221 should fix it, iceiceice
20140624 04:16:27-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Client Quit]
20140624 04:18:18-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140624 04:29:06-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20140624 04:30:40-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140624 04:39:59-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140624 04:48:22-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140624 04:51:09-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 255 seconds]
20140624 05:08:25-!- happygrue_ [~Wintermut@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140624 05:10:37-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140624 05:12:50-!- cib [~cib@p5DD21698.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140624 05:13:14-!- cib is now known as Guest8053
20140624 05:14:37-!- happygrue_ [~Wintermut@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140624 05:28:03-!- irker738 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140624 05:33:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140624 05:39:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140624 05:42:54< Necrosporus> > there were issues with people milking the scenario for gold < and to prevent it I'd rather set gold-per-village and upkeep to 0 and give player fixed amount of gold
20140624 05:47:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140624 06:34:03-!- Guest8053 [~cib@p5DD21698.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140624 06:41:11-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Remote host closed the connection]
20140624 06:46:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140624 06:55:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140624 06:58:51< Necrosporus> Finished DM
20140624 07:03:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140624 07:18:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140624 07:29:58-!- cib [~cib@132.231.178.87] has joined #wesnoth-dev
20140624 07:30:23-!- cib is now known as Guest80259
20140624 07:34:04-!- OnkV [~quassel@178.165.128.142.wireless.dyn.drei.com] has joined #wesnoth-dev
20140624 07:37:40-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140624 07:39:26-!- OnkV is now known as haudegen
20140624 07:43:12-!- irker961 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140624 07:43:12< irker961> wesnoth: aquileia wesnoth:master 939af32e692f / src/display.cpp: Fix openMP build http://git.io/jfRRew
20140624 07:43:14< irker961> wesnoth: Chris Beck wesnoth:master f9b32d375e8a / src/display.cpp: Merge pull request #221 from aquileia/VC_update http://git.io/PIdPcQ
20140624 07:55:38-!- Guest80259 [~cib@132.231.178.87] has quit [Ping timeout: 240 seconds]
20140624 08:10:42-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140624 08:17:11-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140624 08:22:48-!- aquileia [863c54ab@gateway/web/freenode/ip.134.60.84.171] has joined #wesnoth-dev
20140624 08:23:09-!- aquileia [863c54ab@gateway/web/freenode/ip.134.60.84.171] has quit [Client Quit]
20140624 08:24:37-!- aquileia [863c54ab@gateway/web/freenode/ip.134.60.84.171] has joined #wesnoth-dev
20140624 08:25:23-!- aquileia [863c54ab@gateway/web/freenode/ip.134.60.84.171] has quit [Client Quit]
20140624 08:26:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140624 08:26:57-!- _8680_ [~8680@2002:4404:712c:0:183:5944:2376:a80f] has quit [Ping timeout: 272 seconds]
20140624 08:27:47-!- _8680_ [~8680@2002:4404:712c:0:bc00:9fb1:4f53:cae9] has joined #wesnoth-dev
20140624 08:37:02-!- _8680_ [~8680@2002:4404:712c:0:bc00:9fb1:4f53:cae9] has quit [Remote host closed the connection]
20140624 08:37:21-!- _8680_ [~8680@2002:4404:712c:0:1d54:c21f:e0c4:e166] has joined #wesnoth-dev
20140624 08:38:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140624 08:43:18-!- aquileia [863c54ab@gateway/web/freenode/ip.134.60.84.171] has joined #wesnoth-dev
20140624 08:46:51< aquileia> zookeeper: Would you merge https://github.com/wesnoth/resources/pull/1 and https://github.com/wesnoth/resources/pull/2, please? Seeing how long #1 exists, I'd prefer them not to be forgotten
20140624 08:47:20< zookeeper> don't you have push access yet?
20140624 08:47:39< aquileia> no (and especially not to resources)
20140624 08:48:04< zookeeper> ok, well, sure, i can press the button...
20140624 08:49:45-!- haudegen [~quassel@178.165.128.142.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140624 08:50:33< irker961> wesnoth: GunChleoc resources:master 47dc66ac0a00 / image-localization/maps/The_South_Guard/ (labels_flat.png localization.xcf): Added English language text labels for The South Guard to speed up the map local http://git.io/AshubA
20140624 08:50:35< irker961> wesnoth: GunChleoc resources:master ebfa7085c05b / image-localization/maps/The_South_Guard/localization.xcf: Bold text for all labels, minimum size 18pt http://git.io/qnPk-g
20140624 08:50:37< irker961> wesnoth: GunChleoc resources:master e85ae83e8de2 / image-localization/maps/An_Orcish_Incursion/ (labels_flat.png localization.xcf): Integrated English text labels into AOI map http://git.io/yaCgew
20140624 08:50:39< irker961> wesnoth: GunChleoc resources:master 04c53e2e520b / image-localization/maps/ (17 files in 9 dirs): Added English text labels to remaining campaign maps http://git.io/BxjcVg
20140624 08:50:41< irker961> wesnoth: Lari Nieminen resources:master 63f2ac12e5d9 / image-localization/maps/ (20 files in 10 dirs): Merge pull request #1 from gunchleoc/master http://git.io/BCc5XA
20140624 08:50:49< zookeeper> #2 can't be merged
20140624 08:51:35< AI0867> aquileia: what about the comment you made on #1?
20140624 08:51:37< aquileia> Oh, that'll be because it is based on gunchleoc's work
20140624 08:51:50< aquileia> AI0867: Adressed in #2
20140624 08:52:24-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140624 08:53:37-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140624 08:58:45-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140624 09:09:11-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140624 09:15:58< aquileia> zookeeper: rebased, please try again
20140624 09:32:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140624 09:37:16-!- Haudegen_ [~quassel@80-110-40-98.static.surfer.at] has joined #wesnoth-dev
20140624 09:38:54-!- Haudegen_ is now known as haudegen
20140624 09:40:16-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev
20140624 09:50:45-!- prkc [~prkc@5400907B.dsl.pool.telekom.hu] has joined #wesnoth-dev
20140624 10:08:33-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20140624 10:09:07-!- aquileia [863c54ab@gateway/web/freenode/ip.134.60.84.171] has quit [Quit: Page closed]
20140624 10:09:25-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 264 seconds]
20140624 10:16:16-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20140624 10:29:11< irker961> wesnoth: aquileia resources:master 827adc3748cb / image-localization/maps/ (10 files in 10 dirs): Bigmap localization: Decapitalize layer names http://git.io/zmfflw
20140624 10:29:13< irker961> wesnoth: aquileia resources:master 777299f939a1 / image-localization/maps/Legend_of_Wesmere/ (labels_flat.png localization.xcf): Provide text boxes for LoW bigmap localization http://git.io/6AMaWA
20140624 10:29:15< irker961> wesnoth: aquileia resources:master 3975df74d3e5 / image-localization/maps/ (86 files in 68 dirs): Move old bigmap overlays to 'resources' http://git.io/NWwvyw
20140624 10:29:17< irker961> wesnoth: Lari Nieminen resources:master 12a77c63fd1b / image-localization/maps/ (98 files in 79 dirs): Merge pull request #2 from aquileia/LoW_map http://git.io/lYElpg
20140624 10:31:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140624 10:38:10-!- mjs-de [~mjs-de@f049077017.adsl.alicedsl.de] has joined #wesnoth-dev
20140624 11:05:53-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140624 11:07:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140624 11:15:55-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140624 11:16:12-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140624 11:55:14-!- Kexoth [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140624 11:55:40-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140624 11:57:39-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140624 11:58:55-!- sachith500 [~kvirc@112.135.140.137] has joined #wesnoth-dev
20140624 12:00:12-!- Kexoth [~kex@212.92.210.53] has quit [Ping timeout: 245 seconds]
20140624 12:12:21-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140624 12:16:46-!- aquileia [863c36a4@gateway/web/freenode/ip.134.60.54.164] has joined #wesnoth-dev
20140624 12:22:11-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140624 12:26:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20140624 12:31:28< aquileia> zookeeper: The EI deformation path might be slightly off
20140624 12:31:40-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140624 12:35:49< aquileia> Well, he'll be back sometime...
20140624 12:37:09< aquileia> I had tested my map overlays ingame, but EI slipped through it seems
20140624 12:37:41< aquileia> Except for EI, all overlays match the label positions correctly, but EI is deformed
20140624 12:38:09< aquileia> Oh, and thanks for merging PR2
20140624 12:40:43-!- aquileia [863c36a4@gateway/web/freenode/ip.134.60.54.164] has quit [Quit: Page closed]
20140624 13:13:19-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140624 13:23:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140624 13:28:03-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140624 13:29:19-!- irker961 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140624 14:03:15< zookeeper> aquileia, off how?
20140624 14:09:28< zookeeper> i ran the script on the current file and see nothing wrong with the deformation
20140624 14:15:46-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140624 14:41:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140624 14:58:47-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140624 15:00:58-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140624 15:02:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140624 15:28:53-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140624 15:33:27-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev
20140624 15:38:20-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20140624 15:42:50-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20140624 15:49:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140624 15:55:28-!- haudegen [~quassel@80-110-40-98.static.surfer.at] has quit [Remote host closed the connection]
20140624 16:11:22-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Remote host closed the connection]
20140624 16:14:43-!- sachith500|2 [~kvirc@112.134.0.186] has joined #wesnoth-dev
20140624 16:17:17-!- sachith500 [~kvirc@112.135.140.137] has quit [Ping timeout: 245 seconds]
20140624 16:23:19-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev
20140624 16:24:27-!- sachith500|2 [~kvirc@112.134.0.186] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140624 16:29:01-!- Kexoth [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140624 16:29:29-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev
20140624 16:31:38-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140624 16:33:33-!- Kexoth [~kex@212.92.210.53] has quit [Ping timeout: 240 seconds]
20140624 16:49:01-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 264 seconds]
20140624 16:56:55-!- Haudegen [~quassel@178.165.128.142.wireless.dyn.drei.com] has joined #wesnoth-dev
20140624 16:57:05-!- Haudegen is now known as Guest51891
20140624 16:59:26-!- Kexoth [~kex@93-142-130-167.adsl.net.t-com.hr] has joined #wesnoth-dev
20140624 17:12:53-!- irker701 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140624 17:12:53< irker701> wesnoth: Chris Beck wesnoth:master 663494f6614e / / (4 files in 3 dirs): move teambuilder to its own file http://git.io/KtAVmw
20140624 17:14:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140624 17:17:25-!- cib [~cib@p5DD21698.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140624 17:17:49-!- cib is now known as Guest78585
20140624 17:17:57-!- Guest78585 is now known as cib1
20140624 17:30:04-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140624 17:38:02-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140624 17:41:02< AI0867> wesbot: seen thunderstruck
20140624 17:41:02< wesbot> AI0867: The person with the nick thunderstruck last spoke 22h 42m ago.  21h 50m ago was here and on the channel #wesnoth with the message:
20140624 17:50:10< irker701> wesnoth: Chris Beck wesnoth:master cf2651b5a70d / / (10 files in 3 dirs): rename drawable_unit.?pp -> unit_drawer.?pp, b/c of new contents http://git.io/DaPyJQ
20140624 17:50:12< irker701> wesnoth: Chris Beck wesnoth:master b51d6a15d1ed / / (30 files in 9 dirs): rename gamestatus.?pp -> game_data.?pp, b/c of content changes https://github.com/wesnoth/wesnoth/commit/b51d6a15d1ed372c7bf385dd2a3f68b75b1ac347
20140624 17:50:26< iceiceice_> aquileia: btw, with this whole openmp thing
20140624 17:50:38< iceiceice_> there were code comments in the fake units code before i moved it,
20140624 17:50:48-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Read error: Connection reset by peer]
20140624 17:50:48< iceiceice_> that say basically, the fake units are suppsoed to be drawn after the unit_map units
20140624 17:51:07< iceiceice_> i dont think the open mp thing, prior to our changes, was doing that though
20140624 17:51:21< iceiceice_> as i understand, when you parallelize a loop the units are drawn in some arbitrary order?
20140624 17:51:23-!- Guest51891 [~quassel@178.165.128.142.wireless.dyn.drei.com] has quit [Quit: No Ping reply in 180 seconds.]
20140624 17:51:55< iceiceice_> idk if it causes any noticeable problems, i dont run an openmp compiled version
20140624 17:52:05< iceiceice_> but if you see any wierd graphical stuff i guess thats potentially an explanation
20140624 17:52:28< aquileia> iceiceice_: I don't know much about OMP, but AFAIK yes, if you don't specify otherwise, there's no specific order
20140624 17:52:46-!- Haudegen [~quassel@178.165.128.142.wireless.dyn.drei.com] has joined #wesnoth-dev
20140624 17:53:21< iceiceice_> idk who wrote the openmp stuff before, but i think they sort of tried to ensure this, at least they were making sure the fake units were at the end of the list that was being looped over
20140624 17:53:38< iceiceice_> anyways i guess we should just remember it in case someone reports glitches
20140624 17:54:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140624 17:54:53< aquileia> btw looping twice over the same index range (as we do now) can improve performance
20140624 17:56:04< aquileia> If the compiler uses static scheduling for the loop, all threads will have some necessary objects in their cache block
20140624 17:56:39< aquileia> But the most important thing is that it compiles at all
20140624 17:57:33< aquileia> We don't want loonycyborg to start bugfixing before he can release the new binaries
20140624 17:57:36< aquileia> ;)
20140624 18:00:58< iceiceice_> thats true
20140624 18:01:09< iceiceice_> i did actually compile my earlier version with scons openmp=yes
20140624 18:01:14< iceiceice_> so idk what is different in vc
20140624 18:01:29< aquileia> zookeeper: I reran the script and everything's fine now... false alarm
20140624 18:01:39< iceiceice_> but at the same time i dont really know what i'm doing, i was just working from code examples
20140624 18:01:48< zookeeper> aquileia, okay
20140624 18:02:58< aquileia> iceiceice_: You didn't have that flag set, that additional closing brace would error on any compiler
20140624 18:03:53< aquileia> Perhaps you just found an error in the scons script...
20140624 18:04:01< iceiceice_> ok well it didn't error on my compiler / travis
20140624 18:04:12< iceiceice_> maybe i didnt see what you are mentioning?
20140624 18:04:19< iceiceice_> * i guess travis didnt have openmp on
20140624 18:05:41< iceiceice_> hmm idk 
20140624 18:05:48< aquileia> https://github.com/wesnoth/wesnoth/blob/34a745469667ef55ef5afd7ced080908be63c1fb/src/display.cpp#L3107
20140624 18:05:49< iceiceice_> yeah you are right something looks wrong there :/
20140624 18:05:59< aquileia> that was fast...
20140624 18:05:59< wesbot> aquileia: Sometimes we are fast
20140624 18:09:51< aquileia> zookeeper: wait... the new overlay looks identical to the broken one!
20140624 18:10:08< zookeeper> i'm not following
20140624 18:10:33< aquileia> Is it possible that the "english map" in EI's xcf isn't the one used in mainline?
20140624 18:11:24-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140624 18:11:39< vultraz> hello RiftWalker 
20140624 18:11:45 * zookeeper checks
20140624 18:12:17< zookeeper> aquileia, oh wow, indeed, it's a slightly different version
20140624 18:12:20< zookeeper> durr
20140624 18:12:32< aquileia> which one to fix?
20140624 18:13:42< zookeeper> i guess we should treat the in-game map as the right one
20140624 18:14:01< zookeeper> it's the one i've build the journey markers with after all... but let me double-check just to make sure :p
20140624 18:14:23-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Remote host closed the connection]
20140624 18:15:20< zookeeper> yes, confirmed
20140624 18:17:36-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140624 18:20:49< aquileia> zookeeper: At least I'll be the only translator having to worry about bugs - it's thoroughly tested by us both now
20140624 18:21:21< irker701> wesnoth: Chris Beck wesnoth:master bd9fb6914ce4 / src/ (6 files): change saved_game name to saved_game_ in play_controllers http://git.io/llGETA
20140624 18:23:10< zookeeper> aquileia, yeah, it's great. how many bugs have you spotted by now, 5? :P
20140624 18:25:27< aquileia> oh, and by the way, the credits still say "sprite animation, various visual tweaks" for you and list Kestevarn as our "current" map designer
20140624 18:26:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140624 18:26:18< aquileia> so while you're at it you could mention there that you're our new map creator
20140624 18:26:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20140624 18:27:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140624 18:32:01-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140624 18:38:59< zookeeper> aquileia, ah, true enough
20140624 18:48:49-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has joined #wesnoth-dev
20140624 18:52:37< thunderstruck> seen AI0867 
20140624 18:53:44-!- ancestral is now known as ancestral_lunch
20140624 18:55:12-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 245 seconds]
20140624 19:05:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140624 19:16:37-!- cib1 [~cib@p5DD21698.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20140624 19:18:33-!- Kexoth [~kex@93-142-130-167.adsl.net.t-com.hr] has quit []
20140624 19:21:14-!- Kexoth [~kex@93-142-130-167.adsl.net.t-com.hr] has joined #wesnoth-dev
20140624 19:25:01-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140624 19:30:24-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20140624 19:36:43-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140624 19:38:46-!- ancestral_lunch is now known as ancestral
20140624 19:49:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140624 19:49:32< irker701> wesnoth: ln-zookeeper wesnoth:master 614451782534 / data/core/about.cfg: Updated bigmap credits http://git.io/ILYgAg
20140624 19:50:15-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-trlhmnqkoyhsvavc] has quit [Quit: PanicBNC - https://PanicBNC.net - currently sucks]
20140624 19:53:23< irker701> wesnoth: ln-zookeeper wesnoth:1.12 a37a0f027b26 / data/core/about.cfg: Updated bigmap credits http://git.io/D5oUjw
20140624 20:08:53-!- gfgtdf [~chatzilla@e177122136.adsl.alicedsl.de] has joined #wesnoth-dev
20140624 20:14:36-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140624 20:17:31< AI0867> RiftWalker: I commented on your PR
20140624 20:29:12< AI0867> aquileia: are you going to update #117?
20140624 20:31:53-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20140624 20:52:36< irker701> wesnoth: Lari Nieminen resources:master 62c612543a38 / image-localization/maps/Eastern_Invasion/localization.xcf: Fixed map layers out of sync with the actual EI map http://git.io/wAoU5Q
20140624 20:52:41< zookeeper> aquileia, ^ should be fixed now
20140624 21:21:31-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Ping timeout: 272 seconds]
20140624 21:21:47< irker701> wesnoth: Chris Beck wesnoth:master 3d6f2d782110 / src/ (5 files): add game_state class, separate from play_controller http://git.io/GRcKag
20140624 21:21:49< irker701> wesnoth: Chris Beck wesnoth:master 30a443d12f30 / / (8 files in 3 dirs): move game_state to its own file http://git.io/a_c0cA
20140624 21:21:51< irker701> wesnoth: Chris Beck wesnoth:master e85c37e16179 / src/ (play_controller.cpp play_controller.hpp): remove unused member (dead code) http://git.io/4HIOPA
20140624 21:21:53< irker701> wesnoth: Chris Beck wesnoth:master bcb39542c5d7 / src/ (5 files): tweaks to play_controller::init http://git.io/zix_mQ
20140624 21:21:55< irker701> wesnoth: Chris Beck wesnoth:master 15352a24e8b6 / src/ (5 files): move some initializing from play_controller to game_state http://git.io/vcpybQ
20140624 21:21:57< irker701> wesnoth: Chris Beck wesnoth:master d583b3e4015d / src/ (game_state.cpp game_state.hpp play_controller.cpp): add game_state::to_config http://git.io/bKswSg
20140624 21:21:59< irker701> wesnoth: Chris Beck wesnoth:master 9757a2d267cc / data/core/about.cfg: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/kEeqSg
20140624 21:22:45-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has joined #wesnoth-dev
20140624 21:28:08-!- gfgtdf [~chatzilla@e177122136.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20140624 21:28:14-!- gfgtdf_ [~chatzilla@e177126179.adsl.alicedsl.de] has joined #wesnoth-dev
20140624 21:28:15-!- gfgtdf_ is now known as gfgtdf
20140624 21:29:15-!- timotei_ is now known as timotei
20140624 21:36:42< irker701> wesnoth: gfgtdf wesnoth:master 97c1178e022c / src/play_controller.cpp: commented out unneeded code http://git.io/k8kfwQ
20140624 21:41:11< irker701> wesnoth: gfgtdf wesnoth:master d3392cdee5d9 / src/play_controller.cpp: add comment http://git.io/s3dF4w
20140624 21:43:23-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140624 21:43:43-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Remote host closed the connection]
20140624 21:57:35< Ivanovic> wesbot: seen Crab_
20140624 21:57:35< wesbot> Ivanovic: Sorry, I don't know of Crab_.
20140624 21:57:41< Ivanovic> wesbot: seen happygrue
20140624 21:57:41< wesbot> Ivanovic: The person with the nick happygrue 6h 19m ago was here and on the channels #wesnoth and #wesnoth-umc-dev with the message: Remote host closed the connection
20140624 21:57:45< Ivanovic> wesbot: seen Crab
20140624 21:57:45< wesbot> Ivanovic: Sorry, I don't know of Crab.
20140624 22:02:06-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140624 22:06:53-!- Haudegen [~quassel@178.165.128.142.wireless.dyn.drei.com] has quit [Ping timeout: 244 seconds]
20140624 22:10:19-!- Haudegen [~quassel@178.165.128.142.wireless.dyn.drei.com] has joined #wesnoth-dev
20140624 22:13:34-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140624 22:22:27-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wyruzsaeupmrptwo] has joined #wesnoth-dev
20140624 22:23:52< iceiceice_> gfgtdf:
20140624 22:24:02< iceiceice_> i made an attempt to fix up the unit_map and get rid of unit_pods,
20140624 22:24:27< iceiceice_> but i realized that actually it's needed atm to support extra assumptions we make about iterators
20140624 22:24:55-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has quit [Quit: leaving]
20140624 22:25:21< iceiceice_> the change i had planned keeps iterators valid for deletion, even if their unit is removed from the map
20140624 22:25:27< iceiceice_> *valid for dereference
20140624 22:26:17< iceiceice_> but they aren't valid to increment
20140624 22:26:50< iceiceice_> so if you want to loop over all units and delete some of them, you either have to explicitly preincrement the iterator, or use std::remove_if
20140624 22:27:00-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20140624 22:27:04< iceiceice_> i didnt realize that we had code based on this assumption
20140624 22:27:16< gfgtdf> iceiceice_: do you know which code exacly need the that assumption ?
20140624 22:27:30< iceiceice_> some parts of whiteboard (but that was easy to fix)
20140624 22:27:31< iceiceice_> some parts of ai
20140624 22:27:41< iceiceice_> idk i just tested and got segfaults in various places
20140624 22:27:52< iceiceice_> i'm not sure how many places do it
20140624 22:32:41< iceiceice_> idk i dont really want to change the assumptions of the unit_map if they were being used by people
20140624 22:32:55< iceiceice_> not without mailing the list anyway
20140624 22:33:13< iceiceice_> idk if i can see a way to make the iterators safe to increment without keepign the "soft extraction" behavior
20140624 22:33:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: GO, GET TO THE CHOPPAH!!!]
20140624 22:33:23< iceiceice_> and i dont see how to keep that without having a secondary reference counter
20140624 22:33:36-!- Samual [~dioteckte@xonotic/core-team/Samual] has quit [Ping timeout: 255 seconds]
20140624 22:33:39< iceiceice_> the only reason to remove is to reduce code complexity
20140624 22:33:49< iceiceice_> and i guess efficiency but i consider that minor
20140624 22:34:25< iceiceice_> idk it's somewhat worthwhile for the unit_map to be easy to use
20140624 22:36:42< gfgtdf> iceiceice_: we usualy remove unit form the map with unit_map::erase  function ?
20140624 22:36:52< iceiceice_> or extract i guess
20140624 22:36:53< gfgtdf> iceiceice_: i have to say that i dont laike that method
20140624 22:37:07< gfgtdf> iceiceice_: you knwo why it returns size_t and not bool ?
20140624 22:37:32< iceiceice_> it might delete several units it hnk
20140624 22:37:44< gfgtdf> iceiceice_:  no i cannot
20140624 22:37:50< iceiceice_> hmm the comments in the code suggest this
20140624 22:37:52< gfgtdf> iceiceice_: e there cannot be more units on one hex
20140624 22:38:06< gfgtdf> iceiceice_: the commey says it alwqays retuns 0 or 1
20140624 22:38:08< gfgtdf> comment
20140624 22:38:24< iceiceice_> hehe 
20140624 22:38:34-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wyruzsaeupmrptwo] has quit [Changing host]
20140624 22:38:34-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20140624 22:38:34-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20140624 22:38:34-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wyruzsaeupmrptwo] has joined #wesnoth-dev
20140624 22:38:37< iceiceice_> i guess you are right, it actualy is clear from the code it return s0 or 1
20140624 22:38:38-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140624 22:38:59-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140624 22:39:08< iceiceice> gfgtdf: yeah it should be bool
20140624 22:39:15-!- ancestral is now known as ancestral_afk
20140624 22:39:30< gfgtdf> iceiceice: do you think we can make the iterators know whether it can be increased ?
20140624 22:40:10< iceiceice> idk
20140624 22:41:05< iceiceice> its somewhat unclear to me what the unit_map iterator is supposed to represent,
20140624 22:41:21< iceiceice> whether it represents the  thing at the location in the map, or the unit it's pointing at
20140624 22:41:41< iceiceice> i realized that the behavior of .valid() changes slightly after my current PR,
20140624 22:42:00< iceiceice> in the past if you remove a unit from the map, an iterator to that spot realized the unit is gone and says it's not valid
20140624 22:42:17< iceiceice> and i guess if i different unit is placed there, it points to that unit instead
20140624 22:42:33< iceiceice> i didnt realize about that behavior, i think most of the code uses it like " unit_map::find_unit(...) "
20140624 22:42:37< iceiceice> and then assumes its a handle to that unit
20140624 22:46:16-!- travis-ci [~travis-ci@ec2-54-83-67-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20140624 22:46:16< travis-ci> [travis-ci] wesnoth/wesnoth#3395 (master - 97c1178 : gfgtdf): The build passed.
20140624 22:46:16< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/28355581
20140624 22:46:16-!- travis-ci [~travis-ci@ec2-54-83-67-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20140624 22:47:36< iceiceice> gfgtdf: i think the best way to make the iterators know they cant be erased would be like,
20140624 22:47:40-!- spoffy [~spoffy@host-80-47-182-115.as13285.net] has joined #wesnoth-dev
20140624 22:48:11< iceiceice> use something like unit_pod
20140624 22:48:26< iceiceice> like, struct { UnitPtr unit; bool is_valid; }
20140624 22:48:55< iceiceice> and the unit_map itself holds (intrusive_ptr) pointers to those
20140624 22:49:08< iceiceice> and the iterators hold a copy
20140624 22:50:00< iceiceice> idk maybe that should be the code for debug mode, and make it give an assertion failure if you deref a dead iterator
20140624 22:51:24< iceiceice> but we can also just keep it the way it is, there's not so much to be gained here right now
20140624 22:52:59-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving]
20140624 23:01:45-!- RiftWalker [~nathan@ip24-252-126-205.no.no.cox.net] has quit [Remote host closed the connection]
20140624 23:01:46-!- mjs-de [~mjs-de@f049077017.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140624 23:05:32-!- ancestral_afk is now known as ancestral
20140624 23:08:35-!- Jetrel_ [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140624 23:09:39-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140624 23:11:38< aquileia> AI0867: #117 will be updated eventually, but most probably not before mid august
20140624 23:12:25-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 264 seconds]
20140624 23:21:11-!- Haudegen [~quassel@178.165.128.142.wireless.dyn.drei.com] has quit [Remote host closed the connection]
20140624 23:22:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20140624 23:34:57< irker701> wesnoth: Ignacio R. Morelle wesnoth:master 806ed31b9fc7 / src/gui/dialogs/game_cache_options.cpp: gui2/tgame_cache_options: Add wiki documentation http://git.io/wu8Z8g
20140624 23:36:28-!- spoffy [~spoffy@host-80-47-182-115.as13285.net] has quit [Remote host closed the connection]
20140624 23:43:43-!- spoffy [~spoffy@host-80-47-182-115.as13285.net] has joined #wesnoth-dev
20140624 23:44:22< shadowm> gfgtdf, iceiceice: src/saved_game.hpp (and I'm guessing a few other files as well) lacks a copyright statement, Doxygen comments are provided using a mix of both /// and /** comments (we use /** comments for new code), and is a punctuation and grammar mess.
20140624 23:46:51< shadowm> syncmp_handler.hpp and friends lacks a copyright statement too.
20140624 23:46:55< shadowm> *lack
20140624 23:48:08< shadowm> synced_checkup.hpp's documentation is composed of comments that aren't Doxygen comments, needs prose review.
20140624 23:48:49< shadowm> Same goes for most of synced_commands.hpp and synced_context.hpp,.
20140624 23:50:00< shadowm> unit_animation_component.hpp has pretty much no documentation at all, unit_drawer.hpp has a Doxygen comment that seems to have been meant to go with the declaration of unit_drawer but isn't.
20140624 23:51:08< shadowm> random_new_deterministic.hpp has a faux-Doxygen comment and typoed English too.
20140624 23:52:12< shadowm> random_new.hpp's documentation is full of typos.
20140624 23:52:40< shadowm> It's also incomplete and not Doxygen.
20140624 23:55:06< gfgtdf> iceiceice: msvc complains that in https://github.com/wesnoth/wesnoth/blob/master/src/game_events/action_wml.cpp#L242 the second argument 'gender' is casted to bool. which is  most liley not the intended bahviour
20140624 23:55:19< gfgtdf> third*
20140624 23:56:06< shadowm> For make_enum.hpp you should look into Doxygen's @code command.
20140624 23:57:08< shadowm> playturn_network_adapter.hpp ocne again has non-Doxygen documentation.
20140624 23:57:16< shadowm> And no copyright statement.
20140624 23:58:13< shadowm> recall_list_manager.hpp suggests somebody has been using CamelCase in new code, not good (also, it has no documentation at all for non-obvious elements).
20140624 23:59:47< shadowm> replay_helper in replay_helper.hpp has no documentation explaining why it's a class with nothing more than static methods, instead of a namespace with member functions.
--- Log closed Wed Jun 25 00:00:06 2014