--- Log opened Thu Jun 26 00:00:12 2014 20140626 00:06:01< irker701> wesnoth: Chris Beck wesnoth:master 7c6e47d7e70c / src/config.hpp: attempt to fix travis compilation http://git.io/2fWyew 20140626 00:16:58-!- Kexoth [~kex@93-137-10-176.adsl.net.t-com.hr] has quit [Remote host closed the connection] 20140626 00:22:14-!- prkc [~prkc@54028627.dsl.pool.telekom.hu] has quit [Remote host closed the connection] 20140626 00:23:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140626 00:23:50< irker701> wesnoth: Chris Beck wesnoth:master 236e26e7947b / src/game.cpp: Revert "attempt to fix travis compilation" http://git.io/pjTmcg 20140626 00:46:40-!- groggy [~chatzilla@75-131-165-124.dhcp.spbg.sc.charter.com] has joined #wesnoth-dev 20140626 00:49:57-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Ping timeout: 255 seconds] 20140626 00:50:26-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev 20140626 00:51:52 * shadowm stares blankly. 20140626 00:53:07< shadowm> Ivanovic: So, what happened to the plans for 1.11.16? 20140626 00:53:47< shadowm> I vaguely recall you saying something about "next Thursday or so" before last Thursday. 20140626 01:04:46< Laundry> I thought that was if it was on time? 20140626 01:06:10-!- travis-ci [~travis-ci@ec2-54-237-167-213.compute-1.amazonaws.com] has joined #wesnoth-dev 20140626 01:06:10< travis-ci> [travis-ci] wesnoth/wesnoth#3442 (master - 236e26e : Chris Beck): The build was fixed. 20140626 01:06:10< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/28460386 20140626 01:06:10-!- travis-ci [~travis-ci@ec2-54-237-167-213.compute-1.amazonaws.com] has left #wesnoth-dev [] 20140626 01:08:05< irker701> wesnoth: Chris Beck wesnoth:master 221863b89381 / src/config.hpp: remove unnecessary include from header, despite what iwyu tool says http://git.io/8ndn2Q 20140626 01:11:28-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has quit [Quit: Laundry] 20140626 01:14:33-!- groggy [~chatzilla@75-131-165-124.dhcp.spbg.sc.charter.com] has quit [Remote host closed the connection] 20140626 01:29:25-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral] 20140626 01:29:51-!- sachith500 [~kvirc@112.134.96.253] has joined #wesnoth-dev 20140626 02:05:33-!- Kexoth [~kex@93-142-136-33.adsl.net.t-com.hr] has joined #wesnoth-dev 20140626 02:09:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140626 02:10:12-!- Kexoth [~kex@93-142-136-33.adsl.net.t-com.hr] has quit [Ping timeout: 240 seconds] 20140626 02:11:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140626 02:22:40< irker701> wesnoth: Chris Beck wesnoth:master f5a9de40d55d / src/ (16 files in 6 dirs): move village_owner function to display_context http://git.io/ggv5jg 20140626 02:25:01-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 264 seconds] 20140626 02:38:30-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20140626 02:52:15-!- Ivanovic_ [~ivanovic@frnk-5f74e465.pool.mediaWays.net] has joined #wesnoth-dev 20140626 02:55:20-!- Ivanovic_ [~ivanovic@frnk-5f74e465.pool.mediaWays.net] has quit [Changing host] 20140626 02:55:20-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140626 02:55:33-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds] 20140626 02:56:23-!- Ivanovic_ is now known as Ivanovic 20140626 02:57:51-!- sachith500|2 [~kvirc@112.135.142.132] has joined #wesnoth-dev 20140626 03:01:37-!- sachith500 [~kvirc@112.134.96.253] has quit [Ping timeout: 264 seconds] 20140626 03:37:53-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140626 03:54:32-!- Kexoth [~kex@93-142-136-33.adsl.net.t-com.hr] has joined #wesnoth-dev 20140626 03:57:04-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20140626 03:59:12-!- Kexoth [~kex@93-142-136-33.adsl.net.t-com.hr] has quit [Ping timeout: 264 seconds] 20140626 04:17:40-!- Kexoth [~kex@93-142-136-33.adsl.net.t-com.hr] has joined #wesnoth-dev 20140626 04:21:56-!- Kexoth [~kex@93-142-136-33.adsl.net.t-com.hr] has quit [Ping timeout: 244 seconds] 20140626 04:23:42-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 255 seconds] 20140626 04:23:46-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140626 04:33:32-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20140626 04:44:07< irker701> wesnoth: Chris Beck wesnoth:master e62553139c38 / src/ (11 files in 2 dirs): move is_observer to gameboard, with accessor in playcontroller http://git.io/V9cg-g 20140626 04:54:02-!- Guest48170 [~cib@p5DC75223.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140626 04:57:54-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 255 seconds] 20140626 05:03:52-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer] 20140626 05:12:15-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has quit [Remote host closed the connection] 20140626 05:17:09-!- sachith500|2 [~kvirc@112.135.142.132] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 20140626 06:02:06-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20140626 06:33:45-!- Guest48170 [~cib@p5DC75223.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds] 20140626 06:40:20-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Remote host closed the connection] 20140626 06:43:54-!- markus_ [~mjs-de@f048181013.adsl.alicedsl.de] has quit [Quit: On the road again] 20140626 06:54:05-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140626 06:55:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20140626 07:12:27-!- ancestral [~ancestral@12.23.74.29] has quit [Ping timeout: 255 seconds] 20140626 07:22:57-!- cib [~cib@132.231.178.142] has joined #wesnoth-dev 20140626 07:23:21-!- cib is now known as Guest61070 20140626 07:34:30-!- DHost [~Pcy@vps.ponchy.fr] has joined #wesnoth-dev 20140626 07:51:39-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140626 07:55:33-!- Guest61070 [~cib@132.231.178.142] has quit [Ping timeout: 240 seconds] 20140626 08:23:30-!- irker701 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20140626 08:34:02-!- gfgtdf [~chatzilla@f054162133.adsl.alicedsl.de] has joined #wesnoth-dev 20140626 08:35:11< gfgtdf> thundersruck: do you think you can implement this TODO: https://github.com/wesnoth/wesnoth/blob/1.12/src/playcampaign.cpp#L631 before 1.12 ? 20140626 08:35:14-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev 20140626 08:47:36-!- gfgtdf [~chatzilla@f054162133.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]] 20140626 08:54:17-!- matthiaskrgr is now known as matthiaskrgrr 20140626 08:55:29-!- matthiaskrgrr is now known as matthiaskrgr 20140626 08:56:09-!- Kexoth [~kex@212.92.210.53] has joined #wesnoth-dev 20140626 09:07:02-!- Haudegen [~quassel@80-110-40-98.static.surfer.at] has joined #wesnoth-dev 20140626 09:09:04-!- ejls [~ejls@ejls.fr] has quit [Quit: -1] 20140626 09:09:48-!- ejls [~ejls@esimon.eu] has joined #wesnoth-dev 20140626 09:46:17-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Quit: Ex-Chat] 20140626 09:48:45-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev 20140626 10:34:24-!- prkc [~prkc@54028627.dsl.pool.telekom.hu] has joined #wesnoth-dev 20140626 10:39:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer] 20140626 10:39:42-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20140626 10:40:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140626 10:42:33-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds] 20140626 10:51:55-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral] 20140626 10:53:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140626 11:07:19-!- mjs-de [~mjs-de@f048181013.adsl.alicedsl.de] has joined #wesnoth-dev 20140626 11:25:57-!- {V} [~V@72-69-ftth.on.nl] has quit [Ping timeout: 272 seconds] 20140626 11:26:39-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev 20140626 11:39:15-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 272 seconds] 20140626 11:39:16-!- sachith500 [~kvirc@112.135.142.132] has joined #wesnoth-dev 20140626 11:42:22-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20140626 11:50:49-!- Guest61070 [~cib@132.231.178.16] has joined #wesnoth-dev 20140626 11:51:47 * zookeeper will be afk for a couple of days 20140626 11:56:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20140626 12:01:27-!- Guest61070 [~cib@132.231.178.16] has quit [Ping timeout: 245 seconds] 20140626 12:12:23-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 0.4.2] 20140626 12:13:19-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20140626 12:13:19-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20140626 12:13:19-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20140626 12:21:38-!- Guest61070 [~cib@132.231.178.75] has joined #wesnoth-dev 20140626 12:29:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140626 12:33:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140626 12:56:43-!- Guest61070 [~cib@132.231.178.75] has quit [Ping timeout: 240 seconds] 20140626 12:58:09-!- sachith500|2 [~kvirc@112.135.43.26] has joined #wesnoth-dev 20140626 13:01:02-!- sachith500 [~kvirc@112.135.142.132] has quit [Ping timeout: 245 seconds] 20140626 13:25:49-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has joined #wesnoth-dev 20140626 13:56:37-!- sachith500|2 [~kvirc@112.135.43.26] has quit [Read error: Connection reset by peer] 20140626 14:08:30-!- irker845 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140626 14:08:30< irker845> wesnoth: Turuk wesnoth:master 4fbcb933729b / data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg: LoW S7: Dialogue change/Message Fix http://git.io/Z0t2xQ 20140626 14:10:05-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has joined #wesnoth-dev 20140626 14:17:08-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has quit [Ping timeout: 244 seconds] 20140626 14:57:30-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20140626 15:00:54-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140626 15:03:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140626 15:06:57-!- scimitar [~krishna@117.221.45.25] has joined #wesnoth-dev 20140626 15:26:32< irker845> wesnoth: Turuk wesnoth:master f24eed9efd44 / data/campaigns/Legend_of_Wesmere/scenarios/chapter3/09_Bounty_Hunters.cfg: LoW S9: Message on Dwarf Recruitment http://git.io/K4epcA 20140626 15:29:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140626 15:30:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140626 15:33:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20140626 15:38:10< AI0867> http://hastebin.com/afizilunon ← when I try to compile with forum_user_handler=True lacking the mysql headers 20140626 15:39:33-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving] 20140626 15:57:43-!- scimitar [~krishna@117.221.45.25] has quit [Ping timeout: 240 seconds] 20140626 16:01:21-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140626 16:09:02-!- cib_ [~cib@p5DC75223.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140626 16:10:02-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral] 20140626 16:11:23-!- scimitar [~krishna@117.200.99.12] has joined #wesnoth-dev 20140626 16:22:59-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has joined #wesnoth-dev 20140626 16:24:40-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev 20140626 16:29:24-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev 20140626 16:29:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140626 16:30:53-!- matthiaskrgr is now known as matthiaskrger 20140626 16:31:14-!- matthiaskrger is now known as matthiaskrgr 20140626 16:32:58-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev 20140626 16:35:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140626 16:38:03-!- _8680_ [~8680@2002:4404:712c:0:edbc:8798:3e76:7916] has quit [Ping timeout: 240 seconds] 20140626 16:38:51-!- _8680_ [~8680@2002:4404:712c:0:4540:be8d:d306:a0e4] has joined #wesnoth-dev 20140626 16:42:24-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev 20140626 16:59:17-!- scimitar [~krishna@117.200.99.12] has quit [Quit: Leaving] 20140626 17:04:18-!- travis-ci [~travis-ci@ec2-54-205-222-134.compute-1.amazonaws.com] has joined #wesnoth-dev 20140626 17:04:18< travis-ci> [travis-ci] AI0867/wesnoth#52 (wesnothd_memory_leak - fe52ab3 : Alexander van Gessel): The build passed. 20140626 17:04:18< travis-ci> [travis-ci] Build details : http://travis-ci.org/AI0867/wesnoth/builds/28515434 20140626 17:04:18-!- travis-ci [~travis-ci@ec2-54-205-222-134.compute-1.amazonaws.com] has left #wesnoth-dev [] 20140626 17:12:40< Soliton> seems fairly obvious but maybe you meant to ask loonycyborg to provide a better error message? 20140626 17:17:47-!- _8680_ [~8680@2002:4404:712c:0:4540:be8d:d306:a0e4] has quit [Ping timeout: 252 seconds] 20140626 17:26:48-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has quit [Ping timeout: 264 seconds] 20140626 17:27:36-!- _8680_ [~8680@2002:4404:712c:0:1190:cbe9:d786:da82] has joined #wesnoth-dev 20140626 17:28:19-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has joined #wesnoth-dev 20140626 17:33:17-!- _8680_ [~8680@2002:4404:712c:0:1190:cbe9:d786:da82] has quit [Ping timeout: 264 seconds] 20140626 17:34:05-!- _8680_ [~8680@2002:4404:712c:0:4492:beda:7231:d348] has joined #wesnoth-dev 20140626 17:34:52< AI0867> Soliton: pretty much, yes 20140626 17:45:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140626 18:13:51-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has left #wesnoth-dev [] 20140626 18:18:32-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has joined #wesnoth-dev 20140626 18:26:34-!- irker845 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20140626 18:28:17-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20140626 18:28:35< mordante> servus 20140626 18:30:33-!- travis-ci [~travis-ci@ec2-54-205-155-124.compute-1.amazonaws.com] has joined #wesnoth-dev 20140626 18:30:33< travis-ci> [travis-ci] AI0867/wesnoth#53 (wesnothd_memory_leak2 - 564c719 : Alexander van Gessel): The build has errored. 20140626 18:30:33< travis-ci> [travis-ci] Build details : http://travis-ci.org/AI0867/wesnoth/builds/28521431 20140626 18:30:33-!- travis-ci [~travis-ci@ec2-54-205-155-124.compute-1.amazonaws.com] has left #wesnoth-dev [] 20140626 18:31:08< mordante> hi lipkab 20140626 18:31:13-!- ancestral is now known as ancestral_lunch 20140626 18:32:41< lipkab> Hi mordante. 20140626 18:35:02-!- gfgtdf [~chatzilla@f054162133.adsl.alicedsl.de] has joined #wesnoth-dev 20140626 18:35:11< gfgtdf> thunderstruck: did you see my messae above ? 20140626 18:36:04< mordante> lipkab, how are things going? 20140626 18:39:51< lipkab> mordante: Pretty well, thank you. Congrats for Netherlands for proceeding to the hemidemisemifinals in Brazil! 20140626 18:40:21< lipkab> On a more related note, here are my findings about SDL2/OpenGL: 20140626 18:40:56< lipkab> - They are aware of the alpha bug, it will be fixed sooner or later. 20140626 18:42:07< mordante> lipkab, thanks, however I'm not really a fan of soccer, my score is zero games watched ;-) 20140626 18:42:13-!- gfgtdf [~chatzilla@f054162133.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds] 20140626 18:42:16-!- gfgtdf_ [~chatzilla@f054162133.adsl.alicedsl.de] has joined #wesnoth-dev 20140626 18:42:17-!- gfgtdf_ is now known as gfgtdf 20140626 18:42:26< lipkab> - They are discussing about blend modes, but probably they won't add anymore. 20140626 18:42:52-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140626 18:43:46< lipkab> - In general, SDL2 tries to be as basic as possible, even at the cost of uselessness. They probably wouldn't even accept patches if we tried to fix SDL2 ourselves. 20140626 18:44:07< lipkab> Long story short, SDL2 is a no-go in my opinion. 20140626 18:44:19< lipkab> Now, SDL_gpu. 20140626 18:44:44< lipkab> They don't have the alpha issue. 20140626 18:45:01< lipkab> They don't have the bad quality scale issue either. 20140626 18:46:02-!- Netsplit *.net <-> *.split quits: gfgtdf, Necrosporus, nurupo, prkc, mordante, Coffee_irc, Jetrel_, vultraz, EliDupree, RiftWalker, (+1 more, use /NETSPLIT to show all of them) 20140626 18:46:42-!- Netsplit over, joins: mordante, Haudegen, gfgtdf, Necrosporus, vultraz, RiftWalker, prkc, Jetrel_, nurupo, Coffee_irc (+1 more) 20140626 18:47:19< lipkab> I couldn't yet figure out if there is a combination of the various blending options that produces the results we want. However, if everything fails, they allow custom shaders. 20140626 18:47:30< mordante> lipkab, there was a netsplit the last sentence I got is » They don't have the bad quality scale issue either.« 20140626 18:47:48< lipkab> I didn't say anything in between. 20140626 18:47:59< mordante> ok, just wanted to make sure 20140626 18:48:16-!- Netsplit *.net <-> *.split quits: enchilado, wesbot, crimson_penguin 20140626 18:48:21-!- Netsplit *.net <-> *.split quits: janebot 20140626 18:48:27-!- Netsplit over, joins: janebot 20140626 18:48:33-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev 20140626 18:48:37-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev 20140626 18:48:37-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host] 20140626 18:48:37-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20140626 18:48:53< lipkab> There are two problems with SDL_gpu: 20140626 18:49:20< lipkab> 1) It's a one-man project, and if the developer is kidnapped by UFOs, there is trouble. 20140626 18:51:01< lipkab> 2) It's not widely used. There are no packages in the Debian (and thus Ubuntu), openSUSE or Fedora repos. 20140626 18:52:05< lipkab> From a technical viewpoint, SDL_gpu seems superior to plain OGL. 20140626 18:52:55< lipkab> They have nice prewritten functions/data types, but we can still use shaders if we happened to want to. 20140626 18:53:19< lipkab> But packaging might be problem. 20140626 18:53:39< lipkab> Ah, one more thing, SDL_gpu doesn't have a software renderer. 20140626 18:54:18< lipkab> IIRC OpenGL is guaranteed to have software fallback, is that right? 20140626 18:54:45-!- enchilado [~enchilado@130.102.72.196] has joined #wesnoth-dev 20140626 18:57:02-!- Netsplit *.net <-> *.split quits: Necrosporus, nurupo, vultraz, Haudegen 20140626 18:58:08< mordante> yeah I'm somewhat surprised how much seems to be missing in SDL2, still their reference list seems to include a lot of games 20140626 18:58:21< mordante> I wonder whether they just use an OpenGL backend 20140626 18:59:03< mordante> SDL_gpu seems rather new (at least the first public version isn't too old) 20140626 18:59:16< Ivanovic> lipkab: you can always rely on the system providing some software opengl 20140626 18:59:21< Ivanovic> which can be freaking slow though 20140626 18:59:31< Ivanovic> but there is e.g. swrast in mesa 20140626 18:59:53< mordante> it is MIT so we could include it in Wesnoth to avoid the packaging issue (not the best approach, but possible) 20140626 19:00:12< lipkab> Ivanovic: Thanks. 20140626 19:00:15< mordante> and indeed the bus factor is also a real issue 20140626 19:00:21-!- Netsplit over, joins: Haudegen 20140626 19:00:27< Ivanovic> IMO we can assume that any system used to play a game these days and does support 2d output and has a cpu fast enough for wesnoth is "good enough with opengl" 20140626 19:00:47< Ivanovic> that is: opengl or opengl es 20140626 19:01:11< lipkab> mordante: I thought about importing the source too. Their codebase isn't too big. 20140626 19:01:20< mordante> I also really like the fact it is SDL1.2 and SDL2.0 compatible 20140626 19:01:53< thunderstruck> gfgtdf: No, I haven't. 20140626 19:02:10< mordante> did you also look at plain OpenGL with SDL2? 20140626 19:02:27< gfgtdf> thunderstruck: 20140626 08:35:11< gfgtdf> thundersruck: do you think you can implement this TODO: https://github.com/wesnoth/wesnoth/blob/1.12/src/playcampaign.cpp#L631 before 1.12 ? 20140626 19:03:03< thunderstruck> gfgtdf: I completely forgot about it. 20140626 19:03:10< thunderstruck> gfgtdf: I'll try to work on it. 20140626 19:03:11< lipkab> mordante: Yes, but if we go that way I'll need some more time to prepare. 20140626 19:04:03< thunderstruck> gfgtdf: Do you have any use case for it by the way? 20140626 19:04:23< gfgtdf> thunderstruck: this seems to break random map generation in mp campaigns, accporng to forum this is a tegression from 1.10, i changed a lot in that code in 1.13 but i dont knwo about how it works on 1.12 to touch it 20140626 19:04:49< gfgtdf> thunderstruck: make a random mp campaign with random map generation in teh second scenario 20140626 19:05:07< thunderstruck> gfgtdf: I should be able to fix it, I think. 20140626 19:05:08< gfgtdf> thunderstruck: it shodul work in 1.13 currently , but it doesnt in 1.12 20140626 19:05:29< mordante> lipkab, what do you exactly mean with prepare? 20140626 19:06:15< thunderstruck> gfgtdf: In worst case, I could just uncomment that code and it should work. 20140626 19:06:30< gfgtdf> thunderstruck: no i think taht wont work 20140626 19:06:39< gfgtdf> thunderstruck: since taht code happens after teh data was sended 20140626 19:06:43< thunderstruck> gfgtdf: Ah, right. 20140626 19:06:54< lipkab> mordante: Learning some more OpenGL. 20140626 19:06:55< gfgtdf> thunderstruck: maby ejust move ~20 lines above 20140626 19:07:14< thunderstruck> gfgtdf: Well, I'll look into it this weekend. 20140626 19:07:22< gfgtdf> ok 20140626 19:07:31< mordante> lipkab, ok 20140626 19:07:47-!- Haudegen [~quassel@80-110-40-98.static.surfer.at] has quit [Remote host closed the connection] 20140626 19:07:49< mordante> lipkab, did you write some testcode using SDL_gpu? 20140626 19:09:37< lipkab> mordante: I didn't write my own code, I tested it by modifying the example programs in their source tree. 20140626 19:10:12< lipkab> The API is fairly similar to SDL2's. 20140626 19:13:32< mordante> would it be possible to convert the current loadscreen to use SDL_gpu in a separate branch 20140626 19:13:47< mordante> then also include the SDL_gpu source code 20140626 19:13:52< mordante> so we can test 20140626 19:14:29< lipkab> Sure. 20140626 19:14:32< mordante> before we consider mailing the dev-ml I'd like to see it in action in our code 20140626 19:14:54< mordante> how long do you expect it will take you to write that code? 20140626 19:15:00< lipkab> Okay, I'll try to get that done ASAP. 20140626 19:15:43< mordante> could we meet again Saturday afternoon around 14:00? 20140626 19:16:18< lipkab> Yes. 20140626 19:16:37< mordante> ok 20140626 19:16:42< lipkab> I think I'll be ready with the test code by then. 20140626 19:16:56< mordante> that would be great 20140626 19:17:07< mordante> any more questions at the moment? 20140626 19:17:13< lipkab> Nothing. 20140626 19:17:49< mordante> ok 20140626 19:18:10< mordante> then I'd like to postpone the meeting until Saturday 20140626 19:18:36-!- irker953 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140626 19:18:36< irker953> wesnoth: gfgtdf wesnoth:1.12 d69a224269a7 / src/actions/undo.cpp: fix an invalid error message http://git.io/blaB1w 20140626 19:18:41< lipkab> Alright. 20140626 19:19:01< mordante> good luck with the SDL_gpu 20140626 19:19:09-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20140626 19:19:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20140626 19:19:09-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20140626 19:19:31< lipkab> Thanks :) 20140626 19:20:18-!- OnkV [~quassel@80-110-40-98.static.surfer.at] has joined #wesnoth-dev 20140626 19:21:22-!- OnkV is now known as haudegen 20140626 19:21:32-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev 20140626 19:26:50< mordante> I'm off bye 20140626 19:28:02-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20140626 19:28:12-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 255 seconds] 20140626 19:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 239 bugs, 345 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140626 19:29:57-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev 20140626 19:31:48-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140626 19:37:52-!- ancestral_lunch is now known as ancestral 20140626 19:42:45-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20140626 19:51:49-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20140626 20:18:00-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20140626 20:20:03-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds] 20140626 20:20:56-!- matthiaskrgr is now known as matthiaskrgr_ 20140626 20:21:09-!- matthiaskrgr_ is now known as matthiaskrgr 20140626 20:21:10-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20140626 20:33:07-!- Gallaecio [~quassel@84.120.115.132.dyn.user.ono.com] has quit [Remote host closed the connection] 20140626 20:36:20-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 260 seconds] 20140626 20:37:09-!- shadowm_desktop [ignacio@186.10.25.183] has joined #wesnoth-dev 20140626 20:37:10-!- shadowm_desktop [ignacio@186.10.25.183] has quit [Changing host] 20140626 20:37:10-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20140626 20:38:08< irker953> wesnoth: Turuk wesnoth:master d8514c32752b / data/campaigns/Legend_of_Wesmere/scenarios/chapter3/10_Cliffs_of_Thoria.cfg: LoW S10: Added "or" to objectives http://git.io/UWVV4g 20140626 20:38:35< gfgtdf> when i say if(cfg["a"] = "b") what happens then ? I see no operator ==(attribute_value, const char*) 20140626 20:39:01-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140626 20:39:41< shadowm> You mean if(cfg["a"] == "b") ? 20140626 20:40:06< gfgtdf> shadowm: yes 20140626 20:40:44< shadowm> Won't that invoke the config::attribute_value type's const char* cast operator? 20140626 20:41:23< gfgtdf> shadowm: we sont have a to char* operator i think 20140626 20:41:26< shadowm> Which turns out doesn't exist. 20140626 20:41:33< gfgtdf> shadowm: onyl to std::string and t_string 20140626 20:41:36< gfgtdf> only* 20140626 20:41:50< shadowm> Have you tried giving that code to a compiler? 20140626 20:42:57< shadowm> Implicit casts are one of those aspects of C++ that I'll never get, but surely the compiler isn't supposed to check whether t_string or std::string can be instantiated from a const char*? If it did that it'd result in an ambiguous situation since both can. 20140626 20:43:49< gfgtdf> shadowm: hm no but a similar problem in this line: https://github.com/wesnoth/wesnoth/blob/master/src/unit.cpp#L1948 it seems liek somehow ia t_strign si involved to my debugger and i dotn knwo why 20140626 20:44:03-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 20140626 20:44:16< shadowm> Well, a "t_strign" (t_string) can be instantiated from a const char* as I said. 20140626 20:44:29< gfgtdf> in that case id is a std::string 20140626 20:45:07< shadowm> Your hypothetical example above involved a const char*, not a std::string. 20140626 20:45:41< irker953> wesnoth: Andrius Silinskas wesnoth:1.12 a35e8a6093dd / / (5 files in 2 dirs): Added 'faction_lock' and 'leader_lock' for MultiplayerWML. http://git.io/qkqwkQ 20140626 20:46:03< shadowm> As for the real example, t_string has a std::string constructor. 20140626 20:46:19< gfgtdf> shadowm: yes im sorry my hyprocretical example was not actualy what i wantede 20140626 20:46:40< shadowm> I don't really know in what order compilers are supposed to try to resolve implicit conversions, unfortunately. I'm not a C++ lawyer. :/ 20140626 20:47:12< shadowm> Sounds pretty evil, anyway, since t_string appears to have slightly more initialization overhead than a std::string. 20140626 20:56:02-!- cib_ [~cib@p5DC75223.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds] 20140626 20:59:19-!- cib_ [~cib@p5DC75223.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140626 20:59:33-!- ancestral [~ancestral@17.114.45.98] has quit [Ping timeout: 255 seconds] 20140626 21:04:03-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 255 seconds] 20140626 21:05:17< gfgtdf> shadowm: it seems liek also this line https://github.com/wesnoth/wesnoth/blob/master/src/unit.cpp#L1780 implis strign construction 20140626 21:05:22< gfgtdf> t_string* 20140626 21:05:38< gfgtdf> from const char* 20140626 21:06:14-!- haudegen [~quassel@80-110-40-98.static.surfer.at] has quit [Ping timeout: 240 seconds] 20140626 21:06:38-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev 20140626 21:07:00< thunderstruck> Does anyone else get a segfault when trying to access multiplayer on master? 20140626 21:10:40< gfgtdf> lan server, networked server local or all of them ? 20140626 21:11:01< gfgtdf> thunderstruck: the segfaults appears on the server or on the clinet? 20140626 21:11:15< thunderstruck> Client. Just choose "Multiplayer" from main menu. 20140626 21:11:58-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has joined #wesnoth-dev 20140626 21:12:04< gfgtdf> clicking "multiplayer" on the main menu doesnt give me any problems 20140626 21:12:37< thunderstruck> Hmmm.. I already tried removing my add-ons. 20140626 21:13:23< gfgtdf> thunderstruck: ok after i clicken on "local game" i got a sefault too 20140626 21:15:15-!- ancestral [~ancestral@17.114.45.98] has joined #wesnoth-dev 20140626 21:15:36< thunderstruck> gfgtdf: That's interesting. 20140626 21:16:30< gfgtdf> thunderstruck: my szacktrace: http://pastebin.com/U2t7ix6r 20140626 21:16:37< gfgtdf> stacktrace* 20140626 21:17:09-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has quit [Quit: Laundry] 20140626 21:18:05< thunderstruck> gfgtdf: It might be related to RiftWalker's work. His PR was recently merged in. 20140626 21:18:39< thunderstruck> gfgtdf: But I'm not sure why I'm getting a segfault at a different place. 20140626 21:18:39< RiftWalker> I'm building master now. 20140626 21:18:45< gfgtdf> thunderstruck: do me this looks more like iceiceice s work since it seems to be casued by diaply_contet beeing null 20140626 21:19:54< gfgtdf> thunderstruck: https://github.com/wesnoth/wesnoth/commit/f5a9de40d55d31569df2bf4666ce64a1a562dbce 20140626 21:20:31< thunderstruck> gfgtdf: Is someone of it MP related? 20140626 21:20:32< gfgtdf> iceiceice: resources::game_board beeign null in https://github.com/wesnoth/wesnoth/blob/f5a9de40d55d31569df2bf4666ce64a1a562dbce/src/minimap.cpp#L237 20140626 21:20:36< thunderstruck> SP works fine for me. 20140626 21:20:51< thunderstruck> s/someone/some 20140626 21:20:54< gfgtdf> no it seem to be related to "drawing minimap wiout active game" 20140626 21:21:16-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 252 seconds] 20140626 21:21:22< gfgtdf> mp create previerw maps 20140626 21:22:21< thunderstruck> gfgtdf: Ok. It all makes sense now. 20140626 21:22:43< thunderstruck> I was not following recent changes closely :) 20140626 21:23:32< thunderstruck> I'll port http://git.io/qkqwkQ to master once this is fixed then. 20140626 21:23:41-!- gfgtdf_ [~chatzilla@e177151198.adsl.alicedsl.de] has joined #wesnoth-dev 20140626 21:24:00< thunderstruck> Although, it should be safe to just push what I got, I think. 20140626 21:25:12< gfgtdf_> what is it tat you got ? 20140626 21:25:15< gfgtdf_> that* 20140626 21:25:55< gfgtdf_> s/tat/that 20140626 21:26:05-!- gfgtdf [~chatzilla@f054162133.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds] 20140626 21:26:06-!- gfgtdf_ is now known as gfgtdf 20140626 21:26:25< thunderstruck> I have a http://git.io/qkqwkQ for master. 20140626 21:26:45< thunderstruck> There was a merge conflict in multiplayer_wait.cpp which I fixed and code now compiles. 20140626 21:26:58< thunderstruck> But I tested my commit only on 1.12 so far. 20140626 21:34:30< gfgtdf> shadowm: "mod_mp" as the translatable type for mp modification in the add ons dialogs is how its gonna be in 1.12 ? 20140626 21:34:50< gfgtdf> shadowm: n i mena tn teh webpage 20140626 21:34:53< gfgtdf> the webpage 20140626 21:35:10< irker953> wesnoth: Andrius Silinskas wesnoth:master cef9f784680e / / (5 files in 2 dirs): Added 'faction_lock' and 'leader_lock' for MultiplayerWML. http://git.io/30gobQ 20140626 21:35:41< gfgtdf> shadowm: http://add-ons.wesnoth.org/1.12/ shows them as mod_mp 20140626 21:36:01< thunderstruck> gfgtdf: I decided to push it. 20140626 21:36:44< thunderstruck> RiftWalker: In case you didn't notice it, gfgtdf pointed out that segfault(s) were likely introduced by another commit, so you don't need to worry. 20140626 21:36:45< gfgtdf> thunderstruck: ok 20140626 21:37:31< thunderstruck> I'm going now. 20140626 21:37:32< thunderstruck> Bye. 20140626 21:37:35< RiftWalker> thunderstruck: I saw. Later 20140626 21:37:43-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has quit [Quit: leaving] 20140626 21:48:24-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev 20140626 22:02:19-!- cib_ [~cib@p5DC75223.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds] 20140626 22:05:19< Soliton> gfgtdf: how does https://github.com/wesnoth/wesnoth/blob/master/src/unit.cpp#L1780 imply t_string construction? 20140626 22:07:03< gfgtdf> Soliton: from teh output assempy code it seems to result in t_string("full") == std::string(cfg_["upkeep"]) 20140626 22:07:15< gfgtdf> bu i dotn know why 20140626 22:08:05-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140626 22:09:38< Soliton> that makes no sense to me. can you show that assembly? 20140626 22:11:52< gfgtdf> Soliton: http://pastebin.com/drudETyT 20140626 22:14:53-!- ancestral [~ancestral@17.114.45.98] has quit [Quit: ancestral] 20140626 22:17:32-!- lipkabb [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev 20140626 22:18:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds] 20140626 22:21:17-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 264 seconds] 20140626 22:36:50-!- lipkabb [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: .] 20140626 22:37:58< shadowm> gfgtdf: That's an issue with wesnoth_addon_manager, which doesn't know of any such thing as translatability. 20140626 22:38:21< gfgtdf> shadowm: hm ok 20140626 22:38:25< shadowm> Whoever added the new add-on type simply didn't realize wam needed to be updated too. 20140626 22:41:29-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20140626 22:41:43< Soliton> gfgtdf: what's 0BCE890h? 20140626 22:42:25< gfgtdf> Soliton: the adress of t_string_base::operator== i think 20140626 22:42:52< Soliton> yes... which one? 20140626 22:43:21< gfgtdf> bool t_string_base::operator==(const std::string &that) const 20140626 22:46:50< Soliton> and 0BCEBC0h is really "full", yes? 20140626 22:48:19< gfgtdf> Soliton: no tahthe adress of t_string::t_string(const char *o) : super(base(o)) 20140626 22:49:43< Soliton> ah, of course. but "full" is in the following assembly somewhere? 20140626 22:50:22< gfgtdf> Soliton: 00F5F42C 68 98 3F 29 01 push 1293F98h 20140626 22:50:32< gfgtdf> 1293F98h is "full" 20140626 22:51:03< Soliton> right, ok. 20140626 22:52:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20140626 22:53:11< gfgtdf> iceiceice: did you see converation with thunderstruck above ? 20140626 22:53:20< iceiceice> i saw some stuff abou ta segfault 20140626 22:53:26< gfgtdf> yes 20140626 22:53:34< iceiceice> i realized that i caused a segfault yesterday 20140626 22:53:34< iceiceice> but its not realted to tstring 20140626 22:53:36< iceiceice> i havent read the whole log yet 20140626 22:53:41< iceiceice> i have a patch though, 20140626 22:53:45< gfgtdf> no tstrign it a differnet thing 20140626 22:53:47< iceiceice> i moved one of those "orphan" functions 20140626 22:53:50< iceiceice> village_owner 20140626 22:53:53< iceiceice> to game_board 20140626 22:53:55< gfgtdf> https://github.com/wesnoth/wesnoth/commit/f5a9de40d55d31569df2bf4666ce64a1a562dbce 20140626 22:54:00< iceiceice> but it had asecret resources arugment 20140626 22:54:09< iceiceice> and was being used by the minimap 20140626 22:54:10< iceiceice> so it caused segfault int he mp lobby 20140626 22:54:14< gfgtdf> minimap is also calculated for mp create previev image whe there is no game board 20140626 22:54:28< iceiceice> y 20140626 22:54:31< iceiceice> ok i have a patch but did you patch already? 20140626 22:54:34< iceiceice> my wifi sucks today... 20140626 22:54:47< iceiceice> my usual cafe was completely packed b/c of usa vs germany world cup game 20140626 22:55:45< irker953> wesnoth: Chris Beck wesnoth:master dc9585af62d6 / src/minimap.cpp: fixup minimap in case teams is null http://git.io/x9rPMw 20140626 22:55:47< irker953> wesnoth: Chris Beck wesnoth:master 82c6b98907d9 / src/ (15 files in 2 dirs): halo uses handle-body instead of static singleton idiom http://git.io/9fK9IA 20140626 22:55:49< irker953> wesnoth: Chris Beck wesnoth:master 673c44512fc9 / / (8 files in 4 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/U3aXJg 20140626 22:58:56< iceiceice> gfgtdf: ^ i think that fixes the minimap thing, but i still have to read log 20140626 22:59:21< gfgtdf> iceiceice: ye it looks good 20140626 23:01:26< iceiceice> thunderstruck: ^ sorry about the breakage 20140626 23:01:33< iceiceice> let me know if it is'nt fixed for you 20140626 23:01:48< gfgtdf> Soliton: when c["a"] is a t_string value whose translated form is "uuu", and s is "uuu" as a std::string. should a["a"] == s then be true or not ? 20140626 23:02:58< Soliton> good question. the code suggests it can never be equal. 20140626 23:03:37< Soliton> it certainly is never a good idea to do such a comparison. 20140626 23:04:11< iceiceice> what is the point of the t_string class? 20140626 23:04:22< gfgtdf> to be translatable 20140626 23:04:25< iceiceice> it always seemed a bit odd to me, it doesn't manage actual translation? 20140626 23:05:05< gfgtdf> hm i thought it did 20140626 23:05:18< iceiceice> oh i guess it does nm 20140626 23:06:37< Soliton> some surprising conversion there anyway. and worrying that t_string is involved. we've had trouble before with unexpected conversions to t_string. 20140626 23:06:53< Soliton> i thought we've thus removed them but that's clearly not the case. 20140626 23:08:55< Soliton> i think it'd help to define attribute_value::operator==() for const char* to get the expected behaviour in that upkeep case. 20140626 23:10:51< gfgtdf> you want to make == operator in attribute_value for std::string and t_strign then too ? 20140626 23:11:23< Soliton> would probably make sense. 20140626 23:11:34-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wyruzsaeupmrptwo] has quit [Ping timeout: 240 seconds] 20140626 23:11:49< Soliton> alternatively... i wonder how much breaks if we remove t_string_base::operator==(const std::string&) 20140626 23:12:10< Soliton> and what happens to that comparison then. 20140626 23:15:06< gfgtdf> Soliton: i think in the case c["a"] = "b", operator ==(std::string,std::string) would be be used then. 20140626 23:15:41< Soliton> i'd call that an improvement. 20140626 23:16:22< Soliton> seems like that would require two conversions though which does not seem to be allowed. 20140626 23:17:04< Soliton> (attribute_value -> std::string and const char* -> std::string) 20140626 23:17:51< gfgtdf> but doesnt teh current sulution also do (attribute_value -> std::string, const char* -> s_str) ? 20140626 23:18:27-!- Kexoth [~kex@212.92.210.53] has quit [Remote host closed the connection] 20140626 23:18:36< irker953> wesnoth: Ignacio R. Morelle wesnoth:master 991b68a1285d / data/tools/addon_manager/html.py: wam/html: Add add-on type labels for campaign_sp_mp and mod_mp http://git.io/DFBHGw 20140626 23:18:39< irker953> wesnoth: Ignacio R. Morelle wesnoth:1.12 40c549735ff5 / data/tools/addon_manager/html.py: wam/html: Add add-on type labels for campaign_sp_mp and mod_mp http://git.io/DQRnNA 20140626 23:19:18< Soliton> well, i'm no expert on implicit conversions though and ideally one would not need to be to understand that code. 20140626 23:19:35< gfgtdf> ye 20140626 23:19:49< Soliton> so IMO most important is to remove some of the implicit conversions. 20140626 23:20:34< Soliton> because if attribute_value and t_string are involved which have a ton of converion constructors and operators it's really confusing. 20140626 23:27:58-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has quit [Remote host closed the connection] 20140626 23:28:34< Soliton> kind of scary how even our fundamental classes that are used everywhere have pretty much zero documentation. 20140626 23:29:41-!- travis-ci [~travis-ci@ec2-54-82-196-147.compute-1.amazonaws.com] has joined #wesnoth-dev 20140626 23:29:41< travis-ci> [travis-ci] wesnoth/wesnoth#3454 (master - 673c445 : Chris Beck): The build was broken. 20140626 23:29:41< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/28547171 20140626 23:29:41-!- travis-ci [~travis-ci@ec2-54-82-196-147.compute-1.amazonaws.com] has left #wesnoth-dev [] 20140626 23:29:47-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wspxvoklddmzayzy] has joined #wesnoth-dev 20140626 23:32:14< iceiceice> Soliton, gfgtdf: maybe it would be a good idea to use static_assert or smth similar to try to check that some of these conversions are happening as desired? 20140626 23:32:14< iceiceice> in the test_config unit test? 20140626 23:33:01< gfgtdf> i dotn kwo how static assert works but unit testing for those things woul be nice i think 20140626 23:33:16< gfgtdf> i also think we shoudl have less implicit conversions 20140626 23:35:28< iceiceice> this is weird, i wonder what is segfaulting... 20140626 23:38:52< Soliton> iceiceice: in case they are really desired at all, yeah, definitely. 20140626 23:42:23< iceiceice> hmm 20140626 23:42:54< irker953> wesnoth: Ignacio R. Morelle wesnoth:1.10 fe385140d63c / src/server/ (server.cpp server.hpp): wesnothd: Only reset the commands FIFO stream when reloading if needed http://git.io/Wb5xcw 20140626 23:42:58< irker953> wesnoth: Ignacio R. Morelle wesnoth:1.8 dd0cb684e3d0 / src/server/ (server.cpp server.hpp): wesnothd: Only reset the commands FIFO stream when reloading if needed http://git.io/DX7VpQ 20140626 23:43:01< irker953> wesnoth: Ignacio R. Morelle wesnoth:1.12 74dbef4771eb / src/server/ (server.cpp server.hpp): wesnothd: Only reset the commands FIFO stream when reloading if needed http://git.io/M6wLTA 20140626 23:43:36-!- mjs-de [~mjs-de@f048181013.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds] 20140626 23:45:25< irker953> wesnoth: Ignacio R. Morelle wesnoth:master 050aab785c07 / utils/mp-server/new_release: Revert "new_release: Workaround race condition in wesnothd SIGHUP handler" http://git.io/TtZKcQ 20140626 23:45:56< gfgtdf> Soliton: so your plan is to remove atribute_value -> std::/t_ string implicit conversions? 20140626 23:47:53< Soliton> gfgtdf: attribute_value conversions are fine, i think. the t_string ones i worry about. 20140626 23:50:23< Soliton> for example t_string_base(const char* string), is that needed? can it at least be made explicit? 20140626 23:51:13< Soliton> s/t_string_base/t_string/ 20140626 23:53:18< Soliton> gfgtdf: i wouldn't count on me actually getting to investigate that so feel free to do it instead. :-P 20140626 23:53:42< Soliton> now i plan to finally go to bed... 20140626 23:53:56 * Soliton tips hat 20140626 23:55:14< shadowm> std::string foo { return time_t(0); } 20140626 23:55:34< shadowm> I have to wonder what the author's intent really was. 20140626 23:55:51-!- mjs-de [~mjs-de@f048230022.adsl.alicedsl.de] has joined #wesnoth-dev 20140626 23:58:15-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wspxvoklddmzayzy] has quit [Changing host] 20140626 23:58:15-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20140626 23:58:15-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host] 20140626 23:58:15-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wspxvoklddmzayzy] has joined #wesnoth-dev --- Log closed Fri Jun 27 00:00:57 2014