--- Log opened Wed Jul 02 00:00:08 2014
20140702 00:04:52-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140702 00:05:22-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140702 00:15:20-!- prkc [~prkc@4E5CCA17.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20140702 00:15:22-!- ancestral [~ancestral@17.114.45.173] has quit [Quit: ancestral]
20140702 00:15:37-!- ancestral [~ancestral@17.114.45.173] has joined #wesnoth-dev
20140702 00:23:27-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20140702 00:33:47-!- gfgtdf [~chatzilla@d177154.adsl.hansenet.de] has joined #wesnoth-dev
20140702 00:39:04-!- Gambit is now known as Gambutt
20140702 00:39:14-!- Gambutt is now known as Gambit
20140702 00:52:33-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 272 seconds]
20140702 00:54:08-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has quit [Ping timeout: 260 seconds]
20140702 00:54:52-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140702 00:56:19-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has joined #wesnoth-dev
20140702 01:00:14-!- ancestral [~ancestral@17.114.45.173] has quit [Quit: ancestral]
20140702 01:03:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 252 seconds]
20140702 01:09:11-!- sachith500 [~kvirc@112.134.114.124] has joined #wesnoth-dev
20140702 01:12:56-!- gfgtdf [~chatzilla@d177154.adsl.hansenet.de] has quit [Ping timeout: 252 seconds]
20140702 01:14:09-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140702 01:24:13-!- _8680_ [~8680@2002:4404:712c:0:e8e9:b011:a2f1:ed47] has quit [Ping timeout: 252 seconds]
20140702 01:25:14-!- _8680_ [~8680@2002:4404:712c:0:7df3:23cd:dd9e:11cb] has joined #wesnoth-dev
20140702 01:28:33-!- sachith500 [~kvirc@112.134.114.124] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140702 01:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 233 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140702 01:31:36-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140702 01:35:08-!- happygrue [~Wintermut@wesnoth/developer/wintermute] has quit [Ping timeout: 240 seconds]
20140702 02:00:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140702 02:12:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140702 02:20:57-!- gfgtdf [~chatzilla@d177154.adsl.hansenet.de] has joined #wesnoth-dev
20140702 02:22:01< iceiceice_> gfgtdf: i have a question,
20140702 02:22:14< iceiceice_> do you know why we the client-side :ping command doesn't do anything?
20140702 02:22:57< iceiceice_> i somewhat regard that as a bug i think, it is documented in the command help but I was not able to find any version of wesnoth in which it works
20140702 02:23:43< gfgtdf> 	iceiceice_: hm i didnt know that it doesntdo anything
20140702 02:24:28< gfgtdf> iceiceice_: why do you think it does nothign ?
20140702 02:24:35< iceiceice_> there is osme comment in server/server.cpp, "ignore client-side pings for now"
20140702 02:24:43< iceiceice_> it just drops the message it seems
20140702 02:24:48< iceiceice_> i think its been that way since 2009
20140702 02:26:52< gfgtdf> iceiceice_: what i ping supposed to do ?
20140702 02:27:01< iceiceice_> https://github.com/wesnoth/wesnoth/blob/master/src/server/server.cpp#L937
20140702 02:27:05< gfgtdf> iceiceice_: the wiki does way anything about http://wiki.wesnoth.org/CommandMode
20140702 02:27:08< iceiceice_> gfgtdf: i dont really know
20140702 02:27:21< iceiceice_> the only docs i can see are in like ":help" in the game
20140702 02:28:33< iceiceice_> as for what it "should" do, idk i would think it would do something like chat the last ping time to the server,
20140702 02:28:47< iceiceice_> or maybe allow you to ping another player in the game so you can check for a disconnect
20140702 02:28:55< iceiceice_> but idk what was the old behavior
20140702 02:38:22< gfgtdf> iceiceice_: from looking teh the menu_handler code it seems liek the pig commands does teh same as teh normal 'send alive' pings
20140702 02:39:08< iceiceice_> where are the normal 'sent alive' pings?
20140702 02:42:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 244 seconds]
20140702 02:43:45< gfgtdf> iceiceice_: :O idk why i thought that it seems like just teh server sends autoamticly pings.
20140702 02:44:22< iceiceice_> y i mean its a bit weird, it looks like there is a handler for pings in network.cpp
20140702 02:44:34< iceiceice_> right, it does this: 
20140702 02:44:34< gfgtdf> iceiceice_: ye
20140702 02:44:35< iceiceice_> const time_t& now = time(NULL);
20140702 02:44:35< iceiceice_> 		if (cfg.has_attribute("ping")) {
20140702 02:44:35< iceiceice_> 			LOG_NW << "Lag: " << (now - lexical_cast<time_t>(cfg["ping"])) << "\n";
20140702 02:44:35< iceiceice_> 			last_ping = now;
20140702 02:44:42< iceiceice_> but that actualyl doesnt make sense i think
20140702 02:44:52< iceiceice_> its taking time(NULL) on local,
20140702 02:45:00< iceiceice_> and subtract from it, time(NULL) from server?
20140702 02:45:04< iceiceice_> unless i dont get it
20140702 02:46:13< gfgtdf> yes but that only for teh debug message
20140702 02:46:34< iceiceice_> yea thats true
20140702 02:46:52-!- Ivanovic_ [~ivanovic@frnk-5f7514b7.pool.mediaWays.net] has joined #wesnoth-dev
20140702 02:48:09< gfgtdf> i think if we use 'ping' for send alive packages from the server we shouldnt give it a different meaning when sending from the client (as a network package i mean)
20140702 02:48:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 248 seconds]
20140702 02:48:25< iceiceice_> yeah i agree
20140702 02:48:46-!- Ivanovic_ is now known as Ivanovic
20140702 02:50:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140702 02:51:33< iceiceice_> does the server expect a response to the send alive messages?
20140702 02:52:16< iceiceice_> or does the "send_raw_data" fcn do some kind of internal checkup
20140702 02:54:12< gfgtdf> i dont think so bu idk
20140702 02:55:33< iceiceice_> hmm
20140702 02:56:02< iceiceice_> i think maybe i will make the server respond to :ping by pinging everyone in the game, similar to the send alive check
20140702 02:57:01< shadowm> I'd ask Soliton what he thinks first.
20140702 02:58:06< iceiceice_> Soliton: ^
20140702 03:19:51< gfgtdf> iceiceice_: do you think its somehow possible to automaticly add the last commit id in :version ?
20140702 03:21:14< iceiceice_> i think it actually is ther?
20140702 03:21:19< iceiceice_> i just tried it on master
20140702 03:21:42< gfgtdf> on master i just see 1.13.0-dev
20140702 03:21:44< gfgtdf> iceiceice_: ^
20140702 03:23:55< shadowm> It works if Wesnoth was built with scons or cmake.
20140702 03:24:07< gfgtdf> shadowm: how does it wokr on scons/Cmake ?
20140702 03:24:54< shadowm> The reason is simply that those two are scripted to run utils/autorevision and populate src/revision.h with the results, and IIRC pass a preprocessor symbol definition to the compiler to enable using revision.h.
20140702 03:25:06< shadowm> I believe this is only relevant for the game_config.cpp translation unit.
20140702 03:27:35< gfgtdf> shadowm: ok ty
20140702 03:27:45-!- gfgtdf [~chatzilla@d177154.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140702 03:29:43-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140702 03:37:28-!- _8680_ [~8680@2002:4404:712c:0:7df3:23cd:dd9e:11cb] has quit [Ping timeout: 260 seconds]
20140702 03:38:04-!- _8680_ [~8680@2002:4404:712c:0:6932:e1aa:3a5c:4be8] has joined #wesnoth-dev
20140702 03:42:27-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140702 03:49:56-!- {V} [~V@72-69-ftth.on.nl] has quit [Ping timeout: 240 seconds]
20140702 03:50:48-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140702 03:55:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 244 seconds]
20140702 03:56:08-!- vultraz_ [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140702 03:56:50-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20140702 03:56:54-!- vultraz_ is now known as vultraz
20140702 04:02:05-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20140702 04:10:45-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140702 04:21:02-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 252 seconds]
20140702 04:22:41-!- {V} [~V@72-69-ftth.on.nl] has quit [Read error: Connection reset by peer]
20140702 04:23:25-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140702 04:44:41-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds]
20140702 04:48:06-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140702 04:55:55-!- Aishiko_laptop [~unknown@2606:a000:bcc1:2b00:226:5eff:fe65:125c] has quit [Ping timeout: 240 seconds]
20140702 05:00:29-!- Aishiko_laptop [~unknown@2606:a000:bcc1:2b00:226:5eff:fe65:125c] has joined #wesnoth-dev
20140702 05:24:22-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Quit: Ex-Chat]
20140702 05:31:11-!- cib [~cib@p5DD236B4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140702 05:31:35-!- cib is now known as Guest812
20140702 05:31:47-!- Guest95867 [~cib@p5DD236B4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140702 05:32:03-!- Guest95867 [~cib@p5DD236B4.dip0.t-ipconnect.de] has quit [Client Quit]
20140702 05:32:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140702 06:05:07-!- Aishiko_laptop [~unknown@2606:a000:bcc1:2b00:226:5eff:fe65:125c] has quit [Ping timeout: 240 seconds]
20140702 06:05:25-!- ancestral [~ancestral@12.23.74.29] has quit [Ping timeout: 272 seconds]
20140702 06:06:47-!- Aishiko_laptop [~unknown@2606:a000:bcc1:2b00:226:5eff:fe65:125c] has joined #wesnoth-dev
20140702 06:17:31-!- Aishiko_laptop [~unknown@2606:a000:bcc1:2b00:226:5eff:fe65:125c] has quit [Ping timeout: 240 seconds]
20140702 06:18:49-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140702 06:21:09-!- Guest812 is now known as cib1
20140702 06:28:25-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20140702 06:34:25-!- cib1 [~cib@p5DD236B4.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds]
20140702 06:58:42-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140702 07:03:54-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has quit [Ping timeout: 255 seconds]
20140702 07:14:12-!- ancestral [~ancestral@12.23.74.29] has quit [Remote host closed the connection]
20140702 07:14:28-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140702 07:22:31-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140702 07:22:42-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20140702 07:22:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140702 07:23:59-!- cib [~cib@132.231.178.208] has joined #wesnoth-dev
20140702 07:24:22-!- cib is now known as Guest6702
20140702 07:29:28-!- leyyin [~leyyin@unaffiliated/leyyin] has joined #wesnoth-dev
20140702 07:29:36< ancestral> Anyone use xdelta here?
20140702 07:33:33-!- _8680_ [~8680@2002:4404:712c:0:6932:e1aa:3a5c:4be8] has quit [Ping timeout: 240 seconds]
20140702 07:37:10-!- _8680_ [~8680@2002:4404:712c:0:ddf2:aa22:241d:301b] has joined #wesnoth-dev
20140702 07:42:15-!- _8680_ [~8680@2002:4404:712c:0:ddf2:aa22:241d:301b] has quit [Ping timeout: 252 seconds]
20140702 07:43:13-!- _8680_ [~8680@2002:4404:712c:0:3480:22b9:dc77:693] has joined #wesnoth-dev
20140702 07:45:36-!- Ivanovic [~ivanovic@frnk-5f7514b7.pool.mediaWays.net] has quit [Changing host]
20140702 07:45:36-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140702 07:48:51-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140702 08:00:22-!- Guest6702 [~cib@132.231.178.208] has quit [Ping timeout: 264 seconds]
20140702 08:02:46-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Ping timeout: 264 seconds]
20140702 08:11:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140702 08:11:22-!- mjs-de [~mjs-de@f049173055.adsl.alicedsl.de] has joined #wesnoth-dev
20140702 08:15:00-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 255 seconds]
20140702 08:21:17-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20140702 08:48:54-!- Rh0nda is now known as Rhonda
20140702 08:48:58-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Changing host]
20140702 08:48:58-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20140702 09:27:59-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140702 09:28:53-!- kex [~kex@212.92.210.53] has joined #wesnoth-dev
20140702 09:32:46-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140702 09:39:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140702 09:42:22-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 264 seconds]
20140702 09:59:44-!- cib [~cib@132.231.178.92] has joined #wesnoth-dev
20140702 10:00:03-!- cib is now known as Guest89100
20140702 10:02:20-!- prkc [~prkc@4E5CCA17.dsl.pool.telekom.hu] has joined #wesnoth-dev
20140702 10:07:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140702 10:19:04-!- Guest89100 [~cib@132.231.178.92] has quit [Ping timeout: 240 seconds]
20140702 10:19:44-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
20140702 10:21:12-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140702 10:58:48-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has joined #wesnoth-dev
20140702 12:13:37-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Quit: Ex-Chat]
20140702 12:59:01-!- Alkenrinnstet [~Alkenrinn@202.166.68.240] has joined #wesnoth-dev
20140702 13:52:49-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140702 13:54:41-!- sachith500 [~kvirc@112.134.118.154] has joined #wesnoth-dev
20140702 14:10:03-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140702 14:13:07-!- sachith500 [~kvirc@112.134.118.154] has quit [Read error: Connection reset by peer]
20140702 14:13:39-!- sachith500 [~kvirc@112.134.118.154] has joined #wesnoth-dev
20140702 14:20:08-!- prkc [~prkc@4E5CCA17.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20140702 14:34:45-!- cib_ [~cib@p5DC755D3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140702 14:40:35< AI0867> mordante: mainly the design. It's a preference setting for something that should ideally be autodetected (how much room there is on the screen for the right-click menu), and you may know how easy/difficult that would be to do.
20140702 14:46:52-!- sachith500 [~kvirc@112.134.118.154] has quit [Read error: Connection reset by peer]
20140702 14:47:10-!- sachith500 [~kvirc@112.134.118.154] has joined #wesnoth-dev
20140702 14:51:38-!- irker615 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140702 14:51:38< irker615> wesnoth: Paweł Jackowski wesnoth:1.12 61681c853087 / po/wesnoth-dw/pl.po: Dead Water Polish translation update http://git.io/wfcKiw
20140702 14:51:38< irker615> wesnoth: Paweł Jackowski wesnoth:1.12 14b93c6fcf73 / po/wesnoth-httt/pl.po: Heir To The Throne: Polish translation update http://git.io/fpn7hg
20140702 14:51:39< irker615> wesnoth: Paweł Jackowski wesnoth:1.12 24a40819531d / po/wesnoth-low/pl.po: Legend of Wesmere Polish translation update http://git.io/3F1dRA
20140702 14:51:40< irker615> wesnoth: Paweł Jackowski wesnoth:1.12 fe93f2c7f1a4 / po/wesnoth-trow/pl.po: The Rise of Wesnoth: Polish translation update http://git.io/zel7Ag
20140702 14:51:41< irker615> wesnoth: Paweł Jackowski wesnoth:1.12 db5ab397c88c / po/wesnoth-low/pl.po: Removed comments http://git.io/eofO6w
20140702 14:51:42< irker615> wesnoth: Paweł Jackowski wesnoth:1.12 d06b6cbb2d90 / po/wesnoth-tb/pl.po: Two Brothers: Polish translation update http://git.io/PaNHiw
20140702 14:51:44< irker615> wesnoth: Alexander van Gessel wesnoth:1.12 653f25826578 / po/ (5 files in 5 dirs): Merge pull request #230 from aquileia/pl http://git.io/l8XSxA
20140702 15:01:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140702 15:12:57-!- kex [~kex@212.92.210.53] has quit [Remote host closed the connection]
20140702 15:15:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140702 15:35:40-!- kex [~kex@93-143-100-214.adsl.net.t-com.hr] has joined #wesnoth-dev
20140702 15:54:26< irker615> wesnoth: Paweł Jackowski wesnoth:1.12 9c1cc4dee9a1 / po/wesnoth-ei/pl.po: Eastern Invasion: Polish translation update http://git.io/mX9PCA
20140702 15:54:28< irker615> wesnoth: Paweł Jackowski wesnoth:1.12 033ff1a8d867 / po/wesnoth-ei/pl.po: The Eastern Invasion, small update (pl) http://git.io/IZgL8A
20140702 15:54:30< irker615> wesnoth: Alexander van Gessel wesnoth:1.12 fb12e0243ac3 / po/wesnoth-ei/pl.po: Merge pull request #232 from pjackowski/1.12 http://git.io/QaR8Tg
20140702 15:54:32< irker615> wesnoth: Paweł Jackowski wesnoth:master bf63ff25ed64 / / (418 files in 239 dirs): Merge pull request #1 from wesnoth/master http://git.io/w2KaUQ
20140702 15:54:34< irker615> wesnoth: Paweł Jackowski wesnoth:master 57b5282d9000 / po/wesnoth-ei/pl.po:  Eastern Invasion: Polish translation update http://git.io/xt_-ag
20140702 15:54:36< irker615> wesnoth: Paweł Jackowski wesnoth:master 65a381c430e4 / po/wesnoth-ei/pl.po: The Eastern Invasion, small update (pl) http://git.io/uSd3SA
20140702 15:54:38< irker615> wesnoth: Alexander van Gessel wesnoth:master b70576c52624 / po/wesnoth-ei/pl.po: Merge pull request #233 from pjackowski/master http://git.io/V2xQxg
20140702 15:57:19-!- prkc [~prkc@4E5CCA17.dsl.pool.telekom.hu] has joined #wesnoth-dev
20140702 15:59:25-!- Kexoth [~kex@93-143-125-123.adsl.net.t-com.hr] has joined #wesnoth-dev
20140702 16:01:56-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140702 16:02:11-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has joined #wesnoth-dev
20140702 16:02:14-!- sachith500 [~kvirc@112.134.118.154] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20140702 16:02:17-!- kex [~kex@93-143-100-214.adsl.net.t-com.hr] has quit [Ping timeout: 252 seconds]
20140702 16:13:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140702 16:16:52-!- Kexoth [~kex@93-143-125-123.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140702 16:37:20-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140702 16:48:40-!- kex [~kex@93-143-125-123.adsl.net.t-com.hr] has joined #wesnoth-dev
20140702 17:11:59-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 244 seconds]
20140702 17:13:08-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 240 seconds]
20140702 17:31:35-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140702 17:32:04-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140702 17:35:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140702 17:39:30< aquileia> Just grepped through the logs of the last 2 months... found a few things that still might be relevant...
20140702 17:39:42< aquileia> 20140519 15:44:58< aquileia> There's probably a good reason to have the windmill & campfire both under core\images\terrain\misc and core\images\scenery, right? And to preserve that horribly outdated rubble tile in the latter while there are three newer ones under misc? The windmills are cropped differently, but the fires seem identical
20140702 17:40:14< aquileia> 20140527 19:57:00< aquileia> iceiceice: Just a random idea... is there a flag to run a different core? If so I'd say unit tests should use it for failsafe mode
20140702 17:40:33< aquileia> 20140527 19:57:33< iceiceice> y thats a good idea
20140702 17:41:50-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140702 17:41:58< aquileia> 20140529 01:09:32< aquileia> anonymissimus: BTW, are those Test_Debug & Test_Release configurations useful at all? As wesnothlib doesn't have them, they can't be selected anyhow
20140702 17:43:35< aquileia> 201405 19:09:56< Ivanovic> aquileia, mordante: okay, i gave those "other" libs a try and i can't just use them as drop in replacement
20140702 17:44:16-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140702 17:45:43< aquileia> and last but not least we wanted to make the masked dwarvish units use [base_unit] and updated animations
20140702 17:51:35-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has quit [Ping timeout: 272 seconds]
20140702 18:05:37-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Quit: Page closed]
20140702 18:06:08-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has joined #wesnoth-dev
20140702 18:08:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140702 18:21:43-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has quit [Ping timeout: 248 seconds]
20140702 18:41:40-!- Jetrel [~Jetrel@c-75-73-180-126.hsd1.mn.comcast.net] has joined #wesnoth-dev
20140702 18:52:08-!- kex [~kex@93-143-125-123.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140702 18:54:41-!- irker615 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140702 19:08:37-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140702 19:09:18-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has joined #wesnoth-dev
20140702 19:12:57-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140702 19:13:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20140702 19:47:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140702 19:48:23-!- ancestral [~ancestral@17.114.45.173] has joined #wesnoth-dev
20140702 19:48:32< RiftWalker> thunderstruck: I was testing sp commandline. It seems to work, but many scenarios fail to load because of this code here: https://github.com/wesnoth/wesnoth/blob/master/src/flg_manager.cpp#L312
20140702 19:48:35-!- ancestral is now known as ancestral_lunch
20140702 19:51:55< RiftWalker> When the recruit lists are empty on certain scenarios (because we're starting in the middle of a campaign), old sp would just load anyway and have no available units to recruit, but since we only have that custom faction, and it isn't being loaded because there are no recruits, assert(!available_factions.empty()) fails and program exits.
20140702 19:52:27< thunderstruck> RiftWalker: Hi.
20140702 19:52:32< RiftWalker> thunderstruck: Hi
20140702 19:52:53< thunderstruck> This doesn't surprise me. There will be other cases where you'll find some discrepancies between SP and MP.
20140702 19:53:17< thunderstruck> So, such code needs to be adapted for SP.
20140702 19:53:43< thunderstruck> Possibly, by making it not to rely on recruit lists being always non empty.
20140702 19:53:49< RiftWalker> thunderstruck: So my question is, remove the code which is stopping Custom faction from being added to the list? Remove it only in sp? or remove the assertion?
20140702 19:54:49< RiftWalker> Do you think it's necessary to keep that check in mp?
20140702 19:55:03< thunderstruck> Yes.
20140702 19:55:16< thunderstruck> Otherwise, you'll have an unwanted option in MP Connect.
20140702 19:56:08< RiftWalker> thunderstruck: Okay. Also, I've pushed commits addressing most of your comments. All that's left is this and organizing the engine-handling methods better.
20140702 19:56:47< thunderstruck> RiftWalker: I looked at them briefly. They all look good.
20140702 19:57:13< thunderstruck> However, it's a bit of an overkill to do so many commits for small fixes if code is not yet merged to master.
20140702 19:57:33< thunderstruck> I'd recommend to rebase and try to put these fixes into relevant commits next time, if possible.
20140702 19:57:50< thunderstruck> I also want to look at commit with difficulties in more detail.
20140702 20:00:33< RiftWalker> Okay.
20140702 20:01:36< thunderstruck> RiftWalker: So, removing an assertion or that check is not really a way to solve that problem.
20140702 20:02:58< thunderstruck> RiftWalker: You should try to figure out how to adapt it for SP. If you're not sure about the logic of that code - just ask me.
20140702 20:03:32< thunderstruck> RiftWalker: If you don't have any questions at the moment, I'll be going.
20140702 20:05:51-!- trademark_ [~trademark@nsg93-8-88-175-59-164.fbx.proxad.net] has quit [Ping timeout: 272 seconds]
20140702 20:08:24< thunderstruck> RiftWalker: Okay. I'm going. Bye.
20140702 20:08:27-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has quit [Quit: leaving]
20140702 20:09:03-!- Turuk_ [40399531@gateway/web/cgi-irc/kiwiirc.com/ip.64.57.149.49] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
20140702 20:11:34-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20140702 20:21:14-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140702 20:26:46-!- cib_ [~cib@p5DC755D3.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20140702 20:38:18-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140702 20:58:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140702 21:16:52-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20140702 21:17:21-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 252 seconds]
20140702 21:17:40-!- iceiceice_ [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has joined #wesnoth-dev
20140702 21:17:42-!- iceiceice_ [~chris@207-237-132-91.ny.subnet.cable.rcn.com] has quit [Changing host]
20140702 21:17:43-!- iceiceice_ [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140702 21:19:08-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: .]
20140702 21:45:04-!- ancestral_lunch is now known as ancestral
20140702 21:50:20-!- mjs-de [~mjs-de@f049173055.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140702 22:00:52-!- travis-ci [~travis-ci@ec2-54-87-168-71.compute-1.amazonaws.com] has joined #wesnoth-dev
20140702 22:00:52< travis-ci> [travis-ci] gfgtdf/wesnoth-old#182 (game_variables - 4ecd8ae : gfgtdf): The build was broken.
20140702 22:00:52< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/29004342
20140702 22:00:52-!- travis-ci [~travis-ci@ec2-54-87-168-71.compute-1.amazonaws.com] has left #wesnoth-dev []
20140702 22:10:03-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140702 22:24:04-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20140702 22:31:48-!- You're now known as lobby
20140702 22:33:24-!- irker470 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140702 22:33:24< irker470> wesnoth: Chris Beck wesnoth:master b223b37829bd / src/unit.cpp: fixup inefficient invisibility calculation for units http://git.io/BTVxLA
20140702 22:33:26< irker470> wesnoth: Chris Beck wesnoth:master e8bc775ba498 / changelog: changelog http://git.io/U0aPtA
20140702 22:35:01< irker470> wesnoth: Chris Beck wesnoth:1.12 b64c40413713 / src/unit.cpp: fixup inefficient invisibility calculation for units http://git.io/mviCcA
20140702 22:35:03< irker470> wesnoth: Chris Beck wesnoth:1.12 5d17951f8255 / changelog: update changelog http://git.io/hH5bew
20140702 22:38:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140702 22:44:27-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140702 22:46:55-!- kex [~kex@93-143-125-123.adsl.net.t-com.hr] has joined #wesnoth-dev
20140702 23:00:15-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140702 23:01:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20140702 23:04:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140702 23:07:12-!- leyyin [~leyyin@unaffiliated/leyyin] has quit [Quit: So Long, and Thanks for All the Fish]
20140702 23:27:47< irker470> wesnoth: Alexander van Gessel wesnoth:1.12 f02df58d9280 / src/server/ (forum_user_handler.cpp forum_user_handler.hpp): Fix a memory leak in forum_user_handler http://git.io/5QI7CA
20140702 23:27:49< irker470> wesnoth: Alexander van Gessel wesnoth:1.12 7ab054fc85dc / src/server/game.cpp: Fix memory leak in wesnothd http://git.io/RVH06Q
20140702 23:27:51< irker470> wesnoth: Alexander van Gessel wesnoth:1.12 c43bf75eca69 / src/server/forum_user_handler.hpp: Add a comment explaining the use of boost::shared_ptr http://git.io/Ykal4g
20140702 23:35:50-!- travis-ci [~travis-ci@ec2-54-87-194-61.compute-1.amazonaws.com] has joined #wesnoth-dev
20140702 23:35:50< travis-ci> [travis-ci] gfgtdf/wesnoth-old#183 (game_variables - 4ff51a3 : gfgtdf): The build was fixed.
20140702 23:35:50< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/29011845
20140702 23:35:50-!- travis-ci [~travis-ci@ec2-54-87-194-61.compute-1.amazonaws.com] has left #wesnoth-dev []
20140702 23:41:27-!- kex [~kex@93-143-125-123.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140702 23:42:05-!- kex [~kex@93-143-125-123.adsl.net.t-com.hr] has joined #wesnoth-dev
20140702 23:43:37-!- kex [~kex@93-143-125-123.adsl.net.t-com.hr] has quit [Remote host closed the connection]
20140702 23:45:28-!- kex [~kex@93-143-125-123.adsl.net.t-com.hr] has joined #wesnoth-dev
20140702 23:48:17< irker470> wesnoth: Chris Beck wesnoth:master 5637494c3ea0 / changelog: update changelog (forgot to update when wmi_pager was added) http://git.io/n4_oLQ
20140702 23:56:27-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140702 23:57:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
--- Log closed Thu Jul 03 00:00:39 2014