--- Log opened Sun Jul 06 00:00:00 2014
20140706 00:09:05< SpoOkyMagician> er, can someone explain the color_range's rgb=? Why is it in four values?
20140706 00:10:20< Laundry> alpha
20140706 00:10:31< Laundry> if there are four values
20140706 00:10:36< Laundry> one should be alpha
20140706 00:10:36< SpoOkyMagician> ah
20140706 00:10:42< Laundry> I'm assuming
20140706 00:15:29< SpoOkyMagician> ah im starting to think its cmyk...
20140706 00:15:53< SpoOkyMagician> that would explain it
20140706 00:16:35-!- prkc_ [~prkc@4E5C46FD.dsl.pool.telekom.hu] has joined #wesnoth-dev
20140706 00:18:26-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140706 00:19:00< SpoOkyMagician> unless im misunderstanding the format>
20140706 00:19:02< SpoOkyMagician> ?*
20140706 00:20:09-!- prkc [~prkc@4E5CCA17.dsl.pool.telekom.hu] has quit [Ping timeout: 244 seconds]
20140706 00:22:26< iceiceice> SpoOkyMagician: i looked at the code,
20140706 00:22:33< iceiceice> its handled in game_config.cpp
20140706 00:22:37< iceiceice> i think that what it is is,
20140706 00:22:47< iceiceice> each color corresponds to a range, not a single color
20140706 00:22:54< iceiceice> each hex number you see is an RGB color
20140706 00:23:12< iceiceice> the top two portions are ignored,
20140706 00:23:21< iceiceice> *the top two hex digits are ignroed
20140706 00:23:26< iceiceice> after that it hink its either RGB
20140706 00:23:27< iceiceice> or BGR
20140706 00:23:45< iceiceice> i mean it's this: 
20140706 00:23:45< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/game_config.cpp#L340
20140706 00:24:00< SpoOkyMagician> ok ill mess around with it a bit. *also checks link*
20140706 00:24:02< iceiceice> i dont know why a range has 4 parts?
20140706 00:24:37< iceiceice> if you want to see crap loads of output of what the game does iwth the color info, you can run with "--log-debug=engine" and look at all the color pallete stuff
20140706 00:26:38< SpoOkyMagician> hmm... i think i get it... *experiments*
20140706 00:28:12-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140706 00:28:16-!- prophile [~alynn@oftn/member/prophile] has quit [Client Quit]
20140706 00:31:50-!- gfgtdf [~chatzilla@f054143075.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140706 00:36:18< SpoOkyMagician> yep i got it now.
20140706 00:36:42< SpoOkyMagician> or at least starting to get somewhere
20140706 00:38:57< SpoOkyMagician> so this gets you pure magenta rgb=FF00FF,FFFFFF,000000,FF00FF
20140706 00:40:18< SpoOkyMagician> (tested with red, green, and blue and got those so im sort of getting it. need to figure out how the middle values work.
20140706 00:40:20< SpoOkyMagician> )*
20140706 00:42:35-!- Stumpfenstiel [~quassel@193-80-74-213.adsl.highway.telekom.at] has joined #wesnoth-dev
20140706 00:42:46-!- Stumpfenstiel [~quassel@193-80-74-213.adsl.highway.telekom.at] has quit [Remote host closed the connection]
20140706 00:43:27< SpoOkyMagician> it seems for the most part the first and last 2 are important. no clue exactly what the middle two do.
20140706 00:43:46< SpoOkyMagician> (yet)
20140706 00:47:28< SpoOkyMagician> yeah, i don't see a difference. Unless it has to do with actual terrain textures? i'm modding impassible. with 0000FF,AAAAAA,222222,0000FF I still see pure blue.
20140706 00:48:51< SpoOkyMagician> anyway thanks for the info. Really useful. I'll mess around with the colors a bit later. I gtg for now.
20140706 00:51:07< Laundry>  What does the whiteboard do?
20140706 00:59:19< iceiceice> Laundry: easiest way to understand is to play around with it
20140706 01:00:53< Laundry> iceiceice: What is it made for?
20140706 01:01:11< iceiceice> its to help you plan your moves
20140706 01:01:29< Laundry> iceiceice: OOoooOoOOOoOOOoOO
20140706 01:01:30< iceiceice> if you are playing networked, it shows your plans to your ally
20140706 01:01:38< Laundry> ok
20140706 01:06:33-!- prkc_ [~prkc@4E5C46FD.dsl.pool.telekom.hu] has quit [Ping timeout: 240 seconds]
20140706 01:10:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140706 01:19:17< Laundry> in the unit.cpp
20140706 01:20:11< Laundry> what config does it use in the constructor
20140706 01:20:13< Laundry> ?
20140706 01:22:18-!- Laundry [~austin@pool-71-166-34-122.bltmmd.fios.verizon.net] has left #wesnoth-dev []
20140706 01:24:08-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140706 02:13:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140706 02:21:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140706 02:27:20-!- irker601 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140706 02:33:40-!- gfgtdf [~chatzilla@f054048152.adsl.alicedsl.de] has joined #wesnoth-dev
20140706 02:34:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20140706 02:41:45-!- Ivanovic_ [~ivanovic@frnk-5f74e35c.pool.mediaWays.net] has joined #wesnoth-dev
20140706 02:45:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 255 seconds]
20140706 02:45:18-!- Ivanovic_ [~ivanovic@frnk-5f74e35c.pool.mediaWays.net] has quit [Changing host]
20140706 02:45:18-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140706 02:45:53-!- Ivanovic_ is now known as Ivanovic
20140706 02:46:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140706 02:47:39-!- irker702 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140706 02:47:39< irker702> wesnoth: Chris Beck wesnoth:master dbf94c0dedf9 / src/actions/create.cpp: precompute a unit_filter outside of a loop http://git.io/o7-HoA
20140706 02:47:39< irker702> wesnoth: Chris Beck wesnoth:master 750e770c62d3 / src/unit_display.cpp: use unit_filter::first_first_on_map in unit_display http://git.io/KMTarQ
20140706 02:47:40< irker702> wesnoth: Chris Beck wesnoth:master 47e9a3d25d2b / src/scripting/lua.cpp: lua find_cost_map fcn uses unit_filter::all_matches_on_map fcn http://git.io/-Fo92A
20140706 02:47:41< irker702> wesnoth: Chris Beck wesnoth:master eb9b3c97fd05 / src/scripting/lua.cpp: lua get_units uses unit_filter::all_matches_on_map syntax http://git.io/SnQ63g
20140706 03:01:49-!- gfgtdf [~chatzilla@f054048152.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140706 04:33:19-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Excess Flood]
20140706 04:33:35-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140706 04:55:07< SpoOkyMagician> these colors look MUCH better
20140706 04:57:11< SpoOkyMagician> feel free to try them/edit them as need be. I am gonna stick with these: http://pastebin.com/fHAuNyXU
20140706 04:59:02-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 877 seconds]
20140706 05:00:37-!- Samual_ [~dioteckte@xonotic/core-team/Samual] has joined #wesnoth-dev
20140706 05:01:24-!- Samual [~dioteckte@xonotic/core-team/Samual] has quit [Ping timeout: 276 seconds]
20140706 05:01:38-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20140706 05:14:50-!- SpoOkyMagician [~chatzilla@cpe-74-136-58-34.swo.res.rr.com] has quit [Quit: later]
20140706 05:22:12-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140706 05:32:39-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140706 05:34:17< vultraz> Those colors look pretty good
20140706 05:35:19< vultraz> (fixed the indent and removed commented out lines if anyone wants to look at it too http://pastebin.com/9R7Jq2S3 )
20140706 05:36:30< Coffee_irc> is it just me or does master now crash when trying to load any map?
20140706 05:47:42-!- irker702 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140706 06:03:44-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140706 06:09:03-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140706 06:31:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140706 07:02:54-!- cib_ [~cib@p5DC7524F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140706 07:12:07-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has quit [Remote host closed the connection]
20140706 07:17:45-!- Coffee_irc [~david@ppp121-45-15-35.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20140706 07:21:27-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20140706 07:24:55-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20140706 07:25:03-!- _8680_ [~8680@2002:4404:712c:0:5036:ed85:371b:1716] has quit [Remote host closed the connection]
20140706 07:25:20-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140706 07:25:23-!- _8680_ [~8680@2002:4404:712c:0:2dcb:30f7:ea45:1e76] has joined #wesnoth-dev
20140706 07:33:12-!- _8680_ [~8680@2002:4404:712c:0:2dcb:30f7:ea45:1e76] has quit [Ping timeout: 260 seconds]
20140706 07:33:57-!- _8680_ [~8680@2002:4404:712c:0:99fd:afaa:134f:3f3f] has joined #wesnoth-dev
20140706 07:48:34-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140706 08:10:31-!- mjs-de [~mjs-de@f048033127.adsl.alicedsl.de] has joined #wesnoth-dev
20140706 08:33:34-!- d347hm4n [~kde@82.Red-83-46-162.dynamicIP.rima-tde.net] has joined #wesnoth-dev
20140706 08:36:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140706 08:51:47-!- cib_ [~cib@p5DC7524F.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20140706 08:58:33-!- d347hm4n [~kde@82.Red-83-46-162.dynamicIP.rima-tde.net] has quit [Remote host closed the connection]
20140706 08:58:59-!- d347hm4n [~kde@82.Red-83-46-162.dynamicIP.rima-tde.net] has joined #wesnoth-dev
20140706 08:59:12-!- d347hm4n [~kde@82.Red-83-46-162.dynamicIP.rima-tde.net] has quit [Read error: Connection reset by peer]
20140706 09:01:27-!- cib_ [~cib@p5DC7524F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140706 09:03:43-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140706 09:13:07-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20140706 09:21:57-!- cib_ [~cib@p5DC7524F.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds]
20140706 09:25:23-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140706 09:28:11-!- cib_ [~cib@p5DC7524F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140706 09:28:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140706 09:42:33-!- cib_ [~cib@p5DC7524F.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20140706 10:01:34-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20140706 10:20:00-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140706 10:21:17< aquileia> Coffee_irc: If a build from yesterday is good enough, then I can't reproduce
20140706 10:24:08< aquileia> Wow... Did something in caching change? Is loads blazingly fast!
20140706 10:30:44-!- cib_ [~cib@p5DC7524F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140706 10:37:10< aquileia> it hit an assertion (unit_filter.cpp:309 attempt to instantiate a unit filter with a null filter context!) a few times while loading the factions (both for Liberty as well as a local game with default+khalifate)
20140706 10:39:16< aquileia> but it wasn't easily reproducible (F5, restarting the game both give about 10% chance that it'll happen on loading)
20140706 10:44:14-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Quit: Ex-Chat]
20140706 10:51:35< zookeeper> so how do i get the most recent 1.12 win build out of jenkins?
20140706 10:55:00< zookeeper> ah, got it, i think
20140706 10:55:40< zookeeper> that one "wesnoth" link -> debian7-32 1.12 mingw32 -> workspace
20140706 10:57:58< zookeeper> doesn't work with my 1.12 clone though
20140706 10:57:59< zookeeper> User message: Window not defined in WML: 'game_cache_options'. Perhaps a mismatch between data and source versions. Try --data-dir <trunk-dir>
20140706 10:57:59< zookeeper> Dev message: Condition 'window_types.find(*itor) != window_types.end()' failed at src/gui/widgets/settings.cpp:375 in function 'read'.
20140706 10:59:57< zookeeper> ...which happens to be the same i get if i try to run a master build on a 1.12 clone
20140706 11:04:36< Coffee_irc> aquileia: I get a segfault when loading any map with units on it
20140706 11:06:42-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140706 11:07:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140706 11:28:45< zookeeper> well, that much for me testing 1.12. i can't see anything which would have broken something like that recently.
20140706 11:29:45-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140706 11:54:33-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Quit: Page closed]
20140706 12:14:42-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140706 12:16:09< aquileia> zookeeper: This will fix ":n" https://github.com/wesnoth/wesnoth/pull/236
20140706 12:16:40< aquileia> neither gfgtdf nor iceiceice sem to be here, would you merge, please?
20140706 12:17:18-!- prkc [~prkc@4E5C46FD.dsl.pool.telekom.hu] has joined #wesnoth-dev
20140706 12:18:46< aquileia> it's the same fix as they used for ":cl" an I tested that it fixes the issue
20140706 12:28:25-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Quit: Page closed]
20140706 12:35:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140706 12:38:37-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Remote host closed the connection]
20140706 12:44:21-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140706 13:43:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20140706 13:44:14-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140706 13:44:45-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 264 seconds]
20140706 14:04:03-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140706 14:32:37-!- trolling [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140706 14:37:29-!- vultraz_ [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20140706 14:41:59-!- Netsplit *.net <-> *.split quits: prophile, vultraz
20140706 14:42:08-!- vultraz_ is now known as vultraz
20140706 14:51:17-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140706 14:56:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140706 15:04:37-!- irker535 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140706 15:04:37< irker535> wesnoth: gfgtdf wesnoth:master c2e3b4089fd5 / src/menu_events.cpp: Merge pull request #236 from aquileia/next_level http://git.io/d3AJKA
20140706 15:36:26-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140706 15:52:32-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140706 15:53:25< iceiceice> 20140706 10:24:08< aquileia> Wow... Did something in caching change? Is loads blazingly fast!
20140706 15:53:49< iceiceice> aquileia: i changed the way that unit filters are implemented so that they will be much faster if applied repeatedly, and avoid scanning all the units on the board
20140706 15:53:56< iceiceice> i think theres still issues i need to work out though
20140706 15:54:46< iceiceice> i still get a segfault / assertion failure once in a while but it hink i will be able to figure it out
20140706 15:55:07< iceiceice> the main speed win is probably in the animation loop, idk why it would speed up loading but maybe it does
20140706 15:57:19-!- travis-ci [~travis-ci@ec2-54-89-67-17.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 15:57:19< travis-ci> [travis-ci] gfgtdf/wesnoth-old#195 (misc_config_fixes - 5c35d59 : gfgtdf): The build failed.
20140706 15:57:19< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/29253926
20140706 15:57:19-!- travis-ci [~travis-ci@ec2-54-89-67-17.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 16:06:50-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has joined #wesnoth-dev
20140706 16:19:58-!- trolling [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140706 16:21:01< irker535> wesnoth: Alexander van Gessel wesnoth:1.8 8bc0a75c77f7 / src/server/ (forum_user_handler.cpp forum_user_handler.hpp): Fix a memory leak in forum_user_handler http://git.io/zbFuEQ
20140706 16:21:03< irker535> wesnoth: Alexander van Gessel wesnoth:1.8 569f8f36590c / src/server/game.cpp: Fix memory leak in wesnothd http://git.io/QAQbcw
20140706 16:21:05< irker535> wesnoth: Alexander van Gessel wesnoth:1.8 c369e0fe6e5d / src/server/forum_user_handler.hpp: Add a comment explaining the use of boost::shared_ptr http://git.io/EPS3rA
20140706 16:21:09-!- gfgtdf [~chatzilla@f054048152.adsl.alicedsl.de] has joined #wesnoth-dev
20140706 16:21:40< gfgtdf> thunderstruck: did you fix the map generation in mp campaigns in 1.12 ?
20140706 16:22:06< irker535> wesnoth: Chris Beck wesnoth:master c8d95fb953b4 / .travis.yml: run a headless mp test game as part of the travis clang builds http://git.io/aP9W1w
20140706 16:22:08< irker535> wesnoth: Chris Beck wesnoth:master cff404060b71 / src/commandline_options.cpp: give an error message when we crash from bad command line args http://git.io/WsgtgA
20140706 16:23:26< irker535> wesnoth: Chris Beck wesnoth:master f87177c71102 / src/ (unit_filter.cpp variable.cpp variable.hpp): filters hold safe vconfig, const vconfigs can call make safe http://git.io/xPQOlQ
20140706 16:26:15-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20140706 16:26:15-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20140706 16:34:46-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140706 16:36:03-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140706 16:43:55< thunderstruck> gfgtdf: No, not yet. I've been pretty busy for this whole week. I should be able to look at it in a day or two, though.
20140706 16:48:15-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140706 16:48:27-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140706 16:50:28< ancestral> mattsc: What is your Mac’s resolution?
20140706 16:51:33< irker535> wesnoth: Chris Beck wesnoth:master 4230bfb17f21 / src/ (commandline_options.cpp wesnoth.cpp): give better error messages when we can't parse command line args http://git.io/Y2bLRw
20140706 17:00:49< irker535> wesnoth: Chris Beck wesnoth:master ad402a721f25 / .travis.yml: also run ai test with gui on http://git.io/sxccQw
20140706 17:00:51< irker535> wesnoth: Chris Beck wesnoth:master 38a252ad2cf6 / .travis.yml: cleanup travis yml file (don't need [[, ]]) http://git.io/b_WghA
20140706 17:00:53< irker535> wesnoth: Chris Beck wesnoth:master 8bf15afe5e97 / .travis.yml: travis.yml: put time outside of multiline if http://git.io/2lDFKA
20140706 17:04:21-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 17:04:21< travis-ci> [travis-ci] gfgtdf/wesnoth-old#197 (misc_config_fixes - ded0ff3 : gfgtdf): The build is still failing.
20140706 17:04:21< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/29256997
20140706 17:04:21-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 17:05:03< irker535> wesnoth: Chris Beck wesnoth:master edd88206a71d / .travis.yml: add line breaks between the sections in .travis.yml http://git.io/9kty7g
20140706 17:05:05< irker535> wesnoth: Chris Beck wesnoth:master b737b0af96d2 / .travis.yml: fixup minor travis after_failure logic http://git.io/g1eQpA
20140706 17:08:35< ancestral> Is there a “recommended” aspect ratio?
20140706 17:08:42< ancestral> 4:3, 16:9, etc.?
20140706 17:08:49< ancestral> (for playing Wesnoth)
20140706 17:09:17< ancestral> Seems to me the answer is no, but perhaps having some standards ain’t a bad thing…?
20140706 17:18:12-!- Ardonik is now known as Ard0nik
20140706 17:21:38-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 252 seconds]
20140706 17:22:05-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140706 17:23:13-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140706 17:26:13-!- Ard0nik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has quit [Quit: Cats, devils, 'n porcupines]
20140706 17:26:42-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20140706 17:27:09< iceiceice> aquileia, Coffee_irc: let me know if you are still getting any unit_filter related segfaults / assertions
20140706 17:28:01< iceiceice> oh hmm i still have problems in the editor
20140706 17:28:06< iceiceice> anyways, anywhere besides the editor
20140706 17:28:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140706 17:33:49-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140706 17:35:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140706 17:42:24< ancestral> Is there a difference between master and 1.12?
20140706 17:42:48< ancestral> (er, that is, is master 1.13?)
20140706 17:44:46-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has quit [Quit: Leaving]
20140706 17:45:04-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20140706 17:45:41-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has quit [Client Quit]
20140706 17:46:09-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20140706 17:53:01< ancestral> http://wiki.wesnoth.org/WesnothRepository does not say…
20140706 17:55:14< gfgtdf> ancestral: what type of difference you mean ? ofc there are new features, new bugs ... in the newer version.
20140706 17:55:51< ancestral> gfgtdf: I’m about to make a pull request. Which branch should I merge into?
20140706 17:55:55< ancestral> It’s a bug fi
20140706 17:55:56< ancestral> *fix
20140706 17:56:12< gfgtdf> ancestral: is that a bug that is present in 1.12 too ?
20140706 17:56:18< ancestral> Yes. And 1.10.
20140706 17:56:33< ancestral> (And possibly older versions)
20140706 17:56:34< iceiceice> ancestral: probably don't merge to 1.10 as we don't plan to make another release
20140706 17:56:48< ancestral> So, make 2 requests?
20140706 17:56:50< iceiceice> if you want to merge bug fix to 1.12, it depends what it is
20140706 17:56:54< iceiceice> sure you can make requests
20140706 17:56:55< ancestral> 1.12 and master?
20140706 17:57:37< iceiceice> depending what it is, changes on 1.12 might need to be run by Ivanovic
20140706 17:58:07< ancestral> I’ll definitely want Ivanovic to look at it then
20140706 17:59:22< mattsc> ancestral: 1920x1200
20140706 17:59:58< ancestral> mattsc: I’m about to make a pull request for preferences.cpp. Right now the default is to render the window at 1024x768 if windowsize isn’t set
20140706 17:59:58-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140706 18:00:17< mattsc> ancestral: okay, sounds good to me
20140706 18:00:42< ancestral> I’m going to make it 800x600. Think I’ll put it in an #ifdef __APPLE__
20140706 18:01:12< ancestral> mattsc: I noticed resizing the window from the top left corner results in problems
20140706 18:01:39< mattsc> ancestral: okay - I pretty much always resize from the bottom right, so I wouldn’t have noticed
20140706 18:02:02< mattsc> What would changing to 800x600 accomplish?
20140706 18:02:16< ancestral> People who have computers with a smaller y resolution
20140706 18:02:27< ancestral> Like my 1280 x 800
20140706 18:02:48< ancestral> The 768 + window title bar + menu bar > 800
20140706 18:02:50< mattsc> oh, right, because of the factor 2 …
20140706 18:03:10< mattsc> I had the full retina resolution in the back of my mind ...
20140706 18:03:22< mattsc> sounds good to me then
20140706 18:03:56< mattsc> and if that fixes the retina display bug, it should definitely go into both 1.12 and master.  You don’t need to wait for Ivanovic for that.
20140706 18:04:11< ancestral> mattsc, this means anyone with a retina display MacBook won’t have problems at time of launch. Right now, anyone with a MacBook with retina display (half the Mac product line) on launch will have problems
20140706 18:04:14< ancestral> Yes
20140706 18:04:38< mattsc> great
20140706 18:04:47< mattsc> are there displays out there that are even smaller?
20140706 18:04:58< ancestral> The MacBook Air has a 1366 x 768
20140706 18:05:03< ancestral> I figure 600 is small enough
20140706 18:05:17-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 18:05:17< travis-ci> [travis-ci] wesnoth/wesnoth#3684 (master - 8bf15af : Chris Beck): The build has errored.
20140706 18:05:17< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/29258154
20140706 18:05:17-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 18:05:20< ancestral> (I mean, could do 1024x600, 1280x600, etc…)
20140706 18:05:57< ancestral> Ideally, some kind of code will properly set windowsize to whatever the OS X window manager has the window drawn at
20140706 18:06:04< mattsc> okay
20140706 18:06:20< ancestral> But… not sure where to start on that
20140706 18:06:26< mattsc> right - I got the impression that SDL doesn’t do that though, based on the comment somebody made
20140706 18:06:32< ancestral> Hmm
20140706 18:06:49< mattsc> I might be misremembering and don’t really know anything about it myself.
20140706 18:06:49< ancestral> Do you have much experience with Cocoa?
20140706 18:06:57< mattsc> no
20140706 18:07:00< ancestral> Yeah
20140706 18:07:51< ancestral> I’m guessing there must be some way to access Cocoa variables inside the Wesnoth code
20140706 18:08:12-!- travis-ci [~travis-ci@ec2-54-80-74-70.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 18:08:12< travis-ci> [travis-ci] wesnoth/wesnoth#3685 (master - b737b0a : Chris Beck): The build has errored.
20140706 18:08:12< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/29258357
20140706 18:08:12-!- travis-ci [~travis-ci@ec2-54-80-74-70.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 18:08:30< irker535> wesnoth: Chris Beck wesnoth:master 3229d8e44b40 / .travis.yml: remove the play_test with gui from travis script, it doesn't work http://git.io/NOZLug
20140706 18:09:47< ancestral> mattsc: Is Wesnoth easy to build for OS X? Is there anything I need to do in Xcode once I clone the repo?
20140706 18:10:52< AI0867> I can't push to 1.6 because the refspec matches both a branch and a tag...
20140706 18:13:32-!- travis-ci [~travis-ci@ec2-54-80-74-70.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 18:13:32< travis-ci> [travis-ci] gfgtdf/wesnoth-old#198 (misc_config_fixes - d8de05a : gfgtdf): The build was fixed.
20140706 18:13:32< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/29260047
20140706 18:13:32-!- travis-ci [~travis-ci@ec2-54-80-74-70.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 18:13:45< ancestral> mattsc: I really can’t imagine a problem with this commit, but it ought to be tested
20140706 18:14:09< ancestral> git clone is gonna take forever on this hotel wi-fi :-\
20140706 18:15:20< mattsc> ancestral: it _should_ be relatively easy to build (we’ve been working on making it close to out of the box), but there always seem to be some problems.
20140706 18:15:29< ancestral> Cool
20140706 18:15:32< mattsc> And they seem to be different for everybody.
20140706 18:15:39< irker535> wesnoth: Alexander van Gessel wesnoth:1.6 ca2e837b7985 / src/server/ (forum_user_handler.cpp forum_user_handler.hpp): Fix a memory leak in forum_user_handler http://git.io/dsoWPw
20140706 18:15:41< irker535> wesnoth: Alexander van Gessel wesnoth:1.6 84554af7bbd4 / src/server/game.cpp: Fix memory leak in wesnothd http://git.io/PQcLLA
20140706 18:15:43< irker535> wesnoth: Alexander van Gessel wesnoth:1.6 d99950d0be25 / src/server/forum_user_handler.hpp: Add a comment explaining the use of boost::shared_ptr http://git.io/Lip95g
20140706 18:15:44< mattsc> You also need the “Wesnoth compile stuff” from here:
20140706 18:15:53< ancestral> I know crimson_penguin graciously helped me in the past, an eon ago (a belated thanks to you, sir)
20140706 18:16:09< mattsc> http://sourceforge.net/projects/wesnoth/files/unofficial/Mac%20Compile%20Stuff/
20140706 18:16:34< ancestral> 1.13 == master… anything for 1.12?
20140706 18:16:42< mattsc> crimson_penguin knows a lot more about this than I do
20140706 18:16:49< mattsc> yes, master == 1.13
20140706 18:16:54< AI0867> ancestral: did you get the messages I left for you in the logs?
20140706 18:17:03< AI0867> I'm not sure what I said
20140706 18:17:09< ancestral> In the last hour?
20140706 18:17:41< AI0867> no, days ago
20140706 18:18:02< ancestral> Not sure
20140706 18:18:14< AI0867> ah, here's one: 12:31 < AI0867> ancestral: in SDL1.2 (which you're using unless you've been compiling master with SDL2 enabled), we have no way to determine the desktop resolution. It tries a saved resolution, and then a list of sane backups. 1138x904 is not among those
20140706 18:18:27< mattsc> ancestral: in case you don’t know, I have essentially not computer background, so all I ever do with these things is fumble along until I get something to work.
20140706 18:18:39< mattsc> But I really don’t know what I am doing.  :)
20140706 18:19:23< mattsc> ancestral, AI0867: ah, that’s the comment I was thinking about when I said the thing about SDL 15 min ago.
20140706 18:19:23< ancestral> Yeah, I’m not sure how I got 1138x904. I was trying different nonstandard resolutions
20140706 18:19:45-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has joined #wesnoth-dev
20140706 18:20:08< ancestral> AI0867: Thanks
20140706 18:21:16< mattsc> ancestral: http://wiki.wesnoth.org/CompilingWesnothOnMacOSX#Build_using_XCode
20140706 18:21:25< aquileia> ancestral: You are probably aware of this, but just in case - to make a PR for 1.12 you have to make a separate branch based on 1.12, else your PR will try to merge master into 1.12
20140706 18:21:53< mattsc> Those first 3 steps is all that’s needed for me (for Debug builds, at least)
20140706 18:22:01< ancestral> Super
20140706 18:22:28< mattsc> Note that you need the 1.9 compile stuff doe 1.12; and the 1.13 compile stuff for master
20140706 18:22:28< aquileia> alternatively, if you did only one PR, the commit could be cherry-picked to 1.12 by a dev
20140706 18:22:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20140706 18:22:32< ancestral> Is 1.12 being released any time soon?
20140706 18:23:01< ancestral> (Only asking as I want to test this before making the PR)
20140706 18:24:07< mattsc> ancestral: soon(ish), yes, but you have plenty of time for testing.
20140706 18:24:30-!- aquileia [2edf50c1@gateway/web/freenode/ip.46.223.80.193] has quit [Client Quit]
20140706 18:25:15< mattsc> ancestral: if you build the master branch on Xcode, please let me know how it goes, if you have any problems (and which) and what you need to do to get it to work.
20140706 18:25:24< irker535> wesnoth: Chris Beck wesnoth:master fcd9acd1b17b / src/unit_filter.cpp: store child unit filters in a vector not a ptr_vector http://git.io/uJR7UQ
20140706 18:26:00< mattsc> The reason is that I changed everything to 64-bit compiling on master, and that has hardly been tested yet
20140706 18:26:44< mattsc> Also, there are some issues with fonts etc. that still need to be worked out (them being slightly offset in buttons etc., that sort of thing)
20140706 18:26:54< ancestral> Oh fantastic
20140706 18:27:31< ancestral> I had a sparsecheckout of a clone I was using for my Bestiary project and was able to turn that off
20140706 18:27:33< mattsc> Also, I assume you have at least OS X 10.8?
20140706 18:27:46< ancestral> I’m running 10.9.4 on this machine
20140706 18:27:51< mattsc> okay, cool.
20140706 18:28:09< ancestral> Hopefully I can try building later today or possibly tomorrow
20140706 18:28:34< mattsc> I know that the master build currently does not work on 10.5 (because the dylibs don’t use the right SDKs for that).  I’ll recompile them at some point to make that work.
20140706 18:29:36< mattsc> Okay, no worries.  I’m generally around, also not always at the computer.  So you leave me message if you encounter problems.
20140706 18:29:46-!- thunderstruck [~zaibotren@cpc7-lewi16-2-0-cust662.2-4.cable.virginm.net] has quit [Quit: leaving]
20140706 18:29:49< ancestral> I woouldn’t drop a tear if 10.5 support were dropped in the future
20140706 18:29:52< mattsc> s/you/just
20140706 18:30:06< ancestral> Cool, thanks mattsc
20140706 18:30:31< mattsc> well, but there are actually quite a few people who still use 10.5; if it’s easy enough, I’d prefer not to exclude them (quite yet)
20140706 18:31:03< ancestral> Every Intel Mac can run 10.6 or better, and 10.6 is still available to purchase… but sure
20140706 18:31:17< ancestral> Looks like SDL2 still supports 10.5
20140706 18:31:30< ancestral> (but only Intel)
20140706 18:32:16< ancestral> (Okay, that’s just their binary, maybe SDL can be built for PPC. Sounds like a nightmare.)
20140706 18:32:45< mattsc> well, ppc support has already been dropped afaik
20140706 18:32:47-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140706 18:39:14-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 18:39:14< travis-ci> [travis-ci] wesnoth/wesnoth#3686 (master - 3229d8e : Chris Beck): The build has errored.
20140706 18:39:14< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/29261579
20140706 18:39:14-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 18:54:53< irker535> wesnoth: Chris Beck wesnoth:master 59fce33b4239 / .travis.yml: fix syntax error in .travis.yml http://git.io/KmSztw
20140706 19:04:51-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 19:04:51< travis-ci> [travis-ci] wesnoth/wesnoth#3688 (master - fcd9acd : Chris Beck): The build has errored.
20140706 19:04:51< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/29262231
20140706 19:04:51-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 19:20:29-!- ancestral [~ancestral@mobile-166-137-186-033.mycingular.net] has joined #wesnoth-dev
20140706 19:22:18-!- travis-ci [~travis-ci@ec2-54-89-67-17.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 19:22:19< travis-ci> [travis-ci] gfgtdf/wesnoth-old#200 (misc_config_fixes - b2da3f9 : gfgtdf): The build has errored.
20140706 19:22:19< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/29263664
20140706 19:22:19-!- travis-ci [~travis-ci@ec2-54-89-67-17.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 19:25:37-!- travis-ci [~travis-ci@ec2-54-89-67-17.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 19:25:37< travis-ci> [travis-ci] wesnoth/wesnoth#3689 (master - 59fce33 : Chris Beck): The build passed.
20140706 19:25:37< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/29263837
20140706 19:25:37-!- travis-ci [~travis-ci@ec2-54-89-67-17.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 19:28:45-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 240 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140706 19:31:11-!- cib_ [~cib@p5DC7524F.dip0.t-ipconnect.de] has quit [Quit: Leaving]
20140706 19:35:03-!- ancestral [~ancestral@mobile-166-137-186-033.mycingular.net] has quit [Quit: Smell ya later!]
20140706 19:36:07-!- ancestral [~ancestral@mobile-166-137-186-033.mycingular.net] has joined #wesnoth-dev
20140706 19:43:31-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has left #wesnoth-dev []
20140706 19:43:35-!- ancestral [~ancestral@mobile-166-137-186-033.mycingular.net] has quit [Quit: Smell ya later!]
20140706 19:54:41-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 19:54:41< travis-ci> [travis-ci] gfgtdf/wesnoth-old#201 (misc_config_fixes - a8646c3 : gfgtdf): The build failed.
20140706 19:54:41< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/29265690
20140706 19:54:41-!- travis-ci [~travis-ci@ec2-54-242-13-134.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 20:13:57-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140706 20:14:30< iceiceice> AI0867: do you know if mordante plans to look at this? https://github.com/wesnoth/wesnoth/pull/229
20140706 20:14:56< iceiceice> i added some todo remarks around it along the lines "it would be good to integrate this into gui2", i think it would be ok to merge
20140706 20:24:03< AI0867> I poked him about it, he replied
20140706 20:25:40< irker535> wesnoth: Chris Beck wesnoth:master ee6b3ca02a4c / src/ (statistics.cpp unit.cpp unit.hpp): move a barely used function out of unit into statistics http://git.io/45JD7w
20140706 20:25:42< irker535> wesnoth: Chris Beck wesnoth:master e3d34a34bede / src/ (team.cpp team.hpp unit_abilities.cpp variable.cpp): remove pointless static singleton getter for teams http://git.io/eIU4hg
20140706 20:31:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20140706 20:38:02-!- travis-ci [~travis-ci@ec2-54-80-74-70.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 20:38:02< travis-ci> [travis-ci] gfgtdf/wesnoth-old#202 (misc_config_fixes - e6cb47a : gfgtdf): The build is still failing.
20140706 20:38:02< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/29267714
20140706 20:38:02-!- travis-ci [~travis-ci@ec2-54-80-74-70.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 20:38:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20140706 20:39:45< irker535> wesnoth: Chris Beck wesnoth:master 7fec227478d9 / src/ (display_context.cpp display_context.hpp game_board.cpp game_board.hpp): move is_observer from game_board to display_context, b/c editor uses http://git.io/HuXOKQ
20140706 20:39:47< irker535> wesnoth: Chris Beck wesnoth:master f63f1331a19c / src/ (map_label.cpp map_label.hpp): fixup map label segfault in editor http://git.io/1AW-xg
20140706 20:39:49< irker535> wesnoth: Chris Beck wesnoth:master da1aa6343d0a / src/ (6 files): Merge branch 'fixup_editor' http://git.io/Vpj9eg
20140706 21:00:18< irker535> wesnoth: Chris Beck wesnoth:master d64c296edc67 / src/ (menu_events.cpp team.cpp team.hpp): remove pointless "team::nteams()" static getter http://git.io/UIHglQ
20140706 21:13:28-!- prkc [~prkc@4E5C46FD.dsl.pool.telekom.hu] has quit [Quit: Leaving]
20140706 21:24:07< shadowm> iceiceice: What does #229 have to do with GUI2?
20140706 21:24:31< iceiceice> iiuc gui2 is the one with the fancy layout algorithm
20140706 21:24:36-!- shadowm_desktop [ignacio@181.43.81.236] has joined #wesnoth-dev
20140706 21:24:39-!- shadowm_desktop [ignacio@181.43.81.236] has quit [Changing host]
20140706 21:24:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20140706 21:24:54< shadowm> iceiceice: But it doesn't support menus.
20140706 21:25:09< iceiceice> ok
20140706 21:25:26< iceiceice> i think i dont understand what is being requested in the thread in 229 then
20140706 21:25:42< iceiceice> because gui1 menus dont respond to available size etc. ?
20140706 21:25:43< shadowm> Not at this time, anyway, and still I'd not expect it to shoehorn a niche thing like that into the framework.
20140706 21:26:38< shadowm> iceiceice: Where?
20140706 21:26:49< iceiceice> https://github.com/wesnoth/wesnoth/pull/229
20140706 21:27:02< shadowm> Yes, what is the comment you are concerned about?
20140706 21:27:26< iceiceice> i dont see that the behavior can be a function of the available space unless it is integrated into the gui
20140706 21:27:32< iceiceice> i assumed that meant gui2, but if not,
20140706 21:27:41< iceiceice> surely its not "integrate this into gui1" since that is not being developed?
20140706 21:27:50< shadowm> I don't see such a comment.
20140706 21:27:59< iceiceice> the only comment in the thread that isn't mine.
20140706 21:28:11< shadowm> That'd be AI0867's comment, which isn't what you said.
20140706 21:28:26< shadowm> "This doesn't feel like something that should be a preference, but something that should be a function of the vertical space available. What happens if someone sets 32 and tries to play on 800x480?"
20140706 21:28:34< iceiceice> yes... and i'll quote myself:
20140706 21:28:43< iceiceice> <iceiceice> i dont see that the behavior can be a function of the available space unless it is integrated into the gui
20140706 21:29:07< shadowm> I assumed that was in answer to 17:27:01 <shadowm> Yes, what is the comment you are concerned about?
20140706 21:29:17< iceiceice> ah ok
20140706 21:30:00< shadowm> I don't see what AI's comment has to do with GUI2, although I should note I agree with it.
20140706 21:30:15< iceiceice> yeah but do you see any realistic way that we could implement that right now
20140706 21:30:24< shadowm> As I said before, this kind of thing shouldn't be controlled by the user.
20140706 21:30:53< lipkab> max_entries = video.gety() / 30;
20140706 21:31:12< shadowm> The "available space" should be something the gui::menu GUI1 widget should determine by itself based on how much room it has regardless of other UI elements, given its application-modal nature.
20140706 21:31:34< iceiceice> lipkab: that's super hacky, and if anyone tries to actually make gui2 menus then it would probably drive them crazy
20140706 21:31:36< shadowm> In fact, it's pretty obvious it already does so since otherwise it would be unable to present you with a scrollbar when the menu is taller than that available space.
20140706 21:31:58< shadowm> So I'm not sure where the supposed difficulty comes from.
20140706 21:32:40< iceiceice> well the difficulty is that you have two options, you can display fewer menu items in a "menu group" (which the pager would become?) or display a scroll bar
20140706 21:32:43< lipkab> iceiceice: I'll take that as a compliment, but I don't cosider myself a superhacker.
20140706 21:32:49< lipkab> Nor that code super hacky.
20140706 21:33:00< lipkab> *consider
20140706 21:33:13< iceiceice> lipkab: the pager would have to know the context menu coordinates also
20140706 21:33:16< iceiceice> or it wouldn't work
20140706 21:33:16< shadowm> It's all part of the widget's implementation, sure, and not exposed to client code. Should it be otherwise? Most definitely not.
20140706 21:33:53< lipkab> iceiceice: Okay, then:
20140706 21:33:58< iceiceice> i would rather not rewrite context menu code that is scheduled to be removed
20140706 21:34:09< iceiceice> that's a pretty serious waste of my time
20140706 21:34:19< shadowm> It's been scheduled to be removed since 2008.
20140706 21:34:20< lipkab> max_entries = (video.gety() - menu_y) / 30;
20140706 21:34:29< iceiceice> and?
20140706 21:34:51< iceiceice> i guess that means it's probably about to be removed.
20140706 21:34:52< shadowm> That's just a fact I thought might come in handy if you really want to give the issue some thought.
20140706 21:35:18< shadowm> Also "But [GUI2] doesn't support menus. Not at this time, anyway [...]".
20140706 21:35:44< iceiceice> i would be happy to revisit the issue when we have gui2 menus but i have no interest in hacking this behavior into code that we plan to remove... nor in learning how that code works
20140706 21:35:53< iceiceice> i think that's a pretty reasonable position
20140706 21:36:15< shadowm> I'm not trying to force you to reconsider.
20140706 21:36:25< iceiceice> nor in hacking more gui logic into the play_controller, my long term project is to *remove* such logic
20140706 21:36:38< shadowm> However, "it's probably about to be removed" is a pipe dream.
20140706 21:37:07< iceiceice> ok, if you say so
20140706 21:37:10< shadowm> There is no reason why the play_controller should be in charge of making decisions of this sort if gui::menu had the logic built-in.
20140706 21:37:41< iceiceice> i agree with that
20140706 21:37:56< iceiceice> my commit moves us one step closer to that, since previously these decisions were made in game_events/wmi_container
20140706 21:40:34-!- gfgtdf_ [~chatzilla@f054146109.adsl.alicedsl.de] has joined #wesnoth-dev
20140706 21:42:08< irker535> wesnoth: Chris Beck wesnoth:master 8ecef3b6f02e / src/ (11 files in 3 dirs): move homeless statistics calc fcns from unit.?pp to display_context http://git.io/wAHvnA
20140706 21:42:55-!- gfgtdf [~chatzilla@f054048152.adsl.alicedsl.de] has quit [Ping timeout: 272 seconds]
20140706 21:42:59-!- gfgtdf_ is now known as gfgtdf
20140706 21:45:11< irker535> wesnoth: Chris Beck wesnoth:master 3c01715b599a / .travis.yml: fixup syntax errors in .travis.yml http://git.io/6ntjzg
20140706 21:48:53< irker535> wesnoth: gfgtdf wesnoth:master 68f86524a468 / src/variable_info.cpp: fix as_arrays for variable_access_const http://git.io/_QJvXA
20140706 21:48:55< irker535> wesnoth: gfgtdf wesnoth:master 792b34686e5a / src/lua/ldo.cpp: fix assertion error on lua exceptions, http://git.io/unK9rA
20140706 21:48:57< irker535> wesnoth: gfgtdf wesnoth:master ca8528d3c7c5 / src/ (config.cpp config.hpp): fix config comparison http://git.io/nsL3tg
20140706 21:48:59< irker535> wesnoth: gfgtdf wesnoth:master 69a2457a5b67 / src/tests/test_config.cpp: extend test_config unit test http://git.io/LWMZ4g
20140706 21:56:39< shadowm> gfgtdf: Lines 405 through 408 in that diff really belong in the commit message, not the diff.
20140706 21:56:51< shadowm> Er, that diff being https://github.com/wesnoth/wesnoth/commit/ca8528d3c7c5307b68e41f95451de4a0b63c6dc6 .
20140706 22:05:21-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Quit: .]
20140706 22:21:18< crimson_penguin> whoever said something to me, I didn't see it
20140706 22:29:04< gfgtdf> iceiceice: you know why lua_jailbreak_exceptions is not in the scripting/lua subfolder ?
20140706 22:29:18< iceiceice> no idk
20140706 22:29:34< iceiceice> probably people are lazy to move files :p
20140706 22:29:45< iceiceice> i think its a good idea to move
20140706 22:30:27< iceiceice> idk maybe should wait though, only because
20140706 22:30:33< iceiceice> i think ancestral is trying to figure out how to build on xcode
20140706 22:33:15< Coffee_irc> iceiceice: yeah, I still get a segfault on loading any map
20140706 22:33:28< iceiceice> really?
20140706 22:33:31< iceiceice> i thought i fixed it
20140706 22:33:33< iceiceice> i was getting it also
20140706 22:33:36< Coffee_irc> I can take a look at debugging and getting you more info after coming back from work
20140706 22:33:51< iceiceice> ok
20140706 22:34:17< iceiceice> do you have the code in this commit for sure? http://git.io/1AW-xg
20140706 22:34:31-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140706 22:34:53< Coffee_irc> iceiceice: yes
20140706 22:35:00< iceiceice> :(
20140706 22:35:00< iceiceice> ok
20140706 22:35:04< Coffee_irc> just pulled and compiled from master
20140706 22:35:15< Coffee_irc> also did a clean beforehand
20140706 22:37:21-!- mjs-de [~mjs-de@f048033127.adsl.alicedsl.de] has quit [Remote host closed the connection]
20140706 22:43:02< irker535> wesnoth: Ignacio R. Morelle wesnoth:master 3d183dbd91ce / src/addon/manager_ui.cpp: addon/mg: Rework the Update All action logic for genericity http://git.io/M7myZQ
20140706 22:43:05< irker535> wesnoth: Ignacio R. Morelle wesnoth:master 9407f4ab816b / changelog src/addon/manager_ui.cpp: addon/mg: Include Update All on all views and enable it when applicable http://git.io/3AdnWA
20140706 22:43:07-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140706 22:43:08< irker535> wesnoth: Ignacio R. Morelle wesnoth:master d1f1819fc909 / src/addon/manager_ui.cpp: addon/mg: Choose "update" vs. "install" terms when using Update All too http://git.io/r-tiVA
20140706 22:46:19< irker535> wesnoth: Chris Beck wesnoth:master 6f4763ce0467 / src/ (5 files in 4 dirs): get_village takes a pointer to variable set when fire_event desired http://git.io/VYyIyg
20140706 22:46:21< irker535> wesnoth: Chris Beck wesnoth:master 4286b13a7932 / src/ (editor/map/map_context.cpp game_data.cpp team.cpp team.hpp teambuilder.hpp): team::build takes a pointer to the game_data obj we want to use http://git.io/-1xL0Q
20140706 22:46:23< irker535> wesnoth: Chris Beck wesnoth:master 74757696276a / / (7 files in 5 dirs): Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/RHxDCg
20140706 23:01:45< iceiceice> ok, Coffee_irc I tried a few more but I can't reproduce the editor crash, so if you could help me out / perhaps send me the file you can't load?
20140706 23:02:02< iceiceice> or a backtrace i guess, but i'd rather have the file maybe
20140706 23:19:07-!- travis-ci [~travis-ci@ec2-54-225-52-57.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 23:19:07< travis-ci> [travis-ci] wesnoth/wesnoth#3696 (master - d1f1819 : Ignacio R. Morelle): The build passed.
20140706 23:19:07< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/29276474
20140706 23:19:07-!- travis-ci [~travis-ci@ec2-54-225-52-57.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 23:33:27< irker535> wesnoth: Chris Beck wesnoth:master 0ebaae5acf4a / src/unit_animation.cpp: bugfix for #22285 http://git.io/xFsUww
20140706 23:38:43< iceiceice> gfgtdf: you will post something on bug #22268?
20140706 23:41:48< iceiceice> someone who knows about file system issues: can you take a look at 22265?
20140706 23:43:12< shadowm> AI0867: ^ Seems to be your favorite Windows-specific bug.
20140706 23:47:25-!- travis-ci [~travis-ci@ec2-54-225-52-57.compute-1.amazonaws.com] has joined #wesnoth-dev
20140706 23:47:25< travis-ci> [travis-ci] wesnoth/wesnoth#3697 (master - 7475769 : Chris Beck): The build passed.
20140706 23:47:25< travis-ci> [travis-ci] Build details : http://travis-ci.org/wesnoth/wesnoth/builds/29276594
20140706 23:47:25-!- travis-ci [~travis-ci@ec2-54-225-52-57.compute-1.amazonaws.com] has left #wesnoth-dev []
20140706 23:56:40-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
--- Log closed Mon Jul 07 00:00:06 2014