--- Log opened Sun Jul 13 00:00:32 2014 20140713 00:21:27-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140713 00:25:56-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20140713 00:29:08-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20140713 00:29:12< ancestral> shadowm: Would you consider adding `image-rendering: optimizeSpeed;` to .postbody in the forum stylesheet? 20140713 00:29:52< ancestral> This will cause images, particularly pixel art images not to show up blurry when zooming in and on hi-def screens 20140713 00:56:51-!- irker224 [~irker@109.237.218.218] has quit [Quit: transmission timeout] 20140713 01:31:55-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game] 20140713 02:11:10-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140713 02:33:04-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20140713 02:37:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 256 seconds] 20140713 02:39:03-!- Ivanovic_ is now known as Ivanovic 20140713 02:47:42-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140713 03:05:48-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20140713 03:10:35-!- molgrum [~molgrum@212.85.89.43] has quit [Remote host closed the connection] 20140713 03:12:44-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140713 03:13:11-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev 20140713 03:14:31-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140713 03:29:11< mattsc> shadowm, Ivanovic: 1.11.16 OS X package is up on SF also 20140713 03:29:59< mattsc> ancestral: do you want to take over making the OS X packages? 20140713 03:30:38< ancestral> Can’t that kind of thing be automated? 20140713 03:33:36< mattsc> Possibly, but I don’t know enough about that. There are enough different steps involved that I’d have a hard time putting that together. 20140713 03:34:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140713 03:39:01< ancestral> I don’t want to commit to something like that quite right now 20140713 03:43:25-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 240 seconds] 20140713 03:59:08-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140713 04:02:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140713 04:03:25-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20140713 04:03:26< mattsc> ancestral: okay, no worries. 20140713 04:03:56< mattsc> And now I’m off for real. Cheers, everybody. 20140713 04:04:00-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Client Quit] 20140713 04:20:15-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20140713 06:28:05-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140713 06:39:28-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140713 07:19:26-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20140713 07:38:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection] 20140713 07:40:11-!- cib0 [~cib@p5DD232A0.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140713 07:44:15-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20140713 07:52:44-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20140713 08:03:34< Ivanovic> is it just me or is the turn dialog not completely translateable? 20140713 08:03:50< Ivanovic> to reproduce: in the 1.12 branch start the tutorial with the turn dialog active 20140713 08:03:57< Ivanovic> the displayed team name is "human_player" 20140713 08:04:09< Ivanovic> so the save_id is used 20140713 08:04:25-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20140713 08:05:06< Ivanovic> the same when starting TROW 20140713 08:05:16< Ivanovic> i think this once upon the time was translated 20140713 08:06:44< Ivanovic> same issue in master with the untranslateable team name in the turn dialog since the save id is used 20140713 08:09:58-!- thunderstruck [~zaibotren@86.6.42.151] has joined #wesnoth-dev 20140713 08:26:02-!- mjs-de [~mjs-de@80.140.142.227] has joined #wesnoth-dev 20140713 08:49:24< thunderstruck> RiftWalker: Hi. I think that your PR can now be merged. But maybe lets wait a bit to see if iceiceice, gfgtdf, vultraz or any other developer has any comments on it? 20140713 08:53:07-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20140713 08:53:58-!- cib0 [~cib@p5DD232A0.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20140713 08:55:50< RiftWalker> thunderstruck: I've got at least one more commit to do before merging. 20140713 08:56:33< RiftWalker> thunderstruck: I'll email you the details. It's almost done. 20140713 08:58:30< thunderstruck> RiftWalker: Okay. It would be good if you'd leave a comment on your PR saying that it's still WIP or something to avoid it being merged. 20140713 09:17:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140713 09:17:31< RiftWalker> thunderstruck: No need; just pushed it. I had thought there might be another thing, but it seems to be preexisting: after you complete a campaign from command line, selecting "Campaign" from the title screen brings you to the scenario specified in the commandline. 20140713 09:21:23< thunderstruck> RiftWalker: I think it's also worth to note about the needed changes for playcampaign.*pp. It's not clear that non-first scenario are still not using this MP codepath. 20140713 09:21:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140713 09:25:09< RiftWalker> thunderstruck: I may be mistaken, but I believe it follows generally the same codepath as a local mp game. 20140713 09:25:17-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140713 09:25:58< RiftWalker> i.e. IO_NONE 20140713 09:30:09-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 256 seconds] 20140713 09:31:36< RiftWalker> Anyway, I've got to get some sleep. I'll be mostly busy tomorrow, so I'll pick it back up on Monday. I'm fairly certain my branch is now ready to merge, but it's your call whether you want to go ahead and merge or wait and give it a closer look. 20140713 09:31:36< thunderstruck> RiftWalker: Hmm. Does local MP really use IO_NONE? 20140713 09:31:50< RiftWalker> thunderstruck: lemme check.. 20140713 09:32:10< thunderstruck> RiftWalker: There's no urgency at all. Just to go sleep :) 20140713 09:33:18< thunderstruck> RiftWalker: I already had a closer look. But there's always a chance that someone else might notice something I haven't. 20140713 09:38:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140713 09:41:14< RiftWalker> mp uses IO_SERVER. Although, in playcampaign.cpp::play_game(), expand_mp_events() is called for IO_NONE. So maybe era and mod info is being carried over? 20140713 09:41:32< RiftWalker> Anyway, I'm off. shoot me an email if you have any ideas. 20140713 09:42:20-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has quit [Quit: leaving] 20140713 09:44:51< thunderstruck> RiftWalker: well, yeah, I mentioned that in my previous email. But in some cases era and mod might not be part of carryover and then you'll have problems. 20140713 09:47:09-!- _8680_ [~8680@2002:4404:712c:0:9cc3:ab39:531e:1f8e] has quit [Ping timeout: 256 seconds] 20140713 09:47:44-!- _8680_ [~8680@2002:4404:712c:0:6004:84f2:7f3b:de14] has joined #wesnoth-dev 20140713 09:50:47-!- prkc [~prkc@81.182.160.93] has joined #wesnoth-dev 20140713 09:55:09-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev 20140713 09:55:13-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host] 20140713 09:55:13-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20140713 09:55:25< mordante> servus 20140713 09:56:00-!- _8680_ [~8680@2002:4404:712c:0:6004:84f2:7f3b:de14] has quit [Ping timeout: 260 seconds] 20140713 09:58:15-!- _8680_ [~8680@2002:4404:712c:0:cc8d:532e:716c:fcb5] has joined #wesnoth-dev 20140713 10:06:03-!- _8680_ [~8680@2002:4404:712c:0:cc8d:532e:716c:fcb5] has quit [Ping timeout: 240 seconds] 20140713 10:06:56-!- _8680_ [~8680@2002:4404:712c:0:34b2:8d4e:6de3:494f] has joined #wesnoth-dev 20140713 10:13:21-!- irker798 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140713 10:13:21< irker798> wesnoth: Andrius Silinskas wesnoth:1.12 6ff46ee046c3 / changelog src/playcampaign.cpp: Fixed map/scenario generation for networked MP campaigns. http://git.io/t01EGg 20140713 10:33:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20140713 10:35:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140713 10:38:47-!- Netsplit *.net <-> *.split quits: DDR, crimson_penguin 20140713 10:40:03-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140713 10:40:33-!- Netsplit over, joins: DDR, crimson_penguin 20140713 10:41:36-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140713 10:45:19< mordante> wesbot seen lipkab 20140713 10:45:19< wesbot> mordante: The person with the nick lipkab last spoke 4d 15h ago. 13h 34m ago was here and on the channel #wesnoth with the message: Quit: . 20140713 10:49:23< irker798> wesnoth: Mark de Wever wesnoth:master ad6d8c4844a4 / src/game_display.hpp: Fix a Doxygen comment error. http://git.io/M9MTeQ 20140713 10:49:25< irker798> wesnoth: Mark de Wever wesnoth:master 322aebb8ca52 / src/variable_info.cpp: Fix a Doxygen comment error. http://git.io/G02AkQ 20140713 10:49:27< irker798> wesnoth: Mark de Wever wesnoth:master a533a44889be / src/variable_info.cpp: Remove a useless semicolon. http://git.io/lMj0Dw 20140713 10:49:30< irker798> wesnoth: Mark de Wever wesnoth:master e83ab1b6ec3e / src/variable_info.hpp: Remove a useless semicolon. http://git.io/60nu8Q 20140713 10:49:31< irker798> wesnoth: Mark de Wever wesnoth:master a3422cafcca4 / src/variable_info.cpp: Improve a horrible enumerate conversion. http://git.io/3Mubww 20140713 10:49:33< irker798> wesnoth: Mark de Wever wesnoth:master c521a3893313 / src/variable_info.cpp: Fix a comment typo. http://git.io/D7i_7w 20140713 10:49:35< irker798> wesnoth: Mark de Wever wesnoth:master c119584895c2 / src/ (49 files in 8 dirs): Strip trailing whitespace. http://git.io/1WXEiw 20140713 10:49:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20140713 11:02:59-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev 20140713 11:14:07-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140713 11:18:20-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20140713 12:02:23-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140713 12:07:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20140713 12:31:48-!- kex_ [~kex@89.205.75.19] has joined #wesnoth-dev 20140713 12:33:08-!- Kexoth [~kex@89.205.75.19] has quit [Ping timeout: 240 seconds] 20140713 12:34:19-!- Zappaman [~Zappaman@92.55.154.101] has joined #wesnoth-dev 20140713 12:36:56-!- Zappaman [~Zappaman@92.55.154.101] has quit [Client Quit] 20140713 12:52:38-!- scimitar [~krishna@115.248.50.21] has joined #wesnoth-dev 20140713 12:54:02-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev 20140713 12:54:15-!- mjs-de [~mjs-de@80.140.142.227] has quit [Remote host closed the connection] 20140713 13:10:17-!- Alkenrinnstet [~Alkenrinn@202.166.68.240] has quit [Read error: Connection reset by peer] 20140713 13:10:44-!- Alkenrinnstet [~alkenrinn@202.166.68.240] has joined #wesnoth-dev 20140713 13:13:07-!- Samual [~dioteckte@xonotic/core-team/Samual] has quit [Read error: Connection reset by peer] 20140713 13:13:35-!- Samual [~dioteckte@c-24-3-185-118.hsd1.pa.comcast.net] has joined #wesnoth-dev 20140713 13:13:35-!- Samual [~dioteckte@c-24-3-185-118.hsd1.pa.comcast.net] has quit [Changing host] 20140713 13:13:35-!- Samual [~dioteckte@xonotic/core-team/Samual] has joined #wesnoth-dev 20140713 13:18:31-!- scimitar [~krishna@115.248.50.21] has quit [Ping timeout: 256 seconds] 20140713 13:21:07-!- cib0 [~cib@p5DD232A0.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140713 13:31:17< shadowm> Ivanovic: It seems I missed the email announcing a release was going to happen. 20140713 13:34:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140713 13:41:37-!- wesbot changed the topic of #wesnoth-dev to: released 1.11.16, announcing "soon" | string+feature freeze active on 1.12 | 237 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20140713 13:47:56-!- gfgtdf [~chatzilla@f054138165.adsl.alicedsl.de] has joined #wesnoth-dev 20140713 13:50:00< gfgtdf> RiftWalker: yes expand_mp_events is also called for sp, the reason is that we wanted that these events (that are inside [era] or [modification] ) still are present if a mp campaign was reloaded in sp and then advanced to the next scenario. 20140713 13:51:38-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20140713 14:18:45-!- gfgtdf [~chatzilla@f054138165.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]] 20140713 14:19:35-!- kex_ [~kex@89.205.75.19] has quit [Read error: Connection reset by peer] 20140713 14:20:02-!- Kexoth [~kex@89.205.75.19] has joined #wesnoth-dev 20140713 14:43:37-!- irker798 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20140713 14:53:50-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20140713 15:22:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now] 20140713 15:49:58-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20140713 15:50:09< iceiceice> is it still possible to change release notes for 1.11.16? 20140713 15:50:17< iceiceice> i want to add a comment about this bug: https://gna.org/bugs/index.php?22251 20140713 15:51:40< iceiceice> hmm i guess it has not been emptied so i will edit away 20140713 15:54:20< mordante> iceiceice, 1.11.16 also hasn't been announced, I assume shadowm takes the latest RELEASE_NOTES 20140713 15:54:47< iceiceice> yeah if i remember right that's what happened for 1.11.15 20140713 15:59:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140713 16:04:36-!- Kexoth [~kex@89.205.75.19] has quit [Remote host closed the connection] 20140713 16:04:49-!- irker418 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20140713 16:04:49< irker418> wesnoth: Chris Beck wesnoth:1.12 f753a41220fb / src/multiplayer_wait.cpp: fixup some excessively verbose mp debug output http://git.io/_O6UyQ 20140713 16:04:49< irker418> wesnoth: Chris Beck wesnoth:1.12 da360c381739 / RELEASE_NOTES: update release notes (intended for 1.11.16 announcement) http://git.io/m9CG5Q 20140713 16:12:08-!- _8680_ [~8680@2002:4404:712c:0:34b2:8d4e:6de3:494f] has quit [Ping timeout: 260 seconds] 20140713 16:12:54-!- _8680_ [~8680@2002:4404:712c:0:701f:7759:ee8f:d2b8] has joined #wesnoth-dev 20140713 16:15:29< irker418> wesnoth: Chris Beck wesnoth:1.12 28c49b2653b8 / RELEASE_NOTES: update release notes to mention bug 21397 http://git.io/QxFoCQ 20140713 16:22:02< shadowm> So I guess I'll write the announcement. 20140713 16:23:07< vultraz> You will write announcements...forever! 20140713 16:23:30< shadowm> I remember saying before that 1.11.15's was the last one I'd write but it seems nobody else volunteered to take over since then. 20140713 16:24:19-!- mjs-de [~mjs-de@p508C8EE3.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140713 16:24:58< irker418> wesnoth: Chris Beck wesnoth:1.12 f5723cce9ce4 / RELEASE_NOTES: update RELEASE_NOTES (intended for 1.11.16 announcement) http://git.io/hz6dyw 20140713 16:25:54< iceiceice> ok i dont know if theres any thing else worht mentioning, 20140713 16:26:01< iceiceice> maybe can mention some of the fixes fo rhte new minimap? 20140713 16:26:09< iceiceice> "all the buttons should now work, and it doesn't show invisible overlays" 20140713 16:34:26< mordante> shadowm, didn't read that it was the last one you wrote, so I assumed you would do it again 20140713 16:36:29< irker418> wesnoth: Chris Beck wesnoth:1.12 f856b23bce93 / RELEASE_NOTES: update RELEASE_NOTES with minimap related comments http://git.io/zyWywA 20140713 16:36:31< irker418> wesnoth: Chris Beck wesnoth:1.12 c30299724eca / RELEASE_NOTES: fixed typo Groove -> Grove in the section about mushroom grove http://git.io/9XNLaQ 20140713 16:36:33< irker418> wesnoth: Chris Beck wesnoth:1.12 d9cca934e581 / RELEASE_NOTES: change title of the [filter_vision], [has_ally/enemy] section http://git.io/1JkTjg 20140713 16:41:28< irker418> wesnoth: Chris Beck wesnoth:1.12 791b403699d4 / RELEASE_NOTES: update RELEASE_NOTES, abt compat. breaking / nonbreaking changes http://git.io/wUnqjA 20140713 16:48:50-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has joined #wesnoth-dev 20140713 16:54:01< irker418> wesnoth: Chris Beck wesnoth:1.12 8e4762b54d3c / RELEASE_NOTES: update RELEASE_NOTES: add some content and fixup section abt LoW http://git.io/S8UcAw 20140713 16:56:20< irker418> wesnoth: Chris Beck wesnoth:1.12 eed09f819b1a / RELEASE_NOTES: update RELEASE_NOTES: fixup typo in LoW known bugs section http://git.io/KfqlPQ 20140713 16:56:57-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140713 16:58:15< iceiceice> does anyone know what the status is with the issue reported here? i think i don't fully understand from the thread, 20140713 16:58:16< iceiceice> http://forums.wesnoth.org/viewtopic.php?f=4&t=40715 20140713 16:58:39< iceiceice> is this a translatable strings mistake in LoW? 20140713 16:59:01< iceiceice> should it be listed as a "known bug" ? 20140713 17:00:47-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev 20140713 17:00:52-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host] 20140713 17:00:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140713 17:17:51< zookeeper> iceiceice, yes it's a bug with the strings 20140713 17:19:26< shadowm> iceiceice: Re I'm curious which sounds are affected. It's obviously not the most intuitive option in Preferences and that is a rather important bug AFAIAC. 20140713 17:20:35-!- gfgtdf [~chatzilla@f054138165.adsl.alicedsl.de] has joined #wesnoth-dev 20140713 17:20:38< shadowm> Because every case of UI obtuseness counts as a bug AFAIAC. 20140713 17:21:23< iceiceice> shadowm: you can grep for "lobby_sounds()", it is only checked in one place, in src/lobby_main.cpp 20140713 17:22:06< iceiceice> i set a breakpoint right on the switch statement and did a local networking game with the advanced setting off, 20140713 17:22:12< iceiceice> it never triggered it so i guess the setting itself is working 20140713 17:22:16< iceiceice> but i did get lots of other sounds 20140713 17:22:25< shadowm> That's not the default lobby, that's the GUI2 lobby. 20140713 17:22:32< iceiceice> oh 20140713 17:22:40< shadowm> The situation is even worse then. :p 20140713 17:22:57< iceiceice> i thought all the gui2 stuff is in gui/ ? 20140713 17:23:04< iceiceice> i guess im confused 20140713 17:23:08< shadowm> Yes, and so is the single relevant match I get. 20140713 17:23:54< iceiceice> hmm maybe we should mark the prefernce as "only affects experimental gui 2 lobby" 20140713 17:25:27< iceiceice> wait so where is the current lobby main? 20140713 17:25:34< shadowm> That's an option (though it can't be backported until 1.12.0 is released, and the mention of "GUI2" should be left out) -- another option is to just adjust the old lobby accordingly. 20140713 17:25:52< iceiceice> is gui/dialogs/lobby_main.cpp the currently active lobby? 20140713 17:26:03< shadowm> No, that's the GUI2 lobby. 20140713 17:26:12< iceiceice> oh wait im confused 20140713 17:26:15< iceiceice> ok now i see 20140713 17:26:22< iceiceice> for some reason i thought src/lobby_main.cpp was a file 20140713 17:26:32< shadowm> The default lobby is spread out across several src/multiplayer* files. 20140713 17:32:04< iceiceice> i think all of the sounds are in src/multiplayer_ui.cpp though, at least it seems 20140713 17:32:54-!- gfgtdf [~chatzilla@f054138165.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]] 20140713 17:36:00< iceiceice> shadowm: this appears to fix it 20140713 17:36:01< iceiceice> https://github.com/wesnoth/wesnoth/pull/248 20140713 17:37:08< shadowm> src/multiplayer_connect.cpp:563: sound::play_UI_sound(game_config::sounds::party_full_bell); 20140713 17:37:12< shadowm> src/multiplayer_wait.cpp:435: sound::play_UI_sound(game_config::sounds::mp_game_begins); 20140713 17:37:18< shadowm> These two seem relevant. 20140713 17:37:20< iceiceice> yeah so idk if those count as lobby sounds though 20140713 17:37:26< iceiceice> because they are only when you are in the "wait" screen 20140713 17:37:30< iceiceice> or the connect screen 20140713 17:38:02< iceiceice> hmm, maybe the multiplayer_ui object should do a self check to see if it is in lobby mode also when checking the prefernece 20140713 17:38:16< iceiceice> i think these sounds are not nearly so annoying when you are in a game 20140713 17:40:25< mordante> I'm off bye 20140713 17:40:31< shadowm> I personally don't see why anyone with the option to use sounds would disable all these sounds instead of just the annoying join/leave notifications. 20140713 17:40:49-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20140713 17:41:06< shadowm> I mean, receiving a whisper should be pretty important, shouldn't it? 20140713 17:41:24< iceiceice> yeah 20140713 17:43:00< shadowm> Maybe later on we could turn it into a combobox-type option with three states (all enabled, only whispers/highlights, all disabled). 20140713 17:47:28< iceiceice> yeah that would be a good thing 20140713 17:47:39< iceiceice> its pretty annoying to make it work only for the lobby right now... 20140713 17:47:58< iceiceice> i guess that the lobby actually is the base class from which all of configure, connect, create, wait are derived :/ 20140713 17:48:39< iceiceice> hmm wait it hink i'm wrong actually 20140713 17:59:46< iceiceice> ok, i think this probably does the right thing: https://github.com/wesnoth/wesnoth/pull/248 20140713 18:01:11< iceiceice> hmm 20140713 18:01:16< iceiceice> maybe the first part shouldn't be there though 20140713 18:03:53< shadowm> Surely the change to mushroom terrain stat handling counts as a MP-incompatible thing? 20140713 18:07:18< iceiceice> hmm i didnt think about that 20140713 18:07:27< iceiceice> i guess it will change the outcome of replays? 20140713 18:07:59-!- gfgtdf [~chatzilla@f054138165.adsl.alicedsl.de] has joined #wesnoth-dev 20140713 18:09:20< shadowm> That's what I wonder. I guess I'll opt to disallow 1.11.15 clients anyway. 20140713 18:11:48< irker418> wesnoth: Chris Beck wesnoth:1.12 a2939acb46fa / RELEASE_NOTES: update RELEASE_NOTES, with remark about lobby sounds preference http://git.io/AcG43w 20140713 18:12:54< irker418> wesnoth: Chris Beck wesnoth:1.12 0c2454427750 / RELEASE_NOTES: update RELEASE_NOTES, fix a typo introduced in previous commit http://git.io/an7b4g 20140713 18:15:37< shadowm> > Mushroom Groove 20140713 18:16:11< shadowm> Kudos to whoever tried (most likely unintentionally, I'm sure) to get this past my review. 20140713 18:16:30< zookeeper> do you really have to fix it? 20140713 18:22:00< irker418> wesnoth: Chris Beck wesnoth:1.12 d54aec880a1b / RELEASE_NOTES: update RELEASE_NOTES: clarify the problem with map labels http://git.io/aoLOhQ 20140713 18:23:03-!- cib_ [~cib@p5DC74DA7.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140713 18:23:12-!- cib0 [~cib@p5DD232A0.dip0.t-ipconnect.de] has quit [Disconnected by services] 20140713 18:23:56< shadowm> "Note that you must refresh your save_index to get proper behavior, by deleting it from the userdata folder." Surely new saves will be unaffected by the bug anyway? 20140713 18:24:48< shadowm> I'd rather avoid mentioning save_index if at all possible since it's the source of all kinds of misbehavior and bad engineering decisions. 20140713 18:28:42< shadowm> "[has_unit]" -> "[have_unit]", hopefully? 20140713 18:31:29< shadowm> Is the change of behavior documented in the wiki? 20140713 18:32:00< shadowm> I'm curious what the previous behavior was, actually. 20140713 18:32:20< iceiceice> shadowm: regarding save_index, yeah the new saves will be unaffected but if you want the old ones to work (to confirm the bug is fixed) also then you should delete the file 20140713 18:32:40< iceiceice> shadowm: regarding "has_unit", from source inspection it appears the tag, in a SSF, is [has_unit] 20140713 18:33:21< shadowm> Oh, the SSF subtag, not the conditional statement. 20140713 18:33:37< iceiceice> yes. perhaps the writing is unclear 20140713 18:34:03< iceiceice> i did add remarks to the wiki 20140713 18:34:03< shadowm> Throughout this block there are also mentions of "unit filter", "location filter", and "terrain_filter". I assume those are SUF, SLF, and SLF, respectively? 20140713 18:34:13< iceiceice> yes 20140713 18:34:25< shadowm> The wiki doesn't really mention what changed. 20140713 18:34:48< iceiceice> hmm... one sec 20140713 18:35:28< iceiceice> so there was a 1.11.16+ specific subsection added here: http://wiki.wesnoth.org/FilterWML#Filtering_Vision 20140713 18:36:25< iceiceice> i guess i need to update the SUF and SLF pages though 20140713 18:36:47< iceiceice> i added [has_ally] and [has_enemy] here: http://wiki.wesnoth.org/StandardSideFilter 20140713 18:37:27< shadowm> So the change is just changing the requirement for all sides to match to just one side? 20140713 18:41:15< iceiceice> the change also has to dow ith, what if there are no sides matching 20140713 18:41:17-!- cib0 [~cib@p508BC6E3.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140713 18:41:36< iceiceice> if there are no sides matching, then if it was an SUF it would fail to match, and in an SLF it would match 20140713 18:42:39-!- cib_ [~cib@p5DC74DA7.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 20140713 18:43:02< iceiceice> *no sides which match the filter at all 20140713 18:43:14< iceiceice> ** regardless of their vision of the location / unit 20140713 18:43:25< shadowm> Okay, so in other words, none of this code needs to be changed for 1.11.16? http://pastebin.com/AS5Gcbcj 20140713 18:43:55< iceiceice> thats correct 20140713 18:44:30< shadowm> episode2/scenarios/01_By_the_Moonlight.cfg:188 being part of a [have_unit] SUF. 20140713 18:44:55< shadowm> UNIT_VISIBLE_FOR_SIDE is also ever used only for [have_unit] SUFs. 20140713 18:51:47< iceiceice> in all your examples with the filter is side=1, (assuming that side 1 exists) there should be no change in behavior 20140713 18:52:30< iceiceice> for [filter_vision] in a SUF the only change occurred when there is more than one side matching the filter 20140713 18:52:55< iceiceice> for [filter_vision] in a SLF, the behavior changed for that case and also when there is no side matching the filter 20140713 18:54:00< shadowm> So... the behavior of [allied_with] and [enemy_of] remains unchanged? 20140713 18:54:17< iceiceice> yes 20140713 18:54:33< shadowm> Also uh, why would side 1 not exist, that doesn't even make sense. 20140713 18:55:33< iceiceice> i'm not sure, is it actually possible? 20140713 18:55:43< iceiceice> what happens if you label all the sides with hgiher numbers 20140713 18:56:01< iceiceice> anyways for your first one with the macro argument I guess that the side might not exist 20140713 18:56:04< shadowm> I hope the game goes back to the titlescreen. 20140713 18:56:22< iceiceice> i'm pretty sure the mp server would be unhappy if there were no side 1 but i have never tested it 20140713 18:56:32< shadowm> Because last time I checked, all sides were stored in a vector where each side's side - 1 was the position in the vector. 20140713 18:56:35-!- Kexoth [~kex@95.180.213.88] has joined #wesnoth-dev 20140713 18:57:00< iceiceice> yeah thats true 20140713 18:59:22< iceiceice> i mean its possible you will just have some dead space in that vector 20140713 18:59:34< iceiceice> but i wonder also if the game uses teams.size() to count the number of players... 20140713 18:59:41< iceiceice> i think that's pretty likely 20140713 19:01:39< irker418> wesnoth: Chris Beck wesnoth:1.12 d73fc9a9b628 / RELEASE_NOTES: update RELEASE_NOTES with remarks about hotkey bugs http://git.io/W9Tyaw 20140713 19:36:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140713 19:37:08-!- gfgtdf [~chatzilla@f054138165.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds] 20140713 19:46:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140713 19:50:19-!- thunderstruck [~zaibotren@86.6.42.151] has quit [Quit: leaving] 20140713 19:54:32-!- gfgtdf [~chatzilla@f054138165.adsl.alicedsl.de] has joined #wesnoth-dev 20140713 20:00:00-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Quit: Though to our health we drank a thousand times, it's time to ramble on.] 20140713 20:00:08-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20140713 20:02:45-!- Kexoth [~kex@95.180.213.88] has quit [Remote host closed the connection] 20140713 20:03:22-!- Kexoth [~kex@95.180.213.88] has joined #wesnoth-dev 20140713 20:07:38-!- Kexoth [~kex@95.180.213.88] has quit [Ping timeout: 240 seconds] 20140713 20:18:35-!- gfgtdf [~chatzilla@f054138165.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds] 20140713 20:44:47-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20140713 20:50:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140713 21:19:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20140713 21:20:33< shadowm> mordante: Your commits on GitHub aren't linked to your account, so it seems you are using an email address you haven't added and/or verified in your account settings. 20140713 21:24:08< shadowm> > [section="Fixed bug [bug]21397[/bug]: Saving and Loading may cause a Side's turn is not initialized"] 20140713 21:24:44< shadowm> Lines like this (whoever added it) would be pretty bad if I just took the contents here and included them in the announcement as they are. 20140713 21:26:17< shadowm> And I don't mean it just because that [bug] would result in an -within-an- when converting [section=] with [rasection=]. 20140713 21:26:21< shadowm> *replacing 20140713 21:48:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20140713 21:54:04-!- markus_ [~mjs-de@p508C8784.dip0.t-ipconnect.de] has joined #wesnoth-dev 20140713 21:57:03-!- mjs-de [~mjs-de@p508C8EE3.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 20140713 22:27:58-!- trewe [~trewe@107.11.54.77.rev.vodafone.pt] has joined #wesnoth-dev 20140713 22:29:12< shadowm> thunderstruck: I believe you missed doing this: http://wiki.wesnoth.org/index.php?title=SideWML&diff=55340&oldid=55290 20140713 22:41:05-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20140713 22:44:08< irker418> wesnoth: Chris Beck wesnoth:1.12 c5995890df5a / RELEASE_NOTES: update RELEASE_NOTES: fixup [bug][/bug] inside [section] http://git.io/2PyoUA 20140713 22:44:10< iceiceice> shadowm: ^ 20140713 22:45:14< shadowm> "The wmllint gui should now come packaged with 1.12 series releases." 20140713 22:45:39< shadowm> This isn't an acceptable entry. Needs some elaboration and the time I can spend researching every entry is already limited as-is. 20140713 22:45:53< shadowm> iceiceice: There was no need to do that since I completely rewrite the thing in my draft anyway. 20140713 22:46:19< iceiceice> ok, i wasnt sure if you did that already or not 20140713 22:46:42< shadowm> For whoever added the wmllint GUI entry: What does this mean to the average UMC maintainer who can't operate a shell to save their own life? 20140713 22:46:44< iceiceice> vultraz: can you write a reasonable announcement for the wmllint gui? I actually know basically nothing abou tit 20140713 22:46:54< iceiceice> i put in like a placeholder since i saw it in the changelog 20140713 22:48:12< shadowm> What about people on operating systems where Python isn't installed by default? (Like Windows. (Maybe OS X too? I'm under the impression OS X comes with stuff like this ready to use out of the box, but still.)) 20140713 22:49:39< shadowm> So to sum it up: What is it? Who should use it and why? Where is it? How should they use it? 20140713 22:50:06< shadowm> Four simple questions that Average Joe needs answered. 20140713 22:51:30< shadowm> Also, "backported from master" isn't a thing Average Joe needs to know or understands, at this time. 20140713 22:52:13-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20140713 22:54:00< shadowm> Is it data/tools/GUI.pyw, really? And I thought I was bad at names. 20140713 22:56:09-!- markus_ [~mjs-de@p508C8784.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20140713 22:59:21-!- cib0 [~cib@p508BC6E3.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 20140713 23:00:02< shadowm> wesbot: seen fabi 20140713 23:00:02< wesbot> shadowm: The person with the nick fabi last spoke 33d 7h ago. 32d 20h ago was here and on the channels #wesnoth, #wesnoth-de and #wesnoth-umc-dev with the message: Ping timeout: 240 seconds 20140713 23:00:49< shadowm> Nothing to say about that, I hope he's all right. 20140713 23:16:24< shadowm> Coffee_irc: Whether a bug is a blocker or not is a technicality that doesn't belong in R_N. 20140713 23:18:29< iceiceice> wesbot: seen jamit 20140713 23:18:29< wesbot> iceiceice: The person with the nick jamit 24d 18h ago they left with the message: Client Quit 20140713 23:22:09-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20140713 23:22:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20140713 23:27:36< shadowm> iceiceice: Do you know if we want to keep the save_index functionality? (Someone was messing with the savegame code recently, I don't remember who it was but you probably know anyway.) I'm asking so I can make room for an option to purge it in Preferences -> General -> Cache. 20140713 23:30:22-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!] 20140713 23:32:36-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20140713 23:32:44< shadowm> Since I keep being interrupted... Here's the preliminary draft of the announcement: 20140713 23:33:09< shadowm> It's a draft of a draft. It's not for you to edit yet, but if you find something wrong with it you can tell me here. 20140713 23:34:33< shadowm> For example, Known Issues is completely missing for that reason. 20140713 23:37:37< shadowm> "Start of scenario saves have some known bugs, they can't be loaded correctly and they don't get minimaps in the preview pane. (The preview part of this is by design however, the map is not known for a start of scenario save at the time of the load dialog and it cannot be previewed.)" 20140713 23:38:17< shadowm> Not a complaint, but surely we could record whatever [scenario] map_data has into the start-of-scenario save at the time it's generated, and ignore it for any purposes other than save game previews? 20140713 23:39:20< shadowm> Waaaaaaaait. 20140713 23:40:16< shadowm> If this known issue is really the case, then how come there are several scenarios in my campaign where I specifically make sure to have side 1 start with shroud that's unset on prestart purportedly so that the start-of-scenario save doesn't have a map preview? 20140713 23:41:30< shadowm> Also, what does "can't be loaded correctly" entail? Does that refer to the minimap issue too, or something else? Because start-of-scenario saves being broken would be pretty much a catastrophe. 20140713 23:43:26< shadowm> (Are we talking MP or SP, by the way? That might make a difference too.) --- Log closed Mon Jul 14 00:00:50 2014