--- Log opened Sun Jul 20 00:00:55 2014
20140720 00:12:13< iceiceice> when you say binary changes, what do you mean, like the executable or the images
20140720 00:12:27< ancestral> Yes
20140720 00:12:57< ancestral> Executable, images, music, translation files
20140720 00:13:41< gfgtdf> iceiceice: i think 30c179b92da29bb03541e8e0c7dfaf1c3c401b35 broke alignment
20140720 00:13:44< iceiceice> so i remember there was some issue where the images were being translated strangely on the mac problem
20140720 00:13:50< iceiceice> *on macs 
20140720 00:13:57< iceiceice> the profile images turned up with a blue tint
20140720 00:14:01< iceiceice> but that might be from before 1.11.15
20140720 00:14:01< ancestral> Odd
20140720 00:14:29< gfgtdf> iceiceice: becasue we now apply cfg["alignment"] before advance_to which migth result in aligment_ beeing ivwewritten by the unti type
20140720 00:14:33< ancestral> Anyway, I threw together an updater on the Mac. I want to take a stab at Windows now.
20140720 00:14:35< iceiceice> gfgtdf: thats only on master though
20140720 00:14:48< gfgtdf> iceiceice: ye i know
20140720 00:15:00< gfgtdf> iceiceice: but i usualy use master for playing play on master
20140720 00:15:04< ancestral> (Right now it’s just a standalone shell file that runs and does things)
20140720 00:15:29< iceiceice> gfgtdf: wait so you aren't talking about ancestral's issue?
20140720 00:15:35-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20140720 00:15:36< iceiceice> i think i misunderstood you
20140720 00:15:49< gfgtdf> no i was talking about 30c179b92da29bb03541
20140720 00:16:18< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/commit/30c179b92da29bb03541e8e0c7dfaf1c3c401b35#diff-af3fd7e884f8ab9f39f9088ca4010d0dR232
20140720 00:16:32< iceiceice> hehe i thought you meant that some change in alignment of structs caused a massive change in the binary size 
20140720 00:16:56< gfgtdf> ah no
20140720 00:18:40< ancestral> 1.11.15 > 1.11.16 is a 27.8 MB update. 1.10.6 > 1.10.7 is 59.5 MB. 1.10.7 > 1.11.16 is a whopping 264.8 MB (which is still about 31% smaller)
20140720 00:19:53< iceiceice> ancestral: there is a ton of new art in 1.11
20140720 00:20:07< ancestral> That would do it
20140720 00:20:19< iceiceice> new sprites, many new portriats
20140720 00:20:54< ancestral> Yeah campaign art
20140720 00:23:15< iceiceice> ancestral: i had an idea a while ago that, it might be nice if we had like an updater that wrapped git
20140720 00:23:29< iceiceice> since there was that whole thread about, how can people beta test easily
20140720 00:23:37< ancestral> Well
20140720 00:23:50< ancestral> You might want a separate repo then
20140720 00:23:59< ancestral> :-\
20140720 00:24:09< ancestral> iceiceice: What thread?
20140720 00:24:45< iceiceice> really long thread here: http://forums.wesnoth.org/viewtopic.php?f=5&t=40551
20140720 00:25:32< ancestral> Then my updater would be the perfect answer
20140720 00:25:45< iceiceice> how does your updater work?
20140720 00:26:08< ancestral> A .diff file, the binary files that changed, and a shell script that patches them together
20140720 00:26:30< iceiceice> hehe, so its like a mini versino of git/
20140720 00:26:36< ancestral> Sorta
20140720 00:26:38< iceiceice> where does it get the updates from? does it go from the repo?
20140720 00:26:54< ancestral> That might be possible, but no
20140720 00:27:07< ancestral> The plan is to serve up the updates up like a regular download
20140720 00:27:16< ancestral> *serve the updates like
20140720 00:27:39< iceiceice> i see
20140720 00:27:51< iceiceice> so my thoughts that i had briefly were like, 
20140720 00:28:04< ancestral> iceiceice: http://wesnoth.io/version/dev
20140720 00:28:04< iceiceice> (1) take elvish_hunter's gui that goes over wml lint, written in python i guess,
20140720 00:28:19< iceiceice> (2) hack it up, so instead it is a window, with a drop down menu "branch"
20140720 00:28:29< iceiceice> and you select "1.12, master, 1.10"...
20140720 00:28:45< iceiceice> and it manages the git commands to fetch and checkout
20140720 00:28:56< iceiceice> they would have to figure out how to compile on their own
20140720 00:29:25< iceiceice> or i guess it could assume they got scons working, we have detailed info for doing that on windows now, and it should work easily on linux...
20140720 00:29:34< iceiceice> oh, you also should know that, 
20140720 00:29:38< ancestral> That might work well on Linux
20140720 00:29:41< iceiceice> we do currenly have something called "Xdelta"
20140720 00:29:48< ancestral> But no mere mortal should be building in Xcode
20140720 00:29:49< iceiceice> which patches the binary without using git
20140720 00:30:14< iceiceice> http://forums.wesnoth.org/viewtopic.php?f=5&t=40745
20140720 00:30:51< ancestral> Xdelta is fine in Linux, if you’re building
20140720 00:31:09< iceiceice> hmm i think Xdelta doesn't require you to build
20140720 00:31:13< iceiceice> but i never used it, i dont really know
20140720 00:31:24< ancestral> What happens if binary files change?
20140720 00:31:42< iceiceice> xdelta includes the diff of the compiled file
20140720 00:32:18< ancestral> diffs typocally dont do binary files
20140720 00:33:19< iceiceice> idk, i am just reading the wiki page for xdelta
20140720 00:33:31< iceiceice> it says it is targetted at the binary files
20140720 00:35:15< ancestral> My understanding is binary files are different for each platform
20140720 00:35:32< ancestral> er, operating system
20140720 00:35:45< ancestral> Not all Linuxes are equal
20140720 00:36:20-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has joined #wesnoth-dev
20140720 00:36:40< iceiceice> im going to have a look at what exactly we have on the xdelta link on the forums
20140720 00:37:23< iceiceice> ok i just crashed gedit lol
20140720 00:38:03< ancestral> iceiceice: So actually what I have is just a release updater
20140720 00:38:47< ancestral> But if someone were to produce nightlies for OS X and Windows that would help
20140720 00:39:56< iceiceice> i think we do currently produce nightlies for windows, on jenkins...
20140720 00:40:07< iceiceice> idk what the exact link is, its somewhere in here; http://baldras.wesnoth.org:8080/
20140720 00:40:19< ancestral> Well great
20140720 00:40:36< ancestral> I mean, sure, it’s gonna be a large download, I suppose
20140720 00:41:06< ancestral> Only Debian and Gentoo
20140720 00:41:52< iceiceice> theres a cross compile for windows also in there it hink
20140720 00:42:27< ancestral> http://baldras.wesnoth.org:8080/job/Wesnoth/
20140720 00:42:54< irker595> wesnoth: Chris Beck wesnoth:master 051368f12307 / src/desktop/dbus_notification.cpp: fixup a warning being treated as error on jenkins http://git.io/MI-l6Q
20140720 00:42:56< irker595> wesnoth: Chris Beck wesnoth:master d5bf89b49500 / RELEASE_NOTES: Merge branch 'master' of git://github.com/wesnoth/wesnoth http://git.io/jJ85Zw
20140720 00:43:02< ancestral> I don’t see it
20140720 00:44:15< iceiceice> i think the "mingw-32" build is actually a windows build
20140720 00:44:53< ancestral> Mayve you’re right
20140720 00:45:42< ancestral> So if it were me, I’d do two things
20140720 00:45:45< iceiceice> you can see at the end, there is some file "wesnoth.exe" that it copies to some folder named "export/..."
20140720 00:45:46< iceiceice> http://baldras.wesnoth.org:8080/job/Wesnoth/branch=1.12,compiler=mingw32,label=Debian7-32/216/consoleText
20140720 00:45:50< iceiceice> but i dont know what the url for that file is
20140720 00:46:06< ancestral> 1. Have “nightlies” or simply link to these automatic builds
20140720 00:46:23< ancestral> 2. And create a repo with the “nightlies” in them
20140720 00:46:56< iceiceice> is there any way to cross compile for OSX ?
20140720 00:47:25< ancestral> Outside of Xcode? Possibly.
20140720 00:47:57< iceiceice> http://stackoverflow.com/questions/693952/how-to-compile-for-os-x-in-linux-or-windows
20140720 00:48:26< ancestral> Yeah looks like it’s possibl
20140720 00:48:37< iceiceice> i wonder if this works for wesnoth? http://www.macports.org/
20140720 00:48:40< ancestral> Nah nah
20140720 00:48:51< ancestral> That’s just for downloading UNIX libraries
20140720 00:48:54< ancestral> like Homebrew
20140720 00:49:03< ancestral> You want something like Jenkins CI
20140720 00:49:04< ancestral> http://momo.brauchtman.net/2011/11/12/howto-install-jenkins-on-os-x-and-make-it-build-mac-stuff/
20140720 00:49:38< ancestral> Or, that is Jenkins
20140720 00:51:39< gfgtdf> iceiceice: will you fix the unit aligment issue ?
20140720 00:51:44< iceiceice> i dont understand it yet
20140720 00:51:47< iceiceice> i will look into it
20140720 00:52:09< iceiceice> ancestral: we have jenkins-CI
20140720 00:52:19< iceiceice> that was the baldras.wesnoth.org:8080 link i sent
20140720 00:52:42< ancestral> Right
20140720 00:53:43< ancestral> iceiceice: You still need a Mac here to compile for OS X
20140720 00:54:12< iceiceice> why can't we cross compile?
20140720 00:54:33< ancestral> I think you still need Xcode
20140720 00:54:43< iceiceice> why?
20140720 00:54:45< ancestral> I’ll defer to mattsc and others though
20140720 00:55:02-!- prkc [~prkc@54028625.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20140720 00:55:09< iceiceice> i dont think we should buy a mac server just to support mac osx nightlies
20140720 00:55:20< ancestral> I didn’t say that
20140720 00:55:31< iceiceice> i know, i'm just saying
20140720 00:55:44< iceiceice> there should be a way to cross compile for OSX imo, we can do that for windows just fine
20140720 00:56:01< iceiceice> if there isnt its just going to be very hard to distribute afaik
20140720 00:56:20< ancestral> http://wiki.wesnoth.org/CompilingWesnothOnMacOSX
20140720 00:56:27< ancestral> Well, maybe so
20140720 00:56:40< ancestral> Not sure how up-to-date that page is
20140720 00:56:44< ancestral> I’ll give it a shot
20140720 00:58:13< ancestral> Yeah this page is super old
20140720 01:02:11< iceiceice> gfgtdf: are you sure that i actually broke anything?
20140720 01:02:21< iceiceice> i didnt see that units can be advanced before the constructor is finished.
20140720 01:05:15< iceiceice> ok i think is ee now
20140720 01:06:05< iceiceice> why is that just in the middle of the constructor, that's pretty bizarre
20140720 01:06:12< iceiceice> shouldnt it be at the beginning or the end?
20140720 01:06:44< ancestral> iceiceice: Are there four computers, or just four VMs?
20140720 01:06:52< ancestral> (http://baldras.wesnoth.org:8080/computer/)
20140720 01:06:56< iceiceice> ancestral: i'm pretty sure its 4 VMs
20140720 01:07:00< ancestral> Right
20140720 01:07:02< iceiceice> i dont actually have access to baldras so i couldnt tell you
20140720 01:07:45-!- gfgtdf [~chatzilla@f054128092.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140720 01:08:51-!- markus__ [~mjs-de@f048038223.adsl.alicedsl.de] has joined #wesnoth-dev
20140720 01:12:24-!- markus_ [~mjs-de@f048041031.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds]
20140720 01:13:49-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has left #wesnoth-dev []
20140720 01:15:47-!- Laundry [47a6227a@gateway/web/freenode/ip.71.166.34.122] has joined #wesnoth-dev
20140720 01:20:51-!- ryao [user75695@gentoo/developer/ryao] has joined #wesnoth-dev
20140720 01:21:34< ryao> Who authorized this for-profit port and who changed the license under something app store compatible? https://itunes.apple.com/us/app/battle-for-wesnoth-hd/id575852062?mt=8
20140720 01:21:51< ryao> s/under/to/
20140720 01:23:14< ancestral> ryao: Yeah, Wesnoth’s license hasn’t changed, it’s GPL
20140720 01:23:39-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140720 01:27:01< ryao> ancestral: I have a few patches in Wesnoth. I guess that I could try complaining to Apple based on that, but the LoC that I contributed is miniscule. I am a little offended that someone walked over the license to profit from the community's work. I would be less annoyed if it was free for all...
20140720 01:27:26-!- Duthlet_ [~Duthlet@p4FF8E5B9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140720 01:27:31< ancestral> ryao: You have one thing right and one thing wrong
20140720 01:27:39< ryao> ancestral: What?
20140720 01:27:47< ancestral> No one is stopping anyone from building Wesnoth and charging for it
20140720 01:28:08< ryao> ancestral: The GPL does not permit its sake in the App Store.
20140720 01:28:12< ancestral> You can download Wesnoth and charge for it as long as you abide by the GPL
20140720 01:28:19< ancestral> That’s the part you have right
20140720 01:28:19< ryao> s/sake/sale/
20140720 01:28:30< ryao> ancestral: Hence why I am annoyed.
20140720 01:29:37< ryao> They are making money by violating the license. If they were selling it in the Android store, it would likely be okay.
20140720 01:29:39< ancestral> If you’re annoyed solely because people are profiting from the distribution of the game, then you should be annoyed with the GPL
20140720 01:30:09-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Ping timeout: 240 seconds]
20140720 01:30:23< ancestral> The GPL does allow paid distribution. It just has some restrictions, and prevents others from applying incompatible restirctions
20140720 01:30:38< ryao> ancestral: I think you misunderstand. I am annoyed that they are violating the licensing to make a profit. I do not mind that they are making a profit.
20140720 01:30:50< ryao> Just how they are doing it.
20140720 01:30:53< iceiceice> ryao: there was a dev-list email thread about this years ago
20140720 01:31:09< ryao> If the App store terms were fixed, I would not care.
20140720 01:31:42< ryao> I would care if Apple refused to let anyone else publish the game though...
20140720 01:32:29< ryao> If the license went BSD, I would be okay with this. I am soloely annoyed by the lack of resoect for license terms.
20140720 01:32:54< ryao> Well, that and they are making money as a result of violating the lidense terms.
20140720 01:33:29< ryao> If there were no violation, I would not feel annoyed. Does no one else feel this way?
20140720 01:33:52< ryao> s/resoect/respect/
20140720 01:33:56< ryao> Tablet typos.
20140720 01:34:32< ryao> By the way, are the art asseets under a license that allows commercial reuse?
20140720 01:35:06< ryao> I could check, but I am on a tablet at the moment.
20140720 01:35:15< ancestral> Art assets along with all content are GPL
20140720 01:36:00< iceiceice> ryao: not to speak for anyone else in the channel, but i dont think anyone has much appetite to relitigate a 4 year old argument
20140720 01:36:09< iceiceice> you should read this thread in detail: https://mail.gna.org/public/wesnoth-dev/2010-07/msg00008.html
20140720 01:38:01< iceiceice> hmm the mail thing got confused to find links to subsequent messages, but anyways click back up to the index
20140720 01:38:56-!- Duthlet_ [~Duthlet@p4FF8E5B9.dip0.t-ipconnect.de] has quit [Quit: leaving]
20140720 01:40:44< ryao> VLC was pulled from the app store after Apple legal received a letter saying it was a GPL violation. The same could be done here. It is easy. I am just surorised no one has done anything.
20140720 01:40:55-!- Laundry [47a6227a@gateway/web/freenode/ip.71.166.34.122] has quit [Ping timeout: 246 seconds]
20140720 01:41:07< ryao> s/surorised/surprised/
20140720 01:41:37-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 243 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140720 01:41:56< ryao> I would have no problem with this if the project license were changed with the consent of all contributors. I am one of them. My old handle is srk9.
20140720 01:43:10< ryao> I would even sign off on a change if asked. I just feel that it is wrong to disobey the license for money.
20140720 01:44:55< ryao> Anyway, thanks for letting me know where things stand.
20140720 01:45:06< ancestral> ryao: No problem
20140720 01:48:53< iceiceice> ryao: i dont think its possible to relicense
20140720 01:49:24< iceiceice> considering the number of contributors and artists from years ago, that probably we wouldnt be able to contact again
20140720 01:50:06< iceiceice> as I understand, BfW project is not legally the copyright holder, the contributors themselves are.
20140720 01:50:15< bumbadadabum> ^
20140720 01:50:16< bumbadadabum> this
20140720 01:50:31< bumbadadabum> also why the licence can't really be changed
20140720 01:50:54< bumbadadabum> unless you check EVERY LINE of code
20140720 01:51:12< bumbadadabum> and if 1 person says no, rewrite everything he's done
20140720 01:52:12< shadowm> That is our official port, and although it's not maintained by the Battle for Wesnoth Project, it's authorized and contributes financially to Wesnoth Inc.
20140720 01:55:38< iceiceice> gfgtdf: i tried moving that line back,
20140720 01:55:43< iceiceice> it causes a unit test to fail.
20140720 01:55:50< iceiceice> so i don't think that it should be moved
20140720 02:01:21< ryao> shadowm: Do you mean the one by din dai?
20140720 02:01:49< ryao> iceiceice: You can have the license changed if all of the contributors of current code and assets agree.
20140720 02:01:58< ryao> s/din dai/lin dai/
20140720 02:02:26< ancestral> Did Kyle’s port get removed?
20140720 02:02:38< ryao> ancestral: The port on the Apple App Store is by some Chinese guy.
20140720 02:02:48< ryao> Lin Dai. His name isn't Kyle.
20140720 02:02:48< ancestral> Yes, that’s the second port…
20140720 02:03:01< ancestral> Kyle Poole also made a version before that
20140720 02:03:11< ryao> Who is Lin Dai?
20140720 02:03:13< ancestral> But I’m surprised it’s removed from the store.
20140720 02:03:19< iceiceice> ryao: i don't want the license changed, i'm actually quite sympathetic to your complaints
20140720 02:03:20< ancestral> Sucks if you bought it and can’t re-download it now.
20140720 02:03:21< ryao> ancestral: Maybe Lin Dai asked for it to be removed.
20140720 02:03:29< iceiceice> but i'm not so sympathetic that i want to dig up old graves like this.
20140720 02:03:37< ancestral> ryao: He’s posted on the forums
20140720 02:03:55< iceiceice> i think you should read the entire email thread like i suggested, everything that rusty russell wrote, and all the parts about removing the code that he wrote and how that was recieved
20140720 02:04:07< iceiceice> it is very unproductive to discuss this on the irc channel imo
20140720 02:04:14< ryao> iceiceice: I just need to get Apple during business hours to file a complaint. That is all it takes.
20140720 02:04:22< ryao> I just called their technical support number to ask.
20140720 02:04:43< iceiceice> ryao: i don't think you are going to get more of a response by making threats.
20140720 02:04:54< ryao> From Apple?
20140720 02:04:56< iceiceice> if you want to discuss licensing issues, you should take a well thought out position and email the list.
20140720 02:04:58< iceiceice> no, from us.
20140720 02:05:15< ryao> iceiceice: How I am threatening you?
20140720 02:05:25< iceiceice> " I just need to get Apple during business hours to file a complaint. That is all it takes." <-- that is a threat.
20140720 02:05:58< ryao> iceiceice: I am confused. Some guy has GPL code in the App Store. All that is needed to get it removed is 1 guy calling Apple to inform them.
20140720 02:06:04< ryao> It doesn't even have to be a contributor.
20140720 02:06:38< ryao> I understand that Apple removes all GPL code from the App Store.
20140720 02:07:35< iceiceice> as i understand there are two different ports on the app store,
20140720 02:07:43< ryao> iceiceice: There is only 1 port.
20140720 02:07:46< iceiceice> there was one that stopped being maintained, and one that is maintained and officially sanctioned
20140720 02:07:53< iceiceice> i dont know what the current status is, or which is which
20140720 02:08:20< ryao> iceiceice: Is the project going to change its license or contact all contributors to request an exemption for this?
20140720 02:08:33< iceiceice> no.
20140720 02:08:42< iceiceice> it was discussed in great detail on the list.
20140720 02:09:23< ancestral> ryao: It looks like one of them was removed
20140720 02:09:40< ancestral> Don’t know why.
20140720 02:10:01< ryao> Apple has been cracking down on clones of apps... it might be that they decided that the other was illegitimate.
20140720 02:25:08-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20140720 02:28:57-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 255 seconds]
20140720 02:29:06-!- Ivanovic_ is now known as Ivanovic
20140720 02:37:42-!- gfgtdf [~chatzilla@f054128033.adsl.alicedsl.de] has joined #wesnoth-dev
20140720 02:37:52< gfgtdf> iceiceice; which unit test exactly ?
20140720 02:43:47< gfgtdf> iceiceice: 20140720 01:55:43< iceiceice> it causes a unit test to fail.
20140720 02:45:41< iceiceice> gfgtdf: i pushed a PR
20140720 02:45:49< iceiceice> it shodl have failed by now
20140720 02:47:20< Appleman1234> ryao, shadowm's summary is avaliable at http://shadowm.rewound.net/blog/archives/195-The-Fall-of-Wesnoth-for-iOS.html
20140720 02:47:34< gfgtdf> iceiceice: hm i see
20140720 02:48:04< gfgtdf> i think we have to wap that into a if(!cfg["alignment"].emtpy()) or something
20140720 02:49:36< gfgtdf> iceiceice: or : 'alignment_ = lexical_cast_default<unit_type::ALIGNMENT> (cfg["alignment"].str(), alignment_);'
20140720 02:50:04< Appleman1234> ryao, forum topic for kp port is http://forums.wesnoth.org/viewtopic.php?f=6&t=27872, for lindai port is http://forum.wesnoth.org/viewtopic.php?f=6&t=37879
20140720 02:50:57< iceiceice> gfgtdf: i dont understand why that would make a difference, are you sure that the .str() is needed?
20140720 02:51:24< iceiceice> it shoudl have been very broken if that was needed
20140720 02:51:27< gfgtdf> iceiceice: i think teh second oen is beter and also mathes better the previous behviour.
20140720 02:51:44< gfgtdf> iceiceice: idk i copied teh code from your pr and replaced  NEUTRAL with alignment_
20140720 02:52:16< gfgtdf> matches
20140720 02:52:18< gfgtdf> *
20140720 02:53:14< iceiceice> having a default value of NEUTRAL matches the old implementation though
20140720 02:53:15< iceiceice> https://github.com/wesnoth/wesnoth/commit/30c179b92da29bb03541e8e0c7dfaf1c3c401b35#diff-af3fd7e884f8ab9f39f9088ca4010d0dR232
20140720 02:53:48< gfgtdf> iceiceice: oh
20140720 02:53:51< iceiceice> gfgtdf: maybe the problem is actually in unit_types.cpp
20140720 02:53:51< gfgtdf> iceiceice:  your are right
20140720 02:53:59< iceiceice> i added a default value of NEUTRAL to unit_type? was that wrong?
20140720 02:54:08< gfgtdf> iceiceice: no i dont think so
20140720 02:54:29< gfgtdf> iceiceice: we should change alignment_ if cfg["aignment"] is emtpy
20140720 02:54:33< gfgtdf> not*
20140720 02:57:38-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral]
20140720 03:00:21-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140720 03:02:27-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140720 03:04:59< gfgtdf> iceiceice: doesnt this break our unit reference count ? https://github.com/wesnoth/wesnoth/blob/master/src/unit.cpp#L677
20140720 03:05:25< gfgtdf> iceiceice:  i mean operator= shouldnt change the units reference count
20140720 03:07:51< iceiceice> i dont understand why we do that, why dont we just use a copy and swap
20140720 03:09:27< gfgtdf> iceiceice: i think teh main reason for teh curent implementation was just less words to type
20140720 03:13:42< gfgtdf> iceiceice: ok i have to go to bed now
20140720 03:14:35< iceiceice> ok c u
20140720 03:15:49-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has joined #wesnoth-dev
20140720 03:16:11< gfgtdf> RiftWalker: did you see my message above ?
20140720 03:16:35< gfgtdf> RiftWalker: 20140719 12:16:10< gfgtdf> thunderstruck, RiftWalker, in the wiki we say that id= for [multiplayer] and [scenario] cannot clash, is this still true? If not the wiki should be updated.
20140720 03:16:39< RiftWalker> gfgtdf: I did. It hasn't changed.
20140720 03:16:56< gfgtdf> RiftWalker: but i tougth be convert scenario to multiplayer now ?
20140720 03:17:07< gfgtdf> [scenario] to [multiplayer]
20140720 03:18:10< RiftWalker> gfgtdf: right.
20140720 03:19:15< gfgtdf> RiftWalker: so if we have a [multiplayer] tag with if = "myscenario" and a [scenario] tag with id= "myscenario" and we are playing a mp scenario  how do we ensure to laod teh correct scenario ?
20140720 03:19:22< gfgtdf> id = *
20140720 03:19:34< gfgtdf> and we are playing an m campaign*
20140720 03:20:22< RiftWalker> gfgtdf: we can't. so, the wiki is correct.
20140720 03:21:36< gfgtdf> RiftWalker: so i am wrong when i read "Can't clash" as "The engind prevents clashing of those" ?
20140720 03:23:17< gfgtdf> engine*
20140720 03:23:40< RiftWalker> gfgtdf: Ah, I see. Hmm, that is ambiguous. I believe it means that if they do clash, it won't work properly.
20140720 03:24:29< gfgtdf> RiftWalker: ah ok.
20140720 03:24:36< gfgtdf> RiftWalker: well i really have to go to bed now
20140720 03:24:40-!- gfgtdf [~chatzilla@f054128033.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140720 03:26:13-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 256 seconds]
20140720 03:26:13< iceiceice> gfgtdf: i dont think the copy assignment operator we have breaks the ref counting,
20140720 03:26:48-!- ryao [user75695@gentoo/developer/ryao] has left #wesnoth-dev []
20140720 03:26:54< iceiceice> i think the reason we have that instead of copy and swap is that constructing a unit has major engine side effects
20140720 03:26:58< iceiceice> like introducing new engine events.
20140720 03:27:04< iceiceice> which is imo a serious design flaw
20140720 03:27:27< iceiceice> also, affecting the random generator
20140720 03:27:52< iceiceice> but, i dont think the current assignment operator using placement new will break the ref counting anyways
20140720 03:28:11< iceiceice> and i dont see any easy way to change it all right now
20140720 03:29:31< iceiceice> the current one is not that different from copy and swap, its just that it does things in the non-exception-safe order
20140720 03:30:21< iceiceice> if you use operaotr = to assign a unit, it will reset the refcount to 0 because that's what the copy constructor does,
20140720 03:32:56< iceiceice> idk, i didnt think you had to write a special copy assignment operator when using the intrusive ptrs but maybe i'm wrong
20140720 03:34:11-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has quit [Quit: leaving]
20140720 03:36:10< iceiceice> gfgtdf: have a look in src/reference_counted_object.hpp,
20140720 03:36:32< iceiceice> i guess that there we just define the copy assignment operator to do nothing?
20140720 03:37:25< iceiceice> maybe you are right, maybe the copy assignment operator for unit needs to do something special for the ref count
20140720 03:37:57< iceiceice> i actually can't think of any places in the code that we use copy assignment with a unit, i think i changed most of the code to use unit_ptr
20140720 03:42:59-!- irker595 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140720 04:37:50< iceiceice> gfgtdf: i put an `assert(false)` into the copy assignment operator for unit and ran two droid games,
20140720 04:37:53< iceiceice> it didnt crash
20140720 04:38:18< iceiceice> im not sure if there might be some place we actually use it in the wml or lua api,
20140720 04:38:24< iceiceice> i didnt see one in the lua_unit impl though
20140720 04:38:49< iceiceice> so i think you are right, i think the current impl is broken, but i dont think its actually ever used right now
20140720 04:46:30-!- {V} [~V@72-69-ftth.on.nl] has quit [Excess Flood]
20140720 04:46:54-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20140720 05:09:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20140720 05:09:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20140720 05:39:52-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140720 05:48:37-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140720 05:48:53-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20140720 05:57:08-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140720 06:20:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140720 06:45:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140720 06:48:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140720 07:21:03-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has joined #wesnoth-dev
20140720 07:43:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140720 07:43:24-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20140720 07:48:45-!- cib0 [~cib@p5DD2167A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140720 08:00:47-!- cib0 [~cib@p5DD2167A.dip0.t-ipconnect.de] has quit [Quit: Leaving]
20140720 08:01:06-!- cib0 [~cib@p5DD2167A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140720 08:28:16-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 08:41:33-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140720 08:46:48-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has joined #wesnoth-dev
20140720 08:48:02-!- RiftWalker [~nathan@ip98-163-252-45.no.no.cox.net] has quit [Client Quit]
20140720 08:53:56-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20140720 08:54:59< ancestral> shadowm: So the Citadel (Frogatto) team has the same resolution/mouse tracking problems as Wesnoth does, where if the window size is set to dtaw larger than the available space, the video is wonky.
20140720 08:55:49< ancestral> And forcing the resolution to 2000x2000 looks exactly like it did with the patch you wrote up for me to test - where it aligns to the bottom left corner
20140720 08:56:19< ancestral> And it behaves the same way, where if you resize the window at any time it corrects the graphics in the window
20140720 08:56:25< ancestral> shadowm: Also they are using SDL2
20140720 08:59:26-!- cib_ [~cib@p5DC75DF6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140720 09:00:08< ancestral> So maybe this is something upstream after all, or there’s code in common between the two apps (and they’re both missing a setting or something)
20140720 09:02:49-!- cib0 [~cib@p5DD2167A.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20140720 09:10:01-!- patwotrik [~patwotrik@nl118-171-98.student.uu.se] has quit [Remote host closed the connection]
20140720 09:16:48-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140720 09:23:24-!- cib_ [~cib@p5DC75DF6.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20140720 09:24:42-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140720 09:27:27-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20140720 09:28:54-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140720 10:14:23-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 10:46:00-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140720 10:47:15-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 10:51:59-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has quit [Quit: Turuk]
20140720 11:05:15-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140720 11:06:47-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 11:21:14-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140720 11:35:43-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 11:43:31< zookeeper> iceiceice, i'd remove the "role-playing" from "Some role-playing scenarios" really
20140720 11:44:16< zookeeper> if you want something more specific than "some", then i guess "some rare scenarios" wouldn't be out of place
20140720 11:50:48-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140720 11:54:39-!- irker078 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140720 11:54:40< irker078> wesnoth: David Mikos wesnoth:1.12 52e7a3aab97a / changelog data/campaigns/The_Hammer_of_Thursagan/units/Dwarvish_Masked_Lord.cfg: THoT: Masked Dwarvish Lord range attack same as Dwarvish Lord http://git.io/rXxePQ
20140720 11:55:07< irker078> wesnoth: David Mikos wesnoth:master 3c21f01058be / changelog data/campaigns/The_Hammer_of_Thursagan/units/Dwarvish_Masked_Lord.cfg: THoT: Masked Dwarvish Lord range attack same as Dwarvish Lord http://git.io/iwK9bw
20140720 11:59:57-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 12:02:07-!- prophile [~alynn@oftn/member/prophile] has quit [Client Quit]
20140720 12:15:20-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 12:25:08-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140720 12:26:00-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.]
20140720 12:36:17-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140720 12:39:58-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140720 12:40:01-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140720 12:44:02< bumbadadabum> ok I've been out for a few months
20140720 12:44:19< bumbadadabum> what are major features introduced the past few months?
20140720 12:59:37-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Read error: Connection reset by peer]
20140720 13:00:37-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev
20140720 13:03:30-!- WRanger [974d2b9e@gateway/web/freenode/ip.151.77.43.158] has joined #wesnoth-dev
20140720 13:09:31-!- WRanger [974d2b9e@gateway/web/freenode/ip.151.77.43.158] has quit [Quit: Page closed]
20140720 13:22:21-!- prkc [~prkc@h33-59.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20140720 13:41:37-!- wesbot changed the topic of #wesnoth-dev to: string+feature freeze active on 1.12 | 242 bugs, 344 feature requests, 29 patches | Logs: http://irclogs.wesnoth.org | Alternate logs: http://wesnoth.debian.net | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20140720 13:45:39< zookeeper> wesbot, seen fendrin
20140720 13:45:39< wesbot> zookeeper: Sorry, I don't know of fendrin.
20140720 13:46:20< zookeeper> i'd really want the map data padding whitespace back.
20140720 13:54:04< zookeeper> i suspect it was probably changed in a8aa81, but i don't really see anything like that in the diff.
20140720 13:59:16< zookeeper> ah, it was actually ea3028
20140720 13:59:26< zookeeper> whoever simon forsyth is, i don't recall
20140720 14:00:08< zookeeper> alarantalara, it seems
20140720 14:23:09< happygrue> iceiceice: just catching up on logs, I am quite behind as I have been traveling and very busy for about a month solid but I see some talk of fungus changes... saurians/drakes would be THE key units to watch out for with those.  If those values changed around a bunch then we may have a problem
20140720 14:25:19-!- EdB [~edb@85.69.242.6] has joined #wesnoth-dev
20140720 14:53:11-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20140720 14:55:09-!- irker078 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140720 14:56:18-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20140720 15:12:23-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20140720 15:26:49< iceiceice> happygrue: there was a forum thread about the terrain changes,
20140720 15:26:58< iceiceice> i did a little survey,
20140720 15:27:30< iceiceice> afaik the only significant uses of fungus in mainline campains + mp is, fungus + flat, fungus + hills, and fungus + cave
20140720 15:27:49< iceiceice> and there was a list of what was affected
20140720 15:28:39< iceiceice> on fungus + flat, i think the only changes were, cavalary, khalifate cavalry, gryphon rider
20140720 15:28:51< iceiceice> on fungus + hills, more units were changes,
20140720 15:29:18< iceiceice> all dwarves, all orcs (but not trolls), all khalifate units
20140720 15:29:32< iceiceice> got slightly higher defense, because of the "best defense" behavior of the mixed terrain
20140720 15:29:53< iceiceice> also, mermen and nagas got different values there but that doesnt seem to important
20140720 15:30:06< iceiceice> on fungus + cave, the changes were, all rebels 2mp -> 3mp
20140720 15:30:16< iceiceice> flying drakes 2mp -> 3mp
20140720 15:30:27< iceiceice> dwarves got 50% defense instead of 40
20140720 15:30:35< iceiceice> i think that was it
20140720 15:31:29< iceiceice> i dont think saurians got changed on anything, i guess they would be strong on fungus + swamp for instance but that terrain is basically nonexistent
20140720 15:37:45< happygrue> okay, thanks.  I'll take a look
20140720 16:06:22-!- molgrum [~molgrum@212.85.89.43] has quit [Ping timeout: 250 seconds]
20140720 16:07:22-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20140720 16:07:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20140720 16:16:21-!- cib0 [~cib@p5DC75DF6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20140720 16:17:52-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20140720 16:20:34-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140720 16:22:23< iceiceice> happygrue: by the way, when i was looking at the terrain change stuff, i noticed that the khalifate cavalry are different from the loyalist cavalry in that they don't have "negative" defense for forests
20140720 16:22:38< iceiceice> so they get hills defense on forested hills, rather than forest defense
20140720 16:22:54< iceiceice> i guess its all been playtested and balanced, but i thought i would ask anyway if that was intentional?
20140720 16:24:00-!- DCW1 [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev
20140720 16:33:20-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20140720 16:34:13< zookeeper> well it certainly doesn't make any sense that they'd get better defense than loyalist cavalry in forests
20140720 16:34:25-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 16:41:49< iceiceice> idk i mean the "rami" is sort of a light cavalry so it makes some sense
20140720 16:42:07< iceiceice> the khaiyal is armored though, so that doesnt make too much sense to me, but it might be that way on purpose for balance idk
20140720 16:56:33-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140720 17:04:04-!- irker807 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140720 17:04:04< irker807> wesnoth: Chris Beck wesnoth:master 1380842904f5 / src/help.cpp: fixup a null ptr deref in help.cpp when viewing from editor http://git.io/IP60Cw
20140720 17:42:21< happygrue> iceiceice: I'd have to look back at the logs to recall, there were a number of changes back and forth in various directions.  The core idea was to make them NOT "just like loyalists", but it turns out that that is somewhat hard to make it work and feel like a horse without being basically a horseman or cav.
20140720 17:42:41< happygrue> but I agree the armored horse would ideally get hurt in the forest.  
20140720 17:45:11< happygrue> There are a number of choices that noy felt very strongly against or for, and this could be one of those.  But since I don't know the backstory and it isn't visible I don't remember.  But I'll put it on the list of things to examine in the next development cycle.
20140720 17:45:44< iceiceice> ok
20140720 17:46:31< happygrue> I found the forum thread, I'm just backed up with other things for a bit.  I'll take a look when I get a chance.
20140720 17:46:36< happygrue> (regarding the fungus)
20140720 17:46:58< iceiceice> so in the forum thread, one of the few things that we seemed to agree on is, if mushroom is a dual terrain now, like forests, then it should be the case that mushroom + flat works the same as mushroom
20140720 17:47:35< iceiceice> otherwise on all the mp maps with mushroom, cavalry and gryphons will get higher defense, and its not easy to change it back unless you make a custom terrain
20140720 17:47:58< happygrue> it is really unfortunate that this wasn't changed years ago, but IIRC there was a big stink made about changing this for balancing, so we kept all the execptions and it's just years later and a right mess now...  and still needs to be changed.
20140720 17:48:31< iceiceice> so imo we probably should change gryphon and loyalist cavalry (and possibly khalifate cavalry?) to get - whatever defense on fungus, for 1.11.16
20140720 17:48:31< happygrue> It could be that once stable is released and people really start playing with it all kinds of problems come out, I don't know.
20140720 17:48:36< happygrue> or maybe it won't be too bad.
20140720 17:48:37< iceiceice> *1.11.17
20140720 17:49:27< happygrue> yeah
20140720 17:49:42< iceiceice> idk what if anything else we want to do though
20140720 17:49:45< happygrue> I want to chat about that with the other mp folks
20140720 17:49:48< happygrue> but afk now
20140720 17:49:51< iceiceice> i did a bunch of work recently to try to improve the help 
20140720 17:49:55< iceiceice> regarding these negative defense modifiers
20140720 17:50:04< happygrue> ah, nice
20140720 17:50:15< iceiceice> http://imgur.com/a/x6h6F#0
20140720 17:50:29< iceiceice> actually thats out of date, it looks a bit differently now,
20140720 17:50:33< iceiceice> but thats the basic idea
20140720 17:50:38< iceiceice> only on master atm
20140720 17:50:50-!- DCW1 [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20140720 17:51:54< iceiceice> anyways thats all i wanted to say atm
20140720 17:59:01-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Quit: riksteri]
20140720 18:19:51-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140720 18:28:56< zookeeper> happygrue, btw, the forest change referred to here was made in 1.9, so if khalifate cavalry balancing was done before that then it's very likely not intentional.
20140720 18:34:01-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 256 seconds]
20140720 18:43:11-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20140720 18:49:11-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer]
20140720 18:50:54-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140720 18:55:22-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 250 seconds]
20140720 19:23:01< Ivanovic> is it expected that building master fails right now if dbus is enabled and the system not relying on systemd?
20140720 19:23:08< Ivanovic> (at least when using cmake as build system)
20140720 19:23:29< Ivanovic> if this is not supposed to happen, someone please look at this output: http://pastebin.com/BKwpcyR0
20140720 19:23:44< Ivanovic> happens for me on gentoo "unstable" both x86 as well as amd64 with git master
20140720 19:36:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20140720 19:37:27-!- EdB [~edb@85.69.242.6] has quit [Quit: Konversation terminated!]
20140720 19:47:58< Ivanovic> iceiceice: please look at the error i just posted, this might be based on something you have done lately
20140720 19:49:07-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has joined #wesnoth-dev
20140720 19:49:07-!- iceiceice [~chris@cpe-66-108-20-80.nyc.res.rr.com] has quit [Changing host]
20140720 19:49:07-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20140720 19:49:37< iceiceice> Ivanovic: i did move all of the notifications code to separate files instead of where they were,
20140720 19:49:45< iceiceice> i did try to update the cmake files,
20140720 19:49:54< iceiceice> but i have never gotten cmake to work on my system so I was unable to test it
20140720 19:50:06< iceiceice> the compiler output is complaining about bad casts / treating warnings as errors,
20140720 19:50:16< iceiceice> can you test if it was working before i change?
20140720 19:50:25< iceiceice> i think if you checkout any commit from a month ago it should be far back enough
20140720 19:51:41< iceiceice> i didn't change any of the actual code, so my guess is that it wouldnt have compiled 1 month ago either, for the same reason
20140720 20:00:43-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140720 20:07:16-!- ancestral [~ancestral@adsl-76-248-166-148.dsl.pltn13.sbcglobal.net] has joined #wesnoth-dev
20140720 20:16:27< elias> Ivanovic: will you do a gamedev devroom again at fosdem 2015?
20140720 20:19:50< Ivanovic> elias: you are right, the reminder that people can go for devrooms now was sent
20140720 20:20:05< Ivanovic> but i am not really sure if i will manage to organize a devroom this year
20140720 20:20:24< elias> i see
20140720 20:21:09< Ivanovic> so in fact if someone took over that work it would be perfectly fine by me...
20140720 20:22:47< Ivanovic> iceiceice: do you have a commit hash for me which i should test
20140720 20:23:51< iceiceice> try this one: https://github.com/wesnoth/wesnoth/commit/33ae8d7398175e725634c5edc43d4b0e4d504345
20140720 20:26:10< Ivanovic> right now i am trying this one: https://github.com/wesnoth/wesnoth/commit/cff404060b716dd2eefb1a68f39ac36c1a7a14e3
20140720 20:28:58< Ivanovic> that one built nicely
20140720 20:30:57< Ivanovic> iceiceice: when did you move stuff over? that is what is the revision right before that
20140720 20:31:33< iceiceice> i gave you the commit just before that in history for src/game_display.cpp,
20140720 20:31:36< iceiceice> the moves over were these two commits:
20140720 20:31:37< iceiceice> https://github.com/wesnoth/wesnoth/commit/d2edec5921a6547d7ab636da6517adb7df5ddae8
20140720 20:31:45< iceiceice> https://github.com/wesnoth/wesnoth/commit/31487bec2653f8b2424769bc113e28d5bea9943e
20140720 20:38:21< Ivanovic> iceiceice: okay, the first one you linked does not work (d2edec...)
20140720 20:38:32< iceiceice> Ivanovic: when i try to build with cmake, following instructions here, http://wiki.wesnoth.org/CompilingWesnoth#Building_with_CMake
20140720 20:38:35< iceiceice> i get the following error:
20140720 20:38:47< iceiceice> -- Could NOT find Threads (missing:  Threads_FOUND) 
20140720 20:39:08< iceiceice> http://hastebin.com/jenubihari.hs
20140720 20:39:30< Ivanovic> i tried now with this one and it worked: https://github.com/wesnoth/wesnoth/commit/c119584895c2dc78fdb6f66e7a15a55c7061def8
20140720 20:41:26< iceiceice> Ivanovic: do you know when the last time cmake has worked is?
20140720 20:41:42< iceiceice> we dont use that on travis or jenkins,
20140720 20:41:48< iceiceice> and the instructions don't seem to work on the wiki
20140720 20:41:51< Ivanovic> in this commit things broke: https://github.com/wesnoth/wesnoth/commit/77e00157e8bf0f8d4ef3cbd99f371813c5bbfb79
20140720 20:43:47< iceiceice> Ivanovic: do you see a problem with the cmake_lists.txt changes i made in that commit?
20140720 20:43:59< iceiceice> i just did similar things to what i saw in the lines just above
20140720 20:44:25< Ivanovic> iceiceice: i am just using this script for building with cmake and it works great... calling it with "./wesnoth build"
20140720 20:44:33< iceiceice> what does your script look like?
20140720 20:45:04< Ivanovic> http://pastebin.com/Kqa63ZDd
20140720 20:45:56< Ivanovic> are you sure that you are building with -Werror?
20140720 20:46:08< Ivanovic> since those are plain and old compiler *warnings*
20140720 20:46:23-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 20:46:25< Ivanovic> which did not happen before because it was plain C and is not C++ looking at the filenames
20140720 20:47:01< iceiceice> Ivanovic: can you see if your script is different from the instructions on the wiki? http://wiki.wesnoth.org/CompilingWesnoth#Building_with_CMake
20140720 20:47:17< iceiceice> the script seems pretty complicated
20140720 20:47:19< Ivanovic> i am providing like 500 extra parameters
20140720 20:47:27< Ivanovic> my command is basically:
20140720 20:48:43< Ivanovic> cmake PATH_TO_CHECKOUT_DIR -DBINDIR=/games-bin -DDATAROOTDIR=/games -DENABLE_SERVER=TRUE -DPREFERENCES_DIR=.wesnoth-git -DBINARY_SUFFIX=-git -DDATADIRNAME=wesnoth-git -DENABLE_POT_UPDATE_TARGET=TRUE -DENABLE_NOTIFICATIONS=TRUE
20140720 20:50:25< iceiceice> Ivanovic: the problem is that there aren't any working instructions to help someone else build with cmake
20140720 20:51:06< iceiceice> i'm looking on this one the way that i look on the VC9 project files, 
20140720 20:51:16< iceiceice> i don't bulid with VC and I can't test if the projectfile is broken,
20140720 20:51:23< Ivanovic> those instructions do work!
20140720 20:51:26< iceiceice> but its simple enough that i can edit with a text editor and it has always worked
20140720 20:51:29< iceiceice> Ivanovic: no they dont
20140720 20:51:37< iceiceice> not on linux mint 16 anyways
20140720 20:51:49< Ivanovic> then you don't have all deps installed required for cmake
20140720 20:51:49-!- ancestral [~ancestral@adsl-76-248-166-148.dsl.pltn13.sbcglobal.net] has quit [Quit: i go nstuf kthxbai]
20140720 20:51:53< iceiceice> no, i do,
20140720 20:51:56< iceiceice> it works fine with scons
20140720 20:53:28< Ivanovic> http://pastebin.com/HaBTxeCB
20140720 20:53:45< Ivanovic> this is how the output looks on my system when following the instructions provided in the wiki page
20140720 20:53:49< Ivanovic> as you see, it just works
20140720 20:54:17< iceiceice> ok, this is what i do when i follow the instructions on the wiki: http://hastebin.com/jenubihari.hs
20140720 20:54:20< iceiceice> as you can see, it just fails
20140720 20:54:34< Ivanovic> please temove the build dir and then rerun the commands
20140720 20:54:39< iceiceice> sure
20140720 20:54:52< Ivanovic> and check the output of the mentioned log files
20140720 20:57:09< iceiceice> this is all that i get, there are no log files generated: http://hastebin.com/qetimewola.sm
20140720 20:57:18< Ivanovic> See also "/home/chris/wesnoth-src/clone/wesnoth/CMakeFiles/CMakeOutput.log".
20140720 20:57:20< Ivanovic> See also "/home/chris/wesnoth-src/clone/wesnoth/CMakeFiles/CMakeError.log".
20140720 20:57:23< Ivanovic> those files are not generated?
20140720 20:57:35< iceiceice> no, they are not
20140720 20:57:48< iceiceice> as you can see form log, the cmake_build_dir directory is empty
20140720 20:58:01< iceiceice> oh
20140720 20:58:02< iceiceice> i misread it
20140720 20:58:06< iceiceice> sorry
20140720 20:59:32< iceiceice> do you want links to these error log files?
20140720 21:00:15< Ivanovic> could you create the build dir outside of the checkout dir and provide an absolute path to the checkout dir instead of ~/ ?
20140720 21:00:28< Ivanovic> i just want to be sure that those ain't the problems
20140720 21:02:02< iceiceice> ok, i tried that, same result: http://hastebin.com/atoragucup.sm
20140720 21:03:50< Ivanovic> what surprises me most is that the log files are in your wesnoth checkout dir, this does not ahppen over here
20140720 21:04:46< Ivanovic> can you add a / at the end of the path to the checkout dir?
20140720 21:05:00< Ivanovic> so make it "cmake /home/chris/wesnoth-src/clone/wesnoth/"
20140720 21:05:56< iceiceice> ok,
20140720 21:06:11< iceiceice> just so you know, when i put a bad path to cmake, it gives me an error "could not find cmake_lists.txt" or something like this
20140720 21:06:22< Ivanovic> as it should
20140720 21:06:37< iceiceice> i get this error with the / at the end: http://hastebin.com/azinipevet.sm
20140720 21:06:38< Ivanovic> still for me the configure output files are all in the build dir, not in the checkout dir
20140720 21:07:48< Ivanovic> please remove the following files from the checkout dir: CMakeCache.txt CMakeFiles/
20140720 21:08:27< Ivanovic> and: src/CMakeFiles/
20140720 21:08:33< iceiceice> ok that worked now i think :)
20140720 21:08:39< iceiceice> hmm wait
20140720 21:08:40< iceiceice> no
20140720 21:08:53< iceiceice> it just generated a bunch of new input at the start but it failed the same way at the end :(
20140720 21:08:55< Ivanovic> at least you clearly had some strange old files in there
20140720 21:09:01< iceiceice> hmm wait
20140720 21:09:05< Ivanovic> but now the logs should be in the temp folder
20140720 21:09:07< iceiceice> let me read this more carefully
20140720 21:11:54< iceiceice> ok, i ran "make", it looks to have gotten through mo update and now be compiling
20140720 21:12:18< iceiceice> i think maybe we should put some notes in the "compiling with cmake" thing that you might need to delete the cmake cache file if you have problems?
20140720 21:12:35-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 264 seconds]
20140720 21:13:47< iceiceice> the scons script also has a cache i guess but its a bit friendlier about it, and it explains in the scons --help page about how to force it to redo the cache
20140720 21:14:37-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has joined #wesnoth-dev
20140720 21:17:14< Ivanovic> usually that should not happen, and if you have a build dir you can just remove that
20140720 21:18:32-!- prophile [~alynn@oftn/member/prophile] has quit [Quit: The Game]
20140720 21:19:06< iceiceice> ok but if someones cache is broken they wont be able to compile and they wont know why.
20140720 21:19:29< iceiceice> also, note that we do compile on travis using gcc right now, and it treats warnings as errors
20140720 21:20:47< iceiceice> im compiling locally with cmake right now, its gotten into the gui/widgets folder..
20140720 21:21:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20140720 21:21:38-!- prophile [~alynn@oftn/member/prophile] has joined #wesnoth-dev
20140720 21:22:14-!- prophile [~alynn@oftn/member/prophile] has quit [Client Quit]
20140720 21:23:00< Ivanovic> i am off to bed now, n8
20140720 21:23:19< Ivanovic> iceiceice: i don't know if the dbus notifications are active by default in the cmake recipe or not
20140720 21:23:36< iceiceice> i don't know either
20140720 21:23:47< Ivanovic> if things don't break maybe retry with "cmake -DENABLE_NOTIFICATIONS=TRUE PATH_TO_BUILD_DIR"
20140720 21:24:02< Ivanovic> or go into ccmake in your build folder and check the status
20140720 21:24:15< iceiceice> that stuff should be written in the compiling instructions as well
20140720 21:24:18< Ivanovic> that is: inside the build dir type "ccmake ." or "cmake-gui ."
20140720 21:24:25< Ivanovic> ccmake is listed in there!!!
20140720 21:24:27< iceiceice> ok
20140720 21:25:19< iceiceice> but also if dbus notifcations are not enabled, that should not break compilation,
20140720 21:25:22< iceiceice> you simply wont get notifications
20140720 21:25:36< Ivanovic> yes, but compilation over here is broken *WITH* dbus notifications active
20140720 21:25:47< Ivanovic> due to the warning thrown by the compiler
20140720 21:25:48< iceiceice> i think its a problem with the cmake recipe though
20140720 21:26:00< Ivanovic> at least when using gcc 4.8.3
20140720 21:26:14< iceiceice> travis currently compiled with gcc 4.8 without a problem
20140720 21:26:34< Ivanovic> if you reach the breaking point, recall make with VERBOSE=1 make
20140720 21:26:51< Ivanovic> then you should have a little more output and you can check what is set and what not for this single file
20140720 21:26:52-!- lipkab [~the_new_l@host-91-147-212-189.biatv.hu] has quit [Ping timeout: 245 seconds]
20140720 21:27:08< Ivanovic> but since it breaks with those warnings it would surprise me if it really is in the receipe itself
20140720 21:27:21< Ivanovic> unless you specified something else in the scons recipe turning off some warnings
20140720 21:29:02< iceiceice> travis is just doing the default build, no extra flags
20140720 21:29:36< iceiceice> whats really surprising to me is that gcc would complain about type casts, when none of that code was changed when it was moved from game_display.cpp,
20140720 21:29:53< iceiceice> all the "filter_dbus" etc. was just copy pasted
20140720 21:30:41< Ivanovic> whati know is that the stuff was in .h files before and is now called using .hpp files
20140720 21:32:06< iceiceice> no, nothing was changed, you can check the diff: https://github.com/wesnoth/wesnoth/commit/77e00157e8bf0f8d4ef3cbd99f371813c5bbfb79#diff-95e351a3805a1dafa85bf20b81d086e6R1009
20140720 21:32:24-!- cib0 [~cib@p5DC75DF6.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20140720 21:32:27< Ivanovic> -#include <dbus/dbus.h>
20140720 21:32:29< Ivanovic> +#include "dbus_notification.hpp"
20140720 21:32:34< Ivanovic> https://github.com/wesnoth/wesnoth/commit/77e00157e8bf0f8d4ef3cbd99f371813c5bbfb79
20140720 21:34:38< Ivanovic> sorry, my bad, this was just a part of the move of the code
20140720 21:34:45< Ivanovic> that is: the cmake code looks okay to me
20140720 21:34:57< iceiceice> Ivanovic: i think you didnt read the whole diff,
20140720 21:35:07< iceiceice> all that happened was, i moved the functions out of game_display.cpp, where they didn't belong,
20140720 21:35:12< iceiceice> to a new file dbus_notification.cpp
20140720 21:35:36< iceiceice> this didn't change anything for clang, gcc, Xcode, VC, anything else
20140720 21:36:34< Ivanovic> if(LIBDBUS_FOUND)
20140720 21:36:35< Ivanovic> 	set_source_files_properties(
20140720 21:36:37< Ivanovic> 		game_display.cpp
20140720 21:36:38< Ivanovic> 		PROPERTIES
20140720 21:36:40< Ivanovic> 			COMPILE_FLAGS "${CXX_FLAG_NO_OLD_STYLE_CAST}"
20140720 21:36:41< Ivanovic> 	)
20140720 21:36:43< Ivanovic> endif()
20140720 21:36:49< Ivanovic> i just searched for dbus in the src/CMakelists.txt file
20140720 21:37:02< Ivanovic> and, you need to enforce that the old casting is allowed to make it compile
20140720 21:37:40< Ivanovic> so you probably need to change line 361
20140720 21:37:45< iceiceice> hmm i didnt see that before
20140720 21:37:46< Ivanovic> off to bed now, n8
20140720 21:37:47< iceiceice> ok
20140720 21:55:52-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140720 22:05:45-!- irker807 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20140720 22:11:27-!- gfgtdf [~chatzilla@d111109.adsl.hansenet.de] has joined #wesnoth-dev
20140720 22:13:03-!- travis-ci [~travis-ci@ec2-54-211-35-198.compute-1.amazonaws.com] has joined #wesnoth-dev
20140720 22:13:03< travis-ci> [travis-ci] gfgtdf/wesnoth-old#213 (unit_alignment - 8c846d8 : gfgtdf): The build was canceled.
20140720 22:13:03< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/30414062
20140720 22:13:03-!- travis-ci [~travis-ci@ec2-54-211-35-198.compute-1.amazonaws.com] has left #wesnoth-dev []
20140720 22:13:18-!- travis-ci [~travis-ci@ec2-54-211-35-198.compute-1.amazonaws.com] has joined #wesnoth-dev
20140720 22:13:18< travis-ci> [travis-ci] gfgtdf/wesnoth-old#214 (unit_alignment - 495ba60 : gfgtdf): The build passed.
20140720 22:13:18< travis-ci> [travis-ci] Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/30414195
20140720 22:13:18-!- travis-ci [~travis-ci@ec2-54-211-35-198.compute-1.amazonaws.com] has left #wesnoth-dev []
20140720 22:17:44-!- irker044 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20140720 22:17:44< irker044> wesnoth: Chris Beck wesnoth:master d412e89fed85 / src/CMakeLists.txt: fixup src/cmakelists.txt http://git.io/GDK1eQ
20140720 22:21:03< irker044> wesnoth: gfgtdf wesnoth:master 2c4fb674a246 / src/unit.cpp: revert movement of unit alignment init to initializer list  http://git.io/P8g03w
20140720 22:22:54< gfgtdf> iceiceice: ^, i can close https://github.com/wesnoth/wesnoth/pull/256 ?
20140720 22:23:06-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20140720 22:23:09< iceiceice> sure, it was just to show you what error i got
20140720 22:23:49< iceiceice> wait but why does this work?
20140720 22:24:04< gfgtdf> iceiceice: why shoudnt it ?
20140720 22:24:17< iceiceice> the default value of alignment shouldn't be NEUTRAL?
20140720 22:24:42< iceiceice> it just looks wierd...
20140720 22:24:50< gfgtdf> no, aligmnent was setted to teh unittypes alignment by advance_to().
20140720 22:25:07< iceiceice> maybe line 276 should be alignment_(unit_type::NEUTRAL) ?
20140720 22:25:18< iceiceice> idk
20140720 22:25:44< gfgtdf> so this code is 'fall back to unittype adignment if the cfg["alinment"] isno valid alignment (esp if its empty)'
20140720 22:26:25< gfgtdf> iceiceice: we set the aligment here before: https://github.com/wesnoth/wesnoth/blob/2c4fb674a24612b3f909649cb966a00ef02b62e3/src/unit.cpp#L854
20140720 22:27:08< iceiceice> ok i see
20140720 22:31:04-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140720 22:34:40-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140720 22:36:53< happygrue>  zookeeper: "btw, the forest change referred to here was made in 1.9, so if khalifate cavalry balancing was done before that then it's very likely not intentional."  Thanks, that makes more sense.  I guess I need to look back at what the original values were and correct that.
20140720 22:45:48-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20140720 23:05:50-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20140720 23:28:31-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has quit [Read error: Connection reset by peer]
20140720 23:39:24-!- Ardonik [~user@adsl-75-28-103-232.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20140720 23:39:52-!- gfgtdf [~chatzilla@d111109.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]]
20140720 23:42:28-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai]
20140720 23:55:10-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev
20140720 23:58:48-!- prkc [~prkc@h33-59.pool95-168.dyn.tolna.net] has quit [Remote host closed the connection]
--- Log closed Mon Jul 21 00:00:03 2014