--- Log opened Wed Oct 08 00:00:17 2014 20141008 00:01:59-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 00:04:36-!- ancestral [~ancestral@17.114.45.53] has quit [Quit: ancestral] 20141008 00:05:51-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20141008 00:06:22-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 240 seconds] 20141008 00:08:24-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 260 seconds] 20141008 00:08:44-!- ancestral [~ancestral@17.114.45.53] has joined #wesnoth-dev 20141008 00:08:50-!- ancestral [~ancestral@17.114.45.53] has quit [Client Quit] 20141008 00:20:50-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141008 00:23:38-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 00:27:52-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 240 seconds] 20141008 00:33:56-!- irker658 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20141008 00:33:56< irker658> wesnoth: LovCAPONE wesnoth:master 2dae3f7a3b51 / changelog src/play_controller.cpp src/team.hpp: Fix for bug #22443 (Scenario settings table inaccuracies) http://git.io/6Mf09g 20141008 00:33:58< irker658> wesnoth: Ignacio R. Morelle wesnoth:master ec2cf176e73f / data/scenario-test.cfg: Add test case for bug #22443/PR #275 http://git.io/hukwRw 20141008 00:34:01< irker658> wesnoth: Ignacio R. Morelle wesnoth:master c25567ba6682 / src/play_controller.cpp: Fix up a comment from PR #275 for accuracy http://git.io/zYJUvw 20141008 00:36:46< iceiceice> shadowm: i posted a link to the screenshots i get for 22544 (sprites not being darkened correctly) 20141008 00:37:54< iceiceice> vultraz: "is graphincludes/project still used by anything?" 20141008 00:37:54< iceiceice> there was an email where someone mentioned it recently 20141008 00:38:11< iceiceice> i think it was used by someone umpteen years ago to try to figure out how to reduce excessive #includes in the sourcecode 20141008 00:38:18< iceiceice> i dont know if anyone still uses it 20141008 00:38:20< shadowm> God I'm missing C++11 range for already. 20141008 00:38:30< iceiceice> it might be reasonable to move it to to "tools" or something 20141008 00:38:49< iceiceice> i uploaded a different tool which i used for this purpose a while ago (its just a few scripts, its not visual) 20141008 00:39:57< iceiceice> https://mail.gna.org/public/wesnoth-dev/2014-07/msg00009.html 20141008 00:42:32< mattsc> iceiceice: if I understood loonycyborg correctly, the “Sdl r wops 1.12” PR/branch is for music only, maybe? 20141008 00:42:45< iceiceice> i dont know 20141008 00:42:56< mattsc> 20141006 06:39:11< loonycyborg> https://github.com/AI0867/wesnoth/tree/SDL_RWops_1.12 20141008 00:42:56< mattsc> 20141006 06:39:16< loonycyborg> that's the one I applied 20141008 00:43:09< mattsc> 20141006 13:43:59< loonycyborg> the fix that I applied was to loading music 20141008 00:43:40< mattsc> But I don’t understand the topic well enough that I could even lead the discussion … 20141008 00:43:52< irker658> wesnoth: LovCAPONE wesnoth:1.12 31bc4bc4e8a0 / changelog src/play_controller.cpp src/team.hpp: Fix for bug #22443 (Scenario settings table inaccuracies) http://git.io/wk3pvA 20141008 00:43:54< irker658> wesnoth: Ignacio R. Morelle wesnoth:1.12 27c817a46d59 / data/scenario-test.cfg: Add test case for bug #22443/PR #275 http://git.io/K0MJWQ 20141008 00:43:57< irker658> wesnoth: Ignacio R. Morelle wesnoth:1.12 7a4e2c2da70f / src/play_controller.cpp: Fix up a comment from PR #275 for accuracy http://git.io/EiYfog 20141008 00:44:07< iceiceice> i think its supposed to work for any resource loaded by SDL... so i would think music, images... idk what else 20141008 00:44:19< iceiceice> but thats just based on reading the pull request description, 20141008 00:44:22< shadowm> Sounds. 20141008 00:44:22< iceiceice> i dont really know 20141008 00:44:49< shadowm> Possibly fonts (via SDL_ttf for GUI1). 20141008 00:46:00< iceiceice> if we merge SDL_rwops, will people actually be able to have non-ascii paths to wesnoth? 20141008 00:46:00-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 00:46:00< iceiceice> or will it still crap out when they try to save the game and the map has a unicode hyphen 20141008 00:47:43< mattsc> The problem is that only AI0867 really knows at this time, I think, and he might not be back in time for us to move on with this. 20141008 00:48:00< mattsc> So does anybody have a suggestion how to proceed? 20141008 00:49:06< shadowm> Email him. 20141008 00:49:07< iceiceice> i think perhaps we should just wait until he comes back and not make a final release until then 20141008 00:49:17< iceiceice> i dont want to commit code that i dont understand, and i dont understand what it will do 20141008 00:49:51-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 246 seconds] 20141008 00:50:33 * shadowm hasn't actually figured out how to get a diff on the web interface yet. 20141008 00:51:03< shadowm> It looks like I could just look at the three top commits individually but I'm not sure. 20141008 00:51:13< iceiceice> shadowm: usually i just click on the "files changed" tab 20141008 00:51:21< iceiceice> for either the full PR or individual commits 20141008 00:51:27< iceiceice> idk if theres a more powerful way to get diffs than that 20141008 00:51:27< shadowm> But that requires a pull request. 20141008 00:53:36< iceiceice> yeah someties i make PRs and push them to fork so i can get a diff 20141008 00:53:36< shadowm> Oh, is it PR #241? 20141008 00:53:37< iceiceice> i think so 20141008 00:53:37< shadowm> And #155. 20141008 00:53:37< shadowm> Okay, that makes things much easier. 20141008 00:53:37< iceiceice> LovCAPONE: i just saw these github comments, "When we introduce a string in the code that needs translation how do we do it?" 20141008 00:53:37< iceiceice> do you still have questions like this? 20141008 00:53:37< iceiceice> i tried to find a wikipage that explains this... i think maybe i only learned this stuff over irc 20141008 00:53:37< mattsc> [sorry, all, I’ve been called away; I’ll be back later…] 20141008 00:53:37< shadowm> We are string-frozen on 1.12 until 1.12.0 is released, but adding strings is fine on master. 20141008 00:54:02< shadowm> That said, it's also okay to add new references to existing strings on 1.12. (I'll let iceiceice explain the gettext macros.) 20141008 00:54:37< shadowm> *existing strings from the same textdomain 20141008 00:55:52< iceiceice> yeah so, gettext is sort of a clever way to make it easy to write C++ programs that use strings that get translated, without forcing everyone to refer to string id's to be looked up in some dictionary 20141008 00:55:56< shadowm> I don't fully understand AI0867's branch but I'm suddenly unsure this actually fixes everything. 20141008 00:57:10< iceiceice> the simplest way to get a string translated, as a developer, is to mark it with _ 20141008 00:57:11< iceiceice> so instead of "Button Label" you have _ "Button Label", usually actualy _("Button Label") in the code 20141008 00:57:11< iceiceice> _ is a macro 20141008 00:57:11< iceiceice> it is defined in gettext.hpp 20141008 00:57:33< shadowm> It has to be _(foo) instead of _ "foo" in C++, otherwise you get malformed input for the compiler. 20141008 00:57:43< iceiceice> right sorry 20141008 00:57:49< iceiceice> so you have to use ( ) i guess 20141008 00:58:25< iceiceice> the way gettext works is, it scans the entire source code for strings with these _'s 20141008 00:58:32< iceiceice> also the WML i guess 20141008 00:59:07< iceiceice> these all get extracted into a big text file, 20141008 00:59:08< iceiceice> the translators are supposed to supply translated versions for each string 20141008 00:59:26< iceiceice> .po and .pot files are related to that process, i don't remember now exactly how 20141008 00:59:38< iceiceice> also .mo files are sometimes listed by the compiler... 20141008 00:59:50< iceiceice> basically all the translations end up getting aggregated before the C++ compiler runs, 20141008 00:59:55< iceiceice> thats part of our cmake and scons scripts 20141008 01:00:15< iceiceice> and i guess part of the "idea" of gettext, to have this extra step where the translation stuff happens 20141008 01:00:31< iceiceice> When you use _("foo") in code, 20141008 01:00:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 01:00:44< iceiceice> you will always get, at that time, the translated version of foo for whatever the current locale is 20141008 01:01:03< iceiceice> so if they change languages it will work correctly 20141008 01:01:26< iceiceice> 99% of the time this is all you need 20141008 01:01:36< iceiceice> sometimes you need to translate a dynamically generated string. 20141008 01:01:46< iceiceice> the only times i have done this, the answer is to use "sgettext" 20141008 01:02:01< iceiceice> you cannot use _ for this purpose, because then C++ code will appear in the translator's lists which is not good 20141008 01:02:52< iceiceice> what you are supposed to do is, somewhere else, all the possibilities of the dynamically generated string have to be listed with _, even if it's a No_op and gets thrown away by the compiler, 20141008 01:03:07< iceiceice> gettext needs to see each string that you want to be in the dictionary, it has to appear with _ 20141008 01:03:37< iceiceice> there are some other functions in the header gettext.hpp ... 20141008 01:03:56< iceiceice> i dont think i have ever seen them used 20141008 01:04:07< iceiceice> also, there's a macro N_ 20141008 01:04:10< iceiceice> i dont remember exactly what that does 20141008 01:04:25< shadowm> _("single static string"), _n("singular version of static string", "plural version of static string", var_if_1_selects_singular_otherwise_plural) 20141008 01:05:01< shadowm> Both encapsulate function calls in the C++ as well as marking the strings for xgettext's collection. 20141008 01:05:44< shadowm> N_("single static string") does not produce a function call, it just tells xgettext that the string needs to be included in the catalogue, meaning it's your responsibility to call gettext() on the string at a later point to actually get a translated version. 20141008 01:06:24< shadowm> iceiceice: I've never used sgettext() directly and I don't know what it does, but I've seen gettext() called directly instead. 20141008 01:07:01-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 01:07:32< shadowm> A common problem with internationalization is that you need to translate strings that contain variable components, for example "Add-on name: " 20141008 01:07:42< shadowm> *often you 20141008 01:08:02< iceiceice> here's the only time i've seen sgettext that i remember: 20141008 01:08:03< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/unit_types.hpp#L255 20141008 01:08:26< shadowm> Using something like std::string text = _("Add-on name: ") + addon_name may work in some cases. 20141008 01:08:45< shadowm> However, there are more complicated cases like: "The add-on is not installed." 20141008 01:09:37< shadowm> _("The add-on ") + addon_name + _(" is not installed") looks messy in translation catalogues, and breaks for a number of languages where more context is required to produce something gramatically correct. 20141008 01:10:59< shadowm> So you need to use placeholders instead, like _("The add-on $addon_name is not installed."). But how do you actually substitute the placeholder for display? There's a canned solution that deals with all the details for you in the form of the vgettext() functio and its own detail, utils::interpolate_variables_into_string(). 20141008 01:12:18< shadowm> Describing how to use those would take up too much space here, though, so if you need to use them you might prefer to grep for existing instances and take a look at how they are used in context 20141008 01:12:19< shadowm> We need a wiki/Doxygen page about this. 20141008 01:12:19-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 272 seconds] 20141008 01:12:41< iceiceice> shadowm: i just looked at the C++, 20141008 01:12:48< iceiceice> it looks liek sgettext is almost the same as gettext, 20141008 01:12:58< iceiceice> its specifically to handle these strings with "blah^string" 20141008 01:13:12< shadowm> gettext() is an alias for dgettext(), and sgettext() is an alias for dsgettext(). 20141008 01:13:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141008 01:13:40< shadowm> iceiceice: Hm, no, the disambiguation fragments are supported by btoth. 20141008 01:14:20< shadowm> Oh, _() is dsgettext(). 20141008 01:14:32< iceiceice> shadowm: it looks like it depends on if a gettext domain si defined or not 20141008 01:14:46< shadowm> Okay, then you are probably right, but that brings up the question of why anyone would use gettext() at all. 20141008 01:15:02< iceiceice> i dont know 20141008 01:15:07< iceiceice> it looks like sgettext and gettext are almost the same 20141008 01:15:09< shadowm> Other than as an implementation detail of dsgettext() itself. 20141008 01:15:26< shadowm> These Cish names I swear. 20141008 01:15:31< iceiceice> except that, if you do e.g. sgettext("female^liminal") 20141008 01:15:37< iceiceice> if it finds it, great, its the same as gettext 20141008 01:15:53< iceiceice> otherwise it appears in game as "liminal" instead of "female^liminal" 20141008 01:16:30< shadowm> If a GETTEXT_DOMAIN is not defined (and this is relevant for the API discussion above), the practical effect is that any strings in the file are assumed to be from the default 'wesnoth' textdomain. 20141008 01:17:08< shadowm> A large amount of UI stuff uses the non-default 'wesnoth-lib' textdomain instead, so that's a trap to be wary of. 20141008 01:19:23< iceiceice> yeah so i guess the other thing to know is, 20141008 01:19:28< iceiceice> ivanovic is the translation manager, 20141008 01:19:44< iceiceice> translating all the game strings is a lot of work, and we don't like to give translators a moving target 20141008 01:19:55< shadowm> iceiceice: I'm now confused, reading your PM about the Windows issue. There is another required branch in addition to AI0867:SDL_RWops? 20141008 01:20:01< iceiceice> so we go into "string-freeze" about the same time as we go into feature freeze in the development cycle 20141008 01:20:15< iceiceice> in string freeze, you can't add any new translatable strings 20141008 01:20:37< iceiceice> so the moral of the story is, usually you should make a habit of putting _() on everything that might need it as soon as you write it 20141008 01:21:04< iceiceice> because its quite easy to forget and then you will have a headache if string freeze rolls around 20141008 01:22:06< iceiceice> sometimes if you have to you can do stuff like recycle other currently translated strings, but this is work you would rather not have to do 20141008 01:22:30< iceiceice> shadowm: my info is mostly based on, 20141008 01:22:37< iceiceice> AI0867's original email which i dug up 20141008 01:22:39< iceiceice> , 20141008 01:22:43< iceiceice> comments ont he PR 20141008 01:22:49< iceiceice> some things loonycyborg said on irc 20141008 01:23:23< iceiceice> ok, in PR 155: 20141008 01:23:27< shadowm> Well, loonycyborg only mentioned the SDL_RWops branch, so I'm assuming the "binary-only fix" in 1.11.16 is incomplete then. 20141008 01:23:40< iceiceice> AI0867: "Yes, this is a slice of my boost_filesystem branch. However, it was reported to me that on at least the machine of one windows dev, this slice was sufficient to fix unicode handling. (it's probably dependent on his settings, but still)" 20141008 01:24:24< shadowm> (Which would effectively mean my email still applies. :p ) 20141008 01:25:34< shadowm> iceiceice: Also, I don't think we'd need to cherry-pick from 1.12 to the P branch, we can just merge 1.12 into it every time instead (or even rebase it on top of 1.12 and force-push, though that'd probably cause some git clients to barf). 20141008 01:26:13< shadowm> The only risk is getting conflicts that'd need to be resolved as a single unit instead of per patch. 20141008 01:26:52< iceiceice> hmm if we merge 1.12 into it doesn't that add the patch we dont want? 20141008 01:27:03< iceiceice> i guess we'd need to put all bug fixes on the P branch, and merge that into 1.12 instead 20141008 01:27:23< shadowm> No, that'd add the patches we don't want on 1.12 to 1.12. 20141008 01:27:34< iceiceice> there are no pandora specific patches though 20141008 01:27:42< iceiceice> there is only this one patch that hsould go on 1.12 but not on pandora 20141008 01:27:43< shadowm> Er, right. 20141008 01:27:48< shadowm> I was looking at the issue backwards. 20141008 01:27:55< iceiceice> i think #ifdefs is better 20141008 01:28:06< iceiceice> if the PR were bigger i would say to use a branch, 20141008 01:28:07< shadowm> I had considered merging the relevant patches into 1.12 and then reverting them in the pandora-1.12 branch. 20141008 01:28:10< iceiceice> but this looks feasible to #ifdef 20141008 01:28:22< iceiceice> imo 20141008 01:28:33< shadowm> So the pandora-1.12 gets to exist as a tiny set of patches (or even a single patch) that gets merged on top of 1.12 every time. 20141008 01:28:42-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 01:28:43< iceiceice> oh hmm 20141008 01:29:05< iceiceice> yeah thats also a pretty good idea 20141008 01:29:15< iceiceice> then people can just ignore the new branch and cherry-pick to 1.12 as usual 20141008 01:29:15< shadowm> That said, I'd prefer the #ifdef approach too, and the SDL_RWops changes seem small enough to make this feasible. 20141008 01:29:31< shadowm> However, I doubt it actually fixes anything, here's why. 20141008 01:30:14< shadowm> It delegates the responsibility for handling multibyte chars in paths correctly to the existing iostreams implementation. I'm pretty sure that's exactly what's broken for those people who get errors when (auto)saving games. 20141008 01:30:43< shadowm> At least with mingw32's iostreams implementation. (I'd not be surprised if MSVC++ did it right.) 20141008 01:33:13-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 244 seconds] 20141008 01:33:58< iceiceice> yeah i dont know this stuff 20141008 01:38:48< shadowm> iceiceice: Ohhh, I understand the issue in #22544 now. 20141008 01:39:23< shadowm> When you said 'darkened' I didn't think it meant 'with fog overlaid on top'. 20141008 01:39:54< shadowm> So I didn't, in fact, start the scenario with fog enabled. 20141008 01:40:05< iceiceice> can you reproduce it? 20141008 01:40:31< shadowm> Yes. 20141008 01:41:08< shadowm> It's not a bug with the game engine. 20141008 01:41:16< shadowm> {PLACE_HALO "units/saurians/soothsayer/soothsayer-ne-run6.png~FL()~RC(magenta>5)" 42 8} 20141008 01:41:19< shadowm> {PLACE_IMAGE "units/saurians/oracle/oracle-se-melee3.png~FL()~RC(magenta>5)" 36 4} 20141008 01:41:35< shadowm> Halos don't really layer the same way as [item] images, on purpose. 20141008 01:42:54< shadowm> Furthermore, this also affects 1.10. 20141008 01:43:28< LovCAPONE> iceiceice: Ok thanks for the translation explenation! Pretty clever indeed 20141008 01:44:26< shadowm> There is, however, a glitch involving mousing over 48,19 and presumably any other hex where a non-maskable (with the 72x72 hex mask) image is used. 20141008 01:45:16< shadowm> That'd be a long-standing issue that couldn't feasibly be fixed without a rewrite of item (and terrain) rendering. 20141008 01:45:30< shadowm> tl;dr this map is badly designed. 20141008 01:45:53< iceiceice> hmm ok 20141008 01:46:04< iceiceice> well as long as its not an engine bug thats good 20141008 01:46:11< iceiceice> it does look wierd so i thought i would report it 20141008 01:46:25< shadowm> It's not a bug, but rather a limitation. 20141008 01:46:30< iceiceice> it is mainline so i guess someone could change the halo's to images? 20141008 01:46:37< iceiceice> would that make them all fogged the same way 20141008 01:46:47< iceiceice> but not really a big deal i guess 20141008 01:46:55< shadowm> Then we'd get more masking glitches because the haloed images are non-maskable. 20141008 01:47:22< shadowm> Halos aren't constrained by masking, at the expense of rendering performance. 20141008 01:47:50< iceiceice> hmm so what makes some images maskable / nonmaskable? 20141008 01:48:01< iceiceice> also what does that mean :) 20141008 01:48:06< shadowm> Whether they fit in the 72x72 hex mask. 20141008 01:48:14< iceiceice> oh i see 20141008 01:48:29< shadowm> data/core/images/terrain/alphamask.png, for reference. 20141008 01:49:12< shadowm> Back in the day (1.3.x) we artists actually had to watch out for this stuff with unit baseframes. The constraint was lifted from standing unit animations in 1.5.x or 1.7.x. 20141008 01:50:08< shadowm> I think what we could do is replace those halos with multi-hex [terrain_graphics] rules. 20141008 01:50:28-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 01:51:45< shadowm> Terrain rendering is similarly constrained to the 72x72 mask, but there are rules that allow slicing a single image into several hexes to work around the limitation. That's IIRC how villages are implemented, to name an example. 20141008 01:54:09< mattsc> iceiceice, shadowm: sorry for running off like that. Real life interfering … 20141008 01:54:44< mattsc> Anything I should do right now? (I haven’t even read up on things yet) 20141008 01:55:03-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 258 seconds] 20141008 01:55:55< iceiceice> shadowm: thanks for explanation 20141008 01:55:55< shadowm> As far as I can see, we are still stuck due to insufficient/fragmented information on these bugfix branches, so we might still need to pester AI0867 about them. 20141008 01:56:01< mattsc> If not, I’ll work some on my two posts to the mailing list (about the 1.11.17 and 1.12.0 releases). 20141008 01:56:02< iceiceice> LovCAPONE: no problem 20141008 01:56:12< iceiceice> mattsc: it sounds like, 20141008 01:56:27< iceiceice> the SDL_rwops might fix something for someone but won't really fix the issue 20141008 01:57:09< iceiceice> depending on ... technical things about the quality of a particular compiler's standard library 20141008 01:58:48< mattsc> iceiceice: okay, that’s too bad 20141008 02:01:23< mattsc> So is pestering AI0867 the only option at this time? There’s no fall-back plan? 20141008 02:05:01-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20141008 02:08:03< iceiceice> i think we set ourselves up for this by blocking the patch for so long... 20141008 02:08:44< mattsc> iceiceice: that might be true and that’s too bad, but it’s the situation we’re in right now. So how do we get out of it? 20141008 02:08:48< iceiceice> if AI0867 doesnt save the day i doubt we will be able to fix the bug 20141008 02:09:14< mattsc> (and I mean that as an honest question, as I personally don’t know anything about it) 20141008 02:09:25< mattsc> (other than what you guys have told me) 20141008 02:12:06-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 02:16:39-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 246 seconds] 20141008 02:22:56-!- gfgtdf [~chatzilla@e176187184.adsl.alicedsl.de] has joined #wesnoth-dev 20141008 02:22:58< shadowm> I would defer to AI0867's knowledge of his own patch since I can only speculate (based on simple logic), because in truth I don't fully understand some of the involved elements. (For whatever reason, stream-based I/O concepts have always gone above my head.) 20141008 02:23:02< shadowm> *patches 20141008 02:25:31< shadowm> LovCAPONE: I've not read #278 in its entirety and I don't think I'd be able to help much because it deals with MP stuff, so I just wanted to point out that on Linux, the default player name for logging into the MP server is the name associated to the user running the Wesnoth process. 20141008 02:26:23< LovCAPONE> shadowm, ah ok. Because on my build it was "player", wich is really generic 20141008 02:27:19< shadowm> So the thing gfgtdf said. 20141008 02:28:21-!- Ivanovic_ [~ivanovic@frnk-d93332d7.pool.mediaWays.net] has joined #wesnoth-dev 20141008 02:28:22< shadowm> It's remarkably lazy about it, though: char* const login = getenv("USER"); 20141008 02:29:59< LovCAPONE> shadowm: ok should I try to fix it for Windows? 20141008 02:31:21-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 246 seconds] 20141008 02:31:21< shadowm> Well, if you know how to use the Win32 API to get the account name for the user Wesnoth is running as... 20141008 02:32:16< LovCAPONE> Ok I'll put it on my to-do list :) 20141008 02:32:17-!- Ivanovic_ is now known as Ivanovic 20141008 02:32:55< shadowm> Even better question: is it worth it? The MP server only accepts nicknames containing a limited set of ASCII characters. 20141008 02:33:26< shadowm> I believe Unix systems traditionally have similar constraints, whereas I'd not be surprised if Windows allowed Unicode usernames. 20141008 02:33:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds] 20141008 02:33:52-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 02:34:11-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 02:34:33 * shadowm <- not a Windows user. 20141008 02:37:02< shadowm> Ah, GetUserName(). 20141008 02:38:40-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 260 seconds] 20141008 02:38:58< LovCAPONE> returns TCHARs.. so the answer is no 20141008 02:39:28< gfgtdf> LovCAPONE: to which question ? 20141008 02:39:50< shadowm> Why not? IIRC TCHAR is what the Win32 documentation calls a type that can be a UCHAR (_UNICODE defined) or plain char (_UNICODE not defined). 20141008 02:40:10< LovCAPONE> gfgtdf: if in Windows we can have unicode in username 20141008 02:40:24< shadowm> Plus it's also possible to call the ANSI version directly regardless, GetUserNameA(). 20141008 02:40:26< LovCAPONE> shadowm: TCHAR is a "char"... 20141008 02:40:51< LovCAPONE> shadowm: aahhhh 20141008 02:40:54< LovCAPONE> true 20141008 02:40:56< LovCAPONE> sorry yeah 20141008 02:43:28< gfgtdf> i also don't know whether our server allows whitespaces in names 20141008 02:44:02< shadowm> char foo[SOME_LARGE_SIZE] = { '\0' }; size_t bar = sizeof(foo); if (GetUserNameA(foo, &bar) != 0) { /* success */ } else { /* failed */ } 20141008 02:44:06< shadowm> Or so. 20141008 02:44:46< shadowm> We could even use the Unicode version, really. Either version is likely to throw characters that the MP server won't accept. 20141008 02:45:32< gfgtdf> shadowm: do we ahve a utf16 to utf8 fucntion ? in unicode.hpp i only see utf8 to utf16 20141008 02:46:30< shadowm> template<> inline utf16::string unicode_cast(const utf8::string &in) ? 20141008 02:47:00< shadowm> Not sure, because I'm more familiarized with this stuff pre-redesign. It used to be called something else. 20141008 02:47:45< gfgtdf> shadowm: the wirst parameter it "to" the second is "from" 20141008 02:47:48< gfgtdf> first* 20141008 02:48:47< shadowm> Well, that's inconvenient but not unsolvable. 20141008 02:49:12< shadowm> First convert incoming UTF16 string to UTF32 (UCS4), then to UTF8. 20141008 02:50:47< gfgtdf> shadowm: the second parameter is deduced by the parameter. 20141008 02:51:19< gfgtdf> shadowm: i didnt find utf16 to utf32 20141008 02:52:24< shadowm> Well too bad, somebody will need to write one then. 20141008 02:52:35< LovCAPONE> ok I'm quitting for the night 20141008 02:52:48< LovCAPONE> gfgtdf: I made a commit for PR 288... 20141008 02:52:55< LovCAPONE> you can check it out when you have 20141008 02:52:58< shadowm> I surmise it's just a matter of casting every char to a larger size, but I'm probably wrong because Unicode is so complicated. 20141008 02:52:58< LovCAPONE> time* 20141008 02:53:14-!- LovCAPONE is now known as LovAFK 20141008 02:53:16< shadowm> *16 bit-sized char. 20141008 02:54:33-!- DDR [~david@ec2.happyspork.com] has left #wesnoth-dev [] 20141008 02:55:33-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 02:58:47 * shadowm is quite sure he was supposed to look at some code other than the Windows fs stuff. 20141008 02:59:30-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev 20141008 03:00:12-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 245 seconds] 20141008 03:09:11-!- gfgtdf [~chatzilla@e176187184.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 32.0.3/20140923175406]] 20141008 03:10:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20141008 03:17:16-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 03:20:17< irker658> wesnoth: Ignacio R. Morelle wesnoth:master 8c5ac3c9fbda / changelog src/gui/dialogs/gamestate_inspector.cpp: gui2/tgamestate_inspector: Include array subscripts for WML array elements http://git.io/dmngKA 20141008 03:20:20< irker658> wesnoth: Ignacio R. Morelle wesnoth:master ecd25dc33c7f / src/gui/dialogs/gamestate_inspector.cpp: gui2/tgamestate_inspector: Only display N/M page indicators when M > 1 http://git.io/VrmJag 20141008 03:21:57-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 245 seconds] 20141008 03:33:22-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds] 20141008 03:38:59-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 03:43:45-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 272 seconds] 20141008 03:57:20-!- Sulfur [~Miranda@p5B00885F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141008 03:58:50-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20141008 04:00:44-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 04:01:36-!- kex [~kex@46.217.87.221] has quit [Read error: Connection reset by peer] 20141008 04:01:56-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 04:06:27-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 245 seconds] 20141008 04:23:44-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20141008 04:52:33-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev 20141008 04:55:13-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20141008 04:56:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now] 20141008 05:03:10-!- cib0 [~cib@p5DD22847.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141008 05:06:47-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20141008 05:16:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 05:39:30-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Quit: eh] 20141008 05:40:37-!- mantis_ [~mantis@ip68-4-246-66.oc.oc.cox.net] has joined #wesnoth-dev 20141008 05:40:50< mantis_> Hello all. 20141008 05:42:28< mantis_> Can anyone help point me in the right direction? 20141008 05:43:07< vultraz> which direction is that? 20141008 05:44:08-!- cib0 [~cib@p5DD22847.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds] 20141008 05:44:10< mantis_> I am looking to create a fork of the project, but I cannot seem to find any information on the add-on or production level server. 20141008 05:44:33< mantis_> I want to assist with the Wesnoth project, as well as develop my own standalone project based on the core of Wesnoth. 20141008 05:48:35-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: ancestral] 20141008 05:48:37-!- Ivanovic [~ivanovic@frnk-d93332d7.pool.mediaWays.net] has quit [Changing host] 20141008 05:48:37-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20141008 05:53:44-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20141008 05:54:07< mantis_> I have looked through the wiki and the forum, and have not found anything. 20141008 05:55:34< vultraz> talk to iceiceice 20141008 05:57:35< mantis_> Thanks! I have spent the last week looking over every bit of documentation I could find. 20141008 06:14:16-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 260 seconds] 20141008 06:17:20-!- mantis_ [~mantis@ip68-4-246-66.oc.oc.cox.net] has quit [] 20141008 06:20:24-!- irker658 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20141008 06:48:33-!- Sulfur [~Miranda@p5B00885F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141008 06:54:47-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 272 seconds] 20141008 06:55:14-!- enchilado [~enchilado@130.102.73.3] has joined #wesnoth-dev 20141008 06:59:02-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 245 seconds] 20141008 07:09:09-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20141008 07:12:10-!- mantis_ [~mantis@ip68-4-246-66.oc.oc.cox.net] has joined #wesnoth-dev 20141008 07:12:40-!- enchilado [~enchilado@130.102.73.3] has quit [Changing host] 20141008 07:12:40-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20141008 07:14:14-!- mantis_ [~mantis@ip68-4-246-66.oc.oc.cox.net] has quit [Remote host closed the connection] 20141008 07:14:37-!- Sulfur [~Miranda@p5B00885F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141008 07:23:08-!- mantis_ [~mantis@ip68-4-246-66.oc.oc.cox.net] has joined #wesnoth-dev 20141008 07:23:39-!- mantis_ [~mantis@ip68-4-246-66.oc.oc.cox.net] has quit [Client Quit] 20141008 07:44:08-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20141008 07:49:09-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev 20141008 08:08:28-!- Coffee_irc [~david@ppp118-210-39-35.lns20.adl2.internode.on.net] has joined #wesnoth-dev 20141008 08:14:38< shadowm> Unless you need to provide me with confidential information, I'd rather give support on the public channel than in private queries (esp. since I cannot respond to a query when you aren't online). 20141008 08:25:52< vultraz> shadowm: sorry, I referred him to you 20141008 08:25:59< vultraz> didn't know he would pc 20141008 08:28:45-!- LovAFK [~LovCAPONE@modemcable210.107-82-70.mc.videotron.ca] has quit [Ping timeout: 260 seconds] 20141008 08:29:17< shadowm> We all PC. 20141008 08:29:43< shadowm> Except those crazy people using Raspberry Pis for IRC, I guess. 20141008 08:30:05< vultraz> Was that a deliberate pun 20141008 08:30:09< vultraz> ? 20141008 08:30:41< shadowm> You said PC first. 20141008 08:34:22-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds] 20141008 08:37:24-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20141008 08:37:34-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 258 seconds] 20141008 08:38:40< vultraz> shadowm: pardon, what were you saying? 20141008 09:02:33-!- mjs-de [~mjs-de@f048036225.adsl.alicedsl.de] has joined #wesnoth-dev 20141008 09:04:56-!- kex [~kex@46.217.87.221] has joined #wesnoth-dev 20141008 10:07:29-!- Anakonda [Anakonda@87-92-233-213.bb.dnainternet.fi] has joined #wesnoth-dev 20141008 10:10:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141008 10:26:48-!- prkc [~prkc@catv-80-99-60-5.catv.broadband.hu] has joined #wesnoth-dev 20141008 10:36:44-!- Necrosporus_ is now known as Necrosporus 20141008 10:39:17-!- Sulfur [~Miranda@p5B00885F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141008 10:41:24-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev 20141008 11:11:13-!- Netsplit *.net <-> *.split quits: ryao 20141008 11:11:29-!- ryao [~ryao@gentoo/developer/ryao] has joined #wesnoth-dev 20141008 11:20:34-!- Kexoth [~kex@79.125.205.132] has joined #wesnoth-dev 20141008 11:23:17-!- kex [~kex@46.217.87.221] has quit [Ping timeout: 260 seconds] 20141008 11:31:08-!- Coffee_irc [~david@ppp118-210-39-35.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!] 20141008 11:34:35-!- Sulfur [~Miranda@p5B00885F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141008 11:41:24-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Quit: DCW] 20141008 11:43:36< ancestral> 1.12, aka 1.C 20141008 11:43:51-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.] 20141008 11:45:11-!- prkc [~prkc@catv-80-99-60-5.catv.broadband.hu] has quit [Remote host closed the connection] 20141008 12:58:47-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev 20141008 13:19:39-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20141008 13:23:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 13:46:03-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Quit: .] 20141008 13:59:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141008 14:00:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20141008 14:01:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit] 20141008 14:15:40-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping] 20141008 14:20:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 14:27:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 14:38:49-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20141008 14:47:28-!- prkc [~prkc@catv-80-99-60-5.catv.broadband.hu] has joined #wesnoth-dev 20141008 14:56:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 15:00:01-!- irker432 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20141008 15:00:01< irker432> wesnoth: mattsc wesnoth:master fd9cda9cd223 / changelog: Update changelog http://git.io/Wa2l1Q 20141008 15:00:12< irker432> wesnoth: mattsc wesnoth:1.12 320821eafbb6 / changelog: Update changelog http://git.io/fQw4Tg 20141008 15:03:40< irker432> wesnoth: mattsc wesnoth:1.12 cf253e2359f0 / changelog: Fix changelog formatting http://git.io/Xn73ig 20141008 15:07:56< vultraz> mattsc: I wrote to Turuk about the trailer, but I think it unlikely he'll respond before the release 20141008 15:12:50< mattsc> vultraz: Thanks. Yeah, Turuk doesn’t seem to be around at the moment. Let me know if you hear anything. 20141008 15:13:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141008 15:35:26-!- LovAFK [~LovCAPONE@modemcable052.221-21-96.mc.videotron.ca] has joined #wesnoth-dev 20141008 15:36:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 15:37:13-!- ancestral [~ancestral@17.114.45.53] has joined #wesnoth-dev 20141008 15:48:10-!- Sulfur [~Miranda@p5B00885F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141008 15:50:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 15:51:33-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 15:58:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 16:02:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 16:02:39-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20141008 16:03:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20141008 16:06:42-!- Fortescue is now known as Forteskeleton 20141008 16:07:03-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 272 seconds] 20141008 16:34:51-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141008 16:38:10-!- Kexoth [~kex@79.125.205.132] has quit [Remote host closed the connection] 20141008 16:38:57-!- travis-ci [~travis-ci@ec2-54-226-203-200.compute-1.amazonaws.com] has joined #wesnoth-dev 20141008 16:38:57< travis-ci> gfgtdf/wesnoth-old#242 (utf16_to_utf32 - b9d7e31 : gfgtdf): The build failed. 20141008 16:38:57< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/37413720 20141008 16:38:57-!- travis-ci [~travis-ci@ec2-54-226-203-200.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141008 16:39:20-!- kex [~kex@79.125.205.132] has joined #wesnoth-dev 20141008 16:46:52-!- gfgtdf [~chatzilla@e176187184.adsl.alicedsl.de] has joined #wesnoth-dev 20141008 16:47:15< gfgtdf> travis complains about cstdint what can i use instead ? 20141008 16:49:54< gfgtdf> ok it seems liek stdint.h is eactly the same as cstdint but it also alloed pre c++11 20141008 16:51:39-!- Sulfur [~Miranda@p5B00885F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141008 17:07:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 17:10:46< gfgtdf> shikadibot: seen aquileia 20141008 17:10:46< shikadibot> gfgtdf: Sorry, I don't know of aquileia. 20141008 17:21:09< gfgtdf> shikadibot: seen AI0867 20141008 17:21:09< shikadibot> gfgtdf: Queried user AI0867 is currently here and on the channels ##shadowm, #wesnoth-thunderstone and #wesnoth-umc-dev. 20141008 17:29:25-!- travis-ci [~travis-ci@ec2-54-226-203-200.compute-1.amazonaws.com] has joined #wesnoth-dev 20141008 17:29:25< travis-ci> gfgtdf/wesnoth-old#243 (utf16_to_utf32 - 7fe069c : gfgtdf): The build is still failing. 20141008 17:29:25< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/37416523 20141008 17:29:25-!- travis-ci [~travis-ci@ec2-54-226-203-200.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141008 17:29:32< mattsc> gfgtdf: hi 20141008 17:30:03-!- Sulfur [~Miranda@p5B00885F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141008 17:30:04-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141008 17:31:11< mattsc> gfgtdf: you have a few bugs on the tracker that were marked as “ready for test” (or similar) quite some time ago. Could you go through them sometime and mark those that can be closed as fixed? 20141008 17:31:26< mattsc> We’ll then close them after 1.11.17 is out. 20141008 17:31:46< gfgtdf> gfgtdf: bugs that are siigned to me ? 20141008 17:32:14< mattsc> That either are assigned to you or that you worked/commented on. I don’t remember in detail. 20141008 17:33:14< mattsc> Also, “quite a few” might mean 2 or 3. :P I’ve poked around on the bug tracker a lot over the last couple days and didn’t take detailed notes. 20141008 17:33:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 17:34:11< gfgtdf> mattsc: i know that there is at least one bug that i only fixed on master but not on 12 20141008 17:35:17-!- kex [~kex@79.125.205.132] has quit [Remote host closed the connection] 20141008 17:39:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 17:51:04< gfgtdf> mattsc: ok i maked 2 bugs as fixed, still remaining is https://gna.org/bugs/index.php?22068 which i have only fixed on master maybe thunderstruck fixed it on 1.11 but im not sure 20141008 17:52:15< gfgtdf> mattsc: my fix is rather complicated and also changes the wesnothd protocoll and slightly the savefile format that's why i didnt backport. 20141008 17:52:24< gfgtdf> for 22068 i mean 20141008 17:59:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141008 18:01:29-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20141008 18:02:02-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has joined #wesnoth-dev 20141008 18:10:44< mattsc> gfgtdf: okay, thanks 20141008 18:11:44-!- DCW [~Thunderbi@cpc66863-finc15-2-0-cust393.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20141008 18:13:57< mattsc> gfgtdf: #22068 is marked as a blocker; what do we need to do about it for 1.12? 20141008 18:15:36< gfgtdf> mattsc: o teh discussion of 22068 thunderstruck had mentioned https://github.com/thunderstruck/wesnoth/commit/59a31f26d0fe3aa19ab3aa8f5b18c576eb14f239 20141008 18:15:40< gfgtdf> idk whether that works 20141008 18:16:58< mattsc> He also mentions that that doesn’t work 100% 20141008 18:17:27< mattsc> I currently have this bug as a “can be closed” with question “fixed in master, but not in 1.12?” in the list of must-fix bugs. Looks like I need to move it up to category 1? 20141008 18:17:44-!- gfgtdf_ [~chatzilla@e176187184.adsl.alicedsl.de] has joined #wesnoth-dev 20141008 18:18:06< mattsc> thunderstruck: could you comment on this, please? 20141008 18:20:29-!- gfgtdf [~chatzilla@e176187184.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds] 20141008 18:20:38-!- gfgtdf_ is now known as gfgtdf 20141008 18:27:09< thunderstruck> mattsc, gfgtdf: my commit does not fully fix the bug. IIRC, with my commit you can launch start-of-scenario saves, but because some data would be missing or incorrectly set up, there would still be problems. 20141008 18:27:18< thunderstruck> In particular, I think that I saw OOS occuring. 20141008 18:27:27< thunderstruck> Or sides messed up.. 20141008 18:27:44< thunderstruck> I can't really remember very well. I should've written it up properly. 20141008 18:28:23< thunderstruck> Also note that commit is not merged into 1.12 branch. 20141008 18:29:43< mattsc> thunderstruck: thanks. So this is marked as a blocker bug. Which means we need to do something about it or we cannot release 1.12.0. What can we do about it? 20141008 18:32:36< thunderstruck> mattsc: I could try looking into it again. I believe I should use my fix attempt and determine what's wrong with the sos saves when they are loaded. 20141008 18:32:46< thunderstruck> However, I'm a bit busy these days. 20141008 18:33:05< thunderstruck> But I should be able to find some time this weekend. 20141008 18:33:24< mattsc> thunderstruck: that would be fantastic if possible 20141008 18:33:35-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer] 20141008 18:33:36< thunderstruck> Yeah, but I'm not really an expert in that area. 20141008 18:33:56< mattsc> Who is the expert? 20141008 18:34:16< thunderstruck> I just attempted to fix it since my work was mostly MP related and I wanted to improve MP. 20141008 18:34:27-!- irker432 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20141008 18:34:39< thunderstruck> mattsc: I don't know really. This bug was introduced by ayne I believe. But she is not around anymore. 20141008 18:35:23< mattsc> Right - well let me try something ... 20141008 18:35:54< mattsc> I’m going to assign the bug to her; she has previously responded to that, but admittedly the last time was quite some time ago. 20141008 18:36:19< mattsc> If that doesn’t work, maybe you could have a look at it after all? 20141008 18:36:50< mattsc> thunderstruck: and don’t worry about the 1.11.17 release this weekend; we really need this fixed for 1.12.0 (but the sooner the better, of course, so that it can be tested a bit). 20141008 18:39:40< mattsc> gfgtdf: so I took #22068 away from you ;) 20141008 18:39:59< mattsc> thunderstruck: if Ayne does not react within a few days, should I assign it to you then? 20141008 18:41:19< thunderstruck> mattsc: Yes. Although I'll try to look into it this weekend. I'll be travelling to the USA soon and so I won't be able to look into it then. 20141008 18:42:22< mattsc> thunderstruck: sounds great, thank you. The last time we have done this (assigned a bug to Ayne), she responded very quickly, within a day or so. So we’ll likely know by the weekend anyway. 20141008 18:43:45-!- travis-ci [~travis-ci@ec2-54-92-189-237.compute-1.amazonaws.com] has joined #wesnoth-dev 20141008 18:43:45< travis-ci> gfgtdf/wesnoth-old#244 (utf16_to_utf32 - 42e9875 : gfgtdf): The build was fixed. 20141008 18:43:45< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/37423130 20141008 18:43:45-!- travis-ci [~travis-ci@ec2-54-92-189-237.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141008 18:54:58< gfgtdf> are teh .po translation files all utf8 encoded ? 20141008 19:07:54-!- irker820 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20141008 19:07:54< irker820> wesnoth: Chris Beck wesnoth:master dc861ea13200 / src/map_label.cpp: fix bug #22251 (map labels not appearing in mp) http://git.io/JAjgVw 20141008 19:07:54< irker820> wesnoth: Chris Beck wesnoth:master a0a597a266d3 / changelog: update changelog http://git.io/oCmUBg 20141008 19:07:55< irker820> wesnoth: Chris Beck wesnoth:master bbb0c8a926ef / / (5 files in 4 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/9PAzZg 20141008 19:07:58< irker820> wesnoth: Chris Beck wesnoth:1.12 6e8c186dc95a / src/map_label.cpp: fix bug #22251 (map labels not appearing in mp) http://git.io/5_2MzQ 20141008 19:07:58-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 19:08:00< irker820> wesnoth: Chris Beck wesnoth:1.12 667d6eb7e874 / changelog: update changelog http://git.io/ttnzew 20141008 19:08:02< irker820> wesnoth: Chris Beck wesnoth:1.12 05bb3359319c / changelog data/scenario-test.cfg src/play_controller.cpp src/team.hpp: Merge branch '1.12' of https://github.com/wesnoth/wesnoth into 1.12 http://git.io/3U2_fw 20141008 19:12:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 19:14:01-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141008 19:14:04< iceiceice> gfgtdf: yes, they are 20141008 19:14:33< gfgtdf> iceiceice: ok ty 20141008 19:14:54< iceiceice> travis checks it actually, if one of them is not utf8 it makes the build fail 20141008 19:16:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20141008 19:19:01-!- ancestral is now known as ancestral_caffe 20141008 19:24:43-!- travis-ci [~travis-ci@ec2-54-92-189-237.compute-1.amazonaws.com] has joined #wesnoth-dev 20141008 19:24:43< travis-ci> gfgtdf/wesnoth-old#245 (utf16_to_utf32 - 584ad7f : gfgtdf): The build was fixed. 20141008 19:24:43< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/37424903 20141008 19:24:43-!- travis-ci [~travis-ci@ec2-54-92-189-237.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141008 19:36:44-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev 20141008 19:49:25< gfgtdf> is there someone except AI0867 who knows about the unicode stuff? especiqaly someone who is capable of rewiewing https://github.com/wesnoth/wesnoth/pull/293 ? 20141008 19:56:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 19:58:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141008 20:23:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 20:33:17-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 20:35:45-!- fabi_ [~fabi@p54863F63.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141008 20:35:45-!- fabi_ [~fabi@p54863F63.dip0.t-ipconnect.de] has quit [Changing host] 20141008 20:35:45-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20141008 20:36:42-!- TC01 [~quassel@magellan.acm.jhu.edu] has quit [Ping timeout: 246 seconds] 20141008 20:37:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20141008 20:38:07-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141008 20:38:32-!- gfgtdf [~chatzilla@e176187184.adsl.alicedsl.de] has quit [Read error: Connection reset by peer] 20141008 20:43:52-!- ancestral_caffe is now known as ancestral 20141008 20:52:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 20:53:21-!- ancestral [~ancestral@17.114.45.53] has quit [Quit: ancestral] 20141008 20:55:32-!- TC01 [~quassel@magellan.acm.jhu.edu] has joined #wesnoth-dev 20141008 20:57:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141008 21:02:41-!- travis-ci [~travis-ci@ec2-54-92-189-237.compute-1.amazonaws.com] has joined #wesnoth-dev 20141008 21:02:41< travis-ci> gfgtdf/wesnoth-old#247 (utf16_to_utf32 - 9faf742 : gfgtdf): The build was broken. 20141008 21:02:41< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/37436471 20141008 21:02:41-!- travis-ci [~travis-ci@ec2-54-92-189-237.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141008 21:06:52-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Remote host closed the connection] 20141008 21:13:32-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar] 20141008 21:16:21-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141008 21:29:00-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev 20141008 21:29:04-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host] 20141008 21:29:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141008 21:30:14-!- gfgtdf [~chatzilla@e176187184.adsl.alicedsl.de] has joined #wesnoth-dev 20141008 21:36:27-!- travis-ci [~travis-ci@ec2-54-226-203-200.compute-1.amazonaws.com] has joined #wesnoth-dev 20141008 21:36:27< travis-ci> gfgtdf/wesnoth-old#250 (utf16_to_utf32 - f7a1f1b : gfgtdf): The build was broken. 20141008 21:36:27< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/37440554 20141008 21:36:27-!- travis-ci [~travis-ci@ec2-54-226-203-200.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141008 21:49:33-!- gfgtdf_ [~chatzilla@e177116032.adsl.alicedsl.de] has joined #wesnoth-dev 20141008 21:50:16-!- gfgtdf_ [~chatzilla@e177116032.adsl.alicedsl.de] has quit [Read error: Connection reset by peer] 20141008 21:51:22-!- gfgtdf [~chatzilla@e176187184.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds] 20141008 21:51:22-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20141008 21:56:22-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds] 20141008 21:58:07-!- ancestral [~ancestral@17.114.45.53] has joined #wesnoth-dev 20141008 22:05:06-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds] 20141008 22:08:29-!- gfgtdf [~chatzilla@e177116032.adsl.alicedsl.de] has joined #wesnoth-dev 20141008 22:10:05-!- fabi_ [~fabi@p5B3C6265.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141008 22:10:05-!- fabi_ [~fabi@p5B3C6265.dip0.t-ipconnect.de] has quit [Changing host] 20141008 22:10:05-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20141008 22:13:12< shadowm> Okay. 20141008 22:13:46< shadowm> It's been nearly two years and I just realized the existence of the new savanna forest terrain in 1.12. 20141008 22:15:24-!- mjs-de [~mjs-de@f048036225.adsl.alicedsl.de] has quit [Remote host closed the connection] 20141008 22:18:27< gfgtdf> iceiceice: my travis buidl failed (https://s3.amazonaws.com/archive.travis-ci.org/jobs/37440557/log.txt) and i believe it's becasue of the boost unit tests is thewre a wys i can find out what exactly goes wrong? 20141008 22:22:21< iceiceice> hmm... 20141008 22:22:43< iceiceice> i think you gotta compile the test executable and run debugger 20141008 22:22:49< iceiceice> i'm not sure why its not giving you better ouptut 20141008 22:23:14< iceiceice> i dont know what code 201 means 20141008 22:23:21< gfgtdf> iceiceice: maybe some sxception is thrown? 20141008 22:23:45< gfgtdf> iceiceice: does teh current VC9 build support boost units tests ? 20141008 22:23:46< iceiceice> yeah, iirc anyting over 128 is like, fatal / segfault / assertion etc. 20141008 22:24:01< iceiceice> i dont know 20141008 22:24:09< iceiceice> i never used VC 20141008 22:25:02< gfgtdf> iceiceice: unitd clang is teh test in th same executable or a diffreent executable ? 20141008 22:25:33-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!] 20141008 22:25:43< iceiceice> for scons, there's a target "test" 20141008 22:25:48< iceiceice> you can type "scons test" and it will get it, 20141008 22:25:55< iceiceice> its also in the default build target it hink 20141008 22:26:04< iceiceice> it gives you an executable just called test 20141008 22:27:28< shadowm> The test suite is not part of the default list of targets. 20141008 22:28:31< iceiceice> right you are 20141008 22:29:35-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20141008 22:31:06< iceiceice> gfgtdf: i tried building your branch, this is what i got: http://hastebin.com/yijexajima.vbs 20141008 22:31:50< iceiceice> i have to go, i can be back a little later 20141008 22:32:05-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141008 22:32:08< gfgtdf> iceiceice: ok ty :) 20141008 22:34:55< shadowm> Tsk, tsk, UtBS S6a/6b use one-hex-wide passages. 20141008 22:35:54-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds] 20141008 22:40:19-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping] 20141008 22:40:52-!- fabi_ [~fabi@p548634BC.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141008 22:40:52-!- fabi_ [~fabi@p548634BC.dip0.t-ipconnect.de] has quit [Changing host] 20141008 22:40:52-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20141008 22:43:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141008 22:43:59-!- gfgtdf [~chatzilla@e177116032.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 32.0.3/20140923175406]] 20141008 22:44:32-!- Anakonda [Anakonda@87-92-233-213.bb.dnainternet.fi] has quit [Read error: Connection reset by peer] 20141008 22:56:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds] 20141008 23:04:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20141008 23:11:51-!- travis-ci [~travis-ci@ec2-54-92-189-237.compute-1.amazonaws.com] has joined #wesnoth-dev 20141008 23:11:51< travis-ci> gfgtdf/wesnoth-old#251 (utf16_to_utf32 - 5e20472 : gfgtdf): The build was fixed. 20141008 23:11:51< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/37449331 20141008 23:11:51-!- travis-ci [~travis-ci@ec2-54-92-189-237.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141008 23:34:53-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20141008 23:42:26-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev 20141008 23:47:35-!- ancestral [~ancestral@17.114.45.53] has quit [Quit: ancestral] 20141008 23:48:23-!- ancestral [~ancestral@17.114.45.53] has joined #wesnoth-dev 20141008 23:48:23-!- ancestral [~ancestral@17.114.45.53] has quit [Client Quit] 20141008 23:55:05< shadowm> EI's Weldyn Besieged scenario looks so plain compared to the rest. :\ 20141008 23:56:17-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] --- Log closed Thu Oct 09 00:00:28 2014