--- Log opened Tue Oct 14 00:00:43 2014 20141014 00:00:46-!- LovCAPONE [~LovCAPONE@modemcable052.221-21-96.mc.videotron.ca] has joined #wesnoth-dev 20141014 00:06:51-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has joined #wesnoth-dev 20141014 00:12:12-!- mjs-de [~mjs-de@f048181047.adsl.alicedsl.de] has quit [Remote host closed the connection] 20141014 00:12:43-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 255 seconds] 20141014 00:17:13-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 260 seconds] 20141014 00:17:36< iceiceice> is there anyone who knows how to fix bugs like this? 20141014 00:17:36< iceiceice> https://gna.org/bugs/index.php?22327 20141014 00:17:55< iceiceice> i don't even know who might be a reasonable person to ask about it 20141014 00:21:08< shadowm> Alarantalara worked a lot on terrain graphics WML, when he was around anyway. 20141014 00:25:15-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20141014 00:30:20< irker651> wesnoth: Ignacio R. Morelle glamdrol:master 07fe9d5b0290 / glamdrol/glamdrol.skin.php: Use wiki.w.o instead of w.w.o/wiki for the footer copyright link http://git.io/8uShpw 20141014 00:49:37-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20141014 01:01:25-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev 20141014 01:03:07-!- prkc [~prkc@catv-80-99-60-5.catv.broadband.hu] has quit [Remote host closed the connection] 20141014 01:05:41< irker651> wesnoth: fendrin wesnoth:1.12 7208f82efcd7 / data/campaigns/Legend_of_Wesmere/scenarios/ (17 files in 5 dirs): LoW: Fix errors reported by wmllint. http://git.io/T4BQPw 20141014 01:05:46-!- ancestral is now known as ancstrl_workdun 20141014 01:06:55-!- ancstrl_workdun [~ancestral@17.114.45.53] has quit [Quit: ancstrl_workdun] 20141014 01:08:58< mattsc> hi LovCAPONE. I’m only here for a few minutes right now, but I wanted to throw something out for you to think about. 20141014 01:09:48< mattsc> We’ve been sorely missing somebody who can handle the C++ side of the AI. Our AI guru is Crab_, but he has essentially no time to deal with this any more. 20141014 01:10:08< mattsc> I know how the AI works, but my C++ knowledge is very rudimentary. 20141014 01:11:14< mattsc> Now, there are (smallish) number of AI “features” (leftovers from Wesnoth 1.9, essentially) that really should be taken care of and that would be reasonably easy to fix. 20141014 01:12:00< mattsc> LovCAPONE: I’m wondering whether you’d be interested in looking into these a bit. And if you don’t that’s fine, just asking. 20141014 01:23:00< iceiceice> is there anyone online who knows stuff about the unit animation / drawing code? 20141014 01:23:12< iceiceice> i grepped around a little bit trying to find the cause of this: https://gna.org/bugs/index.php?21400 20141014 01:24:07-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has quit [Ping timeout: 272 seconds] 20141014 01:24:09< fabi_> mattsc: What about the wml lint tools? 20141014 01:24:19< fabi_> mattsc: Do we no longe use them? 20141014 01:24:24< iceiceice> i think it might be this: https://github.com/wesnoth/wesnoth/blob/1.12/src/unit.cpp#L1961 20141014 01:24:43< LovCAPONE> mattsc: right now I'm taking care of some of my last PRs. When I'm done with them I can see what I can do 20141014 01:24:49< iceiceice> fabi_: i think we use them 20141014 01:25:15< fabi_> Well, make unresolved is reporting a lot. 20141014 01:25:19< mattsc> fabi_: yes, I believe that they are (and should be) used 20141014 01:26:09< mattsc> fabi_: maybe we’re not talking about the same thing; I just mean the wmllint script itself 20141014 01:26:14< fabi_> mattsc: Then you should think about what to do to all the "make unresolved" output. 20141014 01:26:44< mattsc> fabi_: I don’t know what that means … 20141014 01:26:44< fabi_> mattsc: "make unresolved" calls "wmlscope". 20141014 01:27:03< fabi_> Which checks for the presence of macros and files. 20141014 01:27:26< mattsc> fabi_: okay, I have never used that. I’ve used wmlindent and wmllint 20141014 01:27:35< fabi_> That is fine. 20141014 01:27:36< mattsc> and I think those are the ones that should be run 20141014 01:27:49< fabi_> wmlscope is important as well. 20141014 01:28:15< fabi_> There is no other way to check for those stuff. 20141014 01:28:39-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has joined #wesnoth-dev 20141014 01:29:15< shadowm> wmlscope is horribly broken and eats babies. 20141014 01:29:57< shadowm> IIRC most of its output currently involves false positives due to its inability to handle the new animation syntax. 20141014 01:30:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141014 01:30:15< fabi_> it seems so 20141014 01:30:28< fabi_> The problem is that we can't do without. 20141014 01:30:33< fabi_> There is no alternative. 20141014 01:30:35< shadowm> So I didn't bother with it when I ran the tools before RC 1. 20141014 01:31:07< shadowm> The obvious solution is that someone who understands both Python and the new animation syntax fixes it. 20141014 01:31:14< fabi_> yeah 20141014 01:31:23< fabi_> before we attempt to release 1.12 20141014 01:31:38< shadowm> I wouldn't consider that a blocker for 1.12.0. 20141014 01:31:59< shadowm> Otherwise we'll be here forever. 20141014 01:32:23< fabi_> hmmmm 20141014 01:38:31< iceiceice> i think in wesnoth 2.0, we should use a parser generator to define wml... 20141014 01:38:46< iceiceice> if we used antlr for instance, i think it can generate parser code for both C++ and python 20141014 01:39:05< iceiceice> so it would save us some work on stuff like this 20141014 01:39:08< mattsc> fabi_: I can add it to the “highly desirable to be fixed, but will only happen if we find somebody to do it” list 20141014 01:40:38< fabi_> mattsc: Yeah, fine. I do not really know how to find unresolved references without wmlscope. 20141014 01:41:31< shadowm> You don't. :p Except by playtesting. 20141014 01:41:32< fabi_> And I wonder why we can be fine enough to go without such a proper check in a stable release... 20141014 01:41:46< fabi_> s/why/how 20141014 01:41:57< iceiceice> fabi_: what does wml_scope do? 20141014 01:42:12< fabi_> checks for files and macros. 20141014 01:42:21< iceiceice> what does that mean? 20141014 01:42:23< shadowm> wmlscope. 20141014 01:42:40< fabi_> Whenever something is referenced in the wmlcode the tools should check if it is really there. 20141014 01:43:26< shadowm> wmlscope can understand the WML just fine (although it has problems with preprocessor macros just like the other tools). 20141014 01:43:26-!- kex [~kex@212.158.180.26] has joined #wesnoth-dev 20141014 01:43:56< shadowm> The problem is that it hasn't been taught to understand the new animation syntax that's used on the right hand side of a key value pair. 20141014 01:44:33-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20141014 01:44:37< shadowm> The new syntax allows a single value to represent a whole set of paths. 20141014 01:45:48< iceiceice> i think if you defined WML in a precise way, you would include details like that 20141014 01:46:06< mattsc> LovCAPONE: there’s no rush whatsoever with this (it would be for master, not 1.12). So whenever you think you have time (and only if you are interested) ping me and I’ll tell you what I know. 20141014 01:47:40-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 260 seconds] 20141014 01:50:01-!- LovCAPONE [~LovCAPONE@modemcable052.221-21-96.mc.videotron.ca] has left #wesnoth-dev [] 20141014 01:51:59< iceiceice> anyone: i think i fixed bug #21400, if someone can pull this branch and test it i would appreciate 20141014 01:52:13< iceiceice> https://github.com/wesnoth/wesnoth/pull/298 20141014 01:52:26< iceiceice> or review it... 20141014 01:52:39< iceiceice> i don't really know this part of the code, would hate to introduce new bugs into 1.12 20141014 01:54:03< shadowm> Coffee_irc isn't here but he knows that stuff. 20141014 01:54:22< iceiceice> maybe we can assign the PR to him? 20141014 01:54:45< shadowm> Not sure if he'll see the notification, but sure. 20141014 01:55:17< shadowm> vultraz: So in retrospect, my complaint about the download button's hover state looking like it was pushed down was misdirected, sorry. I've PM'd LordBob about it. 20141014 01:55:55< vultraz> Is the lighting wrong? 20141014 01:56:04< shadowm> Yes. 20141014 02:09:32< shadowm> At this point it seems it'd be more practical for me to drop the dependency on glamdrol and move the relevant bits into intl.css. 20141014 02:12:45< vultraz> what does iltl stand for anyway. It seems a very ambiguous and vague name for a stylesheet 20141014 02:12:45-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer] 20141014 02:12:49< vultraz> intl* 20141014 02:14:16< vultraz> But yes, I agree 20141014 02:21:22-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has quit [Ping timeout: 240 seconds] 20141014 02:21:45-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has joined #wesnoth-dev 20141014 02:22:25-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20141014 02:23:16-!- Kexoth [~kex@89.205.48.13] has joined #wesnoth-dev 20141014 02:25:16-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141014 02:25:30-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 246 seconds] 20141014 02:26:20-!- Ivanovic_ is now known as Ivanovic 20141014 02:26:32-!- kex [~kex@212.158.180.26] has quit [Ping timeout: 245 seconds] 20141014 02:28:52< shadowm> vultraz: Internationalization, presumably. 20141014 02:29:24< shadowm> If you think about it, 80% of it is rules involving the language selection at the bottom. 20141014 02:29:50< shadowm> The other 20% is importing glamdrol and overriding a few styles. 20141014 02:30:23< vultraz> Not anymore 20141014 02:30:51< shadowm> I'm talking of the original intl.css, vultraz. 20141014 02:31:11< vultraz> Of course 20141014 02:31:17< vultraz> But I'm saying that no longer applies 20141014 02:31:29< vultraz> And am intrinsically implying it be renamed 20141014 02:31:36< shadowm> No, and it doesn't really make much sense to import glamdrol anymore either. 20141014 02:31:59< shadowm> 90% of glamdrol goes to waste because it's not used (since it's not a MW-managed page) or has been overridden. 20141014 02:33:12-!- Bob_The_Mighty [~chatzilla@cpc4-brig16-2-0-cust378.3-3.cable.virginm.net] has joined #wesnoth-dev 20141014 02:33:49< vultraz> I said I agreed 20141014 02:33:55< shadowm> So we are blocking the load process on 16 KiB of unused waste. 20141014 02:35:01< vultraz> Oh, I forgot to mention, why did you change to Open Sans from Optima? 20141014 02:35:22-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has quit [Ping timeout: 240 seconds] 20141014 02:36:01< shadowm> Because I've never seen Optima used anywhere before. 20141014 02:36:14< shadowm> Furthermore, it's non-free and non-gratis. 20141014 02:36:17-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has joined #wesnoth-dev 20141014 02:36:34-!- Bob_The_Mighty [~chatzilla@cpc4-brig16-2-0-cust378.3-3.cable.virginm.net] has quit [Client Quit] 20141014 02:37:10< shadowm> Open Sans has become rather ubiquitous to the point of triteness, but it serves its purpose nicely. 20141014 02:37:21< vultraz> It seems overly generic 20141014 02:37:26< shadowm> It's also free and available through Google web fonts. 20141014 02:37:49< shadowm> Which means the chances someone has already cached it are good enough. 20141014 02:37:56< vultraz> Optima at least gave it an elegant, semi-unique look. 20141014 02:38:15< shadowm> And we have a solid guarantee that it will be selected. 20141014 02:38:21< shadowm> Unlike this font I don't even have. 20141014 02:39:02-!- Bob_The_Mighty [~chatzilla@cpc4-brig16-2-0-cust378.3-3.cable.virginm.net] has joined #wesnoth-dev 20141014 02:39:19< shadowm> What even installs Optima? I don't think it's even part of a default Windows 8.1 installation. 20141014 02:40:01< vultraz> I don't know, or how to check 20141014 02:40:21< shadowm> Nope, no Optima in my 8.1 VM. 20141014 02:40:31< shadowm> So Segoe UI would be selected next. 20141014 02:41:27< vultraz> I wonder if perhaps that's what I'm seeing. *shrug* 20141014 02:41:33< vultraz> In which case, why not use that? 20141014 02:41:37< shadowm> It's easy to check that in Firefox. 20141014 02:41:45< shadowm> Segoe UI is not a Linux or OS X font. 20141014 02:42:02< shadowm> I also can't stand it. 20141014 02:42:32< vultraz> And so you reverted to the most generic sans font you could find 20141014 02:42:45< shadowm> Exactly. 20141014 02:42:58< shadowm> [...] it serves its purpose nicely. 20141014 02:43:56< shadowm> In particular, its metrics work well for the intro. 20141014 02:44:38< shadowm> Not for the button, though, which is still using Trebuchet MS. 20141014 02:44:49< shadowm> Much to my chagrin. 20141014 02:44:51< vultraz> I noticed 20141014 02:45:33< vultraz> I also see you applied a gradient to the side of the page 20141014 02:46:07< shadowm> Yes. 20141014 02:46:20< shadowm> I like gradients. 20141014 02:47:12< shadowm> I mean, it's kind of obvius, isn't it? 20141014 02:47:18< vultraz> In my original version (which everyone has forgotten about in leiu of yours) I was considering a s.a.n-style gradient around the intro, but that doesn't seem appropriate anymore 20141014 02:47:36< shadowm> lieu. 20141014 02:47:36< vultraz> But I don't think this linear one looks that good 20141014 02:48:10< vultraz> There's obvious color strips on my screen 20141014 02:48:18-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20141014 02:48:20< shadowm> Are you using Firefox? 20141014 02:48:26< vultraz> Chrome 20141014 02:48:27< shadowm> IE? 20141014 02:48:30< shadowm> What. 20141014 02:48:36< shadowm> Chrome has the best gradient rendering of those three. 20141014 02:48:51< shadowm> It uses color dithering, at least on Linux. 20141014 02:49:10 * vultraz checks again 20141014 02:49:24< vultraz> eeehhhh I guess it's not that obvious. 20141014 02:49:43-!- thunders1ruck [~zaibotren@cpc3-sgyl29-2-0-cust613.sgyl.cable.virginm.net] has joined #wesnoth-dev 20141014 02:50:23< shadowm> I'd need to stick my eyes to the screen to see the strips on Firefox, and that's a browser that doesn't dither gradients. 20141014 02:51:11< vultraz> Yeah, ignore that 20141014 02:52:06-!- MaraJade_ [goossenm@osuosl/staff/MaraJade] has joined #wesnoth-dev 20141014 02:52:54-!- MaraJade [goossenm@osuosl/staff/MaraJade] has quit [Disconnected by services] 20141014 02:53:11-!- MaraJade_ is now known as MaraJade 20141014 02:54:10-!- Netsplit *.net <-> *.split quits: thunderstruck 20141014 02:55:17< iceiceice> hey, shadowm, you probably are the best person to ask this: 20141014 02:55:30< iceiceice> there's an add-on i'm not maintaining, but i have made a git repo in it's folder 20141014 02:55:39< iceiceice> so theres a .git right inside the add-on folder 20141014 02:55:49< iceiceice> if there was an update made and i download it, will it wipe out my repo? 20141014 02:56:25< iceiceice> what's the best course of action, should i copy out the .git folder, and copy it back after the update? 20141014 02:56:31< shadowm> That's an excellent question, because I didn't write the anti-VCS-clobbering code, AI0867 did. 20141014 02:56:48< shadowm> However, I can quickly test it. 20141014 02:59:52< shadowm> OK, first of all, the add-ons manager will take the add-on's version from your .pbl instead of the _info.cfg if you have a .pbl. 20141014 03:00:18< shadowm> That means the remote version has to be greater than the one on your .pbl for it to consider it upgradable. 20141014 03:01:43-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20141014 03:01:46< shadowm> Now, if that is the case, you will see this upon pressing Update All: http://i.imgur.com/iaMoP8B.png 20141014 03:02:17< shadowm> wesnoth_addon_manager (the command-line Python client) would probably happily clobber your files, though. 20141014 03:05:32< shadowm> iceiceice: Oh, but your question wasn't about that. 20141014 03:05:38< shadowm> Yes, it will clobber everything if you say Yes. 20141014 03:06:53-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection] 20141014 03:07:14< shadowm> Think ( rm -rf Addon_Name && tar -xvf Addon_Name.tar ) 20141014 03:07:33< shadowm> Except without -v. 20141014 03:09:25< iceiceice> ok thanks 20141014 03:12:47-!- Kexoth [~kex@89.205.48.13] has quit [Remote host closed the connection] 20141014 03:17:44-!- kex [~kex@89.205.48.13] has joined #wesnoth-dev 20141014 03:18:48-!- kex [~kex@89.205.48.13] has quit [Remote host closed the connection] 20141014 03:21:20-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has quit [Ping timeout: 255 seconds] 20141014 03:22:19-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20141014 03:24:29-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has joined #wesnoth-dev 20141014 03:29:45-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141014 03:40:29-!- Bob_The_Mighty [~chatzilla@cpc4-brig16-2-0-cust378.3-3.cable.virginm.net] has quit [Quit: ChatZilla 0.9.91 [Firefox 32.0.3/20140923175406]] 20141014 03:43:24-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20141014 03:52:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now] 20141014 03:53:12-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20141014 03:59:25< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 6ebd4fbbdd21 / start/1.12/ (7 files in 3 dirs): New release announcement style "Westin" by shadowm and vultraz http://git.io/Iu8RNg 20141014 04:05:21-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 260 seconds] 20141014 04:07:05-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141014 04:10:08< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 6a581e047ee5 / start/1.12/template.html: Use apostrophes instead of quotes in HTML attributes http://git.io/nQujMA 20141014 04:10:11< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 498d3babc3f8 / start/1.12/template.html: Drop dead code http://git.io/-JLk3g 20141014 04:11:18< vultraz> shadowm: ...for some reason it doesn't display correctly here 20141014 04:13:22< shadowm> @import url(http://glamdrol.localhost/mw/skins/glamdrol/main.css); 20141014 04:13:29< shadowm> Hehehehehe. 20141014 04:13:45< shadowm> I'll deal with that as part of the glamdrol decoupling step. 20141014 04:19:04< vultraz> Right 20141014 04:20:42< ancestral> shadowm: You can’t use apostrophes in html 20141014 04:20:53< ancestral> For attributes 20141014 04:21:01< shadowm> We have always done so in this announcement. 20141014 04:21:06< vultraz> You can 20141014 04:21:09< ancestral> Unless it’s going through some kind of web framework I’m unaware of 20141014 04:21:22< shadowm> Also, I'm pretty sure it is valid HTML. 20141014 04:23:02< ancestral> k I take it back, they added it in HTML5 20141014 04:23:15< ancestral> Wait 20141014 04:23:33< shadowm> HTML 4.01 mentions it as an SGML thing. 20141014 04:23:49< shadowm> And HTML 4.01 is pretty much built on top on SGML, so. 20141014 04:23:49< ancestral> Yes 20141014 04:24:04< shadowm> Finally, we are using XHTML 1.1 here. 20141014 04:25:04< shadowm> po4a-gettextize only reads the XML without paying too much attention to XHTML conformity, and that's what ultimately matters. 20141014 04:26:06< vultraz> shadowm: I notice you use 0 inline style attributes 20141014 04:26:18< shadowm> Yes. I explained this before. 20141014 04:26:26< shadowm> Inline styles should be the exception, not the rule. 20141014 04:28:30< vultraz> Gahh please fix this localhost thing soon >_> 20141014 04:29:27< irker651> wesnoth: Charles Dang website:westin-announcement-style 13886c3546ad / start/1.12/styles/intl.css: Center the 'What's new' text http://git.io/p1t9Ww 20141014 04:29:44< shadowm> I didn't say you were allowed to change my branch. 20141014 04:29:51< shadowm> Not without asking first. :>< 20141014 04:30:33 * shadowm can't wait to see what conflicts that will cause. 20141014 04:32:51< shadowm> vultraz: Spaces before opening braces. 20141014 04:33:17< ancestral> vultraz: You should have run shadowlint on your files 20141014 04:33:19< shadowm> Why did you decide to make #game an exception rather than generalize that to all h2 elements? 20141014 04:34:42< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 14c4f6603907 / start/1.12/styles/intl.css: Reorganize CSS rules in sections http://git.io/UNCmig 20141014 04:34:45< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 044395e46f87 / start/1.12/styles/intl.css: Import glamdrol from a non-intranet location to make vultraz less upset http://git.io/v6W1bA 20141014 04:34:59< vultraz> Well for one, h2 is defined in glamdrol 20141014 04:35:16< ancestral> Everyone loves Open Sans 20141014 04:35:16< shadowm> vultraz. 20141014 04:35:22< shadowm> vultraz, dear gods. 20141014 04:35:35< shadowm> If "it's defined in glamdrol" was an argument against anything, I wouldn't get anything done. 20141014 04:35:45< shadowm> You need to learn CSS. :( 20141014 04:36:14< vultraz> This IS me learning css 20141014 04:36:22< vultraz> hands-on, one might say 20141014 04:36:26< shadowm> https://github.com/wesnoth/website/blob/044395e46f87edd9de45cb673328e3995981e8bc/start/1.12/styles/intl.css#L159 20141014 04:36:36< shadowm> Look at that h2 that "is defind in glamdrol". 20141014 04:37:33< vultraz> Er. Oh 20141014 04:38:16< vultraz> Didn't know you could do that 20141014 04:38:36< shadowm> It sounds like you didn't really look at the contents of intl.css when you added the download button styles. 20141014 04:40:01< vultraz> ..... 20141014 04:40:04 * vultraz kicks himself 20141014 04:40:15< vultraz> I did, and now that you mention it, I remember seeing h2 there 20141014 04:41:02< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 67ba5f138964 / start/1.12/styles/intl.css: CSS coding style fixes http://git.io/YFkWng 20141014 04:42:25< vultraz> I suppose it doesn't matter, #game being the only h2 element 20141014 04:42:33< shadowm> It is not. 20141014 04:42:41< shadowm>

Download

20141014 04:42:44< shadowm>

More Info

20141014 04:42:59< vultraz> Oh, right. Well, do you think those should also align center 20141014 04:43:24< shadowm> I've nt made my mind up with regards to this h2 center business. 20141014 04:44:12< vultraz> #game certainly looks better centered 20141014 04:45:41< vultraz> Download looks fine centerd 20141014 04:45:41< vultraz> More Info looks horrible centered 20141014 04:47:38< vultraz> the whole MI section would have to be centered with it, and the bullets removed 20141014 04:51:42< shadowm> It'd look awful. 20141014 04:52:35< vultraz> The only way it looks fine is with MI aligned left 20141014 04:52:38< vultraz> Like it is now 20141014 04:52:42< vultraz> Download can go either way 20141014 04:54:12< vultraz> I'm trying to slightly reduce the thumb t* borders around the image but I can't find where... 20141014 04:54:54< shadowm> I *enlarged* them. 20141014 04:55:02< vultraz> Really? 20141014 04:55:07< shadowm> Yes. 20141014 04:55:10< vultraz> They look too conspicuous now 20141014 04:55:32< shadowm> They are supposed to be. 20141014 04:55:54< shadowm> I found that it helps the cropped images work. 20141014 04:56:45< shadowm> What else are you tring to change so I can now in advance whether to revert it or not. 20141014 04:57:27< shadowm> (If I had wanted us to trample on each other's work without prior notice I'd have committed to your branch instead of starting a new one.) 20141014 04:57:40< vultraz> Nothing else for now 20141014 04:58:37-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has quit [Ping timeout: 260 seconds] 20141014 05:03:36-!- iceiceice [~chris@192.16.204.74] has joined #wesnoth-dev 20141014 05:03:37-!- iceiceice [~chris@192.16.204.74] has quit [Changing host] 20141014 05:03:37-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141014 05:03:55-!- fabi__ [~fabi@p548638BA.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141014 05:03:55-!- fabi__ [~fabi@p548638BA.dip0.t-ipconnect.de] has quit [Changing host] 20141014 05:03:55-!- fabi__ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20141014 05:03:55< iceiceice> Coffee_irc: if you could take a look at https://github.com/wesnoth/wesnoth/pull/298 and at least see if the message i wrote makes sense to you, i would appreciate it 20141014 05:07:10-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds] 20141014 05:09:28< iceiceice> wow this is kind of annoying 20141014 05:09:39< iceiceice> i just looked at our wikipedia page 20141014 05:09:56< iceiceice> `This development version is rolling subject to further tweaking and polishing, depending on the wesnoth community feedback. There is planned to deliver a high-quality and stable 1.12 release in the future, which could feature a seventh default faction, called Khalifate.[12]` 20141014 05:10:00< iceiceice> link [12] is this: 20141014 05:10:08< iceiceice> http://forums.wesnoth.org/viewtopic.php?f=6&t=38005&start=60 20141014 05:10:24< shadowm> Pfft. 20141014 05:10:40< shadowm> What are the odds hachol added the link? 20141014 05:10:48< iceiceice> i dont know 20141014 05:10:52< iceiceice> i guess we can look at the editor 20141014 05:11:01< iceiceice> and see if he has links to insane videos on his profile 20141014 05:11:11< shadowm> Oh my god. 20141014 05:11:19< shadowm> There's a cite note including my name. 20141014 05:11:38< shadowm> http://en.wikipedia.org/wiki/The_Battle_for_Wesnoth#cite_note-era-khalifate-7 20141014 05:13:22< iceiceice> haha 20141014 05:14:11< shadowm> Why doesn't MW have a 'blame/annotate' option. 20141014 05:14:43-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20141014 05:15:15-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20141014 05:16:10< shadowm> http://en.wikipedia.org/w/index.php?title=The_Battle_for_Wesnoth&diff=593946869&oldid=593943590 20141014 05:16:20< shadowm> http://en.wikipedia.org/w/index.php?title=The_Battle_for_Wesnoth&diff=597382400&oldid=593946869 20141014 05:17:09< ancestral> Egads how many music samples can you cram in a page? 20141014 05:17:21< shadowm> Both IPs are in /16s that our friend has used in the past. 20141014 05:17:28< shadowm> No /32 match, though. 20141014 05:17:44< ancestral> Hey, I made the wiki page! 20141014 05:18:01-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has joined #wesnoth-dev 20141014 05:18:40< ancestral> Really I shouldn’t be. “Battle for Wesnoth available music” is pretty generic and broad 20141014 05:19:00< ancestral> You could probably put 50 songs there 20141014 05:25:22< ancestral> BfW needs some reviews of 1.12 20141014 05:27:19< shadowm> I presume there haven't been any. 20141014 05:27:38< shadowm> I mean, it's a development version. Who would review a development version of an obscure OSS game? 20141014 05:27:42< irker651> wesnoth: timotei website:master bca418da81a4 / eclipse.wesnoth.org/download.html: Remove link from eclipse's update site http://git.io/u5KPFQ 20141014 05:29:16< ancestral> shadowm: I was speaking futuristically 20141014 05:30:24< ancestral> It needs reviews once/thereafter 1.12 is released 20141014 05:30:50< shadowm> Well, we don't exactly make any effort to promote ourselves. I don't think there are even reviews of 1.10. 20141014 05:30:59< ancestral> Probably not 20141014 05:31:22< shadowm> Plus, the base game remains unchanged, which isn't exactly constructive review material. 20141014 05:31:34< ancestral> How I used “need” was more of “I think it would be nice” and “Wesntoh deserves the attention” 20141014 05:31:56< ancestral> Why can’t someone who hasn’t played it before look at it for the first time? 20141014 05:32:07< ancestral> And write a quality review 20141014 05:32:16< shadowm> I'm not saying they can't. 20141014 05:32:34< ancestral> I’m speaking figuratively — of course they can — why don’t they? 20141014 05:40:37-!- Sulfur [~Miranda@p5B3271E9.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141014 05:40:45-!- Netsplit *.net <-> *.split quits: janebot 20141014 05:43:55< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 09f95baf459c / start/1.12/styles/intl.css: Copyright statement http://git.io/SzfjwA 20141014 05:43:58< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style dec8b22b5993 / start/1.12/ (images/bullet.gif styles/intl.css): Import styles and drop dependency on Glamdrol http://git.io/fVta9g 20141014 05:46:18-!- Netsplit over, joins: janebot 20141014 05:52:40< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style e0eb3b53fc3c / start/1.12/ (styles/intl.css styles/westin.css template.html): Rename intl.css to westin.css http://git.io/En8Srw 20141014 05:52:43< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 9f1b290dfa52 / start/1.12/template.html: Drop language selection placeholder http://git.io/OHXpeg 20141014 05:53:56< iceiceice> gfgtdf: are you still waiting on anything for PR #296? 20141014 05:54:26< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style bf92f35d4d5b / start/1.12/ (styles/westin.css template.html): Drop element-specific rule, replace it with a class specification http://git.io/61kEMw 20141014 05:58:08< shadowm> vultraz, Ivanovic: Opinions? http://shadowm.ai0867.net/westin-test/template.html 20141014 05:58:30< shadowm> (Yes, I'm aware the intro background is misaligned and huge. I haven't figured out what to do about it yet.) 20141014 05:58:33< Ivanovic> visuals: sweeeeet 20141014 05:58:44< Ivanovic> text: need to read it first, please resend me the link in about 10h 20141014 05:58:51< Ivanovic> so after work 20141014 05:59:18< shadowm> Ivanovic: Don't bother with the text below the intro picture area, it's an earlier version of what's in the master branch. 20141014 05:59:44< Ivanovic> okay, regarding the visuals: just perfect 20141014 06:00:55< shadowm> Though you might want to review the footer's layout for the language selector: http://shadowm.ai0867.net/westin-test/template.html 20141014 06:01:07< shadowm> (May need to hit F5, because there weren't links a minute ago.) 20141014 06:01:22< Ivanovic> looks fine to me 20141014 06:01:38< Ivanovic> maybe some small table of contents would make sense on the page though 20141014 06:02:04< Ivanovic> not full width, but more like a small box floating at the beginning of text 20141014 06:02:18< shadowm> vultraz dropped the table of contents first. I for one am not sure what advantages there are to having a TOC for such a short page that's kind of intended to be read as a single atomic unit. 20141014 06:02:53< shadowm> If the "For Content Developers" section was longer and more complete I'd be more interested in a TOC. 20141014 06:03:44< Ivanovic> the matter is that the announcement has 3 pages on my 27" screen 20141014 06:03:50< Ivanovic> so it is by no means short 20141014 06:04:04< Ivanovic> and people who want to fast track to the downloads want a ToC 20141014 06:04:23< shadowm> The download button leads them to the Download section at the bottom. 20141014 06:04:53< Ivanovic> did i mention that i just fell out of bed and am not able to read yet? 20141014 06:05:14< irker651> wesnoth: Ignacio R. Morelle website:westin-announcement-style 2615ed7158e1 / start/1.12/js/ (jquery-1.11.1.min.js jquery-2.1.1.min.js): Check in jQuery until I decide whether to drop the dependency on it http://git.io/PgjEfw 20141014 06:05:14< shadowm> :p 20141014 06:06:15< iceiceice> shadowm: i don't think the intro background being misaligned is so bad, 20141014 06:06:27< iceiceice> one thing that i might suggest, if i may do so, 20141014 06:06:36< iceiceice> if the crest appeared a bit lower 20141014 06:06:47< iceiceice> so that it's not up among the spires of the towers 20141014 06:06:52< iceiceice> and maybe more on the wall 20141014 06:07:06< iceiceice> i think it wouldn't be so noticeable 20141014 06:07:10< iceiceice> because the front of the wall is pretty well centeres 20141014 06:07:12< iceiceice> *centered 20141014 06:07:16< shadowm> Then we'd run out of image surface at the bottom. 20141014 06:07:49< iceiceice> yeah... i dont know 20141014 06:08:02< shadowm> If you check the image, you'll notice that the bottom as rendered on the page (with a large screen) is actually its physical bottom: http://shadowm.ai0867.net/westin-test/images/header-1920.jpg 20141014 06:08:17< shadowm> So we'd need to shrink the text. 20141014 06:08:59< shadowm> Or make the text follow under the image, but then the intro section would get rather long. 20141014 06:09:52< shadowm> Of course, I could shrink the image, but then it'd get letterboxed to fit the aspect ratio. 20141014 06:09:58< iceiceice> who made this image? 20141014 06:10:13< shadowm> An artist who left long ago. 20141014 06:10:23< shadowm> A few weeks after publishing it. 20141014 06:12:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20141014 06:12:50-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141014 06:15:24< iceiceice> just curious 20141014 06:16:13< ancestral> I remember that 20141014 06:16:27< ancestral> I believe there’s three seasons he made 20141014 06:16:40< vultraz> Yes 20141014 06:16:41< vultraz> Fall is the nicest for this 20141014 06:17:08< ancestral> vultraz: But it’s spring where shadowm is 20141014 06:17:18< vultraz> There's no spring 20141014 06:17:28< ancestral> shadowm: It’s nice, though part of me feels dirty it’s being used when the artist left in a huff 20141014 06:17:36< ancestral> Kinda feels like a “screw you” to his face 20141014 06:20:29< vultraz> ....wat 20141014 06:20:38< vultraz> I'm sorry, but that is absurd logic 20141014 06:21:34< ancestral> What is? 20141014 06:22:16< vultraz> "Artist left, so we can't use his work!" 20141014 06:22:22< vultraz> Many artists have left Wesnoth 20141014 06:23:36< ancestral> vultraz: No, it’s not we can't 20141014 06:23:42< ancestral> It’s “maybe we shouldn’t” 20141014 06:23:45< vultraz> It's an appropriate image, it's been used as the storytext in TSG for years 20141014 06:24:07< ancestral> vultraz: But on the front page for the project? 20141014 06:24:31< vultraz> This is not the front page - this is the announcement 20141014 06:24:34< vultraz> For 1.12 20141014 06:24:54< vultraz> Though I will admit, the front page will look bland compared to this 20141014 06:25:55< ancestral> shadowm: This isn’t the front page? 20141014 06:25:58< ancestral> It ought to be 20141014 06:27:31< vultraz> It's missing previous news, as well as the sidebar - so it cannot be 20141014 06:29:23< vultraz> It might be adapted for the front page, soon, though 20141014 06:29:41< vultraz> Er, I mean, we might adapt the front page to use Westin 20141014 06:30:05< vultraz> Or a modified form of it 20141014 06:31:05< ancestral> You guys should 20141014 06:31:29< vultraz> Indeed 20141014 06:31:59< vultraz> shadowm: kudos on the smooth scrolling 20141014 06:33:18< zookeeper> shadowm, should the "How did you find out about Wesnoth?" thread be merged into the old one (last post from 2012 i think)? 20141014 06:36:46< ancestral> vultraz: You should talk to Gambit and get that kind of theme in https://reddit.com/r/wesnoth/ 20141014 06:39:51< ancestral> vultraz: Some great scenery not in the project but in the forums here: http://forums.wesnoth.org/viewtopic.php?f=9&t=17712&hilit=castle&start=75 20141014 06:40:32< ancestral> (The snowcapped mountains pic look like its straight out of the Wesnoth terrain tiles) 20141014 06:40:45< ancestral> *looks like it’s 20141014 06:41:13< ancestral> (Actually, it could be in some campaigns I haven’t played.) 20141014 06:42:07-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 258 seconds] 20141014 06:43:38< vultraz> shadowm: you didn't mention me in the credits at all :/ 20141014 06:44:08-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has quit [Remote host closed the connection] 20141014 06:51:30-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141014 06:52:41< vultraz> shadowm: also, assuming you worked off my branch, the test is not an earlier version of master - it is master, with a few of my own tweaks 20141014 06:52:49< vultraz> I kept it up to date with all changes 20141014 07:07:16< shadowm> vultraz: I worked with a version of your branch preceding your merge from master. 20141014 07:07:42< shadowm> vultraz: I did mention you in the commit message. 20141014 07:08:52< shadowm> ancestral: zookeeper committed the artwork aware of the circumstances and the artist didn't say "don't use my work" -- in fact, he posted the high-res versions after declaring his intention to not continue producing art for the game. 20141014 07:09:34< shadowm> "Feel free to keep tinkering with the material I put on here, and use it as you please." -- scavenger's words. 20141014 07:11:23< shadowm> That said, alternatives welcome (esp. if they are taller). :p 20141014 07:14:01< shadowm> (The artist!shadowm in me does agree with the sentiment, but coder!shadowm's pragmatism ultimately trumps everything else.) 20141014 07:15:28 * ancestral imgaines up two little “angels” on each shoulder 20141014 07:16:14< ancestral> (http://tvtropes.org/pmwiki/pmwiki.php/Main/GoodAngelBadAngel) 20141014 07:27:58-!- bumbadadabum [~bumbadada@wcw-stud-145-109-11-182.wireless.uva.nl] has joined #wesnoth-dev 20141014 07:29:48< iceiceice> its funny to me to link these things this way actually 20141014 07:30:01< iceiceice> so right brain is the good angel, left brain is the bad angel? 20141014 07:30:09< iceiceice> sounds a bit... schizophrenic :) 20141014 07:32:21< iceiceice> also a bit of a reversal, i guess normally the right brain is considered "sinister" 20141014 07:34:24< ancestral> In real life, there is usually not a Good vs. Evil 20141014 07:34:50< ancestral> (It’s typically Somewhat Evil vs. Somewhat Evil) 20141014 07:35:19< ancestral> Everyone thinks they’re the Good one 20141014 07:35:28< iceiceice> that's just what the Evil want you to think XD 20141014 07:36:02< ancestral> iceiceice: Just like in Wesnoth! 20141014 07:36:17< ancestral> err… maybe 20141014 07:44:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds] 20141014 07:45:09-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20141014 07:47:41-!- ancestral is now known as ansesutoraru 20141014 08:31:07-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev 20141014 08:47:24-!- Sulfur [~Miranda@p5B3271E9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141014 08:50:55-!- ansesutoraru [~ancestral@12.23.74.29] has quit [Quit: i go nstuf kthxbai] 20141014 08:51:27-!- boucman_work1 [~rosen@193.56.60.161] has joined #wesnoth-dev 20141014 08:52:19-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20141014 08:53:44-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 260 seconds] 20141014 09:08:07< vultraz> shadowm: I did two merges 20141014 09:09:21< vultraz> shadowm: and yes, but who is going to look at the commit message in the future 20141014 09:12:06-!- Sulfur [~Miranda@p5B3271E9.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141014 09:30:45< vultraz> shadowm: also, why unicode and not utf8? Copyright © 2003–2014 20141014 09:42:46-!- mjs-de [~mjs-de@f048237064.adsl.alicedsl.de] has joined #wesnoth-dev 20141014 10:09:32< ancestral> vultraz: utf-8 is a subset of Unicode 20141014 10:10:06< ancestral> There are some languages outside of utf-8 (not very many common ones, but there are some) 20141014 10:10:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141014 10:10:41-!- ancestral [~ancestral@12.23.74.29] has quit [Quit: End Transmission.] 20141014 10:19:18-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141014 10:28:13-!- irker651 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20141014 10:42:29-!- Ravana_ [SZ_Bot@27.83.235.80.dyn.estpak.ee] has quit [Disconnected by services] 20141014 10:42:29-!- SZ_Bot__ [SZ_Bot@27.83.235.80.dyn.estpak.ee] has joined #wesnoth-dev 20141014 10:43:10-!- SZ_Bot__ is now known as Ravana_ 20141014 10:48:57-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 272 seconds] 20141014 10:52:21-!- bumbadadabum [~bumbadada@wcw-stud-145-109-11-182.wireless.uva.nl] has quit [Ping timeout: 260 seconds] 20141014 10:53:10-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20141014 11:39:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141014 11:55:51-!- bumbadadabum [~bumbadada@wcw-stud-145-109-11-182.wireless.uva.nl] has joined #wesnoth-dev 20141014 12:07:42-!- kex [~kex@77.28.25.242] has joined #wesnoth-dev 20141014 12:11:30-!- Sulfur [~Miranda@p5B3271E9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141014 12:12:06-!- kex [~kex@77.28.25.242] has quit [Ping timeout: 246 seconds] 20141014 12:24:41-!- bumbadadabum [~bumbadada@wcw-stud-145-109-11-182.wireless.uva.nl] has quit [Ping timeout: 272 seconds] 20141014 12:26:25-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has joined #wesnoth-dev 20141014 12:41:50-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-184.wireless.uva.nl] has joined #wesnoth-dev 20141014 12:49:02-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-184.wireless.uva.nl] has quit [Ping timeout: 245 seconds] 20141014 13:05:31-!- Sulfur [~Miranda@p5B3271E9.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141014 13:21:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20141014 13:25:51-!- prkc [~prkc@catv-80-99-60-5.catv.broadband.hu] has joined #wesnoth-dev 20141014 13:38:45-!- kex [~kex@77.28.25.242] has joined #wesnoth-dev 20141014 14:22:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping] 20141014 14:42:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20141014 14:56:53-!- gfgtdf [~chatzilla@d177061.adsl.hansenet.de] has joined #wesnoth-dev 20141014 15:19:15-!- irker363 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20141014 15:19:15< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master 66176b1738c5 / src/ (59 files in 22 dirs): Move everything in src/filesystem.hpp into its own namespace http://git.io/mLYmMw 20141014 15:19:17< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master e5db3c4091e7 / src/ (7 files in 4 dirs): Rename filesystem::file_name to filesystem::base_name http://git.io/BOJI5A 20141014 15:19:19< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master 76cad9827146 / src/ (5 files in 4 dirs): Remove some unneeded includes http://git.io/RnA7eg 20141014 15:19:21< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master 1cd8fbd8e974 / src/filesystem.hpp: Make filesystem.hpp not depend on config.hpp being included first http://git.io/88451A 20141014 15:19:23< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master db76fa3b522d / src/ (filesystem.cpp filesystem.hpp savegame.cpp): Rename file_create_time to file_modified_time, as that's what it does http://git.io/4iIvIA 20141014 15:19:25< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master a5ab4d73004d / src/filesystem.hpp: Remove a comment that is no longer true http://git.io/8KaRVw 20141014 15:19:27< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master ad8636fc3a43 / src/image.cpp: Don't try to iterate over things that are not directories http://git.io/-hKG_A 20141014 15:19:29< irker363> wesnoth: Alexander van Gessel wesnoth:master 596c2461b83a / src/gui/dialogs/editor/custom_tod.cpp: file_name->base_name http://git.io/0FpzFg 20141014 15:19:31< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master ecf8f3d55cfd / src/ (SConscript filesystem.cpp filesystem_common.cpp): Split the parts of filesystem.cpp that don't directly interface with the filesys http://git.io/qjbP4Q 20141014 15:19:33< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master e5cb79b8e9e4 / src/ (65 files in 24 dirs): Move everything in src/filesystem.hpp into its own namespace http://git.io/MTGPFg 20141014 15:19:35< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master bd76edfb16ac / src/ (12 files in 7 dirs): Rename filesystem::file_name to filesystem::base_name http://git.io/nZrSuA 20141014 15:19:37< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master 1ce6fab41916 / src/ (5 files in 4 dirs): Remove some unneeded includes http://git.io/wBD9lQ 20141014 15:19:39< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master ff87c8023021 / src/filesystem.hpp: Make filesystem.hpp not depend on config.hpp being included first https://github.com/wesnoth/wesnoth/commit/ff87c802302104615563b94def429f302e581649 20141014 15:19:41< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master bf42d2abe570 / src/ (filesystem.cpp filesystem.hpp save_index.cpp): Rename file_create_time to file_modified_time, as that's what it does http://git.io/UUI8Wg 20141014 15:19:43< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master ff51c9a75cc4 / src/filesystem.hpp: Remove a comment that is no longer true http://git.io/KS92Zw 20141014 15:19:45< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master 77b431e8b28f / src/ (SConscript filesystem.cpp filesystem_common.cpp): Split the parts of filesystem.cpp that don't directly interface with the filesys http://git.io/HiWShQ 20141014 15:19:47< irker363> wesnoth: gfgtdf wesnoth:master eb6302b731db / src/CMakeLists.txt: add filesystem_common.cpp to cmake http://git.io/V8lA5Q 20141014 15:19:49< irker363> wesnoth: Alexander van Gessel (AI0867) wesnoth:master 845c26050516 / src/image.cpp: Don't try to iterate over things that are not directories http://git.io/-zyBGQ 20141014 15:19:51< irker363> wesnoth: gfgtdf wesnoth:master fbfad1f48dfb / : Merge commit 'ecf8f3d55cfd9ebc76e99941270500a5781d7819' into AI-boost_filesystem http://git.io/1adsiw 20141014 15:19:53< irker363> wesnoth: gfgtdf wesnoth:master 3de9e1d6a1cf / src/ (73 files in 25 dirs): Merge pull request #296 from gfgtdf/AI-boost_filesystem http://git.io/tLVYrQ 20141014 15:24:33< mattsc> gfgtdf: just for my understanding, is this to fix the Windows filesystem problem? 20141014 15:24:48< mattsc> and will this (or some version of it) be ported to 1.12 as well? 20141014 15:24:53< gfgtdf> mattsc: no this is just a refactor whcih renames and moves fucntions 20141014 15:25:27< mattsc> gfgtdf: okay, (unfortunately) that is what I thought ;) 20141014 15:25:46< mattsc> gfgtdf: is anybody working on the filesystem problem? 20141014 15:27:52< gfgtdf> mattsc: there are 2 pull requests by AI form jul. If we want to fix teh filesystem problem on windows i so no way that does without them 20141014 15:28:30-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141014 15:28:38< gfgtdf> mattsc: those wont allow us to use unicode on windows but it at least allows us to use the locale. 20141014 15:29:13< gfgtdf> mattsc: while currecntly our windows paths are quiet limitied to asci characters 20141014 15:29:54< mattsc> gfgtdf: yes, I know (at least approximately). The problem is that AI0867 is not available at the moment and that this is marked as a must-fix issue for 1.12.0 20141014 15:30:59< mattsc> So somebody else either need to do something about it, or we downgrade this issue, or we don’t release 1.12.0 for a long time... 20141014 15:31:00< gfgtdf> mattsc: i beleive the 1.12 versions on the pr doesnt even have any meging conflits. The main rpobem was that it raises our SDL_mixer requirement to 1.2.12 20141014 15:31:23< mattsc> gfgtdf: right - we discusssed all of this about a week ago 20141014 15:31:44< vultraz> IMO, if he doesn't appear, and we have to go wit 1.12, just merge it 20141014 15:31:57-!- boucman_work1 [~rosen@193.56.60.161] has quit [Ping timeout: 245 seconds] 20141014 15:32:22< gfgtdf> mattsc: if i understood AI in the ML correctly the main problem is that not taht its not possible on 1.2.11 but rather that teh 1.2.12 and teh the 1.2.11 code is just cot compatible. 20141014 15:32:32< gfgtdf> s/cot/not 20141014 15:33:31< gfgtdf> mattsc: but it coudl still happens that there are other problem wit 1.2.11 tha i dotn knwo about 20141014 15:35:31< gfgtdf> mattsc: but if that incompabilirty is the only reason it would most likeley be possible to write a compability code. 20141014 15:36:20< gfgtdf> mattsc: see the ML here: https://www.mail-archive.com/wesnoth-dev@gna.org/msg04700.html 20141014 15:38:52< gfgtdf> mattsc: also i since that is only related to the SDL problems it (the pr by ai ) most likely wouldn't fix https://gna.org/bugs/?13926 20141014 15:39:18< gfgtdf> mattsc: but it supposed to https://gna.org/bugs/?20089 20141014 15:39:34< mattsc> gfgtdf: let me put on my “let’s get 1.12.0 out” hat on for a moment and just make a few blunt statements (take these with a grain of salt) 20141014 15:40:32< mattsc> I really don’t care about the technical implementation … (in good part because I don’t understand the issues well enough for me to be helping with that) 20141014 15:40:36< mattsc> What I care about is: 20141014 15:40:48< mattsc> 1. We want to get out 1.12.0 in a matter of weeks 20141014 15:41:40< mattsc> 2. In order to do that, we want the filesystem/unicode/whatever stuff to work fully in Windows, incl. for somebody who downloads the repo and wants to compile from scratch without having to go through major hoops 20141014 15:42:08< vultraz> Personally, I think Windows is more important to support than the Pandora 20141014 15:42:18< mattsc> 3. We needs some sort of version (enabled as a branch, with ifdefs or whatever) that can be compiled into a Pandora package 20141014 15:42:44< mattsc> 3a. Ivanovic will take care of the compiling of the package, but not of the creation of the branch (or whatever) 20141014 15:43:27< mattsc> gfgtdf: that’s the bottom line; if I understood anything of these kinds of things, I would try to work on it myself. But alas, I do not. 20141014 15:44:26< mattsc> vultraz: nobody disagrees with that; but we have decided that we do want to have a Pandora version of 1.12.0 also 20141014 15:44:36< mattsc> this was all discussed in detail about a week ago 20141014 15:44:49< mattsc> gfgtdf: so, my question is, is there any way to make this happen? 20141014 15:45:05< mattsc> well, to make it happen *soon* 20141014 15:45:25< gfgtdf> mattsc: i do understnd why the currecnt implementtion doesnt work. but i dont know SDL enough teh make any assumptions about the correctnes of the new (AI s pr) implementation. 20141014 15:45:26< mattsc> and I honestly don’t know the answer (see comments about my ignorance up there) 20141014 15:46:07< mattsc> gfgtdf: yeah… and iirc, iceiceice and shadowm said the same thing 20141014 15:46:41< gfgtdf> mattsc: we coudl just try to have a new branch that simply has AI's pr in it and hope it works. 20141014 15:47:16< mattsc> gfgtdf: hope it works or test whether it works? (I don' 20141014 15:47:26< mattsc> t have a Windows system, so I cannot even test it) 20141014 15:48:34< gfgtdf> mattsc: well of i can test the simple cases like renaming my weasnothpath to something cryptic and start playing, but for eample memory leaks or such i cannot test. 20141014 15:49:48< gfgtdf> (and if i understodd coreectly memeoryleaks where the main problem in teh sdl mixer incompability) 20141014 15:50:13< mattsc> gfgtdf: okay 20141014 15:50:42< mattsc> gfgtdf: so let me take a step back again and ask whether I see the overall situation right 20141014 15:51:20< mattsc> essentially, we have nobody who is able to fix this problem on the timescale of a few weeks (we have to assume that AI0867 will not be available) ? 20141014 15:51:50< mattsc> This means essentially we have two possibilites 20141014 15:51:57< mattsc> 1. We don’t release 1.12.0 soon 20141014 15:52:07< mattsc> 2. We release it without the fix 20141014 15:52:25< mattsc> Do I see this right? 20141014 15:55:00< gfgtdf> mattsc: shipping the windows version with a rather untested patch that does fix the problem is the third option. 20141014 15:55:37< gfgtdf> untested= might have other side effects. 20141014 15:56:21< mattsc> gfgtdf: sure, in fact that is what loonycyborg has been doing; but this isn’t only about the package, but also about the situation for people who want to compile themselves 20141014 15:56:36< mattsc> well, I guess he’s done this for part of the problem, not all of it 20141014 15:58:20< gfgtdf> mattsc: creating a new pandora branch and mergign the RWops into master is just 3 clicks on the githb webpage. 20141014 15:59:01< gfgtdf> mattsc: into 1.12 i mean 20141014 15:59:19< mattsc> gfgtdf: but from what I understand, RWops doesn’t fix the problem 20141014 15:59:22-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds] 20141014 15:59:31< mattsc> it only addresses one part of it 20141014 15:59:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141014 16:00:50< gfgtdf> mattsc: yes, but its the more basic part. 20141014 16:02:33< mattsc> gfgtdf: okay 20141014 16:02:58< gfgtdf> for the complete fix i believe your situation description above is right. 20141014 16:03:14< mattsc> gfgtdf: I am going to pull out of this discussion right now though because I cannot contribute to the technical side (and because I need to do work) 20141014 16:04:24< mattsc> I think somebody (and I don’t know who that is, but my best guess would be you, iceiceice, shadowm, others?) needs to discuss and decide what can be done quickly (on the timescale of ~2 weeks) 20141014 16:04:53< mattsc> Based on that, we need to make a decision what we do. 20141014 16:06:10< mattsc> I am happy to participate in that strategy decision, but involving me in the technical details is, unfortunately, not an efficient use of either of our time. :| 20141014 16:07:01< gfgtdf> i go eat now. 20141014 16:07:18< mattsc> bon appetit. I go work now 20141014 16:08:00< mattsc> gfgtdf: thanks, btw 20141014 16:21:29-!- Kexoth [~kex@77.28.25.242] has joined #wesnoth-dev 20141014 16:21:57-!- kex [~kex@77.28.25.242] has quit [Ping timeout: 245 seconds] 20141014 16:26:39-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141014 16:31:11-!- Gallaecio [~quassel@84.120.187.142.dyn.user.ono.com] has joined #wesnoth-dev 20141014 16:34:25< irker363> wesnoth: Charles Dang website:westin-announcement-style a217680f9c16 / start/1.12/template.html: Reworded part of the Download section http://git.io/QCzHwA 20141014 16:44:19-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20141014 16:51:12-!- Sulfur [~Miranda@p5B3271E9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141014 16:59:45-!- ancestral [~ancestral@12.23.74.29] has joined #wesnoth-dev 20141014 17:00:33-!- ancestral [~ancestral@12.23.74.29] has quit [Client Quit] 20141014 17:07:57< gfgtdf> shikadibot: seen aquileia 20141014 17:07:58< shikadibot> gfgtdf: Sorry, I don't know of aquileia. 20141014 17:11:57-!- ancestral [~ancestral@17.114.45.53] has joined #wesnoth-dev 20141014 17:40:31-!- Necrosporus_ is now known as Necrosporus 20141014 18:17:17-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev 20141014 18:18:19-!- riksteri [~riksteri@dsl-tkubrasgw3-54f96b-216.dhcp.inet.fi] has quit [Read error: Connection reset by peer] 20141014 18:27:36-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141014 18:28:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141014 18:30:29< fabi__> hi mattsc 20141014 18:32:03< shadowm> vultraz: UTF-8 is an encoding of Unicode. 20141014 18:33:13< shadowm> Using decimal entities in this case lowers the odds that someone will randomly replace the en dash with a hyphen. 20141014 18:34:02< shadowm> "Why not HTML entities?" Because they are not guaranteed to be defined by XHTML parsers. 20141014 18:34:22< shadowm> i.e. po4a-gettextize 20141014 18:37:53< shadowm> iceiceice: That's a very unfortunate bug you discovered in PR #299. My bad for not seeing the problem while reviewing that line. :\ 20141014 18:40:17-!- ancestral is now known as ancestral_dimsum 20141014 18:43:00< shadowm> fabi__: Did you see this? http://forums.wesnoth.org/viewtopic.php?p=576693#p576693 20141014 18:45:15< fabi__> shadowm: No. Not until now. The attack dialog was not worked on, was it? 20141014 18:45:50< shadowm> I don't know for sure if the report format used in it is shared by stuff you did change. 20141014 18:49:55< mattsc> hi fabi__ 20141014 18:54:59< irker363> wesnoth: timotei website:westin-announcement-style bca418da81a4 / eclipse.wesnoth.org/download.html: Remove link from eclipse's update site http://git.io/u5KPFQ 20141014 18:55:01< irker363> wesnoth: Ignacio R. Morelle website:westin-announcement-style a9bbb64f0cbc / eclipse.wesnoth.org/download.html: Merge branch 'master' into staging/master-to-westin-1 http://git.io/BKzopQ 20141014 19:05:52-!- tomreyn [~tomreyn@p57A9EEDD.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141014 19:05:55-!- tomreyn [~tomreyn@p57A9EEDD.dip0.t-ipconnect.de] has quit [Changing host] 20141014 19:05:55-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20141014 19:10:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141014 19:10:31< iceiceice> shadowm: yeah, i mean, i merged it, i also could have caught it :/ 20141014 19:18:34< shadowm> *#269 20141014 19:19:39< shadowm> Since it's probably not feasible to force Ivanovic to publish a release fixing a single bug, and we have the power of Lua on our side, we could possibly publish an add-on that replaces the implementation of [move_unit] with the fixed version on 1.11.17. 20141014 19:19:52< shadowm> (I could take care of that.) 20141014 19:21:10< iceiceice> ok 20141014 19:21:22< iceiceice> i think a reasonable goal is, maybe first do it on master and make some unit tests 20141014 19:21:30< iceiceice> there might be more broken stuff there, who knows 20141014 19:35:01-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 260 seconds] 20141014 19:35:23< shadowm> iceiceie: For reference, Debian stable has Boost 1.49, and oldstable has 1.42. 20141014 19:35:48< shadowm> Debian stable has a good SDL_mixer version too, and olstable has 1.2.11. 20141014 19:36:05< shadowm> Sorry, oldstable has 1.2.8, not 1.2.11. 20141014 19:38:18-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141014 19:40:59-!- ancestral_dimsum [~ancestral@17.114.45.53] has quit [Quit: ancestral_dimsum] 20141014 19:45:44< shadowm> I'm still unable to offer a technical assessment of the branch as I still haven't read up or, more importantly, used Boost.filesystem. 20141014 19:54:11-!- oldlaptop [~quassel@50-108-67-218.adr01.mskg.mi.frontiernet.net] has quit [Read error: Connection reset by peer] 20141014 19:57:05-!- oldlaptop [~quassel@50-108-67-218.adr01.mskg.mi.frontiernet.net] has joined #wesnoth-dev 20141014 19:58:27< iceiceice> shadowm: thanks 20141014 19:58:39< gfgtdf> iceiceice: in AIs original filesystem branch the boost filesystem is optional i think that be easier than making a second branch wich woudl require to push every commit to the with bfs and the without bfs branch 20141014 19:58:55< gfgtdf> iceiceice: evene furute commit durting 1.12.x i mean 20141014 19:59:01< iceiceice> gfgtdf: i think it didn't make it optional in cmakelists.txt 20141014 19:59:04< iceiceice> at least i didnt see that 20141014 19:59:28< iceiceice> i dont see any good reason not to add filesystem 1.44 as an "official" dependency 20141014 19:59:49< iceiceice> and make this no filesystem build as an "unofficial" thing 20141014 20:00:08< iceiceice> ultimately we dont really want to maintain two versions of the same thing 20141014 20:00:45< gfgtdf> iceiceice: i dont see why maintaining it 'unofficialy' is much easier 20141014 20:01:15< iceiceice> ok, i dont really want to learn how to screw around with cmake right now though 20141014 20:01:37< gfgtdf> iceiceice: i agree 20141014 20:01:49< iceiceice> maybe ivanovic can do that XD 20141014 20:01:58< iceiceice> hes our cmake expert, right? 20141014 20:02:45< shadowm> I have an idea to simplify the branch management issue: 20141014 20:03:06-!- Kexoth [~kex@77.28.25.242] has quit [Remote host closed the connection] 20141014 20:03:13< shadowm> 1) Make branch pointing to the same object as 1.12 before committing the Boost.filesystem implementation 20141014 20:03:25< shadowm> 2) Commit Boost.filesystem implementation to 1.12 20141014 20:03:48< shadowm> 3) Merge 1.12 into branch using --no-ff and the "ours" merge strategy. 20141014 20:04:17< shadowm> 4) Now we can keep merging 1.12 into the alternate branch forever without worrying about the Boost.filesystem implementation cropping up again. 20141014 20:04:22-!- kex [~kex@77.28.25.242] has joined #wesnoth-dev 20141014 20:04:46< shadowm> (Probably every time a release is being tagged.) 20141014 20:04:56-!- kex [~kex@77.28.25.242] has quit [Remote host closed the connection] 20141014 20:05:11-!- kex [~kex@77.28.25.242] has joined #wesnoth-dev 20141014 20:06:24< gfgtdf> shadowm: that sounds doable. 20141014 20:07:29< gfgtdf> shadowm: but taht woudl also cause mergign conflicts if the lines that the bfs branch changes woudl be changes in a later commit 20141014 20:08:50< shadowm> As far as I understand, the implementation details are entirely self-contained and no code that uses the filesystem namespace needs to know that it internally uses bfs, right? 20141014 20:09:38< shadowm> We can repeat steps 2 and 3 at later points if the bfs implementation details are modified. 20141014 20:09:40< gfgtdf> shadowm: taht that true for the boost filesysrtem part but not for the sdl mixer part (although taht coudl also be arrranged) 20141014 20:10:40< shadowm> Alternatively, and this is just an idea, #ifdefs. 20141014 20:11:25< gfgtdf> shadowm: i completely forgot about ifdefs :) 20141014 20:12:47< shadowm> shikadibot: seen happygrue 20141014 20:12:47< shikadibot> shadowm: The person with the nick happygrue last spoke 3d ago. 17h 5m ago was here and on the channel #wesnoth-umc-dev with the message: Remote host closed the connection 20141014 20:13:27< mattsc> iceiceice, gfgtdf, shadowm: just wanted to say thank you for pushing this forward! I will try to keep up with things as much as my limited knowledge of the topic allows 20141014 20:14:58< shadowm> Ugh, po4a-gettextize believes