--- Log opened Tue Nov 04 00:00:12 2014 --- Day changed Tue Nov 04 2014 20141104 00:00:12 * shadowm kicks c74d. 20141104 00:00:26< irker311> wesnoth: Chris Beck wesnoth:master d34a1bf9adf7 / RELEASE_NOTES: mention boost random in release notes http://git.io/XZ_Qcg 20141104 00:00:28< irker311> wesnoth: Chris Beck wesnoth:master 3a32e1e09854 / RELEASE_NOTES: update RELEASE_NOTES to contain the resolution of the BFS saga http://git.io/75hKZA 20141104 00:00:31< iceiceice> shadowm: i updated the release notes 20141104 00:00:32< shadowm> You did that 3 seconds earlier than 21:00 CLST. 20141104 00:00:44< shadowm> So much for machine-like precision. 20141104 00:01:33< irker311> wesnoth: Chris Beck wesnoth:master 0c5ceea3f13e / changelog: update changelog http://git.io/FHIi3g 20141104 00:02:54< c74d> I blame the Network Time Protocol. 20141104 00:04:34< iceiceice> c74d: quite plausible 20141104 00:05:00< shadowm> iceiceice, gfgtdf: Rebuilt. 20141104 00:05:08< iceiceice> thank you 20141104 00:05:10< iceiceice> i am off for dinner 20141104 00:05:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20141104 00:05:17-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141104 00:29:43-!- travis-ci [~travis-ci@ec2-54-166-82-246.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 00:29:44< travis-ci> wesnoth/wesnoth#4597 (master - da9ea37 : Chris Beck): The build passed. 20141104 00:29:44< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/39894026 20141104 00:29:44-!- travis-ci [~travis-ci@ec2-54-166-82-246.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 00:32:50-!- duncan_shriek [~roland@2a01:1e8:e100:8618::24] has quit [] 20141104 00:42:07< gfgtdf> shadowm: do you know what the file loadscreen_empty.cpp does? 20141104 00:46:56< gfgtdf> shadowm: it seems to be involved in wesnothd but i cannot see why 20141104 00:47:00-!- gfgtdf [~chatzilla@f054152069.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 32.0.3/20140923175406]] 20141104 00:56:26-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20141104 01:02:14< irker311> wesnoth: Fabian Müller wesnoth:master f15d6ef37f70 / src/game_initialization/ (create_engine.cpp create_engine.hpp): Display the campaign's icon in the create multiplayer dialog. http://git.io/rZCg5A 20141104 01:03:14< irker311> wesnoth: Fabian Müller wesnoth:1.12 14e3c3422aeb / data/campaigns/Legend_of_Wesmere/scenarios/chapter2/04_The_Elvish_Treasury.cfg: LoW 04: Correct the side ownership of Cleodil's units. http://git.io/g0Cu2A 20141104 01:07:23-!- mjs-de [~mjs-de@f049166004.adsl.alicedsl.de] has quit [Remote host closed the connection] 20141104 01:25:53< shadowm> gfgtdf: Nope, no idea about it. 20141104 01:32:06-!- travis-ci [~travis-ci@ec2-54-82-152-65.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 01:32:06< travis-ci> gfgtdf/wesnoth-old#347 (sidecontroller_refactor - afe9132 : gfgtdf): The build was fixed. 20141104 01:32:06< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/39900455 20141104 01:32:06-!- travis-ci [~travis-ci@ec2-54-82-152-65.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 01:33:40-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev 20141104 01:34:58-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20141104 01:43:26-!- Anakonda_ [Anakonda@87-92-254-66.bb.dnainternet.fi] has joined #wesnoth-dev 20141104 01:47:22-!- Anakonda [Anakonda@87-92-254-66.bb.dnainternet.fi] has quit [Ping timeout: 240 seconds] 20141104 01:53:17< irker311> wesnoth: mattsc wesnoth:master 653282b584c8 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project file with new libboost_random dependency http://git.io/iorLKg 20141104 01:53:36< mattsc> iceiceice: ^ all good with Xcode 20141104 01:59:43-!- travis-ci [~travis-ci@ec2-54-166-82-246.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 01:59:43< travis-ci> gfgtdf/wesnoth-old#348 (sidecontroller_refactor - 655b284 : gfgtdf): The build is still failing. 20141104 01:59:43< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/39901097 20141104 01:59:43-!- travis-ci [~travis-ci@ec2-54-166-82-246.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 02:11:52-!- Anakonda_ [Anakonda@87-92-254-66.bb.dnainternet.fi] has quit [Read error: Connection reset by peer] 20141104 02:20:14-!- Jetrel is now known as ToadMaster 20141104 02:24:57-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [] 20141104 02:38:29-!- ToadMaster is now known as Jetrel 20141104 02:45:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141104 02:59:35-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141104 03:15:36-!- ryao [~ryao@gentoo/developer/ryao] has quit [Ping timeout: 260 seconds] 20141104 03:15:40-!- ryao__ [user81198@smtp.gentoo.org] has joined #wesnoth-dev 20141104 03:17:55-!- Ivanovic_ [~ivanovic@frnk-5f74c542.pool.mediaWays.net] has joined #wesnoth-dev 20141104 03:17:55-!- Ivanovic_ [~ivanovic@frnk-5f74c542.pool.mediaWays.net] has quit [Changing host] 20141104 03:17:55-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20141104 03:21:04-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 245 seconds] 20141104 03:21:55-!- Ivanovic_ is now known as Ivanovic 20141104 03:42:59-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection] 20141104 03:48:12-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev 20141104 03:50:41-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 264 seconds] 20141104 04:25:04-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now] 20141104 05:16:30-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141104 05:21:26-!- sachith500 [~kvirc@112.134.144.60] has joined #wesnoth-dev 20141104 05:31:21-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20141104 05:31:40-!- sachith500 [~kvirc@112.134.144.60] has quit [Read error: Connection reset by peer] 20141104 05:32:25-!- sachith500 [~kvirc@112.134.144.60] has joined #wesnoth-dev 20141104 05:36:20-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 255 seconds] 20141104 05:48:32-!- sachith500 [~kvirc@112.134.144.60] has quit [Read error: Connection reset by peer] 20141104 05:49:00-!- sachith500 [~kvirc@112.134.144.60] has joined #wesnoth-dev 20141104 05:51:04-!- cib0 [~cib@p5DD2252C.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141104 05:56:47-!- Sulfur [~Miranda@p5B327852.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141104 06:19:00-!- Netsplit *.net <-> *.split quits: irker311, [Relic], esr 20141104 06:24:30< iceiceice> mattsc: thanks 20141104 06:25:42-!- sachith500|2 [~kvirc@112.134.231.251] has joined #wesnoth-dev 20141104 06:26:07-!- sachith500 [~kvirc@112.134.144.60] has quit [Ping timeout: 245 seconds] 20141104 06:26:37-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20141104 06:26:37-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20141104 06:26:37-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20141104 06:28:17-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20141104 06:34:06-!- sachith500|2 [~kvirc@112.134.231.251] has quit [Read error: Connection reset by peer] 20141104 06:49:44-!- cib0 [~cib@p5DD2252C.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 20141104 06:51:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141104 07:17:55-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20141104 07:20:28-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20141104 07:24:52-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 256 seconds] 20141104 07:43:39-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20141104 07:48:06-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141104 07:48:22-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 250 seconds] 20141104 07:48:59-!- thunderstruck [~zaibotren@cpc8-sgyl29-2-0-cust37.sgyl.cable.virginm.net] has joined #wesnoth-dev 20141104 08:01:44-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds] 20141104 08:06:20-!- sachith500|2 [~kvirc@112.134.231.251] has joined #wesnoth-dev 20141104 08:18:29-!- sachith500|2 [~kvirc@112.134.231.251] has quit [Ping timeout: 244 seconds] 20141104 08:36:25-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has joined #wesnoth-dev 20141104 08:38:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141104 09:16:00-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141104 09:27:10-!- cib0 [~cib@132.231.178.91] has joined #wesnoth-dev 20141104 09:38:32-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 260 seconds] 20141104 10:18:44-!- cib0 [~cib@132.231.178.91] has quit [Ping timeout: 250 seconds] 20141104 10:27:16-!- Sulfur [~Miranda@p5B327852.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141104 10:31:42-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-115.wireless.uva.nl] has joined #wesnoth-dev 20141104 10:33:37-!- mjs-de [~mjs-de@f049166004.adsl.alicedsl.de] has joined #wesnoth-dev 20141104 11:07:27-!- kex [~kex@46.217.86.12] has joined #wesnoth-dev 20141104 11:12:05-!- kex [~kex@46.217.86.12] has quit [Ping timeout: 244 seconds] 20141104 11:39:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141104 11:40:49-!- Sulfur [~Miranda@p5B327852.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141104 11:44:27-!- cib0 [~cib@132.231.178.148] has joined #wesnoth-dev 20141104 11:54:56-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-115.wireless.uva.nl] has quit [Ping timeout: 250 seconds] 20141104 11:59:25-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-115.wireless.uva.nl] has joined #wesnoth-dev 20141104 12:23:08-!- kex [~kex@46.217.86.12] has joined #wesnoth-dev 20141104 12:45:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20141104 13:01:24-!- cib0 [~cib@132.231.178.148] has quit [Ping timeout: 255 seconds] 20141104 13:03:30-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!] 20141104 13:17:09-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev 20141104 13:18:23-!- Anakonda [Anakonda@87-92-145-160.bb.dnainternet.fi] has joined #wesnoth-dev 20141104 13:20:12-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20141104 13:34:58-!- duncan_shriek [~roland@2a01:1e8:e100:8618::24] has joined #wesnoth-dev 20141104 13:46:39-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-115.wireless.uva.nl] has quit [Ping timeout: 250 seconds] 20141104 13:57:58-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20141104 13:58:06-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20141104 14:01:16-!- jiven [~jiven@2001:660:2402:14:54cf:6576:7fc9:9f03] has joined #wesnoth-dev 20141104 14:01:18< jiven> Hello 20141104 14:02:38< jiven> So I was here yesterday asking about helping developing Wesnoth or translating it 20141104 14:02:49< jiven> And I was wondering about the state of the French translation 20141104 14:03:01< jiven> Because I can help with it 20141104 14:06:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20141104 14:08:04< Crendgrim> jiven: http://wiki.wesnoth.org/FrenchTranslation 20141104 14:08:50< duncan_shriek> In answering my own question from yesterday about the failed build in http://hautz.de/wesnoth.make.log I have now googled up the answer http://hautz.de/0001-Needed-because-of-https-svn.boost.org-trac-boost-tic.patch 20141104 14:09:10< jiven> Crendgrim: thanks 20141104 14:09:23< duncan_shriek> http://hautz.de/0001-Needed-because-of-https-svn.boost.org-trac-boost-tic.patch 20141104 14:09:33< duncan_shriek> (again in one line ;-) ) 20141104 14:16:16-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141104 14:19:07-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds] 20141104 14:37:23-!- jiven is now known as Jiven 20141104 14:39:30< iceiceice> duncan_shriek: am i to conclude from your commit message that you are using VS 2010? 20141104 14:39:40-!- roland_ [~roland@2a01:1e8:e100:8618::24] has joined #wesnoth-dev 20141104 14:39:45-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev 20141104 14:39:46-!- duncan_shriek [~roland@2a01:1e8:e100:8618::24] has quit [Read error: Connection reset by peer] 20141104 14:58:23-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev 20141104 15:00:57-!- Jiven [~jiven@2001:660:2402:14:54cf:6576:7fc9:9f03] has quit [Ping timeout: 265 seconds] 20141104 15:04:35-!- gfgtdf [~chatzilla@e177173208.adsl.alicedsl.de] has joined #wesnoth-dev 20141104 15:07:14< gfgtdf> iceiceice: why do think hes using msvc ? 20141104 15:07:49< gfgtdf> iceiceice: to me http://hautz.de/wesnoth.make.log doesnt look like msvc 20141104 15:07:59-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping] 20141104 15:08:52< roland_> right, it's gnu 4.8.3 20141104 15:10:00-!- Jiven [~Jiven@2001:660:2402:14:54cf:6576:7fc9:9f03] has joined #wesnoth-dev 20141104 15:12:13-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer] 20141104 15:17:25-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20141104 15:27:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20141104 15:29:00-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141104 15:30:37< iceiceice> gfgtdf: hmm i thought the boost ticket said it was msvc issue 20141104 15:32:28< iceiceice> i don't think its gcc 4.8 issue, travis is compiling fine with this 20141104 15:33:03< gfgtdf> iceiceice: you know whta boost version our travis uses ? 20141104 15:33:15< iceiceice> its in the logs 20141104 15:33:52< iceiceice> 1.53.0 20141104 15:33:53< iceiceice> https://travis-ci.org/wesnoth/wesnoth/jobs/39903890#L208 20141104 15:33:54< gfgtdf> 1.53 it seems 20141104 15:34:02< gfgtdf> you faster 20141104 15:34:06< iceiceice> hehe 20141104 15:34:15< iceiceice> im going to output the exact gcc version number 20141104 15:34:53< roland_> I think it's the boost version. Mine is 155.0 20141104 15:37:31-!- irker543 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20141104 15:37:31< irker543> wesnoth: Chris Beck wesnoth:master 54c602c05679 / .travis.yml: output compiler version info in the travis logs http://git.io/PLplgw 20141104 15:37:31< irker543> wesnoth: Chris Beck wesnoth:master ee79fd973035 / / (3 files in 2 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/EnAiHg 20141104 15:37:34< gfgtdf> iceiceice: but travis doesnt compile with c++11 activaed 20141104 15:37:55< gfgtdf> (at least i think) 20141104 15:37:58< iceiceice> no it doesnt 20141104 15:38:04< iceiceice> i thought that didnt work yet? 20141104 15:38:23< gfgtdf> iceiceice: if i remember correctly the patch was abotu c++11 20141104 15:38:27< roland_> it doesn't work otherwise 20141104 15:38:44< gfgtdf> iceiceice: maybe we choudl make one of our travis buidls use c++11 20141104 15:38:46< roland_> boost an application have to be compiles with the samd -std 20141104 15:38:59< iceiceice> roland_: you have to compile boost with c++98 standard 20141104 15:39:05< roland_> otherwise the are not ABI compatibel 20141104 15:39:16< roland_> but my boost is c++11 20141104 15:39:21< iceiceice> you have to recompile 20141104 15:39:27< iceiceice> the project is not really c++11 yet 20141104 15:39:33< gfgtdf> iceiceice: you sure `? 20141104 15:39:35< iceiceice> we would like to be but we aren't there 20141104 15:39:52< gfgtdf> iceiceice: just becsue we dont require c++11 it doesnt mena tht we dont support it 20141104 15:39:53< iceiceice> gfgtdf: idk did you ever get it to work with c++11 on? 20141104 15:40:04< iceiceice> i remember i tried and there were still problems 20141104 15:40:05< gfgtdf> iceiceice: msvc doesnt have an c++11 siwtch 20141104 15:40:09< iceiceice> but it was maybe 6 months ago 20141104 15:40:29< roland_> gfgtdf: sure I'm sure, did it myself ;-) 20141104 15:40:36< gfgtdf> iceiceice: i can eighe ruse "something bewteen c++11 and c++98" or "C89" are the only modes 20141104 15:40:44< iceiceice> hmm 20141104 15:41:06< iceiceice> gfgtdf: if we had got everything working with c++11, 20141104 15:41:12< iceiceice> i think there would have been an email announcing this 20141104 15:41:19< iceiceice> and we would drop support for c++98 20141104 15:41:26< gfgtdf> iceiceice: also aquiera uses a newer msvc compiler which is more liek c++11 than liek c++03 20141104 15:41:44< gfgtdf> iceiceice:there are still cpmpiler that doens thave c++1 support 20141104 15:41:46< roland_> at least that was the only compilation problem with wesnoth c++11 20141104 15:42:49< iceiceice> https://mail.gna.org/public/wesnoth-dev/2014-05/msg00002.html 20141104 15:42:59< iceiceice> https://mail.gna.org/public/wesnoth-dev/2014-05/msg00004.html 20141104 15:44:51< roland_> by the way, I didn't force my wesnoth build into c++11. Cmake has chosen that , and I didn't object 20141104 15:45:28< iceiceice> this is what i get when i try to turn on c++11: https://gist.github.com/cbeck88/c5c7326d6b4603cba5b9 20141104 15:45:52< iceiceice> roland_: the cmake recipe is not very well maintained 20141104 15:46:06< iceiceice> i dont know why it would choose c++11 but it doesn't suprise me if you have problems 20141104 15:47:09< roland_> I have no problem any longer! (Besides of linking HEAD to boost::random ATM) 20141104 15:47:44< gfgtdf> iceiceice: thta looks liek a known ug in clang: https://bbs.archlinux.org/viewtopic.php?id=181094 20141104 15:47:52< gfgtdf> iceiceice: unrelared to wesnoth 20141104 15:48:50< roland_> My patch shouldn't harm a c++98 build. Did somebody try that? 20141104 15:50:13< iceiceice> roland_: if you make a github pull request, travis will try to build 20141104 15:50:49< iceiceice> gfgtdf: i'm trying to use gcc with c++11 now 20141104 15:51:05< roland_> iceiceice: I would like to do that, but for reasons unknown github doesn't want me to fork wesnoth/wesnoth 20141104 15:51:45< iceiceice> hmm, you'l have to wait to find out then 20141104 15:53:05< gfgtdf> roland_: maybe you have it already forked? 20141104 15:53:39< roland_> gfgtdf: no, i have a sinle repository on github as of yet 20141104 15:53:52< roland_> *not a single* 20141104 15:54:12< iceiceice> roland_ i think you have to make an account 20141104 15:54:12-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev 20141104 15:54:28< iceiceice> maybe its not logged in or something? 20141104 15:54:30< iceiceice> idk 20141104 15:54:40< iceiceice> gfgtdf: if it just magically works with c++11 now i'll be surprised 20141104 15:54:41< roland_> iceiceice: of course, 20141104 15:54:51< roland_> iceiceice: i have one 20141104 15:55:03< iceiceice> maybe the fact you used msvc all this time meant you fixed whatever probems we had? 20141104 15:55:44< gfgtdf> iceiceice: my msvc 2010 doesn support that much c++11 features 20141104 15:56:58< iceiceice> yeah but maybe whatever compilation problems we had only used a subset 20141104 15:57:36< iceiceice> i have gotten through all of AI now, 20141104 15:57:48< iceiceice> if i can get through all of /gui then i will have high hopes 20141104 15:59:07< iceiceice> gfgtdf: hmm wait so is there msvc that supports all of c++11 ? 20141104 15:59:53< iceiceice> roland_: now i got your bug: 20141104 16:00:29< roland_> iceiceice: i'm not surprised 20141104 16:00:52-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20141104 16:01:19< iceiceice> roland_: you said it works for you after this patch? 20141104 16:01:23< iceiceice> the whole build? 20141104 16:01:53< gfgtdf> iceiceice: no even msvc2013 doesnt really support c++11 20141104 16:02:08< gfgtdf> iceiceice: esp it doesn't support constexpr 20141104 16:02:24< roland_> well, as i said, it compiled all but that one, but didn't link to boost::random 20141104 16:02:59-!- travis-ci [~travis-ci@ec2-54-221-40-13.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 16:02:59< travis-ci> gfgtdf/wesnoth-old#349 (sidecontroller_refactor - e0757e8 : gfgtdf): The build was fixed. 20141104 16:02:59< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/39953338 20141104 16:02:59-!- travis-ci [~travis-ci@ec2-54-221-40-13.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 16:04:02< roland_> the link issue I could fix myself, but I'm shure you commit the fix soon enough ;-) 20141104 16:04:11< iceiceice> if it works 20141104 16:04:37< iceiceice> i didnt realize we actually could compile with c++11 turned on 20141104 16:04:45< iceiceice> i thought it was totally broken 20141104 16:05:11< iceiceice> gfgtdf: but i guess we can't move the whole project to c++11? if msvc doesn't actually support 20141104 16:06:25< gfgtdf> iceiceice: y, but still i think we can try to keep c++11 by having one of your builds use c++11 compability esp if it turn out that we currently support it. 20141104 16:07:03< iceiceice> maybe we should add another build? 20141104 16:08:25< iceiceice> right now theres gcc -O0, gcc-O2, clang -O0 20141104 16:09:32< iceiceice> wow that's wierd 20141104 16:09:33< iceiceice> virtual memory exhausted: Cannot allocate memory 20141104 16:09:33< iceiceice> scons: *** [build/release/gui/dialogs/editor_generate_map.o] Error 1 20141104 16:12:12< iceiceice> brb 20141104 16:12:13-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141104 16:17:21-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has joined #wesnoth-dev 20141104 16:17:27< Dugi> Hello guys. 20141104 16:17:38-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141104 16:23:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141104 16:26:29-!- gfgtdf [~chatzilla@e177173208.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 32.0.3/20140923175406]] 20141104 16:35:38-!- cib0 [~cib@p5DD2252C.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141104 16:37:18-!- Sulfur [~Miranda@p5B327852.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141104 16:42:47< irker543> wesnoth: Chris Beck wesnoth:master 1bf85228da78 / .travis.yml: move cxx version check to after we install compiler upgrade http://git.io/bZhfuQ 20141104 16:42:49< irker543> wesnoth: Chris Beck wesnoth:master 0e9dcfb3db03 / src/game_events/action_wml.cpp: fixup C++11 compilation, thanks to duncan_shriek/roland_ on irc http://git.io/d-HDHg 20141104 16:42:51< irker543> wesnoth: Chris Beck wesnoth:master 043fe01c42d1 / .travis.yml: add a CXX11 build to travis http://git.io/skH1iw 20141104 16:56:13< irker543> wesnoth: Chris Beck wesnoth:master 37ca01a9f775 / .travis.yml: fixup travis http://git.io/IK0S_g 20141104 17:00:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141104 17:00:29< fendrin> hi Dugi 20141104 17:01:55< irker543> wesnoth: Chris Beck wesnoth:master f7dd05a07134 / .travis.yml: fixup .travis.yml http://git.io/k1xChQ 20141104 17:06:14-!- Jiven [~Jiven@2001:660:2402:14:54cf:6576:7fc9:9f03] has quit [Quit: Au revoir] 20141104 17:07:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141104 17:11:39< irker543> wesnoth: Chris Beck wesnoth:master 2474c37659b7 / .travis.yml: fixup travis http://git.io/8GOlSA 20141104 17:12:14-!- travis-ci [~travis-ci@ec2-54-221-40-13.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 17:12:14< travis-ci> wesnoth/wesnoth#4612 (master - f7dd05a : Chris Beck): The build has errored. 20141104 17:12:14< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/39964400 20141104 17:12:14-!- travis-ci [~travis-ci@ec2-54-221-40-13.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 17:13:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141104 17:14:36-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20141104 17:16:42< roland_> on travis-ci is gcc 4.6.3 That's pretty old 20141104 17:17:04< AI0867> yeah, it's an LTS ubuntu 20141104 17:17:54< roland_> my oldest gcc lying around is 4.6.4 and that one can not c++11, but at most -std=gnu++0x 20141104 17:18:22< vultraz> Isn't 14.04 lts? 20141104 17:18:35< AI0867> maybe, but upgrading takes effort =P 20141104 17:20:22-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141104 17:27:13< irker543> wesnoth: Chris Beck wesnoth:master 2f160de8a5be / .travis.yml: show scons parameters in .travis.yml http://git.io/HRlHyQ 20141104 17:27:29< fendrin> The engine tells me: 20141104 18:19:35 warning unit: Unknown attribute 'no_recruit' discarded. 20141104 17:27:46< fendrin> fabi@sepia:/usr/local/src/git/wesnoth$ grep -r "no_recruit" data/* 20141104 17:27:46< fendrin> fabi@sepia:/usr/local/src/git/wesnoth$ 20141104 17:30:47< iceiceice> fabi: its in the src/ 20141104 17:31:24< iceiceice> something about, gets created by mp connect for private use, but ends up getting inside [team] somehow 20141104 17:31:28< iceiceice> or the leader 20141104 17:31:28< iceiceice> idk 20141104 17:31:39< iceiceice> fendrin: ^ 20141104 17:32:14< iceiceice> roland_: travis actually uses 4.8 20141104 17:32:56< iceiceice> https://travis-ci.org/wesnoth/wesnoth/jobs/39965321#L594 20141104 17:34:45< fendrin> iceiceice: Who coded the connect engine thing? 20141104 17:35:18< roland_> iceiceice: ah, i see 20141104 17:35:20< iceiceice> https://gna.org/bugs/index.php?22162 20141104 17:35:25< iceiceice> fendrin: ^ 20141104 17:39:44-!- gfgtdf [~chatzilla@e177173208.adsl.alicedsl.de] has joined #wesnoth-dev 20141104 17:40:11< gfgtdf> iceiceice, fendrin: i'd be happy if you wouldnt commit to mp_connect engine in master today. 20141104 17:40:31< iceiceice> yeah i didn't plan to 20141104 17:41:29< fendrin> gfgtdf: No intention to do so. 20141104 17:41:31< iceiceice> gfgtdf: i get a bunch of warnings now with c++11 20141104 17:41:32< iceiceice> https://travis-ci.org/wesnoth/wesnoth/jobs/39965322#L5716 20141104 17:42:00< iceiceice> i think i will make c++11 build be strict=false? 20141104 17:43:05< gfgtdf> iceiceice: the main error seems to be "auto_ptr is deprecated" 20141104 17:43:14< iceiceice> yeah but there's probably alot more... 20141104 17:43:29< gfgtdf> iceiceice: we shoudl test whether we cahn replace it with boost::soped_ptr or boost::shared_ptr 20141104 17:43:47< iceiceice> y but i dont want to do it right now 20141104 17:43:54< irker543> wesnoth: Fabian Müller wesnoth:1.12 345f22ffc798 / data/campaigns/Legend_of_Wesmere/utils/characters.cfg: LoW: Macros: Fixed wrong spelled persistent attribute. http://git.io/DZoM6A 20141104 17:43:54< gfgtdf> iceiceice: y i think making it non strict is a good idea, we can then decide what we do if we see all warnings 20141104 17:43:56< irker543> wesnoth: Fabian Müller wesnoth:1.12 246f42dc6ae2 / data/campaigns/Legend_of_Wesmere/scenarios/chapter2/04_The_Elvish_Treasury.cfg: LoW 04 MP: Change unit ownership of the "liberator" to Cleodil's side. http://git.io/w2Mosg 20141104 17:43:58< irker543> wesnoth: Fabian Müller wesnoth:1.12 704e71dd82c0 / data/tools/emacs_mode/wesnoth-wml-data.el: Update of the wml emacs mode database. http://git.io/dm70eg 20141104 17:44:01< iceiceice> ok 20141104 17:46:11< irker543> wesnoth: Chris Beck wesnoth:master 5a8485d22568 / src/ (display.hpp image.hpp): fixup a warning (c++11 unused variable) http://git.io/zqzrzQ 20141104 17:46:13< irker543> wesnoth: Chris Beck wesnoth:master 8bf3a0ddd7cc / .travis.yml: make the c++11 build non-strict http://git.io/GcbaAQ 20141104 17:47:42< gfgtdf> iceiceice: ok i read in the internet that auto_ptr is deprecated becasue c++11 move sceamtics 20141104 17:47:56< irker543> wesnoth: Chris Beck wesnoth:master 1401bc8d17f8 / .travis.yml: fixup travis http://git.io/hhNMkQ 20141104 17:49:09< gfgtdf> iceiceice: so what could be needed is someinth like typedef auto_ptr or unique_ptr in #if HAVE_STD_UNIQUE_PTR 20141104 17:57:16< gfgtdf> iceiceice: you see a readon againdt merging https://github.com/wesnoth/wesnoth/pull/321 ? 20141104 17:57:47< irker543> wesnoth: Chris Beck wesnoth:master e8698e49be53 / .gitignore: refactor gitignore: ignore all build scripts (*build*.sh) http://git.io/wcC1Uw 20141104 17:59:30-!- noy [~Noy@184.69.143.198] has joined #wesnoth-dev 20141104 17:59:38-!- noy [~Noy@184.69.143.198] has quit [Changing host] 20141104 17:59:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141104 17:59:53< iceiceice> gfgtdf: i will read 20141104 18:04:06< iceiceice> gfgtdf: the only thing i dont like is that it adds more resources:: links to team 20141104 18:05:23< gfgtdf> iceiceice: i coudl also put a is_networked(const &side) function to the playcontroller, than that calling fucntion woudlneed to do the resourcess:: call 20141104 18:06:45< iceiceice> yeah... 20141104 18:07:30< iceiceice> when is it needed to know if the team is networked? 20141104 18:08:28< iceiceice> i guess mostly only by play_controller / menu_events anyways 20141104 18:09:03< iceiceice> its something that can be worked on latedr 20141104 18:12:55< iceiceice> gfgtdf: do you think we should replace this with mt19937 generator? https://github.com/wesnoth/wesnoth/blob/master/src/lua/lmathlib.cpp#L203 20141104 18:17:46< gfgtdf> iceiceice: i actualy wouldn't change the lualib if not needed. In fact i was also doubtful of this commit https://github.com/wesnoth/wesnoth/commit/f5e673e6443220c57e40cea31d430870b4f73925 which adds boost as a dependency to our lua implementation just for the pi constant. 20141104 18:18:13< iceiceice> gfgtdf: did you see shadowm's post earlier? 20141104 18:18:18< iceiceice> about the difficulty of upgrading our lua base 20141104 18:18:35< gfgtdf> iceiceice: y thats also a reason 20141104 18:19:05< iceiceice> theres about 8 commits we've made in src/lua 20141104 18:19:14< iceiceice> https://gist.github.com/cbeck88/a89d2e9294a652779201 20141104 18:19:26< iceiceice> maybe we should revert some of them 20141104 18:19:41< iceiceice> or just not reapply them 20141104 18:20:14< gfgtdf> iceiceice: how do you count '8' ? 20141104 18:20:39< iceiceice> i only counted back to "upgrade to 5.2" 20141104 18:20:42< iceiceice> maybe thats wrong 20141104 18:21:32< iceiceice> some of these bugs i guess might also be fixed officially in 5.3 20141104 18:21:39< gfgtdf> iceiceice: is teh lua/Sconscript fiel also part of the original lua ? 20141104 18:22:36< iceiceice> no i think its from here: https://github.com/wesnoth/wesnoth/commit/725c567339035760002b5e57be4e7eaefc59a702 20141104 18:25:06-!- travis-ci [~travis-ci@ec2-54-167-224-232.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 18:25:06< travis-ci> wesnoth/wesnoth#4616 (master - 8bf3a0d : Chris Beck): The build was canceled. 20141104 18:25:06< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/39968755 20141104 18:25:06-!- travis-ci [~travis-ci@ec2-54-167-224-232.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 18:36:52< irker543> wesnoth: Chris Beck wesnoth:master 49d3653ed936 / src/ (image.cpp menu_events.cpp): fixup commit which eliminated image::tile_size http://git.io/wx4pVA 20141104 18:39:45-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141104 18:47:32-!- kex [~kex@46.217.86.12] has quit [Remote host closed the connection] 20141104 18:47:58-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141104 18:49:47-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20141104 18:50:25-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowm] has quit [Remote host closed the connection] 20141104 18:50:30-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds] 20141104 18:51:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141104 19:02:53-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141104 19:05:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 255 seconds] 20141104 19:05:34-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141104 19:08:09-!- noy_ [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 255 seconds] 20141104 19:09:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141104 19:11:46-!- stairway [~stairway@p20030056CB51E50100AAF52399E6F78E.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141104 19:17:36< irker543> wesnoth: Fabian Müller wesnoth:1.12 790adbcd3a69 / data/themes/default.cfg: Move the status icons a bit upwards to fix its broken tooltip. http://git.io/5wb9Kg 20141104 19:17:44< mattsc> All: I am wondering whether it makes sense to create a 1.12.1 branch at this time. 20141104 19:17:46< mattsc> I have come across the situation (and I know others have too) that I have a change I know I want to make, but I cannot because of the string and feature freeze. I know it has to wait until 1.12.1, but it might be more efficient to do it while I am working and thinking on it right now. 20141104 19:18:16< mattsc> On the other hand, this would clearly cause conflicts for merging later - but then, given how close we are to 1.12.0, there might not be that many. 20141104 19:18:52< mattsc> I don’t know. And since this is my first time on the dev team for a stable release, I also have no idea what common practices are in this respect. 20141104 19:19:10< mattsc> Any comments, opinions, etc.? 20141104 19:21:23< iceiceice> i think its not a bad idea 20141104 19:21:39< iceiceice> it probably wouldn't cause many conflicts 20141104 19:21:48< iceiceice> there is a large backlog of such changes i think 20141104 19:22:10< iceiceice> maybe its a little less confusing if the branch is called "1.12-post-stringfreeze" 20141104 19:23:48< mattsc> yeah, that makes sense 20141104 19:23:55< iceiceice> the problem with the idea in general is that if large hunks of code do get moved around it will have conflicts 20141104 19:24:16< iceiceice> the best way to fix that is to periodically rebase it against 1.12 as development continues, and fix the problems as they arise 20141104 19:24:21< iceiceice> but that requires someone to do that 20141104 19:24:42< mattsc> right 20141104 19:25:47-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20141104 19:27:26< AI0867> mattsc: you can have a bunch of branches that you merge immediately after 1.12.0 is released 20141104 19:28:28< mattsc> AI0867: sure; what’s the advantage of several over just one though? 20141104 19:28:47< mattsc> oh, because I could have my own private branch for my own changes? 20141104 19:29:02< mattsc> and everybody could do the same, it doesn’t have to be a concerted effort? 20141104 19:35:30-!- ryao__ [user81198@smtp.gentoo.org] has quit [Changing host] 20141104 19:35:30-!- ryao__ [user81198@gentoo/developer/ryao] has joined #wesnoth-dev 20141104 19:37:30-!- ryao__ is now known as ryao 20141104 19:41:20< iceiceice> yeah but this way then i can see which ones actually got fixed 20141104 19:41:39< iceiceice> rather than having everyone secretly fix bugs separately 20141104 19:59:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141104 20:05:29< iceiceice> gfgtdf: looks like only 2 warnings actually 20141104 20:05:31< iceiceice> for c++11 20141104 20:05:33< iceiceice> https://travis-ci.org/wesnoth/wesnoth/jobs/39973506 20141104 20:06:31-!- travis-ci [~travis-ci@ec2-54-160-187-189.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 20:06:31< travis-ci> wesnoth/wesnoth#4620 (master - 49d3653 : Chris Beck): The build passed. 20141104 20:06:31< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/39973499 20141104 20:06:31-!- travis-ci [~travis-ci@ec2-54-160-187-189.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 20:09:43< gfgtdf> iceiceice: one of them is in usr/include/libpng12/png.h which micgh be hard to fix 20141104 20:09:56< gfgtdf> iceiceice: i wonder why it even whows warnings for external code ? 20141104 20:10:24< gfgtdf> shows. 20141104 20:10:48< iceiceice> maybe can turn off the warning for that file 20141104 20:34:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141104 20:36:56< iceiceice> gfgtdf: do you think i should merge this? 20141104 20:36:58< iceiceice> https://github.com/wesnoth/wesnoth/pull/304 20141104 20:37:38< iceiceice> i thoguht also to backport because of bug report 20141104 20:38:27< gfgtdf> iceiceice: that code in playcampaign often uses std::cerr instead of our ..._ERR streams 20141104 20:38:30< gfgtdf> iceiceice: you know why ? 20141104 20:38:49< iceiceice> oh 20141104 20:38:53< iceiceice> i just remembered why its chat way 20141104 20:38:55< iceiceice> *that way 20141104 20:39:08< iceiceice> because if you write to _ERR during unit test, it fails 20141104 20:39:37< iceiceice> i guess it will fail in all those cases anyways though 20141104 20:39:58< irker543> wesnoth: Fabian Müller wesnoth:1.12 b808f0b5602b / data/campaigns/Legend_of_Wesmere/scenarios/chapter4/17_Breaking_the_Siege.cfg: LoW 17: Add type attribute to side 1. http://git.io/IWWIvw 20141104 20:40:00< irker543> wesnoth: Fabian Müller wesnoth:1.12 ff7a12493da9 / data/campaigns/Legend_of_Wesmere/scenarios/chapter5/21_Elvish_Assassins.cfg: LoW 21: Insert type attribute to fix wmllint warning. http://git.io/J3o04Q 20141104 20:40:44< iceiceice> i was thinking to backport some vesion of this but i'm worried to break the other exception handling 20141104 20:41:30< gfgtdf> iceiceice: were there other bugs except the map generation thing ? 20141104 20:41:49< iceiceice> so the main bug i found was, we don't catch "game::error" anywhere 20141104 20:41:57< iceiceice> even though its the base type of our errors 20141104 20:42:24< iceiceice> throw game::error causes wesnoth to exit at main 20141104 20:42:44< iceiceice> it also was the reason why, if you had missing button image in a custom theme, the game would just close 20141104 20:43:39< iceiceice> i fixed that earlier by making the button throw game::game_error instead 20141104 20:43:42< iceiceice> but now i think that was the wrong idea 20141104 20:46:05< gfgtdf> iceiceice: you want to make a custom exeption ? 20141104 20:46:35< iceiceice> for which? 20141104 20:47:04< gfgtdf> iceiceice: for teh missing theme elements. 20141104 20:47:12< iceiceice> you think thats better than catch game::error? 20141104 20:48:27< iceiceice> i think if you want wesnoth to exit at main you should just throw 42 20141104 20:48:48< iceiceice> idk though if game::error should catch at game_launcher, or at playcampaign, thoguh 20141104 20:48:55< gfgtdf> iceiceice: hmm i think game::error is just sd::exception with a string, mabye we coudl amke a class scenario_error for all errors that should be catched after the scenario 20141104 20:49:10< gfgtdf> iceiceice: eg in playcampaign. 20141104 20:49:59< iceiceice> ok 20141104 20:50:05< iceiceice> a different way is, 20141104 20:50:15< iceiceice> we already have game::game_error, i think that is meant for throws during the game 20141104 20:50:28< iceiceice> so maybe game::error should become sceanrio set up errors 20141104 20:51:02< iceiceice> already we have mapgen_exception and incorrect_map_format deriving from that i guess 20141104 20:52:16< iceiceice> ok, i would like to merge the pr but i wont catch game::error in playcampaign, only in game launcher 20141104 20:52:25< iceiceice> we can figure out what to do next 20141104 20:58:07-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds] 20141104 21:02:19-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!] 20141104 21:05:17-!- cib0 [~cib@p5DD2252C.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 20141104 21:10:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141104 21:16:10-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has joined #wesnoth-dev 20141104 21:21:56< Dugi> Please, how do I get a bool value from a WML table in C++? 20141104 21:22:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20141104 21:23:46< Dugi> Please, how do I get a bool value from a WML table in C++? 20141104 21:24:25< irker543> wesnoth: Chris Beck wesnoth:master cbb28fd5b0ee / src/game_initialization/playcampaign.cpp: add exception handlers for "game::error" in playcampaign.cpp http://git.io/8eEfGQ 20141104 21:24:27< irker543> wesnoth: Chris Beck wesnoth:master 6c5b43f3bede / src/game_initialization/playcampaign.cpp: fixup exception handler for replays http://git.io/-goK1Q 20141104 21:24:29< irker543> wesnoth: Chris Beck wesnoth:master 9e801244eae9 / src/game_launcher.cpp: add game::error handler to game_launcher.cpp, also mapgen errors http://git.io/yntdow 20141104 21:24:31< irker543> wesnoth: Chris Beck wesnoth:master 7e5632d36ceb / src/widgets/button.cpp: button ctor throws game::error when it can't find its image http://git.io/ZqWPMg 20141104 21:24:33< irker543> wesnoth: Chris Beck wesnoth:master 2885a3a9b31e / src/game_initialization/playcampaign.cpp: don't catch game::error in playcampaign.cpp http://git.io/d8FNNw 20141104 21:24:35< irker543> wesnoth: Chris Beck wesnoth:master 3787ec00c9d4 / src/game_initialization/playcampaign.cpp: use standard loggers instead of std::cerr http://git.io/0HBlCw 20141104 21:24:37< irker543> wesnoth: Chris Beck wesnoth:master 85e60b9147ef / src/ (game_initialization/playcampaign.cpp game_launcher.cpp widgets/button.cpp): Merge pull request #304 from cbeck88/fixup_exception_handlers http://git.io/Qc7CXw 20141104 21:24:43< iceiceice> gfgtdf: ^ 20141104 21:24:58< gfgtdf> iceiceice: what is teh difference between game_state class and game_board class ? 20141104 21:25:03< iceiceice> Dugi: cfg["foo"].to_bool() 20141104 21:25:20< Dugi> Thanks. And how do I convert it back? 20141104 21:25:27< iceiceice> cfg["foo"] = true 20141104 21:25:32< iceiceice> cfg["foo"] = bar 20141104 21:25:46< Dugi> Thanks. 20141104 21:25:51< iceiceice> gfgtdf: game_board is only supposed to capture the game state thats on the actual board 20141104 21:26:01< iceiceice> and hold some of the related functions 20141104 21:26:09< iceiceice> so it holds unit map, the game map, and the teams 20141104 21:26:34< iceiceice> game state is supposed to hold a bunch of extra state, including all wml vars, event queue (eventually) 20141104 21:26:45< iceiceice> idk about the lua state 20141104 21:26:58< iceiceice> ideally it should be part of gamestate but the way it works out it isnt 20141104 21:27:01< iceiceice> because it cant be saved 20141104 21:27:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141104 21:27:10< gfgtdf> ok, do you think the controller_client_id shoudl be in game_state or in game_board ? i ad it in game_state ebfore but i now need it in game_board::side_drop_to 20141104 21:27:31< gfgtdf> s/ad/had 20141104 21:28:19< iceiceice> maybe pass as arg to "side_drop_to" ? 20141104 21:28:26< iceiceice> idk 20141104 21:29:02< iceiceice> its a bit complicated because i wouldnt think it should be saved in a save game 20141104 21:29:12< gfgtdf> iceiceice: no its not 20141104 21:29:20< iceiceice> so my first thought is that it shouldnt be in gamestate 20141104 21:29:25< iceiceice> but i guess you cant watch a replay if you dont have it 20141104 21:30:18< gfgtdf> iceiceice: but i needed it in game_state::init that why i moved it from play_controller to game_state 20141104 21:30:26< gfgtdf> iceiceice: you dont need it for replays 20141104 21:30:36< iceiceice> how do you process side_drop info? 20141104 21:30:55< Dugi> iceiceice: How do I check if a WML value is nil? That it's an empty string? 20141104 21:31:01< gfgtdf> iceiceice: i need to set teh teams controller id to teh local contoller id 20141104 21:31:33< iceiceice> gfgtdf: maybe the function should also take a string i guess 20141104 21:31:39< gfgtdf> Dugi: the c++ code can distinguish between somekey="" and some key is not present 20141104 21:31:46< gfgtdf> iceiceice: hm ok 20141104 21:32:15< gfgtdf> Dugi: you can for example use config.has_attribute("somekey") 20141104 21:32:18< iceiceice> Dugi: read config.hpp 20141104 21:32:42< iceiceice> the config::attribute value is a magic type that can sort of be "anything" like lua 20141104 21:33:05< Dugi> Thanks for the information. 20141104 21:36:10< iceiceice> is there some git command to delete all branches that have been merged? 20141104 21:40:16< gfgtdf> iceiceice:: do you really have that much branches :o 20141104 21:40:44< gfgtdf> iceiceice: also note that there are some of teh branches form teh original wesnoth repo that are already merged 20141104 21:40:51< gfgtdf> iceiceice: i actauyl dont knwo why we have them 20141104 21:40:56< gfgtdf> actualy* 20141104 21:41:32< iceiceice> gfgtdf: https://gist.github.com/cbeck88/268211ef55f7ad723a1e 20141104 21:41:38< iceiceice> one thing i noticed is, 20141104 21:41:45< iceiceice> if i write git branch -d foo, 20141104 21:41:55< iceiceice> it might give me a different answer if i'm on master or 1.12 at that time 20141104 21:42:11< iceiceice> because it only checks if it got merged to my current branch, not whatever branch it was intended for 20141104 21:42:29< iceiceice> apparently 20141104 21:47:28< Ravana_> can http://pastebin.com/STyjd3ck be cause of http://pastebin.com/jvX7GCAR ? 20141104 21:48:03-!- travis-ci [~travis-ci@ec2-54-221-40-13.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 21:48:03< travis-ci> gfgtdf/wesnoth-old#351 (sidecontroller_refactor - 39a3ee4 : gfgtdf): The build was fixed. 20141104 21:48:03< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/39990930 20141104 21:48:03-!- travis-ci [~travis-ci@ec2-54-221-40-13.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 21:49:27< iceiceice> Ravana_: i think you are missing a comma 20141104 21:49:28< iceiceice> EmfGs 20141104 21:53:03< Ravana_> that seems most likely yes 20141104 21:57:04< Ravana_> seems that Efm not Emf based on https://raw.githubusercontent.com/wesnoth/wesnoth/master/players_changelog 20141104 22:05:36< iceiceice> man when did all these terrain codes change 20141104 22:07:32< iceiceice> 2012 i guess 20141104 22:07:52< bumbadadabum> 1.9 20141104 22:10:10< Ravana_> this code was from ME, that was made for 1.6 I think, today I just located this to be reason why my orocia sometimes kicks people out 20141104 22:11:05-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev 20141104 22:14:29< Dugi> Guys, any idea what might I be doing wrong when this happens? http://pastebin.com/1PWcGdNB 20141104 22:29:03< Dugi> Any idea how do I properly bind a bool variable to a checkbox? 20141104 22:34:14-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20141104 22:35:06< Dugi> It looks like if it handn't recognised the widget at all. 20141104 22:35:29-!- gfgtdf_ [~chatzilla@d148011.adsl.hansenet.de] has joined #wesnoth-dev 20141104 22:37:19-!- gfgtdf [~chatzilla@e177173208.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds] 20141104 22:37:24-!- gfgtdf_ is now known as gfgtdf 20141104 22:37:34-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 250 seconds] 20141104 22:37:53-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20141104 22:41:19< iceiceice> gfgtdf: can you give any insight why there is this assertion in the configure engine constructor? 20141104 22:42:22-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20141104 22:43:52< gfgtdf> iceiceice: to prevent the segfault rtaht woudl otherwise appear 20141104 22:44:04< Dugi> I have found the issue I was writing about, I should have placed that register_bool into the constructor, not into pre_show. 20141104 22:44:20< gfgtdf> iceiceice: you cannot query teh first side i it has not first side 20141104 22:44:22< iceiceice> gfgtdf: its really annoying that the configure and create engines have all these assertions 20141104 22:44:30< iceiceice> they should give legitimate error messages 20141104 22:44:36< gfgtdf> iceiceice: segfaults yould be more annoying 20141104 22:44:38< iceiceice> its really hard to make a new random map scenario right now 20141104 22:45:11< iceiceice> all it saves me is gdb run, imagine if i was a user 20141104 22:47:30-!- travis-ci [~travis-ci@ec2-54-160-187-189.compute-1.amazonaws.com] has joined #wesnoth-dev 20141104 22:47:30< travis-ci> wesnoth/wesnoth#4626 (master - 85e60b9 : Chris Beck): The build has errored. 20141104 22:47:30< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/39993876 20141104 22:47:30-!- travis-ci [~travis-ci@ec2-54-160-187-189.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141104 22:47:45< gfgtdf> iceiceice: well i still say better thna segfault 20141104 22:47:55< iceiceice> thats true 20141104 22:48:33< gfgtdf> iceiceice: obviously you cannot dereference "sides_.first" if sides_.first != sides_.second 20141104 22:48:42< gfgtdf> iceiceice: actualy i dont liek std::pair 20141104 22:48:47< gfgtdf> don't like* 20141104 22:48:53< gfgtdf> but that adiffernt issue 20141104 22:48:58< iceiceice> the point is that, if someone makes syntax error in wml, shouldn't get a crash 20141104 22:49:05< iceiceice> i think it wasnt your fault htough 20141104 22:50:14< gfgtdf> iceiceice: when i wrote that assert if was invokey by wrong c++ code any not by wrong wml 20141104 22:50:44< gfgtdf> iceiceice: it's sure that we shouldnt use assert if it casn be involked by wml 20141104 22:50:46< gfgtdf> true* 20141104 22:51:08< gfgtdf> iceiceice: actualy "sure" is fone too in this sentence :) 20141104 22:51:11< gfgtdf> fine* 20141104 22:52:03< gfgtdf> iceiceice: also i think it is ossible to have scenario without sides. 20141104 22:52:10< gfgtdf> possible* 20141104 22:52:15< gfgtdf> iceiceice: at least it was 20141104 22:52:56< gfgtdf> iceiceice: although it ended in an ininite loop if id didnt end during teh start event with an [endlevel] 20141104 22:53:28< Dugi> shadowm: You there? 20141104 22:53:50< gfgtdf> iceiceice: but i think i read somewhere that there were some "story-only" scenarios that have no sides or units 20141104 22:57:04< iceiceice> gfgtdf: i find this really annoying: 20141104 22:58:26< iceiceice> gahh 20141104 22:58:55< gfgtdf> ? 20141104 22:59:27-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev 20141104 23:00:09< Dugi> I have no idea who is responsible for this, but I have a strong suspicion that something is broken in addons_client::send_request . addons_client::send_simple_request is working fine but addons_client::send_request never finishes its action in the background. Can at least somebody try to confirm or refute this bug suspicion? 20141104 23:00:15-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20141104 23:01:24< roland_> Any ideas on replacing sdl_net to get ipv6 support? Me thinks, apache portable runtime might work. 20141104 23:01:56< gfgtdf> roland_: some of oyur code uses boost::asio 20141104 23:01:59< gfgtdf> our* 20141104 23:02:25< roland_> gfgtdf: ah. I'll have a look at that 20141104 23:04:04< gfgtdf> iceiceice: do you know how our server ensures thready savety? or is it singeltreaded ? 20141104 23:04:34< iceiceice> i dont have any idea 20141104 23:04:42< iceiceice> i think its not single threaded 20141104 23:09:57< gfgtdf> iceiceice: do ou know what "fps_limit" means for a server ? 20141104 23:11:40< iceiceice> probably abuse of terms 20141104 23:11:55< iceiceice> its probably just the cycle rate or something 20141104 23:13:13< gfgtdf> k 20141104 23:13:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 264 seconds] 20141104 23:15:14-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai] 20141104 23:20:07-!- stairway [~stairway@p20030056CB51E50100AAF52399E6F78E.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20141104 23:22:35< shadowm> Dugi: What you just said doesn't make sense because send_simple_request() is implemented as a wrapper around send_request(). 20141104 23:25:57< Dugi> shadowm: Yes, you're right. Still, it appears that whenever a request is sent (request terms, upload campaign), it hangs indefinitely, it seems that it received nothing even if the server sent it. Request campaign list sends a simple request and it works. It seems that my observation is wrong, but there is still a problem somewhere. 20141104 23:26:44< shadowm> I am observing no such an issue here and this code is running in the live add-ons server, so I'd have found out by now if it was broken for everyone. 20141104 23:27:33< shadowm> The new campaignd code, that is. The add-ons client code is obviously not used server-side. 20141104 23:28:10-!- mjs-de [~mjs-de@f049166004.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds] 20141104 23:28:38-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has quit [Ping timeout: 244 seconds] 20141104 23:28:48< Dugi> shadowm: Have you tried the latest wesnoth and the latest campaignd? 20141104 23:28:51< shadowm> So yes, there is still a problem somewhere and my clairvoyance skills are still unfit for the task, and you still haven't done as I suggested yesterday and provided a diff to inspect it. 20141104 23:29:24< Dugi> shadowm: Haven't noticed that. What diff? 20141104 23:29:43< shadowm> Yes, it works for me as I said above. 20141104 23:30:02< Dugi> The patch I have made is quite large, a diff would be quite large. 20141104 23:30:04< shadowm> A diff of your changes to the client and server code. 20141104 23:30:37< Dugi> Wait, I'll make it. 20141104 23:32:13< shadowm> iceiceice: Would you perhaps want to test this and see if you find any problems with it? https://github.com/wesnoth/wesnoth/pull/323 20141104 23:33:02-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20141104 23:33:06< shadowm> And yes, I'll reapply 299a29f99a84767731dbadd540712d1a37e5e10d on it as soon as I find the energy to look at the affected code paths in detail. 20141104 23:33:11< iceiceice> not at this moment 20141104 23:33:29< shadowm> Okay, but travis is running the WML test suite, right? 20141104 23:33:36< iceiceice> yeah but it doesnt use any lua really 20141104 23:33:43< shadowm> That's not true. 20141104 23:33:59< iceiceice> ok, whatever tags are implemented in lua 20141104 23:34:05< shadowm> There are several WML actions implemented in Lua, [event] included. 20141104 23:35:17< shadowm> Er, s/event/if/ 20141104 23:35:52< shadowm> The point is that if something went horribly wrong with the core Lua functionality, pretty much all tests would fail. 20141104 23:37:10< Dugi> shadowm: diff for client.cpp http://pastebin.com/Z5YvuQuu diff for campaign_server.cpp http://pastebin.com/wzj568Ka 20141104 23:37:32< shadowm> [store_unit], [modify_unit], [store_locations] are also some Lua-backed actions which I'm seeing in the tests' WML. 20141104 23:37:53< shadowm> Dugi: Give me a unified diff, please, not that. 20141104 23:37:56< iceiceice> shadowm: i guess 20141104 23:38:26< shadowm> Dugi: Instead of running diff by hand you should be using `git diff path1/to/file/or/directory [path2/ [path3/ [...]]]` 20141104 23:38:36< Dugi> shadowm: You mean just append one diff after another? 20141104 23:38:43< shadowm> No. 20141104 23:39:02< Dugi> shadowm: I wasn't sure if that would still compare it with master. 20141104 23:39:05< iceiceice> shadowm: my feeling is that there's a huge amount of code in the lua api, probably none of that is tested 20141104 23:39:19-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 264 seconds] 20141104 23:39:28< iceiceice> the whole lua c api 20141104 23:39:39< shadowm> Dugi: You can compare it with an arbitrary object like that yes: `git diff path1 path2 ...` 20141104 23:39:59< iceiceice> idk how much of that is used in [store_unit] etc. 20141104 23:40:04< shadowm> iceiceice: Yes, I am aware (and not by feeling). 20141104 23:41:00< shadowm> I am solely concerned with the foundations of WML command processing. The rest can only be tested the old-fashioned way for now, and that's exactly why I plan to throw this at players on 1.11.19. 20141104 23:42:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141104 23:43:23-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20141104 23:44:27< Dugi> shadowm: This is the result: http://pastebin.com/9bCF4AxZ 20141104 23:45:29< shadowm> Dugi: Explain lines 9 through 60 to me while I check the rest. 20141104 23:47:40< Dugi> shadowm: It processes the information the users sent. It counts the users who voted up some reviews (checking if there weren't too many of them from one IP address) and counts the hours users spent playing. 20141104 23:48:03< shadowm> Dugi: Also explain exactly when you experience the issue you've been talking about and what requests are involved. 20141104 23:48:36< shadowm> Dugi: Why is this information processed only during the timed config commits? 20141104 23:49:03< shadowm> Dugi: Also, why is it not in a separate method? 20141104 23:50:18< shadowm> Line 49 won't compile. 20141104 23:50:45< Dugi> shadowm: I thought that it would be better to calculate it once per a certain period of time (it is saved to disk periodically, so I made it compute just before every save) than to compute it every time somebody makes a change. 20141104 23:51:01< shadowm> I have the suspicion that you are testing a previous campaignd build, throwing requests it doesn't understand at it, and expecting a response back (which you'll never get). 20141104 23:51:49< shadowm> Dugi: Please explain the rationale behind that design decision re processing the review (?) information. 20141104 23:52:11< Dugi> shadowm: It definitely compiles, like 49 looks damage during copying somehow. 20141104 23:52:17< shadowm> And tell me what you expect to happen if campaignd gets a signal from the operating system. 20141104 23:53:05< Dugi> shadowm: If it gets a signal, the changes done after the last time it was saved to disk will be lost. Just like before. 20141104 23:53:20< shadowm> "Just like before" -- no such functionality existed before. 20141104 23:54:35< Dugi> shadowm: It was saving the data periodically to disk before I touched it. I supposed that the data will be lost of it exits with some changes done after that it was saved. 20141104 23:54:45< shadowm> That's only true for download counts. 20141104 23:55:28< Dugi> shadowm: I haven't noticed that it's also saved at some other points. 20141104 23:55:51< shadowm> Every time the same method called from the timed check is also called from request handlers. 20141104 23:56:46< Dugi> shadowm: Yes, it is indeed used also in other cases. I will fix that. In that case, it will definitely need a separate method. 20141104 23:57:07< shadowm> It will definitely need a separate method regardless because that's the coding style I established for readability. 20141104 23:57:33< shadowm> 20:48:01 Dugi: Also explain exactly when you experience the issue you've been talking about and what requests are involved. 20141104 23:58:10-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has quit [Ping timeout: 250 seconds] 20141104 23:59:48< Dugi> shadowm: Back to your older question, I think that it's better to reprocess the information to check for duplicate IPs in votes. I thought that showing the changes immediately would allow possible cheaters to easily experiment on it. --- Log closed Wed Nov 05 00:00:04 2014