--- Log opened Wed Nov 05 00:00:04 2014
--- Day changed Wed Nov 05 2014
20141105 00:00:04< shadowm> The reason I'm asking is because line 290 of the diff is a massive red flag.
20141105 00:00:23< shadowm> So is the missing thing in line 243.
20141105 00:02:04< Dugi> shadowm: So far, I noticed request terms and upload campaign, also delete campaign (which I did not change in any way). Request campaign list works. The action is done, just the client doesn't know about it. Connecting to the server with 1.10 works.
20141105 00:03:12< shadowm> Did you change the add-ons manager code as well?
20141105 00:03:35< Dugi> shadowm: I have done the change on 290 as a temporary solution to avoid the problem and test other things.
20141105 00:03:51< Dugi> shadowm: Add-on manager code was changed quite significantly too.
20141105 00:03:54< shadowm> No, line 290 is bad.
20141105 00:04:17< shadowm> All public-facing methods of the add-ons client are supposed to perform operations synchronously.
20141105 00:04:35-!- Anakonda [Anakonda@87-92-145-160.bb.dnainternet.fi] has quit [Read error: Connection reset by peer]
20141105 00:04:46< Dugi> shadowm: Do we have some problems with line count? I found nothing on line 243. It is the line count of the diff file or of something else?
20141105 00:04:57< shadowm> The diff's line 290.
20141105 00:05:29< shadowm> The above means that if you invoke asynchronous operations like send_request()/send_simple_request(), you are obligated to wait_for_transfer_done() before returning to your caller.
20141105 00:05:34< Dugi> You mean the //wait_for_transfer_done blablabla line?
20141105 00:05:44< shadowm> Yes.
20141105 00:06:50< Dugi> shadowm: I will try to run it without commenting that line asap.
20141105 00:07:21< Dugi> shadowm: Doesn't help.
20141105 00:08:03< shadowm> I don't care whether it fixes the issue or not, I'm stating that not calling that method from other addons_client methods is bad and needs to be fixed.
20141105 00:08:07< Dugi> shadowm: Yay, got what you meant with that line 243.
20141105 00:10:37< Dugi> shadowm: Now it hangs on the wait_for_transfer_done I added to line 243.
20141105 00:10:58< shadowm> That's exactly what it should do.
20141105 00:11:44< shadowm> Are you 100% sure you are connected to a campaignd instance built to understand the [submit_gameplay_times] request?
20141105 00:11:49< Dugi> shadowm: What did I do wrong that it is supposed to hang there indefinitely?
20141105 00:12:31< Dugi> shadowm: It understood it, but it didn't log that it received it at this time.
20141105 00:12:54< shadowm> How do you know it understood it then?
20141105 00:13:47-!- travis-ci [~travis-ci@ec2-54-160-187-189.compute-1.amazonaws.com] has joined #wesnoth-dev
20141105 00:13:47< travis-ci> wesnoth/wesnoth#4626 (master - 85e60b9 : Chris Beck): The build has errored.
20141105 00:13:47< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/39993876
20141105 00:13:47-!- travis-ci [~travis-ci@ec2-54-160-187-189.compute-1.amazonaws.com] has left #wesnoth-dev []
20141105 00:14:55< Dugi> shadowm: Because without that wait_for_transfer_done, the server processes the information. I will add a log message to check it out.
20141105 00:16:41< Dugi> shadowm: It does receive the information.
20141105 00:16:55< shadowm> Dugi: Right, here's the issue: you are calling wait_for_transfer_done() (which you must do), but you are waiting indefinitely for a response from the server that never comes.
20141105 00:17:42< shadowm> Your [submit_gameplay_times] and [rate_addon] request handlers do nothing to notify the client of a successful operation.
20141105 00:18:17< Dugi> shadowm: Yeah, it works!
20141105 00:18:43< Dugi> shadowm: Thanks for your help and useful information.
20141105 00:18:57< shadowm> The patch is still full of other style issues.
20141105 00:20:41< Dugi> shadowm: Can you please keep that for tomorrow, it's too late here and I need to wake up early, I have an experiment scheduled for the morning-
20141105 00:21:00< shadowm> Okay.
20141105 00:21:15< Dugi> shadowm: I am quite sure that there are more style issues in all other files I have changed.
20141105 00:22:08< Dugi> shadowm: If I waited till that is done, I would most likely fall asleep in the lab and my hair would catch fire from the vacuum fournace I am using.
20141105 00:22:12< Dugi> Good night.
20141105 00:22:19-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has quit [Quit: Page closed]
20141105 00:23:24< iceiceice> gfgtdf: there?
20141105 00:23:32< gfgtdf> iceiceice: y
20141105 00:23:56< iceiceice> i want to ask your opinion on something but first i want to know if you have one :)
20141105 00:24:01< iceiceice> did you ever read this page? http://wiki.wesnoth.org/MapGeneratorWML
20141105 00:24:01-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev
20141105 00:24:33< gfgtdf> iceiceice: yi i did, and tehta reming m on my totdo to rename map_generation in mp to sceanrio_generation
20141105 00:24:41-!- irker543 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20141105 00:24:42< gfgtdf> that reminds me*
20141105 00:24:52< iceiceice> hmm ok
20141105 00:25:00< iceiceice> the thing i don't like right now ist his line: "The exception is if you are making an initial MP scenario available in MP game creation, for this a [scenario] tag must appear inside of [generator], containing the [scenario] subtags you want to use. See “data/multiplayer/scenarios/Random_Scenario.cfg” for an example."
20141105 00:25:21< iceiceice> i want to fix it so that is not necessary
20141105 00:25:36< gfgtdf> iceiceice: http://gna.org/bugs/?func=detailitem&item_id=22484
20141105 00:26:27< iceiceice> is that your report?
20141105 00:26:40< gfgtdf> iceiceice: yes
20141105 00:26:45< iceiceice> ok
20141105 00:26:50< iceiceice> i think i see what the problem is here, i will try to fix
20141105 00:27:27< gfgtdf> iceiceice: actualy "mp" is only teh first scenario in a mp campaign, al later use teh sp code
20141105 00:27:33< gfgtdf> all later*
20141105 00:27:58< iceiceice> yeah the good code is in src/saved_game,
20141105 00:28:39< iceiceice> the bad code is here: https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/create_engine.cpp#L426
20141105 00:29:21< iceiceice> actually its a bit wierd that this class exists: https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/create_engine.hpp#L30
20141105 00:29:36< iceiceice> it is like competing with saved_game
20141105 00:29:54< gfgtdf> iceiceice: my plan woudl be 1) replace "map_generation" with "scenario_generation" in create_engine, 2) implement "map_generation" properly in create_engine
20141105 00:29:58< iceiceice> maybe instead of config data_; it should have saved_game data_;
20141105 00:30:25< iceiceice> gfgtdf: i mean basically you want to call "Expand random scenario" instead of the crap in this function that i pointed to
20141105 00:35:18< gfgtdf> iceiceice: also note than random scenario generation in mp create currently is incompatible with RiftWalkers "preprocesor define for multiplayer scenarios" feature becasue on teh one hand we want to generarete teh scenario before we realod the config but on teh other hand we want to overwrite teh sceanrio when we reloaded teh config see http://gna.org/bugs/?func=detailitem&item_id=22486
20141105 00:37:17< gfgtdf> iceiceice: which reminds me on this line: https://github.com/wesnoth/wesnoth/blob/master/src/generators/cave_map_generator.hpp#L89
20141105 00:37:30< gfgtdf> iceiceice: maybe we shoudl use boost mersenne twister there too ?
20141105 00:37:48< iceiceice> gfgtdf: yeah probably
20141105 00:37:56< iceiceice> gfgtdf: today i tried to make a lua random map generator code,
20141105 00:38:15< iceiceice> so you can do "map_generation=lua"
20141105 00:38:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 00:38:36< iceiceice> and then it expects "create_map" to be a lua script that returns a string
20141105 00:38:41< iceiceice> inside [generator]
20141105 00:39:08< iceiceice> that was done hours ago, everything since then is debugging the mp create / configure code D:
20141105 00:39:25< iceiceice> i should ahve read that mapgenerator wml page more carefully though
20141105 00:39:29-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20141105 00:39:37< iceiceice> i didnt realize about the exception, if you dont read that you just get assertion failures
20141105 00:45:25< gfgtdf> iceiceice: also saved_gane::expand_random_scenario doesnt support a user settings dalog
20141105 00:45:54< iceiceice> hmmm
20141105 00:46:01< iceiceice> so you dont think they need to share code?
20141105 00:46:23< iceiceice> i might do it the non-sharing way for now i guess
20141105 00:47:43-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20141105 00:47:45< gfgtdf> iceiceice: sharing code wouldnt be bad but i dont think it woudl be a huge code budlication if not
20141105 00:48:31< gfgtdf> dublication
20141105 00:49:18< gfgtdf> iceiceice: also teh fucntion (random_generate_scenario) that expand_random_scenario calls doenst support the ser dialog
20141105 00:50:07< iceiceice> isnt the user dialog part of the map_generator?
20141105 00:50:16< iceiceice> maybe i didnt read it right,
20141105 00:50:26< gfgtdf> what do you mean ?
20141105 00:50:42-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 245 seconds]
20141105 00:51:15< iceiceice> oh i see what you mean
20141105 00:51:26< iceiceice> yeah because it makes its own internal copy of generator
20141105 00:52:25-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20141105 00:59:26-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 256 seconds]
20141105 01:00:19< gfgtdf> iceiceice: yre you going to fix http://gna.org/bugs/?func=detailitem&item_id=22484 ?
20141105 01:00:39< iceiceice> yes i will make PR in a few minutes maybe, but i have to test it
20141105 01:01:07-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20141105 01:01:57< gfgtdf> iceiceice: dont forget to change teh mainline random scenario that use map_generatio= to scenrio_generation=
20141105 01:02:05< iceiceice> y
20141105 01:09:58< iceiceice> shadowm: i wonder if there are some publicly available unit tests for lua core
20141105 01:10:14< shadowm> Feel free to search for that.
20141105 01:10:56< iceiceice> http://lua-users.org/lists/lua-l/2006-03/msg00716.html
20141105 01:10:58< iceiceice> close but its 5.1
20141105 01:11:15< iceiceice> http://www.lua.org/tests/5.2/
20141105 01:12:40< shadowm> Ahahahahahah.
20141105 01:12:57< shadowm> I'm ******* blind today.
20141105 01:13:49< shadowm> I won't be the one to figure out how to integrate this crap, though.
20141105 01:14:56-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141105 01:15:16< iceiceice> yeah ... 
20141105 01:15:20< iceiceice> i can take a look at it later
20141105 01:16:01< iceiceice> i'm not sure if its needed,
20141105 01:16:09< shadowm> It is.
20141105 01:16:19< iceiceice> it appears the tests come in varieties "easy" and "so hard that you probably fail from lack of portability"
20141105 01:25:58< shadowm> So, what types do boost::math::constants::pi and friends accept?
20141105 01:27:13< shadowm> It's obvious they accept double, and that's what our Lua configuration uses as well, but I get the impression we could use long double if we were interested in using it to compute fancy and smart-sounding mathemtical stuff (which we aren't).
20141105 01:27:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141105 01:28:51< shadowm> In view of this, I guess I'll use lua_Number as the type for reapplying f5e673e6443220c57e40cea31d430870b4f73925 on Lua 5.2.3.
20141105 01:37:00< iceiceice> shadowm: i dont think you need to reapply that
20141105 01:37:12< iceiceice> or at least i think gfgtdf and i were doubtful of it in the first place
20141105 01:37:27< iceiceice> whats the point to start mixing boost stuff into the lua implementation
20141105 01:38:04< iceiceice> also some other patches might not need to be reapplied, i added an assertion to figure out if lua was swallowing unnamed exceptions but i'm not satisfied that it's typically not
20141105 01:38:12< iceiceice> *i'm now satisfied
20141105 01:38:49< shadowm> I did not de-apply or re-apply any other patches but those two. The rest just got merged automatically.
20141105 01:39:05< shadowm> And to answer my own question, the header in question supports even __float128.
20141105 02:12:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141105 02:13:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 02:15:46< shadowm> #yolo
20141105 02:15:48-!- irker157 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20141105 02:15:48< irker157> wesnoth: Ignacio R. Morelle wesnoth:master 471ef92f115e / src/lua/ (44 files): Upgrade bundled Lua library to version 5.2.3 (bug #22893) http://git.io/mUFGIQ
20141105 02:15:51< irker157> wesnoth: Ignacio R. Morelle wesnoth:master 69777695fe28 / changelog: Update changelog http://git.io/o9pchA
20141105 02:17:21< iceiceice> :D
20141105 02:23:32< mattsc> shadowm: compiles just fine for me and the MAIs appear to work also.  (Not sure if there was ever any question about that, but just in case.)
20141105 02:28:33-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has quit [Remote host closed the connection]
20141105 02:30:03-!- gfgtdf [~chatzilla@d148011.adsl.hansenet.de] has quit [Read error: Connection reset by peer]
20141105 02:30:19< mattsc> And thus the PL-MAI wins another round of HttT:TEB …
20141105 02:31:22< vultraz> I've been playing too much dota when I think that means Phantom Lancer and not ... what does it mean? 
20141105 02:32:11< irker157> wesnoth: Ignacio R. Morelle wesnoth:1.12 8a3f49c05006 / src/lua/ (44 files): Upgrade bundled Lua library to version 5.2.3 (bug #22893) http://git.io/M0NU4Q
20141105 02:32:14< irker157> wesnoth: Ignacio R. Morelle wesnoth:1.12 9aec23d05310 / changelog: Update changelog http://git.io/x0T38w
20141105 02:33:02< shadowm> mattsc: I only tested build on master, and let travis run the WML unit tests. I've not tested anything at all for the 1.12 backport.
20141105 02:33:35< shadowm> If an ubiquitous code paths breaks, though, I'll probably find out soon during my AtS playthough.
20141105 02:33:39< shadowm> *path
20141105 02:34:44< mattsc> shadowm: I’ll run a couple of the MAI test scenarios in 1.12 too.  I’ll let you know if I encounter any problems.
20141105 02:36:43-!- Kexoth [~kex@78.157.29.160] has joined #wesnoth-dev
20141105 02:38:56-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 265 seconds]
20141105 02:39:52< mattsc> Woohoo; one blocker off the list!
20141105 02:40:01-!- roland_ [~roland@2a01:1e8:e100:8618::24] has quit [Remote host closed the connection]
20141105 02:44:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20141105 02:44:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 02:45:40< iceiceice> fendrin: i started getting a shitton of console spam from test executable, something about editor terrain groups,
20141105 02:45:41< iceiceice> https://gist.github.com/cbeck88/338d5c5f95a48ff64bd2
20141105 02:45:46< iceiceice> do you have any idea about this?
20141105 02:45:52< iceiceice> or a hint where to look?
20141105 02:46:16-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev
20141105 02:48:44< mattsc> shadowm: at least as far as the MAIs are concerned, Lua seems to work without problems after the upgrade on both 1.12 and master
20141105 02:50:19< ancestral> iceiceice: So where’s the homebrew script at now?
20141105 02:50:29< iceiceice> ancestral: it got merged upstream :D
20141105 02:50:35< ancestral> Awesome!
20141105 02:50:39< iceiceice> at the end of that long night basically
20141105 02:50:52< iceiceice> i forgot to update gist, i shoudl do that
20141105 02:51:04< iceiceice> leaving in the wip app bundle stuff ofc
20141105 02:51:43< ancestral> Yeah I figure I could probably take a stab at it and put together the parts
20141105 02:52:31< ancestral> I have a 4 day weekend with nothing planned! :-D
20141105 02:52:45< ancestral> So there’ll be some time to play around
20141105 02:55:39< iceiceice> cool
20141105 02:55:54< mattsc> vultraz: I suggest turning this into an icon: http://icons.iconarchive.com/icons/jonathan-rey/star-wars-vehicles/256/Millenium-Falcon-02-icon.png
20141105 02:56:13 * vultraz facepalms
20141105 02:56:31-!- travis-ci [~travis-ci@ec2-54-167-224-232.compute-1.amazonaws.com] has joined #wesnoth-dev
20141105 02:56:31< travis-ci> wesnoth/wesnoth#4628 (master - 6977769 : Ignacio R. Morelle): The build passed.
20141105 02:56:31< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/40019642
20141105 02:56:31-!- travis-ci [~travis-ci@ec2-54-167-224-232.compute-1.amazonaws.com] has left #wesnoth-dev []
20141105 02:56:49< ancestral> mattsc, vultraz: Make a feature request :-P
20141105 02:57:19< shadowm> vultraz: A missing race icon is no reason to block a release.
20141105 02:57:33< shadowm> I don't care if it's the falcons or humans or elves.
20141105 02:57:34< vultraz> I didn't say it was a blocker
20141105 02:57:50< vultraz> I'm just saying we should put something there
20141105 02:58:12< shadowm> Then bring it up in Art Development or Art Contributions. It won't reach any artists on the mailing list.
20141105 02:58:26< ancestral> vultraz: Which race?
20141105 02:58:32< vultraz> I'm still waiting for LB
20141105 02:59:23< vultraz> ancestral: falcons
20141105 03:00:11< ancestral> Like http://wesnoth.io/bestiary/falcon ?
20141105 03:01:07< ancestral> (God I love how I finally got that table sorted)
20141105 03:02:10< vultraz> Your CSS is bad and you should feel bad
20141105 03:02:14< ancestral> mattsc: Now what you said makes sense
20141105 03:02:25< vultraz> No border1
20141105 03:02:27< vultraz> !
20141105 03:02:37< bumbadadabum> http://niceme.me
20141105 03:02:38< ancestral> Say again?
20141105 03:02:57< vultraz> The main window should have some kind of border
20141105 03:02:58< mattsc> ancestral: it does?  Now there’s a first …  :P
20141105 03:03:14< ancestral> vultraz: Should it?
20141105 03:03:17< vultraz> or better yet, remove the background al ltogether and just have a color
20141105 03:04:10-!- Kexoth [~kex@78.157.29.160] has quit [Remote host closed the connection]
20141105 03:04:12< ancestral> I could do that…
20141105 03:04:28-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141105 03:04:30< ancestral> I was sorta going for the wesnoth.org border, but higher res
20141105 03:04:40< vultraz> ancestral: do like westin and use sexy-on-anything-but-chrome gradients 
20141105 03:04:45< ancestral> Sorry not “border”; header background
20141105 03:05:00-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection]
20141105 03:05:06< shadowm> vultraz: You sound like some kind of web design fundamentalist.
20141105 03:05:34< ancestral> I kinda like the paper background. (Even if it’s skeumorphic and that’s not popular these days.)
20141105 03:05:46< bumbadadabum> ^
20141105 03:06:28< ancestral> vultraz: Westin: https://www.starwoodhotels.com/westin/index.html
20141105 03:06:40 * vultraz facepalms
20141105 03:08:21< vultraz> NOT THAT WESTIN
20141105 03:10:59< iceiceice> i think C++11 is really slow to compile maybe
20141105 03:11:14< shadowm> Really? I haven't seen that.
20141105 03:11:24< iceiceice> based on the, 6 hours of travis tests....
20141105 03:11:32< iceiceice> a very scientific study clearly
20141105 03:11:48< shadowm> travis is slow regardless of anything.
20141105 03:12:21< iceiceice> it seems increasingly unstable
20141105 03:12:46< iceiceice> i guess the test executable hasn't been mysteriously segfaulting recently, so maybe its not as bad as it once was
20141105 03:12:59< iceiceice> but i noticed a lot fo builds stalled because e.g.
20141105 03:13:08< iceiceice> it loses contact with github for 20 minutes at start of build,
20141105 03:13:16< iceiceice> then inevitably times out 30 minutes after that...
20141105 03:13:20-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-113-185.zoominternet.net] has joined #wesnoth-dev
20141105 03:14:24-!- TC01 [~quassel@magellan.acm.jhu.edu] has quit [Ping timeout: 245 seconds]
20141105 03:17:04-!- Ivanovic_ [~ivanovic@frnk-5f74c2b9.pool.mediaWays.net] has joined #wesnoth-dev
20141105 03:20:22-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 255 seconds]
20141105 03:20:58-!- Ivanovic_ is now known as Ivanovic
20141105 03:24:39-!- TC01 [~quassel@magellan.acm.jhu.edu] has joined #wesnoth-dev
20141105 03:46:03-!- Sulfur [~Miranda@p5B3277B3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141105 03:49:23-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141105 03:54:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141105 04:00:45-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev
20141105 04:02:57< irker157> wesnoth: Chris Beck wesnoth:master d137c378df5d / src/help.cpp: capitalize xBRZ instances in src/help.cpp http://git.io/aHgjZw
20141105 04:08:00-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20141105 04:13:10-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Remote host closed the connection]
20141105 04:13:51-!- Sulfur [~Miranda@p5B3277B3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141105 04:16:35-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20141105 04:21:24< ancestral> Wow, holy warnings and errors, blood bat! http://units.wesnoth.org/trunk/overview.html
20141105 04:24:07< ancestral> B’oh: http://units.wesnoth.org/trunk/Svens_Adventure/error.html
20141105 04:25:16< ancestral> shadowm: http://units.wesnoth.org/trunk/After_the_Storm/error.html
20141105 04:25:31< shadowm> I am aware, I don't care.
20141105 04:26:24< shadowm> Oh wait, only one?
20141105 04:26:48< ancestral> Assuming the parser is perfect
20141105 04:27:03< shadowm> Last time I checked, it was failing to read the campaign.
20141105 04:27:23< shadowm> I should probably "fix" that later.
20141105 04:27:53< ancestral> Yeah, I see: http://units.wesnoth.org/trunk/After_the_Storm/en_US/Quenoth%20Horseman.html
20141105 04:28:08< shadowm> I still don't care.
20141105 04:28:12< ancestral> “This is an awful description, please FIXME.”
20141105 04:28:16< shadowm> The unit isn't even found in normal gameplay.
20141105 04:29:39< shadowm> elias: Could you remind me how to get an add-on unlisted from units.wesnoth.org?
20141105 04:30:17< shadowm> Also wow, some of these sprites are outdated.
20141105 04:30:34< ancestral> One simply does not… k, I’ll stop
20141105 04:30:38< shadowm> Far older than the page's timestamp.
20141105 04:30:48< ancestral> Actually, it’s kind of interesting
20141105 04:30:54< shadowm> Yeah, you'd better stop throwing inverted text at me. :p
20141105 04:31:58< ancestral> The internal errors that show up… but also, add-ons like “Music Book 1” appear in this list
20141105 04:32:30< ancestral> (I realize it’s probably just going through every add-on, regardless if it has custom units or not)
20141105 04:34:09< ancestral> e.g. http://units.wesnoth.org/trunk/A_Few_Logs/en_US/A_Few_Logs.html
20141105 04:51:32-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds]
20141105 04:53:24-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141105 04:53:52-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 240 seconds]
20141105 04:56:18-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20141105 04:56:39-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev
20141105 04:58:34-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 256 seconds]
20141105 05:24:15-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-113-185.zoominternet.net] has quit []
20141105 05:43:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 05:44:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20141105 05:52:02-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141105 05:56:17-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141105 05:59:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141105 06:00:54-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20141105 06:01:17-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141105 06:19:02-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20141105 06:19:46-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141105 06:42:22-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141105 06:46:55-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 255 seconds]
20141105 06:49:04-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141105 06:56:30-!- Ivanovic [~ivanovic@frnk-5f74c2b9.pool.mediaWays.net] has quit [Changing host]
20141105 06:56:30-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20141105 07:05:25-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20141105 07:05:41-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141105 07:10:44-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 260 seconds]
20141105 07:15:57-!- irker157 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20141105 07:44:47-!- irker836 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20141105 07:44:47< irker836> wesnoth: Chris Beck wesnoth:master a97d344b4040 / src/CMakeLists.txt: move SDL_SavePNG to the SDL compilation group, on cmake also http://git.io/t0TX_Q
20141105 08:02:22-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20141105 08:10:10-!- Anakonda [Anakonda@87-92-142-108.bb.dnainternet.fi] has joined #wesnoth-dev
20141105 09:25:19-!- DHost [~Pcy@vps.ponchy.fr] has quit [Ping timeout: 255 seconds]
20141105 09:49:38-!- DHost [~Pcy@vps.ponchy.fr] has joined #wesnoth-dev
20141105 09:58:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141105 10:19:41-!- duncan_shriek [~roland@2a01:1e8:e100:8618::24] has joined #wesnoth-dev
20141105 10:34:20-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141105 10:54:30-!- irker836 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20141105 11:02:31-!- kex [~kex@77.29.85.100] has joined #wesnoth-dev
20141105 11:07:12-!- kex [~kex@77.29.85.100] has quit [Ping timeout: 258 seconds]
20141105 11:08:46-!- cib0 [~cib@132.231.178.96] has joined #wesnoth-dev
20141105 11:11:45-!- kex [~kex@77.29.85.100] has joined #wesnoth-dev
20141105 11:23:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 11:27:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 11:28:31< elias> shadowm: there is no way currently
20141105 11:28:46< elias> it gets the list from the addons server
20141105 11:29:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 11:32:03-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20141105 11:39:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 11:41:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 11:45:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 11:48:53-!- kex [~kex@77.29.85.100] has quit [Remote host closed the connection]
20141105 11:49:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 11:52:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 11:52:43-!- kex [~kex@77.29.85.100] has joined #wesnoth-dev
20141105 11:53:20-!- kex [~kex@77.29.85.100] has quit [Remote host closed the connection]
20141105 11:53:36-!- kex [~kex@77.29.85.100] has joined #wesnoth-dev
20141105 11:54:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 12:00:42-!- cib0 [~cib@132.231.178.96] has quit [Ping timeout: 245 seconds]
20141105 12:14:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 12:17:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 12:23:20-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20141105 12:36:23-!- cib0 [~cib@132.231.178.206] has joined #wesnoth-dev
20141105 12:37:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 13:11:43-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20141105 13:27:34-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Ping timeout: 265 seconds]
20141105 13:50:48-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20141105 13:51:32-!- cib0 [~cib@132.231.178.206] has quit [Ping timeout: 245 seconds]
20141105 13:57:09-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20141105 13:57:35-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20141105 14:00:39-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev
20141105 14:02:12-!- travis-ci [~travis-ci@ec2-54-82-159-30.compute-1.amazonaws.com] has joined #wesnoth-dev
20141105 14:02:12< travis-ci> wesnoth/wesnoth#4323 (master - db02870 : Bär Halberkamp): The build has errored.
20141105 14:02:12< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/38630582
20141105 14:02:12-!- travis-ci [~travis-ci@ec2-54-82-159-30.compute-1.amazonaws.com] has left #wesnoth-dev []
20141105 14:03:22-!- travis-ci [~travis-ci@ec2-54-82-159-30.compute-1.amazonaws.com] has joined #wesnoth-dev
20141105 14:03:22< travis-ci> wesnoth/wesnoth#4324 (master - 4c29154 : Bär Halberkamp): The build has errored.
20141105 14:03:22< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/38631069
20141105 14:03:22-!- travis-ci [~travis-ci@ec2-54-82-159-30.compute-1.amazonaws.com] has left #wesnoth-dev []
20141105 14:09:26-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141105 14:34:37< fendrin> shadowm: okay, I discoverd that load dialog thing when using "wesnoth -e" from the commandline.
20141105 14:34:46< fendrin> Why is Wesnoth doing that at all?
20141105 14:35:35< fendrin> I have started it with -e for ages and never got the file dialog automatically.
20141105 14:40:17-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Remote host closed the connection]
20141105 14:52:19-!- gfgtdf [~chatzilla@f054166006.adsl.alicedsl.de] has joined #wesnoth-dev
20141105 15:04:24-!- gfgtdf [~chatzilla@f054166006.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 33.0.2/20141027150301]]
20141105 15:10:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20141105 15:20:12-!- matthiaskrgr [matthiaskr@unaffiliated/matthiaskrgr] has quit [Ping timeout: 256 seconds]
20141105 15:22:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 15:23:26-!- matthiaskrgr [matthiaskr@I.Eat.Babies.PanicBNC.nl] has joined #wesnoth-dev
20141105 15:23:50-!- matthiaskrgr is now known as Guest42910
20141105 15:24:27-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 256 seconds]
20141105 15:24:27-!- Guest42910 [matthiaskr@I.Eat.Babies.PanicBNC.nl] has quit [Changing host]
20141105 15:24:27-!- Guest42910 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20141105 15:24:39-!- Guest42910 is now known as matthiaskrgr_
20141105 15:24:44-!- heirecka_ [~heirecka@j61898.servers.jiffybox.net] has joined #wesnoth-dev
20141105 15:24:55-!- molgrum [~molgrum@212.85.89.43] has quit [Ping timeout: 264 seconds]
20141105 15:24:59-!- heirecka_ is now known as heirecka
20141105 15:25:24-!- heirecka [~heirecka@j61898.servers.jiffybox.net] has quit [Changing host]
20141105 15:25:24-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20141105 15:26:59-!- molgrum [~molgrum@212.85.89.43] has joined #wesnoth-dev
20141105 15:31:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141105 15:33:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has left #wesnoth-dev []
20141105 15:33:47< Ravana_> Is there reason why http://forums.wesnoth.org/ seems to switch between 2 different favicons, one like house and one like wesnoth.exe?
20141105 15:34:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141105 15:34:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141105 15:38:56< Crendgrim> maybe a caching issue?
20141105 15:40:45-!- cib0 [~cib@132.231.178.82] has joined #wesnoth-dev
20141105 15:43:11-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20141105 15:46:22-!- cib0 [~cib@132.231.178.82] has quit [Ping timeout: 240 seconds]
20141105 15:48:50< ancestral> Can’t say I’m a fan of the new icon
20141105 15:48:50-!- mjs-de [~mjs-de@f053177106.adsl.alicedsl.de] has joined #wesnoth-dev
20141105 15:49:38< ancestral> The top of the shield looks cropped. the shading in the shield looks odd, and there’s not a 32x32 version which is what many browsers these days are displaying
20141105 15:50:22< ancestral> Also, it’s just plain dark and not easy to distinguish. Icons needs to be brighter, vibrant and recognizable
20141105 15:51:37< Crendgrim> I agree.
20141105 15:55:14< ancestral> But, I do think the shield icon is more repsentative of Wesnoth than the village icon
20141105 15:55:26< fendrin> ice³: About your question regarding https://gist.github.com/cbeck88/338d5c5f95a48ff64bd2
20141105 15:57:17< fendrin> The engine discovered two *identical* terrain definitions which also want their terrain in the same editor group.
20141105 15:57:42< fendrin> It would deny terrains with the same string but different semantic with a different error message.
20141105 15:58:32< fendrin> Terrain with identical string and semantic which is to be sorted in a disjunct set of terrain groups is merged with a log output only.
20141105 15:58:56< fendrin> I am not sure why that discrimination is made.
20141105 15:59:20< fendrin> Maybe both cases should just be logged.
20141105 16:01:55< fendrin> I am talking about error vs log output, just to make sure.
20141105 16:10:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 16:13:49-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20141105 16:16:58< shadowm> fendrin: If you don't know then it's unlikely I would...
20141105 16:18:18< shadowm> Also I don't think iceiceice searches the logs for mentions of "ice³" in spite of its obviousness, though he probably reads them in their entirety anyway.
20141105 16:21:23-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141105 16:30:14-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has joined #wesnoth-dev
20141105 16:30:22< Dugi> Hello.
20141105 16:30:45-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev
20141105 16:34:32-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20141105 17:08:27-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 265 seconds]
20141105 17:11:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141105 17:15:55-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141105 17:19:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 17:25:07< fendrin> hi Dugi
20141105 17:27:19< fendrin> shadowm: I don't like the new behavior. Most times when I start "wesnoth -e" the dialog just gets in my way. But that might be different for a user. I am mostly a tester. So I don't know. 
20141105 17:29:55< fendrin> thunderstruck: ping
20141105 17:31:24< shadowm> fendrin: I don't really know what to think of it.
20141105 17:32:10< fendrin> shadowm: I guess it is not intentional. I remember something similar in the past. Thus it is a regression and a side effect of some other change.
20141105 17:32:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141105 17:33:16< shadowm> I don't know the editor like you so I can't think of any reason it'd suddenly open the filechooser dialog only when started from the command line unless it was intended by someone to do that.
20141105 17:55:25-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20141105 18:05:31-!- {V} [~V@72-69-ftth.on.nl] has quit [Ping timeout: 255 seconds]
20141105 18:05:45-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev
20141105 18:32:40-!- gfgtdf [~chatzilla@e176185161.adsl.alicedsl.de] has joined #wesnoth-dev
20141105 18:36:04< fendrin>  hi gfgtdf
20141105 18:36:27< gfgtdf> fendrin: hi
20141105 18:38:04< fendrin> gfgtdf: Do you know anything about the editor load dialog? I remember talking to someone who modified it somehow.
20141105 18:38:20< gfgtdf> fendrin: no i don't
20141105 18:38:28< fendrin> At some time. Somewhere on the internet.
20141105 18:52:14-!- kex [~kex@77.29.85.100] has quit [Remote host closed the connection]
20141105 18:52:48-!- kex [~kex@77.29.85.100] has joined #wesnoth-dev
20141105 18:54:03< Dugi> shadowm: Hey, do you have time to check the rest of the stuff I've written. Since yesterday, I have fixed one bug and split that one thing into two separate methods.
20141105 18:56:54-!- kex [~kex@77.29.85.100] has quit [Ping timeout: 245 seconds]
20141105 19:32:22< Dugi> Quite silent here. Am I even connected?
20141105 19:32:53< Ravana_> connected^
20141105 19:35:59< Dugi> fendrin: You there?
20141105 19:36:10< fendrin> hi Dugi
20141105 19:37:52< Dugi> fendrin: Hi. Last time we talked about the idea of the add.on reviews' system, and I have it completed since then. It's fully operational, just needs a few aesthetical corrections. Do you want to look at that? Some final advice might be handy.
20141105 19:38:47< fendrin> Dugi: Oh yes.
20141105 19:38:54< fendrin> Dugi: Sounds exiting. 
20141105 19:39:04< fendrin> exciting
20141105 19:39:17< Dugi> fendrin: How do I start a chat with you only? I don't want to spam this chat too much.
20141105 19:39:37< fendrin> Dugi: /query <username>
20141105 19:59:57-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141105 20:00:27< iceiceice> gfgtdf: there's more problems than i realized in the mp create,
20141105 20:02:35-!- matthiaskrgr_ is now known as matthiaskrgr
20141105 20:03:40-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20141105 20:04:44< iceiceice> it seems very unstable, if one of the map generators makes a scenario that's slightly wrong it can crash everything
20141105 20:04:54< iceiceice> or the gui gets stuck on an entry even and you have to close it
20141105 20:06:25-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20141105 20:06:36< thunderstruck> fendrin: Hi
20141105 20:06:47< thunderstruck> Wanted to ask something?
20141105 20:06:52< fendrin> hi thunderstruck
20141105 20:07:29< fendrin> thunderstruck: Shall I assign https://gna.org/bugs/?22903 to you?
20141105 20:08:22< thunderstruck> fendrin: Yes.
20141105 20:08:36< fendrin> thunderstruck: Also, do you know what they are talking about here: http://forums.wesnoth.org/viewtopic.php?f=6&t=41098
20141105 20:09:26< fendrin> thunderstruck: The oos bug is not reproduce-able that easily. Maybe you have an idea what they are talking about. 
20141105 20:10:00< thunderstruck> fendrin: I'll take a look, but not now.
20141105 20:10:15< fendrin> thunderstruck: Thank you very much :-)
20141105 20:10:17< thunderstruck> fendrin: Thanks for pointing this out.
20141105 20:11:45< thunderstruck> fendrin: No need to thank me. I didn't do anything yet.
20141105 20:14:46< shadowm> Dugi: Right, so do you have an updated diff or pull request for me to look at?
20141105 20:16:40< fendrin> shadowm: https://github.com/wesnoth/wesnoth/pull/134
20141105 20:16:53< shadowm> I said updated.
20141105 20:17:46< fendrin> shadowm: I am reading the diff at the moment.
20141105 20:18:04< shadowm> That pull request is outdated, fendrin.
20141105 20:18:56< fendrin> shadowm: Dugi gave me the link just a few minutes ago. He thinks it is up to date.
20141105 20:20:05< shadowm> Well, why didn't he give me the link first?
20141105 20:21:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141105 20:22:26-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20141105 20:27:56< shadowm> Dugi: Poke me when you are back, please.
20141105 20:29:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 20:29:10< shadowm> Or better yet, start with explaining why you are using C anonymous struct typedefs in src/addon/info.hpp.
20141105 20:29:50< shadowm> Also, where's the design of this PR explained?
20141105 20:36:37< shadowm> The first commit in the PR (8a6fcac0c907a5525340bbe8d8a159b33f5e57c2) looks completely disjointed from a larger commit, presumably d50873c0dc0accfe81f1ace80cee3cb9bfdb1fd4, and also missing analog changes to SConscript.
20141105 20:37:00< shadowm> i.e. dbded398bb37fa3fc7f0ca3ff13d00cfa1de0d03, sixth commit.
20141105 20:37:26-!- lipkab [~lipkab@host-91-147-211-128.biatv.hu] has joined #wesnoth-dev
20141105 20:37:32< shadowm> https://github.com/Dugy/wesnoth/commit/d50873c0dc0accfe81f1ace80cee3cb9bfdb1fd4#diff-f135a3b6d917b96abb7c0edd8f752d00R2 <- I'm not believing that YogiHH wrote this code.
20141105 20:37:46< shadowm> Change the copyright statement accordingly.
20141105 20:37:57< shadowm> Same goes for every new file.
20141105 20:38:16< iceiceice> here's a nooby question,
20141105 20:38:31< iceiceice> if i write lines `x scons && ./test` in my git rebase interactive,
20141105 20:38:33< iceiceice> sorry
20141105 20:38:41< iceiceice> i was writing `x scons; ./test`
20141105 20:38:48< iceiceice> are these substantively different?
20141105 20:39:16< shadowm> Yes, very much so. In `a && b`, b won't run if a returns with a non-zero status.
20141105 20:39:17< iceiceice> i am suddenly concerned that using the latter instead of former was causing test to run asynchronously with the build
20141105 20:39:25< iceiceice> oh ok, that's all
20141105 20:39:33< shadowm> `a; b` runs b after a regardless of a's exit status.
20141105 20:40:01< shadowm> `a &; b` runs b after starting a in the background.
20141105 20:40:13< iceiceice> i still don't understand why i get crazy console spam
20141105 20:40:20< iceiceice> i guess it must be that i have bad stuff in my add-on dir
20141105 20:41:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 20:42:43< shadowm> Dugi: And this doesn't compile.
20141105 20:42:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20141105 20:43:43< shadowm> ALWAYS try to compile before committing something, never commit code that doesn't compile unless you have a very good reason (hint: that's almost never the case).
20141105 20:44:41< shadowm> These aren't even warning-as-error cases, it's just plain wrong code: http://pastebin.com/NydJNiCm
20141105 20:45:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 20:45:10< shadowm> And once again I need to know exactly what this PR is supposed to accomplish before reviewing it.
20141105 20:47:10-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20141105 20:47:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 20:48:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 20:48:52< Dugi> shadowm: Back. Sorry, I was watching another chat and forgot about this one.
20141105 20:49:36-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141105 20:50:22< Dugi> shadowm: It compiles on my side, maybe I committed it wrongly (still unfamiliar with git),
20141105 20:50:44< Dugi> shadowm: Indeed, campaign server doesn't compile.
20141105 20:51:11< shadowm> First you said it compiles, 22 seconds later you say it doesn't.
20141105 20:51:38< shadowm> What am I supposed to make of that?
20141105 20:51:39< iceiceice> maybe its a problem of only building default targets not including campaign server?
20141105 20:51:42< Dugi> shadowm: I checked the client first and forgot that campaign wasn't a part of it.
20141105 20:51:51< Dugi> *campaignd
20141105 20:52:07< shadowm> `scons default_targets=campaignd,test,wesnoth,wesnothd`
20141105 20:52:18< shadowm> Every coder here should do that if using scons.
20141105 20:53:39< Dugi> shadowm: I will do that next time.
20141105 20:53:52< shadowm> No, do it now.
20141105 20:54:41< shadowm> Since every scons recipe setting is persistent, it'll remember this and next time you run `scons` without any arguments it'll build all those four targets without having to explicitly tell it to do so.
20141105 20:56:07< shadowm> Also note that I did raise other concerns above.
20141105 20:58:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141105 20:58:19-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20141105 20:58:26< Dugi> Dang, now i will compile tests. How long does that take?
20141105 20:58:37< shadowm> 1 minute for me.
20141105 20:58:52< Dugi> shadowm: Yeah, it's done.
20141105 20:58:52< shadowm> Or even less.
20141105 21:00:24< Dugi> shadowm: What were the errors past line 13? I haven't seen those,
20141105 21:01:02< shadowm> Those typically appear when you do something wrong in the arguments to the BOOST_FOREACH macro.
20141105 21:01:20< Dugi> Because when I fixed the errors above it, it compiles without warnings.
20141105 21:02:07< Dugi> Ah, yes, I have fixed also something that could have caused problems of that kind, but I haven't seen those errors.
20141105 21:02:31< Dugi> shadowm: Can I edit the last commit somehow?
20141105 21:02:56< shadowm> You'll have to edit every single commit of this branch at some point later to make it presentable, so.
20141105 21:03:34< shadowm> Yes, it's possible. There are several ways. I can't really help you with that right now though.
20141105 21:03:51< Dugi> Ehm, that will be hard to do... How do I edit this last commit to fix this issue?
20141105 21:04:45< shadowm> Ah, I see, you threw a bunch of unrelated changes into your last commit, that's why you want to do the same again.
20141105 21:05:25< Dugi> It was meant as a sum of final corrections.
20141105 21:05:27< shadowm> Not good.
20141105 21:06:07< shadowm> It's not helping me make sense of this massive PR at all, combined with the overall lack of meta-documentation.
20141105 21:07:01< iceiceice> Dugi: the usual way to fix stuff is,
20141105 21:07:07< iceiceice> if you have to correct a commit, first make a mini commit
20141105 21:07:10< iceiceice> that fies the problem
20141105 21:07:17< iceiceice> then compile and test
20141105 21:07:18< shadowm> There are even conflict markers present in a diff for a previous commit.
20141105 21:07:32< Dugi> Wouldn't it be better as one large commit?
20141105 21:07:34< iceiceice> then use git rebase to move the minicommit right after the commit it was meant to fix
20141105 21:07:38< iceiceice> then test again
20141105 21:07:38< shadowm> I'm sorry, but I can't deal with this right now. Please try to get it cleaned up first.
20141105 21:07:48< iceiceice> then squash it witht he commit that made the problem
20141105 21:08:02< shadowm> And once again I must insist, I need to know exactly what this is all supposed to accomplish, how it works, etc.
20141105 21:08:04< Dugi> I know. It's also because I forgot to check if campaignd compiles too.
20141105 21:08:32< iceiceice> Dugi: it also means that your original tests weren't sound, because you weren't compiling campaignd
20141105 21:09:52< Dugi> I have tested most versions, but I forgot to check it in that one case.
20141105 21:11:31< Dugi> Made that mini commit, how do I squash it with the previous now? git squash f23bea7 a16ab5d
20141105 21:11:45< iceiceice> Dugi: so when you use git rebase -i, 
20141105 21:11:51< iceiceice> like,
20141105 21:12:03< iceiceice> git rebase -i master, called while `git status` says you are at the tip of your branch,
20141105 21:12:15< iceiceice> it will make a text editor screen with a giant list of every commit
20141105 21:12:20< iceiceice> with commands "pick ..." in order
20141105 21:12:28< iceiceice> if you rearrange the list they will be applied in different order
20141105 21:12:32< iceiceice> there's also instructions,
20141105 21:12:37< Dugi> Saw that. What do I have to edit there?
20141105 21:12:45< iceiceice> change pick to "squash" or just "s" to squash the messages together
20141105 21:12:59< iceiceice> change pick to "edit" and it will stop at tha tpoint to edit, but it can be confusing,
20141105 21:13:01< Dugi> I mean, how to I merge two of them? I don't need to reorder them, that would ruin it most likely.
20141105 21:13:06< iceiceice> i recommend the mini commit method
20141105 21:13:16< iceiceice> Dugi: well, i would reorder just the mini commit
20141105 21:13:22< iceiceice> so its just after the one youw ant to merge it with
20141105 21:13:31< iceiceice> and change "pick" to "squash" or "fixup" for that guy
20141105 21:13:46< iceiceice> (fixup means, you drop the commit message of the second commit. squash concatenates them.)
20141105 21:13:50< Dugi> It is the last one at the moment. I need to commit a bug that was added in the last commit.
20141105 21:14:29< Dugi> Strange, in the rebase list, I can't see the individual commits.
20141105 21:14:44< Dugi> Just some 'noop'
20141105 21:15:04< iceiceice> so the way that git rebase selects a range of commits is based on
20141105 21:15:08< iceiceice> (1) where you currently are
20141105 21:15:13< iceiceice> (2) what argument you give it
20141105 21:15:50< iceiceice> always run git status and make sure you are on your branch and your head is clean
20141105 21:15:54< iceiceice> before trying to rebase
20141105 21:16:17< iceiceice> and if it goes bad use "git rebase --abort"
20141105 21:16:43< Dugi> Git status looks okay.
20141105 21:17:24< Dugi> But git rebase -i shows just noop. What could that be?
20141105 21:17:46< iceiceice> paste your console i guess
20141105 21:18:50< Dugi> http://pastebin.com/jVXZqXtH
20141105 21:19:21< Dugi> I might have used a wrong argument somewhere,
20141105 21:21:41< Dugi> I wrote git rebase -i dugi/addon_reviews and it shows only that noop.
20141105 21:24:01< iceiceice> wierd
20141105 21:24:11< iceiceice> show me what your git status says?
20141105 21:24:26< iceiceice> oh hmm
20141105 21:24:33< iceiceice> ok
20141105 21:24:39< iceiceice> it shouldnt be -i dugi/addon_reviews
20141105 21:24:50< Dugi> http://pastebin.com/YZmLruTR
20141105 21:24:51< iceiceice> you should be *on* branch dugi/addon_reviews
20141105 21:25:06< Dugi> The untracked files should not be tracked, they are just some sort of notes.
20141105 21:25:07< iceiceice> and the target should be, whatever branch you are rebasing onto, most likely master
20141105 21:25:48< Dugi> So what command should I use to correct it? Sorry for my unfamiliarity with git.
20141105 21:25:56< iceiceice> yeah, so, dugi, when you use git rebase, the branch you point it to is the *lower bound* basically
20141105 21:26:08< iceiceice> you're telling it you want to rebase some group of commits
20141105 21:26:17< iceiceice> but if you are on branch X and you say rebase -i X
20141105 21:26:26< iceiceice> then there's no commits in between
20141105 21:26:29< iceiceice> so you get noop
20141105 21:26:47< iceiceice> dugi/addon_reviews is based off of master branch
20141105 21:26:53< Dugi> So I should rebase it to master git rebase -i master ?
20141105 21:26:55< iceiceice> so most likely you want to rebase -i master
20141105 21:27:12< iceiceice> another common thing is, git rebase -i HEAD~5
20141105 21:27:18< iceiceice> that will make a range of exactly 5 commits
20141105 21:27:36< Dugi> Why would I need that?
20141105 21:27:39< iceiceice> idk
20141105 21:27:46< iceiceice> if you only want to rearrange the last 5
20141105 21:27:59< Dugi> Ah. I will try that.
20141105 21:28:27< iceiceice> you gotta be careful though with the HEAD~5 thing
20141105 21:28:32< iceiceice> if you are on a branch based off wesnoth master,
20141105 21:28:36< iceiceice> and it only has 3 commits,
20141105 21:28:40< iceiceice> and you use HEAD~5,
20141105 21:28:45< iceiceice> you can start fucking with the commits on master,
20141105 21:28:47< Dugi> So basically I replace the pick of the last one with squash and it will be done?
20141105 21:28:50< iceiceice> and then your fork becomes incompatible
20141105 21:29:02< iceiceice> so make sure you only touch the commits that are yours
20141105 21:29:10< iceiceice> yeah htat will work
20141105 21:29:13< Dugi> I have more than 5 commits there.
20141105 21:29:59< Dugi> It ruined it.
20141105 21:30:19< Dugi> I must have made a mistake somewhere.
20141105 21:30:31< iceiceice> gfgtdf: i want to merge this: https://github.com/wesnoth/wesnoth/pull/324
20141105 21:31:04< iceiceice> i won't do it for like an hour but if you see a reason not to let me know,
20141105 21:31:24< iceiceice> i didnt fix all the bugs that previously existed, just some of them
20141105 21:31:42< iceiceice> at least it seems stable when you click around
20141105 21:31:59< Dugi> iceiceice: Many of the changes of the last commits were undone somehow.
20141105 21:32:28< iceiceice> Dugi: ok
20141105 21:32:31< gfgtdf> iceiceice: hm maybe we should also add a example [multiplayer] that uses the new rng to wesnoth mainline ?
20141105 21:32:44< iceiceice> if you need to undo the rebase ,
20141105 21:32:51< iceiceice> you can use "git reflog" to look at your recent history
20141105 21:33:08< iceiceice> and "git checkout HEAD@{2}" or whatever number to go back before the rebase
20141105 21:33:17< iceiceice> gfgtdf: i put an example in the commit message
20141105 21:33:22< iceiceice> that i have been using to test
20141105 21:33:34< iceiceice> https://github.com/cbeck88/wesnoth/commit/31b4f735b71956f10ce983833dd675c332a9a304
20141105 21:33:45< iceiceice> its like, the worst map generator ever XD
20141105 21:34:09< gfgtdf> iceiceice: also tis assert seems obviously unreachabe to me https://github.com/wesnoth/wesnoth/pull/324/files#diff-e883a8b9a4048bc7fbc4d556178332a4R26
20141105 21:34:56< iceiceice> yeah you're right
20141105 21:35:01< iceiceice> i'll fi that
20141105 21:35:02< gfgtdf> iceiceice: do you use the lua mapgenerator in one of your addons ?
20141105 21:35:08-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20141105 21:35:19< iceiceice> gfgtdf: i made a dummy addon with the scenario code i linked to
20141105 21:36:15< Dugi> iceiceice: Okay, that worked. But why did it undo some of my last changes? Might be because there was one commit where I accidentally didn't fix merging issues.
20141105 21:36:27< gfgtdf> iceiceice: i guess if we don't have the wesnoth table we especialy cannot add files with wesnoth.require/dofile? 
20141105 21:36:48< iceiceice> gfgtdf: i added OS
20141105 21:36:50< iceiceice> lib
20141105 21:36:58< iceiceice> so i think you can still open files maybe/
20141105 21:37:08< iceiceice> but none of the wesnoth api functions are currently available
20141105 21:37:20< gfgtdf> iceiceice: but os is unsav  i think taht why we disable it in our lua code
20141105 21:37:25< gfgtdf> unsave*
20141105 21:37:28< iceiceice> ah right
20141105 21:37:29< gfgtdf> unsafe
20141105 21:37:33< iceiceice> i copied whatever lib loading code we had
20141105 21:37:52< iceiceice> gfgtdf: it's possible to pass arguments to the map generator,
20141105 21:38:07< iceiceice> everything in [generator] gets passed to the vararg thing `...` in lua as a config table
20141105 21:38:08< gfgtdf> iceiceice: maybwe we can have some base luaKernel class and derive our both versiosn from it
20141105 21:38:16< iceiceice> gfgtdf: i did this in my other PR :)
20141105 21:38:36< iceiceice> https://github.com/cbeck88/wesnoth/commit/1998b0263982fbba4e8f3792a61330222924a879
20141105 21:38:50< iceiceice> i have to fix that one up though
20141105 21:38:55< iceiceice> maybe i should just merge the first part
20141105 21:38:59< iceiceice> and work out the second part later
20141105 21:40:25< gfgtdf> iceiceice: what do you mean ba "first" and "second" part ?
20141105 21:41:07< iceiceice> maybe i'll try to merge the part that adds kernel types
20141105 21:41:14< iceiceice> and renames the current lua kernel
20141105 21:41:16< iceiceice> first
20141105 21:41:22< iceiceice> the secodn part would allt he mp scripting related stuff
20141105 21:41:32< iceiceice> i decided that i should have engineered it differently,
20141105 21:41:39< iceiceice> i think the scripts should run as coroutines
20141105 21:42:53< Dugi> iceiceice: Okay, that worked. But why did it undo some of my last changes? Might be because there was one commit where I accidentally didn't fix merging issues.
20141105 21:43:08< fendrin> hi iceiceice
20141105 21:43:09< iceiceice> Dugi: it's really hard for me to know without being able to see each commit
20141105 21:43:16< iceiceice> fendrin: hi
20141105 21:43:18< gfgtdf> iceiceice: what are coroutines ?
20141105 21:43:25< fendrin> iceiceice: I have left you some messages. Search for "ice³"
20141105 21:43:27< Dugi> You can't see it on https://github.com/wesnoth/wesnoth/pull/134 ?
20141105 21:44:00< iceiceice> Dugi: is it up to date?
20141105 21:44:05< iceiceice> you have to push out your changes
20141105 21:44:07< Dugi> It is.
20141105 21:44:10< iceiceice> and if you were rebasing you have to push -f
20141105 21:44:32< Dugi> I have done no changes since the last commit. I only need to merge the last two commits.
20141105 21:44:58< iceiceice> Dugi: i can only give general advice,
20141105 21:45:19< iceiceice> if i am trying to figure out how to rebase things usually it means i am typing git log / git diff blah blah constantly
20141105 21:45:22< iceiceice> to see what each commit does
20141105 21:46:19< Dugi> iceiceice: So any idea why did git rebase -i master{5}, changing pick to squelch for the last update, undid many previous changes? It might be related to the problem that https://github.com/wesnoth/wesnoth/pull/134 claims that there are conflicts.
20141105 21:46:32< iceiceice> fendrin: i don't know how to type ice^3
20141105 21:46:56< fendrin> iceiceice: copy&paste is your friend :-)
20141105 21:47:03< iceiceice> Dugi: i think maybe master{5} is not what you want
20141105 21:47:07< iceiceice> i have no idea what that will do
20141105 21:47:19< iceiceice> Dugi: ah i see
20141105 21:47:23< Dugi> So what, only master ?
20141105 21:47:26< iceiceice> if your branch is not merging cleanly with master
20141105 21:47:41< iceiceice> ok so this is a thing about rebase that is sometimes helpful but sometimes not what you want,
20141105 21:47:52< iceiceice> if you rebase a branch to master it tries to make it branch off of current master
20141105 21:47:58< iceiceice> if you don't want it to do that,
20141105 21:48:03< iceiceice> you need to give a different commit
20141105 21:48:03< iceiceice> like
20141105 21:48:11< iceiceice> git merge-base master
20141105 21:48:21< iceiceice> will tell you the common ancestor of your current place and master
20141105 21:48:28< iceiceice> and i think you should rebase to that commit then
20141105 21:48:34< iceiceice> i never had to do this before though
20141105 21:48:37< Dugi> Any idea how do I fix the problem that it's not merging cleanly with the master?
20141105 21:48:59< iceiceice> Dugi: if it were me i would do "git rebase master" and fix each conflict one at a time
20141105 21:49:38< Dugi> Well, but that would most likely undo most changes I have done later, no?
20141105 21:50:23< iceiceice> dugi: what it will do is,
20141105 21:50:32< iceiceice> for each commit it will generate a diff for it
20141105 21:50:42< iceiceice> going backwards from your branch, to the merge-base with master
20141105 21:50:46< iceiceice> and it keeps those in a list
20141105 21:50:54< iceiceice> then, it moves to the current tip of master
20141105 21:50:58< iceiceice> and tries to replay them in sequence
20141105 21:51:05< iceiceice> if the diffs apply cleanly, great
20141105 21:51:10< iceiceice> if they don't it stops and you ahve to fix it
20141105 21:51:21< iceiceice> if you fix a bug in a later commit now, but you need to fix it earlier,
20141105 21:51:25< iceiceice> it doesn't really matter i guess
20141105 21:51:38< Dugi> Ah, okay, I will try that.
20141105 21:51:51< iceiceice> you can just fix it earlier and when you get to it later it will either not be a problem then, or it will be trivial to resolve
20141105 21:52:15< iceiceice> Dugi: it's also a really good idea to compile each time you resolve a conflict
20141105 21:52:29< iceiceice> so you make sure you actually fixed stuff
20141105 21:53:51< iceiceice> fendrin: ahh thanks for followign up on that
20141105 21:54:00< Dugi> iceiceice: I will try to remember that. I don't wanna screw things up like before.
20141105 21:54:11< fendrin> iceiceice: I guess there is some action to be taken.
20141105 21:54:14< iceiceice> so i realized that, the problem is in World Conquest II add-on
20141105 21:54:20< iceiceice> and i fixed it by deleting that add-on
20141105 21:54:24< iceiceice> from my master branch
20141105 21:54:38< iceiceice> i don't know why the add-ons affect the output of test executable, that seems really annoying
20141105 21:54:42< iceiceice> but it seems to be the case
20141105 21:55:12-!- mjs-de [~mjs-de@f053177106.adsl.alicedsl.de] has quit [Remote host closed the connection]
20141105 21:55:22< iceiceice> i dont know what actually happened int he add-on that was breaking stuff
20141105 21:56:04-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20141105 21:57:27< fendrin> Dugi: your merge request causes some conflicts.
20141105 21:59:33-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20141105 22:00:19< Dugi> iceiceice: I tried to do that, but I accidentally detached the HEAD.
20141105 22:00:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 22:01:14< Dugi> I have made a backup of everything for the case if something went wrong, so the current files can be lost, but how do I reattach the HEAD so that I could merge the last two commits and fix the merging issues with master?
20141105 22:03:52-!- gfgtdf [~chatzilla@e176185161.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 32.0.3/20140923175406]]
20141105 22:04:11< iceiceice> Dugi: when you rebase a branch it makes a detached head
20141105 22:04:14< iceiceice> as long as the rebase is happening
20141105 22:04:24< iceiceice> when it finishes the branch will be reset
20141105 22:05:03< iceiceice> normally the only way you get detached head is if you type "git checkout 29342"
20141105 22:05:07< Dugi> iceiceice: But this time, it showed no problems with merging with master.
20141105 22:05:13< iceiceice> and then you fix it by typing "git checkout branch"
20141105 22:06:36< fendrin> Dugi: Okay, fixed the conflict. It compiles now... Maybe...
20141105 22:07:50< Dugi> The website still writes that 'This pull request contains merge conflicts that must be resolved.' Any idea how do I learn where is that problem?
20141105 22:15:44-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20141105 22:17:40-!- fabi [~quassel@p20030051AA25B935814671F08D2B0AE5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141105 22:17:40-!- fabi [~quassel@p20030051AA25B935814671F08D2B0AE5.dip0.t-ipconnect.de] has quit [Changing host]
20141105 22:17:40-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20141105 22:19:55< Dugi> Hey, I need help, I somehow duplicated the last two commits.
20141105 22:21:12< Dugi> No, it seems that I have successfully merged the last two, but they remain there, inactive.
20141105 22:22:03< Dugi> But it still writes that it has some conflicts, which is weird.
20141105 22:24:12< Dugi> Is there a way to get any attention with this? This git thing is trolling me all the way and I need advice.
20141105 22:25:21< fabi> Dugi: Sorry, I am no expert on git either.
20141105 22:25:55< fabi> Do you use it on the command line?
20141105 22:26:05-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20141105 22:26:07< Dugi> fabi: So how do you handle larger changes?
20141105 22:26:16< Dugi> fabi: Yes, I use it on command line.
20141105 22:26:52< fabi> What is the output of git status?
20141105 22:28:34< Dugi> This: http://pastebin.com/uf1Td3jx But the problem is here: https://github.com/wesnoth/wesnoth/pull/134
20141105 22:28:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20141105 22:31:54< fabi> I don't see duplicated commits.
20141105 22:32:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 22:32:44< Dugi> Well f23bea7 and a16ab5d are the same as 354ed44 in effect. 
20141105 22:33:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 22:34:39< fabi> Dugi: Maybe that is that remerge thing which is not really a problem.
20141105 22:35:24< fabi> Dugi: I am browsing the new ui stuff you added. I think it looks fine. It's not doing much since the add-on server does not understand...
20141105 22:35:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 22:35:38< Dugi> fabi: But those two inactive things look pretty ugly there. Is there a way to get rid of them?
20141105 22:36:05< Dugi> fabi: What does the add-on server not understand?
20141105 22:36:56< fabi> Dugi: My interface is not dispalying anything as "inactive".
20141105 22:37:22< Dugi> fabi: Inactive? What is that?
20141105 22:37:32< fabi> Dugi: The default add-on server can't understand "20141105 23:33:12 error addons-client: server error: message = Unrecognized [submit_gameplay_times] request." for example. Which is not a surprise.
20141105 22:37:41< fabi> <Dugi> fabi: But those two inactive things look pretty ugly there. Is there a way to get rid of them?
20141105 22:37:56< fabi> You talk about them. I can't identify the problem.
20141105 22:38:03< Dugi> Mine does accept it. Have you compiled also the updated campaignd?
20141105 22:38:10< fabi> yes
20141105 22:38:16< Dugi> Ah.
20141105 22:39:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 22:39:12< Dugi> I mean f23bea7 and a16ab5d. I merged them into one 	354ed44, but they still show up there. 
20141105 22:39:47< fabi> I guess this is normal. 
20141105 22:39:57< fabi> I have started the local server now.
20141105 22:40:55< fabi> Dugi: Do you know what address to specify? "localhost" gives me: Connection closed.
20141105 22:41:22< fabi> I mean: Remote host disconnected.
20141105 22:41:28< Dugi> What port did you bind it to?
20141105 22:41:35< fabi> I did not specify.
20141105 22:42:23< Dugi> Then shut it down and set it in the server.cfg file it created.
20141105 22:43:10-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141105 22:43:59< fabi> can't find the server.cfg
20141105 22:44:06< fabi> but I can specify the port on the commandline
20141105 22:44:44< fabi> fabi@sepia:~/git/wesnoth$ sudo ./wesnothd -p 30000
20141105 22:45:08< fabi> when I connect to "localhost:30000" I get now: Network Communicatin Error.
20141105 22:45:28< Dugi> Try 127.0.0.1 instead of localhost
20141105 22:46:54< fabi> no difference
20141105 22:47:15< fabi> Dugi: The interface is already showing me a rating when I connect to the default server. How is it computed?
20141105 22:47:41< Dugi> It gets no information about user rating and gameplay hours abviously.
20141105 22:48:14< Dugi> The rating shown on the list is a value computed from download frequency, hours spent playing and users' rating.
20141105 22:48:29< Dugi> When two of the three values are absent, only one of them is shown.
20141105 22:48:58< fabi> Thus it is only another download thing right now. I see.
20141105 22:49:32< Dugi> I mean, only one of them is considered, the other values are zero. So it computes a rating 0-2.5 based on the download frequency (0.25 would be for gameplay times and 0.5 would be for users' rating for a total of 10).
20141105 22:49:40< shadowm> 19:44:42 <fabi> fabi@sepia:~/git/wesnoth$ sudo ./wesnothd -p 30000
20141105 22:49:49< shadowm> wesnothd is the MP server, campaignd is the add-ons server.
20141105 22:50:00< fabi> oh
20141105 22:50:02< fabi> stupid me
20141105 22:50:06< shadowm> And don't run any of that as root.
20141105 22:50:42< fabi> Thank you :-)
20141105 22:51:13< Dugi> Don't run that as a root, I may have forgotten to remove some of the viruses I included to increase the downloads of my campaign.
20141105 22:51:39< shadowm> wesnothd is incuded in my statement above.
20141105 22:51:42< fabi> lol
20141105 22:51:50< shadowm> And not because it's your code, but rather because it's ours.
20141105 22:51:57< fabi> okay
20141105 22:52:05< fabi> now I have this nice empty server
20141105 22:52:10< fabi> everything seems to work
20141105 22:52:22< fabi> is there a way to get a test population up there easily?
20141105 22:52:32< Dugi> Try to put this into server.cfg : http://pastebin.com/xh0nA5YG
20141105 22:55:39< fabi> Dugi: It does not write a server.cfg.
20141105 22:55:56< fabi> it just complains that it can't open an existing server.cfg.
20141105 22:56:01< Dugi> fabi: Then create a plain text file with that name.
20141105 22:56:08< Dugi> I thought it does,
20141105 22:57:29-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20141105 22:57:32< fabi> Dugi: "The Violent Bullshit" rofl
20141105 22:57:41< fabi> Okay, it is working now.
20141105 22:57:42< shadowm> It will write the server.cfg after 10 minutes or the next time you upload an add-on.
20141105 22:57:56< Dugi> fabi: Needed to make up an add-on name quickly.
20141105 22:58:02< shadowm> Unless the directory isn't writeable by the effective uid running campaign, of course.
20141105 22:58:05< shadowm> campaignd
20141105 22:58:21< fabi> okay, fine
20141105 22:58:23< fabi> seems to work
20141105 23:00:06< fabi> Dugi: The "Do you like it too" checkbox is doing nothing for me.
20141105 23:00:38< Dugi> fabi: It is not computed immediately, wait for up to 10 minutes.
20141105 23:01:02< fabi> Dugi: That is okay. But it needs to be explained to the user.
20141105 23:01:40< Dugi> fabi: I am not sure, but it might show up also when you reconnect to the addons' server.
20141105 23:02:02< fabi> It is now stuck
20141105 23:02:06< shadowm> (But seriously, in general you do not want to run random crap as root, especially not network services, unless they need to bind to a privileged port -- then they should relinquish as many privileges as possible as soon as possible.)
20141105 23:02:23< fabi> shadowm: noted
20141105 23:02:56< Dugi> What kind of thing should be explained? Something like 'Your votes have been cast'?
20141105 23:02:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141105 23:03:03< fabi> Dugi: "Sending information about..." is stalled.
20141105 23:03:33< fabi> Dugi: The output of the server is: 20141105 23:57:14 info campaignd: received information about add-on gameplay times from '127.0.0.120141106 00:01:37 info campaignd: received rating of 'The Violent Bullshit' from 127.0.0.1
20141105 23:03:49< fabi> I can only hit cancel.
20141105 23:04:12< Dugi> Dammit.
20141105 23:04:47< fabi> But it seems to have worked.
20141105 23:04:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 23:04:55< fabi> The rating increased to 6/10.
20141105 23:05:30-!- irker800 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20141105 23:05:30< irker800> wesnoth: gfgtdf wesnoth:master 9fc66b7486d4 / src/playsingle_controller.cpp: add assert http://git.io/hKdLjg
20141105 23:05:40-!- gfgtdf [~chatzilla@d149087.adsl.hansenet.de] has joined #wesnoth-dev
20141105 23:06:00< fabi> Dugi: It also wants to send the data everytime, even if I did not change anything to the rating. 
20141105 23:06:03< Dugi> Add line send_message("Feedback received.", req.sock); to line 872 of campaign_server.cpp
20141105 23:07:09< fabi> Dugi: I would consider to cache the checked boxes and the new liked value localy. That solution won't confuse the user and make every popup obsolete.
20141105 23:07:50< fabi> Dugi: Only when the update fails later a user notification would be necessary.
20141105 23:08:06< Dugi> Sure you haven't done anything with the rating? There is a check that should prevent empty ratings from being uploaded.
20141105 23:08:22< Dugi> Which checkboxes do you mean?
20141105 23:08:43< fabi> Dugi: The "Do you also like it?" one.
20141105 23:09:18< Dugi> Yes, that should make sense.
20141105 23:09:57-!- cib0 [~cib@p508BC259.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20141105 23:10:16< fabi> Dugi: I do: 1) Start Wesnoth 2) Connect to localhost campaignd. 3) Press "Description" of one of the add-ons. 4) Press "Close". Then always the uploading progress bar appears and does not go away until canceled.
20141105 23:10:57< Dugi> It does not appear for me... strange.
20141105 23:11:04-!- Anakonda [Anakonda@87-92-142-108.bb.dnainternet.fi] has quit [Read error: Connection reset by peer]
20141105 23:11:28< fabi> Dugi: Let me insert the feedback received thing. Maybe it fixes everything magically.
20141105 23:12:52< Dugi> fabi: Ah, dammit, I fixed the upload freeze bug on my side and didn't notice that it might be actually uploading the empty rating, but it didn't hang because the hang issue was fixed.
20141105 23:14:59< fabi> Dugi: It seems to work fine except that little glitch.
20141105 23:15:28< fabi> Dugi: Better make sure the user understands that the "Rating" in the list one dialog above and the "Player Rating" are different things.
20141105 23:15:52< Dugi> Dugi: Any suggestions how?
20141105 23:16:07< fabi> Dugi: Call one Rating and the other score
20141105 23:16:24< fabi> a score is computed
20141105 23:16:27< Dugi> fabi: Excellent idea.
20141105 23:16:30< fabi> the term should be correct
20141105 23:16:41< Dugi> So there will be one rating and one score.
20141105 23:16:51< fabi> right
20141105 23:16:57< fabi> sounds good in my ears
20141105 23:17:07< fabi> caching the rating would also make sense.
20141105 23:17:21< fabi> there is currently no feedback that the rating process itself got noticed.
20141105 23:18:09< fabi> Maybe add the personal rating into the players rating line.
20141105 23:18:43< Dugi> fabi: Yeah, that sounds well too.
20141105 23:19:17< fabi> "Players rating: 5.0/10 (5.0)" or "Players rating: 5.0/10 (not rated)"
20141105 23:20:24< Dugi> fabi: Better than what I imagined.
20141105 23:21:08< Dugi> fabi: I wish you could help me this much also with git...
20141105 23:21:20< fabi> Dugi: The "Review this add-on" dialog might benefit from a "type or genre" field which is not free text but some list can be compiled from a predefined set like "RPG" "Dungeon Crawler" "Whatever" 
20141105 23:22:25< Dugi> fabi: I think that it should belong into the overall part.
20141105 23:22:46-!- lipkab [~lipkab@host-91-147-211-128.biatv.hu] has quit [Read error: Connection reset by peer]
20141105 23:23:00< Dugi> fabi: Or gameplay. It's hard to make up cathegories that would cover enough possibilities. And people can create hybrids or completely novel things.
20141105 23:23:32< fabi> yes
20141105 23:23:45< fabi> I get your point.
20141105 23:25:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 23:29:05< fabi> Dugi: Maybe restrict the rating process to installed add-ons only.
20141105 23:29:31< fabi> Dugi: And the review one.
20141105 23:29:44< Dugi> shadowm: I think that it might be better if you reviewed the appearance of my patches first and when all is done, I'll split it into several commits again and make a new pull request.
20141105 23:30:09< fabi> Dugi: Maybe not the "I like this review as well" one.
20141105 23:30:25< Dugi> fabi: There are add-ons you have played in the past and know what they're about, but you don't feel like replaying them.
20141105 23:30:52< shadowm> Dugi: I want to know exactly how this all works first.
20141105 23:31:08< Dugi> shadowm: I thought you have just tried it.
20141105 23:31:13< irker800> wesnoth: Chris Beck wesnoth:master e0c7bc517524 / .travis.yml: travis: disable C++ unit tests when doing the CXX11 build http://git.io/hRBEMg
20141105 23:31:18< Dugi> shadowm: Or it was just fabi who did?
20141105 23:31:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 23:31:43< gfgtdf> iceiceice: the "invalid" here is a typo? https://github.com/wesnoth/wesnoth/pull/324/files#diff-e883a8b9a4048bc7fbc4d556178332a4R17
20141105 23:32:00< shadowm> Dugi: Nowhere above do I see anything that would indicate that I've tried it.
20141105 23:32:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20141105 23:32:12< iceiceice> gfgtdf: yeah i guess
20141105 23:32:16< iceiceice> it shold just be, any old config
20141105 23:32:22< shadowm> I want to know about the score system and the rationale behind other design choices.
20141105 23:32:26< iceiceice> i tried to use config::invalid but apparently that is private
20141105 23:32:39< shadowm> Ideally, this would be permanently archived in a commit message or Doxygen comment.
20141105 23:32:46< Dugi> shadowm: Can you please do it? Showing it would save me a lot of explanation.
20141105 23:33:05< shadowm> I'm busy with other things right now, so that would have to be tomorrow.
20141105 23:33:29< Dugi> shadowm: Okay.
20141105 23:33:36< Dugi> shadowm: It was getting late anyway.
20141105 23:33:42< gfgtdf> iceiceice: you can also just have a "static const config dummy_config" in teh cpp file
20141105 23:33:43< fabi> Dugi, shadowm: I think it would be nice if we had a framework that makes the score system easy customizable. 
20141105 23:33:52< iceiceice> gfgtdf: yeah but its ugly
20141105 23:33:57< iceiceice> the actual value is totally meaningless,
20141105 23:34:03< iceiceice> so why not just put any old config there
20141105 23:34:12< fabi> Dugi, shadowm: And the review sections.
20141105 23:34:22< iceiceice> the problem is that the the field is const so it has to be set in initializer list
20141105 23:34:30< iceiceice> so it has to be with the ? syntax
20141105 23:34:40< iceiceice> i guess i could define a static member fcn to set it 
20141105 23:34:49< iceiceice> * static function that generates the values
20141105 23:35:15< iceiceice> gfgtdf: do you know if you can use lambdas in C++11 in initializer list?
20141105 23:35:36< shadowm> Dugi: I advise you read up on using Git for repositories with multiple contributors, though, because there's absolutely no guarantee that the conflicts from master will not keep happening.
20141105 23:35:49< gfgtdf> iceiceice: i see no reason why not
20141105 23:36:30< Dugi> shadowm: I wanted to see that happen again so that I could resolve it, but it didn't happen again.
20141105 23:36:53< Dugi> iceiceice: C++11 features can be used in wesnoth?
20141105 23:36:57< shadowm> No.
20141105 23:37:04< iceiceice> Dugi: not yet
20141105 23:37:15< shadowm> It's a pity. ;)
20141105 23:37:17< iceiceice> only c++11 + boost for now
20141105 23:37:21< iceiceice> * C++98
20141105 23:38:11< shadowm> I've got a few things in my queue here which I might finish up and land during the upcoming weeks. No major refactors planned, but they may still introduce a lot of diff noise to the campaignd source.
20141105 23:39:15< iceiceice> gfgdf: i thought again, now i am doing what you suggest ;)
20141105 23:39:17< gfgtdf> iceiceice: why not "sides_.first != sides_.second ? *sides_.first : throw some_error_class" 
20141105 23:39:30< Dugi> shadowm: Will you let me finish this thing before you commit those?
20141105 23:39:42< iceiceice> gfgtdf: does that work?
20141105 23:39:53< gfgtdf> iceiceice: although accorind to http://stackoverflow.com/questions/7957696/throw-and-ternary-operator-in-c msvc 2008 migth not support it
20141105 23:40:12-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141105 23:40:38< shadowm> Dugi: I can't really guarantee that.
20141105 23:42:00< fabi> Dugi: The "Hours spent playing: " could also display what the player contributed himself to the overall time. (Assuming it means overall time).
20141105 23:43:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 23:43:48< fabi> Dugi: And there seems to be no possibilty to "unrate" an add-on again.
20141105 23:44:31< fabi> Dugi: Is there any concept to deny multiple ratings per user?
20141105 23:44:37< Dugi> fabi: It isn't stored permanently locally. You just flush all gameplay times to the server and have no track of them anymore aftwewards.
20141105 23:44:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141105 23:45:01< Dugi> fabi: Multiple ratings aren't allowed, only the last one is considered.
20141105 23:45:16< fabi> Dugi: Well, then just store them permanently.
20141105 23:45:29< Dugi> fabi: Multiple review likes from a single user aren't possible neither.
20141105 23:45:48< fabi> Dugi: And upload them the next time possible. Thus playing on the moon is contributed later to the server.
20141105 23:45:53< Dugi> fabi: I might do that.
20141105 23:47:10< iceiceice> Dugi: another git tip that i find valuable,
20141105 23:47:24< iceiceice> git also has the possible to execute arbitrary shell commands, as part of the rebase 
20141105 23:47:39< iceiceice> if you put "exec" or just x after a commit, the rest fo that line will be executed at that point
20141105 23:47:54< iceiceice> so for most pull requests that i make, when i am finishing up i do "git rebase -i master",
20141105 23:48:05< iceiceice> and between every picked commit i copy paste "x scons && ./test"
20141105 23:48:13-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Ping timeout: 244 seconds]
20141105 23:48:14< iceiceice> then i go for dinner or something
20141105 23:48:27< iceiceice> when i come back, if every commit compiled and passed unit tests, i know the whole PR is clea
20141105 23:48:29< iceiceice> *clean
20141105 23:48:39< iceiceice> if something is wrong, it stops there and then i can check it out
20141105 23:48:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141105 23:49:18< fabi> Dugi: Maybe it is enough to add a "none" position to the rating slider.
20141105 23:49:28< Dugi> iceiceice: Interesting. Good to know.
20141105 23:51:17< Dugi> fabi: Messing up with GUI widgets is very hard. There would be the inelegant way to create a string vector of possibilities like None, 0/10, 1/10 etc, but some pedantic people would most likely complain about that. And also, where should that None position be?
20141105 23:51:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141105 23:51:35< Dugi> I will be afk for a while.
20141105 23:54:06< fabi> Dugi: Have a look at the "Maximum auto-saves: " slider in the preferences->General dialg. It uses the "infinite" state, which is at the right most. I would playe "None" to the left most of the rating slider.
20141105 23:54:28< fabi> s/play/place
20141105 23:54:34< fabi> s/playe/place
20141105 23:59:32-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Thu Nov 06 00:00:00 2014