--- Log opened Mon Nov 10 00:00:02 2014
--- Day changed Mon Nov 10 2014
20141110 00:00:02< iceiceice> or maybe even "game_setup" ?
20141110 00:00:20< iceiceice> i think the current name is too long
20141110 00:01:21< shadowm> game_setup sounds more like it.
20141110 00:01:28< gfgtdf> iceiceice: my original name was "game_setup" thunderstruck thought that "game_init" was better, since i dont really like abbreviation  i named it "game_initialization" instead.
20141110 00:01:36< iceiceice> haha
20141110 00:04:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141110 00:11:49< shadowm> Wow eff you gna.org.
20141110 00:12:07< gfgtdf> eff ?
20141110 00:12:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 00:12:50< shadowm> It's been slow for me for the past 10 minutes and suddenly I get a "database down" error. And again.
20141110 00:14:20-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20141110 00:16:56< iceiceice> yeah i guess i should be helping to close bugs
20141110 00:17:28< shadowm> I already did all.
20141110 00:17:52< iceiceice> ok
20141110 00:18:19< iceiceice> what about this one? https://gna.org/bugs/index.php?22307
20141110 00:19:08< shadowm> As in previous occasions, I decided to leave RFT and WFM bugs alone. Someone needs to get to work on triaging them before 1.12.0.
20141110 00:21:20< iceiceice> i guess we should close this also
20141110 00:21:22< iceiceice> https://gna.org/bugs/index.php?21882
20141110 00:22:14< iceiceice> shadowm: for what it's worth, i'm pretty convinced that most RFT are actually "fixed"
20141110 00:23:02< iceiceice> i used to mark everything that I fixed as RFT
20141110 00:23:06< iceiceice> then later i read this: http://wiki.wesnoth.org/ReportingBugs#Bug_protocol
20141110 00:23:11< gfgtdf> +1 for marking those 2 as fixed.
20141110 00:23:48< iceiceice> i mean its always good if someone else tests it,
20141110 00:23:59< iceiceice> but if it went several releases as RFT and no one brought it up again i think it means its fixed
20141110 00:24:15< shadowm> I've done enough meta work for tonight so I'm leaving that to you.
20141110 00:24:48< gfgtdf> iceiceice: y but there are situation when you cannot test it youself becasue for example you develop on windows and the bug is mac only.
20141110 00:24:59< gfgtdf> iceiceice: or becasue you are just lazy.
20141110 00:25:33< iceiceice> gfgtdf: yeah its true
20141110 00:25:41< iceiceice> maybe we should change the wiki
20141110 00:28:49< gfgtdf> iceiceice: i also noted that we have sone colsed bugs merked as ready for test
20141110 00:29:24< gfgtdf> some*
20141110 00:31:01< gfgtdf> iceiceice: maybe it would be useful to have some fixed ony for master/stable option
20141110 00:31:18-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141110 00:32:47-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141110 00:32:53< iceiceice> gfgtdf: yeah, gna is not so good for that
20141110 00:37:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141110 00:40:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 00:43:07< Dugi> Bye,
20141110 00:43:13-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has left #wesnoth-dev []
20141110 00:46:29< gfgtdf> iceiceice: about https://gna.org/bugs/index.php?22307, when you read about OSS you think about something different than http://en.wikipedia.org/wiki/Oss ?
20141110 00:46:44-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141110 00:48:12< iceiceice> i think of Open source software :)
20141110 00:48:37< gfgtdf> iceiceice: ah ok i thought nothing an looked it up at wikipedia.
20141110 00:53:32< iceiceice> hmm here is a git question,
20141110 00:53:40< shadowm> I think of OSS and alternatively OSS.
20141110 00:53:49< iceiceice> so often times, i have some branch with a bunch of commits, and some of them are fixups
20141110 00:53:54< shadowm> (Open Source Software, Open Sound System.)
20141110 00:54:05< iceiceice> and they might be fixups to the most recent commit or an older one
20141110 00:54:11< iceiceice> and it's tedious to figure out exactly where they should be
20141110 00:54:23< iceiceice> i would like to be able to tell git "push this guy as early as it can go without making a conflict"
20141110 00:54:53< iceiceice> does anyone know if that can be done? or do i have to make some terrible shell script
20141110 00:54:58-!- prkc [~prkc@BC06D7AE.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20141110 00:55:14< iceiceice> (i want to be able to tell git rebase that)
20141110 00:56:15< gfgtdf> iceiceice: maaybe you could use git blame to know which commit changed that line before ? (idk how that halps though)
20141110 00:57:21< shadowm> If you have commits that should be in another branch then why not cherry pick them on the other branch and later erase them from the original branch?
20141110 00:57:31< shadowm> *And* rebase that branch.
20141110 00:58:03< iceiceice> gfgtdf: i guess what i had in mind is like, a script that takes the commit and keeps trying to rebase -i, by pushing that commit one step earlier, and it keeps doing this until git reports a conflict, then it does git rebase --abort
20141110 00:58:29< iceiceice> shadowm: the idea is that they are all on the same branch, i'm just trying to handle the fixup commits more gracefully
20141110 00:58:51< shadowm> Also, I'm assuming they are "fixups" to commits that aren't in the branch's parent?
20141110 00:59:06< iceiceice> yeah its like, some topic branch that introduces some code
20141110 00:59:13< iceiceice> but later i realize something needs to be redesigned or something
20141110 00:59:49< shadowm> I usually mark "fixups" with [INTERNAL] in the subject and later squash them in git rebase -i, because nobody is interested in seeing how much I screwed up before merging upstream.
20141110 01:00:01< iceiceice> shadowm: that's exactly what i'm talking about
20141110 01:00:13< iceiceice> the thing is, when i squash them with git rebase -i,
20141110 01:00:20< iceiceice> if i added the feature over like 5-7 commits,
20141110 01:00:28< shadowm> So if you ever see a commit with "[INTERNAL]" in the subject, you know I forgot to review my branch before merging.
20141110 01:00:29< iceiceice> and then in testing generated like 5-7 fixups
20141110 01:00:41< iceiceice> now i have to match the fixups with the commits they are fixing up somehow
20141110 01:01:17< iceiceice> usually i end up pushing the whole mess to my fork and looking at the diffs in github to figure it out
20141110 01:01:20< iceiceice> but it should be easier
20141110 01:01:57< shadowm> Okay, no idea then
20141110 01:07:10< gfgtdf> iceiceice: can we close https://gna.org/bugs/index.php?8106 and https://gna.org/bugs/index.php?3856 ?
20141110 01:09:07< iceiceice> yes
20141110 01:09:14< iceiceice> and yes
20141110 01:11:22< gfgtdf> iceiceice: you now about the state of https://gna.org/bugs/index.php?15948? i know that i fixed "random_start_time=yes" for master, andi know that is has been fixed for 1.12 in MP, but has it also been fixed for 1.12 on SP ?
20141110 01:12:27< iceiceice> gfgtdf: i thought it was only broken for MP
20141110 01:12:35< iceiceice> i never tried for SP
20141110 01:13:36< gfgtdf> iceiceice: broken here means causing OOS in replays.
20141110 01:13:47< iceiceice> yeah
20141110 01:13:49< gfgtdf> iceiceice: hm wait
20141110 01:14:23< gfgtdf> iceiceice: y maybe this issue doesnt effect SP becasue we make teh [replay_start] after resolving random_start_time
20141110 01:15:38< gfgtdf> iceiceice: y your are right
20141110 01:17:49< gfgtdf> iceiceice: marking as fixed
20141110 01:17:55< iceiceice> ok
20141110 01:18:33< iceiceice> i guess we shuld make sure that they got changelog entries also
20141110 01:18:50< iceiceice> its possible that if i thought i fixed a bug but i wasn't sure that i didn't add a "fixed: XXX" entry
20141110 01:47:32-!- gfgtdf [~chatzilla@f054149218.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 33.0.3/20141105223254]]
20141110 02:21:05-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20141110 02:27:37-!- duncan_shriek [~roland@2a01:1e8:e100:8618::24] has quit []
20141110 02:30:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141110 02:31:56< irker465> wesnoth: Chris Beck wesnoth:master 042b72a4b880 / src/ (17 files in 5 dirs): rename scripting/lua.?pp to game_lua_kernel.?pp http://git.io/kgJfZQ
20141110 02:31:58< irker465> wesnoth: Chris Beck wesnoth:master 4541412ebce3 / src/ (6 files in 2 dirs): add lua_kernel_base as a super class of game_lua_kernel http://git.io/45qG0A
20141110 02:32:00< irker465> wesnoth: Chris Beck wesnoth:master ca309d98b2a5 / src/ (5 files in 2 dirs): branch off "lua_common" functions from api defn file http://git.io/jQySoQ
20141110 02:32:02< irker465> wesnoth: Chris Beck wesnoth:master cd3e8cf333d4 / src/ (commandline_options.cpp commandline_options.hpp): add function to generate config from cmd line opts, for lua http://git.io/hHJyRw
20141110 02:32:04< irker465> wesnoth: Chris Beck wesnoth:master ecc714e41e8f / src/ (14 files in 2 dirs): add application lua kernel and game launcher lua wrapper object http://git.io/nZUzug
20141110 02:32:06< irker465> wesnoth: Chris Beck wesnoth:master 4164a24a59b7 / src/ (7 files): take cmdline arg for lua scripts to execute at application start http://git.io/gcM2bQ
20141110 02:32:08< irker465> wesnoth: Chris Beck wesnoth:master 3193a67ce9cd / src/ (commandline_options.cpp commandline_options.hpp game_launcher.cpp): add option to allow "unsafe" lua scripts, with "package" package http://git.io/rIdeZA
20141110 02:32:10< irker465> wesnoth: Chris Beck wesnoth:master ca62a8f7bfa8 / src/ (35 files in 5 dirs): Merge pull request #330 from cbeck88/new_lua_kernel_i http://git.io/NHU46w
20141110 02:34:41< mattsc> iceiceice: I assume this ^ contains new files?
20141110 02:34:48< iceiceice> yes
20141110 02:35:00< mattsc> okay, I’ll update the Xcode project file sometime
20141110 02:35:02< iceiceice> basically it splits the lua kernel into like 4 files, and adds two new
20141110 02:35:16< iceiceice> ok, thank you
20141110 02:35:24< mattsc> sorry, I’m super busy this weekend and I will be traveling the next 5 days, so I’m having a hard time keeping up with things ...
20141110 02:37:02< irker465> wesnoth: Roland Hautz wesnoth:master 37d63fd9ec66 / src/CMakeLists.txt: link game to boost-random and png libraries http://git.io/gLvd-w
20141110 02:37:04< irker465> wesnoth: Roland Hautz wesnoth:master 52b34a09333c / src/CMakeLists.txt: Catched more unsatisfied boost references http://git.io/_5ZJIA
20141110 02:37:06< irker465> wesnoth: Roland Hautz wesnoth:master 1ae031482d81 / data/core/about.cfg: Added myself to Misc. Contributors http://git.io/HA_GAg
20141110 02:48:16-!- gfgtdf [~chatzilla@f054149218.adsl.alicedsl.de] has joined #wesnoth-dev
20141110 02:49:04< gfgtdf> iceiceice: we have now 2 lua kernels that might un at teh same time ?
20141110 02:49:37< gfgtdf> iceiceice: we still have one of this object: https://github.com/wesnoth/wesnoth/blob/master/src/lua_jailbreak_exception.cpp#L20
20141110 02:49:47< iceiceice> gfgtdf: i don't want for that to happen,
20141110 02:49:54< iceiceice> i think i have to reengineer a little bit,
20141110 02:50:02< gfgtdf> iceiceice: ashouldnt we have one for each lukernel ?
20141110 02:50:08< iceiceice> my plan is that the scripting should be based on requests
20141110 02:50:34< iceiceice> so in game lua kernel actually calls C++ functions, but i think the "scripts" i want to support only generate a list of requests
20141110 02:50:41< iceiceice> and then when the script ends the game decides what to do
20141110 02:51:01< gfgtdf> iceiceice: i really think with the introduction of multiple lua kernels we shodul try to get rid of all static variables regarding lua.
20141110 02:51:27< iceiceice> which ones do you mean?
20141110 02:51:28< gfgtdf> iceiceice: and make them members of lua_kernel(-base) instead
20141110 02:51:39< gfgtdf> iceiceice: the oen i posted a link eariler for example
20141110 02:51:42< gfgtdf> one*
20141110 02:51:58< iceiceice> yeah, it would be safer
20141110 02:52:57< iceiceice> maybe lua jailbreak exception should be a template 
20141110 02:53:22< iceiceice> gfgtdf: is it possible right now that the current lua kernel can call itself?
20141110 02:53:40< iceiceice> because probably the current arrangement is broken in that case also
20141110 02:53:56< gfgtdf> iceiceice: what do you mean by callign itself?
20141110 02:54:06< iceiceice> like a lua function makes an api request
20141110 02:54:13< iceiceice> and the api request results in lua being executed again
20141110 02:54:28< iceiceice> before the first request is returned
20141110 02:54:48< gfgtdf> iceiceice: y thats possible
20141110 02:54:52< iceiceice> :/
20141110 02:55:13< gfgtdf> iceiceice: maybe we shoudl add a pointer to teh assiciated lua_kernel_base in teh teh lua_State.
20141110 02:55:58< iceiceice> gfgtdf: i forget now what exactly the purpose of the jailbreak exception is, like what limitation it is meant to overcome
20141110 02:56:21< iceiceice> is it possible that lua 5.2.3 is improved in someway that we don't need it?
20141110 02:56:55< gfgtdf> iceiceice: i dont think so
20141110 02:57:39< iceiceice> the original commit of jailbreak is this:
20141110 02:57:39< iceiceice> https://github.com/wesnoth/wesnoth/commit/d6512a0ef5e2b9a30f00bbd0db20a3d9e61750ac
20141110 02:57:51< iceiceice> so that lua is "exception safe"
20141110 02:58:09< iceiceice> but i thought the entire point of adding lua to the source tree and not using a lua lib at runtime, is to make it exceptions afe
20141110 03:04:43< gfgtdf> iceiceice: so why is that stange ? we add it to thesource tree to be able to change it into beeing excpetion safe.
20141110 03:05:00< iceiceice> so why do we still need jailbreak exception if now it's safe?
20141110 03:05:28< iceiceice> gfgtdf: i'm reading an email here now, i think the answer is that, it's not really safe by doing that
20141110 03:05:28< iceiceice> http://lua-users.org/lists/lua-l/2007-10/msg00473.html
20141110 03:09:51-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20141110 03:10:01-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20141110 03:10:02-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141110 03:10:08-!- Ivanovic_ [~ivanovic@frnk-5f751d66.pool.mediaWays.net] has joined #wesnoth-dev
20141110 03:10:08-!- Ivanovic_ [~ivanovic@frnk-5f751d66.pool.mediaWays.net] has quit [Changing host]
20141110 03:10:08-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20141110 03:10:54< iceiceice> gfgtdf: i think it means that, if you want to fix this bug: https://gna.org/bugs/?22173
20141110 03:11:13< iceiceice> then either "game_end_exception' should be a lua jail break
20141110 03:11:21< iceiceice> (and then it will be buggy if lua calls itself)
20141110 03:11:22< noy> sigh… the khalifate thread depresses me
20141110 03:11:27< gfgtdf> iceiceice: that bug is unrelated to excpetions
20141110 03:11:37< iceiceice> gfgtdf: i know you said that before,
20141110 03:11:48< iceiceice> but now i'm convinced that it shouldn't work
20141110 03:11:57< iceiceice> because lua has to swallow the game end exception
20141110 03:12:46< iceiceice> oh it does derive from lua jailbreak :/
20141110 03:12:47< gfgtdf> iceiceice: actualy i think i'll code this bug, what i really wanted was https://gna.org/bugs/?22635
20141110 03:12:47< iceiceice> i see
20141110 03:12:57< gfgtdf> close*
20141110 03:14:08-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 255 seconds]
20141110 03:14:27< iceiceice> gfgtdf: i think i want to get rid of end_level_exception and end_turn_exception entirely
20141110 03:15:28< gfgtdf> iceiceice: i cosed the bug
20141110 03:15:32< gfgtdf> closed*
20141110 03:16:08-!- Ivanovic_ is now known as Ivanovic
20141110 03:17:38< gfgtdf> iceiceice: why you want that ?
20141110 03:18:09< iceiceice> because i think it's unnecessarily complicated
20141110 03:18:37< gfgtdf> iceiceice: i cannot see that that is more complicated than teh alternatives
20141110 03:18:48< iceiceice> im not convinced that lua jailbreak actually works
20141110 03:18:56< iceiceice> in the complicated cases
20141110 03:19:03< iceiceice> and it will be hell to debug
20141110 03:19:51< iceiceice> i want to add new lua kernels now, i dont want to get stabbed in the ass by exception issues
20141110 03:20:01< iceiceice> so in general i think the game should only be throwing exceptions when there's actually a problem
20141110 03:20:06< iceiceice> and mostly not over the lua boundary
20141110 03:20:48< iceiceice> also it will fix any other possible bug that we haven't discovered,
20141110 03:20:51< gfgtdf> iceiceice: hmm our lua exception code works by ) 1: when lua calls c++ function we catch ll exceptiosn and store them in that variable, 2) after c++ code called lua function (pinvoke) we read that variable and throw the exception in there if there is one
20141110 03:20:54< iceiceice> where some destructor somewhere is thorwing an exception
20141110 03:21:24-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev
20141110 03:21:30< gfgtdf> iceiceice: the bug is that teh destructor is thoowing an exception, not in the game_eng_exception.
20141110 03:21:42< gfgtdf> iceiceice: and yes i still have that destructor on my todo list
20141110 03:22:03< gfgtdf> s/ll/all
20141110 03:22:22< iceiceice> gfgtdf: yeah thats true, the destructor throw is the problem, but at least it won't crash in that case
20141110 03:22:43< iceiceice> there are a lot of different RAII in the code
20141110 03:22:55< iceiceice> it's hard to make sure they never thorw
20141110 03:22:59< iceiceice> *never throw
20141110 03:23:02< gfgtdf> iceiceice: no even if you rmvoe the game_end exception it wil still crash on every other exception that might be thrown there
20141110 03:23:30< iceiceice> yeah but 99% of exceptions that we throw are end_level and end_turn
20141110 03:23:40< iceiceice> because we do that in normal operation
20141110 03:24:02< iceiceice> if we get rid of those it's obv going to reduce the number of actual exception crashes we observe
20141110 03:24:23< irker465> wesnoth: mattsc wesnoth:master cb284f45a73e / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project file with Lua kernel changes http://git.io/fp3nrg
20141110 03:24:24< gfgtdf> iceiceice: actualy i only pbjserved one exception crash while developing wesnoth.
20141110 03:24:28< gfgtdf> observed
20141110 03:25:17< iceiceice> i'm sure it happens more than we realize
20141110 03:26:43< iceiceice> gfgtdf: " 2) after c++ code called lua function (pinvoke) we read that variable and throw the exception in there if there is one"
20141110 03:27:02< iceiceice> do you think this means that it works correctly even if we are reentering lua?
20141110 03:27:37< iceiceice> gfgtdf: do you know how our lua error handler works?
20141110 03:27:59< iceiceice> is it possible that that thing can call c++ code?
20141110 03:32:16-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection]
20141110 03:32:35< gfgtdf> iceiceice: why shouldnt it wokr when reentering lua ?
20141110 03:33:05-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141110 03:33:38< gfgtdf> iceiceice: lau doesn call teh error handlign code i think it more liek we call pcall and pcall returns ERROR or somethign liek that we we got a lua error.
20141110 03:34:34< iceiceice> gfgtdf: i think actually, we have a custom error handler, stored in registry with executeKey
20141110 03:34:52< gfgtdf> iceiceice:  :o let me chack that
20141110 03:34:54< iceiceice> in first 5 lines of luaW_pcall (lua_api.cpp) that's where we push it onto the stack before pcall
20141110 03:35:11< iceiceice> but if you look at where it's defined, i think it's actually just "debug" lib backtrace function
20141110 03:35:16< iceiceice> so i guess it doesn't call any C++
20141110 03:36:34< iceiceice> gfgtdf: i think this is where it is defined: https://github.com/wesnoth/wesnoth/blob/master/src/scripting/game_lua_kernel.cpp#L3720
20141110 03:39:09< gfgtdf> iceiceice: y
20141110 03:42:14< gfgtdf> iceiceice: what i wanted to say before: maybe we could use LUAI_EXTRASPACE to store a pointer to teh lua_kernel_base in the Lua_State and then have 1 "c++ exception sotrage" per lua kernel/thread.
20141110 03:44:42< gfgtdf> iceiceice: so you know whethe its possible to assign c++ marcos ? like #define MYMARCO (MYMARCO + 1) ?
20141110 03:45:07< iceiceice> gfgtdf: i think that is possible
20141110 03:45:17< iceiceice> maybe the lua extraspace is a good idea also
20141110 03:46:18< gfgtdf> iceiceice: ok i need to go to bed now
20141110 03:46:20-!- gfgtdf [~chatzilla@f054149218.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 33.0.3/20141105223254]]
20141110 03:52:13< iceiceice> shadowm: i guess probably we should remove the stuff here? https://github.com/wesnoth/wesnoth/commit/43cd9b867beb1a077153e866352f900a3b2a209e
20141110 03:52:44< shadowm> What does that do?
20141110 03:55:28< shadowm> Marcos, huh.
20141110 03:56:08-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev
20141110 03:56:13< shadowm> #define B (A + 1) gives you literally A + 1, not the result of that.
20141110 03:56:44< shadowm> That's in fact one of the main arguments proposed by anti-preprocessor fundamentalists.
20141110 03:58:16< shadowm> iceiceice: I guess, but I'm not going to spend any energy on documenting the implications for UMC.
20141110 03:59:02< shadowm> There are also a handful of C API wrappers controlled by that symbol, hopefully we no longer rely on that.
20141110 03:59:17< iceiceice> shadowm: maybe we should just leave the compat all stuff on for 1.12
20141110 03:59:22< iceiceice> and remove now for 1.13
20141110 03:59:34< shadowm> Why would you even *consider* removing it in 1.12?
20141110 03:59:35< iceiceice> i guess crab thought it should go in 1.11.2 but who new
20141110 03:59:43< iceiceice> well because he thought it should be removed
20141110 03:59:58< iceiceice> and we have no idea what it actually does i think
20141110 04:00:13< shadowm> He proposed removing them in an alpha release. We are now at the end of the RC stage.
20141110 04:00:28< iceiceice> right, that's why i'm saying probably we should leave it
20141110 04:01:50 * shadowm hopes he won't wind up maintaining Lua as well.
20141110 04:02:38< shadowm> It'd be the second formerly Crab-maintained thing I take over for lack of a better substitute.
20141110 04:30:09< mattsc> what’s the other?
20141110 04:35:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 265 seconds]
20141110 04:35:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141110 04:35:39< iceiceice> noy: for what it's worth i also find this thread pretty annoying
20141110 04:36:08< noy> hm
20141110 04:42:14< shadowm> mattsc: MediaWiki.
20141110 04:44:03< irker465> wesnoth: Chris Beck wesnoth:master d05f5392ceb8 / changelog: update changelog http://git.io/GQ8i9Q
20141110 04:54:43< mattsc> shadowm: ah.  Do you want to take over the AI as well?  ;)
20141110 04:57:24< shadowm> The AI is smarter than me, so I'm pretty sure that'd be a bad idea.
20141110 05:07:21-!- Sulfur [~Miranda@p5B008D16.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141110 05:35:53-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Quit: im gonna go; later all.]
20141110 05:49:54-!- zookeeper [zookeeper@37.35.24.98] has joined #wesnoth-dev
20141110 05:50:01-!- zookeeper [zookeeper@37.35.24.98] has quit [Changing host]
20141110 05:50:01-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141110 05:53:58-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20141110 06:00:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141110 06:08:09< mattsc> O well, I tried ...
20141110 06:09:37-!- Sulfur [~Miranda@p5B008D16.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141110 06:09:46< vultraz> inb4 wesnoth mai becomes Skynet
20141110 06:14:25< zookeeper> well, turn-based skynet sounds better than real-time skynet
20141110 06:16:09< mattsc> unfortunately, we’re already behind schedule on that one ...
20141110 06:16:32< mattsc> but then, those dates are notorioulsy unreliable
20141110 06:18:44-!- mattsc is now known as skynet
20141110 06:19:14-!- skynet is now known as Guest32007
20141110 06:20:29< Guest32007> I am now known as 2^5 + 007 — that must have some meaning
20141110 06:21:10< Guest32007> and on that thought, good night
20141110 06:22:34-!- cib0 [~cib@p508BCC4D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141110 06:22:51-!- Guest32007 [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20141110 06:31:04-!- cib0 [~cib@p508BCC4D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141110 06:34:17-!- cib0 [~cib@p508BCC4D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141110 07:38:01-!- vultraz [~chatzilla@124.109.10.167] has quit [Remote host closed the connection]
20141110 07:39:02-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20141110 07:46:50-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: End Transmission.]
20141110 07:53:01-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141110 08:25:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141110 08:31:51-!- cib0 [~cib@p508BCC4D.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20141110 08:42:48-!- sachith500 [~kvirc@112.135.39.233] has joined #wesnoth-dev
20141110 09:03:26-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds]
20141110 09:14:20-!- sachith500|2 [~kvirc@112.135.210.147] has joined #wesnoth-dev
20141110 09:16:52-!- sachith500 [~kvirc@112.135.39.233] has quit [Ping timeout: 244 seconds]
20141110 09:35:57-!- cib0 [~cib@132.231.178.139] has joined #wesnoth-dev
20141110 09:46:51-!- markus_ [~mjs-de@f048014023.adsl.alicedsl.de] has joined #wesnoth-dev
20141110 09:57:16-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20141110 10:00:24-!- markus_ is now known as mjs-de
20141110 10:27:07-!- cib0 [~cib@132.231.178.139] has quit [Ping timeout: 250 seconds]
20141110 10:37:48-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20141110 11:07:34-!- irker465 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20141110 11:14:10-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has joined #wesnoth-dev
20141110 11:15:25< Dugi> Hello.
20141110 11:23:12-!- Anakonda [Anakonda@87-92-202-225.bb.dnainternet.fi] has joined #wesnoth-dev
20141110 11:26:16-!- duncan_shriek [~roland@2a01:1e8:e100:8618::24] has joined #wesnoth-dev
20141110 11:36:09< lipkab> Hi.
20141110 11:37:26-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141110 11:46:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 12:00:14-!- sachith500|2 [~kvirc@112.135.210.147] has quit [Read error: Connection reset by peer]
20141110 12:00:31-!- sachith500|2 [~kvirc@112.135.210.147] has joined #wesnoth-dev
20141110 12:03:05-!- sachith500|2 [~kvirc@112.135.210.147] has quit [Read error: Connection reset by peer]
20141110 12:07:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141110 12:08:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 12:14:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141110 12:19:38-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20141110 12:20:37-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has quit [Ping timeout: 246 seconds]
20141110 12:23:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 12:47:38-!- Coffee_irc [~david@ppp118-210-90-49.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20141110 13:05:08-!- sachith500|2 [~kvirc@112.135.210.147] has joined #wesnoth-dev
20141110 13:12:37-!- cib0 [~cib@132.231.178.19] has joined #wesnoth-dev
20141110 13:20:27-!- cib0 [~cib@132.231.178.19] has quit [Ping timeout: 250 seconds]
20141110 13:40:54-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20141110 13:43:18-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20141110 13:54:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20141110 13:55:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 13:55:52-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20141110 13:56:16-!- fabi [~quassel@p20030051AA25B958AC4DB04B3D741FC7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141110 13:56:16-!- fabi [~quassel@p20030051AA25B958AC4DB04B3D741FC7.dip0.t-ipconnect.de] has quit [Changing host]
20141110 13:56:16-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20141110 13:56:24-!- sachith500|2 [~kvirc@112.135.210.147] has quit [Ping timeout: 256 seconds]
20141110 13:59:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20141110 14:33:01-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20141110 14:37:41-!- cib0 [~cib@132.231.178.36] has joined #wesnoth-dev
20141110 14:45:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141110 14:51:22-!- cib0 [~cib@132.231.178.36] has quit [Ping timeout: 256 seconds]
20141110 15:00:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141110 15:03:29-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Ping timeout: 265 seconds]
20141110 15:03:44-!- cib0 [~cib@132.231.178.73] has joined #wesnoth-dev
20141110 15:08:36-!- prkc [~prkc@BC06D7AE.dsl.pool.telekom.hu] has joined #wesnoth-dev
20141110 15:15:02-!- cib [~cib@132.231.178.209] has joined #wesnoth-dev
20141110 15:15:32-!- cib is now known as Guest90497
20141110 15:17:22-!- cib0 [~cib@132.231.178.73] has quit [Ping timeout: 245 seconds]
20141110 15:17:23-!- gfgtdf [~chatzilla@f054149218.adsl.alicedsl.de] has joined #wesnoth-dev
20141110 15:25:16< gfgtdf> iceiceice:why is https://github.com/wesnoth/wesnoth/commit/47e9a3d25d2bd80ec824799f7d1881558d388236 c++11 only ? does it use rvalue references or something that?
20141110 15:26:21< gfgtdf> iceiceice: also i think wesnoth.require, dofile and have_file should be in the kernel_base class?
20141110 15:26:28< gfgtdf> s/?/!
20141110 15:29:36< duncan_shriek> gfgtdf: It is not c++11 only, the #ifdef does have an #else branch
20141110 15:34:28< gfgtdf> duncan_shriek: the chnage is ony about c++11, sure the old c++03 code worksstill
20141110 15:34:32< gfgtdf> change*
20141110 15:40:11< duncan_shriek> gfgtdf: Ah, I see your point. So how else to start with c++11 code? If we wait for some c++11 branch, that will postpone it indefinitely IMHO
20141110 15:43:29-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141110 15:46:32< gfgtdf> duncan_shriek: just becasue its c++11 code  its not nessecary better than c++03code,and i such an if add defnitiely complication, 
20141110 15:47:40< gfgtdf> duncan_shriek: alsoeven if c++11 std:: doesnt support copy_if there might be a c++03 equivent in boost (if itdoesnt need c++11 features in the implementation)
20141110 15:49:28< gfgtdf> duncan_shriek: for example "boost::copy" together with "boost::adaptors::filtered" could be able to give the same functionality in 1 expression, and is not much more complicated
20141110 15:51:19< duncan_shriek> gfgtdf: you don't have to convince me, that c++11 is only marginally better. Yet the question of how to make the transition is interesting me. And I take it that you don't know an ansere either ;-)
20141110 15:59:10< gfgtdf> duncan_shriek: well i don't think there is anything to do to make a transition  to c++11. I think transition just means we say we require c++11 and thats it. It's ot like all the c++03code is suddenly breaks as soon as we use c++11.
20141110 16:08:46< duncan_shriek> gfgtdf: Ah, right. It could be done in one patch which sqashes all c++11 warnings.
20141110 16:16:42-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141110 16:17:03< iceiceice> gfgtdf: i committed that way because it wouldn't let me use std::copy_if in c++98
20141110 16:17:30< iceiceice> if you want to change it it doesn't bother me
20141110 16:18:28< iceiceice> i dont know this "adaptors::filtered" stuff, if you want to use that fine, but copy_if is at least quite easy to read
20141110 16:23:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 16:26:39< gfgtdf> iceiceice: hmm ok
20141110 16:27:17< iceiceice> gfgtdf: i'm trying to fix some stuff with the lua kernel base etc,
20141110 16:27:28< iceiceice> i realized that my pcall function pointer thing doesn't work right
20141110 16:27:28< gfgtdf> iceiceice: i think the wesnoth.dofile, require, have_file shoudl also be in teh base lua kernel, esecialy since the bring utf8 supportfor windows
20141110 16:27:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20141110 16:27:39< iceiceice> gfgtdf: yeah that sounds good
20141110 16:27:51< iceiceice> i think the error reporter should also be on all of them
20141110 16:27:59< iceiceice> since its just debug traceback
20141110 16:29:46< gfgtdf> iceiceice: y
20141110 16:35:04-!- Guest90497 [~cib@132.231.178.209] has quit [Ping timeout: 255 seconds]
20141110 16:35:14-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20141110 16:37:44-!- gfgtdf [~chatzilla@f054149218.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 33.0.3/20141105223254]]
20141110 16:40:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 16:49:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20141110 16:49:31-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 16:55:50-!- gfgtdf [~chatzilla@f054149218.adsl.alicedsl.de] has joined #wesnoth-dev
20141110 17:01:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141110 17:02:11-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 17:08:38-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20141110 17:16:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141110 17:20:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 17:39:42-!- prkc [~prkc@BC06D7AE.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20141110 17:40:21-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141110 17:44:52-!- cib0 [~cib@p508BCC4D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141110 17:54:35-!- cib0 [~cib@p508BCC4D.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
20141110 17:56:47-!- cib0 [~cib@p508BCC4D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141110 18:22:09-!- mjs-de [~mjs-de@f048014023.adsl.alicedsl.de] has quit [Remote host closed the connection]
20141110 18:24:46-!- Sulfur [~Miranda@p5B008D16.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141110 18:39:34-!- irker545 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20141110 18:39:34< irker545> wesnoth: gfgtdf wesnoth:master 2264e9961d82 / src/game_events/action_wml.cpp: add a comment http://git.io/i2WjHg
20141110 19:09:11-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Read error: Connection reset by peer]
20141110 19:09:45-!- TooLmaN_ [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20141110 19:20:30-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20141110 19:22:44< iceiceice> duncan_shriek: for what it's worth, i don't expect that we will transition to C++11 anytime soon
20141110 19:46:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141110 19:48:45-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has joined #wesnoth-dev
20141110 20:02:14< Dugi> shadowm: Hey, do you have time to check the code of my patch?
20141110 20:04:45-!- molgrum [~molgrum@212.85.89.43] has quit [Quit: Lämnar]
20141110 20:39:23-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20141110 20:40:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141110 20:41:44-!- TooLmaN_ [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20141110 20:52:56-!- Appleman1234 [~Appleman1@pool-173-74-87-52.dllstx.fios.verizon.net] has quit [Ping timeout: 265 seconds]
20141110 20:58:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141110 21:02:51< Dugi> seen shadowm
20141110 21:03:02< Dugi> wesbot: seen shadowm
20141110 21:03:16< Dugi> Where is wesbot?
20141110 21:08:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141110 21:10:36< iceiceice> wesbot is dead, long live wesbot
20141110 21:10:51< iceiceice> shikadibot: seen shadowm?
20141110 21:10:52< shikadibot> iceiceice: Queried user last spoke 16h 13m ago.  shadowm is currently here and on the channel ##shadowm.
20141110 21:17:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141110 21:18:16-!- Appleman1234 [~Appleman1@pool-108-19-22-104.dllstx.fios.verizon.net] has joined #wesnoth-dev
20141110 21:18:53-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20141110 21:20:22< Dugi> iceiceice: Thanks for info.
20141110 21:25:13-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20141110 21:25:39-!- Samual_ [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 245 seconds]
20141110 21:26:23< Sulfur> Will the khalifate be included in the Default era? Or will the separation between Default+Khalifate and Default era be kept?
20141110 21:27:27-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141110 21:27:59-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev
20141110 21:28:34< ancestral> And if it’s separate, will it change for 1.14?
20141110 21:28:57< iceiceice> i think it was discussed in an email like a year ago
20141110 21:29:24 * ancestral enters his time machine
20141110 21:29:26< iceiceice> iirc the plan is that Default+Khalifate is a mainlined era, and Default is also a mainline era
20141110 21:29:34< iceiceice> someone who actually knows, please correct me...
20141110 21:30:32< ancestral> I know balancing was a thing, I just didn’t know if it was still a thing
20141110 21:32:51-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20141110 21:34:22< shadowm> Dugi: I won't really have time this week, sorry; I have two non-trivial bugs to take care of before Saturday and also my own add-on, and then server setup work plus an announcement.
20141110 21:35:26< shadowm> Sulfur: The separation will be kept for as long as the maintainers feel it necessary with regards to the faction's balance versus the rest of Default. That coupled with maintenance version compatibility policies means it'll definitely remain the case for 1.12.x.
20141110 21:38:19< shadowm> Dugi: You can clean up the stuff I said before in the meantime, though. That is, dropping usage of the C anonymous struct idiom, making sure control blocks always use braces (if/else/do/while/for and macros that use them such as BOOST_FOREACH), making your code's use of spacing and indentation consistent with what was already there (we use `if(` instead of `if (`, no padding within parentheses, etc.), better usage of `const` to ...
20141110 21:38:25< shadowm> ... declare constness intent, etc.
20141110 21:41:42-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20141110 21:43:10< Sulfur> That sounds reasonable, shadowm, thanks for the clarification
20141110 21:44:22< Dugi> shadowm: Thanks for telling when you won't have time (I also assume that you will not have time to finish that add-on system refactoring that woudl complicate my own work).
20141110 21:45:01< shadowm> Probably not.
20141110 21:45:21< shadowm> I should warn you that I intend to take your PR to the mailing list once it's polished enough.
20141110 21:45:22< Dugi> shadowm: I dropped a grep to find where 'if (' is used and I found thousands of cases where it was present.
20141110 21:45:36< Dugi> shadowm: What is the mailing list?
20141110 21:45:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141110 21:47:06< shadowm> At the end of <http://wiki.wesnoth.org/Support>, wesnoth-dev.
20141110 21:47:49< Dugi> shadowm: I have already fixed all uses of anonymous structs in my code..
20141110 21:48:14< shadowm> IRC isn't exactly well-suited for making decisions like whether to merge this PR or not, so I intend to take it there to resume a previous discussion of an add-on review system.
20141110 21:48:49< Dugi> shadowm: I can't folliow that link.
20141110 21:49:25< shadowm> Oh, you can. You just need to tell your browser to ignore gna.org's bogus certificate.
20141110 22:02:38< Dugi> shadowm: No, I can't. It bashes me about a bad title and tells me to visit main page. I know that gna has quite a bad certificate, but this isn't the case. You actually haven't sent me a link to gna.org at all.
20141110 22:03:12< Dugi> shadowm: By the way, can be the starting bracket of an if/for/else/whatever tag at the same line as the if/for/else/whatever?
20141110 22:04:30< shadowm> Dugi: http://wiki.wesnoth.org/Support
20141110 22:04:57< shadowm> The wesnoth-dev link is at the end, and I guess webchat's URL parsing doesn't exclude brackets around URLs.
20141110 22:05:54< Dugi> shadowm: The link contained the > at the end for some reasons, trying to open a page named Support> which didn't exist.
20141110 22:06:04< Dugi> shadowm: Got what you meant by it.
20141110 22:06:12< Dugi> shadowm: By the way, can be the starting bracket of an if/for/else/whatever tag at the same line as the if/for/else/whatever?
20141110 22:07:22< shadowm> I already read that, no need to repeat yourself. :p
20141110 22:08:08< Dugi> shadowm: I assumed that you forgot about it.
20141110 22:08:20< shadowm> Dugi: That's the norm, as you can (again...) see by reading campaignd's source before your changes.
20141110 22:08:26< shadowm> Dugi: No, I did not. I'm multitasking.
20141110 22:10:25< Dugi> shadowm: You could have just replied, it would save time.
20141110 22:11:21< shadowm> ...
20141110 22:12:24-!- Sulfur [~Miranda@p5B008D16.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141110 22:15:53< iceiceice> gfgtdf: i might try to merge this later today: https://github.com/wesnoth/wesnoth/pull/331
20141110 22:16:23< iceiceice> it should make file stuff and others available in the lua kernel base, and also to the map gen
20141110 22:16:37-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has quit [Quit: Ping timeout: 1337 seconds]
20141110 22:17:17< Dugi> shadowm: What did you mean with no padding between parentheses?
20141110 22:18:00< shadowm> That our style is `if(foo)` rather than `if( foo )`.
20141110 22:18:09< shadowm> Same goes for function calls, etc.
20141110 22:18:55< Dugi> shadowm: I don't use that style of writing.
20141110 22:23:01< shadowm> And regarding `if (` versus `if(`, the latter is what I use, what GUI2 uses, and what a large amount of code uses.
20141110 22:23:26< shadowm> So I don't care if a handful of people have been doing it wrong, new code should use the latter.
20141110 22:23:43< shadowm> Especially if the target file consistently uses that.
20141110 22:24:55< iceiceice> Dugi: there's a special program mordante uses to enforce such styles
20141110 22:25:08< shadowm> server::recalculate_campaign_ratings() gets its argument by value, is this intended?
20141110 22:25:09< iceiceice> its configuration file is in the tree somewhere, also it's referred to by email
20141110 22:25:14< iceiceice> i have to go bb
20141110 22:25:16-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141110 22:25:45< shadowm> Most of the time, unless you have a very good reason, you should get non-POD types like that by (const if read-only) reference.
20141110 22:26:50< shadowm> Also, please, do use 'add-on' instead of 'campaign' in new code.
20141110 22:27:16-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has joined #wesnoth-dev
20141110 22:27:50< shadowm> Unless, again, you have a very good reason to use the latter (either when handling add-ons that can only be campaigns, or interacting with code using the legacy term).
20141110 22:28:35< shadowm> Also, regarding spacing, use `foo(bar, baz, bat)` instead of `foo(bar,baz,bat)`.
20141110 22:31:15< shadowm> Also note than in GUI2 there's a very specific convention for choosing whether to have a static function called execute() or display(). Check the Doxygen documentation for gui2::tdialog in src/gui/dialogs/dialog.hpp.
20141110 22:33:59< shadowm>     float years_it_exists = (time(NULL) - cfg["original_timestamp"].to_int()) / (365.3 * 24.0 * 600.0);
20141110 22:34:13< shadowm> :\
20141110 22:34:46< shadowm> Surely there's a standard library function with better precision that that you could've used instead?
20141110 22:34:54< fabi> hello
20141110 22:35:38< shadowm>     rating += 25 * (1.0 - pow(2.0,(downloads_per_year / -300.0 )));
20141110 22:36:07< shadowm> Dugi: There you have an example of unwanted padding.
20141110 22:37:09< shadowm> What is the point of src/addon/info.cpp:150?
20141110 22:38:38< shadowm> Why is the rating decided client-side?
20141110 22:38:57< shadowm> I mean score.
20141110 22:39:04< shadowm> Probably.
20141110 22:40:35< shadowm> Also, opening braces should be below function/method names, not on the same line.
20141110 22:40:55< shadowm> Once again, the context dictates the style.
20141110 22:41:52< shadowm> Do *not* cram multiple statements into the same line. (`for ( ; i < reviews_liked_string.size(); i++) if (reviews_liked_string[i] == 44) break;` must be seven lines including braces.)
20141110 22:42:19< shadowm> That's in src/addon/info.hpp:67.
20141110 22:42:58< shadowm> Also, unless you have a *very* good performance-related reason for it, long methods or constructors should not be inline.
20141110 22:44:09< shadowm> (You usually do not want to bother with micro-optimizations like that for code that isn't executed a million times in a loop.)
20141110 22:44:52< shadowm> I see code taking pointers and dereferencing them without making sure they aren't null.
20141110 22:45:16< shadowm> src/gui/dialogs/addon/reviews_list.cpp:187, for example. Not sure how widespread this is.
20141110 22:46:28< shadowm> Instead of calling preferences::get_prefs() all over the place you should establish a clear protocol for the preferences you introduce and publish it via one of the *preferences.hpp files.
20141110 22:46:49< shadowm> preferences.hpp again has a function that takes a non-POD by value.
20141110 22:47:36< shadowm> Dugi: I think you'll want to take all this from the logs and save it to a file for reference.
20141110 22:47:54< shadowm> Now I'm done. I have work to do.
20141110 22:48:09-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer]
20141110 22:48:55-!- gfgtdf [~chatzilla@f054149218.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20141110 22:51:18-!- gfgtdf [~chatzilla@f054157244.adsl.alicedsl.de] has joined #wesnoth-dev
20141110 22:54:57-!- cib0 [~cib@p508BCC4D.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20141110 23:05:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141110 23:10:54< irker545> wesnoth: Fabian Müller wesnoth:1.12 6d96f19c6c0d / data/campaigns/Legend_of_Wesmere/maps/Lintanir.map: LoW 1+21: Added some more hill terrain to the map. http://git.io/-jmTqg
20141110 23:13:35< fabi> shadowm: I like to mess with the way how goto predefined pathes are handled. Do you know where to look at?
20141110 23:14:06< shadowm> fabi: What's a "goto predefined path"?
20141110 23:15:17< shadowm> And for that commit above (and LoW commits in general), hopefully you are taking care of syncing between 1.12 and master?
20141110 23:15:25< fabi> shadowm: Yeah, I don't know the exact word. Let's say you select a unit and send her somewhere she can't reach before 3 turns have gone. Then the destination is stored in $unit.goto_x and $unit.goto_y, right?
20141110 23:15:59< shadowm> Yes.
20141110 23:17:12< fabi> Okay, then I guess greping for goto_x will bring me to the right code section.
20141110 23:17:13-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20141110 23:17:35< shadowm> What exactly do you want to change about it, though?
20141110 23:18:27< fabi> Currently it happens at the begin of a turn. I have seen while playing another game that it is much better when it happens at the end.
20141110 23:19:04< shadowm> Oh man.
20141110 23:19:11< fabi> ?
20141110 23:19:51< shadowm> I'm just concerned that we've gone down the "this works for XYZ game so surely it'd work for wesnoth too" road before and it wasn't pretty.
20141110 23:21:03< fabi> Example?
20141110 23:21:53< shadowm> Mouse controls.
20141110 23:23:43-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20141110 23:23:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141110 23:23:55< gfgtdf> fabi: i personly think that the goto_x/y ways are not always optimial and i often have to finish them manualy after the beginning of my turn, this is especiay,  the case when i have multiple units that want to go through the same path, becasue the units doesn't choose an alternative path when thwir favourite path is blocked by own units.
20141110 23:24:02-!- Anakonda [Anakonda@87-92-202-225.bb.dnainternet.fi] has quit [Read error: Connection reset by peer]
20141110 23:24:22< fabi> shadowm: Well, I am not finished with the mouse controls...
20141110 23:24:31< gfgtdf> s/especiay,/especially
20141110 23:24:47< fabi> gfgtdf: Do you know what I want to change?
20141110 23:25:28< gfgtdf> fabi: if i underatdns correctly you want to make teh automoves for multi-turn-moves happen at teh end of teh turn
20141110 23:26:03< fabi> Yes, meaning that you can check them and react to changed game situations.
20141110 23:26:57< gfgtdf> fabi: hmm but the "changed game sutuations" are pofthe the othr automoves that happen beofer taht move
20141110 23:27:03< gfgtdf> often*
20141110 23:27:20< fabi> ?
20141110 23:38:16< gfgtdf> fabi: i somethimes have teh problme that if i have 2 units tha want to do automoves A -> B ->C  for unit 1 and  A* -> B -> C* for unit 2 unit 1 moves and blocks place B, and unit 2 then stops one filed before B. Often this is not opmilan since there is another equal-fast route for unit b. There is some code to prevent this i think but i still have do fx it manually sometimes.
20141110 23:38:37< gfgtdf> fabi: but i dont think its that important actually.
20141110 23:38:50-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141110 23:40:53< iceiceice> fabi: i actually agree with you, i think wesnoth's goto's are broken
20141110 23:41:05< iceiceice> there's no other way to explain why so many people want to turn them off
20141110 23:41:15< iceiceice> we had the checkbox in the load game dialog,
20141110 23:41:23< iceiceice> we now have a second checkbox for that in general preferences,
20141110 23:41:30< iceiceice> because lovcapone made it in response to a feature request
20141110 23:41:33< fabi> iceiceice: I do not use them as well. Just to dangerous. 
20141110 23:41:37< fabi> s/to/too
20141110 23:42:34< iceiceice> i think it might be worth an experiment to either add a second preerence for "execute gotos at end of turn", or just reappropraite lov capone's pref, as an experiment for 1.13
20141110 23:42:40< iceiceice> but,
20141110 23:42:55< iceiceice> people mgiht also want a hotkey i guess so they can then execute the gotos before end of turn?
20141110 23:43:04< iceiceice> i dont' really know i would have to play with it to see
20141110 23:43:23< fabi> iceiceice: Yes, that is why I implement it. Then you can see :-)
20141110 23:44:54< iceiceice> https://github.com/wesnoth/wesnoth/pull/260
20141110 23:45:31< iceiceice> fabi: that was the thing i merged
20141110 23:48:18< fabi> iceiceice: I see. Thank you for hinting this to me.
20141110 23:49:18< iceiceice> fabi: another thing to keep in mind i guess,
20141110 23:49:30< iceiceice> i think it might be that the AI uses the goto's also in some hacky manner
20141110 23:49:50< iceiceice> like, to preempt itself from making different decisions later
20141110 23:50:17< fabi> uh
20141110 23:50:20< fabi> sounds ugly
20141110 23:52:01< iceiceice> yeah... actually maybe i should have thought of this when i merged lovcapone's commit
20141110 23:52:06-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20141110 23:52:28< iceiceice> mattsc: am i making this up? do you know if the AI uses the "gotos" of units?
20141110 23:53:38< gfgtdf> i think wml case use goto_x/y to force unit to move to a ceration location
20141110 23:53:45< gfgtdf> ai
20141110 23:56:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141110 23:56:57< fabi> iceiceice: I just moved the execute_gotos() call around. So far it seems to work and the result is pretty much what I expected.
--- Log closed Tue Nov 11 00:00:08 2014