--- Log opened Tue Nov 25 00:00:24 2014
20141125 00:01:48< fabi> No, I do not like sarcasm very much. I meant what I wrote.
20141125 00:02:28< shadowm> And so did I.
20141125 00:05:38< irker298> wesnoth: Chris Beck wesnoth:master 1897cfed9f89 / src/scripting/lua_cpp_function.hpp: add comments: describe motivations and caveats of lua cpp function http://git.io/Bl6ZlQ
20141125 00:13:58-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141125 00:15:26< shadowm> loonycyborg: http://forums.wesnoth.org/viewtopic.php?p=578101#p578101
20141125 00:20:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141125 00:21:54< Dugi> Good night, it's too late.
20141125 00:22:03-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has quit []
20141125 00:23:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds]
20141125 00:25:38-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20141125 00:33:35-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 265 seconds]
20141125 00:35:08-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20141125 00:51:11< irker298> wesnoth: Chris Beck wesnoth:master e09a516935b8 / src/ (18 files in 4 dirs): replace resources::config_manager with game_config_manager::get() http://git.io/33teJQ
20141125 01:04:54< shadowm> Does anyone here by any chance know how to use [default_anim]?
20141125 01:09:30< shadowm> loonycyborg: So what do you think about the installer situation?
20141125 01:10:32< loonycyborg> I think it recognized part of NSIS as a virus
20141125 01:10:51< shadowm> I want this to be confirmed or ruled out ASAP because if it's indeed malware it's a pretty severe issue.
20141125 01:10:51< gfgtdf> shadowm: i dont
20141125 01:11:39< c74d> The download URL is still unsecured HTTP, I suppose?
20141125 01:11:40< shadowm> I'd hate it if tomorrow's headlines speak about Wesnoth distributing malware to its users.
20141125 01:11:57< loonycyborg> I didn't find any files mentioned in the article on that virus
20141125 01:12:14< shadowm> Pentarctagon says he extracted it with 7zip, though.
20141125 01:13:27< shadowm> I guess I'll download the whole thing after midnight to check if the file is there for me.
20141125 01:13:35< shadowm> *me as well.
20141125 01:17:57< c74d> If the download is being infected in transit, it might be selectively not-infected for people with the capability to analyze it for infection.
20141125 01:18:53< shadowm> Ugh. We have the sha1. Ask everyone involved to compute the sha1 of the download.
20141125 01:19:03< shadowm> Ask them for the sha512 isf yuo ou want.
20141125 01:19:50< shadowm> I for one verified that the sha1 matches
20141125 01:20:11< shadowm> Though I downloaded that on baldras, where I don't think I have the tools to extract the package contents.
20141125 01:23:08< gfgtdf> shadowm: i tried to download NSIS to check whether that file is also contained there but teh download page says it has a virus :S : http://sourceforge.net/projects/nsis/files/NSIS%202/2.46/nsis-2.46.zip/download
20141125 01:24:11< shadowm> loonycyborg: ^
20141125 01:24:28< shadowm> gfgtdf: Weirdly enough, the automatic download does still work for me.
20141125 01:24:50< shadowm> So, good job SF.net.
20141125 01:25:10< shadowm> And yes, it does say "This file contains a virus and the automatic download has been disabled." at the top for me too.
20141125 01:27:00< gfgtdf> shadowm: to me it didn't autmatichly download becasue i had javascript disabled
20141125 01:29:32< shadowm> From a cursory glance at the NSIS forums, this seems to be a common issue: http://forums.winamp.com/showthread.php?t=379692 http://forums.winamp.com/showthread.php?t=379822
20141125 01:29:51< shadowm> Also http://nsis.sourceforge.net/NSIS_False_Positives
20141125 01:33:56< irker298> wesnoth: Chris Beck wesnoth:master 217e4a024253 / src/ (5 files in 2 dirs): pass a reference to the play_controller to the game_lua_kernel http://git.io/3_TM8Q
20141125 01:43:10< irker298> wesnoth: Chris Beck wesnoth:master 67ac03b0e1f7 / src/ (play_controller.cpp play_controller.hpp scripting/game_lua_kernel.cpp): remove last resources:: links from game_lua_kernel http://git.io/FcL1pg
20141125 01:50:34< loonycyborg> shadowm: ah yes
20141125 01:50:42< loonycyborg> that's why I thought about NSIS
20141125 01:50:49< loonycyborg> in relation to viruses
20141125 02:05:28-!- gfgtdf [~chatzilla@f054135048.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20141125 02:05:30-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has quit [Remote host closed the connection]
20141125 02:06:55-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 258 seconds]
20141125 02:16:42-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20141125 02:16:43-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20141125 02:16:58< irker298> wesnoth: Chris Beck wesnoth:master b1be437b54d7 / src/scripting/ (game_lua_kernel.cpp game_lua_kernel.hpp): add "lua_chat" to replace chat_message in lua kernel http://git.io/Mbr4VA
20141125 02:38:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141125 02:40:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141125 02:43:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20141125 02:45:19< irker298> wesnoth: Chris Beck wesnoth:master 7e3b4aa1bfdc / src/ (8 files in 2 dirs): move config, vconfig, tstring and helper functions to lua_common http://git.io/rVXTNg
20141125 03:07:23-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20141125 03:09:12-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20141125 03:19:33< fabi> shadowm: Do you know how to use the gui2 tooltip?
20141125 03:20:11< shadowm> Yes, you add a tooltip= attribute to your widget with the contents.
20141125 03:21:52-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev
20141125 03:21:54-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Client Quit]
20141125 03:21:56< fabi> I want to use them directly.
20141125 03:25:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141125 03:25:06< shadowm> GUI2 isn't very well suited for applications other than the intended, in general, plus I believe unless you are running with --new-widgets/have a specific preprocessor symbol defined it uses the same code as GUI1 for tooltips.
20141125 03:25:22< shadowm> But yeah, I don't know. *shrug*
20141125 03:34:48-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20141125 03:34:49-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds]
20141125 03:34:58-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20141125 03:34:58-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141125 03:35:51< iceiceice> gfgtdf: do you know why we use lua_call here and not pcall? https://github.com/wesnoth/wesnoth/blob/master/src/scripting/lua_fileops.cpp#L126
20141125 03:36:32-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20141125 03:37:03< iceiceice> nm i guess it makes sense to menow
20141125 03:39:35-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev
20141125 03:50:44-!- Ivanovic_ [~ivanovic@frnk-5f74d240.pool.mediaWays.net] has joined #wesnoth-dev
20141125 03:53:56-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 244 seconds]
20141125 03:54:38-!- Ivanovic_ is now known as Ivanovic
20141125 03:59:43-!- Polsaker [~MRX@wikimedia/Polsaker] has joined #wesnoth-dev
20141125 03:59:54-!- Polsaker [~MRX@wikimedia/Polsaker] has left #wesnoth-dev ["Leaving"]
20141125 04:13:27-!- Sulfur [~Miranda@p5B327B2D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141125 04:14:53< irker298> wesnoth: Chris Beck wesnoth:master 99678ef29ad9 / src/scripting/ (lua_fileops.cpp lua_fileops.hpp lua_kernel_base.cpp lua_kernel_base.hpp): refactor lua file ops: use fileops::load, but use kernel pcall http://git.io/HOzqjw
20141125 04:15:28< iceiceice> gfgtdf: ^
20141125 04:18:22-!- gfgtdf [~chatzilla@e177119113.adsl.alicedsl.de] has joined #wesnoth-dev
20141125 04:18:52< gfgtdf> iceiceice: you rmoved teh try catch in require/dofile ?
20141125 04:18:54-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection]
20141125 04:18:55< gfgtdf> removed*
20141125 04:19:35< gfgtdf> iceiceice: ah no
20141125 04:20:08< iceiceice> i tried not to do make any substantive change except to use my protected call, if i got rid of try catch it was a mistake
20141125 04:20:26< iceiceice> and to make it so they use the same string loading code
20141125 04:22:26< gfgtdf> iceiceice: i i corrected my self already
20141125 04:22:32< gfgtdf> s/ i/y i
20141125 04:23:22< gfgtdf> iceiceice: i actualy dont reayl know what luaL_argerror does
20141125 04:25:26< iceiceice> i think it calls lua_error eventually
20141125 04:26:16< iceiceice> idk if it is necessary to put "return luaL_argerror"
20141125 04:26:20< iceiceice> i think maybe it isn't but i will just leave it
20141125 04:26:34< gfgtdf> iceiceice: the page says: "This function never returns"
20141125 04:26:50< iceiceice> y thats what i thought
20141125 04:26:55< gfgtdf> iceiceice: i wonder what it does then , especilly if its c code an usualy doesnt throw
20141125 04:27:32< iceiceice> gfgtdf: i think that either it does long jump or it throws some lua specific thing depending how it is set up
20141125 04:29:09< iceiceice> i have to go bb
20141125 04:29:10-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141125 04:29:15-!- gfgtdf [~chatzilla@e177119113.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 33.1/20141106120505]]
20141125 04:31:30-!- Sirp [~Sirp@u17402953.onlinehome-server.com] has joined #wesnoth-dev
20141125 04:35:53-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 240 seconds]
20141125 04:39:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20141125 04:43:14-!- SpoOkyMagician_ [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20141125 04:44:57-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Ping timeout: 240 seconds]
20141125 04:45:02-!- SpoOkyMagician_ is now known as SpoOkyMagician
20141125 04:47:49-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20141125 04:48:05-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141125 04:50:37-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Quit: bleh]
20141125 05:10:45-!- Madd_the_Sane [421da106@gateway/web/freenode/ip.66.29.161.6] has joined #wesnoth-dev
20141125 05:12:20< Madd_the_Sane> It seems like the frameworks for OS X weren't copied correctly.
20141125 05:17:08< Madd_the_Sane> May I post links here?
20141125 05:20:17< Madd_the_Sane> As it stands, many things that should have been symlinks to another location in the framework are referenced, are instead showing up as regular files/folders.
20141125 05:20:43< Madd_the_Sane> This can make the package larger than intended (although, admittedly, not by much).
20141125 05:23:45< Sirp> Madd_the_Sane: you can post links.
20141125 05:41:52-!- Madd_the_Sane [421da106@gateway/web/freenode/ip.66.29.161.6] has quit [Ping timeout: 246 seconds]
20141125 06:06:42-!- atomicbomb [~atomicbom@202.67.35.21] has joined #wesnoth-dev
20141125 06:07:17-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141125 06:11:54-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 250 seconds]
20141125 06:17:54-!- cib0 [~cib@p5DD222CE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141125 06:37:59< c74d> mattsc: ^
20141125 06:38:42-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141125 06:47:41< irker298> wesnoth: gfgtdf wesnoth:1.12 6994ef427ca5 / src/filesystem_boost.cpp: ignore files that begin with '.' http://git.io/uGaicw
20141125 06:47:43< irker298> wesnoth: Ignacio R. Morelle wesnoth:1.12 aeafa091cab6 / changelog: Changelog entry for previous commit http://git.io/CfNCaw
20141125 06:50:58-!- cib0 [~cib@p5DD222CE.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20141125 06:52:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20141125 06:54:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141125 06:56:00-!- Ivanovic [~ivanovic@frnk-5f74d240.pool.mediaWays.net] has quit [Changing host]
20141125 06:56:00-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20141125 06:58:23-!- Samual_ [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 240 seconds]
20141125 07:03:35< zookeeper> huh. i see an allied AI side's units' orbs and bars through fog and shroud, when the [side] tags say nothing about vision sharing.
20141125 07:05:01< zookeeper> after the first (full) turn, shroud got updated to include the AI side's vision as well. weird.
20141125 07:05:01-!- _8680_ [~8680@2002:4404:712c:0:e52c:dd07:5af2:bfaa] has quit [Ping timeout: 272 seconds]
20141125 07:05:44-!- _8680_ [~8680@2002:4404:712c:0:94b5:2eb1:4edf:772] has joined #wesnoth-dev
20141125 07:11:05-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20141125 07:42:05-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20141125 07:49:53-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20141125 07:56:19-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141125 07:58:38-!- mjs-de [~mjs-de@f048006223.adsl.alicedsl.de] has joined #wesnoth-dev
20141125 08:01:16-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 264 seconds]
20141125 08:04:21< Sirp> this page looks awesome. Are we going to make it or something like it the main Wesnoth front page? http://www.wesnoth.org/start/1.12/
20141125 08:05:48< shadowm> Sirp: My plan is to create a similar but not identical style for the rest of the site.
20141125 08:07:36< shadowm> Also thanks, vultraz and I spent like <maths> days working on that.
20141125 08:09:47< Sirp> ahh okay. It does look *awesome* :)
20141125 08:26:22-!- markus_ [~mjs-de@f048104022.adsl.alicedsl.de] has joined #wesnoth-dev
20141125 08:29:50-!- mjs-de [~mjs-de@f048006223.adsl.alicedsl.de] has quit [Ping timeout: 244 seconds]
20141125 08:30:21-!- atomicbomb [~atomicbom@202.67.35.21] has quit [Ping timeout: 244 seconds]
20141125 08:45:06-!- atomicbomb [~atomicbom@202.67.34.30] has joined #wesnoth-dev
20141125 08:45:53< zookeeper> shadowm, tried to start the editor: http://pastebin.com/bjiMkiWR
20141125 08:46:11< zookeeper> (i think i downloaded the add-on a few days ago)
20141125 08:46:22< shadowm> DId you read the 1.12.0 announcement?
20141125 08:46:36< shadowm> The forum post one, not the fancy press release.
20141125 08:47:16< zookeeper> not in detail, no :P
20141125 08:47:26< shadowm> The block you want is titled "Windows-specific post-release erratum for bug #22967".
20141125 08:47:37< zookeeper> i see
20141125 08:48:46-!- markus_ is now known as mjs-de
20141125 08:52:11-!- Sulfur [~Miranda@p5B327B2D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141125 08:53:53-!- atomicbomb [~atomicbom@202.67.34.30] has quit [Ping timeout: 264 seconds]
20141125 09:14:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141125 09:16:29-!- Sulfur [~Miranda@p5B327B2D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141125 09:23:26-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Ping timeout: 250 seconds]
20141125 09:37:53-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20141125 09:41:50-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20141125 09:45:03-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141125 09:49:17-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 240 seconds]
20141125 09:55:42-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Ping timeout: 265 seconds]
20141125 10:15:12-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20141125 10:22:32-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20141125 10:24:04-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Client Quit]
20141125 10:50:48-!- Anakonda [Anakonda@dsl-tkubrasgw1-54f9ba-178.dhcp.inet.fi] has joined #wesnoth-dev
20141125 11:00:57-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Ping timeout: 265 seconds]
20141125 11:03:35-!- Appleman1234 [~Appleman1@rrcs-97-79-164-178.sw.biz.rr.com] has quit [Remote host closed the connection]
20141125 11:05:15-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20141125 11:13:07< vultraz> Sirp: thanks a lot :)
20141125 11:13:49-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141125 11:16:31-!- Sulfur [~Miranda@p5B327B2D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141125 11:30:53-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20141125 11:34:22-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 256 seconds]
20141125 11:36:55-!- cib0 [~cib@132.231.178.91] has joined #wesnoth-dev
20141125 11:46:45-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20141125 12:01:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141125 12:08:04-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection]
20141125 12:10:39-!- Sulfur [~Miranda@p5B327B2D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141125 12:18:06-!- bumbadadabum [~bumbadada@wcw-stud-145-109-11-221.wireless.uva.nl] has joined #wesnoth-dev
20141125 12:20:52-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20141125 12:22:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141125 12:26:25-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20141125 13:02:45-!- bumbadadabum [~bumbadada@wcw-stud-145-109-11-221.wireless.uva.nl] has quit [Ping timeout: 265 seconds]
20141125 13:20:28-!- cib0 [~cib@132.231.178.91] has quit [Ping timeout: 250 seconds]
20141125 13:56:31-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141125 14:01:23-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 240 seconds]
20141125 14:04:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141125 14:09:04-!- Xudo [bce8b04a@gateway/web/freenode/ip.188.232.176.74] has joined #wesnoth-dev
20141125 14:14:00-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Quit: No Ping reply in 180 seconds.]
20141125 14:14:19-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141125 14:16:36< Ravana_> has anyone checked my hypothesis for the cause of some 1.12 mixed campaigns problems? http://forums.wesnoth.org/viewtopic.php?f=4&t=41252#p578084
20141125 14:17:08< mattsc> c74d: Thanks.  I think I know what Madd_the_Sane is talking about.
20141125 14:17:47< mattsc> It’s about the symlinks to different versions within frameworks.
20141125 14:18:37< mattsc> I just went through several releases and it did indeed change from symlinks to regular files when I took over making the packages.
20141125 14:18:59-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20141125 14:19:09< mattsc> I didn’t change anything in the project file at that time though, so it must be a general Xcode setting.  I’ll look into it.
20141125 14:21:11-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Read error: Connection reset by peer]
20141125 14:21:47-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141125 14:33:46< shadowm> "So maybe consider using a different OS"
20141125 14:33:58< shadowm> loonycyborg: They asked specifically about Windows binaries and that response isn't very nice.
20141125 14:38:08-!- iceiceice [~chris@192.16.204.74] has joined #wesnoth-dev
20141125 14:38:13-!- iceiceice [~chris@192.16.204.74] has quit [Changing host]
20141125 14:38:13-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141125 14:38:42< iceiceice> shadowm: fwiw i kind of agree wiht loonycyborg, it's wierd for them to complain to us about anti-virus
20141125 14:39:35< iceiceice> if someone sends me an email and it goes in my spam folder, i don't write them back "sorry, your email ended up in my spam folder, can you write it again differently and resend?"
20141125 14:39:39< shadowm> That's not the point. The point is that if I want to try out a game the last thing I want is a response from one of the developers suggesting I learn to use a completely different operating system to solve a punctual problem.
20141125 14:40:00< shadowm> *want to see
20141125 14:40:30< iceiceice> i think the :p indicated pretty clearly that he was just joking
20141125 14:41:29-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer]
20141125 14:41:34< shadowm> It's hard to tell whether whether a joke like that is about the line itself or the receiver.
20141125 14:42:20< shadowm> The "Windows sucks, use something else" advice is so stereotypical in OSS that it's easy to take it that way.
20141125 14:42:38< iceiceice> yeah i can see that, but in context it doesn't make that much sense...
20141125 14:42:55< iceiceice> i mean he's the windows packager, if he thought windows users were fools why wouldn't he just stop
20141125 14:43:15< iceiceice> anyways this is pretty meta now,
20141125 14:43:26< iceiceice> imo the real question in the thread is whether its really possible that there is a virus
20141125 14:44:06< shadowm> Impossible to tell until someone sends the installer and an envelope full of money to some company dedicated to analyzing this crap.
20141125 14:44:10< iceiceice> it seems reasonable to ask to update nsis and rerun it or something
20141125 14:44:29< shadowm> Ask whom?
20141125 14:44:36< iceiceice> loony
20141125 14:44:46< shadowm> Yes, if SF.net didn't flag NSIS itself as malware.
20141125 14:44:55< iceiceice> yeah i guess that's right
20141125 14:45:07< iceiceice> yeah i guess we should just tell people to complain on google forums
20141125 14:46:53< shadowm> The newer prerelease version isn't flagged, though.
20141125 14:47:59< shadowm> But I wouldn't know how many changes he'd need to make to whatever scripts he uses to adapt it to that, or whether there are obvious downsides to using a, well, prerelease version.
20141125 14:48:42< shadowm> Since it goes from 2.46 to 3.0 I'd guess the number of changes is non-negligible.
20141125 14:55:51-!- TooLmaN [~TooLmaN@mx1.thomsonplastics.com] has joined #wesnoth-dev
20141125 14:56:51< iceiceice> i dont understand why this is only an issue now, does it mean that no one who downloaded any of the RC's was using chrome?
20141125 14:57:10< iceiceice> that would be hard to believe...
20141125 14:58:48< loonycyborg> chrome uses a different logic it seems
20141125 14:58:56< loonycyborg> I don't think it's due to NSIS
20141125 14:59:15-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-djedfwkbmczhcjfa] has joined #wesnoth-dev
20141125 14:59:28< loonycyborg> Some people on stackoverflow said it automatically flags some files that weren't crawled yet
20141125 15:00:33< loonycyborg> But in any case I'm tired of NSIS and its annoying language.
20141125 15:00:40< loonycyborg> I'm considering switching to WiX
20141125 15:00:52< shadowm> All hail the new Google-branded IE.
20141125 15:01:27< iceiceice> maybe i should stop using chrome myself :(
20141125 15:01:32< Ravana_> I use chrome and none of wesnoths have showed such message, though I use dev version
20141125 15:01:32< iceiceice> its so much zippier than firefox though
20141125 15:01:47< iceiceice> or at least it was at the time that i decided to switch
20141125 15:01:54< shadowm> (Though there are two non-Microsoft IEs, actually. Chrome is the standards IE and Firefox is the bugs IE.)
20141125 15:02:24< iceiceice> firefox is also the "not evil" IE though i guess
20141125 15:02:31< iceiceice> :p
20141125 15:03:31< iceiceice> maybe we can make a torrent to distribute the windows installer and tell people to use that
20141125 15:05:32< shadowm> Firefox uses a Google-provided list of known malware distribution sites but I guess it doesn't go around checking download checksums against a file list like Chrome (or whatever it is Chrome does).
20141125 15:06:10< shadowm> Flagging whatever hasn't been crawled yet sounds pretty stupid and I really hope it's not the case, otherwise it raises a lot of questions.
20141125 15:07:18< shadowm> It's a massive jump from "this file isn't trustworthy!" to "this file is malicious!".
20141125 15:07:53< shadowm> "and I'm blocking it without giving you an immediately-visible option unblock it!"
20141125 15:09:42< iceiceice> shadowm: the "feature" is mentioned at the bottom here: https://code.google.com/p/chromium/issues/detail?id=365131
20141125 15:10:15< iceiceice> chrome developer (?): "the "uncommonly downloaded" warning will go away once the link to the software has been crawled, which shouldn't take long. i'll check on the other issues."
20141125 15:12:49< shadowm> iceiceice: That's a different warning.
20141125 15:13:00-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141125 15:13:19< shadowm> Compare the screenshots in comments #21 with #24 for that ticket (as well as Jozrael's in our 1.12.0 announcement topic).
20141125 15:13:47< iceiceice> yeah it's not the same as our woes, but it still fits the bill "sounds pretty stupid and I really hope it's not the case"
20141125 15:14:19< shadowm> #21 is ours.
20141125 15:14:26< shadowm> I mean, the warning.
20141125 15:15:39< shadowm> So as I said before, I'd greatly prefer #24 over #21.
20141125 15:16:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Computer's napping]
20141125 15:24:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141125 15:30:45-!- atomicbomb [~atomicbom@202.67.35.23] has joined #wesnoth-dev
20141125 15:36:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141125 15:37:33-!- Trademark [~trademark@2001:660:3004:64:7dc6:8114:709e:abd] has joined #wesnoth-dev
20141125 15:38:39< vultraz> I had no such issue downloading the exe
20141125 15:39:48-!- Trademark [~trademark@2001:660:3004:64:7dc6:8114:709e:abd] has left #wesnoth-dev []
20141125 15:40:15< vultraz> (using Chrome)
20141125 15:45:30-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141125 15:50:09-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 255 seconds]
20141125 16:02:37-!- molgrum_ [~molgrum@94.254.51.238] has joined #wesnoth-dev
20141125 16:04:33-!- molgrum [~molgrum@212.85.89.43] has quit [Ping timeout: 255 seconds]
20141125 16:08:44-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141125 16:13:33-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 255 seconds]
20141125 16:26:03-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20141125 16:30:23-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20141125 16:45:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141125 16:56:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20141125 16:58:05-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds]
20141125 16:59:02-!- irker298 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout]
20141125 16:59:53-!- shadowm_desktop [ignacio@190.91.82.163] has joined #wesnoth-dev
20141125 16:59:58-!- boucman [~rosen@2a02-8428-034f-f800-400f-ab58-d82f-bfd5.rev.sfr.net] has joined #wesnoth-dev
20141125 16:59:59-!- shadowm_desktop [ignacio@190.91.82.163] has quit [Changing host]
20141125 16:59:59-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20141125 16:59:59-!- boucman [~rosen@2a02-8428-034f-f800-400f-ab58-d82f-bfd5.rev.sfr.net] has quit [Changing host]
20141125 16:59:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141125 17:04:09-!- Sulfur [~Miranda@p5B327B2D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141125 17:04:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141125 17:12:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141125 17:12:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20141125 17:17:41-!- travis-ci [~travis-ci@ec2-54-80-120-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20141125 17:17:41< travis-ci> gfgtdf/wesnoth-old#387 (wesnothd_sides - 634ff56 : gfgtdf): The build has errored.
20141125 17:17:41< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/42096682
20141125 17:17:41-!- travis-ci [~travis-ci@ec2-54-80-120-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20141125 17:28:21-!- ptalbot [~trademark@m1589.ircam.fr] has joined #wesnoth-dev
20141125 17:32:40-!- ptalbot [~trademark@m1589.ircam.fr] has quit [Ping timeout: 258 seconds]
20141125 17:51:36-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141125 17:51:59-!- cib0 [~cib@p5DC74CB7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141125 17:52:40-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20141125 17:56:49-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141125 18:01:36-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Client Quit]
20141125 18:06:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 250 seconds]
20141125 18:07:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141125 18:09:35-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev
20141125 18:16:08-!- irker971 [~irker@fehu.ai0867.net] has joined #wesnoth-dev
20141125 18:16:08< irker971> wesnoth: gfgtdf wesnoth:master b75b7330de87 / src/ (play_controller.cpp play_controller.hpp synced_context.cpp): add "synced_context_id" http://git.io/Te_Shg
20141125 18:16:10< irker971> wesnoth: gfgtdf wesnoth:master 0087b5c44ea9 / src/server/ (game.cpp game.hpp): make server read "context_id" http://git.io/O_1GUg
20141125 18:16:12< irker971> wesnoth: gfgtdf wesnoth:master 9f7638e4e014 / src/ (synced_context.cpp synced_context.hpp): every client asks server for random seed. http://git.io/pDvW0w
20141125 18:16:14< irker971> wesnoth: gfgtdf wesnoth:master 00e51feb16c1 / src/ (play_controller.cpp play_controller.hpp server/game.cpp synced_context.cpp): count requests instead of synced contexts for require_random http://git.io/SRDG-Q
20141125 18:16:16< irker971> wesnoth: gfgtdf wesnoth:master b39531a1a16a / src/server/game.cpp: comment fix http://git.io/TFdyyw
20141125 18:16:18< irker971> wesnoth: gfgtdf wesnoth:master 324d4898deef / src/ (6 files in 2 dirs): Merge pull request #334 from gfgtdf/wesnothd_sides http://git.io/yM2iZQ
20141125 18:27:50-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20141125 18:36:02< irker971> wesnoth: gfgtdf wesnoth:master 90c94876b133 / src/ (playmp_controller.cpp replay.cpp): simplyfy mpsync http://git.io/4qUcAA
20141125 18:36:04< irker971> wesnoth: gfgtdf wesnoth:master 0c6d41127154 / src/server/game.cpp: add a comment http://git.io/_HeQNw
20141125 18:41:32-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141125 18:42:02< iceiceice> gfgtd: does this make sense to you?
20141125 18:42:02< iceiceice> https://github.com/cbeck88/wesnoth/commit/856f3acab730965b7849802c752f9f751b6fc1fe
20141125 18:43:21< iceiceice> gfgtdf: ^
20141125 18:44:03-!- travis-ci [~travis-ci@ec2-54-166-253-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20141125 18:44:03< travis-ci> cbeck88/wesnoth#3 (mp_connect_bool_test - 856f3ac : Chris Beck): The build passed.
20141125 18:44:03< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/42108177
20141125 18:44:03-!- travis-ci [~travis-ci@ec2-54-166-253-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20141125 18:44:52-!- cib0 [~cib@p5DC74CB7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141125 18:46:42< shadowm> Who the hell names a Wesnothian human "Zlex"?
20141125 18:46:44-!- cib0 [~cib@p5DC74CB7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141125 18:47:06-!- tomreyn [~tomreyn@61-197-28-81.ftth.cust.kwaoo.net] has joined #wesnoth-dev
20141125 18:50:32-!- gfgtdf [~chatzilla@e177184090.adsl.alicedsl.de] has joined #wesnoth-dev
20141125 18:51:13< gfgtdf> iceiceice: ye, it does another option would be adding is_bool/is_int ... methods to config::attribute_value
20141125 18:51:30< iceiceice> yeah that might be better
20141125 18:51:46-!- Dugi [93fbd29f@gateway/web/freenode/ip.147.251.210.159] has joined #wesnoth-dev
20141125 18:51:50< iceiceice> there's some other stuff like this that would be good, for instance i think config shoudl have a "has_child" method
20141125 18:52:00< iceiceice> since checking "config.child("foo")" throws an exception if foo is not present
20141125 18:52:10< gfgtdf> iceiceice: i think it has already a has child method ?
20141125 18:52:15< iceiceice> really?
20141125 18:52:19< iceiceice> maybe i missed
20141125 18:52:40< gfgtdf> iceiceice: also i donth think child throws an exception
20141125 18:53:05< gfgtdf> iceiceice: it more that child returns a config that throws an exception on evry operation taht you use on it
20141125 18:53:34< gfgtdf> iceiceice: that why we can use child like if (const config& a = cfg.child("a")) { do somethign with a}
20141125 18:53:48< iceiceice> i see... i think i didn't understand this
20141125 18:54:06< iceiceice> you are right that it has a "has_child"
20141125 18:54:39< gfgtdf> iceiceice: note that teh code about doesnt work without teh reference
20141125 18:55:11< gfgtdf> iceiceice: becasue teh copyconstructor will throw in case it has no such case
20141125 18:56:28< gfgtdf> iceiceice: e.g. "config a = cfg.child("a")" can throw.
20141125 18:56:55< gfgtdf> iceiceice: but not  "const config& a = cfg.child("a")"
20141125 19:05:16-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20141125 19:06:55< irker971> wesnoth: gfgtdf wesnoth:master c22151cbf17d / src/ (playmp_controller.cpp playturn.cpp playturn.hpp): simplyfy mpsync http://git.io/K_A_JA
20141125 19:06:58-!- stikonas_ is now known as stikonas
20141125 19:09:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141125 19:11:13< gfgtdf> iceiceice: do you know what these things in aasserts.hpp do ?
20141125 19:12:01< iceiceice> no i never looked in this file before
20141125 19:13:17< shadowm> They are assert() alternatives that someone introduced at one point without telling anyone and thus didn't enjoy widespread use afterwards..
20141125 19:13:22< iceiceice> it looks that ERROR_LOG( is used in gui2
20141125 19:13:41< shadowm> But I think that's pretty obvious.
20141125 19:14:16< gfgtdf> shadowm: you knwo what the advantage over those asserts compared to normal assert are?
20141125 19:14:46< shadowm> Some syntactic sugar and trapping into the debugger first where supported.
20141125 19:15:09< shadowm> (Or dying in the attempt if there is no debugger attached/the OS won't attach one on request.)
20141125 19:16:26< iceiceice> what does linux do/
20141125 19:16:33< iceiceice> will it launch gdb for me or just die
20141125 19:16:34< shadowm> Although I probably don't need to recite the preprocessor logic, the alternatives are:
20141125 19:16:58< shadowm> 1) MSVC++: Run __debugbreak() (no idea what this is, maybe it's the same thing used by the MSVC++ runtime assert()?)
20141125 19:17:19< shadowm> 2) Any other OS, AMD64/Intel64 or IA32: INT 3
20141125 19:17:32< shadowm> (CPU debugger trap)
20141125 19:17:50< shadowm> 3) Any other OS, none of the above: SIGTRAP to self
20141125 19:18:10< shadowm> 4) SIGTRAP not defined (i.e. not POSIX): libc abort()
20141125 19:19:49< shadowm> On AMD64/Intel64 or IA32 Linux you get option (2), which is handled by the kernel identically to SIGTRAP (in fact, the kernel will raise SIGTRAP for the running process)
20141125 19:20:25< shadowm> Aas with option (3), the process will break into the debugger iff there is a debugger attached, otherwise it will die with SIGTRAP.
20141125 19:20:41-!- Jetrel_ [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has joined #wesnoth-dev
20141125 19:21:01-!- Jetrel [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has quit [Read error: Connection reset by peer]
20141125 19:21:55< shadowm> If you choose to continue you'll hit the subsequent abort() anyway and die, unless you manipulate the execution state of the running thread and take it away from that block.
20141125 19:22:11-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141125 19:22:14< gfgtdf> shadowm: i just tested __debugbreak() and it indeed give me the option, at attach a debugger. an disadvantage of those custom asserts is still that those are statements and not expressions liek asert
20141125 19:22:54< gfgtdf> s/an/A
20141125 19:23:04< shadowm> I haven't seen anyone try to do something like if(assert(false)) and they probably shouldn't, so I don't see how that's a concrete disadvantage.
20141125 19:23:36< shadowm> Plus the implementation of assert() returns void both ways IIRC.
20141125 19:24:22< gfgtdf> shadowm: you can use things like "a = assert(b.has_value()), b.get_value()"
20141125 19:24:35< shadowm> And you shouldn't.
20141125 19:24:42< gfgtdf> shadowm: why?
20141125 19:24:44< shadowm> Really, really shouldn't.
20141125 19:24:52< shadowm> #define NDEBUG, break your code.
20141125 19:25:07< iceiceice> i thought we don't support ndebug
20141125 19:25:20< shadowm> Oh, that unwieldy comma operator. Why would you even do that.
20141125 19:25:26< iceiceice> i know i read a big spiel on the wiki about this
20141125 19:25:49< shadowm> We don't support NDEBUG here and there's an #error in global.hpp to that effect. I was speaking in general terms.
20141125 19:26:20< gfgtdf> shadowm: becasue you for example are in asituation where you cannot pu expression, for example in a initilizer list: a_(assert(b.has_value()), b.get_value())
20141125 19:26:42< shadowm> Ew.
20141125 19:26:49< gfgtdf> can't put stements*
20141125 19:26:55< gfgtdf> statements*
20141125 19:27:42< shadowm> I'd probably go outside and rethink the life choices that led me there if I was ever faced with such a situation.
20141125 19:28:27< iceiceice> what would you do if you were playing the game and you got a segfault at a line in some constructor?
20141125 19:29:36< iceiceice> if i had even known about the , thing i would perhaps consider committing that as a temporary "fixme"
20141125 19:31:20< iceiceice> is it possible to do something like (b.has_value() ? b.get_value : throw game::error("..."))
20141125 19:31:23< iceiceice> ?
20141125 19:31:32< iceiceice> or is that a type mismatch error
20141125 19:32:06< shadowm> Well, I don't have a problem with people being into operators with oblique semantics, but I'm not suddenly going to take a liking to them.
20141125 19:32:59< shadowm> IIRC you can throw from an expression like that and the return type becomes irrelevant since I don't think the question makes much sense if you are never going to return.
20141125 19:33:02< gfgtdf> iceiceice: i think that is possible
20141125 19:33:39< shadowm> I think I read about the ternary operator being recommended precisely for that reason.
20141125 19:37:39< gfgtdf> iceiceice: you knwo the exact difference between play_idle_loop, play_network_turn and play_human_turn ?
20141125 19:38:15< iceiceice> i don't remember anyhting about play_network_turn
20141125 19:38:41< iceiceice> play_idle_loop i made by copying play_human_turn and removing code
20141125 19:39:33< gfgtdf> iceiceice: why did we make adifferent method by removing code?
20141125 19:40:05< gfgtdf> iceiceice: anythign else than the timer ?
20141125 19:42:07< iceiceice> gfgtdf: the idle loop is what happens when a locally owned idle side takes control,
20141125 19:42:19< gfgtdf> iceiceice: y i know
20141125 19:42:22< iceiceice> there should not be any moves made and vision is not granted
20141125 19:42:27< iceiceice> so i had to delete the code that does that
20141125 19:42:30< iceiceice> including the gotos
20141125 19:42:40< iceiceice> i deleted the "check end level",
20141125 19:42:47< iceiceice> i don't remember exactly why
20141125 19:43:09< iceiceice> it shouldn't happen that the level can end while it is the idle sides turn
20141125 19:43:19< iceiceice> since not even the turn start events should fire i think...
20141125 19:43:30< iceiceice> i don't remember how it works anymore, it was a long time since i tested it
20141125 19:43:49< iceiceice> maybe the turn start / refresh events do fire
20141125 19:48:50-!- Xudo [bce8b04a@gateway/web/freenode/ip.188.232.176.74] has quit [Quit: Page closed]
20141125 19:48:59-!- travis-ci [~travis-ci@ec2-54-80-120-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20141125 19:48:59< travis-ci> wesnoth/wesnoth#4919 (master - 0c6d411 : gfgtdf): The build was broken.
20141125 19:48:59< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/42112406
20141125 19:48:59-!- travis-ci [~travis-ci@ec2-54-80-120-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20141125 19:49:36< iceiceice> gfgtdf: i guess the check_end_level is omitted because that function can make the objectives changed display, and that should only be displayed when a player is assigned
20141125 19:50:09< gfgtdf> iceiceice: hm i wondr whether should change it into making "idle/no_controller" a serverside thign and not temporary assign control to host.
20141125 19:50:27< gfgtdf> iceiceice: hm not now
20141125 19:51:18< gfgtdf> iceiceice: you know why end_turn_struct.redo is an int and no bool ?
20141125 19:51:38< iceiceice> i think redo is the team that should take control maybe
20141125 19:52:41< iceiceice> idk the whole system is really needlessly complicated imo,
20141125 19:52:55< iceiceice> there should be like one class that just keeps track of what the turn order is
20141125 19:53:04< gfgtdf> iceiceice: also there are different ways to invoke a "redo", sometimes we set player_type_changed_ manually to false and then throw the exception, and somethimes we thro the exceptionw thi a redo argument
20141125 19:53:10< iceiceice> and whose turn it should become if one side interupts their turn
20141125 19:53:28< gfgtdf> iceiceice: so i propose to remove teh second method
20141125 19:53:35< iceiceice> and the messages about "next turn" or "turn aborted / whatever"  should just be sent to that class
20141125 19:54:04< iceiceice> its wierd to pass this info inside of exceptions
20141125 19:54:17< gfgtdf> iceiceice: y
20141125 19:56:25-!- atomicbomb [~atomicbom@202.67.35.23] has quit [Ping timeout: 272 seconds]
20141125 19:57:17< gfgtdf> iceiceice: can the turn order ever change ?
20141125 19:57:31< iceiceice> no i dont think so
20141125 19:57:41< iceiceice> its an assumption of the server that it is fixed i tink
20141125 19:58:02< iceiceice> i made a feature request once that [end_turn] should be able to specify whose turn is next
20141125 19:58:41< iceiceice> you can work around it though, i made an add-on where this is achieved by events that issue [end_turn] when it
20141125 19:58:50< iceiceice> *when it is not the person's turn who i want to be next
20141125 19:59:01< iceiceice> it can take a few seconds due to network lag though
20141125 19:59:09< gfgtdf> iceiceice: i guess teh differenve is that teh side turn etc events are fired
20141125 19:59:40< gfgtdf> iceiceice: and unit get their healing ..
20141125 20:01:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141125 20:08:32-!- atomicbomb [~atomicbom@202.67.35.22] has joined #wesnoth-dev
20141125 20:13:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141125 20:16:03-!- atomicbomb [~atomicbom@202.67.35.22] has quit [Ping timeout: 272 seconds]
20141125 20:24:16-!- tomreyn [~tomreyn@61-197-28-81.ftth.cust.kwaoo.net] has quit [Ping timeout: 250 seconds]
20141125 20:31:20-!- travis-ci [~travis-ci@ec2-54-83-129-179.compute-1.amazonaws.com] has joined #wesnoth-dev
20141125 20:31:20< travis-ci> wesnoth/wesnoth#4920 (master - c22151c : gfgtdf): The build was broken.
20141125 20:31:20< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/42115687
20141125 20:31:20-!- travis-ci [~travis-ci@ec2-54-83-129-179.compute-1.amazonaws.com] has left #wesnoth-dev []
20141125 20:34:39< irker971> wesnoth: gfgtdf wesnoth:master 9768b623e5d7 / src/playmp_controller.cpp: fix unused variable warning http://git.io/aIvZZQ
20141125 20:39:03-!- cib0 [~cib@p5DC74CB7.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20141125 20:41:02-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Remote host closed the connection]
20141125 21:01:23< gfgtdf> iceiceice: you know whether teh NotsoEasy coding is onyl for fetures or also for fixes ?
20141125 21:01:36< iceiceice> i think i put fixes there also
20141125 21:01:54< iceiceice> nobody complained yet
20141125 21:04:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141125 21:05:43< gfgtdf> iceiceice: ok i'll put "Improve server wml processing - fix translatble string handling on simple_wml" there
20141125 21:05:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141125 21:15:13-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20141125 21:19:17-!- ancestral [~ancestral@63.92.240.233] has quit [Client Quit]
20141125 21:27:19-!- travis-ci [~travis-ci@ec2-54-83-129-179.compute-1.amazonaws.com] has joined #wesnoth-dev
20141125 21:27:19< travis-ci> wesnoth/wesnoth#4921 (master - 9768b62 : gfgtdf): The build has errored.
20141125 21:27:19< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/42123997
20141125 21:27:19-!- travis-ci [~travis-ci@ec2-54-83-129-179.compute-1.amazonaws.com] has left #wesnoth-dev []
20141125 21:38:59< gfgtdf> iceiceice: what is the point of the :idle [<side> [on/off] ] command ?
20141125 21:39:26< iceiceice> debugging
20141125 21:40:07< gfgtdf> iceiceice: so for stopping ai sides in sp mainly ?
20141125 21:40:43< iceiceice> sure
20141125 21:41:36< iceiceice> i think i tested that it works in mp also, if i am controlling two sides i can :idle one of them on and off, and it doesn't break the other clients
20141125 21:43:30< gfgtdf> iceiceice: when i do idle on off teh die becomes a human side
20141125 21:43:43< gfgtdf> tested in sp
20141125 21:43:54< iceiceice> y
20141125 21:44:20< iceiceice> err wait, do you mean that it is not working?
20141125 21:44:55< gfgtdf> iceiceice: also it doesn stop ai from doing moves
20141125 21:45:06< iceiceice> i think if you read what it actually does, idle on makes it local human and idle, and idle off changes an idle to local human
20141125 21:45:15< gfgtdf> iceiceice: it just maked that side "idle controlled" after its turn
20141125 21:45:26< iceiceice> yeah afaik you can't interrupt ai turns
20141125 21:45:35< gfgtdf> iceiceice: why shoudl i want to amke a local side idle ?
20141125 21:45:52< iceiceice> no reason, purely for debugging the idle feature
20141125 21:46:15< gfgtdf> iceiceice: so we can remove if when we know that teh idle featire works
20141125 21:46:23< iceiceice> sure if you like
20141125 21:46:49< gfgtdf> iceiceice: ok
20141125 21:51:44< gfgtdf> iceiceice: you what we do here: https://github.com/wesnoth/wesnoth/blob/master/src/menu_events.cpp#L3328 ?  e.g. why change_side_controller(side,player) is not enough?
20141125 21:52:59< iceiceice> no i don't know
20141125 21:54:17< iceiceice> https://github.com/wesnoth/wesnoth/commit/c8c2f453ea
20141125 21:54:23< iceiceice> apparently i tested it and found i needed to do this
20141125 21:55:24< iceiceice> gfgtdf: it could be just because of the way idle loop is written
20141125 21:55:42< gfgtdf> iceiceice: which loop ?
20141125 21:56:31< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L699
20141125 21:57:05< gfgtdf> iceiceice: or maybe it just becasue teh server doent allow [change_controler] to a side that already controlls that side forma  serve rpoint of view
20141125 21:58:50< iceiceice> ok i misunderstood you
20141125 21:58:56< iceiceice> i thought you were asking why throw exception
20141125 21:59:19< iceiceice> i think you are right about the change_controller, i think the server makes a message if you change controller to side that already controls
20141125 21:59:23< iceiceice> so i didn't want that
20141125 22:00:13< gfgtdf> iceiceice: i was asking about both
20141125 22:02:16-!- TooLmaN [~TooLmaN@mx1.thomsonplastics.com] has quit [Quit: Off to save the world!]
20141125 22:05:36-!- tomreyn [~tomreyn@61-197-28-81.ftth.cust.kwaoo.net] has joined #wesnoth-dev
20141125 22:16:08< gfgtdf> shadowm: you you please rebuidl teh server ?
20141125 22:17:11-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20141125 22:20:03-!- gfgtdf_ [~chatzilla@f054143122.adsl.alicedsl.de] has joined #wesnoth-dev
20141125 22:20:23< gfgtdf_> iceiceice: you know why  we do the change_controller(lexical_cast<std::string>(side_num),"human"); there ? shouldnt the side be alreay human controlled form the servers point of view ?
20141125 22:22:06-!- gfgtdf [~chatzilla@e177184090.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds]
20141125 22:22:13-!- gfgtdf_ is now known as gfgtdf
20141125 22:23:23< iceiceice> yeah it should be
20141125 22:23:49< iceiceice> gfgtdf: like i said i think, if i did this again i would do it differently,
20141125 22:24:04< iceiceice> i think ther should be a separate controller type like "proxy controller" or something
20141125 22:24:40< gfgtdf> iceiceice: on teh serverside you mean ?
20141125 22:24:49< iceiceice> on the client side
20141125 22:25:10< gfgtdf> iceiceice: so what woudl be teh difference ?
20141125 22:25:11< iceiceice> i think controller is too overloaded, it means too many things
20141125 22:25:27< iceiceice> on the one hand it is used to decide when victory / defeat has been achieved
20141125 22:25:40< iceiceice> on the other hand it decides who is controlling what moves are made
20141125 22:26:10< iceiceice> but sometimes i might want to have a droid make my moves for a while and take control again later,
20141125 22:26:15< iceiceice> without the gamestate really being changed
20141125 22:26:20< gfgtdf> iceiceice: my plan would be allowing sides with no controller on serverside an then just no automaticly assigning contoll to host, so that "idle" woudl more or less be a subcase of "network"
20141125 22:26:28< gfgtdf> s/no/not
20141125 22:26:30< iceiceice> yeah that's a good idea for idle
20141125 22:26:39< iceiceice> what i'm talking about is a new way for "human ai" which was removed
20141125 22:27:31< iceiceice> so i think the idea is that there would be another enum "turns_controller" or "proxy_controller" or something, whcih might be human or ai for instnace
20141125 22:27:45< iceiceice> and when you have a local human side, you don't just call play human turn, you check this field
20141125 22:27:56< iceiceice> and give ai control anyways if ai is listed there
20141125 22:28:01< iceiceice> or give idle control if idle is listed there
20141125 22:28:18< iceiceice> and this attribute does not need to be saved to the save file, or synced
20141125 22:28:25< iceiceice> it is just an interface property
20141125 22:28:37< iceiceice> for instance right now there is a really ugly hack i added here: https://github.com/wesnoth/wesnoth/blob/master/src/team.cpp#L242
20141125 22:28:54< iceiceice> because "idle" is not supposed to be a gamestate property really
20141125 22:29:12< iceiceice> its awkard that it is indicated using controller type
20141125 22:29:55< iceiceice> fwiw i think i proposed to implement idle the way you are suggesting now as a server-sided thing,
20141125 22:30:07< iceiceice> and soliton suggested that it should be known only to host instead
20141125 22:30:17< iceiceice> but i think that might just have been to avoid server breakage
20141125 22:31:02< gfgtdf> iceiceice: ok
20141125 22:32:12-!- DHost [~Pcy@vps.ponchy.fr] has quit [Remote host closed the connection]
20141125 22:32:40< irker971> wesnoth: Nathan Aclander wesnoth:master ab3c9b90f85d / src/playturn_network_adapter.cpp: Fix spelling in destructor http://git.io/8wGDIg
20141125 22:32:42< irker971> wesnoth: Alexander van Gessel wesnoth:master bcddbb1469f3 / src/playturn_network_adapter.cpp: Merge pull request #336 from naclander/patch-1 http://git.io/qic4xQ
20141125 22:45:31-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20141125 23:09:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141125 23:15:44-!- travis-ci [~travis-ci@ec2-54-83-129-179.compute-1.amazonaws.com] has joined #wesnoth-dev
20141125 23:15:44< travis-ci> gfgtdf/wesnoth-old#389 (wesnothd_sides - 194f3ad : gfgtdf): The build was broken.
20141125 23:15:44< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/42137364
20141125 23:15:44-!- travis-ci [~travis-ci@ec2-54-83-129-179.compute-1.amazonaws.com] has left #wesnoth-dev []
20141125 23:24:58-!- mjs-de [~mjs-de@f048104022.adsl.alicedsl.de] has quit [Ping timeout: 250 seconds]
20141125 23:28:06< gfgtdf> iceiceice: how does teh machnism work that prevents the host form doing moves for idle sides ?
20141125 23:28:34< iceiceice> tbh i forget
20141125 23:28:47< gfgtdf> iceiceice: or rather: are you sure there is one ?
20141125 23:29:00< iceiceice> i think i tested it
20141125 23:29:15< iceiceice> i think i was mainly concerned with not getting the vision though
20141125 23:29:29< iceiceice> it would be a little surprising if there is none but i really can't remember anymore
20141125 23:29:30< gfgtdf> iceiceice: ye you cannot get teh vision but you can still move teh units
20141125 23:29:35< iceiceice> lol
20141125 23:29:37< iceiceice> great
20141125 23:29:46< gfgtdf> iceiceice: ofc onyl for teh unit you see
20141125 23:30:32< iceiceice> ok i guess that should go on bug tracker ... i can try to fix this if you like
20141125 23:30:39< iceiceice> i won't forget this report though
20141125 23:30:41< gfgtdf> iceiceice: that what i just tested, i didn soem changes but they re onyl about what happens when a controll "un-idles" a side to taht shoudl effect it
20141125 23:30:53< iceiceice> ok
20141125 23:31:03< gfgtdf> s/soem/some*
20141125 23:31:04< iceiceice> the main concern was to fix this bug that slowthinker reported,
20141125 23:31:21< iceiceice> for his add-on it is very important that most of the map is unknown to you and you can do quite a bit in secret
20141125 23:31:34< iceiceice> so if a player drops and vision is given to the host it sort of ruins it
20141125 23:32:02< shadowm> Are the forums slow for anyone else or is it my connection?
20141125 23:32:03< iceiceice> still it looks bad if you can move the "idle" units
20141125 23:32:27< iceiceice> shadowm: my ping to baldras is 120 ms
20141125 23:32:36< shadowm> I said the forums, not ping.
20141125 23:32:39< iceiceice> and the forum is not that slow as far as i can see
20141125 23:33:13< gfgtdf> iceiceice: you now where i can enable teh blindfold feature ?
20141125 23:33:14< shadowm> I guess it's just me then.
20141125 23:33:36< iceiceice> gfgtdf: there is some blindfold struct i made,
20141125 23:33:44< iceiceice> you can see it in the turn dialog notification i think,
20141125 23:34:04< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L850
20141125 23:34:12< iceiceice> it either talks to display or game_display i don't remember now
20141125 23:34:21< gfgtdf> iceiceice: ono i mean where in teh ui can i turn that in, in teh mp connect, mp create or n the  preferences ?
20141125 23:34:31< iceiceice> oh
20141125 23:34:37< iceiceice> i think its only in mp lobby right now
20141125 23:34:46< iceiceice> where the "quick replays" check used to be
20141125 23:34:57< gfgtdf> iceiceice: so i doesnt work for local games =
20141125 23:35:00< gfgtdf> ?*
20141125 23:35:16< iceiceice> "join game blindfolded" does not work for lcoal games
20141125 23:35:19< gfgtdf> iceiceice: i thought teh main intention for this feature were local games
20141125 23:35:30< iceiceice> if you want to see it in the turn dialog you go to preferences > general > show turn dialog
20141125 23:35:34< gfgtdf> iceiceice: were you want to play with another player without srahing vision
20141125 23:35:35< iceiceice> that will work in local games also
20141125 23:36:18< gfgtdf> iceiceice: ah yes
20141125 23:37:04< gfgtdf> iceiceice: i wonder what teh blingodl makes eerythign back? even for games without fog or shroud.
20141125 23:37:10< gfgtdf> s/what/why*
20141125 23:38:52< iceiceice> gfgtdf: i think its basically this line: https://github.com/wesnoth/wesnoth/blob/master/src/display.hpp#L349
20141125 23:40:12-!- tomreyn [~tomreyn@61-197-28-81.ftth.cust.kwaoo.net] has quit [Quit: tomreyn]
20141125 23:41:56< gfgtdf> iceiceice: hm ok ty
20141125 23:44:28-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20141125 23:47:12-!- travis-ci [~travis-ci@ec2-54-166-253-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20141125 23:47:12< travis-ci> wesnoth/wesnoth#4923 (master - bcddbb1 : Alexander van Gessel): The build has errored.
20141125 23:47:12< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/42137409
20141125 23:47:12-!- travis-ci [~travis-ci@ec2-54-166-253-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20141125 23:47:33-!- travis-ci [~travis-ci@ec2-54-91-211-63.compute-1.amazonaws.com] has joined #wesnoth-dev
20141125 23:47:33< travis-ci> gfgtdf/wesnoth-old#390 (wesnothd_sides - e08f297 : gfgtdf): The build was broken.
20141125 23:47:33< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/42141551
20141125 23:47:33-!- travis-ci [~travis-ci@ec2-54-91-211-63.compute-1.amazonaws.com] has left #wesnoth-dev []
20141125 23:49:17< gfgtdf> iceiceice: you have an opinion on https://github.com/wesnoth/wesnoth/pull/337 ?
20141125 23:49:53-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 264 seconds]
20141125 23:50:26-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20141125 23:51:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141125 23:53:48< iceiceice> it looks good to me, but i'm not going to test atm,
20141125 23:53:52< iceiceice> does `update_gui_to_player(player_number_ - 1);` fix a problem?
20141125 23:56:37< gfgtdf> iceiceice: y, but i dont knwo whether that problem is also there before the other commit
20141125 23:57:27< iceiceice> ok
20141125 23:57:44< iceiceice> there really needs to be a "turns_change_manager" class or something...
20141125 23:57:51-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-djedfwkbmczhcjfa] has quit [Quit: Connection closed for inactivity]
20141125 23:57:57< iceiceice> it would be a lot easier to figure out how this stuff should work if it were not all in play_controller at random places
--- Log closed Wed Nov 26 00:00:25 2014