--- Log opened Mon Dec 01 00:00:10 2014 20141201 00:00:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141201 00:03:16-!- irker006 [~irker@fehu.ai0867.net] has joined #wesnoth-dev 20141201 00:03:17< irker006> wesnoth: anonymissimus wesnoth:master 5ad0e47eabd9 / src/scripting/lua_kernel_base.cpp: fix warning about unreferenced variable http://git.io/zY1r3Q 20141201 00:03:18< irker006> wesnoth: anonymissimus wesnoth:master 0f64b9e7a5cd / src/scripting/lua_map_location_ops.cpp: fix MSVC warning about data loss http://git.io/Cx9xvA 20141201 00:03:20< irker006> wesnoth: anonymissimus wesnoth:master ca0a17f791f3 / src/gui/dialogs/advanced_graphics_options.cpp: fix MSVC warning about comparison signed <-> unsigned http://git.io/2ZD7XA 20141201 00:03:23< irker006> wesnoth: anonymissimus wesnoth:master 21924cae74ba / src/playsingle_controller.cpp: mute an invalid MSVC warning about unreachable code http://git.io/Q-Wtew 20141201 00:13:12-!- anonymissimus [~chatzilla@HSI-KBW-078-042-069-130.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 11.0/20120312181643]] 20141201 00:17:19-!- trewe [~trewe@160.7.103.87.rev.vodafone.pt] has quit [Quit: quit] 20141201 00:20:21-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds] 20141201 00:22:06-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 00:27:00< irker006> wesnoth: Chris Beck wesnoth:1.12 856f3acab730 / src/multiplayer_connect_engine.cpp: check properly if a config attribute value is not a boolean http://git.io/M3A7oQ 20141201 00:27:02< irker006> wesnoth: Chris Beck wesnoth:1.12 2fa43e3df9ba / src/multiplayer_connect_engine.cpp: Merge pull request #335 from cbeck88/mp_connect_bool_test http://git.io/o4rU1w 20141201 00:30:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141201 00:30:32-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev 20141201 00:40:27< irker006> wesnoth: Chris Beck wesnoth:master 218d7370ea3d / src/game_initialization/connect_engine.cpp: check properly if a config attribute value is not a boolean http://git.io/kuuDlw 20141201 00:41:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141201 00:45:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 00:51:38-!- gfgtdf [~chatzilla@d222081.adsl.hansenet.de] has joined #wesnoth-dev 20141201 00:52:23< gfgtdf> anonymissimus: i wonder why that warning here https://github.com/wesnoth/wesnoth/commit/21924cae74ba541d0a2ed035d241346d3c376eb8 is invalid? 20141201 00:54:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141201 00:55:34< gfgtdf> anonymissimus: i mean there is code after an infinite loop. 20141201 00:55:50< gfgtdf> iceiceice: i think you wrote that code? Do you know about it ? 20141201 00:56:40< iceiceice> i think its correct, probably the return boost::none is unreachable 20141201 00:57:15< iceiceice> because i think the macro returns end play signals if it finds one 20141201 00:57:46-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has quit [Remote host closed the connection] 20141201 00:58:29< iceiceice> maybe it should all be simplified there 20141201 00:58:44< iceiceice> i guess probably it only returns if it gets an end_level_exception 20141201 00:58:58< gfgtdf> iceiceice: y 20141201 01:00:10< gfgtdf> iceiceice: i wonder why i don't get that warning then though. 20141201 01:02:51< gfgtdf> maybe a bug in msvc 2010 20141201 01:12:37-!- gfgtdf [~chatzilla@d222081.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 33.1/20141106120505]] 20141201 01:13:14-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving] 20141201 02:20:18-!- Pepe_ [~ppjet@anderith.bouah.net] has quit [Quit: leaving] 20141201 02:30:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141201 02:37:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141201 02:44:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 02:47:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20141201 02:47:52-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-kicuuyklmbuyzlrc] has quit [Quit: Connection closed for inactivity] 20141201 02:51:52-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20141201 02:53:22-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 255 seconds] 20141201 02:55:09-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 03:01:22-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds] 20141201 03:03:07-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 03:13:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer] 20141201 03:17:49-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 03:30:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141201 03:40:29-!- irker006 [~irker@fehu.ai0867.net] has quit [Quit: transmission timeout] 20141201 03:43:30-!- Ivanovic_ [~ivanovic@frnk-d933018e.pool.mediaWays.net] has joined #wesnoth-dev 20141201 03:43:30-!- Ivanovic_ [~ivanovic@frnk-d933018e.pool.mediaWays.net] has quit [Changing host] 20141201 03:43:30-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20141201 03:47:49-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 255 seconds] 20141201 03:49:32-!- Ivanovic_ is now known as Ivanovic 20141201 04:14:43-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection] 20141201 04:35:29-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev 20141201 05:19:30-!- ppjet [~ppjet@anderith.bouah.net] has joined #wesnoth-dev 20141201 05:20:48-!- ppjet [~ppjet@anderith.bouah.net] has quit [Client Quit] 20141201 05:21:13-!- ppjet [~ppjet@anderith.bouah.net] has joined #wesnoth-dev 20141201 05:21:36-!- ppjet [~ppjet@anderith.bouah.net] has left #wesnoth-dev [] 20141201 05:23:03-!- ppjet [~ppjet@anderith.bouah.net] has joined #wesnoth-dev 20141201 05:31:03-!- ppjet is now known as Pepe_ 20141201 05:32:10-!- sachith500 [~kvirc@112.135.113.45] has joined #wesnoth-dev 20141201 05:34:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 05:42:48-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20141201 05:44:02-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 245 seconds] 20141201 05:47:01-!- sachith500 [~kvirc@112.135.113.45] has quit [Read error: Connection reset by peer] 20141201 05:47:45-!- sachith500 [~kvirc@112.135.113.45] has joined #wesnoth-dev 20141201 05:58:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20141201 06:26:44-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20141201 06:27:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141201 06:28:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 06:29:14-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has joined #wesnoth-dev 20141201 06:30:20-!- ancestral [~ancestral@71-34-14-121.mpls.qwest.net] has quit [Client Quit] 20141201 06:46:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141201 07:00:07-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection] 20141201 07:03:13-!- Guest70995 [~8680@2002:4404:712c:0:cca7:9ef2:9eda:6441] has quit [Ping timeout: 265 seconds] 20141201 07:03:36-!- _8680_ [~8680@2002:4404:712c:0:5d3a:1bbb:86de:accb] has joined #wesnoth-dev 20141201 07:04:00-!- _8680_ is now known as Guest31514 20141201 07:07:17-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev 20141201 07:18:15-!- Guest31514 [~8680@2002:4404:712c:0:5d3a:1bbb:86de:accb] has quit [Ping timeout: 272 seconds] 20141201 07:18:38-!- _8680__ [~8680@2002:4404:712c:0:604f:2562:e941:a19c] has joined #wesnoth-dev 20141201 07:34:41-!- Gallaecio [~quassel@84.120.218.119.dyn.user.ono.com] has quit [Remote host closed the connection] 20141201 07:42:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 08:08:48-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev 20141201 08:08:48-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host] 20141201 08:08:48-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141201 08:11:09-!- Coffee_irc [~david@ppp121-45-26-75.lns20.adl2.internode.on.net] has joined #wesnoth-dev 20141201 08:26:26-!- markus_ [~mjs-de@g227059245.adsl.alicedsl.de] has joined #wesnoth-dev 20141201 08:30:03-!- mjs-de [~mjs-de@g228130025.adsl.alicedsl.de] has quit [Ping timeout: 244 seconds] 20141201 08:52:08-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer] 20141201 08:57:23-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev 20141201 08:59:11-!- ryao [~ryao@gentoo/developer/ryao] has left #wesnoth-dev [] 20141201 09:02:41-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev 20141201 09:08:09-!- shadowm2 [~shadowm@baldras.wesnoth.org] has joined #wesnoth-dev 20141201 09:08:54-!- shadowm2 [~shadowm@baldras.wesnoth.org] has quit [Changing host] 20141201 09:08:54-!- shadowm2 [~shadowm@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 09:09:22-!- markus_ is now known as mjs-de 20141201 09:24:05-!- cib0 [~cib@p5DC74ADA.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141201 10:09:04-!- cib0 [~cib@p5DC74ADA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141201 10:11:36-!- cib0 [~cib@p5DC74ADA.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141201 10:34:44-!- cib0 [~cib@p5DC74ADA.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 20141201 11:17:57-!- sachith500 [~kvirc@112.135.113.45] has quit [Ping timeout: 240 seconds] 20141201 11:18:44-!- Anakonda [Anakonda@dsl-tkubrasgw1-54f9ba-178.dhcp.inet.fi] has joined #wesnoth-dev 20141201 11:22:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141201 11:31:35-!- mjs-de [~mjs-de@g227059245.adsl.alicedsl.de] has quit [Ping timeout: 272 seconds] 20141201 12:10:57-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has quit [Read error: Connection reset by peer] 20141201 12:15:24-!- sachith500 [~kvirc@112.135.44.219] has joined #wesnoth-dev 20141201 12:17:47-!- sachith500 [~kvirc@112.135.44.219] has quit [Client Quit] 20141201 12:34:26-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20141201 12:42:33-!- mjs-de [~mjs-de@vpn53083.itmc.tu-dortmund.de] has joined #wesnoth-dev 20141201 12:44:29-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Quit: leaving] 20141201 12:45:03-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Remote host closed the connection] 20141201 12:45:39-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev 20141201 12:47:45-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev 20141201 12:49:30-!- mjs-de [~mjs-de@vpn53083.itmc.tu-dortmund.de] has quit [Ping timeout: 250 seconds] 20141201 13:02:36-!- mjs-de [~mjs-de@129.217.43.93] has joined #wesnoth-dev 20141201 13:03:48-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev 20141201 13:05:41-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev 20141201 13:20:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141201 13:20:56-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds] 20141201 13:33:50-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141201 13:36:53-!- TooLmaN [~TooLmaN@mx1.thomsonplastics.com] has joined #wesnoth-dev 20141201 13:39:22-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Read error: No route to host] 20141201 13:41:08-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev 20141201 13:41:08-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host] 20141201 13:41:08-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141201 13:45:51-!- anonymissimus [~chatzilla@HSI-KBW-078-042-069-130.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20141201 13:51:46< anonymissimus> gfgtdf, iceiceice : ok well, the warning seem valid yes...i should have called it "mute a hard to fix warning"...the function (playsingle_controller::play_scenario_main_loop() needs to return something 20141201 13:52:07< anonymissimus> (otherwise compile error) 20141201 14:00:44< anonymissimus> iceiceice: I wonder, shouldn't you have been able to use a function instead of a macro ? 20141201 14:09:14< iceiceice> maybe. i consider that code to not be in a finished state 20141201 14:09:33< anonymissimus> iceiceice: there are other cases with a loop...you need another version of the macro for the loops which just sets the variable, breaks if its true, and the outer function returns it 20141201 14:10:12< anonymissimus> that would be a way to fix 20141201 14:10:26< iceiceice> i don't think there need to be more versions of the macros 20141201 14:10:53< iceiceice> the purpose was to try to help fix some problems with "too many exceptions" 20141201 14:11:37< iceiceice> there are many functions in play controller that have void return type but e.g. always return by throwing an exception 20141201 14:11:41< anonymissimus> well yes, for what it's worth, I always hated that scenarios are end by exeptions 20141201 14:12:33< iceiceice> yes, i think its fine for small programs but if you also have other exceptions like "network::error" its just asking for a crash 20141201 14:13:05< anonymissimus> so the real fix would be to always end by a proper return value, unwinding the stack normally 20141201 14:13:28< iceiceice> yes, the macros were to try to help to get there 20141201 14:13:50< iceiceice> it's pretty complicated because potentially any line is throwing and no one really understands 20141201 14:14:12< iceiceice> i think its hard to boil it down further, 20141201 14:14:38< iceiceice> the problem i guess now is that these functions "check end level" can be called by things called by lua 20141201 14:15:08< iceiceice> so its not realistic that we will change all the return values etc. 20141201 14:15:30< anonymissimus> btw, do you know what sdl_gpu is and why it is included ? 20141201 14:15:37< iceiceice> its lipk's project 20141201 14:15:47< anonymissimus> it throws warnings that I would like to fix 20141201 14:16:05< anonymissimus> it doesn't seem needed...not everywhere at least 20141201 14:16:45< iceiceice> i don't know what his plans are, if he plans to update it in tree or what 20141201 14:56:18-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!] 20141201 15:03:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141201 15:04:26-!- gfgtdf [~chatzilla@f054132134.adsl.alicedsl.de] has joined #wesnoth-dev 20141201 15:05:20-!- mjs-de [~mjs-de@129.217.43.93] has quit [Remote host closed the connection] 20141201 15:06:24< gfgtdf> anonymissimus: you sure removing that "return boost::none;" is a comileerror ? When i removed it i dint have me a wanring or an error. 20141201 15:07:46-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds] 20141201 15:20:31-!- gfgtdf [~chatzilla@f054132134.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 33.1/20141106120505]] 20141201 15:25:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141201 15:41:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20141201 15:41:41< anonymissimus> gfgtdf: right...still, if there us a return type other than void, all possible paths should return a matching type 20141201 15:47:08-!- gfgtdf [~chatzilla@f054132134.adsl.alicedsl.de] has joined #wesnoth-dev 20141201 15:47:30< gfgtdf> anonymissimus: if a code is unreachable it is not a possible path. 20141201 15:48:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141201 16:01:41< anonymissimus> gfgtdf: well...possible in the coder's mind is often not the same as in the compiler's 20141201 16:07:24-!- iceiceice [~chris@192.16.204.74] has joined #wesnoth-dev 20141201 16:07:24-!- iceiceice [~chris@192.16.204.74] has quit [Changing host] 20141201 16:07:24-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141201 16:07:40< iceiceice> anonymissimus: it's not a "mismatching return type" 20141201 16:07:56< iceiceice> boost::none is matching the return type, it is returned that way in many similar functions 20141201 16:08:09< anonymissimus> iceiceice: btw could you pls avoid making branches for small things such as "add wesnoth.show_lua_console, as a debugging aide" 20141201 16:08:25< iceiceice> why should i avoid this? 20141201 16:08:42< anonymissimus> ai's boost filesystem fix is worth a branch, but small things confuse the history 20141201 16:08:53< iceiceice> no, it makes it much simpler imo 20141201 16:09:18< iceiceice> often i will have several parts of some feature, and rebase them or apply them in a different order 20141201 16:10:02< iceiceice> i think "many branches" is considered a good practice with git 20141201 16:12:18< iceiceice> what is getting confused, is it just hard for your gui tool? 20141201 16:15:42< iceiceice> anonymissimus: it's really very useful to work on multiple branches at once even for small things, if you are trying to have high quality for each commit 20141201 16:15:58< iceiceice> in this case wesnoth.show_lua_console is helpful as a testing aide, since you can use it to drop into the interactive mode 20141201 16:16:12< iceiceice> so it should have actually gone in first in my branch, despite the chronological order 20141201 16:16:32< iceiceice> when i have something like that, i don't commit it to master right away because that causes problems 20141201 16:16:50< iceiceice> but i don't want it in the feature branch either, it might not be specifically related to the feature 20141201 16:16:55< iceiceice> its just a separate feature on its own 20141201 16:16:59< iceiceice> so it goes on its own branch 20141201 16:17:04< iceiceice> then maybe i merge that branch with master 20141201 16:17:08< iceiceice> and rebase the feature branch against master 20141201 16:17:31< iceiceice> it would be much more cumbersome to "avoid small branches" here 20141201 16:20:15-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141201 16:21:14< anonymissimus> i generally use cherry-pick for ranges of commits or single commits 20141201 16:21:27< anonymissimus> from the other branch to master 20141201 16:21:29< fabi> hello 20141201 16:25:28-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141201 16:39:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141201 16:53:08-!- iceiceice [~chris@192.16.204.74] has joined #wesnoth-dev 20141201 16:53:08-!- iceiceice [~chris@192.16.204.74] has quit [Changing host] 20141201 16:53:08-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141201 16:53:22< iceiceice> anonymissimus: i don't use cherry-pick except when i am backporting something to 1.12 20141201 16:53:42< iceiceice> if i cherry-pick from feature branches to master, then i guess i have to discard the feature branch at the end instead of merging it? 20141201 16:54:30< iceiceice> i find that its simpler to just use branch, merge and rebase when i'm working on things to go on master 20141201 16:54:58< iceiceice> also cherry-picking destroys history in the sense that the commits have a different date and time after you pick them 20141201 16:56:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds] 20141201 16:57:30-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Client Quit] 20141201 16:58:24-!- travis-ci [~travis-ci@ec2-54-83-139-74.compute-1.amazonaws.com] has joined #wesnoth-dev 20141201 16:58:24< travis-ci> wesnoth/wesnoth#4965 (master - 97bd3a9 : anonymissimus): The build was broken. 20141201 16:58:24< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/42644255 20141201 16:58:24-!- travis-ci [~travis-ci@ec2-54-83-139-74.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141201 17:06:25-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev 20141201 17:07:43-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Client Quit] 20141201 17:09:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141201 17:13:40-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 265 seconds] 20141201 17:41:50-!- irker175 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20141201 17:41:50< irker175> wesnoth: anonymissimus wesnoth:master 97bd3a92a502 / src/playsingle_controller.cpp: remove unreachable code http://git.io/Xw9kXA 20141201 17:53:12-!- Gallaecio [~quassel@84.120.187.197.dyn.user.ono.com] has joined #wesnoth-dev 20141201 17:53:59< gfgtdf> why does irker give a messgae now? (after the travis message?) 20141201 17:55:43-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20141201 17:55:56-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20141201 17:56:43< vultraz> AI0867 was doing some server stuff and restarted it 20141201 18:01:33-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 18:02:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds] 20141201 18:02:56-!- Sulfur [~Miranda@p5B32797F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141201 18:04:47-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 18:05:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 245 seconds] 20141201 18:05:43-!- noy_ is now known as noy 20141201 18:19:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141201 18:25:34< anonymissimus> so where is an error summary why I broke the build ? 20141201 18:25:55-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20141201 18:32:15-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141201 18:32:23< iceiceice> anonymissimus: you can just click the link that the travis bot posts 20141201 18:33:06< iceiceice> its fairly common that the test executable will segfault in the travis environment 20141201 18:33:12< iceiceice> and it doesn't do so if it is restarted 20141201 18:33:23< iceiceice> in this case someone already did it and now your build passed 20141201 18:34:21< anonymissimus> well, what I want to see is something like the error list in MSVC 20141201 18:34:40< anonymissimus> or what calng/gcc outputs...and only the error 20141201 18:34:51< anonymissimus> not tons of messages 20141201 18:35:23< iceiceice> that's not really possible, not all errors are build errors 20141201 18:35:31< iceiceice> some of them are broken unit tests 20141201 18:36:10< iceiceice> travis gives you the log of the whole shell transaction, then the "passes" are color coded in green and "fails" in red 20141201 18:37:22< iceiceice> i guess you want only to see the failed lines from the build? i guess that could be a feature request for travis or something 20141201 18:37:36< anonymissimus> yes 20141201 18:39:28< anonymissimus> someone seems to have added wml unit test execution to msvc, it comes at the end of the build 20141201 18:40:06< anonymissimus> i dont think that really makes much sense...there are extremely few OS-dependant issues in wml or lua 20141201 18:40:27< anonymissimus> so its enough if they auto-run on travis or something 20141201 18:41:37< anonymissimus> (and all of them are reported as failing for me ;)) 20141201 18:41:41-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev 20141201 18:42:29-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20141201 18:45:39< iceiceice> anonymissimus: i think aquileia added them 20141201 18:46:06< iceiceice> its helpful to be able to run the tests locally, unless you use pull requests for everything 20141201 18:46:17< iceiceice> otherwise when you push you end up actually breaking master 20141201 18:47:11< iceiceice> so, someone might be sad if they have to bisect something later and end up in your commits 20141201 18:48:32< iceiceice> if you use pull requests, or ask travis to build your fork of wesnoth, then you can avoid running the tests yourself pretty much 20141201 18:50:31-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Ping timeout: 255 seconds] 20141201 18:52:56-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev 20141201 19:09:07< anonymissimus> hm ok so I'm supposed tp copy WindowsTimout.exe into the project root it seems...they run now 20141201 19:11:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141201 19:21:58-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20141201 19:34:11-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 272 seconds] 20141201 19:34:34-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20141201 19:49:24-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 272 seconds] 20141201 20:01:29-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20141201 20:01:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 20:03:09-!- TooLmaN_ [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev 20141201 20:05:22-!- TooLmaN_ [~TooLmaN@mail.thomsonplastics.com] has quit [Client Quit] 20141201 20:05:54-!- TooLmaN [~TooLmaN@mx1.thomsonplastics.com] has quit [Ping timeout: 264 seconds] 20141201 20:06:10-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 264 seconds] 20141201 20:10:32< anonymissimus> Test 'test_return' timed out, expected return value 0 20141201 20:10:46< anonymissimus> why is linger mode not expected to time out ? 20141201 20:12:35< iceiceice> what is the exact command line you are using to run it 20141201 20:13:59< anonymissimus> no idea...the wml_tests.cmd is too hard to figure it out 20141201 20:14:21< iceiceice> it should look something like this: ./wesnoth -u test_return 20141201 20:15:36< iceiceice> in short you should skip linger mode i think since the test will run headlessly 20141201 20:18:42< iceiceice> ok, it looks correct to me: https://github.com/wesnoth/wesnoth/blob/master/projectfiles/VC9/WML_tests.cmd 20141201 20:20:25-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20141201 20:29:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141201 20:29:42< anonymissimus> now I got ERRORLEVEl 0 when running manually... 20141201 20:29:48< anonymissimus> (as I should) 20141201 20:30:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141201 20:32:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20141201 20:35:27-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141201 20:41:57-!- irker175 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20141201 20:42:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141201 20:45:28-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer] 20141201 20:45:39-!- Ivanovic [~ivanovic@frnk-d933018e.pool.mediaWays.net] has joined #wesnoth-dev 20141201 20:45:59-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20141201 20:46:40-!- Ivanovic [~ivanovic@frnk-d933018e.pool.mediaWays.net] has quit [Changing host] 20141201 20:46:40-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20141201 20:49:26-!- anonymissimus [~chatzilla@HSI-KBW-078-042-069-130.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.90.1 [Firefox 11.0/20120312181643]] 20141201 20:58:55-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 21:00:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 21:01:07-!- shadowm2 [~shadowm@wesnoth/developer/shadowm] has left #wesnoth-dev [] 20141201 21:13:17-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds] 20141201 21:15:27-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 21:21:23-!- SZ_Bot [SZ_Bot@27-83-235-80.dyn.estpak.ee] has joined #wesnoth-dev 20141201 21:21:28-!- Ravana_ [SZ_Bot@27-83-235-80.dyn.estpak.ee] has quit [Disconnected by services] 20141201 21:21:31-!- SZ_Bot is now known as Ravana_ 20141201 21:25:38-!- fendrin [~quassel@p4FDB9CE1.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141201 21:25:38-!- fendrin [~quassel@p4FDB9CE1.dip0.t-ipconnect.de] has quit [Changing host] 20141201 21:25:38-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20141201 21:27:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 256 seconds] 20141201 21:29:29-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 245 seconds] 20141201 21:34:40-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20141201 21:35:08-!- Netsplit *.net <-> *.split quits: fabi 20141201 21:39:32-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20141201 21:40:11-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 21:40:25-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer] 20141201 21:41:37-!- SZ_Bot [SZ_Bot@27-83-235-80.dyn.estpak.ee] has joined #wesnoth-dev 20141201 21:41:37-!- Ravana_ [SZ_Bot@27-83-235-80.dyn.estpak.ee] has quit [Disconnected by services] 20141201 21:42:08-!- SZ_Bot is now known as Ravana_ 20141201 21:45:15-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection] 20141201 21:50:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141201 22:07:18-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 256 seconds] 20141201 22:08:58-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 22:14:48-!- gfgtdf_ [~chatzilla@f054130000.adsl.alicedsl.de] has joined #wesnoth-dev 20141201 22:17:03-!- gfgtdf [~chatzilla@f054132134.adsl.alicedsl.de] has quit [Ping timeout: 258 seconds] 20141201 22:17:12-!- gfgtdf_ is now known as gfgtdf 20141201 22:24:09-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev 20141201 22:24:09-!- iceiceice [~chris@50.245.222.235] has quit [Changing host] 20141201 22:24:09-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141201 22:24:25-!- Sulfur [~Miranda@p5B32797F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141201 22:29:43< gfgtdf> fendrin: where do you use [side]controller = ? 20141201 22:30:16< fendrin> gfgtdf: LoW 3,7,14 20141201 22:31:04-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev 20141201 22:33:33< gfgtdf> was quiet fast :), ty 20141201 22:34:30-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141201 22:44:55-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20141201 22:53:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141201 23:04:09-!- Coffee_irc [~david@ppp121-45-26-75.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!] 20141201 23:13:57-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 272 seconds] 20141201 23:15:35-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 23:23:17-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds] 20141201 23:23:51-!- mjs-de [~mjs-de@g227059245.adsl.alicedsl.de] has joined #wesnoth-dev 20141201 23:25:12-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 23:30:36-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20141201 23:34:54-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer] 20141201 23:39:53-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20141201 23:58:45-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Tue Dec 02 00:00:13 2014