--- Log opened Fri Dec 05 00:00:08 2014
--- Day changed Fri Dec 05 2014
20141205 00:00:08< iceiceice> it woudl be nice if we could somehow auto generate some docs for that stuff
20141205 00:00:25< iceiceice> but i really dont want to just sit down and write docs for someone who didn't feel like it
20141205 00:00:45< iceiceice> its bizarre to make features like this and then not document it, since no one will be able to use it...
20141205 00:01:04< fabi> There is no http://wiki.wesnoth.org/ReferenceLUA ?
20141205 00:01:07< fabi> !
20141205 00:01:18< fabi> Maybe that is the problem.
20141205 00:01:37< iceiceice> there is only this blurb on the subject: http://wiki.wesnoth.org/LuaWML:Display#wesnoth.theme_items
20141205 00:01:54< iceiceice> really there should be a gigantic list there, with an entry for every "report_Generator" declared in reports.cpp
20141205 00:02:52< fabi> iceiceice: Yes, right. Please fill a feature request for autogenerating the reports wiki entries.
20141205 00:03:04< fabi> iceiceice: Really good thing to have.
20141205 00:03:17< iceiceice> fabi: maybe what i should do is,
20141205 00:03:37< iceiceice> just grep "REPORT_GENERATOR" in that file
20141205 00:03:42< iceiceice> or fgrep or whatever
20141205 00:03:47< iceiceice> and paste the list into wiki
20141205 00:03:55< fabi> iceiceice: Something different. I like to give qt a try and implement enough so you can also use qt dialogs in Wesnoth. 
20141205 00:04:42< fabi> I am not stuck to qt, every other gui toolkit might do it as well.
20141205 00:05:08< iceiceice> fabi: yeah i think qt seems good, i don't know very much about qt or the competitors
20141205 00:05:12< fabi> Qt just seems to be very portable. And is already ported to many platforms. 
20141205 00:05:22< iceiceice> there seems to be a ton of tutorial information and examples
20141205 00:05:26< iceiceice> and many games that use it
20141205 00:05:27< fabi> And the qt people care about games. 
20141205 00:05:29< iceiceice> yes
20141205 00:05:48< iceiceice> i guess that its common now to use QT + opengl for graphics
20141205 00:05:55< iceiceice> in 2d games
20141205 00:06:00< iceiceice> at least i read some stuff like this
20141205 00:06:25< fabi> iceiceice: Do you like to join me? This is certainly not something that I can do alone.
20141205 00:06:57-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Leaving]
20141205 00:07:19< iceiceice> yeah if you want to make a branch as an experiment i think it would be interesting
20141205 00:07:48< fabi> iceiceice: Yes why not. I mean that is why we switched to git iirc.
20141205 00:08:03< iceiceice> i think we should fix a target, like some specific dialog to do in QT
20141205 00:08:19< iceiceice> or we could say, if there are no plans to redo themewml in gui2, why not try in QT and see how it looks
20141205 00:08:51< fabi> I think a good target is a simple dialog that just says: "Hello World" in a label.
20141205 00:09:22< fabi> We need to connect event queues to the qt framework without breaking gui1/gui2/sdl stuff.
20141205 00:09:42< fabi> That is enough work for the start.
20141205 00:09:44< iceiceice> it's annoying to me that we have like 50 different "event queue" objects
20141205 00:10:06< iceiceice> i mean how many do we have
20141205 00:10:09< iceiceice> there is one for the in game events
20141205 00:10:12< iceiceice> there is one for hotkeys
20141205 00:10:20< iceiceice> there is one for gui 1 (?)
20141205 00:10:25< iceiceice> there is one for gui 2(?)
20141205 00:10:32< iceiceice> (actually i'm sure there is one for gui2 )
20141205 00:10:39< iceiceice> does SDL have an internal one i guess?
20141205 00:11:15< fabi> yes
20141205 00:11:38< fabi> the hotkeys are just wrappers around SDL events.
20141205 00:15:00< fabi> iceiceice: Can you make the branch on the github repository? I now how to handle local branches...
20141205 00:16:15< fabi> iceiceice: I guess redoing the titlescreen in qt is a good second stage goal.
20141205 00:18:43< iceiceice> fabi: it seems like it could be controversial to replace gui2, so maybe instead of redoing titlescreen we should redo a gui1 thing?
20141205 00:19:06< iceiceice> it's possible that we will end up with gui2 + qt coexisting for a while
20141205 00:19:20< iceiceice> we could also try redoing the lua interpreter in qt even though its currently in gui2,
20141205 00:19:29< iceiceice> that would probably fix several of the bugs it inherits from gui2
20141205 00:19:37< fabi> yes
20141205 00:20:19< fabi> The preferences dialog would be a good candidate.
20141205 00:20:33< fabi> It is just far more complex than the titlescreen.
20141205 00:20:53< iceiceice> yes
20141205 00:20:54< fabi> Most simple dialogs are already ported to gui2.
20141205 00:21:14< fabi> But the whole thing is offensive to mordante no matter what we start with.
20141205 00:21:43< iceiceice> yeah... thats why i suggested to replace themewml with qt, since i guess there are probably no plans to replace that for now
20141205 00:21:57< iceiceice> i think maybe there is some gui1 in the mp server selection or something?
20141205 00:22:02< iceiceice> don't remember
20141205 00:22:11< fabi> Yeah, good idea. But not a good second milestone. Because of complexity.
20141205 00:22:29< fabi> The attack dialog.
20141205 00:22:37< fabi> I want to redo it anyway.
20141205 00:22:38< iceiceice> that's a good candidate
20141205 00:22:48< fabi> It was the last thing I worked on.
20141205 00:23:04< fabi> Before I got distracted by the label tooltip thing.
20141205 00:23:15< fabi> And it is more or less simple.
20141205 00:23:35< iceiceice> fabi: the last time i made a new branch upstream, it was just, i made a local branch as usual, then i `git push upstream branchname`
20141205 00:24:33< fabi> iceiceice: My gui for making local branches wants to know some stuff from me I can't answer properly. I would be really glad if you do the branching.
20141205 00:24:51< iceiceice> ok, give me a sec
20141205 00:25:03< iceiceice> btw i added a giant list here just now using grep: http://wiki.wesnoth.org/LuaWML:Display#wesnoth.theme_items
20141205 00:28:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 00:29:54< fabi> iceiceice: Nice.
20141205 00:30:28-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20141205 00:30:32< fabi> iceiceice: Still the whole lua can change the ui idea is not recognizable very well. It is very hidden in our wiki.
20141205 00:31:06< iceiceice> fabi: made a branch called "qt"
20141205 00:31:22< fabi> iceiceice: Cool, thanks :-)
20141205 00:33:00< fabi> iceiceice: http://qt-project.org/doc/qt-5/qtquickcontrols-index.html I wonder if using that quick thing (whatever it is) is a good idea.
20141205 00:34:00< iceiceice> it might be, it is referred to in other posts i looked at: http://qt-project.org/forums/viewthread/37858
20141205 00:35:15< fabi> iceiceice: Well, the poster wants to display some gui above a first person 3d viewport.
20141205 00:35:34< fabi> iceiceice: We do not have a big opengl canvas we render qt into.
20141205 00:35:40< iceiceice> hmm, in the case i posted i think its supposed to be a 2d game
20141205 00:35:45< fabi> Complete different situation.
20141205 00:35:59< iceiceice> but yes he has unique problems in the subsequent posts
20141205 00:36:39< iceiceice> i did not look at how gui1 works in the "SDL_GPU" code
20141205 00:36:46< fabi> The point of qt quick seems that you can use the Qt QML language. http://qt-project.org/doc/qt-5/qtqml-index.html
20141205 00:36:55< iceiceice> "SDL_GPU" is supposed to basically wrap opengl i guess
20141205 00:38:14< iceiceice> hmmm
20141205 00:38:21< iceiceice> sounds a lot like GUI2
20141205 00:38:39< iceiceice> instead of WML have "qml" and instead of formula strings interpreted using the formula ai stuff, you just support javascript exprssions
20141205 00:39:49< iceiceice> so probably its on the right track i guess
20141205 00:40:24< fabi> Yes Qt Quick looks promising.
20141205 00:40:33< iceiceice> which part actually provides widgets?
20141205 00:40:40< iceiceice> does Qt quick do that?
20141205 00:40:55< fabi> No
20141205 00:41:05< fabi> The widgets are part of the core library.
20141205 00:41:40< iceiceice> can they be tweaked and such in qml?
20141205 00:41:43< iceiceice> presumably, yes?
20141205 00:41:50< fabi> Quick seems to be a solution that replaces what currently sdl does for us.
20141205 00:42:33< fabi> On the one hand. Handling user Input for example.
20141205 00:43:32< fabi> I am just reading http://qt-project.org/doc/qt-5/qtquick-index.html
20141205 00:43:34< iceiceice> i think some of this stuff is also done in gui2
20141205 00:43:39< iceiceice> for instnace gui2 has a canvas object i remember
20141205 00:44:31< fabi> I guess the canvas http://qt-project.org/doc/qt-5/qtquick-visualcanvas-topic.html can replace what we do with sdl_surface.
20141205 00:45:56< iceiceice> hmm this worries me: http://stackoverflow.com/questions/9640615/some-thoughts-on-sdl-qt-opengl-for-a-game-engine
20141205 00:46:19< iceiceice> "Fullscreen blocks everything, so for using Qt 4 for in-game GUI it is very likely that you'll have to design your own Qt-based GUI framework for SDL from nothing. Although this can be done, it will take time. You won't have this problem if application isn't fullscreen, though, but still Qt GUI won't be exactly suitable for this scenario."
20141205 00:47:12< iceiceice> it might be that qt is not really compatible with SDL
20141205 00:47:23< iceiceice> http://stackoverflow.com/questions/118659/how-do-i-use-qt-and-sdl-together
20141205 00:47:36< iceiceice> but these are also old threads
20141205 00:50:10< iceiceice> https://forums.libsdl.org/viewtopic.php?p=39332&sid=f05ee8efa396f3bc4b74f97e8c58a4c5
20141205 00:50:16< iceiceice> thats more recent
20141205 00:52:10< fabi> iceiceice: I think all there problems are related to rendering qt widgets into an opengl canvas. This is not quite our scenario. This posts can be ignored in my opinion.
20141205 00:52:18< fabi> s/there/their
20141205 00:52:31< nurupo> Qt Quick / QML got a big update with Qt5, Qt Qucik 2 / QML2
20141205 00:53:00< fabi> nurupo: Have you worked with Qt before?
20141205 00:53:00< iceiceice> fabi: i'm actually finding quite a few threads about issues with portably using QT and SDL together
20141205 00:53:05< nurupo> and Qt5 released in 2012, i think, so the update happened sometime between 2012 and 2014
20141205 00:53:21< nurupo> fabi: only with Qt Widgets, not QML or Qt Quick
20141205 00:53:56< iceiceice> especially this post "SDL's strength has always been porting, and its weakness is the lack of decent GUI integration so I'm not sure why this topic isn't at least being looked into for future versions now that SDL2 is out. Being able to mix the graphics between the two easily would really be nice. Joystick/Gamepad/Haptic is really the only thing I use SDL for that Qt doesn't reasonably provide. Qt's QGraphicsView is nice, but being able t
20141205 00:53:56< iceiceice> raphics with Qt in a non-hackish way will really eliminate the GUI issue once and for all. "
20141205 00:55:12< nurupo> are there some issues with wesnoth's GUI2 that you are looking into Qt?
20141205 00:57:01< iceiceice> well there's many things it doesn't really support
20141205 00:57:05< iceiceice> like, menus, context menus,
20141205 00:57:08< iceiceice> modal dialogs,
20141205 00:57:14< fabi> tabs
20141205 00:57:30< fabi> sorted lists
20141205 00:57:55< iceiceice> all the scrollable items behave a little bit wonky if there is any "resizing" going on
20141205 00:58:33< fabi> iceiceice: So far every problem reported regarding sdl and qt is a different scenario.
20141205 00:58:48< iceiceice> alot of standard gui stuff like drag-select copy and paste isn't there, so we would have to write it ourselves...
20141205 00:58:55< fabi> We do not have a sdl opengl canvas which qt needs to render into.
20141205 00:59:07< nurupo> iceiceice: you could also try asking on #qt about integrating it with SDL, maybe someone would tell you something
20141205 00:59:29< iceiceice> fabi: yeah i guess you are right about this
20141205 01:00:52< nurupo> the channel is kind of dead right now though
20141205 01:01:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 01:02:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20141205 01:03:47< fabi> nurupo: Yeah, I also do not know enough yet  to ask good questions. 
20141205 01:04:08< iceiceice> bye for now
20141205 01:04:09-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141205 01:05:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 01:06:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20141205 01:11:03-!- travis-ci [~travis-ci@ec2-54-211-211-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20141205 01:11:03< travis-ci> wesnoth/wesnoth#4988 (qt - 9aa75d4 : Chris Beck): The build passed.
20141205 01:11:03< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/43048562
20141205 01:11:03-!- travis-ci [~travis-ci@ec2-54-211-211-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20141205 01:35:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 01:42:15-!- Anakonda [Anakonda@dsl-tkubrasgw1-54f9ba-178.dhcp.inet.fi] has quit [Read error: Connection reset by peer]
20141205 01:52:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 01:54:22-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141205 02:00:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 02:06:30< vultraz> ah, build worked!
20141205 02:06:54< vultraz> tdm gcc 4.5.2 did the trick
20141205 02:07:01< vultraz> (w/ -fopenmp)
20141205 02:07:43< vultraz> I'll see if I can work on compiling some boost libs for 4.8
20141205 02:14:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 02:15:12< vultraz> (interestingly, it takes ~2 minutes longer with 4.8)
20141205 02:20:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 02:21:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20141205 02:34:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141205 02:43:10-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141205 02:46:35-!- irker818 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20141205 02:51:21-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20141205 03:11:23-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20141205 03:15:45-!- iceiceice [~chris@wesnoth/developer/iceiceice] has left #wesnoth-dev ["Leaving"]
20141205 03:16:02-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141205 03:20:45-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has joined #wesnoth-dev
20141205 03:39:01-!- Ivanovic_ [~ivanovic@frnk-5f74e0ac.pool.mediaWays.net] has joined #wesnoth-dev
20141205 03:39:01-!- Ivanovic_ [~ivanovic@frnk-5f74e0ac.pool.mediaWays.net] has quit [Changing host]
20141205 03:39:01-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20141205 03:42:35-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 244 seconds]
20141205 03:43:00-!- Ivanovic_ is now known as Ivanovic
20141205 03:59:36-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20141205 04:11:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 04:32:04-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141205 05:05:50-!- oldlaptop [~quassel@50-108-67-218.adr01.mskg.mi.frontiernet.net] has quit [Ping timeout: 258 seconds]
20141205 05:12:39-!- oldlaptop [~quassel@50-108-67-218.adr01.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20141205 05:55:24-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141205 06:33:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141205 06:55:50-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has joined #wesnoth-dev
20141205 07:22:47-!- Coffee_irc [~david@ppp121-45-26-75.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20141205 07:54:57-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141205 08:49:03-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20141205 08:49:15-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141205 08:49:16< Necrosporus> Is there any khalifate campaigns?
20141205 09:04:17-!- oldlaptop [~quassel@50-108-67-218.adr01.mskg.mi.frontiernet.net] has quit [Ping timeout: 258 seconds]
20141205 09:04:59-!- oldlaptop [~quassel@50-108-67-218.adr01.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20141205 09:28:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 09:40:44-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 265 seconds]
20141205 10:49:17-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20141205 11:09:11-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Ping timeout: 265 seconds]
20141205 11:26:42-!- Anakonda [Anakonda@dsl-tkubrasgw1-54f9ba-178.dhcp.inet.fi] has joined #wesnoth-dev
20141205 11:33:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141205 11:54:28-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20141205 11:55:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20141205 12:03:05-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141205 12:13:10-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20141205 12:22:33-!- Coffee_irc [~david@ppp121-45-26-75.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20141205 12:30:06< AI0867> gfgtdf: I see you're rewriting the network code. Do you have some documentation of how it works? (previously or now)
20141205 12:32:31-!- zookeeper_ is now known as zookeeper
20141205 12:32:33-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20141205 12:32:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141205 12:35:12-!- DCW1 [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20141205 13:14:51-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Ping timeout: 265 seconds]
20141205 13:22:21-!- gfgtdf [~chatzilla@f054051082.adsl.alicedsl.de] has joined #wesnoth-dev
20141205 13:23:03< gfgtdf> AI0867: you talk abut my current pr, or about something i didn previously ?
20141205 13:23:05< gfgtdf> did*
20141205 13:31:36< AI0867> the current one
20141205 13:32:04< AI0867> you seem to understand it more than I do, and I wrote some tiny bots to interface with it about a year ago
20141205 13:35:20-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has joined #wesnoth-dev
20141205 13:36:19-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141205 13:37:16-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 244 seconds]
20141205 13:38:00-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has quit [Client Quit]
20141205 13:45:50< gfgtdf> AI0867: actualy i don't know why we did it the way we previously did it, i made it a pr so that someone how might knew could rewiew it, I tried to reach Soliton but he didn't answer yet. 
20141205 13:46:00< gfgtdf> AI0867: y i can update the wiki if i merge it
20141205 13:46:09-!- Crendgrim_ is now known as Crendgrim
20141205 13:46:32-!- DCW1 [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20141205 13:47:15-!- mjs-de [~mjs-de@f048142005.adsl.alicedsl.de] has joined #wesnoth-dev
20141205 14:37:23-!- Alkenrinnstet [~alkenrinn@bb116-14-123-231.singnet.com.sg] has quit [Ping timeout: 272 seconds]
20141205 15:29:44-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20141205 15:31:35-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Client Quit]
20141205 15:55:17-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 16:00:10-!- _8680__ [~8680@2002:4404:712c:0:5d8d:485f:dcd9:309f] has quit [Ping timeout: 244 seconds]
20141205 16:01:07-!- _8680_ [~8680@2002:4404:712c:0:6479:123a:ae5d:db4d] has joined #wesnoth-dev
20141205 16:01:30-!- _8680_ is now known as Guest56569
20141205 16:13:41-!- Guest56569 [~8680@2002:4404:712c:0:6479:123a:ae5d:db4d] has quit [Ping timeout: 265 seconds]
20141205 16:14:06-!- _8680__ [~8680@2002:4404:712c:0:4c5d:6fc:1135:d98f] has joined #wesnoth-dev
20141205 16:21:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 16:29:52-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20141205 16:33:05-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141205 16:34:16-!- _8680__ [~8680@2002:4404:712c:0:4c5d:6fc:1135:d98f] has quit [Ping timeout: 244 seconds]
20141205 16:34:43-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has joined #wesnoth-dev
20141205 16:34:46-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20141205 16:35:04-!- _8680__ [~8680@2002:4404:712c:0:455d:93c3:aff9:9aa7] has joined #wesnoth-dev
20141205 16:44:50-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141205 16:49:51-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has joined #wesnoth-dev
20141205 16:51:24< gfgtdf> iceiceice: you know of any ther changes in in lua in master besides set_strict that are likeley to break addons ?
20141205 16:51:50< gfgtdf> other*
20141205 16:58:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 17:01:47-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141205 17:22:53-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20141205 17:23:07-!- gfgtdf [~chatzilla@f054051082.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 34.0/20141125180439]]
20141205 17:28:26-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has joined #wesnoth-dev
20141205 17:34:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20141205 17:37:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141205 17:51:56-!- gfgtdf [~chatzilla@f054051082.adsl.alicedsl.de] has joined #wesnoth-dev
20141205 17:54:22-!- ancestral [~ancestral@75-161-233-211.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141205 17:54:48-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20141205 18:13:33-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141205 18:16:02-!- Sulfur [~Miranda@p5B0080AA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141205 18:27:26< gfgtdf> iceiceice i made a bug report
20141205 19:08:36-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141205 19:08:55< iceiceice> gfgtdf: can you give a test case / bisect?
20141205 19:08:59< iceiceice> the code looks correct to me: 
20141205 19:08:59< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/scripting/lua_kernel_base.cpp#L487
20141205 19:09:23< gfgtdf> iceiceice: ut looks different than the 1.12 code
20141205 19:09:27< gfgtdf> it*
20141205 19:09:58< iceiceice> here was the change commit:
20141205 19:09:59< iceiceice> https://github.com/wesnoth/wesnoth/commit/99678ef29ad9765578738242bff2cdb76f05e7cb
20141205 19:10:39< gfgtdf> iceiceice: y thats teh bad commit i think
20141205 19:10:47< iceiceice> what is bad?
20141205 19:11:06< gfgtdf> iceiceice: the lua_settop(L, 0) is removed form dofile
20141205 19:11:52< gfgtdf> iceiceice: i think it's needed for the later return lua_gettop(L).
20141205 19:12:38< iceiceice> i see so lua_loadfile does not consume a stack argument
20141205 19:13:09< iceiceice> i think the simplest fix is to return lua_gettop(L) - 1 instead
20141205 19:16:23< gfgtdf> iceiceice: hm would that maybe not work if someone tries to call dofile with multiple arguments? (not that im doing that)
20141205 19:16:42< iceiceice> no i think it should work in that case also
20141205 19:16:56< gfgtdf> iceiceice: hm ok
20141205 19:17:00< iceiceice> returning an int "n" means the n values on the top of the stack are the return values
20141205 19:17:08< gfgtdf> iceiceice: i dont really know how lua stacks works, was just a guess
20141205 19:17:15< iceiceice> y ok
20141205 19:17:31< iceiceice> i wonder why we were using lua_call instead of lua_pcall
20141205 19:18:25< gfgtdf> iceiceice: i think that also teh behviour of original lua dofile
20141205 19:19:31< iceiceice> y but it doesn't make that much sense to me
20141205 19:20:21< gfgtdf> iceiceice: mybe so teh the caller of dofile can handle teh error
20141205 19:20:53< gfgtdf> iceiceice: the point is that one should treat dofile like a normal function call i think.
20141205 19:21:12< iceiceice> and require is not?
20141205 19:21:43< gfgtdf> iceiceice: no
20141205 19:21:50< iceiceice> ok
20141205 19:22:02< gfgtdf> iceiceice: require is like load library
20141205 19:24:51< iceiceice> did you see this commit?
20141205 19:24:52< iceiceice> https://github.com/wesnoth/wesnoth/commit/675c8a95f76604f6cac6ec77b14f98da046ab3eb
20141205 19:35:53-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer]
20141205 19:36:18-!- fabi [~quassel@p20030051AA4C46573C967161BEBED5E8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141205 19:36:18-!- fabi [~quassel@p20030051AA4C46573C967161BEBED5E8.dip0.t-ipconnect.de] has quit [Changing host]
20141205 19:36:18-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20141205 19:36:38< gfgtdf> iceiceice: y i saw. I dont know what we can do about it. I guess we shoudl move taht code out of teh destructor to a function and than call that function naually
20141205 19:37:08< gfgtdf> iceiceice: i als don't think that this class uses destructors becasue it wasnts those to be called even if aan exception interferes
20141205 19:37:30< gfgtdf> also*
20141205 19:37:56< iceiceice> yeah it seems fine to skip the dialog in that case
20141205 19:38:28< iceiceice> i think maybe playcontroller should just have a function pointer variable, that it checks for null periodically and calls
20141205 19:39:33-!- irker269 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20141205 19:39:33< irker269> wesnoth: gfgtdf wesnoth:master e78fde8137d8 / src/config_assign.hpp: simplfy use of config_of http://git.io/Yuai4A
20141205 19:46:10-!- gfgtdf [~chatzilla@f054051082.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 34.0/20141125180439]]
20141205 19:49:01< AI0867> gfgtdf: please do. My previous work (no docs, just reverse-engineering and seeing what works) is here: https://github.com/AI0867/wesnet-tools
20141205 20:02:17-!- gfgtdf [~chatzilla@f054051082.adsl.alicedsl.de] has joined #wesnoth-dev
20141205 20:04:06< irker269> wesnoth: Chris Beck wesnoth:master e5d85d219269 / src/scripting/lua_fileops.cpp: fix bug #23027 (wesnoth dofile) http://git.io/vlOp3Q
20141205 20:04:13< iceiceice> gfgtdf: ^ can you test this?
20141205 20:04:23< gfgtdf> AI0867: i think i'd be better if we could have teh scenario data inside [create_game] but the simple_wml offers no fast swap operation for child nodes only for documents, so idk whether i'd be ok form teh performance, on the other sides we do exactly that for [store_next_scenario]
20141205 20:05:35-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 20:05:56< gfgtdf> iceiceice: from looking at teh code that looks like it wont work if the files has mutiple return values.
20141205 20:06:05< gfgtdf> (just  a guess though)
20141205 20:06:08< iceiceice> i think it will work fine
20141205 20:06:13< gfgtdf> iceiceice: hm ok
20141205 20:06:35< iceiceice> the return "gettop" is supposed to make that part work
20141205 20:06:45< iceiceice> also call(..., 0, multret)
20141205 20:06:55< iceiceice> the only problem was that the filename was being the first return value
20141205 20:07:20< gfgtdf> iceiceice: ahh yes we do the lua_remove(L, -2) before executign teh function
20141205 20:08:03< gfgtdf> s/on the other sides/on the other hand
20141205 20:09:01< gfgtdf> iceiceice: ok i'll take a shower while it complies.
20141205 20:09:07< iceiceice> ok
20141205 20:15:44< iceiceice> hmm i think its still broken
20141205 20:15:52< iceiceice> i decided to write a unit test for it...
20141205 20:16:11< iceiceice> oh it might be old executable thoguh
20141205 20:18:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 20:18:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141205 20:29:04-!- Sulfur [~Miranda@p5B0080AA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141205 20:30:31< irker269> wesnoth: Chris Beck wesnoth:master bae61e944fa8 / src/scripting/lua_kernel_base.cpp: fixup wesnoth.require after commit HEAD^ http://git.io/btSZeQ
20141205 20:30:33< irker269> wesnoth: Chris Beck wesnoth:master 69d7924df5a2 / data/test/macros/test.lua data/test/scenarios/test_dofile.cfg wml_test_schedule: add a wml unit test for lua dofile http://git.io/jGjo8g
20141205 20:39:22-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141205 20:42:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 20:53:22< gfgtdf> iceiceice: i get PANIC: unprotected error in call to Lua API (bad argument #-1 (string expected, got table)) as soon as i start wewnoth in curent master.
20141205 20:53:29< gfgtdf> iceiceice it diesnt even whow the window
20141205 20:54:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 20:55:08< gfgtdf> show*
20141205 20:57:54-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141205 20:58:07< iceiceice> gfgtdf: i got that once but after i recompiled i didn't get it anymore
20141205 20:58:57< iceiceice> hmm it looks like travis isn't happy though
20141205 21:01:23< iceiceice> well that's only the intermediate commit though
20141205 21:02:47< gfgtdf> iceiceice: ok i pulled again and it doesn't crash now.
20141205 21:02:59< iceiceice> ok
20141205 21:05:04< gfgtdf> iceiceice: and my addon (PYR non prep turn) also works again :)
20141205 21:05:38< iceiceice> ok good
20141205 21:18:22-!- travis-ci [~travis-ci@ec2-23-22-192-57.compute-1.amazonaws.com] has joined #wesnoth-dev
20141205 21:18:22< travis-ci> wesnoth/wesnoth#4991 (master - e5d85d2 : Chris Beck): The build has errored.
20141205 21:18:22< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/43134222
20141205 21:18:22-!- travis-ci [~travis-ci@ec2-23-22-192-57.compute-1.amazonaws.com] has left #wesnoth-dev []
20141205 21:34:23< zookeeper> playing 1.12 isar's, on first turn i got this:
20141205 21:34:24< zookeeper> <23:32 server> Ignoring illegal whiteboard data, sent from user 'Winter_Queen' to team 'south-west'.
20141205 21:39:37< iceiceice> did it persist or was it only first turn?
20141205 21:40:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141205 21:40:01< iceiceice> i think first turn white board errors are a hold over from 1.10 anyways
20141205 21:50:01< zookeeper> only first
20141205 21:52:24< gfgtdf> zookeeper: is the reproducable ?
20141205 21:52:29< gfgtdf> that*
20141205 21:52:33< zookeeper> i wouldn't know
20141205 21:54:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 21:54:17< gfgtdf> zookeeper: we will mpove the 'check which side is in that team' code to the becasue teh serversides code is bugged in multiple ways, i'd be cool to knwo why we get those meessages before we do that.
20141205 21:54:27< gfgtdf> to the cleint*
20141205 21:57:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 22:15:08-!- gfgtdf [~chatzilla@f054051082.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91 [Firefox 34.0/20141125180439]]
20141205 22:21:57-!- oldlaptop [~quassel@50-108-67-218.adr01.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20141205 22:23:32-!- oldlaptop [~quassel@50-108-67-218.adr01.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20141205 22:23:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141205 22:25:53-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20141205 22:43:02-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20141205 22:43:05-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 272 seconds]
20141205 22:49:04-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Leaving]
20141205 23:00:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141205 23:03:59-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141205 23:04:47< zookeeper> also a big pile of errors like this:
20141205 23:04:48< zookeeper> Removing illegal command 'update_shroud' from Winter_Queen
20141205 23:04:57< zookeeper> also for 'auto_shroud' and maybe something else too
20141205 23:25:19-!- Coffee_irc [~david@ppp121-45-26-75.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20141205 23:31:25-!- irker269 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20141205 23:32:36-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20141205 23:56:02-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: ancestral]
20141205 23:58:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
--- Log closed Sat Dec 06 00:00:49 2014